| *** stanzi has quit IRC | 00:02 | |
| *** stanzi has joined #openstack-barbican | 00:03 | |
| *** zz_dimtruck is now known as dimtruck | 00:05 | |
| elmiko | woodster_: ok, for reasons that only the mysql devs know, server_default='0' seems to work | 00:06 |
|---|---|---|
| elmiko | not sure about postgresql, i'll try that next | 00:06 |
| *** stanzi has quit IRC | 00:07 | |
| *** kebray has quit IRC | 00:11 | |
| *** kebray has joined #openstack-barbican | 00:15 | |
| *** kebray has quit IRC | 00:16 | |
| *** stanzi has joined #openstack-barbican | 00:19 | |
| elmiko | woodster_: that does seem to work in postgres | 00:20 |
| *** tkelsey has joined #openstack-barbican | 00:21 | |
| *** SheenaG has quit IRC | 00:25 | |
| *** tkelsey has quit IRC | 00:26 | |
| *** stanzi has quit IRC | 00:26 | |
| *** stanzi has joined #openstack-barbican | 00:26 | |
| *** stanzi has quit IRC | 00:31 | |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add utility functions to convert between and PEM and DER https://review.openstack.org/174178 | 01:17 |
| *** crc32 has joined #openstack-barbican | 01:25 | |
| woodster_ | elmiko: so we'll have quite a list of do's and don'ts before this is done | 01:29 |
| alee | dave-mcc_, redrobot ping | 02:06 |
| dave-mcc_ | alee pong | 02:18 |
| alee | dave-mcc_, so - I just verified that (with a small tweak) the dogtag tests work. | 02:19 |
| dave-mcc_ | alee \o/ | 02:19 |
| alee | dave-mcc_, now how close are we to getting the skipped tests working? | 02:19 |
| dave-mcc_ | alee i've had them working in my local environment for a couple days... we just need to get all the CRs toghether. | 02:20 |
| alee | dave-mcc_, because depending on what you guys end up doing for that -- that may change what happens in the dogtag code | 02:20 |
| dave-mcc_ | alee i just found something fun for gate... rare, but random, failures in unit tests. i'm fixing it now. | 02:20 |
| dave-mcc_ | alee, we want the big CR too land ASAP, and then fix KMIP and dogtag in subsequent CRs. | 02:20 |
| alee | right - but the big cr does not unskip all the tests , right? | 02:21 |
| dave-mcc_ | alee, correct, it still skips a few. | 02:21 |
| alee | dave-mcc_, well +2 from me -- now we just need a workflow | 02:23 |
| alee | hockeynut, jvrbanac ? | 02:24 |
| dave-mcc_ | alee, unfortunately it failed the gate due to random unit test failure. we could recheck, and maybe it will work next time. | 02:25 |
| dave-mcc_ | alee, i just submitted recheck. but i'm working on patch to fix it. there are several unit tests related to containers that assume the order of a list is predictable; it is not. | 02:26 |
| alee | dave-mcc_, yeah - we need to fix those tests | 02:27 |
| dave-mcc_ | alee, it's in validators, orders, containers, and others. | 02:28 |
| alee | dave-mcc_, really? | 02:28 |
| alee | dave-mcc_, from what I see - it failed the gate because of this -- > api.v1.smoke.test_rsa.RSATestCase.test_rsa_create_and_get_container_with_passphrase | 02:29 |
| dave-mcc_ | alee, and models | 02:29 |
| alee | dave-mcc_, ie. functional tests | 02:29 |
| dave-mcc_ | alee yea, that was random... that usually passes because refs[0] and refs[1] are in the same order it was passed in. but sometimes, the values are switched. | 02:30 |
| dave-mcc_ | alee that same assumption is made all over the place. | 02:30 |
| alee | dave-mcc_, are you looking at http://logs.openstack.org/96/173396/12/check/gate-barbican-devstack-dsvm/bd624e6/console.html ? | 02:30 |
| alee | right -- but maybe that assumption is ok in other cases. In these functional tests, though it may be invalid | 02:31 |
| alee | dave-mcc_, where are you seeing unit tests even being invoked in the gate? | 02:32 |
| dave-mcc_ | alee... i assumed they were. they aren't? | 02:33 |
| alee | dave-mcc_, perhaps - but I dont see them in the console | 02:33 |
| alee | dave-mcc_, I think you just need to focus on fixing the offending functional tests | 02:34 |
| *** peter-hamilton has quit IRC | 02:34 | |
| dave-mcc_ | alee i think separate jobs for unit and functional. sounds good. i'll fix those and submit a CR asap. hopefully no one else has hit this yet. | 02:34 |
| alee | dave-mcc_, you can use self.assertIn(...) | 02:42 |
| dave-mcc_ | alee, i was just going to ask you for a suggestion. | 02:42 |
| dave-mcc_ | instead of self.assertEqual(get_resp.model.secret_refs[0].name, 'public_key') | 02:42 |
| *** crc32 has quit IRC | 02:43 | |
| alee | names = ['public_key', 'private_key'] | 02:43 |
| alee | self.assertIn(get_resp.model.secret_refs[0].name, names) | 02:43 |
| alee | dave-mcc_, ^^ | 02:44 |
| alee | soemthing like that | 02:44 |
| alee | dave-mcc_, ping | 02:56 |
| dave-mcc_ | alee pong | 02:56 |
| alee | dave-mcc_, question -- with the big cr in -- if you remove the skips in test_rsa.py, do the tests pass for you? | 02:57 |
| alee | dave-mcc_, I have them passing with a small tweak to one test | 02:57 |
| dave-mcc_ | alee i haven't tried lately. i thought maybe. was the tweak with payload_content_encoding? | 02:58 |
| alee | dave-mcc_, in test_rsa_order_certificate_from_csr() .. | 02:58 |
| alee | test_model = order_models.OrderModel( | 02:58 |
| alee | **get_order_create_certificate_simple_cmc( | 02:58 |
| alee | base64.b64encode(csr))) | 02:58 |
| alee | csr needs to be base64 encoded | 02:59 |
| alee | other than that - they all pass for me (against dogtag) | 02:59 |
| dave-mcc_ | alee, yes. https://review.openstack.org/173452 | 02:59 |
| dave-mcc_ | alee awesome! | 03:00 |
| alee | dave-mcc_, do they pass for you? | 03:00 |
| *** xaeth_afk is now known as xaeth | 03:00 | |
| dave-mcc_ | alee, i haven't tried lately. i had them passing, and then put some fixes in the bug-cr and some in separate ones to keep them small... waiting for them all to merge. | 03:01 |
| dave-mcc_ | alee, the base64(csr) fix is one waiting at the gate. i think it was hit with the out of order list issue. | 03:02 |
| *** xaeth is now known as xaeth_afk | 03:02 | |
| alee | ok - so roll the fix for the order-list issue in with that | 03:03 |
| alee | and that way it will pass the gate | 03:03 |
| dave-mcc_ | alee good idea. will do. | 03:06 |
| *** SheenaG has joined #openstack-barbican | 03:16 | |
| *** rm_you| has joined #openstack-barbican | 03:23 | |
| *** rm_you has quit IRC | 03:27 | |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Fix errors in functional tests https://review.openstack.org/173452 | 03:31 |
| dave-mcc_ | alee, i just fixed test_rsa, since it was the one failing. hopefully it gets us going. | 03:32 |
| dave-mcc_ | alee, if we can get that one workflowed, i can rebase the big one and we can get that one through too. | 03:32 |
| alee | dave-mcc_, looking | 03:33 |
| dave-mcc_ | alee, i've got an extra function i wrote an didn't use. i'll revert that. | 03:36 |
| dave-mcc_ | alee, let me know if there rest is ok, and i'll push up the second patch | 03:36 |
| alee | dave-mcc_, you mean the get_secret_dict() function? | 03:37 |
| alee | dave-mcc_, I'd actually prefer you to encapsulate the test in that function | 03:38 |
| alee | ie. use the funciton instead of repeating yourself in two tests | 03:38 |
| dave-mcc_ | alee, yea, i know that's better. it's on my to-do list to duplicate all the repetitious code in this file. (not for rc1). ok, i'll do it right. | 03:39 |
| dave-mcc_ | alee, done. anything else? | 03:45 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Fix errors in functional tests https://review.openstack.org/173452 | 03:48 |
| *** SheenaG has quit IRC | 04:02 | |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Fix base64 decoding of payloads in one-step POST https://review.openstack.org/173396 | 04:08 |
| alee | dave-mcc_, good for me | 04:09 |
| dave-mcc_ | alee, all passing now. there were a couple bugs in 173452 that i fixed in 173396. they're lined up now. | 04:09 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add utility functions to convert between and PEM and DER https://review.openstack.org/174178 | 04:21 |
| *** tkelsey has joined #openstack-barbican | 04:23 | |
| *** tkelsey has quit IRC | 04:29 | |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Fix handling of payload_content_encoding for orders https://review.openstack.org/172819 | 04:52 |
| *** dimtruck is now known as zz_dimtruck | 05:18 | |
| *** dave-mcc_ has quit IRC | 05:31 | |
| openstackgerrit | Douglas Mendizábal proposed openstack/barbican: Fix KMIP Secret Store input/output https://review.openstack.org/174144 | 06:04 |
| *** jaosorior has joined #openstack-barbican | 07:01 | |
| openstackgerrit | Merged openstack/barbican: Fix errors in functional tests https://review.openstack.org/173452 | 07:11 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Initial setup for command line tests https://review.openstack.org/172604 | 07:12 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Use keystoneclient to get endpoint if it's empty https://review.openstack.org/172958 | 07:12 |
| *** chlong has quit IRC | 07:40 | |
| *** xek has joined #openstack-barbican | 08:00 | |
| *** rm_you| has quit IRC | 08:39 | |
| *** rm_you| has joined #openstack-barbican | 08:40 | |
| *** rm_work is now known as rm_work|away | 09:13 | |
| *** woodster_ has quit IRC | 09:30 | |
| *** gitorres has left #openstack-barbican | 09:36 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Use keystoneclient to get endpoint if it's empty https://review.openstack.org/172958 | 10:31 |
| *** jamielennox is now known as jamielennox|away | 11:47 | |
| *** joesavak has joined #openstack-barbican | 11:56 | |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/barbican-specs: Use oslo.versionedobjects to help with upgrades https://review.openstack.org/174318 | 11:57 |
| *** everjeje has joined #openstack-barbican | 12:27 | |
| *** rellerreller has joined #openstack-barbican | 12:36 | |
| *** jsavak has joined #openstack-barbican | 12:43 | |
| *** joesavak has quit IRC | 12:46 | |
| rellerreller | redrobot I reviewed https://review.openstack.org/#/c/173396/ You want me to workflow or wait for alee? | 12:49 |
| *** woodster_ has joined #openstack-barbican | 13:00 | |
| *** nkinder has quit IRC | 13:09 | |
| *** stanzi has joined #openstack-barbican | 13:14 | |
| *** stanzi has quit IRC | 13:15 | |
| *** stanzi has joined #openstack-barbican | 13:16 | |
| *** stanzi has quit IRC | 13:20 | |
| jaosorior | woodster_: ping | 13:21 |
| woodster_ | jaosorior: morning (or evening rather) | 13:23 |
| jaosorior | woodster_: hey man, I remember there was gonna be some working regarding starting to use the standard output or format for the version output, meaning the output that comes out when we access the / resource in Barbican. What happened to that? | 13:24 |
| woodster_ | jaosorior: the bp was approved but know one freed up to work on it. The quota bp wasn't implemented either...tsv has been pulled to work other things but said he'd come back to it in liberty | 13:26 |
| jaosorior | woodster_: alright, was just wandering about it | 13:27 |
| woodster_ | jaosorior: yeah, we need a few more barbicaneers to get all the stuff done! | 13:27 |
| *** alee_ has joined #openstack-barbican | 13:28 | |
| woodster_ | elmiko: I'm mailing a patch to you to consider...it adds named FKs and reworks that first version file a bit...please let me know what you think | 13:52 |
| elmiko | woodster_: ack, i'll take a look | 13:52 |
| elmiko | woodster_: i got that migration you posted to work for both mysql and postgresql | 13:53 |
| woodster_ | elmiko: and that was just by chaning the boolean default value to 0? | 13:54 |
| elmiko | woodster_: pretty much | 13:54 |
| elmiko | woodster_: oh, and the downgrade mismatch in the comments makes alembic think there are 2 heads, but that's separate | 13:55 |
| *** stanzi has joined #openstack-barbican | 13:57 | |
| *** dave-mccowan has joined #openstack-barbican | 13:58 | |
| *** stanzi has quit IRC | 14:00 | |
| *** stanzi has joined #openstack-barbican | 14:01 | |
| elmiko | woodster_: looking at your patch, i'm not so sure we need to drop the secret_id constraing | 14:05 |
| elmiko | i think only the tenant_id constraint needs to change | 14:05 |
| *** paul_glass has joined #openstack-barbican | 14:05 | |
| *** nkinder has joined #openstack-barbican | 14:06 | |
| elmiko | hmm, or maybe it does... | 14:06 |
| *** igueths has joined #openstack-barbican | 14:06 | |
| woodster_ | elmiko: I think if more than one FK exists in a table we need to name the constraints, but also whenever we touch FKs like in the other tables with just project FKs. We really need to move to naming all constraints to avoid issues | 14:08 |
| elmiko | woodster_: ok, fair | 14:08 |
| elmiko | woodster_: the only other thing jumping out to me, at the moment, is that if we change the fk's to be explicitly named do we also need to change the model to show that name? | 14:10 |
| elmiko | nvm, missed that part | 14:10 |
| elmiko | woodster_: at first pass, this change makes sense | 14:11 |
| woodster_ | elmiko: yep | 14:11 |
| woodster_ | elmiko: yeah I figure when I fix my CR per you default value change, I'll also beef up the doc that a | 14:12 |
| woodster_ | elmiko: that I modified with it | 14:12 |
| elmiko | woodster_: +1 | 14:13 |
| woodster_ | elmiko: would you be up for modifying youR CR along the lines of that patch? | 14:14 |
| elmiko | woodster_: definitely, i just want to test it against my setup here | 14:14 |
| elmiko | woodster_: and thanks for the help =) | 14:15 |
| woodster_ | elmiko: good point, I didn't test on Postgres:\ | 14:15 |
| elmiko | woodster_: gotta say though, this does give me a new perspective on why folks like postgres over mysql | 14:19 |
| alee_ | redrobot, dave-mccowan I see the big cr was workflowed | 14:27 |
| alee_ | redrobot, dave-mccowan - I'm working right now on dogtag changes | 14:27 |
| dave-mccowan | alee_ it failed the final gate, though. no merge. :-( but, it's passing on my bog. | 14:31 |
| *** stanzi has quit IRC | 14:39 | |
| *** stanzi has joined #openstack-barbican | 14:40 | |
| *** zz_dimtruck is now known as dimtruck | 14:44 | |
| *** stanzi has quit IRC | 14:44 | |
| dave-mccowan | alee_, can you check if functional tests run for you on git review -d 173396 ? | 14:50 |
| alee_ | dave-mccowan, sure -- give me a few mins -- almost sorted all the dogtag issues. | 14:51 |
| *** stanzi has joined #openstack-barbican | 14:51 | |
| alee_ | dave-mccowan, once I do, I need to rebase anyways | 14:51 |
| dave-mccowan | alee_ thanks. odd, it worked in jenkins check, but failed in jenkins gate. | 14:53 |
| dave-mccowan | alee_, i see the bug now. | 15:02 |
| igueths | redrobot: So out of the directory tree at http://logs.openstack.org/93/170693/8/check/gate-barbican-devstack-dsvm/e7cd6c0/ , which file (s) should I focus on to attempt to make sense of whatever the failure is? | 15:02 |
| elmiko | woodster_: your patch works well for me, the only issue i have with postgres is that there seems to be a timing issue which causes one migration to fail because a table is not created | 15:02 |
| elmiko | woodster_: i'm not sure what to do about that | 15:02 |
| redrobot | igueths looks like your CR failed for an unrelated change | 15:03 |
| igueths | Hm. | 15:03 |
| alee_ | dave-mccowan, which test is failing? | 15:03 |
| dave-mccowan | redrobot, alee_ three of them. i see the fix now, but i don't know why it's tempermental. | 15:04 |
| dave-mccowan | alee_, oh wait... i don't see the fix. | 15:05 |
| igueths | redrobot: Can you elaborate? | 15:05 |
| dave-mccowan | alee_ one is api.v1.functional.test_certificate_orders.CertificatesTestCase.test_create_stored_key_order | 15:08 |
| *** stanzi has quit IRC | 15:09 | |
| *** stanzi has joined #openstack-barbican | 15:09 | |
| dave-mccowan | alee_, redrobot. in the passing "check", in the barbican screen, i don't see error: "string or callable". in the failing "gate", i do see the error "string or callable". that error was fixed by 173456 which has merged. | 15:09 |
| igueths | Rebased...Here goes take 9. | 15:10 |
| openstackgerrit | Igor Gueths proposed openstack/barbican: Potential resource exhaustion when registering consumers to containers https://review.openstack.org/170693 | 15:11 |
| redrobot | dave-mccowan alee_ strange.... I'll pull down the patch, rebase on master and see if I can get the tests to pass... | 15:11 |
| *** stanzi has quit IRC | 15:14 | |
| *** kebray has joined #openstack-barbican | 15:14 | |
| *** darrenmoffat has quit IRC | 15:14 | |
| *** stanzi has joined #openstack-barbican | 15:14 | |
| *** darrenmoffat has joined #openstack-barbican | 15:15 | |
| *** bbby has joined #openstack-barbican | 15:15 | |
| woodster_ | elmiko: ugh :\ so much for liking postgres more! For grins, maybe try to stick a sleep(10) in there to rule out some other sequencing issue? It bugs me that these migration steps aren't transactional either | 15:17 |
| elmiko | woodster_: i'm talking with folks in #sqlalchemy about this now, maybe it has to do with the get_foreign_keys call | 15:18 |
| *** rm_work|away is now known as rm_work | 15:18 | |
| woodster_ | elmiko: well, if you manually upgrade/downgrade across that change, does that pass? Only when you do it as a batch of version changes, correct? | 15:19 |
| elmiko | woodster_: correct | 15:19 |
| *** xaeth_afk is now known as xaeth | 15:20 | |
| *** SheenaG has joined #openstack-barbican | 15:22 | |
| alee_ | jaosorior, very naughty | 15:23 |
| *** stanzi has quit IRC | 15:23 | |
| jaosorior | alee_: wha? | 15:23 |
| *** stanzi has joined #openstack-barbican | 15:24 | |
| alee_ | jaosorior, you put in a fix to return 409 when a secret is being updated with a PUT with payload already present | 15:24 |
| rm_work | jaosorior: commented on https://review.openstack.org/#/c/172958 | 15:24 |
| alee_ | jaosorior, thats good in itself, but the check you used is this -- | 15:24 |
| alee_ | if self.secret.encrypted_data: | 15:25 |
| alee_ | _secret_already_has_data() | 15:25 |
| rm_work | jaosorior: ah and right as I say that, I found the etc/functional_tests.conf in the barbicanclient stuff | 15:25 |
| alee_ | secret.encrypted_data() is only valid for the crypto_plugin | 15:25 |
| rm_work | jaosorior: so then my only concern is the lack of consistency, which is probably not your problem | 15:26 |
| alee_ | ie. not for dogtag/kmip .... | 15:26 |
| jaosorior | alee_: well, shit | 15:27 |
| jaosorior | rm_work: so... will you revert the -1? | 15:28 |
| rm_work | jaosorior: curious how concerned we are about the consistency issue first | 15:29 |
| rm_work | was hoping someone would comment | 15:29 |
| rm_work | but I would +1 if pressed :P | 15:29 |
| rm_work | consistency is one of the things I get a little OCD about sometimes | 15:29 |
| alee_ | jaosorior, its fixed easily enough --- you just need to throw the exception later in the code. | 15:29 |
| jaosorior | rm_work: that's why it's 'v2' in CONF.identity.auth_version, that covers for the decimals if they would exist... though that was actually mostly meant since there was some part of the keystone version config that would take decimales for the 3.X api | 15:30 |
| rm_work | I guess maybe the client CLI args need to change to use v2 and v3? that matches both the client's functional_test.conf and the barbican server's config? | 15:30 |
| jaosorior | alee_: can you point out to the file? | 15:30 |
| alee_ | jaosorior, plugin/resources.py | 15:31 |
| *** rellerreller has quit IRC | 15:31 | |
| alee_ | jaosorior, line 77 | 15:31 |
| alee_ | instead of throwing a ValueError() , you throw a different exception | 15:32 |
| alee_ | jaosorior, or better yet .. | 15:33 |
| alee_ | change to check to : secret_model.encrypted_data or secret_model.secret_store_metadata | 15:33 |
| jaosorior | alee_: Wasn't that the case for the two step secret creation? | 15:33 |
| alee_ | jaosorior, it all goes through the same -- | 15:33 |
| elmiko | woodster_: so, according to the folks in #sqlalchemy we shouldn't be doing db inspection during the migrations | 15:33 |
| alee_ | jaosorior, the right check is as above .. | 15:34 |
| jaosorior | alee_: Actually a subsequent change would have gotten rid of the weird things of sometimes getting a secret_model and sometimes not | 15:34 |
| elmiko | woodster_: i'm thing about changing those get_foreign_key checks to instead gate on if the dialect is mysql | 15:34 |
| alee_ | I'll change it in my upcoming cr | 15:34 |
| alee_ | jaosorior, yup - that fixes it | 15:36 |
| *** dave-mccowan has quit IRC | 15:37 | |
| jaosorior | alee_: I'm talking about the changes in this CR https://review.openstack.org/#/c/172378/2/barbican/plugin/resources.py | 15:37 |
| jaosorior | alee_: But honeslty, I'm still not quite sure to what change are you referring to that broke things | 15:37 |
| alee_ | jaosorior, no worries -- it was a change in controllers/secrets.py | 15:39 |
| woodster_ | elmiko: that makes sense. Once everything is named though we shouldn't have to worry about this anymore | 15:39 |
| elmiko | woodster_: yeah, exactly =) | 15:40 |
| rm_work | jaosorior: i gave up caring, every single place this is configured is different (and none of it is really due to your patchset) T_T | 15:40 |
| woodster_ | elmiko: did the sqlalchemy folks have thoughts on the Postgres timing issue by chance | 15:40 |
| jaosorior | rm_work: if you want we can sit down, agree on a more consistent way, and I'll work on a patch for that | 15:41 |
| rm_work | it would be good to at least agree on what the correct way is, for a start -- and possibly if they NEED to be different for some reason, at least comment in place "# Your options are "v2" or "v3" | 15:42 |
| rm_work | or whatever they should be -- because i see the example default, but no idea what the other option is in some cases | 15:42 |
| elmiko | woodster_: yes, they thought it had to do with postgres' transaction DDL. so we shouldn't be inspecting the db during a migration | 15:43 |
| jaosorior | alee_: Any updates on the dogtag gate? That would have helped preventing this. I don't have a dogtage instance running myself :/ | 15:43 |
| alee_ | jaosorior, I was thinking exactly the same thing -- redrobot ^^ | 15:43 |
| elmiko | woodster_: i'm going to change the "fk_name_to_try in fkeys" logic to instead just look at the ctx.dialect to see if we're using mysql | 15:44 |
| elmiko | woodster_: if that makes sense to you | 15:44 |
| redrobot | alee_ jaosorior no progress, kinda took a back seat to getting Kilo out the door, and some internal stuff. | 15:44 |
| jaosorior | alee_: Can you push a fix? It would be better since you actually can test with dogtag. Sorry for the regression on your side | 15:45 |
| alee_ | redrobot, ok - we're not leaving Vancouver until we have a running dogtag gate. | 15:45 |
| redrobot | alee deal! | 15:45 |
| woodster_ | elmiko: that makes sense given what the sqlalchemy folks said | 15:45 |
| alee_ | jaosorior, yeah - doing it as part of a larger cr | 15:45 |
| *** kebray has quit IRC | 15:47 | |
| *** kebray has joined #openstack-barbican | 15:52 | |
| *** dave-mccowan has joined #openstack-barbican | 15:55 | |
| redrobot | dave-mccowan alee got one failure when I rebased onto master. | 15:56 |
| dave-mccowan | redrobot, was it the same "ERROR" instead of "PENDING" ? | 15:57 |
| redrobot | dave-mccowan nope, it's one for consumers | 15:57 |
| alee_ | dave-mccowan, redrobot -looks like it passed the gate? | 15:58 |
| openstackgerrit | Michael McCune proposed openstack/barbican: [WIP] Adding MySQL fixes to migrations https://review.openstack.org/173617 | 15:58 |
| dave-mccowan | alee_, redrobot: jaosorior issued reverify and it worked. random failures? :-( | 16:00 |
| elmiko | woodster_: latest patch, works with both but i still have a question about one of the constraints that presumably was an error in the old migrations | 16:00 |
| jaosorior | dave-mccowan: random failures, actually, I'm yet to figure out why though | 16:00 |
| woodster_ | elmiko: would naming it help? | 16:02 |
| elmiko | woodster_: oh yea, i meant to add a name to the constraint that's added. but i was more confused by the preferred_certificate_authorities_project_id_key name because it never appears in the actual db schema | 16:03 |
| dave-mccowan | jaosorior, i fixed some random errors in https://review.openstack.org/#/c/173452/4 (bad assumption of list order) but, the others i've seen have different symptoms. | 16:03 |
| woodster_ | elmiko: maybe too long? | 16:04 |
| elmiko | woodster_: nah, i think it was a misname on the part of the migration. in the db there is a preferred_certificate_authorities_project_id_fkey name | 16:05 |
| redrobot | alee_ dave-mccowan jaosorior gate is still in progress https://jenkins07.openstack.org/job/gate-barbican-devstack-dsvm/450/console | 16:05 |
| elmiko | woodster_: i really need to analyze the db schemas against the sqlalchemy models again | 16:05 |
| openstackgerrit | Merged openstack/barbican: Fix base64 decoding of payloads in one-step POST https://review.openstack.org/173396 | 16:05 |
| woodster_ | elmiko: interesting that it wouldn't show up on db | 16:06 |
| redrobot | alee_ dave-mccowan jaosorior woot! it merged! :D | 16:06 |
| elmiko | woodster_: that's what i though | 16:06 |
| *** gyee_ has joined #openstack-barbican | 16:06 | |
| elmiko | woodster_: i might not get to it for a few hours though, got some meetings coming up | 16:07 |
| jaosorior | redrobot: might have been some connectivity issues in the gate... or something O_O | 16:08 |
| jaosorior | anyway, did reverify on the CRs that depended on that one | 16:11 |
| woodster_ | elmiko: yeah meeting foo for me too | 16:11 |
| elmiko | \o/ yay meetings ;) | 16:12 |
| jaosorior | redrobot: got a couple of minutes for this one? https://review.openstack.org/#/c/172958/ | 16:12 |
| jaosorior | would be nice to get a working barbicanclient :P | 16:13 |
| jaosorior | alee_: by the way, what larger CR were you talking about? is it something that's uploaded yet? or is it to come? | 16:14 |
| alee_ | jaosorior, its coming | 16:16 |
| alee_ | jaosorior, fixes to dogtag plugin to get it to pass functional tests | 16:16 |
| jaosorior | alee_: Awesome, ping me when it's up | 16:17 |
| alee_ | jaosorior, will do :) cause no one will test the changes except me :/ | 16:18 |
| jaosorior | alee_: well, that re-asserts the needfor that gate | 16:20 |
| alee_ | indeed | 16:20 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Refactor dogtag gate scripts https://review.openstack.org/161935 | 16:22 |
| *** gyee_ has quit IRC | 16:43 | |
| *** kebray_ has joined #openstack-barbican | 16:45 | |
| *** kebray has quit IRC | 16:46 | |
| openstackgerrit | Merged openstack/python-barbicanclient: Adding payload flag to get secret https://review.openstack.org/174094 | 16:50 |
| rm_work | ^^ BTW what did that really add? just… now you can use -d OR -p ? | 16:53 |
| rm_work | is there a plan to deprecate -d ? | 16:54 |
| redrobot | rm_work yeah, I was just wondering the same thing | 16:55 |
| rm_work | merged before i managed to review, would have asked that | 16:55 |
| redrobot | rm_work the idea was that --decrypt was going to return the payload without the ascii box, but it appears that you can do that with the existing --decrypt | 16:55 |
| rm_work | yeah | 16:56 |
| rm_work | err | 16:56 |
| redrobot | derp --payload was going to be different | 16:56 |
| rm_work | so one option i mentioned was that you COULD print&bail | 16:56 |
| redrobot | but now they're both the same | 16:56 |
| rm_work | and just dodge cliff | 16:56 |
| rm_work | but that's a bit "dodgy" :P (pun intended) | 16:56 |
| redrobot | turns out cliff had an undocumented feature to allow non-boxy output | 16:56 |
| rm_work | yeah, kinda | 16:56 |
| redrobot | but yeah, no value on that above CR | 16:56 |
| rm_work | but still not what i would expect the output to be | 16:56 |
| rm_work | whelp | 16:57 |
| rm_work | if args.payload: print(entity.payload); sys.exit(0) | 16:57 |
| rm_work | lol | 16:57 |
| *** alee_ is now known as alee_lunch | 16:58 | |
| rm_work | you guys doing loonch today? | 16:58 |
| rm_work | still waiting IPA-AH myself | 16:58 |
| rm_work | *watching | 16:58 |
| redrobot | rm_work -f value doesn't do plain payoload? | 16:58 |
| redrobot | rm_work we're in the all hands still | 16:58 |
| rm_work | according to chellygel it does "value = payload" | 16:58 |
| redrobot | rm_work but yeah, loonch | 16:58 |
| rm_work | still not JUST payload | 16:58 |
| redrobot | yeah.... so why did we merge the change >_< | 16:59 |
| rm_work | redrobot: i am at home right now but I could meet somewhere possibly :P let me know | 16:59 |
| rm_work | redrobot: do not know | 16:59 |
| rm_work | my response when i saw the merge message in channel was "shit" | 16:59 |
| rm_work | "meant to comment on that" | 16:59 |
| redrobot | now it just adds confusion on whether you should use --payload or --decrypt ... | 16:59 |
| rm_work | --payload matches the other operations now at least | 17:02 |
| rm_work | so "secret get -p" and "secret store -p" | 17:02 |
| rm_work | are similar | 17:02 |
| rm_work | I still don't like "store" BTW -- why mess with CR[U]D -- but whatever | 17:02 |
| redrobot | lol, you're beating a dead horse rm_work :-P | 17:03 |
| rm_work | hehe i know | 17:03 |
| rm_work | but i mistype it virtually every time still | 17:03 |
| rm_work | and I've been using the client for quite a while | 17:03 |
| redrobot | rm_work well, good news is we've got a chance to fix it in the unified cli | 17:04 |
| rm_work | woot | 17:04 |
| rm_work | redrobot: IF you were going to grab loonch, where would that be, do you think? | 17:04 |
| redrobot | rm_work hoping this meeting will be over soon | 17:04 |
| rm_work | redrobot: also -- sorry if my constantly ribbing you about Thai Thai is annoying :P | 17:05 |
| rm_work | redrobot: well I still need to DRIVE | 17:05 |
| redrobot | rm_work we thinking Erick's? | 17:05 |
| rm_work | redrobot: so i need heads up | 17:05 |
| rm_work | k | 17:05 |
| rm_work | redrobot: text me please if you leave :P | 17:08 |
| redrobot | rm_work meeting is just about over | 17:08 |
| rm_work | or change destination | 17:09 |
| rm_work | redrobot: yeah but I have to start driving NOW | 17:09 |
| redrobot | rm_work heading out in 5 | 17:09 |
| rm_work | lol | 17:09 |
| rm_work | k | 17:09 |
| *** tkelsey has joined #openstack-barbican | 17:11 | |
| *** stanzi has quit IRC | 17:33 | |
| *** stanzi has joined #openstack-barbican | 17:34 | |
| *** joesavak has joined #openstack-barbican | 17:35 | |
| *** jsavak has quit IRC | 17:38 | |
| *** stanzi has quit IRC | 17:38 | |
| *** rellerreller has joined #openstack-barbican | 17:40 | |
| *** jsavak has joined #openstack-barbican | 17:47 | |
| *** jsavak has quit IRC | 17:47 | |
| *** dave-mccowan has quit IRC | 17:50 | |
| *** joesavak has quit IRC | 17:51 | |
| *** alee_lunch is now known as alee_ | 17:52 | |
| igueths | Can I get some +2's on https://review.openstack.org/170693? Hopefully before the Devstack gate breaks for me again! | 17:55 |
| openstackgerrit | Merged openstack/barbican: Fix handling of payload_content_encoding for orders https://review.openstack.org/172819 | 17:56 |
| openstackgerrit | Merged openstack/barbican: Add utility functions to convert between and PEM and DER https://review.openstack.org/174178 | 17:56 |
| *** joesavak has joined #openstack-barbican | 17:57 | |
| *** stanzi has joined #openstack-barbican | 17:57 | |
| *** rellerreller has quit IRC | 18:01 | |
| *** rellerreller_ has joined #openstack-barbican | 18:01 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Refactor dogtag gate scripts https://review.openstack.org/161935 | 18:09 |
| openstackgerrit | Doug Hellmann proposed openstack/python-barbicanclient: Uncap library requirements for liberty https://review.openstack.org/174527 | 18:12 |
| openstackgerrit | Doug Hellmann proposed openstack/python-kiteclient: Uncap library requirements for liberty https://review.openstack.org/174537 | 18:13 |
| *** stanzi has quit IRC | 18:17 | |
| *** stanzi has joined #openstack-barbican | 18:17 | |
| *** tkelsey has quit IRC | 18:20 | |
| *** stanzi has quit IRC | 18:22 | |
| woodster_ | igueths: workflow +1! | 18:31 |
| *** rellerreller_ has quit IRC | 18:35 | |
| igueths | woodster_: Awesome! | 18:51 |
| openstackgerrit | Merged openstack/barbican: Potential resource exhaustion when registering consumers to containers https://review.openstack.org/170693 | 18:54 |
| *** stanzi has joined #openstack-barbican | 19:27 | |
| *** nkinder has quit IRC | 19:32 | |
| -openstackstatus- NOTICE: gerrit has been restarted to clear a problem with its event stream. any gerrit changes updated or approved between 19:14 and 19:46 utc will need to be rechecked or have their approval reapplied for zuul to pick them up | 19:46 | |
| redrobot | thanks for the heads up openstackgerrit | 19:47 |
| redrobot | or openstackstatus | 19:47 |
| openstackgerrit | Ade Lee proposed openstack/barbican: Fix Dogtag plugin to make latest functional tests pass https://review.openstack.org/174577 | 19:48 |
| openstackgerrit | Douglas Mendizábal proposed openstack/barbican: Fix KMIP Secret Store input/output https://review.openstack.org/174144 | 19:48 |
| alee_ | woodster_, redrobot jaosorior -- changes to get dogtag plugin working | 19:49 |
| redrobot | alee_ nice! | 19:50 |
| alee_ | redrobot, woodster_ jaosorior - with this , dogtag ca and kra pass all functional tests | 19:50 |
| *** stanzi has quit IRC | 19:50 | |
| alee_ | so lets crank out those +2's :) | 19:50 |
| *** stanzi has joined #openstack-barbican | 19:51 | |
| alee_ | jvrbanac, hockeynut ^^ | 19:51 |
| *** stanzi has quit IRC | 19:55 | |
| *** kebray_ has quit IRC | 20:01 | |
| *** stanzi has joined #openstack-barbican | 20:02 | |
| jaosorior | alee_: just a very minor comment. Other than that a +2 from my side | 20:05 |
| alee_ | jaosorior, looking | 20:06 |
| alee_ | jaosorior, I guess there is no way for me to change the commit message without resubmitting, is there? | 20:09 |
| redrobot | alee_ you can edit it on gerrit | 20:10 |
| jaosorior | Uhm... I think you can edit it straight from gerrit | 20:10 |
| alee_ | jaosorior, redrobot - cool - doing so right now | 20:10 |
| woodster_ | so....close...to...release! | 20:11 |
| woodster_ | elmiko, does you CR support mysql migrations then, or were there still some issues? | 20:12 |
| redrobot | alee_ jaosorior woodster_ the KMIP patch is up for review as well https://review.openstack.org/#/c/174144/3 | 20:12 |
| woodster_ | ...looking now.... | 20:12 |
| *** stanzi has quit IRC | 20:13 | |
| elmiko | woodster_: it supports both | 20:13 |
| *** stanzi has joined #openstack-barbican | 20:13 | |
| elmiko | woodster_: the only outstanding question is the constraint issue | 20:13 |
| elmiko | (i have comments in the review) | 20:14 |
| openstackgerrit | Ade Lee proposed openstack/barbican: Fix Dogtag plugin to make latest functional tests pass https://review.openstack.org/174577 | 20:14 |
| alee_ | jaosorior, redrobot -- modified | 20:15 |
| woodster_ | elmiko: I had added comments since then...I'm thinking those constraints were just postgres ones that didn't really need to be there. As for adding named constraints to the models, we could take that on first thing in Liberty, no need to have in this CR | 20:15 |
| alee_ | redrobot, guess the mod makes you add your +2 again .. | 20:15 |
| elmiko | woodster_: makes sense, should i remove the extraneous constraint stuff then? | 20:16 |
| alee_ | redrobot, jaosorior thanks | 20:16 |
| jaosorior | alee_: +2 delivered | 20:16 |
| alee_ | woodster_, need a whoop whoop please ! :) | 20:16 |
| woodster_ | alee, there are lot out there, is their a preferred review order? :) | 20:17 |
| *** stanzi has quit IRC | 20:17 | |
| elmiko | woodster_: the name on those postgres constraints is incorrect anyways, not sure where alembic got those from | 20:17 |
| woodster_ | elmiko: oh got it. Well, it is possible these were hand generated? | 20:19 |
| elmiko | woodster_: possible, but the comments seem to suggest otherwise. maybe best to just remove them? | 20:19 |
| *** igueths has quit IRC | 20:20 | |
| elmiko | either that or fix the name | 20:21 |
| elmiko | but i'm unclear if that constraint even exists | 20:21 |
| woodster_ | elmiko just for postgres though right? | 20:22 |
| woodster_ | elmiko, it is a uniqueness constraint that wasn't needed...it is possible postgres optimizes that with no need for a constraint | 20:23 |
| woodster_ | elmiko: my guess is that wasn't entirely auto generated | 20:23 |
| *** major3rd has joined #openstack-barbican | 20:23 | |
| elmiko | woodster_: ok, that would make more sense | 20:24 |
| elmiko | woodster_: on your comment in the review about adding named fk constraints, should i do that now or wait? | 20:25 |
| alee_ | woodster_, whoop whoop? | 20:25 |
| alee_ | woodster_, yes please | 20:25 |
| *** igueths has joined #openstack-barbican | 20:26 | |
| alee_ | woodster_, awesome - thanks! | 20:26 |
| *** major3rd has quit IRC | 20:28 | |
| *** joesavak has quit IRC | 20:30 | |
| openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Fix the clientrc file to match defaults and add docs https://review.openstack.org/174076 | 20:32 |
| *** joesavak has joined #openstack-barbican | 20:32 | |
| *** kebray has joined #openstack-barbican | 20:33 | |
| *** jsavak has joined #openstack-barbican | 20:34 | |
| *** stanzi has joined #openstack-barbican | 20:35 | |
| woodster_ | elmiko: we can wait to do that...clean house first thing in Liberty then | 20:35 |
| elmiko | woodster_: ack | 20:36 |
| elmiko | woodster_: i'm gonna remove the extraneous postgres constraint stuff then | 20:36 |
| woodster_ | elmiko, so I'd say once your patch is ready we can +2 it. I added a patch to my alembic change too, including adding more guidance for column migrations | 20:36 |
| woodster_ | elmiko: sounds good | 20:37 |
| woodster_ | alee, all those +2s should be good for my stackalytics! | 20:37 |
| *** joesavak has quit IRC | 20:37 | |
| *** major3rd has joined #openstack-barbican | 20:41 | |
| major3rd | Hey guys. This is my first time in the IRC and I have some questions about barbican. Is there where I can ask for help? | 20:43 |
| *** nkinder has joined #openstack-barbican | 20:45 | |
| redrobot | major3rd ask away | 20:45 |
| major3rd | redrobot: Thanks. So I set up barbican in a development environment running Rhel 6.5 and I'm trying to utilize the kmip_plugin feature in barbican. However, I'm getting an SSL error. In the kmip_plugin section in barbican-api.conf file it requests a keyfile, certfile, and ca_certs. What exactly are those values suppose to be? I think that's why barbican is not working. | 20:48 |
| redrobot | major3rd hmm... I'm not so familiar with the KMIP plugin. rellerreller or kfarr would know for sure, but unfortunately they're not on right now. | 20:49 |
| *** kebray has quit IRC | 20:49 | |
| redrobot | major3rd I want to say that they are required to establish a connection to your KMIP device? ... but I may totally be making that up on the spot ;) | 20:49 |
| openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Porting over more documentation to RST from cli wiki https://review.openstack.org/174598 | 20:49 |
| major3rd | hah thanks. I figured that's what they're for and I put what it sounds like should be there but it's still not working. Do you happen to know when they will be online? | 20:50 |
| woodster_ | M | 20:51 |
| chellygel | woodster_, theres another set of docs to end your wiki :( | 20:51 |
| redrobot | major3rd rellerreller is usually around in the AM (PDT). You can also shoot a question to the openstack mailing list. kfarr is pretty good about answering emails about KMIP questions. | 20:52 |
| *** kebray has joined #openstack-barbican | 20:52 | |
| major3rd | redrobot thanks I'll do that. Thanks for your help! | 20:52 |
| woodster_ | major3rd: also I was seeing an issue with kmip plugin __init__ exceptions not showing up in logs due to config issues. If you suspect that you could either debug through the setup, or try this CR out locally: https://review.openstack.org/#/c/171868/ | 20:53 |
| major3rd | woodster_: thanks! I'll look into it. Hopefully that should help. | 20:54 |
| woodster_ | chellygel: wiki docs don't go down easy! Thanks for working to bury those though | 20:54 |
| redrobot | jaosorior alee_ oh wow, seems like the dogtag gate is working now! It used to fail on DogTag installation, but it seems this last run failed because of actual failed tests! :-O | 20:54 |
| redrobot | jaosorior alee_ I'm going to rebase on top of your changes and see if it'll pass. | 20:55 |
| chellygel | woodster_, i think that CR is the last of the CLI docs that existed in the wiki -- so thos ecan get blown away once published ! but the barbican proper docs... those will definitely take some time | 20:55 |
| alee_ | cool beans! | 20:55 |
| elmiko | woodster_: checking out the downgrade on that project migration, it's a total mess because of all the indexes created | 20:56 |
| elmiko | woodster_: basically mysql wants all those constraints cleaned before dropping the index | 20:56 |
| openstackgerrit | Douglas Mendizábal proposed openstack/barbican: Refactor dogtag gate scripts https://review.openstack.org/161935 | 20:58 |
| woodster_ | elmiko: yeah, so we might have to do the approach similar to 795737bb3c3: auto-named to hard-named on upgrade, hard-named to auto-named on downgrade? | 21:05 |
| elmiko | woodster_: yea, could be. there is some extraneous stuff going on here. i'll post the review and maybe you can give some advice on which to name? | 21:06 |
| openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Fix the clientrc file to match defaults and add docs https://review.openstack.org/174076 | 21:11 |
| chellygel | woodster_, ^ fixed | 21:11 |
| openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Porting over more documentation to RST from cli wiki https://review.openstack.org/174598 | 21:13 |
| chellygel | and woodster_ in regards to ^ -- i can't change that, that is how it is listed in the client itself -- I can fix it, but i think it would need to be a separate CR | 21:14 |
| *** xaeth is now known as xaeth_afk | 21:17 | |
| openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Updating client and client docs for accuracy https://review.openstack.org/174613 | 21:23 |
| chellygel | woodster_, ^ separate CR for URI/HREF issue | 21:23 |
| *** xaeth_afk is now known as xaeth | 21:29 | |
| *** alee_ has quit IRC | 21:30 | |
| *** stanzi has quit IRC | 21:38 | |
| *** jamielennox|away is now known as jamielennox | 21:39 | |
| *** stanzi has joined #openstack-barbican | 21:39 | |
| *** kebray_ has joined #openstack-barbican | 21:39 | |
| *** kebray has quit IRC | 21:40 | |
| *** xaeth is now known as xaeth_afk | 21:41 | |
| *** SheenaG has quit IRC | 21:42 | |
| *** stanzi has quit IRC | 21:43 | |
| elmiko | woodster_: i forget, are you one of the TX crew? | 21:47 |
| *** major3rd has quit IRC | 21:48 | |
| *** paul_glass has quit IRC | 21:51 | |
| rm_work | chellygel: an secret :P | 21:59 |
| redrobot | elmiko he is. he's also distracted right now. (I can see him from my desk) | 21:59 |
| elmiko | redrobot: hehe, ok. didn't mean to bug ;) | 22:00 |
| elmiko | mysql may or may not be driving me slightly crazy | 22:01 |
| redrobot | elmiko lol | 22:01 |
| elmiko | would it be too much to ask for a drop_index call to also remove the associated foreignkey.... ffffffffuuuuuuuuuuuuuu | 22:02 |
| openstackgerrit | Charles Neill proposed openstack/barbican: Security tests for Secret resources https://review.openstack.org/164882 | 22:02 |
| *** SheenaG has joined #openstack-barbican | 22:03 | |
| openstackgerrit | Merged openstack/barbican: Fix KMIP Secret Store input/output https://review.openstack.org/174144 | 22:04 |
| openstackgerrit | Merged openstack/barbican: Fix Dogtag plugin to make latest functional tests pass https://review.openstack.org/174577 | 22:13 |
| *** tkelsey has joined #openstack-barbican | 22:17 | |
| *** tkelsey has quit IRC | 22:22 | |
| elmiko | woodster_: ok, i've got this working. big question, should i name all these foreignkeys in the troublesome migration? | 22:28 |
| elmiko | my worry is that it will make the review way more complicated | 22:28 |
| *** jsavak has quit IRC | 22:31 | |
| *** dimtruck is now known as zz_dimtruck | 22:34 | |
| woodster_ | elmiko: you could make a dependent CR to fix that one migration script | 22:34 |
| woodster_ | elmiko: so maybe put up what you have now to cap that CR off (so the upgrades work, not all the downgrades)? | 22:35 |
| woodster_ | elmiko: is it mainly the FK constraints that are the issue? | 22:35 |
| elmiko | woodster_: actually, i've got the downgrades working as well, it's just very verbose as we need to drop the fk constraints for each index | 22:37 |
| *** igueths has quit IRC | 22:39 | |
| openstackgerrit | Michael McCune proposed openstack/barbican: [WIP] Adding MySQL fixes to migrations https://review.openstack.org/173617 | 22:39 |
| woodster_ | elmiko: well, I think that is a necessary beast unfortunately. Would you be able to add a function to do the heavy lifting to reduce lines of code? | 22:39 |
| openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Updating client and client docs for accuracy https://review.openstack.org/174613 | 22:39 |
| elmiko | woodster_: yea, i did, similar to what you had before | 22:39 |
| elmiko | woodster_: that review i just posted works for up/down on both mysql and postgres | 22:40 |
| elmiko | i *think* we're good on mysql migrations /me fingers-crossed | 22:40 |
| woodster_ | elmiko: that looks good to me! There are a lot of constraints in that module anyway. | 22:41 |
| elmiko | woodster_: yea | 22:41 |
| elmiko | and with luck it won't blow up redrobot's migration ;) | 22:41 |
| woodster_ | elmiko: nice! | 22:42 |
| woodster_ | elmiko: +2 | 22:42 |
| elmiko | \o/ | 22:42 |
| redrobot | woot! you're the man elmiko ! | 22:42 |
| elmiko | ha, just glad i could help =) | 22:43 |
| redrobot | elmiko wanna remove [WIP] from the title? | 22:43 |
| woodster_ | alee, redrobot can you guys review these CRs?: https://review.openstack.org/#/c/173617 and https://review.openstack.org/#/c/169946/ | 22:43 |
| elmiko | oh yea, sorry | 22:43 |
| openstackgerrit | Michael McCune proposed openstack/barbican: Adding MySQL fixes to migrations https://review.openstack.org/173617 | 22:43 |
| elmiko | sorry woodster_ you gotta review again now, on the upside it will help the stackalytics scores ;) | 22:44 |
| elmiko | ok, i'm gonna go not think about db migrations. have a good one all! | 22:45 |
| *** alee_ has joined #openstack-barbican | 22:45 | |
| redrobot | elmiko haha, well deserved. thanks again! | 22:46 |
| openstackgerrit | Chelsea Winfree proposed openstack/python-barbicanclient: Fix the clientrc file to match defaults and add docs https://review.openstack.org/174076 | 22:47 |
| woodster_ | elmiko: awesome work, thanks again! | 22:51 |
| *** chadlung has joined #openstack-barbican | 22:52 | |
| *** nkinder has quit IRC | 22:59 | |
| *** chlong has joined #openstack-barbican | 23:02 | |
| woodster_ | arunkant, were you up for updating your CADF blueprint per comments?: https://review.openstack.org/#/c/159938 It probably needs to be moved to a new 'liberty' folder now too | 23:10 |
| *** jaosorior has quit IRC | 23:12 | |
| *** bbby has left #openstack-barbican | 23:29 | |
| *** chadlung has quit IRC | 23:45 | |
| *** chadlung has joined #openstack-barbican | 23:46 | |
| openstackgerrit | Merged openstack/barbican: Security tests for Consumer resources https://review.openstack.org/167018 | 23:48 |
| *** SheenaG has quit IRC | 23:49 | |
| *** chadlung has quit IRC | 23:53 | |
| *** SheenaG has joined #openstack-barbican | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!