| *** insequent has quit IRC | 00:00 | |
| *** SheenaG has joined #openstack-barbican | 00:00 | |
| dave-mccowan | pksingh an admin can assign a different preferred CA for each project | 00:01 |
|---|---|---|
| pksingh | dave-mccowan: OK thanks, sorry if my queries are too silly, who creates sub CAs in dogtag currently, admin? | 00:04 |
| dave-mccowan | pksingh i'm not sure about subCAs. but an admin can issue commands add-CA-to-project and remove-CA-from-project. | 00:07 |
| pksingh | dave-mccowan: i referred link https://github.com/openstack/barbican-specs/blob/master/specs/liberty/add-cas.rst, | 00:14 |
| pksingh | dave-mccowan: It is now time to take the next step. Dogtag has implemented the ability to create back-end subordinate CA's on the fly. We need to expose this functionality to project admins, so that they will be able to create project specific CAs. This would allow all certificates issued to clients in the project to be scoped to the project only. | 00:14 |
| pksingh | dave-mccowan: any idea about ^^, actually in magnum we need different CAs for different project | 00:15 |
| dave-mccowan | pksingh you'll need this new feature for magnum to create CAs on the fly. ade wants to this to go into Liberty and is planning on submitting the patches this week. | 00:17 |
| pksingh | dave-mccowan: OK thanks a lot, i will come to you if have some other queries | 00:18 |
| *** gyee has quit IRC | 00:23 | |
| *** vivek-ebay has joined #openstack-barbican | 00:25 | |
| *** rellerreller has joined #openstack-barbican | 00:45 | |
| *** chlong has joined #openstack-barbican | 01:02 | |
| *** rellerreller has quit IRC | 01:04 | |
| *** dave-mccowan has quit IRC | 01:04 | |
| *** rm_you has quit IRC | 01:22 | |
| *** rm_you has joined #openstack-barbican | 01:23 | |
| *** SheenaG has quit IRC | 01:28 | |
| *** edtubill has joined #openstack-barbican | 01:36 | |
| alee | pksingh, pong | 01:58 |
| *** zz_dimtruck is now known as dimtruck | 02:08 | |
| pksingh | alee: I had few questions related to dogtag sub CAs functionality in barbican | 02:09 |
| pksingh | alee: which dave-mccowan answered, that you are planning to do them in this week | 02:10 |
| alee | pksingh, so yeah -- there are lots of patches coming in | 02:11 |
| alee | pksingh, on the barbican side, I will be submiitting patches to allow barbican to expose subca creation funcitonality | 02:12 |
| pksingh | alee: so after that a tenant would be able to create its own CA in dogtag on the fly right? | 02:12 |
| alee | ideally too - I will submit some functional tests that use the snakeoil plugin in a very basic way | 02:12 |
| alee | yes - thats the idea | 02:13 |
| alee | pksingh, on the dogtag side, there are bunches of patches being reviewed/submitted by me and others to get all that seamless in dogtag | 02:13 |
| pksingh | alee: so only admin can do that or every tenant can create sub CAs? | 02:13 |
| pksingh | ok | 02:13 |
| alee | well that will depend on policy | 02:14 |
| alee | my initial thought was project admin | 02:14 |
| alee | tenant admin | 02:14 |
| alee | but we'll see how that plays out in the reviews. | 02:14 |
| alee | either way, it will be changeable if you change policy | 02:15 |
| pksingh | in magnum our team requires different CA for different tenant , so that one tenant cant access the certificate of others | 02:15 |
| pksingh | so i think once this is implemented the life would be easy at our side :) | 02:16 |
| alee | pksingh, yup - I'm familiar with your use case | 02:18 |
| pksingh | alee: :) | 02:18 |
| *** woodster_ has quit IRC | 02:19 | |
| alee | pksingh, I'm hoping to get it all working within the next two weeks. certainly, there will be code you can integrate and test against with the snake oil plugin | 02:19 |
| alee | and then once the dogtag plugin is updated, you can use it for your prod systems instead | 02:19 |
| pksingh | alee: OK thanks a lot | 02:20 |
| alee | once I get a basic snake oil implmentation in, you guys may want to improve it for those who dont want to use dogtag | 02:20 |
| alee | I'm not goign to have time to focus on that initially | 02:20 |
| pksingh | ok | 02:20 |
| pksingh | Hi, could anyone please review https://review.openstack.org/#/c/206770/, it is necessary for py34 support, so that "tox -epy34 " can be executed successfully, currently its failing | 02:42 |
| pksingh | https://review.openstack.org/#/c/206770/ has one +2 and two +1s ^^ | 02:43 |
| *** edtubill has quit IRC | 03:11 | |
| *** diazjf has joined #openstack-barbican | 03:12 | |
| *** chlong has quit IRC | 03:12 | |
| *** Nirupama has joined #openstack-barbican | 03:14 | |
| *** vivek-ebay has quit IRC | 03:34 | |
| *** chlong has joined #openstack-barbican | 03:38 | |
| *** insequent has joined #openstack-barbican | 03:44 | |
| *** chlong_ has joined #openstack-barbican | 04:04 | |
| *** chlong has quit IRC | 04:04 | |
| openstackgerrit | Fernando Diaz proposed openstack/barbican: Use testr for running functional tests and documentation https://review.openstack.org/218117 | 04:39 |
| *** ccneill has joined #openstack-barbican | 04:41 | |
| *** ccneill has quit IRC | 04:50 | |
| *** jhfeng has joined #openstack-barbican | 05:01 | |
| openstackgerrit | Pradeep Kumar Singh proposed openstack/barbican: Replace dict.iteritems() with six.iteritems(dict) https://review.openstack.org/219123 | 05:03 |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Change tox to use testr for functional tests https://review.openstack.org/219124 | 05:08 |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Change tox to use testr for functional tests https://review.openstack.org/219124 | 05:14 |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: WIP: Make Client test documentation similar to Barbican https://review.openstack.org/219135 | 05:28 |
| openstackgerrit | Fernando Diaz proposed openstack/barbican: Use testr for running functional tests and documentation https://review.openstack.org/218117 | 05:36 |
| *** dimtruck is now known as zz_dimtruck | 05:46 | |
| *** shohel has joined #openstack-barbican | 06:25 | |
| *** diazjf has quit IRC | 07:11 | |
| *** chlong_ has quit IRC | 07:24 | |
| *** shohel has quit IRC | 08:18 | |
| *** shohel has joined #openstack-barbican | 08:24 | |
| *** jaosorior has joined #openstack-barbican | 09:00 | |
| *** shohel has quit IRC | 09:00 | |
| *** dave-mccowan has joined #openstack-barbican | 10:06 | |
| *** mmdurrant has quit IRC | 10:09 | |
| *** shohel has joined #openstack-barbican | 10:42 | |
| *** h00327910__ has quit IRC | 10:43 | |
| dave-mccowan | pksingh ping | 10:44 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 10:54 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 10:55 |
| *** DTadrzak has quit IRC | 11:02 | |
| *** shohel has quit IRC | 11:05 | |
| *** peter-hamilton has joined #openstack-barbican | 11:06 | |
| *** peter-hamilton has quit IRC | 11:23 | |
| *** peter-hamilton has joined #openstack-barbican | 11:24 | |
| *** peter-hamilton has left #openstack-barbican | 11:28 | |
| dave-mccowan | jaosorior ping | 11:33 |
| jaosorior | dave-mccowan: pong | 11:33 |
| dave-mccowan | can you give https://review.openstack.org/#/c/216253/ another look? it's the first in the chain for the quotas blueprint and needs another +2. | 11:34 |
| *** Kevin_Zheng has joined #openstack-barbican | 11:37 | |
| *** mmdurrant has joined #openstack-barbican | 11:58 | |
| *** Nirupama has quit IRC | 11:59 | |
| *** chlong_ has joined #openstack-barbican | 12:09 | |
| *** alee has quit IRC | 12:15 | |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 12:25 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 12:32 |
| dave-mccowan | jaosorior thanks for the review. have you seen my replies yet? | 12:32 |
| *** woodster_ has joined #openstack-barbican | 12:36 | |
| jaosorior | dave-mccowan: Not yet | 12:39 |
| jaosorior | dave-mccowan: You're right. I changed my score for a +1 | 12:58 |
| jaosorior | I mean +2 | 12:58 |
| dave-mccowan | jaosorior i had it wrong in an earlier patch set. rellerreller straightened me out last week. :-) thanks! | 12:59 |
| dave-mccowan | jaosorior there's 3 more patches in the chain, while you're thinking about quotas. then we'll be feature complete for liberty-3 milestone this week. | 13:00 |
| jaosorior | dave-mccowan: Send the links | 13:01 |
| dave-mccowan | #2 https://review.openstack.org/#/c/218064/ | 13:01 |
| dave-mccowan | #3 https://review.openstack.org/#/c/218064/ | 13:02 |
| dave-mccowan | #4 https://review.openstack.org/#/c/218717/ | 13:02 |
| dave-mccowan | jaosorior ^^^ | 13:02 |
| jaosorior | dave-mccowan: I'll check em out, thanks | 13:04 |
| dave-mccowan | hockeynut can you take a look at #1 https://review.openstack.org/#/c/216253/4 for a +W. it's the first in the chain for the rest of the quotas blueprint. you might also like #4 above (functional tests for quotas). | 13:08 |
| jaosorior | dave-mccowan: It will take me some time, as I have to give them a good read. But hopefully I can review them properly between today and tomorrow | 13:13 |
| dave-mccowan | jaosorior awesome. thanks. your reviews are great, by the way. i always appreciate the feedback! | 13:15 |
| *** rellerreller has joined #openstack-barbican | 13:24 | |
| *** alee has joined #openstack-barbican | 13:26 | |
| *** darrenmoffat has quit IRC | 13:30 | |
| *** jhfeng has quit IRC | 13:31 | |
| *** darrenmoffat has joined #openstack-barbican | 13:31 | |
| openstackgerrit | Merged openstack/barbican: Allow debug flag in Barbican tox and debugging documentation https://review.openstack.org/208623 | 13:50 |
| *** lisaclark1 has joined #openstack-barbican | 13:56 | |
| *** shohel has joined #openstack-barbican | 13:59 | |
| *** kfarr has joined #openstack-barbican | 14:05 | |
| rellerreller | Feel like getting the day started with a good +2 and a workflow :) Checkout my CR, https://review.openstack.org/#/c/212579/ ! | 14:06 |
| *** spotz_zzz is now known as spotz | 14:06 | |
| *** pglass has joined #openstack-barbican | 14:06 | |
| lisaclark1 | morning rellerreller! | 14:09 |
| rellerreller | Good morning lisaclark1 :) | 14:11 |
| *** jhfeng has joined #openstack-barbican | 14:11 | |
| *** shohel has quit IRC | 14:13 | |
| *** dave-mccowan has quit IRC | 14:13 | |
| kfarr | Is redrobot still out? Does anyone else have permissions to create releases? | 14:13 |
| *** lisaclark1 has quit IRC | 14:14 | |
| *** xaeth_afk is now known as xaeth | 14:18 | |
| *** jaosorior_ has joined #openstack-barbican | 14:18 | |
| *** shohel has joined #openstack-barbican | 14:19 | |
| *** lisaclark1 has joined #openstack-barbican | 14:20 | |
| *** jaosorior_ has quit IRC | 14:22 | |
| *** edtubill has joined #openstack-barbican | 14:24 | |
| *** dave-mccowan has joined #openstack-barbican | 14:28 | |
| *** diazjf has joined #openstack-barbican | 14:35 | |
| *** Kevin_Zheng has quit IRC | 14:35 | |
| *** zz_dimtruck is now known as dimtruck | 14:37 | |
| *** kebray has joined #openstack-barbican | 14:48 | |
| *** shohel has quit IRC | 14:51 | |
| *** dave-mccowan has quit IRC | 14:51 | |
| *** diazjf has quit IRC | 14:57 | |
| rellerreller | kfarr did you find anyone? | 14:57 |
| *** kfarr has quit IRC | 14:58 | |
| *** dave-mccowan has joined #openstack-barbican | 14:58 | |
| rellerreller | We need to cut a release because our Glance image signing feature requires it. | 14:58 |
| rellerreller | Code freeze is today or tomorrow, so we need a release soon. | 14:58 |
| dave-mccowan | woodster_ can you take another look at https://review.openstack.org/#/c/216253/ ? you reviewed it on 8/28 and it now needs a +W. | 14:59 |
| *** kebray has quit IRC | 15:04 | |
| *** ccneill has joined #openstack-barbican | 15:11 | |
| *** kebray has joined #openstack-barbican | 15:11 | |
| *** diazjf has joined #openstack-barbican | 15:12 | |
| *** yuanying has quit IRC | 15:13 | |
| *** pksingh has quit IRC | 15:14 | |
| *** kebray has quit IRC | 15:17 | |
| *** jaosorior_ has joined #openstack-barbican | 15:18 | |
| *** pksingh has joined #openstack-barbican | 15:24 | |
| *** jaosorior_ has quit IRC | 15:27 | |
| *** yuanying has joined #openstack-barbican | 15:30 | |
| *** SheenaG has joined #openstack-barbican | 15:30 | |
| *** diazjf has quit IRC | 15:31 | |
| *** diazjf has joined #openstack-barbican | 15:33 | |
| *** silos has joined #openstack-barbican | 15:35 | |
| *** arunkant_ has joined #openstack-barbican | 15:40 | |
| *** diazjf has quit IRC | 15:46 | |
| *** diazjf has joined #openstack-barbican | 15:49 | |
| *** insequent has quit IRC | 15:54 | |
| openstackgerrit | Fernando Diaz proposed openstack/barbican: Use testr for running functional tests and documentation https://review.openstack.org/218117 | 15:56 |
| *** kfarr has joined #openstack-barbican | 15:57 | |
| *** lisaclark1 has quit IRC | 15:57 | |
| silos | redrobot: ping | 15:57 |
| *** silos has quit IRC | 16:02 | |
| *** silos has joined #openstack-barbican | 16:02 | |
| *** silos has left #openstack-barbican | 16:02 | |
| *** silos has joined #openstack-barbican | 16:02 | |
| *** lisaclark1 has joined #openstack-barbican | 16:04 | |
| hockeynut | redrobot et al - for the new review process, it is a +2 and a workflow (implying a 2nd +2)? Or should the second +2 also do the workflow? Or doesn't it matter? | 16:05 |
| *** tkelsey has joined #openstack-barbican | 16:06 | |
| *** lisaclark2 has joined #openstack-barbican | 16:07 | |
| *** lisaclark2 has quit IRC | 16:07 | |
| *** lisaclark2 has joined #openstack-barbican | 16:07 | |
| *** lisaclark1 has quit IRC | 16:08 | |
| *** jenkins-keep has quit IRC | 16:11 | |
| *** vivek-ebay has joined #openstack-barbican | 16:18 | |
| redrobot | hockeynut should be two core reviewers total. First one gives a +2, second one gives +2 and +Worflow. | 16:18 |
| redrobot | good UGT mornin' everyone! | 16:19 |
| redrobot | I'm back! | 16:19 |
| dave-mccowan | redrobot \o/ | 16:19 |
| hockeynut | redrobot thx for the clarification! | 16:20 |
| *** peter-hamilton has joined #openstack-barbican | 16:20 | |
| redrobot | silos pong | 16:21 |
| redrobot | kfarr I'm back! What needs to be released? | 16:21 |
| kfarr | Castellan please! | 16:21 |
| kfarr | I tried to start it, so there's a release on github | 16:21 |
| kfarr | I didn't have permissions for getting it on pypi though | 16:22 |
| dave-mccowan | speaking of workflows, https://review.openstack.org/#/c/216253/ needs one. :-) | 16:22 |
| redrobot | kfarr 8F95 5A5C 2C29 123A 5024 965A A1A9 C4BA 01F6 A559 is your GPG key signature? | 16:25 |
| kfarr | redrobot, yes! | 16:25 |
| redrobot | kfarr hmm... looks like you pushed the tag to Gerrit... not sure why it didn't end up in pypi automagically. | 16:26 |
| redrobot | kfarr I'll do a manual upload for now | 16:26 |
| kfarr | redrobot, ok, thank you! I was not sure if it was supposed to be automagic, or if there was another button that needed to be pushed | 16:27 |
| silos | silos: I updated the Federated Barbican wiki for the meeting tomorrow. | 16:27 |
| silos | *redrobot: ^^ | 16:27 |
| *** lisaclark2 has quit IRC | 16:30 | |
| redrobot | kfarr https://pypi.python.org/pypi/castellan/0.2.0 | 16:32 |
| redrobot | silos awesome, I'll take a look | 16:32 |
| kfarr | redrobot, that's awesome! Thank you! | 16:32 |
| silos | redrobot: thankx! :) | 16:32 |
| redrobot | kfarr do you want to send a message to the Dev ML ? | 16:32 |
| kfarr | redrobot, yes please! | 16:33 |
| redrobot | kfarr k, I'll send something after lunch... the rest of the team is already ordering food... brb | 16:34 |
| *** kebray has joined #openstack-barbican | 16:42 | |
| *** lisaclark1 has joined #openstack-barbican | 16:43 | |
| *** alee is now known as alee_lunch | 16:43 | |
| openstackgerrit | Fernando Diaz proposed openstack/barbican: Use testr for running functional tests and documentation https://review.openstack.org/218117 | 16:47 |
| *** vivek-ebay has quit IRC | 16:48 | |
| *** david-ly_ has joined #openstack-barbican | 16:49 | |
| *** david-lyle has quit IRC | 16:49 | |
| *** kfarr has quit IRC | 16:59 | |
| *** kebray has quit IRC | 17:01 | |
| *** rellerreller has quit IRC | 17:02 | |
| *** david-ly_ has quit IRC | 17:07 | |
| *** vivek-ebay has joined #openstack-barbican | 17:09 | |
| *** jaosorior_ has joined #openstack-barbican | 17:11 | |
| *** lisaclark1 has quit IRC | 17:13 | |
| dave-mccowan | redrobot do you have a date/time in mind to tag liberty-3? | 17:21 |
| arunkant_ | dave-mccowan: ping | 17:22 |
| dave-mccowan | arunkant_ pong' | 17:22 |
| arunkant_ | In this review..why you are checking for table exists..https://review.openstack.org/#/c/216253/4/barbican/model/migration/alembic_migrations/versions/46b98cde536_add_project_quotas_table.py,cm | 17:23 |
| *** jaosorior_ has quit IRC | 17:23 | |
| *** jaosorior_ has joined #openstack-barbican | 17:23 | |
| dave-mccowan | arunkant_ i cut and pasted from the other migration scripts that add a table. | 17:24 |
| arunkant_ | dave-mccowan: I have not seen any checks in any previous migrations..that's why curious | 17:24 |
| dave-mccowan | arunkant_ it's in all of the ones that add a table, not just a column to an existing table | 17:25 |
| arunkant_ | dave-mccowan: They generally check for same table..to see if its already created (exists) or not? In your commit, its different table. | 17:27 |
| *** jaosorior_ has quit IRC | 17:27 | |
| *** jaosorior_ has joined #openstack-barbican | 17:28 | |
| dave-mccowan | arunkant_ which line are you looking at? | 17:28 |
| *** SheenaG has left #openstack-barbican | 17:28 | |
| arunkant_ | dave-mccowan : Line 20 | 17:29 |
| dave-mccowan | arunkant_ whoa. that is weird. maybe i got one line too many with my cut-and-paste. checking... thanks! | 17:30 |
| arunkant_ | dave-mccowan: Looks like that change needs to check for 'project_quotas' instead of 'order_barbican_metadata'. | 17:30 |
| *** jaosorior_ has quit IRC | 17:31 | |
| dave-mccowan | arunkant_ yep. i grabbed one line too many with the my cut. nice catch. | 17:31 |
| *** jaosorior_ has joined #openstack-barbican | 17:32 | |
| redrobot | dave-mccowan I was thinking maybe Thursday if we can get away with it. | 17:33 |
| *** kebray has joined #openstack-barbican | 17:49 | |
| *** david-lyle has joined #openstack-barbican | 17:54 | |
| *** peter-hamilton has quit IRC | 17:57 | |
| *** gyee has joined #openstack-barbican | 17:59 | |
| *** david-lyle has quit IRC | 18:01 | |
| *** alee_lunch is now known as alee | 18:05 | |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Ensure Project and ProjectQuotas Tables are in sync https://review.openstack.org/216253 | 18:08 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add get_count() method to project resource repositories https://review.openstack.org/212876 | 18:09 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 18:09 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 18:09 |
| *** rellerreller has joined #openstack-barbican | 18:09 | |
| openstackgerrit | Elvin Tubillara proposed openstack/barbican: Add Request ID to worker-side logs in barbican. https://review.openstack.org/217775 | 18:10 |
| *** kfarr has joined #openstack-barbican | 18:10 | |
| rellerreller | Feeling sluggish this afternoon? | 18:10 |
| rellerreller | Perhaps a nice code review of KMIP secret store will give you the pep in your step to get you through the afternoon https://review.openstack.org/#/c/212579/ | 18:10 |
| rellerreller | alee jvrbanac redrobot woodster_ ^^^ | 18:11 |
| dave-mccowan | rellerreller does that come with a piece of Pie? | 18:11 |
| rellerreller | No, but it does show that PyKMIP is now as easy as Pie to use. | 18:12 |
| *** silos has left #openstack-barbican | 18:17 | |
| *** david-lyle has joined #openstack-barbican | 18:19 | |
| arunkant_ | rellerreller .. for https://review.openstack.org/#/c/212579/. Does global requirements needs to be updated for pykmip version change | 18:25 |
| rellerreller | arunkant_ https://review.openstack.org/#/c/215755/ | 18:30 |
| rellerreller | arunkant_ we pushed an update to global requirements. Hopefully that will go through soon. | 18:31 |
| *** lisaclark1 has joined #openstack-barbican | 18:32 | |
| arunkant_ | relllerreller . Okay. So you are keeping the barbican requirements change? https://review.openstack.org/#/c/214894/ | 18:33 |
| rellerreller | woodster_ thank you! | 18:33 |
| rellerreller | arunkant_ I am keeping it for now. I'm not sure if proposal bot will make that one obsolete, but until then I plan to keep it. | 18:34 |
| arunkant_ | rellerreller, barbican will fail till the barbican requirement change is not merged | 18:34 |
| arunkant_ | rellerreller , I meant kmip interactions only. | 18:35 |
| woodster_ | rellerreller: just testing the new process out :) | 18:35 |
| *** lisaclark1 has quit IRC | 18:35 | |
| *** lisaclark1 has joined #openstack-barbican | 18:35 | |
| rellerreller | arunkant_ the requirements libraries are a little frustrating for us. We push out changes quite frequently and need constant updates. It would be nice if we did not have to go through global requirements. | 18:36 |
| diazjf | Can any core do a quick review on https://review.openstack.org/#/c/196876/ https://review.openstack.org/#/c/212130/ thanks :-D | 18:37 |
| *** kebray has quit IRC | 18:45 | |
| diazjf | thanks rellerreller, kfarr, you're the best! | 18:47 |
| kfarr | diazjf sure thing! | 18:48 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/barbican: Updated from global requirements https://review.openstack.org/218901 | 18:49 |
| *** jaosorior_ has quit IRC | 18:51 | |
| *** jaosorior_ has joined #openstack-barbican | 18:51 | |
| *** peter-hamilton has joined #openstack-barbican | 18:53 | |
| dave-mccowan | rellerreller can you take another look at this: https://review.openstack.org/#/c/216253/ ? there's a new patch set from your last review, and an open question on a possible performance improvement. | 18:54 |
| rellerreller | dave-mccowan is the open question whether or not to use the project id or external project id? | 18:58 |
| dave-mccowan | rellerreller for most of the APIs, using external_project_id is a must. for one API call (GET /v1/quotas), it is possible to use project_id. For the sake of code reuse, I chose to use external_project_id anyways. However, I could create two paths, so we could either use project_id or external_project_id. Then, for GET /v1/quotas, we could avoid a query().join(). | 19:01 |
| jaosorior_ | dave-mccowan: The query join could be avoided if we use the value returned by get_or_create_project | 19:02 |
| openstackgerrit | Fernando Diaz proposed openstack/barbican: Use testr for running functional tests and documentation https://review.openstack.org/218117 | 19:03 |
| rellerreller | dave-mccowan I was thinking the same thing as os. | 19:03 |
| rellerreller | I think internal project ID makes the most sense to me because you get it in controller and then use it. | 19:03 |
| *** kebray has joined #openstack-barbican | 19:04 | |
| dave-mccowan | jaosorior_, right, but only GET /v1/quotas calls get_or_create_project(). GET /v1/project-quotas, PUT /v1/project-quotas, DELETE /v1/proejct-quotas will all still use external ID. | 19:04 |
| *** vivek-ebay has quit IRC | 19:04 | |
| rellerreller | But I am not as familiar with all the different controllers | 19:04 |
| *** vivek-ebay has joined #openstack-barbican | 19:04 | |
| rellerreller | dave-mccowan how can others operate only with external ID? | 19:05 |
| rellerreller | dave-mccowan it seems that the first step must be to retrieve or create project. | 19:05 |
| rellerreller | dave-mccowan otherwise you will have a FK constraint violation. | 19:05 |
| dave-mccowan | jaosorior, rellerreller i'm happy to make this change... it's a trade off for extra code vs. faster code. it's twice as much code to make it work both ways. (i already have it written both ways... it's just a matter of do we want to support it going forward). | 19:05 |
| dave-mccowan | rellerreller it's all done with the SELECT/JOIN we were talking about on Friday | 19:06 |
| rellerreller | dave-mccowan why is it twice as much code? | 19:06 |
| rellerreller | I honestly do not care much either way as long as it is consistent. | 19:07 |
| openstackgerrit | Ade Lee proposed openstack/barbican: Support for creation of subordinate CAs https://review.openstack.org/219411 | 19:07 |
| openstackgerrit | Ade Lee proposed openstack/barbican: API documentation for CAs interface https://review.openstack.org/219412 | 19:07 |
| alee | woodster_, chellygel , jaosorior ^^ | 19:08 |
| alee | initial code for subcas | 19:08 |
| dave-mccowan | for now, i have multiple requests all using get_by_external_project_id() to make this performance enhancement, i'll have some using that and some using a new get_by_internal_project_id() | 19:08 |
| rellerreller | dave-mccowan that is why I did not workflow the change earlier. I think jaosorior_ has some thoughts. | 19:08 |
| dave-mccowan | rellerreller that's the trade off: performance or consistent | 19:09 |
| jaosorior_ | dave-mccowan: But is i really that much of a performance inpact? | 19:09 |
| jaosorior_ | *impact | 19:10 |
| dave-mccowan | jaosorior_, rellerreller i don't think it matters. it's a convenience command (give me my quotas), not really in a mainline path. | 19:10 |
| rellerreller | dave-mccowan can you remind me again of the difference between GET /v1/quotas and GET /v1/project-quotas ? | 19:11 |
| jaosorior_ | dave-mccowan: Then I think I rather have consistency, if it's not that performance critical | 19:11 |
| rellerreller | I want to make sure I have it clear because I keep mixing them up because they sound similar. | 19:11 |
| *** vivek-ebay has quit IRC | 19:12 | |
| dave-mccowan | GET /v1/qutoas is a project admin with an authorized product ID asking for his own project whose existence has been confirmed by Keystone. GET /v1/project-quotas/{external_id} is a service admin asking for the configured quota information of a project with {external_id}. if nothing has been configured for that project, he'll get a 404. we do not want barbican to create a project based on this command. | 19:13 |
| *** vivek-ebay has joined #openstack-barbican | 19:14 | |
| dave-mccowan | rellerreller, jaosorior_ so in the first case, we happen to have the internal project id, so we can performance optimize by adding more code. but, i'd rather just reuse the code from the second case. less code == better. | 19:15 |
| *** jaosorior has quit IRC | 19:15 | |
| rellerreller | dave-mccowan thank you. I remember this conversation again. | 19:15 |
| rellerreller | dave-mccowan I remember you convinced me that external ID was good because of this. | 19:16 |
| dave-mccowan | rellerreller and you convinced me to use join() instead of putting internal and external ids in the quota table. | 19:16 |
| rellerreller | dave-mccowan I'm good with what is there. I think consistency is better because otherwise someone will call with wrong id. | 19:16 |
| rellerreller | dave-mccowan so I vote as is. | 19:17 |
| dave-mccowan | arunkant, arunkant_ do you agree too? | 19:17 |
| rellerreller | Is jaosorior_ on board as well? | 19:17 |
| *** kebray has quit IRC | 19:26 | |
| *** vivek-ebay has quit IRC | 19:34 | |
| *** ccneill has quit IRC | 19:34 | |
| *** whydidyoustealmy has quit IRC | 19:34 | |
| *** vivek-ebay has joined #openstack-barbican | 19:35 | |
| *** ccneill has joined #openstack-barbican | 19:35 | |
| *** whydidyoustealmy has joined #openstack-barbican | 19:35 | |
| *** whydidyoustealmy has quit IRC | 19:35 | |
| *** whydidyoustealmy has joined #openstack-barbican | 19:36 | |
| *** rellerreller has quit IRC | 19:41 | |
| *** kebray has joined #openstack-barbican | 19:47 | |
| *** vivek-ebay has quit IRC | 19:47 | |
| *** ccneill has quit IRC | 19:47 | |
| *** vivek-ebay has joined #openstack-barbican | 19:52 | |
| *** ccneill has joined #openstack-barbican | 19:52 | |
| *** lisaclark1 has quit IRC | 20:00 | |
| *** kebray has quit IRC | 20:03 | |
| *** lisaclark1 has joined #openstack-barbican | 20:03 | |
| *** SheenaG has joined #openstack-barbican | 20:03 | |
| *** kebray has joined #openstack-barbican | 20:05 | |
| openstackgerrit | Merged openstack/python-barbicanclient: Allow Barbican Client Secret Update Functionality https://review.openstack.org/196876 | 20:05 |
| *** peter-hamilton has quit IRC | 20:05 | |
| openstackgerrit | Merged openstack/python-barbicanclient: Add Unit Tests for Store and Update Payload when Payload is zero https://review.openstack.org/212130 | 20:05 |
| *** lisaclark1 has quit IRC | 20:09 | |
| jaosorior_ | rellerreller: +1 | 20:09 |
| dave-mccowan | jaosorior_ thanks! kfarr can you proxy ozz's +W. I'm guessing he's in a better place than instead of in front of gerrit. :-) | 20:11 |
| kfarr | dave-mccown, this one, yeah? https://review.openstack.org/#/c/216253/ | 20:12 |
| dave-mccowan | kfarr yep | 20:13 |
| dave-mccowan | kfarr hopefully this one will go automatically next, but it might need to be kicked. https://review.openstack.org/#/c/212876/ | 20:14 |
| *** everjeje has joined #openstack-barbican | 20:20 | |
| *** kfarr has quit IRC | 20:22 | |
| *** dave-mccowan has quit IRC | 20:25 | |
| *** lisaclark1 has joined #openstack-barbican | 20:29 | |
| *** SheenaG has quit IRC | 20:29 | |
| *** lisaclark1 has quit IRC | 20:30 | |
| *** pglass has quit IRC | 20:31 | |
| *** dave-mccowan has joined #openstack-barbican | 20:38 | |
| openstackgerrit | Adam Harwell proposed openstack/barbican: Use the new Devstack external plugin method https://review.openstack.org/167885 | 20:43 |
| *** hyakuhei has joined #openstack-barbican | 20:43 | |
| hyakuhei | sup :) | 20:44 |
| openstackgerrit | Adam Harwell proposed openstack/barbican: Use the new Devstack external plugin method https://review.openstack.org/167885 | 20:44 |
| openstackgerrit | Adam Harwell proposed openstack/barbican: Remove old gate code https://review.openstack.org/219451 | 20:49 |
| openstackgerrit | Adam Harwell proposed openstack/barbican: Remove old gate code https://review.openstack.org/219451 | 20:50 |
| *** SheenaG has joined #openstack-barbican | 20:54 | |
| openstackgerrit | Merged openstack/barbican: Ensure Project and ProjectQuotas Tables are in sync https://review.openstack.org/216253 | 20:56 |
| openstackgerrit | Merged openstack/barbican: Add get_count() method to project resource repositories https://review.openstack.org/212876 | 20:57 |
| *** jaosorior_ has quit IRC | 21:05 | |
| *** lisaclark1 has joined #openstack-barbican | 21:11 | |
| *** lisaclark1 has quit IRC | 21:12 | |
| *** kebray has quit IRC | 21:17 | |
| *** kebray has joined #openstack-barbican | 21:21 | |
| *** vivek-ebay has quit IRC | 21:30 | |
| *** vivek-ebay has joined #openstack-barbican | 21:31 | |
| *** kebray has quit IRC | 21:35 | |
| *** kebray has joined #openstack-barbican | 21:36 | |
| openstackgerrit | Elvin Tubillara proposed openstack/barbican: Add Request ID to worker-side logs in barbican. https://review.openstack.org/217775 | 21:53 |
| *** diazjf has quit IRC | 21:55 | |
| rm_work | woodster_ / jvrbanac / hockeynut / chellygel / redrobot: Hey guys, we should be able to merge https://review.openstack.org/#/c/167885/ any time now, made it backwards compatible (duh, no idea why i didn't to begin with) | 21:58 |
| rm_work | sooner is better, then I can work on getting the infra side merged, then we can remove the old cruft on this side, and sneak in just before L freeze | 21:58 |
| rm_work | jenkins tests should finish soonish | 21:59 |
| *** vivek-ebay has quit IRC | 21:59 | |
| rm_work | but already seeing passes on the dsvm jobs | 21:59 |
| *** vivek-ebay has joined #openstack-barbican | 22:02 | |
| *** vivek-ebay has quit IRC | 22:03 | |
| *** alee has quit IRC | 22:03 | |
| *** vivek-ebay has joined #openstack-barbican | 22:06 | |
| *** xaeth is now known as xaeth_afk | 22:07 | |
| *** vivek-ebay has quit IRC | 22:10 | |
| *** vivek-ebay has joined #openstack-barbican | 22:17 | |
| *** vivek-ebay has quit IRC | 22:18 | |
| *** vivek-eb_ has joined #openstack-barbican | 22:18 | |
| rm_work | redrobot / woodster_ / jvrbanac / hockeynut / chellygel / who else is +2? https://review.openstack.org/#/c/167885/ this is now *good to merge* and backwards compatible | 22:27 |
| rm_work | as soon as this goes in we can start using it elsewhere | 22:28 |
| rm_work | so it'd be nice to merge ASAP to give people time to convert | 22:28 |
| rm_work | gate change will go next and will also be non-breaking | 22:28 |
| *** ccneill_ has joined #openstack-barbican | 22:32 | |
| *** ccneill has quit IRC | 22:34 | |
| rm_work | you know you want to +2 it... you KNOW you want to... | 22:40 |
| *** kebray has quit IRC | 22:42 | |
| *** spotz is now known as spotz_zzz | 22:49 | |
| *** alee has joined #openstack-barbican | 22:57 | |
| *** edtubill has quit IRC | 22:57 | |
| *** chlong_ is now known as chlong | 23:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/barbican: Updated from global requirements https://review.openstack.org/218901 | 23:19 |
| *** SheenaG has quit IRC | 23:24 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-barbicanclient: Updated from global requirements https://review.openstack.org/217193 | 23:25 |
| *** SheenaG has joined #openstack-barbican | 23:25 | |
| *** SheenaG has quit IRC | 23:35 | |
| *** diazjf has joined #openstack-barbican | 23:35 | |
| *** kebray has joined #openstack-barbican | 23:51 | |
| *** arunkant_ has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!