| *** dimtruck is now known as zz_dimtruck | 00:01 | |
| *** everjeje has quit IRC | 00:02 | |
| *** jhfeng has quit IRC | 00:09 | |
| *** insequent has joined #openstack-barbican | 00:30 | |
| pksingh | dave-mccowan: pong | 00:41 |
|---|---|---|
| dave-mccowan | pksingh hi | 00:42 |
| pksingh | dave-mccowan: hi, good morning | 00:42 |
| dave-mccowan | pksingh good morning. i was wondering how the python3 work was going, how much you think is left, and if there is a way to split up the remaining work so other's can help to make it go faster. | 00:49 |
| pksingh | dave-mccowan: almost 90% tests are working, | 00:51 |
| pksingh | dave-mccowan: only few test files are failing | 00:51 |
| pksingh | i tried to resolve them but could not do so | 00:52 |
| pksingh | one problem is https://bugs.launchpad.net/barbican/+bug/1485452 | 00:53 |
| openstack | Launchpad bug 1485452 in Barbican "test case "test_should_raise_container_no_content_type_header" is failing with py34 due to content-type header" [Undecided,New] | 00:53 |
| dave-mccowan | pksingh great! that's good news (the 90% part). if i want to recreate to help debug, what code do i need? | 00:53 |
| rm_work | dave-mccowan: commented, the "-new" will be there for max a couple of days | 00:56 |
| rm_work | it's a little shuffle-dance of merging things right after each other to get it to switch to the new gates safely with no breakage | 00:56 |
| dave-mccowan | rm_work cool. i like the dual-running approach. the -V makes people nervous. :-) | 00:57 |
| pksingh | dave-mccowan: and barbican.tests.plugin.util.test_translations is also not working currently | 00:58 |
| pksingh | dave-mccowan: ahh, recreation is i think little bit difficult, because i created small patches, and they are dependent one ,if they get merged then life would be very easy | 00:59 |
| pksingh | dave-mccowan: for recreation you have to apply all dependent patches first | 01:00 |
| pksingh | dave-mccowan: and i am sorry, i missed to make them dependent earlier during commit | 01:01 |
| dave-mccowan | pksingh can you add the dependencies now? | 01:02 |
| *** insequent has quit IRC | 01:04 | |
| dave-mccowan | pksingh it's easy to do. if you don't already know how, i can tell you. | 01:04 |
| pksingh | dave-mccowan: let me see, i will come to you soon | 01:07 |
| *** tkelsey has quit IRC | 01:21 | |
| *** hyakuhei has quit IRC | 01:23 | |
| pksingh | dave-mccowan: some patches are merged and some are not some are not merged, so i think changing few lines manually on master should work | 01:23 |
| pksingh | dave-mccowan: https://github.com/openstack/barbican/blob/master/barbican/model/repositories.py#L264 , s/func_name/__name__/ | 01:25 |
| pksingh | dave-mccowan: apply changes in change https://review.openstack.org/#/c/213574/3/barbican/api/controllers/__init__.py and https://review.openstack.org/#/c/213574/3/barbican/api/hooks.py | 01:28 |
| *** kebray has quit IRC | 01:30 | |
| pksingh | dave-mccowan: after above two changes you will be able to test the tests failing with py34, i.e. barbican/tests/api/controllers/test_containers.py and barbican/tests/plugin/util/test_translations.py | 01:30 |
| *** diazjf has quit IRC | 01:35 | |
| openstackgerrit | Pradeep Kumar Singh proposed openstack/barbican: Replace dict.iteritems() with dict.items() https://review.openstack.org/219123 | 01:38 |
| dave-mccowan | pksingh i think it would be a good idea to link the patches together. it would be really cool to show all the unit tests running in the final patch patch of the chain. | 01:40 |
| rm_work | yeah we discussed that earlier, but... | 01:42 |
| rm_work | erg. | 01:42 |
| rm_work | you can test it locally by just cherry-picking them all in a row | 01:42 |
| rm_work | but doing it in a chain during development is really limiting / a PITA | 01:42 |
| rm_work | we just really need to start *merging some* | 01:43 |
| pksingh | rm_work: if two or three patches get merged then there would be no problems, and on some of then there are two +2s and on some of them one +2s | 01:44 |
| pksingh | so if these are reviewed early then that would be good | 01:45 |
| rm_work | yeah just need to get people actually *online* | 01:46 |
| rm_work | i haven't seen many core reviewers (especially redrobot or other rackers) responding in IRC for at least a week <_< not sure what is up | 01:47 |
| *** Kevin_Zheng has joined #openstack-barbican | 01:47 | |
| rm_work | been pinging people all of this week and last week and only ever really saw jaosorior and hockeynut around I think | 01:48 |
| pksingh | ohh | 01:49 |
| rm_work | really need reviewers to start moving stuff since we're so close to the freeze | 01:51 |
| pksingh | yes | 01:53 |
| rm_work | CORES: https://review.openstack.org/#/c/167885/ | 01:53 |
| *** vivek-eb_ has quit IRC | 01:57 | |
| *** jhfeng has joined #openstack-barbican | 02:07 | |
| dave-mccowan | pksingh have you committed a patch with base64 changes? | 02:10 |
| pksingh | dave-mccowan: yes, but all base-64 changes are not in the same patch | 02:17 |
| pksingh | dave-mccowan: i have followed the approach of fixing test module wise | 02:17 |
| *** kebray has joined #openstack-barbican | 02:20 | |
| pksingh | dave-mccowan: this patch has some changes related to base64 https://review.openstack.org/#/c/216093/1 | 02:20 |
| *** jhfeng has quit IRC | 02:25 | |
| *** gyee has quit IRC | 02:47 | |
| *** dave-mccowan has quit IRC | 03:08 | |
| *** vivek-ebay has joined #openstack-barbican | 03:20 | |
| *** woodster_ has quit IRC | 03:39 | |
| *** mmdurrant has quit IRC | 03:39 | |
| *** diazjf has joined #openstack-barbican | 03:53 | |
| *** edtubill has joined #openstack-barbican | 03:58 | |
| *** insequent has joined #openstack-barbican | 04:10 | |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Create Common functions used for cleaning up items used for testing https://review.openstack.org/218396 | 04:35 |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for secrets https://review.openstack.org/213414 | 04:35 |
| *** hyakuhei has joined #openstack-barbican | 04:43 | |
| *** Nirupama has joined #openstack-barbican | 04:44 | |
| *** insequent has quit IRC | 04:52 | |
| *** hyakuhei has quit IRC | 04:56 | |
| openstackgerrit | Elvin Tubillara proposed openstack/barbican: Add Request ID to worker-side logs in barbican. https://review.openstack.org/217775 | 05:02 |
| *** vivek-ebay has quit IRC | 05:02 | |
| openstackgerrit | Merged openstack/barbican: Updated from global requirements https://review.openstack.org/218901 | 05:04 |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for secrets https://review.openstack.org/213414 | 05:11 |
| *** kebray has quit IRC | 05:13 | |
| *** diazjf has left #openstack-barbican | 05:21 | |
| *** insequent has joined #openstack-barbican | 05:41 | |
| openstackgerrit | Merged openstack/barbican: Replace itertools.ifilter with six.moves.filter for py3 compatibility https://review.openstack.org/214447 | 05:42 |
| *** edtubill has quit IRC | 05:46 | |
| openstackgerrit | Merged openstack/barbican: Replace urllib with six.moves.urllib for py3 support https://review.openstack.org/206770 | 06:02 |
| openstackgerrit | Merged openstack/barbican: Make tests in barbican.tests.api.middleware py3 compatible https://review.openstack.org/213594 | 06:02 |
| pksingh | redrobot: thanks for the reviews of py3 patches, could you please review https://review.openstack.org/#/c/219123/ | 06:07 |
| openstackgerrit | Pradeep Kumar Singh proposed openstack/barbican: Make files in barbican.tests.api py3 compatible https://review.openstack.org/213574 | 06:29 |
| *** jaosorior has joined #openstack-barbican | 06:43 | |
| *** jaosorior has quit IRC | 06:45 | |
| *** jaosorior has joined #openstack-barbican | 06:50 | |
| *** shohel has joined #openstack-barbican | 07:26 | |
| *** insequent has quit IRC | 07:35 | |
| *** jaosorior has quit IRC | 07:38 | |
| *** insequent has joined #openstack-barbican | 07:48 | |
| *** shohel has quit IRC | 09:11 | |
| *** shohel has joined #openstack-barbican | 09:17 | |
| *** jaosorior has joined #openstack-barbican | 10:29 | |
| *** jaosorior has quit IRC | 10:29 | |
| *** jaosorior has joined #openstack-barbican | 10:30 | |
| *** insequent has quit IRC | 10:43 | |
| *** everjeje has joined #openstack-barbican | 10:51 | |
| *** dave-mccowan has joined #openstack-barbican | 10:51 | |
| *** insequent has joined #openstack-barbican | 10:58 | |
| *** shohel has quit IRC | 11:00 | |
| *** dtadrzak_ has quit IRC | 11:06 | |
| rm_work | jaosorior: https://review.openstack.org/#/c/167885/ | 11:23 |
| rm_work | jaosorior: you're the only core i've seen responding recently, would love a +2 for that :P | 11:24 |
| rm_work | bbl | 11:24 |
| jaosorior | rm_work: Alright, let me take a look | 11:34 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 11:42 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 11:42 |
| dave-mccowan | jaosorior ^^ last 2 commits for quotas blueprint. (not counting docs) | 11:43 |
| jaosorior | dave-mccowan: Those are gonna take me more time to review, give me some hours haha. Doing some stuff regarding my new job. | 11:44 |
| *** DTadrzak has joined #openstack-barbican | 11:52 | |
| *** peter-hamilton has joined #openstack-barbican | 12:19 | |
| *** david-lyle has quit IRC | 12:27 | |
| *** david-lyle has joined #openstack-barbican | 12:28 | |
| *** shohel has joined #openstack-barbican | 12:33 | |
| *** Nirupama has quit IRC | 12:38 | |
| *** lisaclark1 has joined #openstack-barbican | 13:04 | |
| *** jaosorior has quit IRC | 13:28 | |
| *** darrenmoffat has quit IRC | 13:31 | |
| *** darrenmoffat has joined #openstack-barbican | 13:32 | |
| *** rellerreller has joined #openstack-barbican | 13:34 | |
| openstackgerrit | Kaitlin Farr proposed openstack/castellan: Update Barbican functional tests https://review.openstack.org/216247 | 13:56 |
| *** spotz_zzz is now known as spotz | 14:06 | |
| *** zz_dimtruck is now known as dimtruck | 14:06 | |
| *** jhfeng has joined #openstack-barbican | 14:16 | |
| *** kfarr has joined #openstack-barbican | 14:31 | |
| *** edtubill has joined #openstack-barbican | 14:31 | |
| *** edtubill1 has joined #openstack-barbican | 14:34 | |
| *** edtubill has quit IRC | 14:36 | |
| *** lisaclark1 has quit IRC | 14:43 | |
| *** lisaclark1 has joined #openstack-barbican | 14:50 | |
| *** diazjf has joined #openstack-barbican | 14:53 | |
| *** silos has joined #openstack-barbican | 14:54 | |
| *** SheenaG has joined #openstack-barbican | 14:59 | |
| *** xaeth_afk is now known as xaeth | 15:03 | |
| *** dave-mccowan has quit IRC | 15:03 | |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for secrets https://review.openstack.org/213414 | 15:12 |
| *** dave-mccowan has joined #openstack-barbican | 15:16 | |
| silos | redrobot: ping | 15:19 |
| *** tkelsey has joined #openstack-barbican | 15:20 | |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Add functional test for updating a Secret https://review.openstack.org/219739 | 15:22 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 15:22 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 15:33 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 15:33 |
| redrobot | silos pong | 15:37 |
| silos | redrobot: In our endeavour to find a solution to federated barbican we turned over a rock and found a project called Mercador whose trying to setup federating independent clouds. I updated the wiki about it. Wanted to give you a heads up. | 15:39 |
| silos | *who's <grammar fail> | 15:39 |
| redrobot | silos interesting... | 15:42 |
| *** everjeje has quit IRC | 15:42 | |
| *** shohel has quit IRC | 15:43 | |
| openstackgerrit | Merged openstack/barbican: Add Request ID to worker-side logs in barbican. https://review.openstack.org/217775 | 15:50 |
| *** vivek-ebay has joined #openstack-barbican | 15:56 | |
| *** lisaclark1 has quit IRC | 15:56 | |
| *** gyee has joined #openstack-barbican | 15:57 | |
| openstackgerrit | Arun Kant proposed openstack/python-barbicanclient: Part 2: Adding ACL support for CLI commands and docs https://review.openstack.org/208343 | 16:03 |
| openstackgerrit | Arun Kant proposed openstack/python-barbicanclient: Part 1: Adding ACL support for Client API. https://review.openstack.org/206699 | 16:03 |
| openstackgerrit | Arun Kant proposed openstack/python-barbicanclient: Part 3: Adding ACL functional tests. https://review.openstack.org/208344 | 16:03 |
| *** kebray has joined #openstack-barbican | 16:05 | |
| *** kebray has quit IRC | 16:05 | |
| *** kebray has joined #openstack-barbican | 16:06 | |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Change test_containers unit test to work around webtest issue https://review.openstack.org/219774 | 16:16 |
| *** lisaclark1 has joined #openstack-barbican | 16:25 | |
| *** lisaclark2 has joined #openstack-barbican | 16:29 | |
| *** lisaclark2 has quit IRC | 16:30 | |
| *** lisaclark2 has joined #openstack-barbican | 16:30 | |
| *** lisaclark1 has quit IRC | 16:31 | |
| *** kebray has quit IRC | 16:32 | |
| *** lisaclark2 has quit IRC | 16:35 | |
| *** lisaclark1 has joined #openstack-barbican | 16:35 | |
| *** kebray has joined #openstack-barbican | 16:40 | |
| *** vivek-ebay has quit IRC | 16:49 | |
| *** SheenaG has left #openstack-barbican | 16:53 | |
| *** vivek-ebay has joined #openstack-barbican | 17:03 | |
| *** silos has left #openstack-barbican | 17:03 | |
| *** woodster_ has joined #openstack-barbican | 17:03 | |
| *** kebray has quit IRC | 17:07 | |
| *** jaosorior has joined #openstack-barbican | 17:16 | |
| redrobot | dave-mccowan hola dave | 17:29 |
| redrobot | dave-mccowan I'm hoping to get the last of the quota CRs merged today | 17:29 |
| redrobot | dave-mccowan but they seem to be failing at the gate right now. | 17:29 |
| dave-mccowan | redrobot hi doug! woot! | 17:29 |
| dave-mccowan | redrobot yep... i'm on it. i just need to delete a couple tests. | 17:29 |
| * redrobot knows about the coup and is permanently keeping an eye on dave-mccowan | 17:30 | |
| dave-mccowan | redrobot you left the keys in the car... | 17:30 |
| redrobot | lol | 17:30 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 17:34 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 17:35 |
| dave-mccowan | redrobot ^^ | 17:35 |
| *** lisaclark1 has quit IRC | 17:36 | |
| chellygel | i take full responsibility for putting the keys in the car | 17:36 |
| chellygel | and coming outside to see the engine running | 17:36 |
| chellygel | and letting it happen | 17:36 |
| dave-mccowan | redrobot let me know if there is any other blueprint that needs help to make the milestone | 17:36 |
| redrobot | dave-mccowan https://review.openstack.org/#/q/status:open+project:openstack/barbican+branch:master+topic:bp/add-cas,n,z would be good as well, | 17:37 |
| chellygel | ;~; i am sorry doug, 5 minutes late. i will commit sudoku! http://i.imgur.com/D9OqsCX.jpg | 17:37 |
| redrobot | chellygel lmao | 17:37 |
| dave-mccowan | chellygel (my accomplice) are you still working on update container? | 17:37 |
| chellygel | dave-mccowan, yes -- i apologize, its been a bit of a crazy week! | 17:38 |
| openstackgerrit | Merged openstack/barbican: Use the new Devstack external plugin method https://review.openstack.org/167885 | 17:38 |
| chellygel | I am; however, leaving on vacation after today | 17:38 |
| *** jaosorior has quit IRC | 17:39 | |
| dave-mccowan | chellygel no worries from me. let me know if you need help with the patch, i've been playing in similar code with the quotas. i can chip in if it needs anything after you leave for vacation. | 17:40 |
| chellygel | yeah for sure :) i appreciate the help. your reviews are great too. | 17:41 |
| redrobot | diazjf ping | 17:47 |
| diazjf | redrobot, pong | 18:02 |
| redrobot | diazjf just wondering if you wanted to get https://review.openstack.org/#/c/218117/ into liberty-3 ? | 18:02 |
| diazjf | redrobot, yeah that would be awesome | 18:03 |
| redrobot | diazjf I can review if you want to update the patch to use only one .testr.conf as suggested | 18:03 |
| diazjf | redrobot, yeah I can do that. All it should entail is just removing the /home/stack/barbican/functionaltests/.testr.conf | 18:04 |
| diazjf | I'll have the change up in the next 15 min | 18:10 |
| rellerreller | redrobot when is our code freeze? | 18:11 |
| redrobot | rellerreller Feature Freeze is liberty-3 https://wiki.openstack.org/wiki/Liberty_Release_Schedule | 18:12 |
| redrobot | rellerreller we'll probably want a Feature Freeze Exception for alee's work on cas | 18:12 |
| alee | redrobot, yes please | 18:13 |
| *** jaosorior has joined #openstack-barbican | 18:13 | |
| dave-mccowan | redrobot what about the PY3 patches? are these a "feature", of just refactoring that can trickle in? | 18:13 |
| redrobot | alee yeah, the magnum folks are expecting it for Liberty. | 18:13 |
| rellerreller | redrobot thanks. I might try to get in more patch that does the standardized functional tests with the annotations. | 18:13 |
| redrobot | dave-mccowan I think those are low priority, I don't think we'll be py3 compliant by the liberty release. | 18:14 |
| rellerreller | I need diazjf to get his .testr.conf patch accepted. I have been looking at that a lot today. | 18:14 |
| redrobot | rellerreller yeah, we'll try to get it merged today. He's working on an updated patch. | 18:14 |
| *** lisaclark1 has joined #openstack-barbican | 18:15 | |
| diazjf | rellerreller, posted a quick comment on https://review.openstack.org/#/c/218117/ | 18:15 |
| diazjf | let me know if thats ok | 18:16 |
| *** kebray has joined #openstack-barbican | 18:16 | |
| rellerreller | diazjf I think that is good. That is exactly what I was thinking. | 18:16 |
| openstackgerrit | Fernando Diaz proposed openstack/barbican: Use testr for running functional tests and documentation https://review.openstack.org/218117 | 18:18 |
| diazjf | rellerreller, redrobot, awesome! patch updated | 18:18 |
| *** insequent has quit IRC | 18:23 | |
| arunkant | _woodster, redrobot : Are you guys okay with this proposed change. https://review.openstack.org/#/c/211671 . | 18:26 |
| *** lisaclark1 has quit IRC | 18:27 | |
| jaosorior | redrobot: Have you had some time to check out why the stable/kilo gate fails? | 18:28 |
| redrobot | arunkant yes, for development purposes a wsgi container is not needed. we should not force everyone to use uwsgi | 18:28 |
| redrobot | jaosorior I spent a little bit of time on it and didn't get very far. Haven't had a chance to go back and look at it again. | 18:29 |
| arunkant | rellerreller: Looks like pkymip change is not merged (https://review.openstack.org/#/c/212579/) as its stuck because of global requirements pending change. | 18:29 |
| arunkant | redrobot, How concurrency support is provided in barbican..please see my comments. | 18:30 |
| rellerreller | arunkant NNNNNNNNNNooooooooooo! | 18:30 |
| rellerreller | Everyone should go +1 https://review.openstack.org/#/c/215755/ :) | 18:31 |
| redrobot | arunkant barbican.sh is just a reference/convenience script. anyone who deploys Barbican in a production environment should consider what WSGI container they will use. | 18:31 |
| *** peter-hamilton has quit IRC | 18:31 | |
| arunkant | redrobot, yes..but similar to other services, openstack service do provide concurrency support via oslo_service . I don't see that support for wsgi app in barbican which provides someone to deploy service as-is if they wish to. | 18:34 |
| redrobot | arunkant seems that we would want to add oslo_service support for that purpose then? not force uwsgi on everyone. | 18:35 |
| arunkant | yes..that's definitely a better approach as it allows to deploy barbican as-is if someone wants that way | 18:36 |
| *** tasalasc has joined #openstack-barbican | 18:36 | |
| arunkant | redrobot: We should add that support before removing uswsgi which is currently providing that capability. | 18:37 |
| *** tasalasc has left #openstack-barbican | 18:37 | |
| *** silos has joined #openstack-barbican | 18:39 | |
| woodster_ | arunkant: have you found examples of this approach in other projects? | 18:40 |
| arunkant | woddster_, yes I have mentioned them in comments | 18:41 |
| woodster_ | arunkant: sorry, I was focused on the inline comment | 18:45 |
| rellerreller | diazjf I don't know what the proper format is for .testr.conf. It seems to work the same with or without it. Perhaps someone else knows if it is needed. | 18:53 |
| *** tkelsey has quit IRC | 18:55 | |
| *** lisaclark1 has joined #openstack-barbican | 18:57 | |
| woodster_ | arunkant: added a comment on that CR please | 18:57 |
| *** lisaclark2 has joined #openstack-barbican | 19:01 | |
| *** lisaclark1 has quit IRC | 19:03 | |
| *** tkelsey has joined #openstack-barbican | 19:03 | |
| diazjf | rellerreller, yeah someone else checking that would be good. | 19:05 |
| diazjf | The way I have it runs all the test within the specified directory either way | 19:06 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 19:06 |
| *** vivek-ebay has quit IRC | 19:06 | |
| rellerreller | diazjf that is why it is so confusing to me. Why is there a --start flag? | 19:11 |
| *** vivek-ebay has joined #openstack-barbican | 19:12 | |
| diazjf | rellerreller, I have no idea, why they even have that :-/ | 19:13 |
| diazjf | keystone does it the same way I have it setup | 19:13 |
| rellerreller | redrobot I saw that you are core for global requirements. I have the pykmip 0.4.0 request, https://review.openstack.org/#/c/215755/ that is outstanding and blocking the merge of my Barbican patch ;0 | 19:14 |
| diazjf | redrobot, should we get the test behavior abstreaction removal done for this release? That way when other features are added the functional tests are created properly. | 19:15 |
| *** kebray has quit IRC | 19:18 | |
| *** lisaclark2 has quit IRC | 19:24 | |
| dave-mccowan | diazjf barbican client is not part of this code freeze. | 19:25 |
| *** vivek-ebay has quit IRC | 19:26 | |
| *** kebray has joined #openstack-barbican | 19:28 | |
| hockeynut | dave-mccowan - I went thru the quota CRs, lots of questions and still confusion in my little brain about project IDs - keystone and barbican :-) | 19:30 |
| dave-mccowan | hockeynut IDs. IDs everywhere. | 19:31 |
| hockeynut | external project ID is the keystone proj id? | 19:31 |
| diazjf | dave-mccowan, gotcha | 19:31 |
| dave-mccowan | hockeynut yep | 19:31 |
| arunkant | woodster_, please see my reply comments on CR | 19:31 |
| hockeynut | dave-mccowan and everywhere else I see "project id" refers to the internal key in the db (which a user never sees nor uses)? | 19:32 |
| dave-mccowan | hockeynut yep. your comments were right on. | 19:32 |
| hockeynut | dave-mccowan thanks. we have so many overloaded terms in this industry its amazing that anything ever works :-D | 19:33 |
| dave-mccowan | hockeynut i copied that naming convention from the other controllers, so if i got it right, at least i haven't added confusion to the code base. :-) | 19:34 |
| *** shohel has joined #openstack-barbican | 19:36 | |
| *** rellerreller has quit IRC | 19:37 | |
| openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Add functional test for updating a Secret https://review.openstack.org/219739 | 19:37 |
| *** gyee has quit IRC | 19:44 | |
| jaosorior | hockeynut, dave-mccowan: That is indeed the case. External project ID comes from keystone and is the one that comes in the request's headers. While "project id", is the id that was generated in the database. the user shouldn't really need to deal with that. | 19:45 |
| hockeynut | jaosorior dave-mccowan so our docs that reference project id are talking about keystone and not the internal one. looking at the code that gets very confusing when we just see project_id | 19:46 |
| jaosorior | initially external project id was called keystone id... but I got rid of that, since we were asuming that that id might not necessarily be coming from keystone. | 19:46 |
| hockeynut | jaosorior that makes sense. wish we had another thing internally besudes project | 19:46 |
| hockeynut | like "tenant" :-D | 19:46 |
| jaosorior | hockeynut: the thing is, the "project id" that is in the code is not something the user should even know about. It's just implementation details | 19:47 |
| hockeynut | jaosorior correct...just trying to be sure looking at the code that I'm clear what its doing | 19:47 |
| jaosorior | so the documentation should be refferring to what in the code is the "external_project_id" | 19:47 |
| jaosorior | I know this causes a lot of confusion but in the end I didn't come up with an alternative :/ | 19:47 |
| jaosorior | I remember having a lot of discussion about this with woodster | 19:48 |
| jaosorior | but no, "tenant" is not coming back haha :P | 19:48 |
| hockeynut | I guess a good rule of thumb could be: (1) if the docs refer to a project ID (like in a URL, its the EXTERNAL one. (2) in the code, when you see external_project_id then its talking about the EXTERNAL one and if you see just project_id its talking about the internal one. | 19:49 |
| jaosorior | yep | 19:49 |
| jaosorior | that should be it | 19:49 |
| jaosorior | that should be documented somewhere though... not sure where | 19:50 |
| hockeynut | I am thinking about getting a tattoo | 19:50 |
| hockeynut | or maybe just put it on a shirt - less permanent :-D | 19:50 |
| dave-mccowan | document it in the IRC channel every six months, right before code freeze | 19:50 |
| hockeynut | thx for clearing it up! | 19:50 |
| hockeynut | dave-mccowan MOTD ! | 19:51 |
| jaosorior | shirt + MOTD sounds like the way to go :P | 19:51 |
| hockeynut | pull request accepted | 19:51 |
| dave-mccowan | Sorry. Your project_id is in another castle. | 19:51 |
| hockeynut | perfect | 19:51 |
| dave-mccowan | or would that be external_project_id? | 19:53 |
| jaosorior | hahaha dammit | 19:54 |
| *** vivek-ebay has joined #openstack-barbican | 19:57 | |
| *** gyee has joined #openstack-barbican | 20:06 | |
| *** kfarr has quit IRC | 20:16 | |
| *** peter-hamilton has joined #openstack-barbican | 20:18 | |
| *** lisaclark1 has joined #openstack-barbican | 20:20 | |
| dave-mccowan | hockeynut ping | 20:22 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 20:33 |
| *** jaosorior has quit IRC | 20:41 | |
| redrobot | dave-mccowan hockeynut I disagree that quota=0 needs to be a special case | 20:54 |
| redrobot | dave-mccowan hockeynut I don't see the value in having different exceptions and different messages | 20:54 |
| redrobot | dave-mccowan hockeynut we're really just talking about the quota not being high enough to add new entities. | 20:55 |
| dave-mccowan | redrobot i was on the fence. part of me liked the one exception, since it automatically told the user/admin to change project-quotas to fix it. | 20:55 |
| dave-mccowan | redrobot hockeynut i'll revert. | 20:56 |
| dave-mccowan | redrobot what do you think about hockeynut's suggestion on https://review.openstack.org/#/c/218717/ ? | 20:57 |
| *** lisaclark1 has quit IRC | 21:01 | |
| redrobot | dave-mccowan I don't have a strong preference... I would +2 your impl and let hockeynut follow up with a new patch if he wants to. | 21:04 |
| dave-mccowan | redrobot hockeynut that works for me. i don't want to spend time refactoring the night before code freeze. risk > reward. | 21:05 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 21:07 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 21:09 |
| *** dave-mccowan has quit IRC | 21:14 | |
| *** edtubill1 has quit IRC | 21:15 | |
| *** diazjf has left #openstack-barbican | 21:18 | |
| *** silos has left #openstack-barbican | 21:26 | |
| *** lisaclark1 has joined #openstack-barbican | 21:34 | |
| *** lisaclark1 has quit IRC | 21:34 | |
| *** lisaclark1 has joined #openstack-barbican | 21:34 | |
| *** shohel has quit IRC | 21:34 | |
| *** kebray has quit IRC | 21:42 | |
| *** dave-mccowan has joined #openstack-barbican | 21:45 | |
| *** xaeth is now known as xaeth_afk | 21:48 | |
| *** lisaclark1 has quit IRC | 21:59 | |
| *** everjeje has joined #openstack-barbican | 22:00 | |
| *** kebray has joined #openstack-barbican | 22:04 | |
| woodster_ | redrobot: arunkant Are the changes in Amy's CR (https://review.openstack.org/#/c/211671) needed for the release? | 22:12 |
| woodster_ | redrobot: arunkant if not, I'd argue for putting that CR with a call out to the bin/barbican-api script to boot the app up, with a separate CR to modify that script to invoke an oslo_service server | 22:13 |
| *** peter-hamilton has quit IRC | 22:31 | |
| woodster_ | hockeynut: Hey Steve, how adamant are you about data driven tests for Dave's CR: https://review.openstack.org/#/c/218717 | 22:39 |
| *** jhfeng has quit IRC | 22:40 | |
| *** dimtruck is now known as zz_dimtruck | 22:54 | |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Update API Reference Docs with Project Quota Information https://review.openstack.org/214764 | 22:56 |
| openstackgerrit | Amy Marrich proposed openstack/barbican: Removes pyenv from barbican.sh https://review.openstack.org/211671 | 22:57 |
| *** rellerreller has joined #openstack-barbican | 23:03 | |
| *** kebray has quit IRC | 23:03 | |
| *** spotz is now known as spotz_zzz | 23:06 | |
| openstackgerrit | Merged openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 23:17 |
| *** rellerreller has quit IRC | 23:45 | |
| *** fnaval has quit IRC | 23:47 | |
| *** fnaval has joined #openstack-barbican | 23:50 | |
| openstackgerrit | Merged openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 23:59 |
| openstackgerrit | Merged openstack/barbican: Add Functional Tests for Quota Enforcement https://review.openstack.org/218717 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
