| *** _cjones_ has quit IRC | 00:04 | |
| *** thorst has quit IRC | 00:25 | |
| *** ankita_wagh has joined #openstack-ceilometer | 00:47 | |
| *** ankita_w_ has quit IRC | 00:51 | |
| *** nadya has joined #openstack-ceilometer | 00:54 | |
| *** nadya has quit IRC | 00:59 | |
| *** ankita_wagh has quit IRC | 01:14 | |
| openstackgerrit | Merged openstack/ceilometer: Updated from global requirements https://review.openstack.org/210857 | 01:16 |
|---|---|---|
| *** fabian1 has joined #openstack-ceilometer | 01:22 | |
| *** jwcropp__ has quit IRC | 01:23 | |
| *** jwcroppe has joined #openstack-ceilometer | 01:24 | |
| openstackgerrit | liusheng proposed openstack/ceilometer: Drop the downgrade function of migration scripts https://review.openstack.org/211379 | 01:26 |
| *** liusheng has joined #openstack-ceilometer | 01:27 | |
| *** jwcroppe has quit IRC | 01:28 | |
| *** ankita_wagh has joined #openstack-ceilometer | 01:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ceilometerclient: Updated from global requirements https://review.openstack.org/210917 | 01:38 |
| *** jwcroppe has joined #openstack-ceilometer | 01:41 | |
| *** jwcroppe has quit IRC | 01:41 | |
| *** jwcroppe has joined #openstack-ceilometer | 01:42 | |
| *** ankita_wagh has quit IRC | 01:43 | |
| *** ankita_wagh has joined #openstack-ceilometer | 01:43 | |
| *** jwcroppe has quit IRC | 01:46 | |
| openstackgerrit | liusheng proposed openstack/ceilometer: Add Kilo release note reference https://review.openstack.org/211391 | 01:47 |
| *** jdandrea has quit IRC | 02:00 | |
| *** ankita_w_ has joined #openstack-ceilometer | 02:08 | |
| *** ankita_wagh has quit IRC | 02:12 | |
| openstackgerrit | Rohit Jaiswal proposed openstack/ceilometer: Adds support for dynamic event pipeline https://review.openstack.org/208068 | 02:12 |
| *** ddieterly has joined #openstack-ceilometer | 02:22 | |
| *** jwcroppe has joined #openstack-ceilometer | 02:25 | |
| *** haigang has joined #openstack-ceilometer | 02:43 | |
| *** ddieterl_ has joined #openstack-ceilometer | 02:45 | |
| *** ddieterly has quit IRC | 02:48 | |
| *** nadya has joined #openstack-ceilometer | 02:55 | |
| openstackgerrit | liusheng proposed openstack/ceilometer: Drop the downgrade function of migration scripts https://review.openstack.org/211379 | 02:57 |
| *** ddieterly has joined #openstack-ceilometer | 02:57 | |
| *** ddieterl_ has quit IRC | 02:58 | |
| *** nadya has quit IRC | 02:59 | |
| *** ankita_w_ has quit IRC | 03:01 | |
| *** jwcroppe has quit IRC | 03:05 | |
| *** david-lyle has quit IRC | 03:21 | |
| *** rbak has joined #openstack-ceilometer | 03:22 | |
| *** jwcroppe has joined #openstack-ceilometer | 03:24 | |
| *** rbak has quit IRC | 03:26 | |
| *** fawadkhaliq has joined #openstack-ceilometer | 03:29 | |
| openstackgerrit | liusheng proposed openstack/ceilometer: Introduce Guru Meditation Reports into Ceilometer https://review.openstack.org/196369 | 03:39 |
| *** logan2 has quit IRC | 03:47 | |
| *** hhuang has quit IRC | 03:54 | |
| *** jkraj has joined #openstack-ceilometer | 03:54 | |
| *** logan2 has joined #openstack-ceilometer | 03:55 | |
| *** jwcroppe has quit IRC | 03:57 | |
| *** Ephur has quit IRC | 04:12 | |
| *** ddieterly has quit IRC | 04:15 | |
| *** fawadkhaliq has quit IRC | 04:21 | |
| *** fabian1 has left #openstack-ceilometer | 04:32 | |
| *** fabian1 has joined #openstack-ceilometer | 04:36 | |
| *** jkraj has quit IRC | 04:38 | |
| *** exploreshaifali has joined #openstack-ceilometer | 04:39 | |
| *** david-lyle has joined #openstack-ceilometer | 04:40 | |
| *** ildikov has quit IRC | 04:46 | |
| *** ankita_wagh has joined #openstack-ceilometer | 04:58 | |
| *** ankita_wagh has quit IRC | 04:58 | |
| *** ankita_wagh has joined #openstack-ceilometer | 04:59 | |
| *** jkraj has joined #openstack-ceilometer | 05:07 | |
| *** ddieterly has joined #openstack-ceilometer | 05:16 | |
| *** ddieterly has quit IRC | 05:21 | |
| *** fawadkhaliq has joined #openstack-ceilometer | 05:22 | |
| *** ildikov has joined #openstack-ceilometer | 05:24 | |
| *** yprokule has joined #openstack-ceilometer | 05:24 | |
| *** exploreshaifali has quit IRC | 05:24 | |
| *** nadya has joined #openstack-ceilometer | 05:27 | |
| *** nadya_ has joined #openstack-ceilometer | 05:30 | |
| *** nadya has quit IRC | 05:30 | |
| *** fawadk has joined #openstack-ceilometer | 05:31 | |
| *** fawadkhaliq has quit IRC | 05:31 | |
| *** nadya_ has quit IRC | 05:32 | |
| *** liusheng has quit IRC | 05:34 | |
| *** belmoreira has joined #openstack-ceilometer | 05:43 | |
| *** liusheng has joined #openstack-ceilometer | 05:44 | |
| *** ddieterly has joined #openstack-ceilometer | 06:17 | |
| *** ddieterly has quit IRC | 06:21 | |
| *** shardy has joined #openstack-ceilometer | 06:24 | |
| *** rohit has quit IRC | 06:30 | |
| *** jkraj has quit IRC | 06:36 | |
| *** jwcroppe has joined #openstack-ceilometer | 06:37 | |
| *** rbak has joined #openstack-ceilometer | 06:44 | |
| *** exploreshaifali has joined #openstack-ceilometer | 06:56 | |
| *** cdent has joined #openstack-ceilometer | 07:02 | |
| *** shardy has quit IRC | 07:06 | |
| *** exploreshaifali has quit IRC | 07:12 | |
| *** afazekas has joined #openstack-ceilometer | 07:13 | |
| *** ddieterly has joined #openstack-ceilometer | 07:18 | |
| *** ankita_wagh has quit IRC | 07:20 | |
| *** ddieterly has quit IRC | 07:22 | |
| *** jkraj has joined #openstack-ceilometer | 07:22 | |
| *** nadya has joined #openstack-ceilometer | 07:33 | |
| *** nadya has quit IRC | 07:38 | |
| *** cdent has quit IRC | 08:03 | |
| *** cdent has joined #openstack-ceilometer | 08:05 | |
| *** boris-42 has quit IRC | 08:10 | |
| *** links has joined #openstack-ceilometer | 08:13 | |
| *** yassine__ has joined #openstack-ceilometer | 08:16 | |
| *** ddieterly has joined #openstack-ceilometer | 08:19 | |
| *** ddieterly has quit IRC | 08:24 | |
| openstackgerrit | liusheng proposed openstack/ceilometer-specs: Improve Nova Instance metering https://review.openstack.org/209799 | 08:25 |
| *** fawadk has quit IRC | 08:25 | |
| *** fawadkhaliq has joined #openstack-ceilometer | 08:26 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/aodh: Move ceilometerclient mock to evaluator/base https://review.openstack.org/211459 | 08:26 |
| *** nadya has joined #openstack-ceilometer | 08:30 | |
| *** dikonoor has joined #openstack-ceilometer | 08:49 | |
| *** dikonoo has joined #openstack-ceilometer | 08:49 | |
| *** yassine__ has quit IRC | 09:01 | |
| *** yassine__ has joined #openstack-ceilometer | 09:01 | |
| openstackgerrit | Merged openstack/ceilometer-specs: highly distributed coordinated notifications https://review.openstack.org/199331 | 09:07 |
| *** yassine__ has quit IRC | 09:09 | |
| openstackgerrit | Zhai, Edwin proposed openstack/aodh: Fix aodh-dbsync crash https://review.openstack.org/211471 | 09:12 |
| *** yassine__ has joined #openstack-ceilometer | 09:12 | |
| openstackgerrit | Merged openstack/ceilometer: Add Kilo release note reference https://review.openstack.org/211391 | 09:15 |
| *** ddieterly has joined #openstack-ceilometer | 09:20 | |
| openstackgerrit | Merged openstack/ceilometer: initialise opencontrail client in tests https://review.openstack.org/211335 | 09:20 |
| *** ddieterly has quit IRC | 09:24 | |
| *** nadya has quit IRC | 09:31 | |
| openstackgerrit | Merged openstack/aodh: Move ceilometerclient mock to evaluator/base https://review.openstack.org/211459 | 09:31 |
| openstackgerrit | Chris Dent proposed openstack/aodh: Refactor api tests for alarm history https://review.openstack.org/210832 | 09:35 |
| openstackgerrit | Chris Dent proposed openstack/aodh: Fixes querying alarm history with severity field https://review.openstack.org/200315 | 09:36 |
| openstackgerrit | Ildiko Vancsa proposed openstack/aodh: Move import to local to resolve circular dependency failure https://review.openstack.org/210816 | 09:36 |
| cdent | ildikov: if you're around can you have a look at https://review.openstack.org/#/c/210503/ | 09:38 |
| cdent | please and thank you! | 09:38 |
| ildikov | cdent: done | 09:40 |
| cdent | thanks | 09:40 |
| ildikov | cdent: can you push this one through: https://review.openstack.org/#/c/210816/1 ? | 09:41 |
| * cdent looks | 09:41 | |
| cdent | yup, there it goes | 09:41 |
| ildikov | cdent: I rebased it so the W +1 disappeared | 09:41 |
| ildikov | cdent: tnx :) | 09:41 |
| *** nadya has joined #openstack-ceilometer | 09:47 | |
| openstackgerrit | Merged openstack/aodh: Refactor api tests for alarm history https://review.openstack.org/210832 | 09:50 |
| *** nadya has quit IRC | 09:51 | |
| *** nadya has joined #openstack-ceilometer | 09:52 | |
| jd__ | Gnocchi 1.1.0 is out | 09:53 |
| cdent | \o/ | 09:53 |
| openstackgerrit | Merged openstack/aodh: Move import to local to resolve circular dependency failure https://review.openstack.org/210816 | 09:55 |
| *** ddieterly has joined #openstack-ceilometer | 10:20 | |
| *** fawadkhaliq has quit IRC | 10:22 | |
| *** fawadkhaliq has joined #openstack-ceilometer | 10:22 | |
| openstackgerrit | Merged openstack/ceilometer: Revert "Revert "remove instance:<flavor> meter"" https://review.openstack.org/192503 | 10:22 |
| *** ddieterly has quit IRC | 10:25 | |
| openstackgerrit | Julien Danjou proposed openstack/aodh: Stop registering oslo.messaging option https://review.openstack.org/211025 | 10:26 |
| *** jwcroppe has quit IRC | 10:42 | |
| openstackgerrit | Divya K Konoor proposed openstack/ceilometer: Control Events RBAC from policy.json https://review.openstack.org/211494 | 10:43 |
| openstackgerrit | Divya K Konoor proposed openstack/ceilometer: Control Events RBAC from policy.json https://review.openstack.org/211494 | 10:47 |
| openstackgerrit | Merged openstack/ceilometer: Correct thread handling in TranslationHook https://review.openstack.org/210503 | 10:54 |
| *** yassine__ has quit IRC | 11:00 | |
| openstackgerrit | Divya K Konoor proposed openstack/ceilometer: Add user_id,project_id traits to audit events https://review.openstack.org/211509 | 11:17 |
| openstackgerrit | Julien Danjou proposed openstack/gnocchi: Add to influx command's $PATH https://review.openstack.org/209561 | 11:18 |
| openstackgerrit | Julien Danjou proposed openstack/gnocchi: InfluxDB storage driver https://review.openstack.org/165407 | 11:18 |
| *** ddieterly has joined #openstack-ceilometer | 11:21 | |
| *** ddieterly has quit IRC | 11:26 | |
| *** dikonoor has quit IRC | 11:31 | |
| *** yassine__ has joined #openstack-ceilometer | 11:35 | |
| *** belmoreira has quit IRC | 11:35 | |
| *** thorst1 has joined #openstack-ceilometer | 11:36 | |
| *** eglynn has joined #openstack-ceilometer | 11:38 | |
| *** gordc has joined #openstack-ceilometer | 11:39 | |
| dikonoo | gordc:Hi gordc | 11:40 |
| dikonoo | gordc: I am looking at the possibility of adding user_id and project_id traits to all the event_types at https://github.com/openstack/ceilometer/blob/master/etc/ceilometer/event_definitions.yaml | 11:41 |
| dikonoo | gordc: The image event_types have user_id and project_id but I am not really sure if they actually point to the ids | 11:42 |
| dikonoo | https://github.com/openstack/ceilometer/blob/master/etc/ceilometer/event_definitions.yaml#L101-L112 | 11:42 |
| dikonoo | gordc:There are few other traits defined here which are also related to user_id and project_id https://github.com/openstack/ceilometer/blob/master/etc/ceilometer/event_definitions.yaml#L119-L124 | 11:43 |
| gordc | dikonoo: point to which ids? | 11:43 |
| dikonoo | gordc: the ids should point to whatever is in the token | 11:44 |
| gordc | dikonoo: they should be. they are the same ids we use when we built them as meters. | 11:45 |
| gordc | the crud events are mostly just existing meters i shifted over. | 11:45 |
| dikonoo | gordc: ok..https://github.com/openstack/ceilometer/blob/master/etc/ceilometer/event_definitions.yaml#L102 So you are saying that this actually points to something like | 11:46 |
| dikonoo | { | 11:46 |
| dikonoo | "type":"string", | 11:46 |
| dikonoo | "name":"project_id", | 11:46 |
| dikonoo | "value":"20a3720a680240f2acbfde969d91c37d" | 11:46 |
| dikonoo | } | 11:46 |
| dikonoo | gordc: as in they do point to the project_id and not to anything else | 11:47 |
| *** liusheng has quit IRC | 11:49 | |
| dikonoo | gordc : In https://github.com/openstack/ceilometer-specs/blob/master/specs/liberty/events-rbac.rst , we have mentioned that there could be cases where certain event_types don't have project_id and user_id as traits , in which case we will return events that doesn't have this trait | 11:50 |
| dikonoo | exact lines from the spec are these : | 11:50 |
| dikonoo | Until all events have project/user information, events which lack this data will be returned along with events corresponding to the token’s project, if the token's user is an admin on that project | 11:50 |
| gordc | dikonoo: should be... let me cehck | 11:50 |
| gordc | dikonoo: right. | 11:50 |
| dikonoo | gordc: I couldn;t figure out a way that could be used in the events filter that says - give me all the events that doesn't have traits abc | 11:51 |
| dikonoo | gordc: I can run a filter that says - "give me events where the project_id='abc'" | 11:51 |
| dikonoo | gordc: but is it possible to run a filter that says - "give me events that doesn't have this trait" | 11:52 |
| gordc | dikonoo: i'm not sure there's an exists query capability... we might need to add that in | 11:52 |
| dikonoo | gordc: In the current events definition yaml file , most of the event_types have user_id and project_id defined as traits.. I have added a review for audit events..There's a even type related to dns that doesn;t have these and I don;t have any clue on where that comes from | 11:54 |
| dikonoo | gordc:https://github.com/openstack/ceilometer/blob/master/etc/ceilometer/event_definitions.yaml#L369-L399 | 11:55 |
| dikonoo | gordc: Do you have any idea on these? | 11:56 |
| gordc | dikonoo: yeah, i think let me find the patch. | 11:56 |
| gordc | those are designate events | 11:57 |
| gordc | https://review.openstack.org/#/c/186962/ | 11:57 |
| dikonoo | https://review.openstack.org/#/c/186962 | 11:58 |
| dikonoo | ok | 11:58 |
| dikonoo | gordc:not sure where to find rohit :) | 12:00 |
| *** openstackgerrit_ has joined #openstack-ceilometer | 12:02 | |
| *** liusheng has joined #openstack-ceilometer | 12:02 | |
| dikonoo | gordc: Do you think adding this trait to all event types and setting it to null by default (for temporary purposes till all events set user/project) makes sense? | 12:02 |
| gordc | dikonoo: what does that achieve? | 12:04 |
| gordc | dikonoo: regarding the glance_crud snippet from above, project_id is correct. i don't know why user_id is set to payload.owner as well, that seems to be wrong. | 12:04 |
| gordc | but i'm not sure... i'm just looking at test payload | 12:04 |
| dikonoo | gordc: that way we can use the existing filter logic to query for all events that has trait project_id set to null | 12:05 |
| dikonoo | gordc: that way we take care of returning events that don't have user/project set (this will be returned for admins only) along with the events that have project_id set to the user's request project_id | 12:06 |
| gordc | dikonoo: i see.. i think you'll still need to support OR condition...so you can grab all events with an id OR null | 12:06 |
| gordc | unless you're doing two queries | 12:06 |
| gordc | your query would be completely out of whack because of limits though | 12:07 |
| dikonoo | gordc: If I do two queries, I will get beaten by the community at review state saying it's a performance overhead..but do you think 2 queries will cause that much perf overhead | 12:07 |
| dikonoo | gordc: *review stage | 12:08 |
| gordc | dikonoo: it will be very complicated to do two queries and still enforce the limit | 12:08 |
| dikonoo | gordc: hmm..thats right | 12:08 |
| dikonoo | gordc: which is easier..investing my time on implementing OR condition in the query..or adding user_id, project_id to all events | 12:09 |
| dikonoo | gordc: All events should have project_id (there could be events without user_id).. | 12:09 |
| gordc | i think you'll still need to have OR no matter what. | 12:09 |
| gordc | you'll need to grab all events=xyz OR null (not exist) | 12:10 |
| gordc | i'm looking to see if there's existing code we can grab to do this. | 12:11 |
| dikonoo | gordc: I haven't looked into how to implement that but my guess is each of the db driver needs a separate/custom implementation | 12:11 |
| dikonoo | gordc: yeah..Please help :) | 12:11 |
| gordc | dikonoo: i think one good thing is that we don't have to surface the OR functionality so it actually might not be that bad. | 12:12 |
| gordc | can you tell when it's an 'admin' query vs a common user query? | 12:12 |
| dikonoo | gordc: yeah..we use the 'context_is_admin' rule from policy.json to check that | 12:13 |
| dikonoo | gordc: if that rule passes, that means the user making the call is an admin | 12:14 |
| gordc | dikonoo: so in your patch https://review.openstack.org/#/c/211494/2/ceilometer/api/controllers/v2/events.py | 12:15 |
| gordc | when it gets past rbac.enforce | 12:15 |
| gordc | how do i know if it's a user request or an admin request? | 12:16 |
| gordc | assuming we accept both | 12:16 |
| dikonoo | gordc: gordc: we use this method https://github.com/openstack/ceilometer/blob/master/ceilometer/api/rbac.py#L63 | 12:17 |
| dikonoo | gordc: this in turn checks for the rule 'context_is_admin' | 12:17 |
| dikonoo | gordc: If the call is made by an admin , this method will return None,None | 12:18 |
| dikonoo | gordc: This method is used in many other places in the ceilometer code to check if the call is made by an admin | 12:19 |
| dikonoo | gordc: like here >> https://github.com/openstack/ceilometer/blob/master/ceilometer/api/controllers/v2/utils.py#L341 | 12:19 |
| gordc | ah got it. | 12:19 |
| gordc | yeah, i guess you can figure out if user, query on that user id. | 12:20 |
| gordc | if admin, query on the project_id (and then just append an or conditions to query on events project_id not exists | 12:21 |
| gordc | i can probably help you with each of the backends... you should be able to just do it for sql first since that's what we gate on.. the other backends i can help address | 12:22 |
| *** ddieterly has joined #openstack-ceilometer | 12:22 | |
| dikonoo | gordc: ok..so there's no escape | 12:24 |
| dikonoo | gordc:do you know if there's some existing ceilometer tests around rbac that I can update for https://review.openstack.org/#/c/211494/ | 12:25 |
| *** thumpba has joined #openstack-ceilometer | 12:25 | |
| gordc | yeah. i think there's only 'append OR condition' or 'do two queries'... and two queries is going to be a bad time for everyone. | 12:25 |
| gordc | dikonoo: i don't believe there are | 12:26 |
| *** ddieterly has quit IRC | 12:27 | |
| gordc | dikonoo: seems like it's hardcoded into assume admin: https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/functional/api/v2/test_event_scenarios.py#L26 | 12:27 |
| dikonoo | gordc: perhaps i can add something where the role defined in the policy.json corresponds to something else and that should give a 403 | 12:30 |
| *** jwcroppe has joined #openstack-ceilometer | 12:30 | |
| dikonoo | gordc: does this need a documentation change >> https://review.openstack.org/#/c/211494/ | 12:31 |
| dikonoo | gordc: which document should I change? | 12:31 |
| gordc | you can just add DocImpact to your commit message | 12:33 |
| gordc | dikonoo: i don't think we have it stated anywhere that events require admin right now | 12:33 |
| *** edmondsw has joined #openstack-ceilometer | 12:33 | |
| dikonoo | gordc: so doc chane not required..I have the new rules at policy.json.sample | 12:34 |
| dikonoo | gordc:change* | 12:34 |
| dikonoo | gordc: https://review.openstack.org/#/c/211509/. could you take a look at this when you get a chance | 12:35 |
| *** ddieterly has joined #openstack-ceilometer | 12:35 | |
| *** haigang has quit IRC | 12:35 | |
| gordc | dikonoo: hmm.. that's weird there's listing for both objectstore.http.request and *http.* | 12:37 |
| gordc | i'm pretty sure it's never matching against objectstore.http.request since *http.* will catch it | 12:38 |
| dikonoo | gordc: so the entries added against objectstore* are not required | 12:42 |
| gordc | probably not. that can be done separately. i need to confirm that | 12:42 |
| dikonoo | ok | 12:43 |
| openstackgerrit | gordon chung proposed openstack/ceilometer: support multiple-meter payloads https://review.openstack.org/210512 | 12:45 |
| *** thumpba has quit IRC | 12:45 | |
| *** links has quit IRC | 12:48 | |
| openstackgerrit | gordon chung proposed openstack/ceilometer: start rpc deprecation https://review.openstack.org/211304 | 12:50 |
| *** kfarhane_ has quit IRC | 12:50 | |
| *** ddieterly has quit IRC | 12:50 | |
| *** openstackgerrit_ has quit IRC | 12:51 | |
| *** thumpba has joined #openstack-ceilometer | 12:52 | |
| *** jwcroppe has quit IRC | 12:53 | |
| *** openstackgerrit_ has joined #openstack-ceilometer | 12:56 | |
| *** jwcroppe has joined #openstack-ceilometer | 12:59 | |
| *** jwcroppe has quit IRC | 13:01 | |
| openstackgerrit | Divya K Konoor proposed openstack/ceilometer: Add user_id,project_id traits to audit events https://review.openstack.org/211509 | 13:06 |
| *** vgnbkr has quit IRC | 13:20 | |
| *** fawadkhaliq has quit IRC | 13:20 | |
| *** vgnbkr has joined #openstack-ceilometer | 13:22 | |
| dikonoo | liusheng: Hi liusheng. | 13:26 |
| dikonoo | liusheng: this is about a comment you had added in https://review.openstack.org/#/c/211494/ on UT | 13:27 |
| dikonoo | liusheng: I don't see a UT framework or existing testcases in place in ceilometer to UT the rules I have added.. Do you see a way? | 13:27 |
| *** julim has joined #openstack-ceilometer | 13:29 | |
| dikonoo | liusheng:I checked out https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/functional/gabbi/fixtures.py#L67 but that seems to be using the the policy.json at /etc/ceilometer | 13:29 |
| dikonoo | liusheng: Do you have any suggestions on how we can add a UT? | 13:31 |
| *** david-lyle has quit IRC | 13:36 | |
| dikonoo | gordc: I have uploaded another patch for https://review.openstack.org/211509 , removing the entries for objectstore | 13:36 |
| dikonoo | gordc: and for https://review.openstack.org/#/c/211494/ , I don't see a place I can add some UTs for the change I made :-| | 13:37 |
| *** jasonamyers has joined #openstack-ceilometer | 13:46 | |
| * cdent waves at jasonamyers | 13:49 | |
| jasonamyers | hey cdent | 13:49 |
| *** edmondsw has quit IRC | 13:51 | |
| *** yprokule has quit IRC | 13:53 | |
| *** yprokule has joined #openstack-ceilometer | 13:55 | |
| *** openstackgerrit_ has quit IRC | 13:55 | |
| *** openstackgerrit_ has joined #openstack-ceilometer | 13:56 | |
| *** exploreshaifali has joined #openstack-ceilometer | 13:56 | |
| *** afazekas has quit IRC | 13:56 | |
| *** r-daneel has joined #openstack-ceilometer | 14:00 | |
| *** fawadkhaliq has joined #openstack-ceilometer | 14:01 | |
| *** openstackgerrit_ has quit IRC | 14:17 | |
| *** openstackgerrit_ has joined #openstack-ceilometer | 14:18 | |
| gordc | dikonoo: you'll probably want to edit this: https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/functional/api/v2/test_event_scenarios.py | 14:23 |
| gordc | but pass in different headers | 14:23 |
| cdent | gordc: you got anybody who can do this: https://bugs.launchpad.net/ceilometer/+bug/1458579 | 14:24 |
| openstack | Launchpad bug 1458579 in Ceilometer "Event filtering by trait doesn't work with elasticsearch backend" [Medium,Triaged] | 14:24 |
| *** edmondsw has joined #openstack-ceilometer | 14:24 | |
| *** prad_ has joined #openstack-ceilometer | 14:24 | |
| gordc | reading | 14:25 |
| *** prad_ is now known as pradk | 14:25 | |
| gordc | cdent: hmmm. i swear i just ran elasticsearch and the tests passed | 14:26 |
| gordc | let me try again | 14:26 |
| *** rbak has quit IRC | 14:26 | |
| cdent | gordc: I guess the issue is that maybe it doesn't work in kilo | 14:27 |
| cdent | and if so, what's the diff | 14:27 |
| gordc | https://github.com/openstack/ceilometer/commit/906c72fc216a108cd949faf94fc2a2adda014a9b | 14:29 |
| gordc | only change... and it was backported | 14:29 |
| * gordc running tests again | 14:30 | |
| cdent | right on | 14:30 |
| *** openstackgerrit_ has quit IRC | 14:31 | |
| gordc | hmmm. setup-test-env-es.sh doesn't seem to work... time to hack it. | 14:31 |
| cdent | gordc so you're saying that bugs 1458579 and 1453919 are the same thing | 14:33 |
| openstack | bug 1453919 in Ceilometer kilo "elasticsearch get_events incorrect trait type" [Medium,Fix released] https://launchpad.net/bugs/1453919 - Assigned to gordon chung (chungg) | 14:33 |
| openstack | bug 1458579 in Ceilometer "Event filtering by trait doesn't work with elasticsearch backend" [Medium,Triaged] https://launchpad.net/bugs/1458579 | 14:33 |
| gordc | cdent: oh. no. i was just saying that was the only patch since kilo | 14:34 |
| cdent | oh | 14:35 |
| *** nadya has quit IRC | 14:35 | |
| *** rbak has joined #openstack-ceilometer | 14:41 | |
| *** nadya has joined #openstack-ceilometer | 14:41 | |
| gordc | cdent: hmmm... either a gap in our tests or the bug is fixed | 14:43 |
| *** jdandrea has joined #openstack-ceilometer | 14:43 | |
| gordc | i'll start debugging it. | 14:44 |
| cdent | thanks, I have zero clue about es | 14:45 |
| * cdent is tired of having zero clues | 14:45 | |
| gordc | just know they all rich. | 14:45 |
| openstackgerrit | gordon chung proposed openstack/ceilometer: add poll history to avoid duplicate samples https://review.openstack.org/209160 | 14:46 |
| *** ddieterly has joined #openstack-ceilometer | 14:47 | |
| *** Ephur has joined #openstack-ceilometer | 14:47 | |
| *** Ephur has quit IRC | 14:52 | |
| *** IBerezovskiy has joined #openstack-ceilometer | 15:02 | |
| *** exploreshaifali has quit IRC | 15:06 | |
| *** yprokule has quit IRC | 15:12 | |
| *** david-lyle has joined #openstack-ceilometer | 15:15 | |
| openstackgerrit | Merged openstack/ceilometer: api: fix alarm deletion and update https://review.openstack.org/209441 | 15:19 |
| nadya | cdent: Chris, hi! are you working on aodh posgresql job? | 15:19 |
| *** julim has quit IRC | 15:27 | |
| *** julim has joined #openstack-ceilometer | 15:28 | |
| *** jruano has joined #openstack-ceilometer | 15:28 | |
| *** lexholden has joined #openstack-ceilometer | 15:30 | |
| cdent | nadya: not currently no, I did this just recently, which is related: https://review.openstack.org/#/c/207840/ | 15:33 |
| cdent | now that that has merged we can check experimental to get some (quite simple) devstack+<storage engine> tests | 15:33 |
| gordc | jd__: is the proposal to disable by default in L* and remove in M*? | 15:34 |
| nadya | cdent: cool, I have to do the same for Ceilometer, I believe I need only create a job template with postgresql backend, I hope everything should work | 15:35 |
| gordc | i'm not against that considering the default switched back in J*... i just think i need to send ML message | 15:35 |
| gordc | nadya: i hope so too.. will be great to gate against real sql | 15:35 |
| cdent | nadya: I think the one non-obvious thing is the need to set DEVSTACK_GATE_POSTGRES=1 in gate_hook.sh if postgres is being used | 15:39 |
| cdent | gordc: you have state for the elasticsearch thing I pointed at, I'm getting ready to be done for the day and just want to confirm that somebody/something is thinking about it or if not, remind myself to think about it later | 15:41 |
| gordc | i asked yurii to reconfirm as well... i can't reproduce | 15:43 |
| gordc | i don't have a clean machine for kilo though | 15:44 |
| cdent | thanks gordc | 15:44 |
| *** cdent has quit IRC | 15:46 | |
| nadya | cdent: looks like it should be done in post_test_hook, we don't have gate_hook for Ceilo yet... | 15:46 |
| *** changbl has quit IRC | 15:47 | |
| *** changbl has joined #openstack-ceilometer | 15:50 | |
| *** openstackgerrit_ has joined #openstack-ceilometer | 16:08 | |
| openstackgerrit | Nadya Shakhat proposed openstack/ceilometer: Make it possible to run postgesql functional job https://review.openstack.org/211651 | 16:09 |
| *** ddieterl_ has joined #openstack-ceilometer | 16:11 | |
| *** _cjones_ has joined #openstack-ceilometer | 16:12 | |
| *** ddieterly has quit IRC | 16:14 | |
| *** ankita_wagh has joined #openstack-ceilometer | 16:19 | |
| openstackgerrit | gordon chung proposed openstack/ceilometer: add poll history to avoid duplicate samples https://review.openstack.org/209160 | 16:19 |
| *** ig0r_ has joined #openstack-ceilometer | 16:20 | |
| jd__ | gordc: I'd say so | 16:22 |
| openstackgerrit | Julien Danjou proposed openstack/aodh: storage: remove unused option db2nosql_resource_id_maxlen https://review.openstack.org/211657 | 16:27 |
| *** thumpba has quit IRC | 16:27 | |
| *** thumpba has joined #openstack-ceilometer | 16:28 | |
| *** jasonamyers has quit IRC | 16:34 | |
| gordc | jd__: kk, let me craft up an email. | 16:34 |
| openstackgerrit | Julien Danjou proposed openstack/aodh: api: move API options to their own api group https://review.openstack.org/211660 | 16:36 |
| *** ildikov has quit IRC | 16:37 | |
| *** nadya has quit IRC | 16:39 | |
| openstackgerrit | Julien Danjou proposed openstack/aodh: service: stop supporting deprecated group for auth option https://review.openstack.org/211661 | 16:39 |
| *** htruta has quit IRC | 16:41 | |
| *** htruta has joined #openstack-ceilometer | 16:43 | |
| *** htruta has quit IRC | 16:44 | |
| openstackgerrit | Julien Danjou proposed openstack/aodh: storage: remove mongodb_replica_set option https://review.openstack.org/211665 | 16:47 |
| *** ig0r_ has quit IRC | 16:48 | |
| *** htruta has joined #openstack-ceilometer | 16:55 | |
| *** ankita_wagh has quit IRC | 16:56 | |
| openstackgerrit | Julien Danjou proposed openstack/aodh: api: move API options to their own api group https://review.openstack.org/211660 | 17:00 |
| *** lexholden has quit IRC | 17:11 | |
| *** jruano has quit IRC | 17:16 | |
| openstackgerrit | Pradeep Kilambi proposed openstack/ceilometer: support multiple-meter payloads https://review.openstack.org/210512 | 17:18 |
| openstackgerrit | Pradeep Kilambi proposed openstack/ceilometer: Convert instance, bandwidth and SwiftMiddleware meters https://review.openstack.org/209637 | 17:18 |
| *** thumpba has quit IRC | 17:22 | |
| *** jfluhmann has joined #openstack-ceilometer | 17:23 | |
| *** ankita_wagh has joined #openstack-ceilometer | 17:28 | |
| *** jwcroppe has joined #openstack-ceilometer | 17:30 | |
| *** boris-42 has joined #openstack-ceilometer | 17:32 | |
| *** ildikov has joined #openstack-ceilometer | 17:46 | |
| *** harlowja has quit IRC | 17:51 | |
| *** harlowja has joined #openstack-ceilometer | 17:54 | |
| *** htruta_ has joined #openstack-ceilometer | 18:02 | |
| *** lexholden has joined #openstack-ceilometer | 18:05 | |
| *** openstackgerrit_ has quit IRC | 18:06 | |
| *** dikonoo has quit IRC | 18:10 | |
| openstackgerrit | Pradeep Kilambi proposed openstack/ceilometer: Add support to compute cpu meters in yaml https://review.openstack.org/210619 | 18:16 |
| *** ig0r_ has joined #openstack-ceilometer | 18:18 | |
| *** ig0r_ has quit IRC | 18:18 | |
| *** jruano has joined #openstack-ceilometer | 18:22 | |
| *** htruta_ has quit IRC | 18:24 | |
| openstackgerrit | Pradeep Kilambi proposed openstack/ceilometer: Add support to compute cpu meters in yaml https://review.openstack.org/210619 | 18:25 |
| *** ig0r_ has joined #openstack-ceilometer | 18:28 | |
| *** exploreshaifali has joined #openstack-ceilometer | 18:32 | |
| openstackgerrit | gordon chung proposed openstack/ceilometer: start rpc deprecation https://review.openstack.org/211304 | 18:44 |
| *** annasort has joined #openstack-ceilometer | 18:45 | |
| *** ddieterl_ has quit IRC | 18:48 | |
| *** jfluhmann has quit IRC | 18:51 | |
| *** rjaiswal has joined #openstack-ceilometer | 18:53 | |
| *** ig0r_ has quit IRC | 18:59 | |
| *** ig0r_ has joined #openstack-ceilometer | 19:05 | |
| *** jruano has quit IRC | 19:06 | |
| *** exploreshaifali has quit IRC | 19:13 | |
| *** eglynn has quit IRC | 19:18 | |
| *** eglynn has joined #openstack-ceilometer | 19:18 | |
| openstackgerrit | Pradeep Kilambi proposed openstack/ceilometer: Add support to compute cpu meters in yaml https://review.openstack.org/210619 | 19:21 |
| *** alejandrito has joined #openstack-ceilometer | 19:24 | |
| *** eglynn has quit IRC | 19:25 | |
| *** nadya has joined #openstack-ceilometer | 19:28 | |
| *** ankita_wagh has quit IRC | 19:37 | |
| *** gordc has quit IRC | 19:37 | |
| *** ddieterly has joined #openstack-ceilometer | 19:40 | |
| *** gordc has joined #openstack-ceilometer | 19:42 | |
| *** jkraj has quit IRC | 19:43 | |
| *** ig0r_ has quit IRC | 19:58 | |
| *** nadya has quit IRC | 20:02 | |
| *** ig0r_ has joined #openstack-ceilometer | 20:08 | |
| *** fawadkhaliq has quit IRC | 20:10 | |
| *** hongbin has joined #openstack-ceilometer | 20:22 | |
| *** nadya has joined #openstack-ceilometer | 20:42 | |
| *** nadya has quit IRC | 20:43 | |
| *** jruano has joined #openstack-ceilometer | 20:48 | |
| *** jruano has quit IRC | 20:54 | |
| *** ig0r_ has quit IRC | 20:58 | |
| *** ankita_wagh has joined #openstack-ceilometer | 21:00 | |
| *** julim has quit IRC | 21:00 | |
| *** ddieterly has quit IRC | 21:04 | |
| *** thorst1 has quit IRC | 21:05 | |
| *** pradk has quit IRC | 21:16 | |
| *** liusheng has quit IRC | 21:25 | |
| *** liusheng has joined #openstack-ceilometer | 21:26 | |
| *** rbak has quit IRC | 21:34 | |
| *** alejandrito has quit IRC | 21:41 | |
| *** ildikov has quit IRC | 21:51 | |
| *** hongbin has left #openstack-ceilometer | 22:01 | |
| *** ildikov has joined #openstack-ceilometer | 22:06 | |
| *** yassine__ has quit IRC | 22:08 | |
| *** jruano has joined #openstack-ceilometer | 22:09 | |
| *** r-daneel has quit IRC | 22:12 | |
| *** edmondsw has quit IRC | 22:17 | |
| rjaiswal | Hi gordc | 22:18 |
| rjaiswal | gordc: https://bugs.launchpad.net/ceilometer/+bug/1482797 seems to impact multi-publisher isolation cases, not sure how we can have both - event ack/requeue and keeping publisher isolated at same time | 22:21 |
| openstack | Launchpad bug 1482797 in Ceilometer "Event not requeued or ack'ed on event persistence failure" [Undecided,Triaged] - Assigned to Rohit Jaiswal (rohit-jaiswal-3) | 22:21 |
| gordc | rjaiswal: is this only for direct publisher? | 22:24 |
| gordc | i should mention that publisher is mainly for testing | 22:25 |
| rjaiswal | gordc: Fixing https://bugs.launchpad.net/ceilometer/+bug/1482797 will break the pipeline | 22:26 |
| openstack | Launchpad bug 1482797 in Ceilometer "Event not requeued or ack'ed on event persistence failure" [Undecided,Triaged] - Assigned to Rohit Jaiswal (rohit-jaiswal-3) | 22:26 |
| rjaiswal | i think, for the requeue to happen | 22:26 |
| rjaiswal | It could be any publisher, the exception is not raised in the EventSink | 22:28 |
| gordc | rjaiswal: but it's raised for samplesink? | 22:29 |
| rjaiswal | gordc: no, but there isnt any requeueing for samples, i think | 22:30 |
| rjaiswal | event has a flag ack_on_event_error, which when False leads to requeueing | 22:33 |
| gordc | right. so i think the main reason for the requeue there is to catch that conversion done by event_converter works. if not, then requeue. | 22:35 |
| gordc | after that, once it's built a meter, i don't know if it makes sense to requeue because there are so many intermediate steps... | 22:36 |
| gordc | i'm going to head home but could you clarify how if you fix it, the pipeline breaks? | 22:36 |
| rjaiswal | what if the event persistence fails | 22:36 |
| rjaiswal | ok | 22:36 |
| rjaiswal | theres a unit test in test_event_pipeline: test_multiple_publisher_isolation thats failing | 22:37 |
| gordc | event persistence shouldn't be handled by notification agent... the direct publisher is just a side effect of old behvaiour. | 22:37 |
| *** jwcroppe has quit IRC | 22:38 | |
| rjaiswal | oh ok, the option here https://github.com/openstack/ceilometer/blob/master/ceilometer/notification.py#L37 | 22:38 |
| rjaiswal | np, we can chat later | 22:38 |
| gordc | i'll need to dig into it... will sync up with you later | 22:39 |
| gordc | ttyl | 22:40 |
| rjaiswal | np, thanks | 22:40 |
| rjaiswal | sure | 22:40 |
| *** gordc has quit IRC | 22:40 | |
| *** jruano has quit IRC | 22:54 | |
| *** ildikov has quit IRC | 22:58 | |
| *** jwcroppe has joined #openstack-ceilometer | 23:08 | |
| *** jwcroppe has quit IRC | 23:10 | |
| *** ildikov has joined #openstack-ceilometer | 23:11 | |
| *** jwcroppe has joined #openstack-ceilometer | 23:11 | |
| openstackgerrit | Rohit Jaiswal proposed openstack/ceilometer: Fixed event requeuing/ack on publisher failure https://review.openstack.org/211779 | 23:14 |
| *** jwcroppe has quit IRC | 23:15 | |
| openstackgerrit | Rohit Jaiswal proposed openstack/aodh: Fixes querying alarm history with severity field https://review.openstack.org/200315 | 23:23 |
| *** jruano has joined #openstack-ceilometer | 23:40 | |
| *** alejandrito has joined #openstack-ceilometer | 23:57 | |
| *** david-lyle has quit IRC | 23:58 | |
| *** david-lyle has joined #openstack-ceilometer | 23:58 | |
| *** thumpba has joined #openstack-ceilometer | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!