| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-identity master: Fixes to support fog-openstack-1.x https://review.opendev.org/665827 | 00:02 |
|---|---|---|
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-identity master: Fixes to support fog-openstack-1.x https://review.opendev.org/665827 | 00:34 |
| Ramereth | i'm a little confused how to get my openstack/cookbook-openstack-identity PR to pass with the dependencies. Any help would be great! | 00:54 |
| Ramereth | At least openstack-chef passed:) | 00:54 |
| *** higgins has quit IRC | 01:30 | |
| *** higgins has joined #openstack-chef | 01:38 | |
| *** irclogbot_1 has quit IRC | 05:30 | |
| *** irclogbot_3 has joined #openstack-chef | 05:30 | |
| *** mutin-s has quit IRC | 09:18 | |
| *** mutin-s has joined #openstack-chef | 09:19 | |
| calbers | Ramereth: great job! openstack-chef lonely passes is expected since there are all the dependencies that should've changed depending on your fog-openstack fix chain. I'll try contruct a merge order if possible. Otherwise we have to merge everything even if they fail until openstack-chef can be merged at last :) | 10:18 |
| Ramereth | calbers: thanks! | 15:27 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstackclient master: Fixes to support fog-openstack-1.x https://review.opendev.org/665826 | 15:32 |
| Ramereth | calbers: isn't adding that dep going to create a circular dep loop in zuul? | 15:38 |
| calbers | Ramereth: i don't think so, but if we have to remove the dependencies on openstack-chef. We have to add it also in all the other cookbooks | 15:42 |
| Ramereth | true. I think part of the problem I'm having is the direction of the dep as I feel like I'm doing it backwards | 15:43 |
| calbers | Ramereth: the depends on in openstack-chef just aproved that all patches work fine, the merge process will be in the other direction 'on-by-one' | 15:43 |
| calbers | true is like deriving the hole tree by hand | 15:44 |
| Ramereth | what does gerrit/zuul do if two changes are both depend on each other? from what I can tell, it never kicks off a test run | 15:47 |
| calbers | ok, i guess then its fail/loop prove, then lets kick out the hole dependencies of openstack-chef and give it a recheck :D | 15:48 |
| Ramereth | I know that will fail as I kicked it off w/o any deps | 15:49 |
| calbers | sure, but the client cookbook will proly succeed imo | 15:49 |
| calbers | then we'll have to also depend in identity on openstack-chef and so on | 15:50 |
| Ramereth | I think what needs to happen is I need to do it in reverse order. i.e. 1) remove deps from everything 2) have openstack-integration-test dep on everything, that should succeed and then merge. 3) do bare-metal next, etc etc | 15:50 |
| Ramereth | or should I chain the deps? client -> identity -> image, etc? | 15:50 |
| Ramereth | or rather the reverse? | 15:51 |
| * Ramereth is so confused | 15:51 | |
| Ramereth | the trouble is because of the run list order and how this impacts nearly every cookbook in the integration test | 15:51 |
| calbers | no your first approach is correct, but leave it in all except for openstack-chef | 15:51 |
| calbers | these deps seem to be nearly perfect :) | 15:52 |
| Ramereth | to clarify, what is correct and what should I change? | 15:52 |
| calbers | remove deps of openstack-chef, add openstack-chef as dep to all the others. next steps will follow since i haven't done such a merge chain in a while | 15:53 |
| Ramereth | basically, openstack-chef will need to be merged last so it's ok to remove those deps since we can rerun it after the others are merged? | 15:54 |
| calbers | correct! if we're lucky jklare will show up and say some words | 15:54 |
| calbers | but i think we are on the right direction | 15:55 |
| Ramereth | alright, I'll give it a go | 15:56 |
| Ramereth | thanks for your help | 15:56 |
| calbers | your welcome i really appreciate your work! our team will start, as you proly heard of jklare, soon on rocky and stein :) | 16:00 |
| openstackgerrit | Lance Albertson proposed openstack/openstack-chef master: Install and use Chef Client instead of ChefDK on integration tests https://review.opendev.org/666176 | 16:03 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstackclient master: Fixes to support fog-openstack-1.x https://review.opendev.org/665826 | 16:14 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-identity master: Fixes to support fog-openstack-1.x https://review.opendev.org/665827 | 16:16 |
| * Ramereth just discovered https://zuul.openstack.org/status | 16:19 | |
| Ramereth | looks like using the newer chefdk is running into this: https://github.com/sous-chefs/apache2/issues/588. I'll push the version back to something that doesn't include that version of chefspec | 16:45 |
| openstackgerrit | Lance Albertson proposed openstack/openstack-chef master: Install and use Chef Client instead of ChefDK on integration tests https://review.opendev.org/666176 | 16:56 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-identity master: Fixes to support fog-openstack-1.x https://review.opendev.org/665827 | 16:57 |
| openstackgerrit | Lance Albertson proposed openstack/openstack-chef master: Install and use Chef Client instead of ChefDK on integration tests https://review.opendev.org/666176 | 17:10 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-identity master: Fixes to support fog-openstack-1.x https://review.opendev.org/665827 | 17:12 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-image master: Fixes to support fog-openstack-1.x https://review.opendev.org/666182 | 17:13 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-network master: Fixes to support fog-openstack-1.x https://review.opendev.org/666183 | 17:13 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-compute master: Fixes to support fog-openstack-1.x https://review.opendev.org/666184 | 17:13 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-bare-metal master: Fixes to support fog-openstack-1.x https://review.opendev.org/666185 | 17:14 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-integration-test master: Fixes to support fog-openstack-1.x https://review.opendev.org/666188 | 17:14 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstackclient master: Fixes to support fog-openstack-1.x https://review.opendev.org/665826 | 17:15 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-block-storage master: Fixes to support fog-openstack-1.x https://review.opendev.org/666189 | 17:16 |
| Ramereth | sorry for the "spam" here.. I was fixing some deps. I *think* openstack/cookbook-openstackclient should pass this time | 17:17 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-bare-metal master: Fixes to support fog-openstack-1.x https://review.opendev.org/666185 | 17:29 |
| calbers | no worries :) | 17:46 |
| Ramereth | looks like I forgot to update the unit tests in some of those. grr | 17:53 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-image master: Fixes to support fog-openstack-1.x https://review.opendev.org/666182 | 17:57 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-network master: Fixes to support fog-openstack-1.x https://review.opendev.org/666183 | 17:58 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-compute master: Fixes to support fog-openstack-1.x https://review.opendev.org/666184 | 17:59 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-block-storage master: Fixes to support fog-openstack-1.x https://review.opendev.org/666189 | 18:00 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstackclient master: Fixes to support fog-openstack-1.x https://review.opendev.org/665826 | 18:14 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstackclient master: Fixes to support fog-openstack-1.x https://review.opendev.org/665826 | 18:25 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-identity master: Fixes to support fog-openstack-1.x https://review.opendev.org/665827 | 19:06 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstack-identity master: Fixes to support fog-openstack-1.x https://review.opendev.org/665827 | 19:07 |
| openstackgerrit | Lance Albertson proposed openstack/cookbook-openstackclient master: Fixes to support fog-openstack-1.x https://review.opendev.org/665826 | 19:07 |
| Ramereth | calbers frickler jklare: would love a review on this now that it passed: https://review.opendev.org/#/c/665826/ | 20:14 |
| Ramereth | after that's merged, I can then work on the other dependant PR's | 20:15 |
| *** mutin-s has quit IRC | 21:21 | |
| *** mutin-s has joined #openstack-chef | 21:21 | |
| *** asidorenko has quit IRC | 21:53 | |
| *** asidorenko has joined #openstack-chef | 21:54 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!