*** asidorenko has quit IRC | 03:17 | |
*** mutin-s has quit IRC | 08:39 | |
*** mutin-s has joined #openstack-chef | 08:39 | |
*** mutin-sa has joined #openstack-chef | 08:41 | |
*** mutin-s has quit IRC | 08:45 | |
*** mutin-sa has quit IRC | 08:45 | |
*** mutin-sa has joined #openstack-chef | 08:45 | |
*** mutin-sa has quit IRC | 09:26 | |
*** mutin-sa has joined #openstack-chef | 09:27 | |
*** asidorenko has joined #openstack-chef | 10:39 | |
*** asidorenko has quit IRC | 10:41 | |
*** asidorenko has joined #openstack-chef | 10:57 | |
openstackgerrit | Jan Klare proposed openstack/cookbook-openstackclient master: WIP: testpatch https://review.opendev.org/666559 | 12:56 |
---|---|---|
jklare | Ramereth i am currently reviewing your patch here https://review.opendev.org/#/c/665826/ but i do not understand why this is needed | 13:33 |
jklare | Ramereth do you have a link to a log or something with the error message or issue? | 13:34 |
jklare | i guess i do not really understand why we need these depends on | 13:42 |
openstackgerrit | Jan Klare proposed openstack/cookbook-openstackclient master: WIP: testpatch https://review.opendev.org/666559 | 13:46 |
jklare | Ramereth ok, i understand the patch in libraries/openstack_base.rb , but i think there is no need for any depends-on in this patch | 13:52 |
jklare | Ramereth i think i am getting closer to understanding the issue, but will have to get back on this tomorrow :) i think the main issue we want to solve here is the locked version of fog-openstack in chefdk | 14:12 |
jklare | but i also think there might be an easier way than to install chef ourselves | 14:13 |
jklare | i will try to put together a patch tomorrow | 14:13 |
Ramereth | jklare: how else would you install chef ourselves? | 15:29 |
Ramereth | IMHO we shouldn't be using chefdk for our integration tests because of the differences that get packaged in gems between that and installing chef stand alone if that's what you're referring to | 15:32 |
Ramereth | The depends-on isn't technically needed for the patch but to fix the integration job run which fails without everything being used | 15:33 |
Ramereth | The fog-openstack version lock issue didn't show up in our tests until we switched over to using chef proper. Also this better aligns with how these cookbooks get used in production | 15:34 |
Ramereth | it should hopefully catch issues like this more quickly in the future | 15:35 |
openstackgerrit | Lance Albertson proposed openstack/cookbook-openstackclient master: Fixes to support fog-openstack-1.x https://review.opendev.org/665826 | 15:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!