| *** lpetrut has quit IRC | 00:08 | |
| *** primechuck has quit IRC | 00:31 | |
| *** heyun has joined #openstack-cinder | 00:52 | |
| *** zhenguo has joined #openstack-cinder | 00:54 | |
| *** primechuck has joined #openstack-cinder | 01:24 | |
| *** mriedem has quit IRC | 01:26 | |
| *** jungleboyj has joined #openstack-cinder | 01:31 | |
| *** Yogi1 has joined #openstack-cinder | 01:34 | |
| *** julim has quit IRC | 01:47 | |
| *** julim has joined #openstack-cinder | 01:48 | |
| *** Lee1092 has joined #openstack-cinder | 01:48 | |
| *** julim has quit IRC | 01:48 | |
| *** vilobhmm1 has joined #openstack-cinder | 01:56 | |
| *** vilobhmm1 has quit IRC | 02:13 | |
| *** vilobhmm1 has joined #openstack-cinder | 02:14 | |
| *** vilobhmm1 has quit IRC | 02:14 | |
| *** vilobhmm1 has joined #openstack-cinder | 02:14 | |
| *** annashen has joined #openstack-cinder | 02:16 | |
| openstackgerrit | Jeegn Chen proposed openstack/cinder: Make VNX Cinder Driver aware of VNX Pool Full Threshold https://review.openstack.org/175247 | 02:21 |
|---|---|---|
| *** annashen has quit IRC | 02:38 | |
| *** davechen has joined #openstack-cinder | 02:38 | |
| *** kfox1111 has quit IRC | 02:39 | |
| *** vilobhmm1 has quit IRC | 02:39 | |
| *** davechen1 has joined #openstack-cinder | 02:44 | |
| *** davechen2 has joined #openstack-cinder | 02:46 | |
| *** davechen has quit IRC | 02:46 | |
| *** davechen1 has quit IRC | 02:48 | |
| *** Yogi1 has quit IRC | 02:49 | |
| openstackgerrit | QiangGuan proposed openstack/cinder: Fix NoneType AttributeError problem https://review.openstack.org/175249 | 02:52 |
| *** david-lyle has quit IRC | 02:55 | |
| *** annashen has joined #openstack-cinder | 02:57 | |
| *** annashen has quit IRC | 02:57 | |
| *** jamielennox is now known as jamielennox|away | 02:58 | |
| *** jamielennox|away is now known as jamielennox | 03:03 | |
| *** annashen has joined #openstack-cinder | 03:15 | |
| *** annashen has quit IRC | 03:20 | |
| *** annashen has joined #openstack-cinder | 03:21 | |
| *** annashen has quit IRC | 03:22 | |
| *** annashen has joined #openstack-cinder | 03:23 | |
| *** annashen has quit IRC | 03:27 | |
| *** coolsvap|afk is now known as coolsvap | 03:39 | |
| *** vilobhmm1 has joined #openstack-cinder | 03:54 | |
| *** ishant has joined #openstack-cinder | 04:04 | |
| *** rushiagr_away is now known as rushiagr | 04:20 | |
| *** annashen has joined #openstack-cinder | 04:31 | |
| *** aswadr has joined #openstack-cinder | 04:32 | |
| *** Longgeek has joined #openstack-cinder | 04:35 | |
| *** Longgeek has quit IRC | 04:35 | |
| *** Longgeek has joined #openstack-cinder | 04:36 | |
| *** BharatK has joined #openstack-cinder | 04:43 | |
| *** sks has joined #openstack-cinder | 04:48 | |
| *** tshefi has joined #openstack-cinder | 04:48 | |
| *** btran has joined #openstack-cinder | 04:50 | |
| *** annashen has quit IRC | 04:50 | |
| *** annashen has joined #openstack-cinder | 04:51 | |
| *** annashen has quit IRC | 04:56 | |
| *** boris-42 has quit IRC | 04:58 | |
| *** annashen has joined #openstack-cinder | 04:59 | |
| *** sgotliv has joined #openstack-cinder | 05:05 | |
| *** deepakcs has joined #openstack-cinder | 05:10 | |
| *** ishant has quit IRC | 05:13 | |
| *** nlevinki has joined #openstack-cinder | 05:14 | |
| *** nkrinner has joined #openstack-cinder | 05:23 | |
| *** ishant has joined #openstack-cinder | 05:38 | |
| *** annashen has quit IRC | 06:01 | |
| *** annashen has joined #openstack-cinder | 06:03 | |
| *** ankit_ag has joined #openstack-cinder | 06:04 | |
| *** afazekas_ has joined #openstack-cinder | 06:10 | |
| *** annashen has quit IRC | 06:12 | |
| *** anshul has joined #openstack-cinder | 06:14 | |
| *** annashen has joined #openstack-cinder | 06:14 | |
| *** annashen has quit IRC | 06:16 | |
| *** annashen has joined #openstack-cinder | 06:16 | |
| *** annashen has quit IRC | 06:20 | |
| *** anshul has quit IRC | 06:27 | |
| *** sgotliv has quit IRC | 06:28 | |
| *** annashen has joined #openstack-cinder | 06:39 | |
| *** anshul has joined #openstack-cinder | 06:40 | |
| *** lpetrut has joined #openstack-cinder | 06:44 | |
| *** anshul has quit IRC | 06:50 | |
| *** jamielennox is now known as jamielennox|away | 06:52 | |
| *** annashen has quit IRC | 07:02 | |
| *** anshul has joined #openstack-cinder | 07:04 | |
| *** ociuhandu has joined #openstack-cinder | 07:27 | |
| *** chlong has quit IRC | 07:29 | |
| *** e0ne has joined #openstack-cinder | 07:31 | |
| *** bkopilov has quit IRC | 07:32 | |
| *** bkopilov has joined #openstack-cinder | 07:32 | |
| *** e0ne has quit IRC | 07:34 | |
| *** e0ne has joined #openstack-cinder | 07:38 | |
| *** vilobhmm1 has quit IRC | 07:39 | |
| *** e0ne has quit IRC | 07:40 | |
| openstackgerrit | wanghao proposed openstack/cinder-specs: Support query volume filter by glance metadata https://review.openstack.org/174778 | 07:41 |
| *** kaisers has joined #openstack-cinder | 07:42 | |
| openstackgerrit | wanghao proposed openstack/cinder-specs: Support query volume filter by glance metadata https://review.openstack.org/174778 | 07:43 |
| *** ociuhandu has quit IRC | 07:45 | |
| *** pschaef has joined #openstack-cinder | 07:45 | |
| *** e0ne has joined #openstack-cinder | 07:45 | |
| *** wanghao has joined #openstack-cinder | 07:46 | |
| *** jistr has joined #openstack-cinder | 07:47 | |
| wanghao | hi~ guys, there is a bug in nova side: https://review.openstack.org/#/c/147042/. But it may need some suggestion came from cinder. Is anyone can help me with this? | 07:50 |
| *** sgotliv has joined #openstack-cinder | 07:51 | |
| wanghao | https://www.irccloud.com/pastebin/9pmFpEkD | 07:51 |
| wanghao | Nova can't detach volume in init host routine | 07:51 |
| wanghao | Scenario: | 07:51 |
| wanghao | 1. create a vm using bootable volume. | 07:51 |
| wanghao | 2. delete this vm | 07:51 |
| wanghao | 3. restart service nova-compute when vm's task state is deleting. | 07:51 |
| wanghao | When nova-compute is up, vm became deleted successful, but the bootable | 07:51 |
| wanghao | volume is still in-use state and can't delete it using cinder delete volume. | 07:51 |
| wanghao | solve method: | 07:51 |
| wanghao | Add init=True in _delete_instance when init_host, and raise exception | 07:51 |
| wanghao | when EndpointNotFound exists. It will set vm's status to error and | 07:51 |
| wanghao | make user can re-issue a delete. | 07:51 |
| wanghao | Some detail about this bug. | 07:52 |
| *** annashen has joined #openstack-cinder | 08:03 | |
| *** jordanP has joined #openstack-cinder | 08:04 | |
| *** e0ne has quit IRC | 08:04 | |
| *** e0ne has joined #openstack-cinder | 08:08 | |
| *** annashen has quit IRC | 08:08 | |
| *** e0ne is now known as e0ne_ | 08:09 | |
| *** e0ne_ is now known as e0ne | 08:11 | |
| *** e0ne has quit IRC | 08:17 | |
| openstackgerrit | Tina Tang proposed openstack/cinder: Create consistgroup from cgsnapshot support in VNX driver https://review.openstack.org/163706 | 08:23 |
| *** ndipanov has joined #openstack-cinder | 08:28 | |
| deepakcs | wanghao, so why can't nova init_host re-issue a delete if the instance state is 'deleting' instead of raising excp as you suggest ? | 08:30 |
| *** pschaef has quit IRC | 08:30 | |
| *** pschaef has joined #openstack-cinder | 08:31 | |
| deepakcs | wanghao, or mark instance as 'error' during init_host itself if state is 'deleting'. When do we get EndpointNotFound excp ? | 08:31 |
| *** anshul has quit IRC | 08:32 | |
| *** anshul has joined #openstack-cinder | 08:46 | |
| *** Yogi1 has joined #openstack-cinder | 08:50 | |
| *** alecv has joined #openstack-cinder | 08:50 | |
| *** chlong has joined #openstack-cinder | 08:50 | |
| *** kbyrne has joined #openstack-cinder | 08:54 | |
| *** Yogi1 has quit IRC | 08:54 | |
| *** e0ne has joined #openstack-cinder | 08:59 | |
| *** annashen has joined #openstack-cinder | 09:04 | |
| *** annashen has quit IRC | 09:09 | |
| wanghao | @deepakcs: Before this patch, When nova get EndpointNotFound excp in init_host routine, it delete vm successful in nova side and just log a message about this exception. But in cinder side, this bootable volume still is in-use and can't detach it by user. | 09:13 |
| *** e0ne is now known as e0ne_ | 09:13 | |
| *** e0ne_ is now known as e0ne | 09:13 | |
| deepakcs | wanghao, whats the VM state after u restart n-cpu ? I am trying to understand the problem first, not clear to me | 09:15 |
| openstackgerrit | Bharat Kumar Kobagana proposed openstack/cinder: GlusterFS: Support over subscription in thin provisioning https://review.openstack.org/162718 | 09:17 |
| *** alexpilotti has joined #openstack-cinder | 09:17 | |
| wanghao | Before restart n-cpu, VM state is deleting, After restart, it is deleted. But when init_host in restart process, nova use context.get_admin_context to obtain context using it to send message to cinder. The context don't have auth_token, so when call terminate_connection to cinder , it will fail. | 09:19 |
| *** chlong has quit IRC | 09:20 | |
| wanghao | But in nova side, it just log a message about this exception, and go on with deleting vm successful. | 09:20 |
| wanghao | So, that's why VM is deleted after restart n-cpu. | 09:21 |
| *** kaisers has quit IRC | 09:22 | |
| *** pcaruana has quit IRC | 09:27 | |
| *** ishant has quit IRC | 09:28 | |
| *** nlevinki_ has joined #openstack-cinder | 09:29 | |
| *** zerda has joined #openstack-cinder | 09:29 | |
| *** pcaruana has joined #openstack-cinder | 09:30 | |
| *** nlevinki has quit IRC | 09:33 | |
| *** chlong has joined #openstack-cinder | 09:33 | |
| *** lpetrut has quit IRC | 09:33 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder-specs: Checking the existence of volume https://review.openstack.org/174823 | 09:39 |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Add missing backups entry to default quota class https://review.openstack.org/174941 | 09:44 |
| *** primechuck has quit IRC | 09:47 | |
| *** davechen2 has left #openstack-cinder | 09:50 | |
| *** coolsvap is now known as coolsvap|afk | 09:51 | |
| *** boris-42 has joined #openstack-cinder | 09:51 | |
| openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 09:54 |
| *** aix has joined #openstack-cinder | 10:01 | |
| *** haomaiwa_ has quit IRC | 10:03 | |
| *** haomaiwa_ has joined #openstack-cinder | 10:04 | |
| *** kaisers has joined #openstack-cinder | 10:05 | |
| *** haomaiwa_ has quit IRC | 10:09 | |
| *** kaisers has quit IRC | 10:14 | |
| *** lpetrut has joined #openstack-cinder | 10:16 | |
| *** kaisers has joined #openstack-cinder | 10:18 | |
| *** haomaiwang has joined #openstack-cinder | 10:18 | |
| *** heyun has quit IRC | 10:18 | |
| *** nlevinki_ has quit IRC | 10:25 | |
| *** nlevinki has joined #openstack-cinder | 10:26 | |
| *** IanGovett has joined #openstack-cinder | 10:28 | |
| *** kaisers has quit IRC | 10:34 | |
| *** rushiagr is now known as rushiagr_away | 10:38 | |
| *** anshul has quit IRC | 10:42 | |
| *** zerda has quit IRC | 10:53 | |
| *** anshul has joined #openstack-cinder | 10:55 | |
| *** e0ne is now known as e0ne_ | 10:56 | |
| *** e0ne_ is now known as e0ne | 10:58 | |
| *** sgotliv_ has joined #openstack-cinder | 11:05 | |
| *** sgotliv has quit IRC | 11:05 | |
| *** anshul has quit IRC | 11:14 | |
| *** e0ne is now known as e0ne_ | 11:16 | |
| *** astellwa1 has joined #openstack-cinder | 11:23 | |
| *** astellwa1 has quit IRC | 11:23 | |
| *** afazekas_ has quit IRC | 11:24 | |
| *** e0ne_ has quit IRC | 11:26 | |
| *** TobiasE has joined #openstack-cinder | 11:26 | |
| *** anshul has joined #openstack-cinder | 11:27 | |
| *** nlevinki_ has joined #openstack-cinder | 11:28 | |
| *** afazekas_ has joined #openstack-cinder | 11:28 | |
| *** nlevinki has quit IRC | 11:30 | |
| *** akerr has joined #openstack-cinder | 11:51 | |
| *** deepakcs has quit IRC | 11:51 | |
| *** jistr has quit IRC | 11:57 | |
| *** chlong has quit IRC | 11:58 | |
| *** afazekas_ has quit IRC | 11:58 | |
| *** kaisers has joined #openstack-cinder | 11:59 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** jistr has joined #openstack-cinder | 12:03 | |
| *** zhenguo has quit IRC | 12:07 | |
| *** bswartz has quit IRC | 12:08 | |
| *** kaisers has quit IRC | 12:10 | |
| *** nlevinki_ has quit IRC | 12:10 | |
| *** ronis has joined #openstack-cinder | 12:11 | |
| *** lpetrut has quit IRC | 12:13 | |
| *** lpetrut has joined #openstack-cinder | 12:15 | |
| *** nlevinki_ has joined #openstack-cinder | 12:23 | |
| *** e0ne has joined #openstack-cinder | 12:26 | |
| *** timcl has joined #openstack-cinder | 12:30 | |
| *** jamielennox|away is now known as jamielennox | 12:31 | |
| *** jamielennox is now known as jamielennox|away | 12:32 | |
| *** jaypipes has joined #openstack-cinder | 12:33 | |
| *** erlon has joined #openstack-cinder | 12:34 | |
| e0ne | DuncanT: hi! should i add A/A HA issue description to the etherpad only or file a bug too? | 12:36 |
| *** BharatK has quit IRC | 12:36 | |
| DuncanT | e0ne: The etherpad for now, please. It'll get turned to bugs once there's some agreement that we've got a good set | 12:42 |
| DuncanT | e0ne: https://etherpad.openstack.org/p/cinder-active-active-vol-service-issues | 12:43 |
| e0ne | DuncanT: ok, thanks | 12:43 |
| aarefiev | DuncanT: hi, have a min? | 12:45 |
| DuncanT | aarefiev: Sure | 12:46 |
| aarefiev | DuncanT: have a question about options for quotas | 12:46 |
| DuncanT | aarefiev: shoot | 12:46 |
| aarefiev | DuncanT: I don't see where it is deprecated | 12:47 |
| DuncanT | give me a minute | 12:47 |
| aarefiev | DuncanT: or you mean it will i L | 12:47 |
| aarefiev | *in L | 12:47 |
| DuncanT | I thought it had been marked depricated some time ago, give me a minute | 12:47 |
| DuncanT | Hmmm, there was a comment about it, which has since been lost, and it looks like the CFG options were never marked depricated :-( | 12:51 |
| DuncanT | Ok, I'll remove the -1 and knock up a patch to mark them as depricated | 12:52 |
| DuncanT | We meant to move to setting all the quotas in the db ages ago, looks like that work never got finished :-( | 12:52 |
| *** esker has quit IRC | 12:52 | |
| aarefiev | DuncanT: ok thaks, where do you propose to store default values for quotas? | 12:53 |
| DuncanT | db | 12:53 |
| DuncanT | The initial defaults I'm not sure about TBH | 12:54 |
| DuncanT | If there's no default in the db then coping them in from the conf file, like you did, is the right thing to do | 12:54 |
| DuncanT | I'm just not sure what those migrations should do once the config files have been removed | 12:55 |
| DuncanT | Probably hard-code the values in the migration? | 12:55 |
| e0ne | DuncanT: +1, hardcode current values from config | 12:55 |
| DuncanT | It'll be a job for whomever does the deprications now anyway | 12:55 |
| *** bswartz has joined #openstack-cinder | 12:55 | |
| DuncanT | e0ne: Thanks | 12:55 |
| e0ne | and add this to the release notes | 12:55 |
| DuncanT | Even if we depricate them now, we can't remove them until M, right? | 12:56 |
| e0ne | yes:( | 12:56 |
| *** mwichmann has joined #openstack-cinder | 12:56 | |
| aarefiev | and we have a few migration with this options | 12:57 |
| *** mwichmann has left #openstack-cinder | 12:57 | |
| aarefiev | 21 and 26 | 12:58 |
| smcginnis | DuncanT: Still free? Got time to give your opinion on something? | 13:00 |
| *** Yogi1 has joined #openstack-cinder | 13:00 | |
| *** pschaef has quit IRC | 13:00 | |
| *** sks has quit IRC | 13:02 | |
| *** lifeless has quit IRC | 13:05 | |
| *** annashen has joined #openstack-cinder | 13:08 | |
| *** annashen has quit IRC | 13:13 | |
| *** nlevinki_ has quit IRC | 13:14 | |
| *** sks has joined #openstack-cinder | 13:16 | |
| jgriffith | smcginnis: Not sure what's up wit those gate failures yet. The one I have a patch up for, the others I can't reproduce | 13:19 |
| jgriffith | smcginnis: aha! Vincent figured it out (at least one of them indirectly) | 13:24 |
| jgriffith | smcginnis: so the added reference get from the db | 13:24 |
| smcginnis | jgriffith: Just saw his comment. | 13:26 |
| *** zerda has joined #openstack-cinder | 13:26 | |
| smcginnis | jgriffith: So between your patch and that, looks like that covers it? | 13:26 |
| jgriffith | smcginnis: maybe | 13:26 |
| jgriffith | smcginnis: the second has a bunch of failures I can't reproduce | 13:27 |
| smcginnis | jgriffith: I'll keep my fingers crossed. ;) | 13:27 |
| jgriffith | smcginnis: still trying to figure that one out | 13:27 |
| jgriffith | smcginnis: :) | 13:27 |
| *** bkopilov has quit IRC | 13:27 | |
| smcginnis | jgriffith: Yeah, nothing directly obvious in any of this to me. | 13:27 |
| smcginnis | jgriffith: Glad you were able to find something at least. | 13:27 |
| jgriffith | smcginnis: I can't take credit, it was Vincent who put the two together | 13:27 |
| smcginnis | jgriffith: He's not here right now so you can take all the credit. :D | 13:28 |
| e0ne | jgriffith: morning | 13:29 |
| *** crose has joined #openstack-cinder | 13:29 | |
| jgriffith | smcginnis: LOL | 13:29 |
| jgriffith | e0ne: hey there | 13:29 |
| e0ne | jgriffith: i didn't put -1 for https://review.openstack.org/#/c/175077/ but hope my question won't be ignored | 13:29 |
| jgriffith | e0ne: I could probably change that | 13:30 |
| smcginnis | e0ne: That is a good point. | 13:30 |
| jgriffith | e0ne: but... | 13:30 |
| jgriffith | e0ne: we're kinda stupid in what we're doing with those custom built dicts | 13:30 |
| jgriffith | e0ne: I'm of the opinion that if we pull a ref from the db in one layer we should pass the whole thing, not just the pieces we 'think' are important | 13:31 |
| jgriffith | arbitrarily | 13:31 |
| *** superdan is now known as dansmith | 13:31 | |
| jgriffith | e0ne: I can certainly remove those | 13:31 |
| e0ne | jgriffith: sounds reasonable to pass original objects throw all flows | 13:31 |
| jgriffith | e0ne: it's a valid concern... just use the "resource={'type': 'volume', 'id': volume_id} format | 13:31 |
| jgriffith | e0ne: yeah, but that should probably be follow up | 13:32 |
| jgriffith | e0ne: I'll respin those patches and remove the db get calls if that makes everybody "happier" | 13:32 |
| jgriffith | e0ne: frankly though I think we have some mistakes by not having the full reference | 13:33 |
| e0ne | jgriffith: ok. i'm vote +++ and many + for unifiing logging and make it better. but performance should be goog too | 13:33 |
| e0ne | s/goog/goog | 13:33 |
| jgriffith | e0ne: :) | 13:33 |
| e0ne | *good | 13:33 |
| jgriffith | e0ne: ok, thanks for the feedback | 13:33 |
| e0ne | jgriffith: thank you for understanging | 13:33 |
| * e0ne doesn't want to be a nerdy in reviews | 13:34 | |
| *** bkopilov has joined #openstack-cinder | 13:35 | |
| DuncanT | smcginnis: Sorry, was at standup. What do you want me to look at? | 13:35 |
| *** annegentle has joined #openstack-cinder | 13:35 | |
| *** jistr_ has joined #openstack-cinder | 13:35 | |
| e0ne | jgriffith: just 2c more: imo, moving to objects will help us to pass the same dicts over the code | 13:37 |
| jgriffith | e0ne: agreed | 13:37 |
| jgriffith | e0ne: trouble is the cinder.api.xxxx code is kinda of a mess | 13:37 |
| jgriffith | e0ne: that's where it's broken in most places | 13:38 |
| e0ne | :( | 13:38 |
| jgriffith | e0ne: that is the next section I want to tackle for logging, it's rather ugly | 13:38 |
| DuncanT | jgriffith: I'm a big fan of the logging standardisation, stuff, I looked at the review, couldn't see anything fundamental wrong but your spelling hurt | 13:38 |
| *** jistr has quit IRC | 13:38 | |
| jgriffith | DuncanT: haha! | 13:39 |
| *** jungleboyj has quit IRC | 13:39 | |
| jgriffith | DuncanT: so I did a bash search and replace at Mitsuhiro's point that I screwed up the spelling on successfull | 13:39 |
| e0ne | there are 2 areas of improvement that will be forever: logging and testing (unit, functional, tempest, etc) | 13:40 |
| jgriffith | DuncanT: but the regex was wrong and put an extra 's' inbetween | 13:40 |
| jgriffith | :( | 13:40 |
| DuncanT | lol | 13:40 |
| jgriffith | I didn't even look | 13:40 |
| jgriffith | automation is awesome!!! | 13:40 |
| *** esker has joined #openstack-cinder | 13:40 | |
| jgriffith | Great way to make the same mistake over and over and over and over | 13:40 |
| *** russellb has quit IRC | 13:40 | |
| *** bkopilov has quit IRC | 13:40 | |
| e0ne | https://xkcd.com/149/ - sudo make me a sandwich | 13:41 |
| e0ne | it's about automation:) | 13:41 |
| *** julim has joined #openstack-cinder | 13:41 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:42 | |
| *** ankit_ag has quit IRC | 13:42 | |
| *** sigmavirus24 has left #openstack-cinder | 13:42 | |
| *** bkopilov has joined #openstack-cinder | 13:42 | |
| DuncanT | jgriffith: http://www.latech.edu/tech/liberal-arts/geography/courses/spellchecker.htm | 13:42 |
| jgriffith | DuncanT: LOL! | 13:42 |
| *** jistr_ has quit IRC | 13:44 | |
| *** jistr has joined #openstack-cinder | 13:44 | |
| *** zhenguo has joined #openstack-cinder | 13:44 | |
| smcginnis | DuncanT: Sorry, now I was off getting coffee. | 13:45 |
| *** russellb has joined #openstack-cinder | 13:45 | |
| smcginnis | DuncanT: Was just wondering - I remembered you had agreed in a discussion earlier | 13:45 |
| smcginnis | DuncanT: about not using exact strings in unit tests. | 13:46 |
| smcginnis | DuncanT: So the question is the correct way to verify logging. | 13:46 |
| *** mriedem has joined #openstack-cinder | 13:46 | |
| DuncanT | smcginnis: That was specifically for log strings, I believe, but the principle can apply in many places | 13:46 |
| smcginnis | DuncanT: Wondering if you agree with my response on line 277 here: https://review.openstack.org/#/c/173368/3/cinder/tests/scheduler/test_host_manager.py | 13:46 |
| *** lpetrut has quit IRC | 13:47 | |
| DuncanT | smcginnis: I'll reply in the review, but I agree with you | 13:48 |
| *** lpetrut has joined #openstack-cinder | 13:48 | |
| *** bkopilov has quit IRC | 13:49 | |
| smcginnis | DuncanT: Cool, just wanted to get another opinion. Thanks! | 13:49 |
| *** eharney has joined #openstack-cinder | 13:50 | |
| DuncanT | Replied inline | 13:51 |
| *** timcl has quit IRC | 13:52 | |
| *** e0ne is now known as e0ne_ | 13:53 | |
| smcginnis | DuncanT: Thanks! | 13:57 |
| *** kaisers has joined #openstack-cinder | 13:58 | |
| *** rushil has joined #openstack-cinder | 13:59 | |
| *** timcl has joined #openstack-cinder | 13:59 | |
| *** Yogi11 has joined #openstack-cinder | 13:59 | |
| *** Yogi1 has quit IRC | 14:02 | |
| *** e0ne_ is now known as e0ne | 14:02 | |
| jgriffith | e0ne: ok, so there was only "one" call that introduced a new get to the db | 14:04 |
| jgriffith | e0ne: I modified that one | 14:04 |
| jgriffith | e0ne: the rest all just moved the call up the chain | 14:04 |
| jgriffith | e0ne: cleaning those up running some tests will resubmit in a few | 14:04 |
| *** bkopilov has joined #openstack-cinder | 14:04 | |
| jgriffith | smcginnis: I put the _LE back on that one | 14:04 |
| jgriffith | smcginnis: should probably make sure it's the one you were referring to | 14:04 |
| e0ne | jgriffith: thanks! | 14:05 |
| jgriffith | tbarron: frankly if I miss some items in replication and migration that's life | 14:05 |
| smcginnis | jgriffith: Which line was that. I can take a look. | 14:05 |
| jgriffith | tbarron: maybe you could create a patch to fix them up :) | 14:05 |
| tbarron | jgriffith: will do, I'll swithc my vote now. ty. | 14:05 |
| jgriffith | tbarron: might as well wait til I put the new set up :) | 14:06 |
| tbarron | again :-) I'm a flip, flopper. | 14:06 |
| tbarron | jgriffith: kk, I will look for it. | 14:06 |
| jgriffith | smcginnis: the Detach volume call around line 857 | 14:06 |
| jgriffith | smcginnis: was "msg = _("Volume %(id)s is attached to more than one instance" | 14:07 |
| smcginnis | jgriffith: Did I say to change that? | 14:08 |
| smcginnis | Looks like that one is used in the logger and the exception, so _() would be correct. | 14:08 |
| smcginnis | Not _LE(). | 14:08 |
| *** mtanino has joined #openstack-cinder | 14:08 | |
| smcginnis | jgriffith: Sorry if I had said otherwise. :\ | 14:08 |
| *** sks has quit IRC | 14:08 | |
| * smcginnis looks back through comments | 14:09 | |
| jgriffith | smcginnis: you made a comment that Exception and Error are the same translation | 14:10 |
| jgriffith | smcginnis: comment at 6:21 | 14:10 |
| smcginnis | jgriffith: Oh, I think maybe I didn't state that right. | 14:10 |
| smcginnis | jgriffith: LOG.error and LOG.exception are the same. | 14:10 |
| smcginnis | jgriffith: But translation is different between LOG.[error|exception] and Exception(msg) | 14:11 |
| smcginnis | jgriffith: That make any sense? | 14:11 |
| jgriffith | smcginnis: totally | 14:11 |
| tbarron | smcginnis: jgriffith: so I think that implies there's no point in doing LOG.error(...) followed immediately by LOG.exception(ex) | 14:11 |
| jgriffith | smcginnis: but I don't know what youre comment referred to then :) | 14:11 |
| smcginnis | tbarron: Exactly! | 14:11 |
| jgriffith | tbarron: ah | 14:11 |
| jgriffith | tbarron: well FYI, I don't think I *added* those | 14:11 |
| smcginnis | jgriffith: Yeah, sorry. That comment was supposed to be a reply to tbarron. | 14:12 |
| jgriffith | guess I can try and scrub those out | 14:12 |
| tbarron | jgriffith: yes, you didn't add and we can change them in another patch. | 14:12 |
| tbarron | jgriffith: but I'd really love to have a file that does it all right that I can look at. | 14:12 |
| smcginnis | tbarron: I agree. | 14:12 |
| tbarron | I learn by example, not by reading the logging rules. | 14:12 |
| smcginnis | tbarron: I've been working on a series of patches to clean all this up. | 14:12 |
| jgriffith | smcginnis: tbarron I think the difference was putting the exception in the log | 14:13 |
| smcginnis | tbarron: Hoping so they do become good examples. | 14:13 |
| jgriffith | smcginnis: tbarron the error just has an "error" message, the ex is logged in the log.exception only | 14:13 |
| tbarron | smcginnis: that would be awesome. I can't believe the amount of energy this project diverts to getting logging right. | 14:13 |
| *** nkrinner has quit IRC | 14:13 | |
| jgriffith | tbarron: that and spelling in comments :) | 14:14 |
| tbarron | I don't in any way mean to say that getting it right is not terribly important. | 14:14 |
| *** nkrinner has joined #openstack-cinder | 14:14 | |
| jgriffith | we're KING!!! | 14:14 |
| smcginnis | tbarron: I know. And I feel kind of bad having all these patches for something seemly so trivial, but I think it will be good in the end. I hope. | 14:14 |
| tbarron | but I just want to have an easier way to do it. | 14:14 |
| tbarron | smcginnis: +1 | 14:14 |
| jgriffith | smcginnis: so what's your preference? Fix it up now, or leave it for follow up? | 14:14 |
| *** nkrinner has quit IRC | 14:14 | |
| *** mdenny has joined #openstack-cinder | 14:14 | |
| smcginnis | jgriffith: I'm fine leaving it. | 14:14 |
| smcginnis | jgriffith: Ankit has a patch that is addressing some of them under cinder/volume. | 14:15 |
| smcginnis | jgriffith: And I am working my way through with hacking check support. | 14:15 |
| *** nkrinner has joined #openstack-cinder | 14:15 | |
| smcginnis | jgriffith: I've been leaving cinder/volume for last both because Ankit is addressing most and because it's going to be a huge PITA. :) | 14:15 |
| DuncanT | The resource bits of this patch are extremely useful... I spent some time trying to write better logstash filters for our log messages, and it was a nightmare, much easier now | 14:16 |
| smcginnis | tbarron: If you care to look: https://review.openstack.org/#/c/173368/ | 14:16 |
| openstackgerrit | John Griffith proposed openstack/cinder: Add resource tag to logging in volume.manager.py https://review.openstack.org/175077 | 14:16 |
| smcginnis | jgriffith: /sould/should/ | 14:18 |
| smcginnis | Doh! | 14:18 |
| *** afazekas_ has joined #openstack-cinder | 14:18 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Add resource tag to logging in volume.manager.py https://review.openstack.org/175077 | 14:19 |
| tbarron | smcginnis: wow, you are going to be the logging go-to guy! Though, to your point, if we have most of the "old" code fixed, there will be less confusion and less need to go-to. | 14:19 |
| tbarron | smcginnis: so thank you. | 14:19 |
| smcginnis | tbarron: That's what I'm hoping. | 14:19 |
| smcginnis | There just seemed to be a lot of cases in code reviews where something was copy/pasted using wrong things. | 14:20 |
| *** wormwood has quit IRC | 14:21 | |
| jgriffith | smcginnis: +1 | 14:22 |
| e0ne | smcginnis: +1 | 14:23 |
| *** zerda has quit IRC | 14:23 | |
| *** jungleboyj has joined #openstack-cinder | 14:24 | |
| *** Tross1 has joined #openstack-cinder | 14:25 | |
| *** Tross has quit IRC | 14:25 | |
| tbarron | DuncanT: just followed your spell-checker link. Hadn't seen that before, and enjoyed it. | 14:26 |
| jgriffith | if anybody has a few cycles... | 14:26 |
| smcginnis | jgriffith, e0ne: Thanks! Glad to know folks aren't shaking their heads thinking what the hell is that guy think he's doing. :) | 14:26 |
| jgriffith | it woudl be AWESOME if you could download: 175054 | 14:26 |
| jgriffith | and see if you can get it to fail | 14:26 |
| jgriffith | OH!!! | 14:26 |
| jgriffith | never mind | 14:26 |
| jgriffith | I got it :) | 14:26 |
| *** afazekas_ has quit IRC | 14:26 | |
| smcginnis | jgriffith: Eureka moment? | 14:27 |
| jgriffith | smcginnis: yeah :) | 14:27 |
| *** tshefi has quit IRC | 14:28 | |
| *** emagana has joined #openstack-cinder | 14:28 | |
| *** afazekas_ has joined #openstack-cinder | 14:30 | |
| *** lifeless has joined #openstack-cinder | 14:32 | |
| *** afazekas_ has quit IRC | 14:36 | |
| jgriffith | smcginnis: nahh... the cleanup stuff is a PITA but it's godo | 14:37 |
| smcginnis | jgriffith: The volume directory is going to be painful. Especially if it takes a while to get through. I forsee a lot of rebasing. | 14:38 |
| jgriffith | smcginnis: yeah, not sure how I'm going to tackle that one yet | 14:39 |
| jgriffith | smcginnis: I'd love to see each Vendor do their driver on their own :) | 14:39 |
| smcginnis | jgriffith: That would be ideal. Not sure that's going to happen though. :) | 14:40 |
| tbarron | jgriffith: in https://review.openstack.org/175077, cinder/volume/manager.py:870, why are you using the weaker (volume_id) resource tag? You got the volume itself at line 841. | 14:41 |
| jgriffith | tbarron: cuz IRDumb | 14:43 |
| jgriffith | tbarron: oversight | 14:43 |
| tbarron | jgriffith: kk (agreeing with the 2nd proposition, not the first) | 14:44 |
| tbarron | That's all I need for the +1 | 14:44 |
| *** emagana has quit IRC | 14:44 | |
| *** emagana has joined #openstack-cinder | 14:45 | |
| *** afazekas_ has joined #openstack-cinder | 14:47 | |
| *** russellb has quit IRC | 14:48 | |
| *** geguileo has quit IRC | 14:49 | |
| *** asselin_ has joined #openstack-cinder | 14:50 | |
| *** hemnafk is now known as hemna | 14:50 | |
| hemna | mornin | 14:50 |
| ameade | happy monday hemna | 14:51 |
| hemna | w00t! Mon..day | 14:51 |
| hemna | ok Coffee helps | 14:51 |
| hemna | :) | 14:51 |
| *** geguileo has joined #openstack-cinder | 14:51 | |
| ameade | heh i am working from home this AM just so I can have a whole pot next to me | 14:52 |
| *** russellb has joined #openstack-cinder | 14:53 | |
| jungleboyj | hemna: Another Manic Monday. :-) | 14:54 |
| * jungleboyj has his thermos of coffee next to him. | 14:54 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Add resource tag to logging in volume.manager.py https://review.openstack.org/175077 | 14:54 |
| jgriffith | tbarron: ^^ and that's the last one!! :) | 14:54 |
| smcginnis | You guys are way too chipper for a Monday morning. :) | 14:54 |
| * e0ne does'nt undertand what is goint on. it's almost 6pm :) | 14:55 | |
| smcginnis | :) | 14:56 |
| *** anshul has quit IRC | 14:56 | |
| jungleboyj | e0ne: :-) | 14:56 |
| jungleboyj | e0ne: Did you have this conversation 8 hours ago? | 14:56 |
| jungleboyj | *Didn't? | 14:56 |
| e0ne | jungleboyj: i did:) | 14:57 |
| *** timcl has quit IRC | 14:57 | |
| *** annegentle has quit IRC | 14:57 | |
| *** strictlyb has quit IRC | 14:58 | |
| *** tsekiyama has joined #openstack-cinder | 14:58 | |
| *** crose has quit IRC | 14:59 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Standardize logging in volume.api.py https://review.openstack.org/175054 | 14:59 |
| *** annegentle has joined #openstack-cinder | 14:59 | |
| *** timcl has joined #openstack-cinder | 15:01 | |
| *** BharatK has joined #openstack-cinder | 15:01 | |
| *** rwsu has joined #openstack-cinder | 15:02 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Brick: Fix race in removing iSCSI device https://review.openstack.org/168506 | 15:03 |
| *** annegentle has quit IRC | 15:04 | |
| *** annegentle has joined #openstack-cinder | 15:05 | |
| *** annegentle has quit IRC | 15:06 | |
| *** afazekas_ has quit IRC | 15:08 | |
| *** annegentle has joined #openstack-cinder | 15:10 | |
| *** annashen has joined #openstack-cinder | 15:10 | |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Add ability to specify path var to testr https://review.openstack.org/162262 | 15:10 |
| *** beekneemech is now known as bnemec | 15:10 | |
| *** e0ne is now known as e0ne_ | 15:10 | |
| *** nkrinner has quit IRC | 15:12 | |
| *** jistr has quit IRC | 15:14 | |
| *** annashen has quit IRC | 15:15 | |
| *** strictlyb has joined #openstack-cinder | 15:16 | |
| *** e0ne_ is now known as e0ne | 15:17 | |
| Swanson | Did the gerrit email toilet unclog over the weekend? Seriously out of order messages in my inbox... | 15:17 |
| *** annegentle has quit IRC | 15:18 | |
| *** afazekas_ has joined #openstack-cinder | 15:21 | |
| *** Yogi1 has joined #openstack-cinder | 15:23 | |
| *** flip214 has quit IRC | 15:24 | |
| *** harlowja_at_home has joined #openstack-cinder | 15:24 | |
| *** afazekas_ has quit IRC | 15:26 | |
| *** Yogi11 has quit IRC | 15:26 | |
| *** sgotliv_ has quit IRC | 15:27 | |
| *** jistr has joined #openstack-cinder | 15:28 | |
| *** Yogi1 has quit IRC | 15:28 | |
| *** Yogi1 has joined #openstack-cinder | 15:29 | |
| smcginnis | Swanson: I had emails come in this morning from last Wednesday. Not sure if it's gerrit or something messed up with our mail server. | 15:29 |
| smcginnis | Anyone else see issues like that/ | 15:29 |
| thingee | hemna: I wish my contributions to cinder could just be making coffee for everyone and approving changes here and there. | 15:30 |
| thingee | coffee is important stuff | 15:30 |
| *** lpabon has joined #openstack-cinder | 15:31 | |
| *** jdurgin1 has joined #openstack-cinder | 15:31 | |
| jungleboyj | thingee: +1 | 15:31 |
| jungleboyj | smcginnis: I didn't see anything like that. | 15:32 |
| Swanson | smcginnis: I was seriously confused until I had about 1/2 a cup of coffee and then clarity descended | 15:32 |
| smcginnis | jungleboyj: Yeah, probably just us. Funky email scanner or something. | 15:32 |
| jungleboyj | :-( | 15:32 |
| smcginnis | Might just have to switch over to gmail. | 15:32 |
| jungleboyj | smcginnis: +2 | 15:33 |
| Swanson | Eventually our firewall will be a physical wall crushing the incoming fibre. | 15:33 |
| *** Yogi1 has quit IRC | 15:33 | |
| hemna | thingee, +1 :) | 15:37 |
| *** Yogi1 has joined #openstack-cinder | 15:37 | |
| *** afazekas_ has joined #openstack-cinder | 15:37 | |
| jungleboyj | Swanson: Ahh, physical barrier, huh? What are you, a government lab? | 15:38 |
| Swanson | jungleboyj: The great firewall of austin. | 15:39 |
| jungleboyj | :-) | 15:39 |
| thingee | smcginnis: you mind bringing me up to speed on the gate failures? | 15:39 |
| *** dannywilson has joined #openstack-cinder | 15:39 | |
| Swanson | no such option: config_file. Joy. Love debugging stacking failures... | 15:41 |
| *** annashen has joined #openstack-cinder | 15:41 | |
| smcginnis | thingee: I think jgriffith has a good understanding of what's going on. And a fix if I understood right. | 15:42 |
| smcginnis | thingee: Something was not getting faked correctly IIRC. | 15:42 |
| *** dannywilson has quit IRC | 15:42 | |
| openstackgerrit | Alex Meade proposed openstack/cinder: NetApp E-Series: Fix instance live-migration with attached volumes https://review.openstack.org/170990 | 15:42 |
| smcginnis | thingee: That in a combination of some setup not being done in the right order was causing some py27 test failures. | 15:43 |
| *** dannywilson has joined #openstack-cinder | 15:43 | |
| thingee | smcginnis: oh, yeah I already started approving that change | 15:43 |
| thingee | thanks jgriffith per the usual | 15:43 |
| thingee | :) | 15:43 |
| smcginnis | thingee: Yeah, that was part of it. | 15:43 |
| smcginnis | :) | 15:43 |
| thingee | we have jgriffith who is captain gate and jungleboyj who is captain oslo | 15:43 |
| smcginnis | thingee: Hah! True. | 15:44 |
| thingee | I only add additional exception catches to turn off gate issues :) | 15:44 |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Remove print statement in unit test https://review.openstack.org/175459 | 15:45 |
| smcginnis | If you ignore something long enough it eventually goes away. ;) | 15:45 |
| jungleboyj | :-) Keep this up and we will need to have Sargents, Admirals and Generals | 15:45 |
| smcginnis | jungleboyj: You'll need to be promoted at some point. | 15:46 |
| hemna | phew, that's pretty innocuous | 15:46 |
| hemna | good thing you don't see my debuging print statements. | 15:46 |
| jungleboyj | smcginnis: Hmmm, who will promote me or can I self promote? | 15:46 |
| hemna | LOG.debug("ASS = %s", connector) | 15:46 |
| smcginnis | jungleboyj: Hmm, wonder where this came from: https://review.openstack.org/#/c/175459/1/cinderclient/tests/unit/test_client.py | 15:47 |
| smcginnis | :P | 15:47 |
| smcginnis | jungleboyj: I think after a few beers at the summit you can promote yourself. :) | 15:47 |
| *** afazekas_ has quit IRC | 15:47 | |
| jungleboyj | smcginnis: WTF, how did that ever get in!?! | 15:47 |
| thingee | jgriffith, jungleboyj: fastest approval evar | 15:48 |
| smcginnis | jungleboyj: Darn reviewers not doing their jobs. | 15:48 |
| thingee | jgriffith, jungleboyj: my version discovery patch actually removes that | 15:48 |
| thingee | guess that's going to need to be rebased now | 15:48 |
| jungleboyj | Doh! | 15:49 |
| jgriffith | thingee: no it won't | 15:49 |
| jgriffith | thingee: it'll just merge fine | 15:49 |
| jgriffith | thingee: master changed to match you, should be fine I think | 15:49 |
| thingee | jgriffith: Oh I didn't mean just by that change...just I haven't checked on it in a while. Looks like it's just failing jenkins from a another gate issue | 15:49 |
| openstackgerrit | Mike Perez proposed openstack/python-cinderclient: Enable version discovery https://review.openstack.org/145613 | 15:50 |
| jgriffith | thingee: oh... hehe | 15:50 |
| thingee | would be good to get this merged soon so we can gate on it | 15:50 |
| thingee | would love to get this code removed soon :( | 15:50 |
| thingee | also if anyone has refactoring suggestions ^ | 15:51 |
| *** dannywilson has quit IRC | 15:51 | |
| *** ronis has quit IRC | 15:52 | |
| *** mwichmann has joined #openstack-cinder | 15:52 | |
| *** mwichmann has left #openstack-cinder | 15:52 | |
| *** jistr_ has joined #openstack-cinder | 15:53 | |
| *** russellb has quit IRC | 15:53 | |
| *** pradipta has joined #openstack-cinder | 15:54 | |
| *** jistr has quit IRC | 15:56 | |
| kmartin_ | smcginnis, jungleboyj, jgriffith, rhe00: hemna posted a draft presentation and linked it to the etherpad... https://etherpad.openstack.org/p/vancouver_fc_in_openstack | 15:57 |
| *** _cjones_ has joined #openstack-cinder | 15:57 | |
| smcginnis | kmartin_: Yeah, looks pretty good for a start. | 15:57 |
| kmartin_ | can you guys tack a look and plan on contributing your vendor slide | 15:58 |
| *** russellb has joined #openstack-cinder | 15:58 | |
| smcginnis | So each of us just need to add a slide for our own storage piece. | 15:58 |
| kmartin_ | *take | 15:58 |
| smcginnis | kmartin_: I'm hoping to get ours this week. | 15:58 |
| kmartin_ | smcginnis, correct | 15:58 |
| smcginnis | hemna: Just send updates to you? | 15:58 |
| hemna | sure | 15:58 |
| smcginnis | hemna: Thanks for putting that together! | 15:59 |
| hemna | is everyone ok with the names I put on the slides and the speaker order, etc ? | 15:59 |
| smcginnis | hemna: +1 | 15:59 |
| *** _cjones_ has quit IRC | 15:59 | |
| *** _cjones_ has joined #openstack-cinder | 15:59 | |
| *** sseverson has joined #openstack-cinder | 15:59 | |
| smcginnis | Or can I actually +2 on this one? :) | 15:59 |
| hemna | :) | 15:59 |
| hemna | you can! | 15:59 |
| hemna | I'm going to try and get my slides done this week | 15:59 |
| smcginnis | Woohoo. | 15:59 |
| *** BharatK has quit IRC | 16:00 | |
| *** Longgeek has quit IRC | 16:00 | |
| thingee | smcginnis, jgriffith: think it would be good to start discussing summit panel stuff soon. sent an email to everyone. | 16:00 |
| * jungleboyj is looking. | 16:01 | |
| smcginnis | thingee: Agreed | 16:02 |
| smcginnis | hemna: Do we also need a short blurb (title, company, etc.) for the Presenters slide? | 16:02 |
| smcginnis | Don't want to put too much there. Maybe just our names and the company we work for? | 16:03 |
| * thingee remember his last panel where he was a red x because he didn't submit a picture. :) | 16:03 | |
| hemna | smcginnis, we could use the bio's from the preso page ? | 16:03 |
| smcginnis | I'd be fine with a red X. :) | 16:03 |
| hemna | heh yah | 16:03 |
| smcginnis | hemna: Yeah, that's fine. | 16:04 |
| *** jistr_ is now known as jistr | 16:05 | |
| jungleboyj | hemna: kmartin_ Looks good. I will work on putting some slides together for the IBM piece. | 16:06 |
| rhe00 | hemna: kmartin_: I will work on something from X-IO. Are we still thinking one slide per vendor? | 16:08 |
| hemna | rhe00, yah I think so | 16:08 |
| rhe00 | hemna: ok, sounds good | 16:08 |
| *** xyang1 has joined #openstack-cinder | 16:09 | |
| jgriffith | just wondering... is this a "look at me I'm vendor-xyz" panel or a Cinder team panel? | 16:09 |
| jgriffith | not to be a jerk, but.... I didn't know this kinda feels off to me | 16:10 |
| hemna | jgriffith, I think this is for the FC preso | 16:10 |
| hemna | no ? | 16:10 |
| jgriffith | hemna: yeah | 16:10 |
| hemna | we have 7 presenters...which is kinda silly, but it is what it is. | 16:10 |
| jgriffith | hemna: so typically we try and avoid the "vendorized" slides on these | 16:11 |
| jgriffith | hemna: you're missing my point | 16:11 |
| *** rmesta has joined #openstack-cinder | 16:11 | |
| hemna | ok | 16:11 |
| hemna | I'm sure I am. | 16:11 |
| jgriffith | hemna: ok... never mind | 16:11 |
| smcginnis | jgriffith: I think we just wanted to mention everyone involved. | 16:11 |
| jgriffith | smcginnis: yeah, def | 16:11 |
| smcginnis | jgriffith: Primarily as a show of force that FC is a supported option. | 16:11 |
| kmartin_ | jgriffith, 1 slide per vendor is too much? | 16:11 |
| jgriffith | smcginnis: but Vendor branded slides for each section is what i'm getting at | 16:11 |
| smcginnis | jgriffith: Oh, not for each slide. | 16:12 |
| hemna | so the other option is to just have everyone up on stage during the Q&A and not do vendor slides ? | 16:12 |
| jgriffith | kmartin_: not at all... I'm saying if we're doing slides they should probably be OpenStack template slides and consistent | 16:12 |
| smcginnis | jgriffith: Just to have a quick spot for one slide to show I'm vendor X and I support FC. | 16:12 |
| hemna | I'm open to whatever. I was just trying to accommodate everyone. | 16:12 |
| smcginnis | jgriffith: That's how I saw it. | 16:13 |
| hemna | jgriffith, I think that's fine. I put up a template slide deck that we can use | 16:13 |
| hemna | it's in the etherpad | 16:13 |
| smcginnis | Openstack branded slide with my company name and a couple bullet items about what we support. Next. | 16:13 |
| hemna | jgriffith, 3rd link in the etherpad is what I put together last week | 16:13 |
| kmartin_ | jgriffith, https://www.dropbox.com/s/2rc8mk3sbpdhicl/PastPresentFutureFibreChannel.odp?dl=0 has all the branding stuff removed | 16:14 |
| jgriffith | smcginnis: so what I was getting at was OpenStack slide template, an intro slide with panelists and their affiliation | 16:14 |
| hemna | as a starting point for the outline for the preso, according to the etherpad outline. | 16:14 |
| jgriffith | kmartin_: the dropbox one? | 16:14 |
| hemna | yup | 16:14 |
| smcginnis | jgriffith: And that's it. Just the list of names and the companies? | 16:14 |
| jgriffith | kk | 16:15 |
| jgriffith | looking | 16:15 |
| smcginnis | jgriffith: I'm not opposed to that. | 16:15 |
| jgriffith | hemna: kmartin_ yeah... perfect | 16:15 |
| smcginnis | jgriffith: But if we have time and space just thinking it would be nice to have at least 30 seconds to add more. | 16:15 |
| jgriffith | hemna: kmartin_ sorry, there are way too many slide sets up there ;) | 16:15 |
| kmartin_ | jgriffith, :) | 16:15 |
| thingee | xyang1: do we have docs for incremental backup support? | 16:16 |
| *** jdurgin1 has quit IRC | 16:16 | |
| xyang1 | thingee: Oh, not yet. The CLI part is not merged yet | 16:16 |
| xyang1 | thingee: In the doc, I use CLI to illustrate | 16:16 |
| thingee | xyang1: mind linking me to the patch? | 16:17 |
| thingee | both docs and cli | 16:17 |
| xyang1 | thingee: https://review.openstack.org/#/c/112101/ | 16:18 |
| xyang1 | thingee: That error is in every cli patch | 16:19 |
| thingee | smcginnis: https://review.openstack.org/#/c/175054/7 | 16:19 |
| xyang1 | thingee: I don't have a doc link yet. I can create one and send to you later | 16:20 |
| thingee | xyang1: cool. would like to include it in the Kilo release notes, but would be good if we had something | 16:20 |
| thingee | as is, I wouldn't include it just because it's not self explanatory | 16:20 |
| thingee | tbarron: hey, do we have any docs on nfs backup driver? | 16:21 |
| xyang1 | thingee: Ok, I'll work on the doc. When can we do the cli release? | 16:21 |
| thingee | xyang1: I think we're going to be doing a big cinderclient release soonish..would like to get the version discovery stuff in | 16:21 |
| *** jcru has joined #openstack-cinder | 16:22 | |
| xyang1 | thingee: Ok | 16:22 |
| thingee | xyang1: https://review.openstack.org/#/c/145613/ | 16:22 |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder-specs: Checking the existence of volume https://review.openstack.org/174823 | 16:22 |
| thingee | xyang1: do we have anything for configuring oversubscription in thin provisioning? | 16:23 |
| rhe00 | does anyone here know the best way to get a hold of the documentation group? are they active on IRC or is the mailing list a safer bet? | 16:24 |
| smcginnis | jgriffith, hemna, kmartin_, jungleboyj, rhe00, xyang1: Do we have consensus? Vendor slide or no vendor slide? I'm fine either way I guess, just don't want to put on together if we don't want it. | 16:24 |
| xyang1 | thingee: That is a flag in cinder.conf | 16:24 |
| thingee | rhe00: #openstack-docs or something? | 16:24 |
| xyang1 | thingee: I'll take a look of the existing doc | 16:24 |
| smcginnis | rhe00: Anne Gentle is around usually. | 16:24 |
| *** jistr has quit IRC | 16:24 | |
| xyang1 | thingee: And see if i should add anything | 16:24 |
| rhe00 | seems like the documentation for our volume driver fell of the planet over the weekend | 16:24 |
| kmartin_ | smcginnis, one vendor slide | 16:24 |
| thingee | xyang1: might be good to have some explanation. If I remember correctly, the names were a little overlapping, so it would be good to be clear. | 16:24 |
| jgriffith | smcginnis: so my point was really just one slide deck and making it all "flow" | 16:25 |
| xyang1 | thingee: Sure | 16:25 |
| jgriffith | smcginnis: so like a google-doc that everyone can collaborate on | 16:25 |
| thingee | xyang1: thanks, include me on any reviews and I'll +1 | 16:25 |
| thingee | xyang1: think these would be excellent for the release notes | 16:25 |
| jgriffith | smcginnis: but it's hemna and kmartin_ 's prez really, so it's up to them I think | 16:25 |
| xyang1 | thingee: Sure. Thanks | 16:25 |
| thingee | xyang1: it's awesome that we have stuff to include in the release notes for consistency groups!! | 16:25 |
| smcginnis | jgriffith: Sure, I get what you're saying. | 16:26 |
| kmartin_ | smcginnis, jgriffith was looking at the wrong deck that had all the HP branding stuff, so I think he is ok with one slide per vendor using the OpenStack side template | 16:26 |
| xyang1 | thingee: I need to update cg as well for 2 new apis | 16:26 |
| smcginnis | kmartin_: Ah, I could see why. :) | 16:26 |
| xyang1 | thingee: The doc | 16:26 |
| xyang1 | smcginnis: I am ok with or without vendor slide. | 16:27 |
| thingee | tsekiyama: you mind updating the release notes about the multi path patches you worked on. There is overlap on these and I always forget which does what. https://wiki.openstack.org/wiki/ReleaseNotes/Kilo | 16:27 |
| *** annashen has quit IRC | 16:27 | |
| DuncanT | So I don't want flights to Vancouver, BC, do I? | 16:28 |
| smcginnis | xyang1: I'll make one and if we pull it - oh well. :) | 16:28 |
| tsekiyama | thingee: okey, let me see | 16:28 |
| smcginnis | DuncanT: You could fly in to Seattle, but that would be more direct. | 16:28 |
| thingee | tsekiyama: thanks | 16:28 |
| jgriffith | DuncanT: yeah, you do | 16:29 |
| smcginnis | DuncanT: Shuttle or taxi looked like it was only about 10-15 away from the conference center. | 16:29 |
| smcginnis | Or in this case centre. :) | 16:29 |
| * thingee still needs to get a hotel | 16:29 | |
| jgriffith | smcginnis: you sure about that? | 16:29 |
| DuncanT | "Vancouver, BC YVR"? That's the right airport? | 16:29 |
| smcginnis | DuncanT: Yep. | 16:29 |
| DuncanT | Phew | 16:29 |
| smcginnis | jgriffith: Which? | 16:29 |
| DuncanT | There was some discussion earlier about there being more than one Vancouver | 16:30 |
| jgriffith | Seattle to Vancouver? That's like 2.5 hours I think? | 16:30 |
| openstackgerrit | Huang Zhiteng proposed openstack/cinder: RBD: Add missing Ceph customized cluster name support https://review.openstack.org/175475 | 16:30 |
| smcginnis | jgriffith: I meant you can fly in to Seattle and go up, but if you fly into Vancouver then it's really close. | 16:30 |
| jgriffith | smcginnis: oh, yeah! :) | 16:30 |
| *** leeantho has joined #openstack-cinder | 16:30 | |
| smcginnis | Only reason I considered Seattle was to see some friends on the way. | 16:31 |
| smcginnis | And to avoid company travel being flagged as "international" :) | 16:31 |
| jgriffith | I was worried because DuncanT said "So I don't want flights to Vancouver, BC, do I?" | 16:31 |
| jgriffith | smcginnis: was worried you were going to send him to the wrong country :) | 16:32 |
| jungleboyj | smcginnis: I am ok with Vendor slides or we could do a list of all the drivers with FC support. Don't have to have it company branded. | 16:32 |
| thingee | tsekiyama: also information on the volume copy bandwidth limit would be good. Might be good to propose something to http://docs.openstack.org/admin-guide-cloud/content/managing-volumes.html | 16:32 |
| smcginnis | jgriffith: That would be pretty cruel. ;) | 16:32 |
| tsekiyama | thingee: sounds good. Will try it. | 16:33 |
| thingee | tsekiyama: thanks again | 16:34 |
| DuncanT | jgriffith: Don't give people ideas! | 16:34 |
| smcginnis | DuncanT: You heard the next summit got moved to Siberia, right? | 16:36 |
| smcginnis | :p | 16:36 |
| tbarron | thingee: was at lunch | 16:37 |
| tbarron | thingee: we don't have any specific docs on nfs backup driver, but I can do some updates | 16:37 |
| *** Yogi11 has joined #openstack-cinder | 16:38 | |
| thingee | tbarron: thanks that would be great. | 16:38 |
| thingee | the backup doc in general needs help | 16:38 |
| thingee | DuncanT: ^ | 16:38 |
| thingee | http://docs.openstack.org/admin-guide-cloud/content/volume-backup-restore.html | 16:39 |
| thingee | doesn't really help with specific backends | 16:39 |
| *** Yogi1 has quit IRC | 16:40 | |
| *** harlowja_at_home has quit IRC | 16:41 | |
| thingee | tbarron: I would love to include the nfs backup driver in the release notes, but there's no explanation with setting things up from Cinder's perspective. | 16:42 |
| *** alecv has quit IRC | 16:43 | |
| thingee | e0ne, jgriffith: does it matter if we notify about this dep change? It's already installed by other projects. | 16:45 |
| thingee | https://review.openstack.org/#/c/168419/ | 16:45 |
| thingee | since it's already in the global requirements | 16:45 |
| jgriffith | thingee: absolutely yes | 16:45 |
| thingee | ok glad I asked then | 16:45 |
| jgriffith | thingee: the issue is that packagers aren't packaging that for Cinder currently | 16:46 |
| jgriffith | thingee: that's why it's kinda sketchy | 16:46 |
| thingee | ah ha, good point | 16:46 |
| e0ne | thingee: -1 was for commit message:( | 16:46 |
| e0ne | jgriffith: +1. some vendors probably will need to update their deb/rpm/etc to add new requirement | 16:47 |
| thingee | so what do we do now? | 16:47 |
| jgriffith | e0ne: thingee that's why it may not be valid to merge that | 16:47 |
| jgriffith | thingee: it's technically backporting "new" functionality | 16:48 |
| thingee | got it. so is there any other way for us to backport the fix for this bug? | 16:48 |
| thingee | that is depending on this | 16:49 |
| e0ne | i didn't verify what projects already use it but it could impact cinder packaging and deployment | 16:49 |
| jgriffith | thingee: see my notes in that patch... the alternative is posted as a gist | 16:49 |
| thingee | jgriffith: sorry missed that, thanks | 16:49 |
| jgriffith | thingee: s/notes/comments/ | 16:49 |
| thingee | jgriffith: yeah that makes sense to me | 16:50 |
| thingee | wrt to the gist | 16:50 |
| thingee | sorry for initially leading you down this path :) | 16:50 |
| jgriffith | thingee: nahh... no worries | 16:51 |
| jgriffith | thingee: so you want me to propose the alternative? | 16:51 |
| thingee | jgriffith: yes please | 16:51 |
| jgriffith | thingee: k... I'll do that later today | 16:51 |
| *** annashen has joined #openstack-cinder | 16:51 | |
| thingee | jgriffith: before juno is security backports only =/ | 16:51 |
| e0ne | fyi, retrying is used by glance so i believe that everyone has it in thers rpm/deb repo | 16:53 |
| tbarron | thingee: I'm reading over the release notes now to get context for your remark. I did look at the backup section in the admin guide and do see that it is way too thin. | 16:53 |
| thingee | overall I'm really happy with the doc references from the release notes. good job to everyone making that happen :) | 16:53 |
| e0ne | jgriffith, thingee: btw, should we add slots for db migrations for Kilo | 16:54 |
| e0ne | ? | 16:54 |
| *** russellb has quit IRC | 16:55 | |
| *** vilobhmm1 has joined #openstack-cinder | 16:55 | |
| thingee | add slots? | 16:55 |
| jgriffith | e0ne: yeah | 16:55 |
| jgriffith | thingee: we need to reserve slots for bakcports | 16:55 |
| *** vilobhmm11 has joined #openstack-cinder | 16:55 | |
| *** haomaiwang has joined #openstack-cinder | 16:55 | |
| jgriffith | thingee: e0ne but I always get messed up on the "when" for that :) | 16:55 |
| e0ne | thingee: like this one https://github.com/openstack/cinder/commit/78ca2c3dc711d0982b0a67101f6b8529c4599944 | 16:55 |
| thingee | oh yeah | 16:56 |
| thingee | definitely | 16:56 |
| e0ne | jgriffith: after FF and RC i believe we won't have many migrations so i'll go on with it | 16:57 |
| ameade | DuncanT: rebased https://review.openstack.org/#/c/170990/ | 16:57 |
| jgriffith | e0ne: great, thanks! | 16:57 |
| ameade | it was near trivial | 16:57 |
| jgriffith | e0ne: it was on my list... but I'm obviously behind a bit :( | 16:57 |
| e0ne | jgriffith: i can leave it for you | 16:57 |
| tbarron | thingee: I don't know how the doc process works, so bear with me. Release notes will come out April 30. How long do we have for updates between now and then? | 16:58 |
| thingee | e0ne, jgriffith: I can also do it. I know jgriffith has already a bit on his plate. | 16:58 |
| e0ne | :) | 16:58 |
| jgriffith | e0ne: thingee done | 16:58 |
| *** russellb has joined #openstack-cinder | 16:58 | |
| e0ne | great!:) | 16:58 |
| thingee | tbarron: you have from now until april 30? :) | 16:59 |
| *** asselin__ has joined #openstack-cinder | 16:59 | |
| *** bswartz has quit IRC | 16:59 | |
| *** akerr has quit IRC | 16:59 | |
| tbarron | thingee: I was thinking we could have a bullet that says: * Ability to backup cinder volumes to an NFS repository. **Read the docs for more info** | 16:59 |
| *** vilobhmm1 has quit IRC | 16:59 | |
| thingee | tbarron: sure. we need docs though :) | 17:00 |
| tbarron | But then we have to backfill http://docs.openstack.org/admin-guide-cloud/content/volume-backup-restore.html | 17:00 |
| tbarron | thingee: yup. | 17:00 |
| tbarron | thingee: so I could add a brief section that says: By default, backup/restore uses Swift to provide the backup repository. If you choose to use NFS instead, configure your cinder.conf as follows. ... | 17:01 |
| thingee | that might be fine for now | 17:01 |
| e0ne | jbernard: fyi, i'm testing my fix for https://launchpad.net/bugs/1401335. i'll publish patch once i'll get it tested not only with devstack all-in-one env | 17:02 |
| openstack | Launchpad bug 1401335 in Cinder "rbd calls block eventlet threads" [High,Confirmed] - Assigned to Alan Jiang (ajiang) | 17:02 |
| thingee | tbarron: depending as this grows, we may split them up in different pages. can always change that later though | 17:02 |
| tbarron | thingee: but I'm not qualified to speak to Ceph or TSM | 17:02 |
| thingee | tbarron: yeah that's fine. I just meant having docs for nfs backup driver would be great for the release notes. | 17:02 |
| tbarron | thingee: OK, I will get that done this week. | 17:02 |
| *** asselin_ has quit IRC | 17:02 | |
| *** akerr has joined #openstack-cinder | 17:03 | |
| *** jms has joined #openstack-cinder | 17:04 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Reserve 5 migrations for Kilo backports https://review.openstack.org/175490 | 17:05 |
| thingee | jgriffith: thanks | 17:06 |
| jgriffith | thingee: sure | 17:06 |
| jgriffith | e0ne: thanks for the reminder! :) | 17:06 |
| thingee | was just about to push something up :) ... wasn't sure if done meant "done! sold to thingee to do it" :) | 17:06 |
| *** annashen has quit IRC | 17:06 | |
| *** lpetrut has quit IRC | 17:07 | |
| thingee | e0ne: do you not have +2 on cinderclient? https://review.openstack.org/#/c/107886/7 | 17:08 |
| *** Yogi1 has joined #openstack-cinder | 17:09 | |
| e0ne | thingee: oops. i've put +1 because my previous vote was +1 | 17:09 |
| *** Yogi11 has quit IRC | 17:09 | |
| hemna | thingee, so, we just have one more os-brick patch to land | 17:10 |
| hemna | and I think it's good for a first drop to pypi | 17:10 |
| hemna | https://review.openstack.org/#/c/168506 | 17:10 |
| * thingee checks | 17:10 | |
| hemna | whenever you have time. | 17:10 |
| hemna | no hurry | 17:10 |
| e0ne | thingee: i'll test it once more today before +2 | 17:10 |
| *** patrickeast has joined #openstack-cinder | 17:10 | |
| e0ne | hemna: thanks for addressing my comments | 17:12 |
| hemna | e0ne, np | 17:12 |
| *** annashen has joined #openstack-cinder | 17:12 | |
| e0ne | jgriffith: one more thing: cherry-pick to stable/kilo | 17:14 |
| *** ronis has joined #openstack-cinder | 17:14 | |
| jgriffith | e0ne: actualy they don't need to go back | 17:15 |
| jgriffith | e0ne: they're just "place-holders" incase | 17:16 |
| *** Guest36304 is now known as mgagne | 17:16 | |
| *** mgagne has joined #openstack-cinder | 17:16 | |
| e0ne | jgriffith: ok, makes sence | 17:16 |
| jgriffith | e0ne: so we just reserve the spots, don't need to actually move them | 17:16 |
| jgriffith | e0ne: yeah, I used to think it was the same way too... but I was educated :) | 17:17 |
| *** xyang has joined #openstack-cinder | 17:17 | |
| *** deepakcs has joined #openstack-cinder | 17:17 | |
| jms | (Let me know if this would be better directed elsewhere...) Is there a way during debug to get the cinder files to do a trace on what call it's in when it outputs messages? | 17:17 |
| e0ne | jgriffith: thanks for sharing knoweledge:) | 17:17 |
| jgriffith | jms: that should already be there | 17:17 |
| jgriffith | jms: if it's missing, you might look at your logging config in cinder.conf | 17:18 |
| jgriffith | jms: oh... wait, a full trace? | 17:18 |
| jordanP | guys, just to let you know that I silent the scality-ci for a couple of hours. Ipv4 vs ipv6 problem while running apt-get | 17:18 |
| jgriffith | jms: hmmm... best way I know is a breakpoint, but I'm sure there's a way to auto do that | 17:18 |
| *** timcl has quit IRC | 17:20 | |
| jms | jgriffith: Yeah, a full trace ... I was looking at the pythong trace module, but that doesn't seem to do exactly what I'm needing (ofcourse, I don't know python.... I'm just working on this!). :/ | 17:22 |
| jms | jgriffith: That, or maybe manually starting cinder-volume with -m pdb ... pdg ... Whatever the python debugger module is? | 17:23 |
| jms | I'm _pretty sure_ what I'm looking for it called from -volume anyway | 17:25 |
| jms | *is called | 17:25 |
| jgriffith | jms: yeah, restart with that may work... not sure. I've always done it via breakpoints manually :) | 17:26 |
| jms | jgriffith: I'm learning python as I go so... Whoo! | 17:27 |
| *** zhenguo has quit IRC | 17:27 | |
| jgriffith | jms: best way to do it :) | 17:28 |
| jms | ... Yeah, not for those of us that ignore white space when reading code ... Makes it just a tad more difficult. ;) | 17:30 |
| *** aswadr has quit IRC | 17:32 | |
| jgriffith | mtreinish: you ever run into "git review" not recognizing the "Change-ID:" line? | 17:33 |
| mtreinish | jgriffith: not normally | 17:34 |
| mtreinish | jgriffith: the hook it installs normally makes it pretty error free | 17:35 |
| jgriffith | mtreinish: http://goo.gl/nMdXkG | 17:35 |
| deepakcs | eharney, ping | 17:35 |
| *** lpetrut has joined #openstack-cinder | 17:35 | |
| jgriffith | mtreinish: yeah, I have the hook, and it "works" | 17:35 |
| eharney | deepakcs: hi | 17:35 |
| jgriffith | mtreinish: just for some reason this particular set pukes | 17:35 |
| deepakcs | eharney, http://paste.fedoraproject.org/213466/29551323 | 17:35 |
| deepakcs | eharney, gettign this error while nova tries to do update_snapshot_status call to cinder | 17:36 |
| mtreinish | jgriffith: well it looks like one of the commits in the middle is missing it | 17:36 |
| *** russellb has quit IRC | 17:36 | |
| jgriffith | mtreinish: oh.. hmmm | 17:36 |
| jgriffith | mtreinish: ahhh! You're a genius :) | 17:36 |
| mtreinish | and I don't know if it's able to add it or not in that situation | 17:36 |
| deepakcs | eharney, my cinder/api/contrib/snapshot_actions.py function (_update_snapshot_status_) is not getting called | 17:36 |
| jgriffith | I know what happened | 17:36 |
| deepakcs | eharney, instead wsgi.server directly returns 400 back to Nova | 17:36 |
| jgriffith | mtreinish: the one in the middle should be squashed actually | 17:36 |
| jgriffith | mtreinish: ok... thanks!! | 17:36 |
| mtreinish | jgriffith: heh, sure np | 17:37 |
| mtreinish | btw, really like that tree :) | 17:37 |
| jgriffith | mtreinish: :) | 17:38 |
| *** melwitt has joined #openstack-cinder | 17:38 | |
| *** harlowja_away is now known as harlowja | 17:38 | |
| *** kmartin_ has quit IRC | 17:39 | |
| eharney | deepakcs: Cinder doesn't throw an error somewhere? | 17:39 |
| *** Yogi1 has quit IRC | 17:39 | |
| *** russellb has joined #openstack-cinder | 17:40 | |
| deepakcs | eharney, nope | 17:41 |
| *** dustins has joined #openstack-cinder | 17:41 | |
| deepakcs | eharney, i am seeing c-api, c-sch, c-vol | 17:41 |
| deepakcs | eharney, as you can see, nova's update is reachign cinder (Action body: debug msg is present in c-api) but before it reaches actions.py, eventlet.wsgi.server is returning 400 back Nova | 17:41 |
| deepakcs | eharney, is there a way to look at wsgi server logs to figure why it returns back 400 ? | 17:41 |
| eharney | deepakcs: wsgi issues should appear in the api service log | 17:42 |
| deepakcs | eharney, u mean c-api.log ? | 17:43 |
| eharney | deepakcs: yes | 17:43 |
| deepakcs | eharney, Hmm i don't see any, only the INFO msg from wsgi | 17:43 |
| deepakcs | eharney, is my conclusion above on whats happening correct ? | 17:43 |
| eharney | deepakcs: i think so but i don't know why it's issuing 400 | 17:45 |
| *** vilobhmm11 has quit IRC | 17:45 | |
| deepakcs | eharney, any idea on how to proceed further, have spent > 1 day, without luck :( | 17:45 |
| *** lcurtis has joined #openstack-cinder | 17:46 | |
| eharney | deepakcs: make sure the log shows that it loaded the os-snapshot-actions extension at startup | 17:46 |
| *** vilobhmm1 has joined #openstack-cinder | 17:47 | |
| *** russellb has quit IRC | 17:47 | |
| deepakcs | eharney, i don't see it being loaded, what needs to be done to have it loaded ? | 17:48 |
| eharney | deepakcs: generally it should just happen automatically and show with all the other extensions loading | 17:49 |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Introduce functional testing to cinderlcient https://review.openstack.org/175512 | 17:50 |
| *** bswartz has joined #openstack-cinder | 17:50 | |
| *** jordanP has quit IRC | 17:50 | |
| *** e0ne has quit IRC | 17:51 | |
| *** akerr has quit IRC | 17:51 | |
| *** timcl has joined #openstack-cinder | 17:52 | |
| *** russellb has joined #openstack-cinder | 17:52 | |
| deepakcs | eharney, 3171:2015-04-20 17:15:12.127 DEBUG cinder.api.extensions [-] Loading extension cinder.api.contrib.snapshot_actions.Snapshot_actions from (pid=5018) load_extension /opt/stack/cinder/cinder/api/extensions.py:258 | 17:52 |
| *** akerr has joined #openstack-cinder | 17:52 | |
| deepakcs | eharney, I was looking for the word "Loaded" and it didn't show up, but the above Loading msg does mean its loaded, right ? | 17:53 |
| eharney | deepakcs: yes | 17:53 |
| deepakcs | eharney, It was working a week before, until i added code to support old and new nova & cinder and then it broke | 17:54 |
| deepakcs | eharney, looking at the changes I haven't yet figured what could cause the nova - cinder api call to break | 17:55 |
| *** akerr has quit IRC | 17:57 | |
| *** Yogi1 has joined #openstack-cinder | 17:58 | |
| *** akerr has joined #openstack-cinder | 17:59 | |
| *** annegentle has joined #openstack-cinder | 18:01 | |
| deepakcs | eharney, any other ideas ? :) | 18:02 |
| eharney | deepakcs: see if nova can talk to cinder in general with something like "nova volume-create" | 18:03 |
| *** vilobhmm1 has quit IRC | 18:03 | |
| *** vilobhmm1 has joined #openstack-cinder | 18:05 | |
| *** vilobhmm1 has quit IRC | 18:05 | |
| *** vilobhmm1 has joined #openstack-cinder | 18:05 | |
| deepakcs | eharney, ok, does nova calling cinder's v1 Vs v2 API can cause this to happen ? I don't see any cinder API version in nova.conf, just wondering | 18:06 |
| eharney | deepakcs: it shouldn't... Nova uses v1, but the extension code is shared between the two iirc | 18:07 |
| *** rushil has quit IRC | 18:10 | |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Add functional post test_hook https://review.openstack.org/175521 | 18:15 |
| jgriffith | mtreinish: cinder is next... then to start moving tests | 18:16 |
| *** nikesh has joined #openstack-cinder | 18:18 | |
| rmstar | do you guys know if i'd leave orphans around if i were to force delete a cinder volume while it is downloading? | 18:21 |
| jgriffith | rmstar: it *shouldn't*, it should handle things like aborting the download and cleaning up after itself | 18:22 |
| jgriffith | rmstar: that's not to say it does... but it *should* :) | 18:22 |
| rmstar | jgriffith: thanks. i understand :) | 18:22 |
| DuncanT | rmstar: Currently, yes it leaves orphan volumes at times, orphan iscsi connections, and all sorts of other mess | 18:25 |
| *** sgotliv has joined #openstack-cinder | 18:29 | |
| *** vilobhmm1 has quit IRC | 18:29 | |
| *** e0ne has joined #openstack-cinder | 18:29 | |
| *** vilobhmm1 has joined #openstack-cinder | 18:31 | |
| *** annashen has quit IRC | 18:37 | |
| rmstar | DuncanT: do you know if there is anyway to clear off the "mess"? | 18:38 |
| *** jcru has quit IRC | 18:40 | |
| mtreinish | thingee: have you seen this: https://review.openstack.org/#/c/166695/ | 18:40 |
| *** jcru has joined #openstack-cinder | 18:41 | |
| mtreinish | thingee: that seems very similar to the issue you are hitting in your ci right? | 18:41 |
| thingee | mtreinish: thanks, checking | 18:41 |
| DuncanT | rmstar: nope, sorry, you can script it but it really needs to be build into cinder I think. We're starting to work on it for liberty | 18:44 |
| *** garthb_ has joined #openstack-cinder | 18:45 | |
| *** garthb has joined #openstack-cinder | 18:45 | |
| *** e0ne is now known as e0ne_ | 18:46 | |
| *** deepakcs has quit IRC | 18:47 | |
| *** rushil has joined #openstack-cinder | 18:49 | |
| *** annashen has joined #openstack-cinder | 18:50 | |
| *** dannywilson has joined #openstack-cinder | 18:52 | |
| *** e0ne_ has quit IRC | 18:54 | |
| *** ebalduf has joined #openstack-cinder | 18:54 | |
| *** pradipta has quit IRC | 18:54 | |
| *** dannywilson has quit IRC | 18:56 | |
| *** e0ne has joined #openstack-cinder | 18:58 | |
| *** annashen has quit IRC | 19:03 | |
| *** annashen has joined #openstack-cinder | 19:03 | |
| e0ne | jgriffith: pep8 failed again on migrations placeholders | 19:07 |
| jgriffith | e0ne: hmm.... looking | 19:09 |
| jgriffith | e0ne: haha... stupid blank lines | 19:09 |
| jgriffith | e0ne: fixing now | 19:09 |
| *** diemt has joined #openstack-cinder | 19:10 | |
| *** deepakcs has joined #openstack-cinder | 19:14 | |
| jms | Where does driver_api come from (as used in cinder.scheduler.flow.create_volume.ScheduleCreateVolumeTask)? Specifically execute() ... I *think* that's where there error I'm getting is comming from ("No weighted host found") ... but I don't know _why_ it's getting that error. If I could figure that out it may help a bit. ;) | 19:21 |
| jms | Could also have something to do with volume.filters ... or in addition to. :/ | 19:21 |
| jgriffith | jungleboyj: hey... what the heck does this do? https://github.com/openstack/cinder/blob/master/cinder/tests/test_hacking.py#L131 | 19:25 |
| jungleboyj | jgriffith: Looking. | 19:26 |
| jgriffith | jungleboyj: hoping you know :) Not sure if you introduced or not | 19:27 |
| jgriffith | jungleboyj: reason I ask is: http://paste.openstack.org/show/204914/ | 19:27 |
| jgriffith | jungleboyj: I have no idea why that's failing | 19:28 |
| jungleboyj | I didn't, but it tests this: https://github.com/openstack/cinder/blob/master/cinder/hacking/checks.py#L118 | 19:28 |
| jungleboyj | Checking to make sure that no one is using assert_called_once_with() | 19:28 |
| jungleboyj | That was pulled over from Nova. | 19:28 |
| jgriffith | jungleboyj: well... yeah, but checking *what* | 19:28 |
| jgriffith | jungleboyj: it's a unit test, checking "something" | 19:29 |
| jgriffith | but I don't know what | 19:29 |
| *** aix has quit IRC | 19:29 | |
| jgriffith | jungleboyj: ie test1.py ? | 19:29 |
| jungleboyj | jgriffith: Oh, ok. | 19:29 |
| jgriffith | jungleboyj: ahhh... hm, I think I see what it's doing | 19:29 |
| jgriffith | it's a hard coded to cinder/tests in the hacking check | 19:30 |
| jungleboyj | jgriffith: So, the first one is making sure that assert_called_with(including a filename) doesn't griffer a fail in the check. | 19:30 |
| jgriffith | which is used by the unit test | 19:30 |
| jgriffith | ewwww | 19:30 |
| jungleboyj | It isn't really using that at all. | 19:30 |
| jgriffith | jungleboyj: wait... what? | 19:30 |
| jungleboyj | It is just a string as that is what is expected as the second argument. Some filename. | 19:30 |
| jgriffith | jungleboyj: so I'm confused.... the second arg is a "filename" | 19:32 |
| jungleboyj | jgriffith: ".assert_called_with(", "cinder/tests/test1.py") is just an example of a logical line that could go through the check. | 19:32 |
| jgriffith | jungleboyj: sure, but we're assertEqual'ing on it and it's failing :) | 19:32 |
| jungleboyj | check.check_assert_called_once( uses that function. | 19:32 |
| jgriffith | jungleboyj: yeah, I get that | 19:32 |
| jungleboyj | Where is that happening? | 19:32 |
| jgriffith | trying to figure out why I'm getting this: http://paste.openstack.org/show/204914/ | 19:33 |
| jgriffith | jungleboyj: see what I mean? | 19:33 |
| jungleboyj | That is bizarre . I am assuming you didn't change anything there? | 19:34 |
| smcginnis | The check's unit test itself is failing. That's new. :{ | 19:34 |
| jgriffith | smcginnis: jungleboyj so I changed a bunch of stuff :) | 19:34 |
| smcginnis | jgriffith: I blame you then. :P | 19:34 |
| jgriffith | smcginnis: jungleboyj I'm in the process of moving tests to test/unit/ | 19:34 |
| jgriffith | smcginnis: there's obviously something I need to change, but no diea what | 19:35 |
| smcginnis | jgriffith: Ah, did you update the exlusion path in https://github.com/openstack/cinder/blob/master/cinder/hacking/checks.py#L123 | 19:35 |
| *** vilobhmm1 has quit IRC | 19:35 | |
| jgriffith | Nope :) | 19:35 |
| jungleboyj | cinder.tests.unit/test1.py | 19:36 |
| jungleboyj | Try changing that to cinder/tests/unit/test1.py | 19:36 |
| *** annegentle has quit IRC | 19:36 | |
| smcginnis | jungleboyj: Shouldn't this line actually be testing assert_called_once? https://github.com/openstack/cinder/blob/master/cinder/tests/test_hacking.py#L135 | 19:36 |
| smcginnis | jungleboyj: But that's besides the point. | 19:36 |
| jgriffith | jungleboyj: in the unit test? thought of that, but the problem is that the other tests pass and I haven't modified them | 19:36 |
| *** bill_az has joined #openstack-cinder | 19:36 | |
| *** crose has joined #openstack-cinder | 19:37 | |
| smcginnis | This is really odd. If the check didn't change and the check's unit test didn't change, then it should still work as expected regardless of where actual tests are located. | 19:37 |
| jungleboyj | Let me try something. | 19:37 |
| jgriffith | smcginnis: one would think | 19:37 |
| jgriffith | smcginnis: but honestly I don't understand how this test works anyway | 19:37 |
| jungleboyj | Give me a minute. | 19:37 |
| smcginnis | jgriffith: No git diff between these two (checks.ph and test_hacking.py)? | 19:37 |
| smcginnis | The check or the check check? :) | 19:38 |
| jgriffith | smcginnis: jungleboyj never mind... I get it! | 19:39 |
| smcginnis | Light bulb! | 19:39 |
| jgriffith | smcginnis: kinda | 19:39 |
| * jungleboyj must not have explained well? | 19:39 | |
| jgriffith | fixed | 19:40 |
| jgriffith | jungleboyj: think maybe it's what you were trying to say | 19:40 |
| smcginnis | jgriffith: Inadvertent change to the check? | 19:40 |
| * jungleboyj waits with baited breat | 19:41 | |
| jungleboyj | breath | 19:41 |
| jgriffith | jungleboyj: so the issue is that the input is cinder.unit/tests | 19:41 |
| jgriffith | jungleboyj: so it wasn't cinder/unit/tests.... | 19:41 |
| jungleboyj | jgriffith: Yep, that was what I was trying to say. :-) | 19:41 |
| jgriffith | jungleboyj: ok... good job then :) | 19:42 |
| jgriffith | jungleboyj: and thanks! | 19:42 |
| jungleboyj | jgriffith: Welcome! | 19:42 |
| rmstar | DuncanT: ok. thanks for your answer | 19:44 |
| *** ronis has quit IRC | 19:45 | |
| *** lpabon has quit IRC | 19:48 | |
| *** vilobhmm1 has joined #openstack-cinder | 19:50 | |
| *** vilobhmm1 has quit IRC | 19:50 | |
| *** vilobhmm1 has joined #openstack-cinder | 19:50 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Reserve 5 migrations for Kilo backports https://review.openstack.org/175490 | 19:52 |
| *** kaisers has quit IRC | 19:56 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Move RBD calls to a separate threads https://review.openstack.org/175555 | 19:56 |
| e0ne | jungleboyj: hi! could you take a look on patch ^^ today if you'll get a time? | 19:57 |
| jungleboyj | e0ne: I just opened it. :-) | 19:57 |
| *** julim has quit IRC | 19:58 | |
| e0ne | jungleboyj: cool. thanks | 19:58 |
| e0ne | it's an alternative for https://review.openstack.org/#/c/145678/ | 19:58 |
| *** liusheng has quit IRC | 19:58 | |
| *** liusheng has joined #openstack-cinder | 19:59 | |
| *** jdurgin1 has joined #openstack-cinder | 19:59 | |
| *** Rockyg has joined #openstack-cinder | 19:59 | |
| *** annashen has quit IRC | 20:02 | |
| *** jdurgin has quit IRC | 20:03 | |
| jungleboyj | e0ne: Just commented. The commit message needs to be cleaned up a bit and then it will be ok. | 20:04 |
| e0ne | jungleboyj: thanks. fixing | 20:05 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Move RBD calls to a separate threads https://review.openstack.org/175555 | 20:10 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Move RBD calls to a separate threads https://review.openstack.org/175555 | 20:10 |
| jungleboyj | Ok, that makes more sense. Thank you. | 20:11 |
| *** jdurgin1 has quit IRC | 20:12 | |
| e0ne | jungleboyj: thanks! | 20:14 |
| jungleboyj | e0ne: You are welcome. | 20:15 |
| e0ne | jungleboyj: i hate such fixes. 2 days tried to find env for reproduce it, half-a-day reading manuals/sources and result is 2 lines of code | 20:15 |
| jungleboyj | :-) | 20:15 |
| jungleboyj | e0ne: It can't all be easy. You learned a lot though, right? | 20:16 |
| e0ne | jungleboyj: yes, you're absolutely right. | 20:16 |
| jungleboyj | e0ne: So, here is a bright side. :-) | 20:17 |
| e0ne | jungleboyj: :) | 20:17 |
| *** crose has quit IRC | 20:20 | |
| *** Yogi1 has quit IRC | 20:23 | |
| mtanino | jungleboyj: Thank you for trying the patch. I need to add more test cases but I'd like to agree the way to fix beforehand :) | 20:26 |
| e0ne | thingee: I verified and change my vote for https://review.openstack.org/#/c/107886/ | 20:26 |
| *** jdurgin has joined #openstack-cinder | 20:26 | |
| jungleboyj | mtanino: Welcome. Yeah, I tried a few times to recreate the failure and didn't see it fail. | 20:27 |
| jungleboyj | You want me to take my +1 off of it if you are planning to do more test cases? | 20:27 |
| mtanino | jungleboyj: nice! | 20:27 |
| mtanino | jungleboyj: yes. now you can lift off you +1 until I will add test cases. | 20:27 |
| jungleboyj | mtanino: Yeah, thank you for figuring that out! | 20:27 |
| jungleboyj | Ok, back in a bit. | 20:28 |
| *** timcl has quit IRC | 20:30 | |
| *** Yogi1 has joined #openstack-cinder | 20:30 | |
| *** akerr has quit IRC | 20:30 | |
| ameade | winston-d: hey if you get a chance, can you let me know if you are good with this patch? https://review.openstack.org/#/c/170990/ | 20:31 |
| * e0ne bb tomorrow | 20:31 | |
| *** jungleboyj has quit IRC | 20:34 | |
| *** Yogi1 has quit IRC | 20:34 | |
| *** deepakcs has quit IRC | 20:37 | |
| *** Yogi1 has joined #openstack-cinder | 20:43 | |
| *** Lee1092 has quit IRC | 20:51 | |
| *** eharney has quit IRC | 20:54 | |
| *** e0ne has quit IRC | 20:55 | |
| *** annegent_ has joined #openstack-cinder | 20:55 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: WIP: Remove Brick from cinder codebase https://review.openstack.org/155552 | 20:57 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: WIP: Remove Brick from cinder codebase https://review.openstack.org/155552 | 20:57 |
| smcginnis | hemna: Just noticed something. One of the emails I got for the summit said the presentation should be formatted 16:9. | 20:59 |
| hemna | ?! | 20:59 |
| smcginnis | hemna: How to change: http://askubuntu.com/questions/139053/how-to-change-a-libreoffice-impress-presentation-from-43-to-169-ratio | 20:59 |
| smcginnis | hemna: Widescreen only I guess. | 20:59 |
| hemna | uhh | 21:00 |
| hemna | where are the requirements to switch it to 16:9 ? | 21:00 |
| smcginnis | hemna: Did you get an email titled "OpenStack Speaker Information"? | 21:01 |
| hemna | I'm sure I did | 21:01 |
| hemna | :) | 21:01 |
| hemna | I'm looking | 21:01 |
| smcginnis | hemna: "please come prepared with your VGA or DVI compatible laptop with your 16:9 presentation loaded and ready to present." | 21:02 |
| hemna | hrmm yah I see that | 21:02 |
| hemna | bleh | 21:02 |
| hemna | I was actually going to start hacking on my slides | 21:02 |
| smcginnis | Doesn't look like it messes up the format too badly. | 21:03 |
| hemna | yah I just tried switching | 21:03 |
| hemna | just kinda lost some vertical resolution | 21:04 |
| hemna | but fine otherwise ? | 21:04 |
| *** Yogi1 has quit IRC | 21:05 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: Fix range check for NFS used ratio https://review.openstack.org/175573 | 21:08 |
| *** bswartz has quit IRC | 21:09 | |
| *** xyang has quit IRC | 21:17 | |
| thingee | mtreinish: trying that patch now | 21:18 |
| mtreinish | thingee: cool, hopefully it'll work. I have no idea tbh | 21:25 |
| mtreinish | I just saw it go by somewhere and it looked on point | 21:25 |
| *** jaypipes has quit IRC | 21:26 | |
| *** e0ne has joined #openstack-cinder | 21:30 | |
| *** mwichmann has joined #openstack-cinder | 21:30 | |
| thingee | mtreinish: no dice =/ | 21:33 |
| mtreinish | oh well, it was worth a shot at least | 21:34 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/python-cinderclient: Add volume multi attach support https://review.openstack.org/85856 | 21:35 |
| *** e0ne has quit IRC | 21:35 | |
| *** lpetrut has quit IRC | 21:35 | |
| *** bswartz has joined #openstack-cinder | 21:38 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Move unit tests into dedicated directory https://review.openstack.org/175583 | 21:39 |
| jgriffith | thingee: DuncanT hemna ^^ | 21:40 |
| jgriffith | It would be *best* to rip the band-aid and merge that sooner rather than later | 21:40 |
| hemna | jgriffith, is this in prep for creating cinder/tests/tempest ? | 21:40 |
| *** mwichmann has left #openstack-cinder | 21:40 | |
| jgriffith | Better to let each patch in the queue rebase, as opposed to try and refactor that monster over and over and over until I dide | 21:41 |
| jgriffith | die | 21:41 |
| *** erlon has quit IRC | 21:41 | |
| mtreinish | hemna: wait, what is cinder/tests/tempest ? | 21:41 |
| thingee | hemna: in general, it's something we've been wanting to do for some time. | 21:41 |
| jgriffith | mtreinish: maybe that's something hemna is workign on? | 21:42 |
| thingee | hemna: splitting out unit tests | 21:42 |
| jgriffith | hemna: functional vs unit | 21:42 |
| hemna | I thought folks were looking at pulling in tempest tests into each project instead them living in the tempest project ? | 21:42 |
| hemna | maybe i'm drunk. dunno | 21:42 |
| jgriffith | hemna: drunk!!! | 21:43 |
| hemna | :P | 21:43 |
| jgriffith | hemna: it's 2:43!!! | 21:43 |
| mtreinish | hemna: well that's something tons of people are confused about. Because there is a push for projects to spin up functional testing | 21:43 |
| jgriffith | 14:43 to be more clear | 21:43 |
| hemna | it's 5:43 somewhere | 21:43 |
| jgriffith | hemna: you're close... it's spin up functional tests in the project using tempest-lib | 21:43 |
| mtreinish | but that's doesn't necessarily mean pulling tempest tests into each project | 21:43 |
| hemna | I see | 21:43 |
| hemna | cool | 21:43 |
| *** jungleboyj has joined #openstack-cinder | 21:43 | |
| mtreinish | jgriffith: well functional test don't necessarily have to use tempest-lib either. Only if it makes sense for what you're trying to test | 21:44 |
| mtreinish | like the nova functional tests have a good pattern for functional testing pieces without needing tempest-lib | 21:44 |
| jgriffith | mtreinish: fair enough | 21:44 |
| jgriffith | hemna: just one typo in teh commit message? That's my only mistake WooHooooo!!!! | 21:45 |
| hemna | :P | 21:45 |
| mtreinish | jgriffith: btw that change is gonna be total rebase hell for everyone else :) | 21:46 |
| jgriffith | mtreinish: I know | 21:46 |
| jgriffith | mtreinish: it's them or me | 21:46 |
| hemna | mtreinish, hence the hope that it lands first! | 21:46 |
| hemna | :P | 21:46 |
| jgriffith | mtreinish: I don't know of another way to go about it, do you? | 21:46 |
| mtreinish | nope | 21:46 |
| *** dustins has quit IRC | 21:47 | |
| jgriffith | mtreinish: and there's significantly higher risk of *me* breaking all the onesie twosies | 21:47 |
| jgriffith | mtreinish: and I know we'll never get everybody to cut the chord and build off of this | 21:47 |
| jgriffith | :) | 21:47 |
| jgriffith | so I'm throwing the chaos grenade in | 21:47 |
| mtreinish | jgriffith: well it really comes down to how much you want to be stat padding | 21:48 |
| jgriffith | mtreinish: LOL | 21:48 |
| mtreinish | because you know stackalytics brings in the money | 21:48 |
| jgriffith | mtreinish: not at my company :( | 21:48 |
| jgriffith | mtreinish: but I've heard | 21:48 |
| hemna | didn't thingee win that one in Kilo | 21:49 |
| hemna | with all the driver removal patches ? | 21:49 |
| hemna | :P | 21:49 |
| jgriffith | mtreinish: I get paid the same if it's one line or a billion, or ZERO commits vs 1000 | 21:49 |
| jgriffith | mtreinish: since they're all renames they don't mean squat anyway | 21:49 |
| jgriffith | mtreinish: besides... I thought you wanted me to get cracking on moving some tests around :) | 21:50 |
| mtreinish | jgriffith: sure but does your company get paid more if solidfire is contrib #30 instead of #31 :) | 21:50 |
| mtreinish | oh or think of the headlines | 21:50 |
| mtreinish | jgriffith: you could get something like: http://thenewstack.io/openstack-code-contribution-trends/ | 21:51 |
| mtreinish | which has the best comment about sdague at samsung | 21:51 |
| jgriffith | Holy shit, WTF is that! | 21:51 |
| jgriffith | Ddue, that's just sad | 21:52 |
| jgriffith | really F'ing sad | 21:52 |
| *** jcru has quit IRC | 21:52 | |
| *** mriedem is now known as mriedem_away | 21:53 | |
| * jgriffith needs to find a new project to work on... no more room here | 21:53 | |
| mtreinish | jgriffith: hehe, I've got a couple that no one cares about. I'd love contribs on https://github.com/mtreinish/powerpyspice | 21:55 |
| jgriffith | mtreinish: so does that mean I have to leave tha twork to someobdy from Redhat, HP, Mirantis or IBM? | 21:55 |
| jgriffith | mtreinish: tisk-tisk... no README | 21:56 |
| hemna | spice | 21:56 |
| hemna | is this Dune ? | 21:56 |
| mtreinish | tbh, I only ever worked on it for a little bit. I would like to pick it up again soon | 21:56 |
| mtreinish | hemna: that would probably be cooler than what it really is | 21:57 |
| mtreinish | I just wrote it in anger after I started using the circuit simulation visualization tools at IBM which were the best 1982 had to offer | 21:58 |
| hemna | hehe | 21:58 |
| jgriffith | mtreinish: it's funny, after moving away from EE work I though for sure I'd be doing SPICE or FPGA etc | 21:59 |
| jgriffith | haven't done a ckt analysis in forever... closest I came was buildign my barn and doing the power budget | 21:59 |
| mtreinish | jgriffith: up until about 1.5 years ago I thought that I was going to switch over to a mainframe SRAM design group at ibm | 22:02 |
| mtreinish | but they never found the budget to transfer me for reals | 22:02 |
| mtreinish | so I haven't really touched ckt stuff since then either | 22:03 |
| mtreinish | unless you count rewiring my car's audio system :) | 22:03 |
| *** melwitt has quit IRC | 22:04 | |
| *** jms has quit IRC | 22:07 | |
| patrickeast | i recall seeing folks discussing issues with test_volume_boot_pattern, is that still in progress? | 22:14 |
| patrickeast | wasn’t sure which bug was related to it | 22:14 |
| smcginnis | thingee: ^^ That was you, wasn't it? | 22:21 |
| smcginnis | patrickeast: I seem to recall it being an issue with nova calling things out of sequence. | 22:21 |
| thingee | patrickeast: I'm hitting an issue with my ci | 22:21 |
| patrickeast | thingee: same :( | 22:22 |
| patrickeast | looking into intermittent issues this week | 22:22 |
| patrickeast | wanted to see if it was the same issue or not | 22:22 |
| patrickeast | thingee: do you have a bug open for yours? | 22:23 |
| thingee | patrickeast: no | 22:24 |
| thingee | patrickeast: here's an example of mine though with volumebootpatternv2... http://paste.openstack.org/raw/204927/ | 22:25 |
| thingee | same request, creates a volume, then eventually does a remove export | 22:25 |
| thingee | while the convert is happening | 22:25 |
| thingee | mtreinish: ^ | 22:25 |
| *** rushil has quit IRC | 22:25 | |
| thingee | once that remove export happens, then nova complains there's no session | 22:26 |
| patrickeast | thingee: hmm interesting, i’ll have to go dig through my vol log and see if that happens for me too | 22:27 |
| patrickeast | thingee: i end up getting a timeout in the actual test as the failure reason, do you see that too? | 22:27 |
| patrickeast | http://ec2-54-67-51-189.us-west-1.compute.amazonaws.com/90/175490/2/check/PureISCSIDriver-tempest-dsvm-volume-multipath-chap/e188f05/ | 22:27 |
| thingee | actually this maybe correct behavior for me. it's suppose to eventually detach the volume after copy volume to image | 22:27 |
| mtreinish | thingee: would that be related to: https://review.openstack.org/#/c/171569/8 | 22:27 |
| mtreinish | which I'm still not sure whether it's a valid change or not | 22:27 |
| mtreinish | I wasn't able to reproduce that reported bug | 22:28 |
| patrickeast | i saw https://bugs.launchpad.net/tempest/+bug/1298472 which describes my symptoms exactly, but it kind of looks like this is a catch-all for something broke and the test timed out | 22:28 |
| openstack | Launchpad bug 1298472 in tempest "SSHTimeout in tempest trying to verify that computes are actually functioning" [Critical,New] - Assigned to Matt Riedemann (mriedem) | 22:28 |
| mtreinish | patrickeast: yeah that's pretty much what it is. Debugging why tempest fails to ssh into a guest 196 secs after nova says it's available is very hard | 22:30 |
| mtreinish | patrickeast: oh but in that case it wasn't the ssh which caused the timeout (well it is but sort of) | 22:32 |
| mtreinish | patrickeast: that test hit the per test timeout to ensure we don't hang forever | 22:32 |
| mtreinish | patrickeast: look at "20:59:55 Captured traceback:" in that console log | 22:32 |
| thingee | patrickeast: ah, yeah I'm not having that problem | 22:32 |
| mtreinish | that's the timeout fixture which will kill a test if OS_TEST_TIMEOUT is elapsed (it defaults to 500 in .testr.conf in tempest) | 22:33 |
| patrickeast | mtreinish: ooo yea its the fixture timeout | 22:33 |
| patrickeast | iirc i set that extra high… | 22:33 |
| * patrickeast checks the config | 22:33 | |
| mtreinish | patrickeast: yeah you did | 22:34 |
| mtreinish | look right below that | 22:34 |
| mtreinish | it killed it after 1209.126 secs | 22:34 |
| patrickeast | ah yep | 22:34 |
| mtreinish | so something is really slow in your env | 22:34 |
| patrickeast | i set it to 1200 | 22:34 |
| patrickeast | so what i’ve noticed is that when it works, its like 160 tops | 22:35 |
| patrickeast | i set it to 1200 to see if maybe it needed more time | 22:35 |
| patrickeast | but its either ~2 min or never seems to finish | 22:35 |
| patrickeast | although maybe i’m just overloading this initiator | 22:36 |
| *** jaypipes has joined #openstack-cinder | 22:37 | |
| thingee | patrickeast: when did your issue start happening? | 22:44 |
| Swanson | I've seen something like that every so often. I haven't checked the latest round from our ci to know if it is still happening. | 22:45 |
| patrickeast | thingee: its been occurring over the last week or two since i got my system moved into a DMZ and back online, not sure exactly when something would have been introduced since it was off for about 3 weeks waiting until we fixed the security issues | 22:45 |
| patrickeast | terrible timing with the release cycle… but it is what it is | 22:45 |
| *** _cjones_ has quit IRC | 22:46 | |
| mtreinish | patrickeast: yeah I can't really say one way or the other | 22:46 |
| mtreinish | nothing really stands out in the logs as causing a failure from a quick glance | 22:46 |
| mtreinish | I would have expected something to timeout somewhere after waiting so long | 22:46 |
| mtreinish | maybe on your san (or whatever hardware you're testing with) | 22:47 |
| patrickeast | yea i’m almost thinking it might be a network issue with my openstack provider nodepool is using to spin these devstack vm’s up on | 22:47 |
| thingee | patrickeast: I haven't figured out yet if mine is related to the multi-attach change. It's hard to tell, because my ci passes if I use a patch before multi-attach, but also the multi-attach patch caused a series of changes in nova and tempest | 22:47 |
| openstackgerrit | John Griffith proposed openstack/cinder: Move unit tests into dedicated directory https://review.openstack.org/175583 | 22:48 |
| patrickeast | hmm interesting, that would make sense that it could have caused some issues | 22:48 |
| patrickeast | touched a lot of code paths | 22:48 |
| patrickeast | mtreinish: yea i’ve looked into issues with our data paths, but the iscsi stuff all seems ok | 22:48 |
| thingee | but I have raised an issue where cinder is returning an exception that nova isn't expecting. | 22:48 |
| thingee | that was introduced in multi-attach | 22:49 |
| thingee | mtreinish: which by the way, catching that exception did not help | 22:49 |
| *** _cjones_ has joined #openstack-cinder | 22:49 | |
| mtreinish | thingee: really, did it just fail later on? | 22:49 |
| jgriffith | thingee: patrickeast if each of you want to send me a datera cluster and pure array I'll be happy to help troubleshoot :) | 22:50 |
| patrickeast | hah | 22:50 |
| jgriffith | thingee: patrickeast make sure you opt for the insurance on the shipping :) | 22:50 |
| thingee | heh | 22:51 |
| mtreinish | jgriffith: heh, that's a good idea, I wish I had thought of it. My home array could always use a boost | 22:51 |
| jgriffith | mtreinish: "Griffith resellers" | 22:52 |
| thingee | just got a recruiter email with just buzz words. it's literally devopsclouddockertestdrivendevelopmentcontinuousintegration | 22:52 |
| jgriffith | thingee: you should jump all over that one! NOT | 22:52 |
| thingee | jgriffith: ha! | 22:52 |
| thingee | griffith resellers | 22:52 |
| thingee | I'm imagining walking on a farm and then inside a barn there are server racks. | 22:53 |
| hemna | powered by horse manure | 22:53 |
| * thingee used to imagine that's what jgriffith's "lab" was | 22:53 | |
| thingee | laugh all you want, but you city slickers with your drought and fancy silicon valley will be coming back to old mcdonald. | 22:54 |
| hemna | dried out, it can burn the boil water turn a turbine. | 22:54 |
| hemna | :P | 22:55 |
| *** annegent_ has quit IRC | 22:57 | |
| thingee | xyang1: besides jenkins complaining, the incremental doc makes sense to me. thanks | 22:59 |
| thingee | incremental backup* | 22:59 |
| *** rmesta has quit IRC | 23:01 | |
| *** annashen has joined #openstack-cinder | 23:03 | |
| *** hemna is now known as hemnafk | 23:07 | |
| *** annashen has quit IRC | 23:08 | |
| openstackgerrit | Jay Bryant proposed openstack/cinder: Add hacking check for str and unicode in exceptions https://review.openstack.org/175604 | 23:11 |
| patrickeast | thingee: if you have a chance can you target some bp’s for me? i’ve got a few for L-1 | 23:11 |
| patrickeast | lemmie know if its easiest to email a list or post links here | 23:13 |
| *** jungleboyj has quit IRC | 23:15 | |
| *** mdenny has quit IRC | 23:16 | |
| thingee | jgriffith, mtreinish: so what I've observed now is that in the volumebootpattern, the second instance it brings up with the volume it originally created, it never does an export. I see the volume is in-use in cinder, but I don't see an export happening, so it's like initialize connection is not happening. | 23:18 |
| thingee | https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L156 | 23:18 |
| thingee | the export definitely is there for the first instance though, but is gone after the instance is deleted and the volume is detached | 23:22 |
| *** lcurtis has quit IRC | 23:22 | |
| *** IanGovett has quit IRC | 23:26 | |
| *** esker has quit IRC | 23:27 | |
| thingee | take that back, initialize_connection is definitely happening | 23:28 |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Introduce functional testing to cinderlcient https://review.openstack.org/175512 | 23:29 |
| openstackgerrit | John Griffith proposed openstack/cinder: Move unit tests into dedicated directory https://review.openstack.org/175583 | 23:30 |
| thingee | jgriffith: spelled cinderclient wrong ^ | 23:30 |
| thingee | :) | 23:30 |
| jgriffith | thingee: must not be a problem since you knew it was cinderclient :) | 23:31 |
| jgriffith | thingee: send me a new keyboard :) Mine sucks :) | 23:31 |
| thingee | haha | 23:31 |
| thingee | jgriffith: I'll send you a das keyboard with no labels! | 23:31 |
| jgriffith | LMAO | 23:31 |
| jgriffith | Couldn't be any worse | 23:31 |
| jgriffith | mtreinish: ok... now, trying to remember what our priorities were for test moves? | 23:32 |
| thingee | with the cherry blue key switches. your co-workers and wife will love you. | 23:32 |
| jgriffith | thingee: I have my old IBM keyboard from 1993... it's clicky-clacky enough | 23:32 |
| thingee | oh nice! I like those | 23:33 |
| jgriffith | thingee: and my Gold Touch... which I'm not allowed to use in the house any more :) | 23:33 |
| thingee | HA | 23:33 |
| mtreinish | jgriffith: I win Model M from 92 :) | 23:33 |
| jgriffith | mtreinish: ha! Nice | 23:33 |
| jgriffith | mtreinish: mine is just on display on my desk at work now | 23:33 |
| thingee | mtreinish: that adapter to USB is slowing down your keystrokes | 23:33 |
| thingee | !! | 23:33 |
| openstack | thingee: Error: "!" is not a valid command. | 23:33 |
| jgriffith | mtreinish: every once in a while someobdy walks by and goes "Ohhh wow!" | 23:34 |
| mtreinish | I have one older than me, but I didn't want to deal with the adapter to get it working on my computer | 23:34 |
| *** arif-ali has quit IRC | 23:34 | |
| *** chlong has joined #openstack-cinder | 23:34 | |
| mtreinish | jgriffith: priorities for test moves? | 23:35 |
| *** ebalduf has quit IRC | 23:35 | |
| jgriffith | mtreinish: yeah... tempest--->cinder | 23:37 |
| jgriffith | mtreinish: there were some inparticular that you guys were sick of dealing with I thought :) | 23:37 |
| mtreinish | jgriffith: heh, is that a trick question? :) | 23:39 |
| jgriffith | mtreinish: LOL... not trick, but loaded ;) | 23:40 |
| mtreinish | jgriffith: but if you're thinking about it, I would look at: https://wiki.openstack.org/wiki/QA/Tempest-test-removal first | 23:40 |
| *** Rockyg has quit IRC | 23:41 | |
| jgriffith | mtreinish: That's exactly what I was looking for | 23:41 |
| mtreinish | jgriffith: fwiw, I think the tests which are valuable are those which are really testing an internal cinder function indirectly | 23:42 |
| mtreinish | valuable to move | 23:42 |
| mtreinish | also I expect a bunch of the negative tests are valid to migrate too | 23:43 |
| jgriffith | mtreinish: which there are a lot of IMO | 23:43 |
| mtreinish | because most of them just test the api layer and maybe some db | 23:43 |
| jgriffith | mtreinish: yeah, I just thought I saw something in my logs between you and sdague about something being "gone soon" | 23:44 |
| *** david-ly_ has joined #openstack-cinder | 23:44 | |
| mtreinish | jgriffith: oh we might have just been talking about the cli tests :) | 23:44 |
| jgriffith | mtreinish: yeah, looking back that's what it was | 23:44 |
| mtreinish | jgriffith: but sdague's nova flavor functional tests are a really good example of what we should be doing for functional testing: https://review.openstack.org/#/c/160423/ | 23:45 |
| *** jamielennox|away is now known as jamielennox | 23:45 | |
| mtreinish | well not self approving with only 1 +2 | 23:45 |
| mtreinish | :) | 23:45 |
| *** david-ly_ is now known as david-lyle | 23:46 | |
| *** mtanino has quit IRC | 23:46 | |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Add functional post test_hook https://review.openstack.org/175521 | 23:52 |
| *** garthb_ has quit IRC | 23:53 | |
| *** garthb has quit IRC | 23:53 | |
| *** annegentle has joined #openstack-cinder | 23:57 | |
| *** openstackgerrit has quit IRC | 23:58 | |
| *** openstackgerrit has joined #openstack-cinder | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!