| *** annegentle has quit IRC | 00:04 | |
| *** ebalduf has joined #openstack-cinder | 00:08 | |
| *** melwitt has joined #openstack-cinder | 00:10 | |
| *** ebalduf has quit IRC | 00:12 | |
| *** patrickeast has quit IRC | 00:14 | |
| *** tsekiyam_ has joined #openstack-cinder | 00:22 | |
| *** openstackgerrit has quit IRC | 00:22 | |
| *** openstackgerrit has joined #openstack-cinder | 00:23 | |
| *** tsekiya__ has joined #openstack-cinder | 00:24 | |
| *** tsekiyam_ has quit IRC | 00:24 | |
| *** tsekiya__ has quit IRC | 00:24 | |
| *** tsekiyama has quit IRC | 00:26 | |
| *** _cjones_ has quit IRC | 00:26 | |
| *** _cjones_ has joined #openstack-cinder | 00:28 | |
| *** arif-ali has joined #openstack-cinder | 00:33 | |
| *** _cjones_ has quit IRC | 00:34 | |
| *** openstack has joined #openstack-cinder | 00:36 | |
| *** leeantho has quit IRC | 00:39 | |
| thingee | mtreinish: success got to here http://paste.openstack.org/show/204931/ | 00:44 |
|---|---|---|
| *** emagana has quit IRC | 00:54 | |
| *** Lee1092 has joined #openstack-cinder | 01:00 | |
| *** heyun has joined #openstack-cinder | 01:01 | |
| *** theanalyst has quit IRC | 01:04 | |
| *** theanalyst has joined #openstack-cinder | 01:07 | |
| *** Yogi1 has joined #openstack-cinder | 01:18 | |
| *** zhenguo has joined #openstack-cinder | 01:21 | |
| *** _cjones_ has joined #openstack-cinder | 01:29 | |
| *** _cjones_ has quit IRC | 01:34 | |
| *** vilobhmm1 has quit IRC | 01:45 | |
| *** melwitt has quit IRC | 01:51 | |
| *** bkopilov has quit IRC | 01:53 | |
| *** lcurtis has joined #openstack-cinder | 02:05 | |
| *** liusheng has quit IRC | 02:16 | |
| *** sks has joined #openstack-cinder | 02:27 | |
| *** _cjones_ has joined #openstack-cinder | 02:31 | |
| *** Yogi1 has quit IRC | 02:32 | |
| *** _cjones_ has quit IRC | 02:35 | |
| *** harlowja is now known as harlowja_away | 02:35 | |
| *** harlowja_away is now known as harlowja | 02:37 | |
| *** asselin__ has quit IRC | 02:54 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Create initiator id for VMAX iSCSI driver https://review.openstack.org/175696 | 03:12 |
| *** sks has quit IRC | 03:13 | |
| *** bkopilov has joined #openstack-cinder | 03:19 | |
| *** _cjones_ has joined #openstack-cinder | 03:37 | |
| *** _cjones_ has quit IRC | 03:42 | |
| *** annashen has joined #openstack-cinder | 03:42 | |
| *** lpetrut has joined #openstack-cinder | 03:49 | |
| *** harlowja is now known as harlowja_away | 03:56 | |
| *** BharatK has joined #openstack-cinder | 04:04 | |
| *** annashen has quit IRC | 04:05 | |
| *** annashen has joined #openstack-cinder | 04:06 | |
| *** annashen has quit IRC | 04:11 | |
| *** ishant has joined #openstack-cinder | 04:26 | |
| *** _cjones_ has joined #openstack-cinder | 04:38 | |
| *** _cjones_ has quit IRC | 04:44 | |
| *** annashen has joined #openstack-cinder | 04:45 | |
| *** vilobhmm1 has joined #openstack-cinder | 04:50 | |
| *** Longgeek has joined #openstack-cinder | 04:52 | |
| *** lcurtis has quit IRC | 04:52 | |
| *** zhenguo has quit IRC | 04:57 | |
| openstackgerrit | Yoshihide Matsumoto proposed openstack/cinder: Fix tiny typo: compatability => compatibility https://review.openstack.org/175712 | 04:58 |
| *** emagana has joined #openstack-cinder | 05:02 | |
| openstackgerrit | Alon Marx proposed openstack/cinder: Add Multi-connection support to XIV https://review.openstack.org/175186 | 05:03 |
| *** emagana has quit IRC | 05:16 | |
| *** tshefi has joined #openstack-cinder | 05:16 | |
| *** emagana has joined #openstack-cinder | 05:17 | |
| *** deepakcs has joined #openstack-cinder | 05:18 | |
| *** emagana has quit IRC | 05:21 | |
| *** nkrinner has joined #openstack-cinder | 05:21 | |
| *** dannywilson has joined #openstack-cinder | 05:23 | |
| *** dannywilson has quit IRC | 05:23 | |
| *** dannywilson has joined #openstack-cinder | 05:24 | |
| *** heyun has quit IRC | 05:31 | |
| *** afazekas has quit IRC | 05:31 | |
| *** _cjones_ has joined #openstack-cinder | 05:41 | |
| *** anshul has joined #openstack-cinder | 05:43 | |
| *** heyun has joined #openstack-cinder | 05:50 | |
| *** lihit has joined #openstack-cinder | 05:59 | |
| *** lihit has quit IRC | 05:59 | |
| *** ishant has quit IRC | 06:05 | |
| *** alecv has joined #openstack-cinder | 06:13 | |
| *** lpetrut has quit IRC | 06:18 | |
| *** _cjones_ has quit IRC | 06:19 | |
| *** afazekas_ has joined #openstack-cinder | 06:21 | |
| *** annashen has quit IRC | 06:23 | |
| *** sgotliv has quit IRC | 06:29 | |
| *** jamielennox is now known as jamielennox|away | 06:34 | |
| openstackgerrit | Jeegn Chen proposed openstack/cinder: Make VNX Cinder Driver aware of VNX Pool Full Threshold https://review.openstack.org/175247 | 06:48 |
| *** vilobhmm11 has joined #openstack-cinder | 06:50 | |
| *** vilobhmm1 has quit IRC | 06:51 | |
| *** kaisers has joined #openstack-cinder | 06:54 | |
| *** vilobhmm11 has quit IRC | 06:54 | |
| *** angela-s has quit IRC | 07:03 | |
| *** zhenguo has joined #openstack-cinder | 07:10 | |
| *** kaisers has quit IRC | 07:11 | |
| *** pcaruana has quit IRC | 07:11 | |
| *** bill_az has quit IRC | 07:14 | |
| *** avishay has joined #openstack-cinder | 07:15 | |
| *** arif-ali has quit IRC | 07:20 | |
| *** arif-ali has joined #openstack-cinder | 07:21 | |
| *** kaisers has joined #openstack-cinder | 07:21 | |
| *** ronis has joined #openstack-cinder | 07:23 | |
| *** afazekas_ has quit IRC | 07:32 | |
| *** afazekas_ has joined #openstack-cinder | 07:36 | |
| *** jamielennox|away is now known as jamielennox | 07:43 | |
| *** jistr has joined #openstack-cinder | 07:47 | |
| *** sgotliv has joined #openstack-cinder | 07:55 | |
| *** aviramb has joined #openstack-cinder | 07:56 | |
| *** Miouge has joined #openstack-cinder | 07:58 | |
| openstackgerrit | Kamil Rykowski proposed openstack/cinder: Leverage dict comprehension in PEP-0274 https://review.openstack.org/143851 | 08:00 |
| *** avishay has quit IRC | 08:04 | |
| *** avishay has joined #openstack-cinder | 08:04 | |
| *** smoriya has joined #openstack-cinder | 08:09 | |
| *** jordanP has joined #openstack-cinder | 08:16 | |
| *** sgotliv has quit IRC | 08:23 | |
| *** e0ne has joined #openstack-cinder | 08:34 | |
| *** ankit_ag has joined #openstack-cinder | 08:37 | |
| *** dannywilson has quit IRC | 08:41 | |
| *** Longgeek has quit IRC | 08:42 | |
| *** ronis has quit IRC | 08:44 | |
| *** coolsvap|afk is now known as coolsvap | 08:45 | |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Add missing backups entry to default quota class https://review.openstack.org/174941 | 08:46 |
| *** sgotliv has joined #openstack-cinder | 08:46 | |
| *** deepakcs has quit IRC | 08:46 | |
| *** coolsvap is now known as coolsvap|afk | 08:46 | |
| *** sgotliv has quit IRC | 09:07 | |
| *** Longgeek has joined #openstack-cinder | 09:14 | |
| *** deepakcs has joined #openstack-cinder | 09:15 | |
| *** lpetrut has joined #openstack-cinder | 09:36 | |
| *** alexpilotti has quit IRC | 09:37 | |
| *** _cjones_ has joined #openstack-cinder | 09:51 | |
| *** lpetrut has quit IRC | 09:54 | |
| *** _cjones_ has quit IRC | 09:55 | |
| *** e0ne is now known as e0ne_ | 10:02 | |
| *** e0ne_ is now known as e0ne | 10:04 | |
| *** boris-42 has quit IRC | 10:05 | |
| *** kaisers has quit IRC | 10:06 | |
| *** boris-42 has joined #openstack-cinder | 10:08 | |
| *** guitarzan has quit IRC | 10:09 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Move RBD calls to a separate threads https://review.openstack.org/175555 | 10:14 |
| *** IanGovett has joined #openstack-cinder | 10:22 | |
| *** nlevinki has joined #openstack-cinder | 10:30 | |
| *** e0ne is now known as e0ne_ | 10:33 | |
| *** e0ne_ is now known as e0ne | 10:34 | |
| *** xyang1 has quit IRC | 10:35 | |
| *** lpetrut has joined #openstack-cinder | 10:36 | |
| *** heyun has quit IRC | 10:39 | |
| *** BharatK has quit IRC | 11:02 | |
| *** jistr has quit IRC | 11:02 | |
| *** jistr has joined #openstack-cinder | 11:04 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Implement blueprint: check-volume-exists https://review.openstack.org/175809 | 11:06 |
| *** yuriy_n17 has joined #openstack-cinder | 11:09 | |
| *** BharatK has joined #openstack-cinder | 11:15 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Move RBD calls to a separate threads https://review.openstack.org/175555 | 11:16 |
| yuriy_n17 | DuncanT: Hi | 11:18 |
| yuriy_n17 | DuncanT: I'd like to discuss your comments about REST API in https://review.openstack.org/#/c/174823/2/specs/liberty/check-volume-exists.rst | 11:20 |
| *** rongze has joined #openstack-cinder | 11:29 | |
| *** avishay has quit IRC | 11:35 | |
| tbarron | e0ne: I was just going to ask you what you thought about the eventlet.sleep(0) calls in cinder backup! Saw your remark in https://review.openstack.org/175555. | 11:35 |
| tbarron | e0ne: will follow your investigation with interest. | 11:35 |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/cinder: Service object https://review.openstack.org/160417 | 11:35 |
| e0ne | tbarron: hi! thanks for review! | 11:36 |
| tbarron | e0ne: yw | 11:36 |
| *** avishay has joined #openstack-cinder | 11:36 | |
| e0ne | tbarron: eventlet.sleep resolves other problem, i need some time to get working env and test cinder-backup with volumes >100GB | 11:37 |
| *** BharatK has quit IRC | 11:38 | |
| *** _cjones_ has joined #openstack-cinder | 11:40 | |
| *** alexpilotti has joined #openstack-cinder | 11:40 | |
| tbarron | e0ne: well, I'm interested in learning more. I was thinking that the eventlet.sleep after each chunk in backup was supposed to prevent backup/restore of large volumes from blocking other tasks. | 11:43 |
| e0ne | tbarron: it's true. but it works only if eventlet can patch blocking calls | 11:44 |
| *** deepakcs has quit IRC | 11:45 | |
| e0ne | tbarron: at least, we need to check how backup delete works | 11:46 |
| e0ne | tbarron: it could take a lot of time to delete 1TB backup | 11:47 |
| tbarron | e0ne: so you would expect problems only for delete, not backup create or restore, then? | 11:47 |
| *** _cjones_ has quit IRC | 11:47 | |
| e0ne | tbarron: it depends on chunk size. default value 128MB is small enough for quick operations | 11:48 |
| *** ronis has joined #openstack-cinder | 11:48 | |
| e0ne | tbarron: but creating a new backup for a large volume could take a lot of time. need to go deeper into the code to be sure | 11:49 |
| *** sgotliv has joined #openstack-cinder | 11:49 | |
| tbarron | e0ne: I think DuncanT told me they use a bigger chunk size in HP public cloud. I certainly would do that with NFS backup (where chunk size is preseneted as backup file size). | 11:49 |
| tbarron | So this is an area I need to learn about :-) | 11:50 |
| tbarron | For delete we could presumably just do a soft delete (say, a rename) and run some background cleanup job. | 11:50 |
| e0ne | tbarron: imo, soft deletes could raise new errors. we could try to delete in background and leave backupd in a deliting state until it's finished | 11:57 |
| tbarron | e0ne: I was thinking the state could change right away and the cleanup could be done lazily. Probably makes more sense with NFS backup than with Swift. | 12:00 |
| tbarron | Not an essential idea for the discussion right now. | 12:00 |
| tbarron | The main thing is to understand the performance impact with large files as you suggest. | 12:00 |
| tbarron | For deletes, but also for backup and restore with large chunk sizes. | 12:01 |
| e0ne | tbarron: what heppen if we change status to deleted and it will failed during lazy delete? | 12:01 |
| tbarron | I was planning to use large chunk sizes for NFS backup but I don't want to block other tasks. | 12:02 |
| *** markvoelker has joined #openstack-cinder | 12:02 | |
| tbarron | e0ne: for file system based backup you could just have a periodic task that cleans up the files. If it fails one time, it would get them the next time. | 12:03 |
| *** markvoelker_ has joined #openstack-cinder | 12:03 | |
| tbarron | If they were renamed out of the way, who cares except for eventual space/capacity issues in the backup repository? | 12:03 |
| *** markvoelker_ has quit IRC | 12:04 | |
| tbarron | And you better have a lot of space there anyways if you are going to use it for backup! | 12:04 |
| tbarron | But as I say, that is just a side issue. I'm not attached to the idea at the moment. | 12:04 |
| *** markvoelker_ has joined #openstack-cinder | 12:05 | |
| *** kaisers has joined #openstack-cinder | 12:06 | |
| *** markvoelker has quit IRC | 12:07 | |
| e0ne | imo, we need to notify users/admins if something went wrong not only via log messages | 12:08 |
| tbarron | e0ne: what do you have in mind for notification? | 12:09 |
| *** thangp has joined #openstack-cinder | 12:09 | |
| e0ne | notifications, error state in db or something else | 12:09 |
| e0ne | because not all users/operators have access to logs | 12:10 |
| tbarron | e0ne: I would agree with that. | 12:10 |
| e0ne | and we need to take care on correct capacity and quotas | 12:11 |
| *** bkopilov has quit IRC | 12:12 | |
| tbarron | e0ne: again, I agree with the general principle. | 12:12 |
| tbarron | e0ne: I was just more casual about lazily, asynchronously cleaning up files already marked for deletion. | 12:12 |
| tbarron | e0ne: maybe wrongly though | 12:13 |
| tbarron | :-) | 12:13 |
| e0ne | tbarron: it makes sence. | 12:14 |
| tbarron | e0ne: sorry, *what* makes sense? | 12:15 |
| openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 12:16 |
| e0ne | tbarron: asynchronously cleaning up | 12:16 |
| tbarron | e0ne: well, it might :-) But we need to understand the eventlet/threading stuff with big files in any case. | 12:17 |
| e0ne | tbarron: agreed | 12:18 |
| *** lpetrut has quit IRC | 12:19 | |
| wanghao | ping thingee | 12:20 |
| *** aix has joined #openstack-cinder | 12:21 | |
| wanghao | thingee: hi~ There is a bp that you +2 in Juno. I want to merge it in L. Would you help me +2 again in L specs? https://review.openstack.org/#/c/98325/ | 12:22 |
| *** timcl has joined #openstack-cinder | 12:31 | |
| *** bswartz has quit IRC | 12:37 | |
| *** thangp has quit IRC | 12:38 | |
| *** smoriya has quit IRC | 12:40 | |
| *** lpetrut has joined #openstack-cinder | 12:42 | |
| *** jistr has quit IRC | 12:42 | |
| *** jistr has joined #openstack-cinder | 12:43 | |
| *** lpetrut has quit IRC | 12:46 | |
| *** bill_az has joined #openstack-cinder | 12:56 | |
| *** Yogi1 has joined #openstack-cinder | 12:59 | |
| *** jistr is now known as jistr|mtg | 13:01 | |
| *** xyang1 has joined #openstack-cinder | 13:04 | |
| *** e0ne is now known as e0ne_ | 13:04 | |
| *** Longgeek has quit IRC | 13:05 | |
| *** lpetrut has joined #openstack-cinder | 13:06 | |
| *** e0ne_ is now known as e0ne | 13:06 | |
| *** avishay has quit IRC | 13:07 | |
| *** avishay has joined #openstack-cinder | 13:07 | |
| *** sandywalsh has quit IRC | 13:11 | |
| *** rongze has quit IRC | 13:11 | |
| *** tshefi has quit IRC | 13:14 | |
| *** changbl has quit IRC | 13:14 | |
| *** rongze has joined #openstack-cinder | 13:14 | |
| *** bswartz has joined #openstack-cinder | 13:15 | |
| *** sandywalsh has joined #openstack-cinder | 13:15 | |
| *** e0ne is now known as e0ne_ | 13:16 | |
| *** tshefi has joined #openstack-cinder | 13:17 | |
| *** zhenguo has quit IRC | 13:17 | |
| mtreinish | thingee: hmm, that means the volume wasn't actually reused correctly, because the data the test wrote wasn't there when the volume was used again | 13:17 |
| mtreinish | thingee: but, I thought you were getting further in the test before. Wasn't it failing in teardown? | 13:18 |
| *** avishay_ has joined #openstack-cinder | 13:19 | |
| *** avishay has quit IRC | 13:19 | |
| *** anshul has quit IRC | 13:20 | |
| *** e0ne_ is now known as e0ne | 13:21 | |
| *** jungleboyj has joined #openstack-cinder | 13:21 | |
| *** Longgeek has joined #openstack-cinder | 13:24 | |
| *** Longgeek has quit IRC | 13:24 | |
| *** Longgeek has joined #openstack-cinder | 13:25 | |
| *** jungleboyj has quit IRC | 13:26 | |
| *** esker has joined #openstack-cinder | 13:26 | |
| *** e0ne is now known as e0ne_ | 13:26 | |
| *** timcl has quit IRC | 13:26 | |
| *** e0ne_ is now known as e0ne | 13:26 | |
| *** dustins has joined #openstack-cinder | 13:31 | |
| *** timcl has joined #openstack-cinder | 13:35 | |
| *** mriedem_away is now known as mriedem | 13:36 | |
| *** EmilienM has quit IRC | 13:40 | |
| *** EmilienM has joined #openstack-cinder | 13:41 | |
| *** xyang has joined #openstack-cinder | 13:41 | |
| openstackgerrit | Silvan Kaiser proposed openstack/cinder: Fix Quobyte driver secure permissions issue https://review.openstack.org/169283 | 13:44 |
| *** ankit_ag has quit IRC | 13:44 | |
| *** cbits has joined #openstack-cinder | 13:45 | |
| *** rongze has quit IRC | 13:45 | |
| *** emagana has joined #openstack-cinder | 13:48 | |
| *** guitarzan has joined #openstack-cinder | 13:50 | |
| *** emagana_ has joined #openstack-cinder | 13:51 | |
| *** emagana has quit IRC | 13:52 | |
| *** julim has joined #openstack-cinder | 13:52 | |
| thingee | mtreinish: nah this was previously failing before the second instance would be creating. | 13:56 |
| thingee | mtreinish: I think a bug exists for reexporting in the driver itself. | 13:57 |
| mtreinish | ah ok, yeah I was misremembering it was during the first delete. | 13:58 |
| thingee | wanghao: I'll be looking at specs eventually. Thanks. | 13:58 |
| mtreinish | thingee: that might be, I'd suspect that would be the issue too | 13:58 |
| thingee | I think these tests being re enabled revealed them. I thought these tests were enabled at one point at least during Juno. Oh well | 14:00 |
| mtreinish | thingee: yeah they were enabled at one point before | 14:00 |
| mtreinish | let me dig up when we added the skip | 14:00 |
| mtreinish | thingee: http://git.openstack.org/cgit/openstack/tempest/commit/?id=1fd223e750048f8f39dea2f1b3fc6c73ff0b27d1 was when we added the skip | 14:01 |
| *** cbits has left #openstack-cinder | 14:02 | |
| mtreinish | thingee: but if people were using the api.volume regex they wouldn't have picked this test up | 14:03 |
| openstackgerrit | Tom Barron proposed openstack/cinder: Fix range check for NFS used ratio https://review.openstack.org/175573 | 14:06 |
| *** eharney has joined #openstack-cinder | 14:06 | |
| *** mtanino has joined #openstack-cinder | 14:06 | |
| thingee | Ah good point | 14:07 |
| e0ne | thingee: hi. is this patch https://review.openstack.org/146541 (set default api version to v2 in cinderclient) still needed after yours or i should abadone it? | 14:07 |
| *** emagana_ has quit IRC | 14:08 | |
| *** afazekas_ has quit IRC | 14:08 | |
| *** emagana has joined #openstack-cinder | 14:08 | |
| thingee | e0ne: not sure it matters. It will do a fallback to v1 if it's not available. | 14:08 |
| thingee | I think it's more about how likely people have v2 deployed. | 14:09 |
| e0ne | imho, we need to enforce moving to v2 since v1 is deprecated | 14:10 |
| e0ne | but i don't know what is the best way to do it | 14:10 |
| *** lcurtis has joined #openstack-cinder | 14:10 | |
| *** annegentle has joined #openstack-cinder | 14:10 | |
| thingee | It will probably be fine. | 14:11 |
| *** BharatK has joined #openstack-cinder | 14:11 | |
| *** bkopilov has joined #openstack-cinder | 14:12 | |
| *** Yogi1 has quit IRC | 14:13 | |
| *** lpetrut has quit IRC | 14:13 | |
| tbarron | thingee: w.r.t. the Kilo release notes, I have pushed up an openstack-manuals review for an update to the Admin guide for NFS backup. | 14:15 |
| tbarron | thingee: https://review.openstack.org/#/c/175826/ | 14:16 |
| tbarron | xyang: ^^^^^^ | 14:16 |
| thingee | tbarron: thanks! Make sure I'm added to to the review and I'll review it today. | 14:16 |
| tbarron | xyang: I wiggled on the incremental backup stuff. Can change that sentence if the python-client change is going in for Kilo. | 14:17 |
| tbarron | xyang: and can cross-link to your section if there is one. | 14:17 |
| *** mwichmann has joined #openstack-cinder | 14:18 | |
| tbarron | thingee: done. | 14:18 |
| xyang | tbarron: hi, I did add something for incremental backup here: https://review.openstack.org/#/c/175576/ | 14:21 |
| tbarron | xyang: OK, I'll review it too. Maybe get yours merged and then I can cross-reference it. | 14:22 |
| tbarron | xyang: looks like you've got a small syntax issue ... | 14:23 |
| *** avishay__ has joined #openstack-cinder | 14:23 | |
| xyang | tbarron: sure, I need to fix the syntax issues | 14:23 |
| *** avishay_ has quit IRC | 14:23 | |
| xyang | tbarron, thingee: we need to get the cinderclient side change merged first before merging the doc? Or is it okay to get the doc merged first? | 14:24 |
| tbarron | xyang: I don't know. Good question. I hope thingee has had coffee already, he's getting a early start today ... | 14:25 |
| thingee | xyang: that's a good point. This finally landed https://review.openstack.org/#/c/145613/ !! | 14:25 |
| thingee | :) | 14:25 |
| thingee | xyang: make sure I'm already added to the client review and I'll look at it today | 14:25 |
| thingee | xyang: I'll also be looking for anything else that would be good for this next release | 14:25 |
| thingee | xyang: I'll let you know when I do a client release | 14:26 |
| thingee | thanks! | 14:26 |
| *** jistr|mtg is now known as jistr | 14:26 | |
| xyang | thingee: great! I was going to review it but haven't got to it yet. I have some jenkins errors that are not caused by my patch. let me do a recheck. I'll add you as reviewer | 14:27 |
| tbarron | bbiab | 14:27 |
| uberjay | Hey there, I have a couple meta-questions about the "Standardize logging in volume.api.py" commit. (e9bc08f0ada2831dee4f3cd5a936cdc2f21fef6d) -- first, where can I read about the resource tag support in olso logging, and second, should this be discoverable from the change ID/gerrit topic, to some blueprint? (I'm new here :) | 14:27 |
| thingee | xyang: thanks | 14:27 |
| *** fanyaohong has joined #openstack-cinder | 14:28 | |
| *** annegentle has quit IRC | 14:28 | |
| *** annegentle has joined #openstack-cinder | 14:28 | |
| *** annashen has joined #openstack-cinder | 14:29 | |
| openstackgerrit | Clinton Knight proposed openstack/cinder: NetApp FC driver shims missing manage/unmanage https://review.openstack.org/175896 | 14:30 |
| *** lpetrut has joined #openstack-cinder | 14:30 | |
| *** Yogi11 has joined #openstack-cinder | 14:31 | |
| *** rushil has joined #openstack-cinder | 14:31 | |
| *** annashen has quit IRC | 14:34 | |
| openstackgerrit | xing-yang proposed openstack/python-cinderclient: Add support to incremental backups in cinder https://review.openstack.org/112101 | 14:36 |
| *** xyang has quit IRC | 14:36 | |
| *** xyang has joined #openstack-cinder | 14:44 | |
| *** rongze has joined #openstack-cinder | 14:46 | |
| *** _cjones_ has joined #openstack-cinder | 14:46 | |
| *** _cjones_ has quit IRC | 14:51 | |
| *** sileht has quit IRC | 14:57 | |
| *** breitz has joined #openstack-cinder | 14:57 | |
| *** crose has joined #openstack-cinder | 14:58 | |
| *** garthb has joined #openstack-cinder | 15:03 | |
| *** garthb_ has joined #openstack-cinder | 15:03 | |
| openstackgerrit | Doug Hellmann proposed openstack/python-cinderclient: Update README to work with release tools https://review.openstack.org/175921 | 15:04 |
| *** hemnafk is now known as hemna | 15:04 | |
| dhellmann | thingee: I'm working on releases of all libraries from master today, including python-cinderclient. It looks like there are quite a lot of unreleased changes. Is that what you expected? http://paste.openstack.org/show/204989/ | 15:05 |
| *** cbader has joined #openstack-cinder | 15:05 | |
| *** rmesta has joined #openstack-cinder | 15:10 | |
| *** jaypipes has quit IRC | 15:11 | |
| *** lpetrut1 has joined #openstack-cinder | 15:14 | |
| *** BaconIsKing has joined #openstack-cinder | 15:16 | |
| hemna | dhellmann, will you be doing the release for os-brick as well ? | 15:16 |
| *** lpetrut has quit IRC | 15:16 | |
| *** julim has quit IRC | 15:16 | |
| *** julim has joined #openstack-cinder | 15:18 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Update README to work with release tools https://review.openstack.org/175931 | 15:18 |
| hemna | dhellmann, can you check that one out for me? ^^^ | 15:19 |
| hemna | Just want to make sure that the README conforms to what the release tools need. | 15:19 |
| *** breitz has quit IRC | 15:20 | |
| *** breitz has joined #openstack-cinder | 15:20 | |
| e0ne | hemna: hi. just fyi. brick, cinder-agent and flaskkeystone-auth will be a high priority for me starting this week, so i'll be able to work on it almost full time | 15:21 |
| hemna | e0ne, ok cool. | 15:21 |
| hemna | e0ne, we have a few os-brick bugs outstanding that need to get resolved. fwiw. | 15:21 |
| hemna | e0ne, https://bugs.launchpad.net/os-brick | 15:21 |
| hemna | if I can get some help on those, that'd be great | 15:21 |
| dhellmann | hemna: I can do os-brick, yes | 15:21 |
| e0ne | hemna: i need to finish spec for eventlet in api before starting work on brick related tasks | 15:21 |
| hemna | I think anish was going to tackle one of them | 15:22 |
| dhellmann | hemna: oh, actually os-brick isn't on my list yet, hang on | 15:22 |
| hemna | dhellmann, thanks. just coordinate with thingee | 15:22 |
| hemna | dhellmann, ok :) | 15:22 |
| e0ne | hemna: thanks! | 15:22 |
| dhellmann | hemna, thingee : does anything other than cinder use os-brick? | 15:22 |
| hemna | dhellmann, fwiw, os-brick hasn't been release to pypi yet. This will be the first drop of it. | 15:22 |
| hemna | dhellmann, cinder doesn't use os-brick yet. | 15:22 |
| hemna | but it will in Liberty. | 15:22 |
| dhellmann | ok, if nothing uses it we don't need a release today | 15:22 |
| hemna | dhellmann, so, nothing (that I know of) relies on os-brick just yetl. | 15:23 |
| hemna | yet | 15:23 |
| dhellmann | I'm just trying to unwedge us, so I'm trying to keep the list as short as possible | 15:23 |
| hemna | ok | 15:23 |
| hemna | I have 2 patches outstanding that are waiting for a drop to pypi | 15:23 |
| dhellmann | hemna: I can help you with the release at a time when the pressure is lower | 15:23 |
| hemna | I have 2 WIP patches, cinder and nova that need a drop to pypi. but it's not emergency urgent :) | 15:23 |
| hemna | dhellmann, sure! | 15:23 |
| hemna | dhellmann, I just saw you ping thingee about releasing cinderclient, so I thought I'd raise os-brick awareness. | 15:24 |
| hemna | no hurry. | 15:24 |
| *** IanGovett has quit IRC | 15:25 | |
| dhellmann | hemna: yep, thanks | 15:25 |
| dhellmann | hemna: I left some comments on that README update | 15:25 |
| hemna | ok thank you. | 15:26 |
| *** ronis has quit IRC | 15:27 | |
| hemna | dhellmann, thanks for the feedback, I'll address those. much appreciated! | 15:27 |
| dhellmann | hemna: np | 15:27 |
| *** tshefi has quit IRC | 15:28 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Update README to work with release tools https://review.openstack.org/175931 | 15:29 |
| *** jungleboyj has joined #openstack-cinder | 15:31 | |
| *** annashen has joined #openstack-cinder | 15:31 | |
| *** nlevinki has quit IRC | 15:31 | |
| *** jdurgin1 has joined #openstack-cinder | 15:32 | |
| openstackgerrit | hadi esiely proposed openstack/cinder: Store volume encryption metadata on each volume https://review.openstack.org/152284 | 15:33 |
| openstackgerrit | hadi esiely proposed openstack/cinder: Add test case for volume_encryption_metadata_get https://review.openstack.org/168177 | 15:33 |
| openstackgerrit | hadi esiely proposed openstack/cinder: Remove unnecessary checks for encrypted types https://review.openstack.org/168179 | 15:33 |
| *** annashen has quit IRC | 15:36 | |
| *** david-lyle has quit IRC | 15:36 | |
| *** changbl has joined #openstack-cinder | 15:36 | |
| *** thangp has joined #openstack-cinder | 15:36 | |
| *** IanGovett has joined #openstack-cinder | 15:36 | |
| *** kaisers has quit IRC | 15:41 | |
| *** dannywilson has joined #openstack-cinder | 15:43 | |
| *** zhipeng has joined #openstack-cinder | 15:43 | |
| *** avishay__ has quit IRC | 15:45 | |
| *** zhipeng has quit IRC | 15:45 | |
| *** dannywilson has quit IRC | 15:48 | |
| *** avishay__ has joined #openstack-cinder | 15:49 | |
| *** markstur has quit IRC | 15:53 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Switch get_all_snapshots to use objects https://review.openstack.org/161077 | 15:54 |
| *** rongze has quit IRC | 15:54 | |
| *** ronis has joined #openstack-cinder | 15:54 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Complete switch to snapshot objects https://review.openstack.org/163910 | 15:54 |
| *** ebalduf has joined #openstack-cinder | 15:56 | |
| thangp | hemna: could you remove the -2 on https://review.openstack.org/#/c/161077/? liberty is now open | 15:57 |
| *** sileht has joined #openstack-cinder | 15:57 | |
| hemna | thangp, done! | 15:58 |
| thangp | hemna: thx! | 15:58 |
| *** BaconIsKing has quit IRC | 15:58 | |
| *** tsekiyama has joined #openstack-cinder | 16:01 | |
| *** vilobhmm1 has joined #openstack-cinder | 16:02 | |
| *** david-lyle has joined #openstack-cinder | 16:02 | |
| *** ronis has quit IRC | 16:02 | |
| *** AlkaD has joined #openstack-cinder | 16:06 | |
| *** _cjones_ has joined #openstack-cinder | 16:09 | |
| *** timcl has quit IRC | 16:10 | |
| *** avishay__ has quit IRC | 16:10 | |
| jgriffith | Has anybody noticed we don't seem to actually use the osapi_volume_workers setting anywhere besides unit tests? | 16:14 |
| jgriffith | ^^ ./cinder/service.py: cfg.IntOpt('osapi_volume_workers' | 16:14 |
| eharney | jgriffith: i think it's used in a hidden way by cmd/api.py | 16:15 |
| eharney | jgriffith: i went digging after this same question some time ago :) | 16:15 |
| jgriffith | eharney: hehe... I love "hidden" things :) | 16:15 |
| jgriffith | eharney: I'm poking around at the whole c-api won't die thing | 16:15 |
| eharney | jgriffith: the common service code determines the conf variable name based on the service name or something like that | 16:15 |
| jgriffith | eharney: Ahh... hmm, that's sort of an annoying thing :( | 16:16 |
| e0ne | jgriffith: it is used in the code | 16:16 |
| eharney | jgriffith: yeah, getattr(CONF, '%s_workers' % name, None) in service.py | 16:16 |
| jgriffith | eharney: But not *new* there are several cases of that with libs now I guess | 16:16 |
| jgriffith | eharney: OH GEESH!!! | 16:16 |
| e0ne | eharney: that's what i tried to find, thanks:) | 16:17 |
| jgriffith | e0ne: eharney thanks! | 16:18 |
| *** avishay__ has joined #openstack-cinder | 16:18 | |
| jgriffith | e0ne: eharney so I wonder if something in the way we're spawning those is causing the issue of not being able to kill the WSGI service | 16:18 |
| eharney | i don't think i'm familiar with this issue... | 16:18 |
| e0ne | jgriffith: what do you mean? | 16:18 |
| jgriffith | eharney: e0ne http://goo.gl/4rDVrp | 16:18 |
| eharney | oh, that looks like a fun one | 16:19 |
| jgriffith | eharney: e0ne It turns out that we don't have the oslo update they've proposed to fix Keystone (they're reverting to what we have) | 16:19 |
| jgriffith | eharney: yeah... my gut makes me suspicious of our add of multiple API workers | 16:19 |
| e0ne | jgriffith: that's why we need to move api to wsgi application w/o eventlet and custom process launcher | 16:21 |
| jgriffith | e0ne: apparantly so | 16:21 |
| jgriffith | e0ne: although there's been arguments the we should drop wsgi in the past I thought | 16:21 |
| *** jistr has quit IRC | 16:21 | |
| e0ne | drop wsgi? | 16:22 |
| jgriffith | e0ne: like flask or pecan or something... but I think that ended badly for folks that tried it | 16:22 |
| jgriffith | e0ne: I seem to recall Ceilometer went down that path | 16:24 |
| jgriffith | e0ne: and I believe thingee was proposing flask at one point or another | 16:24 |
| jgriffith | e0ne: anyway... kind of a side track | 16:24 |
| e0ne | jgriffith: there are 2 areas of responsibility: handling api request and managing api workers | 16:24 |
| *** vilobhmm1 has quit IRC | 16:24 | |
| jgriffith | e0ne: correct, and right now I'm interested in the second one | 16:24 |
| e0ne | jgriffith: in openstack we mixed it | 16:24 |
| jgriffith | e0ne: Ahh... I see what you're getting at | 16:25 |
| jgriffith | e0ne: Interesting point | 16:25 |
| *** rhagarty_ has quit IRC | 16:25 | |
| *** rhagarty has quit IRC | 16:25 | |
| e0ne | jgriffith: i volunteered to make speck about wsgi w/o eventlet in a past. i'm going to publish it this week | 16:25 |
| eharney | jgriffith: at a glance, i'm not sure that the shutdown code in devstack/grenade isn't racy... | 16:26 |
| e0ne | jgriffith: i'm not fimilar with issue you provided so can't help a lot with it | 16:26 |
| eharney | jgriffith: it calls pkill -g but doesn't wait at all for the service to actually stop? | 16:27 |
| jgriffith | eharney: hmm... I think it does | 16:27 |
| jgriffith | eharney: but I could be wrong | 16:27 |
| eharney | jgriffith: i walked through the code and didn't see where | 16:27 |
| e0ne | eharney: i thought that our services could handle SIGTERM correct | 16:28 |
| eharney | e0ne: sure, but if grenade/devstack doesn't give them time to handle it before checking to see if the pid is still present... | 16:28 |
| thingee | hemna: yup I already started talking to dhellmann about brick. | 16:28 |
| *** avishay__ has quit IRC | 16:28 | |
| *** timcl has joined #openstack-cinder | 16:28 | |
| thingee | hemna: that's who I was originally talking to earlier. | 16:28 |
| eharney | it could just be checking if they're still running before they have time to finish | 16:28 |
| hemna | thingee, ok coolio. I didn't mean to step on toes. I just saw him asking about lib. releases and thought I'd touch base. | 16:28 |
| jgriffith | eharney: you may be right | 16:28 |
| jgriffith | eharney: that would explain the frequency | 16:29 |
| hemna | I posted up another os-brick review, to update the README.txt with the same kinds of changes that dhellmann put into cinderclient for the release tools. | 16:29 |
| *** jordanP has quit IRC | 16:29 | |
| hemna | thingee, https://review.openstack.org/#/c/175931/ | 16:29 |
| thingee | hemna: yeah saw that. Thanks! | 16:29 |
| e0ne | need to have a break for dinner. bb in ~2 hours | 16:29 |
| *** jaypipes has joined #openstack-cinder | 16:30 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Move RBD calls to a separate threads https://review.openstack.org/175555 | 16:31 |
| jgriffith | eharney: I was actually thinking about adding a wait in the api service stop | 16:31 |
| jgriffith | eharney: assuming they wait for a response | 16:31 |
| jgriffith | eharney: but I guess kill wouldn't | 16:31 |
| *** annashen has joined #openstack-cinder | 16:32 | |
| eharney | jgriffith: pkill -g doesn't | 16:32 |
| jgriffith | eharney: yeah, I see | 16:34 |
| *** annashen has quit IRC | 16:37 | |
| *** fanyaohong has quit IRC | 16:39 | |
| *** leeantho has joined #openstack-cinder | 16:43 | |
| *** akerr has joined #openstack-cinder | 16:44 | |
| *** e0ne has quit IRC | 16:45 | |
| thingee | hemna: +2 for readme change | 16:45 |
| *** yuriy_n17 has quit IRC | 16:46 | |
| *** annegentle has quit IRC | 16:47 | |
| hemna | thank you | 16:48 |
| *** kaisers has joined #openstack-cinder | 16:50 | |
| *** jdurgin1 has quit IRC | 16:55 | |
| *** rongze has joined #openstack-cinder | 16:55 | |
| *** sgotliv has quit IRC | 16:56 | |
| *** harlowja_away is now known as harlowja | 16:57 | |
| *** rongze has quit IRC | 16:59 | |
| *** annashen has joined #openstack-cinder | 16:59 | |
| dhellmann | thingee: I'm working on releases of all libraries from master today, including python-cinderclient. It looks like there are quite a lot of unreleased changes. Is that what you expected? http://paste.openstack.org/show/204989/ | 16:59 |
| thingee | dhellmann: yeah last release was around september I think | 17:00 |
| thingee | dhellmann: I'm about to go into a meeting, bbl | 17:00 |
| dhellmann | thingee: wow, ok | 17:00 |
| thingee | dhellmann: :( | 17:00 |
| dhellmann | thingee: when you have time, let's talk about how to do that more often during liberty | 17:00 |
| dhellmann | thingee: I may be able to help there | 17:01 |
| *** julim has quit IRC | 17:01 | |
| thingee | dhellmann: yeah sorry I let that slip and do feel bad. | 17:02 |
| *** Yogi11 has quit IRC | 17:02 | |
| dhellmann | thingee: I'm not complaining! | 17:02 |
| dhellmann | thingee: :-) | 17:02 |
| *** vilobhmm1 has joined #openstack-cinder | 17:04 | |
| *** julim has joined #openstack-cinder | 17:04 | |
| *** vilobhmm11 has joined #openstack-cinder | 17:04 | |
| *** _cjones_ has quit IRC | 17:04 | |
| *** _cjones_ has joined #openstack-cinder | 17:07 | |
| *** david-lyle has quit IRC | 17:08 | |
| *** vilobhmm1 has quit IRC | 17:08 | |
| *** ronis has joined #openstack-cinder | 17:15 | |
| *** Yogi1 has joined #openstack-cinder | 17:18 | |
| *** patrickeast has joined #openstack-cinder | 17:22 | |
| *** mwichmann has left #openstack-cinder | 17:22 | |
| *** asselin has quit IRC | 17:24 | |
| *** asselin has joined #openstack-cinder | 17:24 | |
| *** asselin has quit IRC | 17:24 | |
| *** rongze has joined #openstack-cinder | 17:25 | |
| *** ronis_ has joined #openstack-cinder | 17:25 | |
| *** ronis has quit IRC | 17:29 | |
| *** asselin has joined #openstack-cinder | 17:29 | |
| *** lpetrut1 has quit IRC | 17:30 | |
| *** rongze has quit IRC | 17:30 | |
| *** kmartin has joined #openstack-cinder | 17:31 | |
| *** annegentle has joined #openstack-cinder | 17:32 | |
| *** e0ne has joined #openstack-cinder | 17:33 | |
| *** e0ne is now known as e0ne_ | 17:33 | |
| *** nkrinner has quit IRC | 17:34 | |
| *** e0ne_ is now known as e0ne | 17:34 | |
| *** asselin has quit IRC | 17:36 | |
| *** aix has quit IRC | 17:37 | |
| *** asselin has joined #openstack-cinder | 17:37 | |
| *** annegentle has quit IRC | 17:38 | |
| *** annegentle has joined #openstack-cinder | 17:39 | |
| *** markstur has joined #openstack-cinder | 17:40 | |
| *** angela-s has joined #openstack-cinder | 17:42 | |
| *** e0ne is now known as e0ne_ | 17:44 | |
| *** e0ne_ is now known as e0ne | 17:45 | |
| *** timcl has quit IRC | 17:47 | |
| *** ronis_ has quit IRC | 17:49 | |
| *** e0ne is now known as e0ne_ | 17:51 | |
| *** timcl has joined #openstack-cinder | 17:52 | |
| *** annegentle has quit IRC | 17:53 | |
| *** e0ne_ has quit IRC | 17:56 | |
| *** Yogi11 has joined #openstack-cinder | 17:57 | |
| *** vilobhmm11 has quit IRC | 17:59 | |
| *** vilobhmm1 has joined #openstack-cinder | 17:59 | |
| *** vilobhmm1 has quit IRC | 17:59 | |
| *** vilobhmm1 has joined #openstack-cinder | 18:00 | |
| *** melwitt has joined #openstack-cinder | 18:00 | |
| *** vilobhmm1 has quit IRC | 18:00 | |
| *** Yogi1 has quit IRC | 18:00 | |
| *** vilobhmm1 has joined #openstack-cinder | 18:00 | |
| *** vilobhmm11 has joined #openstack-cinder | 18:02 | |
| *** vilobhmm12 has joined #openstack-cinder | 18:02 | |
| *** xyang has quit IRC | 18:04 | |
| *** vilobhmm1 has quit IRC | 18:04 | |
| *** annegentle has joined #openstack-cinder | 18:05 | |
| *** vilobhmm11 has quit IRC | 18:07 | |
| *** e0ne has joined #openstack-cinder | 18:10 | |
| *** annegentle has quit IRC | 18:10 | |
| *** ronis_ has joined #openstack-cinder | 18:11 | |
| thingee | hemna: what version are we starting with os-brick | 18:16 |
| thingee | technically it has been around | 18:17 |
| thingee | dhellmann: ^ | 18:18 |
| hemna | hrmm I dunno | 18:18 |
| hemna | I'm ok with 1.0.0 ? | 18:18 |
| thingee | me too... looking at the other clients some started with 0.0 :P | 18:18 |
| thingee | we're past that | 18:18 |
| *** rongze has joined #openstack-cinder | 18:26 | |
| *** mriedem has quit IRC | 18:29 | |
| *** rongze has quit IRC | 18:31 | |
| *** vilobhmm1 has joined #openstack-cinder | 18:33 | |
| *** vilobhmm12 has quit IRC | 18:33 | |
| *** mriedem has joined #openstack-cinder | 18:35 | |
| *** openstackgerrit has quit IRC | 18:37 | |
| *** openstackgerrit has joined #openstack-cinder | 18:38 | |
| akerr | anyone else seeing conflicting requirements in stable/juno devstack builds in their CI system? If i'm reading devstack's log right, keystone wants stevedore <=1.2.0 but keystone_middleware wants stevedore >=1.3.0 | 18:39 |
| *** david-lyle has joined #openstack-cinder | 18:39 | |
| thingee | akerr: https://github.com/openstack/keystonemiddleware/blob/stable/juno/requirements.txt https://github.com/openstack/keystone/blob/stable/juno/requirements.txt | 18:44 |
| thingee | akerr: I don't even see it in their requirements | 18:44 |
| dhellmann | akerr, thingee: bknudson and gordc know about this, ask in #openstack-keystone | 18:46 |
| *** david-ly_ has joined #openstack-cinder | 18:46 | |
| *** david-lyle has quit IRC | 18:46 | |
| akerr | dhellmann: thanks | 18:46 |
| * thingee is confused | 18:47 | |
| akerr | http://dcf901611175aa43f968-c54047c910227e27e1d6f03bb1796fd7.r95.cf5.rackcdn.com/09/175909/1/check/cDOT-iSCSI-tempest-openstack/54711c1/ are my logs :) It clearly installs stevedore 1.4.0 first, then gets other requirements and uninstalls it and installs 1.2.0, then throws an error creating keystone admin accounts saying it needs 1.3.0 /sigh | 18:48 |
| akerr | i'll ping in keystone | 18:48 |
| *** asselin_ has joined #openstack-cinder | 18:59 | |
| *** melwitt has quit IRC | 19:03 | |
| *** melwitt has joined #openstack-cinder | 19:04 | |
| akerr | hah, vindicated, jenkins is hitting the exact same issue on stable/juno | 19:06 |
| * akerr probably shouldn't be happy the gate is broken | 19:07 | |
| *** diemt has quit IRC | 19:09 | |
| *** _cjones_ has quit IRC | 19:09 | |
| *** diemt has joined #openstack-cinder | 19:10 | |
| e0ne | just learned that 'cinder show volume_name' will filter all volumes by name on a client side:( | 19:10 |
| *** Rockyg has joined #openstack-cinder | 19:15 | |
| *** uberjay has quit IRC | 19:15 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: Fix range check for NFS used ratio https://review.openstack.org/175573 | 19:16 |
| *** uberjay has joined #openstack-cinder | 19:16 | |
| *** changbl has quit IRC | 19:16 | |
| *** david-ly_ has quit IRC | 19:18 | |
| *** BaconIsKing has joined #openstack-cinder | 19:18 | |
| *** changbl has joined #openstack-cinder | 19:19 | |
| *** uberjay has quit IRC | 19:26 | |
| *** Yogi11 has quit IRC | 19:26 | |
| *** rongze has joined #openstack-cinder | 19:27 | |
| *** uberjay has joined #openstack-cinder | 19:28 | |
| *** Yogi1 has joined #openstack-cinder | 19:29 | |
| smcginnis | e0ne: Ouch. | 19:30 |
| e0ne | smcginnis: :( | 19:31 |
| *** _cjones_ has joined #openstack-cinder | 19:31 | |
| smcginnis | e0ne: That's got to be real painful in large deployments. | 19:31 |
| e0ne | smcginnis: ~3-5 min to get volume on my env with 12000 volumes | 19:32 |
| eharney | it is (i've also been investigating this recently) | 19:32 |
| *** rongze has quit IRC | 19:32 | |
| smcginnis | Should be fairly easy to fix I would think (or hope). | 19:32 |
| smcginnis | Wonder why it was done that way in the first place. | 19:32 |
| *** sgotliv has joined #openstack-cinder | 19:33 | |
| eharney | smcginnis: i think because the original v1 API didn't have a way to do it better | 19:33 |
| e0ne | smcginnis: it's a common code from oslo-incubator api client | 19:33 |
| smcginnis | eharney: Ah, guess that makes some sense. At least explains it. | 19:33 |
| e0ne | eharney: we can do it using 'params' and list method | 19:34 |
| eharney | and as far as i can tell the client isn't doing what it should be for v2 | 19:34 |
| eharney | e0ne: hmm yeah | 19:34 |
| eharney | i'm still trying to wrap my head around this, i haven't spent a ton of time in our APIs really | 19:34 |
| smcginnis | e0ne: I think that's what I ended up doing for delete by name. | 19:35 |
| *** alexpilotti has quit IRC | 19:36 | |
| e0ne | eharney: i'm going to ask my team to fix it | 19:37 |
| eharney | e0ne: cool... note that https://review.openstack.org/#/c/162130/ from geguileo at least makes this slightly less horrible | 19:38 |
| e0ne | i'm agree with smcginnis that it's very painful on the big environments | 19:38 |
| e0ne | eharney: thanks, i'll take a look on it tomorrow | 19:39 |
| eharney | e0ne: it definitely isn't the actual fix, though | 19:39 |
| smcginnis | I could probably dig in to it later this week if no one else wants to. | 19:40 |
| e0ne | http://paste.openstack.org/show/205022/ -oh... 2min for volume get | 19:40 |
| eharney | e0ne: yeah... v2 is bad if the name isn't found too, though | 19:41 |
| e0ne | eharney: it's an exising name of the volume | 19:41 |
| e0ne | i din't copy output with the volume info | 19:43 |
| eharney | e0ne: right. but if you query one that doesn't exist, you'll see that it's also very slow | 19:43 |
| e0ne | eharney: :( | 19:43 |
| e0ne | it makes me very and very sad | 19:44 |
| eharney | e0ne: indeed | 19:44 |
| e0ne | two more thing | 19:45 |
| e0ne | no --limit param for cinderclient api v1 for CLI | 19:45 |
| e0ne | and _no_ default 'limit' for volumes lit | 19:45 |
| e0ne | *list | 19:45 |
| eharney | default limit? | 19:46 |
| e0ne | so if we have 12k volumes in a tenant, cinderclient returns 12k volumes to user | 19:46 |
| e0ne | i mean limit for select list of volumes, backups, snapshots, etc | 19:46 |
| eharney | ah, well, that's perhaps another thing to consider | 19:47 |
| *** lpetrut has joined #openstack-cinder | 19:47 | |
| *** rooneym has joined #openstack-cinder | 19:47 | |
| e0ne | +1 | 19:47 |
| e0ne | it's too late for me. i'll file bug for all found issues for python-cinderclient tomorrow morning | 19:50 |
| vilobhmm1 | eone : need to fix this. thanks for bringing this up! | 19:51 |
| *** crose has quit IRC | 19:51 | |
| geguileo | eharney: e0ne Also relevant to the list issue is this patch: https://review.openstack.org/#/c/162139/ | 19:52 |
| e0ne | eharney: be appreciative if you'll get a time to review https://review.openstack.org/175555 once more | 19:52 |
| eharney | e0ne: will do | 19:52 |
| e0ne | eharney: thanks | 19:53 |
| geguileo | eharney: e0ne That one adds cache so it doesn't request the same date 3 times | 19:53 |
| uberjay | say I'm submitting a volume driver soon -- should the unit tests follow a hierarchical directory structure? most tests are in cinder/tests, but there are a couple in cinder/tests/volume/drivers -- what's the convention? | 19:54 |
| smcginnis | uberjay: Most have gone in cinder/tests. | 19:54 |
| smcginnis | uberjay: Though I would like to see a better structure. | 19:54 |
| smcginnis | uberjay: They are being moved right now to make it a little better. Let me find the patch. | 19:55 |
| uberjay | smcginnis: I see that... mine are in a single file, and I guess if the structure gets reorganized it'll just be done all at once | 19:55 |
| uberjay | smcginnis: ah, thanks | 19:55 |
| e0ne | uberjay: afair, there should be review request to move tests to a new structure | 19:55 |
| smcginnis | uberjay: https://review.openstack.org/#/c/175583/ | 19:56 |
| e0ne | geguileo: caching is only an option. filtering must be done on the server-side by default | 19:56 |
| *** AlkaD has quit IRC | 19:56 | |
| smcginnis | Caching would be nice, but I agree e0ne, it should be filtered in the first place. | 19:57 |
| geguileo | e0ne: I agree, but since on v1 that didn't exist (afaik) I thought this would mitigate the problem | 19:57 |
| smcginnis | geguileo: Good point. | 19:57 |
| eharney | the caching patch (which works now) is just an intermediate fix which does help a lot in the mean time, though | 19:57 |
| *** AlkaD has joined #openstack-cinder | 19:57 | |
| uberjay | smcginnis: great, thanks. I'm glad I asked! | 19:57 |
| smcginnis | jgriffith: Are you able to rebase any time soon? https://review.openstack.org/#/c/175583/ | 19:57 |
| vilobhmm1 | eharney : caching patch for v1 or v2 ? | 19:58 |
| smcginnis | jgriffith: Looks like it had one +2. Would be good to get that through before too long. | 19:58 |
| * smcginnis preaching to the choir, I'm sure | 19:58 | |
| hemna | damn, already in conflict | 19:59 |
| hemna | that didn't take long | 19:59 |
| eharney | vilobhmm1: i think it does both (geguileo?) | 19:59 |
| smcginnis | hemna: Yeah, I'm afraid if this doesn't get through very quickly it's going to need contuinual rebasing. | 19:59 |
| vilobhmm1 | hemna : it acted as per your saying :P | 19:59 |
| vilobhmm1 | Let the rebase hell begin! :) | 19:59 |
| hemna | hahah yah | 19:59 |
| hemna | :P | 19:59 |
| vilobhmm1 | on the code review | 19:59 |
| smcginnis | :-) | 19:59 |
| hemna | I'm glad someone saw that :) | 19:59 |
| vilobhmm1 | smcginnis : agree.. | 20:00 |
| geguileo | vilobhmm1: I think it did both, but I'd have to check to confirm | 20:01 |
| *** AlkaD has quit IRC | 20:01 | |
| geguileo | vilobhmm1: Mind if I confirm tomorrow? It's 22:00 here and I'm hungry XD | 20:01 |
| smcginnis | eharney: Did you see there was a response to your comment here: https://review.openstack.org/#/c/162130/3/cinderclient/utils.py | 20:01 |
| eharney | smcginnis: yes thanks | 20:02 |
| e0ne | hemna: it's good time to merge it (of course, after conflict resolve) | 20:02 |
| vilobhmm1 | geguileo : thats fine…but it would be nice to get that in if we have it | 20:02 |
| vilobhmm1 | good night :) | 20:02 |
| smcginnis | vilobhmm1: Have a good one... | 20:02 |
| e0ne | hemna: we hadn't do it in Kilo because some driver unit tests failed after moving to a new structure - i think is was issue with global objects like configs and incorrect mocking | 20:03 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Move RBD calls to a separate threads https://review.openstack.org/175555 | 20:05 |
| openstackgerrit | hadi esiely proposed openstack/cinder-specs: Volume Encryption Metadata Specification https://review.openstack.org/176050 | 20:08 |
| *** annashen has quit IRC | 20:08 | |
| geguileo | vilobhmm1: Ok cache is added to findall of v1 and v2 | 20:09 |
| geguileo | vilobhmm1: Because it modifies the base class | 20:09 |
| *** AlkaD has joined #openstack-cinder | 20:09 | |
| e0ne | geguileo: i'll test and review yours patch once i'll get my env working | 20:10 |
| *** dustins_ has joined #openstack-cinder | 20:11 | |
| geguileo | e0ne: Thanks! and ping me if you see anything weird with them :-) | 20:13 |
| *** dustins has quit IRC | 20:14 | |
| *** BaconIsKing has quit IRC | 20:14 | |
| *** jwang_ has quit IRC | 20:16 | |
| *** jwang_ has joined #openstack-cinder | 20:16 | |
| *** e0ne is now known as e0ne_ | 20:17 | |
| e0ne_ | bb in ~12 hours | 20:17 |
| *** david-lyle has joined #openstack-cinder | 20:21 | |
| *** ronis_ has quit IRC | 20:22 | |
| *** rongze has joined #openstack-cinder | 20:28 | |
| *** dannywilson has joined #openstack-cinder | 20:28 | |
| *** sgotliv has quit IRC | 20:28 | |
| smcginnis | Speaking of avoiding rebases - would love it if I could get some eyes on this: https://review.openstack.org/#/c/173368/ | 20:29 |
| *** rongze has quit IRC | 20:32 | |
| *** asselin_ has quit IRC | 20:43 | |
| openstackgerrit | Mike Perez proposed openstack/cinder: Move unit tests into dedicated directory https://review.openstack.org/175583 | 20:45 |
| thingee | hemna: ^ | 20:45 |
| thingee | wanna try again? | 20:45 |
| hemna | ok | 20:45 |
| * hemna waits for jenkins | 20:46 | |
| *** emagana has quit IRC | 20:46 | |
| *** alexpilotti has joined #openstack-cinder | 20:51 | |
| *** openstackgerrit has quit IRC | 20:52 | |
| smcginnis | Never seen a patch going through check and gate queues at the same time. Is that normal? | 20:52 |
| *** openstackgerrit has joined #openstack-cinder | 20:52 | |
| *** changbl has quit IRC | 20:57 | |
| *** julim has quit IRC | 20:57 | |
| thingee | xyang1: is there a patch for incremental backsupport in cinderclient? | 20:57 |
| xyang1 | thingee: Yes, one minute | 20:58 |
| *** timcl has quit IRC | 20:59 | |
| xyang1 | thingee: Here: https://review.openstack.org/#/c/112101/ | 20:59 |
| thingee | thanks | 21:00 |
| *** annashen has joined #openstack-cinder | 21:01 | |
| *** Lee1092 has quit IRC | 21:01 | |
| xyang1 | thingee: Two more CG cinderclient patches: https://review.openstack.org/#/c/144567/ , https://review.openstack.org/#/c/148790/ | 21:01 |
| thingee | yeah saw them. I'll check 'em out before tagging cinderclient, thanks | 21:02 |
| *** bswartz has quit IRC | 21:02 | |
| xyang1 | thingee: Thanks | 21:03 |
| *** dustins_ has quit IRC | 21:03 | |
| *** annashen has quit IRC | 21:06 | |
| vilobhmm1 | thanks geguileo | 21:06 |
| *** haomaiwang has quit IRC | 21:07 | |
| *** haomaiwang has joined #openstack-cinder | 21:07 | |
| *** vilobhmm1 has quit IRC | 21:08 | |
| *** Yogi1 has quit IRC | 21:09 | |
| *** vilobhmm11 has joined #openstack-cinder | 21:09 | |
| *** vilobhmm12 has joined #openstack-cinder | 21:11 | |
| *** vilobhmm12 has quit IRC | 21:11 | |
| *** vilobhmm13 has joined #openstack-cinder | 21:11 | |
| *** vilobhmm11 has quit IRC | 21:12 | |
| openstackgerrit | Jay Bryant proposed openstack/cinder: Add hacking check for str and unicode in exceptions https://review.openstack.org/175604 | 21:17 |
| *** lpetrut has quit IRC | 21:19 | |
| *** eharney has quit IRC | 21:20 | |
| *** lpetrut has joined #openstack-cinder | 21:21 | |
| *** thangp has quit IRC | 21:21 | |
| *** lpetrut has quit IRC | 21:22 | |
| *** rongze has joined #openstack-cinder | 21:28 | |
| openstackgerrit | Alex Meade proposed openstack/cinder: Add tracing facility to NetApp ONTAP drivers https://review.openstack.org/157439 | 21:29 |
| openstackgerrit | Alex Meade proposed openstack/cinder: Add tracing facility to NetApp ESeries driver https://review.openstack.org/170580 | 21:29 |
| *** jungleboyj has quit IRC | 21:29 | |
| *** e0ne_ has quit IRC | 21:31 | |
| *** emagana has joined #openstack-cinder | 21:32 | |
| *** rongze has quit IRC | 21:33 | |
| *** mwichmann has joined #openstack-cinder | 21:34 | |
| *** haomaiwang has quit IRC | 21:35 | |
| *** haomaiwang has joined #openstack-cinder | 21:36 | |
| *** haomaiwang has quit IRC | 21:40 | |
| openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC driver calls out the wrong REST API version https://review.openstack.org/176095 | 21:41 |
| *** haomaiwang has joined #openstack-cinder | 21:42 | |
| *** mriedem is now known as mriedem_away | 21:44 | |
| *** sgotliv has joined #openstack-cinder | 21:44 | |
| *** sgotliv has quit IRC | 21:45 | |
| *** sgotliv has joined #openstack-cinder | 21:45 | |
| *** patrickeast has quit IRC | 21:51 | |
| *** rmesta has quit IRC | 21:51 | |
| *** diemt has quit IRC | 21:52 | |
| *** mtanino has quit IRC | 21:52 | |
| *** emagana has quit IRC | 21:53 | |
| *** emagana has joined #openstack-cinder | 21:54 | |
| *** mtanino has joined #openstack-cinder | 21:55 | |
| *** AlkaD has quit IRC | 21:57 | |
| *** emagana has quit IRC | 21:59 | |
| thingee | hemna: https://github.com/openstack/os-brick/tree/0.1.0 | 21:59 |
| thingee | \o/ | 21:59 |
| *** akerr has quit IRC | 21:59 | |
| hemna | !! | 21:59 |
| openstack | hemna: Error: "!" is not a valid command. | 21:59 |
| thingee | LOL | 21:59 |
| hemna | haha | 21:59 |
| *** harlowja is now known as harlowja_away | 22:00 | |
| *** vilobhmm13 has quit IRC | 22:03 | |
| *** vilobhmm1 has joined #openstack-cinder | 22:03 | |
| *** vilobhmm1 has quit IRC | 22:03 | |
| *** vilobhmm1 has joined #openstack-cinder | 22:04 | |
| *** harlowja_away is now known as harlowja | 22:05 | |
| Swanson | Check seems broken. | 22:10 |
| *** emagana has joined #openstack-cinder | 22:10 | |
| *** vilobhmm1 has quit IRC | 22:12 | |
| *** vilobhmm1 has joined #openstack-cinder | 22:12 | |
| *** jungleboyj has joined #openstack-cinder | 22:14 | |
| *** vilobhmm1 has quit IRC | 22:14 | |
| *** vilobhmm1 has joined #openstack-cinder | 22:15 | |
| *** patrickeast has joined #openstack-cinder | 22:18 | |
| *** patrickeast has quit IRC | 22:21 | |
| *** dannywilson has quit IRC | 22:22 | |
| *** akerr has joined #openstack-cinder | 22:23 | |
| *** patrickeast has joined #openstack-cinder | 22:24 | |
| *** akerr_ has joined #openstack-cinder | 22:25 | |
| *** Rockyg has quit IRC | 22:26 | |
| *** akerr has quit IRC | 22:28 | |
| *** rongze has joined #openstack-cinder | 22:29 | |
| *** annegentle has joined #openstack-cinder | 22:32 | |
| *** _cjones_ has quit IRC | 22:33 | |
| *** rongze has quit IRC | 22:34 | |
| *** ebalduf has quit IRC | 22:35 | |
| *** annegentle has quit IRC | 22:38 | |
| *** lcurtis has quit IRC | 22:38 | |
| *** mwichmann has left #openstack-cinder | 22:39 | |
| *** _cjones_ has joined #openstack-cinder | 22:42 | |
| *** haomaiwang has quit IRC | 22:46 | |
| *** annegentle has joined #openstack-cinder | 22:46 | |
| *** haomaiwang has joined #openstack-cinder | 22:47 | |
| *** haomaiwang has quit IRC | 22:49 | |
| *** haomaiwang has joined #openstack-cinder | 22:50 | |
| *** Longgeek has quit IRC | 22:54 | |
| *** annegentle has quit IRC | 23:00 | |
| *** bswartz has joined #openstack-cinder | 23:03 | |
| *** annashen has joined #openstack-cinder | 23:03 | |
| *** annashen has quit IRC | 23:08 | |
| *** hemna is now known as hemnafk | 23:12 | |
| *** markvoelker_ has quit IRC | 23:16 | |
| *** akerr_ is now known as akerr_away | 23:26 | |
| *** rongze has joined #openstack-cinder | 23:30 | |
| *** bill_az has quit IRC | 23:34 | |
| *** rongze has quit IRC | 23:34 | |
| *** bill_az has joined #openstack-cinder | 23:38 | |
| *** esker has quit IRC | 23:38 | |
| *** zhenguo has joined #openstack-cinder | 23:47 | |
| *** garthb_ has quit IRC | 23:48 | |
| *** garthb has quit IRC | 23:48 | |
| *** akerr_away is now known as akerr_ | 23:49 | |
| *** s-moriya has joined #openstack-cinder | 23:51 | |
| *** rhagarty has joined #openstack-cinder | 23:51 | |
| *** rhagarty_ has joined #openstack-cinder | 23:51 | |
| *** rwsu has quit IRC | 23:56 | |
| *** melwitt has quit IRC | 23:56 | |
| *** dannywilson has joined #openstack-cinder | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!