*** salv-orlando has joined #openstack-cinder | 00:05 | |
*** david-ly_ has joined #openstack-cinder | 00:06 | |
*** jwcroppe has quit IRC | 00:07 | |
*** jwcroppe has joined #openstack-cinder | 00:07 | |
*** akerr_ has quit IRC | 00:08 | |
*** david-lyle has quit IRC | 00:08 | |
*** jwcroppe has quit IRC | 00:10 | |
*** akerr has joined #openstack-cinder | 00:10 | |
*** garthb_ has quit IRC | 00:11 | |
*** garthb has quit IRC | 00:11 | |
*** salv-orlando has quit IRC | 00:12 | |
*** Longgeek has joined #openstack-cinder | 00:12 | |
*** jwcroppe has joined #openstack-cinder | 00:13 | |
*** dims_ has joined #openstack-cinder | 00:14 | |
*** esker has quit IRC | 00:15 | |
*** edmondsw has joined #openstack-cinder | 00:16 | |
*** gouthamr has joined #openstack-cinder | 00:16 | |
*** dims has quit IRC | 00:16 | |
*** edmondsw_ has joined #openstack-cinder | 00:16 | |
*** edmondsw_ has quit IRC | 00:17 | |
*** leeantho has quit IRC | 00:17 | |
harlowja | anyone know if http://logs.openstack.org/58/195358/2/check/gate-tempest-dsvm-neutron-src-oslo.service/95420c7/logs/screen-c-api.txt.gz?level=WARNING#_2015-06-24_23_58_01_831 has/is being fixed ? | 00:20 |
---|---|---|
harlowja | might be something new (?) | 00:21 |
*** salv-orlando has joined #openstack-cinder | 00:21 | |
*** Longgeek has quit IRC | 00:23 | |
*** esker has joined #openstack-cinder | 00:25 | |
*** salv-orlando has quit IRC | 00:27 | |
*** rushiagr_away is now known as rushiagr | 00:32 | |
*** rwsu has quit IRC | 00:38 | |
*** boris-42 has quit IRC | 00:42 | |
mtanino | harlowja: oslo.service is imported today. so I guess it is new. https://review.openstack.org/#/c/193951/ | 00:42 |
*** mriedem has quit IRC | 00:45 | |
harlowja | mtanino interesting, wonder how that passed/merged :-/ | 00:46 |
harlowja | magically somehow, ha | 00:47 |
mtanino | hmm, what kind of magic happened.... | 00:47 |
*** jwcroppe_ has joined #openstack-cinder | 00:47 | |
*** edmondsw has quit IRC | 00:47 | |
* harlowja just was wondering how http://logs.openstack.org/58/195358/2/check/gate-tempest-dsvm-neutron-src-oslo.service/95420c7/logs/screen-c-api.txt.gz?level=WARNING#_2015-06-24_23_58_01_831 happened, shouldn't 193951 not have merged if that was possible | 00:48 | |
*** diogogmt has quit IRC | 00:48 | |
*** r-daneel has quit IRC | 00:48 | |
mtanino | Can you reproduce it in your devstack environment? | 00:49 |
*** rushiagr is now known as rushiagr_away | 00:49 | |
*** jwcroppe has quit IRC | 00:49 | |
harlowja | don't really have to, can just follow the code :) | 00:52 |
*** zhenguo has joined #openstack-cinder | 00:52 | |
*** tobe has joined #openstack-cinder | 00:56 | |
openstackgerrit | Joshua Harlow proposed openstack/cinder: Ensure 'WSGIService' derives from oslo_service base class https://review.openstack.org/195369 | 00:57 |
*** Rockyg has joined #openstack-cinder | 01:05 | |
*** smoriya has joined #openstack-cinder | 01:06 | |
*** DericHorn-HP has joined #openstack-cinder | 01:16 | |
mtanino | This is not happen in my devstack environment... hmm | 01:18 |
winston-d | mtanino, harlowja: i am not seeing the issue in my devstack | 01:23 |
harlowja | hmmm, odd | 01:24 |
harlowja | whats up with that | 01:24 |
mtanino | mee too. | 01:24 |
mtanino | but your proposed code seems fix the root cause. | 01:24 |
harlowja | https://github.com/openstack/oslo.service/blob/0.1.0/oslo_service/service.py#L624 | 01:25 |
* harlowja that should be triggered, are u guys using the installed oslo.service ? | 01:25 | |
harlowja | weird | 01:25 |
*** laughterwym_ has joined #openstack-cinder | 01:25 | |
*** Lee1092 has joined #openstack-cinder | 01:26 | |
*** Yogi11 has joined #openstack-cinder | 01:27 | |
harlowja | which eventually gets called by https://github.com/openstack/cinder/blob/master/cinder/service.py#L439 ... | 01:27 |
harlowja | and all that | 01:27 |
mtanino | yes, oslo.service 0.1.0 is installed in my environment. | 01:27 |
harlowja | which comes from https://github.com/openstack/cinder/blob/master/cinder/cmd/api.py#L58 | 01:27 |
harlowja | weird | 01:27 |
*** laughterwym has quit IRC | 01:29 | |
*** davechen_away is now known as davechen | 01:31 | |
*** DericHorn-HP has quit IRC | 01:31 | |
harlowja | well anywho, seems like the right fix anyway | 01:34 |
harlowja | even if https://github.com/openstack/oslo.service/blob/0.1.0/oslo_service/service.py#L623 somehow isn't being hit for u guys | 01:34 |
harlowja | likely would of anyway (if https://github.com/openstack/oslo.service/commit/59ed2ec38 change caused that) | 01:34 |
*** david-ly_ is now known as david-lyle | 01:36 | |
*** Yogi11 has quit IRC | 01:37 | |
mtanino | ahh, using master branch oslo.service causes error which you mentioned. | 01:40 |
*** _cjones_ has quit IRC | 01:41 | |
mtanino | harlowja: And using your patch, the problem was solved :) | 01:41 |
harlowja | woot | 01:41 |
mtanino | I guess same issue will be happen at nova? | 01:42 |
winston-d | so CI is not using pip for oslo_service? | 01:45 |
*** dims_ has quit IRC | 01:45 | |
mtanino | fmm, this did not happen nova... | 01:48 |
mtanino | ah, they still use nova.openstack.common.service | 01:49 |
*** davechen is now known as davechen_afk | 01:50 | |
*** dims has joined #openstack-cinder | 01:50 | |
mtanino | winston-d: not sure but using pip package(0.1.0), that error did not happen. | 01:51 |
winston-d | mtanino: yeah, that's what I am seeing in my devstack | 01:53 |
mtanino | master branch is 0.1.1.dev12 and this version causes that error in my devstack environment. | 01:53 |
mtanino | so if you uninstall pip version oslo.service and "python setup.py install" for oslo.service you will hit the error. | 01:54 |
harlowja | winston-d so what i think is happening is that https://github.com/openstack/oslo.service/commit/59ed2ec38 hasn't propagated out yet | 01:54 |
harlowja | and the http://logs.openstack.org/58/195358/2/check/gate-tempest-dsvm-neutron-src-oslo.service/95420c7/logs/screen-c-api.txt.gz?level=WARNING#_2015-06-24_23_58_01_831 is an early warning system | 01:54 |
harlowja | that would of eventually hit everyone i guess | 01:54 |
harlowja | *or will with the next oslo.service release | 01:54 |
winston-d | harlowja: i thought it won't hit us until next oslo.service release | 01:55 |
harlowja | right, so it might not be an immediate fix needed, but it doesn't hurt | 01:56 |
*** dontalton has quit IRC | 01:56 | |
harlowja | *and avoids the pain in the near-future | 01:56 |
winston-d | harlowja: your fix is good fix, no doubt about that. | 01:57 |
winston-d | harlowja: but if you look at c-sch service code, it should have hit the issue: https://github.com/openstack/cinder/blob/master/cinder/cmd/scheduler.py#L52 | 01:57 |
earlephilhower | Is anyone else's CI nodepool dying today on a missing oslo_context during prepare_tempest_testerpo.py? http://paste.openstack.org/show/320645/ | 01:58 |
winston-d | https://github.com/openstack/cinder/blob/master/cinder/service.py#L444 | 01:58 |
winston-d | https://github.com/openstack/oslo.service/blob/0.1.0/oslo_service/service.py#L624 | 01:59 |
winston-d | need to run for a meeting | 01:59 |
patrickeast | earlephilhower: just checked, and yes, we are hitting that | 02:03 |
patrickeast | earlephilhower: our image failed to build last night from it | 02:03 |
*** dims has quit IRC | 02:04 | |
mtanino | winston-d: harlowja I think scheduler inherit Class service in oslo.service and the service class inherits the class Servicebase. | 02:04 |
mtanino | so the problem does not happen. | 02:04 |
akerr | patrickeast: how long ago? Our latest image was built 22.8 hours ago (so almost due for a rebuild) | 02:05 |
earlephilhower | patrickeast, Thanks for the confirmation! I just moved to a new (stable I hope) host and can't get a new nodepool image, didn't change the VMs at all. May steal one from old dead system and hack nodepool DB. | 02:06 |
patrickeast | akerr: mmm roughly 15 hours ago, it tried to run at 2am pst | 02:06 |
akerr | going to try and kick one off now | 02:07 |
patrickeast | lets maybe go ask in -infra if they have seen this | 02:09 |
*** Yogi1 has joined #openstack-cinder | 02:09 | |
*** dims has joined #openstack-cinder | 02:10 | |
*** gouthamr has quit IRC | 02:10 | |
*** DericHorn-HP has joined #openstack-cinder | 02:11 | |
*** DericHorn-HP has quit IRC | 02:12 | |
*** DericHorn-HP has joined #openstack-cinder | 02:14 | |
*** Yogi11 has joined #openstack-cinder | 02:14 | |
openstackgerrit | Xiaolei Hu proposed openstack/cinder: Split FC driver code into Common and FC https://review.openstack.org/195379 | 02:14 |
*** DericHorn-HP has quit IRC | 02:17 | |
*** Yogi1 has quit IRC | 02:17 | |
*** gouthamr has joined #openstack-cinder | 02:21 | |
*** Rockyg has quit IRC | 02:22 | |
*** patrickeast has quit IRC | 02:22 | |
openstackgerrit | Xiaolei Hu proposed openstack/cinder: Split FC driver code into Common and FC https://review.openstack.org/195382 | 02:24 |
*** akerr has quit IRC | 02:25 | |
*** salv-orl_ has joined #openstack-cinder | 02:29 | |
*** bkopilov has quit IRC | 02:33 | |
*** salv-orl_ has quit IRC | 02:34 | |
*** laughterwym__ has joined #openstack-cinder | 02:35 | |
*** laughterwym_ has quit IRC | 02:36 | |
openstackgerrit | Xi Yang proposed openstack/cinder: Provide snap copy feature in EMC VNX Cinder driver https://review.openstack.org/184733 | 02:39 |
*** diogogmt has joined #openstack-cinder | 02:40 | |
*** dguryanov has quit IRC | 02:46 | |
*** IanGovett has quit IRC | 02:49 | |
*** gouthamr has quit IRC | 02:50 | |
*** gouthamr has joined #openstack-cinder | 02:51 | |
*** dims has quit IRC | 02:58 | |
*** harlowja_at_home has joined #openstack-cinder | 03:01 | |
*** akerr has joined #openstack-cinder | 03:02 | |
*** akerr has quit IRC | 03:08 | |
openstackgerrit | Qian Gao proposed openstack/cinder: Storwize: add the missing stops in the end of the messages https://review.openstack.org/194970 | 03:12 |
*** Tross has quit IRC | 03:12 | |
*** Tross has joined #openstack-cinder | 03:12 | |
*** amit213 has quit IRC | 03:12 | |
*** zul has quit IRC | 03:13 | |
*** amit213 has joined #openstack-cinder | 03:13 | |
*** gouthamr_ has joined #openstack-cinder | 03:16 | |
*** zul has joined #openstack-cinder | 03:17 | |
*** gouthamr has quit IRC | 03:20 | |
*** Longgeek has joined #openstack-cinder | 03:20 | |
*** Longgeek has quit IRC | 03:21 | |
*** Longgeek has joined #openstack-cinder | 03:21 | |
*** tobe has quit IRC | 03:26 | |
*** mtanino has quit IRC | 03:31 | |
*** Yogi11 has quit IRC | 03:35 | |
*** gouthamr_ has quit IRC | 03:36 | |
*** dannywil_ has joined #openstack-cinder | 03:36 | |
*** diogogmt has quit IRC | 03:38 | |
*** tobe has joined #openstack-cinder | 03:39 | |
*** dannywilson has quit IRC | 03:40 | |
*** dannywil_ has quit IRC | 03:40 | |
*** bkopilov has joined #openstack-cinder | 03:54 | |
*** coolsvap|away is now known as coolsvap | 04:04 | |
*** heyun has joined #openstack-cinder | 04:07 | |
*** vilobhmm has joined #openstack-cinder | 04:14 | |
*** heyun1 has joined #openstack-cinder | 04:17 | |
*** esker has quit IRC | 04:18 | |
*** esker has joined #openstack-cinder | 04:18 | |
*** hemna has joined #openstack-cinder | 04:19 | |
*** MJ_ has joined #openstack-cinder | 04:19 | |
MJ_ | Hi... | 04:19 |
MJ_ | unable to attach volume to instance in openstack kilo | 04:20 |
*** heyun has quit IRC | 04:20 | |
MJ_ | debugging gives me following outpuy | 04:20 |
MJ_ | DEBUG (shell:914) The server has either erred or is incapable of performing the requested operation. (HTTP 500) (Request-ID: req-0fe16b68-0efa-408d-a8b5-c21513c78dea) Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/novaclient/shell.py", line 911, in main OpenStackComputeShell().main(argv) File "/usr/lib/python2.7/dist-packages/novaclient/shell.py", line 838, in main args.func(self.cs, args | 04:20 |
hemna | looks like a nova api issue | 04:21 |
MJ_ | how to resolve it? | 04:21 |
MJ_ | I am able to launch a vm so i guess issue with nova - cinder communication | 04:22 |
*** esker has quit IRC | 04:23 | |
openstackgerrit | Edwin Wang proposed openstack/cinder: Split FC driver code into Common and FC https://review.openstack.org/195382 | 04:28 |
*** DericHorn-HP has joined #openstack-cinder | 04:28 | |
*** laughterwym__ has quit IRC | 04:30 | |
*** laughterwym has joined #openstack-cinder | 04:30 | |
*** laughterwym_ has joined #openstack-cinder | 04:30 | |
*** laughterwym_ has quit IRC | 04:31 | |
*** yamada-h has joined #openstack-cinder | 04:31 | |
*** shausy has joined #openstack-cinder | 04:33 | |
*** annashen has joined #openstack-cinder | 04:36 | |
laughterwym | hemna: ping? | 04:36 |
hemna | hey | 04:36 |
laughterwym | Hemma: We proposed a change that split our old FlashSystem FC driver into common and FC part. So IMO it's not a new FC driver. | 04:37 |
*** Longgeek has quit IRC | 04:37 | |
laughterwym | hemna: https://review.openstack.org/#/c/195382 | 04:37 |
*** Longgeek has joined #openstack-cinder | 04:37 | |
hemna | it looks like a new FC driver to me | 04:38 |
hemna | is there an FC CI for it already in place? | 04:38 |
laughterwym | Yes. | 04:38 |
laughterwym | It's running from Kilo. | 04:39 |
*** hemna has quit IRC | 04:40 | |
laughterwym | hemna: The original FC driver is merged in Kilo. This proposal is to break it into common part and then the new iSCSI driver can inherit from the common part. | 04:41 |
*** salv-orlando has joined #openstack-cinder | 04:41 | |
*** hemna has joined #openstack-cinder | 04:42 | |
hemna | ok I'll check the CI results later | 04:42 |
hemna | I see something that resembles an FC based driver in the original common file | 04:42 |
laughterwym | hemna: iSCSI driver has been merged in L-1. And you can see this a small change that flashsystem_fc.py is split from old flashsystem.py. | 04:43 |
hemna | well, it's not a small change | 04:43 |
hemna | I had to look at the removed file to see the original FC code | 04:43 |
hemna | very confusing files | 04:43 |
hemna | looks like the refactor cleans it up a bit though :) | 04:44 |
*** Longgeek has quit IRC | 04:44 | |
laughterwym | hemna: Yes. It was confused before. So we'd like to make it clear - three parts: common, FC and iSCSI. | 04:44 |
*** shyama has joined #openstack-cinder | 04:45 | |
hemna | coolio | 04:45 |
*** MJ_ has quit IRC | 04:45 | |
laughterwym | :) | 04:46 |
*** salv-orlando has quit IRC | 04:47 | |
*** hemna has quit IRC | 05:05 | |
*** annashen has quit IRC | 05:05 | |
*** dannywilson has joined #openstack-cinder | 05:07 | |
*** BharatK has joined #openstack-cinder | 05:12 | |
*** Longgeek has joined #openstack-cinder | 05:17 | |
*** esker has joined #openstack-cinder | 05:19 | |
*** vilobhmm has quit IRC | 05:26 | |
*** dannywilson has quit IRC | 05:30 | |
*** dannywilson has joined #openstack-cinder | 05:31 | |
*** esker has quit IRC | 05:32 | |
*** shausy has quit IRC | 05:33 | |
*** dannywilson has quit IRC | 05:35 | |
*** nkrinner has joined #openstack-cinder | 05:39 | |
*** nlevinki has joined #openstack-cinder | 05:41 | |
*** markvoelker has quit IRC | 05:43 | |
*** eduardo has quit IRC | 05:49 | |
*** esker has joined #openstack-cinder | 05:59 | |
*** laughterwym_ has joined #openstack-cinder | 06:02 | |
*** DericHorn-HP has quit IRC | 06:04 | |
*** ericksonsantos has quit IRC | 06:05 | |
*** laughterwym has quit IRC | 06:05 | |
*** BharatK has quit IRC | 06:07 | |
*** agarciam has joined #openstack-cinder | 06:10 | |
*** tobe has quit IRC | 06:14 | |
*** changbl_ has quit IRC | 06:15 | |
*** esker has quit IRC | 06:15 | |
*** BharatK has joined #openstack-cinder | 06:19 | |
*** deepakcs has joined #openstack-cinder | 06:21 | |
*** nlevinki has quit IRC | 06:25 | |
*** tobe has joined #openstack-cinder | 06:33 | |
openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: sheepdog: Add class for dog command executor https://review.openstack.org/194532 | 06:35 |
*** mkoderer_cloud has joined #openstack-cinder | 06:39 | |
*** ian_brown has quit IRC | 06:40 | |
*** esker has joined #openstack-cinder | 06:41 | |
*** markvoelker has joined #openstack-cinder | 06:43 | |
*** markvoelker has quit IRC | 06:49 | |
*** belmoreira has joined #openstack-cinder | 06:53 | |
*** salv-orlando has joined #openstack-cinder | 06:54 | |
*** salv-orlando has quit IRC | 06:56 | |
*** salv-orlando has joined #openstack-cinder | 06:56 | |
*** esker has quit IRC | 06:56 | |
*** aix has joined #openstack-cinder | 06:56 | |
*** markus_z has joined #openstack-cinder | 06:57 | |
*** lennyb has quit IRC | 07:03 | |
*** root_ has joined #openstack-cinder | 07:07 | |
*** root_ has quit IRC | 07:09 | |
*** lennyb has joined #openstack-cinder | 07:12 | |
*** anshul has joined #openstack-cinder | 07:14 | |
*** lan has quit IRC | 07:20 | |
*** lan has joined #openstack-cinder | 07:20 | |
*** esker has joined #openstack-cinder | 07:23 | |
openstackgerrit | TaoBai proposed openstack/cinder: test https://review.openstack.org/195434 | 07:26 |
*** esker has quit IRC | 07:38 | |
*** BharatK has quit IRC | 07:39 | |
*** lpetrut has joined #openstack-cinder | 07:41 | |
*** jordanP has joined #openstack-cinder | 07:42 | |
*** tobe has quit IRC | 07:48 | |
*** BharatK has joined #openstack-cinder | 07:51 | |
*** BharatK has quit IRC | 07:58 | |
*** BharatK has joined #openstack-cinder | 07:59 | |
openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: sheepdog: Add class for dog command executor https://review.openstack.org/194532 | 08:03 |
*** tobe has joined #openstack-cinder | 08:04 | |
*** esker has joined #openstack-cinder | 08:04 | |
*** ndipanov has joined #openstack-cinder | 08:06 | |
*** harlowja_still_a has joined #openstack-cinder | 08:10 | |
aarefiev | winston-d: hi, are you around? | 08:13 |
*** harlowja_at_home has quit IRC | 08:14 | |
aarefiev | winston-d: could you look at https://review.openstack.org/#/c/195155/ , small fix with resolving host with pool part | 08:16 |
*** coolsvap is now known as coolsvap|away | 08:16 | |
*** deepakcs has quit IRC | 08:17 | |
*** coolsvap|away is now known as coolsvap | 08:19 | |
*** esker has quit IRC | 08:20 | |
*** e0ne has joined #openstack-cinder | 08:32 | |
*** markvoelker has joined #openstack-cinder | 08:32 | |
*** e0ne has quit IRC | 08:37 | |
*** markvoelker has quit IRC | 08:37 | |
*** shyama has quit IRC | 08:37 | |
*** haypo has joined #openstack-cinder | 08:38 | |
*** laughterwym_ has quit IRC | 08:42 | |
*** BharatK has quit IRC | 08:45 | |
*** esker has joined #openstack-cinder | 08:46 | |
*** yamada-h has quit IRC | 08:51 | |
winston-d | aarefiev: sure | 08:52 |
winston-d | aarefiev: looking | 08:52 |
aarefiev | winston-d: thank you | 08:53 |
*** salv-orl_ has joined #openstack-cinder | 08:53 | |
winston-d | aarefiev: done | 08:54 |
aarefiev | winston-d: you are fast :) , thanks | 08:55 |
*** salv-orlando has quit IRC | 08:57 | |
*** salv-orl_ has quit IRC | 08:58 | |
*** esker has quit IRC | 09:01 | |
*** e0ne has joined #openstack-cinder | 09:10 | |
*** shyama has joined #openstack-cinder | 09:14 | |
*** e0ne is now known as e0ne_ | 09:16 | |
openstackgerrit | Sergey Vilgelm proposed openstack/os-brick: Switch to oslo.service https://review.openstack.org/195469 | 09:18 |
openstackgerrit | TaoBai proposed openstack/cinder: Storwize driver report capability for multiattach https://review.openstack.org/195471 | 09:20 |
*** e0ne_ has quit IRC | 09:22 | |
*** esker has joined #openstack-cinder | 09:28 | |
*** lpetrut has quit IRC | 09:28 | |
*** e0ne has joined #openstack-cinder | 09:33 | |
*** laughterwym has joined #openstack-cinder | 09:36 | |
*** BharatK has joined #openstack-cinder | 09:40 | |
openstackgerrit | Pranali Deore proposed openstack/cinder: Validate string, integer limit for input parameter https://review.openstack.org/194968 | 09:43 |
*** esker has quit IRC | 09:44 | |
*** alexpilotti has joined #openstack-cinder | 09:45 | |
*** atuvenie has joined #openstack-cinder | 09:50 | |
openstackgerrit | Michal Dulko proposed openstack/python-cinderclient: Add set_management_url to cinderclient.client https://review.openstack.org/153274 | 09:50 |
*** salv-orlando has joined #openstack-cinder | 09:51 | |
*** lixiaoy1 has quit IRC | 09:52 | |
*** laughterwym_ has joined #openstack-cinder | 09:53 | |
*** nlevinki has joined #openstack-cinder | 09:53 | |
*** salv-orl_ has joined #openstack-cinder | 09:56 | |
*** laughterwym has quit IRC | 09:56 | |
*** lpetrut has joined #openstack-cinder | 09:57 | |
*** salv-orlando has quit IRC | 09:58 | |
*** salv-orl_ has quit IRC | 09:59 | |
*** salv-orlando has joined #openstack-cinder | 09:59 | |
*** salv-orl_ has joined #openstack-cinder | 10:01 | |
*** salv-orlando has quit IRC | 10:03 | |
aarefiev | dulek: hi, I've answered on your question https://review.openstack.org/#/c/176233/ | 10:03 |
*** edmondsw has joined #openstack-cinder | 10:06 | |
*** edmondsw has quit IRC | 10:06 | |
*** edmondsw has joined #openstack-cinder | 10:07 | |
*** yamada-h has joined #openstack-cinder | 10:09 | |
*** esker has joined #openstack-cinder | 10:11 | |
*** dims has joined #openstack-cinder | 10:14 | |
*** BharatK has quit IRC | 10:15 | |
*** husanu4 has joined #openstack-cinder | 10:19 | |
*** markvoelker has joined #openstack-cinder | 10:21 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add pagination to snapshots https://review.openstack.org/195071 | 10:22 |
*** husanu4 has quit IRC | 10:25 | |
*** markvoelker has quit IRC | 10:25 | |
*** husanu3 has joined #openstack-cinder | 10:26 | |
*** husanu3 has quit IRC | 10:28 | |
*** shausy has joined #openstack-cinder | 10:28 | |
*** esker has quit IRC | 10:29 | |
*** husanu3 has joined #openstack-cinder | 10:29 | |
shausy | Hi Im facing problem with attaching volume to instance [ Driver - Netapp iSCSI] | 10:30 |
shausy | following is my error | 10:30 |
shausy | ERROR nova.virt.block_device [req-21a265d0-1bc0-4bab-86f2-f2b6d167727b ef123e34625a466794faabc52fe0eda9 7e7a2c9f4bef469882f6808641dd9eab] [instance: a1364e74-9b40-46e6-aafc-a6a51a9caa1b] Driver failed to attach volume 310814f5-e564-46d1-a5aa-e064f3cb4e07 at /dev/vdb | 10:30 |
shausy | Any help on this ? | 10:30 |
*** husanu3 has quit IRC | 10:31 | |
*** e0ne is now known as e0ne_ | 10:31 | |
*** jasondot_ has joined #openstack-cinder | 10:32 | |
*** e0ne_ has quit IRC | 10:36 | |
*** jasondot_ is now known as jasondotstar | 10:37 | |
openstackgerrit | Sasikanth Eda proposed openstack/cinder: GPFS volume encryption-at-rest support https://review.openstack.org/195507 | 10:37 |
*** yamada-h_ has joined #openstack-cinder | 10:43 | |
dulek | aarefiev: Good point, I'll happily +1 the spec once tbarron's comments will be addressed. | 10:46 |
*** yamada-h has quit IRC | 10:47 | |
*** juzuluag has quit IRC | 10:47 | |
aarefiev | dulek: ok, thanks, I'm working om impl, I'll try to push it today and update the spec | 10:47 |
*** heyun1 has quit IRC | 10:52 | |
*** esker has joined #openstack-cinder | 10:54 | |
*** e0ne has joined #openstack-cinder | 10:55 | |
*** IanGovett has joined #openstack-cinder | 10:59 | |
*** timcl has joined #openstack-cinder | 11:00 | |
openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 11:00 |
openstackgerrit | Daniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object https://review.openstack.org/163641 | 11:00 |
*** dims has quit IRC | 11:02 | |
*** breitz has quit IRC | 11:02 | |
openstackgerrit | wanghao proposed openstack/cinder: Do not allow to modify access for public volume type https://review.openstack.org/194549 | 11:02 |
*** breitz has joined #openstack-cinder | 11:02 | |
*** dims has joined #openstack-cinder | 11:05 | |
*** shyama_ has joined #openstack-cinder | 11:06 | |
*** shyama has quit IRC | 11:09 | |
*** shyama_ is now known as shyama | 11:09 | |
*** dims_ has joined #openstack-cinder | 11:10 | |
*** dims has quit IRC | 11:11 | |
*** tobe has quit IRC | 11:11 | |
*** esker has quit IRC | 11:11 | |
*** yamada-h_ has quit IRC | 11:14 | |
*** salv-orl_ has quit IRC | 11:14 | |
*** e0ne is now known as e0ne_ | 11:15 | |
*** dims_ has quit IRC | 11:16 | |
openstackgerrit | Daniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object https://review.openstack.org/163641 | 11:16 |
*** david-lyle has quit IRC | 11:17 | |
*** dims has joined #openstack-cinder | 11:21 | |
*** david-lyle has joined #openstack-cinder | 11:21 | |
*** e0ne_ has quit IRC | 11:26 | |
*** e0ne has joined #openstack-cinder | 11:28 | |
*** ociuhandu has joined #openstack-cinder | 11:33 | |
*** ericksonsantos has joined #openstack-cinder | 11:33 | |
*** markvoelker has joined #openstack-cinder | 11:37 | |
*** esker has joined #openstack-cinder | 11:37 | |
*** EmilienM|off is now known as EmilienM | 11:38 | |
*** ociuhandu_ has joined #openstack-cinder | 11:39 | |
*** ociuhandu has quit IRC | 11:40 | |
*** ociuhandu_ is now known as ociuhandu | 11:40 | |
*** markvoelker has quit IRC | 11:41 | |
*** sgotliv has quit IRC | 11:44 | |
*** sgotliv has joined #openstack-cinder | 11:44 | |
*** salv-orlando has joined #openstack-cinder | 11:49 | |
*** jasondotstar has quit IRC | 11:50 | |
*** marcusvrn has quit IRC | 11:53 | |
*** esker has quit IRC | 11:54 | |
geguileo | dulek: ping - Tooz to replace file locks | 11:57 |
dulek | geguileo: Hi! | 11:57 |
geguileo | dulek: Hi | 11:58 |
geguileo | dulek: I was wondering, have you thought about replacing current file locks with Tooz in parallel with the Nova/Cinder fixes? | 11:58 |
*** markvoelker has joined #openstack-cinder | 11:58 | |
geguileo | dulek: I'm not talking about atomic state changes, just the file locks | 11:58 |
geguileo | dulek: For example that a snapshot is deleted while it's being used to create a volume | 11:59 |
dulek | geguileo: Ah, these kind of things... | 11:59 |
dulek | geguileo: I thought that such situation will be prevented by atomic state changes? | 12:00 |
dulek | We have something like that now: https://review.openstack.org/#/c/183537/ | 12:00 |
geguileo | dulek: Not really, because in that case the snapshot would not change its state | 12:00 |
dulek | (+dependent patch). | 12:00 |
dulek | geguileo: Ah, okay, you're right... | 12:00 |
geguileo | dulek: Yes I saw you patch, but maybe we should look at using it just to replace current file locks | 12:01 |
geguileo | dulek: And to include the missing lock you saw while working on volume create | 12:01 |
dulek | geguileo: Do you mean locks in volume.manager? | 12:02 |
geguileo | dulek: Since we should be possible to work in parallel with fixes to Cinder-Nova interaction | 12:02 |
dulek | geguileo: You mean that you're working on Nova error handling now? | 12:03 |
*** zhenguo has quit IRC | 12:04 | |
dulek | Okay, let me try to summarize what I know. ;) | 12:04 |
geguileo | dulek: No I'm not | 12:04 |
dulek | I'm working on Nova->Cinder interactions now. | 12:04 |
geguileo | dulek: Ok, then I'll ask you some questions later :) | 12:05 |
geguileo | dulek: about that nova-cinder | 12:05 |
dulek | I've got a patch for attach almost ready, hoping to get it in review today. | 12:05 |
geguileo | dulek: For Nova or Cinder? | 12:05 |
dulek | I'm probably not addressing all the issues, but at least Nova doesn't blow up when Cinder returns an error. | 12:05 |
dulek | For Nova. | 12:05 |
geguileo | dulek: Nice! | 12:06 |
dulek | Szymon from my team is trying to reproduce some issues with locks in drivers. Right now we're stressing c-vol with GlusterFS driver working in A/A to see if things will get nasty (without distributed locks). | 12:07 |
geguileo | dulek: Ok | 12:08 |
dulek | So another activity you propose is to add locking for resources we're using (for example creating volume from snapshot, or snapshot from volume). | 12:09 |
geguileo | dulek: Wouldn't it be easier for a first step to replace utils.synchronized that use external with Tooz? | 12:09 |
*** agarciam has quit IRC | 12:09 | |
geguileo | dulek: Yes, basically replacing external synchronized everywhere | 12:09 |
geguileo | dulek: Default can be to file locks (same as it is now) | 12:09 |
geguileo | dulek: And easily changed to a DLM | 12:10 |
dulek | Yeah, that's how our Tooz patch is supposed to work - default to files. | 12:10 |
dulek | So I'm not sure if we're actually locking the snapshot anywhere when creating a volume from it. | 12:10 |
dulek | Do we? | 12:10 |
geguileo | dulek: There are some missing places | 12:11 |
geguileo | I think you found one the other day in Volume Create | 12:11 |
geguileo | And there's sure to be some more | 12:11 |
dulek | Okay, this would require some thinking how to approach that probably... | 12:11 |
geguileo | So I think we could retake your patch and put it up to date | 12:11 |
dulek | Which one? Can you link it? | 12:11 |
*** marcusvrn has joined #openstack-cinder | 12:12 | |
geguileo | Then create another one istead of the POC: Tooz locks demo | 12:12 |
geguileo | That addresses all calls to synchronized with external | 12:12 |
geguileo | And we would be no worse than we are now regarding Cinder-Nova interaction | 12:12 |
dulek | So you mean this one: https://review.openstack.org/#/c/183537/ | 12:13 |
geguileo | Then we can look for missing places where we have to add locks | 12:13 |
geguileo | dulek: Yes, retake that one | 12:13 |
dulek | I'm not even sure why it has -1 from Jenkins... | 12:14 |
geguileo | dulek: Don't know | 12:14 |
geguileo | In parallel to finding those missing locks we can look into making sure all drivers have the right kind of locks (external if they need) | 12:15 |
dulek | Ah, requirements... Seems like CI failure. | 12:15 |
dulek | Okay, I agree with you. | 12:16 |
geguileo | You are working on Cinder-Nova interactions now | 12:16 |
dulek | Feel free to revive the patch and base your work on it. :) | 12:17 |
geguileo | Are you going to keep working on that? | 12:17 |
dulek | If that's what you've asked actually. :P | 12:17 |
dulek | I would love to stop it. :D It's a mess. | 12:17 |
geguileo | dulek: I was actually asking (1) if you think it's a good idea | 12:17 |
geguileo | dulek: (2) If you were already working on it or if you were going to | 12:17 |
dulek | So for last 2 weeks we tried to prepare tests. | 12:18 |
geguileo | dulek: Ok, so you'll keep working on N-C | 12:18 |
geguileo | What kind of tests? | 12:18 |
dulek | Yeah, DuncanT had a little time for that. | 12:18 |
dulek | Steps to reproduce issues without DLM - we've talked about that at the summit. | 12:18 |
geguileo | Yes, I know, but I mean: Rally? Tempest? Manual? | 12:19 |
dulek | Right now we're trying to Rally. | 12:19 |
*** bswartz has quit IRC | 12:19 | |
dulek | If it won't work we'll probably stop - it eats too much time. ;) | 12:19 |
geguileo | So no success up to now? :( | 12:20 |
*** esker has joined #openstack-cinder | 12:21 | |
dulek | Yup, I'm not even sure what for are these locks in GlusterFS and RemoteFS. | 12:21 |
geguileo | XD | 12:21 |
dulek | hemnafk said that FC drivers brake without locks, but we don't have any FC gear. | 12:22 |
geguileo | Ok, because I was going to start working on tests to break Cinder and didn't want to redo work | 12:22 |
dulek | So were looking only on tests to prove that DLM is needed for locks *in drivers*. | 12:22 |
dulek | We haven't looked at any more. | 12:22 |
geguileo | Ok | 12:23 |
geguileo | By the way, the patch you'll be pushing today (if I leave you alone) is not about fixing Issue2 (https://etherpad.openstack.org/p/CinderNovaAPI) but just not breaking Nova on Cinder exceptions, right? | 12:24 |
dulek | More like: https://bugs.launchpad.net/nova/+bug/1458958 | 12:26 |
openstack | Launchpad bug 1458958 in OpenStack Compute (nova) "Exceptions from Cinder detach volume API not handled" [Undecided,In progress] - Assigned to Vilobh Meshram (vilobhmm) | 12:26 |
dulek | It's mentioned on Issue2, but isn't the root case I think | 12:26 |
*** rakesh_hs has joined #openstack-cinder | 12:26 | |
*** coolsvap is now known as coolsvap|away | 12:26 | |
geguileo | Ok, but that was just another thing I was going to ask hemnafk if we could do | 12:27 |
geguileo | Split between fixing things that are broken and things that prevent us from changing Cinder state changes | 12:27 |
dulek | Good point. | 12:28 |
dulek | So I think my work will enable atomic state changes. | 12:28 |
rakesh_hs | Hi Guys, could you please review https://review.openstack.org/#/c/194677/ | 12:29 |
dulek | Because Nova won't blow up if attach returns some exception. | 12:29 |
dulek | This means you can return VolumeBusy | 12:29 |
dulek | And Nova will be ready to accept new request to attach volume. | 12:29 |
geguileo | dulek: That's fantastic! | 12:29 |
*** akerr has joined #openstack-cinder | 12:29 | |
dulek | Right now it requires manual DB cleanup to recover from such issues. | 12:30 |
dulek | But definitely - I'm not sure. ;) | 12:30 |
dulek | It's probably best to ask hemnafk and others once I'll have the patch in Gerrit. | 12:30 |
geguileo | dulek: Maybe we should discuss with hemnafk what other changes need to be done just to allow us to keep working on Cinder side.... | 12:30 |
dulek | You're right. :) | 12:31 |
geguileo | dulek: Ok, I'll leave you to finish you patch and then we'll open the discussion, ok? ;-) | 12:31 |
*** dims has quit IRC | 12:31 | |
*** dims has joined #openstack-cinder | 12:31 | |
dulek | I have time till around 6 PM, lets see if we'll be able to catch anyone by then. | 12:32 |
*** bkopilov has quit IRC | 12:32 | |
*** kjnelson has joined #openstack-cinder | 12:32 | |
geguileo | dulek: It doesn't have to be today | 12:32 |
dulek | Okay. Sounds like we have a plan. :) | 12:33 |
geguileo | dulek: We can start reviewing your patch and then open the discussion tomorrow or next week | 12:33 |
geguileo | dulek: Cool! | 12:33 |
*** coolsvap|away is now known as coolsvap | 12:35 | |
*** david-ly_ has joined #openstack-cinder | 12:35 | |
*** resker has joined #openstack-cinder | 12:36 | |
*** coolsvap is now known as coolsvap|away | 12:36 | |
*** esker has quit IRC | 12:38 | |
*** geguileo has quit IRC | 12:38 | |
*** david-lyle has quit IRC | 12:39 | |
*** geguileo has joined #openstack-cinder | 12:43 | |
*** jasondotstar has joined #openstack-cinder | 12:46 | |
smcginnis | haypo: You around? | 12:47 |
haypo | smcginnis: hi | 12:47 |
smcginnis | haypo: Hey! So I was watching the py34 tests yesterday. | 12:48 |
smcginnis | haypo: Didn't see any issues. | 12:48 |
smcginnis | haypo: So for me at least I am more comfortable moving that to voting now. | 12:48 |
smcginnis | haypo: Just seemed a little too quick yesterday. :) | 12:48 |
*** lpetrut1 has joined #openstack-cinder | 12:49 | |
haypo | smcginnis: good :) for nova, i had to check the previous week. but failures were only real py3 bugs because a patch introduced py3 regressions | 12:49 |
haypo | (a patch under review) | 12:49 |
haypo | smcginnis: we can wait one week, there is no urgency | 12:49 |
smcginnis | haypo: Yeah, it's a balance I think between risking something non-py3 getting in and having gate issues. | 12:50 |
*** lpetrut has quit IRC | 12:50 | |
smcginnis | haypo: But based on the ones I've looked at my concerns are met. | 12:50 |
*** husanu4 has joined #openstack-cinder | 12:50 | |
smcginnis | Can't speak for others of course. | 12:50 |
openstackgerrit | Rakesh H S proposed openstack/cinder: check for encrypted volume type existance before deleting https://review.openstack.org/194677 | 12:51 |
*** husanu4 has quit IRC | 12:52 | |
haypo | smcginnis: i removed the WIP status of https://review.openstack.org/#/c/195101/ feel free to elaborate your point of view their with a vote ;) | 12:53 |
smcginnis | haypo: Will do. | 12:53 |
*** tellesnobrega_ has joined #openstack-cinder | 12:55 | |
*** resker has quit IRC | 12:55 | |
*** esker has joined #openstack-cinder | 12:55 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Check for encrypted volume type existence before deleting https://review.openstack.org/194677 | 12:56 |
haypo | smcginnis: if the py34 starts failing, don't hesitate to harass me until it's fixed :) | 12:56 |
smcginnis | haypo: Definitely will do! :) | 12:56 |
*** Ctina has joined #openstack-cinder | 12:56 | |
*** husanu5 has joined #openstack-cinder | 12:56 | |
haypo | haha | 12:57 |
openstackgerrit | Michal Dulko proposed openstack/cinder: Check for encrypted volume type existence before deleting https://review.openstack.org/194677 | 12:57 |
openstackgerrit | Rakesh H S proposed openstack/cinder: check for existence of volume type encryption before deleting https://review.openstack.org/194677 | 12:58 |
*** bswartz has joined #openstack-cinder | 12:59 | |
*** smoriya has quit IRC | 12:59 | |
*** coolsvap|away is now known as coolsvap | 13:00 | |
*** atuvenie_ has joined #openstack-cinder | 13:00 | |
*** husanu5 has quit IRC | 13:00 | |
*** julim has joined #openstack-cinder | 13:01 | |
*** amoturi has joined #openstack-cinder | 13:03 | |
*** atuvenie has quit IRC | 13:04 | |
*** nlevinki has quit IRC | 13:04 | |
*** e0ne is now known as e0ne_ | 13:04 | |
*** e0ne_ is now known as e0ne | 13:04 | |
*** belmoreira has quit IRC | 13:05 | |
*** afazekas has joined #openstack-cinder | 13:08 | |
*** jecarey has joined #openstack-cinder | 13:10 | |
*** nlevinki has joined #openstack-cinder | 13:12 | |
openstackgerrit | Forest Romain proposed openstack/cinder: Correct overquota error message https://review.openstack.org/193018 | 13:13 |
*** husanux2 has joined #openstack-cinder | 13:13 | |
*** husanux2 has quit IRC | 13:13 | |
*** Yogi1 has joined #openstack-cinder | 13:13 | |
*** merooney has joined #openstack-cinder | 13:13 | |
*** husanux3 has joined #openstack-cinder | 13:14 | |
*** husanux3 has quit IRC | 13:18 | |
*** husanux9 has joined #openstack-cinder | 13:20 | |
*** e0ne is now known as e0ne_ | 13:20 | |
*** husanux9 has quit IRC | 13:21 | |
*** coolsvap is now known as coolsvap|away | 13:21 | |
*** e0ne_ is now known as e0ne | 13:22 | |
*** jdurgin has joined #openstack-cinder | 13:24 | |
*** rushil has joined #openstack-cinder | 13:25 | |
*** husanux1 has joined #openstack-cinder | 13:25 | |
*** salv-orl_ has joined #openstack-cinder | 13:27 | |
openstackgerrit | Michal Dulko proposed openstack/python-cinderclient: Use shared shell arguments provided by Session https://review.openstack.org/165833 | 13:27 |
openstackgerrit | Forest Romain proposed openstack/cinder: Correct overquota error message https://review.openstack.org/193018 | 13:28 |
*** husanux1 has quit IRC | 13:29 | |
*** salv-orlando has quit IRC | 13:31 | |
*** bluex-pl has joined #openstack-cinder | 13:31 | |
*** mriedem has joined #openstack-cinder | 13:31 | |
*** nkrinner has quit IRC | 13:32 | |
*** rushil has quit IRC | 13:32 | |
*** eharney has quit IRC | 13:35 | |
*** marcusvrn1 has joined #openstack-cinder | 13:38 | |
openstackgerrit | Pranali Deore proposed openstack/cinder: Change generic NotFound to specific exception https://review.openstack.org/186688 | 13:38 |
*** rushil has joined #openstack-cinder | 13:38 | |
*** gouthamr has joined #openstack-cinder | 13:38 | |
*** marcusvrn has quit IRC | 13:39 | |
*** dustins has joined #openstack-cinder | 13:40 | |
*** jungleboyj has quit IRC | 13:40 | |
*** changbl_ has joined #openstack-cinder | 13:40 | |
*** julim has quit IRC | 13:44 | |
*** thangp has joined #openstack-cinder | 13:48 | |
*** rushil has quit IRC | 13:48 | |
*** sjcherry has joined #openstack-cinder | 13:51 | |
*** tellesnobrega_ has quit IRC | 13:51 | |
*** ericksonsantos has quit IRC | 13:51 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Filter snapshots data on the DB side https://review.openstack.org/184267 | 13:54 |
*** merooney has quit IRC | 13:54 | |
openstackgerrit | Anton Arefiev proposed openstack/cinder-specs: Service healthcheck https://review.openstack.org/176233 | 13:55 |
*** nllrte has joined #openstack-cinder | 13:56 | |
nllrte | Anyone know if Rackspace private cloud supports the EMC cinder driver? | 13:56 |
smcginnis | nllrte: She's not online right now, but xyang might know that answer. | 13:57 |
*** earlephilhower has quit IRC | 13:57 | |
*** xyang1 has joined #openstack-cinder | 13:58 | |
nllrte | thanks smcginnis | 13:58 |
*** rakesh_hs has quit IRC | 14:01 | |
*** tellesnobrega has joined #openstack-cinder | 14:01 | |
*** eharney has joined #openstack-cinder | 14:01 | |
*** bkopilov has joined #openstack-cinder | 14:02 | |
nllrte | hi xyang1, are you aware whether or not Rackspace private cloud supports the EMC cinder driver? | 14:04 |
*** julim has joined #openstack-cinder | 14:04 | |
*** rmesta has joined #openstack-cinder | 14:05 | |
*** merooney has joined #openstack-cinder | 14:06 | |
xyang1 | nllrte: There was certification on that long time ago, but I am not sure if it was done recently. I can find out about it | 14:06 |
nllrte | ok thanks xyang1 | 14:07 |
*** r-daneel has joined #openstack-cinder | 14:09 | |
openstackgerrit | Edwin Wang proposed openstack/cinder: Split FC driver code into Common and FC https://review.openstack.org/195382 | 14:11 |
*** rushil has joined #openstack-cinder | 14:11 | |
*** tellesnobrega has quit IRC | 14:11 | |
*** e0ne is now known as e0ne_ | 14:13 | |
*** tellesnobrega has joined #openstack-cinder | 14:14 | |
*** rmesta has left #openstack-cinder | 14:15 | |
*** ronis has joined #openstack-cinder | 14:16 | |
*** akerr has quit IRC | 14:16 | |
*** rushil has quit IRC | 14:21 | |
*** jungleboyj has joined #openstack-cinder | 14:21 | |
albertom | hi aarefiev:can you review my patch again? I added the changes in your comment and test suite is passing with 0 failures | 14:23 |
albertom | https://review.openstack.org/194920 | 14:23 |
openstackgerrit | Szymon Wróblewski proposed openstack/cinder: POC: Tooz locks demo https://review.openstack.org/185646 | 14:23 |
*** e0ne_ has quit IRC | 14:23 | |
aarefiev | albertom: sure, I'll look on it later | 14:23 |
albertom | thanks | 14:24 |
*** tellesnobrega has quit IRC | 14:24 | |
*** nlevinki has quit IRC | 14:24 | |
smcginnis | thingee, hemnafk, jungleboyj, jgriffith, xyang1, patrickeast: Any interest in doing another "Conversation" again at the next summit? | 14:25 |
xyang1 | smcginnis: Sounds good to me | 14:26 |
*** Zhongjun has joined #openstack-cinder | 14:26 | |
smcginnis | xyang1: Cool. I'll see who else is interested and submit a proposal. | 14:26 |
smcginnis | Deadline is coming up kinda soon. | 14:26 |
jungleboyj | smcginnis: Works for me. | 14:26 |
jungleboyj | smcginnis: I have one other one that I need to get proposed. | 14:27 |
smcginnis | jungleboyj: Awesome. At least three of us then. :) | 14:27 |
*** akerr has joined #openstack-cinder | 14:29 | |
*** esker has quit IRC | 14:29 | |
*** esker has joined #openstack-cinder | 14:30 | |
*** marcusvrn has joined #openstack-cinder | 14:31 | |
*** eharney has quit IRC | 14:33 | |
xyang1 | nllrte: Hi, We didn't do any certification work with Rackspace recently, not sure about future plan yet | 14:33 |
*** vilobhmm has joined #openstack-cinder | 14:33 | |
*** dtynan has quit IRC | 14:33 | |
*** marcusvrn1 has quit IRC | 14:34 | |
nllrte | ok, thanks xyang1 | 14:34 |
*** dtynan has joined #openstack-cinder | 14:34 | |
*** esker has quit IRC | 14:35 | |
*** e0ne has joined #openstack-cinder | 14:36 | |
*** juzuluag has joined #openstack-cinder | 14:39 | |
*** eharney has joined #openstack-cinder | 14:40 | |
*** Tross has quit IRC | 14:40 | |
*** rushil has joined #openstack-cinder | 14:47 | |
*** MIDENN_ has quit IRC | 14:52 | |
*** mdenny has joined #openstack-cinder | 14:53 | |
*** kaisers_ has joined #openstack-cinder | 14:57 | |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: HP XP driver should call register_opts() https://review.openstack.org/195619 | 14:58 |
*** fifieldt has joined #openstack-cinder | 15:00 | |
*** rakesh_mishra has joined #openstack-cinder | 15:00 | |
dulek | geguileo: You may be interested - few minutes ago with bluex-pl we were able to cause problems when creating a lot of snapshots in parallel in GlusterFS driver | 15:00 |
*** david-ly_ is now known as david-lyle | 15:01 | |
geguileo | dulek: Awesome!! | 15:01 |
geguileo | dulek: (in a way) ;-) | 15:01 |
dulek | geguileo: (when running two c-vol in A/A) | 15:01 |
*** fifieldt has quit IRC | 15:01 | |
dulek | geguileo: We also confirmed that Tooz patch solves the problems. :) | 15:01 |
*** fifieldt has joined #openstack-cinder | 15:01 | |
geguileo | dulek: Then you confirmed that it needed the lock | 15:01 |
geguileo | dulek: Thanks for the update | 15:02 |
dulek | geguileo: Yes, thing is - we have clear test that can confirm that we're solving the issue. | 15:02 |
geguileo | dulek: Is the test upstream so I can have a look? | 15:02 |
*** kaisers_0 has joined #openstack-cinder | 15:03 | |
dulek | geguileo: Not yet, bluex-pl is working on some kind of "steps to reproduce" list, we'll post it in cinder-active-active-vol-service-issues once ready | 15:04 |
*** kaisers_ has quit IRC | 15:04 | |
geguileo | dulek: Great | 15:04 |
*** mtanino has joined #openstack-cinder | 15:05 | |
*** reed has quit IRC | 15:05 | |
*** lpabon has joined #openstack-cinder | 15:05 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Filter snapshots data on the DB side https://review.openstack.org/184267 | 15:06 |
openstackgerrit | Edwin Wang proposed openstack/cinder: Separate FlashSystem FC and iSCSI common code https://review.openstack.org/195382 | 15:07 |
mtanino | jungleboyj: hi, | 15:08 |
mtanino | jungleboyj: My folks posted a patch for this bug. https://bugs.launchpad.net/cinder/+bug/1466198 | 15:09 |
openstack | Launchpad bug 1466198 in Cinder "tox -e genconfig fails" [Critical,In progress] - Assigned to Kazumasa Nomura (kazumasa-nomura-rx) | 15:09 |
*** med_` is now known as med_ | 15:09 | |
*** med_ is now known as med___ | 15:09 | |
mtanino | jungleboyj: If you have a chance, please visit here. https://review.openstack.org/#/c/195619/ | 15:09 |
mtanino | Thanks. | 15:09 |
dulek | geguileo: One more thing - https://review.openstack.org/#/c/186742/ | 15:10 |
dulek | geguileo: Turns out change I was working on in Nova is already in review. | 15:10 |
*** reed has joined #openstack-cinder | 15:10 | |
*** jasondotstar has quit IRC | 15:10 | |
geguileo | dulek: I'll have a look at that one to understand what is blocking it | 15:11 |
aarefiev | tbarron: hi, I've mentioned about modified field in alternatives section, could you look? | 15:13 |
openstackgerrit | Anton Arefiev proposed openstack/cinder-specs: Service healthcheck https://review.openstack.org/176233 | 15:14 |
jungleboyj | mtanino: Ok, will try to take a look shortly. | 15:14 |
*** rakesh_mishra has quit IRC | 15:14 | |
tbarron | aarefiev: looking, thanks for your patience | 15:15 |
*** mtanino_ has joined #openstack-cinder | 15:15 | |
aarefiev | tbarron: np, thanks | 15:15 |
*** mtanino has quit IRC | 15:16 | |
*** ronis has quit IRC | 15:16 | |
*** Tross has joined #openstack-cinder | 15:16 | |
*** edmondsw has quit IRC | 15:16 | |
*** MentalRay has joined #openstack-cinder | 15:17 | |
tbarron | aarefiev: thank you. My -1 is now gone. Might end up doing +1 but I want to follow the discussion of the | 15:18 |
*** anshul has quit IRC | 15:18 | |
*** dannywilson has joined #openstack-cinder | 15:18 | |
tbarron | overloaded field and the design choice a bit. If there is any discussion, maybe everyone else is | 15:18 |
tbarron | fine with it. | 15:18 |
tbarron | The health check is a great idea and I very much appreciate your proposing it. | 15:19 |
*** merooney has quit IRC | 15:20 | |
aarefiev | tbarron: thanks, I don't think using 'modified_at' will be a problem, it uses only on start/stop services, and I'm testing it now | 15:20 |
*** dannywil_ has joined #openstack-cinder | 15:20 | |
*** dannywilson has quit IRC | 15:20 | |
openstackgerrit | Shay Halsband proposed openstack/cinder: XtremIO driver fix array snapshot problem https://review.openstack.org/193954 | 15:21 |
*** edmondsw has joined #openstack-cinder | 15:25 | |
*** rakesh_mishra has joined #openstack-cinder | 15:26 | |
*** rakesh_mishra has quit IRC | 15:26 | |
*** rakesh_mishra has joined #openstack-cinder | 15:26 | |
*** laughterwym_ has quit IRC | 15:27 | |
*** DericHorn-HP has joined #openstack-cinder | 15:27 | |
*** agarciam has joined #openstack-cinder | 15:27 | |
*** mtanino has joined #openstack-cinder | 15:28 | |
*** Apoorva has joined #openstack-cinder | 15:29 | |
*** garthb_ has joined #openstack-cinder | 15:30 | |
*** garthb has joined #openstack-cinder | 15:30 | |
*** mtanino_ has quit IRC | 15:31 | |
*** dtynan has quit IRC | 15:32 | |
*** daneyon has joined #openstack-cinder | 15:33 | |
*** dtynan has joined #openstack-cinder | 15:33 | |
*** merooney has joined #openstack-cinder | 15:34 | |
*** daneyon_ has joined #openstack-cinder | 15:34 | |
*** e0ne is now known as e0ne_ | 15:35 | |
*** med___ is now known as med_ | 15:36 | |
*** med_ has quit IRC | 15:36 | |
*** med_ has joined #openstack-cinder | 15:36 | |
*** jdurgin has quit IRC | 15:37 | |
*** e0ne_ is now known as e0ne | 15:37 | |
*** daneyon has quit IRC | 15:37 | |
*** kjnelson has quit IRC | 15:37 | |
*** hemnafk is now known as hemna | 15:38 | |
*** jungleboyj has quit IRC | 15:38 | |
*** rakesh_mishra has quit IRC | 15:39 | |
*** mtanino has quit IRC | 15:40 | |
*** annegentle has joined #openstack-cinder | 15:40 | |
*** merooney has quit IRC | 15:42 | |
*** mkoderer_cloud has quit IRC | 15:44 | |
*** jasondotstar has joined #openstack-cinder | 15:45 | |
*** marcusvrn1 has joined #openstack-cinder | 15:47 | |
*** marcusvrn has quit IRC | 15:47 | |
*** rakesh_mishra has joined #openstack-cinder | 15:47 | |
*** jungleboyj has joined #openstack-cinder | 15:47 | |
*** vilobhmm has quit IRC | 15:51 | |
*** timcl has quit IRC | 15:51 | |
*** annegentle has quit IRC | 15:52 | |
*** timcl has joined #openstack-cinder | 15:52 | |
*** shyama has quit IRC | 15:52 | |
*** annegentle has joined #openstack-cinder | 15:52 | |
*** rakesh_mishra has quit IRC | 15:53 | |
*** agarciam has quit IRC | 15:54 | |
*** e0ne is now known as e0ne_ | 15:56 | |
*** kaisers_0 has quit IRC | 15:57 | |
*** Longgeek has quit IRC | 15:59 | |
*** atuvenie_ has quit IRC | 16:00 | |
*** Longgeek has joined #openstack-cinder | 16:00 | |
openstackgerrit | Amador Pahim proposed openstack/cinder: Do not accept qos name with only invisible characters https://review.openstack.org/195651 | 16:00 |
*** leeantho has joined #openstack-cinder | 16:01 | |
*** lcurtis has joined #openstack-cinder | 16:05 | |
*** rakesh_mishra has joined #openstack-cinder | 16:05 | |
*** harlowja_still_a has quit IRC | 16:06 | |
*** e0ne_ has quit IRC | 16:06 | |
*** rushil has quit IRC | 16:11 | |
*** e0ne has joined #openstack-cinder | 16:11 | |
*** jordanP has quit IRC | 16:16 | |
*** annegentle has quit IRC | 16:17 | |
*** annashen has joined #openstack-cinder | 16:20 | |
*** DericHorn-HP has quit IRC | 16:20 | |
*** afazekas has quit IRC | 16:23 | |
*** Tross has quit IRC | 16:23 | |
openstackgerrit | Anton Arefiev proposed openstack/cinder: WIP: Implement service healthcheck tool https://review.openstack.org/195665 | 16:23 |
*** esker has joined #openstack-cinder | 16:25 | |
*** esker has quit IRC | 16:25 | |
*** esker has joined #openstack-cinder | 16:25 | |
*** bluex-pl has quit IRC | 16:28 | |
*** VManiac16 has joined #openstack-cinder | 16:29 | |
*** bswartz has quit IRC | 16:29 | |
*** erlon has joined #openstack-cinder | 16:29 | |
*** markus_z has quit IRC | 16:29 | |
*** atuvenie has joined #openstack-cinder | 16:30 | |
*** Yogi1 has quit IRC | 16:34 | |
*** shyama has joined #openstack-cinder | 16:39 | |
*** ndipanov has quit IRC | 16:42 | |
*** ronis has joined #openstack-cinder | 16:44 | |
*** jwcroppe_ has quit IRC | 16:51 | |
*** jwcroppe has joined #openstack-cinder | 16:51 | |
*** rakesh_mishra has quit IRC | 16:52 | |
*** nllrte has quit IRC | 16:52 | |
*** rwsu has joined #openstack-cinder | 16:52 | |
*** Yogi1 has joined #openstack-cinder | 16:53 | |
*** jasondotstar has quit IRC | 16:55 | |
*** jwcroppe has quit IRC | 16:56 | |
*** _cjones_ has joined #openstack-cinder | 16:58 | |
Swanson | jungleboyj: Re 193334. Thingee said on here somewhere that it didn't need a blueprint. | 17:01 |
jungleboyj | Swanson: Thanks for confirming. I trusted you guys. :-) | 17:02 |
*** garthb_ has quit IRC | 17:03 | |
*** garthb has quit IRC | 17:03 | |
*** rushil has joined #openstack-cinder | 17:04 | |
*** DericHorn-HP has joined #openstack-cinder | 17:05 | |
*** esker has quit IRC | 17:05 | |
*** hemna_ has joined #openstack-cinder | 17:06 | |
*** garthb has joined #openstack-cinder | 17:07 | |
*** garthb_ has joined #openstack-cinder | 17:07 | |
*** jasondotstar has joined #openstack-cinder | 17:08 | |
*** patrickeast has joined #openstack-cinder | 17:08 | |
*** e0ne has quit IRC | 17:08 | |
*** hemna_ has quit IRC | 17:09 | |
*** _cjones_ has quit IRC | 17:17 | |
*** _cjones_ has joined #openstack-cinder | 17:17 | |
*** rushil_ has joined #openstack-cinder | 17:19 | |
*** sseverson has quit IRC | 17:21 | |
*** merooney has joined #openstack-cinder | 17:21 | |
*** rushil has quit IRC | 17:22 | |
*** shausy has quit IRC | 17:22 | |
*** Ctina_ has joined #openstack-cinder | 17:31 | |
*** jasondotstar has quit IRC | 17:34 | |
*** marcusvrn1 has quit IRC | 17:34 | |
*** Ctina has quit IRC | 17:35 | |
smcginnis | Is that the db exception one? | 17:36 |
*** Ctina_ has quit IRC | 17:36 | |
smcginnis | Oops, wrong window. :) | 17:36 |
*** jasondotstar has joined #openstack-cinder | 17:39 | |
*** jwcroppe has joined #openstack-cinder | 17:41 | |
jungleboyj | smcginnis: Who on earth are you talking to? ;-) | 17:44 |
smcginnis | :) | 17:46 |
eharney | i think he was asking "the cloud" | 17:48 |
*** Tross has joined #openstack-cinder | 17:48 | |
smcginnis | Hah! | 17:48 |
jungleboyj | :-) | 17:48 |
*** nllrte has joined #openstack-cinder | 17:48 | |
smcginnis | eharney: Follow up from yesterday. py34 tests were stable all day so I have my +1 to the patch to make it voting. | 17:49 |
smcginnis | Got approved so it's going through gate right now. | 17:49 |
eharney | nice | 17:49 |
eharney | i wonder if we're all about to learn new things about py3 | 17:49 |
jungleboyj | That is good. | 17:49 |
smcginnis | eharney: No doubt. | 17:49 |
*** afazekas has joined #openstack-cinder | 17:49 | |
openstackgerrit | Amador Pahim proposed openstack/cinder: Do not accept qos name with only invisible characters https://review.openstack.org/195651 | 17:50 |
patrickeast | asselin: hey, have you run into any issues with building dib images the last day or so? | 17:53 |
*** marcusvrn has joined #openstack-cinder | 17:53 | |
*** boris-42 has joined #openstack-cinder | 17:54 | |
*** breitz has quit IRC | 17:54 | |
*** afazekas has quit IRC | 17:55 | |
*** markstur has quit IRC | 17:55 | |
*** tellesnobrega has joined #openstack-cinder | 17:56 | |
asselin | patrickeast, will look | 17:57 |
*** breitz has joined #openstack-cinder | 17:57 | |
patrickeast | asselin: i’m getting this error http://paste.openstack.org/show/321098/ | 17:58 |
patrickeast | asselin: from… https://github.com/openstack-infra/project-config/blob/master/nodepool/elements/cache-devstack/install.d/99-cache-testrepository-db#L26 | 17:58 |
patrickeast | unsure if its just my system or if something is actually borked | 17:58 |
asselin | patrickeast, my last one was 4 days ago | 18:00 |
*** husanu0 has joined #openstack-cinder | 18:02 | |
*** dontalton has joined #openstack-cinder | 18:02 | |
*** bswartz has joined #openstack-cinder | 18:02 | |
*** markstur has joined #openstack-cinder | 18:05 | |
*** jasondotstar has quit IRC | 18:05 | |
*** jwcroppe_ has joined #openstack-cinder | 18:08 | |
*** gouthamr has quit IRC | 18:08 | |
*** esker has joined #openstack-cinder | 18:08 | |
*** gouthamr has joined #openstack-cinder | 18:08 | |
asselin | patrickeast, building one now.... | 18:08 |
*** jwcroppe_ has quit IRC | 18:09 | |
*** jwcroppe_ has joined #openstack-cinder | 18:09 | |
*** jwcroppe has quit IRC | 18:11 | |
*** MentalRay has quit IRC | 18:11 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Don't allow >4-byte Unicode characters in volume names https://review.openstack.org/195695 | 18:13 |
*** husanu0 has quit IRC | 18:14 | |
asselin | patrickeast, but that file I override it to be empty | 18:16 |
*** merooney has quit IRC | 18:16 | |
patrickeast | asselin: oh? why do you do that? | 18:17 |
asselin | patrickeast, I must've add problems with it way back and didn't really need it | 18:17 |
asselin | patrickeast, do you know what it does? | 18:18 |
patrickeast | asselin: not really :D | 18:19 |
patrickeast | asselin: prepares the tempest testrepository cache thing? | 18:19 |
*** jasondotstar has joined #openstack-cinder | 18:19 | |
openstackgerrit | Amador Pahim proposed openstack/cinder: Do not accept qos name with only invisible characters https://review.openstack.org/195651 | 18:20 |
patrickeast | https://github.com/openstack-infra/project-config/blob/master/nodepool/scripts/prepare_tempest_testrepository.py looks like it is creating subunit results from the logstash db? | 18:21 |
patrickeast | not sure why we would need that | 18:21 |
asselin | patrickeast, this is my error: http://paste.openstack.org/show/321101/ | 18:21 |
patrickeast | asselin: hmm | 18:23 |
*** kjnelson has joined #openstack-cinder | 18:24 | |
*** alyfon has joined #openstack-cinder | 18:26 | |
*** alyfon has quit IRC | 18:26 | |
*** alyfon has joined #openstack-cinder | 18:26 | |
asselin | patrickeast, I seem to have a old build still running from a few days ago http://paste.openstack.org/show/321108/ | 18:27 |
alyfon | hey there I was looking at the reference LVM driver and wondering why they didnt explicitly write an attach/detach volume method even though it | 18:27 |
alyfon | it's part of the min requirements | 18:27 |
alyfon | is it because the base volumedriver class has it implemented | 18:28 |
alyfon | ? | 18:28 |
*** julim has quit IRC | 18:28 | |
*** annashen has quit IRC | 18:28 | |
*** shyama has quit IRC | 18:28 | |
*** annegentle has joined #openstack-cinder | 18:28 | |
*** julim has joined #openstack-cinder | 18:28 | |
asselin | patrickeast, killed and restarted | 18:29 |
dannywil_ | alyfon: yes | 18:30 |
*** DericHorn-HP has quit IRC | 18:31 | |
alyfon | ok and i know this may sound really stupid but I was wondering what the difference between the call back attach/detach volume methods and the _attach/_detach functions are | 18:31 |
*** krtaylor has quit IRC | 18:31 | |
alyfon | b/c the callback functions are empty with pass | 18:31 |
alyfon | in driver.py | 18:31 |
*** timcl has quit IRC | 18:32 | |
*** lpetrut1 has quit IRC | 18:36 | |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: HP XP driver should call register_opts() https://review.openstack.org/195619 | 18:37 |
dannywil_ | alyfon: are you talking about these functions? https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L804 | 18:37 |
dannywil_ | alyfon: I am not too familiar with what those are for | 18:37 |
alyfon | yeah exactly | 18:38 |
alyfon | ok | 18:38 |
*** ericksonsantos has joined #openstack-cinder | 18:38 | |
dannywil_ | alyfon: have to step out for a bit, sorry I couldn't be more help | 18:38 |
alyfon | thanks for the help so far | 18:38 |
*** Zhongjun has quit IRC | 18:38 | |
*** Yogi1 has quit IRC | 18:39 | |
*** Yogi1 has joined #openstack-cinder | 18:40 | |
*** merooney has joined #openstack-cinder | 18:43 | |
*** ericksonsantos has quit IRC | 18:43 | |
*** dontalton has quit IRC | 18:44 | |
*** annegentle has quit IRC | 18:45 | |
*** jasondotstar has quit IRC | 18:47 | |
*** ociuhandu has quit IRC | 18:48 | |
*** timcl has joined #openstack-cinder | 18:48 | |
*** julim has quit IRC | 18:52 | |
*** r-daneel has quit IRC | 18:54 | |
*** r-daneel has joined #openstack-cinder | 18:55 | |
*** jwcroppe_ has quit IRC | 18:55 | |
*** jwcroppe has joined #openstack-cinder | 18:56 | |
*** ericksonsantos has joined #openstack-cinder | 18:56 | |
*** jwcroppe has quit IRC | 18:57 | |
*** jwcroppe has joined #openstack-cinder | 18:57 | |
*** julim has joined #openstack-cinder | 18:59 | |
*** MentalRay has joined #openstack-cinder | 19:02 | |
*** julim has quit IRC | 19:02 | |
*** julim has joined #openstack-cinder | 19:03 | |
*** ericksonsantos has quit IRC | 19:03 | |
*** jasondotstar has joined #openstack-cinder | 19:07 | |
*** Svedrin has quit IRC | 19:09 | |
*** tellesnobrega has quit IRC | 19:10 | |
*** kjnelson has quit IRC | 19:10 | |
*** Svedrin has joined #openstack-cinder | 19:11 | |
*** merooney has quit IRC | 19:12 | |
*** merooney has joined #openstack-cinder | 19:12 | |
openstackgerrit | Andrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage https://review.openstack.org/193596 | 19:12 |
*** merooney has quit IRC | 19:13 | |
*** Tross has quit IRC | 19:15 | |
*** garthb_ has quit IRC | 19:15 | |
*** garthb has quit IRC | 19:15 | |
openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 19:20 |
openstackgerrit | Thang Pham proposed openstack/cinder: WIP: RPC and object versioning https://review.openstack.org/184404 | 19:20 |
openstackgerrit | Andrey Pavlov proposed openstack/cinder: Small fix in doc string definition https://review.openstack.org/193124 | 19:23 |
*** jdurgin has joined #openstack-cinder | 19:24 | |
*** merooney has joined #openstack-cinder | 19:27 | |
*** annashen has joined #openstack-cinder | 19:29 | |
*** tellesnobrega has joined #openstack-cinder | 19:29 | |
*** merooney has quit IRC | 19:32 | |
*** rushiagr_away is now known as rushiagr | 19:32 | |
openstackgerrit | Jay Bryant proposed openstack/cinder: Fix cinder.conf.sample generation https://review.openstack.org/195715 | 19:33 |
*** annashen has quit IRC | 19:34 | |
openstackgerrit | Jay Bryant proposed openstack/cinder: Fix cinder.conf.sample generation https://review.openstack.org/195715 | 19:35 |
*** tellesnobrega has quit IRC | 19:35 | |
*** annashen has joined #openstack-cinder | 19:35 | |
*** merooney has joined #openstack-cinder | 19:36 | |
*** jdurgin has quit IRC | 19:37 | |
*** merooney has quit IRC | 19:39 | |
*** kjnelson has joined #openstack-cinder | 19:40 | |
*** daneyon_ has quit IRC | 19:42 | |
*** julim has quit IRC | 19:44 | |
*** merooney has joined #openstack-cinder | 19:48 | |
*** DericHorn-HP has joined #openstack-cinder | 19:50 | |
*** lpetrut has joined #openstack-cinder | 19:52 | |
openstackgerrit | Amador Pahim proposed openstack/cinder: Do not accept qos name with only invisible characters https://review.openstack.org/195651 | 19:52 |
*** esker has quit IRC | 19:54 | |
eharney | jungleboyj: it seems like we should have a job/test somewhere that ensures that the sample conf actually can be generated | 19:54 |
eharney | (though not requiring updates like we used to) | 19:54 |
*** kjnelson has quit IRC | 19:55 | |
*** nllrte has quit IRC | 19:58 | |
*** timcl has quit IRC | 19:58 | |
*** juzuluag has quit IRC | 20:01 | |
*** merooney has quit IRC | 20:01 | |
*** mtanino has joined #openstack-cinder | 20:01 | |
mtanino | jungleboyj: ping | 20:03 |
jungleboyj | mtanino: Was about to step out for a bit. What's up? | 20:05 |
*** atuvenie has quit IRC | 20:05 | |
mtanino | jungleboyj: about the bug https://bugs.launchpad.net/cinder/+bug/1466198 | 20:06 |
openstack | Launchpad bug 1466198 in Cinder "tox -e genconfig fails" [Critical,In progress] - Assigned to Jay Bryant (jsbryant) | 20:06 |
jungleboyj | mtanino: Yes. | 20:06 |
mtanino | jungleboyj: my folks posted a patch https://review.openstack.org/#/c/195619/ | 20:06 |
mtanino | do you plan to post someting to fix it? | 20:06 |
mtanino | I saw you took the bug again. so just asking :) | 20:07 |
jungleboyj | *sigh* I took the bug as I was working on it. | 20:08 |
jungleboyj | I had talked to the driver owner and to Walt about this about the solution. | 20:08 |
openstackgerrit | Eric Harney proposed openstack/cinder: Don't allow >4-byte Unicode chars in volume names https://review.openstack.org/195695 | 20:09 |
*** jecarey has quit IRC | 20:09 | |
*** krtaylor has joined #openstack-cinder | 20:09 | |
mtanino | hmm, the patch was posted by driver owner. | 20:10 |
jungleboyj | Yeah, and this is changing more than it needs to. | 20:10 |
jungleboyj | Oh, that is the driver owner? nestor ? | 20:10 |
mtanino | yes Kazumasa Nomura is driver owner | 20:11 |
mtanino | Hitachi guy. | 20:11 |
jungleboyj | Ok. Really wish he had talked to me since I was the bug owner. | 20:12 |
mtanino | Ah, because he locates in Japan, he is not here now :( | 20:12 |
jungleboyj | Wasted a notable amount of time. | 20:12 |
*** Longgeek has quit IRC | 20:13 | |
*** amoturi has quit IRC | 20:14 | |
mtanino | Sorry for about that :( | 20:14 |
jungleboyj | Ok. | 20:14 |
jungleboyj | I need to drop off now. | 20:15 |
mtanino | sure. | 20:15 |
mtanino | jungleboyj: Thank you for taking time. | 20:15 |
jungleboyj | Oh, that was what you asked me to review earlier today mtanino | 20:16 |
jungleboyj | Which Ironically, I didn't look at because I was busy working on that and other fixes. | 20:16 |
jungleboyj | Oh well. | 20:16 |
mtanino | jungleboyj: Yes, yes. | 20:17 |
*** gfarmerfr has joined #openstack-cinder | 20:17 | |
mtanino | jungleboyj: I'm joining Red Hat summit and sometimes lost wifi connection... sorry. | 20:17 |
*** thangp has quit IRC | 20:24 | |
*** jungleboyj has quit IRC | 20:25 | |
gfarmerfr | Hi everyone, has anyone already tested the Storwise SVC driver in conjuction with zonemanager for FC autozoning ? | 20:30 |
*** ronis has quit IRC | 20:31 | |
*** marcusvrn has quit IRC | 20:34 | |
*** rushil_ has quit IRC | 20:35 | |
*** MentalRay has quit IRC | 20:36 | |
*** jasondotstar has quit IRC | 20:39 | |
*** jaypipes has quit IRC | 20:39 | |
*** MentalRay has joined #openstack-cinder | 20:40 | |
*** rushil has joined #openstack-cinder | 20:40 | |
*** afazekas has joined #openstack-cinder | 20:41 | |
openstackgerrit | Alex Meade proposed openstack/cinder: Add tracing facility for drivers https://review.openstack.org/157439 | 20:47 |
*** julim has joined #openstack-cinder | 20:47 | |
ameade | patrickeast: https://review.openstack.org/#/c/157439/ | 20:48 |
patrickeast | ameade: oo metaclass magic | 20:50 |
patrickeast | ameade: thats pretty cool, only need the one annotation on the class now | 20:51 |
ameade | and you can still do the other way if you dont want every method wrapped | 20:52 |
patrickeast | ameade: does it end up being the last wrapper around methods? or the first one? | 20:54 |
ameade | the outer | 20:54 |
patrickeast | awesome | 20:55 |
alyfon | hey i asked this before but im having trouble fully understanding why most of the driver files im looking at (pure, emc_vmax, and even in the lvm reference driver) they don't explicily call an attach/detach volume method | 20:55 |
ameade | patrickeast: yessir, almost too tricky though | 20:55 |
alyfon | and for example emc_vmax_fc doesnt derive its class from the volumedriver class that includes _attach_volume/_detach_volume only from the fibrechannel driver class | 20:56 |
patrickeast | alyfon: speaking for the pure driver, we haven’t needed to, all we need is the stuff done in initialize_connection/terminate_connection | 20:56 |
alyfon | ohh ok that makes sense | 20:57 |
alyfon | im guessing the emc driver also works in a similar way | 20:57 |
patrickeast | yea probably | 20:57 |
alyfon | thanks a lot | 20:58 |
*** garthb has joined #openstack-cinder | 20:59 | |
*** garthb_ has joined #openstack-cinder | 20:59 | |
patrickeast | np | 21:00 |
*** garthb_ has quit IRC | 21:00 | |
*** garthb_ has joined #openstack-cinder | 21:01 | |
openstackgerrit | xing-yang proposed openstack/os-brick: Add connector driver for the ScaleIO cinder driver https://review.openstack.org/185835 | 21:01 |
*** garthb_ has quit IRC | 21:01 | |
*** garthb has quit IRC | 21:01 | |
openstackgerrit | xing-yang proposed openstack/cinder: EMC VMAX Create CG from CG Snapshot https://review.openstack.org/195280 | 21:01 |
*** garthb has joined #openstack-cinder | 21:01 | |
*** garthb_ has joined #openstack-cinder | 21:02 | |
*** dannywilson has joined #openstack-cinder | 21:02 | |
hemna | finding more failures in nova live migration process. bleh. | 21:02 |
*** patrickeast_ has joined #openstack-cinder | 21:03 | |
*** annegentle has joined #openstack-cinder | 21:03 | |
openstackgerrit | Alex Meade proposed openstack/cinder: Add tracing facility for drivers https://review.openstack.org/157439 | 21:04 |
openstackgerrit | Alex Meade proposed openstack/cinder: Add tracing facility for drivers https://review.openstack.org/157439 | 21:05 |
*** patrickeast has quit IRC | 21:05 | |
*** patrickeast_ is now known as patrickeast | 21:05 | |
*** dannywil_ has quit IRC | 21:05 | |
*** e0ne has joined #openstack-cinder | 21:05 | |
*** akerr has quit IRC | 21:07 | |
*** DericHorn-HP has quit IRC | 21:08 | |
*** DericHorn-HP has joined #openstack-cinder | 21:11 | |
*** chlong has quit IRC | 21:11 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Don't allow >3-byte Unicode chars in volume names https://review.openstack.org/195695 | 21:12 |
hemna | xyang1, so I'm not sure how your drivers react to having initialize_connection called multiple times for the same volume. | 21:13 |
hemna | but our drivers react differently. Lefthand turns into a no op, but 3PAR creates an export for even initialize_connection call. | 21:13 |
*** KurtMartin has joined #openstack-cinder | 21:13 | |
*** amoturi has joined #openstack-cinder | 21:13 | |
xyang1 | hemna: I think it will just return success if it is already attached | 21:13 |
hemna | xyang1, not all drivers do that though. | 21:14 |
*** IanGovett has quit IRC | 21:14 | |
hemna | xyang1, and I'm curious how multi-attach works then in that case for you guys :) | 21:14 |
hemna | but nova's assumptions of calling initialize_connection multiple times is bad | 21:14 |
hemna | xyang1, here https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L281-L294 | 21:15 |
xyang1 | hemna: We will nave to check host and volume | 21:15 |
hemna | bad mmmkay | 21:15 |
xyang1 | hemna: We have not tested multi attach yet | 21:15 |
hemna | xyang1, that refresh_connection_info was also the source of the lost devices | 21:15 |
hemna | for the bdm | 21:15 |
*** rushil has quit IRC | 21:15 | |
hemna | because it pounds over whatever the libvirt volume connect_volume driver returned for the connection_info, with what cinder's initialize_connection returns. | 21:16 |
hemna | also bad | 21:16 |
hemna | :( | 21:16 |
xyang1 | hemna: :( | 21:16 |
hemna | it's so badly broken, I want to puke. | 21:16 |
*** Yogi1 has quit IRC | 21:17 | |
xyang1 | hemna: How is switching over to os-brick going? | 21:17 |
hemna | so, it's going well actually | 21:17 |
hemna | we are testing live migration with the nova os-brick patch | 21:17 |
hemna | just to make sure that it doesn't cause anything that doesn't already exist. | 21:18 |
hemna | internally I have a CI setup against the nova os-brick patch that tests against our hardware | 21:18 |
hemna | 3par iscsi, FC and Lefthand iSCSI | 21:18 |
xyang1 | hemna: Oh, I don't see instruction on os brick CI on the wiki | 21:18 |
hemna | asselin, can help you with that | 21:19 |
hemna | xyang1, I had been rebasing your nova patch when I pushed a new os-brick patch up. | 21:19 |
xyang1 | hemna: We are setting it up too. We had to shut down the normal CI to test os brick | 21:19 |
xyang1 | hemna: Thanks for the help | 21:19 |
*** IanGovett has joined #openstack-cinder | 21:20 | |
*** rushil has joined #openstack-cinder | 21:20 | |
*** Longgeek has joined #openstack-cinder | 21:21 | |
hemna | crap | 21:23 |
*** chlong has joined #openstack-cinder | 21:23 | |
*** sjcherry has quit IRC | 21:28 | |
hemna | xyang1, https://github.com/openstack/cinder/commit/3e4f554f614c8cb6d5f014c72f3c635184a4dec2 | 21:28 |
*** eharney has quit IRC | 21:28 | |
hemna | so it looks like rescan_iscsi was added there | 21:28 |
hemna | that causes dangling iSCSI volumes during live migration | 21:29 |
xyang1 | hemna: Line 270? | 21:30 |
hemna | yes | 21:30 |
hemna | because nova's compute manager's post_live_migration() | 21:30 |
xyang1 | hemna: There is a reason that was added though | 21:30 |
xyang1 | hemna: There is comment there | 21:30 |
xyang1 | hemna: I think it is moved, the rescan was at different location before | 21:31 |
hemna | so if there are more than 1 volumes on a vm during live migration, for iSCSI, you will most likely end up with dangling volumes on the source host when it's done | 21:31 |
hemna | when iscsiadm --rescan is called, the volumes that were previously removed show back up. | 21:31 |
hemna | because the compute manager doesn't call cinder's terminate_connection with every libvirt volume disconnect_volume call. | 21:32 |
hemna | so if there is 1 volume, it's ok. | 21:32 |
hemna | but if there are 2 or more | 21:32 |
xyang1 | hemna: Did you see the comments, the call was there at a different location | 21:32 |
hemna | you will end up with volumes left behind on the source. | 21:32 |
hemna | yah, I see the comment | 21:33 |
hemna | not sure I understand the reason for the rescan though | 21:33 |
hemna | I think this is the same issue basically. | 21:33 |
hemna | so for iSCSI | 21:34 |
hemna | if we issue a delete volume from the host | 21:34 |
hemna | w/o an immediate call to cinder to terminate_connection | 21:34 |
hemna | that volume can show back up | 21:34 |
hemna | anyone that issues an iscsiadm --rescan | 21:34 |
hemna | poop! | 21:34 |
hemna | which can happen in parallel for volume attaches | 21:34 |
hemna | :( | 21:34 |
xyang1 | This is after terminate connection, no? | 21:35 |
hemna | not for live migration | 21:35 |
*** sseverson has joined #openstack-cinder | 21:36 | |
xyang1 | I see | 21:36 |
*** rushil has quit IRC | 21:36 | |
hemna | look at https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4934-L4948 | 21:36 |
hemna | and https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6050-L6055 | 21:37 |
*** mtanino has quit IRC | 21:38 | |
hemna | libvirt/driver.py's post_live_migration walks every volume in the BDM and calls disconnect_volume | 21:38 |
hemna | each disconnect_volume call issues an iscsiadm --rescan | 21:38 |
hemna | :( | 21:38 |
hemna | terminate_connection needs to be called for every disconnect_volume call | 21:39 |
hemna | or iSCSI volumes will be orphaned on the source | 21:39 |
*** e0ne is now known as e0ne_ | 21:39 | |
*** Longgeek has quit IRC | 21:40 | |
*** e0ne_ is now known as e0ne | 21:41 | |
*** ian_brown has joined #openstack-cinder | 21:41 | |
xyang1 | If you call terminate connection so early in live migration, the volume will be attached to no one in the middle of migration | 21:42 |
*** mriedem has quit IRC | 21:44 | |
hemna | this is post_live_migration | 21:45 |
hemna | so this is after the destination has been stood up and volumes attached to it. | 21:45 |
hemna | this is all about tearing down the source side and cleaning up | 21:45 |
*** krtaylor has quit IRC | 21:47 | |
*** ian_brown has quit IRC | 21:48 | |
*** lpetrut has quit IRC | 21:50 | |
*** julim has quit IRC | 21:51 | |
hemna | xyang1, the driver.post_live_migration() walks through the list of volumes and calls disconnect_volume(), that returns and then immediately the compute manager calls terminate_connection on each volume. | 21:55 |
xyang1 | Are you suggesting to move rescan after terminate connection? | 21:56 |
hemna | I'm questioning why we need rescan at all | 21:57 |
*** annegentle has quit IRC | 21:58 | |
jgriffith | cleanup | 21:59 |
xyang1 | I think if you don't rescan, the detached device won't go away | 21:59 |
hemna | I'm not sure about that | 21:59 |
jgriffith | xyang1: +1 | 21:59 |
jgriffith | It's better to be explicit than implicit | 21:59 |
hemna | the device goes away in brick with the call to remove it from the kernel | 22:00 |
jgriffith | because implicit isn't guaranteed to work | 22:00 |
jgriffith | hemna: "your" devices, or everybody elses? | 22:00 |
*** chlong has quit IRC | 22:00 | |
jgriffith | hemna: and the bigger problem is it doesn't "always" work | 22:00 |
hemna | https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L449 | 22:01 |
hemna | that removes the device entirely from the host. | 22:01 |
jgriffith | sure | 22:01 |
hemna | a rescan makes it come back | 22:01 |
*** dannywilson has quit IRC | 22:01 | |
hemna | which is what is happening in live migration | 22:01 |
jgriffith | I guess I'm confused, what you're talking about | 22:01 |
jgriffith | nova, brick, both, neither, something else | 22:02 |
hemna | well yah it's confusing | 22:02 |
hemna | but it's both really. | 22:02 |
hemna | nova's compute manager post_live_migration gets called | 22:02 |
*** dannywilson has joined #openstack-cinder | 22:02 | |
*** dannywilson has quit IRC | 22:02 | |
jgriffith | Yeah, I know you have a LOT of issues with how the nova side deals with volumes, some of it I get, some of it I don't understand the problem at all | 22:02 |
*** dannywilson has joined #openstack-cinder | 22:03 | |
hemna | it calls the libvirt volume driver's post_live_migration(), which loops through each volume and calls the libvirt volume driver's disconnect_volume() | 22:03 |
hemna | then the compute manager calls terminate_connection for each volume. | 22:03 |
jgriffith | live-migration inparticular, I just tested again last week, seems to work fine | 22:03 |
*** rushiagr is now known as rushiagr_away | 22:03 | |
hemna | for VMs that have more than 1 volume attached | 22:03 |
hemna | that leaves iSCSI volumes behind on the source. | 22:03 |
Swanson | I can't help but think having 4 returns in a 16 statement function (4 of which are logs) will get me a sea of -1s when I push this. | 22:04 |
xyang1 | jgriffith: Are you testing single path or multipath? | 22:04 |
hemna | because terminate_connection isn't called until after all libvirt volume disconnect_volume calls are done. | 22:04 |
*** Rockyg has joined #openstack-cinder | 22:04 | |
jgriffith | xyang1: oh... just multipath | 22:04 |
hemna | each libvirt volume disconnect_volume issues an iscsi rescan at the very start | 22:04 |
xyang1 | jgriffith: I think that explained it | 22:04 |
jgriffith | hemna: have you logged a bug, submitted a patch? | 22:04 |
xyang1 | jgriffith: We tested multipath as well and it worked | 22:04 |
jgriffith | hemna: I'd be happy to review either or both | 22:04 |
hemna | so the 2nd disconnect_volume is called, it issues a rescan, and the volume it just removed shows back up. | 22:04 |
jgriffith | xyang1: ooops... typo | 22:05 |
hemna | I haven't filed a bug yet | 22:05 |
hemna | I'm trying to figure out how to fix it :P | 22:05 |
jgriffith | xyang1: I have NOT done anything with multi-path as of yet | 22:05 |
*** jwcroppe_ has joined #openstack-cinder | 22:05 | |
xyang1 | jgriffith: oh | 22:05 |
jgriffith | hemna: well, a bug might be really useful to write up the problem and help others understand what you're talking about | 22:05 |
xyang1 | jgriffith: hemna runs into problem with single path | 22:06 |
hemna | we are just spending cycles looking heavily at live migration and it's issues, and doing lots of testing. this is the latest issue we found. | 22:06 |
hemna | jgriffith, yah ok. | 22:06 |
jgriffith | hemna: you need to log bugs... becuase you say "it's issues" but meanwhile there are a number of folks using it without issue | 22:07 |
jgriffith | hemna: which concerns me | 22:07 |
*** jwcroppe has quit IRC | 22:07 | |
hemna | jgriffith, well, that's part of the problem I've been discovering actually | 22:07 |
hemna | part of the problem is the interaction between nova and cinder | 22:07 |
hemna | and also how some cinder driver's have implemented initialize_conneciton. | 22:07 |
jgriffith | hemna: I'm aware, you keep saying that :) | 22:07 |
jgriffith | hemna: I'm just pointing out that it would be good to get things written down so others can follow along and help out | 22:08 |
hemna | https://etherpad.openstack.org/p/CinderNovaAPI | 22:08 |
hemna | I documented some of it at the bottom of that | 22:08 |
jgriffith | particularly since there's a number of devices that seem to work fine and it would suck if you broke them :) | 22:08 |
hemna | well I didn't break them | 22:08 |
hemna | it's a combination of things | 22:08 |
jgriffith | hemna: slow down | 22:08 |
jgriffith | hemna: read what I said please :) | 22:08 |
hemna | heh I did, I gave you a url :) | 22:09 |
jgriffith | I'll repeat: There are a number of drivers that WORK properly today | 22:09 |
hemna | anyway, I documented some of it in that etherpad of what we've been seeing. | 22:09 |
hemna | yes I know | 22:09 |
jgriffith | I'm concerned that changes made for 3Par could "break" those drivers | 22:09 |
hemna | and I understand why that is | 22:09 |
hemna | I understand why some backends work and others don't. | 22:09 |
hemna | I documented it in that etherpad | 22:10 |
hemna | "Live migration broken for some cinder backends, and works for others:" section | 22:10 |
*** gouthamr has quit IRC | 22:10 | |
hemna | that's issue 1) there | 22:10 |
jgriffith | hemna: I know... but I'm pointing out that be sure "you're" not the one making incorrect assumptions | 22:11 |
hemna | I believe I have fixed issue 2) for FC based drivers already in my patch here: https://review.openstack.org/#/c/195350 | 22:11 |
hemna | I'm just documenting what I'm seeing, and looking at a few cinder drivers, it's broken for more than just the 3PAR. | 22:12 |
hemna | lefthand 'works' | 22:13 |
hemna | heh | 22:13 |
*** KurtMartin has quit IRC | 22:14 | |
*** KurtMartin has joined #openstack-cinder | 22:14 | |
*** merooney has joined #openstack-cinder | 22:19 | |
openstackgerrit | xing-yang proposed openstack/cinder: EMC VMAX Create CG from CG Snapshot https://review.openstack.org/195280 | 22:22 |
angela-s | good news for those interested, Brocade CI is finally posting to the VF and Friendly Zone Names code reviews | 22:24 |
xyang1 | angela-s: Nice! | 22:25 |
angela-s | bad news is there are still about 16 failed tests | 22:25 |
*** e0ne has quit IRC | 22:26 | |
openstackgerrit | xing-yang proposed openstack/cinder: EMC VMAX Create CG from CG Snapshot https://review.openstack.org/195280 | 22:26 |
angela-s | also, PG&E is shutting power off to our campus for the next week for upgrades, so Brocade CI will be offline starting tomorrow until July 8. | 22:26 |
angela-s | got it working just in time to shut if off. :) | 22:27 |
*** annashen has quit IRC | 22:27 | |
*** edmondsw has quit IRC | 22:27 | |
angela-s | thanks xyang1 | 22:28 |
xyang1 | angela-s: Np, glad it started reporting | 22:28 |
asselin | angela-s, cool! | 22:29 |
*** KurtMartin has quit IRC | 22:30 | |
*** krtaylor has joined #openstack-cinder | 22:30 | |
*** dims has quit IRC | 22:30 | |
*** garthb has quit IRC | 22:31 | |
*** garthb_ has quit IRC | 22:31 | |
*** dontalton has joined #openstack-cinder | 22:32 | |
*** garthb has joined #openstack-cinder | 22:33 | |
*** garthb_ has joined #openstack-cinder | 22:33 | |
*** IlyaG has joined #openstack-cinder | 22:35 | |
*** Longgeek has joined #openstack-cinder | 22:37 | |
*** dims_ has joined #openstack-cinder | 22:38 | |
*** gfarmerfr has quit IRC | 22:40 | |
*** lcurtis has quit IRC | 22:41 | |
*** Longgeek has quit IRC | 22:42 | |
openstackgerrit | Ryan Lucio proposed openstack/cinder: VMEM v7000: external-head storage pool and volume type selection https://review.openstack.org/195773 | 22:45 |
*** dustins_ has joined #openstack-cinder | 22:45 | |
*** DericHorn-HP has quit IRC | 22:45 | |
*** rwall has quit IRC | 22:45 | |
*** dontalton has quit IRC | 22:45 | |
*** dhellmann has quit IRC | 22:46 | |
*** dhellmann has joined #openstack-cinder | 22:46 | |
*** dustins has quit IRC | 22:47 | |
*** rwall has joined #openstack-cinder | 22:48 | |
*** merooney has quit IRC | 22:55 | |
*** annegentle has joined #openstack-cinder | 22:59 | |
*** mriedem has joined #openstack-cinder | 23:02 | |
patrickeast | jgriffith: hey, if you are around/have a few min, i have a couple questions for stuff i’m running into with the generic image cache that you probably know | 23:03 |
*** annegentle has quit IRC | 23:05 | |
*** mriedem has quit IRC | 23:06 | |
*** mriedem has joined #openstack-cinder | 23:06 | |
jgriffith | patrickeast: sure, what's up | 23:13 |
*** dustins_ has quit IRC | 23:14 | |
*** zhenguo has joined #openstack-cinder | 23:18 | |
*** markvoelker has quit IRC | 23:24 | |
*** garthb has quit IRC | 23:24 | |
*** garthb_ has quit IRC | 23:24 | |
*** garthb has joined #openstack-cinder | 23:25 | |
*** garthb_ has joined #openstack-cinder | 23:25 | |
*** aorourke has quit IRC | 23:27 | |
*** aorourke has joined #openstack-cinder | 23:27 | |
*** MentalRay has quit IRC | 23:35 | |
patrickeast | jgriffith: sry got side tracked, still around? | 23:36 |
*** garthb has quit IRC | 23:37 | |
*** garthb_ has quit IRC | 23:37 | |
jgriffith | patrickeast: sure | 23:38 |
patrickeast | jgriffith: cool, so first thing is for the size of the cached volumes, in your driver you are using the virtual_size, and maybe i’m missing something, but wouldn’t the min_size property be better? | 23:39 |
patrickeast | jgriffith: or is the virtual_size actually the smaller one? | 23:39 |
patrickeast | jgriffith: s/min_size/min_disk/ | 23:39 |
jgriffith | patrickeast: min_size doesn't work :( | 23:40 |
patrickeast | jgriffith: oh | 23:40 |
jgriffith | patrickeast: trying to remember why LOL | 23:40 |
patrickeast | jgriffith: haha, well i see that sometimes it may not be set | 23:40 |
patrickeast | like uhh | 23:40 |
* patrickeast pulls up github links | 23:40 | |
jgriffith | patrickeast: so IIRC min_disk has a different meaning though | 23:41 |
patrickeast | jgriffith: so maybe better question would be, whats virtual_size then? | 23:41 |
patrickeast | jgriffith: thats like the actual image size uncompressed? | 23:42 |
jgriffith | patrickeast: so the main reason I went with that is I didn't want to mess around with anything Glance had stored in the image | 23:42 |
jgriffith | patrickeast: in our case things like "0" don't do us any good | 23:42 |
jgriffith | patrickeast: but if you change that it screws up the ephemeral case | 23:42 |
jgriffith | patrickeast: virtual size is safe because it's metadata and for the most part not used | 23:42 |
patrickeast | jgriffith: gotcha | 23:42 |
jgriffith | patrickeast: also, virtual_size is the expanded/virtual size reported back from the Instance | 23:42 |
patrickeast | jgriffith: so then my next question, does that mean a user would have to go set it manually on each image? | 23:43 |
jgriffith | patrickeast: so in our case, we're kinda making it "non" virtual | 23:43 |
patrickeast | or is that automatic | 23:43 |
patrickeast | ahh ok, thats where the virtual size comes from | 23:43 |
jgriffith | Yes, and Admin has to do it | 23:43 |
patrickeast | ok cool | 23:43 |
jgriffith | I have/had a comment in the code about that | 23:43 |
jgriffith | patrickeast: It would be cool if we automated that at some point | 23:43 |
jgriffith | patrickeast: but for now, I have it listed as a requirement | 23:43 |
patrickeast | jgriffith: seems pretty reasonable to me | 23:44 |
jgriffith | patrickeast: if it's not set I just skip it and move on | 23:44 |
patrickeast | so i’ll stick with virtual_size then | 23:44 |
jgriffith | patrickeast: yeah, there's probably a better way to do all of that part, but that was a quick and dirty method that didn't introduce problems and was explicit | 23:44 |
patrickeast | jgriffith: ok, so last question, maybe more of a check to see if i’m going way off in the woods | 23:45 |
jgriffith | patrickeast: It was kinda surprising to me that by default we didn't seem to store any "real" size info in the image | 23:45 |
jgriffith | LOL | 23:45 |
patrickeast | i currently am calling back into the volume api to create the volume | 23:45 |
patrickeast | but i am going to need to skip the scheduler | 23:45 |
patrickeast | and go straight to the host | 23:45 |
patrickeast | i dunno how much cinder devs adhere to layering violations and what not | 23:45 |
patrickeast | but i’m going through like 8 million of them | 23:46 |
patrickeast | anyway | 23:46 |
jgriffith | patrickeast: so personally I am not a big fan of that... but it might be necessary/ok | 23:46 |
*** esker has joined #openstack-cinder | 23:46 | |
jgriffith | patrickeast: in my case I prefer calling the driver itself in the manager | 23:46 |
jgriffith | patrickeast: given you are already there and have the handle it seemed like an "ok" way to do it | 23:46 |
patrickeast | i need to pass some kind of parameter that is like a don’t schedule and don’t try to create this volume from the cache, it really needs to download option | 23:46 |
*** esker has quit IRC | 23:46 | |
patrickeast | actually | 23:46 |
patrickeast | one sec i’ll put up a WIP review, maybe this will make more sense | 23:46 |
jgriffith | patrickeast: so you can do that.. but keeping it in the manager might be better IMHO | 23:47 |
jgriffith | patrickeast: ok | 23:47 |
patrickeast | yea thats what im asking, it feels kind of wrong | 23:47 |
*** esker has joined #openstack-cinder | 23:47 | |
jgriffith | patrickeast: so we have the mechanism to do what you want on the rpc side (ie snapshot, delete etc) | 23:47 |
jgriffith | patrickeast: cramming that into tflow might be interesting | 23:47 |
jgriffith | patrickeast: might be a piece of cake, I'm not sure TBH | 23:47 |
patrickeast | jgriffith: yea the problem is that the quota and db stuff is on the other side of the rpc | 23:47 |
openstackgerrit | Patrick East proposed openstack/cinder: WIP generic image cache https://review.openstack.org/195795 | 23:48 |
jgriffith | patrickeast: ahh...hmm, interesting point | 23:48 |
patrickeast | ignore some of the ghetto pieces | 23:48 |
patrickeast | its mostly a POC | 23:48 |
*** chlong has joined #openstack-cinder | 23:48 | |
patrickeast | it works right now | 23:48 |
patrickeast | but it doesn’t have a way to say ‘don’t use the cache’ | 23:48 |
patrickeast | so it will recursively fill up the cache with the same image until it errors, then continue on : / | 23:49 |
jgriffith | patrickeast: LOL | 23:51 |
jgriffith | patrickeast: why can't you just add a call to DB like I have in the driver? | 23:51 |
jgriffith | patrickeast: or do you mean you just haven't fixed that up yet | 23:51 |
patrickeast | jgriffith: just haven’t fixed it yet | 23:51 |
*** erlon has quit IRC | 23:51 | |
jgriffith | patrickeast: ahh... got ya | 23:51 |
patrickeast | i also need to figure out the keystone internal tenant stuff.. but one problem at a time | 23:51 |
jgriffith | patrickeast: :) | 23:51 |
jgriffith | patrickeast: so I'll have to load it up to really understand it all, but looking through it, sure seems reasonable to me | 23:53 |
*** alyfon has quit IRC | 23:53 | |
jgriffith | patrickeast: I'm unsure of putting the calls in tflow vs manager still | 23:53 |
*** laughterwym has joined #openstack-cinder | 23:53 | |
jgriffith | patrickeast: but that's just kind of an impl detail more than anything else probably | 23:54 |
jgriffith | patrickeast: can't think of a real reason why it matters right now | 23:54 |
patrickeast | jgriffith: yea i’m going to keep thinking on that, i don’t like that it needs to make so many extra rpc and glance calls now | 23:54 |
patrickeast | drop in the bucket compared with downloading an image from a cache hit | 23:54 |
patrickeast | but still doesn’t sit well | 23:54 |
jgriffith | patrickeast: yeah, that's the only ugly thing | 23:54 |
jgriffith | patrickeast: so one advantage of the manager is you can just do driver direct calls and such. But then you're on that other side of the boundary like you said, which also causes problems with things like context in some cases | 23:55 |
patrickeast | jgriffith: yea exactly, i was trying to find a nice balance of re-using code vs having to call in so high up in the stack | 23:56 |
*** smoriya has joined #openstack-cinder | 23:56 | |
jgriffith | patrickeast: I'd love to see if we could have more reuse | 23:56 |
patrickeast | jgriffith: the taskflow stuff makes it hard, i almost want to just do a few of the taska and sort of cheat to put a new volume entry in w/ quota and stuff | 23:56 |
patrickeast | its silly to do all of the checks over again | 23:57 |
patrickeast | but they are built in to the flows | 23:57 |
jgriffith | patrickeast: yeah, that's one of the things I've never been a huge fan of | 23:57 |
*** esker has quit IRC | 23:57 | |
jgriffith | patrickeast: it's a bit ironic, it's so dynamic about some things, yet completely monolithic about others | 23:57 |
*** Rockyg has quit IRC | 23:57 | |
jgriffith | patrickeast: split personality :) | 23:58 |
patrickeast | jgriffith: haha yea, i suspect thats a symptom of us being kind of half-in with it | 23:58 |
patrickeast | anyway, i guess i’ll keep going with this direction and get it a bit more polished and tested | 23:59 |
patrickeast | jgriffith: let me know if you have any more ideas on how to stick with just the manager, or if you have time to look through the code a bit more and see anything i need to change | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!