Friday, 2015-06-26

jgriffithpatrickeast: yeah, I'll see if I can't load it up and play around with it00:00
*** annegentle has joined #openstack-cinder00:00
patrickeastjgriffith: it should work, ive been playing around with it on a local devstack… you just need to create a new project and user and set all of the config options00:01
patrickeastjgriffith: keep the projects volume quota low tho since it will fill them all up right now, lol00:01
*** dannywilson has quit IRC00:01
*** jwcroppe_ has quit IRC00:03
*** annegentle has quit IRC00:05
jgriffithpatrickeast: :)00:07
*** hemna is now known as hemnafk00:11
*** Rockyg has joined #openstack-cinder00:12
*** IlyaG has quit IRC00:15
openstackgerritxing-yang proposed openstack/cinder: EMC VMAX Create CG from CG Snapshot  https://review.openstack.org/19528000:16
*** patrickeast has quit IRC00:18
*** markvoelker has joined #openstack-cinder00:24
*** markvoelker has quit IRC00:30
*** heyun has joined #openstack-cinder00:32
*** Longgeek has joined #openstack-cinder00:38
*** leeantho has quit IRC00:41
*** IanGovett has quit IRC00:42
*** Longgeek has quit IRC00:44
*** daneyon has joined #openstack-cinder00:50
*** Rockyg has quit IRC00:52
*** VManiac16 has quit IRC00:52
*** annegentle has joined #openstack-cinder01:01
*** daneyon_ has joined #openstack-cinder01:02
*** jwcroppe has joined #openstack-cinder01:02
*** daneyon has quit IRC01:05
*** tobe has joined #openstack-cinder01:05
*** jwcroppe_ has joined #openstack-cinder01:05
*** jwcroppe has quit IRC01:06
*** annegentle has quit IRC01:06
*** david-ly_ has joined #openstack-cinder01:06
*** david-lyle has quit IRC01:09
openstackgerritEdwin Wang proposed openstack/cinder: Separate FlashSystem FC and iSCSI common code  https://review.openstack.org/19538201:12
*** julim has joined #openstack-cinder01:13
openstackgerritEdwin Wang proposed openstack/cinder: Separate FlashSystem FC and iSCSI common code  https://review.openstack.org/19538201:14
*** IlyaG has joined #openstack-cinder01:15
*** lixiaoy1 has joined #openstack-cinder01:15
*** IlyaG has quit IRC01:19
*** lixiaoy11 has joined #openstack-cinder01:21
*** lixiaoy1 has quit IRC01:23
*** anshul has joined #openstack-cinder01:31
*** lixiaoy1 has joined #openstack-cinder01:31
*** lixiaoy11 has quit IRC01:33
*** jasondotstar has joined #openstack-cinder01:33
*** et10man has joined #openstack-cinder01:39
*** boris-42 has quit IRC01:42
*** Yogi1 has joined #openstack-cinder01:44
*** amoturi has quit IRC01:45
*** _cjones_ has quit IRC01:58
*** jasondotstar has quit IRC01:59
*** dosaboy has quit IRC02:04
*** wolsen has quit IRC02:05
*** wolsen has joined #openstack-cinder02:05
*** dosaboy has joined #openstack-cinder02:06
*** Apoorva has quit IRC02:06
openstackgerritEdwin Wang proposed openstack/cinder: Separate FlashSystem FC and iSCSI common code  https://review.openstack.org/19538202:08
*** daneyon_ has quit IRC02:09
*** jasondotstar has joined #openstack-cinder02:10
openstackgerritxing-yang proposed openstack/os-brick: Add connector driver for the ScaleIO cinder driver  https://review.openstack.org/18583502:13
*** markvoelker has joined #openstack-cinder02:14
*** dims has joined #openstack-cinder02:14
*** dims_ has quit IRC02:15
openstackgerritwanghao proposed openstack/cinder: Support volume backup of qcow2 format volume  https://review.openstack.org/18227602:16
*** Yogi1 has quit IRC02:17
*** daneyon has joined #openstack-cinder02:17
*** markvoelker has quit IRC02:18
*** daneyon has quit IRC02:18
*** dims has quit IRC02:20
*** lan has quit IRC02:22
*** dims has joined #openstack-cinder02:22
*** annegentle has joined #openstack-cinder02:24
*** lan has joined #openstack-cinder02:25
*** IlyaG has joined #openstack-cinder02:25
*** annashen has joined #openstack-cinder02:32
*** jwcroppe_ has quit IRC02:33
*** alexpilotti has quit IRC02:36
*** r-daneel has quit IRC02:39
*** annegentle has quit IRC02:39
openstackgerritTeruaki Ishizaki proposed openstack/cinder: sheepdog: Add class for dog command executor  https://review.openstack.org/19453202:40
*** Longgeek has joined #openstack-cinder02:40
*** jasondotstar has quit IRC02:42
*** Yogi1 has joined #openstack-cinder02:46
*** lpabon has quit IRC02:47
*** Longgeek has quit IRC02:52
*** Yogi1 has quit IRC02:53
*** esker has joined #openstack-cinder02:54
*** esker has quit IRC02:54
*** esker has joined #openstack-cinder02:55
*** dims has quit IRC03:01
*** mriedem has quit IRC03:02
*** vincent_hou has joined #openstack-cinder03:05
vincent_houxyang1: Ping.03:06
xyang1vincent_hou: Hi03:06
*** IlyaG has quit IRC03:06
vincent_houxyang1: I have answered your question in patch https://review.openstack.org/#/c/180873/03:06
vincent_houIt is a long story and hope you can understand. :-)03:07
xyang1vincent_hou: Ok, I'll take a look03:07
*** xyang1 has quit IRC03:09
openstackgerritEdwin Wang proposed openstack/cinder: Separate FlashSystem FC and iSCSI common code  https://review.openstack.org/19538203:10
*** xyang1 has joined #openstack-cinder03:14
openstackgerritwanghao proposed openstack/cinder-specs: Incremental backup improvements for L  https://review.openstack.org/18792603:15
*** boris-42 has joined #openstack-cinder03:22
xyang1vincent_hou: I'll check with Sean tomorrow to make sure.  There are a couple of others that implemented this too.03:22
xyang1vincent_hou: What is the downside of keeping this call for attached? That will preserve the existing behavior for attached in this patch03:24
*** harlowja_at_home has joined #openstack-cinder03:31
SwansonUpdate_migrated_volume has changed?03:31
Swansonxyang1: is update_migrated_volume no longer being called in the patch above?03:36
xyang1Swanson: It is no longer called for attached volume03:37
xyang1Swanson: It is still called for available volume03:37
xyang1Swanson: Will that be a problem for your driver03:37
Swansonxyang1: If the volume is migrated to a new backend it will be copied to a new volume with a new guid.  If the new guid is used going forward we have no issues.  If not we will lose track of the volume.03:38
openstackgerritwanghao proposed openstack/cinder: Incremental backup improvements for L  https://review.openstack.org/18832803:39
Swansonxyang1: We use the id as our volume name.  That is the only link to the volume.  If that isn't the same as what the db thinks it is the volume is as good as gone to us.03:40
*** annegentle has joined #openstack-cinder03:40
xyang1vincent_hou: Still here?03:40
Swansonxyang1: I can talk to Sean tomorrow morning as I think he has paid more attention to this patch than I have.  (I stopped looking at it after implementing the update_migrated_volume method fixed our problem.)03:41
xyang1Swanson: Sure03:42
xyang1Swanson: I added a question for sean in the patch as well03:42
*** vincent_hou_ has joined #openstack-cinder03:43
*** Longgeek has joined #openstack-cinder03:44
*** vincent_hou has quit IRC03:44
*** vincent_hou_ is now known as vincent_hou03:44
*** annegentle has quit IRC03:45
*** laughterwym has quit IRC03:45
*** laughterwym_ has joined #openstack-cinder03:45
*** Longgeek has quit IRC03:46
*** Longgeek has joined #openstack-cinder03:47
*** jwcroppe has joined #openstack-cinder03:47
*** david-ly_ is now known as david-lyle03:51
*** julim has quit IRC03:52
*** lpetrut has joined #openstack-cinder03:52
*** annashen has quit IRC03:57
*** markvoelker has joined #openstack-cinder04:02
*** vilobhmm has joined #openstack-cinder04:04
*** markvoelker has quit IRC04:07
*** shyama has joined #openstack-cinder04:07
*** annashen has joined #openstack-cinder04:11
*** rushiagr_away is now known as rushiagr04:13
*** annashen has quit IRC04:14
*** xyang1 has quit IRC04:15
vincent_housmcginnis: Hi Sean. Xing has a question for you in the comment for https://review.openstack.org/#/c/180873/61/cinder/volume/manager.py.04:15
*** annashen has joined #openstack-cinder04:19
*** lpetrut has quit IRC04:34
*** vilobhmm has quit IRC04:36
*** harlowja_at_home has quit IRC04:36
*** tobe has quit IRC04:40
*** annegentle has joined #openstack-cinder04:41
vincent_houSwanson: Still there?04:43
*** annegentle has quit IRC04:46
*** mdbooth has quit IRC04:54
*** tobe has joined #openstack-cinder05:19
openstackgerritTeruaki Ishizaki proposed openstack/cinder: sheepdog: Add class for dog command executor  https://review.openstack.org/19453205:28
*** annashen has quit IRC05:29
openstackgerritLisaLi proposed openstack/cinder: Add dependency check in RBD delete_snapshot  https://review.openstack.org/19300305:32
openstackgerritTaoBai proposed openstack/cinder: Storwize driver report capability for multiattach  https://review.openstack.org/19547105:42
*** annegentle has joined #openstack-cinder05:42
*** rushiagr is now known as rushiagr_away05:43
*** mtanino has joined #openstack-cinder05:43
mtaninovincent_hou: hi,05:44
vincent_houmtanino: Hi05:45
mtaninovincent_hou: Did you see my comment on my patch? https://review.openstack.org/#/c/194223/105:45
vincent_houAh.05:45
vincent_houYes.05:46
vincent_houmtanino: I think currently we can fix it this way.05:46
mtaninovincent_hou: hmm05:47
mtaninosometing happen in the future, you mean?05:47
*** annegentle has quit IRC05:47
vincent_houI was think why in terminate_connect , the export is not removed.05:47
mtaninobecause terminate_connection does not call remove export05:48
vincent_houwhy doesn't05:48
mtaninojust terminate connection is a feature of terminate_connection05:48
vincent_houWhat if we add it? Because during init_connect, we create the export. Why cannot we remove it in terminate-connect?05:49
mtaninoIf the terminte_connection has remove_export feature, nova instance(with volume) live migration will be failed.05:49
vincent_houi am not sure if there is any reason for it.05:50
mtaninoNova's live migration code calls terminate_connection for the purpose of only terminating connection.(without removing export)05:51
vincent_houWow05:51
*** markvoelker has joined #openstack-cinder05:51
vincent_houThat is sth I did not realize.05:51
*** kaisers has quit IRC05:51
*** laughterwym_ has quit IRC05:51
openstackgerritVincent Hou proposed openstack/cinder-specs: Volume migration improvement for Liberty version  https://review.openstack.org/18632705:52
mtaninoIf you will add remove_export in the terminate_connection and then migrate nova instance with volume,05:52
*** boris-42 has quit IRC05:52
mtaninoI think you will fail it.05:52
vincent_houOK05:52
vincent_houThanks for your explanation.05:53
*** kaisers has joined #openstack-cinder05:53
mtaninotherefore, I called attach volume and detach volume. This is same logic of Nova's live migration05:53
mtaninosure.05:53
vincent_houOK I support it.05:54
vincent_houI will check the patch once more.05:54
*** links has joined #openstack-cinder05:55
vincent_houBTW, did you receive the latest mail from me?05:55
*** markvoelker has quit IRC05:56
vincent_houabout my idea for the back-end name consistency for attached volumes?05:56
mtaninoAh, I recieved it but couldn't read enough.05:58
mtaninovincent_hou: will be reply tomorrow or next week. it's OK?05:59
vincent_houtake your time05:59
vincent_houNP05:59
mtanino:)05:59
mtaninook, go to sleep, zzz05:59
mtaninobye05:59
*** mtanino is now known as mtanino_zzz06:00
*** vincent_hou_ has joined #openstack-cinder06:01
*** tobe has quit IRC06:05
*** vincent_hou has quit IRC06:05
*** vincent_hou_ is now known as vincent_hou06:05
*** mtanino_zzz has quit IRC06:14
*** rushiagr_away is now known as rushiagr06:15
vincent_houbye06:16
*** boris-42 has joined #openstack-cinder06:26
*** annashen has joined #openstack-cinder06:30
*** lpetrut has joined #openstack-cinder06:36
*** tobe has joined #openstack-cinder06:40
*** belmoreira has joined #openstack-cinder06:43
*** annegentle has joined #openstack-cinder06:43
*** coolsvap|away is now known as coolsvap06:44
*** annegentle has quit IRC06:48
*** coolsvap is now known as coolsvap|away06:56
*** lpetrut has quit IRC07:00
*** ronis has joined #openstack-cinder07:03
*** yamada-h has joined #openstack-cinder07:05
openstackgerritLisaLi proposed openstack/cinder: Add dependency check in RBD delete_snapshot  https://review.openstack.org/19300307:06
*** lpetrut has joined #openstack-cinder07:10
*** vincent_hou_ has joined #openstack-cinder07:11
openstackgerritAndrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage  https://review.openstack.org/19359607:12
*** vincent_hou has quit IRC07:13
*** vincent_hou_ is now known as vincent_hou07:14
*** lpetrut has quit IRC07:14
*** yamada-h has quit IRC07:16
*** annashen has quit IRC07:23
*** bkopilov has quit IRC07:23
*** rushiagr is now known as rushiagr_away07:36
*** shyama has quit IRC07:44
*** markus_z has joined #openstack-cinder07:55
*** chlong has quit IRC07:55
*** bluex-pl has joined #openstack-cinder07:58
aarefievvincent_hou: hi, could you revisit it https://review.openstack.org/#/c/178588 , and comment please ?08:05
vincent_houaarefiev: V1 won't exist in Cinder. Do you think it is meaningful to have them in client?08:13
aarefievvincent_hou: what about existing deployments with v108:13
*** jwcroppe has quit IRC08:14
aarefievvincent_hou: I think we should support it too08:14
*** mdbooth has joined #openstack-cinder08:15
vincent_houI need other folks' comments. If there are more cores fine with it. I am OK.08:16
*** jwcroppe has joined #openstack-cinder08:18
*** jwcroppe has quit IRC08:19
*** jwcroppe has joined #openstack-cinder08:19
*** jwcroppe has quit IRC08:21
*** jwcroppe has joined #openstack-cinder08:22
*** jwcroppe has quit IRC08:22
*** jwcroppe has joined #openstack-cinder08:24
*** jwcroppe has quit IRC08:24
*** Lee1092 has quit IRC08:25
vincent_houaarefiev: https://review.openstack.org/#/c/92768/ you can check this patch. There are similar comments.08:27
*** jwcroppe has joined #openstack-cinder08:28
aarefievvincent_hou: ok, but I'm not agree with you, we a have lot of envs with v1, and I'd like to see bugs fixed for them too08:28
vincent_houaarefiev: I am gonna ask other folks as well. Hope we will a solution to it.08:30
*** jwcroppe has quit IRC08:30
aarefievvincent_hou: also when we delete v1 in api, we should support v1 in client, because we can't upgrade all envs to v2 in time08:30
*** jwcroppe has joined #openstack-cinder08:30
aarefievvincent_hou: ok, thanks, please comment patches after decision08:35
vincent_houSure.08:36
openstackgerritVincent Hou proposed openstack/cinder: Volume status management during migration  https://review.openstack.org/18631208:41
*** shyama has joined #openstack-cinder08:49
openstackgerritVincent Hou proposed openstack/cinder: Add the notification and the migration progress indication  https://review.openstack.org/18961408:50
*** jwcroppe has quit IRC08:56
*** jwcroppe has joined #openstack-cinder08:58
openstackgerritVincent Hou proposed openstack/cinder: Add the notification and the migration progress indication  https://review.openstack.org/18961408:58
openstackgerritVincent Hou proposed openstack/python-cinderclient: Add the --force flag to cinder migrate  https://review.openstack.org/18954709:00
*** tobe has quit IRC09:02
*** abhishekk has joined #openstack-cinder09:03
openstackgerritVincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers  https://review.openstack.org/19593209:04
*** breitz has quit IRC09:05
*** breitz has joined #openstack-cinder09:06
*** vincent_hou has quit IRC09:08
*** husanu0 has joined #openstack-cinder09:09
*** jordanP has joined #openstack-cinder09:10
*** husanu0 has quit IRC09:18
*** boris-42 has quit IRC09:22
*** ndipanov has joined #openstack-cinder09:22
*** husanu4 has joined #openstack-cinder09:23
*** markus_z has quit IRC09:23
*** markus_z has joined #openstack-cinder09:28
*** husanu4 has quit IRC09:28
*** markvoelker has joined #openstack-cinder09:29
openstackgerritForest Romain proposed openstack/cinder: Correct overquota error message  https://review.openstack.org/19301809:33
*** markvoelker has quit IRC09:33
*** annegentle has joined #openstack-cinder09:45
*** annegentle has quit IRC09:50
*** lixiaoy1 has quit IRC09:52
*** dims has joined #openstack-cinder09:59
openstackgerritCedric Zhuang proposed openstack/cinder: Use symbol for error code in VNX cinder driver  https://review.openstack.org/18920810:00
*** bluex-pl has quit IRC10:02
*** ankit_ag has joined #openstack-cinder10:10
*** e0ne has joined #openstack-cinder10:15
*** dims has quit IRC10:18
*** agarciam has joined #openstack-cinder10:21
openstackgerritAndrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage  https://review.openstack.org/19359610:23
*** annashen has joined #openstack-cinder10:24
abhishekkndipanov: hi, you around?10:25
ndipanovabhishekk, hey10:27
abhishekkndipanov: need 5 minuts, is it good time?10:27
*** annashen has quit IRC10:28
ndipanovstart typing but I'll go get a coffee real quick :)10:29
abhishekkndipanov: https://bugs.launchpad.net/nova/+bug/141613210:29
openstackLaunchpad bug 1416132 in OpenStack Compute (nova) "_get_instance_disk_info fails to read files from NFS due to permissions" [High,In progress] - Assigned to Eric Harney (eharney)10:29
ndipanovyes10:29
abhishekkI have applied your patch, but the permission issue is still there10:29
ndipanovhmm so it's not fixing it then :(10:30
abhishekksee comment #410:30
ndipanovcan you give me more details?10:30
ndipanovinstance xml for example10:30
abhishekkok10:30
ndipanovand block_device_mapping table10:30
ndipanovWHERE instance_uuid = your uuuid10:31
abhishekkok just give me a minute, or you can proceed to coffee break, I will paste in here10:35
*** links has quit IRC10:36
*** et10man has quit IRC10:37
abhishekkndipanov: http://paste.openstack.org/show/32132610:43
*** heyun has quit IRC10:50
ndipanovabhishekk, thanks! that is very helpful!10:53
abhishekkndipanov: thank you too :)10:53
*** IanGovett has joined #openstack-cinder10:56
*** dims has joined #openstack-cinder10:59
*** e0ne is now known as e0ne_11:08
*** Lee1092 has joined #openstack-cinder11:10
*** kbyrne has quit IRC11:16
*** links has joined #openstack-cinder11:17
*** markvoelker has joined #openstack-cinder11:17
*** sgotliv has quit IRC11:18
*** e0ne_ has quit IRC11:18
*** sgotliv has joined #openstack-cinder11:19
*** links has quit IRC11:19
*** kbyrne has joined #openstack-cinder11:20
*** kbyrne has quit IRC11:21
*** kbyrne has joined #openstack-cinder11:21
*** markvoelker has quit IRC11:22
*** lpetrut has joined #openstack-cinder11:25
*** delattec has quit IRC11:31
*** cdelatte has quit IRC11:31
*** bluex-pl has joined #openstack-cinder11:36
*** e0ne has joined #openstack-cinder11:39
openstackgerritAndrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage  https://review.openstack.org/19359611:40
*** aix has quit IRC11:41
openstackgerritPranali Deore proposed openstack/cinder: Validate string, integer limit for input parameter  https://review.openstack.org/19496811:46
*** annegentle has joined #openstack-cinder11:47
*** annegentle has quit IRC11:52
openstackgerritAnton Arefiev proposed openstack/cinder: WIP: Implement service healthcheck tool  https://review.openstack.org/19566511:58
*** timcl has joined #openstack-cinder11:59
*** markvoelker has joined #openstack-cinder12:00
*** Ctina_ has joined #openstack-cinder12:04
*** aix has joined #openstack-cinder12:08
*** dims is now known as dimsum__12:09
*** laughterwym has joined #openstack-cinder12:09
*** akerr has joined #openstack-cinder12:11
*** dims_ has joined #openstack-cinder12:13
*** dimsum__ has quit IRC12:16
*** Longgeek_ has joined #openstack-cinder12:17
*** rmstar has joined #openstack-cinder12:20
*** Longgeek has quit IRC12:21
openstackgerritDaniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object  https://review.openstack.org/16364112:21
*** bswartz has quit IRC12:26
*** aix has quit IRC12:28
*** kjnelson has joined #openstack-cinder12:29
*** edmondsw has joined #openstack-cinder12:32
*** jaypipes has joined #openstack-cinder12:41
*** Longgeek has joined #openstack-cinder12:41
*** tellesnobrega has joined #openstack-cinder12:45
*** Longgeek_ has quit IRC12:45
*** julim has joined #openstack-cinder12:47
*** smoriya has quit IRC12:48
*** tellesnobrega has quit IRC13:04
openstackgerritAndrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage  https://review.openstack.org/19359613:04
*** dimsum__ has joined #openstack-cinder13:07
*** gouthamr has joined #openstack-cinder13:07
*** tellesnobrega has joined #openstack-cinder13:08
*** dims_ has quit IRC13:10
*** kaisers has quit IRC13:11
*** dtynan has quit IRC13:12
*** dtynan has joined #openstack-cinder13:12
*** kaisers has joined #openstack-cinder13:13
*** ankit_ag has quit IRC13:13
*** Yogi1 has joined #openstack-cinder13:18
*** shyama has quit IRC13:18
*** merooney has joined #openstack-cinder13:18
*** bswartz has joined #openstack-cinder13:19
*** mriedem has joined #openstack-cinder13:25
*** cdelatte has joined #openstack-cinder13:25
*** delattec has joined #openstack-cinder13:25
delattecDoes anyone by chance know of a way to disable cinder snapshots?  we want to temporarily disable just our users abilities to create snapshots while we are going through some changes.  Ideally through the policy.json file, but open to suggestions13:29
*** dustins has joined #openstack-cinder13:31
smcginnisdelattec: You should be able to change their quota to cap them.13:31
smcginnisdelattec: https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux_OpenStack_Platform/4/html/Administration_User_Guide/cli_set_quotas.html#cli_set_block_storage_quotas13:32
delattec#smcginnis we were looking at that at well.  the issue with quotas being we have modified project quotas per request for our users.  so we have some default, some not default.13:33
smcginnisdelattec: OK, I see. Maybe someone else has a suggestion then.13:34
delattecsmcginnis: thanks for the suggestion.  would have been easy if our customers were all default.  could have used puppet-cinder to make all those changes as well13:35
*** merooney has quit IRC13:37
*** thangp has joined #openstack-cinder13:40
*** primechuck has joined #openstack-cinder13:41
*** e0ne is now known as e0ne_13:46
*** boris-42 has joined #openstack-cinder13:47
*** annegentle has joined #openstack-cinder13:48
*** dansmith is now known as superdan13:49
*** annegentle has quit IRC13:53
*** abhishekk has quit IRC13:54
thangpdulek: ping13:54
thangpdulek: did you see this bug - https://bugs.launchpad.net/cinder/+bug/146912013:55
openstackLaunchpad bug 1469120 in Cinder "Cannot save dates in Versioned Objects" [Undecided,New] - Assigned to Gorka Eguileor (gorka)13:55
*** annegentle has joined #openstack-cinder13:55
dulekthangp: Looking at it...13:55
thangpdulek: gorka might have a good point13:56
*** e0ne_ is now known as e0ne13:56
thangpdulek: we might have to make every DateTime fields tzinfo_aware=False13:56
dulekgeguileo: Hey, Gorka, you should have pinged me on that. ;)13:56
dulekthangp: Why haven't we looked at other projects?13:57
thangpdulek: i started to look at nova13:57
geguileodulek: I mentioned it in the backup patch yesterday13:58
geguileodulek: I have a patch for that13:58
dulekgeguileo: Oh, I haven't noticed.13:58
dulekFun fact - Heat has all objects timezone-aware.13:58
dulekI don't get why they haven't run into problems.13:59
thangpdulek: they are using fields.DateTimeField from oslo_versionedobjects13:59
thangpand using the default13:59
thangphttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L4813:59
*** eharney has joined #openstack-cinder14:00
geguileoWe don't have problems either in delete time because we change it using the db methods14:00
dulekthangp: So what's wrong with Cinder if it works for Nova and Heat?14:00
*** salv-orl_ has quit IRC14:01
dulekgeguileo: Ah, I get it... But each of these projects has services table. That's the place where you bump up date manually.14:01
thangpdulek: I havent run into it, but I remember running into your patch or mine where we do update the *_at datetime field14:01
geguileodulek: If I'm not mistaken they don't use the objects to change datetimes14:01
thangpdulek: I dont remember where, but did the save work?14:01
dulekhttps://review.openstack.org/#/c/160417/14:03
dulekProbably this one.14:03
*** julim has quit IRC14:03
*** jecarey has joined #openstack-cinder14:03
geguileoI don't think we should disable the tzinfo14:04
geguileoWe agreed not to do that in the meeting14:04
openstackgerritPranali Deore proposed openstack/cinder: Validate string, integer limit for input parameter  https://review.openstack.org/19496814:04
dulekOh, I see why services worked - updated_at is handled inside the db.sqlalchemy14:05
dulekBut wait, if we don't have timezone info in the DB, then why should we in the code?14:06
*** Yogi1 has quit IRC14:06
dulekThat makes no sense to have tz_aware=True. We don't persist such information.14:06
thangpthe services object modifies the CinderPersistentObject to have tzinfo_aware=False14:07
geguileoSince it's oslo's default I wouldn't change it14:07
*** annegentle has quit IRC14:07
dulekthangp: Yeah, I haven't had time to update the patch after the meeting. I've meant services in Heat for example.14:08
*** DTadrzak has joined #openstack-cinder14:08
dulekgeguileo: Fact that this is default in Oslo doesn't mean that it's a good idea.14:08
geguileoXD14:08
geguileoWell, the other day in the meeting I was alone when suggested to remove it14:09
geguileoSo I have fixed this another way14:09
geguileoXD14:09
thangphttps://github.com/openstack/heat/blob/master/heat/objects/service.py#L3714:09
dulekgeguileo: If I remember correctly tz awareness was added by my colleague from the office, he isn't some nova-core-god-never-making-mistakes. :D14:09
thangpheat service is using the oslo_versionedobjects fields14:09
thangpwith the default14:09
geguileoNova is doing it as well14:10
dulekthangp: Yes, but they bump up the updated_at using just update method. They don't change it directly.14:10
*** krtaylor has quit IRC14:10
*** Yogi1 has joined #openstack-cinder14:10
dulekthangp: The thing is - if you update it directly - then you're unable to save the object.14:10
dulekI see three options:14:11
dulek1. Change model (not an option really).14:11
dulek2. Change fields in objects.14:11
dulek3. Make conversion (a little nasty...)14:11
dulekAnything else?14:11
*** annegentle has joined #openstack-cinder14:11
*** annegentle has quit IRC14:11
thangpdulek: which update method?14:11
thangpcould you point to the code?14:12
geguileoGive me 1 minute and I'll update my solution and we can discuss it14:12
*** annegentle has joined #openstack-cinder14:13
*** annegentle has quit IRC14:13
*** amoturi has joined #openstack-cinder14:14
*** e0ne is now known as e0ne_14:14
dulekthangp: I'm unable to see where's heartbeat bumping in the code in Nova or Heat.14:14
*** merooney has joined #openstack-cinder14:15
thangpdulek: ok14:15
thangpI think we should keep using the default and modify the update() in cinder's base to handle the save correctly14:16
thangpand the save()14:16
dulekThat would be option 3.14:16
*** e0ne_ is now known as e0ne14:16
thangpbut it would apply to all objects14:16
thangpif we change it in CinderObject14:17
dulekYes, that's what I've expected.14:17
geguileoThat's something similar to what I've done14:17
thangpbut I still dont know why nova works14:17
dulekthangp: :D14:17
geguileoIt's not that "nasty"  ;-)14:17
dulekSo when we're loading non-tz-aware DB row into tz-aware field in object - it assumes it's UTC?14:17
thangpdulek: yup14:18
dulekthangp: https://github.com/openstack/nova/search?utf8=%E2%9C%93&q=scheduled_at+%3D+&type=Code14:18
thangpthangp: and it should based on our meeting yesterday14:18
dulekthangp: I cannot find any occurrence in Nova where they modify the date in an object.14:18
thangphmm... :-/14:19
geguileodulek: That's what I said before, they don't modify dates in the objects14:19
geguileoThey access the DB directly, like we do14:19
thangpoption 4: get oslo to change their default14:21
thangpwould need to talk with superdan14:21
dulekHuh, what's happening in Nova that makes danms become superdan?14:22
thangpdulek: it's a friday14:23
thingeedulek: casual nick friday14:23
thangpdulek: they change to alias14:23
dulekI love the idea. :D14:23
geguileoXD XD14:23
openstackgerritGorka Eguileor proposed openstack/cinder: Fix backup metadata import missing fields  https://review.openstack.org/18322214:24
openstackgerritGorka Eguileor proposed openstack/cinder: Fix saving tz aware datetimes in Versioned Objects  https://review.openstack.org/19607114:24
geguileodulek: thangp ^14:26
dulekThanks geguileo, let's consult that with superdan and get over it. :)14:26
geguileodulek: Ok14:26
*** r-daneel has joined #openstack-cinder14:26
thangpgeguileo: looks cleaner then changing everything14:27
geguileothangp: And it supports timezones in the objects14:27
thangpagree, we should consult with superdan14:27
geguileoWhich I think it's a good thing14:27
geguileoI have to leave now, I have a wedding to go to, but I'd appretiate if you could keep me updated with you conversation with superdan14:28
thangpgeguileo: np, thanks!14:29
geguileoBy the way, I also changed the approach to the backup migration to use objects14:29
*** lcurtis has joined #openstack-cinder14:29
geguileoAnd I think it looks a lot nicer now14:29
dulekgeguileo: Thanks, have a nice evening!14:30
geguileoYour suggestions actually helped me improve readability (I think), so thanks14:30
*** merooney has quit IRC14:30
*** alexpilotti has joined #openstack-cinder14:30
geguileoThanks, you too, and a nice weekend as well14:30
thangpdulek: lets jump to the nova channel to find superdan14:31
dulekthangp: okay!14:31
thangpdulek: he's on a call14:32
thangpdulek: he'll response soon14:32
dulek:)14:32
*** sgotliv has quit IRC14:34
*** alexpilotti_ has joined #openstack-cinder14:35
*** alexpilotti has quit IRC14:36
*** alexpilotti_ is now known as alexpilotti14:36
openstackgerritEric Harney proposed openstack/cinder: Don't allow >4-byte Unicode chars in volume names  https://review.openstack.org/19569514:36
*** merooney has joined #openstack-cinder14:38
ameadehemnafk: https://review.openstack.org/#/c/157439/13 wrt splitting, i have them as one to show an example, the api.py stuff is how you could do the API level tracing14:39
*** rmesta has joined #openstack-cinder14:39
*** lpabon has joined #openstack-cinder14:41
*** xyang1 has joined #openstack-cinder14:43
*** nikeshm has quit IRC14:45
*** jordanP has quit IRC14:45
*** krtaylor has joined #openstack-cinder14:46
openstackgerritEric Harney proposed openstack/cinder: Don't allow >3-byte Unicode chars in volume names  https://review.openstack.org/19569514:50
*** vilobhmm has joined #openstack-cinder14:50
*** MentalRay has joined #openstack-cinder14:52
*** anshul has quit IRC14:53
*** jaypipes is now known as leakypipes14:56
*** belmoreira has quit IRC14:57
*** kjnelson has quit IRC14:58
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502714:59
openstackgerritDaniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object  https://review.openstack.org/16364114:59
Swansonvincent_hou: ping15:02
*** kjnelson has joined #openstack-cinder15:04
*** salv-orlando has joined #openstack-cinder15:05
superdanthangp: okay, I see some of the backlog here, but probably easier if you summaries15:05
superdaner, summarize15:05
*** bluex-pl has quit IRC15:05
thangpsuperdan: ok...the problem is outline here - https://bugs.launchpad.net/cinder/+bug/146912015:06
openstackLaunchpad bug 1469120 in Cinder "Cannot save dates in Versioned Objects" [Undecided,In progress] - Assigned to Gorka Eguileor (gorka)15:06
thangpsuperdan: basically...15:06
*** timcl has quit IRC15:06
*** primechuck has quit IRC15:06
thangpsuperdan: the db does not save the timezone15:06
thangpsuperdan: the objects do15:06
superdanah, yeah, so we just convert them all to unaware UTC timestamps in db_api15:06
thangpsuperdan: do should we make the fields.DateTimeField use tzinfo_aware=False?15:07
*** ronis has quit IRC15:07
thangpbecause by default it is True15:07
superdanyou can do that if you want15:07
superdanthangp: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L32315:08
thangpgeguileo: had another suggestion - https://review.openstack.org/#/c/196071/115:08
superdanthangp: I probably wouldn't do it that way, but that's certainly easy15:08
thangpsuperdan: or could we make the oslo_versionedobjects use tzinfo_aware=False by default?15:09
superdanthangp: I think I'd probably make a obj_cinder_get_changes() or something just to make it clearly a cinderism15:09
superdanthangp: yeah, but that changes the RPC API, if you've already started passing these objects over the wire...15:09
superdanthangp: TBH, I think the TZ-aware-ness is most important over RPC15:09
thangpsuperdan: hmm...ok15:09
superdanwe specifically decided to default to TZ-aware just to be very clear about things,15:10
superdanbecause we had like two timestamps that were in local time or something silly like that15:10
superdanand it was always confusing15:10
*** rakesh_mishra has joined #openstack-cinder15:10
thangpok, so changing oslo is not an option, so we will make some changes in cinder obj to handle it15:11
thangpthx! was quick15:11
geguileosuperdan: Thanks15:11
superdangeguileo: np15:11
superdanfor what it's worth, this decision to be explicit about TZs has caused no end of pain for everyone15:12
geguileoAnd that you all for having the conversation here, I got to read it before leaving :)15:12
thangp:)15:12
superdanI still think it's the right thing to do in a model, but it's still painful :)15:12
superdangeguileo: no problem, I was just on a call earlier and had to pay attention15:12
*** dimsum__ has quit IRC15:13
geguileoUsually a good idea paying attention to phone conversations  XD15:13
superdanheh15:13
*** garthb has joined #openstack-cinder15:14
*** salv-orlando has quit IRC15:14
*** garthb_ has joined #openstack-cinder15:14
openstackgerritSergey Vilgelm proposed openstack/cinder: Use right oslo.service entry points  https://review.openstack.org/19609915:15
openstackgerritSergey Vilgelm proposed openstack/cinder: Use right oslo.service entry points  https://review.openstack.org/19609915:17
*** DericHorn-HP has joined #openstack-cinder15:23
*** e0ne is now known as e0ne_15:25
*** e0ne_ is now known as e0ne15:25
*** zul has quit IRC15:28
openstackgerritSergey Vilgelm proposed openstack/cinder: Use right oslo.service entry points  https://review.openstack.org/19609915:29
*** garthb_ has quit IRC15:30
*** garthb has quit IRC15:30
*** merooney has quit IRC15:31
*** zul has joined #openstack-cinder15:33
*** tellesnobrega has quit IRC15:34
*** DericHorn-HP has quit IRC15:36
*** tellesnobrega has joined #openstack-cinder15:38
*** yuriy_n17 has quit IRC15:41
*** hemna has joined #openstack-cinder15:43
openstackgerritAnton Arefiev proposed openstack/cinder: Implement service healthcheck tool  https://review.openstack.org/19566515:45
mriedemjgriffith: so i guess i'll need to bring this up in a cinder meeting next week huh https://review.openstack.org/#/c/193673/15:53
mriedemgiven the 3rd party ci explosion15:53
mriedemi guess i could start with the mailing list as a heads up15:54
mriedemxyang1: ^15:54
*** mriedem is now known as mriedem_lunch15:54
xyang1mriedem: Hi15:54
xyang1mriedem_lunch: Yes, we should discuss at team meeting15:55
xyang1mriedem_lunch: Since this affects lots of CI's15:55
*** amoturi has quit IRC15:55
xyang1mriedem_lunch: start with Mailing list is good idea15:56
smcginnis+115:56
*** Yogi1 has quit IRC15:56
jgriffithmriedem_lunch: heads up on ML seems appropriate to me15:57
*** vilobhmm has quit IRC15:58
*** markstur has quit IRC15:58
xyang1jgriffith: Did you do anything special in your driver to support this, other than setting the key?15:59
hemnadoesn't the current patch set the key in the manager?15:59
hemnaregardless of the driver15:59
xyang1hemna: Yes15:59
tbarronping eharney15:59
jgriffithhemna: yes, which is how it should've been in the first place16:00
xyang1hemna: But ci still fails for some16:00
*** markstur has joined #openstack-cinder16:00
hemnajgriffith, +116:00
jgriffithxyang1: no, I didn't need to do anything.  But I do need to look closer at it again16:00
jgriffithxyang1: in theory drivers shouldn't "matter" for this16:00
xyang1hemna: So I don't know what else needs to be fixed in the driver16:00
tbarroneharney: w.r.t.  https://review.openstack.org/195695, here's what I'm trying to say: http://paste.openstack.org/show/321391/16:00
jgriffithxyang1: it's all done on hypervisor layer etc16:00
xyang1jgriffith: so that is why I don't understand why it failed netapp ci on this patch16:01
jgriffithxyang1: but "stuffs on fire yo"16:01
xyang1jgriffith: It should work16:01
eharneytbarron: humm.... what version of python is that?16:01
tbarronmriedem_lunch: the patch looks good and I am certainly not proposing that we not do it, we just wanted to know if we can skip16:02
tbarronand what the plan was for removing the skip eventually16:02
xyang1jgriffith: If it is taken care of by hypervisor16:02
tbarroneharney: 2.7.616:02
xyang1jgriffith: And this patch sets the key for everyone16:02
jgriffithtbarron: might be good to explain why it breaks?16:02
jgriffithtbarron: the only error I see in your cDOT driver is: dpkg-query16:03
tbarronjgriffith: :-) that's expected16:03
*** harlowja_at_home has joined #openstack-cinder16:03
eharneytbarron: that even works on my 2.6.6 install...16:04
jgriffithtbarron: my point is that you fail, but there's no useful info in the logs16:04
jgriffithtbarron: ie no way to know "why" :)16:04
tbarronjgriffith: good point, that's why I haven't been able to figure it out myself yet16:04
jgriffithtbarron: same with the other systems FWIW16:04
jgriffithtbarron: I *could* spend my morning debuggin everybody elses stuff, but I'd rather not :)16:05
tbarronjgriffith: feel free to do so, but we didn't ask you to :-)16:05
jgriffithtbarron: LOL :)16:05
*** ronis has joined #openstack-cinder16:05
jgriffithtbarron: all I know is it breaks attach... can't see why though :(16:06
tbarronjgriffith: my plan was to start learning about encrypted volumes, which weren't even on my horizon (no pun) before16:06
Swansonjgriffith: you could be a geek super hero.  D'Bugger!  Coding by day, debugging by night!16:06
jgriffithSwanson: no thanks.. been there done that.  Doesn't pay well :)16:06
Swansonjgriffith: or at all16:06
tbarronjgriffith: me either, looks like the LUKS commands don't like the blocks we present to it though16:06
tbarronjgriffith: I dunno why16:06
hemnaxyang1, yah that's what I'm curious about, but then why is ceph failing then16:06
*** leeantho has joined #openstack-cinder16:06
jgriffithof course the f'ing spewing of errors in the nova logs doesn't help16:07
tbarroneharney: so that failure I see may be spurious, if it doesn't show up in CI, I won't worry about it16:07
xyang1hemna: I Did you anything else other than setting the key in your driver?16:07
jgriffithoh... interesting16:07
tbarroneharney: maybe "wide" vs "narrow" python build?16:07
eharneytbarron: well, it's pretty weird.  makes me wonder if something is wrong w/ your version of python on mac...16:07
hemnaxyang1, I don't think we did anything in our driver for encryption16:08
tbarroneharney: mebbe so16:08
jgriffithtbarron: xyang1 ok, so here's a clue maybe16:08
*** rushiagr_away is now known as rushiagr16:09
tbarroneharney: that code ran just fine on ubuntu trusty with python 2.7.616:10
tbarronjust checked now16:10
tbarroneharney: so I'll write that up to mac anomaly16:11
*** DericHorn-HP has joined #openstack-cinder16:11
eharneytbarron: can you try replacing \uffff with \U00001000 ?16:11
tbarroneharney: and it looks ok on ubuntu trusty with 3.416:12
eharneytbarron: wait... that's not right16:12
eharneytbarron: \U0001000016:12
eharneytbarron: or maybe \U0000FFFF16:13
tbarroneharney: yeah, I already tried that and it had the same error, hence my "too wide" theory, but let me try those you just posted again to be sure16:13
*** e0ne is now known as e0ne_16:14
eharneytbarron: i suspect it's https://bugs.python.org/issue12749  which includes a test case to see if that's the issue16:14
*** e0ne_ has quit IRC16:15
*** dannywilson has joined #openstack-cinder16:16
openstackgerritThang Pham proposed openstack/cinder: Conversion to volume object  https://review.openstack.org/17705416:16
openstackgerritThang Pham proposed openstack/cinder: WIP: RPC and object versioning  https://review.openstack.org/18440416:17
openstackgerritVincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers  https://review.openstack.org/18087316:18
*** rmesta has quit IRC16:18
*** rmesta has joined #openstack-cinder16:18
tbarroneharney: http://paste.openstack.org/show/321399/16:19
tbarroneharney: looking at https://bugs.python.org/issue12749  now16:19
*** Apoorva has joined #openstack-cinder16:23
tbarroneharney: 'if re.search("[𝒜-𝒵]", "𝒞", re.UNICODE):' (from the python bug you cite) works on the mac 2.7.616:23
eharneytbarron: well... seems like i need to figure out something so that i don't have a horde of mac users showing up saying i broke everything :/16:24
*** harlowja_at_home has quit IRC16:24
*** haypo has left #openstack-cinder16:24
tbarroneharney: they only reason I have a mac was that when they refreshed my old stinkpad running (cough) debian, I couldn't get a new one from our corp supplier with as much ram & ssd as this powerbook16:25
tbarroneharney: and now I've grown accustomed to running unit tests on it16:25
tbarroneharney: which to my pleasant surprise were running just fine16:26
tbarroneharney: but I deploy to a running devstack on an ubuntu trusty vm everytime I make a code change anyways16:26
*** bill_az has joined #openstack-cinder16:26
tbarroneharney: so it wouldn't be a big burden for me to just run UT there as well16:27
*** tellesnobrega has quit IRC16:28
eharneytbarron: unfortunately without understanding the cause, it's hard to know where else it will be broken too16:28
*** merooney has joined #openstack-cinder16:29
openstackgerritVincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers  https://review.openstack.org/18087316:33
akerrjgriffith: just saw the conversation about the patch.  The errors appear in the nova log for some reason.  They try to run a mount command during attach but the device they use is "already in use."  No idea why though :(16:33
*** tellesnobrega has joined #openstack-cinder16:35
jgriffithakerr: indeed16:35
jgriffithakerr: only thing I'm wondering is if part of the Luks formatting is hanging up or puking on the device16:36
jgriffithakerr: also quick look trying to coorelate what backends are impacted... looks like all Netapp and HDS have similar signature16:36
jgriffithakerr: number of the other failures appear to be different, but didn't dig real deep into the logs16:37
jgriffithwas thinking the other thing is Netapp and HDS have some "out of tree" initialize connection stuff... but that doesn't seem too relevant16:37
jgriffithakerr: anywho... it would be really cool to have a bug and know what someobody from Netapp is actively working and trying to resolve it16:38
*** Yogi1 has joined #openstack-cinder16:38
akerrjgriffith: I think tbarron is looking into it, but I'm not sure we filed a bug yet on LP16:38
*** _cjones_ has joined #openstack-cinder16:39
*** dannywilson has quit IRC16:41
*** ronis has quit IRC16:41
openstackgerritVincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers  https://review.openstack.org/18087316:42
*** e0ne has joined #openstack-cinder16:43
*** e0ne has quit IRC16:45
*** dimsum__ has joined #openstack-cinder16:53
*** jungleboyj has joined #openstack-cinder16:57
*** laughterwym has quit IRC16:57
jgriffithmriedem_lunch: akerr tbarron something that might be worth looking at16:58
jgriffithmriedem_lunch: akerr tbarron on the nova side we do a connect, encryptor.attach then the guest attach dev16:59
jgriffithmriedem_lunch: akerr tbarron given the notes on the detach side about order and "still in use" I'm wondering if that's something Netapp and others should be focusing on16:59
*** markus_z has quit IRC16:59
jgriffithie you don't do multi-attach support or something along those lines16:59
jgriffithor if that sequence is just "not right"17:00
*** setmason has joined #openstack-cinder17:01
*** Longgeek has quit IRC17:02
*** mriedem_lunch is now known as mriedem17:02
mriedemjgriffith: xyang1: tbarron: eharney: the problem on the nova side is the provider code (the luks or cryptsetup modules in nova) expects the 'device_path' key to be set in the connection_info from the libvirt volume driver being used17:03
*** tellesnobrega has quit IRC17:03
*** annashen has joined #openstack-cinder17:03
mriedemthat isn't set for some of these other volume drivers so they get a KeyError in the encryption provider in nova17:03
mriedemsee the related nova change here https://review.openstack.org/#/c/193830/17:03
mriedemto turn that KeyError into something not as dumb17:03
*** patrickeast has joined #openstack-cinder17:04
*** eharney has quit IRC17:05
mriedemi'll send something to the ML17:05
xyang1mriedem: Device_path key is set for iscsi and fc drivers, so they should work then17:05
xyang1hemna: around?17:06
*** bswartz has quit IRC17:07
mriedemxyang1: yes that's true17:07
mriedemxyang1: that's why the encrypted volumes test is fine in the integrated gate since it's using lvm17:07
xyang1mriedem: Then the failure in NetApp CI is something else17:07
mriedemthe failure in the ceph job was something else too17:08
mriedemthat's why i rechecked it17:08
xyang1mriedem: Their iscsi test failed17:08
openstackgerritSergey Vilgelm proposed openstack/cinder: Use right oslo.service entry points  https://review.openstack.org/19609917:08
*** ronis has joined #openstack-cinder17:09
openstackgerritTom Barron proposed openstack/cinder: Fix 'no actual-pathname' API error  https://review.openstack.org/19614817:11
*** ameade is now known as ameade_vacation17:16
openstackgerritDmitry Guryanov proposed openstack/cinder: smbfs: fix invalid check for smbfs_used_ratio correctness  https://review.openstack.org/19032617:20
hemnaxyang1, yah17:20
*** eharney has joined #openstack-cinder17:21
xyang1hemna: Did you see mriedem's comments about device_path17:21
hemnano17:21
xyang1hemna: So FC and iSCSI drivers should work17:21
xyang1hemna: It is about encryption17:22
hemnaxyang1, which patch are we talking about ?17:22
xyang1hemna: On nova side, it requires device_path17:22
*** e0ne has joined #openstack-cinder17:22
xyang1https://review.openstack.org/#/c/193673/17:23
xyang1hemna: mriedem's patch17:23
hemnaok17:24
hemnaso the RBD libvirt volume driver isn't setting device_path ?17:24
xyang1hemna: sounds like it17:24
mriedemhemna: nope17:24
*** dannywilson has joined #openstack-cinder17:24
mriedemhemna: jgriffith: xyang1: tbarron: eharney: here is the long form http://lists.openstack.org/pipermail/openstack-dev/2015-June/068117.html17:25
mriedembrb17:25
*** eharney has quit IRC17:25
*** EmilienM is now known as EmilienM|brb17:25
*** eharney has joined #openstack-cinder17:26
hemnamriedem, yah the RBD driver in libvirt doesn't even do connect_volume17:27
hemnait's simply a call to get_config17:27
hemnahrmm17:27
hemnaI'm not an RBD guy, so I have no idea how it works.17:27
hemnaI thought every libvirt volume driver's job was to return the device_path17:28
hemnafor connect_volume17:28
mriedemthere isn't actually an rbd volume driver in nova, it's in the network volume driver17:28
hemnamriedem, yah17:28
hemnaI was just looking through that stuff again17:28
hemnaI've been hacking that file up quite a bit lately with my os-brick patch17:29
mriedemhttp://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/volume.py#n24217:29
hemnabut left alone the net driver17:29
mriedemthe connect happens in hte base class17:29
mriedemwhich is a pass :)17:29
*** MentalRay has quit IRC17:29
*** bswartz has joined #openstack-cinder17:30
hemnayup17:30
hemnano idea how RBD volumes get into the VM's then if there is not device path set17:30
*** timcl has joined #openstack-cinder17:30
hemnamaybe it's a native virt supported protocol ?17:30
*** annegentle has joined #openstack-cinder17:31
hemnathat libvirt itself knows how to connect to it.17:31
hemnahence no need for the device path17:31
hemnain that case, then libvirt itself would need encrypted volume support in order to do encrypted RBD volumes17:31
*** MentalRay has joined #openstack-cinder17:31
mriedemit's not just rbd, i also don't see it for quobyte and some others17:32
hemnahttps://libvirt.org/storage.html#StorageBackendRBD17:32
hemnayup17:32
hemnathat's why the get_config for the net driver is setting those values and not a device_path17:32
openstackgerritIvan Kolodyazhny proposed openstack/cinder-specs: Cinder API WSGI application under Apache/Nginx  https://review.openstack.org/19268317:34
*** shyama has joined #openstack-cinder17:34
hemnamriedem, I think the get_config().source_path has it though17:34
hemnahttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume.py#L153617:34
*** annegentle has quit IRC17:36
*** amoturi has joined #openstack-cinder17:39
mriedemhemna: for quobyte you mean, yeah, just not set during connect_volume though17:39
hemnayah17:39
xyang1mriedem: I have a different question for you.  What should I do about the scaleio libvirt volume driver spec?  I saw an email about nova spec freeze today.  Not sure if I need to move it somewhere17:39
e0nethingee: hi. i'm going to post update about removing api v2 to openstack-dev.17:39
e0nethingee: do you have any wishes or objections?17:40
mriedemxyang1: i think libvirt volume drivers in nova are going to depend on os-brick17:40
mriedemxyang1: so we need to get hemna's os-brick integration patch reviewed and in17:40
mriedemi haven't reviewed it yet17:40
xyang1mriedem: Ok, so I don't need to worry about that spec then17:41
*** ndipanov has quit IRC17:42
openstackgerritAnthony Lee proposed openstack/cinder: Improve 3PAR driver VLUN creation and deletion  https://review.openstack.org/19616417:44
mriedemxyang1: i don't think so. assuming your scaleio thing gets into os-brick and os-brick gets into nova, then the only changes needed in nova i think are the volume driver registration in the libvirt driver.py, right?17:44
mriedemxyang1: this part: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L27117:45
xyang1mriedem: It still needs a shim libvirt volume driver: https://review.openstack.org/#/c/194454/17:46
xyang1mriedem: My patch is dependent on hemna 's os-brick patch17:46
mriedemxyang1: where is your os-brick change?17:47
mriedemhttps://review.openstack.org/#/c/185835/17:47
xyang1Yes17:48
mriedemxyang1: so i'm confused, when https://review.openstack.org/#/c/185835/5/os_brick/initiator/connector.py gets into os-brick, does the shim libvirt volume driver still need the connect/disconnect_volume and get_config methods?17:48
mriedemwell, for like iscsi in hemna's change https://review.openstack.org/#/c/175569/19/nova/virt/libvirt/volume.py17:49
mriedemthe connect/disconnect calls just pass through to os-brick17:49
hemnayah, they should17:49
hemnaand populate anything in connection_info after the brick call is made17:49
mriedemok17:49
mriedemget_config() remains untouched though?17:50
hemnayah most likely.  if everything is done in connect_volume, then get_config should have everything it needs at that point.17:50
*** dannywilson has quit IRC17:50
*** dannywilson has joined #openstack-cinder17:51
mriedemhemna: ok, i thought the libvirt volume driver would just call os-brick for get_config too17:51
mriedembut i honestly don't know how all of it works either17:51
mriedemsince for example there is a get_config in os-brick for the scaleio connector https://review.openstack.org/#/c/185835/5/os_brick/initiator/connector.py17:52
mriedemoh well, they aren't really the same. and in nova we could probably abstract some of the get_config in a base class since most of it is copy/paste in those drivers17:54
mriedemset the source_type and source_path, we could just delegate that to the subclasses to return their type and path given connection_info, let the base class set the config values17:54
*** e0ne is now known as e0ne_17:55
*** rakesh_mishra has quit IRC17:57
hemnamriedem, the config stuff is specific to nova17:57
hemnaso brick connectors don't have a get_config.   they just do the connect_volume and disconnect_volume work17:58
hemnaand the libvirt drivers will build the config out of the connection_info returned from the connect_volume calls17:58
*** mriedem has quit IRC17:59
hemnaI'm all for refactoring the nova libvirt volume drivers, but we have to do step 1 first :)17:59
*** mriedem has joined #openstack-cinder18:01
*** Longgeek has joined #openstack-cinder18:02
*** gouthamr has quit IRC18:03
*** EmilienM|brb is now known as EmilienM18:04
*** akerr has quit IRC18:04
*** rushiagr is now known as rushiagr_away18:04
openstackgerritTom Barron proposed openstack/cinder: Fix 'no actual-pathname' NetApp API error  https://review.openstack.org/19614818:07
*** annashen has quit IRC18:08
*** Longgeek has quit IRC18:08
*** annashen has joined #openstack-cinder18:08
*** e0ne_ is now known as e0ne18:10
*** DericHorn-HP has quit IRC18:12
*** DericHorn-HP has joined #openstack-cinder18:13
*** rushiagr_away is now known as rushiagr18:17
*** DericHorn-HP has quit IRC18:17
*** sjcherry has joined #openstack-cinder18:17
*** DericHorn-HP has joined #openstack-cinder18:18
*** arif-ali has quit IRC18:31
*** annegentle has joined #openstack-cinder18:32
*** Yogi1 has quit IRC18:34
*** arif-ali has joined #openstack-cinder18:36
*** annegentle has quit IRC18:37
*** arif-ali has quit IRC18:37
*** arif-ali has joined #openstack-cinder18:38
*** dustins has quit IRC18:38
*** rushiagr is now known as rushiagr_away18:39
*** e0ne has quit IRC18:42
*** annegentle has joined #openstack-cinder18:51
*** e0ne has joined #openstack-cinder18:54
*** rushiagr_away is now known as rushiagr18:56
tbarronmriedem: thanks for writing that up!  I had to leave my keyboard for a while and am just now catching up with the backlog here.19:03
*** Ctina__ has joined #openstack-cinder19:03
*** merooney has quit IRC19:03
*** scottda has quit IRC19:03
mriedemtbarron: you didn't miss much19:03
tbarronI think it will well repay my efforts to learn what is going on here19:03
tbarronmriedem: well, I had to leave suddenly (realized I had forgotten all about lunch meeting) just as jgriffith was offering his suggestions19:04
tbarronthen got back to the office and had to take care of stuff with folks there for a bit19:05
xyang1tbarron: I don't know why your iscsi driver failed because it should have device_path19:05
*** Ctina_ has quit IRC19:06
*** Ctina__ has quit IRC19:07
*** harlowja has quit IRC19:09
openstackgerritTom Barron proposed openstack/cinder: Remove oslo logging from backup unit tests  https://review.openstack.org/19123319:11
*** Lee1092 has quit IRC19:15
*** r-daneel has quit IRC19:17
*** primechuck has joined #openstack-cinder19:18
*** rushiagr is now known as rushiagr_away19:19
*** markvoelker has quit IRC19:20
*** annegentle has quit IRC19:20
*** harlowja has joined #openstack-cinder19:22
*** rmesta has left #openstack-cinder19:26
*** haypo has joined #openstack-cinder19:26
patrickeastjgriffith: hey, back again with a question about virtual size, for an image like http://paste.openstack.org/show/321426/ is virtual size supposed to be in GB rounded up to an int? or a float number?19:26
*** alexpilotti has quit IRC19:26
*** markvoelker has joined #openstack-cinder19:26
patrickeastjgriffith: i’m assuming an in int based on what you’ve got here https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/solidfire.py#L554 but i wanted to double check19:27
hayposmcginnis: hi. you approved two of my python 3 patches on backup cinder, but they depend on https://review.openstack.org/#/c/194587/ would you like to review it? IMO it's even simpler than the two other patches19:27
haypo(well, smcginnis or another core reviewer ;-))19:28
jgriffithpatrickeast: I round everything up to int/GiB19:28
jgriffithpatrickeast: it doesn't make much sense not to given the resolution of volumes in Cinder is GiB19:28
patrickeastjgriffith: ah yea, that makes sense19:28
patrickeastjgriffith: ok cool19:28
patrickeastjgriffith: ill do the same then19:28
patrickeastthanks!19:29
jgriffithpatrickeast: cool19:29
hayposmcginnis: (anything, thanks for the review you already did ;-))19:29
tbarronxyang1: right, that's a good question, maybe the best place to start investigating.19:30
*** timcl has left #openstack-cinder19:32
*** markvoelker has quit IRC19:32
*** markvoelker has joined #openstack-cinder19:32
*** e0ne has quit IRC19:36
*** markvoelker_ has joined #openstack-cinder19:38
*** markvoelker has quit IRC19:40
*** shyama has quit IRC19:41
openstackgerritTom Barron proposed openstack/cinder: Port NetApp DATAONTAP blocks drivers to ABC model  https://review.openstack.org/19620219:42
*** markvoelker has joined #openstack-cinder19:44
*** markvoelker_ has quit IRC19:45
*** skylerberg has joined #openstack-cinder19:45
mtreinishjgriffith: btw, just a heads up you might want to make sure you're running the latest subunit2sql release, the last oslo.db release broke things so I had to add an exclude to requirements19:45
*** sjcherry has quit IRC19:45
mtreinisherr, well I guess it's only an issue if you ever reinstall subunit2sql or it's deps in your env19:46
mtreinishwhich I don't think you would from what I remember of the sos code19:46
mtreinishso nm19:46
jgriffithmtreinish: :)19:46
openstackgerritAnthony Lee proposed openstack/cinder: Improve 3PAR driver VLUN creation and deletion  https://review.openstack.org/19616419:47
jgriffithmtreinish: so the good think is my Docker file just pulls latest for everything anyway if/when I rebuild19:47
jgriffithmtreinish: which is on my list of things to do next week as a matter of fact19:47
jgriffithmtreinish: I'm trying an experiment with isolating the services and scaling out the workers as seperate containers19:48
*** daneyon has joined #openstack-cinder19:50
mtreinishjgriffith: heh, ok cool19:51
mtreinishI just wanted to make sure it didn't break you, because it killed yesterday's nodepool image build19:51
*** MentalRay has quit IRC19:52
jgriffithmtreinish: thanks... and yeah, forget sometimes I'm the only one that cares about the nonsense I try and blabber about :)19:52
*** markvoelker has quit IRC19:54
mtreinishjgriffith: heh, nah trying to run the workers isolated in different containers is an interesting idea19:54
mtreinishjust doesn't apply much to what I would ever be doing :)19:54
openstackgerritPatrick East proposed openstack/cinder: WIP generic image cache  https://review.openstack.org/19579519:55
patrickeastjgriffith: ^ that version doesn’t do the silly recursion thing and actually uses the virtual size19:56
jgriffithpatrickeast: sweeeet!19:57
jgriffithpatrickeast: it's in my queue19:57
jgriffithpatrickeast: I promise feedback on Monday so don't let me forget :)19:57
patrickeastjgriffith: thanks!19:58
*** markvoelker has joined #openstack-cinder19:58
jgriffithpatrickeast: today's all about Puppet and keeping myself from jumping out the window because I dislike it soooo much19:58
patrickeasthaha19:58
patrickeastjgriffith: i understand just enough about puppet to really like the concept, and enough to really hate trying to change/write modules19:59
jgriffithpatrickeast: the writing modules is "ok" IMHO, but the shit it does constantly going back and modiyfing/resetting stuff just pisses me off :)19:59
jgriffithpatrickeast: I prefer run-once and get on with life :)20:00
jgriffitheven though I know that's not what most want20:00
patrickeastjgriffith: yea its nice sometimes like when i know something is wrong but I don’t know what it is, i can just re-apply the puppet stuff and not worry about it20:01
patrickeastbut if there is one specific thing i want it to do its annoying to wait20:02
jgriffith:)20:02
*** e0ne has joined #openstack-cinder20:03
*** zhenguo has quit IRC20:03
openstackgerritTom Barron proposed openstack/cinder: Port NetApp E-Series iSCSI driver to ABC model  https://review.openstack.org/19622520:03
*** Longgeek has joined #openstack-cinder20:04
mriedemtbarron: jgriffith: xyang1: as promised https://wiki.openstack.org/wiki/CinderMeetings#Next_meeting20:06
xyang1mriedem: Sounds good20:07
tbarronmriedem: excellent20:07
*** Longgeek has quit IRC20:09
*** markvoelker_ has joined #openstack-cinder20:09
*** markvoelker has quit IRC20:11
*** markvoelker_ has quit IRC20:12
*** pots1 has quit IRC20:15
*** MentalRay has joined #openstack-cinder20:16
*** krtaylor has quit IRC20:21
*** e0ne has quit IRC20:24
*** hemna has quit IRC20:25
skylerbergHi tbarron: I wanted to check in on https://review.openstack.org/#/c/193673/. Right now it causes the Tintri-ci (which I am working on) to go into and inconsistent state. For now we are going to not respond to changes on this change to avoid false failures on subsequent changes.20:25
skylerbergDo you think these tests will be skipped if this patch goes in or will this require changes to our CI or driver?20:26
*** amoturi has quit IRC20:27
*** ronis has quit IRC20:34
*** rmesta has joined #openstack-cinder20:37
*** annegentle has joined #openstack-cinder20:37
*** e0ne has joined #openstack-cinder20:39
*** e0ne has quit IRC20:44
*** daneyon_ has joined #openstack-cinder20:46
*** daneyon has quit IRC20:49
*** jecarey has quit IRC20:50
*** xyang1 has quit IRC20:50
*** markvoelker has joined #openstack-cinder20:51
*** sgotliv has joined #openstack-cinder20:52
*** skylerberg has quit IRC20:55
*** thangp has quit IRC20:55
*** jwcroppe_ has joined #openstack-cinder20:58
*** jwcroppe has quit IRC21:00
*** jwcroppe_ has quit IRC21:02
*** jwcroppe has joined #openstack-cinder21:02
openstackgerritJay Bryant proposed openstack/cinder: Sync the latest fileutils module from oslo-incubator  https://review.openstack.org/19624521:04
*** krtaylor has joined #openstack-cinder21:05
*** jwcroppe_ has joined #openstack-cinder21:05
*** skylerberg has joined #openstack-cinder21:06
*** jwcroppe has quit IRC21:06
*** lpetrut has quit IRC21:09
*** kjnelson has left #openstack-cinder21:12
*** primechuck has quit IRC21:18
*** dannywilson has quit IRC21:19
*** markvoelker has quit IRC21:19
*** Longgeek has joined #openstack-cinder21:22
*** harlowja has quit IRC21:23
*** openstack has joined #openstack-cinder21:25
tbarronskylerberg: I think we're all trying to figure this out and will sync up at the next weekly cinder meeting21:25
jgriffithmriedem: thanks for putting that on the agenda21:26
tbarronhttps://wiki.openstack.org/wiki/CinderMeetings#Next_meeting21:26
*** Longgeek has quit IRC21:26
tbarronI know I'm going to be trying to figure what's going on with our driver in the mean time, lot's to learn.21:26
tbarronmriedem's patch is doing the right thing, we just need to figure out collectively how to adapt21:27
skylerbergtbarron: Thanks. I will be keeping an eye on what gets decided.21:27
tbarronmost of our drivers weren't (just my opinion) that aware of the possibility of encrypted volumes21:27
tbarronso this is a good thing21:28
*** markvoelker has joined #openstack-cinder21:28
*** jungleboyj has quit IRC21:30
*** markvoelker has quit IRC21:30
*** IlyaG has joined #openstack-cinder21:31
*** earlephilhower has joined #openstack-cinder21:34
*** DericHorn-HP has quit IRC21:34
*** harlowja has joined #openstack-cinder21:35
*** hemna has joined #openstack-cinder21:38
*** annegentle has quit IRC21:39
*** annegentle has joined #openstack-cinder21:40
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/19510521:48
*** rwsu has quit IRC21:56
openstackgerritOpenStack Proposal Bot proposed openstack/os-brick: Updated from global requirements  https://review.openstack.org/19399622:00
*** hemna_ has joined #openstack-cinder22:01
*** MentalRay has quit IRC22:02
*** hemna has quit IRC22:02
*** patrickeast has quit IRC22:03
*** patrickeast has joined #openstack-cinder22:04
*** haypo has quit IRC22:05
*** edmondsw has quit IRC22:08
*** edmondsw has joined #openstack-cinder22:08
*** edmondsw has quit IRC22:08
*** earlephilhower has quit IRC22:16
*** setmason has quit IRC22:17
*** DericHorn-HP has joined #openstack-cinder22:18
*** DericHorn-HP has quit IRC22:19
*** annashen has quit IRC22:22
*** annashen has joined #openstack-cinder22:22
*** IlyaG has quit IRC22:30
*** annashen has quit IRC22:39
*** DericHorn-HP has joined #openstack-cinder22:40
*** annegentle has quit IRC22:41
*** annashen has joined #openstack-cinder22:50
*** annegentle has joined #openstack-cinder23:01
*** lcurtis has quit IRC23:12
*** rmesta has quit IRC23:13
*** rmesta has joined #openstack-cinder23:13
*** rmesta has quit IRC23:14
*** annashen has quit IRC23:14
*** rmesta has joined #openstack-cinder23:14
*** rmesta has quit IRC23:14
*** ekarlso has quit IRC23:18
*** ekarlso has joined #openstack-cinder23:18
*** annegentle has quit IRC23:19
*** Longgeek has joined #openstack-cinder23:22
*** annashen has joined #openstack-cinder23:26
*** _cjones_ has quit IRC23:27
*** DericHorn-HP has quit IRC23:27
*** annashen has quit IRC23:31
*** skylerberg has quit IRC23:33
*** angela-s has quit IRC23:36
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick: update os-brick to pass python3 tests  https://review.openstack.org/19628423:43
*** Longgeek has quit IRC23:44

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!