*** alexpilotti has quit IRC | 00:00 | |
*** chlong has joined #openstack-cinder | 00:00 | |
*** harlowja_at_home has quit IRC | 00:05 | |
*** merooney has quit IRC | 00:26 | |
*** Apoorva has joined #openstack-cinder | 00:26 | |
*** Apoorva has quit IRC | 00:31 | |
*** heyun has joined #openstack-cinder | 00:33 | |
*** r-daneel has joined #openstack-cinder | 00:38 | |
*** laughterwym has joined #openstack-cinder | 00:43 | |
*** r-daneel has quit IRC | 00:44 | |
*** salv-orlando has joined #openstack-cinder | 00:45 | |
*** salv-orl_ has joined #openstack-cinder | 00:49 | |
*** salv-orlando has quit IRC | 00:50 | |
*** salv-orl_ has quit IRC | 00:54 | |
*** dims has joined #openstack-cinder | 00:58 | |
*** lixiaoy1 has joined #openstack-cinder | 01:04 | |
*** annashen has joined #openstack-cinder | 01:11 | |
*** ericksonsantos has quit IRC | 01:11 | |
*** harlowja_at_home has joined #openstack-cinder | 01:12 | |
*** lixiaoy11 has joined #openstack-cinder | 01:15 | |
*** ericksonsantos has joined #openstack-cinder | 01:15 | |
*** lixiaoy1 has quit IRC | 01:17 | |
*** lixiaoy1 has joined #openstack-cinder | 01:18 | |
openstackgerrit | xing-yang proposed openstack/cinder: Clone CG https://review.openstack.org/203473 | 01:20 |
---|---|---|
*** lixiaoy11 has quit IRC | 01:21 | |
*** jasondotstar has joined #openstack-cinder | 01:26 | |
*** harlowja_at_home has quit IRC | 01:26 | |
openstackgerrit | Dave Chen proposed openstack/python-cinderclient: Add commands for modifying image metadata https://review.openstack.org/147077 | 01:28 |
*** davechen has joined #openstack-cinder | 01:31 | |
*** laughterwym_ has joined #openstack-cinder | 01:32 | |
*** laughterwym has quit IRC | 01:35 | |
*** Lee1092 has joined #openstack-cinder | 01:37 | |
openstackgerrit | Raunak Kumar proposed openstack/cinder: Add extra spec capability for Nimble Cinder Driver https://review.openstack.org/198853 | 01:49 |
openstackgerrit | wanghao proposed openstack/cinder: Add pagination to backups https://review.openstack.org/204493 | 01:51 |
*** salv-orlando has joined #openstack-cinder | 01:53 | |
*** daneyon has joined #openstack-cinder | 01:54 | |
*** daneyon has quit IRC | 01:59 | |
*** salv-orl_ has joined #openstack-cinder | 02:01 | |
openstackgerrit | wanghao proposed openstack/cinder: Implement function to manage/unmanage snapshots https://review.openstack.org/144590 | 02:03 |
*** salv-orlando has quit IRC | 02:03 | |
*** salv-orl_ has quit IRC | 02:06 | |
*** smoriya has joined #openstack-cinder | 02:07 | |
*** zhenguo has joined #openstack-cinder | 02:07 | |
openstackgerrit | wanghao proposed openstack/cinder: Support volume backup of qcow2 format volume https://review.openstack.org/182276 | 02:20 |
openstackgerrit | wanghao proposed openstack/cinder: Incremental backup improvements for L https://review.openstack.org/188328 | 02:25 |
*** annashen has quit IRC | 02:35 | |
*** annashen has joined #openstack-cinder | 02:37 | |
*** annashen_ has joined #openstack-cinder | 02:40 | |
*** annashen_ has quit IRC | 02:41 | |
*** annashen has quit IRC | 02:42 | |
*** annashen has joined #openstack-cinder | 02:42 | |
*** annashen has quit IRC | 02:45 | |
*** annashen has joined #openstack-cinder | 02:46 | |
*** zhonghua-lee has joined #openstack-cinder | 02:49 | |
*** annashen has quit IRC | 02:50 | |
*** annashen has joined #openstack-cinder | 02:50 | |
*** hakimo has joined #openstack-cinder | 02:52 | |
*** hakimo_ has quit IRC | 02:54 | |
*** markvoelker has joined #openstack-cinder | 02:58 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Adds framework for get_capabilities() feature https://review.openstack.org/201243 | 02:58 |
*** Liu has joined #openstack-cinder | 02:58 | |
openstackgerrit | xiaoqin proposed openstack/cinder: Port StorwizeSVCDriver to use ABCMeta driver model https://review.openstack.org/205475 | 02:59 |
*** dims has quit IRC | 02:59 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add iSCSI multipath support for Huawei driver https://review.openstack.org/188365 | 03:02 |
*** markvoelker has quit IRC | 03:02 | |
*** kcaj has quit IRC | 03:07 | |
*** salv-orlando has joined #openstack-cinder | 03:08 | |
*** annashen has quit IRC | 03:09 | |
*** smoriya has quit IRC | 03:12 | |
*** annashen has joined #openstack-cinder | 03:12 | |
*** salv-orlando has quit IRC | 03:12 | |
*** salv-orlando has joined #openstack-cinder | 03:13 | |
*** kcaj has joined #openstack-cinder | 03:14 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Efficient volume copy for generic volume migration https://review.openstack.org/183701 | 03:16 |
*** salv-orlando has quit IRC | 03:17 | |
*** changbl has quit IRC | 03:19 | |
*** jasondotstar has quit IRC | 03:20 | |
*** smoriya has joined #openstack-cinder | 03:22 | |
*** nzrf has left #openstack-cinder | 03:26 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Volume status management during migration https://review.openstack.org/186312 | 03:27 |
openstackgerrit | Vincent Hou proposed openstack/cinder: Volume status management during migration https://review.openstack.org/186312 | 03:29 |
*** Apoorva has joined #openstack-cinder | 03:29 | |
*** harlowja_at_home has joined #openstack-cinder | 03:29 | |
*** coolsvap|away is now known as coolsvap | 03:30 | |
*** changbl has joined #openstack-cinder | 03:32 | |
*** Apoorva has quit IRC | 03:33 | |
*** daneyon has joined #openstack-cinder | 03:43 | |
*** zhonghua-li has joined #openstack-cinder | 03:43 | |
openstackgerrit | YuanHui Xu proposed openstack/cinder: Add mock cases for IBM FlashSystem https://review.openstack.org/205371 | 03:45 |
*** zhonghua-lee has quit IRC | 03:46 | |
*** daneyon has quit IRC | 03:48 | |
*** annashen has quit IRC | 03:48 | |
*** annashen has joined #openstack-cinder | 03:48 | |
*** zul has quit IRC | 03:52 | |
openstackgerrit | Edwin Wang proposed openstack/cinder: Test for dependency https://review.openstack.org/205889 | 03:53 |
*** zul has joined #openstack-cinder | 03:53 | |
openstackgerrit | xing-yang proposed openstack/cinder: Clone CG https://review.openstack.org/203473 | 03:53 |
*** dims has joined #openstack-cinder | 04:00 | |
*** haomaiwang has quit IRC | 04:02 | |
*** haomaiwang has joined #openstack-cinder | 04:04 | |
*** dims has quit IRC | 04:06 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add multiple pools support to VMAX driver https://review.openstack.org/189990 | 04:10 |
*** annashen has quit IRC | 04:16 | |
*** annashen has joined #openstack-cinder | 04:16 | |
*** annashen has quit IRC | 04:19 | |
*** daneyon has joined #openstack-cinder | 04:20 | |
openstackgerrit | xing-yang proposed openstack/cinder: EMC VMAX Create CG from CG Snapshot https://review.openstack.org/195280 | 04:21 |
*** daneyon_ has joined #openstack-cinder | 04:22 | |
*** daneyon has quit IRC | 04:22 | |
*** daneyon_ has quit IRC | 04:23 | |
openstackgerrit | wanghao proposed openstack/cinder: Refactoring of manager's manage_existing flow https://review.openstack.org/205896 | 04:25 |
*** DericHorn-HP has joined #openstack-cinder | 04:26 | |
*** zhonghua-li has quit IRC | 04:26 | |
openstackgerrit | YuanHui Xu proposed openstack/cinder: Add mock cases for IBM FlashSystem https://review.openstack.org/205371 | 04:28 |
*** annashen has joined #openstack-cinder | 04:28 | |
openstackgerrit | xing-yang proposed openstack/python-cinderclient: CLI: Clone CG https://review.openstack.org/205897 | 04:29 |
*** annashen has quit IRC | 04:35 | |
*** zhonghua-li has joined #openstack-cinder | 04:35 | |
*** krypton has joined #openstack-cinder | 04:40 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Adds the migration progress support for migration https://review.openstack.org/204953 | 04:46 |
*** markvoelker has joined #openstack-cinder | 04:58 | |
*** salv-orlando has joined #openstack-cinder | 05:01 | |
*** Zhongjun has joined #openstack-cinder | 05:02 | |
*** markvoelker has quit IRC | 05:03 | |
*** salv-orl_ has joined #openstack-cinder | 05:03 | |
*** salv-orlando has quit IRC | 05:05 | |
openstackgerrit | Andrey Pavlov proposed openstack/cinder: Fix doc string definitions https://review.openstack.org/193124 | 05:07 |
*** ub has quit IRC | 05:09 | |
*** salv-orl_ has quit IRC | 05:11 | |
*** salv-orlando has joined #openstack-cinder | 05:12 | |
thingee | winston-d: ping | 05:13 |
*** pradipta has joined #openstack-cinder | 05:13 | |
*** salv-orlando has quit IRC | 05:16 | |
*** salv-orlando has joined #openstack-cinder | 05:19 | |
*** lixiaoy1 has quit IRC | 05:23 | |
*** avishay has joined #openstack-cinder | 05:24 | |
*** lixiaoy1 has joined #openstack-cinder | 05:24 | |
*** Apoorva has joined #openstack-cinder | 05:26 | |
*** vlaza has joined #openstack-cinder | 05:33 | |
*** BharatK has joined #openstack-cinder | 05:33 | |
*** lpetrut has joined #openstack-cinder | 05:34 | |
*** DericHorn-HP has quit IRC | 05:35 | |
*** annashen has joined #openstack-cinder | 05:35 | |
*** annashen has quit IRC | 05:40 | |
*** ankit_ag has joined #openstack-cinder | 05:44 | |
*** deepakcs has joined #openstack-cinder | 05:47 | |
*** krypton has quit IRC | 05:50 | |
*** nkrinner has joined #openstack-cinder | 05:50 | |
*** krypton has joined #openstack-cinder | 05:51 | |
*** avishay has quit IRC | 05:52 | |
*** avishay_ has joined #openstack-cinder | 05:52 | |
*** krypton_ has joined #openstack-cinder | 05:56 | |
*** krypton has quit IRC | 05:59 | |
*** jwcroppe has joined #openstack-cinder | 06:00 | |
*** fifieldt has joined #openstack-cinder | 06:00 | |
*** krypton_ has quit IRC | 06:01 | |
*** dims has joined #openstack-cinder | 06:03 | |
openstackgerrit | Mike Perez proposed openstack/cinder: Remove deprecated SimpleScheduler https://review.openstack.org/205911 | 06:04 |
*** Apoorva has quit IRC | 06:04 | |
*** harlowja_at_home has quit IRC | 06:04 | |
*** agarciam has joined #openstack-cinder | 06:07 | |
*** dims has quit IRC | 06:09 | |
*** zhonghua-li has quit IRC | 06:09 | |
*** markus_z has joined #openstack-cinder | 06:10 | |
*** daneyon has joined #openstack-cinder | 06:12 | |
openstackgerrit | Mike Perez proposed openstack/cinder-specs: Updating Get Volume Driver Capabilities Spec https://review.openstack.org/183947 | 06:13 |
*** annashen has joined #openstack-cinder | 06:14 | |
openstackgerrit | Abhijeet Malawade proposed openstack/cinder: Remove unused context parameter https://review.openstack.org/185861 | 06:15 |
*** daneyon has quit IRC | 06:17 | |
*** markus_z has quit IRC | 06:17 | |
*** vilobhmm has joined #openstack-cinder | 06:19 | |
*** annashen has quit IRC | 06:23 | |
thingee | davechen: ping | 06:26 |
*** alexpilotti has joined #openstack-cinder | 06:26 | |
*** lan has quit IRC | 06:27 | |
*** annashen has joined #openstack-cinder | 06:29 | |
thingee | davechen: commented on https://review.openstack.org/#/c/147077/13 ... just curious how one would see their volume glance metdata. | 06:29 |
thingee | davechen: obvious I could just look in the db, but there appears to be other cinderclient commands to see metadata, so maybe we need one for this as well? | 06:30 |
*** vilobhmm1 has joined #openstack-cinder | 06:30 | |
*** annashen has quit IRC | 06:31 | |
*** vilobhmm has quit IRC | 06:33 | |
*** ub has joined #openstack-cinder | 06:33 | |
*** annashen has joined #openstack-cinder | 06:33 | |
*** sgotliv_ has quit IRC | 06:33 | |
thingee | jgriffith: by chance would you be able to push an update of https://review.openstack.org/#/c/155644/5 this week, so we can push that along for ya based on consensus in the last meeting of auto-failover not being necessary this time around? | 06:39 |
*** annashen has quit IRC | 06:39 | |
*** krypton has joined #openstack-cinder | 06:40 | |
*** vilobhmm1 has quit IRC | 06:43 | |
*** avishay_ has quit IRC | 06:44 | |
*** avishay__ has joined #openstack-cinder | 06:44 | |
*** annashen has joined #openstack-cinder | 06:46 | |
*** annashen has quit IRC | 06:49 | |
*** annashen has joined #openstack-cinder | 06:51 | |
*** rushiagr_away is now known as rushiagr | 06:53 | |
*** annashen has quit IRC | 06:53 | |
*** vilobhmm has joined #openstack-cinder | 06:59 | |
*** markvoelker has joined #openstack-cinder | 06:59 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Set virtual disk UUID to volume ID https://review.openstack.org/205494 | 07:03 |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Add volume ID in vCenter's volume config https://review.openstack.org/194534 | 07:03 |
*** krypton has quit IRC | 07:03 | |
*** krypton has joined #openstack-cinder | 07:04 | |
*** markvoelker has quit IRC | 07:04 | |
*** lpetrut has quit IRC | 07:09 | |
*** markus_z has joined #openstack-cinder | 07:11 | |
*** ronis has joined #openstack-cinder | 07:13 | |
*** lpetrut has joined #openstack-cinder | 07:16 | |
*** LiuXinguo has joined #openstack-cinder | 07:23 | |
*** Liu has quit IRC | 07:26 | |
*** zhonghua-li has joined #openstack-cinder | 07:28 | |
*** chlong has quit IRC | 07:28 | |
*** jwcroppe has quit IRC | 07:30 | |
*** jwcroppe has joined #openstack-cinder | 07:31 | |
*** vilobhmm has quit IRC | 07:38 | |
*** salv-orlando has quit IRC | 07:39 | |
*** fifieldt has quit IRC | 07:42 | |
*** zhonghua-li has quit IRC | 07:43 | |
*** zhonghua-lee has joined #openstack-cinder | 07:43 | |
*** jistr has joined #openstack-cinder | 07:44 | |
*** salv-orlando has joined #openstack-cinder | 07:45 | |
*** bluex-pl has joined #openstack-cinder | 07:47 | |
*** bluex-pl has quit IRC | 07:48 | |
*** bluex-pl has joined #openstack-cinder | 07:48 | |
*** bluex-pl has quit IRC | 07:49 | |
*** chenying has joined #openstack-cinder | 07:49 | |
*** bluex-pl has joined #openstack-cinder | 07:49 | |
*** chenying has quit IRC | 07:49 | |
*** lpetrut has quit IRC | 07:53 | |
*** daneyon has joined #openstack-cinder | 08:01 | |
*** jwcroppe has quit IRC | 08:01 | |
*** jwcroppe has joined #openstack-cinder | 08:02 | |
*** vincent_hou has joined #openstack-cinder | 08:02 | |
*** daneyon has quit IRC | 08:06 | |
*** jwcroppe has quit IRC | 08:06 | |
*** dtadrzak_ has quit IRC | 08:06 | |
*** aarefiev has joined #openstack-cinder | 08:07 | |
*** ndipanov has joined #openstack-cinder | 08:08 | |
*** git-harry_ is now known as git-harry | 08:09 | |
*** sgotliv has joined #openstack-cinder | 08:09 | |
*** Zhongjun has quit IRC | 08:12 | |
*** jwcroppe has joined #openstack-cinder | 08:15 | |
*** coolsvap is now known as coolsvap|away | 08:21 | |
openstackgerrit | Lei Zhang proposed openstack/cinder: Make concurrent backups for same volume impossible https://review.openstack.org/202914 | 08:28 |
*** coolsvap|away is now known as coolsvap | 08:29 | |
*** coolsvap is now known as coolsvap|away | 08:31 | |
*** aix has joined #openstack-cinder | 08:31 | |
*** e0ne has joined #openstack-cinder | 08:32 | |
*** gaurangt has joined #openstack-cinder | 08:35 | |
*** annashen has joined #openstack-cinder | 08:38 | |
*** laughterwym_ has quit IRC | 08:38 | |
davechen | thingee: sorry, Mike, just notice your message. | 08:39 |
davechen | thingee: are you still around? | 08:39 |
openstackgerrit | Avishay Traeger proposed openstack/os-brick: Fix race in check and access of /dev/disk/by-path/ https://review.openstack.org/205945 | 08:39 |
*** lpetrut has joined #openstack-cinder | 08:43 | |
*** coolsvap|away is now known as coolsvap | 08:43 | |
*** dalgaaf has joined #openstack-cinder | 08:45 | |
davechen | thingee: I will reply to you on that patch, thanks! | 08:46 |
openstackgerrit | Gaurang Tapase proposed openstack/cinder: Adding NFS support to the GPFS Driver https://review.openstack.org/197884 | 08:53 |
*** subscope has joined #openstack-cinder | 08:55 | |
*** vincent_hou has quit IRC | 08:57 | |
*** markvoelker has joined #openstack-cinder | 09:00 | |
*** markvoelker has quit IRC | 09:05 | |
openstackgerrit | Abhijeet Malawade proposed openstack/cinder: Remove unused context parameter https://review.openstack.org/185861 | 09:06 |
*** dims has joined #openstack-cinder | 09:06 | |
*** dims has quit IRC | 09:11 | |
*** annashen has quit IRC | 09:18 | |
*** lpetrut has quit IRC | 09:26 | |
*** lpetrut has joined #openstack-cinder | 09:27 | |
*** afazekas has joined #openstack-cinder | 09:28 | |
*** laughterwym has joined #openstack-cinder | 09:28 | |
*** jordanP has joined #openstack-cinder | 09:32 | |
*** jasondotstar has joined #openstack-cinder | 09:32 | |
*** kodoku has joined #openstack-cinder | 09:49 | |
*** daneyon has joined #openstack-cinder | 09:50 | |
kodoku | Hi, I upgraded juno to kilo but I have issue when I manage old volumes (created on JUNO) ==> http://paste.openstack.org/show/405892/ | 09:50 |
kodoku | VolumeBackendAPIException: Bad or unexpected response from the storage volume backend API: Unable to fetch connection information from backend: 'NoneType' object has no attribute 'service_content' | 09:50 |
*** lixiaoy1 has quit IRC | 09:51 | |
*** jwcroppe has quit IRC | 09:54 | |
*** davechen has left #openstack-cinder | 09:54 | |
*** kodoku has quit IRC | 09:55 | |
*** daneyon has quit IRC | 09:55 | |
*** jwcroppe has joined #openstack-cinder | 09:56 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 09:59 |
deepakcs | jordanP: u r not on nova channel ? :) | 09:59 |
openstackgerrit | liuxinguo proposed openstack/cinder: Enhance FC zone support for Huawei driver https://review.openstack.org/201578 | 10:02 |
*** dims has joined #openstack-cinder | 10:04 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add iSCSI multipath support for Huawei driver https://review.openstack.org/188365 | 10:04 |
openstackgerrit | liuxinguo proposed openstack/cinder: Add smartX support for Huawei driver https://review.openstack.org/188732 | 10:06 |
*** dims_ has joined #openstack-cinder | 10:06 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add volume migration support for Huawei driver https://review.openstack.org/201406 | 10:08 |
BharatK | DuncanT, Please review the patch https://review.openstack.org/#/c/163647/, (Modified as per the comments) | 10:09 |
*** dims has quit IRC | 10:10 | |
LiuXinguo | e0ne: I saw you leave a -1 on patch https://review.openstack.org/#/c/188732/ | 10:13 |
LiuXinguo | e0ne: But I can't see any comments outside the patch or inline | 10:14 |
e0ne | LiuXinguo: i posted my commenst with vote in the same time as you did a new patch | 10:15 |
LiuXinguo | e0ne: :) | 10:15 |
LiuXinguo | e0ne: I guessed that | 10:15 |
*** smoriya has quit IRC | 10:15 | |
e0ne | LiuXinguo: that's why gerrit leave -1 and marked my comments as draft for the previous patch:( | 10:16 |
LiuXinguo | e0ne: Maybe it's a bug, haha | 10:16 |
openstackgerrit | Daniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object https://review.openstack.org/163641 | 10:18 |
LiuXinguo | e0ne: So you need to submit the comments again? | 10:18 |
e0ne | LiuXinguo: done | 10:18 |
e0ne | LiuXinguo: thanks for pinging me for it | 10:19 |
LiuXinguo | e0ne: No pro | 10:19 |
*** Lee1092_ has joined #openstack-cinder | 10:20 | |
LiuXinguo | e0ne: Thanks for you review, I will address your comments as soon as possible | 10:20 |
e0ne | LiuXinguo: you're welcome! do not hesitate to ping if my help is needed | 10:20 |
*** cppforlife__ has joined #openstack-cinder | 10:21 | |
LiuXinguo | e0ne: That's great | 10:21 |
LiuXinguo | e0ne: thanks e0ne! | 10:21 |
*** Lee1092 has quit IRC | 10:21 | |
*** cppforlife_ has quit IRC | 10:21 | |
*** dobson` has quit IRC | 10:21 | |
*** albertom has quit IRC | 10:21 | |
*** rushiagr has quit IRC | 10:21 | |
*** git-harry has quit IRC | 10:21 | |
*** smcginnis has quit IRC | 10:21 | |
*** smcginni1 has joined #openstack-cinder | 10:22 | |
*** powerbsd has joined #openstack-cinder | 10:22 | |
*** Lee1092_ is now known as Lee1092 | 10:22 | |
*** powerbsd is now known as albertom | 10:22 | |
*** cppforlife__ is now known as cppforlife_ | 10:22 | |
*** salv-orlando has quit IRC | 10:24 | |
*** dobson has joined #openstack-cinder | 10:25 | |
*** heyun has quit IRC | 10:29 | |
*** coolsvap is now known as coolsvap|away | 10:35 | |
*** gaurangt1 has joined #openstack-cinder | 10:37 | |
*** gaurangt has quit IRC | 10:38 | |
*** gaurangt1 has left #openstack-cinder | 10:39 | |
*** gaurangt1 has joined #openstack-cinder | 10:39 | |
*** git-harry has joined #openstack-cinder | 10:40 | |
*** zhonghua-lee has quit IRC | 10:42 | |
DuncanT | BharatK: looking now | 10:45 |
BharatK | DuncanT, Thank you very much. | 10:45 |
DuncanT | BharatK: +2, but can you have a look at the sheepdog CI failure please? It seems to be the only one that is backup related | 10:50 |
BharatK | Thanks DuncanT, | 10:53 |
BharatK | DuncanT, Backup testcases in sheepdog are failing for every patch set. | 10:53 |
DuncanT | BharatK: Ok, thanks for checking | 10:53 |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Set virtual disk UUID to volume ID https://review.openstack.org/205494 | 10:54 |
BharatK | DuncanT, Thanks once again. | 10:54 |
*** DTadrzak has joined #openstack-cinder | 10:55 | |
*** markvoelker has joined #openstack-cinder | 11:01 | |
*** zhonghua-lee has joined #openstack-cinder | 11:03 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Set virtual disk UUID to volume ID https://review.openstack.org/205494 | 11:04 |
*** markvoelker has quit IRC | 11:05 | |
*** avishay__ has quit IRC | 11:08 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add smartX support for Huawei driver https://review.openstack.org/188732 | 11:11 |
*** avishay__ has joined #openstack-cinder | 11:11 | |
*** pradipta has quit IRC | 11:12 | |
LiuXinguo | e0ne: Have addressed all of your comments, please check again | 11:15 |
LiuXinguo | e0ne: just when you have timek, thanks! | 11:15 |
e0ne | LiuXinguo: thanks. will look on it a bit later | 11:15 |
LiuXinguo | e0ne: thanks! | 11:15 |
openstackgerrit | liuxinguo proposed openstack/cinder: Add volume migration support for Huawei driver https://review.openstack.org/201406 | 11:16 |
*** ganso_ has joined #openstack-cinder | 11:21 | |
*** simondodsley has joined #openstack-cinder | 11:24 | |
*** salv-orlando has joined #openstack-cinder | 11:26 | |
*** jwcroppe_ has joined #openstack-cinder | 11:30 | |
*** salv-orlando has quit IRC | 11:30 | |
*** marzif has joined #openstack-cinder | 11:31 | |
*** salv-orlando has joined #openstack-cinder | 11:32 | |
*** jwcroppe has quit IRC | 11:33 | |
*** markus_z has quit IRC | 11:35 | |
*** daneyon has joined #openstack-cinder | 11:39 | |
*** avishay__ has quit IRC | 11:40 | |
*** avishay__ has joined #openstack-cinder | 11:40 | |
*** daneyon has quit IRC | 11:44 | |
*** jwcroppe_ has quit IRC | 11:46 | |
*** deepakcs has quit IRC | 11:46 | |
*** markus_z has joined #openstack-cinder | 11:48 | |
*** avishay__ has quit IRC | 11:50 | |
*** gaurangt1 has left #openstack-cinder | 11:50 | |
*** davechen has joined #openstack-cinder | 11:51 | |
davechen | thingee: Just replied to you on that patch (https://review.openstack.org/#/c/147077/), pls kindly let me know if there is anything more needed. | 11:52 |
*** avishay__ has joined #openstack-cinder | 11:53 | |
davechen | thingee: I need to logoff and have supper, thanks! | 11:54 |
*** zhonghua-lee has quit IRC | 11:54 | |
*** davechen is now known as davechen_afk | 11:54 | |
*** BharatK has quit IRC | 11:57 | |
*** salv-orlando has quit IRC | 11:58 | |
openstackgerrit | zhongjun proposed openstack/cinder: Add volume retype support for Huawei driver https://review.openstack.org/201485 | 12:00 |
*** avishay__ has quit IRC | 12:00 | |
*** shyama has joined #openstack-cinder | 12:01 | |
*** marcusvrn has joined #openstack-cinder | 12:02 | |
*** zhenguo has quit IRC | 12:02 | |
*** thangp has joined #openstack-cinder | 12:06 | |
*** jasondotstar has quit IRC | 12:10 | |
*** bswartz has quit IRC | 12:13 | |
openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 12:18 |
*** annashen has joined #openstack-cinder | 12:19 | |
*** nzrf has joined #openstack-cinder | 12:19 | |
DuncanT | e0ne: You beat me to the db scaling comments on https://review.openstack.org/#/c/188328/ - I was busy spinning up devstack to check I was correct before making the comments | 12:23 |
*** annashen has quit IRC | 12:23 | |
DuncanT | e0ne: Good spot | 12:23 |
e0ne | DuncanT: thanks | 12:25 |
openstackgerrit | wanghao proposed openstack/cinder: Add pagination to backups https://review.openstack.org/204493 | 12:26 |
e0ne | DuncanT: i didn't test it, so i asked to get some performance results | 12:26 |
DuncanT | e0ne: I'm trying to write a large-ops CI job, so I had some scripts to generate fake backups handy. | 12:27 |
openstackgerrit | Thang Pham proposed openstack/cinder: Create service_versions table https://review.openstack.org/205622 | 12:27 |
e0ne | DuncanT: i didn't test cinder well with large numbers ob backups, but we've found several issues when we've got >30k volumes and snapshots in the db | 12:28 |
*** kaisers has quit IRC | 12:28 | |
*** avishay__ has joined #openstack-cinder | 12:28 | |
DuncanT | e0ne: There have been quite a few fixed over the last 2 years, usually resulting from the same pattern (build a list then query the db for every item on the list before returning) - I try to keep an eye out for new ones but no doubt miss some | 12:30 |
*** edmondsw has joined #openstack-cinder | 12:30 | |
*** timcl has joined #openstack-cinder | 12:30 | |
DuncanT | e0ne: Have you root-caused any of the issues you found to see if there's any other base issues? | 12:30 |
*** chlong has joined #openstack-cinder | 12:30 | |
e0ne | DuncanT: not yet:(. i hope to have time for it after L-3 will be released | 12:31 |
*** jasondotstar has joined #openstack-cinder | 12:32 | |
DuncanT | e0ne: I'll carry on my slow progress too, and ping you if I find anything | 12:32 |
*** rushiagr_away has joined #openstack-cinder | 12:33 | |
DuncanT | e0ne: I should be able to automate issue detection to some degree - insert 1000+ dummy records into the db for each entity type (vol, snap, cg, bak, etc) and call all of the list interfaces - any call that causes 1000+ db queries is broken | 12:33 |
e0ne | DuncanT: thanks. we've got a reported bug for our distro https://bugs.launchpad.net/mos/+bug/1471273. i'll ask to check it with devstack too | 12:34 |
openstack | Launchpad bug 1471273 in Mirantis OpenStack 6.0-updates " 'cinder list' ERROR: Gateway Timeout (HTTP 504) when we have more than 50k volumes" [High,Confirmed] - Assigned to MOS Sustaining (mos-sustaining) | 12:34 |
e0ne | DuncanT: we tested cinder with fake driver | 12:34 |
DuncanT | e0ne: I configure the fake driver, but just inserting into the db is much quicker... should give me something I can sensibly run on every commit. Need a fake backup driver to do that with backups, plus the fake driver needs some fixup for cgs etc | 12:35 |
DuncanT | e0ne: Actually, I might go write a fake backup driver, shouldn't be hard... assuming we don't already have one | 12:36 |
e0ne | DuncanT: you're right. but with fake driver we could also see to create something works when we've got a lot of data in the DB | 12:37 |
*** eharney has quit IRC | 12:37 | |
DuncanT | e0ne: Yeah, definitely. Maybe insert a bunch of fake data then call create a few times? | 12:38 |
e0ne | DuncanT: sound like a good idea:). i like it | 12:38 |
*** kodoku has joined #openstack-cinder | 12:43 | |
*** kaisers has joined #openstack-cinder | 12:43 | |
*** zhonghua-lee has joined #openstack-cinder | 12:44 | |
openstackgerrit | wanghao proposed openstack/cinder: Support volume backup of qcow2 format volume https://review.openstack.org/182276 | 12:45 |
kodoku | Hi, I upgraded juno to kilo but I have issue when I manage old volumes (created on JUNO) ==> http://paste.openstack.org/show/405892/ | 12:45 |
kodoku | Maybe somebody can help me ? | 12:47 |
*** kaisers has quit IRC | 12:50 | |
*** kaisers1 has joined #openstack-cinder | 12:50 | |
*** kjnelson has joined #openstack-cinder | 12:52 | |
*** bswartz has joined #openstack-cinder | 12:53 | |
*** annegentle has joined #openstack-cinder | 12:54 | |
*** akerr has joined #openstack-cinder | 12:56 | |
*** markus_z has quit IRC | 12:59 | |
*** kaisers1 has quit IRC | 13:00 | |
DuncanT | kodoku: It looks like that's an error within the VMWare driver itself | 13:01 |
*** merooney has joined #openstack-cinder | 13:01 | |
*** zhenguo has joined #openstack-cinder | 13:01 | |
*** cbader has joined #openstack-cinder | 13:02 | |
*** markus_z has joined #openstack-cinder | 13:03 | |
*** rushiagr_away is now known as rushiagr | 13:03 | |
DuncanT | kodoku: I've never looked at that driver, but I'll see if I can spot a possible cause | 13:03 |
*** julim has joined #openstack-cinder | 13:05 | |
kodoku | DuncanT hum do you think it's like this bug ==> https://bugs.launchpad.net/cinder/+bug/1380675 | 13:07 |
openstack | Launchpad bug 1380675 in VMwareAPI-Team "VMware: retype fails with AttributeError 'NoneType' object has no attribute 'service_content'" [Undecided,New] | 13:07 |
*** edmondsw has quit IRC | 13:08 | |
*** diogogmt has quit IRC | 13:09 | |
*** annegentle has quit IRC | 13:10 | |
*** annegentle has joined #openstack-cinder | 13:11 | |
*** diogogmt has joined #openstack-cinder | 13:11 | |
*** diogogmt has quit IRC | 13:15 | |
openstackgerrit | Thang Pham proposed openstack/cinder: Create service_versions table https://review.openstack.org/205622 | 13:15 |
*** akshai has joined #openstack-cinder | 13:16 | |
DuncanT | kodoku: Doesn't look like it is that exact bug, but it could well be related | 13:17 |
DuncanT | kodoku: I've not got a vmware system to poke around I'm afraid, so I can't dig any deeper | 13:17 |
*** eharney has joined #openstack-cinder | 13:22 | |
*** kaisers has joined #openstack-cinder | 13:23 | |
*** daneyon has joined #openstack-cinder | 13:28 | |
*** daneyon has quit IRC | 13:32 | |
*** markvoelker has joined #openstack-cinder | 13:34 | |
*** gaurangt has joined #openstack-cinder | 13:37 | |
*** annegent_ has joined #openstack-cinder | 13:38 | |
*** Yogi1 has joined #openstack-cinder | 13:40 | |
*** annegentle has quit IRC | 13:41 | |
*** chlong has quit IRC | 13:42 | |
*** jungleboyj has quit IRC | 13:44 | |
*** alexpilotti has quit IRC | 13:46 | |
*** coolsvap|away is now known as coolsvap | 13:47 | |
*** jasondotstar has quit IRC | 13:48 | |
e0ne | thingee: fyi, we'll have rally meeting in 10 minutes | 13:50 |
*** jistr has quit IRC | 13:52 | |
*** jistr has joined #openstack-cinder | 13:54 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/205651 | 13:54 |
*** julim_ has joined #openstack-cinder | 13:57 | |
*** edmondsw has joined #openstack-cinder | 13:57 | |
*** thangp_ has joined #openstack-cinder | 13:57 | |
*** julim has quit IRC | 14:00 | |
*** mylu has joined #openstack-cinder | 14:00 | |
*** Guest10__ has joined #openstack-cinder | 14:01 | |
*** thangp has quit IRC | 14:01 | |
*** boris-42 has joined #openstack-cinder | 14:02 | |
*** jungleboyj has joined #openstack-cinder | 14:03 | |
*** zhonghua-lee has quit IRC | 14:05 | |
*** erlon has joined #openstack-cinder | 14:08 | |
*** xyang has joined #openstack-cinder | 14:13 | |
*** davechen_afk has left #openstack-cinder | 14:13 | |
erlon | tbarron: ping | 14:13 |
tbarron | erlon: wazzup? | 14:14 |
erlon | tbarron: hey, Tom, can you have a look on that patch when you have a change? | 14:14 |
erlon | tbarron: https://review.openstack.org/#/c/203780/ | 14:15 |
erlon | tbarron: I have implemented you suggestion, with the @retry | 14:15 |
erlon | tbarron: its much cleaner! :) | 14:15 |
erlon | tbarron: thanks! | 14:15 |
*** Yogi1 has quit IRC | 14:16 | |
tbarron | erlon: will look in a half hour or so (meeting). I like that retry decorator too. | 14:16 |
*** ankit_ag has quit IRC | 14:18 | |
openstackgerrit | Matthew Edmonds proposed openstack/cinder: move oslo.vmware to test-requirements https://review.openstack.org/203237 | 14:20 |
*** salv-orlando has joined #openstack-cinder | 14:21 | |
*** edtubill has joined #openstack-cinder | 14:23 | |
ameade | someone want to put a nail in this simple patch? https://review.openstack.org/#/c/170580/ | 14:23 |
*** mylu has quit IRC | 14:27 | |
smcginni1 | ameade: Would if I could. ;) | 14:27 |
*** smcginni1 is now known as smcginnis | 14:27 | |
*** jasondotstar has joined #openstack-cinder | 14:28 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Dell SC: Add check of current value on retype https://review.openstack.org/206091 | 14:28 |
*** mylu has joined #openstack-cinder | 14:28 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add volume migration support for Huawei driver https://review.openstack.org/201406 | 14:30 |
*** changbl has quit IRC | 14:32 | |
*** vilobhmm has joined #openstack-cinder | 14:35 | |
ameade | smcginnis: maybe if you just click that +2 extra hard? ;) | 14:35 |
*** Guest14296 is now known as dansmith | 14:35 | |
*** salv-orlando has quit IRC | 14:35 | |
ameade | that may have come off weird with the winky face >.> | 14:35 |
smcginnis | ameade: Hah! ;) | 14:36 |
jungleboyj | ameade: What are you suggesting? | 14:36 |
ameade | jungleboyj: ;) | 14:36 |
*** vilobhmm1 has joined #openstack-cinder | 14:36 | |
*** bluex-pl has quit IRC | 14:36 | |
* ameade is suggesting that jungleboyj review that patch | 14:37 | |
smcginnis | ameade: Nice one! | 14:37 |
jungleboyj | ameade: Get the big old +2 out. Ok. Got it. | 14:37 |
*** bluex-pl has joined #openstack-cinder | 14:37 | |
*** bluex-pl has quit IRC | 14:38 | |
*** merooney has quit IRC | 14:38 | |
*** bluex-pl has joined #openstack-cinder | 14:38 | |
jungleboyj | Looking. | 14:38 |
*** merooney has joined #openstack-cinder | 14:38 | |
*** vilobhmm has quit IRC | 14:39 | |
*** salv-orlando has joined #openstack-cinder | 14:44 | |
jungleboyj | ameade: You are welcome. ;-) | 14:45 |
ameade | jungleboyj: ty sir! | 14:45 |
jungleboyj | ameade: Welcome. | 14:46 |
*** r-daneel has joined #openstack-cinder | 14:46 | |
*** mtanino has joined #openstack-cinder | 14:48 | |
*** jaypipes has joined #openstack-cinder | 14:48 | |
openstackgerrit | Matthew Edmonds proposed openstack/cinder: move oslo.vmware to test-requirements https://review.openstack.org/203237 | 14:50 |
LiuXinguo | Why lots of patch not have bug link or bp link in the commit message? | 14:51 |
LiuXinguo | I am a little confused about this | 14:51 |
smcginnis | LiuXinguo: A lot of them are not bugs or major changes to cinder. Most don't need them. | 14:53 |
*** annegent_ has quit IRC | 14:54 | |
LiuXinguo | smcginnis: So I can just commit code to gerrit and needn't register a bug or bp? | 14:55 |
*** vlaza has left #openstack-cinder | 14:55 | |
smcginnis | In many cases, yes. | 14:55 |
*** Yogi1 has joined #openstack-cinder | 14:55 | |
smcginnis | LiuXinguo: If it's a legitimage bug that might affect someone where it would be useful to have a way for them to search and find the bug, then file a bug. | 14:55 |
smcginnis | LiuXinguo: If it's a change to how Cinder behaves or significant enough work that it should be tracked and made visible then file a blueprint. | 14:56 |
smcginnis | LiuXinguo: Otherwise just make a change and submit it. | 14:56 |
*** kbyrne has quit IRC | 14:56 | |
openstackgerrit | John Griffith proposed openstack/cinder: Use a single base class for the VolumeDriver https://review.openstack.org/201812 | 14:57 |
LiuXinguo | smcginnis: Thanks for your explain, smcginnis | 14:57 |
LiuXinguo | smcginnis: I've got that :) | 14:58 |
*** blinky_ghost has joined #openstack-cinder | 15:01 | |
aarefiev | jungleboyj: hi, could look at https://review.openstack.org/#/c/139071/ please , it blocks this one https://review.openstack.org/#/c/156939/ | 15:01 |
*** Swanson has joined #openstack-cinder | 15:01 | |
*** ronis has quit IRC | 15:01 | |
jungleboyj | aarefiev: Sure, can take a look. | 15:02 |
*** alexpilotti has joined #openstack-cinder | 15:02 | |
aarefiev | jungleboyj: thanks | 15:02 |
blinky_ghost | hi all, is it possible to use cinder-backup service with an attached volume to a VM? I get this error: cinder backup-create cirrosiscibackup "ERROR: Invalid volume: Volume to be backed up must be available (HTTP 400) (Request-ID: req-7e23875c-4663-4147-91e1-974375e36070)" Is this normal or a bug? Thanks | 15:03 |
*** kodoku has quit IRC | 15:03 | |
*** jdurgin1 has joined #openstack-cinder | 15:05 | |
*** gaurangt has quit IRC | 15:05 | |
*** diogogmt has joined #openstack-cinder | 15:06 | |
*** nkrinner has quit IRC | 15:09 | |
guitarzan | blinky_ghost: that's currently being worked on | 15:10 |
*** kbyrne has joined #openstack-cinder | 15:10 | |
*** crose has joined #openstack-cinder | 15:10 | |
guitarzan | blinky_ghost: right now it's not possible, no | 15:10 |
thangp_ | guitarzan: actually, it recently made it into master - https://github.com/openstack/cinder/commit/e78018bd05a51e33d5e1cd7c001ee6e5116a6370 | 15:11 |
guitarzan | thangp_: even better | 15:11 |
thangp_ | so depends on what version blinky_ghost has | 15:11 |
erlon | jungleboyj: hi Jay, can you give a look in this change again when you have a change? | 15:14 |
erlon | jungleboyj: https://review.openstack.org/#/c/203780/ | 15:14 |
*** salv-orlando has quit IRC | 15:16 | |
*** daneyon has joined #openstack-cinder | 15:16 | |
*** kmartin has joined #openstack-cinder | 15:18 | |
*** dannywilson has joined #openstack-cinder | 15:19 | |
*** eharney has quit IRC | 15:20 | |
*** dims_ has quit IRC | 15:21 | |
*** daneyon has quit IRC | 15:21 | |
*** tsekiyama has joined #openstack-cinder | 15:21 | |
*** dims has joined #openstack-cinder | 15:21 | |
*** aix has quit IRC | 15:22 | |
jungleboyj | erlon: Can try. :-) | 15:22 |
*** rushiagr is now known as rushiagr_away | 15:22 | |
*** zhenguo has quit IRC | 15:22 | |
*** edtubill has quit IRC | 15:22 | |
*** edtubill has joined #openstack-cinder | 15:23 | |
*** dobson has quit IRC | 15:29 | |
openstackgerrit | Curt Bruns proposed openstack/cinder: Add deactivate step to extend_lv https://review.openstack.org/198813 | 15:29 |
*** dobson has joined #openstack-cinder | 15:34 | |
*** eharney has joined #openstack-cinder | 15:35 | |
*** afazekas has quit IRC | 15:36 | |
*** ganso_ has quit IRC | 15:40 | |
anteaya | thingee: when you are about? can we go over the systems you would like disabled? the third-party-announce list tends to be broadcasting actions to operators that have already happened or decisions that have been made, it isn't really a discussion forum and honestly it isn't the best way to tell me what systems you would like disabled | 15:41 |
anteaya | thingee: I get confused | 15:41 |
openstackgerrit | liuxinguo proposed openstack/cinder: Add volume migration support for Huawei driver https://review.openstack.org/201406 | 15:44 |
*** rushiagr_away is now known as rushiagr | 15:45 | |
openstackgerrit | Danny Wilson proposed openstack/cinder-specs: Add ability for Cinder backend to report discard/unmap/trim https://review.openstack.org/205714 | 15:45 |
*** kfox1111_ has left #openstack-cinder | 15:46 | |
hemna | aaaand it's Monday. | 15:48 |
*** daneyon has joined #openstack-cinder | 15:48 | |
*** nkrinner has joined #openstack-cinder | 15:48 | |
*** daneyon_ has joined #openstack-cinder | 15:51 | |
LiuXinguo | hah, yeah Monday again | 15:51 |
*** agarciam has quit IRC | 15:52 | |
*** daneyon has quit IRC | 15:53 | |
*** harlowja_at_home has joined #openstack-cinder | 15:54 | |
LiuXinguo | hemna: have you saw my leave words, I'm so sorry to disturb you just from Monday ^-^ | 15:55 |
*** xyang has quit IRC | 15:55 | |
*** mgarza_ has joined #openstack-cinder | 16:00 | |
thingee | anteaya: in the future how would you like me to request CI's to be disabled. This was the previous way people were making requests. | 16:03 |
thingee | ah an etherpad, ok | 16:03 |
anteaya | or irc | 16:04 |
anteaya | thanks | 16:04 |
openstackgerrit | Tom Barron proposed openstack/cinder: Fix cleanup_temp_volume_snapshots for missing vol https://review.openstack.org/206131 | 16:07 |
thingee | dulek: https://review.openstack.org/#/c/183947/2 | 16:07 |
*** jdurgin1 has quit IRC | 16:07 | |
*** e0ne has quit IRC | 16:10 | |
*** avishay__ has quit IRC | 16:14 | |
thingee | smcginnis: I would like to see WIP not touched as well https://review.openstack.org/#/c/203158/1 | 16:15 |
*** bluex-pl has quit IRC | 16:16 | |
thingee | mkoderer: what were your reasons for not wanting to go all in on jgriffith's approach here? https://review.openstack.org/#/c/201812/ | 16:17 |
openstackgerrit | Tomoki Sekiyama proposed openstack/cinder: Efficient image download and upload for Glance Cinder backend https://review.openstack.org/201754 | 16:18 |
*** mragupat has joined #openstack-cinder | 16:18 | |
*** leeantho has joined #openstack-cinder | 16:19 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Add abandon script to clean up orphaned reviews https://review.openstack.org/203158 | 16:21 |
*** thangp_ has quit IRC | 16:21 | |
thingee | smcginnis: thanks | 16:21 |
openstackgerrit | Anton Arefiev proposed openstack/cinder: Add entry create and cast tasks to manage workflow https://review.openstack.org/139071 | 16:22 |
openstackgerrit | Anton Arefiev proposed openstack/cinder: Fix lvm manage existing volume https://review.openstack.org/156939 | 16:22 |
*** ganso_ has joined #openstack-cinder | 16:23 | |
*** Apoorva has joined #openstack-cinder | 16:23 | |
aarefiev | thingee: hi, is there any chance that it lands in liberty https://review.openstack.org/#/c/137318/ ? | 16:24 |
*** salv-orlando has joined #openstack-cinder | 16:24 | |
*** patrickeast has joined #openstack-cinder | 16:25 | |
*** salv-orl_ has joined #openstack-cinder | 16:26 | |
*** vilobhmm1 has quit IRC | 16:27 | |
anteaya | thingee: thanks I have to run errands now, will check the etherpad in a few hours when I return | 16:28 |
anteaya | thank you | 16:28 |
*** vokt has joined #openstack-cinder | 16:28 | |
*** salv-orlando has quit IRC | 16:29 | |
*** laughterwym has quit IRC | 16:30 | |
DuncanT | thingee: jgriffith's ABC replacement patch I didn't like.... I'm not sure what it achieves. The problem (highlighted by the current approach) is that a bunch of 'mandatory' features are not universally implemented. IMO jgriffith's patch is only needed because we haven't faced up to / fixed that problem. It goes back to 'if things are broken, that's the | 16:30 |
DuncanT | driver author's fault and they should have done better', rather than making the problem clear to everybody | 16:30 |
thingee | DuncanT: I think it's the idea of having a single class as oppose to all these broken out classes. | 16:31 |
DuncanT | thingee: All of the features that are universally implemented can go in one class, sure, but there aren't that many of those... | 16:31 |
thingee | DuncanT: There was a good point raised on the list though http://lists.openstack.org/pipermail/openstack-dev/2015-June/067572.html | 16:32 |
DuncanT | thingee: snapshots etc are currently defacto optional... being able to put them in the base class proves your problem detection mechanism is broken | 16:32 |
thingee | I would agree with that post on the ML that THAT'S broken | 16:32 |
DuncanT | thingee: The ABC approach to that would be to introduce a second ABC that is a superset of the first, then migrate all of the existing drivers to the superset over time. The *point* of the ABC work, to a certain degree, was to make situations like that obvious (both in the code and the testing) | 16:34 |
eharney | doesn't putting things back in the base class remove the ability to use abc to ensure we know which features are implemented in which drivers, and that the interface for those features is correctly shaped? | 16:34 |
DuncanT | thingee: Introspection means it doesn't blow up until run time, and our test coverage is not exactly high | 16:34 |
eharney | like Duncan (i think), i'm still kind of lost on the motivation | 16:34 |
*** jasondotstar has quit IRC | 16:34 | |
thingee | I'm confused by both your guys' comments. are you for or against the current approach? :P | 16:35 |
thingee | rather current merged approach | 16:35 |
*** afazekas has joined #openstack-cinder | 16:36 | |
eharney | sorry, i'm generally for the current approach, and don't really understand the aim with the new patch | 16:36 |
*** mylu has quit IRC | 16:37 | |
thingee | eharney: my main take away from jgriffith's email was there are too many classes. lets put everything into one and one by one start decorating methods we mark as required features. | 16:37 |
thingee | eharney: the whole goal is to not know what drivers do what features. the main goal was to eventually graduate features into being required. | 16:37 |
thingee | eharney: avoid a matrix | 16:37 |
DuncanT | thingee: There can be one class for every required feature, fine, but we have lots of defacto optional features, the classes make that clear | 16:37 |
*** _cjones_ has joined #openstack-cinder | 16:38 | |
*** mylu has joined #openstack-cinder | 16:38 | |
DuncanT | thingee: We *have* a matrix, pretending we don't is a fantasy | 16:38 |
eharney | yeah, there's a reason we haven't made more features required in the code | 16:38 |
thingee | DuncanT: do we always see these features being optional? | 16:38 |
thingee | DuncanT: there's no hiding here. The point of this is a movement away from that. | 16:38 |
DuncanT | thingee: CGs for example? Yes, absolutely | 16:38 |
eharney | the only one i see moving any time soon is basic snapshot support, but even that's not ready yet | 16:38 |
DuncanT | thingee: Snapshots I'd love to see going away from being optional, but people don't want to kill the block driver | 16:39 |
jgriffith | DuncanT: thingee eharney so all those points aside... | 16:39 |
eharney | more people don't want to kill the NFS driver | 16:39 |
thingee | I guess that goes back to people being unhappy that some features aren't capable of being fulfilled in the reference implementation | 16:39 |
*** thangp has joined #openstack-cinder | 16:39 | |
jgriffith | is there a reason having 12 classes is "better" preferred to having "one" | 16:39 |
DuncanT | thingee: replication - always optional | 16:39 |
jgriffith | (in terms of the abstract classes) | 16:40 |
thingee | jgriffith: from what I got from DuncanT, yes. Just to be clear of what features a driver supports | 16:40 |
eharney | jgriffith: well, i think it depends on what your personal goals are, and it seems that we have different ones | 16:40 |
thingee | jgriffith: since we'll never escape a matrix with the directiont hings have gone | 16:40 |
*** jasondotstar has joined #openstack-cinder | 16:40 | |
thingee | jgriffith: that's it though. | 16:40 |
DuncanT | So we have BaseVD for everything that is mandatory | 16:41 |
jgriffith | DuncanT: but we don't really. It' s not complete, it's not used, and I don't see any value in breaking everything out by method. | 16:41 |
*** harlowja_at_home has quit IRC | 16:41 | |
jgriffith | That being said, I'm also not going to argue this any longer. I noted my opinion and provided an alternative. If it's not good enough... well then that's life | 16:42 |
thingee | jgriffith: by feature... but I knew what you meant. | 16:42 |
jgriffith | thingee: Ooops.. :) yeah, sorry | 16:42 |
DuncanT | jgriffith: Only optional features was the original idea... it just turned out many feature are optional | 16:42 |
jgriffith | FTR, I think the diverging features is a bad thing; but probably inevitable as mentioned. In which case I think it should be the vendors problem not mine or anybody elses | 16:43 |
thingee | jgriffith: I think your idea is fine, if we decide to just get rid of folks who can't do snapshots and remove features like CG and replication | 16:43 |
DuncanT | jgriffith: SnapVD, TransferVD MigrateVD, ExtendVD can all go into the base class once all of the drivers actually support the features | 16:44 |
DuncanT | jgriffith: Putting them in a base class now is just broken since not all drivers support them | 16:44 |
thingee | at least mkoderer started some patch in moving some to the base | 16:44 |
jgriffith | DuncanT: ok. My point was I just don't see any real value in that; or continuing to modify the object heirarchy | 16:44 |
*** krypton_ has joined #openstack-cinder | 16:44 | |
thingee | jgriffith: did you have any reasons of disliking it besides it just being (my words here) unusual to have all these classes broken out? | 16:45 |
eharney | this was one of the value-adds, just for context: https://review.openstack.org/#/c/160346/ | 16:45 |
jgriffith | thingee: it's poor object design | 16:46 |
DuncanT | jgriffith: Well, part of the problem is that you consider having (relatively) crap drivers in cinder and letting the vendors suffer for that ok, I don't - I get hassle whenever there's a 'cinder' problem, whether it is ultimately a vendor issue or not, so I want every driver in cinder to get better (or get out) | 16:46 |
jgriffith | thingee: inheritance can be bad enough, let alone multi-way inheritance | 16:46 |
DuncanT | jgriffith: It is interfaces, which is not poor OO IMO | 16:46 |
jgriffith | thingee: it's not implemented fully anywhere | 16:46 |
jgriffith | thingee: it's lead to a mix of both the "old" inheritance structure and the new | 16:47 |
*** sghanekar_ has joined #openstack-cinder | 16:47 | |
jgriffith | thingee: There are a number of drivers that have done a pick and choose of which classes they use and which ones they don't | 16:47 |
DuncanT | jgriffith: In part because cleaning it up is damn tricky because out drivers are a weird mess | 16:47 |
jgriffith | thingee: inheritance is the least flexible form of code design and object usage | 16:47 |
thingee | DuncanT: I have to say though wrt http://lists.openstack.org/pipermail/openstack-dev/2015-June/067572.html I don't think creating yet more classes is a good idea =/ | 16:48 |
DuncanT | jgriffith: Interfaces are *not* classical inheritence, though in python they look like it | 16:48 |
jgriffith | DuncanT: yes, and my patch in part cleaned some of that up IMHO. And also, that's not going to change by adding more layers until something is actually done to enforce the changes | 16:48 |
*** krypton has quit IRC | 16:48 | |
jgriffith | DuncanT: The way we've used them, they kinda are though... but regardless. I really don't want to argue this any more. | 16:49 |
*** krypton_ has quit IRC | 16:49 | |
*** jwcroppe has joined #openstack-cinder | 16:49 | |
jgriffith | if eharney doesn't agree in particular then "ok" | 16:49 |
*** sgotliv has quit IRC | 16:49 | |
jgriffith | and given that nobody else has really raised any issue other than me, and all the other folks writing drivers seem good with it then maybe i'm just being paranoid and overly picky | 16:50 |
eharney | i'm not really terribly vested either way on this, i'm just trying to figure out if there's a route here that's a clear win or not | 16:50 |
jgriffith | I'm not changing my opinion, and I think it is going to come back and bight us in the butt | 16:50 |
*** markus_z has quit IRC | 16:50 | |
winston-d | bite? | 16:51 |
jgriffith | eharney: Well if there's no "clear win" then why introduce the extra complexity? | 16:51 |
DuncanT | jgriffith: I thing you're *right* to think that what we have is ugly, but where we disagree is the cause of the ugly... I think the ABC work highlights a bunch of ugly that is and was there all along, and it will look better once we've fixed the underlying mess | 16:51 |
jgriffith | winston-d: as in "chomp chomp" | 16:51 |
jgriffith | :) | 16:51 |
jgriffith | DuncanT: ok | 16:51 |
thingee | to sum up this discussion, it appears people value seeing a clear idea of what optional features are supported by which drivers, and fine with the cost being a bunch of classes | 16:52 |
eharney | jgriffith: i think the win is that we are making our mess more understandable and documenting it -- it's a mess either way, but that sounds like a win to me | 16:52 |
eharney | yeah what thingee just said | 16:52 |
jgriffith | DuncanT: but I'd argue that given we've had drivers merge in Liberty that ignored or half implemented the abc semantics that were added in Kilo it's likely not going to work out | 16:52 |
jgriffith | eharney: but I've been saying it's not "more understandable" to most | 16:52 |
DuncanT | thingee: jgriffith: As for the case discussed on the mailing list, having a new interface that is implemented in only a few drivers is the root ugly, and ABCs make that ugly obvious - it all goes away once everybody has migrated to the new structure. I call that a feature of the ABC system, not a bug | 16:52 |
jgriffith | thingee: yes, that seems to be the concensus | 16:53 |
eharney | jgriffith: i think that's because of the inherent complexity that would be there for any way that we handle this, not due to abc, though | 16:53 |
eharney | but i'm kinda guessing there | 16:53 |
jgriffith | DuncanT: and by the way, I argue that the reason for such a wide divergence in the implementations in all of our drivers is the lack of a clear well defined base class | 16:53 |
jgriffith | DuncanT: and having 12 base classes isn't going to help that, it's going to make it worse | 16:54 |
*** nkrinner has quit IRC | 16:54 | |
jgriffith | eharney: DuncanT yes, to be clear I'm not opposed to ABC at ALL. If you looked at my patch you will notice that I utilized it | 16:54 |
jgriffith | abstract base class definitions is not the issue IMO | 16:54 |
jgriffith | i.e. the issue to debate | 16:55 |
*** jistr has quit IRC | 16:55 | |
thingee | jgriffith: I'd like to understand more on your point of it not being understandable. 1) For example, people wrote this to see a clear list of what's supported by which drivers https://review.openstack.org/#/c/160346/ ... 2) You can just look at the driver's class of long list of inherited classes | 16:55 |
jgriffith | thingee: how does that help a person writing a driver? | 16:56 |
eharney | jgriffith: i'll admit that i need to study your patch more to really figure out what all is going on there, i think i'm still missing some of the detail | 16:56 |
Swanson | jgriffith: Two driver implementation things. | 16:57 |
thingee | jgriffith: Well we have a BaseVD class. That's the base. As a new volume driver, you should start there. I agree though that by us diverging from just that idea makes things more interesting in Cinder. | 16:57 |
jgriffith | thingee: DuncanT so my biggest concern is the goal seems to be "build an automated feature matrix" but my contention is still that we shouldn't do that | 16:57 |
Swanson | jgriffith: I add consistency groups so I can just see what is in ConsistencyGroupVD and add those functions. Easy. No searching. | 16:57 |
*** afazekas has quit IRC | 16:58 | |
*** ub has quit IRC | 16:58 | |
Swanson | jgriffith: I also need to change existing functions that are in basevd. Not so easy. Lots of searching. | 16:58 |
DuncanT | jgriffith: So kick out all of the drivers that don't meet minimums, move transfer, snap and migrate into baseVD, and the answer is 'implement all of baseVB' | 16:58 |
eharney | i don't think avoiding a feature matrix is a feasible option any time soon | 16:58 |
jgriffith | Swanson: sure.. but what's wrong with ### Consistency Group Interface Begin ##### ..... END | 16:58 |
thingee | jgriffith: I agree. I think though that before we can say this idea of optional feature classes is bad, we should use it as a point that we just don't like the idea of replication and consistency group in CInder. | 16:58 |
jgriffith | eharney: fair enough (I guess) | 16:58 |
thingee | DuncanT: that's fair, I think that should be a goal of next release. | 16:58 |
jgriffith | eharney: but that means I've been doing things wrong for the last 4 years | 16:58 |
DuncanT | jgriffith: That was kind of where I hoped we'd be by now, TBH | 16:59 |
*** annashen has joined #openstack-cinder | 16:59 | |
thingee | DuncanT: I didn't focus on this release of graduating features. IMO I need to do early communication to maintainers. | 16:59 |
jgriffith | eharney: I should be submitting all the "special" features that I have been hiding in extensions or in volume-types | 16:59 |
smcginnis | I think for M a goal should be to have all drivers switched to ABC. | 16:59 |
smcginnis | That will be a move to identifying what is really common and what is extra. | 16:59 |
smcginnis | With the long term goal of getting as much as possible into base. | 16:59 |
Swanson | jgriffith: Either way works for me. What we had was a pain. xxxVD is better. Your patch is fine, too. | 17:00 |
DuncanT | jgriffith: Nova said no extensions, only core API, because otherwise your workload portability is shot.... not an entirely bad point | 17:00 |
*** afazekas has joined #openstack-cinder | 17:00 | |
jgriffith | DuncanT: Cinder != Nova last time I checked | 17:00 |
jgriffith | DuncanT: and you're the most famous for saying "I don't care what project X does" | 17:00 |
thingee | heh | 17:00 |
DuncanT | jgriffith: I didn't say they were the same, I said they had a not entirely bad point in this case | 17:00 |
DuncanT | jgriffith: Just because they're full of crazy doesn't mean they always make bad points | 17:01 |
thingee | ok lets bring things back... | 17:01 |
jgriffith | DuncanT: well.. don't take this the wrong way please, but that's awfully convenient. Use the argument when it suits you? | 17:01 |
thingee | Do we all agree that avoiding a matrix at this point is not feasible? | 17:01 |
DuncanT | jgriffith: Huh? The argument that sometimes nova make good points? | 17:02 |
smcginnis | thingee: +1 | 17:02 |
jgriffith | thingee: -1 | 17:02 |
DuncanT | thingee: Agreed. +1. | 17:02 |
*** jordanP has quit IRC | 17:02 | |
thingee | jgriffith: should we start considering on removing some of these features we have in Cinder? | 17:02 |
jgriffith | thingee: I'd personally be fine with that (more than fine actually) | 17:02 |
jgriffith | Most of them aren't used by any real customers anyway | 17:03 |
jgriffith | nor are they tested anywhere | 17:03 |
smcginnis | Options I see are 1) remove functionality from cinder (that may be used by someone), 2) remove drivers that can't be fully functional, or 3) have a matrix. | 17:03 |
jgriffith | thingee: but I also realize that's a tough thing to do, because as soon as we do remove something somebody is going to hollar | 17:04 |
thingee | smcginnis: that would remove our reference implementation at this point :) | 17:04 |
* DuncanT would say kill replication, keep cgs, and improve testing and discoverability | 17:04 | |
smcginnis | thingee: Exactly! | 17:04 |
*** akshai has quit IRC | 17:04 | |
DuncanT | CGs are cross vendor, replication is currently single vendor | 17:04 |
thingee | DuncanT: might change once things are accessible by jgriffith's efforts. | 17:04 |
jgriffith | How many of the drivers do CG's now? | 17:04 |
jgriffith | So maybe there should be at least a 50% rule or something :) | 17:05 |
smcginnis | If they were all using ABC we could know pretty quick. :P | 17:05 |
*** akshai has joined #openstack-cinder | 17:05 | |
* smcginnis hides | 17:05 | |
thingee | all of emc, if not a patch up for review by now, pure, dell | 17:05 |
thingee | huawei | 17:05 |
jgriffith | smcginnis: not true actually | 17:05 |
Swanson | As a semirelated aside TransferVD seems to actually be implemented by solidfire only. Haven't finished my migratevd search. | 17:05 |
smcginnis | jgriffith: Well, if they were all switched over we could see which ones implement the consistency group interface. | 17:06 |
jgriffith | Swanson: FWIW, transfer is implemented by quite a few drivers. Somebody updated the SF driver to use the class though | 17:06 |
*** coolsvap is now known as coolsvap|away | 17:06 | |
smcginnis | If they don't support it, they don't implement the interface. | 17:06 |
DuncanT | jgriffith: If the ABCs were done properly, we should know easily and in code... if that isn't possible then I'd liketo know about it | 17:06 |
thingee | jgriffith: so lets say we did remove CG and replication all together... | 17:06 |
DuncanT | Swanson: Most drivers don't need to do anything for transfer, it just works | 17:06 |
*** kjnelson has quit IRC | 17:06 | |
thingee | jgriffith: I've been sort of curious how drivers would do this today without having some knowledge in the manager to handle the requests. it's not enough for their to be an api extension | 17:06 |
thingee | there* | 17:07 |
DuncanT | Swanson: ONly backends that store tenant ids etc need to care | 17:07 |
jgriffith | DuncanT: Id' say go look at the code, pick some "features' and start looking at drivers. It doesn't work currently at all | 17:07 |
blinky_ghost | guitarzan: I use icehouse so guess not :) thanks anyway | 17:07 |
thingee | jgriffith: and maybe your answer is it just shouldn't be possible in Cinder. | 17:07 |
Swanson | jgriffith: really? When I did a search on accept_transfer that was the only driver I found. I found more than a few that inherited transfervd but only the one that implemented its function. Maybe the scope of my search is off. | 17:07 |
jgriffith | thingee: yeah, well you can do direct calls to db and roc layer from the extension (not saying that's good... just saying you can) | 17:07 |
jgriffith | Swanson: interesting | 17:08 |
DuncanT | jgriffith: If you're going to do that, why bother with cinder as a standard at all? | 17:08 |
jgriffith | Swanson: did you by chance notice that it's implemented at a general layer? | 17:08 |
DuncanT | jgriffith: For most drivers, transfer is a no-op | 17:08 |
jgriffith | Swanson: it's only implemented as a method in my driver so I can update the attributes on the cluster device | 17:08 |
winston-d | Swanson: jgriffith was right, most drivers don't need driver level accept_transfer 'cos they don't use volid internally. | 17:09 |
jgriffith | Swanson: so it's a good example of a "feature" abc-class that gets picked up by the base driver and nobody has to implement | 17:09 |
jgriffith | but that doesn't mean it will actually "work" | 17:09 |
DuncanT | Sorry, got to run. I'll look again at the class hierachy, see if I can suggest some cleanup that doesn't involve throwing out the baby with the bath water | 17:09 |
jgriffith | Swanson: my driver for example can do that; but if I didn't update the volume object on the cluster the "new" owner would never be able to find the volume or access it | 17:10 |
jgriffith | Swanson: I wouldn't be surprised if there are some drivers that have this problem TBH and don't even know it | 17:10 |
jgriffith | Swanson: which IMO shows that ABC doesn't actually "do" what some people think it does | 17:10 |
winston-d | DuncanT: btw, before you leave, quick question about decouple backup from volume service | 17:10 |
winston-d | DuncanT: anything in progress? | 17:11 |
jgriffith | Swanson: and being that transfer has a general implementation in the base driver and the reference works, why is it a "separate" feature in the matrix? | 17:11 |
smcginnis | If things are done right, we should be able to do isinstance(driver, transferableVD). | 17:11 |
jgriffith | smcginnis: but that will "pass" | 17:11 |
smcginnis | Then they aren't inheriting correctly. | 17:11 |
jgriffith | smcginnis: because the method is implemented in the next layer of base driver | 17:12 |
smcginnis | They should only inherit if they implement that interface. | 17:12 |
jgriffith | smcginnis: which the vendor driver inherits from | 17:12 |
smcginnis | jgriffith: That's a problem. | 17:12 |
jgriffith | smcginnis: but that doesn't mean the feature works | 17:12 |
smcginnis | None of these should be in base driver implementations unless it's clear what it means to inherit from that base. | 17:12 |
jgriffith | smcginnis: that's what I've been trying to say here | 17:12 |
thingee | I think this will be excellent to discuss with ya'll at the midcycle. My decision is still going to be that unless we're really interested in doing a hard push of removing these features and telling a small number of customers (according to sources in this room) tough, that's not what Cinder does, what we're doing is fine. | 17:12 |
Swanson | jgriffith: i do use the volume id for about everything. I wonder if I'm hosed. | 17:12 |
tbarron | winston-d: i've got a bp spec and POC up | 17:12 |
smcginnis | jgriffith: But moving them ALL into a base volumedriver is the wrong direction then. | 17:13 |
thingee | especially since we don't have an answer for drivers to do this outside of CInder easily. | 17:13 |
jgriffith | thingee: that's cool | 17:13 |
*** krypton has joined #openstack-cinder | 17:13 | |
jgriffith | smcginnis: volume-id doesn't change | 17:13 |
jgriffith | errr.. Swanson | 17:13 |
smcginnis | thingee: +2, this should be a midcycle discussion. | 17:13 |
tbarron | winston-d: want me to add you as reviewer to these? | 17:13 |
jgriffith | Swanson: in my case I have multi-tenancy on the cluster that maps to tenants in OpenStack, so I need to make that update | 17:13 |
thingee | jgriffith: I have to say though, I think it's funny that you're both wanting to remove replication and fix it. :P | 17:14 |
winston-d | tbarron: scalable backup? | 17:14 |
tbarron | winston-d: yes, really just a pre-conditiono for scalable backup :-) | 17:14 |
Swanson | jgriffith: I'm thinking it doesn't matter because of that. We had plans for some backend weirdness but smcginnis fixed that.. | 17:14 |
thingee | that's the kind of guy jgriffith is... "well if it has to be here, I'm going to fix it." | 17:14 |
tbarron | winston-d: I'm re-working some of the POC code in light of the recent merge of Xing's non-disruptive backuip | 17:15 |
tbarron | backuip | 17:15 |
tbarron | backup :-) | 17:15 |
*** krypton_ has joined #openstack-cinder | 17:15 | |
winston-d | tbarron: thx, i was expecting sth like 'decouple backup from vol', sth more straightforward, but it makes sense. | 17:15 |
jgriffith | thingee: well... I guess. But if it's going to be "in" might as well try and help make it better no? | 17:15 |
tbarron | winston-d: -1 and have me change the title if you want :-) | 17:15 |
tbarron | winston-d: actually, I agree. | 17:15 |
winston-d | tbarron: nah, i don't mind. i'm just too lazy to read the code | 17:16 |
thingee | jgriffith: I was trying to communicate your last sentence, yes. :) | 17:16 |
thingee | jgriffith: https://review.openstack.org/#/c/200237 https://review.openstack.org/#/c/104653/7 | 17:17 |
Swanson | jgriffith: (Still would be the same tenant so even the weirdness I was planning wouldn't have mattered.) | 17:17 |
winston-d | tbarron: one question regarding to lisa's change on adding 'volume_name' to backup_restore? | 17:17 |
jgriffith | thingee: LOL.. yeah, I see that line now (missed it) | 17:17 |
winston-d | tbarron: you said you understand the motivation, could you elabrate a bit, 'cos I don't. | 17:18 |
*** krypton has quit IRC | 17:18 | |
winston-d | but i am not familiar with backup, so i must have missed sth obvious | 17:18 |
*** angela-s has joined #openstack-cinder | 17:19 | |
*** krypton_ has quit IRC | 17:20 | |
*** vilobhmm has joined #openstack-cinder | 17:20 | |
erlon | smcginnis: hey Sean, you have just reviewed my patch 'concurrent attaches on HNAS iSCSI driver', there's still another comment I did, about adding a new exception. Can you answer my question so I can address both points in one commit? | 17:21 |
smcginnis | erlon: Sure. Was that the question about whether to add a new exception or not? | 17:22 |
*** afazekas has quit IRC | 17:22 | |
*** e0ne has joined #openstack-cinder | 17:22 | |
erlon | smcginnis: yes, currenty every driver addis its own exception | 17:22 |
smcginnis | erlon: Not every driver. | 17:23 |
erlon | smcginnis: so I just I just did the same, as I couldn't reuse the one there | 17:23 |
erlon | smcginnis: not not all, but several | 17:23 |
smcginnis | erlon: OK, I see how you are using it now. I'm fine if you leave it as is. | 17:24 |
*** xyang has joined #openstack-cinder | 17:24 | |
smcginnis | erlon: But the text passed to does need to have _(). | 17:24 |
tbarron | winston-d: just got back, got pulled AFK for a bit. Catching up. | 17:25 |
openstackgerrit | abhiram moturi proposed openstack/cinder: Enhance unit tests for zfssa drivers https://review.openstack.org/203895 | 17:25 |
erlon | smcginnis: ok then, ill fix that, I understood what you meant. | 17:25 |
smcginnis | erlon: OK, great. Thanks erlon! | 17:26 |
tbarron | winston-d: the dependent change wants to display volume_name along with the other info. Do you agree that this could be a useful thing to see? | 17:27 |
tbarron | winston-d: https://review.openstack.org/#/c/199846/ | 17:27 |
tbarron | winston-d: her use case is where the same restore cmd is run several times in a row | 17:28 |
tbarron | winston-d: showing the name would make it apparent that one is creating a bunch of volumes with the same name | 17:28 |
tbarron | winston-d: maybe the use case isn't that compelling. I just figured someone had gotten into the situation and showing the name would have been helpful. | 17:29 |
winston-d | tbarron: i just want to understand how is that helpful. | 17:32 |
winston-d | if you restore backup using same name multiple times, you'd need a pen to track down vol uuid instead of name, right? | 17:33 |
*** krypton has joined #openstack-cinder | 17:33 | |
tbarron | winston-d: right. | 17:34 |
tbarron | winston-d: you should press the point "how is this really useful". Maybe I was too hasty. | 17:35 |
tbarron | winston-d: I was figuring it provided a way of grouping these volumes and making their origin clear. But Lisa should explain rather than me making up an explanation. | 17:36 |
*** avishay__ has joined #openstack-cinder | 17:36 | |
winston-d | tbarron: yeah, i should ask here, but i did in previous comments. | 17:37 |
winston-d | maybe i should call her instead. | 17:37 |
tbarron | winston-d: you can probably make a local call? | 17:37 |
*** lpetrut has quit IRC | 17:37 | |
winston-d | tbarron: yeah, sometime this week. | 17:38 |
dannywilson | winston-d: with regards to https://review.openstack.org/#/c/205726/ and reusing the scsi controller, do you know how to detect it was already added? | 17:39 |
winston-d | still stuck at airport, my flight has been delayed for almost 8hrs. | 17:39 |
winston-d | dannywilson: tbh, no, not yet. :) | 17:40 |
tbarron | winston-d: lisa is reviewing the decouple backup stuff too, so maybe encourage her to hang out on IRC. She doesn't have to be on US time of course. | 17:40 |
smcginnis | winston-d: Oh man. Good luck. | 17:40 |
dannywilson | winston-d: ouch | 17:40 |
tbarron | winston-d: which airport? | 17:40 |
*** boris-42 has quit IRC | 17:40 | |
dannywilson | winston-d: okay, I will keep looking, good luck | 17:40 |
winston-d | tbarron: beijing, it's almost 2am. ;0 | 17:40 |
tbarron | winston-d: I was going to say ... Where are you going? | 17:41 |
winston-d | tbarron: heading back to hometown, somewhere in south china. | 17:42 |
tbarron | winston-d: ah, well enjoy being home then. | 17:42 |
tbarron | winston-d: when you eventually get there :( | 17:42 |
*** raunak has joined #openstack-cinder | 17:42 | |
winston-d | dannywilson: we piggyback the image properties for discard support. | 17:43 |
winston-d | no pretty, but works. | 17:43 |
winston-d | dannywilson: but i really would like your change to land, especially Nova's part. | 17:43 |
*** akshai has quit IRC | 17:44 | |
*** mgarza_ has quit IRC | 17:44 | |
winston-d | dannywilson: we should talk to Daniel P. Berrangé, he must know how | 17:47 |
dannywilson | winston-d: okay, I'll check with him on nova irc, thanks | 17:47 |
winston-d | tbarron: thx, hopefully i can be there, eventually. | 17:48 |
*** afazekas has joined #openstack-cinder | 17:49 | |
tbarron | winston-d: yes, we'll "keep our fingers crossed" for you | 17:50 |
*** akshai has joined #openstack-cinder | 17:50 | |
winston-d | tbarron: thx, my notebook battery is dead, need to get off now. | 17:51 |
*** winston-d is now known as winston-d_zZZ | 17:51 | |
winston-d_zZZ | switching to zZZ mode, but not sleeping actually. | 17:51 |
winston-d_zZZ | you guys have a good day. | 17:52 |
dannywilson | winston-d_zZZ: safe travels | 17:52 |
*** harlowja has joined #openstack-cinder | 17:52 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/205651 | 17:54 |
*** annegentle has joined #openstack-cinder | 17:58 | |
*** e0ne has quit IRC | 18:01 | |
*** kjnelson has joined #openstack-cinder | 18:03 | |
openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 18:04 |
*** mylu has quit IRC | 18:07 | |
*** mylu has joined #openstack-cinder | 18:08 | |
*** blinky_ghost has quit IRC | 18:08 | |
openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/cinder: Fix get default quota values for subprojects https://review.openstack.org/206170 | 18:11 |
openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/cinder: Nested Quota Driver: Get Project Hierarchy https://review.openstack.org/206171 | 18:11 |
*** changbl has joined #openstack-cinder | 18:12 | |
*** salv-orl_ has quit IRC | 18:14 | |
*** annegentle has quit IRC | 18:15 | |
*** annashen has quit IRC | 18:16 | |
*** avishay__ has quit IRC | 18:17 | |
*** avishay has joined #openstack-cinder | 18:17 | |
*** annashen has joined #openstack-cinder | 18:18 | |
*** afazekas has quit IRC | 18:19 | |
*** jasondot_ has joined #openstack-cinder | 18:25 | |
openstackgerrit | Jon Bernard proposed openstack/cinder: RBD: use user-configured value for max_clone_depth https://review.openstack.org/205202 | 18:25 |
*** annegentle has joined #openstack-cinder | 18:27 | |
*** jasondotstar has quit IRC | 18:27 | |
*** casusbelli has joined #openstack-cinder | 18:31 | |
*** boris-42 has joined #openstack-cinder | 18:42 | |
*** annegentle has quit IRC | 18:43 | |
*** sgotliv has joined #openstack-cinder | 18:46 | |
*** mylu has quit IRC | 18:47 | |
jbernard | i'll be at the glance minisummit (since it's in the town where is live), if anyone would like a topic to be raised or anything, im happy to help | 18:49 |
*** andrey-mp has joined #openstack-cinder | 18:49 | |
*** mragupat_ has joined #openstack-cinder | 18:50 | |
*** rushiagr is now known as rushiagr_away | 18:50 | |
*** mylu has joined #openstack-cinder | 18:51 | |
*** casusbelli has quit IRC | 18:52 | |
*** lpetrut has joined #openstack-cinder | 18:52 | |
*** mragupat has quit IRC | 18:54 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: WIP: Cleanup stuck jobs https://review.openstack.org/205838 | 18:57 |
*** raunak has quit IRC | 18:57 | |
andrey-mp | hi all. can anyone tell me when such type of review close - https://review.openstack.org/#/c/193124/ ? I've re-based it ten times and i bored ^) that very simple change requires very much efforts... | 18:57 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add connector object to create_export https://review.openstack.org/202808 | 18:59 |
*** zhonghua-lee has joined #openstack-cinder | 19:00 | |
*** annegentle has joined #openstack-cinder | 19:02 | |
thingee | jbernard: is the glance ptl going to be present? | 19:04 |
thingee | jbernard: last I heard the ptl wasn't going to be present at the tokyo summit. | 19:05 |
jbernard | thingee: i expect so, it's at the rackspace office | 19:05 |
jbernard | thingee: (which is where nikhil is located) | 19:05 |
thingee | has anyone tried the cinder glance store? http://lists.openstack.org/pipermail/openstack-dev/2015-July/068561.html | 19:06 |
thingee | I cc'd Nikhil since I haven't heard anything from this and it has some Cinder folks approval | 19:06 |
jbernard | thingee: im happy to read through and raise it in the adjenda | 19:07 |
thingee | jbernard: I think someone just needs to test it out. | 19:07 |
thingee | patrickeast: ^ | 19:08 |
jbernard | thingee: i can do that too | 19:08 |
thingee | patrickeast: not sure if you tried it out yet. I'm bring up an instance now with the patch | 19:08 |
patrickeast | thingee: i haven’t tried out the glance side yet, just the cinder changes for it | 19:08 |
patrickeast | thingee: i’ll try it out later today too | 19:08 |
thingee | patrickeast: there are cinder changes for it? | 19:08 |
openstackgerrit | Sean Chen proposed openstack/cinder: Tintri snapshot id https://review.openstack.org/198829 | 19:09 |
patrickeast | thingee: yea there is a change… one sec lemmie find a link | 19:09 |
patrickeast | thingee: https://review.openstack.org/#/c/201754/9 | 19:09 |
patrickeast | thingee: it can kind of work standalone without the glance side, which is what i have tried out | 19:10 |
*** avishay has quit IRC | 19:10 | |
andrey-mp | thingee: could you tell me when such type of review close - https://review.openstack.org/#/c/193124/ ? I've re-based it ten times and i bored :) so very simple change requires very much efforts... | 19:11 |
*** salv-orlando has joined #openstack-cinder | 19:11 | |
*** annegentle has quit IRC | 19:11 | |
*** annegentle has joined #openstack-cinder | 19:12 | |
tbarron | andrey-mp: I'm tired of +1-ing your change :-) | 19:15 |
*** zhonghua-lee has quit IRC | 19:16 | |
*** ub has joined #openstack-cinder | 19:17 | |
*** lpetrut has quit IRC | 19:18 | |
*** xyang has quit IRC | 19:20 | |
*** edtubill1 has joined #openstack-cinder | 19:21 | |
*** xyang has joined #openstack-cinder | 19:22 | |
thingee | patrickeast: thanks | 19:23 |
thingee | my goal today is to be further along with the volume migration patches https://etherpad.openstack.org/p/cinder-liberty-2-reviews and tested out the cinder glance store. | 19:24 |
*** edtubill has quit IRC | 19:25 | |
andrey-mp | thingee: thank you | 19:27 |
*** shyama has quit IRC | 19:28 | |
*** andrey-mp has left #openstack-cinder | 19:32 | |
*** lpetrut has joined #openstack-cinder | 19:36 | |
openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/cinder: Fix get default quota values for subprojects https://review.openstack.org/206170 | 19:44 |
openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/cinder: Nested Quota Driver: Get Project Hierarchy https://review.openstack.org/206171 | 19:44 |
*** thangp has quit IRC | 19:44 | |
tsekiyama | thingee: thanks for testing cinder glance store. Just FYI, you also need glance rootwrap patch to make it work: https://review.openstack.org/#/c/186201/ | 19:44 |
*** harlowja has quit IRC | 19:45 | |
*** vilobhmm has quit IRC | 19:45 | |
*** raunak has joined #openstack-cinder | 19:49 | |
*** vilobhmm has joined #openstack-cinder | 19:56 | |
j_king | does provider_location provide any information about the driver/backend? Noticing that the tests in test_nfs.py assume provider location can be something in the ballpark of r'[a-zA-Z0-9-.]+:/{1}.*$' and https://bugs.launchpad.net/cinder/+bug/1287134 wants to check the volume in ensure_export() to see that the volume was created by the same provider as is presently configured... | 19:58 |
openstack | Launchpad bug 1287134 in Cinder "C-vol crashes when driver class is changed after some volumes exist on that backend" [Low,In progress] - Assigned to j_king (james-agentultra) | 19:58 |
j_king | code doesn't say much and presently trying to scrape through documentation but turning up short | 19:59 |
*** harlowja has joined #openstack-cinder | 20:01 | |
*** Apoorva has quit IRC | 20:01 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder-specs: Add Connector to create_export https://review.openstack.org/202765 | 20:05 |
*** andreykurilin__ has joined #openstack-cinder | 20:07 | |
*** diogogmt_ has joined #openstack-cinder | 20:19 | |
*** breitz has quit IRC | 20:19 | |
*** breitz has joined #openstack-cinder | 20:19 | |
*** Apoorva has joined #openstack-cinder | 20:21 | |
j_king | unless I'm totally lost it seems like there's no way for the driver or the manager to know what backend a volume came from | 20:21 |
*** diogogmt has quit IRC | 20:22 | |
*** diogogmt_ is now known as diogogmt | 20:22 | |
Swanson | j_king: it doesn't in the dell driver. I do not return provider_location. | 20:22 |
hemna | j_king, the volume table has the host field, which is what backend and pool the volume came from. | 20:22 |
*** merooney has quit IRC | 20:22 | |
patrickeast | j_king: https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L134 | 20:23 |
patrickeast | hemna: beat me to it :p | 20:23 |
j_king | hemna: host might be good; in the nfs case I would I be right assuming that's a parseable url? | 20:23 |
j_king | patrickeast: I have a buffer open on that file atm, ty | 20:23 |
hemna | j_king, the format of the host field should always be foo@bar#pool | 20:24 |
hemna | regardless of the backend. | 20:24 |
*** sghanekar_ has quit IRC | 20:26 | |
*** lpetrut has quit IRC | 20:31 | |
*** mragupat_ has quit IRC | 20:36 | |
jungleboyj | hemna: smcginnis xyang Would appreciate some eyes on these simple patches to help get our drivers back to proper functionality: https://review.openstack.org/#/c/205475/ and https://review.openstack.org/#/c/205738/ | 20:36 |
*** mragupat has joined #openstack-cinder | 20:37 | |
*** mragupat has quit IRC | 20:37 | |
*** annegentle has quit IRC | 20:37 | |
*** mragupat has joined #openstack-cinder | 20:37 | |
*** julim_ has quit IRC | 20:38 | |
*** mragupat has quit IRC | 20:38 | |
hemna | jungleboyj, https://review.openstack.org/#/c/205738 Is there CI for the XIV driver? | 20:39 |
*** mragupat has joined #openstack-cinder | 20:39 | |
hemna | maybe I'm not seeing it | 20:39 |
jungleboyj | Not at the moment because it has been disabled partially because of this bug. | 20:39 |
hemna | doh | 20:40 |
jungleboyj | hemna: I am working that issue internally. It has been verified that that patch works internally. | 20:40 |
hemna | but shouldn't it be reporting for that patch to prove it fixes it ? | 20:40 |
jungleboyj | hemna: How would that happen if they have disabled it? | 20:40 |
Swanson | I want to mark a patch as also being a problem in Kilo. I don't remember how to do this. Anyone? | 20:40 |
hemna | enable the CI and it tests against that patch and reports success ? | 20:41 |
jungleboyj | Swanson: Nominate for Series | 20:41 |
jungleboyj | Right, but they aren't allowing us to report results anymore. | 20:41 |
*** Yogi1 has quit IRC | 20:42 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Move update_migrated_volume to correct class https://review.openstack.org/206210 | 20:42 |
openstackgerrit | Eric Harney proposed openstack/cinder: Log which service is down https://review.openstack.org/206211 | 20:42 |
*** raildo has joined #openstack-cinder | 20:46 | |
patrickeast | tsekiyama: hey, so i’m looking into the v2 glance api that has virtual_size, but i’m not seeing it ever be anything other than ‘None’… is there some glance configuration required to get those filled it? or is it a manual step after creating the image? | 20:46 |
*** harlowja_ has joined #openstack-cinder | 20:47 | |
openstackgerrit | Mike Perez proposed openstack/cinder: Remove deprecated config options for Liberty https://review.openstack.org/206215 | 20:48 |
tsekiyama | patrickeast: hmm, as far as I tried so far, it is not yet completed. Currently it is set only when you use the import flow to register an image. http://www.sebastien-han.fr/blog/2015/05/11/openstack-glance-a-first-glimpse-at-image-conversion/ | 20:48 |
patrickeast | tsekiyama: ah ok cool | 20:49 |
*** vilobhmm has quit IRC | 20:50 | |
patrickeast | patrickeast: so I think what i’ll do is check for it, if its there we use it, otherwise look for a property with the right name (like it does right now) | 20:51 |
patrickeast | tsekiyama: ^ | 20:51 |
*** harlowja has quit IRC | 20:51 | |
patrickeast | tsekiyama: and for the ones we upload from cinder we can set the value for them based on the volume size | 20:51 |
tsekiyama | patrickeast: yeah I think that is reasonable | 20:52 |
*** eharney has quit IRC | 20:53 | |
*** bswartz has quit IRC | 20:54 | |
openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/cinder: Fix get default quota values for subprojects https://review.openstack.org/206170 | 20:54 |
openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/cinder: Nested Quota Driver: Get Project Hierarchy https://review.openstack.org/206171 | 20:54 |
thingee | tsekiyama: thanks | 20:54 |
*** raunak has quit IRC | 20:58 | |
*** raildo has quit IRC | 21:00 | |
*** edtubill1 has left #openstack-cinder | 21:00 | |
Swanson | jungleboyj: I'm not familiar with nominate for series. I did find Cherry Pick to Branch which I think I've done before but that doesn't seem to be working for me. Where do I find the nominate for series bit? Or is it some kind of typey typey thing. | 21:00 |
*** raunak has joined #openstack-cinder | 21:01 | |
*** sghanekar_ has joined #openstack-cinder | 21:02 | |
*** annegentle has joined #openstack-cinder | 21:06 | |
*** akerr has quit IRC | 21:11 | |
*** annashen has quit IRC | 21:14 | |
openstackgerrit | Jon Bernard proposed openstack/cinder: Add support for file I/O volume migration https://review.openstack.org/187270 | 21:15 |
*** xyang has quit IRC | 21:21 | |
*** crose has quit IRC | 21:31 | |
thingee | Swanson: should be under the bug information of assignee and priority | 21:31 |
*** vilobhmm has joined #openstack-cinder | 21:38 | |
*** annashen has joined #openstack-cinder | 21:39 | |
*** salv-orlando has quit IRC | 21:39 | |
*** mylu has quit IRC | 21:41 | |
jungleboyj | Swanson: So, you can cherry-pick the change to stable/kilo and then Launchpad takes care of the deails of showing a fix has been proposed. | 21:44 |
jungleboyj | Swanson: Otherwise, below the table that shows Affect, Status, etc. There should be a little clock button that says 'Nominate for Series' there. | 21:45 |
jungleboyj | That is another way to indicate that something should be cherry-picked back. | 21:45 |
thingee | git cherry-pick -x | 21:45 |
thingee | https://wiki.openstack.org/wiki/StableBranch#Proposing_Fixes | 21:46 |
jungleboyj | Yeah. :-) | 21:46 |
*** julim has joined #openstack-cinder | 21:46 | |
jungleboyj | Swanson: I am wondering if that button is only something that stable maintainers have. | 21:51 |
jungleboyj | Swanson: Anyway, if you want to propose a patch for backport, do the cherry pick. I will get an e-mail and review it. | 21:51 |
smcginnis | Thanks jungleboyj, I don't have that option on my screen, so probably the same for Swanson. | 21:52 |
Swanson | jungleboyj: Thanks! I think I've gone blind trying to find that. | 21:52 |
smcginnis | Swanson: No comment. | 21:53 |
Swanson | thingee: thanks! | 21:53 |
jungleboyj | smcginnis: I am biting my tongue as well. | 21:53 |
Swanson | smcginnis: quiet you | 21:53 |
jungleboyj | Second time things have gone wrong out here today. | 21:53 |
smcginnis | Gotta have some fun on a Monday. :) | 21:54 |
jungleboyj | Tell me about it. I need that today. | 21:54 |
jungleboyj | Anyway, I gotta drop off. I will watch for the backport and take a look at it. That is a big code change, but it is limited to your driver. So, I can look. | 21:54 |
Swanson | jungleboyj: Thanks! | 21:55 |
*** sgotliv has quit IRC | 21:55 | |
jungleboyj | Swanson: Welcome sir. Don't go blind. | 21:55 |
*** mragupat has quit IRC | 21:57 | |
*** ganso_ has quit IRC | 22:00 | |
*** jungleboyj has quit IRC | 22:01 | |
*** Guest10__ has quit IRC | 22:07 | |
*** Lee1092 has quit IRC | 22:07 | |
Swanson | Oh, what an ugly merge. | 22:07 |
*** chlong has joined #openstack-cinder | 22:09 | |
*** salv-orlando has joined #openstack-cinder | 22:09 | |
*** xyang has joined #openstack-cinder | 22:11 | |
patrickeast | tsekiyama: i just noticed after the latest rebase there is a new error http://paste.openstack.org/show/405975/ looks like there was some cleanup to remove extra parameters in create volume | 22:13 |
*** edmondsw has quit IRC | 22:14 | |
openstackgerrit | Sonia Ghanekar proposed openstack/cinder: Nimble driver version shows the correct version instead of N/A in the volume.log https://review.openstack.org/206239 | 22:15 |
*** jasondot_ has quit IRC | 22:15 | |
*** harlowja_ has quit IRC | 22:21 | |
*** harlowja has joined #openstack-cinder | 22:21 | |
openstackgerrit | Danny Wilson proposed openstack/cinder: Add discard to connection properties https://review.openstack.org/205717 | 22:23 |
*** raunak has quit IRC | 22:24 | |
*** xyang has quit IRC | 22:24 | |
*** raunak has joined #openstack-cinder | 22:24 | |
*** marcusvrn has quit IRC | 22:25 | |
tsekiyama | patrickeast: thanks, I'm looking into it. | 22:28 |
openstackgerrit | Sonia Ghanekar proposed openstack/cinder: Nimble driver version shows the correct version instead of N/A in the volume.log https://review.openstack.org/206239 | 22:30 |
*** robotiX has joined #openstack-cinder | 22:42 | |
thingee | tsekiyama: which group does show_multiple_locations=True get set to? This not obvious from the commit message or /etc/glance/glance-api.conf | 22:44 |
*** robotiX has left #openstack-cinder | 22:45 | |
tsekiyama | thingee: It's [DEFAULT] section in /etc/glance/glance-api.conf. | 22:47 |
thingee | Ok, it would probably be good to have that in the glance sample conf or something | 22:47 |
tsekiyama | thingee: I agree | 22:47 |
*** annegentle has quit IRC | 22:50 | |
*** DericHorn-HP has joined #openstack-cinder | 22:51 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Adds framework for get_capabilities() feature https://review.openstack.org/201243 | 22:51 |
thingee | tsekiyama: ok, about to test things | 22:54 |
*** alexpilotti has quit IRC | 22:54 | |
*** akshai has quit IRC | 22:55 | |
openstackgerrit | Sonia Ghanekar proposed openstack/cinder: Nimble driver version shows the correct version instead of N/A in the volume.log https://review.openstack.org/206239 | 22:56 |
*** Apoorva has quit IRC | 22:57 | |
*** DericHorn-HP has quit IRC | 22:58 | |
thingee | tsekiyama: things exploded :( http://paste.openstack.org/show/405981/ | 22:59 |
thingee | tsekiyama: this was uploading to image | 22:59 |
tsekiyama | thingee: hmm | 23:00 |
tsekiyama | thingee: let me see what is wrong... | 23:00 |
patrickeast | oh sweet, i’m seeing that too… i thought for sure my cache stuff i’m playing with was breaking it | 23:00 |
*** r-daneel has quit IRC | 23:02 | |
patrickeast | thingee: tsekiyama: fwiw i only see that error uploading a volume to image with the v2 glance api enabled | 23:02 |
*** jwcroppe has quit IRC | 23:02 | |
patrickeast | enabled in cinder.conf* | 23:03 |
*** jwcroppe has joined #openstack-cinder | 23:03 | |
*** DericHorn-HP has joined #openstack-cinder | 23:05 | |
thingee | patrickeast: the patch noted it has to be v2, did it succeed for you with v1? | 23:06 |
* thingee is happy patrickeast is also trying this | 23:06 | |
tsekiyama | patrickeast: thingee: ah... so it is a cinder bug, not related to this patch | 23:06 |
*** arahal has joined #openstack-cinder | 23:06 | |
*** DericHorn-HP has quit IRC | 23:06 | |
patrickeast | thingee: i don’t even have the cinder:// url stuff enabled and just creating an image from volume with v2 enabled does it | 23:06 |
tsekiyama | thingee: can you try just "glance image-create --file ... ..." to create a new image? | 23:07 |
thingee | did you all know about http://apps.openstack.org/#tab=glance-images btw? | 23:08 |
*** jasondotstar has joined #openstack-cinder | 23:08 | |
thingee | bam! glance image-create command already ready http://apps.openstack.org/#tab=glance-images&asset=Ubuntu%20Trusty%2014 | 23:08 |
patrickeast | oh wow | 23:08 |
patrickeast | thats pretty sweet | 23:08 |
thingee | Yeah I'm really, really happy to see some of this surface. While I agree the foundation needs work first and foremost, this useful bits are quite appreciated!! | 23:09 |
tsekiyama | It's nice. if you add --store cinder (only supported by glance v1 API), you may put the image into cinder volume | 23:09 |
thingee | tsekiyama: so far it seems to be working. the image is in a saving state | 23:10 |
thingee | tsekiyama: fwiw, cinder upload-to-image was working fine for me previously. If it's not this patch, it might be v2 enabled what is hitting this issue | 23:12 |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Adds framework for get_capabilities() feature https://review.openstack.org/201243 | 23:12 |
*** annashen has quit IRC | 23:12 | |
*** jasondotstar has quit IRC | 23:13 | |
tsekiyama | thingee: Have you also applied my cinder patch for "efficient upload/download for glance cinder store"? | 23:16 |
thingee | tsekiyama: I applied the glance patch for rootwrap, made sure things are setup in /etc/glance/rootwrap.d, applied the Cinder patch, applied the glance_store patch | 23:17 |
*** annashen has joined #openstack-cinder | 23:17 | |
*** Apoorva has joined #openstack-cinder | 23:18 | |
thingee | tsekiyama: the only config changes I made is what's listed here https://review.openstack.org/#/c/201754/10 | 23:18 |
thingee | except for image_upload_use_cinder_backend and image_upload_use_internal_tenant | 23:18 |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Efficient volume copy for generic volume migration https://review.openstack.org/183701 | 23:18 |
tsekiyama | thingee: ah ok. then my cinder patch is doing something bad | 23:18 |
*** jaypipes has quit IRC | 23:19 | |
thingee | tsekiyama: have you tried applying the patches to a clean environment? | 23:19 |
tsekiyama | thingee: yeah, but it looks like there were rebase error before proposing the last revision | 23:20 |
patrickeast | so that error about the keys http://paste.openstack.org/show/405981/ looks like it is due to glance giving back a 204 and thus giving us None here https://github.com/openstack/cinder/blob/master/cinder/image/glance.py#L329 | 23:22 |
openstackgerrit | Vilobh Meshram proposed openstack/cinder: ConsistencyGroup Object https://review.openstack.org/163641 | 23:22 |
thingee | patrickeast: ah, yeah I thought it might be related to v1 and v2 differences | 23:22 |
patrickeast | which is different than the rebase error which will look like http://paste.openstack.org/show/405975/ | 23:22 |
*** annashen has quit IRC | 23:23 | |
patrickeast | thingee: yea, i wonder if this is a glance bug or if we are expecting the wrong thing | 23:24 |
patrickeast | doh, glance is behaving as expected http://developer.openstack.org/api-ref-image-v2.html#storeImageFile-v2 | 23:27 |
patrickeast | this call is wrong https://github.com/openstack/cinder/blob/master/cinder/image/glance.py#L326 | 23:28 |
patrickeast | there is not image_meta coming back from that upload call | 23:28 |
*** jasondot_ has joined #openstack-cinder | 23:28 | |
thingee | patrickeast: was it for v1? | 23:29 |
patrickeast | thingee: for v1 we call a different method, which does appear to return the new image data | 23:29 |
thingee | ok so v2 glance in cinder is just broken regardless | 23:30 |
patrickeast | i think so | 23:30 |
tsekiyama | looks like the returned value from v2 is really different from v1 | 23:31 |
thingee | tsekiyama: yeah that's what patrickeast was saying | 23:31 |
*** salv-orlando has quit IRC | 23:32 | |
*** arahal has quit IRC | 23:37 | |
*** arahal has joined #openstack-cinder | 23:37 | |
*** arahal has quit IRC | 23:37 | |
tsekiyama | thingee: I'm wondering why it is trying to upload the image data. It should just register the location to Glance and if that succeeds, it won't upload the data. Do you have some other error logs before http://paste.openstack.org/show/405981/ ? | 23:38 |
*** markvoelker has quit IRC | 23:40 | |
*** erlon has quit IRC | 23:43 | |
*** jasondotstar has joined #openstack-cinder | 23:44 | |
*** DericHorn-HP has joined #openstack-cinder | 23:44 | |
*** diogogmt has quit IRC | 23:44 | |
*** jasondot_ has quit IRC | 23:47 | |
*** vokt has quit IRC | 23:48 | |
*** bswartz has joined #openstack-cinder | 23:51 | |
tsekiyama | thingee: okey I confirmed "upload-to-image --disk-format=qcow2 --container-format=bare vol1 img1" fails when glance_api_version is set to 2 even without any patches. | 23:53 |
*** Yogi1 has joined #openstack-cinder | 23:56 | |
*** dannywilson has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!