*** jwang has quit IRC | 00:00 | |
*** jwang has joined #openstack-cinder | 00:00 | |
patrickeast | tsekiyama: i think if we change https://github.com/openstack/cinder/blob/master/cinder/image/glance.py#L326 to be more like http://paste.openstack.org/show/405989/ it should do what we expect | 00:01 |
---|---|---|
patrickeast | what i’m not sure of though is if anyone actually needs the metadata | 00:01 |
patrickeast | looks like upload_volume in image_utils.py doesn’t actually use the return value anyway | 00:02 |
tsekiyama | patrickeast: Confirmed that it works as expectedly | 00:03 |
tsekiyama | patrickeast: but I'm not sure why it actually need metadata.. | 00:04 |
patrickeast | tsekiyama: i dont think it does all the places in here where its called we ignore the return value https://github.com/openstack/cinder/blob/master/cinder/image/image_utils.py#L339 | 00:04 |
* patrickeast is searching around other places to verify | 00:04 | |
patrickeast | unfortunately searching for .update( finds a lot of stuff : ( | 00:05 |
tsekiyama | patrickeast: yeah.. maybe we could just remove the returning values and run unittests to check what will fail.. | 00:06 |
patrickeast | tsekiyama: good idea | 00:06 |
patrickeast | tsekiyama: in theory if it breaks anyone too bad it should show up on their 3rd party ci too | 00:07 |
*** timcl has quit IRC | 00:07 | |
thingee | is there any documentation on glance artifacts? | 00:07 |
thingee | I don't have the patience for the video presentation I found from the paris summit. | 00:08 |
patrickeast | thingee: i haven’t found any good sources | 00:08 |
thingee | lol | 00:08 |
*** markvoelker has joined #openstack-cinder | 00:09 | |
tsekiyama | patrickeast: haven't seen anything yet either | 00:09 |
*** Guest10__ has joined #openstack-cinder | 00:09 | |
patrickeast | thingee: the best docs i could find were scattered around in here http://docs.openstack.org/developer/glance/ | 00:10 |
thingee | patrickeast: I did a search in that, and all I got was the metadata catalog | 00:11 |
thingee | On how I can search on artifacts. | 00:11 |
tsekiyama | or glance specs? http://specs.openstack.org/openstack/glance-specs/specs/kilo/artifact-repository.html | 00:11 |
thingee | I still don't know what a dang artifact is. | 00:12 |
thingee | ah I see | 00:13 |
thingee | tsekiyama: thanks | 00:13 |
thingee | wow, now that's a spec | 00:14 |
thingee | tsekiyama: how well are artifacts working out in glance, you know? | 00:14 |
patrickeast | haha yea, thats the most detailed one i’ve ever seen | 00:14 |
*** andreykurilin__ has quit IRC | 00:14 | |
tsekiyama | thingee: I don't know much about it | 00:15 |
thingee | tsekiyama: ok so I'm assuming you're looking into this bug already? | 00:16 |
* thingee checks if there's already an open bug | 00:16 | |
tsekiyama | thingee: yep, and confirmed that patrickeast's patch fixes it | 00:17 |
thingee | Couldn't find a bug. I'll report it | 00:17 |
tsekiyama | ok | 00:17 |
thingee | tsekiyama, patrickeast: not the first time this has happened https://bugs.launchpad.net/cinder/+bug/1210467 | 00:19 |
openstack | Launchpad bug 1210467 in Cinder "cinder upload-to-image broken with v2 glance api" [Undecided,Fix released] - Assigned to Edward Hope-Morley (hopem) | 00:19 |
patrickeast | mebbe we should add some check/gate tests that use v2 glance | 00:20 |
patrickeast | although i suppose thats easier said than done | 00:20 |
thingee | tsekiyama, patrickeast: anyone able to verify kilo? | 00:21 |
*** jasondotstar has quit IRC | 00:21 | |
*** angela-s has quit IRC | 00:21 | |
thingee | tsekiyama: https://bugs.launchpad.net/cinder/+bug/1478737 | 00:22 |
openstack | Launchpad bug 1478737 in Cinder "Cinder upload-to-image with glance v2 fails" [Medium,In progress] - Assigned to Tomoki Sekiyama (tsekiyama) | 00:22 |
tsekiyama | thingee: ok I'll try it on Kilo too | 00:22 |
*** jasondotstar has joined #openstack-cinder | 00:22 | |
*** dims has quit IRC | 00:22 | |
patrickeast | i don’t have a kilo env ready right now, could spin one up if needed | 00:23 |
patrickeast | thingee: tsekiyama: although a quick check of the code appears that it should repro on kilo too | 00:23 |
tsekiyama | my kilo env is killed by OOM lol | 00:25 |
*** mtanino_ has joined #openstack-cinder | 00:25 | |
patrickeast | lol | 00:25 |
*** mtanino has quit IRC | 00:26 | |
tsekiyama | mm sorry i'll check it tomorrow | 00:27 |
*** tsekiyam_ has joined #openstack-cinder | 00:27 | |
patrickeast | i’ve got one stacking right now… take a few min and i can verify | 00:29 |
tsekiyam_ | great | 00:29 |
*** xyang has joined #openstack-cinder | 00:30 | |
*** tsekiyama has quit IRC | 00:31 | |
*** dims has joined #openstack-cinder | 00:32 | |
*** xyang has quit IRC | 00:33 | |
*** salv-orlando has joined #openstack-cinder | 00:33 | |
*** DericHorn-HP has quit IRC | 00:37 | |
*** salv-orlando has quit IRC | 00:37 | |
*** laughterwym has joined #openstack-cinder | 00:39 | |
*** jasondotstar is now known as jasondotstar|afk | 00:43 | |
thingee | patrickeast: so what's the plan now with your caching work and this cinder glance store being revived? | 00:45 |
thingee | I guess you still need both | 00:45 |
patrickeast | thingee: heh yea good question | 00:45 |
patrickeast | so i’ve though about this a bunch | 00:45 |
patrickeast | i really don’t like the idea of having two code paths doing such similar things | 00:46 |
patrickeast | but i can’t figure out a good way around it | 00:46 |
*** heyun has joined #openstack-cinder | 00:46 | |
patrickeast | the biggest problem is the image formats | 00:46 |
patrickeast | the cinder backend stuff only helps out a bunch if they are raw | 00:46 |
*** openstackgerrit has quit IRC | 00:46 | |
patrickeast | or if we code the cinder backend to do something tricky like keep the original image data in one volume and a second copy as a raw one to clone off of (basically what the cache does) | 00:47 |
patrickeast | but there is not limiations for it | 00:47 |
patrickeast | and you would need to duplicate it around on all your cinder backends | 00:47 |
*** openstackgerrit has joined #openstack-cinder | 00:47 | |
patrickeast | so i came back to the conclusion that a cache which glance doesn’t need to know about still makes sense | 00:47 |
thingee | patrickeast: so in the end, how are communicating to operators why you need one or the other? | 00:48 |
thingee | tsekiyam_: ^ | 00:48 |
patrickeast | thingee: i don’t have a real solid plan for that yet | 00:49 |
patrickeast | they kind of have different use cases | 00:49 |
*** _cjones_ has quit IRC | 00:50 | |
patrickeast | the cache isn’t really a viable solution if you just want to use cinder as the glance backend to store all the images, but if you still want some improvement and to keep your glance stuff using swift or whatever its a nice alternative | 00:50 |
patrickeast | or for like our customers, i’m sure i would be looked at like an idiot if i told them the only way they got fast image operations is to put *all* the images on their tier 1 flash array | 00:51 |
thingee | patrickeast: just to make sure I understand myself, you use the glance store know about a single storage backend. Sometimes the copy will be quick we're cloning to the same storage backend. However, you cache work will just work across all backends and still involves glance keeping track of what volumes still represent an image? | 00:51 |
thingee | wow lots of typos in that | 00:52 |
thingee | sorry | 00:52 |
patrickeast | haha no worries | 00:52 |
patrickeast | thingee: so the cache is per-backend | 00:52 |
thingee | yup | 00:52 |
patrickeast | thingee: and glance doesn’t know about it | 00:52 |
patrickeast | thingee: after the first copy you would see faster volume creation | 00:52 |
thingee | with you so far | 00:53 |
patrickeast | thingee: this is similar to tsekiyam_ ’s, but the big difference is in the image-volume formats | 00:53 |
patrickeast | thingee: so like for the cache, we download the image run it through qemu-whatever and get raw data on the volume | 00:53 |
patrickeast | thingee: we then clone that and stick it in the cache | 00:54 |
*** diogogmt has joined #openstack-cinder | 00:54 | |
patrickeast | thingee: if you are the glance backend you might have a volume but the data is actually qcow or some other compressed info | 00:54 |
patrickeast | thingee: so you can’t just directly clone it and run | 00:54 |
*** annashen has joined #openstack-cinder | 00:54 | |
patrickeast | thingee: in the case where it is a raw image with no container they function almost identical sans the size limiations and stuff the cache adds | 00:55 |
thingee | patrickeast: thanks for the explanation, that helps | 00:55 |
thingee | patrickeast: yeah I don't see a use case difference in there :P | 00:55 |
*** jbernard has quit IRC | 00:56 | |
patrickeast | thingee: haha | 00:56 |
*** jbernard has joined #openstack-cinder | 00:56 | |
thingee | patrickeast, tsekiyam_: here's my worry about these two efforts. We're going to focus on supporting both, people deploy the different options which effective do the same. we now have to support both | 00:56 |
thingee | patrickeast, tsekiyam_ unless there is a clear reason to have both, I'm unsure why we would want to continue to go down this path | 00:57 |
thingee | patrickeast: is your patch ready to go for testing? | 00:57 |
patrickeast | thingee: yea pretty much | 00:58 |
thingee | patrickeast: excellent going to spin up an environment now with it. I'm assuming it's fine for me to continue with lvm? | 00:59 |
*** annashen has quit IRC | 00:59 | |
thingee | patrickeast: if you don't mind, I'm going to reference this conversation on the ML to see if others have thoughts. | 01:00 |
thingee | patrickeast: I think your explanation is excellent to get people up to speed | 01:00 |
tsekiyam_ | thingee: One thing I can add to patrickeast's explanation is that my approach can skip uploading volume to Glance | 01:03 |
thingee | ah that's true | 01:04 |
tsekiyam_ | thingee: if the image format is raw. It just register the cloned volume url so it is quite fast even if the volume size if 1TB. | 01:04 |
patrickeast | thingee: tsekiyam_: i was actually playing with that with the cache too | 01:04 |
patrickeast | for any image format we can jus take a clone and toss it in the cache | 01:04 |
patrickeast | as a backup if the glance code tsekiyam_ added couldn’t handle it | 01:05 |
patrickeast | although i’m removing it in the next update (which is going up in the next few min if i can figure out how i broke this unit test) | 01:07 |
patrickeast | there are some things that would need to be reworked to make it work correctly | 01:07 |
*** lixiaoy1 has joined #openstack-cinder | 01:07 | |
thingee | tsekiyam_, patrickeast http://lists.openstack.org/pipermail/openstack-dev/2015-July/070714.html | 01:10 |
*** krypton has quit IRC | 01:11 | |
patrickeast | maybe a topic for the mid-cycle | 01:11 |
*** krypton has joined #openstack-cinder | 01:11 | |
thingee | patrickeast: oh there's a merge conflict with your patch | 01:13 |
*** Apoorva has quit IRC | 01:14 | |
patrickeast | thingee: tsekiyam_: good news… that bug doesn’t repro on kilo, bad news… not sure why | 01:14 |
patrickeast | thingee: oh uh… one sec | 01:14 |
thingee | lol | 01:14 |
tsekiyam_ | hmm? | 01:14 |
patrickeast | i’ve been rebasing the stupid thing for like the last 4 hours | 01:14 |
patrickeast | keep getting distracted | 01:14 |
openstackgerrit | Patrick East proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 01:15 |
thingee | patrickeast: haha, you'll never get things merged in OpenStack with that attitude! should be rebasing once an hour at least | 01:15 |
thingee | sheesh | 01:15 |
openstackgerrit | Tomoki Sekiyama proposed openstack/cinder: Efficient image download and upload for Glance Cinder backend https://review.openstack.org/201754 | 01:15 |
patrickeast | doh | 01:15 |
patrickeast | one more rebase | 01:15 |
tsekiyam_ | patrickeast: ^ hope this fixes the rebase mistakes | 01:15 |
openstackgerrit | Patrick East proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 01:15 |
*** Guest1___ has joined #openstack-cinder | 01:16 | |
*** krypton has quit IRC | 01:16 | |
patrickeast | tsekiyam_: did you test it? | 01:16 |
patrickeast | tsekiyam_: thats different from how i fixed it XD | 01:17 |
patrickeast | thingee: that latest one should be ok now, assuming the issue with create_volume got fixed | 01:17 |
*** jasondotstar|afk has quit IRC | 01:17 | |
thingee | patrickeast: patch set 21 still has cherry pick issues | 01:18 |
*** davechen has joined #openstack-cinder | 01:18 | |
*** Guest10__ has quit IRC | 01:18 | |
patrickeast | thingee: are you grabbing the dependant change too? | 01:19 |
thingee | patrickeast: of course not | 01:19 |
patrickeast | :D | 01:19 |
*** haomaiwang has quit IRC | 01:22 | |
thingee | patrickeast: alright environment is going up | 01:23 |
*** haomaiwang has joined #openstack-cinder | 01:23 | |
thingee | patrickeast: there's a beer with my name on it somewhere. I'll bb on later tonight if anyone wants to gossip on reviews | 01:24 |
*** davechen1 has joined #openstack-cinder | 01:24 | |
patrickeast | thingee: haha word, let me know if you run into issues that patchset | 01:24 |
thingee | also people keep in mind https://etherpad.openstack.org/p/cinder-liberty-2-reviews | 01:25 |
thingee | bunch of stuff merged. and some stuff moved out of liberty-2 that just doesn't stand a chance IMO. Very likely image caching, migration will be in there too | 01:25 |
*** davechen has quit IRC | 01:25 | |
*** davechen1 is now known as davechen | 01:26 | |
davechen | thingee: hi boss, | 01:26 |
*** vilobhmm has quit IRC | 01:26 | |
thingee | these are just going to liberty-3 of course | 01:26 |
thingee | davechen: don't call me boss :P | 01:26 |
davechen | thingee: yeah, I believe it's true. | 01:26 |
davechen | thingee: some question from me about the cinder client | 01:27 |
* thingee makes an angry look at jungleboyj | 01:27 | |
davechen | thingee: I am not sure whether it's correct, so want your answer. | 01:27 |
thingee | davechen: so simply, I just think people should be able to get the image metadata. | 01:27 |
thingee | it's not intuitive IMO to expect people to know to list the details of a volume to get image metadata | 01:28 |
davechen | thingee: yes, currently, we have the API already in the extenstions. | 01:28 |
thingee | davechen: excellent, then we're done on that part :) | 01:28 |
davechen | thingee: but it's used by cinder volume show/list command. | 01:28 |
davechen | thingee: if we explictly want a API to do that, should we do some refacoring? | 01:29 |
*** jwcroppe has quit IRC | 01:30 | |
*** Yogi1 has quit IRC | 01:30 | |
davechen | since, these API has been defined, and I assume it's been designed as this, not sure it's okay to that? change the meaning of these existing API or just expose somem new API to do that? | 01:30 |
*** jwcroppe has joined #openstack-cinder | 01:30 | |
thingee | I'm just looking at things like cinder metadata-show and cinder snapshot-metadata-show. Those all have cinder metadata set or cinder snapshot-metadata set ... so it just seems like it would be expected we'd have a cinder image-metadata-show | 01:31 |
thingee | if we're effectively adding in cinder image-metadata set | 01:31 |
davechen | thingee: so, we need some new API exposed in the cinder side? | 01:31 |
thingee | davechen: yes | 01:31 |
thingee | I don't know what other's think though | 01:32 |
thingee | that's just me thinking out loud of what's obvious to me | 01:32 |
thingee | davechen: I guess I'm saying take my advice, someone might disagree when they have time to review things :P | 01:33 |
davechen | that should be okay, I not sure other's opinion as well, so there will be two different APIs, one for cinder lists/show and one for cinder image-metadata stuff? | 01:33 |
thingee | davechen: but I'll argue my reason for having you do it. | 01:33 |
thingee | yes | 01:33 |
thingee | davechen: if you'll excuse me, I was about to step out for dinner. | 01:34 |
davechen | thingee: okay, excellent, both of them should be in the some module, I meant both of the APIs should be defined in volume_image_metadata extension, right? | 01:34 |
davechen | thingee: of course | 01:34 |
*** jwcroppe has quit IRC | 01:35 | |
davechen | thingee: I am going to propose a new patch both in the cinder cli and cinder API, it that okay? | 01:35 |
davechen | thingee: so we can let that patch go at first? | 01:35 |
thingee | yeah it looks like you can define an index method in the volume_image_metadata extension | 01:37 |
thingee | just like how volume_metadata and snapshot_metadata define the index method | 01:37 |
thingee | davechen: https://github.com/openstack/cinder/blob/master/cinder/api/v2/volume_metadata.py#L41 | 01:37 |
thingee | but yes, the volume_image_metadata extension change, and update to the cinder client will be correct | 01:38 |
thingee | I'll bbl | 01:38 |
thingee | davechen: thanks | 01:38 |
openstackgerrit | YuanHui Xu proposed openstack/cinder: Add mock cases for IBM FlashSystem https://review.openstack.org/205371 | 01:38 |
davechen | thingee: okay, got you. | 01:38 |
davechen | thingee: can we do these in a seperate review? | 01:39 |
davechen | thingee: we need at least two patches for that. | 01:40 |
davechen | thingee: one for cinder api change/ one for cinder client change, am i right? | 01:40 |
*** mylu has joined #openstack-cinder | 01:41 | |
*** Lee1092 has joined #openstack-cinder | 01:42 | |
*** leeantho has quit IRC | 01:43 | |
*** salv-orlando has joined #openstack-cinder | 01:44 | |
*** salv-orlando has quit IRC | 01:48 | |
openstackgerrit | wanghao proposed openstack/cinder: Implement function to manage/unmanage snapshots https://review.openstack.org/144590 | 01:51 |
*** abhi has quit IRC | 01:52 | |
*** abhi has joined #openstack-cinder | 01:53 | |
*** annashen has joined #openstack-cinder | 01:55 | |
*** mylu has quit IRC | 01:56 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add multiple pools support to VMAX driver https://review.openstack.org/189990 | 02:00 |
*** annashen has quit IRC | 02:00 | |
*** tsekiyam_ has quit IRC | 02:03 | |
*** mtanino_ has quit IRC | 02:06 | |
*** raunak has quit IRC | 02:09 | |
*** jasondotstar|afk has joined #openstack-cinder | 02:12 | |
*** annashen has joined #openstack-cinder | 02:17 | |
*** sghanekar_ has quit IRC | 02:17 | |
*** zhenguo has joined #openstack-cinder | 02:19 | |
*** bkopilov has quit IRC | 02:35 | |
*** dims has quit IRC | 02:35 | |
*** changbl has quit IRC | 02:37 | |
*** Guest1___ has quit IRC | 02:38 | |
*** zhonghua-lee has joined #openstack-cinder | 02:38 | |
*** mragupat has joined #openstack-cinder | 02:40 | |
*** mylu has joined #openstack-cinder | 02:44 | |
*** mylu has quit IRC | 02:45 | |
*** daneyon_ has quit IRC | 02:47 | |
openstackgerrit | wanghao proposed openstack/cinder: Incremental backup improvements for L https://review.openstack.org/188328 | 02:50 |
*** mragupat has quit IRC | 02:51 | |
*** hakimo_ has joined #openstack-cinder | 02:52 | |
*** patrickeast has quit IRC | 02:54 | |
*** hakimo has quit IRC | 02:54 | |
*** annashen_ has joined #openstack-cinder | 02:56 | |
openstackgerrit | wanghao proposed openstack/cinder: Fixing notify message of manager's manage_existing flow https://review.openstack.org/205896 | 02:58 |
*** annashen_ has quit IRC | 03:01 | |
*** Apoorva has joined #openstack-cinder | 03:07 | |
*** krypton has joined #openstack-cinder | 03:09 | |
*** BharatK has joined #openstack-cinder | 03:19 | |
*** jasondotstar|afk has quit IRC | 03:24 | |
*** diogogmt has quit IRC | 03:24 | |
*** DericHorn-HP has joined #openstack-cinder | 03:25 | |
*** jwcroppe has joined #openstack-cinder | 03:30 | |
*** edtubill has joined #openstack-cinder | 03:30 | |
*** edtubill has left #openstack-cinder | 03:31 | |
*** coolsvap|away is now known as coolsvap | 03:32 | |
*** annashen has quit IRC | 03:45 | |
*** julim has quit IRC | 03:46 | |
*** avishay has joined #openstack-cinder | 03:53 | |
*** vilobhmm has joined #openstack-cinder | 03:55 | |
*** annashen has joined #openstack-cinder | 03:57 | |
*** annashen has quit IRC | 04:01 | |
*** bkopilov has joined #openstack-cinder | 04:02 | |
*** jwcroppe has quit IRC | 04:02 | |
*** patrickeast has joined #openstack-cinder | 04:03 | |
*** jwcroppe has joined #openstack-cinder | 04:03 | |
*** markvoelker has quit IRC | 04:04 | |
*** jwcroppe_ has joined #openstack-cinder | 04:06 | |
*** jwcroppe has quit IRC | 04:08 | |
*** daneyon has joined #openstack-cinder | 04:09 | |
*** BharatK has quit IRC | 04:15 | |
*** jwcroppe_ has quit IRC | 04:16 | |
*** jwcroppe has joined #openstack-cinder | 04:17 | |
*** jwcroppe has quit IRC | 04:22 | |
*** daneyon has quit IRC | 04:22 | |
openstackgerrit | Apoorva Deshpande proposed openstack/cinder: Fix order of arguments in assertEqual https://review.openstack.org/206296 | 04:25 |
*** Apoorva has quit IRC | 04:32 | |
*** harlowja_at_home has joined #openstack-cinder | 04:32 | |
*** BharatK has joined #openstack-cinder | 04:33 | |
openstackgerrit | wanghao proposed openstack/cinder: Add pagination to backups https://review.openstack.org/204493 | 04:33 |
*** DericHorn-HP has quit IRC | 04:37 | |
*** krypton has quit IRC | 04:37 | |
*** BharatK has quit IRC | 04:38 | |
*** sgotliv has joined #openstack-cinder | 04:38 | |
*** DericHorn-HP has joined #openstack-cinder | 04:41 | |
*** BharatK has joined #openstack-cinder | 04:43 | |
*** DericHorn-HP has quit IRC | 04:46 | |
*** BharatK has quit IRC | 04:47 | |
*** BharatK has joined #openstack-cinder | 04:49 | |
*** sgotliv has quit IRC | 04:50 | |
*** abehl has joined #openstack-cinder | 04:50 | |
*** deepakcs has joined #openstack-cinder | 04:51 | |
*** shyama has joined #openstack-cinder | 04:54 | |
*** krypton has joined #openstack-cinder | 04:54 | |
*** patrickeast_ has joined #openstack-cinder | 04:54 | |
*** jwcroppe has joined #openstack-cinder | 04:56 | |
*** patrickeast has quit IRC | 04:56 | |
*** patrickeast_ is now known as patrickeast | 04:56 | |
*** jwcroppe has quit IRC | 04:58 | |
*** annashen has joined #openstack-cinder | 04:58 | |
*** jwcroppe has joined #openstack-cinder | 04:58 | |
*** jwcroppe_ has joined #openstack-cinder | 05:01 | |
*** annashen has quit IRC | 05:02 | |
*** jwcroppe has quit IRC | 05:03 | |
*** markvoelker has joined #openstack-cinder | 05:05 | |
lixiaoy1 | : thingee: I answered your comments in https://review.openstack.org/#/c/199846/, please have a look | 05:05 |
*** ub has quit IRC | 05:06 | |
*** markvoelker has quit IRC | 05:10 | |
*** e0ne has joined #openstack-cinder | 05:14 | |
*** DericHorn-HP has joined #openstack-cinder | 05:21 | |
*** harlowja_at_home has quit IRC | 05:32 | |
*** shyama has quit IRC | 05:35 | |
*** e0ne has quit IRC | 05:42 | |
*** DericHorn-HP has quit IRC | 05:43 | |
*** e0ne has joined #openstack-cinder | 05:44 | |
*** e0ne has quit IRC | 05:51 | |
*** jamielennox is now known as jamielennox|away | 05:52 | |
*** rushiagr_away is now known as rushiagr | 05:55 | |
*** salv-orlando has joined #openstack-cinder | 05:55 | |
*** e0ne has joined #openstack-cinder | 05:55 | |
*** agarciam has joined #openstack-cinder | 05:56 | |
*** jamielennox|away is now known as jamielennox | 05:56 | |
*** gaurangt has joined #openstack-cinder | 05:58 | |
*** annashen has joined #openstack-cinder | 05:59 | |
*** albertom has quit IRC | 06:01 | |
*** annashen has quit IRC | 06:03 | |
*** harlowja_at_home has joined #openstack-cinder | 06:04 | |
*** vlaza has joined #openstack-cinder | 06:06 | |
*** krypton_ has joined #openstack-cinder | 06:08 | |
*** albertom has joined #openstack-cinder | 06:09 | |
*** krypton has quit IRC | 06:11 | |
*** krypton_ has quit IRC | 06:12 | |
*** vilobhmm has quit IRC | 06:13 | |
*** e0ne has quit IRC | 06:13 | |
*** shyama has joined #openstack-cinder | 06:14 | |
*** chlong has quit IRC | 06:17 | |
*** patrickeast has quit IRC | 06:22 | |
*** harlowja_at_home has quit IRC | 06:23 | |
*** belmoreira has joined #openstack-cinder | 06:25 | |
deepakcs | thingee: https://review.openstack.org/#/c/150511/4/specs/liberty/standard-capabilities.rst | 06:29 |
deepakcs | thingee: reg. the Q on why snapshot is not considered as a capability, was curious to know your response to that. | 06:29 |
*** ub has joined #openstack-cinder | 06:33 | |
*** nkrinner has joined #openstack-cinder | 06:42 | |
*** afazekas has joined #openstack-cinder | 06:44 | |
-openstackstatus- NOTICE: zuul is stuck and about to undergo an emergency restart, please be patient as job results may take a long time | 06:44 | |
*** ChanServ changes topic to "zuul is stuck and about to undergo an emergency restart, please be patient as job results may take a long time" | 06:44 | |
*** jwcroppe_ has quit IRC | 06:48 | |
*** markus_z has joined #openstack-cinder | 06:59 | |
*** salv-orlando has quit IRC | 06:59 | |
*** annashen has joined #openstack-cinder | 07:00 | |
*** annashen has quit IRC | 07:05 | |
*** markvoelker has joined #openstack-cinder | 07:06 | |
*** markvoelker has quit IRC | 07:11 | |
openstackgerrit | Dave Chen proposed openstack/cinder: Role based properties protection https://review.openstack.org/160090 | 07:12 |
openstackgerrit | liuxinguo proposed openstack/cinder: Add iSCSI multipath support for Huawei driver https://review.openstack.org/188365 | 07:19 |
*** ishant__ has joined #openstack-cinder | 07:21 | |
*** sgotliv has joined #openstack-cinder | 07:23 | |
openstackgerrit | Dave Chen proposed openstack/cinder: Policies based properties protection https://review.openstack.org/160145 | 07:29 |
*** shyama has quit IRC | 07:34 | |
*** lpetrut has joined #openstack-cinder | 07:34 | |
*** e0ne has joined #openstack-cinder | 07:37 | |
*** salv-orlando has joined #openstack-cinder | 07:50 | |
*** coolsvap is now known as coolsvap|away | 07:57 | |
*** agarciam has quit IRC | 07:57 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add iSCSI multipath support for Huawei driver https://review.openstack.org/188365 | 07:57 |
*** sgotliv has quit IRC | 07:58 | |
*** agarciam has joined #openstack-cinder | 08:00 | |
*** annashen has joined #openstack-cinder | 08:01 | |
*** abehl has quit IRC | 08:01 | |
*** ChanServ changes topic to "The OpenStack Block Storage Project Cinder | The New Kids On the Block | https://wiki.openstack.org/wiki/Cinder" | 08:01 | |
-openstackstatus- NOTICE: zuul has been restarted and queues restored. It may take some time to work through the backlog. | 08:01 | |
*** jwcroppe has joined #openstack-cinder | 08:02 | |
openstackgerrit | Szymon Wróblewski proposed openstack/cinder: POC: Tooz locks demo https://review.openstack.org/185646 | 08:02 |
openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Tooz locks https://review.openstack.org/183537 | 08:02 |
*** jistr has joined #openstack-cinder | 08:03 | |
*** annashen has quit IRC | 08:05 | |
*** jordanP has joined #openstack-cinder | 08:07 | |
*** kjelly has joined #openstack-cinder | 08:12 | |
*** ndipanov has quit IRC | 08:12 | |
kjelly | Hi guys, does anyone know why the condition is "project_only and is_user_context(context)" instead of "project_only"? https://github.com/openstack/cinder/blame/master/cinder/db/sqlalchemy/api.py#L257 | 08:13 |
*** sgotliv has joined #openstack-cinder | 08:20 | |
*** shyama has joined #openstack-cinder | 08:22 | |
*** bluex-pl has joined #openstack-cinder | 08:29 | |
*** bluex-pl has quit IRC | 08:29 | |
*** bluex-pl has joined #openstack-cinder | 08:30 | |
*** alexpilotti has joined #openstack-cinder | 08:33 | |
dulek | kjelly: I guess it's for the situation when we have project_only and user isn't admin. | 08:33 |
dulek | kjelly: User can see only resources from his own project. | 08:33 |
dulek | kjelly: And admin can see all of the resources. | 08:34 |
dulek | kjelly: I think that's why the filter is added here. | 08:34 |
*** agarciam has quit IRC | 08:35 | |
*** agarciam has joined #openstack-cinder | 08:36 | |
*** ub has quit IRC | 08:36 | |
*** ub has joined #openstack-cinder | 08:39 | |
openstackgerrit | wanghao proposed openstack/cinder: Enhance deletion efficiency when backup init host https://review.openstack.org/206359 | 08:41 |
*** aix has joined #openstack-cinder | 08:45 | |
kjelly | If admin want to see all of the resources, we can just set project_only to false to get all data. | 08:45 |
*** laughterwym has quit IRC | 08:45 | |
kjelly | dulek: If admin want to see all of the resources, we can just set project_only to false to get all data. | 08:45 |
kjelly | dulek: "project_only and is_user_context(context)" means that admin always get all resources. | 08:46 |
dulek | kjelly: :param project_only: if present and context is user-type, then restrict query to match the context's project_id. | 08:47 |
dulek | kjelly: I guess that's the point of project_only param. | 08:48 |
kjelly | dulek: I am working on the bug. https://bugs.launchpad.net/cinder/+bug/1477625 . the bug happened because cinder will add admin role to contxt , so user can show any volumes. | 08:52 |
openstack | Launchpad bug 1477625 in Cinder "DB access to show volumes may not be properly controlled" [Undecided,Confirmed] - Assigned to jelly (coding1314) | 08:52 |
kjelly | dulek: If the condition is "project_only" instead of "project_only and is_user_context(context)", we don't have the problem because we just get the volume in project. | 08:53 |
dulek | kjelly: Ah, I get it. You're probably right... | 08:55 |
kjelly | dulek: If the condition is "project_only" and admin want to get all resources, we can just pass project_only to false to get all volumes. | 08:55 |
*** coolsvap|away is now known as coolsvap | 08:56 | |
dulek | kjelly: I think there's --all-tenants param. | 08:56 |
*** sgotliv has quit IRC | 08:59 | |
kjelly | dulek: By the way, to solve the bug 1477625, maybe we can add "viewable_admin_meta" param to db.volume_get instead of using context.elevated. https://github.com/openstack/cinder/commit/0505bb268942534ad5d6ecd5e34a4d9b0e7f5c04#diff-33011bbeb0dd51161827701307e6d033R265 | 09:01 |
openstack | bug 1477625 in Cinder "DB access to show volumes may not be properly controlled" [Undecided,Confirmed] https://launchpad.net/bugs/1477625 - Assigned to jelly (coding1314) | 09:01 |
*** annashen has joined #openstack-cinder | 09:01 | |
*** jwcroppe has quit IRC | 09:02 | |
openstackgerrit | Pradeep Sathasivam proposed openstack/cinder: Adds VF support with HTTPS southbound connector https://review.openstack.org/184799 | 09:02 |
dulek | kjelly: This also seems possible to me. | 09:04 |
*** ub has quit IRC | 09:06 | |
*** annashen has quit IRC | 09:06 | |
*** ub has joined #openstack-cinder | 09:07 | |
*** markvoelker has joined #openstack-cinder | 09:07 | |
*** boris-42 has quit IRC | 09:10 | |
*** markvoelker has quit IRC | 09:11 | |
*** ndipanov has joined #openstack-cinder | 09:12 | |
*** jwcroppe has joined #openstack-cinder | 09:16 | |
*** jwcroppe has quit IRC | 09:16 | |
mkoderer | thingee: I put my comment on jgriffith rework (https://review.openstack.org/#/c/201812/) | 09:19 |
mkoderer | thingee: I planed to have a small design session with john.. but unfortunately currently I am a bit busy with other tasks | 09:20 |
*** agarciam has quit IRC | 09:22 | |
*** agarciam has joined #openstack-cinder | 09:22 | |
*** agarciam has quit IRC | 09:23 | |
*** abhishekk has joined #openstack-cinder | 09:24 | |
*** jasondotstar|afk has joined #openstack-cinder | 09:29 | |
*** agarciam has joined #openstack-cinder | 09:35 | |
*** sasi has joined #openstack-cinder | 09:36 | |
*** sasi has left #openstack-cinder | 09:37 | |
*** jwcroppe has joined #openstack-cinder | 09:38 | |
*** jwcroppe has quit IRC | 09:42 | |
*** lixiaoy1 has quit IRC | 09:44 | |
*** davechen has left #openstack-cinder | 09:52 | |
openstackgerrit | Kuo-tung Kao proposed openstack/cinder: non-admin user don't get volumes in other project https://review.openstack.org/206450 | 09:52 |
*** kjelly has quit IRC | 09:53 | |
*** kjelly has joined #openstack-cinder | 09:53 | |
*** kjelly has quit IRC | 09:54 | |
*** jasondotstar|afk has quit IRC | 09:54 | |
*** aix has quit IRC | 09:55 | |
*** Zhongjun has joined #openstack-cinder | 09:57 | |
*** ronis has joined #openstack-cinder | 09:59 | |
*** annashen has joined #openstack-cinder | 10:02 | |
*** jwcroppe has joined #openstack-cinder | 10:04 | |
*** annashen has quit IRC | 10:07 | |
*** jasondotstar|afk has joined #openstack-cinder | 10:12 | |
openstackgerrit | Lei Zhang proposed openstack/cinder: Make concurrent backups for same volume impossible https://review.openstack.org/202914 | 10:16 |
*** jwcroppe has quit IRC | 10:19 | |
*** aix has joined #openstack-cinder | 10:22 | |
*** dims has joined #openstack-cinder | 10:31 | |
*** salv-orl_ has joined #openstack-cinder | 10:34 | |
*** salv-orlando has quit IRC | 10:37 | |
*** heyun has quit IRC | 10:44 | |
*** gaurangt has left #openstack-cinder | 10:44 | |
*** salv-orl_ has quit IRC | 10:47 | |
*** timcl has joined #openstack-cinder | 10:51 | |
*** ankit_ag has joined #openstack-cinder | 10:55 | |
*** avishay_ has joined #openstack-cinder | 10:56 | |
*** avishay has quit IRC | 10:57 | |
*** salv-orlando has joined #openstack-cinder | 11:00 | |
*** salv-orl_ has joined #openstack-cinder | 11:01 | |
*** annashen has joined #openstack-cinder | 11:03 | |
*** salv-orlando has quit IRC | 11:05 | |
*** ishant__ has quit IRC | 11:05 | |
*** annashen has quit IRC | 11:07 | |
*** markvoelker has joined #openstack-cinder | 11:08 | |
*** markvoelker has quit IRC | 11:13 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add iSCSI multipath support for Huawei driver https://review.openstack.org/188365 | 11:14 |
*** zhonghua-lee has quit IRC | 11:21 | |
*** marcusvrn has joined #openstack-cinder | 11:21 | |
*** sgotliv has joined #openstack-cinder | 11:22 | |
*** breitz1 has joined #openstack-cinder | 11:25 | |
*** breitz has quit IRC | 11:25 | |
openstackgerrit | liuxinguo proposed openstack/cinder: Add iSCSI multipath support for Huawei driver https://review.openstack.org/188365 | 11:28 |
openstackgerrit | liuxinguo proposed openstack/cinder: Add iSCSI multipath support for Huawei driver https://review.openstack.org/188365 | 11:35 |
*** gaurangt has joined #openstack-cinder | 11:36 | |
*** abehl has joined #openstack-cinder | 11:36 | |
*** coolsvap is now known as coolsvap|away | 11:37 | |
*** gaurangt has left #openstack-cinder | 11:39 | |
openstackgerrit | Bharat Kumar Kobagana (BharatK) proposed openstack/cinder: GlusterFS backup driver https://review.openstack.org/182254 | 11:40 |
openstackgerrit | Bharat Kumar Kobagana (BharatK) proposed openstack/cinder: Posix backup driver https://review.openstack.org/163647 | 11:40 |
*** samueldmq has joined #openstack-cinder | 11:41 | |
samueldmq | morning | 11:41 |
samueldmq | I need to discover identity url from inside cinder | 11:41 |
samueldmq | I have two options, i) look at the service catalog of the token or ii) look at the config encryption_auth_url | 11:42 |
samueldmq | is that config always set properly ? | 11:42 |
*** bkopilov has quit IRC | 11:45 | |
*** jasondotstar|afk has quit IRC | 11:46 | |
*** jwcroppe has joined #openstack-cinder | 11:51 | |
openstackgerrit | Jordan Pittier proposed openstack/os-brick: Remotefs: add ScalityFS support https://review.openstack.org/196631 | 11:53 |
openstackgerrit | Bharat Kumar Kobagana (BharatK) proposed openstack/cinder: GlusterFS: Using 'fallocate' instead of 'dd' to create raw volumes https://review.openstack.org/164527 | 11:55 |
*** annashen has joined #openstack-cinder | 12:04 | |
*** agarciam has quit IRC | 12:08 | |
*** agarciam has joined #openstack-cinder | 12:08 | |
*** markvoelker has joined #openstack-cinder | 12:09 | |
*** annashen has quit IRC | 12:09 | |
*** Zhongjun has quit IRC | 12:12 | |
*** markvoelker has quit IRC | 12:14 | |
openstackgerrit | Bharat Kumar Kobagana (BharatK) proposed openstack/cinder: GlusterFS: 'fallocate' instead of 'dd' to create raw volumes https://review.openstack.org/164527 | 12:18 |
*** jwcroppe has quit IRC | 12:19 | |
*** jwcroppe has joined #openstack-cinder | 12:20 | |
*** laughterwym has joined #openstack-cinder | 12:21 | |
*** akerr has joined #openstack-cinder | 12:24 | |
*** eharney has joined #openstack-cinder | 12:28 | |
*** markvoelker has joined #openstack-cinder | 12:29 | |
*** edmondsw has joined #openstack-cinder | 12:33 | |
*** bswartz has quit IRC | 12:35 | |
*** jasondotstar|afk has joined #openstack-cinder | 12:37 | |
*** timcl has quit IRC | 12:38 | |
DuncanT | samueldmq: no that property is not always set. | 12:38 |
*** timcl has joined #openstack-cinder | 12:39 | |
DuncanT | samueldmq: config rather. You should look in the context catalogue | 12:39 |
*** BharatK has quit IRC | 12:42 | |
*** zhenguo has quit IRC | 12:42 | |
*** coolsvap|away is now known as coolsvap | 12:45 | |
samueldmq | DuncanT: nice, I was discussing with jamielennox in #keystone about that.. actually the ksmiddleware already instantiates the ksclient plugin to check if tokens are valid, etc | 12:48 |
samueldmq | DuncanT: after that, it passes the plugin down as a env var, that could be re-used by cinder | 12:49 |
samueldmq | DuncanT: nova already does that | 12:49 |
samueldmq | DuncanT: this is how middleware passes it down : https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L164 | 12:49 |
samueldmq | DuncanT: and nova code using it : https://github.com/openstack/nova/blob/master/nova/context.py#L37 | 12:49 |
*** jasondotstar|afk is now known as jasondotstar | 12:49 | |
samueldmq | DuncanT: basically to not re-create the code for parsing the catalog, etc :) | 12:50 |
*** changbl has joined #openstack-cinder | 12:50 | |
DuncanT | samueldmq: patches welcome. What do you want the keystone server for? | 12:52 |
DuncanT | samueldmq: backup code already looks in the catalogue to find swift btw | 12:53 |
samueldmq | DuncanT: hmm, do you have a pointer to that code | 12:54 |
samueldmq | DuncanT: actually we are implementing hierarchical quotas (cc ericksonsantos) | 12:54 |
samueldmq | DuncanT: so we need to know the project hierarchy | 12:54 |
*** julim has joined #openstack-cinder | 12:55 | |
samueldmq | DuncanT: (asking keystone server) | 12:55 |
*** changbl has quit IRC | 12:55 | |
DuncanT | samueldmq: got you. Give me two minutes to find that code | 12:56 |
*** BharatK has joined #openstack-cinder | 12:56 | |
*** rushiagr is now known as rushiagr_away | 12:56 | |
samueldmq | DuncanT: sure :) | 12:57 |
*** merooney has joined #openstack-cinder | 12:57 | |
DuncanT | backup/drivers/swift.py:130 | 12:58 |
openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Tooz locks https://review.openstack.org/183537 | 13:00 |
*** afazekas has quit IRC | 13:02 | |
*** annashen has joined #openstack-cinder | 13:05 | |
DuncanT | samueldmq: backup/drivers/swift.py:130 | 13:06 |
DuncanT | samueldmq: Fixing the barbican plugin so that is doesn't need the keystone url in the config (and also so that it can pick the barbican url out of the catalog) would be nice too | 13:07 |
openstackgerrit | Eric Harney proposed openstack/cinder: Fix update_migrate_volume() exception handling https://review.openstack.org/198731 | 13:08 |
*** annashen has quit IRC | 13:09 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Move update_migrated_volume() to BaseVD https://review.openstack.org/198731 | 13:10 |
*** xyang1 has joined #openstack-cinder | 13:12 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Log which service is down https://review.openstack.org/206211 | 13:12 |
*** edmondsw has quit IRC | 13:14 | |
*** xyang has joined #openstack-cinder | 13:14 | |
*** ganso_ has joined #openstack-cinder | 13:15 | |
*** bswartz has joined #openstack-cinder | 13:15 | |
*** kjelly_ has joined #openstack-cinder | 13:17 | |
*** kjelly_ is now known as kjelly | 13:17 | |
*** xyang1 has quit IRC | 13:17 | |
*** mylu has joined #openstack-cinder | 13:19 | |
*** rushiagr_away is now known as rushiagr | 13:21 | |
*** Zhongjun has joined #openstack-cinder | 13:21 | |
openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Tooz locks https://review.openstack.org/183537 | 13:22 |
*** Yogi1 has joined #openstack-cinder | 13:24 | |
bluex-pl | geguileo: hi | 13:26 |
DuncanT | eharney: Thanks for a review I'm not in any way conflicted or confused about, I needed that | 13:26 |
geguileo | bluex-pl: hi | 13:26 |
eharney | DuncanT: glad to help :) | 13:26 |
bluex-pl | i just finished reading your blog post and looking through poc patches, very interesting | 13:28 |
*** xyang1 has joined #openstack-cinder | 13:28 | |
bluex-pl | I would like to propose merging https://review.openstack.org/#/c/205840/ into https://review.openstack.org/#/c/183537/ and adding you as co-author | 13:29 |
geguileo | bluex-pl: Sounds good to me | 13:30 |
ericksonsantos | DuncanT, thanks for point it out. Since encryption_auth_url conf is not always set, I think we really need to get the keystone url from the service catalog. | 13:30 |
geguileo | bluex-pl: We would need to add tests for the code in my patch though | 13:30 |
bluex-pl | geguileo: sure, consider it done | 13:30 |
geguileo | bluex-pl: Awesome! | 13:30 |
*** akshai has joined #openstack-cinder | 13:31 | |
geguileo | bluex-pl: By the way, I really liked your Tooz patch :-) | 13:31 |
bluex-pl | geguileo: Thanks ^^ | 13:31 |
DuncanT | ericksonsantos: Sounds like the right answer to me. I'm just working on a patch to remove the requirement for the barbican service URL from the plugin, I'll keep an eye out for your patch and consider using whatever technique you guys use to get the keystone url to remove the need for encryption_auth_url too | 13:32 |
dulek | geguileo: Do you think that a part of your approach can get into L? | 13:33 |
ericksonsantos | DuncanT, nice :) | 13:33 |
geguileo | dulek: Depends on whether we decide is the right approach or not and who else would be collaborating | 13:34 |
dulek | geguileo: I'm not sure if you saw my spec - https://review.openstack.org/#/c/202615/ | 13:34 |
geguileo | dulek: No, I didn't :( | 13:34 |
dulek | geguileo: I think it is compatible with your approach, just describes first steps - that is locks. | 13:34 |
geguileo | dulek: I have been in EuroPython | 13:34 |
*** abehl has quit IRC | 13:35 | |
geguileo | dulek: I'll read your spec | 13:35 |
dulek | geguileo: Thanks :) | 13:35 |
geguileo | dulek: Sorry I didn't see it earlier and thanks for pointing it out :) | 13:35 |
dulek | geguileo: I have also some questions on approach described in the blogpost. | 13:35 |
geguileo | dulek: Shoot | 13:36 |
smcginnis | hemna: Congrats on the nova os-brick patch! | 13:36 |
dulek | geguileo: For example - how do you plan to take LVM-like drivers? | 13:37 |
dulek | geguileo: When scheduler decides where the request will go. | 13:37 |
geguileo | Well, in theory you cannot have A-A on LVM, right? | 13:37 |
geguileo | Sorry, stupid comment | 13:38 |
dulek | geguileo: Right. Sorry, I'll get back to you in a moment. | 13:39 |
geguileo | dulek: The scheduler will decide on a cluster, not a specific node, right? | 13:39 |
*** sgotliv_ has joined #openstack-cinder | 13:40 | |
*** sgotliv has quit IRC | 13:41 | |
samueldmq | DuncanT: sorry I was holding another conversation in #keystone | 13:41 |
samueldmq | DuncanT: thanks for the links :) | 13:41 |
DuncanT | samueldmq: You're welcome | 13:42 |
*** bkopilov has joined #openstack-cinder | 13:45 | |
*** deepakcs has quit IRC | 13:47 | |
*** abehl has joined #openstack-cinder | 13:48 | |
*** thangp has joined #openstack-cinder | 13:50 | |
*** belmoreira has quit IRC | 13:51 | |
*** edmondsw has joined #openstack-cinder | 13:51 | |
openstackgerrit | Curt Bruns proposed openstack/os-brick: WIP: Set executor to Putils https://review.openstack.org/206549 | 13:59 |
openstackgerrit | Curt Bruns proposed openstack/os-brick: WIP: Set executor to Putils https://review.openstack.org/206549 | 14:01 |
dulek | geguileo: I'm here again, sorry - it's always multiple people want something when I'm talking. | 14:03 |
geguileo | dulek: Jaja, no problem :) | 14:03 |
dulek | geguileo: We probably want to have scheduler to decide on particular node. | 14:03 |
dulek | geguileo: So it will use the filters. | 14:04 |
geguileo | dulek: I disagree | 14:04 |
dulek | geguileo: I mean in case of LVM. | 14:04 |
geguileo | dulek: In my opinion scheduler selects backend | 14:04 |
geguileo | dulek: And he doesn't care which node of the cluster does the operation | 14:04 |
geguileo | dulek: Since the backend is the same | 14:05 |
*** abhishekk has quit IRC | 14:05 | |
geguileo | dulek: That's the whole idea of Active-Active, right? | 14:05 |
geguileo | dulek: Exact same node | 14:05 |
dulek | geguileo: That would be a big change to how LVM driver works now. | 14:05 |
geguileo | dulek: That can work simultaneously | 14:05 |
geguileo | dulek: No, I mean | 14:06 |
*** annashen has joined #openstack-cinder | 14:06 | |
geguileo | dulek: If you are using LVM with local storage (as with devstack) | 14:06 |
geguileo | dulek: Then you cannot have HA Active-Active | 14:06 |
dulek | geguileo: I think that scheduler selects LVM hosts basing for example on information if host is able to fit the volume in. | 14:06 |
geguileo | dulek: Because the storage is local to the node | 14:06 |
geguileo | dulek: That is correct | 14:06 |
geguileo | dulek: But it's not that the host is able to fit the volume in | 14:06 |
geguileo | dulek: But that the storage is able to fit it | 14:07 |
geguileo | dulek: The node is just an intermediary | 14:07 |
*** ankit_ag has quit IRC | 14:08 | |
dulek | geguileo: Then how can you tell if node has enough free space to create a volume? | 14:08 |
dulek | geguileo: Right now I think scheduler decides that. | 14:08 |
geguileo | dulek: Yes, but based on information sent from the nodes, right? | 14:09 |
dulek | geguileo: That's right. | 14:09 |
geguileo | dulek: Then what's the difference? | 14:09 |
geguileo | dulek: Nodes will keep updating that information | 14:09 |
geguileo | dulek: But it will receive N times as many refreshes as it does now (N being the number of active nodes in the cluster) | 14:10 |
*** boris-42 has joined #openstack-cinder | 14:10 | |
geguileo | dulek: Since each node will be sending that information from the same backend | 14:10 |
dulek | geguileo: It would need to aggregate them... | 14:10 |
geguileo | dulek: Why? | 14:10 |
geguileo | dulek: The free space is not the sum of those | 14:10 |
*** annashen has quit IRC | 14:11 | |
geguileo | dulek: It's the latest one that counts | 14:11 |
dulek | geguileo: Because every LVM node has only knowledge of it's own capabilities I think. | 14:11 |
geguileo | dulek: They are all going to the same storage backend | 14:11 |
dulek | geguileo: It doesn't have the view of the whole cluster. | 14:11 |
geguileo | dulek: The thing is that if LVM is set to local storage (you store data in local HD) you cannot have A-A | 14:11 |
dulek | geguileo: That's right, I just want to think how to integrate that. So I guess we just have LVMs as different hosts as we have now? | 14:12 |
geguileo | dulek: Yes | 14:13 |
geguileo | dulek: And they can be configured as A-P but not A-A | 14:13 |
dulek | geguileo: Okay, so we still have host option in the config, nothing changes there. | 14:13 |
dulek | geguileo: Cool. | 14:13 |
geguileo | dulek: Nothing changes, we use the same host configuration as we do now | 14:14 |
geguileo | dulek: But you set the same host for nodes from the same cluster | 14:14 |
dulek | geguileo: Got it! | 14:14 |
geguileo | dulek: And they must access the exact same backend | 14:14 |
geguileo | ok | 14:14 |
dulek | geguileo: I've also took a look on how to detect if oslo.messaging disconnected from RabbitMQ. | 14:15 |
*** msno has joined #openstack-cinder | 14:15 | |
msno | hi | 14:15 |
dulek | geguileo: That's unfortunately hard in current state. | 14:15 |
geguileo | dulek: Really? :( | 14:15 |
msno | what should be vendor_name for cinder.volume.drivers.emc.emc_cli_iscsi.EMCCLIISCSIDriver for cinder in tempest.conf | 14:15 |
msno | i tried vendor_name=EMC but my test fails | 14:16 |
dulek | geguileo: I think so, but maybe deeper investigation should be done. Anyway just for you to know. ;) | 14:16 |
geguileo | dulek: Thanks for looking into it, it's good to know | 14:16 |
dulek | geguileo: And just a nit - I guess it's "for the sake of", and not "for the shake of". ;) | 14:18 |
geguileo | dulek: XD XD XD | 14:18 |
geguileo | dulek: Thanks | 14:18 |
geguileo | dulek: I'll fix it :) | 14:18 |
openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 14:19 |
dulek | geguileo: I wonder if we're able to go on with merging Tooz locks into Liberty, and then follow your approach in M. | 14:20 |
dulek | geguileo: BPs deadline is this Friday I think. | 14:20 |
geguileo | dulek: I think that's reasonable | 14:20 |
geguileo | dulek: And if we have locks for manager and drivers it will be big step | 14:21 |
*** Tross has quit IRC | 14:21 | |
*** tsekiyama has joined #openstack-cinder | 14:21 | |
dulek | geguileo: Ah, probably one more step is needed - reworking https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L319-L381 to work in distributed version. | 14:23 |
dulek | geguileo: Am I right? | 14:23 |
geguileo | dulek: Yes, there are patches for that ;-) | 14:24 |
geguileo | dulek: https://review.openstack.org/#/c/205838/ | 14:24 |
*** annegentle has joined #openstack-cinder | 14:26 | |
dulek | geguileo: Is this strongly tied with other of your patches or it can be extracted and used on it's own? | 14:26 |
geguileo | dulek: That's a good question. XD | 14:27 |
geguileo | dulek: I think that one has only 2 dependencies | 14:28 |
*** esker has joined #openstack-cinder | 14:28 | |
geguileo | dulek: But I'd have to check if it would work without the other stuff | 14:28 |
openstackgerrit | Eric Harney proposed openstack/cinder: Move retype() to BaseVD https://review.openstack.org/206559 | 14:29 |
*** jaypipes has joined #openstack-cinder | 14:29 | |
dulek | geguileo: But the dependencies are all this queued statuses stuff, which may be a little harder to push through. | 14:29 |
eharney | i'd appreciate if folks could review https://review.openstack.org/#/c/206559/ and its dep -- this is really breaking some NFS-ish drivers | 14:30 |
geguileo | dulek: Well, the only reason I needed to change the init_host method in the first place is because of the change in the ACK | 14:30 |
*** Yogi11 has joined #openstack-cinder | 14:30 | |
dulek | geguileo: Is it? In case of A/A when starting a c-vol we don't know if volume is processed by some other c-vol or orphaned. | 14:32 |
dulek | geguileo: Or am I wrong (hopefully?)? | 14:32 |
*** vlaza has quit IRC | 14:32 | |
geguileo | dulek: You are right | 14:32 |
geguileo | dulek: But if you remove the stuck fixing from there, where do you fix them? | 14:34 |
*** Yogi1 has quit IRC | 14:34 | |
geguileo | dulek: And how will you be able to tell apart a stuck resource from one that just got queued by the API? | 14:34 |
tbarron | geguileo: dulek: I want to read https://review.openstack.org/#/c/205838/ today myself, as I'm also looking to fix backup init_host for issues of the same kind. | 14:35 |
tbarron | or similar at least. | 14:35 |
geguileo | tbarron: I'm not sure if that patch will be helpful for current code | 14:37 |
dulek | geguileo: Ah, right, we cannot just acquire the lock in init_host and do cleanups - action might been just scheduled by the API and is inside RabbitMQ, without any c-vol processing yet. | 14:38 |
tbarron | geguileo: I figured that might be the case, but it will help expand my "conceptual repetoire" at least :-) | 14:38 |
geguileo | dulek: Precisely!! | 14:38 |
geguileo | dulek: That's why I introduced those new statuses | 14:38 |
geguileo | tbarron: Cool | 14:39 |
dulek | geguileo: So this statuses actually mean "on the way to c-vol"? | 14:40 |
dulek | s/this/these | 14:40 |
geguileo | dulek: Yes | 14:41 |
geguileo | dulek: It means the operation has been requested, and once they are received by a volume node and they have the locks they can change them to *ing state | 14:41 |
dulek | geguileo: Can the c-vol drop the operation intentionally and let it go back to RabbitMQ? | 14:43 |
dulek | geguileo: Or will it always lock it - which basically means queuing on greenthreads. | 14:43 |
geguileo | dulek: It cannot let it go back to the broker | 14:43 |
geguileo | dulek: Because for that to hapen it would need to drop the whole connection to the broker | 14:44 |
geguileo | dulek: RabbitMQ support requeuing, but other brokers don't | 14:44 |
dulek | geguileo: Okay, got it | 14:44 |
geguileo | dulek: We could always send a new request from volume node | 14:44 |
geguileo | dulek: But I think that's kind of "dirty" | 14:45 |
dulek | geguileo: Not too elegant idea. | 14:45 |
dulek | geguileo: exactly | 14:45 |
geguileo | dulek: I agree | 14:45 |
dulek | geguileo: This seems like it's really well thought, but it seems that minimal set of improvements is: Tooz locks + post-action acks + "about to be processed" statuses + cleanup done with locks. | 14:47 |
dulek | geguileo: Anything else? | 14:47 |
geguileo | dulek: Races in the API nodes | 14:48 |
geguileo | dulek: Small change to how we report service status to the DB | 14:49 |
geguileo | dulek: And maybe I should have a look at the scheduler interactions you mentioned to confirm everything is OK | 14:49 |
*** erlon has joined #openstack-cinder | 14:49 | |
dulek | geguileo: It should be I think... | 14:49 |
dulek | geguileo: Okay, so it's like all-or-nothing here. | 14:50 |
geguileo | dulek: Well, I think tooz locks can be implemented regardless of everything else | 14:50 |
geguileo | dulek: Since we are going to need them anyway, regardless of the solution | 14:50 |
dulek | geguileo: That's true, but are they adding any value alone? | 14:50 |
geguileo | dulek: Well, for one we would add all locks that are missing | 14:51 |
*** Adriano__ has joined #openstack-cinder | 14:51 | |
geguileo | dulek: Since we would be going through all operations | 14:51 |
geguileo | dulek: And if we get that in L it means it will better tested when we start working on the rest of the stuff | 14:52 |
dulek | geguileo: That's a value, but can be achieved without Tooz. | 14:52 |
*** jwcroppe has quit IRC | 14:52 | |
dulek | geguileo: I'm looking for a rationale here. | 14:52 |
*** jwcroppe has joined #openstack-cinder | 14:52 | |
geguileo | dulek: Yes, but if we add Tooz with just file locks (no DLM) we make it easier for the next phase | 14:52 |
geguileo | dulek: That's the rationale | 14:52 |
geguileo | dulek: For the final solution we will need Tooz | 14:53 |
geguileo | dulek: And using Tooz with file locks will not change current behavior | 14:53 |
dulek | geguileo: Yup... Okay, so locks cleanup + Tooz as first step seems fine. | 14:53 |
geguileo | dulek: I think so, since it's basically what we have now | 14:53 |
geguileo | dulek: Not much to think about :) | 14:54 |
*** daneyon has joined #openstack-cinder | 14:55 | |
*** jwcroppe has quit IRC | 14:56 | |
dulek | geguileo: Can you review the spec for A/A then? Feel free to update it if you find that easier. | 14:58 |
*** mdenny has joined #openstack-cinder | 14:58 | |
geguileo | dulek: Yes, I'll review it now | 14:59 |
dulek | geguileo: Thanks! | 14:59 |
*** daneyon has quit IRC | 15:00 | |
*** crose has joined #openstack-cinder | 15:01 | |
openstackgerrit | xing-yang proposed openstack/cinder: Add multiple pools support to VMAX driver https://review.openstack.org/189990 | 15:02 |
kjelly | hi guys, I am working on the bug 1477625 . there are many ways to solve the problem. the simplest way is like https://review.openstack.org/#/c/206450/1 . another way is that add new argument "viewable_admin_meta" to db.volume_get function. And don't use context.elevated() . https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L402 Any suggestion for the bug? | 15:02 |
openstack | bug 1477625 in Cinder "DB access to show volumes may not be properly controlled" [Undecided,In progress] https://launchpad.net/bugs/1477625 - Assigned to jelly (coding1314) | 15:02 |
*** crose has quit IRC | 15:05 | |
*** msno has quit IRC | 15:06 | |
*** annashen has joined #openstack-cinder | 15:06 | |
openstackgerrit | xing-yang proposed openstack/cinder: EMC VMAX Create CG from CG Snapshot https://review.openstack.org/195280 | 15:09 |
*** nkrinner has quit IRC | 15:10 | |
*** daneyon has joined #openstack-cinder | 15:11 | |
*** annashen has quit IRC | 15:11 | |
*** mylu has quit IRC | 15:13 | |
geguileo | dulek: You really don't mind if I update the spec? | 15:13 |
*** ronis has quit IRC | 15:13 | |
dulek | geguileo: Definitely not, go on. | 15:14 |
*** agarciam has quit IRC | 15:14 | |
geguileo | dulek: Ok, because the comments were a pita | 15:14 |
*** agarciam has joined #openstack-cinder | 15:14 | |
*** edtubill has joined #openstack-cinder | 15:15 | |
hemna | os-brick in nova just landed. | 15:15 |
smcginnis | hemna: Woot woot | 15:15 |
xyang1 | hemna: Congrats! | 15:15 |
hemna | should I panic now? | 15:15 |
smcginnis | hemna: Probably. :) | 15:15 |
hemna | :) | 15:15 |
avishay_ | hemna: mazal tov! | 15:15 |
hemna | thanks for all the help guys. | 15:16 |
Swanson | hemna: Congrats! And it is definitely time to panic. Or at least after liberty-2 gets into the wild. | 15:17 |
hemna | heh yah | 15:18 |
hemna | thanks :) | 15:18 |
*** mtanino has joined #openstack-cinder | 15:18 | |
*** mylu has joined #openstack-cinder | 15:18 | |
*** dannywilson has joined #openstack-cinder | 15:22 | |
*** markus_z has quit IRC | 15:23 | |
*** igajsin_ has joined #openstack-cinder | 15:25 | |
*** jasondotstar has quit IRC | 15:25 | |
*** avishay_ is now known as avishay | 15:30 | |
avishay | jordanP: hey, what did you have in mind here? https://review.openstack.org/#/c/205945/ | 15:30 |
jordanP | avishay, I posted a new comment to be more specific | 15:30 |
*** jdurgin1 has joined #openstack-cinder | 15:31 | |
jordanP | avishay, maybe I am a bit picky today... sorry | 15:31 |
avishay | jordanP: i think so :) | 15:31 |
jordanP | but as os-brick could be one day also used by Nova, better safe than sorry | 15:32 |
avishay | jordanP: the unit test is basically a copy of the code, don't think it helps much | 15:32 |
jordanP | I don't think it's a copy of the code, the idea is to test that the exception is properly handled | 15:32 |
jordanP | we should also unit test the 'unhappy path' when things fail | 15:32 |
avishay | jordanP: i don't see much value in it for this case, but i will add it if you insist | 15:33 |
avishay | jordanP: thanks | 15:34 |
jordanP | avishay, I insist :) It's should take 5 min at most... (15 min if you are not a a mock expert). You'll lose your +2 but I am sure hemna will give it back | 15:35 |
jordanP | avishay, what do you think of the 'too broad except statement' comment I also left ? | 15:35 |
*** lcurtis has joined #openstack-cinder | 15:36 | |
openstackgerrit | Cindy Pallares proposed openstack/cinder: Fix multi-line docstrings to meet hacking rules https://review.openstack.org/184820 | 15:36 |
*** aix has quit IRC | 15:38 | |
*** Apoorva has joined #openstack-cinder | 15:39 | |
*** laughterwym has quit IRC | 15:40 | |
avishay | jordanP: what error are you worried about? if somebody replaced the directory with a file and it returns ENOTDIR? i think that's the only other error code for this call... | 15:40 |
geguileo | dulek: Have you looked into zookeepers lock mechanism in Tooz? | 15:40 |
jordanP | avishay, you're saying that the only errno that os.listdir could raise is ENOENT and ENOTDIR ? | 15:42 |
dulek | geguileo: I have some knowledge on that, what's special about them? | 15:42 |
avishay | jordanP: as far as i can see, yes | 15:42 |
geguileo | dulek: Expiration timeout of a lock | 15:42 |
jordanP | I am impressed with you low level cPython knowledge :) | 15:42 |
jordanP | avishay, what about errno.EIO or errno.ENOMEM ? | 15:43 |
geguileo | dulek: Or if you prefer, if a node dies, does its locks get released? how? when? | 15:43 |
jordanP | if you list a super big directory ? | 15:43 |
geguileo | s/does/do | 15:43 |
dulek | geguileo: Ah, that thing. So I think Redis locks are dropped when service holding it dies. | 15:45 |
geguileo | dulek: Redis I know, it's Zookeeper that worries me | 15:45 |
dulek | geguileo: I'm not sure if I checked that explicitly, but that was my understanding. | 15:45 |
avishay | jordanP: if you can attach enough devices to a system to make listing /dev/disk/by-path run out of memory i will give you $100 | 15:45 |
geguileo | dulek: Redis locks have an expiration date that you update each time you call heartbeat | 15:45 |
dulek | geguileo: ZooKeeper is basically a storage. | 15:45 |
* jordanP is going to spawn his 8 MB of RAM VM.... | 15:46 | |
dulek | geguileo: It uses Paxos consensus algorithm to get the state right. | 15:46 |
avishay | jordanP: go ahead, i'm sure listing the directory is the first thing that will fail | 15:46 |
dulek | geguileo: I think that when a node die other nodes will decide that they have quorum and will drop the lock. | 15:46 |
avishay | jordanP: if you really want to nitpick my 2 line change to this point, go ahead, i will just abandon it and you can do it however you like. | 15:47 |
dulek | harlowja: Isn't my explanation for geguileo right? ;) | 15:47 |
*** alexpilotti has quit IRC | 15:47 | |
geguileo | dulek: I would feel better if we knew that for sure | 15:47 |
*** annashen has joined #openstack-cinder | 15:48 | |
jordanP | avishay, that's sad. I have 15 min of free time in front of me. Can I propose a new patchset and add myself as a coauthor ? | 15:48 |
avishay | jordanP: enjoy | 15:48 |
jordanP | I'll add a unit test and I'll narrow the except statement. | 15:48 |
dulek | geguileo: ZooKeeper is Tooz's reference implementation, I wouldn't expect it to be worse that other. | 15:49 |
avishay | jordanP: abandoned - you can do whatever you'd like | 15:49 |
geguileo | dulek: XD XD XD | 15:49 |
geguileo | dulek: No comment on that | 15:49 |
jordanP | avishay, You can't abandoned it. Because then I can"t push a new patchset to it | 15:49 |
avishay | jordanP: i will feel better knowing that i won't run out of memory listing that directory | 15:49 |
dulek | geguileo: If I recall correctly it even doesn't need explicit heartbeating, ZooKeeper takes care of that. | 15:49 |
jordanP | avishay, I need to keep the change ID to keep track of the conversation | 15:49 |
avishay | jordanP: restored, enjoy | 15:50 |
jordanP | avishay, thanks | 15:50 |
smcginnis | There is such thing as being too defensive in programming. Just saying. | 15:50 |
geguileo | dulek: Yes, I don't see a heartbeat | 15:50 |
*** agarciam has quit IRC | 15:51 | |
geguileo | dulek: But I don't see anywhere that it mentions anything about how these are droped | 15:51 |
*** _cjones_ has joined #openstack-cinder | 15:51 | |
*** annashen has quit IRC | 15:51 | |
geguileo | dulek: And Redis is also recommended solution by the Tooz project: http://docs.openstack.org/admin-guide-cloud/content/section_telemetry-cetral-compute-agent-ha.html | 15:51 |
*** Yogi1 has joined #openstack-cinder | 15:52 | |
dulek | geguileo: Ceilometer you mean? | 15:52 |
geguileo | dulek: Well, they say there that Tooz guys recommend both | 15:52 |
geguileo | dulek: Anyway, we should ask someone who knows how that stuff works, because I don't feel like digging into that myself | 15:52 |
geguileo | XD | 15:53 |
*** changbl has joined #openstack-cinder | 15:53 | |
geguileo | I already did it for Redis | 15:53 |
*** Yogi11 has quit IRC | 15:53 | |
*** jungleboyj has joined #openstack-cinder | 15:53 | |
*** BharatK has quit IRC | 15:55 | |
*** logan2 has quit IRC | 15:55 | |
*** breitz1 is now known as breitz | 15:55 | |
*** BharatK has joined #openstack-cinder | 15:56 | |
openstackgerrit | Apoorva Deshpande proposed openstack/cinder: Fix order of arguments in assertEqual https://review.openstack.org/206296 | 15:56 |
dulek | geguileo: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks | 15:57 |
dulek | geguileo: "The removal of a node will only cause one client to wake up" | 15:57 |
geguileo | dulek: Yes, that's talking about exclusion | 15:58 |
geguileo | dulek: And it's implying the release removes it | 15:58 |
dulek | geguileo: This suggest that it will drop it, but they aren't saying that explicitly. ;) | 15:58 |
geguileo | dulek: It doesn't say anything about a node dying | 15:58 |
geguileo | dulek: I don't think so | 15:58 |
geguileo | dulek: I mean, I don't think that's what that sentence is talking about | 15:59 |
dulek | geguileo: Isn't "removal of a node" equal to "node dies"? | 15:59 |
dulek | geguileo: Ah, no, it isn't. | 15:59 |
geguileo | dulek: They are talking about queue nodes | 15:59 |
*** kjelly has quit IRC | 16:00 | |
geguileo | dulek: Ok, I found the answer, these are ephemeral nodes and will be removed automatically :) | 16:01 |
geguileo | dulek: Members of the group create ephemeral nodes under the group node. Nodes of the members that fail abnormally will be removed automatically when ZooKeeper detects the failure. | 16:01 |
dulek | geguileo: :) | 16:01 |
geguileo | dulek: So we are good :) | 16:01 |
openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Tooz locks https://review.openstack.org/183537 | 16:01 |
*** BharatK has quit IRC | 16:06 | |
*** coolsvap is now known as coolsvap|dinner | 16:06 | |
*** annashen has joined #openstack-cinder | 16:07 | |
*** Tross has joined #openstack-cinder | 16:08 | |
*** merooney has quit IRC | 16:09 | |
*** bluex-pl has quit IRC | 16:11 | |
*** annegentle has quit IRC | 16:11 | |
*** annashen has quit IRC | 16:12 | |
*** lpetrut has quit IRC | 16:14 | |
*** ub2 has joined #openstack-cinder | 16:18 | |
*** ub has quit IRC | 16:19 | |
*** leeantho has joined #openstack-cinder | 16:19 | |
*** e0ne has quit IRC | 16:20 | |
*** Yogi1 has quit IRC | 16:20 | |
*** Zhongjun has quit IRC | 16:22 | |
*** jistr has quit IRC | 16:22 | |
*** logan2 has joined #openstack-cinder | 16:24 | |
*** Tross has quit IRC | 16:26 | |
*** Apoorva has quit IRC | 16:27 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder-specs: Add Cinder Volume A/A HA lock spec https://review.openstack.org/202615 | 16:28 |
geguileo | dulek: ^ | 16:28 |
dulek | geguileo: Thanks, I'll take a look. | 16:29 |
geguileo | dulek: you'll probably want to change some things :-) | 16:29 |
openstackgerrit | Jordan Pittier proposed openstack/os-brick: Fix race in check and access of /dev/disk/by-path/ https://review.openstack.org/205945 | 16:30 |
Swanson | If I wanted to back port a driver from kilo to juno or icehouse are we talking significant differences? | 16:32 |
*** jdurgin1 has quit IRC | 16:32 | |
*** jasondotstar has joined #openstack-cinder | 16:34 | |
openstackgerrit | Jordan Pittier proposed openstack/os-brick: Remotefs: add ScalityFS support https://review.openstack.org/196631 | 16:37 |
*** hodos has joined #openstack-cinder | 16:38 | |
*** annashen has joined #openstack-cinder | 16:38 | |
Swanson | Just posted a fix to stable/kilo and two CI's gave me a pass in less than a minute! Woo! | 16:39 |
*** thangp has quit IRC | 16:40 | |
*** thangp has joined #openstack-cinder | 16:41 | |
*** jordanP has quit IRC | 16:41 | |
hemna | entire CI running in <1minute ? | 16:41 |
hemna | um....I'd say that's probably a false + | 16:41 |
avishay | hemna: mock CI :) | 16:41 |
hemna | mock the world CI ? | 16:42 |
hemna | mock *.* | 16:42 |
hemna | heh | 16:42 |
Swanson | hemna: I think you're right. Either that or they are running their CI on Deep Thought which seems like overkill. | 16:42 |
*** lpetrut has joined #openstack-cinder | 16:42 | |
avishay | hemna: no chance of the driver getting booted for failing all the time :) | 16:42 |
avishay | Swanson: which CIs? | 16:42 |
hemna | what's the review ? | 16:43 |
Swanson | IBM DB2 CI StorPool | 16:43 |
Swanson | and should be between those two. | 16:43 |
*** sghanekar_ has joined #openstack-cinder | 16:43 | |
Swanson | hemna: https://review.openstack.org/206615 I have suspicions I'll be trimming that down to just the payload filter change. But I have high hopes. | 16:44 |
hemna | oh DB2 CI | 16:45 |
hemna | so that might simply be running the DB migration scripts | 16:45 |
avishay | i don't see that any CIs posted on that patch, and I think DB2 probably only does db-related tests | 16:45 |
*** ronis has joined #openstack-cinder | 16:45 | |
Swanson | Got two emails. | 16:46 |
Swanson | Which is fine, I guess, so long as they aren't posting on the review. | 16:46 |
*** mriedem has joined #openstack-cinder | 16:47 | |
mriedem | oh hello cinder peeps | 16:48 |
mriedem | some nova people, myself included, are wondering if this is a priority for cinder | 16:48 |
mriedem | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/volume-multi-attach,n,z | 16:48 |
jungleboyj | Everyone run! | 16:48 |
mriedem | b/c it's DOA for our FF | 16:48 |
*** Yogi1 has joined #openstack-cinder | 16:48 | |
hemna | it would have been nice to get it in | 16:48 |
jungleboyj | hemna: ^^ | 16:48 |
jungleboyj | Very nice. | 16:48 |
mriedem | alright, | 16:49 |
mriedem | well, | 16:49 |
mriedem | it has quite a few issues at this point | 16:49 |
hemna | I'd rather see it working :) | 16:49 |
hemna | than push it through. | 16:49 |
mriedem | yeah, it has rpc and rest api impacts | 16:49 |
*** johnthetubaguy has joined #openstack-cinder | 16:49 | |
mriedem | and the code came in pretty late and low on the radar | 16:50 |
mriedem | plus, random vendor pushing it | 16:50 |
mriedem | rather than cinder core like the os-brick change | 16:50 |
hemna | ok | 16:50 |
mriedem | anyway, i guess this is just a heads up | 16:50 |
hemna | no worries. | 16:50 |
hemna | thanks for the heads up | 16:50 |
mriedem | we've been trying to prioritize sub-teamy type things like virt drivers in nova, we should probably start talking about doing that with cross project stuff | 16:51 |
mriedem | we track some of that here https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 16:51 |
jungleboyj | mriedem: Thanks for letting us know. | 16:51 |
johnthetubaguy | yeah, a cinder or volume group in there would be awesome | 16:51 |
mriedem | b/c last week someone popped up complaining about glance v2 not making liberty nova | 16:51 |
*** dims has quit IRC | 16:52 | |
mriedem | but if glance isn't pushing it and it aint broken, we aren't actively pursuing more work | 16:52 |
hemna | mriedem, +1 | 16:52 |
mriedem | henceforth let it be know that jungleboyj is the nova/cinder liasion :) | 16:52 |
mriedem | *known | 16:52 |
*** dims has joined #openstack-cinder | 16:52 | |
*** dims has quit IRC | 16:52 | |
*** dims has joined #openstack-cinder | 16:53 | |
mriedem | sheesh, joking tw | 16:53 |
mriedem | *btw | 16:53 |
hemna | hehe | 16:53 |
johnthetubaguy | seriously though, if someone fancies that, it would be great to add that in... https://wiki.openstack.org/wiki/CrossProjectLiaisons#Inter-project_Liaisons ;) | 16:53 |
*** jaypipes has quit IRC | 16:54 | |
johnthetubaguy | (although, I can't say they are working that well right now, I need to really try push that forward more...) | 16:54 |
*** jaypipes has joined #openstack-cinder | 16:54 | |
mriedem | i wasn't aware that table existed :) | 16:55 |
hemna | yah interesting | 16:57 |
*** annashen has quit IRC | 16:57 | |
hemna | I suppose I could sign up for it. I have done lots of nova <--> Cinder stuffs | 16:57 |
johnthetubaguy | hemna: that would be cool | 16:57 |
*** sghanekar_ has quit IRC | 16:57 | |
hemna | I'm not sure what it entails | 16:58 |
hemna | kinda feels like it should be a PTL thing | 16:58 |
hemna | so I'll defer to thingee for advice | 16:58 |
johnthetubaguy | hemna: its really just trying to scale out the PTL roles I guess | 16:58 |
hemna | I'm sure he's overwhelmed with things to do | 16:58 |
johnthetubaguy | hemna: I think the idea is to jump into nova meetings when there is something important you need doing | 16:58 |
johnthetubaguy | hemna: and track the nova process, and be a point of contact | 16:59 |
johnthetubaguy | hemna: honestly, we don't really have a good pattern to follow yet, so its more... aspirational | 16:59 |
hemna | heh | 16:59 |
*** annashen has joined #openstack-cinder | 16:59 | |
*** ub2 has quit IRC | 17:00 | |
hemna | ok, well I'll defer to thingee at this point as the PTL. I can help though | 17:00 |
hemna | it's hard to be aware of everything all the time for sure. | 17:00 |
*** coolsvap|dinner is now known as coolsvap|mt | 17:01 | |
*** coolsvap|mt is now known as coolsvap|mtg | 17:01 | |
thingee | fwiw mriedem, glance v2 is broken in Cinder today https://bugs.launchpad.net/cinder/+bug/1478737 | 17:02 |
openstack | Launchpad bug 1478737 in Cinder "Cinder upload-to-image with glance v2 fails" [Medium,In progress] - Assigned to Tomoki Sekiyama (tsekiyama) | 17:02 |
thingee | tsekiyama: speaking of, are you pushing a patch for this ^ | 17:02 |
mriedem | thingee: i heard glance v2 doesn't work with glance v1 created shapshots either, so yeah, some issues with nova moving to glance v2 | 17:03 |
thingee | mriedem: I was noting it on the ML http://lists.openstack.org/pipermail/openstack-dev/2015-July/070714.html | 17:03 |
*** mylu has quit IRC | 17:04 | |
*** mylu has joined #openstack-cinder | 17:05 | |
*** Tross has joined #openstack-cinder | 17:05 | |
*** lpetrut has quit IRC | 17:06 | |
*** vilobhmm has joined #openstack-cinder | 17:06 | |
*** avishay has quit IRC | 17:08 | |
smcginnis | Anyone else seeing their test_volume_boot_pattern tests suddenly starting to fail? | 17:10 |
hemna | yup | 17:10 |
smcginnis | Hmm | 17:11 |
hemna | saw that last night as well I thinks | 17:11 |
smcginnis | hemna: Any idea what's going on there? | 17:11 |
*** ub has joined #openstack-cinder | 17:12 | |
hemna | nah I haven't dug into it yet today | 17:12 |
smcginnis | I'll see if I can do a little digging. | 17:12 |
*** mylu has quit IRC | 17:13 | |
mriedem | ssh failures or other? | 17:15 |
*** mylu has joined #openstack-cinder | 17:16 | |
*** boris-42 has quit IRC | 17:20 | |
*** jungler has quit IRC | 17:20 | |
thingee | breitz: hi | 17:20 |
*** jungler has joined #openstack-cinder | 17:21 | |
*** boris-42 has joined #openstack-cinder | 17:22 | |
*** abehl has quit IRC | 17:22 | |
thingee | breitz: unless there's a good reason for a PM, I'd rather keep the convo here. | 17:22 |
*** merooney has joined #openstack-cinder | 17:23 | |
*** Apoorva has joined #openstack-cinder | 17:25 | |
openstackgerrit | Sonia Ghanekar proposed openstack/cinder: Set VERSION on the Nimble driver. https://review.openstack.org/206239 | 17:26 |
breitz | ah sure - did not want to bother everybody else with the first q | 17:27 |
breitz | thingee: was wondering if there was anybody that was willing to help mentor a new guy a bit. | 17:27 |
breitz | and if not - I was looking for a suggestion for a bug or two to look at fixing | 17:28 |
*** patrickeast has joined #openstack-cinder | 17:29 | |
*** annegentle has joined #openstack-cinder | 17:30 | |
thingee | breitz: first off welcome to the team | 17:32 |
breitz | heh - thanks! | 17:32 |
thingee | breitz: so I have a bug that I started fixing, but stopped that I could hand off to you. I usually just tell people to pair up with someone working on significant changes in Cinder though | 17:33 |
breitz | thingee, that sounds good. I can pick up the bug - and try to pair up with somebody. | 17:34 |
*** annegentle has quit IRC | 17:35 | |
thingee | breitz: here's the bug though https://bugs.launchpad.net/nova/+bug/1437904 https://review.openstack.org/#/c/178860/ | 17:35 |
openstack | Launchpad bug 1437904 in Cinder "generate_sample.sh uses MODULEPATH environment variable, conflicts with environment-modules" [Low,In progress] - Assigned to Mike Perez (thingee) | 17:35 |
breitz | suggestions of who I can pair up with would be most welcome | 17:35 |
thingee | breitz: vilobhmm is working on nested quota inside of Cinder. sure help would be appreciated there http://specs.openstack.org/openstack/cinder-specs/specs/liberty/cinder-nested-quota-driver.html | 17:37 |
breitz | thingee: ok, I'll see if I can provide some help there. thanks | 17:38 |
thingee | breitz: patrickeast is working a generic image caching feature. testing would be great here http://specs.openstack.org/openstack/cinder-specs/specs/liberty/image-volume-cache.html | 17:38 |
thingee | breitz: here's the patch for image caching https://review.openstack.org/#/c/195795/ | 17:39 |
patrickeast | oo yea, definitely would like to get more folks trying it out | 17:39 |
breitz | k - this sounds like a good starting point to ramp up with. awesome | 17:40 |
thingee | patrickeast: is there any documenting that's necessary for getting this working with new drivers that breitz could help with? | 17:40 |
patrickeast | thingee: breitz: mmm not really, it doesn’t require any driver changes or anything, you only need to set the config options for the internal tenant and to enable the cache | 17:41 |
thingee | breitz: so I know some projects like to start people off with random bugs, but I lean more towards having people work with others on significant changes. So eventually you yourself will be working on significant changes :) | 17:42 |
thingee | breitz: unfortunately you're coming in when we're almost through a release cut, so things are sort of at testing phases, but testing out changes coming through the pipeline is very helpful | 17:42 |
*** annashen has quit IRC | 17:42 | |
thingee | patrickeast: perhaps documentation for enabling it ;D | 17:43 |
thingee | breitz: ^ | 17:43 |
patrickeast | thingee: yep, definitely will want some | 17:43 |
breitz | testing is fine - much learning to be had even with that. | 17:43 |
patrickeast | thingee: breitz: an example of my local.conf i’m using to play around with it http://paste.openstack.org/show/406111/ | 17:43 |
patrickeast | note the image_volume_cache_* and cinder_internal_tenant_* options | 17:44 |
*** mylu has quit IRC | 17:44 | |
thingee | I'd like to see documentation for it somewhere in http://docs.openstack.org/admin-guide-cloud/content/managing-volumes.html | 17:44 |
thingee | patrickeast: I guess we still have this mess on the ML to figure out | 17:44 |
patrickeast | thingee: haha yea, i figured i would wait for it to land before writing up too much documentation for it | 17:45 |
*** mylu has joined #openstack-cinder | 17:45 | |
thingee | patrickeast: I appreciate your last email to thread. I still haven't decided what to do | 17:46 |
* thingee decided to make his x1 carbon work better with linux last night. he's now typing on a 2010 macbook pro. | 17:47 | |
patrickeast | lol | 17:47 |
*** ronis has quit IRC | 17:47 | |
thingee | I think I scared breitz off | 17:47 |
*** markvoelker has quit IRC | 17:47 | |
patrickeast | thingee: hopefully that email made sense… i felt like i wrote a small novel and still didn’t really hit all the points very well | 17:48 |
thingee | patrickeast: I do like short emails with bullet points, but I still appreciated the info | 17:48 |
breitz | heh - scared yes - scared off - not yet. ;-) | 17:48 |
breitz | much to figure out | 17:48 |
*** ub has quit IRC | 17:49 | |
*** crose has joined #openstack-cinder | 17:50 | |
*** ub has joined #openstack-cinder | 17:51 | |
*** haomaiwang has quit IRC | 17:51 | |
*** annashen has joined #openstack-cinder | 17:52 | |
thingee | patrickeast: Is tsekiyama not posting a fix for https://bugs.launchpad.net/bugs/1478737 ? | 17:52 |
openstack | Launchpad bug 1478737 in Cinder "Cinder upload-to-image with glance v2 fails" [Medium,In progress] - Assigned to Tomoki Sekiyama (tsekiyama) | 17:52 |
*** haomaiwang has joined #openstack-cinder | 17:52 | |
patrickeast | dunno | 17:52 |
patrickeast | thingee: we had a working fix yesterday | 17:52 |
breitz | I also had some code questions about stuff that is now moved into os-brick. | 17:53 |
thingee | patrickeast: that bug is targeted for l-2 | 17:53 |
thingee | patrickeast: guess I can move it to l-3 since I'm trying to do a cut today | 17:53 |
thingee | anyone from core want to give the last +2 on https://review.openstack.org/#/c/184820/ once jenkins is ready? | 17:53 |
thingee | pretty simple hacking update ^ | 17:54 |
thingee | breitz: hemna is brick masta | 17:54 |
thingee | is our* | 17:54 |
patrickeast | thingee: i can put a fix up for it right now if you wanna sneak it into l-2 | 17:54 |
thingee | patrickeast: that'd be cool | 17:55 |
breitz | k - basically much of what is in os_brick/remotefs/remotefs.py is specific to linux - mount command, parsing mount cmd output. Was looking for a way to make it less so. | 17:56 |
*** annashen has quit IRC | 17:56 | |
breitz | or better put - was looking for suggestions about how that might be done | 17:56 |
*** changbl has quit IRC | 17:57 | |
thingee | jgriffith: https://review.openstack.org/#/c/200237/ | 17:58 |
*** ronis has joined #openstack-cinder | 17:58 | |
*** jasondotstar has quit IRC | 17:58 | |
*** lpetrut has joined #openstack-cinder | 18:00 | |
*** mriedem is now known as mriedem_meeting | 18:00 | |
*** timcl has quit IRC | 18:00 | |
*** timcl has joined #openstack-cinder | 18:00 | |
*** abehl has joined #openstack-cinder | 18:01 | |
mtanino | jgriffith: Could you visit this fix for LVM? https://review.openstack.org/#/c/200237/ | 18:02 |
tsekiyama | thingee: patrickeast: oh, I'm writing a unit test for patrickeast's patch for the bug https://bugs.launchpad.net/bugs/1478737 . I'm going to post it soon. | 18:03 |
openstack | Launchpad bug 1478737 in Cinder "Cinder upload-to-image with glance v2 fails" [Medium,In progress] - Assigned to Patrick East (patrick-east) | 18:03 |
patrickeast | tsekiyama: ah excellent | 18:04 |
*** jungler has quit IRC | 18:04 | |
*** jungler has joined #openstack-cinder | 18:05 | |
*** xyang1 has quit IRC | 18:05 | |
*** sgotliv_ has quit IRC | 18:06 | |
vilobhmm | breitz : hello | 18:07 |
vilobhmm | i am working on the nested quota driver right now | 18:08 |
vilobhmm | as part fo http://specs.openstack.org/openstack/cinder-specs/specs/liberty/cinder-nested-quota-driver.html | 18:08 |
vilobhmm | 2 patches have been merged and the 3rd patch for the driver is under review | 18:08 |
vilobhmm | https://review.openstack.org/#/c/205369/ | 18:09 |
breitz | vilobhmm: hi | 18:10 |
vilobhmm | hi | 18:10 |
vilobhmm | breitz : ^6 | 18:10 |
breitz | my first order of business is to get a working dev/test env setup. | 18:10 |
*** changbl has joined #openstack-cinder | 18:10 | |
breitz | after that I'm interested in helping as much as I can. | 18:11 |
vilobhmm | sure | 18:12 |
vilobhmm | let me know if you need help with that | 18:12 |
vilobhmm | breitz : 1] http://docs.openstack.org/developer/devstack/ 2] http://www.rushiagr.com/blog/2013/05/27/cinder-on-devstack-quick-start/ | 18:12 |
breitz | k. thanks. | 18:13 |
vilobhmm | should be helpful for you to start with it | 18:13 |
breitz | I think I've read both of those - but I'll re-read them again to be sure | 18:13 |
breitz | but thanks for the links - I appreciate it | 18:13 |
*** avishay has joined #openstack-cinder | 18:14 | |
breitz | I've messed with devstack on FC - but was going to switch to ubuntu for a platform instead. | 18:14 |
breitz | I | 18:15 |
breitz | I'm familiar with openstack and cinder (to a point). Like many my introduction came with writing a cinder driver. | 18:16 |
*** angela-s has joined #openstack-cinder | 18:18 | |
vilobhmm | awesome | 18:20 |
*** lpetrut has quit IRC | 18:20 | |
openstackgerrit | Tomoki Sekiyama proposed openstack/cinder: Fix exception on uploading a volume to image with glance v2 API https://review.openstack.org/206645 | 18:22 |
tsekiyama | patrickeast: thingee: ^ posted the patch with unit tests for glance api v2. | 18:24 |
*** agarciam has joined #openstack-cinder | 18:26 | |
*** annashen has joined #openstack-cinder | 18:27 | |
*** xyang1 has joined #openstack-cinder | 18:27 | |
*** ub has quit IRC | 18:28 | |
*** haomaiwang has quit IRC | 18:29 | |
*** haomaiwang has joined #openstack-cinder | 18:30 | |
*** mylu has quit IRC | 18:34 | |
avishay | hemna: would appreciate your input here to get this bug fixed - https://review.openstack.org/#/c/205945/ | 18:35 |
hemna | avishay, so, I added a comment in the previous patch I think | 18:35 |
hemna | if that listdir fails, then we should return an empty list IMHO | 18:36 |
avishay | hemna: in practice it doesn't matter, because no other error will ever occur. it's ugly and sets bad precedent IMO but i just don't want it the patch to collect dust. | 18:36 |
hemna | so that code is only used to fetch the list of existing /dev/disk/by-path entries at iscsi disconnect time | 18:37 |
hemna | avishay, https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L500 | 18:38 |
smcginnis | avishay: I was fine with it as it was. If it hits something like ENOMEM then their are bigger problems. | 18:39 |
avishay | hemna: correct | 18:39 |
avishay | smcginnis: yep | 18:39 |
hemna | if it fails to get that listing, then it basically means there are no volumes. | 18:39 |
*** mylu has joined #openstack-cinder | 18:39 | |
hemna | so I dunno | 18:39 |
avishay | hemna: i prefer without checking errno, but don't care much. your call | 18:40 |
hemna | so if that devices list comes back empty, it tries to do an iscsiadm logout basically. | 18:40 |
*** vokt has joined #openstack-cinder | 18:40 | |
avishay | hemna: yep | 18:40 |
hemna | so maybe what you have is fine I guess | 18:41 |
hemna | if we hit ENOMEM, we won't try and do a logout | 18:41 |
hemna | if we raise | 18:41 |
hemna | which is probably safer. | 18:41 |
*** markvoelker has joined #openstack-cinder | 18:42 | |
hemna | we can always change it later | 18:42 |
avishay | hemna: if we hit ENOMEM, VMs will be killed, the system will be unusable, etc. it really won't matter. | 18:42 |
hemna | yah, but we won't make it worse by nuking iscsi connections....or trying to :) | 18:42 |
avishay | hemna: i think it's a bad precedent to check all kinds of things we shouldn't care about all over, but again, doesn't matter for this case | 18:42 |
hemna | ENOENT is really the only real normal failure | 18:43 |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix concurrent attaches on HNAS iSCSI driver https://review.openstack.org/203780 | 18:43 |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix HNAS iSCSI 32 targets limitation error https://review.openstack.org/206651 | 18:43 |
patrickeast | that seems like a pretty reasonable change to me… we shouldn’t leave the iscsi portal open if we get ENOENT | 18:44 |
hemna | yah that's what I think | 18:44 |
hemna | if we get other spurious errors, we raise and crap out | 18:44 |
avishay | hemna: i stated my opinion, you're the core member, you make the call :) | 18:45 |
avishay | hemna: i don't care as long as some version of it is merged :) | 18:45 |
hemna | :) | 18:46 |
hemna | I think it's good. | 18:46 |
hemna | just waiting on jenkins | 18:46 |
*** markvoelker_ has joined #openstack-cinder | 18:46 | |
openstackgerrit | Curt Bruns proposed openstack/cinder: Add deactivate step to extend_lv https://review.openstack.org/198813 | 18:47 |
*** markvoelker has quit IRC | 18:48 | |
avishay | hemna: great, thanks | 18:48 |
*** mragupat has joined #openstack-cinder | 18:49 | |
*** abehl has quit IRC | 18:49 | |
*** ronis has quit IRC | 18:56 | |
*** timcl1 has joined #openstack-cinder | 19:03 | |
*** e0ne has joined #openstack-cinder | 19:03 | |
*** akshai has quit IRC | 19:04 | |
*** timcl has quit IRC | 19:05 | |
*** akshai has joined #openstack-cinder | 19:06 | |
*** ub has joined #openstack-cinder | 19:07 | |
*** hemna is now known as hemnalunch | 19:07 | |
*** avishay has quit IRC | 19:24 | |
*** mriedem_meeting is now known as mriedem | 19:27 | |
*** ub has quit IRC | 19:29 | |
*** markvoelker_ has quit IRC | 19:29 | |
*** akshai has quit IRC | 19:30 | |
*** annashen has quit IRC | 19:30 | |
*** ub has joined #openstack-cinder | 19:30 | |
*** akshai has joined #openstack-cinder | 19:32 | |
vilobhmm | smcginnis, jungleboyj : If you can review this https://review.openstack.org/#/c/206170/3 it would be helpful thanks :) | 19:32 |
smcginnis | vilobhmm: SUre, I'll take a look. | 19:32 |
vilobhmm | thanks smcginnis ! :) | 19:32 |
*** agarciam has quit IRC | 19:37 | |
*** annegentle has joined #openstack-cinder | 19:40 | |
*** ccesario has joined #openstack-cinder | 19:43 | |
*** jasondotstar has joined #openstack-cinder | 19:44 | |
ccesario | hello... does someone have idea about fix this error ? http://paste.openstack.org/show/aKjp8hSKG1Bu9oku6adt/ | 19:45 |
*** annashen has joined #openstack-cinder | 19:53 | |
*** julim has quit IRC | 19:55 | |
*** annashen has quit IRC | 19:57 | |
*** btran has joined #openstack-cinder | 20:01 | |
*** alexpilotti has joined #openstack-cinder | 20:06 | |
*** rushiagr is now known as rushiagr_away | 20:06 | |
*** alexpilotti has quit IRC | 20:12 | |
dannywilson | ccesario: says "volume service is down", check cinder volume log contents to see why it crashed/didn't start | 20:13 |
*** ub2 has joined #openstack-cinder | 20:15 | |
*** Apoorva has quit IRC | 20:15 | |
*** ub has quit IRC | 20:17 | |
ccesario | dannywilson, http://paste.openstack.org/show/406137/ | 20:18 |
ccesario | it seems is started | 20:18 |
*** merooney has quit IRC | 20:19 | |
*** e0ne has quit IRC | 20:19 | |
*** annashen has joined #openstack-cinder | 20:20 | |
dannywilson | ccesario: check log file to be sure, if using devstack possibly at /opt/stack/logs/screen/screen-c-vol.log | 20:20 |
*** jaypipes has quit IRC | 20:20 | |
*** e0ne has joined #openstack-cinder | 20:21 | |
*** e0ne has quit IRC | 20:21 | |
*** julim has joined #openstack-cinder | 20:22 | |
*** mtanino has quit IRC | 20:23 | |
ccesario | dannywilson, http://paste.openstack.org/show/7FsXMrdq0NhMVHShDR5X/ | 20:23 |
*** sgotliv_ has joined #openstack-cinder | 20:25 | |
dannywilson | ccesario: "Update driver status failed: (config name vsphere) is uninitialized." from log file, can you paste cinder.conf too? | 20:25 |
*** shyama has quit IRC | 20:28 | |
ccesario | sure .. a momment pls | 20:29 |
*** Apoorva has joined #openstack-cinder | 20:30 | |
*** jaypipes has joined #openstack-cinder | 20:31 | |
*** salv-orlando has joined #openstack-cinder | 20:31 | |
ccesario | dannywilson, http://paste.openstack.org/show/LdDWkc1PBvKeXe7EN7UZ/ | 20:31 |
*** salv-orl_ has quit IRC | 20:34 | |
dannywilson | ccesario: Hmm "enabled_backends = vsphere" I am not familiar with this volume type but it seems like this might be the problem | 20:35 |
dannywilson | ccesario: also not familiar with cinder.volume.drivers.vmware.vmdk.VMwareVcVmdkDriver driver, sorry | 20:35 |
dannywilson | ccesario: also looks like you haven't set this up fully based on this line "vmware_host_ip = 192.168.X.X" | 20:36 |
*** Lee1092 has quit IRC | 20:37 | |
Swanson | I would have assumed there would have to be a volume backend of some kind listed. Presumably with the vsphere name. | 20:38 |
*** ganso_ has quit IRC | 20:40 | |
ccesario | well... I 'm not a expert with this... I 'm testing openstack with vmware environment... and I follow some guides to try it with devstack :) | 20:40 |
*** Yogi1 has quit IRC | 20:41 | |
*** mtanino has joined #openstack-cinder | 20:41 | |
*** alexpilotti has joined #openstack-cinder | 20:41 | |
*** Tross has quit IRC | 20:41 | |
ccesario | then can exists errors in this config :/ | 20:42 |
*** logan2 has quit IRC | 20:42 | |
dannywilson | ccesario: the process started but it failed to initialize a back end to create volumes on | 20:42 |
dannywilson | ccesario: sorry, ignore that one | 20:43 |
dannywilson | ccesario: yes, there are errors in the cinder.conf file, do a little googling on using the VMwareVcVmdkDriver and how to set up cinder.conf with it | 20:44 |
*** logan2 has joined #openstack-cinder | 20:45 | |
ccesario | let me try do it :) .. thanks for the tips dannywilson | 20:48 |
dannywilson | ccesario: np, good luck | 20:48 |
ccesario | thank you... I'll report you eheheheh | 20:48 |
*** alexpilotti has quit IRC | 20:52 | |
*** IlyaG has joined #openstack-cinder | 20:53 | |
*** akerr has quit IRC | 20:55 | |
*** esker has quit IRC | 20:58 | |
*** esker has joined #openstack-cinder | 21:00 | |
*** jaypipes has quit IRC | 21:04 | |
*** esker has quit IRC | 21:04 | |
*** DericHorn-HP has joined #openstack-cinder | 21:06 | |
*** aix has joined #openstack-cinder | 21:06 | |
*** mylu has quit IRC | 21:07 | |
*** bswartz has quit IRC | 21:07 | |
*** DericHorn-HP has quit IRC | 21:09 | |
Swanson | I've never had every single test fail before. Wow. | 21:10 |
smcginnis | Swanson: Nice. You're just that good. | 21:10 |
*** jasondotstar has quit IRC | 21:11 | |
*** delatte has quit IRC | 21:15 | |
*** thangp has quit IRC | 21:15 | |
Swanson | smcginnis: Looks like a sea of ci setup issues. | 21:16 |
Swanson | Hard to tell since the logs are not showing up. | 21:21 |
openstackgerrit | Vilobh Meshram proposed openstack/cinder: Fix get default quota values for subprojects https://review.openstack.org/206170 | 21:26 |
*** esker has joined #openstack-cinder | 21:29 | |
*** resker has joined #openstack-cinder | 21:31 | |
*** esker_ has joined #openstack-cinder | 21:32 | |
*** crose has quit IRC | 21:32 | |
*** esker__ has joined #openstack-cinder | 21:33 | |
*** esker___ has joined #openstack-cinder | 21:33 | |
*** esker has quit IRC | 21:34 | |
*** esker has joined #openstack-cinder | 21:34 | |
*** resker has quit IRC | 21:35 | |
*** resker has joined #openstack-cinder | 21:35 | |
*** esker_ has quit IRC | 21:36 | |
*** esker_ has joined #openstack-cinder | 21:37 | |
*** esker__ has quit IRC | 21:37 | |
*** esker___ has quit IRC | 21:38 | |
*** esker has quit IRC | 21:39 | |
*** esker has joined #openstack-cinder | 21:39 | |
*** resker has quit IRC | 21:40 | |
openstackgerrit | xing-yang proposed openstack/cinder: Clone CG https://review.openstack.org/203473 | 21:40 |
*** resker has joined #openstack-cinder | 21:40 | |
*** esker_ has quit IRC | 21:42 | |
*** dims has quit IRC | 21:42 | |
*** esker has quit IRC | 21:44 | |
openstackgerrit | xing-yang proposed openstack/cinder: Clone CG https://review.openstack.org/203473 | 21:44 |
*** resker has quit IRC | 21:45 | |
*** eharney has quit IRC | 21:45 | |
*** esker has joined #openstack-cinder | 21:46 | |
openstackgerrit | xing-yang proposed openstack/cinder: Clone CG https://review.openstack.org/203473 | 21:46 |
*** resker has joined #openstack-cinder | 21:47 | |
*** esker_ has joined #openstack-cinder | 21:48 | |
*** esker has quit IRC | 21:50 | |
*** esker has joined #openstack-cinder | 21:51 | |
*** resker has quit IRC | 21:52 | |
*** jwcroppe has joined #openstack-cinder | 21:52 | |
*** esker_ has quit IRC | 21:52 | |
*** changbl has quit IRC | 21:53 | |
*** resker has joined #openstack-cinder | 21:53 | |
*** annashen_ has joined #openstack-cinder | 21:53 | |
*** edtubill has left #openstack-cinder | 21:54 | |
*** esker_ has joined #openstack-cinder | 21:54 | |
*** mriedem has quit IRC | 21:54 | |
openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/cinder: Nested Quota Driver: Get Project Hierarchy https://review.openstack.org/206171 | 21:55 |
openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/cinder: WIP : Cinder Nested Quota Driver https://review.openstack.org/205369 | 21:55 |
*** esker has quit IRC | 21:56 | |
*** esker has joined #openstack-cinder | 21:56 | |
*** resker has quit IRC | 21:57 | |
*** resker has joined #openstack-cinder | 21:58 | |
*** annashen_ has quit IRC | 21:58 | |
*** esker_ has quit IRC | 21:59 | |
*** coolsvap|mtg is now known as coolsvap|away | 22:00 | |
*** esker has quit IRC | 22:01 | |
*** dims has joined #openstack-cinder | 22:02 | |
*** resker has quit IRC | 22:02 | |
*** jungleboyj has quit IRC | 22:06 | |
*** hemnalunch is now known as hemna | 22:09 | |
hemna | patrickeast, any idea what's up w/ the iscsi failures for pure here: https://review.openstack.org/#/c/205945/ ? | 22:09 |
hemna | volumes stuck in attaching | 22:09 |
hemna | I don't see errors in n-cpu or c-vol | 22:10 |
*** mdenny has quit IRC | 22:13 | |
cebruns | hemna: sorry for the delay in getting this brick bug going. It's WIP as I wanted some feedback before updating all the testcode. Thx! https://review.openstack.org/#/c/206549/ | 22:14 |
hemna | cebruns, cool thanks for working on it :) | 22:15 |
*** haomaiwang has quit IRC | 22:15 | |
patrickeast | hemna: uhh good question | 22:16 |
cebruns | hemna: no prob. When you have a chance, see if that's what you and jgriffith were envisioning. :) | 22:17 |
*** haomaiwang has joined #openstack-cinder | 22:17 | |
*** mragupat has quit IRC | 22:17 | |
patrickeast | hemna: i’ve been having a lot of weirdness with my ci system the last week or so, i’m looking into but so far havne’t figure out exactly what the problem is | 22:18 |
patrickeast | hemna: very strange that there are no errors | 22:18 |
*** annegentle has quit IRC | 22:18 | |
hemna | cebruns, yah basically. | 22:18 |
hemna | cebruns, I think it should be putils all the time basically. | 22:19 |
hemna | there was a need early on to make it configurable, but I don't think that's the case now. | 22:19 |
cebruns | hemna: Ok - the Class "Executor" might be misleading since we will be hard-coding putils as the executor. :) | 22:20 |
hemna | cebruns, https://github.com/openstack/cinder/blob/master/cinder/utils.py#L572-L585 | 22:20 |
hemna | cebruns, I think it's safer just to leave it in for now. | 22:21 |
hemna | and by it, I mean the Executor | 22:21 |
cebruns | hemna: agree - no point in major surgery when a comment would suffice. | 22:21 |
cebruns | hemna: In that blob you sent - my thought is to just remove the "execute=processutils.execute," parameter from the method alltogether and any other place there is "execute=execute" or similar. | 22:28 |
hemna | ok | 22:28 |
hemna | cinder is passing it in currently to force it to processutils | 22:29 |
hemna | so we just have to be safe to not break cinder/nova now in every patch | 22:29 |
*** rhe00 has joined #openstack-cinder | 22:29 | |
*** rhedlind has quit IRC | 22:30 | |
*** bswartz has joined #openstack-cinder | 22:30 | |
cebruns | Ok - cool. That's why I wanted to check-in and see if the direction was what you had in mind. | 22:33 |
*** jungleboyj has joined #openstack-cinder | 22:43 | |
*** marcusvrn has quit IRC | 22:45 | |
openstackgerrit | Patrick East proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 22:46 |
*** mriedem has joined #openstack-cinder | 22:47 | |
jamielennox | hey everyone i've got a tempest failure coming from ceph in cinder-backup | 22:48 |
jamielennox | the actual tempest run is in glance_store eg https://review.openstack.org/#/c/193422/ | 22:48 |
jamielennox | failing test is: tempest.api.volume.admin.test_volumes_backup.VolumesBackupsV1Test.test_volume_backup_export_import[id-a99c54a1-dd80-4724-8a13-13bf58d4068d] | 22:49 |
jamielennox | error message at: http://logs.openstack.org/22/193422/3/check/gate-tempest-dsvm-full-ceph-src-glance_store/098988f/logs/screen-c-bak.txt.gz#_2015-07-25_10_43_27_924 | 22:49 |
jamielennox | says: | 22:49 |
jamielennox | WARNING cinder.backup.manager [req-41e2626d-5540-4ff0-a586-9183e0a98e43 tempest-VolumesBackupsV2Test-1882584612] Backup service cinder.backup.drivers.ceph does not support verify. Backup id 0cb52178-01d9-459c-b081-1eb3ba4972b5 is not verified. Skipping verify. | 22:49 |
*** garthb has joined #openstack-cinder | 22:50 | |
jamielennox | then | 22:50 |
jamielennox | 2015-07-25 10:43:30.704 5045 ERROR oslo_messaging.rpc.dispatcher ImageNotFound: error opening image volume-0000-0000-0000-0000.backup.0cb52178-01d9-459c-b081-1eb3ba4972b5 at snapshot None | 22:50 |
*** garthb_ has joined #openstack-cinder | 22:50 | |
*** garthb_ has quit IRC | 22:50 | |
jamielennox | i'm only guessing that's the cause but does anyone have any ideas | 22:51 |
jamielennox | mtreinish: have you seen ^ before? | 22:51 |
jgriffith | jamielennox: known issue / bug | 22:52 |
jgriffith | jamielennox: restoring an external backup to Ceph doesn't work. That test was/is skipped for Ceph backends currently | 22:52 |
jamielennox | jgriffith: it's hitting glance_store fairly consistently, is there a workaround or should i disable the gate job? | 22:52 |
mtreinish | jamielennox: is that on a ceph run | 22:52 |
jamielennox | mtreinish: yep | 22:52 |
mtreinish | yep it is, there is a bug open for that | 22:52 |
jgriffith | jamielennox: should skip it similar to the cinder-dsvm-ceph job IMO | 22:52 |
mtreinish | jamielennox: https://bugs.launchpad.net/cinder/+bug/1476416 | 22:53 |
openstack | Launchpad bug 1476416 in Cinder "backup.api:import_record sets volume_id to '0000-0000-0000-0000'" [High,Confirmed] - Assigned to Ivan Kolodyazhny (e0ne) | 22:53 |
jamielennox | jgriffith, mtreinish: ok, i'll propose to skip it, thanks | 22:53 |
jamielennox | jgriffith: ceph jobs seem to be running on cinder: https://review.openstack.org/#/c/197075/ | 22:56 |
jamielennox | or is that a different test | 22:56 |
jamielennox | gate-tempest-dsvm-full-cephSUCCESS in 46m 39s | 22:56 |
jgriffith | jamielennox: Sorry... to be more specific, just skip "that job" on the cep run | 22:56 |
jgriffith | jamielennox: you're correct, it's still running, but we added a skip to the projects file for that particular test | 22:56 |
* jgriffith grabbing the link.... | 22:57 | |
jamielennox | jgriffith: if you can show me that i'd appreciate it, i haven't seen skipping individual tests from projects file | 22:57 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: WIP: remove the iscsi rescan during disconnect https://review.openstack.org/203265 | 22:57 |
earlephilhower | mriedem: ping | 22:58 |
jgriffith | jamielennox: try this out: https://review.openstack.org/#/c/203845/ | 22:58 |
jgriffith | jamielennox: but NOTE, I don't think the .*slow filter should be in there | 22:59 |
jamielennox | jgriffith: that's a fun regexp, yea i'll have to change it to the new job name | 22:59 |
jamielennox | thanks | 22:59 |
jgriffith | jamielennox: sure... good luck :) | 22:59 |
mriedem | earlephilhower: pong | 22:59 |
*** lcurtis has quit IRC | 23:00 | |
*** dannywilson has quit IRC | 23:00 | |
earlephilhower | mriedem: Howdy. I'm trying to update the new os-brick shim for HGST w/your breaking out of volume drivers in Nova bp/consolidate-libvirt-fs-volume-drivers. But it looks like your branch was done before os-brick support pulled in. | 23:01 |
mriedem | earlephilhower: yeah, so i'm in the process of rebasing that bastard today/tonight | 23:01 |
mriedem | i'm a few changes off yet, but should have that rebased and up in a couple of hours | 23:01 |
*** haomaiwang has quit IRC | 23:01 | |
earlephilhower | mriedem: Great, thanks. Been beating my head around how to make it all line up | 23:01 |
*** haomaiwang has joined #openstack-cinder | 23:02 | |
earlephilhower | I'll keep up on it and try again tomorrow if there's a new rebase... | 23:02 |
earlephilhower | s/keep/give/ ^^ | 23:03 |
jamielennox | mriedem: the above bug is what i was pinging you about yesterday, the glance guys said to ask you about it, i think we've got a solution | 23:03 |
*** dims has quit IRC | 23:05 | |
*** edmondsw has quit IRC | 23:07 | |
jamielennox | jgriffith, mtreinish: skip ceph test: https://review.openstack.org/206759 | 23:14 |
jungleboyj | scottda: You still around? | 23:14 |
jgriffith | jamielennox: LGTM | 23:17 |
*** xek has quit IRC | 23:18 | |
scottda | jungleboyj: hi | 23:20 |
jungleboyj | scottda: Hey, I was just chatting with cebruns too. | 23:20 |
jungleboyj | Austin's has a private dinner Thursday already so the earliest they could get us in is 8 . What do you think? | 23:20 |
*** xek has joined #openstack-cinder | 23:21 | |
scottda | Seem's OK...It's the last "official" day of the mid-cycle, so people might want to go late.... | 23:21 |
jungleboyj | scottda: That is true. If not we can grab a drink somewhere beforehand. | 23:22 |
jungleboyj | Down at that pizza place maybe that was good. | 23:22 |
scottda | That's what I was thinking, just wanted to phrase it in a way that didn't make me look like a lush :) | 23:22 |
scottda | Plenty of places around. | 23:22 |
jungleboyj | cebruns: Beat you to it. /me is planning plenty of beverage time. | 23:22 |
jungleboyj | Hey, I am trying to pick a place near the hotel. Who is the lush? | 23:23 |
scottda | :) | 23:23 |
scottda | Fort Collins is known for beer and bikes. They kinda go together. | 23:23 |
jungleboyj | Ok, I will reserve Austin's at 8 then. | 23:24 |
scottda | swell | 23:24 |
*** r-daneel has joined #openstack-cinder | 23:24 | |
*** NobodyCam has quit IRC | 23:24 | |
jungleboyj | I will bring it up in the meeting tomorrow and make sure everyone is cool with that. | 23:24 |
cebruns | beer+bikes go well together...up to a point. :) | 23:24 |
*** r-daneel has quit IRC | 23:24 | |
*** NobodyCam has joined #openstack-cinder | 23:24 | |
jungleboyj | cebruns: That was what I was thinking. Add altitude ... | 23:24 |
jungleboyj | Whee@! | 23:24 |
*** r-daneel has joined #openstack-cinder | 23:25 | |
thingee | winston-d_zZZ: you know what would really be good... some documentation on the filters. not sure if I'm blind | 23:26 |
thingee | winston-d_zZZ: filter schedulers to be exact | 23:26 |
mtanino | jgriffith: Hi, Can I get a one more core review for this LVM patch? https://review.openstack.org/#/c/200237/ | 23:30 |
jungleboyj | cebruns: scottda Funny, I called back and he was glad I did. There was a cancellation they hadn't gotten documented. | 23:30 |
jgriffith | mtanino: hmm.. never thought of applying that to the secure delete op | 23:30 |
jungleboyj | cebruns: scottda So, 6:30 on Thursday. | 23:31 |
scottda | jungleboyj: uhhhh...doesn't that mess up the early drinking? | 23:32 |
jungleboyj | scottda: It leave plenty of time for late drinking. :-) | 23:33 |
cebruns | jungleboyj: Sweet! You made him an offer he couldn't refuse, eh? | 23:33 |
*** rhagarty_ has quit IRC | 23:33 | |
*** rhagarty has quit IRC | 23:33 | |
jungleboyj | Or we can do early drinking Friday instead. :-) Just thinking, for those who want free food but might be leaving early Friday. | 23:33 |
*** dims has joined #openstack-cinder | 23:34 | |
*** esker has joined #openstack-cinder | 23:34 | |
mtanino | jgriffith: For clear_volume() path, sparse is always set to False for the secure delete op | 23:34 |
*** akshai has quit IRC | 23:35 | |
mtanino | jgriffith: Does this cover your concern? | 23:35 |
jungleboyj | scottda: Didn't realize you liked the early drinking idea that much. :-) | 23:35 |
jungleboyj | cebruns: Yeah, guaranteed income. | 23:36 |
scottda | I never start before 5:00 PM.... | 23:36 |
*** esker has quit IRC | 23:36 | |
jungleboyj | Well, we have an hour and a half then. | 23:36 |
scottda | but since my team is in Ireland, that ends being 10:00 AM | 23:36 |
jungleboyj | :-) | 23:36 |
*** esker has joined #openstack-cinder | 23:36 | |
jungleboyj | scottda: Even earlier if you start with DuncanT . :-) | 23:37 |
jungleboyj | scottda: Seriously though, 6:30 sound ok? | 23:37 |
*** merooney has joined #openstack-cinder | 23:37 | |
*** rhagarty has joined #openstack-cinder | 23:38 | |
*** rhagarty_ has joined #openstack-cinder | 23:39 | |
mtanino | jgriffith: As I mentined about it in the [NOTE] of my previous patch(https://review.openstack.org/#/c/182473/), do you want to add same NOTE for my current proposed patch? | 23:39 |
jgriffith | mtanino: I wasn't really concerned about it TBH, I just didn't consider it :) | 23:39 |
scottda | sure, 6:30 should be fine. It's only minutes away, and folks could stop in their hotels if they like. | 23:39 |
mtanino | jgriffith: hmm, | 23:40 |
jungleboyj | scottda: Yeah, that was what I was thinking. I will see what people think in the meeting tomorrow. | 23:40 |
*** jasondotstar has joined #openstack-cinder | 23:41 | |
jungleboyj | Want to get a more concise number attending. If everyone is planning to go they want to do a reduced menu. | 23:41 |
jgriffith | mtanino: so the change LGTM | 23:41 |
jungleboyj | If we don't have to do that, it would be good. | 23:41 |
*** Yogi1 has joined #openstack-cinder | 23:41 | |
jgriffith | mtanino: I haven't tested it, but traditionally your'e never submitted anything that I found you didn't test out | 23:41 |
jgriffith | s/you're/you've/ | 23:41 |
scottda | cool. Are you going to post a generic 'mid-cycle logistics' topic to the meeting agenda? | 23:41 |
jgriffith | and I'm assuming that's the case here as well ;) | 23:42 |
*** kaisers has quit IRC | 23:42 | |
mtanino | jgriffith: so, since the target of this patch is L-3, I'm fine to wait your enough test, and then get this to merge! | 23:43 |
*** erlon has quit IRC | 23:43 | |
jgriffith | mtanino: I already gave it my vote :) | 23:43 |
mtanino | ! | 23:43 |
mtanino | jgriffith: sure. thank you. | 23:44 |
*** kaisers has joined #openstack-cinder | 23:44 | |
*** IlyaG has quit IRC | 23:44 | |
*** albertom has quit IRC | 23:46 | |
jungleboyj | scottda: Oh, I can do that if you like? | 23:48 |
scottda | It's ok, I'll put something up. | 23:49 |
*** albertom has joined #openstack-cinder | 23:49 | |
jungleboyj | Ok, cool. | 23:49 |
scottda | BTW, are you able to connect to etherpad? I keep getting kicked off. | 23:49 |
jungleboyj | Yeah, I had no problem. | 23:49 |
jungleboyj | Wait, is there something wrong with your wifi? | 23:49 |
jungleboyj | ;-) | 23:50 |
* scottda will not jinx himself with wifi jokes | 23:50 | |
thingee | hemna: getting back to you earlier discussion with johnthetubaguy and mriedem ... I think it would be good if scottda (if he has time) to be our liason in nova | 23:50 |
jungleboyj | He he he. | 23:50 |
thingee | hemna: I think you already have a bit on your plate since have to drop multi-attach work | 23:51 |
thingee | having* | 23:51 |
thingee | hemna: but if you're really interested and want to take on more, I won't stop you :) ... just a recommendation | 23:51 |
scottda | scottda: I'm OK with that, although I feel quite ignorant compared to hemna | 23:52 |
*** salv-orlando has quit IRC | 23:52 | |
thingee | scottda: I think it's great work to step up to. hemna can help you still | 23:53 |
mriedem | hemna: btw, i'm rebasing my refactor series for the libvirt volume drivers so if you see me adding post-mortem comments in https://review.openstack.org/#/c/175569/ they are just notes to myself so i can go back and cleanup later | 23:53 |
thingee | I just think hemna is doing great work elsewhere at the moment, even if does happen to touch on the nova side. | 23:53 |
scottda | sure, he's a busy guy. I've the cycles and I'd be happy to do it. | 23:54 |
*** annashen_ has joined #openstack-cinder | 23:54 | |
jungleboyj | Wow, a Nova liaison! | 23:55 |
*** DTadrzak has quit IRC | 23:55 | |
*** annashen has quit IRC | 23:55 | |
openstackgerrit | Vilobh Meshram proposed openstack/cinder: Cinder Nested Quota Driver https://review.openstack.org/205369 | 23:56 |
*** DTadrzak has joined #openstack-cinder | 23:56 | |
thingee | so scheduler_hints extension has no policy. is that on purpose? | 23:57 |
*** annashen_ has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!