| *** gouthamr has quit IRC | 00:02 | |
| *** dims has quit IRC | 00:03 | |
| *** takedakn has joined #openstack-cinder | 00:05 | |
| *** mtanino has quit IRC | 00:05 | |
| *** pv__ has quit IRC | 00:05 | |
| *** jdurgin has quit IRC | 00:06 | |
| jgriffith | Not sure who's still around.. but https://review.openstack.org/#/c/219027/ just kicked off verify | 00:07 |
|---|---|---|
| *** jdurgin has joined #openstack-cinder | 00:07 | |
| jgriffith | if I'm not back before it finishes if you somebody could hit the recheck and +2/A on https://review.openstack.org/#/c/218977/ that would be *awesome* | 00:07 |
| *** mtanino has joined #openstack-cinder | 00:09 | |
| *** rushil has quit IRC | 00:10 | |
| *** takedakn has quit IRC | 00:12 | |
| *** diogogmt has quit IRC | 00:18 | |
| *** gouthamr has joined #openstack-cinder | 00:21 | |
| *** takedakn has joined #openstack-cinder | 00:29 | |
| *** mtanino has quit IRC | 00:29 | |
| *** jgravel has joined #openstack-cinder | 00:32 | |
| *** mtanino has joined #openstack-cinder | 00:32 | |
| *** jgravel has left #openstack-cinder | 00:44 | |
| *** angela-s has quit IRC | 00:52 | |
| *** zhangjn has joined #openstack-cinder | 00:57 | |
| *** takedakn has quit IRC | 00:59 | |
| *** garthb has quit IRC | 01:00 | |
| *** garthb_ has quit IRC | 01:00 | |
| *** chlong has joined #openstack-cinder | 01:02 | |
| *** skylerberg has quit IRC | 01:03 | |
| openstackgerrit | Ryan McNair proposed openstack/cinder: Fix MITM vulnerability for Brocade FC SAN lookup https://review.openstack.org/218341 | 01:05 |
| *** lixiaoy1 has joined #openstack-cinder | 01:11 | |
| *** DericHorn-HP has joined #openstack-cinder | 01:13 | |
| *** leeantho has quit IRC | 01:13 | |
| *** Apoorva has quit IRC | 01:14 | |
| *** zhangjn_ has joined #openstack-cinder | 01:17 | |
| *** p0rtal has quit IRC | 01:17 | |
| *** lixiaoy11 has joined #openstack-cinder | 01:18 | |
| *** gouthamr has quit IRC | 01:18 | |
| *** bill_az has quit IRC | 01:19 | |
| *** zhangjn has quit IRC | 01:19 | |
| *** dims has joined #openstack-cinder | 01:20 | |
| *** lixiaoy1 has quit IRC | 01:20 | |
| *** sghanekar has quit IRC | 01:21 | |
| *** vilobhmm1 has quit IRC | 01:22 | |
| openstackgerrit | Eli Qiao proposed openstack/cinder: Handle KeyManager exception when deleting a volume https://review.openstack.org/209828 | 01:24 |
| *** lixiaoy1 has joined #openstack-cinder | 01:24 | |
| *** lixiaoy11 has quit IRC | 01:27 | |
| *** mtanino has quit IRC | 01:29 | |
| *** haomaiwang has joined #openstack-cinder | 01:33 | |
| *** DericHorn-HP has quit IRC | 01:34 | |
| *** edtubill has joined #openstack-cinder | 01:36 | |
| *** mudassirlatif has quit IRC | 01:36 | |
| *** mudassirlatif has joined #openstack-cinder | 01:37 | |
| *** Lee1092 has joined #openstack-cinder | 01:41 | |
| *** mudassirlatif has quit IRC | 01:41 | |
| *** mriedem is now known as mriedem_away | 01:44 | |
| *** haigang has quit IRC | 01:44 | |
| *** sam_wan has joined #openstack-cinder | 01:44 | |
| *** Zhongjun has quit IRC | 01:47 | |
| *** longguang has quit IRC | 01:48 | |
| *** gouthamr has joined #openstack-cinder | 01:50 | |
| *** IlyaG has quit IRC | 01:56 | |
| *** zhangjn_ has quit IRC | 01:58 | |
| *** zhangjn has joined #openstack-cinder | 01:59 | |
| jungleboyj | jgriffith: Recheck started on 218977 | 01:59 |
| *** zhangjn has quit IRC | 01:59 | |
| *** zhangjn has joined #openstack-cinder | 02:00 | |
| *** davechen has joined #openstack-cinder | 02:02 | |
| *** lyanchih has joined #openstack-cinder | 02:04 | |
| jgriffith | jungleboyj: :) already hit it, it's almost done :) | 02:05 |
| jgriffith | jungleboyj: I gave it +2/A | 02:05 |
| jgriffith | bb after dinner | 02:05 |
| jgriffith | jungleboyj: thanks! | 02:05 |
| *** hw__chenying has joined #openstack-cinder | 02:10 | |
| *** vilobhmm1 has joined #openstack-cinder | 02:12 | |
| openstackgerrit | yogeshprasad proposed openstack/cinder: Retype support for CloudByte iSCSI cinder driver https://review.openstack.org/218645 | 02:15 |
| jungleboyj | jgriffith: Crap. I missed that you had already done that. Thanks for din git. | 02:17 |
| jungleboyj | jgriffith: Have a good dinner. | 02:17 |
| *** vilobhmm1 has left #openstack-cinder | 02:18 | |
| *** I has joined #openstack-cinder | 02:20 | |
| *** bkopilov has quit IRC | 02:20 | |
| *** I is now known as Guest10903 | 02:20 | |
| *** baojg has joined #openstack-cinder | 02:23 | |
| *** gouthamr has quit IRC | 02:25 | |
| *** subhadee_ has joined #openstack-cinder | 02:29 | |
| *** subhadeep_de has quit IRC | 02:29 | |
| openstackgerrit | Anna Sortland proposed openstack/cinder: Add delete_snapshot and update_snapshot rules https://review.openstack.org/202680 | 02:30 |
| *** rushiagr_away is now known as rushiagr | 02:36 | |
| openstackgerrit | Rongze Zhu proposed openstack/cinder: Remove deprecated options https://review.openstack.org/219098 | 02:37 |
| *** BharatK has joined #openstack-cinder | 02:45 | |
| *** rushiagr is now known as rushiagr_away | 02:45 | |
| *** sam_wan has quit IRC | 02:46 | |
| *** baojg has quit IRC | 02:49 | |
| *** hakimo has joined #openstack-cinder | 02:52 | |
| *** hakimo_ has quit IRC | 02:54 | |
| *** rushiagr_away is now known as rushiagr | 02:55 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 03:00 |
| jungleboyj | xyang1: jgriffith DuncanT et al The etherpad is updated and I have triple checked to make sure I didn't block anyone that was already +2/+A. Have a bold note next to the ones that are waiting for the gate to clear. | 03:00 |
| xyang1 | jungleboyj: Thanks:) | 03:01 |
| jungleboyj | Flexing my manager muscles. ;-) | 03:02 |
| jungleboyj | xyang1: How are you? Didn't get to chat with you as much in FC> | 03:02 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id) https://review.openstack.org/218781 | 03:02 |
| xyang1 | jungleboyj: Good. Have you booked your tickets yet | 03:03 |
| jungleboyj | xyang1: *Sigh* No, I have a hotel and stuff but no approval for plane tickets. | 03:07 |
| xyang1 | jungleboyj: You are still waiting? Can't imagine they won't approve you though | 03:08 |
| *** annasort has quit IRC | 03:09 | |
| *** Zhongjun has joined #openstack-cinder | 03:10 | |
| xyang1 | jungleboyj: I hope you get approval soon. Good night now | 03:10 |
| *** subhadee_ has quit IRC | 03:11 | |
| *** edtubill has quit IRC | 03:11 | |
| jungleboyj | xyang1: Thanks. I will. | 03:12 |
| jungleboyj | xyang1: Good night! | 03:12 |
| *** chlong has quit IRC | 03:12 | |
| *** xyang1 has quit IRC | 03:13 | |
| *** sam_wan has joined #openstack-cinder | 03:13 | |
| *** rushil has joined #openstack-cinder | 03:15 | |
| *** davechen1 has joined #openstack-cinder | 03:20 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Add cinder.conf.sample to gitignore https://review.openstack.org/216044 | 03:20 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Remove the detination volume check in delete_volume https://review.openstack.org/219108 | 03:20 |
| *** davechen has quit IRC | 03:23 | |
| *** p0rtal has joined #openstack-cinder | 03:24 | |
| *** p0rtal has quit IRC | 03:25 | |
| *** p0rtal has joined #openstack-cinder | 03:26 | |
| *** shausy has joined #openstack-cinder | 03:26 | |
| jungleboyj | jgriffith: Ok, all the ones that need a recheck should be in the check now. | 03:26 |
| jgriffith | jungleboyj: awesome! | 03:26 |
| *** mriedem_away has quit IRC | 03:27 | |
| *** annasort has joined #openstack-cinder | 03:31 | |
| *** davechen has joined #openstack-cinder | 03:33 | |
| *** davechen1 has quit IRC | 03:36 | |
| *** chlong has joined #openstack-cinder | 03:38 | |
| *** subhadeep_de has joined #openstack-cinder | 03:44 | |
| *** links has joined #openstack-cinder | 03:46 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Add instructions on how to deploy API under Apache https://review.openstack.org/207020 | 03:47 |
| *** rushil has quit IRC | 03:50 | |
| *** haomaiwang has quit IRC | 03:51 | |
| *** haomaiwang has joined #openstack-cinder | 03:52 | |
| *** breitz has quit IRC | 03:52 | |
| *** breitz has joined #openstack-cinder | 03:52 | |
| *** p0rtal_ has joined #openstack-cinder | 03:53 | |
| *** p0rtal_ has quit IRC | 03:53 | |
| jgriffith | jungleboyj: DuncanT patrickeast geguileo I've gone through bp's and such again and removed a few. I think we should use Launchpad and the milestone items as a reference for what to review at this point NOT the etherpad. | 03:53 |
| *** p0rtal_ has joined #openstack-cinder | 03:54 | |
| jgriffith | jungleboyj: DuncanT patrickeast geguileo IMHO that's part of why things get dropped, we should just say "what's targettted in LP is priority" after all that's what LP is for no? | 03:54 |
| jgriffith | tbarron: FWIW, that would have probably helped out your patches as well ^^ | 03:54 |
| jgriffith | why do we need multiple records and tracking sources for everything? That just creates confusion | 03:55 |
| jgriffith | LP already has everything, and it has it prioritized | 03:55 |
| patrickeast | sounds good to me | 03:56 |
| *** p0rtal has quit IRC | 03:56 | |
| jgriffith | cool... I hope others are ok with that idea. These etherpads are just duplicate sources of info and more work IMO | 03:57 |
| openstackgerrit | Vincent Hou proposed openstack/python-cinderclient: Volume status management for volume migration https://review.openstack.org/189547 | 03:59 |
| *** markvoelker has joined #openstack-cinder | 04:00 | |
| *** bkopilov has joined #openstack-cinder | 04:00 | |
| *** markvoelker_ has joined #openstack-cinder | 04:02 | |
| *** shausy has quit IRC | 04:04 | |
| *** chlong_ has joined #openstack-cinder | 04:04 | |
| *** chlong has quit IRC | 04:04 | |
| *** markvoelker has quit IRC | 04:04 | |
| *** rushiagr is now known as rushiagr_away | 04:04 | |
| *** takedakn has joined #openstack-cinder | 04:14 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 04:22 |
| *** takedakn has quit IRC | 04:23 | |
| *** baojg has joined #openstack-cinder | 04:25 | |
| *** hw__chenying has quit IRC | 04:26 | |
| *** dims has quit IRC | 04:30 | |
| *** rushiagr_away is now known as rushiagr | 04:31 | |
| jungleboyj | jgriffith: Fair enough. | 04:35 |
| * jungleboyj will work on getting better with LP. :-) | 04:36 | |
| openstackgerrit | Rongze Zhu proposed openstack/cinder: Remove deprecated options https://review.openstack.org/219098 | 04:40 |
| *** rushiagr is now known as rushiagr_away | 04:44 | |
| *** shyama has joined #openstack-cinder | 04:49 | |
| *** hw_chenying has joined #openstack-cinder | 04:52 | |
| *** p0rtal_ has quit IRC | 04:56 | |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Allow specified backend capabilities to be retrieved https://review.openstack.org/212861 | 04:56 |
| *** p0rtal has joined #openstack-cinder | 05:03 | |
| *** ankit_ag has joined #openstack-cinder | 05:08 | |
| *** vincent_hou has joined #openstack-cinder | 05:10 | |
| vincent_hou | https://review.openstack.org/#/c/189547/ | 05:11 |
| *** diablo_rojo has quit IRC | 05:12 | |
| *** shausy has joined #openstack-cinder | 05:21 | |
| *** hw_chenying has quit IRC | 05:23 | |
| *** lpetrut has joined #openstack-cinder | 05:31 | |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve snapshot and clone operation https://review.openstack.org/198952 | 05:36 |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve image operations https://review.openstack.org/202954 | 05:37 |
| *** yrabl has joined #openstack-cinder | 05:38 | |
| *** lyanchih has quit IRC | 05:40 | |
| *** Guest10903 has quit IRC | 05:42 | |
| *** p0rtal has quit IRC | 05:43 | |
| *** lprice1 has joined #openstack-cinder | 05:44 | |
| *** lprice has quit IRC | 05:45 | |
| *** lprice1 has quit IRC | 05:45 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Adds migration abortion for available volumes https://review.openstack.org/207754 | 05:45 |
| *** lyanchih has joined #openstack-cinder | 05:48 | |
| *** nkrinner has joined #openstack-cinder | 05:51 | |
| *** markvoelker_ has quit IRC | 05:53 | |
| *** p0rtal has joined #openstack-cinder | 05:54 | |
| *** hw_chenying has joined #openstack-cinder | 05:57 | |
| *** I has joined #openstack-cinder | 05:58 | |
| *** I is now known as Guest92023 | 05:58 | |
| *** dims has joined #openstack-cinder | 05:59 | |
| *** lyanchih has quit IRC | 06:01 | |
| *** agarciam has joined #openstack-cinder | 06:02 | |
| *** dims has quit IRC | 06:04 | |
| *** shausy has quit IRC | 06:04 | |
| *** shausy has joined #openstack-cinder | 06:05 | |
| *** agarciam has quit IRC | 06:09 | |
| *** baojg has quit IRC | 06:09 | |
| *** lprice has joined #openstack-cinder | 06:09 | |
| *** lpetrut has quit IRC | 06:10 | |
| *** lyanchih has joined #openstack-cinder | 06:15 | |
| *** Zhongjun has quit IRC | 06:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/218741 | 06:17 |
| *** vilobhmm11 has joined #openstack-cinder | 06:18 | |
| *** BharatK has quit IRC | 06:27 | |
| *** deepakcs has joined #openstack-cinder | 06:34 | |
| *** afazekas__ has joined #openstack-cinder | 06:36 | |
| *** lpetrut has joined #openstack-cinder | 06:38 | |
| *** zhongjun has joined #openstack-cinder | 06:49 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Adds migration abortion for available volumes https://review.openstack.org/207754 | 06:51 |
| *** alexschm has joined #openstack-cinder | 06:54 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id) https://review.openstack.org/218781 | 06:59 |
| *** lpetrut has quit IRC | 07:01 | |
| dulek | Hi, are we currently experiencing problems with the gate? I don't want to recheck my patch unnecessarily but errors seem unrelated. | 07:02 |
| dulek | I'm talking about this one - https://review.openstack.org/#/c/160417/ | 07:02 |
| *** abehl has joined #openstack-cinder | 07:02 | |
| *** p0rtal has quit IRC | 07:03 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Service object https://review.openstack.org/160417 | 07:09 |
| *** stefan_amann has joined #openstack-cinder | 07:09 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id) https://review.openstack.org/218781 | 07:12 |
| *** ndipanov has quit IRC | 07:16 | |
| *** deepakcs has quit IRC | 07:22 | |
| *** chlong_ has quit IRC | 07:24 | |
| *** ndipanov has joined #openstack-cinder | 07:27 | |
| *** Zhongjun_ has joined #openstack-cinder | 07:33 | |
| *** ishant has joined #openstack-cinder | 07:34 | |
| *** kjelly has quit IRC | 07:35 | |
| *** kjelly has joined #openstack-cinder | 07:36 | |
| *** zhongjun has quit IRC | 07:38 | |
| *** Zhongjun_ is now known as Zhongjun | 07:38 | |
| *** jwcroppe is now known as jwcroppe_zzz | 07:45 | |
| *** shyama has quit IRC | 07:47 | |
| *** sgotliv has joined #openstack-cinder | 07:54 | |
| *** vincent_hou has quit IRC | 07:55 | |
| *** vilobhmm11 has quit IRC | 07:58 | |
| *** bluex-pl has joined #openstack-cinder | 07:59 | |
| *** zhongjun22 has joined #openstack-cinder | 08:01 | |
| *** lixiaoy1 has quit IRC | 08:05 | |
| *** jistr has joined #openstack-cinder | 08:08 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 08:08 |
| *** lennyb has joined #openstack-cinder | 08:11 | |
| *** e0ne has joined #openstack-cinder | 08:13 | |
| *** baojg has joined #openstack-cinder | 08:16 | |
| *** agarciam has joined #openstack-cinder | 08:21 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 08:25 |
| *** zhangjn_ has joined #openstack-cinder | 08:32 | |
| *** baojg has quit IRC | 08:34 | |
| *** zhangjn has quit IRC | 08:34 | |
| *** e0ne has quit IRC | 08:36 | |
| *** lyanchih has quit IRC | 08:37 | |
| *** dims has joined #openstack-cinder | 08:42 | |
| *** baojg has joined #openstack-cinder | 08:44 | |
| *** IanGovett has joined #openstack-cinder | 08:45 | |
| *** shyama has joined #openstack-cinder | 08:46 | |
| *** lyanchih has joined #openstack-cinder | 08:47 | |
| *** e0ne has joined #openstack-cinder | 08:48 | |
| *** dims has quit IRC | 08:48 | |
| *** aix has quit IRC | 08:50 | |
| *** svilgelm has joined #openstack-cinder | 08:53 | |
| *** ociuhandu has quit IRC | 08:54 | |
| *** boris-42 has quit IRC | 09:00 | |
| *** ndipanov has quit IRC | 09:03 | |
| *** shausy has quit IRC | 09:04 | |
| *** shausy has joined #openstack-cinder | 09:05 | |
| *** baojg has quit IRC | 09:12 | |
| *** zhongjun22 has quit IRC | 09:13 | |
| e0ne | geguileo: hi! you need to rebase https://review.openstack.org/#/c/183222/ to pass CI | 09:13 |
| geguileo | e0ne: I'm on it | 09:14 |
| e0ne | geguileo: ok:) | 09:14 |
| geguileo | e0ne: But it needs some test changes as well, and I'm trying to figure out the best way to do it :-) | 09:14 |
| *** ociuhandu has joined #openstack-cinder | 09:16 | |
| *** aix has joined #openstack-cinder | 09:19 | |
| *** baojg has joined #openstack-cinder | 09:30 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Adds migration abortion for available volumes https://review.openstack.org/207754 | 09:31 |
| *** dims has joined #openstack-cinder | 09:36 | |
| *** Guest92023 has quit IRC | 09:40 | |
| *** dims has quit IRC | 09:41 | |
| *** lpetrut has joined #openstack-cinder | 09:47 | |
| *** davechen has left #openstack-cinder | 09:54 | |
| *** zhongjun22 has joined #openstack-cinder | 09:58 | |
| *** baojg has quit IRC | 10:00 | |
| *** coolsvap has quit IRC | 10:01 | |
| *** coolsvap has joined #openstack-cinder | 10:02 | |
| *** ndipanov has joined #openstack-cinder | 10:03 | |
| *** aix has quit IRC | 10:05 | |
| *** aix has joined #openstack-cinder | 10:05 | |
| *** Zhongjun has quit IRC | 10:07 | |
| openstackgerrit | Petrut Lucian proposed openstack/cinder: SMBFS: Fix retrieving total allocated size https://review.openstack.org/158713 | 10:18 |
| *** dims has joined #openstack-cinder | 10:30 | |
| *** yrabl has quit IRC | 10:31 | |
| *** yrabl has joined #openstack-cinder | 10:32 | |
| *** dims has quit IRC | 10:36 | |
| *** hw_chenying has quit IRC | 10:37 | |
| *** h00327910__ has quit IRC | 10:43 | |
| *** lyanchih has quit IRC | 10:43 | |
| *** ociuhandu_ has joined #openstack-cinder | 10:44 | |
| *** andreykurilin__ has joined #openstack-cinder | 10:45 | |
| *** ociuhandu has quit IRC | 10:45 | |
| *** ociuhandu_ is now known as ociuhandu | 10:45 | |
| *** haypo has joined #openstack-cinder | 10:47 | |
| *** zhangjn_ has quit IRC | 10:47 | |
| haypo | hi. on my latest python3 patchers for cinder, i got question on how i should mention the link the blueprint https://blueprints.launchpad.net/cinder/+spec/cinder-python3 : see https://review.openstack.org/#/c/215752/2//COMMIT_MSG | 10:48 |
| haypo | it's not clear if i should use the syntax "Blueprint <link>", "Implements: blueprint <link>", "Partially implements: blueprint <link>". i maybe use again the name of the blueprint instead of the url? | 10:49 |
| haypo | someone asked me to use the url instead of the name, on a previous change, because the blueprint is now completed, and so launchpad doesn't find the blueprint | 10:49 |
| haypo | i would prefer to continue to use the name, and modify https://blueprints.launchpad.net/cinder/+spec/cinder-python3 status | 10:50 |
| haypo | the blueprint status is "completed" which is not right, cinder is not fully compatible with python 3. i'm still writing python3 patches ;) | 10:50 |
| haypo | thanks in advance for your replies ;) | 10:51 |
| haypo | (reply, answer, comment, anything that can help me to make progress ;)) | 10:51 |
| *** amann has joined #openstack-cinder | 10:51 | |
| *** stefan_amann has quit IRC | 10:54 | |
| dulek | haypo: We're still using Partially-Implements: cinder-objects for versioned objects patches even if BP is completed. I think you can do the same. | 10:54 |
| *** Roamer` has quit IRC | 10:55 | |
| *** Roamer` has joined #openstack-cinder | 10:55 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port image_utils to Python 3 https://review.openstack.org/213817 | 11:00 |
| *** DTadrzak has quit IRC | 11:02 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access https://review.openstack.org/219231 | 11:03 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access https://review.openstack.org/219231 | 11:04 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix backup metadata import missing fields https://review.openstack.org/183222 | 11:05 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port volume transfer to Python 3 https://review.openstack.org/215752 | 11:07 |
| *** Yogi1 has joined #openstack-cinder | 11:08 | |
| *** haomaiwang has quit IRC | 11:08 | |
| *** ganso_ has joined #openstack-cinder | 11:09 | |
| haypo | dulek: ok, i will use "Partially implements: blueprint cinder-python3". (i already upgraded https://review.openstack.org/#/c/215752/) | 11:09 |
| *** Yogi11 has joined #openstack-cinder | 11:09 | |
| *** smoriya has quit IRC | 11:11 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port volume transfer to Python 3 https://review.openstack.org/215752 | 11:12 |
| *** Yogi1 has quit IRC | 11:13 | |
| *** jaypipes has joined #openstack-cinder | 11:14 | |
| *** sayali has quit IRC | 11:15 | |
| *** sayali has joined #openstack-cinder | 11:17 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 11:18 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port image_utils to Python 3 https://review.openstack.org/213817 | 11:22 |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Check before add lun to QoS in Huawei driver https://review.openstack.org/219239 | 11:22 |
| *** hodos has joined #openstack-cinder | 11:23 | |
| *** dims has joined #openstack-cinder | 11:25 | |
| *** timcl has joined #openstack-cinder | 11:29 | |
| *** dims has quit IRC | 11:29 | |
| DuncanT | Any cores about to push https://review.openstack.org/#/c/207020/ through? It's already been +2/A once but needed a rebase, and it is only docs | 11:29 |
| DuncanT | https://review.openstack.org/#/c/212861/ has also been approved once but ran into gate issues | 11:34 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix Python 3 issues in wsgi https://review.openstack.org/217417 | 11:35 |
| *** e0ne has quit IRC | 11:46 | |
| *** sam_wan has quit IRC | 11:48 | |
| *** amann has quit IRC | 11:50 | |
| *** breitz1 has joined #openstack-cinder | 11:51 | |
| *** breitz has quit IRC | 11:51 | |
| shausy | @here can someone confirm creating volume snapshot with diff backend for HP_LHN is supported ? | 11:56 |
| *** gouthamr has joined #openstack-cinder | 11:57 | |
| *** diegows has joined #openstack-cinder | 11:58 | |
| *** svilgelm has quit IRC | 12:01 | |
| DuncanT | shausy: I don't understand the question. You can't snapshot between backends, only on the same backend, but I'm not sure how you'd try - I don't think the API lets you even attempt it | 12:01 |
| *** svilgelm has joined #openstack-cinder | 12:01 | |
| DuncanT | shausy: You can use volume migrate or backup/restore to move between backends | 12:01 |
| *** stefan_amann has joined #openstack-cinder | 12:02 | |
| *** bkopilov has quit IRC | 12:02 | |
| shausy | DuncanT, I have created volume of X volume type and created a snapshot of the same and now im trying to create a volume from snapshot with Y volume type... | 12:05 |
| *** svilgelm has quit IRC | 12:06 | |
| shausy | I just want to know, is this operation supported ? | 12:06 |
| DuncanT | shausy: I believe that is forbidden - snapshots are done using backend specific technology, so it can't be made to work in the general case except by a slow copy | 12:06 |
| shausy | Ok thanks DuncanT. | 12:09 |
| DuncanT | shausy: You can create the volume on the existing backend and then retype it, if that helps | 12:09 |
| *** chlong_ has joined #openstack-cinder | 12:09 | |
| DuncanT | shausy: You loose and thin copy advantage that way though | 12:09 |
| *** bluex-pl has quit IRC | 12:10 | |
| *** annegentle has joined #openstack-cinder | 12:11 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races from delete methods https://review.openstack.org/205835 | 12:11 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add atomic conditional updates to objects https://review.openstack.org/205834 | 12:11 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Rename db.api methods to match models' names https://review.openstack.org/218936 | 12:11 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: WIP: Remove more API races https://review.openstack.org/216378 | 12:11 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Move get_by_id to CinderObject https://review.openstack.org/218012 | 12:11 |
| *** bluex-pl has joined #openstack-cinder | 12:11 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Improve metadata update operations https://review.openstack.org/216376 | 12:11 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races from attach and detach methods https://review.openstack.org/216377 | 12:11 |
| *** bluex-pl has quit IRC | 12:11 | |
| *** bluex-pl has joined #openstack-cinder | 12:12 | |
| *** jgregor has joined #openstack-cinder | 12:13 | |
| *** bluex-pl has quit IRC | 12:14 | |
| *** salv-orlando has quit IRC | 12:14 | |
| *** bluex-pl has joined #openstack-cinder | 12:15 | |
| *** ishant has quit IRC | 12:17 | |
| *** e0ne has joined #openstack-cinder | 12:18 | |
| *** pwehrle has joined #openstack-cinder | 12:19 | |
| *** bswartz has joined #openstack-cinder | 12:21 | |
| *** salv-orlando has joined #openstack-cinder | 12:22 | |
| *** salv-orl_ has joined #openstack-cinder | 12:23 | |
| *** tpsilva has joined #openstack-cinder | 12:26 | |
| *** zhangjn has joined #openstack-cinder | 12:26 | |
| *** salv-orlando has quit IRC | 12:26 | |
| *** zhangjn has quit IRC | 12:27 | |
| *** dims has joined #openstack-cinder | 12:33 | |
| shausy | DuncanT, I will try the same.. thanks alot for ur inputs | 12:33 |
| *** salv-orlando has joined #openstack-cinder | 12:33 | |
| *** svilgelm has joined #openstack-cinder | 12:34 | |
| *** merooney has joined #openstack-cinder | 12:34 | |
| *** crose has joined #openstack-cinder | 12:35 | |
| *** salv-orl_ has quit IRC | 12:37 | |
| *** zhangjn has joined #openstack-cinder | 12:38 | |
| *** svilgelm has quit IRC | 12:39 | |
| *** baojg has joined #openstack-cinder | 12:40 | |
| *** raildo is now known as raildo-afk | 12:40 | |
| *** baojg has quit IRC | 12:42 | |
| *** nzrf has joined #openstack-cinder | 12:42 | |
| *** porrua has joined #openstack-cinder | 12:44 | |
| *** diablo_rojo has joined #openstack-cinder | 12:45 | |
| *** haomaiwang has joined #openstack-cinder | 12:48 | |
| *** diegows has quit IRC | 12:52 | |
| *** gouthamr has quit IRC | 12:52 | |
| *** dustins has joined #openstack-cinder | 12:56 | |
| openstackgerrit | Edmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder https://review.openstack.org/217857 | 12:58 |
| *** vincent_hou has joined #openstack-cinder | 13:00 | |
| vincent_hou | jbernard: Hi | 13:00 |
| jbernard | vincent_hou: heya | 13:00 |
| vincent_hou | jbernard: I will give you a five. I think you know the reason. | 13:01 |
| jbernard | vincent_hou: thanks :) it's been a long road on that one ;) | 13:01 |
| vincent_hou | Well done. | 13:01 |
| jbernard | honestly, the review feedback from everyone was not only super helpful, but I learned a lot during the process and the patch was much better for it | 13:02 |
| vincent_hou | Awesome. I need that one as well. | 13:02 |
| vincent_hou | Exactly, that is how we work in an open source project. | 13:02 |
| *** stefan_amann has quit IRC | 13:03 | |
| vincent_hou | I just did a rebase on your patch, but now I just ned to rebase on master. | 13:03 |
| *** salv-orlando has quit IRC | 13:04 | |
| jbernard | for progress status? | 13:04 |
| vincent_hou | That one is for sure, but I mean this one: https://review.openstack.org/207754 | 13:04 |
| vincent_hou | still working on it. | 13:05 |
| jbernard | ok, let me know if/when you need review | 13:05 |
| vincent_hou | sure. | 13:05 |
| *** gouthamr has joined #openstack-cinder | 13:07 | |
| *** bill_az has joined #openstack-cinder | 13:10 | |
| *** stefan_amann has joined #openstack-cinder | 13:11 | |
| *** baojg has joined #openstack-cinder | 13:12 | |
| *** esker has quit IRC | 13:14 | |
| *** svilgelm has joined #openstack-cinder | 13:18 | |
| *** julim has joined #openstack-cinder | 13:22 | |
| *** mriedem has joined #openstack-cinder | 13:24 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 13:25 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id) https://review.openstack.org/218781 | 13:26 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix backup metadata import missing fields https://review.openstack.org/183222 | 13:27 |
| *** changbl has quit IRC | 13:28 | |
| *** baojg has quit IRC | 13:29 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Fix way of get LUN id in Huawei driver https://review.openstack.org/209749 | 13:30 |
| *** simondodsley has joined #openstack-cinder | 13:31 | |
| *** mtanino has joined #openstack-cinder | 13:31 | |
| *** baojg has joined #openstack-cinder | 13:32 | |
| *** jwcroppe_zzz is now known as jwcroppe | 13:32 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Encode username and password in Huawei driver https://review.openstack.org/216085 | 13:34 |
| *** wilson has joined #openstack-cinder | 13:34 | |
| *** ankit_ag has quit IRC | 13:35 | |
| *** lcurtis has joined #openstack-cinder | 13:36 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Check before add lun to QoS in Huawei driver https://review.openstack.org/219239 | 13:36 |
| *** xyang has joined #openstack-cinder | 13:36 | |
| *** sgotliv has quit IRC | 13:38 | |
| mriedem | is this bad? http://logs.openstack.org/17/215817/2/gate/gate-tempest-dsvm-neutron-full/e9c2466/logs/screen-c-vol.txt.gz#_2015-09-01_04_04_47_016 | 13:40 |
| mriedem | it's only logged at debug level | 13:40 |
| mriedem | seeing a problem in VolumesV1SnapshotTestJSON where tempest times out waiting for a volume to go to in-use status after it's attached but it never does | 13:42 |
| mriedem | even though c-vol says it was attached successfully: http://logs.openstack.org/17/215817/2/gate/gate-tempest-dsvm-neutron-full/e9c2466/logs/screen-c-vol.txt.gz#_2015-09-01_04_04_52_311 | 13:42 |
| *** eharney has joined #openstack-cinder | 13:44 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: utils.synchronized lock name formatting https://review.openstack.org/217258 | 13:46 |
| *** jungleboyj has quit IRC | 13:46 | |
| *** rushil has joined #openstack-cinder | 13:47 | |
| *** edmondsw has joined #openstack-cinder | 13:47 | |
| *** baojg has quit IRC | 13:47 | |
| *** kvidvans has joined #openstack-cinder | 13:48 | |
| *** annegentle has quit IRC | 13:49 | |
| *** amoturi has quit IRC | 13:51 | |
| *** amoturi has joined #openstack-cinder | 13:51 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Adds migration abortion for available volumes https://review.openstack.org/207754 | 13:51 |
| *** sgotliv has joined #openstack-cinder | 13:52 | |
| *** bkopilov has joined #openstack-cinder | 13:56 | |
| *** zul has quit IRC | 13:56 | |
| *** zul has joined #openstack-cinder | 13:56 | |
| mtanino | mriedem: I think it's not bad. Config file didn't exist but it will regenerate automatically at | 14:00 |
| mtanino | mriedem: http://logs.openstack.org/17/215817/2/gate/gate-tempest-dsvm-neutron-full/e9c2466/logs/screen-c-vol.txt.gz#_2015-09-01_04_04_47_119 | 14:00 |
| mriedem | mtanino: ok, i was going to dig into the tempest.api.volume.test_volumes_snapshots.VolumesV1SnapshotTestJSON.test_snapshot_create_with_volume_in_use test and see what it's failing on | 14:00 |
| mtanino | mriedem: then the volume attachment was succeeded, I think | 14:00 |
| mriedem | http://logs.openstack.org/17/215817/2/gate/gate-tempest-dsvm-neutron-full/e9c2466/console.html#_2015-09-01_04_31_42_912 | 14:00 |
| *** thangp has joined #openstack-cinder | 14:00 | |
| mriedem | i see it creates a volume and attaches it ok, then creates a snapshot | 14:00 |
| mriedem | snapshot of the volume | 14:00 |
| mriedem | i'm not sure what happens after that, i have to dig into what the test is doing | 14:01 |
| mriedem | but now i have to start my day of 5 meetings | 14:01 |
| *** mriedem is now known as mriedem_meetings | 14:01 | |
| mtanino | mriedem_meetings: oops... | 14:01 |
| *** lprice has quit IRC | 14:01 | |
| *** crose has quit IRC | 14:02 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Adds migration abortion for available volumes https://review.openstack.org/207754 | 14:04 |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Fix way of get LUN id in Huawei driver https://review.openstack.org/209749 | 14:06 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access https://review.openstack.org/219231 | 14:08 |
| thangp | geguileo: ping | 14:10 |
| geguileo | thangp: Hi | 14:10 |
| thangp | geguileo: 177054 | 14:10 |
| thangp | geguileo: I tried breaking it up to specific apis | 14:10 |
| geguileo | thangp: Can't it be reduced even more? Because it looks like it's possible | 14:11 |
| geguileo | (though I could be wrong) | 14:11 |
| thangp | geguileo: but since volume is so intertwined with everything, i cant do one without doing another | 14:11 |
| thangp | Daniel Tadrzak tried | 14:11 |
| thangp | geguileo: he had a hard time because everything just breaks | 14:12 |
| geguileo | thangp: The problem now is that we are trying to do the reserve of what should have been done | 14:13 |
| geguileo | thangp: And that's usually HELL | 14:13 |
| thangp | geguileo: reserve? | 14:13 |
| geguileo | thangp: ^ what do you mean? | 14:13 |
| thangp | geguileo: "The problem now is that we are trying to do the reserve" | 14:14 |
| geguileo | XD XD XD | 14:14 |
| thangp | geguileo: I dont understand your comment | 14:14 |
| geguileo | thangp: s/reserve/reverse | 14:14 |
| geguileo | thangp: It's normal you couldn't understand me with these fingers that write whatever they want ;-) | 14:15 |
| *** andreykurilin__ has quit IRC | 14:15 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Check before add lun to QoS in Huawei driver https://review.openstack.org/219239 | 14:16 |
| thangp | geguileo: i dont think it can be broken up easily | 14:17 |
| geguileo | thangp: I see the patch is changing create, create_snapshot, _migrate_volume_generic and _clean_temporary_volume in the same patch | 14:17 |
| thangp | geguileo: which file is create_snapshot in? | 14:18 |
| geguileo | thangp: manager | 14:18 |
| *** rushil has quit IRC | 14:18 | |
| thangp | geguileo: create_snapshot can go out | 14:20 |
| *** takedakn has joined #openstack-cinder | 14:21 | |
| thangp | geguileo: but i remember having problems with tempest for the conversion, hence the changes went into these methods | 14:21 |
| *** xyang has quit IRC | 14:22 | |
| *** links has quit IRC | 14:23 | |
| *** edtubill has joined #openstack-cinder | 14:24 | |
| *** annegentle has joined #openstack-cinder | 14:25 | |
| *** timcl has quit IRC | 14:25 | |
| *** alejandrito has joined #openstack-cinder | 14:26 | |
| *** akerr has joined #openstack-cinder | 14:27 | |
| *** takedakn has quit IRC | 14:28 | |
| *** xyang has joined #openstack-cinder | 14:28 | |
| *** dustins_ has joined #openstack-cinder | 14:28 | |
| e0ne | й is | 14:29 |
| e0ne | oops | 14:29 |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 14:29 |
| *** dustins has quit IRC | 14:31 | |
| jgriffith | thangp: geguileo correct me if I'm wrong, but really over 90% of that is unit test changes no? | 14:31 |
| dulek | jgriffith: 75.9% exactly - I've just counted. ;) | 14:31 |
| thangp | :) | 14:31 |
| geguileo | jgriffith: But if unittests are not changed correctly they may not be testing what they should and how they should be testing it | 14:32 |
| e0ne | what changes do you mean? | 14:32 |
| geguileo | jgriffith: So those changes are just as important | 14:32 |
| jgriffith | geguileo: duhh :) | 14:32 |
| thangp | e0ne: to use versionedobjects instead of db | 14:32 |
| dulek | geguileo: Basically when reviewing I've checked for removed asserts. There's just a few, all justified. | 14:32 |
| jgriffith | geguileo: did I say they weren't? | 14:32 |
| geguileo | e0ne: For Volume | 14:32 |
| thangp | e0ne: instead of db dicts | 14:32 |
| geguileo | jgriffith: No you didn't :-) | 14:33 |
| jgriffith | geguileo: it's tricky because any time you make any change in volume code you're going to have a significant ripple effect out to the unit tests | 14:33 |
| jgriffith | geguileo: that being said, the patch is a bit large for my liking at L3 | 14:33 |
| jgriffith | geguileo: we're supposed to be getting more selective at this point, not rewriting the world :) | 14:33 |
| geguileo | jgriffith: Me? | 14:34 |
| jgriffith | geguileo: you what? | 14:34 |
| geguileo | jgriffith: It's not my patch | 14:34 |
| jgriffith | geguileo: I'm aware of that | 14:34 |
| geguileo | jgriffith: My patches are getting -2 from you ;-P | 14:34 |
| jgriffith | geguileo: I'm somewhat agreeing with your comments in the patch | 14:34 |
| jgriffith | geguileo: yes they are | 14:34 |
| jgriffith | geguileo: but you've updated them | 14:34 |
| jgriffith | geguileo: I haven't looked yet | 14:35 |
| geguileo | jgriffith: It was just a joke, I know why you -2 them :-) | 14:35 |
| jgriffith | geguileo: Oh... :) | 14:35 |
| thangp | at this point, i'm not expecting it to be able to go into L3...but i have a problem breaking up the patch | 14:35 |
| jgriffith | thangp: understood... | 14:35 |
| jgriffith | thangp: maybe folks can volunteer to help look for opportunities on breaking it up | 14:36 |
| openstackgerrit | Vincent Hou proposed openstack/python-cinderclient: Volume status management for volume migration https://review.openstack.org/189547 | 14:36 |
| dulek | Basically without all object patches we're loosing possibility of making rolling upgrades L->M possible. | 14:36 |
| jgriffith | thangp: I had though isolate the taskflow stfuff as a start, but that doesn't work :( | 14:36 |
| geguileo | thangp: Puffff, then that's going to be hellish to review :''-( | 14:36 |
| jgriffith | Then I though... manager and rpc... bizzzzz no joy | 14:36 |
| jgriffith | dulek: indeed | 14:37 |
| geguileo | dulek: Yes, but changing ALL volume operation in L3 is really risky, don't you think? | 14:37 |
| dulek | jgriffith: Probably the only sane idea would be to split create and delete. | 14:37 |
| dulek | geguileo: It definitely is, I know that. | 14:37 |
| thangp | dulek: yeah, that will only account for 100 lines :) | 14:37 |
| jgriffith | dulek: yeah, breaking it up by operation seems to be the only workable solution | 14:37 |
| *** timcl has joined #openstack-cinder | 14:38 | |
| dulek | jgriffith: Thing is - a lot of volume tests are doing creates and deletes in one test, so it's kind of natural to change that in one shot. | 14:38 |
| thangp | jgriffith, geguileo: the get operation is causing the largest change | 14:38 |
| jgriffith | dulek: oh, I get it it... | 14:38 |
| jgriffith | hmmm... what a kunundrum | 14:40 |
| *** afazekas__ has quit IRC | 14:41 | |
| *** Yogi11 has quit IRC | 14:41 | |
| dulek | We were actually able to merge snapshots, which were a +1468, -272 patch. | 14:41 |
| jgriffith | one thing to keep in mind is that most of it is not *functional* or *logic* changes, it's just data-structures | 14:41 |
| thangp | jgriffith: correct | 14:42 |
| jgriffith | dulek: yeah, I'm not saying we can't merge it, not saying the size is a deal breaker | 14:42 |
| *** boris-42 has joined #openstack-cinder | 14:42 | |
| jgriffith | dulek: just trying to talk through some of the concerns | 14:42 |
| jgriffith | dulek: part of the reality is if we don't "just do it" we never will | 14:42 |
| jgriffith | The fact that is' been in progress since April and has 80+ revisions I HATE the thought of dragging it out even longer :) | 14:43 |
| dulek | jgriffith: That's my concern also - works on patch started in Apirl. | 14:43 |
| jgriffith | dulek: thangp I say get it rebased, and we all dedicate time TODAY to review it | 14:44 |
| thangp | jgriffith: ok, will do | 14:45 |
| vincent_hou | geguileo: thank you for ur comments. | 14:45 |
| jgriffith | dulek: thangp and if I see any nit picky bs about punctuation or spelling I'm going to blow a gasket :) | 14:45 |
| thangp | jgriffith: :) | 14:45 |
| geguileo | vincent_hou: that patch is just about ready :-) | 14:45 |
| DuncanT | jgriffith: 'pickey' ;-) | 14:46 |
| geguileo | jgriffith: You and me both | 14:46 |
| * DuncanT ducks | 14:46 | |
| jgriffith | if there's a typo in a comment I don't really care; if it's a doc-string... meh; ok but shouldn't be a -1 unless it's something like profanity interlaced in with the description :) | 14:46 |
| dulek | jgriffith, thangp: That way we'll at least have compatibility for rolling upgrades L->M for creating and deleting volumes. | 14:46 |
| vincent_hou | geguileo: Just submit a new one. | 14:46 |
| geguileo | vincent_hou: Awesome | 14:46 |
| dulek | That's something. :) | 14:46 |
| * jgriffith lobs a water balloon at DuncanT | 14:46 | |
| jgriffith | and it's shot down by Israel's iron curtain | 14:46 |
| DuncanT | lol | 14:46 |
| dulek | :D | 14:46 |
| dulek | BTW - there's one more smaller objects patch - CGSnapshots | 14:47 |
| dulek | https://review.openstack.org/#/c/195027/37 | 14:47 |
| DuncanT | I do actually rather agree with your point though, and I'm happy to merge over the top of nit pick -1s | 14:47 |
| jgriffith | DuncanT: smcginnis_afk patrickeast geguileo eharney xyang You all ok with proceeding/comitting to reviewing that patch today? | 14:47 |
| *** ppal has joined #openstack-cinder | 14:47 | |
| * jgriffith would ask other cores but they're not all online | 14:47 | |
| DuncanT | jgriffith: The CGSnap one or the vol one? | 14:47 |
| dulek | thangp: Do you agree with my concerns on unnecessary DB calls? I can help you with fixing them if you have any questions. | 14:48 |
| jgriffith | This one: https://review.openstack.org/#/c/177054/84 | 14:48 |
| jgriffith | whcih cg-snap one? | 14:48 |
| DuncanT | I've got about 40 minutes I can spend on it now | 14:48 |
| thangp | dulek: yeah, I agree | 14:48 |
| *** vincent_hou has quit IRC | 14:48 | |
| thangp | dulek: let me put rebase of the vol obj | 14:48 |
| jgriffith | DuncanT: that works | 14:48 |
| thangp | dulek: if you have time, could you help me with the taskflow stuff? | 14:48 |
| openstackgerrit | Thang Pham proposed openstack/cinder: Sync volume versionedobject to ORM https://review.openstack.org/218361 | 14:49 |
| dulek | thangp: Definitely, I'll stay here for some time. | 14:49 |
| jgriffith | BTW... those on the night shift may not have seen my note last night; I don't think the etherpad thing worked out very well for us, I think we should use Launchpad as that's what it's for. | 14:49 |
| jgriffith | All the items for L3 are there and targetted and those should be priority | 14:49 |
| dulek | jgriffith: The CGSNapshot's one is here: https://review.openstack.org/#/c/195027/37 | 14:49 |
| jgriffith | DuncanT: I think that can wait personally | 14:50 |
| jgriffith | errr.. dulek ^^ | 14:50 |
| geguileo | jgriffith: This one also need reviewing https://review.openstack.org/#/c/218361 | 14:50 |
| geguileo | jgriffith: Which syncs Volume to ORM Volume | 14:50 |
| *** rushil has joined #openstack-cinder | 14:50 | |
| jgriffith | geguileo: yeah... I was looking at that dep chain :( | 14:51 |
| jgriffith | CGSnapsots would be my lowest priority | 14:51 |
| xyang | jgriffith: that one still need a requirement change? | 14:51 |
| jgriffith | any chance at getting volumes actually merged would be a big win IMO | 14:51 |
| jgriffith | I know it might not be possible, but if people are willing to try I think it would be worth the investment | 14:52 |
| *** svilgelm has quit IRC | 14:52 | |
| jgriffith | xyang: the volume objects requires the ORM change | 14:52 |
| * geguileo thinks it's a bad idea to review and merge 3700 LOC at this point | 14:52 | |
| xyang | jgriffith: I mean the CGSnapshot change | 14:52 |
| *** svilgelm has joined #openstack-cinder | 14:52 | |
| * DuncanT is reviewing https://review.openstack.org/#/c/218361/2 first on the off change the merge conflict is fixed by the time I'm finished | 14:52 | |
| jgriffith | geguileo: yeah... you may be rigth | 14:52 |
| jgriffith | right even :) | 14:52 |
| geguileo | XD | 14:52 |
| xyang | jgriffith: it needs a requirement change for the versionedobjects release | 14:52 |
| jgriffith | hmm... oh boy; I don't know if this is going to work | 14:53 |
| *** nkrinner has quit IRC | 14:53 | |
| dulek | xyang: Actually global-requirements commit is merged, so no blockers no. | 14:53 |
| dulek | xyang: s/no./now. | 14:53 |
| *** tpsilva has quit IRC | 14:53 | |
| jgriffith | I will say one thing!!! If we don't merge this in L, I vote that NOTHING is reviewed/merged in M until this lands | 14:54 |
| jgriffith | we can't go on like this IMO | 14:54 |
| jgriffith | for once we need to just "finish" something :) | 14:54 |
| *** cdelatte has joined #openstack-cinder | 14:55 | |
| *** delattec has joined #openstack-cinder | 14:55 | |
| xyang | jgriffith: I have tested this earlier. Just need to make sure the right version of versionedobjects is installed, otherwise cg functions will fail | 14:55 |
| jgriffith | geguileo: BTW the counter-argument to the "it's late in the cycle" is that we've always lived under this silly false pretense that everybody deploys OpenStack continiously from trunk so release is just a tag or a date :) | 14:55 |
| jgriffith | geguileo: I clearly see the difference, but just pointing out the argument :) | 14:56 |
| xyang | dulek: can you send me a url for the global-requirement change? | 14:56 |
| geguileo | jgriffith: You do have a point | 14:56 |
| jgriffith | geguileo: it's not a very strong one... but it is "a point" anyway :) | 14:57 |
| geguileo | jgriffith: And I do really want to see us using Volume vo everywhere... | 14:57 |
| *** svilgelm has quit IRC | 14:57 | |
| *** zhangjn has quit IRC | 14:57 | |
| *** links has joined #openstack-cinder | 14:57 | |
| dulek | xyang: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L92 | 14:58 |
| xyang | dulek: thanks | 14:58 |
| *** jistr is now known as jistr|call | 14:58 | |
| *** erlon has quit IRC | 14:58 | |
| *** thangp has quit IRC | 14:58 | |
| dulek | xyang: And here's the review: https://review.openstack.org/#/c/216848/ | 14:58 |
| dulek | jgriffith: One more thing, I worked to fix a bug with using Cinder on non-US locale: https://review.openstack.org/#/c/216675/ | 14:59 |
| *** hemna has joined #openstack-cinder | 14:59 | |
| jgriffith | DuncanT: geguileo xyang dulek so here's my other conflicted view on this.... | 14:59 |
| dulek | jgriffith: As this is changing rootwrap filters it requires grenade changes, which require a release note and an ACK from PTL. | 15:00 |
| jgriffith | DuncanT: geguileo xyang dulek rolling upgrades are cool; and they're pretty important for projects like Nova | 15:00 |
| jgriffith | for Cinder, I've always viewed them as a "convenience" not a must-have | 15:00 |
| jgriffith | dulek: I don't think we're going to be able to do this | 15:01 |
| *** daemontool_ has quit IRC | 15:01 | |
| dulek | jgriffith: Okay, early Mitaka it is! :) | 15:01 |
| jgriffith | dulek: the thought of changing grenade and gate at this point along with everything else I'm afraid is going to show bad judgement | 15:01 |
| jgriffith | dulek: I'm really sorry; I really wanted to just commit to this and move forward on it today | 15:01 |
| jgriffith | dulek: I WISH that I had been paying attention to this earlier, this SHOULD have been driven as a top priority in L2 or at least the first half of L3 | 15:02 |
| xyang | jgriffith: so not merging the CGSnapshot object change in L? https://review.openstack.org/#/c/195027/ | 15:02 |
| jgriffith | dulek: we really need to organize our efforts better and work as a team | 15:02 |
| dulek | jgriffith: Yeah, I've discovered it in late L3. I look at it as rather low priority - you can always change locale, so I'm okay with moving it to M> | 15:03 |
| jgriffith | xyang: I don't think that one was really ever on the table | 15:03 |
| jgriffith | :) | 15:03 |
| jgriffith | xyang: in other words no | 15:03 |
| xyang | jgriffith: oh, you pinged me earlier for that:) | 15:03 |
| jgriffith | xyang: sorry... DuncanT asked about that one, but I was actually talking about the volume version | 15:04 |
| xyang | jgriffith: ok, I won't +2 then | 15:04 |
| *** diogogmt has joined #openstack-cinder | 15:04 | |
| jgriffith | xyang: TBH I haven't looked at the CG one much; I'm not necessarily sure which way to go on that one yet | 15:04 |
| xyang | jgriffith: the CG object is already merged | 15:05 |
| xyang | jgriffith: this one is CGSnapshot object | 15:05 |
| jgriffith | xyang: yeah.... looking | 15:05 |
| xyang | jgriffith: blocked earlier because of a bug in versionedobjects | 15:05 |
| jgriffith | xyang: that one's fine IMO if people want to review it | 15:06 |
| jgriffith | It's isolated, and "smallish" | 15:06 |
| xyang | jgriffith: I'm already done reviewing it. now that requirements are all updated for versionedobjects change | 15:06 |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Add instructions on how to deploy API under Apache https://review.openstack.org/207020 | 15:07 |
| xyang | jgriffith: so I'll +2 if it passes Jenkins? | 15:07 |
| *** diogogmt has quit IRC | 15:07 | |
| jgriffith | xyang: sure... why not :) | 15:08 |
| jgriffith | what could go wrong | 15:08 |
| *** diogogmt has joined #openstack-cinder | 15:09 | |
| xyang | jgriffith: :) | 15:09 |
| jgriffith | tbarron: you around? | 15:09 |
| *** diogogmt has quit IRC | 15:11 | |
| tbarron | jgriffith: you getcha | 15:11 |
| tbarron | betcha | 15:11 |
| tbarron | what's up? | 15:12 |
| *** alexschm has quit IRC | 15:13 | |
| *** salv-orlando has joined #openstack-cinder | 15:13 | |
| *** thangp has joined #openstack-cinder | 15:14 | |
| *** cbader has joined #openstack-cinder | 15:14 | |
| dulek | jgriffith: Ehm, I think we got misunderstood a little. Volume object doesn't have grenade dependencies... I've pointed to other review. | 15:14 |
| *** links has quit IRC | 15:16 | |
| *** dims has quit IRC | 15:17 | |
| *** salv-orlando has quit IRC | 15:18 | |
| *** sayali has quit IRC | 15:19 | |
| *** salv-orlando has joined #openstack-cinder | 15:19 | |
| *** diogogmt has joined #openstack-cinder | 15:21 | |
| *** sayali has joined #openstack-cinder | 15:21 | |
| *** rmetcalf has joined #openstack-cinder | 15:21 | |
| *** annegentle has quit IRC | 15:23 | |
| *** annegentle has joined #openstack-cinder | 15:23 | |
| *** jdurgin1 has joined #openstack-cinder | 15:23 | |
| *** diogogmt has quit IRC | 15:24 | |
| *** salv-orlando has quit IRC | 15:26 | |
| *** haomaiwang has quit IRC | 15:27 | |
| *** timcl has quit IRC | 15:29 | |
| jgriffith | tbarron: never mind, saw your post on ML and just responded to that | 15:30 |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Add instructions on how to deploy API under Apache https://review.openstack.org/207020 | 15:31 |
| jgriffith | tbarron: I believe I also asked you to let me know how you would prioritize those items on your list | 15:33 |
| *** avishay has joined #openstack-cinder | 15:34 | |
| tbarron | jgriffith: I changed the order to (among ours only) to reflect priority | 15:34 |
| jgriffith | tbarron: ya know, I'm trying to be nice here and even tempered; but frankly I find this extremely annoying | 15:35 |
| *** p0rtal has joined #openstack-cinder | 15:35 | |
| jgriffith | tbarron: you've been working in Cinder long enough | 15:35 |
| openstackgerrit | Anton Arefiev proposed openstack/cinder: Add instructions on how to deploy API under Apache https://review.openstack.org/207020 | 15:35 |
| jgriffith | tbarron: YOU should know that to expect to post a patch for a driver FEATURE and think it's going to just breeze through in a week is foolish! | 15:35 |
| jgriffith | tbarron: ESPECIALLY when that week is the closing week for the 3'rd milestone | 15:36 |
| tbarron | jgriffith: Honestly I have been trying to follow the process that was outlined for us. Everything on their made the deadlines, etc. | 15:36 |
| jgriffith | tbarron: prioritizations are there for a reason.. and that reason is that things that are "higher" in priority are the friking PRIORITY | 15:36 |
| jgriffith | tbarron: things that are LOW on the list are "lower on the list" | 15:37 |
| jgriffith | tbarron: You're completely missing the point!!!! | 15:37 |
| avishay | hey all | 15:37 |
| jgriffith | tbarron: process, deadlines etc... it's all artificial | 15:37 |
| jgriffith | avishay: hey !!! | 15:37 |
| jgriffith | avishay: how the heck have you been! | 15:37 |
| avishay | jgriffith: what's going on man? | 15:37 |
| avishay | jgriffith: doing well :) | 15:38 |
| avishay | jgriffith: you? | 15:38 |
| jgriffith | avishay: the usual | 15:38 |
| tbarron | jgriffith: I don't want to get in the way of productive work today and will drop off for now unless there's something constructive I can add. | 15:38 |
| jgriffith | avishay: "my patches didn't make L3... you suck blah blah blah" | 15:38 |
| jgriffith | tbarron: yes, there is | 15:38 |
| jgriffith | you can help get the high and med stuff figured out | 15:38 |
| *** salv-orlando has joined #openstack-cinder | 15:38 | |
| avishay | jgriffith: :) | 15:38 |
| jgriffith | and then we can move to the low priority ones in your list | 15:38 |
| tbarron | jgriffith: I have been reviewing quite steadily and will continue to do so. | 15:39 |
| jgriffith | tbarron: we have more cores submitting new patches than we have doing reviews right now... which isn't really helping me here | 15:39 |
| jgriffith | or you fo rthat matter | 15:39 |
| jgriffith | tbarron: okie dokie, thanks | 15:39 |
| e0ne | jgriffith: hi. could you please take a look on it (https://review.openstack.org/#/c/194726/) if you'll get a time? this patch switches cinder to api v2 in infra tempest tests | 15:39 |
| avishay | OpenStack doesn't support rolling upgrades, does it? | 15:40 |
| e0ne | jgriffith: i'm going to post to openstack-dev about it too | 15:40 |
| jbernard | avishay: not yet | 15:40 |
| jbernard | avishay: oh sorry, cinder not yet | 15:40 |
| jbernard | avishay: nova does | 15:40 |
| jgriffith | avishay: lol... we were just talking about that | 15:40 |
| dulek | avishay: Heat, Glance and Swift also, | 15:41 |
| jbernard | dulek: and i think neutron is working on it | 15:41 |
| avishay | wow | 15:41 |
| avishay | nice | 15:41 |
| avishay | any pointer as to how it works in nova/glance? | 15:41 |
| jgriffith | dulek: you're killin me man :( | 15:41 |
| e0ne | jgriffith: thanks! i just wanted to confirm that we want it in liberty | 15:41 |
| jgriffith | dulek: I would like to merge that patch... I REALLY would | 15:41 |
| jbernard | jgriffith: all the cool kids are rolling upgrades man, get with the times :) | 15:42 |
| jgriffith | jbernard: LOL | 15:42 |
| jgriffith | damn HIPSTERS!!! | 15:42 |
| e0ne | :) | 15:42 |
| jbernard | ruining everything! | 15:42 |
| avishay | :) | 15:42 |
| *** dustins_ has quit IRC | 15:43 | |
| dulek | jgriffith: I get it, just please read this log again, there were quite big misunderstanding about granade: http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/latest.log.html#t2015-09-01T14:59:31 | 15:43 |
| jgriffith | dulek: thangp I'm just curious... do you guys think that moving that to M is the wrong call? I mean, setting aside the fact that you've put so much work into it | 15:43 |
| dulek | s/granade/grenade | 15:43 |
| *** subhadeep_de has quit IRC | 15:43 | |
| jgriffith | dulek: oh... yes... about that | 15:43 |
| thangp | jgriffith: moving what? | 15:44 |
| jgriffith | dulek: so I was/am confused | 15:44 |
| thangp | jgriffith: rolling upgrade? | 15:44 |
| jgriffith | thangp: yes | 15:44 |
| jgriffith | thangp: or the volume objects patch at any rate | 15:44 |
| *** subhadeep_de has joined #openstack-cinder | 15:44 | |
| dulek | jgriffith: I was talking about review https://review.openstack.org/#/c/216675/ and *not* about the volume patch. | 15:44 |
| avishay | jbernard: dulek: any pointers as to how to do rolling upgrades with nova/glance? | 15:44 |
| jgriffith | dulek: Oh!!! | 15:44 |
| thangp | jgriffith: thing is that, in order to doing some rolling upgrade, we need the objects in place | 15:44 |
| avishay | via "objects"? | 15:44 |
| jgriffith | dulek: thank god! | 15:44 |
| jgriffith | dulek: ok, so now I'm back on the fence again | 15:45 |
| jgriffith | :) | 15:45 |
| dulek | avishay: http://superuser.openstack.org/articles/upgrading-nova-to-kilo-with-minimal-downtime | 15:45 |
| jgriffith | I would LOVE some input form others | 15:45 |
| avishay | dulek: gracias | 15:45 |
| dulek | jgriffith: I know, I know, sorry about that, got in the middle of your messages with mine. | 15:45 |
| jgriffith | dulek: yeah, you mentioned that and the rootwrap stuff and I was like... duuude, no way | 15:46 |
| jgriffith | I'm out | 15:46 |
| dulek | jgriffith: It would be quite silly if that would require changing rootwrap. | 15:46 |
| dulek | jgriffith: So about rolling upgrades - ops are always saying that this is an issue. | 15:47 |
| jgriffith | dulek: well... I was wondering what was going on that you'd need a grenade change and a rootwrap change | 15:47 |
| dulek | jgriffith: Especially with 6-months releases. | 15:47 |
| jgriffith | dulek: that's what pushed me over the edge and made me put the -2 on this https://review.openstack.org/#/c/177054/ | 15:47 |
| dulek | jgriffith: And for my work I'm getting requirements by talking with ops mostly. | 15:47 |
| dulek | jgriffith: That's why I think it is a hot topic in the community. | 15:48 |
| *** martyturner has joined #openstack-cinder | 15:48 | |
| dulek | jgriffith: I think thingee also said in Vancouver that he's tired of ops complaining that Cinder cannot do upgrades without downtime. | 15:49 |
| dulek | jgriffith: And first step is object versioning which allows us to run multiple versions of services and downgrade objects on demand. | 15:50 |
| thangp | jgriffith, dulek: it's going to take some time before we get actual rolling-upgrade to work. you need to have a release that has the stuff to transform the rpc and objects first...then the next release will be able to do rolling upgrade | 15:50 |
| jgriffith | the magical "ops" groups | 15:50 |
| jgriffith | kinda like a unicorn | 15:50 |
| jgriffith | thangp: yeah, that's why it's kind of important to quite screwing around on this | 15:51 |
| dulek | thangp: Actually to get upgrade X->Y possible you need to have all versioned objects calls done in X. | 15:51 |
| *** j_king has left #openstack-cinder | 15:51 | |
| jgriffith | thangp: and why somebody should've been driving it a long time ago | 15:51 |
| *** xyang has quit IRC | 15:51 | |
| jgriffith | dulek: I tihnk that was his point | 15:51 |
| *** mriedem_meetings is now known as mriedem | 15:51 | |
| thangp | dulek, jgriffith: correct | 15:52 |
| *** garthb has joined #openstack-cinder | 15:52 | |
| *** garthb_ has joined #openstack-cinder | 15:52 | |
| dulek | jgriffith, thangp: What I've meant is that RPC compatibility mode (aka RPC version pinning) is needed only in Y. | 15:52 |
| thangp | dulek: well...we need code to register the versions in X, so you know what to pin to | 15:53 |
| thangp | in Y | 15:53 |
| *** dustins has joined #openstack-cinder | 15:54 | |
| dulek | thangp: Ah, right. In Cinder's model that's true. In Heat's model pinning is done in configuration, so admin can simply add config option for heat.conf in newer services. | 15:54 |
| thangp | dulek: https://review.openstack.org/#/c/209701/ | 15:55 |
| thangp | dulek: have to rebase :/ | 15:55 |
| *** shausy has quit IRC | 15:56 | |
| *** ociuhandu_ has joined #openstack-cinder | 15:58 | |
| *** esker has joined #openstack-cinder | 15:59 | |
| *** esker has quit IRC | 16:00 | |
| *** zhenguo has quit IRC | 16:00 | |
| *** skylerberg has joined #openstack-cinder | 16:00 | |
| *** eharney has quit IRC | 16:01 | |
| *** esker has joined #openstack-cinder | 16:01 | |
| *** vilobhmm1 has joined #openstack-cinder | 16:01 | |
| *** xyang has joined #openstack-cinder | 16:02 | |
| *** martyturner has quit IRC | 16:03 | |
| *** martyturner has joined #openstack-cinder | 16:04 | |
| *** dims has joined #openstack-cinder | 16:05 | |
| *** e0ne has quit IRC | 16:05 | |
| *** crose has joined #openstack-cinder | 16:06 | |
| *** leeantho has joined #openstack-cinder | 16:06 | |
| *** ociuhandu_ has quit IRC | 16:07 | |
| *** akerr has quit IRC | 16:07 | |
| *** stefan_amann has quit IRC | 16:08 | |
| *** dflorea has joined #openstack-cinder | 16:09 | |
| *** pwehrle has quit IRC | 16:09 | |
| *** changbl has joined #openstack-cinder | 16:10 | |
| *** akerr has joined #openstack-cinder | 16:11 | |
| thrawn01 | anyone know of some openstack projects that are using pylint and might have examples of custom pylint checkers? | 16:11 |
| *** martyturner1 has joined #openstack-cinder | 16:12 | |
| thrawn01 | pylint documentation is limited when it comes to custome checkers, it has some examples but not even sure how to load the custom checker once I write it! | 16:12 |
| *** martyturner has quit IRC | 16:12 | |
| thrawn01 | I'm trying to do this "low hanging fruit" https://bugs.launchpad.net/cinder/+bug/1415241 | 16:12 |
| openstack | Launchpad bug 1415241 in Cinder "cinder hacking checks don't cover logging format string arg count" [Undecided,New] - Assigned to Scott DAngelo (scott-dangelo) | 16:12 |
| *** garthb_ has quit IRC | 16:15 | |
| thangp | dulek: do you still plan to update https://review.openstack.org/177054? | 16:15 |
| *** jaypipes has quit IRC | 16:16 | |
| *** eharney has joined #openstack-cinder | 16:16 | |
| dulek | thangp: Ah, you've thought I will do it. Sorry, another misunderstanding. I can do it, give me a few minutes. :) | 16:17 |
| thangp | dulek: :) | 16:17 |
| *** lprice has joined #openstack-cinder | 16:17 | |
| *** vilobhmm1 has left #openstack-cinder | 16:17 | |
| *** esker has quit IRC | 16:20 | |
| *** sgotliv has quit IRC | 16:21 | |
| *** hemna_ has joined #openstack-cinder | 16:27 | |
| *** jaypipes has joined #openstack-cinder | 16:27 | |
| *** jistr|call has quit IRC | 16:28 | |
| *** dannywilson has joined #openstack-cinder | 16:28 | |
| *** bluex-pl has quit IRC | 16:30 | |
| *** jdurgin1 has quit IRC | 16:30 | |
| *** dannywilson has quit IRC | 16:30 | |
| *** gouthamr has quit IRC | 16:32 | |
| *** avishay has quit IRC | 16:35 | |
| *** avishay has joined #openstack-cinder | 16:35 | |
| hemna_ | phew | 16:35 |
| hemna_ | finally have my desktop back | 16:35 |
| hemna_ | man, apt-get upgrade changed the / LVM UUID ! | 16:36 |
| Swanson | plus an underscore | 16:36 |
| smcginnis_afk | thrawn01: Make sure Scott sin't working on it first suince it's assigned to him. | 16:36 |
| smcginnis_afk | OMG wifi sucks here. | 16:37 |
| Swanson | Are you at IBM? | 16:37 |
| smcginnis_afk | thrawn01: Second, it would be a flake8 plugin/ Looking at the HACKING stuff. | 16:37 |
| hemna_ | Swanson, lol | 16:37 |
| smcginnis_afk | thrawn01: Third, it's pretty much impossible to address that, so good luck. ;) | 16:37 |
| smcginnis_afk | Swanson: Hah! | 16:38 |
| smcginnis_afk | I think Jay's phone would be better than this. | 16:38 |
| smcginnis_afk | Gee, I'm gone one day and all hell breaks loose. :) | 16:38 |
| hemna_ | smcginnis_afk, job security. | 16:39 |
| *** dustins has quit IRC | 16:39 | |
| hemna_ | smcginnis_afk, or sabatoge, one of the 2 | 16:39 |
| *** lpetrut has quit IRC | 16:39 | |
| smcginnis_afk | hemna_: :) | 16:39 |
| *** abehl has quit IRC | 16:40 | |
| scottda | thrawn01: You can take that bug | 16:41 |
| *** Apoorva has joined #openstack-cinder | 16:41 | |
| *** dustins has joined #openstack-cinder | 16:41 | |
| dulek | thangp: To rebase the patch I need also to move the dependency up. That would mean losing +2 from DuncanT. I hope you're not disappointed? | 16:42 |
| thangp | really? i just rebased https://review.openstack.org/218361 to the latest | 16:44 |
| thangp | that's before DuncanT +2 | 16:44 |
| dulek | thangp: Okay, let me take a look. | 16:44 |
| *** aix has quit IRC | 16:45 | |
| *** diogogmt has joined #openstack-cinder | 16:46 | |
| *** skylerberg has quit IRC | 16:46 | |
| *** david-ly_ has joined #openstack-cinder | 16:49 | |
| *** david-lyle has quit IRC | 16:49 | |
| *** p0rtal has quit IRC | 16:49 | |
| dtadrzak_ | xyang: CGSnapshot passed tests | 16:50 |
| *** rhagarty_ has quit IRC | 16:50 | |
| *** rhagarty has quit IRC | 16:50 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 16:57 |
| dulek | thangp: ^ I've managed to update just one. :) | 16:57 |
| thangp | dulek: thanks! | 16:57 |
| *** rhagarty has joined #openstack-cinder | 16:57 | |
| *** rhagarty_ has joined #openstack-cinder | 16:58 | |
| dulek | thangp: A cross-check done by you will be beneficial. It's the evening here, so I may be not that focused. | 16:59 |
| thangp | dulek: will do | 16:59 |
| *** subhadeep_de has quit IRC | 16:59 | |
| dulek | thangp: Time to get home, I'll be back on IRC in an hour in case of any questions/concerns. | 16:59 |
| *** julim has quit IRC | 17:00 | |
| thangp | dulek: ok, ttyl | 17:00 |
| *** lpetrut has joined #openstack-cinder | 17:01 | |
| *** skylerberg has joined #openstack-cinder | 17:01 | |
| *** gouthamr has joined #openstack-cinder | 17:01 | |
| *** julim has joined #openstack-cinder | 17:03 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 17:03 |
| dulek | thangp: ^ Sorry, forgot to remove unused imports. | 17:04 |
| *** avishay has quit IRC | 17:06 | |
| *** david-ly_ has quit IRC | 17:07 | |
| *** dflorea has quit IRC | 17:08 | |
| *** dflorea has joined #openstack-cinder | 17:08 | |
| *** hemna has quit IRC | 17:09 | |
| *** subhadeep_de has joined #openstack-cinder | 17:10 | |
| *** lpetrut has quit IRC | 17:11 | |
| *** subhadeep_de has quit IRC | 17:13 | |
| *** subhadeep_de has joined #openstack-cinder | 17:13 | |
| openstackgerrit | Patrick East proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 17:20 |
| patrickeast | hemna_: hey, have you had a chance to read through the latest comments on the image cache change? ^ | 17:23 |
| hemna_ | patrickeast, no, I just got my machine back up a bit ago, dealing with email backlog, etc | 17:23 |
| patrickeast | jgriffith: regarding your comment and the 24 hour window mentioned... any chance that could extend a few more hours till the weekly meeting? | 17:23 |
| patrickeast | hemna_: ok, well let me know if you have any questions once you do get to it | 17:24 |
| hemna_ | goosh. looks like a big discussion there. | 17:24 |
| hemna_ | sorry I've been out of it for a few days....machine down and all | 17:24 |
| patrickeast | no worries, it happens | 17:24 |
| *** aix has joined #openstack-cinder | 17:25 | |
| hemna_ | patrickeast, so I think a suggestion I might have mentioned for the config thing | 17:27 |
| hemna_ | is that I think if we can add a check in our 3PAR driver to see if the conf option is set and enabled, | 17:28 |
| hemna_ | then we can raise an exception in do_setup for our driver | 17:28 |
| hemna_ | which in effect will mark the driver as uninitialized and won't accept any requests. | 17:28 |
| hemna_ | it's not ideal, but it prevents the admin from enabling this feature for our driver, which will break on copy image <--> volume operations | 17:29 |
| hemna_ | until we can find a workaround for it :( | 17:29 |
| patrickeast | hemna_: ah yea, thats easy enough to do, the image_volume_cache_enabled config option is available in the conf your driver gets | 17:29 |
| hemna_ | ok I can try putting together a patch and test to make sure it works. | 17:29 |
| jgriffith | patrickeast: I'm fine with somebody reviewing and approving that one. I gave it my +2 already | 17:30 |
| jgriffith | patrickeast: my only concern was making sure hemna_ was ok with it | 17:30 |
| jgriffith | patrickeast: the -2 from jungleboy can be lifted | 17:31 |
| patrickeast | jgriffith: sounds good, thanks again for taking the time to work through the issues with it | 17:31 |
| hemna_ | the feature works great on our LeftHand arrays | 17:31 |
| jgriffith | patrickeast: I'm still reviewing items, including tbarron 's netapp patches | 17:31 |
| jgriffith | I was wishing/hoping others were still reviewing as well | 17:31 |
| hemna_ | it's just the 3PAR issue of modifying a volume while it's cloning is in flight. | 17:31 |
| jgriffith | hemna_: right, so you get to say yay or nay :) | 17:32 |
| jgriffith | hemna_: I guess my question is, how hard is that to fix? | 17:32 |
| hemna_ | if we can get my follow up patch in that disable it for 3PAR only, then I think it's cool w/ me. | 17:32 |
| hemna_ | so I have some ideas | 17:32 |
| jgriffith | hemna_: is it something that can be fixed before release | 17:32 |
| hemna_ | I'll have to experiment and put some patches together and test | 17:32 |
| jgriffith | hemna_: Oh, I haven't seen your follow up patch | 17:32 |
| hemna_ | it might be possible | 17:32 |
| hemna_ | I haven't posted it yet :) | 17:33 |
| jgriffith | hemna_: patrickeast honestly I fully anticipate bug fixes, that's what RC's are for :) | 17:33 |
| hemna_ | yah | 17:33 |
| jgriffith | hemna_: LOL...ahh, ok that's why I didn't see it then :) | 17:33 |
| hemna_ | ok so I'll just comment in the review and +2 it, if we are ok with that ? | 17:33 |
| jgriffith | hemna_: I'm certainly fine with it, but I don't want to ignore input from anybody either | 17:33 |
| tbarron | jgriffith: thanks for the +2s! | 17:34 |
| hemna_ | jgriffith, ok thanks man. | 17:34 |
| *** lpetrut has joined #openstack-cinder | 17:38 | |
| dtadrzak_ | Could someone take a look on CGSnapshot patch (195027)? | 17:40 |
| hemna_ | no junglboy | 17:42 |
| *** afazekas__ has joined #openstack-cinder | 17:46 | |
| *** p0rtal has joined #openstack-cinder | 17:48 | |
| *** dflorea has quit IRC | 17:51 | |
| *** afazekas__ has quit IRC | 17:51 | |
| *** david-lyle has joined #openstack-cinder | 17:54 | |
| *** afazekas__ has joined #openstack-cinder | 17:54 | |
| *** skylerberg has left #openstack-cinder | 17:55 | |
| *** martyturner1 has quit IRC | 17:58 | |
| *** martyturner has joined #openstack-cinder | 18:00 | |
| *** dflorea has joined #openstack-cinder | 18:00 | |
| *** timcl has joined #openstack-cinder | 18:01 | |
| *** david-lyle has quit IRC | 18:01 | |
| *** agarciam has quit IRC | 18:03 | |
| *** dflorea has quit IRC | 18:04 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Register RPC and object versions https://review.openstack.org/209701 | 18:05 |
| *** martyturner has quit IRC | 18:06 | |
| *** afazekas__ has quit IRC | 18:07 | |
| *** subhadeep_de has quit IRC | 18:09 | |
| *** lpetrut has quit IRC | 18:10 | |
| DuncanT | dulek: thangp: if you need me to re-review something after a rebase, poke me and I should see it without too long to wait | 18:10 |
| thangp | DuncanT: ok :) we ended up not needing (yet) | 18:11 |
| *** jungleboyj has joined #openstack-cinder | 18:13 | |
| dhellmann | hemna_: are you the release liaison, since thingee is out? https://review.openstack.org/#/c/219013/ | 18:14 |
| hemna_ | dhellmann, I think it's jgriffith. | 18:14 |
| dhellmann | hemna_: ok, thanks | 18:15 |
| hemna_ | dhellmann, I think that one is good to go FWIW | 18:15 |
| *** david-lyle has joined #openstack-cinder | 18:19 | |
| Swanson | where is thingee these days? He didn't have a bad reaction to some hair dye did he? :) | 18:19 |
| jungleboyj | Swanson: He is at Burning Man. | 18:20 |
| hemna_ | Swanson, burning man | 18:20 |
| jungleboyj | Lost in the desert. | 18:20 |
| jungleboyj | dhellmann: hemna_ Yeah 219013 looks fine to me too. | 18:21 |
| Swanson | I don't think I expected that answer. | 18:21 |
| jungleboyj | Swanson: :-) Oh, he has shared a few stories from there. He always disappears at this time of the year for Burning Man. | 18:24 |
| jungleboyj | At least this year we were expecting it. :-) | 18:24 |
| *** rushil has quit IRC | 18:27 | |
| tbarron | jgriffith: thanks for running re-check on https://review.openstack.org/215833 It passed. | 18:27 |
| patrickeast | jungleboyj: oh hey, any chance you can undo the -2 from https://review.openstack.org/#/c/195795/ ? | 18:28 |
| *** e0ne has joined #openstack-cinder | 18:29 | |
| *** thangp_ has joined #openstack-cinder | 18:31 | |
| jgriffith | hemna_: https://review.openstack.org/#/c/193451/ | 18:31 |
| jgriffith | hemna_: My understanding is you wanted that before the next lib was cut? | 18:31 |
| jgriffith | hemna_: https://review.openstack.org/#/c/219013/ | 18:31 |
| hemna_ | ok | 18:31 |
| hemna_ | well I wanted it before L ships :) | 18:31 |
| jgriffith | hemna_: well... that was kind of a question :) | 18:31 |
| jgriffith | hemna_: then we should probably do it now I think maybe. Since a proposal is up to cut a release already | 18:32 |
| hemna_ | ok +A'd | 18:32 |
| jgriffith | hemna_: mriedem ok, we'll just need to update the sha when it merges then and we can stick with that prposal | 18:32 |
| jgriffith | mriedem: sound ok to you? | 18:33 |
| jungleboyj | patrickeast: Sorry, I thought I had skipped that one. Unblocked. | 18:33 |
| patrickeast | jungleboyj: yay, thanks! | 18:33 |
| jungleboyj | patrickeast: Of course. | 18:33 |
| *** thangp has quit IRC | 18:34 | |
| jgriffith | jungleboyj: you going to be around for tomorrows meeting? | 18:34 |
| *** esker has joined #openstack-cinder | 18:35 | |
| *** esker has quit IRC | 18:35 | |
| tbarron | jgriffith: and the recheck you did on https://review.openstack.org/#/c/215808/ also passed. thanks again. | 18:36 |
| jgriffith | mtanino: hemna_ kmartin looks like this is done no? | 18:38 |
| jgriffith | https://blueprints.launchpad.net/cinder/+spec/get-volume-type-extra-specs | 18:38 |
| jgriffith | mtanino: hemna_ kmartin little bit of confusion with the driver impls being tagged to it, but they all seem to be abandoned | 18:38 |
| hemna_ | https://review.openstack.org/#/c/216394/ | 18:39 |
| hemna_ | that guy is still outstanding | 18:39 |
| *** e0ne has quit IRC | 18:39 | |
| hemna_ | https://review.openstack.org/#/c/212861/ is in the gate | 18:39 |
| mtanino | jgriffith: one main patch was merged and endpoint patch is in the gate and CLI is waiting the gate. | 18:39 |
| hemna_ | so yah I think it's close FWIW | 18:40 |
| *** dims has quit IRC | 18:40 | |
| kmartin | https://review.openstack.org/#/c/216394/ is just the cinder spec that was updated | 18:40 |
| mtanino | jgriffith: Can you change the Assginee to me? https://blueprints.launchpad.net/cinder/+spec/get-volume-type-extra-specs | 18:40 |
| *** zhongjun222 has joined #openstack-cinder | 18:40 | |
| *** dims has joined #openstack-cinder | 18:40 | |
| mtanino | jgriffith: I will close this BP when all patches will be merged. | 18:41 |
| kmartin | jgriffith, change the assignee to mtanino. Gary and Julie are no longer are working on it nor cinder for that matter | 18:42 |
| jgriffith | kmartin: I don't care about that, all I care about is "is the work done" :) | 18:42 |
| jgriffith | kmartin: it appears that there are no outstanding code-reviews, so it should be marked as implemented, no? | 18:43 |
| jgriffith | Ooops... mtanino ^^ | 18:43 |
| jgriffith | which patches aren't merged yet? | 18:43 |
| mtanino | jgriffith: implemented, yes! | 18:43 |
| *** zhongjun22 has quit IRC | 18:44 | |
| jgriffith | mtanino: kmartin ok, I changed assignee and marked it as implemented | 18:44 |
| mtanino | jgriffith: one patch is in gate and one more patch is wating. | 18:44 |
| jgriffith | mtanino: grrrr | 18:44 |
| jgriffith | mtanino: do you have links for said patches? | 18:44 |
| mtanino | jgriffith: https://etherpad.openstack.org/p/cinder-liberty-3-reviews | 18:44 |
| mtanino | Get capabilities | 18:44 |
| *** dims has quit IRC | 18:45 | |
| kmartin | jgriffith, I think https://review.openstack.org/#/c/212861/ just hasn't landed yet but has been +2+A | 18:45 |
| jungleboyj | jgriffith: I will be around for tomorrow's meeting. | 18:45 |
| jgriffith | kmartin: mtanino ok, got it... and THANKS! | 18:46 |
| jgriffith | jungleboyj: ok, cool | 18:46 |
| mtanino | jgriffith: Thank you for pushing. | 18:46 |
| jgriffith | jungleboyj: so I think we'll clear some of the -2's based on concensus and reviews and try and get them merged | 18:46 |
| jgriffith | jungleboyj: now that we've recovered a bit I'm feeling better about things | 18:46 |
| jgriffith | jungleboyj: we'll need your super-powers :) | 18:47 |
| *** zhongjun has joined #openstack-cinder | 18:47 | |
| *** diogogmt has quit IRC | 18:48 | |
| jungleboyj | jgriffith: I will bring my cape. | 18:49 |
| *** zhongjun222 has quit IRC | 18:49 | |
| jgriffith | jungleboyj: LOL | 18:49 |
| * jgriffith looks for photoshop and a picture of jungleboyj to work up | 18:49 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 18:49 |
| patrickeast | jgriffith: is that just for the ones left on https://launchpad.net/cinder/+milestone/liberty-3 or for some of the 'low' ones from the etherpad that go knocked off yesterday? | 18:50 |
| patrickeast | got* | 18:50 |
| jgriffith | patrickeast: some of the no brainer low's I plan to bring back up | 18:50 |
| jgriffith | patrickeast: for example a few of the NetApp ones are isolated and don't present any risk to core or release so I'm fine if they get reviewed and go out the door | 18:51 |
| *** tpsilva has joined #openstack-cinder | 18:51 | |
| patrickeast | jgriffith: so something like https://review.openstack.org/#/c/213855/ :D | 18:51 |
| jgriffith | patrickeast: in other words, all the low priority ones we removed from LP yesterday are open for discussion | 18:51 |
| patrickeast | http://www.reactiongifs.com/wp-content/uploads/2013/04/a-chance.gif | 18:52 |
| jgriffith | LOL | 18:52 |
| jgriffith | patrickeast: remember what she said though :) | 18:52 |
| jungleboyj | jgriffith: Bring it on. :-) | 18:52 |
| patrickeast | haha | 18:52 |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 18:52 |
| jgriffith | dulek: I have bad news.... | 18:53 |
| *** raildo-afk is now known as raildo | 18:53 | |
| *** eharney has quit IRC | 18:53 | |
| jungleboyj | patrickeast: Love the gif. | 18:53 |
| jgriffith | dulek: I talked about this in the release management meeting; I don't think there's much chance I can justify it | 18:53 |
| jgriffith | https://review.openstack.org/#/c/177054/ | 18:54 |
| jungleboyj | jgriffith: That sounds like a good plan. I think it was good to lock things down yesterday and then take a careful approach to what remains. | 18:54 |
| jgriffith | I know I'm flip-flopping this morning; but I have been trying to figure out a way to make it go through even though I know it shouldn't :( | 18:54 |
| *** diogogmt has joined #openstack-cinder | 18:54 | |
| jgriffith | jungleboyj: yeah, so my goal was to get folks to focus on reviewing the higher priority stuff... that's all. Turns out it didn't work anyway | 18:54 |
| jgriffith | jungleboyj: not many people revieiwed anything, and a bunch of people just submitted new patches :( | 18:55 |
| jgriffith | oh well | 18:55 |
| *** e0ne has joined #openstack-cinder | 18:55 | |
| jgriffith | so goes release weeks :) | 18:55 |
| dulek | jgriffith: Thank you for bringing this up to release management meeting. If that's the outcome we need to accept it. | 18:56 |
| jgriffith | dulek: unfortunately it's the right answer | 18:57 |
| *** salv-orlando has quit IRC | 18:57 | |
| jgriffith | dulek: BUT I promise you, if I can get anybody to listen I will propose this gets DONE finally in the first weeks of M | 18:57 |
| kmartin | jgriffith, did you buy your tickets yet for burning man next year? :) | 18:57 |
| jgriffith | dulek: it should've have some coordination help to begin with | 18:58 |
| jgriffith | kmartin: LOL.. burning man... no thanks! | 18:58 |
| jgriffith | kmartin: I've been to Black-Rock, have no idea why anybody would want to spend a week in August there | 18:58 |
| dulek | jgriffith, thangp_: That would be great, coordination would be helpful, patches are constantly getting into merge conflicts. | 18:58 |
| jgriffith | it's miserable | 18:58 |
| mriedem | jgriffith: hemna_: you want https://review.openstack.org/#/c/193451/ in 0.4.0, got it | 18:58 |
| * jgriffith just isn't Hipster | 18:58 | |
| kmartin | lol | 18:58 |
| thangp_ | dulek: at least we tried :-/ | 18:58 |
| jgriffith | mriedem: yes please | 18:58 |
| dulek | jgriffith, thangp_: Probably we can also get that merged during the summit with few cores reviewing live. | 18:59 |
| jungleboyj | xyang: Just got a request to look at this: https://review.openstack.org/#/c/195027 Has a +2 from you but seems like it falls into the 'missed the deadline' category. Thoughts./ | 18:59 |
| hemna_ | mriedem, yes please | 18:59 |
| thangp_ | jgriffith, dulek: the problem with volume obj is it is not very isolated...any minor change to rpc, manager, or api will force a rebase | 19:00 |
| *** annegent_ has joined #openstack-cinder | 19:00 | |
| *** angela-s has joined #openstack-cinder | 19:00 | |
| thangp_ | jgriffith: what about https://review.openstack.org/218361? | 19:00 |
| *** lpetrut has joined #openstack-cinder | 19:00 | |
| thangp_ | jgriffith: that patch is pretty isolated | 19:00 |
| *** Apoorva has quit IRC | 19:01 | |
| dulek | thangp_, jgriffith: Oh, right, this one cannot possibly hurt us. | 19:01 |
| jgriffith | thangp_: I'm fine with that one... lemme review it right now | 19:02 |
| thangp_ | jgriffith: thanks! | 19:02 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Disable generic image cache for 3PAR drivers https://review.openstack.org/219406 | 19:02 |
| *** changbl has quit IRC | 19:02 | |
| *** annegentle has quit IRC | 19:03 | |
| *** marcusvrn_ has joined #openstack-cinder | 19:03 | |
| hemna_ | jgriffith, patrickeast ^^ that's the temporary 'fix' for the 3PAR drivers. | 19:03 |
| hemna_ | so if I can't get a workaround to work, then at least that's in there. | 19:03 |
| hemna_ | not idea, but it's our problem. | 19:03 |
| jgriffith | hemna_: so you want to come up with something else for L though right? | 19:04 |
| *** Apoorva has joined #openstack-cinder | 19:04 | |
| hemna_ | yah I'd like to | 19:04 |
| hemna_ | I have to hack around and see if I can get something workable | 19:04 |
| jgriffith | hemna_: I'm fine if you want to wait on the interim here? | 19:04 |
| *** afazekas has quit IRC | 19:04 | |
| jgriffith | hemna_: in other words I don't feel that this needs to land until RC gets cut | 19:05 |
| hemna_ | ok fine w/ me | 19:05 |
| jgriffith | hemna_: but it's up to you and what you prefer | 19:05 |
| hemna_ | we can always abandon it | 19:05 |
| hemna_ | sounds like a good plan, thanks | 19:05 |
| jgriffith | ok, let's leave it up for now and figure it out tomorrow | 19:05 |
| *** salv-orlando has joined #openstack-cinder | 19:06 | |
| mtanino | jgriffith: jbernard I think this was merged/Implemented on this morning. https://blueprints.launchpad.net/cinder/+spec/generic-volume-migration | 19:06 |
| hemna_ | jgriffith, ok so are we good with +A'ing https://review.openstack.org/#/c/195795/ ? | 19:06 |
| jbernard | mtanino: yes, it did merge | 19:06 |
| jgriffith | hemna_: sure... what could go wrong :) | 19:06 |
| mtanino | jbernard: can you change the BP's status to implemented? | 19:07 |
| hemna_ | :) | 19:07 |
| jgriffith | mtanino: doing it now | 19:07 |
| mtanino | jgriffith: thank you :) | 19:07 |
| hemna_ | ok, everyone can blame me :) | 19:07 |
| *** esker has joined #openstack-cinder | 19:07 | |
| *** martyturner has joined #openstack-cinder | 19:07 | |
| mtanino | patrickeast: congrat! | 19:08 |
| patrickeast | yay | 19:08 |
| patrickeast | hemna_: jgriffith: thanks! its probably going to be great | 19:08 |
| *** annegent_ has quit IRC | 19:08 | |
| jgriffith | patrickeast: Whaaaa! "probably" ??????? | 19:08 |
| * jgriffith grabs the revert button | 19:08 | |
| *** dims has joined #openstack-cinder | 19:09 | |
| patrickeast | lol | 19:09 |
| hemna_ | lol | 19:09 |
| * hemna_ hides | 19:09 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Calculate virtual free capacity and notify https://review.openstack.org/206923 | 19:11 |
| *** annegentle has joined #openstack-cinder | 19:11 | |
| *** krtaylor has quit IRC | 19:11 | |
| jgriffith | hemna_: https://review.openstack.org/#/c/207020/ | 19:12 |
| jgriffith | hemna_: ^^ I think that's ok (using the bp, not a bug) | 19:12 |
| jgriffith | hemna_: you ok with that? | 19:13 |
| hemna_ | yah I think it's fine | 19:13 |
| jgriffith | hemna_: in other words, since it's tied to the BP | 19:13 |
| jgriffith | ok... cool | 19:13 |
| *** dims has quit IRC | 19:13 | |
| jgriffith | I'm a +2/A | 19:13 |
| hemna_ | I just didn't know how strict we were being with BPs vs. bugs after the 'freeze' | 19:13 |
| jgriffith | hemna_: yeah... good call | 19:13 |
| jgriffith | hemna_: but this was higher prio and never removed | 19:13 |
| hemna_ | +2'd | 19:14 |
| jgriffith | hemna_: so it was "ok" as was | 19:14 |
| *** julim has quit IRC | 19:14 | |
| jgriffith | hemna_: thank ya sir | 19:14 |
| hemna_ | np | 19:14 |
| hemna_ | ok lunch...bbiab | 19:15 |
| *** hemna_ is now known as hemnafk | 19:15 | |
| *** dims has joined #openstack-cinder | 19:18 | |
| *** krtaylor has joined #openstack-cinder | 19:21 | |
| thrawn01 | smcginnis_afk: Do you think this bug is a red hering, and we should scuttle it? Because there are a list of other bugs that I would rather work on (referencing: https://bugs.launchpad.net/cinder/+bug/1415241) | 19:22 |
| openstack | Launchpad bug 1415241 in Cinder "cinder hacking checks don't cover logging format string arg count" [Undecided,New] - Assigned to Scott DAngelo (scott-dangelo) | 19:22 |
| thrawn01 | scottda: ^^ | 19:22 |
| e0ne | do we allow patches like 'Port something to Python 3' after L-3? | 19:23 |
| *** dims has quit IRC | 19:25 | |
| jgriffith | e0ne: nope | 19:25 |
| jgriffith | e0ne: and technically we shouldn't be doing them now either | 19:25 |
| *** lpetrut has quit IRC | 19:25 | |
| e0ne | :) | 19:25 |
| jgriffith | e0ne: we're *supposed* to be in release mode; only things that are targeted | 19:26 |
| e0ne | one more maybe stupid question | 19:26 |
| jgriffith | e0ne: after we go in to RC it's supposed to be bug fixes only | 19:26 |
| * e0ne didn't find answet in the histiry | 19:26 | |
| jgriffith | e0ne: sure... no stupid questions :) | 19:26 |
| e0ne | :) | 19:26 |
| simondodsley | jgriffiths: I'm sure I could come up with one :) | 19:27 |
| e0ne | yesterday's proplem with failing unit tests and '(Pulled from gate, cinder can no longer pass unit tests)' string in a commit messages. what is it? | 19:27 |
| jgriffith | simondodsley: :) | 19:27 |
| jgriffith | e0ne: so just what it sounds like... something changed such that any cinder change that went into the verify gate would fail | 19:28 |
| jgriffith | e0ne: we got a patch for it, but until it landed/merged nothing would pass | 19:28 |
| jgriffith | e0ne: openssl change somehow | 19:28 |
| e0ne | jgriffith: so, is this comment sill needed? | 19:28 |
| jgriffith | e0ne: nope | 19:28 |
| e0ne | jgriffith: got it, thank you for help! | 19:29 |
| jgriffith | it's now meaningless, except for tracking to put approvals back on items that we bumped for it | 19:29 |
| jgriffith | e0ne: in other words, anything with that comment should get a free +2/A now | 19:29 |
| e0ne | free +2/A! great! | 19:29 |
| xyang | jgriffith: can I get a free +2/A on this one that was pulled from the gate? :) https://review.openstack.org/#/c/218421/ | 19:30 |
| jgriffith | done | 19:30 |
| xyang | thanks! | 19:30 |
| jgriffith | xyang: and for those that aren't paying attention I guess it''s "you snooze, you loose" | 19:31 |
| xyang | jgriffith: :) | 19:31 |
| *** martyturner has quit IRC | 19:32 | |
| xyang | jgriffith, jungleboyj: should -2 be removed from this one? https://review.openstack.org/#/c/206923/ | 19:32 |
| *** krtaylor has quit IRC | 19:34 | |
| *** jungleboyj has quit IRC | 19:34 | |
| *** bill_az has quit IRC | 19:34 | |
| *** hakimo has quit IRC | 19:34 | |
| *** jwcroppe has quit IRC | 19:34 | |
| *** lifeless has quit IRC | 19:34 | |
| *** tobasco_ has quit IRC | 19:34 | |
| *** rmstar has quit IRC | 19:34 | |
| *** mtreinish has quit IRC | 19:34 | |
| *** harlowja has quit IRC | 19:34 | |
| *** xiaohui has quit IRC | 19:34 | |
| *** goodygum has quit IRC | 19:34 | |
| *** whydidyoustealmy has quit IRC | 19:34 | |
| *** IanGovett has quit IRC | 19:34 | |
| *** sdague has quit IRC | 19:34 | |
| *** dobson has quit IRC | 19:34 | |
| *** martyturner has joined #openstack-cinder | 19:34 | |
| *** mriedem is now known as mattykins | 19:34 | |
| *** IanGovett has joined #openstack-cinder | 19:34 | |
| *** sdague has joined #openstack-cinder | 19:34 | |
| *** dobson has joined #openstack-cinder | 19:34 | |
| *** rushil has joined #openstack-cinder | 19:35 | |
| *** krtaylor has joined #openstack-cinder | 19:35 | |
| *** jungleboyj has joined #openstack-cinder | 19:35 | |
| *** bill_az has joined #openstack-cinder | 19:35 | |
| *** hakimo has joined #openstack-cinder | 19:35 | |
| *** jwcroppe has joined #openstack-cinder | 19:35 | |
| *** lifeless has joined #openstack-cinder | 19:35 | |
| *** tobasco_ has joined #openstack-cinder | 19:35 | |
| *** rmstar has joined #openstack-cinder | 19:35 | |
| *** mtreinish has joined #openstack-cinder | 19:35 | |
| *** xiaohui has joined #openstack-cinder | 19:35 | |
| *** goodygum has joined #openstack-cinder | 19:35 | |
| *** whydidyoustealmy has joined #openstack-cinder | 19:35 | |
| *** harlowja has joined #openstack-cinder | 19:35 | |
| *** whydidyoustealmy has quit IRC | 19:35 | |
| *** harlowja has quit IRC | 19:35 | |
| *** harlowja has joined #openstack-cinder | 19:35 | |
| *** dannywilson has joined #openstack-cinder | 19:35 | |
| *** dims has joined #openstack-cinder | 19:35 | |
| *** eharney has joined #openstack-cinder | 19:35 | |
| jgriffith | xyang: could be but I'd likely downvote it anyway | 19:36 |
| *** whydidyoustealmy has joined #openstack-cinder | 19:36 | |
| jgriffith | xyang: I'm not sure i understand how/why that was approved as medium priority | 19:36 |
| xyang | jgriffith: I don't know. any non-driver feature gets at least medium priority probably | 19:37 |
| xyang | jgriffith: you don't like this feature or just think it is not as important? | 19:38 |
| jgriffith | could be :) | 19:38 |
| jgriffith | little of both | 19:38 |
| jgriffith | but I'm not sure about the implementation | 19:38 |
| jgriffith | I need to look at it a bit closer | 19:39 |
| xyang | jgriffith: ok | 19:39 |
| xyang | jgriffith: seems to be a useful feature to me. so that you can find out how much capacity you have | 19:40 |
| jgriffith | xyang: what if you share your cluster across multiple clouds? | 19:43 |
| jgriffith | xyang: or perish the though... an OpenStack deployment AND and ESX deployment :) | 19:43 |
| *** erlon has joined #openstack-cinder | 19:44 | |
| xyang | jgriffith: you mean how do you show capacity when you share your storage with non-openstack deployment? | 19:44 |
| xyang | jgriffith: this is just calling the existing get_pools API | 19:44 |
| *** prometheanfire has joined #openstack-cinder | 19:45 | |
| jgriffith | xyang: ahh... wait, yeah, it's pool based more than anything else | 19:45 |
| xyang | jgriffith: ya | 19:45 |
| *** prometheanfire has left #openstack-cinder | 19:45 | |
| xyang | jgriffith: it is just an aggregation of what we already have | 19:45 |
| jgriffith | xyang: got it | 19:45 |
| jgriffith | I'll look at it. Needs others to review it though :) | 19:46 |
| xyang | jgriffith: ya, I think gorka should take a look | 19:46 |
| xyang | jgriffith: the latest patch set was to addressing his comments | 19:47 |
| *** mattykins is now known as mriedem | 19:47 | |
| *** harlowja has quit IRC | 19:47 | |
| *** rushil has quit IRC | 19:47 | |
| *** krtaylor has quit IRC | 19:47 | |
| *** jungleboyj has quit IRC | 19:47 | |
| *** bill_az has quit IRC | 19:47 | |
| *** hakimo has quit IRC | 19:47 | |
| *** jwcroppe has quit IRC | 19:47 | |
| *** lifeless has quit IRC | 19:47 | |
| *** tobasco_ has quit IRC | 19:47 | |
| *** rmstar has quit IRC | 19:47 | |
| *** mtreinish has quit IRC | 19:47 | |
| *** xiaohui has quit IRC | 19:47 | |
| *** goodygum has quit IRC | 19:47 | |
| scottda | thrawn01: If you'd rather work on some other bug, then go for it... | 19:50 |
| scottda | I'm not sure what you mean by 'scuttle 1415241' | 19:50 |
| thrawn01 | scottda: I want to close bugs, if this is not a useful bug, then it should be closed. | 19:50 |
| scottda | Well, DuncanT filed that bug, so you'd have to ask him about closing the bug. | 19:51 |
| scottda | It may be a useful bug that should stay open. But there's no need for you to work on it if you don't want to. | 19:51 |
| tbarron | patrickeast: need to reverify https://review.openstack.org/#/c/195795/ - gate-tempest-dsvm-neutron full failed with "echo 'ERROR: the main setup script run by this job failed - exit code: 137'" | 19:51 |
| *** harlowja has joined #openstack-cinder | 19:52 | |
| *** rushil has joined #openstack-cinder | 19:52 | |
| *** krtaylor has joined #openstack-cinder | 19:52 | |
| *** jungleboyj has joined #openstack-cinder | 19:52 | |
| *** bill_az has joined #openstack-cinder | 19:52 | |
| *** hakimo has joined #openstack-cinder | 19:52 | |
| *** jwcroppe has joined #openstack-cinder | 19:52 | |
| *** lifeless has joined #openstack-cinder | 19:52 | |
| *** tobasco_ has joined #openstack-cinder | 19:52 | |
| *** rmstar has joined #openstack-cinder | 19:52 | |
| *** mtreinish has joined #openstack-cinder | 19:52 | |
| *** xiaohui has joined #openstack-cinder | 19:52 | |
| *** goodygum has joined #openstack-cinder | 19:52 | |
| *** simondodsley has quit IRC | 19:52 | |
| thrawn01 | scottda: that is the question I'm asking, is it useful? can it be done? smcginnis_afk seams to think it's impossible, if so... then close it. | 19:53 |
| *** sgotliv has joined #openstack-cinder | 19:54 | |
| *** e0ne has quit IRC | 19:54 | |
| *** e0ne has joined #openstack-cinder | 19:55 | |
| *** ociuhandu has quit IRC | 19:55 | |
| thrawn01 | I'm still gonna attempt it, it looks like it might be possible to accomplish via a pylint AST check, but docs are not clear on how to implement a custom checker. | 19:55 |
| thrawn01 | smcginnis_afk: seams to think it should instead be a flake8 plugin, which, I've not looked at, I will today tho. | 19:56 |
| thrawn01 | but yeah, closing bugs/issues is my goal. | 19:57 |
| thrawn01 | I've got a few of the issues I'm targeting in the next few weeks | 19:57 |
| thrawn01 | I was hoping this would be a low hanging fruit issue, but it's apparently not quite a low as I thought. | 19:58 |
| *** julim has joined #openstack-cinder | 19:58 | |
| scottda | yes, probably not low hanging fruit | 19:58 |
| mriedem | jgriffith: hemnafk: updated https://review.openstack.org/#/c/219013/ | 19:59 |
| *** boris-42 has quit IRC | 20:00 | |
| *** krtaylor has quit IRC | 20:01 | |
| *** krtaylor has joined #openstack-cinder | 20:02 | |
| *** hemnafk is now known as hemna | 20:03 | |
| *** p0rtal has quit IRC | 20:05 | |
| *** porrua has quit IRC | 20:06 | |
| jgriffith | jungleboyj: any thoughts on this turkey: https://bugs.launchpad.net/cinder/+bug/1465393 | 20:08 |
| openstack | Launchpad bug 1465393 in Cinder "db migration shouldn't rely on CONF option or set values in row" [Undecided,In progress] - Assigned to Rakesh Mishra (mishra-rakesh510) | 20:08 |
| jgriffith | jungleboyj: I'm looking at a new migration that clears the setting | 20:09 |
| *** ociuhandu has joined #openstack-cinder | 20:09 | |
| jgriffith | jungleboyj: but wondering if you might have a better suggestion | 20:09 |
| jgriffith | mriedem: thanks much! | 20:10 |
| jgriffith | jungleboyj: but what I don't quite see is "how" we ever upgrade this :( | 20:11 |
| jgriffith | jungleboyj: in other words, you appear to be "stuck" with whatever you had set at deploy time ? | 20:12 |
| jgriffith | boooo... hisssss | 20:12 |
| *** mudassirlatif has joined #openstack-cinder | 20:14 | |
| *** gouthamr has quit IRC | 20:14 | |
| *** gouthamr has joined #openstack-cinder | 20:14 | |
| *** eharney has quit IRC | 20:15 | |
| *** merooney has quit IRC | 20:16 | |
| Swanson | Are the image volume cache options per backend or per cinder node? | 20:17 |
| jungleboyj | jgriffith: Jacob and I were just looking through that code trying to fix this. | 20:18 |
| patrickeast | Swanson: yes | 20:18 |
| jungleboyj | jgregor: ^^ | 20:18 |
| jgriffith | jungleboyj: ahh... ok, so does that mean I shouldn't work on it ? | 20:18 |
| patrickeast | Swanson: you can scope them per backend or put them in the default section and all backends get them | 20:18 |
| jgriffith | jungleboyj: I was going to write a migration that just deletes the info in the column | 20:19 |
| Swanson | patrickeast: Thanks! | 20:19 |
| jgriffith | jungleboyj: I'd prefer to go back and modify the migration that introduced it, but I don't remember if that's kosher | 20:19 |
| jungleboyj | jgriffith: No, we are working it. | 20:19 |
| patrickeast | that reminds me i need to probably go write up documentation for it | 20:19 |
| jungleboyj | jgriffith: Since it is kind of my mess I created. :-) | 20:19 |
| jgriffith | jungleboyj: ok... can you update the bug to reflect you are on it | 20:19 |
| jungleboyj | Yep. | 20:19 |
| jgriffith | jungleboyj: thanks! | 20:19 |
| *** esker has quit IRC | 20:20 | |
| *** salv-orl_ has joined #openstack-cinder | 20:20 | |
| *** IanGovett has quit IRC | 20:21 | |
| jgriffith | jungleboyj: BTW...don't forget you own this one currently as well: https://bugs.launchpad.net/cinder/+bug/1381563 | 20:21 |
| openstack | Launchpad bug 1381563 in Cinder "cinder using obsolete oslo modules" [Medium,In progress] - Assigned to Jay Bryant (jsbryant) | 20:21 |
| jgriffith | jungleboyj: I tihnk it's dead, but let me know if I'm wrong | 20:22 |
| jungleboyj | jgriffith: Updated. Hopefully we can get something nailed down. We have made progress figuring out what Nova is doing. Trying to assimilate. | 20:22 |
| *** timcl has quit IRC | 20:22 | |
| jgriffith | jungleboyj: excellent | 20:22 |
| *** eharney has joined #openstack-cinder | 20:22 | |
| jungleboyj | That bug is related to the config generator work that diablo_rojo is pinging me about in my other Window. :-) | 20:23 |
| jgriffith | LOL | 20:23 |
| diablo_rojo | :D | 20:23 |
| jungleboyj | jgriffith: Updated accordingly. | 20:23 |
| diablo_rojo | jungleboyj: so now I am on the chopping block? | 20:24 |
| jungleboyj | Just a heads up that in Mitaka we are going to probably have oslo-incubator completely going away. Once we are off the generator we are close to being done with oslo-incubator and I have that on our work list for Mitaka. | 20:24 |
| *** salv-orlando has quit IRC | 20:24 | |
| * jungleboyj said nothing about chopping blocks | 20:25 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access https://review.openstack.org/219231 | 20:25 |
| *** xyang has quit IRC | 20:26 | |
| *** p0rtal has joined #openstack-cinder | 20:27 | |
| *** julim has quit IRC | 20:29 | |
| *** bill_az has quit IRC | 20:30 | |
| *** p0rtal has quit IRC | 20:31 | |
| *** dperaza has joined #openstack-cinder | 20:34 | |
| *** p0rtal has joined #openstack-cinder | 20:34 | |
| *** dperaza has left #openstack-cinder | 20:35 | |
| *** sgotliv has quit IRC | 20:35 | |
| *** p0rtal_ has joined #openstack-cinder | 20:36 | |
| *** dustins has quit IRC | 20:37 | |
| *** p0rtal has quit IRC | 20:39 | |
| *** julim has joined #openstack-cinder | 20:42 | |
| *** Lee1092 has quit IRC | 20:43 | |
| *** p0rtal has joined #openstack-cinder | 20:43 | |
| *** bswartz has quit IRC | 20:44 | |
| *** p0rtal_ has quit IRC | 20:47 | |
| *** Apoorva has quit IRC | 20:50 | |
| * tbarron is going to driver home. Will check backlog here and continue reviewing in an hour or so. | 20:52 | |
| *** Apoorva has joined #openstack-cinder | 20:52 | |
| tbarron | drive home, LOL | 20:53 |
| *** earlephilhower has quit IRC | 20:55 | |
| tpsilva | We're having a problem with our HDS HNAS driver. oslo_concurrency.processutils logs every command that we run, so the HNAS password comes as plain text in the log. Is there anyway that we can avoid that? I checked the execute implementation, and it already uses mask_password, but since our command does not use the format that this function expects, it does not mask our password. | 20:55 |
| *** rmetcalf has quit IRC | 20:56 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access https://review.openstack.org/219231 | 20:57 |
| Swanson | tbarron: "driver" works if you read that with a JFK accent. | 21:02 |
| *** raildo is now known as raildo-afk | 21:02 | |
| *** changbl has joined #openstack-cinder | 21:02 | |
| *** jungleboyj has quit IRC | 21:02 | |
| *** crose has quit IRC | 21:05 | |
| *** thangp_ has quit IRC | 21:07 | |
| *** lcurtis_ has joined #openstack-cinder | 21:08 | |
| *** changbl has quit IRC | 21:09 | |
| *** changbl has joined #openstack-cinder | 21:13 | |
| e0ne | jgriffith: only if you'll get a time. i really appreciate your opinion and woul like to take a look on https://review.openstack.org/#/c/217857/ (not my patch) to be sure that we are on the same page | 21:14 |
| *** e0ne has quit IRC | 21:15 | |
| *** e0ne has joined #openstack-cinder | 21:16 | |
| *** rushil has quit IRC | 21:20 | |
| *** akerr has quit IRC | 21:20 | |
| *** yrabl has quit IRC | 21:21 | |
| mtanino | https://review.openstack.org/#/c/215847/ was +A'd but I can't see this ID on the gate queue list... what is this... | 21:21 |
| jgriffith | mtanino: that's why I re-voted with the "kick" comment :) | 21:22 |
| jgriffith | e0ne: looking now | 21:22 |
| mtanino | jgriffith: yes. I saw it. Does the kick do someting? | 21:23 |
| e0ne | jgriffith: thanks! i know that you're very busy these days | 21:23 |
| jgriffith | e0ne: aren't those pot files supposed to be auto-updated? | 21:24 |
| e0ne | jgriffith: tbh, i'm not sure | 21:24 |
| jgriffith | mtanino: no, kick doesn't do anything really.... Just me putting a comment in there :) | 21:24 |
| *** julim has quit IRC | 21:25 | |
| e0ne | jgriffith: i'm not sure that it is a right way to fix the bug | 21:25 |
| mtanino | jgriffith: I see. may be I need to try reverify | 21:25 |
| jgriffith | yea, try it :) | 21:26 |
| jgriffith | e0ne: you have an alternate idea? | 21:26 |
| jgriffith | e0ne: having a configurable fall-back seems "ok" | 21:26 |
| jgriffith | not ideal, but "ok" | 21:27 |
| e0ne | jgriffith: move validation to scheduler and use AZ filter. but it requires more changes | 21:27 |
| e0ne | jgriffith: i'm worry about new config option that looks like a hack and will be deprecated in Mitaka | 21:27 |
| jgriffith | e0ne: I wonder if it's worth moving forward with this approach as an interim solution | 21:27 |
| jgriffith | e0ne: yeah... it's ugly | 21:28 |
| *** yrabl has joined #openstack-cinder | 21:28 | |
| jgriffith | e0ne: so you're thinking actually report AZ's up to scheduler from the driver and use that? | 21:28 |
| *** jgregor has quit IRC | 21:29 | |
| e0ne | jgriffith: from driver? it's a create flow before c-vol starts work on it | 21:29 |
| jgriffith | e0ne: yeah, but you mentioned scheduler, so I assumed you meant filtering out valid AZ's from the backend | 21:30 |
| jgriffith | e0ne: in other words, postpone the AZ check to the scheduler | 21:30 |
| jgriffith | e0ne: let the scheduler figure out how/where to place | 21:30 |
| e0ne | jgriffith: yes. now we check in in the API | 21:30 |
| *** jungleboyj has joined #openstack-cinder | 21:30 | |
| jgriffith | e0ne: then you could have things like "driver.conf.valid_availability_zones=[a, b, c....]" | 21:30 |
| jgriffith | e0ne: I don't know if that actually works though :( | 21:31 |
| e0ne | jgriffith: oh, no | 21:31 |
| e0ne | jgriffith: i mean if we'll check AZ in scheduler with AZ filter, we could just disable AZ filter | 21:31 |
| e0ne | jgriffith: no changes to drivers or c-vol are needed | 21:32 |
| jgriffith | e0ne: ahh.. interesting | 21:32 |
| jgriffith | e0ne: ok... so I think that would work nicely | 21:33 |
| jgriffith | e0ne: I'd propose we go with something like what's proposed (unless you want to code up your solution tonight and not sleep) :) | 21:33 |
| e0ne | jgriffith: :) | 21:33 |
| jgriffith | e0ne: either that or go with what's there (minus the pot files) and update in M | 21:34 |
| e0ne | jgriffith: ok.. I will sync with dulek tomorrow. maybe he already tried my proposal with scheduler | 21:34 |
| jgriffith | e0ne: ok, sounds good | 21:34 |
| e0ne | jgriffith: and I won't block this patch | 21:34 |
| jgriffith | e0ne: please keep me posted | 21:34 |
| e0ne | jgriffith: sure. thank you for advise | 21:34 |
| * e0ne bb in ~12 hours | 21:36 | |
| jgriffith | e0ne: sleep well :) | 21:36 |
| dulek | e0ne, jgriffith: I've already tried this solution. It basically means reverting a harlowja's commit, let me find it... | 21:37 |
| e0ne | jgriffith: I will try:) | 21:37 |
| jgriffith | dulek: oh well... it's just harlowja :) | 21:37 |
| e0ne | dulek: oh.. do you mean moving to taskflow commit? | 21:37 |
| dulek | jgriffith, e0ne: https://review.openstack.org/#/c/98924/ | 21:38 |
| dulek | jgriffith, e0ne: Thing is if we want to move validation to scheduler we're changing how API behaves - user won't get notice if he provided wrong AZ. | 21:39 |
| *** lprice has quit IRC | 21:40 | |
| jgriffith | dulek: well, I think the idea is if you use an AZ filter you could get either or | 21:40 |
| jgriffith | dulek: if the filter is enabled you fail | 21:40 |
| jgriffith | dulek: if you explicitly disable it, that means you don't care | 21:40 |
| jgriffith | dulek: it's really the same thing that's proposed.... just does it in scheduler | 21:41 |
| jgriffith | dulek: see what I mean? | 21:41 |
| e0ne | dulek: we've got a lot of async errors in scheduler and manager which is not reported to user:(. but I agree that we need to fix it | 21:41 |
| jgriffith | dulek: and I'm not sure it's better or worse, just saying it's different ;) | 21:41 |
| dulek | jgriffith: Yes, that's fine. My only concern is that this will fail on a scheduler level. So user won't be able to know that he made a mistake in AZ name. | 21:41 |
| e0ne | dulek, jgriffith: a very valid concern | 21:42 |
| jgriffith | mtanino: that's weird, it got booted back to check | 21:42 |
| jgriffith | dulek: true | 21:42 |
| jgriffith | dulek: and people hate that | 21:42 |
| mtanino | jgriffith: Sorry, are there any good way?... | 21:43 |
| jgriffith | mtanino: not your fault... | 21:43 |
| dulek | jgriffith, e0ne: So from my perspective it's better to live with deprecation of an option than to break API contract. | 21:43 |
| jgriffith | mtanino: we'll just wait then give it another +2/A when it finishes if it doesn't go automatically :) | 21:43 |
| dulek | jgriffith, e0ne: (even tough I don't think someone relies in their script on API AZ validation ;)) | 21:44 |
| jgriffith | dulek: yeah.... I'm looking at the code again; I think that the proposed change is good enough for now | 21:44 |
| jgriffith | dulek: minus the pot files :) | 21:44 |
| jgriffith | dulek: it solves the problem, we can deal with a better solution; even have them coexist if we have to IMO | 21:44 |
| dulek | jgriffith: I wasn't sure about the pot files either, commit author was over-diligent. ;) | 21:45 |
| e0ne | dulek, jgriffith: you convinced me that this patch is good enough for L | 21:45 |
| mtanino | jgriffith: I see. I will keep watching it. | 21:45 |
| jgriffith | e0ne: :) Now you can sleep easy :) | 21:45 |
| e0ne | :) | 21:45 |
| jgriffith | dulek: Yeah, I've never seen anybody update those on their own... kudos to comitter for that :) | 21:45 |
| jgriffith | dulek: no remove them :) | 21:45 |
| *** mriedem is now known as mriedem_away | 21:46 | |
| dulek | jgriffith, e0ne: Okay, thank you for your opinions guys. | 21:46 |
| *** lcurtis_ has quit IRC | 21:47 | |
| * dulek gets back to writing his thesis. No sleeping yet... | 21:47 | |
| jgriffith | thanks e0ne and dulek ... dulek let me know how your thesis turns out and if it's published so I can read it :) | 21:48 |
| *** annegentle has quit IRC | 21:48 | |
| dulek | jgriffith: Fortunately it's in English, but if you're not into hardcore graph algorithmics you won't enjoy it. ;) | 21:49 |
| jgriffith | dulek: haha! | 21:50 |
| hemna | patrickeast, ping | 21:51 |
| patrickeast | hemna: hey | 21:51 |
| hemna | looks like jenkins frowned on the merge | 21:51 |
| hemna | https://review.openstack.org/#/c/195795/ | 21:51 |
| patrickeast | yea I saw the first failure, jgriffith put a reverify on it, last I saw it was in the long line for checking | 21:53 |
| patrickeast | from the zuul status page it looks like its doing better this time around | 21:55 |
| Swanson | It has pretty much passed. Only one left is non-voting. | 21:55 |
| *** xyang has joined #openstack-cinder | 21:57 | |
| *** changbl has quit IRC | 21:57 | |
| harlowja | jgriffith dulek what i do? | 21:58 |
| harlowja | it was all jgriffith fault, he made me do it | 21:58 |
| harlowja | lol | 21:58 |
| harlowja | whatever it is | 21:58 |
| harlowja | ha | 21:58 |
| jgriffith | harlowja: :) | 21:58 |
| *** xyang has quit IRC | 21:59 | |
| dulek | harlowja: You did a good thing, just Nova guys screwed it up. ;) | 21:59 |
| harlowja | ah | 21:59 |
| harlowja | phew, lol | 21:59 |
| *** leeantho has quit IRC | 22:01 | |
| *** p0rtal_ has joined #openstack-cinder | 22:04 | |
| *** tpsilva has quit IRC | 22:05 | |
| *** p0rtal has quit IRC | 22:07 | |
| *** e0ne has quit IRC | 22:10 | |
| tbarron | Swanson: I talk like a Texan who lived in the Twin Cities for 10 years so I can't sound like JFK. Though people tell me I look a lot like him. | 22:13 |
| * tbarron thinks Swanson and I have never actually seen one another | 22:13 | |
| *** e0ne has joined #openstack-cinder | 22:14 | |
| Swanson | tbarron: I haven't been to any of the openstack events so pretty unlikely. | 22:14 |
| *** martyturner has quit IRC | 22:15 | |
| *** p0rtal has joined #openstack-cinder | 22:16 | |
| tbarron | Swanson: are you going to Tokyo by any chance? | 22:16 |
| *** p0rtal_ has quit IRC | 22:19 | |
| *** edmondsw has quit IRC | 22:28 | |
| *** earlephilhower has joined #openstack-cinder | 22:32 | |
| *** e0ne has quit IRC | 22:34 | |
| *** jaypipes has quit IRC | 22:40 | |
| *** annegentle has joined #openstack-cinder | 22:40 | |
| Swanson | tbarron: Nope. smcginnis_afk is. | 22:42 |
| *** alejandrito_ has joined #openstack-cinder | 22:43 | |
| tbarron | Swanson: do you work with Walter Poxon and Chris Hertel? | 22:43 |
| Swanson | Chris doesn't come to mind but Walter is in this facility. | 22:44 |
| tbarron | I work in a *facility* too :-) | 22:44 |
| tbarron | Anyways, Walter and Chris can tell you how much I look like JFK (not). | 22:44 |
| Swanson | heh | 22:45 |
| *** alejandrito_ has quit IRC | 22:45 | |
| *** alejandrito has quit IRC | 22:45 | |
| *** asselin_ has quit IRC | 22:46 | |
| Roamer` | thingee, hi, did you have a chance to look at the e-mails I sent about reactivating the StorPool CI? | 22:52 |
| Roamer` | oh, hmm, I just realized he's on vacation... well, whom should I contact about reactivating a CI that was turned off, we've fixed the problems, and we have like three weeks of success reports in silent mode now? | 22:54 |
| *** angela-s has quit IRC | 22:55 | |
| mtanino | jgriffith: https://review.openstack.org/#/c/215847/ didn't enter gate queue after finishing check. strange status :( | 22:56 |
| *** boris-42 has joined #openstack-cinder | 22:57 | |
| *** edtubill has quit IRC | 22:57 | |
| hemna | patrickeast, ping | 22:59 |
| *** lcurtis has quit IRC | 23:02 | |
| *** dims has quit IRC | 23:03 | |
| *** asselin has joined #openstack-cinder | 23:06 | |
| *** leeantho has joined #openstack-cinder | 23:07 | |
| patrickeast | hemna: hola | 23:07 |
| hemna | kinda have my driver working | 23:08 |
| hemna | but seeing something odd | 23:09 |
| *** krotscheck has joined #openstack-cinder | 23:09 | |
| hemna | patrickeast, https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/hp/hp_3par_common.py#L1574 | 23:09 |
| krotscheck | Is there a list of custom HTTP headers that cinder uses? I'm assuming that X-Auth-Token is valid, but are there any others? X-Forwarded-For.... | 23:09 |
| hemna | so for whatever reason we are using volume['source_volid'] as the source volume id | 23:09 |
| hemna | and that is None during creates from cache | 23:10 |
| hemna | so it pukes | 23:10 |
| patrickeast | hmm thats odd | 23:10 |
| hemna | src_vref['id'] is what we want, and I'm not sure why we weren't using that | 23:11 |
| hemna | but for whatever reason volume['source_volid'] = None | 23:11 |
| jgriffith | hemna: That's weird, I've never even noticed that column before | 23:12 |
| * hemna scratches head | 23:12 | |
| jgriffith | hemna: not sure what it means or is for, vs why you aren't just using ['id'] | 23:13 |
| hemna | yah me either | 23:13 |
| jgriffith | ahh... | 23:13 |
| hemna | fwiw, normal create volume from volume id works with that | 23:13 |
| *** asselin has quit IRC | 23:14 | |
| hemna | must be a holdover from ages ago ? | 23:14 |
| jgriffith | hemna: not really https://github.com/openstack/cinder/commit/d99fb6011cc610b78d42891800189feed0391742 | 23:14 |
| jgriffith | hemna: it's a special reference for LVM that I did | 23:14 |
| hemna | that j-griffith guy must know..... | 23:14 |
| *** asselin has joined #openstack-cinder | 23:14 | |
| jgriffith | hemna: so that column should be used on the "destination" | 23:14 |
| jgriffith | hemna: as a column that says "hey, I'm cloned from <source-volid>" | 23:15 |
| *** ganso_ has quit IRC | 23:15 | |
| jgriffith | hemna: that was partially for people that have linked clones | 23:15 |
| jgriffith | hemna: and required a tracking mechanism | 23:15 |
| hemna | so it looks like it's None when create_cloned_volume is called from the cache | 23:15 |
| tbarron | intuitive :-) | 23:15 |
| jgriffith | hemna: I'm not sure how your driver could ever do a clone volume the way it is there? | 23:15 |
| hemna | maybe because it's not the same project ? | 23:15 |
| hemna | internal project user ? | 23:15 |
| hemna | it's worked! :P | 23:16 |
| jgriffith | hemna: lemme see... | 23:16 |
| hemna | ok I'll just file a bug against our crappy driver and fix it before I try and push my patch to fix the image cache clone work | 23:16 |
| jgriffith | tbarron: actually... "source-volume-id" does seem kind of intutive tome :) | 23:16 |
| hemna | it's probably my fault in our code | 23:16 |
| tbarron | jgriffith: well, if I turn my head 32 degrees to the left it does to me as well. Need to visit CO more :) | 23:17 |
| *** leeantho has quit IRC | 23:17 | |
| jgriffith | hemna: ahhh.... I see | 23:17 |
| hemna | hah, it's kmartin's fault | 23:17 |
| hemna | :P | 23:17 |
| *** bkopilov has quit IRC | 23:17 | |
| tbarron | jgriffith: I'm just messing with you, as if I haven't been enough of a PITA recently. | 23:17 |
| jgriffith | hemna: patrickeast so in taskflows execute on a normal "create from source" it fills that in | 23:18 |
| *** chlong_ is now known as chlong | 23:18 | |
| jgriffith | hemna: patrickeast it actually fetches the source_volid, populates the column | 23:18 |
| *** bkopilov has joined #openstack-cinder | 23:18 | |
| jgriffith | hemna: patrickeast and shoots it out as part of the vref in the request-spec | 23:18 |
| openstackgerrit | Michael Krotscheck proposed openstack/cinder: Added CORS support to Cinder https://review.openstack.org/219489 | 23:19 |
| patrickeast | i suppose we should probably do that for the cache code too then for consistency | 23:19 |
| hemna | kmartin, https://goo.gl/OoQwpD | 23:19 |
| hemna | back in the day | 23:19 |
| jgriffith | but clone_image_volume and create_from_source_volume are "different" | 23:19 |
| patrickeast | yea i suppose | 23:19 |
| patrickeast | but i guess the thing we pass into the driver could be consistent at least | 23:19 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 23:20 |
| jgriffith | patrickeast: hemna well.... | 23:20 |
| patrickeast | or we just call it a 3PARism and i wont worry about it >:D | 23:20 |
| hemna | I'll post a patch against 3PAR | 23:20 |
| hemna | and fixy there. | 23:20 |
| jgriffith | patrickeast: hemna either way... but it's easy to fix... just change line 1574 to "src_vref['id']" and you never have to worry about it | 23:21 |
| jgriffith | hemna: :) | 23:21 |
| hemna | jgriffith, +1 | 23:21 |
| jgriffith | hemna: that's the safest thing IMO | 23:21 |
| hemna | friggin 3PAR driver writers.... | 23:21 |
| jgriffith | LOL | 23:21 |
| *** mdbooth has quit IRC | 23:21 | |
| jgriffith | jungleboyj: ping | 23:21 |
| tbarron | hemna: :) I can relate | 23:21 |
| jungleboyj | jgriffith: Pong. | 23:22 |
| jgriffith | jungleboyj: hey dude! | 23:22 |
| jgriffith | jungleboyj: so I started picking at the genconfig stuff | 23:22 |
| jgriffith | jungleboyj: thought I'd check and make sure you hadn't already done a chunk of it | 23:23 |
| jgriffith | jungleboyj: buiilding the opts files (or trying to) and adding the entry-points | 23:23 |
| jungleboyj | jgriffith: Dude, we have and have most of it done. | 23:23 |
| * jgriffith wishes we didn't have opts declared in SO DAMN many places | 23:23 | |
| jgriffith | jungleboyj: Oh// yipee! | 23:23 |
| jgriffith | jungleboyj: where? | 23:24 |
| jungleboyj | That is what Kendall has been working on. | 23:24 |
| jgriffith | I can help | 23:24 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Fix create_cloned_volume source volume id https://review.openstack.org/219498 | 23:24 |
| jgriffith | we can finish it and get it done once and for all | 23:24 |
| jungleboyj | jgriffith: That would be awesome. | 23:24 |
| *** dims__ has joined #openstack-cinder | 23:24 | |
| jungleboyj | jgriffith: You want me to have her push up what she has in the morning so you two can collaborate? | 23:24 |
| jgriffith | Throw it on gitub, we can divide and conquer! | 23:24 |
| jgriffith | jungleboyj: yeah... that sounds good | 23:25 |
| jgriffith | jungleboyj: do you know how far along with the opt files and entry points she is? | 23:25 |
| *** leeantho has joined #openstack-cinder | 23:25 | |
| kmartin | hemna, that was back in the day, jgriffith review it :) CI must have of been broke that day | 23:25 |
| jungleboyj | jgriffith: Mostly done. She has a good looking opt file, just something weird happening when she sends it to genconfig. | 23:25 |
| jgriffith | jungleboyj: ok, awesome! | 23:26 |
| jgriffith | jungleboyj: get it posted and I'll see if I can help | 23:26 |
| jgriffith | we'll get that sucker merged and call it DONE | 23:26 |
| jungleboyj | It is treating the output of list_opts like one big config option and we weren't sure why. How are had you gotten? | 23:26 |
| *** mdbooth has joined #openstack-cinder | 23:26 | |
| jgriffith | jungleboyj: so I am almost done with the cinder.volume opts.py file | 23:27 |
| jgriffith | jungleboyj: have an entrypoint file and and config file | 23:27 |
| jgriffith | jungleboyj: but it's not usable yet | 23:27 |
| jgriffith | jungleboyj: I've been spending too much time trying to figure out how to auto-collect/generate the opts entries :( | 23:27 |
| jungleboyj | He he, that she has done and working 90%. | 23:28 |
| jungleboyj | jgriffith: Just texted her, she will push up a WIP in the morning and ping you. | 23:28 |
| * jgriffith grep >file && s/\./volume/import cinder.volume/ | s/\/\/\/ blah blahb alhba | 23:29 | |
| jgriffith | jungleboyj: sweeet! | 23:29 |
| jgriffith | in that case I'm drinking beer!!! | 23:29 |
| jgriffith | jungleboyj: post it up, I'll see if I can help finish it off | 23:29 |
| *** dannywil_ has joined #openstack-cinder | 23:30 | |
| jungleboyj | Man, beer sounds good but not until after karate. :-) | 23:30 |
| jgriffith | jungleboyj: BTW, I was associating it with this bug: https://bugs.launchpad.net/nova/+bug/1437904 | 23:30 |
| openstack | Launchpad bug 1437904 in Cinder "generate_sample.sh uses MODULEPATH environment variable, conflicts with environment-modules" [Low,In progress] - Assigned to Mike Perez (thingee) | 23:30 |
| jgriffith | jungleboyj: which is why I started hacking on it | 23:30 |
| jungleboyj | Ok. I will send her that info. | 23:31 |
| jgriffith | jungleboyj: nahh... beers not really that good, you're not missing anything :) | 23:31 |
| jungleboyj | jgriffith: You are full of it! | 23:31 |
| * jgriffith goes back to the kegarator to see if it's gotten better since the last pour | 23:31 | |
| hemna | mmmm | 23:31 |
| jgriffith | Don't know what they were thinking putting a kegarator in the office :) | 23:32 |
| jgriffith | tbarron: now would be a good time to be trying to recruit cores to review your patches BTW | 23:32 |
| hemna | :) | 23:33 |
| tbarron | jgriffith: on it, and thanks for the cure | 23:33 |
| jgriffith | tbarron: actually, this morning would have been an even better time | 23:33 |
| tbarron | I meant to say cue but that might be a better word | 23:33 |
| jgriffith | lOL | 23:33 |
| jgriffith | s/I/L/ | 23:33 |
| *** dannywilson has quit IRC | 23:33 | |
| tbarron | jgriffith: yeah | 23:33 |
| jungleboyj | tbarron: Has been bribing me for the last couple hours. | 23:34 |
| tbarron | believe me, I've been a major PITA all around. | 23:34 |
| tbarron | yeah, I plan to buy drinks all around and charge NetApp, who owes me for this effort. | 23:34 |
| mtanino | jgriffith: https://review.openstack.org/#/c/215847/ seems this guy does not like gate queue... | 23:35 |
| kmartin | tbarron, hemna is waiting for the review URL to click | 23:35 |
| tbarron | kmartin: hemna was spared so far b/c his computer had problems, but hemna please take a look at the Low prio section of https://etherpad.openstack.org/p/cinder-liberty-3-reviews | 23:36 |
| openstackgerrit | John Griffith proposed openstack/cinder: ScaleIO driver should use os-brick connector https://review.openstack.org/214420 | 23:37 |
| tbarron | jungleboyj: jgriffith: and xyang: have been helping NetApp out a lot in that set of reviews, but there are still some that need attention. | 23:37 |
| jgriffith | mtanino: so strange... been a long time since I've seen this happen | 23:37 |
| *** hodos has quit IRC | 23:38 | |
| tbarron | hemna: and there are a couple of very nice changes from Pure there in the same boat | 23:38 |
| jgriffith | mtanino: we can ping infra and see if they can help; other option abandon it and submit a new one, we'll just push it through | 23:38 |
| mtanino | jgriffith: Do you know who is a apporpriate person in Infra? | 23:39 |
| tbarron | kmartin: you can get drinks on that round too, since you threw just threw hemna under the bus for me | 23:39 |
| kmartin | tbarron, some have -1 for cores are ready are you fixing them https://review.openstack.org/#/c/215833/ | 23:39 |
| jgriffith | mtanino: meet me over there, we'lljust ask | 23:39 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Fix create_cloned_volume source volume id https://review.openstack.org/219498 | 23:39 |
| tbarron | kmartin: yeah, we have a patch ready to go up that addresses the refactor and exception change that e0ne requested. | 23:40 |
| *** diogogmt has quit IRC | 23:40 | |
| mtanino | jgriffith: thank you for your help. | 23:40 |
| tbarron | kmartin: I don't want to push it before the dependent changes merge before it, as we'll lose all the votes, etc. | 23:40 |
| tbarron | make sense? | 23:40 |
| jungleboyj | tbarron: Ok, all your patches have been reviewed. | 23:40 |
| kmartin | I guess | 23:40 |
| tbarron | jungleboyj: awesome! | 23:41 |
| jungleboyj | :-) | 23:41 |
| tbarron | kmartin: I'll do whatever experienced folks advise on that one. | 23:41 |
| jungleboyj | Checks can be made out to Jay S. Bryant. ;-) | 23:41 |
| kmartin | tbarron, seems that you would want to address -1 for cores ASAP | 23:41 |
| tbarron | kmartin: ok, I'll start the reverify on our internal CI to push that up. Hopefully the patches it depends on will merge first or we can regain votes if they are lost. | 23:43 |
| *** diogogmt has joined #openstack-cinder | 23:43 | |
| tbarron | kmartin: e0ne won't look at that one for another 6-8 hours anyways :-) | 23:43 |
| tbarron | kmartin: assuming he sleeps better tonight than I will. | 23:43 |
| *** salv-orlando has joined #openstack-cinder | 23:43 | |
| *** diogogmt has quit IRC | 23:45 | |
| jgriffith | jungleboyj: LOL.. not a bad side biz ya got going | 23:45 |
| jgriffith | tbarron: what's the problem? | 23:45 |
| tbarron | jgriffith: what problem? | 23:46 |
| tbarron | jgriffith: oh, I see what you are asking. We have a change, | 23:47 |
| *** salv-orl_ has quit IRC | 23:47 | |
| jungleboyj | :-) | 23:47 |
| tbarron | jgriffith: https://review.openstack.org/#/c/215833/ | 23:47 |
| jungleboyj | Dinner time here. | 23:47 |
| jgriffith | tbarron: well, you need to fix the errors | 23:47 |
| tbarron | jgriffith: where e0ne has made some very good comments. We have a patch that addresses them. | 23:47 |
| jgriffith | http://logs.openstack.org/33/215833/5/check/gate-cinder-pylint/2b853c3/console.html#_2015-09-01_20_13_59_076 | 23:47 |
| tbarron | I am pushing it up now. | 23:47 |
| tbarron | jgriffith: but I didn't see the pylint errors!! | 23:48 |
| tbarron | TY. | 23:48 |
| *** IanGovett has joined #openstack-cinder | 23:50 | |
| tbarron | jgriffith: lemme make sure our new patch doesn't have that issue | 23:50 |
| jgriffith | tbarron: might be a good idea | 23:51 |
| tbarron | :-) | 23:51 |
| hemna | ok I'm out, heading home. I'll try and be online later for review help. | 23:51 |
| jgriffith | doesn't matter who reviews your patches, if they don't pass gate you're not going to get them merged :) | 23:51 |
| tbarron | true that | 23:51 |
| *** hemna is now known as hemnafk | 23:51 | |
| *** esker has joined #openstack-cinder | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
