Tuesday, 2015-09-01

*** gouthamr has quit IRC00:02
*** dims has quit IRC00:03
*** takedakn has joined #openstack-cinder00:05
*** mtanino has quit IRC00:05
*** pv__ has quit IRC00:05
*** jdurgin has quit IRC00:06
jgriffithNot sure who's still around.. but https://review.openstack.org/#/c/219027/ just kicked off verify00:07
*** jdurgin has joined #openstack-cinder00:07
jgriffithif I'm not back before it finishes if you somebody could hit the recheck and +2/A on https://review.openstack.org/#/c/218977/ that would be *awesome*00:07
*** mtanino has joined #openstack-cinder00:09
*** rushil has quit IRC00:10
*** takedakn has quit IRC00:12
*** diogogmt has quit IRC00:18
*** gouthamr has joined #openstack-cinder00:21
*** takedakn has joined #openstack-cinder00:29
*** mtanino has quit IRC00:29
*** jgravel has joined #openstack-cinder00:32
*** mtanino has joined #openstack-cinder00:32
*** jgravel has left #openstack-cinder00:44
*** angela-s has quit IRC00:52
*** zhangjn has joined #openstack-cinder00:57
*** takedakn has quit IRC00:59
*** garthb has quit IRC01:00
*** garthb_ has quit IRC01:00
*** chlong has joined #openstack-cinder01:02
*** skylerberg has quit IRC01:03
openstackgerritRyan McNair proposed openstack/cinder: Fix MITM vulnerability for Brocade FC SAN lookup  https://review.openstack.org/21834101:05
*** lixiaoy1 has joined #openstack-cinder01:11
*** DericHorn-HP has joined #openstack-cinder01:13
*** leeantho has quit IRC01:13
*** Apoorva has quit IRC01:14
*** zhangjn_ has joined #openstack-cinder01:17
*** p0rtal has quit IRC01:17
*** lixiaoy11 has joined #openstack-cinder01:18
*** gouthamr has quit IRC01:18
*** bill_az has quit IRC01:19
*** zhangjn has quit IRC01:19
*** dims has joined #openstack-cinder01:20
*** lixiaoy1 has quit IRC01:20
*** sghanekar has quit IRC01:21
*** vilobhmm1 has quit IRC01:22
openstackgerritEli Qiao proposed openstack/cinder: Handle KeyManager exception when deleting a volume  https://review.openstack.org/20982801:24
*** lixiaoy1 has joined #openstack-cinder01:24
*** lixiaoy11 has quit IRC01:27
*** mtanino has quit IRC01:29
*** haomaiwang has joined #openstack-cinder01:33
*** DericHorn-HP has quit IRC01:34
*** edtubill has joined #openstack-cinder01:36
*** mudassirlatif has quit IRC01:36
*** mudassirlatif has joined #openstack-cinder01:37
*** Lee1092 has joined #openstack-cinder01:41
*** mudassirlatif has quit IRC01:41
*** mriedem is now known as mriedem_away01:44
*** haigang has quit IRC01:44
*** sam_wan has joined #openstack-cinder01:44
*** Zhongjun has quit IRC01:47
*** longguang has quit IRC01:48
*** gouthamr has joined #openstack-cinder01:50
*** IlyaG has quit IRC01:56
*** zhangjn_ has quit IRC01:58
*** zhangjn has joined #openstack-cinder01:59
jungleboyjjgriffith: Recheck started on 21897701:59
*** zhangjn has quit IRC01:59
*** zhangjn has joined #openstack-cinder02:00
*** davechen has joined #openstack-cinder02:02
*** lyanchih has joined #openstack-cinder02:04
jgriffithjungleboyj: :)  already hit it, it's almost done :)02:05
jgriffithjungleboyj: I gave it +2/A02:05
jgriffithbb after dinner02:05
jgriffithjungleboyj: thanks!02:05
*** hw__chenying has joined #openstack-cinder02:10
*** vilobhmm1 has joined #openstack-cinder02:12
openstackgerrityogeshprasad proposed openstack/cinder: Retype support for CloudByte iSCSI cinder driver  https://review.openstack.org/21864502:15
jungleboyjjgriffith: Crap.  I missed that you had already done that.  Thanks for din git.02:17
jungleboyjjgriffith: Have a good dinner.02:17
*** vilobhmm1 has left #openstack-cinder02:18
*** I has joined #openstack-cinder02:20
*** bkopilov has quit IRC02:20
*** I is now known as Guest1090302:20
*** baojg has joined #openstack-cinder02:23
*** gouthamr has quit IRC02:25
*** subhadee_ has joined #openstack-cinder02:29
*** subhadeep_de has quit IRC02:29
openstackgerritAnna Sortland proposed openstack/cinder: Add delete_snapshot and update_snapshot rules  https://review.openstack.org/20268002:30
*** rushiagr_away is now known as rushiagr02:36
openstackgerritRongze Zhu proposed openstack/cinder: Remove deprecated options  https://review.openstack.org/21909802:37
*** BharatK has joined #openstack-cinder02:45
*** rushiagr is now known as rushiagr_away02:45
*** sam_wan has quit IRC02:46
*** baojg has quit IRC02:49
*** hakimo has joined #openstack-cinder02:52
*** hakimo_ has quit IRC02:54
*** rushiagr_away is now known as rushiagr02:55
openstackgerritVincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy  https://review.openstack.org/21875003:00
jungleboyjxyang1: jgriffith DuncanT et al The etherpad is updated and I have triple checked to make sure I didn't block anyone that was already +2/+A.  Have a bold note next to the ones that are waiting for the gate to clear.03:00
xyang1jungleboyj: Thanks:)03:01
jungleboyjFlexing my manager muscles.  ;-)03:02
jungleboyjxyang1: How are you?  Didn't get to chat with you as much in FC>03:02
openstackgerritVincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id)  https://review.openstack.org/21878103:02
xyang1jungleboyj: Good.  Have you booked your tickets yet03:03
jungleboyjxyang1: *Sigh*  No, I have a hotel and stuff but no approval for plane tickets.03:07
xyang1jungleboyj: You are still waiting? Can't imagine they won't approve you though03:08
*** annasort has quit IRC03:09
*** Zhongjun has joined #openstack-cinder03:10
xyang1jungleboyj: I hope you get approval soon.  Good night now03:10
*** subhadee_ has quit IRC03:11
*** edtubill has quit IRC03:11
jungleboyjxyang1: Thanks.  I will.03:12
jungleboyjxyang1: Good night!03:12
*** chlong has quit IRC03:12
*** xyang1 has quit IRC03:13
*** sam_wan has joined #openstack-cinder03:13
*** rushil has joined #openstack-cinder03:15
*** davechen1 has joined #openstack-cinder03:20
openstackgerritJohn Griffith proposed openstack/cinder: Add cinder.conf.sample to gitignore  https://review.openstack.org/21604403:20
openstackgerritVincent Hou proposed openstack/cinder: Remove the detination volume check in delete_volume  https://review.openstack.org/21910803:20
*** davechen has quit IRC03:23
*** p0rtal has joined #openstack-cinder03:24
*** p0rtal has quit IRC03:25
*** p0rtal has joined #openstack-cinder03:26
*** shausy has joined #openstack-cinder03:26
jungleboyjjgriffith: Ok, all the ones that need a recheck should be in the check now.03:26
jgriffithjungleboyj: awesome!03:26
*** mriedem_away has quit IRC03:27
*** annasort has joined #openstack-cinder03:31
*** davechen has joined #openstack-cinder03:33
*** davechen1 has quit IRC03:36
*** chlong has joined #openstack-cinder03:38
*** subhadeep_de has joined #openstack-cinder03:44
*** links has joined #openstack-cinder03:46
openstackgerritJohn Griffith proposed openstack/cinder: Add instructions on how to deploy API under Apache  https://review.openstack.org/20702003:47
*** rushil has quit IRC03:50
*** haomaiwang has quit IRC03:51
*** haomaiwang has joined #openstack-cinder03:52
*** breitz has quit IRC03:52
*** breitz has joined #openstack-cinder03:52
*** p0rtal_ has joined #openstack-cinder03:53
*** p0rtal_ has quit IRC03:53
jgriffithjungleboyj: DuncanT patrickeast geguileo I've gone through bp's and such again and removed a few.  I think we should use Launchpad and the milestone items as a reference for what to review at this point NOT the etherpad.03:53
*** p0rtal_ has joined #openstack-cinder03:54
jgriffithjungleboyj: DuncanT patrickeast geguileo IMHO that's part of why things get dropped, we should just say "what's targettted in LP is priority" after all that's what LP is for no?03:54
jgriffithtbarron: FWIW, that would have probably helped out your patches as well ^^03:54
jgriffithwhy do we need multiple records and tracking sources for everything?  That just creates confusion03:55
jgriffithLP already has everything, and it has it prioritized03:55
patrickeastsounds good to me03:56
*** p0rtal has quit IRC03:56
jgriffithcool... I hope others are ok with that idea.  These etherpads are just duplicate sources of info and more work IMO03:57
openstackgerritVincent Hou proposed openstack/python-cinderclient: Volume status management for volume migration  https://review.openstack.org/18954703:59
*** markvoelker has joined #openstack-cinder04:00
*** bkopilov has joined #openstack-cinder04:00
*** markvoelker_ has joined #openstack-cinder04:02
*** shausy has quit IRC04:04
*** chlong_ has joined #openstack-cinder04:04
*** chlong has quit IRC04:04
*** markvoelker has quit IRC04:04
*** rushiagr is now known as rushiagr_away04:04
*** takedakn has joined #openstack-cinder04:14
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/21544004:22
*** takedakn has quit IRC04:23
*** baojg has joined #openstack-cinder04:25
*** hw__chenying has quit IRC04:26
*** dims has quit IRC04:30
*** rushiagr_away is now known as rushiagr04:31
jungleboyjjgriffith: Fair enough.04:35
* jungleboyj will work on getting better with LP. :-)04:36
openstackgerritRongze Zhu proposed openstack/cinder: Remove deprecated options  https://review.openstack.org/21909804:40
*** rushiagr is now known as rushiagr_away04:44
*** shyama has joined #openstack-cinder04:49
*** hw_chenying has joined #openstack-cinder04:52
*** p0rtal_ has quit IRC04:56
openstackgerritMitsuhiro Tanino proposed openstack/cinder: Allow specified backend capabilities to be retrieved  https://review.openstack.org/21286104:56
*** p0rtal has joined #openstack-cinder05:03
*** ankit_ag has joined #openstack-cinder05:08
*** vincent_hou has joined #openstack-cinder05:10
*** diablo_rojo has quit IRC05:12
*** shausy has joined #openstack-cinder05:21
*** hw_chenying has quit IRC05:23
*** lpetrut has joined #openstack-cinder05:31
openstackgerritTeruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve snapshot and clone operation  https://review.openstack.org/19895205:36
openstackgerritTeruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve image operations  https://review.openstack.org/20295405:37
*** yrabl has joined #openstack-cinder05:38
*** lyanchih has quit IRC05:40
*** Guest10903 has quit IRC05:42
*** p0rtal has quit IRC05:43
*** lprice1 has joined #openstack-cinder05:44
*** lprice has quit IRC05:45
*** lprice1 has quit IRC05:45
openstackgerritVincent Hou proposed openstack/cinder: Adds migration abortion for available volumes  https://review.openstack.org/20775405:45
*** lyanchih has joined #openstack-cinder05:48
*** nkrinner has joined #openstack-cinder05:51
*** markvoelker_ has quit IRC05:53
*** p0rtal has joined #openstack-cinder05:54
*** hw_chenying has joined #openstack-cinder05:57
*** I has joined #openstack-cinder05:58
*** I is now known as Guest9202305:58
*** dims has joined #openstack-cinder05:59
*** lyanchih has quit IRC06:01
*** agarciam has joined #openstack-cinder06:02
*** dims has quit IRC06:04
*** shausy has quit IRC06:04
*** shausy has joined #openstack-cinder06:05
*** agarciam has quit IRC06:09
*** baojg has quit IRC06:09
*** lprice has joined #openstack-cinder06:09
*** lpetrut has quit IRC06:10
*** lyanchih has joined #openstack-cinder06:15
*** Zhongjun has quit IRC06:17
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex  https://review.openstack.org/21874106:17
*** vilobhmm11 has joined #openstack-cinder06:18
*** BharatK has quit IRC06:27
*** deepakcs has joined #openstack-cinder06:34
*** afazekas__ has joined #openstack-cinder06:36
*** lpetrut has joined #openstack-cinder06:38
*** zhongjun has joined #openstack-cinder06:49
openstackgerritVincent Hou proposed openstack/cinder: Adds migration abortion for available volumes  https://review.openstack.org/20775406:51
*** alexschm has joined #openstack-cinder06:54
openstackgerritVincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id)  https://review.openstack.org/21878106:59
*** lpetrut has quit IRC07:01
dulekHi, are we currently experiencing problems with the gate? I don't want to recheck my patch unnecessarily but errors seem unrelated.07:02
dulekI'm talking about this one - https://review.openstack.org/#/c/160417/07:02
*** abehl has joined #openstack-cinder07:02
*** p0rtal has quit IRC07:03
openstackgerritMichal Dulko proposed openstack/cinder: Service object  https://review.openstack.org/16041707:09
*** stefan_amann has joined #openstack-cinder07:09
openstackgerritVincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id)  https://review.openstack.org/21878107:12
*** ndipanov has quit IRC07:16
*** deepakcs has quit IRC07:22
*** chlong_ has quit IRC07:24
*** ndipanov has joined #openstack-cinder07:27
*** Zhongjun_ has joined #openstack-cinder07:33
*** ishant has joined #openstack-cinder07:34
*** kjelly has quit IRC07:35
*** kjelly has joined #openstack-cinder07:36
*** zhongjun has quit IRC07:38
*** Zhongjun_ is now known as Zhongjun07:38
*** jwcroppe is now known as jwcroppe_zzz07:45
*** shyama has quit IRC07:47
*** sgotliv has joined #openstack-cinder07:54
*** vincent_hou has quit IRC07:55
*** vilobhmm11 has quit IRC07:58
*** bluex-pl has joined #openstack-cinder07:59
*** zhongjun22 has joined #openstack-cinder08:01
*** lixiaoy1 has quit IRC08:05
*** jistr has joined #openstack-cinder08:08
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502708:08
*** lennyb has joined #openstack-cinder08:11
*** e0ne has joined #openstack-cinder08:13
*** baojg has joined #openstack-cinder08:16
*** agarciam has joined #openstack-cinder08:21
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502708:25
*** zhangjn_ has joined #openstack-cinder08:32
*** baojg has quit IRC08:34
*** zhangjn has quit IRC08:34
*** e0ne has quit IRC08:36
*** lyanchih has quit IRC08:37
*** dims has joined #openstack-cinder08:42
*** baojg has joined #openstack-cinder08:44
*** IanGovett has joined #openstack-cinder08:45
*** shyama has joined #openstack-cinder08:46
*** lyanchih has joined #openstack-cinder08:47
*** e0ne has joined #openstack-cinder08:48
*** dims has quit IRC08:48
*** aix has quit IRC08:50
*** svilgelm has joined #openstack-cinder08:53
*** ociuhandu has quit IRC08:54
*** boris-42 has quit IRC09:00
*** ndipanov has quit IRC09:03
*** shausy has quit IRC09:04
*** shausy has joined #openstack-cinder09:05
*** baojg has quit IRC09:12
*** zhongjun22 has quit IRC09:13
e0negeguileo: hi! you need to rebase https://review.openstack.org/#/c/183222/ to pass CI09:13
geguileoe0ne: I'm on it09:14
e0negeguileo: ok:)09:14
geguileoe0ne: But it needs some test changes as well, and I'm trying to figure out the best way to do it  :-)09:14
*** ociuhandu has joined #openstack-cinder09:16
*** aix has joined #openstack-cinder09:19
*** baojg has joined #openstack-cinder09:30
openstackgerritVincent Hou proposed openstack/cinder: Adds migration abortion for available volumes  https://review.openstack.org/20775409:31
*** dims has joined #openstack-cinder09:36
*** Guest92023 has quit IRC09:40
*** dims has quit IRC09:41
*** lpetrut has joined #openstack-cinder09:47
*** davechen has left #openstack-cinder09:54
*** zhongjun22 has joined #openstack-cinder09:58
*** baojg has quit IRC10:00
*** coolsvap has quit IRC10:01
*** coolsvap has joined #openstack-cinder10:02
*** ndipanov has joined #openstack-cinder10:03
*** aix has quit IRC10:05
*** aix has joined #openstack-cinder10:05
*** Zhongjun has quit IRC10:07
openstackgerritPetrut Lucian proposed openstack/cinder: SMBFS: Fix retrieving total allocated size  https://review.openstack.org/15871310:18
*** dims has joined #openstack-cinder10:30
*** yrabl has quit IRC10:31
*** yrabl has joined #openstack-cinder10:32
*** dims has quit IRC10:36
*** hw_chenying has quit IRC10:37
*** h00327910__ has quit IRC10:43
*** lyanchih has quit IRC10:43
*** ociuhandu_ has joined #openstack-cinder10:44
*** andreykurilin__ has joined #openstack-cinder10:45
*** ociuhandu has quit IRC10:45
*** ociuhandu_ is now known as ociuhandu10:45
*** haypo has joined #openstack-cinder10:47
*** zhangjn_ has quit IRC10:47
haypohi. on my latest python3 patchers for cinder, i got question on how i should mention the link the blueprint https://blueprints.launchpad.net/cinder/+spec/cinder-python3 : see https://review.openstack.org/#/c/215752/2//COMMIT_MSG10:48
haypoit's not clear if i should use the syntax "Blueprint <link>", "Implements: blueprint <link>", "Partially implements: blueprint <link>". i maybe use again the name of the blueprint instead of the url?10:49
hayposomeone asked me to use the url instead of the name, on a previous change, because the blueprint is now completed, and so launchpad doesn't find the blueprint10:49
haypoi would prefer to continue to use the name, and modify https://blueprints.launchpad.net/cinder/+spec/cinder-python3 status10:50
haypothe blueprint status is "completed" which is not right, cinder is not fully compatible with python 3. i'm still writing python3 patches ;)10:50
haypothanks in advance for your replies ;)10:51
haypo(reply, answer, comment, anything that can help me to make progress ;))10:51
*** amann has joined #openstack-cinder10:51
*** stefan_amann has quit IRC10:54
dulekhaypo: We're still using Partially-Implements: cinder-objects for versioned objects patches even if BP is completed. I think you can do the same.10:54
*** Roamer` has quit IRC10:55
*** Roamer` has joined #openstack-cinder10:55
openstackgerritVictor Stinner proposed openstack/cinder: Port image_utils to Python 3  https://review.openstack.org/21381711:00
*** DTadrzak has quit IRC11:02
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access  https://review.openstack.org/21923111:03
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access  https://review.openstack.org/21923111:04
openstackgerritGorka Eguileor proposed openstack/cinder: Fix backup metadata import missing fields  https://review.openstack.org/18322211:05
openstackgerritVictor Stinner proposed openstack/cinder: Port volume transfer to Python 3  https://review.openstack.org/21575211:07
*** Yogi1 has joined #openstack-cinder11:08
*** haomaiwang has quit IRC11:08
*** ganso_ has joined #openstack-cinder11:09
haypodulek: ok, i will use "Partially implements: blueprint cinder-python3". (i already upgraded https://review.openstack.org/#/c/215752/)11:09
*** Yogi11 has joined #openstack-cinder11:09
*** smoriya has quit IRC11:11
openstackgerritVictor Stinner proposed openstack/cinder: Port volume transfer to Python 3  https://review.openstack.org/21575211:12
*** Yogi1 has quit IRC11:13
*** jaypipes has joined #openstack-cinder11:14
*** sayali has quit IRC11:15
*** sayali has joined #openstack-cinder11:17
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502711:18
openstackgerritVictor Stinner proposed openstack/cinder: Port image_utils to Python 3  https://review.openstack.org/21381711:22
openstackgerritWilson Liu proposed openstack/cinder: Check before add lun to QoS in Huawei driver  https://review.openstack.org/21923911:22
*** hodos has joined #openstack-cinder11:23
*** dims has joined #openstack-cinder11:25
*** timcl has joined #openstack-cinder11:29
*** dims has quit IRC11:29
DuncanTAny cores about to push https://review.openstack.org/#/c/207020/ through? It's already been +2/A once but needed a rebase, and it is only docs11:29
DuncanThttps://review.openstack.org/#/c/212861/ has also been approved once but ran into gate issues11:34
openstackgerritVictor Stinner proposed openstack/cinder: Fix Python 3 issues in wsgi  https://review.openstack.org/21741711:35
*** e0ne has quit IRC11:46
*** sam_wan has quit IRC11:48
*** amann has quit IRC11:50
*** breitz1 has joined #openstack-cinder11:51
*** breitz has quit IRC11:51
shausy@here can someone confirm creating volume snapshot with diff backend for HP_LHN is supported ?11:56
*** gouthamr has joined #openstack-cinder11:57
*** diegows has joined #openstack-cinder11:58
*** svilgelm has quit IRC12:01
DuncanTshausy: I don't understand the question. You can't snapshot between backends, only on the same backend, but I'm not sure how you'd try - I don't think the API lets you even attempt it12:01
*** svilgelm has joined #openstack-cinder12:01
DuncanTshausy: You can use volume migrate or backup/restore to move between backends12:01
*** stefan_amann has joined #openstack-cinder12:02
*** bkopilov has quit IRC12:02
shausyDuncanT, I have created volume of X volume type and created a snapshot of the same and now im trying to create a volume from snapshot with Y volume type...12:05
*** svilgelm has quit IRC12:06
shausyI just want to know, is this operation supported ?12:06
DuncanTshausy: I believe that is forbidden - snapshots are done using backend specific technology, so it can't be made to work in the general case except by a slow copy12:06
shausyOk thanks DuncanT.12:09
DuncanTshausy: You can create the volume on the existing backend and then retype it, if that helps12:09
*** chlong_ has joined #openstack-cinder12:09
DuncanTshausy: You loose and thin copy advantage that way though12:09
*** bluex-pl has quit IRC12:10
*** annegentle has joined #openstack-cinder12:11
openstackgerritGorka Eguileor proposed openstack/cinder: Remove API races from delete methods  https://review.openstack.org/20583512:11
openstackgerritGorka Eguileor proposed openstack/cinder: Add atomic conditional updates to objects  https://review.openstack.org/20583412:11
openstackgerritGorka Eguileor proposed openstack/cinder: Rename db.api methods to match models' names  https://review.openstack.org/21893612:11
openstackgerritGorka Eguileor proposed openstack/cinder: WIP: Remove more API races  https://review.openstack.org/21637812:11
openstackgerritGorka Eguileor proposed openstack/cinder: Move get_by_id to CinderObject  https://review.openstack.org/21801212:11
*** bluex-pl has joined #openstack-cinder12:11
openstackgerritGorka Eguileor proposed openstack/cinder: Improve metadata update operations  https://review.openstack.org/21637612:11
openstackgerritGorka Eguileor proposed openstack/cinder: Remove API races from attach and detach methods  https://review.openstack.org/21637712:11
*** bluex-pl has quit IRC12:11
*** bluex-pl has joined #openstack-cinder12:12
*** jgregor has joined #openstack-cinder12:13
*** bluex-pl has quit IRC12:14
*** salv-orlando has quit IRC12:14
*** bluex-pl has joined #openstack-cinder12:15
*** ishant has quit IRC12:17
*** e0ne has joined #openstack-cinder12:18
*** pwehrle has joined #openstack-cinder12:19
*** bswartz has joined #openstack-cinder12:21
*** salv-orlando has joined #openstack-cinder12:22
*** salv-orl_ has joined #openstack-cinder12:23
*** tpsilva has joined #openstack-cinder12:26
*** zhangjn has joined #openstack-cinder12:26
*** salv-orlando has quit IRC12:26
*** zhangjn has quit IRC12:27
*** dims has joined #openstack-cinder12:33
shausyDuncanT, I will try the same.. thanks alot for ur inputs12:33
*** salv-orlando has joined #openstack-cinder12:33
*** svilgelm has joined #openstack-cinder12:34
*** merooney has joined #openstack-cinder12:34
*** crose has joined #openstack-cinder12:35
*** salv-orl_ has quit IRC12:37
*** zhangjn has joined #openstack-cinder12:38
*** svilgelm has quit IRC12:39
*** baojg has joined #openstack-cinder12:40
*** raildo is now known as raildo-afk12:40
*** baojg has quit IRC12:42
*** nzrf has joined #openstack-cinder12:42
*** porrua has joined #openstack-cinder12:44
*** diablo_rojo has joined #openstack-cinder12:45
*** haomaiwang has joined #openstack-cinder12:48
*** diegows has quit IRC12:52
*** gouthamr has quit IRC12:52
*** dustins has joined #openstack-cinder12:56
openstackgerritEdmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder  https://review.openstack.org/21785712:58
*** vincent_hou has joined #openstack-cinder13:00
vincent_houjbernard: Hi13:00
jbernardvincent_hou: heya13:00
vincent_houjbernard: I will give you a five. I think you know the reason.13:01
jbernardvincent_hou: thanks :) it's been a long road on that one ;)13:01
vincent_houWell done.13:01
jbernardhonestly, the review feedback from everyone was not only super helpful, but I learned a lot during the process and the patch was much better for it13:02
vincent_houAwesome. I need that one as well.13:02
vincent_houExactly, that is how we work in an open source project.13:02
*** stefan_amann has quit IRC13:03
vincent_houI just did a rebase on your patch, but now I just ned to rebase on master.13:03
*** salv-orlando has quit IRC13:04
jbernardfor progress status?13:04
vincent_houThat one is for sure, but I mean this one: https://review.openstack.org/20775413:04
vincent_houstill working on it.13:05
jbernardok, let me know if/when you need review13:05
*** gouthamr has joined #openstack-cinder13:07
*** bill_az has joined #openstack-cinder13:10
*** stefan_amann has joined #openstack-cinder13:11
*** baojg has joined #openstack-cinder13:12
*** esker has quit IRC13:14
*** svilgelm has joined #openstack-cinder13:18
*** julim has joined #openstack-cinder13:22
*** mriedem has joined #openstack-cinder13:24
openstackgerritWilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver  https://review.openstack.org/20202313:25
openstackgerritVincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id)  https://review.openstack.org/21878113:26
openstackgerritGorka Eguileor proposed openstack/cinder: Fix backup metadata import missing fields  https://review.openstack.org/18322213:27
*** changbl has quit IRC13:28
*** baojg has quit IRC13:29
openstackgerritWilson Liu proposed openstack/cinder: Fix way of get LUN id in Huawei driver  https://review.openstack.org/20974913:30
*** simondodsley has joined #openstack-cinder13:31
*** mtanino has joined #openstack-cinder13:31
*** baojg has joined #openstack-cinder13:32
*** jwcroppe_zzz is now known as jwcroppe13:32
openstackgerritWilson Liu proposed openstack/cinder: Encode username and password in Huawei driver  https://review.openstack.org/21608513:34
*** wilson has joined #openstack-cinder13:34
*** ankit_ag has quit IRC13:35
*** lcurtis has joined #openstack-cinder13:36
openstackgerritWilson Liu proposed openstack/cinder: Check before add lun to QoS in Huawei driver  https://review.openstack.org/21923913:36
*** xyang has joined #openstack-cinder13:36
*** sgotliv has quit IRC13:38
mriedemis this bad? http://logs.openstack.org/17/215817/2/gate/gate-tempest-dsvm-neutron-full/e9c2466/logs/screen-c-vol.txt.gz#_2015-09-01_04_04_47_01613:40
mriedemit's only logged at debug level13:40
mriedemseeing a problem in VolumesV1SnapshotTestJSON where tempest times out waiting for a volume to go to in-use status after it's attached but it never does13:42
mriedemeven though c-vol says it was attached successfully: http://logs.openstack.org/17/215817/2/gate/gate-tempest-dsvm-neutron-full/e9c2466/logs/screen-c-vol.txt.gz#_2015-09-01_04_04_52_31113:42
*** eharney has joined #openstack-cinder13:44
openstackgerritSzymon Wróblewski proposed openstack/cinder: utils.synchronized lock name formatting  https://review.openstack.org/21725813:46
*** jungleboyj has quit IRC13:46
*** rushil has joined #openstack-cinder13:47
*** edmondsw has joined #openstack-cinder13:47
*** baojg has quit IRC13:47
*** kvidvans has joined #openstack-cinder13:48
*** annegentle has quit IRC13:49
*** amoturi has quit IRC13:51
*** amoturi has joined #openstack-cinder13:51
openstackgerritVincent Hou proposed openstack/cinder: Adds migration abortion for available volumes  https://review.openstack.org/20775413:51
*** sgotliv has joined #openstack-cinder13:52
*** bkopilov has joined #openstack-cinder13:56
*** zul has quit IRC13:56
*** zul has joined #openstack-cinder13:56
mtaninomriedem: I think it's not bad. Config file didn't exist but it will regenerate automatically at14:00
mtaninomriedem: http://logs.openstack.org/17/215817/2/gate/gate-tempest-dsvm-neutron-full/e9c2466/logs/screen-c-vol.txt.gz#_2015-09-01_04_04_47_11914:00
mriedemmtanino: ok, i was going to dig into the tempest.api.volume.test_volumes_snapshots.VolumesV1SnapshotTestJSON.test_snapshot_create_with_volume_in_use test and see what it's failing on14:00
mtaninomriedem: then the volume attachment was succeeded, I think14:00
*** thangp has joined #openstack-cinder14:00
mriedemi see it creates a volume and attaches it ok, then creates a snapshot14:00
mriedemsnapshot of the volume14:00
mriedemi'm not sure what happens after that, i have to dig into what the test is doing14:01
mriedembut now i have to start my day of 5 meetings14:01
*** mriedem is now known as mriedem_meetings14:01
mtaninomriedem_meetings: oops...14:01
*** lprice has quit IRC14:01
*** crose has quit IRC14:02
openstackgerritVincent Hou proposed openstack/cinder: Adds migration abortion for available volumes  https://review.openstack.org/20775414:04
openstackgerritWilson Liu proposed openstack/cinder: Fix way of get LUN id in Huawei driver  https://review.openstack.org/20974914:06
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access  https://review.openstack.org/21923114:08
thangpgeguileo: ping14:10
geguileothangp: Hi14:10
thangpgeguileo: 17705414:10
thangpgeguileo: I tried breaking it up to specific apis14:10
geguileothangp: Can't it be reduced even more?  Because it looks like it's possible14:11
geguileo(though I could be wrong)14:11
thangpgeguileo: but since volume is so intertwined with everything, i cant do one without doing another14:11
thangpDaniel Tadrzak tried14:11
thangpgeguileo: he had a hard time because everything just breaks14:12
geguileothangp: The problem now is that we are trying to do the reserve of what should have been done14:13
geguileothangp: And that's usually HELL14:13
thangpgeguileo: reserve?14:13
geguileothangp: ^ what do you mean?14:13
thangpgeguileo: "The problem now is that we are trying to do the reserve"14:14
geguileoXD XD XD14:14
thangpgeguileo: I dont understand your comment14:14
geguileothangp: s/reserve/reverse14:14
geguileothangp: It's normal you couldn't understand me with these fingers that write whatever they want  ;-)14:15
*** andreykurilin__ has quit IRC14:15
openstackgerritWilson Liu proposed openstack/cinder: Check before add lun to QoS in Huawei driver  https://review.openstack.org/21923914:16
thangpgeguileo: i dont think it can be broken up easily14:17
geguileothangp: I see the patch is changing create, create_snapshot, _migrate_volume_generic and _clean_temporary_volume in the same patch14:17
thangpgeguileo: which file is create_snapshot in?14:18
geguileothangp: manager14:18
*** rushil has quit IRC14:18
thangpgeguileo: create_snapshot can go out14:20
*** takedakn has joined #openstack-cinder14:21
thangpgeguileo: but i remember having problems with tempest for the conversion, hence the changes went into these methods14:21
*** xyang has quit IRC14:22
*** links has quit IRC14:23
*** edtubill has joined #openstack-cinder14:24
*** annegentle has joined #openstack-cinder14:25
*** timcl has quit IRC14:25
*** alejandrito has joined #openstack-cinder14:26
*** akerr has joined #openstack-cinder14:27
*** takedakn has quit IRC14:28
*** xyang has joined #openstack-cinder14:28
*** dustins_ has joined #openstack-cinder14:28
e0neй is14:29
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502714:29
*** dustins has quit IRC14:31
jgriffiththangp: geguileo correct me if I'm wrong, but really over 90% of that is unit test changes no?14:31
dulekjgriffith: 75.9% exactly - I've just counted. ;)14:31
geguileojgriffith: But if unittests are not changed correctly they may not be testing what they should and how they should be testing it14:32
e0newhat changes do you mean?14:32
geguileojgriffith: So those changes are just as important14:32
jgriffithgeguileo: duhh :)14:32
thangpe0ne: to use versionedobjects instead of db14:32
dulekgeguileo: Basically when reviewing I've checked for removed asserts. There's just a few, all justified.14:32
jgriffithgeguileo: did I say they weren't?14:32
geguileoe0ne: For Volume14:32
thangpe0ne: instead of db dicts14:32
geguileojgriffith: No you didn't  :-)14:33
jgriffithgeguileo: it's tricky because any time you make any change in volume code you're going to have a significant ripple effect out to the unit tests14:33
jgriffithgeguileo: that being said, the patch is a bit large for my liking at L314:33
jgriffithgeguileo: we're supposed to be getting more selective at this point, not rewriting the world :)14:33
geguileojgriffith: Me?14:34
jgriffithgeguileo: you what?14:34
geguileojgriffith: It's not my patch14:34
jgriffithgeguileo: I'm aware of that14:34
geguileojgriffith: My patches are getting -2 from you  ;-P14:34
jgriffithgeguileo: I'm somewhat agreeing with your comments in the patch14:34
jgriffithgeguileo: yes they are14:34
jgriffithgeguileo: but you've updated them14:34
jgriffithgeguileo: I haven't looked yet14:35
geguileojgriffith: It was just a joke, I know why you -2 them  :-)14:35
jgriffithgeguileo: Oh... :)14:35
thangpat this point, i'm not expecting it to be able to go into L3...but i have a problem breaking up the patch14:35
jgriffiththangp: understood...14:35
jgriffiththangp: maybe folks can volunteer to help look for opportunities on breaking it up14:36
openstackgerritVincent Hou proposed openstack/python-cinderclient: Volume status management for volume migration  https://review.openstack.org/18954714:36
dulekBasically without all object patches we're loosing possibility of making rolling upgrades L->M possible.14:36
jgriffiththangp: I had though isolate the taskflow stfuff as a start, but that doesn't work :(14:36
geguileothangp: Puffff, then that's going to be hellish to review  :''-(14:36
jgriffithThen I though... manager and rpc... bizzzzz no joy14:36
jgriffithdulek: indeed14:37
geguileodulek: Yes, but changing ALL volume operation in L3 is really risky, don't you think?14:37
dulekjgriffith: Probably the only sane idea would be to split create and delete.14:37
dulekgeguileo: It definitely is, I know that.14:37
thangpdulek: yeah, that will only account for 100 lines :)14:37
jgriffithdulek: yeah, breaking it up by operation seems to be the only workable solution14:37
*** timcl has joined #openstack-cinder14:38
dulekjgriffith: Thing is - a lot of volume tests are doing creates and deletes in one test, so it's kind of natural to change that in one shot.14:38
thangpjgriffith, geguileo: the get operation is causing the largest change14:38
jgriffithdulek: oh, I get it it...14:38
jgriffithhmmm... what a kunundrum14:40
*** afazekas__ has quit IRC14:41
*** Yogi11 has quit IRC14:41
dulekWe were actually able to merge snapshots, which were a +1468, -272 patch.14:41
jgriffithone thing to keep in mind is that most of it is not *functional* or *logic* changes, it's just data-structures14:41
thangpjgriffith: correct14:42
jgriffithdulek: yeah, I'm not saying we can't merge it, not saying the size is a deal breaker14:42
*** boris-42 has joined #openstack-cinder14:42
jgriffithdulek: just trying to talk through some of the concerns14:42
jgriffithdulek: part of the reality is if we don't "just do it" we never will14:42
jgriffithThe fact that is' been in progress since April and has 80+ revisions I HATE the thought of dragging it out even longer :)14:43
dulekjgriffith: That's my concern also - works on patch started in Apirl.14:43
jgriffithdulek: thangp I say get it rebased, and we all dedicate time TODAY to review it14:44
thangpjgriffith: ok, will do14:45
vincent_hougeguileo: thank you for ur comments.14:45
jgriffithdulek: thangp and if I see any nit picky bs about punctuation or spelling I'm going to blow a gasket :)14:45
thangpjgriffith: :)14:45
geguileovincent_hou: that patch is just about ready  :-)14:45
DuncanTjgriffith: 'pickey' ;-)14:46
geguileojgriffith: You and me both14:46
* DuncanT ducks14:46
jgriffithif there's a typo in a comment I don't really care; if it's a doc-string... meh; ok but shouldn't be a -1 unless it's something like profanity interlaced in with the description :)14:46
dulekjgriffith, thangp: That way we'll at least have compatibility for rolling upgrades L->M for creating and deleting volumes.14:46
vincent_hougeguileo: Just submit a new one.14:46
geguileovincent_hou: Awesome14:46
dulekThat's something. :)14:46
* jgriffith lobs a water balloon at DuncanT 14:46
jgriffithand it's shot down by Israel's iron curtain14:46
dulekBTW - there's one more smaller objects patch - CGSnapshots14:47
DuncanTI do actually rather agree with your point though, and I'm happy to merge over the top of nit pick -1s14:47
jgriffithDuncanT: smcginnis_afk patrickeast geguileo eharney xyang You all ok with proceeding/comitting to reviewing that patch today?14:47
*** ppal has joined #openstack-cinder14:47
* jgriffith would ask other cores but they're not all online 14:47
DuncanTjgriffith: The CGSnap one or the vol one?14:47
dulekthangp: Do you agree with my concerns on unnecessary DB calls? I can help you with fixing them if you have any questions.14:48
jgriffithThis one: https://review.openstack.org/#/c/177054/8414:48
jgriffithwhcih cg-snap one?14:48
DuncanTI've got about 40 minutes I can spend on it now14:48
thangpdulek: yeah, I agree14:48
*** vincent_hou has quit IRC14:48
thangpdulek: let me put  rebase of the vol obj14:48
jgriffithDuncanT: that works14:48
thangpdulek: if you have time, could you help me with the taskflow stuff?14:48
openstackgerritThang Pham proposed openstack/cinder: Sync volume versionedobject to ORM  https://review.openstack.org/21836114:49
dulekthangp: Definitely, I'll stay here for some time.14:49
jgriffithBTW... those on the night shift may not have seen my note last night; I don't think the etherpad thing worked out very well for us, I think we should use Launchpad as that's what it's for.14:49
jgriffithAll the items for L3 are there and targetted and those should be priority14:49
dulekjgriffith: The CGSNapshot's one is here: https://review.openstack.org/#/c/195027/3714:49
jgriffithDuncanT: I think that can wait personally14:50
jgriffitherrr.. dulek ^^14:50
geguileojgriffith: This one also need reviewing https://review.openstack.org/#/c/21836114:50
geguileojgriffith: Which syncs Volume to ORM Volume14:50
*** rushil has joined #openstack-cinder14:50
jgriffithgeguileo: yeah... I was looking at that dep chain :(14:51
jgriffithCGSnapsots would be my lowest priority14:51
xyangjgriffith: that one still need a requirement change?14:51
jgriffithany chance at getting volumes actually merged would be a big win IMO14:51
jgriffithI know it might not be possible, but if people are willing to try I think it would be worth the investment14:52
*** svilgelm has quit IRC14:52
jgriffithxyang: the volume objects requires the ORM change14:52
* geguileo thinks it's a bad idea to review and merge 3700 LOC at this point14:52
xyangjgriffith: I mean the CGSnapshot change14:52
*** svilgelm has joined #openstack-cinder14:52
* DuncanT is reviewing https://review.openstack.org/#/c/218361/2 first on the off change the merge conflict is fixed by the time I'm finished14:52
jgriffithgeguileo: yeah... you may be rigth14:52
jgriffithright even :)14:52
xyangjgriffith: it needs a requirement change for the versionedobjects release14:52
jgriffithhmm... oh boy; I don't know if this is going to work14:53
*** nkrinner has quit IRC14:53
dulekxyang: Actually global-requirements commit is merged, so no blockers no.14:53
dulekxyang: s/no./now.14:53
*** tpsilva has quit IRC14:53
jgriffithI will say one thing!!!  If we don't merge this in L, I vote that NOTHING is reviewed/merged in M until this lands14:54
jgriffithwe can't go on like this IMO14:54
jgriffithfor once we need to just "finish" something :)14:54
*** cdelatte has joined #openstack-cinder14:55
*** delattec has joined #openstack-cinder14:55
xyangjgriffith: I have tested this earlier.  Just need to make sure the right version of versionedobjects is installed, otherwise cg functions will fail14:55
jgriffithgeguileo: BTW the counter-argument to the "it's late in the cycle" is that we've always lived under this silly false pretense that everybody deploys OpenStack continiously from trunk so release is just a tag or a date :)14:55
jgriffithgeguileo: I clearly see the difference, but just pointing out the argument :)14:56
xyangdulek: can you send me a url for the global-requirement change?14:56
geguileojgriffith: You do have a point14:56
jgriffithgeguileo: it's not a very strong one... but it is "a point" anyway :)14:57
geguileojgriffith: And I do really want to see us using Volume vo everywhere...14:57
*** svilgelm has quit IRC14:57
*** zhangjn has quit IRC14:57
*** links has joined #openstack-cinder14:57
dulekxyang: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L9214:58
xyangdulek: thanks14:58
*** jistr is now known as jistr|call14:58
*** erlon has quit IRC14:58
*** thangp has quit IRC14:58
dulekxyang: And here's the review: https://review.openstack.org/#/c/216848/14:58
dulekjgriffith: One more thing, I worked to fix a bug with using Cinder on non-US locale: https://review.openstack.org/#/c/216675/14:59
*** hemna has joined #openstack-cinder14:59
jgriffithDuncanT: geguileo xyang dulek so here's my other conflicted view on this....14:59
dulekjgriffith: As this is changing rootwrap filters it requires grenade changes, which require a release note and an ACK from PTL.15:00
jgriffithDuncanT: geguileo xyang dulek rolling upgrades are cool; and they're pretty important for projects like Nova15:00
jgriffithfor Cinder, I've always viewed them as a "convenience" not a must-have15:00
jgriffithdulek: I don't think we're going to be able to do this15:01
*** daemontool_ has quit IRC15:01
dulekjgriffith: Okay, early Mitaka it is! :)15:01
jgriffithdulek: the thought of changing grenade and gate at this point along with everything else I'm afraid is going to show bad judgement15:01
jgriffithdulek: I'm really sorry; I really wanted to just commit to this and move forward on it today15:01
jgriffithdulek: I WISH that I had been paying attention to this earlier, this SHOULD have been driven as a top priority in L2 or at least the first half of L315:02
xyangjgriffith: so not merging the CGSnapshot object change in L?  https://review.openstack.org/#/c/195027/15:02
jgriffithdulek: we really need to organize our efforts better and work as a team15:02
dulekjgriffith: Yeah, I've discovered it in late L3. I look at it as rather low priority - you can always change locale, so I'm okay with moving it to M>15:03
jgriffithxyang: I don't think that one was really ever on the table15:03
jgriffithxyang: in other words no15:03
xyangjgriffith: oh, you pinged me earlier for that:)15:03
jgriffithxyang: sorry... DuncanT asked about that one, but I was actually talking about the volume version15:04
xyangjgriffith: ok, I won't +2 then15:04
*** diogogmt has joined #openstack-cinder15:04
jgriffithxyang: TBH I haven't looked at the CG one much; I'm not necessarily sure which way to go on that one yet15:04
xyangjgriffith: the CG object is already merged15:05
xyangjgriffith: this one is CGSnapshot object15:05
jgriffithxyang: yeah.... looking15:05
xyangjgriffith: blocked earlier because of a bug in versionedobjects15:05
jgriffithxyang: that one's fine IMO if people want to review it15:06
jgriffithIt's isolated, and "smallish"15:06
xyangjgriffith: I'm already done reviewing it.  now that requirements are all updated for versionedobjects change15:06
openstackgerritAnton Arefiev proposed openstack/cinder: Add instructions on how to deploy API under Apache  https://review.openstack.org/20702015:07
xyangjgriffith: so I'll +2 if it passes Jenkins?15:07
*** diogogmt has quit IRC15:07
jgriffithxyang: sure... why not :)15:08
jgriffithwhat could go wrong15:08
*** diogogmt has joined #openstack-cinder15:09
xyangjgriffith: :)15:09
jgriffithtbarron: you around?15:09
*** diogogmt has quit IRC15:11
tbarronjgriffith: you getcha15:11
tbarronwhat's up?15:12
*** alexschm has quit IRC15:13
*** salv-orlando has joined #openstack-cinder15:13
*** thangp has joined #openstack-cinder15:14
*** cbader has joined #openstack-cinder15:14
dulekjgriffith: Ehm, I think we got misunderstood a little. Volume object doesn't have grenade dependencies... I've pointed to other review.15:14
*** links has quit IRC15:16
*** dims has quit IRC15:17
*** salv-orlando has quit IRC15:18
*** sayali has quit IRC15:19
*** salv-orlando has joined #openstack-cinder15:19
*** diogogmt has joined #openstack-cinder15:21
*** sayali has joined #openstack-cinder15:21
*** rmetcalf has joined #openstack-cinder15:21
*** annegentle has quit IRC15:23
*** annegentle has joined #openstack-cinder15:23
*** jdurgin1 has joined #openstack-cinder15:23
*** diogogmt has quit IRC15:24
*** salv-orlando has quit IRC15:26
*** haomaiwang has quit IRC15:27
*** timcl has quit IRC15:29
jgriffithtbarron: never mind, saw your post on ML and just responded to that15:30
openstackgerritAnton Arefiev proposed openstack/cinder: Add instructions on how to deploy API under Apache  https://review.openstack.org/20702015:31
jgriffithtbarron: I believe I also asked you to let me know how you would prioritize those items on your list15:33
*** avishay has joined #openstack-cinder15:34
tbarronjgriffith: I changed the order to (among ours only) to reflect priority15:34
jgriffithtbarron: ya know, I'm trying to be nice here and even tempered; but frankly I find this extremely annoying15:35
*** p0rtal has joined #openstack-cinder15:35
jgriffithtbarron: you've been working in Cinder long enough15:35
openstackgerritAnton Arefiev proposed openstack/cinder: Add instructions on how to deploy API under Apache  https://review.openstack.org/20702015:35
jgriffithtbarron: YOU should know that to expect to post a patch for a driver FEATURE and think it's going to just breeze through in a week is foolish!15:35
jgriffithtbarron: ESPECIALLY when that week is the closing week for the 3'rd milestone15:36
tbarronjgriffith: Honestly I have been trying to follow the process that was outlined for us.  Everything on their made the deadlines, etc.15:36
jgriffithtbarron: prioritizations are there for a reason.. and that reason is that things that are "higher" in priority are the friking PRIORITY15:36
jgriffithtbarron: things that are LOW on the list are "lower on the list"15:37
jgriffithtbarron: You're completely missing the point!!!!15:37
avishayhey all15:37
jgriffithtbarron: process, deadlines etc... it's all artificial15:37
jgriffithavishay: hey !!!15:37
jgriffithavishay: how the heck have you been!15:37
avishayjgriffith: what's going on man?15:37
avishayjgriffith: doing well :)15:38
avishayjgriffith: you?15:38
jgriffithavishay: the usual15:38
tbarronjgriffith:  I don't want to get in the way of productive work today and will drop off for now unless there's something constructive I can add.15:38
jgriffithavishay: "my patches didn't make L3... you suck blah blah blah"15:38
jgriffithtbarron: yes, there is15:38
jgriffithyou can help get the high and med stuff figured out15:38
*** salv-orlando has joined #openstack-cinder15:38
avishayjgriffith: :)15:38
jgriffithand then we can move to the low priority ones in your list15:38
tbarronjgriffith: I have been reviewing quite steadily and will continue to do so.15:39
jgriffithtbarron: we have more cores submitting new patches than we have doing reviews right now... which isn't really helping me here15:39
jgriffithor you fo rthat matter15:39
jgriffithtbarron: okie dokie, thanks15:39
e0nejgriffith: hi. could you please take a look on it (https://review.openstack.org/#/c/194726/) if you'll get a time? this patch switches cinder to api v2 in infra tempest tests15:39
avishayOpenStack doesn't support rolling upgrades, does it?15:40
e0nejgriffith: i'm going to post to openstack-dev about it too15:40
jbernardavishay: not yet15:40
jbernardavishay: oh sorry, cinder not yet15:40
jbernardavishay: nova does15:40
jgriffithavishay: lol... we were just talking about that15:40
dulekavishay: Heat, Glance and Swift also,15:41
jbernarddulek: and i think neutron is working on it15:41
avishayany pointer as to how it works in nova/glance?15:41
jgriffithdulek: you're killin me man :(15:41
e0nejgriffith: thanks! i just wanted to confirm that we want it in liberty15:41
jgriffithdulek: I would like to merge that patch... I REALLY would15:41
jbernardjgriffith: all the cool kids are rolling upgrades man, get with the times :)15:42
jgriffithjbernard: LOL15:42
jgriffithdamn HIPSTERS!!!15:42
jbernardruining everything!15:42
*** dustins_ has quit IRC15:43
dulekjgriffith: I get it, just please read this log again, there were quite big misunderstanding about granade: http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/latest.log.html#t2015-09-01T14:59:3115:43
jgriffithdulek: thangp I'm just curious... do you guys think that moving that to M is the wrong call?  I mean, setting aside the fact that you've put so much work into it15:43
*** subhadeep_de has quit IRC15:43
jgriffithdulek: oh... yes... about that15:43
thangpjgriffith: moving what?15:44
jgriffithdulek: so I was/am confused15:44
thangpjgriffith: rolling upgrade?15:44
jgriffiththangp: yes15:44
jgriffiththangp: or the volume objects patch at any rate15:44
*** subhadeep_de has joined #openstack-cinder15:44
dulekjgriffith: I was talking about review https://review.openstack.org/#/c/216675/ and *not* about the volume patch.15:44
avishayjbernard: dulek: any pointers as to how to do rolling upgrades with nova/glance?15:44
jgriffithdulek: Oh!!!15:44
thangpjgriffith: thing is that, in order to doing some rolling upgrade, we need the objects in place15:44
avishayvia "objects"?15:44
jgriffithdulek: thank god!15:44
jgriffithdulek: ok, so now I'm back on the fence again15:45
dulekavishay: http://superuser.openstack.org/articles/upgrading-nova-to-kilo-with-minimal-downtime15:45
jgriffithI would LOVE some input form others15:45
avishaydulek: gracias15:45
dulekjgriffith: I know, I know, sorry about that, got in the middle of your messages with mine.15:45
jgriffithdulek: yeah, you mentioned that and the rootwrap stuff and I was like... duuude, no way15:46
jgriffithI'm out15:46
dulekjgriffith: It would be quite silly if that would require changing rootwrap.15:46
dulekjgriffith: So about rolling upgrades - ops are always saying that this is an issue.15:47
jgriffithdulek: well... I was wondering what was going on that you'd need a grenade change and a rootwrap change15:47
dulekjgriffith: Especially with 6-months releases.15:47
jgriffithdulek: that's what pushed me over the edge and made me put the -2 on this https://review.openstack.org/#/c/177054/15:47
dulekjgriffith: And for my work I'm getting requirements by talking with ops mostly.15:47
dulekjgriffith: That's why I think it is a hot topic in the community.15:48
*** martyturner has joined #openstack-cinder15:48
dulekjgriffith: I think thingee also said in Vancouver that he's tired of ops complaining that Cinder cannot do upgrades without downtime.15:49
dulekjgriffith: And first step is object versioning which allows us to run multiple versions of services and downgrade objects on demand.15:50
thangpjgriffith, dulek: it's going to take some time before we get actual rolling-upgrade to work.  you need to have a release that has the stuff to transform the rpc and objects first...then the next release will be able to do rolling upgrade15:50
jgriffiththe magical "ops" groups15:50
jgriffithkinda like a unicorn15:50
jgriffiththangp: yeah, that's why it's kind of important to quite screwing around on this15:51
dulekthangp: Actually to get upgrade X->Y possible you need to have all versioned objects calls done in X.15:51
*** j_king has left #openstack-cinder15:51
jgriffiththangp: and why somebody should've been driving it a long time ago15:51
*** xyang has quit IRC15:51
jgriffithdulek: I tihnk that was his point15:51
*** mriedem_meetings is now known as mriedem15:51
thangpdulek, jgriffith: correct15:52
*** garthb has joined #openstack-cinder15:52
*** garthb_ has joined #openstack-cinder15:52
dulekjgriffith, thangp: What I've meant is that RPC compatibility mode (aka RPC version pinning) is needed only in Y.15:52
thangpdulek: well...we need code to register the versions in X, so you know what to pin to15:53
thangpin Y15:53
*** dustins has joined #openstack-cinder15:54
dulekthangp: Ah, right. In Cinder's model that's true. In Heat's model pinning is done in configuration, so admin can simply add config option for heat.conf in newer services.15:54
thangpdulek: https://review.openstack.org/#/c/209701/15:55
thangpdulek: have to rebase :/15:55
*** shausy has quit IRC15:56
*** ociuhandu_ has joined #openstack-cinder15:58
*** esker has joined #openstack-cinder15:59
*** esker has quit IRC16:00
*** zhenguo has quit IRC16:00
*** skylerberg has joined #openstack-cinder16:00
*** eharney has quit IRC16:01
*** esker has joined #openstack-cinder16:01
*** vilobhmm1 has joined #openstack-cinder16:01
*** xyang has joined #openstack-cinder16:02
*** martyturner has quit IRC16:03
*** martyturner has joined #openstack-cinder16:04
*** dims has joined #openstack-cinder16:05
*** e0ne has quit IRC16:05
*** crose has joined #openstack-cinder16:06
*** leeantho has joined #openstack-cinder16:06
*** ociuhandu_ has quit IRC16:07
*** akerr has quit IRC16:07
*** stefan_amann has quit IRC16:08
*** dflorea has joined #openstack-cinder16:09
*** pwehrle has quit IRC16:09
*** changbl has joined #openstack-cinder16:10
*** akerr has joined #openstack-cinder16:11
thrawn01anyone know of some openstack projects that are using pylint and might have examples of custom pylint checkers?16:11
*** martyturner1 has joined #openstack-cinder16:12
thrawn01pylint documentation is limited when it comes to custome checkers, it has some examples but not even sure how to load the custom checker once I write it!16:12
*** martyturner has quit IRC16:12
thrawn01I'm trying to do this "low hanging fruit" https://bugs.launchpad.net/cinder/+bug/141524116:12
openstackLaunchpad bug 1415241 in Cinder "cinder hacking checks don't cover logging format string arg count" [Undecided,New] - Assigned to Scott DAngelo (scott-dangelo)16:12
*** garthb_ has quit IRC16:15
thangpdulek: do you still plan to update https://review.openstack.org/177054?16:15
*** jaypipes has quit IRC16:16
*** eharney has joined #openstack-cinder16:16
dulekthangp: Ah, you've thought I will do it. Sorry, another misunderstanding. I can do it, give me a few minutes. :)16:17
thangpdulek: :)16:17
*** lprice has joined #openstack-cinder16:17
*** vilobhmm1 has left #openstack-cinder16:17
*** esker has quit IRC16:20
*** sgotliv has quit IRC16:21
*** hemna_ has joined #openstack-cinder16:27
*** jaypipes has joined #openstack-cinder16:27
*** jistr|call has quit IRC16:28
*** dannywilson has joined #openstack-cinder16:28
*** bluex-pl has quit IRC16:30
*** jdurgin1 has quit IRC16:30
*** dannywilson has quit IRC16:30
*** gouthamr has quit IRC16:32
*** avishay has quit IRC16:35
*** avishay has joined #openstack-cinder16:35
hemna_finally have my desktop back16:35
hemna_man, apt-get upgrade changed the / LVM UUID !16:36
Swansonplus an underscore16:36
smcginnis_afkthrawn01: Make sure Scott sin't working on it first suince it's assigned to him.16:36
smcginnis_afkOMG wifi sucks here.16:37
SwansonAre you at IBM?16:37
smcginnis_afkthrawn01: Second, it would be a flake8 plugin/ Looking at the HACKING stuff.16:37
hemna_Swanson, lol16:37
smcginnis_afkthrawn01: Third, it's pretty much impossible to address that, so good luck. ;)16:37
smcginnis_afkSwanson: Hah!16:38
smcginnis_afkI think Jay's phone would be better than this.16:38
smcginnis_afkGee, I'm gone one day and all hell breaks loose. :)16:38
hemna_smcginnis_afk, job security.16:39
*** dustins has quit IRC16:39
hemna_smcginnis_afk, or sabatoge, one of the 216:39
*** lpetrut has quit IRC16:39
smcginnis_afkhemna_: :)16:39
*** abehl has quit IRC16:40
scottdathrawn01: You can take that bug16:41
*** Apoorva has joined #openstack-cinder16:41
*** dustins has joined #openstack-cinder16:41
dulekthangp: To rebase the patch I need also to move the dependency up. That would mean losing +2 from DuncanT. I hope you're not disappointed?16:42
thangpreally?  i just rebased https://review.openstack.org/218361 to the latest16:44
thangpthat's before DuncanT +216:44
dulekthangp: Okay, let me take a look.16:44
*** aix has quit IRC16:45
*** diogogmt has joined #openstack-cinder16:46
*** skylerberg has quit IRC16:46
*** david-ly_ has joined #openstack-cinder16:49
*** david-lyle has quit IRC16:49
*** p0rtal has quit IRC16:49
dtadrzak_xyang: CGSnapshot passed tests16:50
*** rhagarty_ has quit IRC16:50
*** rhagarty has quit IRC16:50
openstackgerritMichal Dulko proposed openstack/cinder: Conversion to volume object  https://review.openstack.org/17705416:57
dulekthangp: ^ I've managed to update just one. :)16:57
thangpdulek: thanks!16:57
*** rhagarty has joined #openstack-cinder16:57
*** rhagarty_ has joined #openstack-cinder16:58
dulekthangp: A cross-check done by you will be beneficial. It's the evening here, so I may be not that focused.16:59
thangpdulek: will do16:59
*** subhadeep_de has quit IRC16:59
dulekthangp: Time to get home, I'll be back on IRC in an hour in case of any questions/concerns.16:59
*** julim has quit IRC17:00
thangpdulek: ok, ttyl17:00
*** lpetrut has joined #openstack-cinder17:01
*** skylerberg has joined #openstack-cinder17:01
*** gouthamr has joined #openstack-cinder17:01
*** julim has joined #openstack-cinder17:03
openstackgerritMichal Dulko proposed openstack/cinder: Conversion to volume object  https://review.openstack.org/17705417:03
dulekthangp: ^ Sorry, forgot to remove unused imports.17:04
*** avishay has quit IRC17:06
*** david-ly_ has quit IRC17:07
*** dflorea has quit IRC17:08
*** dflorea has joined #openstack-cinder17:08
*** hemna has quit IRC17:09
*** subhadeep_de has joined #openstack-cinder17:10
*** lpetrut has quit IRC17:11
*** subhadeep_de has quit IRC17:13
*** subhadeep_de has joined #openstack-cinder17:13
openstackgerritPatrick East proposed openstack/cinder: Generic image-volume cache  https://review.openstack.org/19579517:20
patrickeasthemna_: hey, have you had a chance to read through the latest comments on the image cache change? ^17:23
hemna_patrickeast, no, I just got my machine back up a bit ago, dealing with email backlog, etc17:23
patrickeastjgriffith: regarding your comment and the 24 hour window mentioned... any chance that could extend a few more hours till the weekly meeting?17:23
patrickeasthemna_: ok, well let me know if you have any questions once you do get to it17:24
hemna_goosh.  looks like a big discussion there.17:24
hemna_sorry I've been out of it for a few days....machine down and all17:24
patrickeastno worries, it happens17:24
*** aix has joined #openstack-cinder17:25
hemna_patrickeast, so I think a suggestion I might have mentioned for the config thing17:27
hemna_is that I think if we can add a check in our 3PAR driver to see if the conf option is set and enabled,17:28
hemna_then we can raise an exception in do_setup for our driver17:28
hemna_which in effect will mark the driver as uninitialized and won't accept any requests.17:28
hemna_it's not ideal, but it prevents the admin from enabling this feature for our driver, which will break on copy image <--> volume operations17:29
hemna_until we can find a workaround for it :(17:29
patrickeasthemna_: ah yea, thats easy enough to do, the image_volume_cache_enabled config option is available in the conf your driver gets17:29
hemna_ok I can try putting together a patch and test to make sure it works.17:29
jgriffithpatrickeast: I'm fine with somebody reviewing and approving that one.  I gave it my +2 already17:30
jgriffithpatrickeast: my only concern was making sure hemna_ was ok with it17:30
jgriffithpatrickeast: the -2 from jungleboy can be lifted17:31
patrickeastjgriffith: sounds good, thanks again for taking the time to work through the issues with it17:31
hemna_the feature works great on our LeftHand arrays17:31
jgriffithpatrickeast: I'm still reviewing items, including tbarron 's netapp patches17:31
jgriffithI was wishing/hoping others were still reviewing as well17:31
hemna_it's just the 3PAR issue of modifying a volume while it's cloning is in flight.17:31
jgriffithhemna_: right, so you get to say yay or nay :)17:32
jgriffithhemna_: I guess my question is, how hard is that to fix?17:32
hemna_if we can get my follow up patch in that disable it for 3PAR only, then I think it's cool w/ me.17:32
hemna_so I have some ideas17:32
jgriffithhemna_: is it something that can be fixed before release17:32
hemna_I'll have to experiment and put some patches together and test17:32
jgriffithhemna_: Oh, I haven't seen your follow up patch17:32
hemna_it might be possible17:32
hemna_I haven't posted it yet :)17:33
jgriffithhemna_: patrickeast honestly I fully anticipate bug fixes, that's what RC's are for :)17:33
jgriffithhemna_: LOL...ahh, ok that's why I didn't see it then :)17:33
hemna_ok so I'll just comment in the review and +2 it, if we are ok with that ?17:33
jgriffithhemna_: I'm certainly fine with it, but I don't want to ignore input from anybody either17:33
tbarronjgriffith: thanks for the +2s!17:34
hemna_jgriffith, ok thanks man.17:34
*** lpetrut has joined #openstack-cinder17:38
dtadrzak_Could someone take a look on CGSnapshot patch (195027)?17:40
hemna_no junglboy17:42
*** afazekas__ has joined #openstack-cinder17:46
*** p0rtal has joined #openstack-cinder17:48
*** dflorea has quit IRC17:51
*** afazekas__ has quit IRC17:51
*** david-lyle has joined #openstack-cinder17:54
*** afazekas__ has joined #openstack-cinder17:54
*** skylerberg has left #openstack-cinder17:55
*** martyturner1 has quit IRC17:58
*** martyturner has joined #openstack-cinder18:00
*** dflorea has joined #openstack-cinder18:00
*** timcl has joined #openstack-cinder18:01
*** david-lyle has quit IRC18:01
*** agarciam has quit IRC18:03
*** dflorea has quit IRC18:04
openstackgerritThang Pham proposed openstack/cinder: Register RPC and object versions  https://review.openstack.org/20970118:05
*** martyturner has quit IRC18:06
*** afazekas__ has quit IRC18:07
*** subhadeep_de has quit IRC18:09
*** lpetrut has quit IRC18:10
DuncanTdulek: thangp: if you need me to re-review something after a rebase, poke me and I should see it without too long to wait18:10
thangpDuncanT: ok :)  we ended up not needing (yet)18:11
*** jungleboyj has joined #openstack-cinder18:13
dhellmannhemna_: are you the release liaison, since thingee is out? https://review.openstack.org/#/c/219013/18:14
hemna_dhellmann, I think it's jgriffith.18:14
dhellmannhemna_: ok, thanks18:15
hemna_dhellmann, I think that one is good to go FWIW18:15
*** david-lyle has joined #openstack-cinder18:19
Swansonwhere is thingee these days?  He didn't have a bad reaction to some hair dye did he?  :)18:19
jungleboyjSwanson: He is at Burning Man.18:20
hemna_Swanson, burning man18:20
jungleboyjLost in the desert.18:20
jungleboyjdhellmann: hemna_ Yeah 219013 looks fine to me too.18:21
SwansonI don't think I expected that answer.18:21
jungleboyjSwanson: :-)  Oh, he has shared a few stories from there.  He always disappears at this time of the year for Burning Man.18:24
jungleboyjAt least this year we were expecting it.  :-)18:24
*** rushil has quit IRC18:27
tbarronjgriffith: thanks for running re-check on https://review.openstack.org/215833  It passed.18:27
patrickeastjungleboyj: oh hey, any chance you can undo the -2 from https://review.openstack.org/#/c/195795/ ?18:28
*** e0ne has joined #openstack-cinder18:29
*** thangp_ has joined #openstack-cinder18:31
jgriffithhemna_: https://review.openstack.org/#/c/193451/18:31
jgriffithhemna_: My understanding is you wanted that before the next lib was cut?18:31
jgriffithhemna_: https://review.openstack.org/#/c/219013/18:31
hemna_well I wanted it before L ships :)18:31
jgriffithhemna_: well... that was kind of a question :)18:31
jgriffithhemna_: then we should probably do it now I think maybe.  Since a proposal is up to cut a release already18:32
hemna_ok +A'd18:32
jgriffithhemna_: mriedem ok, we'll just need to update the sha when it merges then and we can stick with that prposal18:32
jgriffithmriedem: sound ok to you?18:33
jungleboyjpatrickeast: Sorry, I thought I had skipped that one.  Unblocked.18:33
patrickeastjungleboyj: yay, thanks!18:33
jungleboyjpatrickeast: Of course.18:33
*** thangp has quit IRC18:34
jgriffithjungleboyj: you going to be around for tomorrows meeting?18:34
*** esker has joined #openstack-cinder18:35
*** esker has quit IRC18:35
tbarronjgriffith: and the recheck you did on https://review.openstack.org/#/c/215808/ also passed.  thanks again.18:36
jgriffithmtanino: hemna_ kmartin looks like this is done no?18:38
jgriffithmtanino: hemna_ kmartin little bit of confusion with the driver impls being tagged to it, but they all seem to be abandoned18:38
hemna_that guy is still outstanding18:39
*** e0ne has quit IRC18:39
hemna_https://review.openstack.org/#/c/212861/ is in the gate18:39
mtaninojgriffith: one main patch was merged and endpoint patch is in the gate and CLI is waiting the gate.18:39
hemna_so yah I think it's close FWIW18:40
*** dims has quit IRC18:40
kmartinhttps://review.openstack.org/#/c/216394/ is just the cinder spec that was updated18:40
mtaninojgriffith: Can you change the Assginee to me?  https://blueprints.launchpad.net/cinder/+spec/get-volume-type-extra-specs18:40
*** zhongjun222 has joined #openstack-cinder18:40
*** dims has joined #openstack-cinder18:40
mtaninojgriffith: I will close this BP when all patches will be merged.18:41
kmartinjgriffith, change the assignee to mtanino. Gary and Julie are no longer are working on it nor cinder for that matter18:42
jgriffithkmartin: I don't care about that, all I care about is "is the work done" :)18:42
jgriffithkmartin: it appears that there are no outstanding code-reviews, so it should be marked as implemented, no?18:43
jgriffithOoops... mtanino ^^18:43
jgriffithwhich patches aren't merged yet?18:43
mtaninojgriffith: implemented, yes!18:43
*** zhongjun22 has quit IRC18:44
jgriffithmtanino: kmartin ok, I changed assignee and marked it as implemented18:44
mtaninojgriffith: one patch is in gate and one more patch is wating.18:44
jgriffithmtanino: grrrr18:44
jgriffithmtanino: do you have links for said patches?18:44
mtaninojgriffith: https://etherpad.openstack.org/p/cinder-liberty-3-reviews18:44
mtaninoGet capabilities18:44
*** dims has quit IRC18:45
kmartinjgriffith, I think https://review.openstack.org/#/c/212861/ just hasn't landed yet but has been +2+A18:45
jungleboyjjgriffith: I will be around for tomorrow's meeting.18:45
jgriffithkmartin: mtanino ok, got it... and THANKS!18:46
jgriffithjungleboyj: ok, cool18:46
mtaninojgriffith: Thank you for pushing.18:46
jgriffithjungleboyj: so I think we'll clear some of the -2's based on concensus and reviews and try and get them merged18:46
jgriffithjungleboyj: now that we've recovered a bit I'm feeling better about things18:46
jgriffithjungleboyj: we'll need your super-powers :)18:47
*** zhongjun has joined #openstack-cinder18:47
*** diogogmt has quit IRC18:48
jungleboyjjgriffith: I will bring my cape.18:49
*** zhongjun222 has quit IRC18:49
jgriffithjungleboyj: LOL18:49
* jgriffith looks for photoshop and a picture of jungleboyj to work up 18:49
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/21544018:49
patrickeastjgriffith: is that just for the ones left on https://launchpad.net/cinder/+milestone/liberty-3 or for some of the 'low' ones from the etherpad that go knocked off yesterday?18:50
jgriffithpatrickeast: some of the no brainer low's I plan to bring back up18:50
jgriffithpatrickeast: for example a few of the NetApp ones are isolated and don't present any risk to core or release so I'm fine if they get reviewed and go out the door18:51
*** tpsilva has joined #openstack-cinder18:51
patrickeastjgriffith: so something like https://review.openstack.org/#/c/213855/ :D18:51
jgriffithpatrickeast: in other words, all the low priority ones we removed from LP yesterday are open for discussion18:51
jgriffithpatrickeast: remember what she said though :)18:52
jungleboyjjgriffith: Bring it on.  :-)18:52
openstackgerritMichal Dulko proposed openstack/cinder: Conversion to volume object  https://review.openstack.org/17705418:52
jgriffithdulek: I have bad news....18:53
*** raildo-afk is now known as raildo18:53
*** eharney has quit IRC18:53
jungleboyjpatrickeast: Love the gif.18:53
jgriffithdulek: I talked about this in the release management meeting; I don't think there's much chance I can justify it18:53
jungleboyjjgriffith: That sounds like a good plan.  I think it was good to lock things down yesterday and then take a careful approach to what remains.18:54
jgriffithI know I'm flip-flopping this morning; but I have been trying to figure out a way to make it go through even though I know it shouldn't :(18:54
*** diogogmt has joined #openstack-cinder18:54
jgriffithjungleboyj: yeah, so my goal was to get folks to focus on reviewing the higher priority stuff... that's all.  Turns out it didn't work anyway18:54
jgriffithjungleboyj: not many people revieiwed anything, and a bunch of people just submitted new patches :(18:55
jgriffithoh well18:55
*** e0ne has joined #openstack-cinder18:55
jgriffithso goes release weeks :)18:55
dulekjgriffith: Thank you for bringing this up to release management meeting. If that's the outcome we need to accept it.18:56
jgriffithdulek: unfortunately it's the right answer18:57
*** salv-orlando has quit IRC18:57
jgriffithdulek: BUT I promise you, if I can get anybody to listen I will propose this gets DONE finally in the first weeks of M18:57
kmartinjgriffith, did you buy your tickets yet for burning man next year? :)18:57
jgriffithdulek: it should've have some coordination help to begin with18:58
jgriffithkmartin: LOL.. burning man... no thanks!18:58
jgriffithkmartin: I've been to Black-Rock, have no idea why anybody would want to spend a week in August there18:58
dulekjgriffith, thangp_: That would be great, coordination would be helpful, patches are constantly getting into merge conflicts.18:58
jgriffithit's miserable18:58
mriedemjgriffith: hemna_: you want https://review.openstack.org/#/c/193451/ in 0.4.0, got it18:58
* jgriffith just isn't Hipster18:58
thangp_dulek: at least we tried :-/18:58
jgriffithmriedem: yes please18:58
dulekjgriffith, thangp_: Probably we can also get that merged during the summit with few cores reviewing live.18:59
jungleboyjxyang: Just got a request to look at this:  https://review.openstack.org/#/c/195027  Has a +2 from you but seems like it falls into the 'missed the deadline' category.  Thoughts./18:59
hemna_mriedem, yes please18:59
thangp_jgriffith, dulek: the problem with volume obj is it is not very isolated...any minor change to rpc, manager, or api will force a rebase19:00
*** annegent_ has joined #openstack-cinder19:00
*** angela-s has joined #openstack-cinder19:00
thangp_jgriffith: what about https://review.openstack.org/218361?19:00
*** lpetrut has joined #openstack-cinder19:00
thangp_jgriffith: that patch is pretty isolated19:00
*** Apoorva has quit IRC19:01
dulekthangp_, jgriffith: Oh, right, this one cannot possibly hurt us.19:01
jgriffiththangp_: I'm fine with that one... lemme review it right now19:02
thangp_jgriffith: thanks!19:02
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: Disable generic image cache for 3PAR drivers  https://review.openstack.org/21940619:02
*** changbl has quit IRC19:02
*** annegentle has quit IRC19:03
*** marcusvrn_ has joined #openstack-cinder19:03
hemna_jgriffith, patrickeast ^^ that's the temporary 'fix' for the 3PAR drivers.19:03
hemna_so if I can't get a workaround to work, then at least that's in there.19:03
hemna_not idea, but it's our problem.19:03
jgriffithhemna_: so you want to come up with something else for L though right?19:04
*** Apoorva has joined #openstack-cinder19:04
hemna_yah I'd like to19:04
hemna_I have to hack around and see if I can get something workable19:04
jgriffithhemna_: I'm fine if you want to wait on the interim here?19:04
*** afazekas has quit IRC19:04
jgriffithhemna_: in other words I don't feel that this needs to land until RC gets cut19:05
hemna_ok fine w/ me19:05
jgriffithhemna_: but it's up to you and what you prefer19:05
hemna_we can always abandon it19:05
hemna_sounds like a good plan, thanks19:05
jgriffithok, let's leave it up for now and figure it out tomorrow19:05
*** salv-orlando has joined #openstack-cinder19:06
mtaninojgriffith: jbernard I think this was merged/Implemented on this morning. https://blueprints.launchpad.net/cinder/+spec/generic-volume-migration19:06
hemna_jgriffith, ok so are we good with +A'ing https://review.openstack.org/#/c/195795/ ?19:06
jbernardmtanino: yes, it did merge19:06
jgriffithhemna_: sure... what could go wrong :)19:06
mtaninojbernard: can you change the BP's status to implemented?19:07
jgriffithmtanino: doing it now19:07
mtaninojgriffith: thank you :)19:07
hemna_ok, everyone can blame me :)19:07
*** esker has joined #openstack-cinder19:07
*** martyturner has joined #openstack-cinder19:07
mtaninopatrickeast: congrat!19:08
patrickeasthemna_: jgriffith: thanks! its probably going to be great19:08
*** annegent_ has quit IRC19:08
jgriffithpatrickeast: Whaaaa!  "probably" ???????19:08
* jgriffith grabs the revert button19:08
*** dims has joined #openstack-cinder19:09
* hemna_ hides19:09
openstackgerritJohn Griffith proposed openstack/cinder: Calculate virtual free capacity and notify  https://review.openstack.org/20692319:11
*** annegentle has joined #openstack-cinder19:11
*** krtaylor has quit IRC19:11
jgriffithhemna_: https://review.openstack.org/#/c/207020/19:12
jgriffithhemna_: ^^ I think that's ok (using the bp, not a bug)19:12
jgriffithhemna_: you ok with that?19:13
hemna_yah I think it's fine19:13
jgriffithhemna_: in other words, since it's tied to the BP19:13
jgriffithok... cool19:13
*** dims has quit IRC19:13
jgriffithI'm a +2/A19:13
hemna_I just didn't know how strict we were being with BPs vs. bugs after the 'freeze'19:13
jgriffithhemna_: yeah... good call19:13
jgriffithhemna_: but this was higher prio and never removed19:13
jgriffithhemna_: so it was "ok" as was19:14
*** julim has quit IRC19:14
jgriffithhemna_: thank ya sir19:14
hemna_ok lunch...bbiab19:15
*** hemna_ is now known as hemnafk19:15
*** dims has joined #openstack-cinder19:18
*** krtaylor has joined #openstack-cinder19:21
thrawn01smcginnis_afk: Do you think this bug is a red hering, and we should scuttle it? Because there are a list of other bugs that I would rather work on (referencing: https://bugs.launchpad.net/cinder/+bug/1415241)19:22
openstackLaunchpad bug 1415241 in Cinder "cinder hacking checks don't cover logging format string arg count" [Undecided,New] - Assigned to Scott DAngelo (scott-dangelo)19:22
thrawn01scottda: ^^19:22
e0nedo we allow patches like 'Port something to Python 3' after L-3?19:23
*** dims has quit IRC19:25
jgriffithe0ne: nope19:25
jgriffithe0ne: and technically we shouldn't be doing them now either19:25
*** lpetrut has quit IRC19:25
jgriffithe0ne: we're *supposed* to be in release mode; only things that are targeted19:26
e0neone more maybe stupid question19:26
jgriffithe0ne: after we go in to RC it's supposed to be bug fixes only19:26
* e0ne didn't find answet in the histiry19:26
jgriffithe0ne: sure... no stupid questions :)19:26
simondodsleyjgriffiths: I'm sure I could come up with one :)19:27
e0neyesterday's proplem with failing unit tests and '(Pulled from gate, cinder can no longer pass unit tests)' string in a commit messages. what is it?19:27
jgriffithsimondodsley: :)19:27
jgriffithe0ne: so just what it sounds like... something changed such that any cinder change that went into the verify gate would fail19:28
jgriffithe0ne: we got a patch for it, but until it landed/merged nothing would pass19:28
jgriffithe0ne: openssl change somehow19:28
e0nejgriffith: so, is this comment sill needed?19:28
jgriffithe0ne: nope19:28
e0nejgriffith: got it, thank you for help!19:29
jgriffithit's now meaningless, except for tracking to put approvals back on items that we bumped for it19:29
jgriffithe0ne: in other words, anything with that comment should get a free +2/A now19:29
e0nefree +2/A! great!19:29
xyangjgriffith: can I get a free +2/A on this one that was pulled from the gate? :)  https://review.openstack.org/#/c/218421/19:30
jgriffithxyang: and for those that aren't paying attention I guess it''s "you snooze, you loose"19:31
xyangjgriffith: :)19:31
*** martyturner has quit IRC19:32
xyangjgriffith, jungleboyj: should -2 be removed from this one?  https://review.openstack.org/#/c/206923/19:32
*** krtaylor has quit IRC19:34
*** jungleboyj has quit IRC19:34
*** bill_az has quit IRC19:34
*** hakimo has quit IRC19:34
*** jwcroppe has quit IRC19:34
*** lifeless has quit IRC19:34
*** tobasco_ has quit IRC19:34
*** rmstar has quit IRC19:34
*** mtreinish has quit IRC19:34
*** harlowja has quit IRC19:34
*** xiaohui has quit IRC19:34
*** goodygum has quit IRC19:34
*** whydidyoustealmy has quit IRC19:34
*** IanGovett has quit IRC19:34
*** sdague has quit IRC19:34
*** dobson has quit IRC19:34
*** martyturner has joined #openstack-cinder19:34
*** mriedem is now known as mattykins19:34
*** IanGovett has joined #openstack-cinder19:34
*** sdague has joined #openstack-cinder19:34
*** dobson has joined #openstack-cinder19:34
*** rushil has joined #openstack-cinder19:35
*** krtaylor has joined #openstack-cinder19:35
*** jungleboyj has joined #openstack-cinder19:35
*** bill_az has joined #openstack-cinder19:35
*** hakimo has joined #openstack-cinder19:35
*** jwcroppe has joined #openstack-cinder19:35
*** lifeless has joined #openstack-cinder19:35
*** tobasco_ has joined #openstack-cinder19:35
*** rmstar has joined #openstack-cinder19:35
*** mtreinish has joined #openstack-cinder19:35
*** xiaohui has joined #openstack-cinder19:35
*** goodygum has joined #openstack-cinder19:35
*** whydidyoustealmy has joined #openstack-cinder19:35
*** harlowja has joined #openstack-cinder19:35
*** whydidyoustealmy has quit IRC19:35
*** harlowja has quit IRC19:35
*** harlowja has joined #openstack-cinder19:35
*** dannywilson has joined #openstack-cinder19:35
*** dims has joined #openstack-cinder19:35
*** eharney has joined #openstack-cinder19:35
jgriffithxyang: could be but I'd likely downvote it anyway19:36
*** whydidyoustealmy has joined #openstack-cinder19:36
jgriffithxyang: I'm not sure i understand how/why that was approved as medium priority19:36
xyangjgriffith: I don't know.  any non-driver feature gets at least medium priority probably19:37
xyangjgriffith: you don't like this feature or just think it is not as important?19:38
jgriffithcould be :)19:38
jgriffithlittle of both19:38
jgriffithbut I'm not sure about the implementation19:38
jgriffithI need to look at it a bit closer19:39
xyangjgriffith: ok19:39
xyangjgriffith: seems to be a useful feature to me.  so that you can find out how much capacity you have19:40
jgriffithxyang: what if you share your cluster across multiple clouds?19:43
jgriffithxyang: or perish the though... an OpenStack deployment AND and ESX deployment :)19:43
*** erlon has joined #openstack-cinder19:44
xyangjgriffith: you mean how do you show capacity when you share your storage with non-openstack deployment?19:44
xyangjgriffith: this is just calling the existing get_pools API19:44
*** prometheanfire has joined #openstack-cinder19:45
jgriffithxyang: ahh... wait, yeah, it's pool based more than anything else19:45
xyangjgriffith: ya19:45
*** prometheanfire has left #openstack-cinder19:45
xyangjgriffith: it is just an aggregation of what we already have19:45
jgriffithxyang: got it19:45
jgriffithI'll look at it.  Needs others to review it though :)19:46
xyangjgriffith: ya, I think gorka should take a look19:46
xyangjgriffith: the latest patch set was to addressing his comments19:47
*** mattykins is now known as mriedem19:47
*** harlowja has quit IRC19:47
*** rushil has quit IRC19:47
*** krtaylor has quit IRC19:47
*** jungleboyj has quit IRC19:47
*** bill_az has quit IRC19:47
*** hakimo has quit IRC19:47
*** jwcroppe has quit IRC19:47
*** lifeless has quit IRC19:47
*** tobasco_ has quit IRC19:47
*** rmstar has quit IRC19:47
*** mtreinish has quit IRC19:47
*** xiaohui has quit IRC19:47
*** goodygum has quit IRC19:47
scottdathrawn01: If you'd rather work on some other bug, then go for it...19:50
scottdaI'm not sure what you mean by 'scuttle 1415241'19:50
thrawn01scottda: I want to close bugs, if this is not a useful bug, then it should be closed.19:50
scottdaWell, DuncanT filed that bug, so you'd have to ask him about closing the bug.19:51
scottdaIt may be a useful bug that should stay open. But there's no need for you to work on it if you don't want to.19:51
tbarronpatrickeast: need to reverify https://review.openstack.org/#/c/195795/  - gate-tempest-dsvm-neutron full failed with "echo 'ERROR: the main setup script run by this job failed - exit code: 137'"19:51
*** harlowja has joined #openstack-cinder19:52
*** rushil has joined #openstack-cinder19:52
*** krtaylor has joined #openstack-cinder19:52
*** jungleboyj has joined #openstack-cinder19:52
*** bill_az has joined #openstack-cinder19:52
*** hakimo has joined #openstack-cinder19:52
*** jwcroppe has joined #openstack-cinder19:52
*** lifeless has joined #openstack-cinder19:52
*** tobasco_ has joined #openstack-cinder19:52
*** rmstar has joined #openstack-cinder19:52
*** mtreinish has joined #openstack-cinder19:52
*** xiaohui has joined #openstack-cinder19:52
*** goodygum has joined #openstack-cinder19:52
*** simondodsley has quit IRC19:52
thrawn01scottda: that is the question I'm asking, is it useful? can it be done? smcginnis_afk seams to think it's impossible, if so... then close it.19:53
*** sgotliv has joined #openstack-cinder19:54
*** e0ne has quit IRC19:54
*** e0ne has joined #openstack-cinder19:55
*** ociuhandu has quit IRC19:55
thrawn01I'm still gonna attempt it, it looks like it might be possible to accomplish via a pylint AST check, but docs are not clear on how to implement a custom checker.19:55
thrawn01smcginnis_afk: seams to think it should instead be a flake8 plugin, which, I've not looked at, I will today tho.19:56
thrawn01but yeah, closing bugs/issues is my goal.19:57
thrawn01I've got a few of the issues I'm targeting in the next few weeks19:57
thrawn01I was hoping this would be a low hanging fruit issue, but it's apparently not quite a low as I thought.19:58
*** julim has joined #openstack-cinder19:58
scottdayes, probably not low hanging fruit19:58
mriedemjgriffith: hemnafk: updated https://review.openstack.org/#/c/219013/19:59
*** boris-42 has quit IRC20:00
*** krtaylor has quit IRC20:01
*** krtaylor has joined #openstack-cinder20:02
*** hemnafk is now known as hemna20:03
*** p0rtal has quit IRC20:05
*** porrua has quit IRC20:06
jgriffithjungleboyj: any thoughts on this turkey: https://bugs.launchpad.net/cinder/+bug/146539320:08
openstackLaunchpad bug 1465393 in Cinder "db migration shouldn't rely on CONF option or set values in row" [Undecided,In progress] - Assigned to Rakesh Mishra (mishra-rakesh510)20:08
jgriffithjungleboyj: I'm looking at a new migration that clears the setting20:09
*** ociuhandu has joined #openstack-cinder20:09
jgriffithjungleboyj: but wondering if you might have a better suggestion20:09
jgriffithmriedem: thanks much!20:10
jgriffithjungleboyj: but what I don't quite see is "how" we ever upgrade this :(20:11
jgriffithjungleboyj: in other words, you appear to be "stuck" with whatever you had set at deploy time ?20:12
jgriffithboooo... hisssss20:12
*** mudassirlatif has joined #openstack-cinder20:14
*** gouthamr has quit IRC20:14
*** gouthamr has joined #openstack-cinder20:14
*** eharney has quit IRC20:15
*** merooney has quit IRC20:16
SwansonAre the image volume cache options per backend or per cinder node?20:17
jungleboyjjgriffith: Jacob and I were just looking through that code trying to fix this.20:18
patrickeastSwanson: yes20:18
jungleboyjjgregor: ^^20:18
jgriffithjungleboyj: ahh... ok, so does that mean I shouldn't work on it ?20:18
patrickeastSwanson: you can scope them per backend or put them in the default section and all backends get them20:18
jgriffithjungleboyj: I was going to write a migration that just deletes the info in the column20:19
Swansonpatrickeast: Thanks!20:19
jgriffithjungleboyj: I'd prefer to go back and modify the migration that introduced it, but I don't remember if that's kosher20:19
jungleboyjjgriffith: No, we are working it.20:19
patrickeastthat reminds me i need to probably go write up documentation for it20:19
jungleboyjjgriffith: Since it is kind of my mess I created.  :-)20:19
jgriffithjungleboyj: ok... can you update the bug to reflect you are on it20:19
jgriffithjungleboyj: thanks!20:19
*** esker has quit IRC20:20
*** salv-orl_ has joined #openstack-cinder20:20
*** IanGovett has quit IRC20:21
jgriffithjungleboyj: BTW...don't forget you own this one currently as well: https://bugs.launchpad.net/cinder/+bug/138156320:21
openstackLaunchpad bug 1381563 in Cinder "cinder using obsolete oslo modules" [Medium,In progress] - Assigned to Jay Bryant (jsbryant)20:21
jgriffithjungleboyj: I tihnk it's dead, but let me know if I'm wrong20:22
jungleboyjjgriffith: Updated.  Hopefully we can get something nailed down.  We have made progress figuring out what Nova is doing.  Trying to assimilate.20:22
*** timcl has quit IRC20:22
jgriffithjungleboyj: excellent20:22
*** eharney has joined #openstack-cinder20:22
jungleboyjThat bug is related to the config generator work that diablo_rojo is pinging me about in my other Window.  :-)20:23
jungleboyjjgriffith: Updated accordingly.20:23
diablo_rojojungleboyj: so now I am on the chopping block?20:24
jungleboyjJust a heads up that in Mitaka we are going to probably have oslo-incubator completely going away.  Once we are off the generator we are close to being done with oslo-incubator and I have that on our work list for Mitaka.20:24
*** salv-orlando has quit IRC20:24
* jungleboyj said nothing about chopping blocks 20:25
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access  https://review.openstack.org/21923120:25
*** xyang has quit IRC20:26
*** p0rtal has joined #openstack-cinder20:27
*** julim has quit IRC20:29
*** bill_az has quit IRC20:30
*** p0rtal has quit IRC20:31
*** dperaza has joined #openstack-cinder20:34
*** p0rtal has joined #openstack-cinder20:34
*** dperaza has left #openstack-cinder20:35
*** sgotliv has quit IRC20:35
*** p0rtal_ has joined #openstack-cinder20:36
*** dustins has quit IRC20:37
*** p0rtal has quit IRC20:39
*** julim has joined #openstack-cinder20:42
*** Lee1092 has quit IRC20:43
*** p0rtal has joined #openstack-cinder20:43
*** bswartz has quit IRC20:44
*** p0rtal_ has quit IRC20:47
*** Apoorva has quit IRC20:50
* tbarron is going to driver home. Will check backlog here and continue reviewing in an hour or so.20:52
*** Apoorva has joined #openstack-cinder20:52
tbarrondrive home, LOL20:53
*** earlephilhower has quit IRC20:55
tpsilvaWe're having a problem with our HDS HNAS driver. oslo_concurrency.processutils logs every command that we run, so the HNAS password comes as plain text in the log. Is there anyway that we can avoid that? I checked the execute implementation, and it already uses mask_password, but since our command does not use the format that this function expects, it does not mask our password.20:55
*** rmetcalf has quit IRC20:56
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Remove empty rules from policies for API access  https://review.openstack.org/21923120:57
Swansontbarron: "driver" works if you read that with a JFK accent.21:02
*** raildo is now known as raildo-afk21:02
*** changbl has joined #openstack-cinder21:02
*** jungleboyj has quit IRC21:02
*** crose has quit IRC21:05
*** thangp_ has quit IRC21:07
*** lcurtis_ has joined #openstack-cinder21:08
*** changbl has quit IRC21:09
*** changbl has joined #openstack-cinder21:13
e0nejgriffith: only if you'll get a time. i really appreciate your opinion and woul like to take a look on https://review.openstack.org/#/c/217857/ (not my patch) to be sure that we are on the same page21:14
*** e0ne has quit IRC21:15
*** e0ne has joined #openstack-cinder21:16
*** rushil has quit IRC21:20
*** akerr has quit IRC21:20
*** yrabl has quit IRC21:21
mtaninohttps://review.openstack.org/#/c/215847/ was +A'd but I can't see this ID on the gate queue list... what is this...21:21
jgriffithmtanino: that's why I re-voted with the "kick" comment :)21:22
jgriffithe0ne: looking now21:22
mtaninojgriffith: yes. I saw it. Does the kick do someting?21:23
e0nejgriffith: thanks! i know that you're very busy these days21:23
jgriffithe0ne: aren't those pot files supposed to be auto-updated?21:24
e0nejgriffith: tbh, i'm not sure21:24
jgriffithmtanino: no, kick doesn't do anything really.... Just me putting a comment in there :)21:24
*** julim has quit IRC21:25
e0nejgriffith: i'm not sure that it is a right way to fix the bug21:25
mtaninojgriffith: I see. may be I need to try reverify21:25
jgriffithyea, try it :)21:26
jgriffithe0ne: you have an alternate idea?21:26
jgriffithe0ne: having a configurable fall-back seems "ok"21:26
jgriffithnot ideal, but "ok"21:27
e0nejgriffith: move validation to scheduler and use AZ filter. but it requires more changes21:27
e0nejgriffith: i'm worry about new config option that looks like a hack and will be deprecated in Mitaka21:27
jgriffithe0ne: I wonder if it's worth moving forward with this approach as an interim solution21:27
jgriffithe0ne: yeah... it's ugly21:28
*** yrabl has joined #openstack-cinder21:28
jgriffithe0ne: so you're thinking actually report AZ's up to scheduler from the driver and use that?21:28
*** jgregor has quit IRC21:29
e0nejgriffith: from driver? it's a create flow before c-vol starts work on it21:29
jgriffithe0ne: yeah, but you mentioned scheduler, so I assumed you meant filtering out valid AZ's from the backend21:30
jgriffithe0ne: in other words, postpone the AZ check to the scheduler21:30
jgriffithe0ne: let the scheduler figure out how/where to place21:30
e0nejgriffith: yes. now we check in in the API21:30
*** jungleboyj has joined #openstack-cinder21:30
jgriffithe0ne: then you could have things like "driver.conf.valid_availability_zones=[a, b, c....]"21:30
jgriffithe0ne: I don't know if that actually works though :(21:31
e0nejgriffith: oh, no21:31
e0nejgriffith: i mean if we'll check AZ in scheduler with AZ filter, we could just disable AZ filter21:31
e0nejgriffith: no changes to drivers or c-vol are needed21:32
jgriffithe0ne: ahh.. interesting21:32
jgriffithe0ne: ok... so I think that would work nicely21:33
jgriffithe0ne: I'd propose we go with something like what's proposed (unless you want to code up your solution tonight and not sleep) :)21:33
e0nejgriffith: :)21:33
jgriffithe0ne: either that or go with what's there (minus the pot files) and update in M21:34
e0nejgriffith: ok.. I will sync with dulek tomorrow. maybe he already tried my proposal with scheduler21:34
jgriffithe0ne: ok, sounds good21:34
e0nejgriffith: and I won't block this patch21:34
jgriffithe0ne: please keep me posted21:34
e0nejgriffith: sure. thank you for advise21:34
* e0ne bb in ~12 hours21:36
jgriffithe0ne: sleep well :)21:36
duleke0ne, jgriffith: I've already tried this solution. It basically means reverting a harlowja's commit, let me find it...21:37
e0nejgriffith: I will try:)21:37
jgriffithdulek: oh well... it's just harlowja :)21:37
e0nedulek: oh.. do you mean moving to taskflow commit?21:37
dulekjgriffith, e0ne: https://review.openstack.org/#/c/98924/21:38
dulekjgriffith, e0ne: Thing is if we want to move validation to scheduler we're changing how API behaves - user won't get notice if he provided wrong AZ.21:39
*** lprice has quit IRC21:40
jgriffithdulek: well, I think the idea is if you use an AZ filter you could get either or21:40
jgriffithdulek: if the filter is enabled you fail21:40
jgriffithdulek: if you explicitly disable it, that means you don't care21:40
jgriffithdulek: it's really the same thing that's proposed.... just does it in scheduler21:41
jgriffithdulek: see what I mean?21:41
e0nedulek: we've got a lot of async errors in scheduler and manager which is not reported to user:(. but I agree that we need to fix it21:41
jgriffithdulek: and I'm not sure it's better or worse, just saying it's different ;)21:41
dulekjgriffith: Yes, that's fine. My only concern is that this will fail on a scheduler level. So user won't be able to know that he made a mistake in AZ name.21:41
e0nedulek, jgriffith: a very valid concern21:42
jgriffithmtanino: that's weird, it got booted back to check21:42
jgriffithdulek: true21:42
jgriffithdulek: and people hate that21:42
mtaninojgriffith: Sorry, are there any good way?...21:43
jgriffithmtanino: not your fault...21:43
dulekjgriffith, e0ne: So from my perspective it's better to live with deprecation of an option than to break API contract.21:43
jgriffithmtanino: we'll just wait then give it another +2/A when it finishes if it doesn't go automatically :)21:43
dulekjgriffith, e0ne: (even tough I don't think someone relies in their script on API AZ validation ;))21:44
jgriffithdulek: yeah.... I'm looking at the code again; I think that the proposed change is good enough for now21:44
jgriffithdulek: minus the pot files :)21:44
jgriffithdulek: it solves the problem, we can deal with a better solution; even have them coexist if we have to IMO21:44
dulekjgriffith: I wasn't sure about the pot files either, commit author was over-diligent. ;)21:45
e0nedulek, jgriffith: you convinced me that this patch is good enough for L21:45
mtaninojgriffith: I see. I will keep watching it.21:45
jgriffithe0ne: :)  Now you can sleep easy :)21:45
jgriffithdulek: Yeah, I've never seen anybody update those on their own... kudos to comitter for that :)21:45
jgriffithdulek: no remove them :)21:45
*** mriedem is now known as mriedem_away21:46
dulekjgriffith, e0ne: Okay, thank you for your opinions guys.21:46
*** lcurtis_ has quit IRC21:47
* dulek gets back to writing his thesis. No sleeping yet...21:47
jgriffiththanks e0ne and dulek ... dulek let me know how your thesis turns out and if it's published so I can read it :)21:48
*** annegentle has quit IRC21:48
dulekjgriffith: Fortunately it's in English, but if you're not into hardcore graph algorithmics you won't enjoy it. ;)21:49
jgriffithdulek: haha!21:50
hemnapatrickeast, ping21:51
patrickeasthemna: hey21:51
hemnalooks like jenkins frowned on the merge21:51
patrickeastyea I saw the first failure, jgriffith put a reverify on it, last I saw it was in the long line for checking21:53
patrickeastfrom the zuul status page it looks like its doing better this time around21:55
SwansonIt has pretty much passed.  Only one left is non-voting.21:55
*** xyang has joined #openstack-cinder21:57
*** changbl has quit IRC21:57
harlowjajgriffith dulek what i do?21:58
harlowjait was all jgriffith fault, he made me do it21:58
harlowjawhatever it is21:58
jgriffithharlowja: :)21:58
*** xyang has quit IRC21:59
dulekharlowja: You did a good thing, just Nova guys screwed it up. ;)21:59
harlowjaphew, lol21:59
*** leeantho has quit IRC22:01
*** p0rtal_ has joined #openstack-cinder22:04
*** tpsilva has quit IRC22:05
*** p0rtal has quit IRC22:07
*** e0ne has quit IRC22:10
tbarronSwanson: I talk like a Texan who lived in the Twin Cities for 10 years so I can't sound like JFK.  Though people tell me I look a lot like him.22:13
* tbarron thinks Swanson and I have never actually seen one another22:13
*** e0ne has joined #openstack-cinder22:14
Swansontbarron: I haven't been to any of the openstack events so pretty unlikely.22:14
*** martyturner has quit IRC22:15
*** p0rtal has joined #openstack-cinder22:16
tbarronSwanson: are you going to Tokyo by any chance?22:16
*** p0rtal_ has quit IRC22:19
*** edmondsw has quit IRC22:28
*** earlephilhower has joined #openstack-cinder22:32
*** e0ne has quit IRC22:34
*** jaypipes has quit IRC22:40
*** annegentle has joined #openstack-cinder22:40
Swansontbarron: Nope.  smcginnis_afk is.22:42
*** alejandrito_ has joined #openstack-cinder22:43
tbarronSwanson: do you work with Walter Poxon and Chris Hertel?22:43
SwansonChris doesn't come to mind but Walter is in this facility.22:44
tbarronI work in a *facility* too :-)22:44
tbarronAnyways, Walter and Chris can tell you how much I look like JFK (not).22:44
*** alejandrito_ has quit IRC22:45
*** alejandrito has quit IRC22:45
*** asselin_ has quit IRC22:46
Roamer`thingee, hi, did you have a chance to look at the e-mails I sent about reactivating the StorPool CI?22:52
Roamer`oh, hmm, I just realized he's on vacation... well, whom should I contact about reactivating a CI that was turned off, we've fixed the problems, and we have like three weeks of success reports in silent mode now?22:54
*** angela-s has quit IRC22:55
mtaninojgriffith: https://review.openstack.org/#/c/215847/ didn't enter gate queue after finishing check. strange status :(22:56
*** boris-42 has joined #openstack-cinder22:57
*** edtubill has quit IRC22:57
hemnapatrickeast, ping22:59
*** lcurtis has quit IRC23:02
*** dims has quit IRC23:03
*** asselin has joined #openstack-cinder23:06
*** leeantho has joined #openstack-cinder23:07
patrickeasthemna: hola23:07
hemnakinda have my driver working23:08
hemnabut seeing something odd23:09
*** krotscheck has joined #openstack-cinder23:09
hemnapatrickeast, https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/hp/hp_3par_common.py#L157423:09
krotscheckIs there a list of custom HTTP headers that cinder uses? I'm assuming that X-Auth-Token is valid, but are there any others? X-Forwarded-For....23:09
hemnaso for whatever reason we are using volume['source_volid'] as the source volume id23:09
hemnaand that is None during creates from cache23:10
hemnaso it pukes23:10
patrickeasthmm thats odd23:10
hemnasrc_vref['id'] is what we want, and I'm not sure why we weren't using that23:11
hemnabut for whatever reason volume['source_volid'] = None23:11
jgriffithhemna: That's weird, I've never even noticed that column before23:12
* hemna scratches head23:12
jgriffithhemna: not sure what it means or is for, vs why you aren't just using ['id']23:13
hemnayah me either23:13
hemnafwiw, normal create volume from volume id works with that23:13
*** asselin has quit IRC23:14
hemnamust be a holdover from ages ago ?23:14
jgriffithhemna: not really https://github.com/openstack/cinder/commit/d99fb6011cc610b78d42891800189feed039174223:14
jgriffithhemna: it's a special reference for LVM that I did23:14
hemnathat j-griffith guy must know.....23:14
*** asselin has joined #openstack-cinder23:14
jgriffithhemna: so that column should be used on the "destination"23:14
jgriffithhemna: as a column that says "hey, I'm cloned from <source-volid>"23:15
*** ganso_ has quit IRC23:15
jgriffithhemna: that was partially for people that have linked clones23:15
jgriffithhemna: and required a tracking mechanism23:15
hemnaso it looks like it's None when create_cloned_volume is called from the cache23:15
tbarronintuitive :-)23:15
jgriffithhemna: I'm not sure how your driver could ever do a clone volume the way it is there?23:15
hemnamaybe because it's not the same project ?23:15
hemnainternal project user ?23:15
hemnait's worked! :P23:16
jgriffithhemna: lemme see...23:16
hemnaok I'll just file a bug against our crappy driver and fix it before I try and push my patch to fix the image cache clone work23:16
jgriffithtbarron: actually... "source-volume-id" does seem kind of intutive tome :)23:16
hemnait's probably my fault in our code23:16
tbarronjgriffith: well, if I turn my head 32 degrees to the left it does to me as well.  Need to visit CO more :)23:17
*** leeantho has quit IRC23:17
jgriffithhemna: ahhh.... I see23:17
hemnahah, it's kmartin's fault23:17
*** bkopilov has quit IRC23:17
tbarronjgriffith: I'm just messing with you, as if I haven't been enough of a PITA recently.23:17
jgriffithhemna: patrickeast so in taskflows execute on a normal "create from source" it fills that in23:18
*** chlong_ is now known as chlong23:18
jgriffithhemna: patrickeast it actually fetches the source_volid, populates the column23:18
*** bkopilov has joined #openstack-cinder23:18
jgriffithhemna: patrickeast and shoots it out as part of the vref in the request-spec23:18
openstackgerritMichael Krotscheck proposed openstack/cinder: Added CORS support to Cinder  https://review.openstack.org/21948923:19
patrickeasti suppose we should probably do that for the cache code too then for consistency23:19
hemnakmartin, https://goo.gl/OoQwpD23:19
hemnaback in the day23:19
jgriffithbut clone_image_volume and create_from_source_volume are "different"23:19
patrickeastyea i suppose23:19
patrickeastbut i guess the thing we pass into the driver could be consistent at least23:19
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/21544023:20
jgriffithpatrickeast: hemna well....23:20
patrickeastor we just call it a 3PARism and i wont worry about it >:D23:20
hemnaI'll post a patch against 3PAR23:20
hemnaand fixy there.23:20
jgriffithpatrickeast: hemna either way... but it's easy to fix... just change line 1574 to "src_vref['id']" and you never have to worry about it23:21
jgriffithhemna: :)23:21
hemnajgriffith, +123:21
jgriffithhemna: that's the safest thing IMO23:21
hemnafriggin 3PAR driver writers....23:21
*** mdbooth has quit IRC23:21
jgriffithjungleboyj: ping23:21
tbarronhemna: :) I can relate23:21
jungleboyjjgriffith: Pong.23:22
jgriffithjungleboyj: hey dude!23:22
jgriffithjungleboyj: so I started picking at the genconfig stuff23:22
jgriffithjungleboyj: thought I'd check and make sure you hadn't already done a chunk of it23:23
jgriffithjungleboyj: buiilding the opts files (or trying to) and adding the entry-points23:23
jungleboyjjgriffith: Dude, we have and have most of it done.23:23
* jgriffith wishes we didn't have opts declared in SO DAMN many places23:23
jgriffithjungleboyj: Oh// yipee!23:23
jgriffithjungleboyj: where?23:24
jungleboyjThat is what Kendall has been working on.23:24
jgriffithI can help23:24
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: Fix create_cloned_volume source volume id  https://review.openstack.org/21949823:24
jgriffithwe can finish it and get it done once and for all23:24
jungleboyjjgriffith: That would be awesome.23:24
*** dims__ has joined #openstack-cinder23:24
jungleboyjjgriffith: You want me to have her push up what she has in the morning so you two can collaborate?23:24
jgriffithThrow it on gitub, we can divide and conquer!23:24
jgriffithjungleboyj: yeah... that sounds good23:25
jgriffithjungleboyj: do you know how far along with the opt files and entry points she is?23:25
*** leeantho has joined #openstack-cinder23:25
kmartinhemna, that was back in the day, jgriffith review it :) CI must have of been broke that day23:25
jungleboyjjgriffith: Mostly done.  She has a good looking opt file, just something weird happening when she sends it to genconfig.23:25
jgriffithjungleboyj: ok, awesome!23:26
jgriffithjungleboyj: get it posted and I'll see if I can help23:26
jgriffithwe'll get that sucker merged and call it DONE23:26
jungleboyjIt is treating the output of list_opts like one big config option and we weren't sure why.  How are had you gotten?23:26
*** mdbooth has joined #openstack-cinder23:26
jgriffithjungleboyj: so I am almost done with the cinder.volume opts.py file23:27
jgriffithjungleboyj: have an entrypoint file and and config file23:27
jgriffithjungleboyj: but it's not usable yet23:27
jgriffithjungleboyj: I've been spending too much time trying to figure out how to auto-collect/generate the opts entries :(23:27
jungleboyjHe he, that she has done and working 90%.23:28
jungleboyjjgriffith: Just texted her, she will push up a WIP in the morning and ping you.23:28
* jgriffith grep >file && s/\./volume/import cinder.volume/ | s/\/\/\/ blah blahb alhba23:29
jgriffithjungleboyj: sweeet!23:29
jgriffithin that case I'm drinking beer!!!23:29
jgriffithjungleboyj: post it up, I'll see if I can help finish it off23:29
*** dannywil_ has joined #openstack-cinder23:30
jungleboyjMan, beer sounds good but not until after karate.  :-)23:30
jgriffithjungleboyj: BTW, I was associating it with this bug: https://bugs.launchpad.net/nova/+bug/143790423:30
openstackLaunchpad bug 1437904 in Cinder "generate_sample.sh uses MODULEPATH environment variable, conflicts with environment-modules" [Low,In progress] - Assigned to Mike Perez (thingee)23:30
jgriffithjungleboyj: which is why I started hacking on it23:30
jungleboyjOk.  I will send her that info.23:31
jgriffithjungleboyj: nahh... beers not really that good, you're not missing anything :)23:31
jungleboyjjgriffith: You are full of it!23:31
* jgriffith goes back to the kegarator to see if it's gotten better since the last pour23:31
jgriffithDon't know what they were thinking putting a kegarator in the office :)23:32
jgriffithtbarron: now would be a good time to be trying to recruit cores to review your patches BTW23:32
tbarronjgriffith: on it, and thanks for the cure23:33
jgriffithtbarron: actually, this morning would have been an even better time23:33
tbarronI meant to say cue but that might be a better word23:33
*** dannywilson has quit IRC23:33
tbarronjgriffith: yeah23:33
jungleboyjtbarron: Has been bribing me for the last couple hours.23:34
tbarronbelieve me, I've been a major PITA all around.23:34
tbarronyeah, I plan to buy drinks all around and charge NetApp, who owes me for this effort.23:34
mtaninojgriffith: https://review.openstack.org/#/c/215847/ seems this guy does not like gate queue...23:35
kmartintbarron, hemna is waiting for the review URL to click23:35
tbarronkmartin: hemna was spared so far b/c his computer had problems, but hemna please take a look at the Low prio section of https://etherpad.openstack.org/p/cinder-liberty-3-reviews23:36
openstackgerritJohn Griffith proposed openstack/cinder: ScaleIO driver should use os-brick connector  https://review.openstack.org/21442023:37
tbarronjungleboyj: jgriffith: and xyang: have been helping NetApp out a lot in that set of reviews, but there are still some that need attention.23:37
jgriffithmtanino: so strange... been a long time since I've seen this happen23:37
*** hodos has quit IRC23:38
tbarronhemna: and there are a couple of very nice changes from Pure there in the same boat23:38
jgriffithmtanino: we can ping infra and see if they can help; other option abandon it and submit a new one, we'll just push it through23:38
mtaninojgriffith: Do you know who is a apporpriate person in Infra?23:39
tbarronkmartin: you can get drinks on that round too, since you threw just threw hemna under the bus for me23:39
kmartintbarron, some have -1 for cores are ready are you fixing them https://review.openstack.org/#/c/215833/23:39
jgriffithmtanino: meet me over there, we'lljust ask23:39
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: Fix create_cloned_volume source volume id  https://review.openstack.org/21949823:39
tbarronkmartin: yeah, we have a patch ready to go up that addresses the refactor and exception change that e0ne requested.23:40
*** diogogmt has quit IRC23:40
mtaninojgriffith: thank you for your help.23:40
tbarronkmartin: I don't want to push it before the dependent changes merge before it, as we'll lose all the votes, etc.23:40
tbarronmake sense?23:40
jungleboyjtbarron: Ok, all your patches have been reviewed.23:40
kmartinI guess23:40
tbarronjungleboyj: awesome!23:41
tbarronkmartin: I'll do whatever experienced folks advise on that one.23:41
jungleboyjChecks can be made out to Jay S. Bryant.  ;-)23:41
kmartintbarron, seems that you would want to address -1 for cores ASAP23:41
tbarronkmartin: ok, I'll start the reverify on our internal CI to push that up.  Hopefully the patches it depends on will merge first or we can regain votes if they are lost.23:43
*** diogogmt has joined #openstack-cinder23:43
tbarronkmartin: e0ne won't look at that one for another 6-8 hours anyways :-)23:43
tbarronkmartin: assuming he sleeps better tonight than I will.23:43
*** salv-orlando has joined #openstack-cinder23:43
*** diogogmt has quit IRC23:45
jgriffithjungleboyj: LOL.. not a bad side biz ya got going23:45
jgriffithtbarron: what's the problem?23:45
tbarronjgriffith: what problem?23:46
tbarronjgriffith: oh, I see what you are asking.  We have a change,23:47
*** salv-orl_ has quit IRC23:47
tbarronjgriffith: https://review.openstack.org/#/c/215833/23:47
jungleboyjDinner time here.23:47
jgriffithtbarron: well, you need to fix the errors23:47
tbarronjgriffith: where e0ne has made some very good comments.  We have a patch that addresses them.23:47
tbarronI am pushing it up now.23:47
tbarronjgriffith: but I didn't see the pylint errors!!23:48
*** IanGovett has joined #openstack-cinder23:50
tbarronjgriffith: lemme make sure our new patch doesn't have that issue23:50
jgriffithtbarron: might be a good idea23:51
hemnaok I'm out, heading home.  I'll try and be online later for review help.23:51
jgriffithdoesn't matter who reviews your patches, if they don't pass gate you're not going to get them merged :)23:51
tbarrontrue that23:51
*** hemna is now known as hemnafk23:51
*** esker has joined #openstack-cinder23:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!