*** dflorea has joined #openstack-cinder | 00:01 | |
patrickeast | so uh, who do i have to bribe to get this https://review.openstack.org/#/c/213855 unstuck? | 00:01 |
---|---|---|
patrickeast | jungleboyj: still accepting checks? | 00:02 |
patrickeast | or perhaps fine Seattle beers? | 00:02 |
*** pots1 has joined #openstack-cinder | 00:07 | |
*** gouthamr has quit IRC | 00:09 | |
openstackgerrit | Tom Barron proposed openstack/cinder: NetApp E-Series over-subscription support https://review.openstack.org/215801 | 00:11 |
*** salv-orlando has quit IRC | 00:15 | |
*** dims__ has quit IRC | 00:16 | |
*** garthb has quit IRC | 00:17 | |
mtanino | jgriffith: just for your information(may be your are logging infra thread): | 00:18 |
-mtanino- 20:12 (fungi) jgriffith: mtanino: ahh, yep that's correct. cinder and cinderclient really don't share a change queue (they have no jobs in common with each other at all) | 00:18 | |
-mtanino- 20:12 (fungi) jgriffith: mtanino: so anyway, if you have a cinderclient change depends-on a cinder change (or vice versa) you need to wait to approve the second until the first merges | 00:18 | |
-mtanino- 20:13 (fungi) jgriffith: mtanino: now that 212861 has merged, if you remove and readd your approval workflow +1 vote on 215847 it should head into the gate | 00:18 | |
*** garthb has joined #openstack-cinder | 00:18 | |
*** garthb has quit IRC | 00:19 | |
*** garthb has joined #openstack-cinder | 00:19 | |
*** pots1 has quit IRC | 00:25 | |
*** Apoorva has quit IRC | 00:28 | |
*** gouthamr has joined #openstack-cinder | 00:29 | |
*** zhenguo has joined #openstack-cinder | 00:30 | |
*** dflorea has quit IRC | 00:31 | |
*** gouthamr_ has joined #openstack-cinder | 00:32 | |
*** gouthamr has quit IRC | 00:35 | |
*** sayali_ has joined #openstack-cinder | 00:37 | |
*** sayali_ has quit IRC | 00:37 | |
*** sayali_ has joined #openstack-cinder | 00:37 | |
tbarron | "Running pylint. Be patient..." you ain't kiddng. | 00:37 |
*** Roamer` has quit IRC | 00:37 | |
tbarron | of course there are 4 dependent change sets, am talking to our folks about whether all that is really necessary. | 00:37 |
tbarron | finally finished | 00:37 |
tbarron | jgriffith: this changeset has the same pylint errors. Thank you! | 00:37 |
*** sayali has quit IRC | 00:37 | |
mtanino | smcginnis_afk: ohhh!! Finally he enters gate queue. thank you | 00:38 |
*** diogogmt has joined #openstack-cinder | 00:39 | |
*** garthb has quit IRC | 00:39 | |
*** dannywil_ has quit IRC | 00:43 | |
*** dannywilson has joined #openstack-cinder | 00:43 | |
*** zhangjn has joined #openstack-cinder | 00:44 | |
*** dannywilson has quit IRC | 00:45 | |
*** akerr has joined #openstack-cinder | 00:47 | |
*** yrabl has quit IRC | 00:48 | |
*** yrabl has joined #openstack-cinder | 00:49 | |
*** xyang has joined #openstack-cinder | 00:50 | |
*** dims__ has joined #openstack-cinder | 00:51 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Adds command to fetch specified backend capabilities https://review.openstack.org/215847 | 00:51 |
mtanino | jgriffith: Should I push rebase? | 00:53 |
jgriffith | mtanino: yes please | 00:53 |
openstackgerrit | Mitsuhiro Tanino proposed openstack/python-cinderclient: Adds command to fetch specified backend capabilities https://review.openstack.org/215847 | 00:53 |
*** rhagarty_ has quit IRC | 00:53 | |
jgriffith | mtanino: I removed the depends message | 00:53 |
mtanino | jgriffith: I see. | 00:53 |
*** leeantho has quit IRC | 00:53 | |
jgriffith | mtanino: I'll add my +2/A after it finishes up check | 00:54 |
*** rhagarty_ has joined #openstack-cinder | 00:54 | |
openstackgerrit | Tom Barron proposed openstack/cinder: Scheduler-based over-subscription for NFS drivers https://review.openstack.org/216055 | 00:54 |
mtanino | jgriffith: Thank you for taking care of this many times :) | 00:54 |
*** dims__ has quit IRC | 00:56 | |
*** xyang1 has joined #openstack-cinder | 00:57 | |
*** sseverson has quit IRC | 00:58 | |
*** sseverson has joined #openstack-cinder | 00:59 | |
*** kaisers has quit IRC | 01:01 | |
*** kaisers has joined #openstack-cinder | 01:03 | |
*** r-daneel has quit IRC | 01:04 | |
*** kjelly has quit IRC | 01:07 | |
*** hemna has joined #openstack-cinder | 01:10 | |
anish | johnthetubaguy: can you close this bp https://blueprints.launchpad.net/nova/+spec/add-transport-support-to-iscsi | 01:13 |
anish | it was implemented ages ago | 01:13 |
*** mtanino has quit IRC | 01:13 | |
openstackgerrit | Tom Barron proposed openstack/cinder: Implement thin provisioning support for E-Series https://review.openstack.org/215833 | 01:25 |
*** haomaiwa_ has joined #openstack-cinder | 01:30 | |
*** lcurtis_ has joined #openstack-cinder | 01:36 | |
*** mudassirlatif has quit IRC | 01:39 | |
tbarron | ^^^ that's just the commit message change, still owe the real thing | 01:40 |
*** Lee1092 has joined #openstack-cinder | 01:42 | |
*** sam_wan has joined #openstack-cinder | 01:42 | |
*** diogogmt has quit IRC | 01:46 | |
*** diogogmt has joined #openstack-cinder | 01:48 | |
*** resker has joined #openstack-cinder | 01:48 | |
hemna | tbarron: ok I saw it | 01:48 |
hemna | that is a bit more clear thanks | 01:48 |
hemna | waiting on CI and jenkins | 01:48 |
tbarron | hemna: ty, I've got to get it put through our CI and approval with changes to address the remarks from xyang and e0ne. Will take a while :_ | 01:50 |
*** lyanchih has joined #openstack-cinder | 01:50 | |
*** simondodsley has joined #openstack-cinder | 01:50 | |
*** Yogi1 has joined #openstack-cinder | 01:51 | |
*** esker has quit IRC | 01:52 | |
*** Yogi11 has joined #openstack-cinder | 01:53 | |
*** simondodsley has quit IRC | 01:55 | |
*** Yogi1 has quit IRC | 01:56 | |
*** zhangjn_ has joined #openstack-cinder | 01:57 | |
*** zhangjn has quit IRC | 01:58 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Fix create_cloned_volume source volume id https://review.openstack.org/219498 | 02:05 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Cloudbyte fix create_cloned_volume parent id https://review.openstack.org/219531 | 02:12 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: 3PAR Fix create_cloned_volume source volume id https://review.openstack.org/219498 | 02:14 |
hemna | had to update the title | 02:14 |
hemna | bleh | 02:14 |
*** Yogi11 has quit IRC | 02:15 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: DotHill driver fix create_cloned_volume parent id https://review.openstack.org/219534 | 02:22 |
anish | hemna: ping | 02:25 |
hemna | sup | 02:25 |
anish | this is caught in the cracks https://blueprints.launchpad.net/nova/+spec/add-transport-support-to-iscsi | 02:26 |
anish | can you close the bp ? was implemented ages ago | 02:26 |
hemna | anish, it’s a nova BP. I can’t close it :( | 02:26 |
anish | ah my bad, I kept thinking cinder | 02:27 |
hemna | :) | 02:27 |
hemna | sorry about that, or I would | 02:27 |
*** salv-orlando has joined #openstack-cinder | 02:27 | |
anish | no worries ! | 02:27 |
*** BharatK has joined #openstack-cinder | 02:28 | |
anish | does os-brick have a TODO list btw ? | 02:28 |
*** xyang has quit IRC | 02:30 | |
*** hw_chenying has joined #openstack-cinder | 02:30 | |
*** salv-orlando has quit IRC | 02:32 | |
*** leizhang has joined #openstack-cinder | 02:34 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 02:36 |
*** resker has quit IRC | 02:41 | |
*** annegentle has quit IRC | 02:41 | |
*** annegentle has joined #openstack-cinder | 02:43 | |
*** xyang has joined #openstack-cinder | 02:44 | |
*** hakimo_ has joined #openstack-cinder | 02:52 | |
*** hemna has quit IRC | 02:54 | |
*** hakimo has quit IRC | 02:54 | |
*** leizhang has quit IRC | 02:55 | |
*** annegentle has quit IRC | 02:57 | |
*** xyang has quit IRC | 03:00 | |
*** changbl has joined #openstack-cinder | 03:03 | |
*** hemna has joined #openstack-cinder | 03:03 | |
hemna | anish: I don’t think it currently does | 03:03 |
hemna | I want to refactor some of the iSCSI code | 03:03 |
hemna | to share the same multipath lookup code that the FC connector uses | 03:03 |
hemna | that was next on my list | 03:03 |
hemna | I also have to fix this one up: https://review.openstack.org/#/c/199764/ | 03:04 |
*** akerr has quit IRC | 03:09 | |
*** gouthamr has joined #openstack-cinder | 03:13 | |
*** gouthamr_ has quit IRC | 03:16 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: 3PAR Disable generic image volume cache https://review.openstack.org/219406 | 03:17 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 03:17 |
hemna | crap | 03:17 |
patrickeast | haha | 03:18 |
patrickeast | was there any actual change to it? | 03:18 |
hemna | fack! | 03:18 |
hemna | damnit beavis | 03:18 |
patrickeast | looks like just rebase maybe? | 03:18 |
hemna | I rebased my patch against master | 03:18 |
patrickeast | just +A it again | 03:18 |
hemna | friggin git deps are a pain | 03:19 |
patrickeast | haha yea | 03:19 |
hemna | does it look ok? | 03:19 |
patrickeast | yea i mean the diff between the last two doesn't even touch any of the files in the actual change | 03:19 |
patrickeast | so prolly fine | 03:19 |
hemna | ok I’ll +A it again | 03:20 |
hemna | sorry man. | 03:20 |
hemna | dumbass | 03:21 |
patrickeast | no worries | 03:21 |
hemna | maybe the rebase will help the reverify issue it was having | 03:21 |
hemna | at least I’ll tell myself that…. | 03:21 |
patrickeast | lol | 03:22 |
hemna | patrickeast: fwiw, I fixed a few other drivers using volume[‘source_volid’] in create_cloned_volume | 03:23 |
hemna | so it should help their drivers work with the image cache stuff | 03:23 |
patrickeast | oh nice | 03:23 |
hemna | dothill CloudByte were both doing the same thing | 03:23 |
patrickeast | image cache making things faster *and* finding weird bugs in drivers | 03:23 |
patrickeast | win-win amiright? | 03:23 |
hemna | w00t! | 03:23 |
hemna | winning! | 03:24 |
hemna | maybe we should submit other patches that just drop volume object keys! | 03:24 |
hemna | see how many other drivers we can break. | 03:24 |
hemna | yah baby! | 03:24 |
patrickeast | best way to figure out if they are actually needed | 03:24 |
hemna | :) | 03:24 |
patrickeast | could probably automate the process | 03:24 |
hemna | just start dropping db columns in a patch, and let jenkins test it for us. | 03:25 |
hemna | submit a patch per column. | 03:25 |
patrickeast | yea i mean if it passes jenkins, its good to go | 03:25 |
hemna | it’s not like the build boxes are busy | 03:25 |
patrickeast | could do the same for requirements | 03:25 |
patrickeast | just rake over cinder until everything is optimized | 03:25 |
hemna | yah! | 03:25 |
hemna | cinder db, 1 table and 1 column | 03:26 |
hemna | ship it!! | 03:26 |
patrickeast | lol | 03:26 |
patrickeast | so uh, can someone verify something... for this model update, we end up giving a dict to the db.volume_update() with a {'model': {...}} | 03:28 |
patrickeast | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L3106 | 03:28 |
*** haomaiwa_ has quit IRC | 03:28 | |
patrickeast | doesnt the model need to be the thing passed in to volume_update? | 03:28 |
*** haomaiwang has joined #openstack-cinder | 03:29 | |
patrickeast | jgriffith: ^ maybe of interest to you | 03:29 |
hemna | patrickeast: we do model updates elsewhere no? | 03:31 |
patrickeast | hemna: yea but this one if the driver returns something like {'provider_whatever':'foo'} | 03:32 |
patrickeast | we then turn around and call the db method with an update like {'model':{'provider_whatever':'foo'}} | 03:32 |
patrickeast | i think other places we just pass that model update directly into the db api method | 03:32 |
* patrickeast needs to go read through what actually happens in db.volume_update() | 03:33 | |
hemna | hrmm | 03:33 |
hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L3076 | 03:33 |
hemna | it’s just a comment, but makes me go…hrmm. | 03:33 |
*** esker has joined #openstack-cinder | 03:35 | |
jgriffith | patrickeast: that's a bug | 03:35 |
patrickeast | jgriffith: ok cool, im thinking that line 3106 should look more like 'update = model_update' | 03:36 |
patrickeast | then we just put the other fields onto it, glom them all together, and do the volume_update call | 03:36 |
jgriffith | patrickeast: could.... but better answer is to rework that whole section and pass everything in a single update | 03:37 |
jgriffith | patrickeast: yes, for the most part "what you said" | 03:37 |
patrickeast | jgriffith: ah yea, just have the driver return a model_update and thats it | 03:37 |
jgriffith | patrickeast: I'll submit a fix tomorrow morning | 03:37 |
jungleboyj | patrickeast: Sorrry, was at Karate class. | 03:37 |
jgriffith | thanks for pointing it out, I actually knew it was borked, just never fixed it :( | 03:37 |
jungleboyj | patrickeast: Let me look. | 03:37 |
jgriffith | hemna: and yes... you're correct | 03:38 |
jgriffith | hemna: model_update is actually a dict | 03:38 |
patrickeast | jgriffith: np, i'm trying to actually iron out some stuff with our v2 replication patch... the scary part is that wasn't causing a big problem... just some subtle side effects | 03:38 |
hemna | ok cool | 03:38 |
hemna | patrickeast: nice find | 03:38 |
*** gouthamr has quit IRC | 03:38 | |
patrickeast | jungleboyj: no worries, thanks for taking a look! | 03:38 |
jgriffith | hemna: {provider_info:xxx, ....} | 03:39 |
jungleboyj | Welcome. | 03:39 |
jgriffith | patrickeast: hemna same way we return that stuff on "create volume" | 03:39 |
*** esker has quit IRC | 03:40 | |
patrickeast | yea that makes sense | 03:40 |
hemna | jgriffith: yah that’s what I had thought. | 03:40 |
hemna | coolio | 03:40 |
*** salv-orlando has joined #openstack-cinder | 03:41 | |
jgriffith | hemna: ouch! https://review.openstack.org/#/c/216055/ | 03:42 |
hemna | yah I don’t know what the hell happened there | 03:43 |
hemna | the logs look…suspect | 03:43 |
jgriffith | unrelated, but suspect that both Pure and HP failed :( | 03:43 |
hemna | i’ve never seen our CI poop out that quick before | 03:43 |
jgriffith | You guys have recheck implemented? | 03:43 |
hemna | yah supposed to :) | 03:43 |
jgriffith | LOL | 03:43 |
hemna | where is that asselin guy? | 03:44 |
hemna | :P | 03:44 |
jgriffith | I'll leave that patch alone til recheck goes on it, even though it should be PERFECTLY isolated | 03:44 |
patrickeast | ew yea, that got one of the FC intermittent failures i'm in the middle of debugging http://ec2-54-67-51-189.us-west-1.compute.amazonaws.com/55/216055/5/check/PureFCDriver-tempest-dsvm-volume-multipath/52f6bfa/logs/screen-c-vol.txt.gz?level=TRACE | 03:44 |
hemna | oh I bet I know what it is | 03:44 |
hemna | friggin network | 03:44 |
hemna | the HP split is causing no end of internal network problems | 03:45 |
jgriffith | ok... so we cool? | 03:45 |
hemna | the repo where the hp-functions.sh lives was unreachable | 03:45 |
hemna | (internal network FUBAR) | 03:45 |
jgriffith | ahh... that'll do it | 03:45 |
hemna | so yah, ignore our CI for that one :( | 03:45 |
jungleboyj | patrickeast: Updated. | 03:45 |
patrickeast | jungleboyj: awesome, thanks! | 03:46 |
*** salv-orlando has quit IRC | 03:46 | |
*** gouthamr has joined #openstack-cinder | 03:47 | |
*** links has joined #openstack-cinder | 03:48 | |
*** simondodsley has joined #openstack-cinder | 03:55 | |
*** simondodsley has quit IRC | 03:56 | |
*** edtubill has joined #openstack-cinder | 03:58 | |
*** zhangjn has joined #openstack-cinder | 04:00 | |
*** zhangjn_ has quit IRC | 04:02 | |
*** dims__ has joined #openstack-cinder | 04:03 | |
*** p0rtal has quit IRC | 04:06 | |
*** ishant has joined #openstack-cinder | 04:08 | |
openstackgerrit | Patrick East proposed openstack/cinder: Replication V2 for Pure Storage https://review.openstack.org/214825 | 04:15 |
*** xyang1 has quit IRC | 04:17 | |
*** dims__ is now known as dims | 04:17 | |
hemna | patrickeast: ^^ | 04:17 |
jungleboyj | hemna: patrickeast Are we going to try to get that through? | 04:18 |
patrickeast | dunno | 04:18 |
patrickeast | I'd like to | 04:18 |
hemna | :P | 04:18 |
jungleboyj | patrickeast: Really? | 04:18 |
jungleboyj | ;-) | 04:19 |
patrickeast | shocking I know | 04:19 |
hemna | well it seems that we are trying to get a bunch of stuff in this week. | 04:19 |
patrickeast | Yah, kind of cramming a lot in | 04:19 |
hemna | can I get my new driver in, if I put my first patch up tomorrow? | 04:19 |
hemna | :) | 04:19 |
jungleboyj | While the PTL is away, the developers will play. | 04:19 |
hemna | yah | 04:20 |
patrickeast | haha | 04:20 |
jungleboyj | hemna: Ah, you are a nice guy, sure. | 04:20 |
jungleboyj | patrickeast: Ok, we will talk about that one tomorrow. | 04:20 |
hemna | I saw a bunch of Burning Man cars/vans/trucks on the freeway on the way in to work on Monday | 04:20 |
hemna | hippy central | 04:20 |
jungleboyj | :-) | 04:20 |
patrickeast | yea I figure it's at least worth discussing at the meeting | 04:20 |
jungleboyj | Sounds good to me. | 04:20 |
patrickeast | at this point I'm not going to raise too big if a stink since we are passed the FF, I'll take my other ones that snuck by and be hapoy | 04:21 |
patrickeast | happy even | 04:22 |
*** lcurtis_ has quit IRC | 04:22 | |
hemna | mike will come back and go WTF! people! :P | 04:22 |
jungleboyj | hemna: Will he? After Burning Man? | 04:23 |
*** dims has quit IRC | 04:24 | |
hemna | :P | 04:24 |
*** hw_chenying has quit IRC | 04:26 | |
jungleboyj | Ok, gents. I need to go relax for a bit. Have a good night my friends. | 04:26 |
jungleboyj | Tomorrow we see what else we can shove in the release. ;-) | 04:27 |
hemna | jungleboyj: ok night man | 04:27 |
hemna | thanks for the help | 04:28 |
*** gouthamr has quit IRC | 04:30 | |
*** esker has joined #openstack-cinder | 04:30 | |
*** hemna has quit IRC | 04:31 | |
*** lyanchih has quit IRC | 04:31 | |
*** esker has quit IRC | 04:34 | |
*** hemna has joined #openstack-cinder | 04:36 | |
*** hemna has quit IRC | 04:36 | |
*** esker has joined #openstack-cinder | 04:43 | |
*** garthb has joined #openstack-cinder | 04:45 | |
*** esker has quit IRC | 04:49 | |
*** shausy has joined #openstack-cinder | 04:53 | |
*** salv-orlando has joined #openstack-cinder | 04:56 | |
*** mtreinish has quit IRC | 04:57 | |
*** lyanchih has joined #openstack-cinder | 04:58 | |
*** salv-orlando has quit IRC | 05:01 | |
*** mtreinish has joined #openstack-cinder | 05:04 | |
*** markvoelker has joined #openstack-cinder | 05:06 | |
*** mudassirlatif has joined #openstack-cinder | 05:06 | |
*** markvoelker has quit IRC | 05:11 | |
*** markvoelker has joined #openstack-cinder | 05:12 | |
*** lyanchih has quit IRC | 05:14 | |
*** IanGovett has quit IRC | 05:25 | |
*** IanGovett has joined #openstack-cinder | 05:25 | |
*** IanGovett has quit IRC | 05:30 | |
*** nkrinner has joined #openstack-cinder | 05:35 | |
*** shausy has quit IRC | 05:36 | |
*** shausy has joined #openstack-cinder | 05:36 | |
*** mudassirlatif has quit IRC | 05:43 | |
*** rushiagr_away is now known as rushiagr | 05:44 | |
*** edtubill has quit IRC | 05:46 | |
openstackgerrit | Tom Barron proposed openstack/cinder: NetApp E-Series over-subscription support https://review.openstack.org/215801 | 05:48 |
*** salv-orlando has joined #openstack-cinder | 05:52 | |
*** garthb has quit IRC | 05:52 | |
*** hw_chenying has joined #openstack-cinder | 05:54 | |
*** lyanchih has joined #openstack-cinder | 05:59 | |
*** mudassirlatif has joined #openstack-cinder | 06:03 | |
openstackgerrit | LisaLi proposed openstack/cinder: Transfer volumd id not object during RPC call https://review.openstack.org/219566 | 06:04 |
*** diogogmt has quit IRC | 06:11 | |
*** lpetrut has joined #openstack-cinder | 06:20 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/218741 | 06:20 |
*** markvoelker has quit IRC | 06:23 | |
*** lpetrut has quit IRC | 06:27 | |
*** dflorea has joined #openstack-cinder | 06:28 | |
*** ndipanov has quit IRC | 06:40 | |
*** yrabl has quit IRC | 06:40 | |
*** yrabl has joined #openstack-cinder | 06:41 | |
*** rushil has joined #openstack-cinder | 06:46 | |
*** rushil_ has joined #openstack-cinder | 06:48 | |
*** dims has joined #openstack-cinder | 06:50 | |
*** stefan_amann has joined #openstack-cinder | 06:50 | |
*** lyanchih has quit IRC | 06:51 | |
*** rushil has quit IRC | 06:51 | |
*** wilson has quit IRC | 06:52 | |
*** afazekas__ has joined #openstack-cinder | 06:52 | |
*** wilson has joined #openstack-cinder | 06:52 | |
*** dims has quit IRC | 06:54 | |
*** abehl has joined #openstack-cinder | 07:02 | |
*** abehl has quit IRC | 07:03 | |
*** anshul has joined #openstack-cinder | 07:03 | |
*** mudassirlatif has quit IRC | 07:03 | |
*** vincent_hou has joined #openstack-cinder | 07:09 | |
*** sam_wan has quit IRC | 07:10 | |
*** ndipanov has joined #openstack-cinder | 07:19 | |
*** alexschm has joined #openstack-cinder | 07:21 | |
*** lyanchih has joined #openstack-cinder | 07:21 | |
*** coolsvap_ has joined #openstack-cinder | 07:21 | |
*** svilgelm has joined #openstack-cinder | 07:24 | |
*** coolsvap_ has quit IRC | 07:26 | |
*** rushil_ has quit IRC | 07:27 | |
*** rushil has joined #openstack-cinder | 07:28 | |
*** BharatK has quit IRC | 07:34 | |
*** dflorea has quit IRC | 07:36 | |
*** dims has joined #openstack-cinder | 07:44 | |
*** esker has joined #openstack-cinder | 07:48 | |
*** dflorea has joined #openstack-cinder | 07:48 | |
*** BharatK has joined #openstack-cinder | 07:48 | |
*** dims has quit IRC | 07:49 | |
*** svilgelm has quit IRC | 07:51 | |
*** dflorea has quit IRC | 07:52 | |
*** esker has quit IRC | 07:52 | |
*** e0ne has joined #openstack-cinder | 08:01 | |
*** lpetrut has joined #openstack-cinder | 08:03 | |
*** svilgelm has joined #openstack-cinder | 08:05 | |
*** bluex-pl has joined #openstack-cinder | 08:08 | |
*** bluex-pl has quit IRC | 08:09 | |
*** bluex-pl has joined #openstack-cinder | 08:09 | |
openstackgerrit | Tina Tang proposed openstack/cinder: Fix the virtual port support in VNX driver https://review.openstack.org/214044 | 08:10 |
*** jistr has joined #openstack-cinder | 08:11 | |
*** e0ne has quit IRC | 08:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 08:14 |
vincent_hou | geguileo: Hi, i have got a new https://review.openstack.org/#/c/189547/ | 08:14 |
* geguileo reviewing ^ | 08:15 | |
*** bluex-pl has quit IRC | 08:16 | |
*** yuriy_n17 has joined #openstack-cinder | 08:16 | |
geguileo | vincent_hou: Done | 08:16 |
vincent_hou | geguileo: Thank you so much. It has been improved a lot. | 08:17 |
geguileo | vincent_hou: Thank you for working on that feature | 08:17 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 08:18 |
vincent_hou | geguileo: I will go to Japan as well, since my company has approved the trip. | 08:18 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/210918 | 08:19 |
geguileo | vincent_hou: Awesome, we'll meet there :-) | 08:19 |
vincent_hou | geguileo: yeps. | 08:20 |
*** lixiaoy1 has joined #openstack-cinder | 08:21 | |
*** EinstCrazy has joined #openstack-cinder | 08:25 | |
*** peter-wang has joined #openstack-cinder | 08:26 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Adds migration abortion for available volumes https://review.openstack.org/207754 | 08:27 |
*** earlephilhower has quit IRC | 08:28 | |
*** kjelly has joined #openstack-cinder | 08:31 | |
openstackgerrit | Accela Zhao proposed openstack/cinder: Just test commit. Will abandon later. https://review.openstack.org/219597 | 08:31 |
lixiaoy1 | jgriffith: Hi John, I just submitted a patch and do some updates related replication interface, may you help to review? the patch is https://review.openstack.org/#/c/219566/ | 08:32 |
openstackgerrit | Accela Zhao proposed openstack/cinder: Just test commit. Will abandon later. https://review.openstack.org/219598 | 08:35 |
*** dims has joined #openstack-cinder | 08:38 | |
*** dims has quit IRC | 08:43 | |
*** ronis has joined #openstack-cinder | 08:44 | |
*** lyanchih has quit IRC | 08:46 | |
*** dflorea has joined #openstack-cinder | 08:49 | |
*** lyanchih has joined #openstack-cinder | 08:50 | |
*** lixiaoy1 has quit IRC | 08:53 | |
*** dflorea has quit IRC | 08:53 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Adds migration abortion for available volumes https://review.openstack.org/207754 | 08:57 |
*** markvoelker has joined #openstack-cinder | 08:57 | |
*** IanGovett has joined #openstack-cinder | 09:01 | |
*** markvoelker has quit IRC | 09:02 | |
*** rushil has quit IRC | 09:03 | |
*** hw_chenying has quit IRC | 09:03 | |
*** peter-wang has quit IRC | 09:04 | |
*** salv-orlando has quit IRC | 09:07 | |
*** takedakn has joined #openstack-cinder | 09:10 | |
openstackgerrit | zhaohua proposed openstack/cinder: Huawei: fix multi REST-URLs bug https://review.openstack.org/214500 | 09:15 |
openstackgerrit | Vincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 09:15 |
*** kaisers1 has joined #openstack-cinder | 09:16 | |
*** zhangjn has quit IRC | 09:17 | |
*** takedakn has quit IRC | 09:24 | |
DuncanT | A review that isn't affected by feature freeze: https://review.openstack.org/#/c/211583/ (Spec update for trim/disgard, since it ended up being slightly simpler than thought) | 09:25 |
*** vincent_hou has quit IRC | 09:26 | |
openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve snapshot and clone operation https://review.openstack.org/198952 | 09:30 |
*** e0ne has joined #openstack-cinder | 09:32 | |
*** dims has joined #openstack-cinder | 09:32 | |
*** esker has joined #openstack-cinder | 09:36 | |
*** dims has quit IRC | 09:37 | |
*** hw_chenying has joined #openstack-cinder | 09:38 | |
*** ociuhandu has quit IRC | 09:41 | |
*** esker has quit IRC | 09:41 | |
openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve image operations https://review.openstack.org/202954 | 09:44 |
*** e0ne has quit IRC | 09:46 | |
*** EinstCrazy has quit IRC | 09:46 | |
*** salv-orlando has joined #openstack-cinder | 09:50 | |
openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 09:55 |
*** e0ne has joined #openstack-cinder | 09:55 | |
*** ociuhandu has joined #openstack-cinder | 10:05 | |
*** hw_chenying has quit IRC | 10:12 | |
*** esker has joined #openstack-cinder | 10:14 | |
*** esker has quit IRC | 10:18 | |
*** zhangjn has joined #openstack-cinder | 10:23 | |
*** zhangjn has quit IRC | 10:26 | |
*** dims has joined #openstack-cinder | 10:26 | |
*** dims has quit IRC | 10:31 | |
*** sayali_ has quit IRC | 10:32 | |
*** sayali has joined #openstack-cinder | 10:34 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 10:34 |
*** sgotliv has joined #openstack-cinder | 10:42 | |
*** shyama has quit IRC | 10:49 | |
*** daemontool_ has joined #openstack-cinder | 10:50 | |
*** esker has joined #openstack-cinder | 10:50 | |
*** lyanchih has quit IRC | 10:51 | |
*** shyama has joined #openstack-cinder | 10:52 | |
*** shyama_ has joined #openstack-cinder | 10:53 | |
*** shyama has quit IRC | 10:56 | |
*** shyama_ is now known as shyama | 10:56 | |
*** takedakn has joined #openstack-cinder | 11:01 | |
*** jgriffith has quit IRC | 11:02 | |
*** eharney has quit IRC | 11:02 | |
*** jgriffith has joined #openstack-cinder | 11:03 | |
*** eharney has joined #openstack-cinder | 11:04 | |
*** jgriffith is now known as Guest91834 | 11:04 | |
*** dtadrzak_ has quit IRC | 11:06 | |
*** Anticimex has quit IRC | 11:13 | |
*** dims has joined #openstack-cinder | 11:21 | |
*** Anticimex has joined #openstack-cinder | 11:23 | |
*** esker has quit IRC | 11:26 | |
*** dims has quit IRC | 11:26 | |
*** esker has joined #openstack-cinder | 11:26 | |
*** wilson has quit IRC | 11:29 | |
*** wilson has joined #openstack-cinder | 11:30 | |
*** svilgelm_ has joined #openstack-cinder | 11:31 | |
*** tpsilva has joined #openstack-cinder | 11:32 | |
*** svilgelm has quit IRC | 11:34 | |
*** aix has quit IRC | 11:36 | |
*** haomaiwang has quit IRC | 11:37 | |
*** svilgelm_ has quit IRC | 11:39 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: FAKE. DO NOT MERGE https://review.openstack.org/219654 | 11:41 |
*** bapalm has quit IRC | 11:43 | |
*** takedakn has quit IRC | 11:43 | |
*** rushil has joined #openstack-cinder | 11:46 | |
*** rushil_ has joined #openstack-cinder | 11:47 | |
*** bapalm has joined #openstack-cinder | 11:49 | |
*** rushil has quit IRC | 11:50 | |
*** dflorea has joined #openstack-cinder | 11:50 | |
*** panbalag has joined #openstack-cinder | 11:51 | |
*** breitz1 has quit IRC | 11:51 | |
*** breitz has joined #openstack-cinder | 11:51 | |
*** esker has quit IRC | 11:52 | |
*** dflorea has quit IRC | 11:55 | |
panbalag | Hi.. I have cinder configured with iscsi backend. Any idea how I can retrieve the LUN id of a volume created. cinder show <volume-id> does not seem to have it. | 11:57 |
*** svilgelm has joined #openstack-cinder | 11:59 | |
panbalag | nevermind. Found the lun id. | 12:02 |
*** panbalag has left #openstack-cinder | 12:02 | |
*** svilgelm has quit IRC | 12:03 | |
*** shyama has quit IRC | 12:03 | |
*** DTadrzak has joined #openstack-cinder | 12:06 | |
*** jaypipes has joined #openstack-cinder | 12:08 | |
*** aix has joined #openstack-cinder | 12:09 | |
*** shyama has joined #openstack-cinder | 12:10 | |
*** bswartz has joined #openstack-cinder | 12:12 | |
*** delattec has quit IRC | 12:15 | |
*** cdelatte has quit IRC | 12:15 | |
*** martyturner has joined #openstack-cinder | 12:19 | |
*** martyturner has quit IRC | 12:20 | |
*** martyturner has joined #openstack-cinder | 12:21 | |
*** gouthamr has joined #openstack-cinder | 12:22 | |
*** svilgelm has joined #openstack-cinder | 12:25 | |
*** bkopilov has quit IRC | 12:25 | |
*** martyturner has quit IRC | 12:26 | |
*** bkopilov has joined #openstack-cinder | 12:26 | |
*** rushiagr is now known as rushiagr_away | 12:27 | |
*** david-lyle has quit IRC | 12:27 | |
*** mordred has quit IRC | 12:27 | |
*** dansmith has quit IRC | 12:28 | |
*** Swanson has quit IRC | 12:28 | |
*** david-lyle has joined #openstack-cinder | 12:28 | |
*** raildo-afk is now known as raildo | 12:29 | |
*** agarciam has joined #openstack-cinder | 12:29 | |
*** rushil_ has quit IRC | 12:31 | |
*** rushil has joined #openstack-cinder | 12:32 | |
*** dansmith has joined #openstack-cinder | 12:33 | |
*** timcl has joined #openstack-cinder | 12:33 | |
*** dansmith is now known as Guest91339 | 12:33 | |
openstackgerrit | Marian Horban proposed openstack/cinder: [WIP]Remove wsgi functionality https://review.openstack.org/219671 | 12:36 |
*** rushil has quit IRC | 12:37 | |
*** porrua has joined #openstack-cinder | 12:41 | |
*** Swanson has joined #openstack-cinder | 12:41 | |
*** takedakn has joined #openstack-cinder | 12:45 | |
*** takedakn has quit IRC | 12:47 | |
*** zhangjn has joined #openstack-cinder | 12:47 | |
*** dims has joined #openstack-cinder | 12:48 | |
*** annegentle has joined #openstack-cinder | 12:51 | |
*** e0ne has quit IRC | 12:53 | |
*** akerr has joined #openstack-cinder | 12:53 | |
openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Support initialization state in Backup Manager https://review.openstack.org/216728 | 12:54 |
*** zhangjn has quit IRC | 12:54 | |
*** diogogmt has joined #openstack-cinder | 12:56 | |
*** jamesk has joined #openstack-cinder | 12:56 | |
*** merooney has joined #openstack-cinder | 12:57 | |
*** jamesk is now known as MrJamesK | 12:57 | |
*** sgotliv has quit IRC | 12:57 | |
*** sgotliv has joined #openstack-cinder | 12:57 | |
*** bswartz has quit IRC | 12:58 | |
*** diogogmt has quit IRC | 12:59 | |
*** diogogmt has joined #openstack-cinder | 13:04 | |
*** zhangjn has joined #openstack-cinder | 13:04 | |
*** zhangjn has quit IRC | 13:04 | |
*** zhangjn has joined #openstack-cinder | 13:05 | |
*** jungleboyj has quit IRC | 13:05 | |
*** timcl1 has joined #openstack-cinder | 13:06 | |
*** timcl has quit IRC | 13:07 | |
*** diogogmt has quit IRC | 13:08 | |
*** lyanchih has joined #openstack-cinder | 13:11 | |
*** bill_az has joined #openstack-cinder | 13:12 | |
*** rushiagr_away is now known as rushiagr | 13:17 | |
*** simondodsley has joined #openstack-cinder | 13:17 | |
*** ishant has quit IRC | 13:17 | |
*** links has quit IRC | 13:17 | |
*** dims_ has joined #openstack-cinder | 13:17 | |
*** esker has joined #openstack-cinder | 13:18 | |
*** xyang has joined #openstack-cinder | 13:20 | |
*** esker has quit IRC | 13:20 | |
*** dims has quit IRC | 13:21 | |
*** rushiagr is now known as rushiagr_away | 13:21 | |
geguileo | DuncanT: ping - moving get_by_id to CinderObject | 13:23 |
*** mriedem_away is now known as mriedem | 13:25 | |
*** esker has joined #openstack-cinder | 13:25 | |
DuncanT | geguileo: Hmmm? Is that not merged? | 13:26 |
*** timcl has joined #openstack-cinder | 13:26 | |
*** jgregor has joined #openstack-cinder | 13:26 | |
DuncanT | geguileo: Got a link? | 13:26 |
geguileo | DuncanT: https://review.openstack.org/#/c/218012/ | 13:26 |
*** esker has quit IRC | 13:26 | |
geguileo | DuncanT: I'd like to discuss with you your comment on explicit mapping of Versioned Objects to ORM models and models to get methods | 13:27 |
*** timcl1 has quit IRC | 13:27 | |
*** esker has joined #openstack-cinder | 13:27 | |
*** timcl has left #openstack-cinder | 13:29 | |
*** zul has quit IRC | 13:29 | |
DuncanT | geguileo: Sure | 13:30 |
DuncanT | geguileo: It was just a thought, but looks far neater | 13:31 |
DuncanT | geguileo: We have a history of forgetting to update manual mappings | 13:31 |
geguileo | DuncanT: Yeah, but has a lot of problems with latests patches :''-( | 13:31 |
geguileo | DuncanT: Versioned object is called VolumeType and not VolumeTypes | 13:31 |
geguileo | DuncanT: So I cannot do the mapping automatically | 13:32 |
*** zul has joined #openstack-cinder | 13:32 | |
geguileo | DuncanT: We also have a BackupImport versioned object which corresponding Backup ORM model | 13:32 |
DuncanT | Ok, can you file a bug to look at fixing that in future, and link to the bug in a review comment please? At least it will get looked at then | 13:32 |
geguileo | DuncanT: Ok | 13:33 |
DuncanT | Once you've done that, I'm happy with the manual list as a temporary solution | 13:33 |
geguileo | DuncanT: As for model to get methods | 13:33 |
geguileo | DuncanT: jgriffith didn't like that we change name from volume_type_get to volume_types_get when it is actually only returning 1 type | 13:34 |
geguileo | DuncanT: And I kind of agree | 13:34 |
*** dustins has joined #openstack-cinder | 13:36 | |
DuncanT | Looking | 13:37 |
geguileo | DuncanT: It's in parent patch | 13:37 |
openstackgerrit | Vincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 13:38 |
*** edmondsw has joined #openstack-cinder | 13:41 | |
DuncanT | I see it. I don't think that this is going to get in for L now :-( | 13:42 |
*** annegentle has quit IRC | 13:43 | |
geguileo | DuncanT: And you consider and acceptable solution the explicit mapping or you still think I should change those method names? | 13:45 |
*** ganso_ has joined #openstack-cinder | 13:45 | |
DuncanT | I think explicit mapping is fine as long as there's a bug to look at a better way | 13:45 |
geguileo | DuncanT: Ok | 13:46 |
geguileo | DuncanT: By the way, I am seeing another object that will have problems with automatic mapping, CGSnapshot in orm is Cgsnapshot (this one hasn't merged yet) | 13:47 |
geguileo | DuncanT: Thanks, I'll file those bugs and change the patch back | 13:47 |
DuncanT | Cool. I think auto-mapping is cleaner (and more pythonic) but I'm fine with getting there in steps | 13:48 |
geguileo | DuncanT: Awesome | 13:48 |
*** BharatK has quit IRC | 13:49 | |
*** Roamer` has joined #openstack-cinder | 13:49 | |
*** Guest91339 is now known as dansmith | 13:51 | |
*** dansmith is now known as Guest36431 | 13:51 | |
*** amoturi has quit IRC | 13:51 | |
*** amoturi has joined #openstack-cinder | 13:52 | |
*** svilgelm has quit IRC | 13:53 | |
*** martyturner has joined #openstack-cinder | 13:53 | |
openstackgerrit | Kendall Nelson proposed openstack/cinder: WIP: Dynamically create cinder.conf.sample https://review.openstack.org/219700 | 13:53 |
*** lprice has joined #openstack-cinder | 13:55 | |
*** Yogi1 has joined #openstack-cinder | 13:55 | |
*** merooney has quit IRC | 13:55 | |
*** jgregor has quit IRC | 13:56 | |
*** Guest36431 is now known as dansmith | 13:56 | |
*** haomaiwang has joined #openstack-cinder | 13:57 | |
*** xyang has quit IRC | 13:58 | |
*** jgregor has joined #openstack-cinder | 13:58 | |
*** jgregor has quit IRC | 13:58 | |
*** thangp has joined #openstack-cinder | 13:59 | |
*** mriedem is now known as mriedem_meeting | 13:59 | |
*** lprice1 has joined #openstack-cinder | 14:01 | |
*** markvoelker has joined #openstack-cinder | 14:01 | |
*** bswartz has joined #openstack-cinder | 14:01 | |
*** lprice has quit IRC | 14:03 | |
*** xyang has joined #openstack-cinder | 14:04 | |
*** julim has joined #openstack-cinder | 14:04 | |
*** BharatK has joined #openstack-cinder | 14:04 | |
*** merooney has joined #openstack-cinder | 14:05 | |
*** markvoelker has quit IRC | 14:06 | |
*** annegentle has joined #openstack-cinder | 14:14 | |
*** raildo is now known as raildo-afk | 14:16 | |
*** crose has joined #openstack-cinder | 14:16 | |
*** raildo-afk is now known as raildo | 14:17 | |
*** haomaiwang has quit IRC | 14:23 | |
*** zhenguo has quit IRC | 14:24 | |
*** haomaiwa_ has joined #openstack-cinder | 14:25 | |
*** cdelatte has joined #openstack-cinder | 14:25 | |
*** delattec has joined #openstack-cinder | 14:25 | |
*** Guest91834 is now known as jgriffith | 14:26 | |
*** dustins_ has joined #openstack-cinder | 14:26 | |
*** lyanchih has quit IRC | 14:27 | |
MrJamesK | Is there a way to use the LVM driver without iSCSI? Trying to figure a way to use local storage. I see the Blockdevice driver, but it requries predefined devices which is rather limiting. | 14:27 |
*** esker has quit IRC | 14:27 | |
*** dustins has quit IRC | 14:28 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 14:28 |
*** mtanino has joined #openstack-cinder | 14:30 | |
*** shausy has quit IRC | 14:30 | |
*** edtubill has joined #openstack-cinder | 14:31 | |
*** merooney has quit IRC | 14:31 | |
*** afazekas__ has quit IRC | 14:31 | |
*** shyama_ has joined #openstack-cinder | 14:33 | |
*** merooney has joined #openstack-cinder | 14:34 | |
*** edtubill1 has joined #openstack-cinder | 14:34 | |
*** shyama has quit IRC | 14:35 | |
*** shyama_ is now known as shyama | 14:35 | |
*** edtubill has quit IRC | 14:36 | |
*** eharney has quit IRC | 14:36 | |
*** e0ne has joined #openstack-cinder | 14:39 | |
*** esker has joined #openstack-cinder | 14:39 | |
*** alexpilotti has joined #openstack-cinder | 14:42 | |
*** markvoelker has joined #openstack-cinder | 14:42 | |
*** markvoelker has quit IRC | 14:42 | |
*** diogogmt has joined #openstack-cinder | 14:42 | |
*** markvoelker has joined #openstack-cinder | 14:43 | |
*** zhangjn has quit IRC | 14:45 | |
*** zhangjn has joined #openstack-cinder | 14:45 | |
*** zhangjn has quit IRC | 14:45 | |
*** zhangjn has joined #openstack-cinder | 14:46 | |
*** zhangjn has quit IRC | 14:46 | |
DuncanT | MrJamesK: That's an oft-requested feature, but I don't think anybody has done all the leg work needed to get it working | 14:47 |
*** cdelatte has quit IRC | 14:47 | |
*** delattec has quit IRC | 14:47 | |
*** cdelatte has joined #openstack-cinder | 14:47 | |
*** delattec has joined #openstack-cinder | 14:47 | |
*** zhangjn has joined #openstack-cinder | 14:47 | |
*** rushil has joined #openstack-cinder | 14:48 | |
*** zhangjn has quit IRC | 14:49 | |
*** zhangjn has joined #openstack-cinder | 14:50 | |
*** zhangjn has quit IRC | 14:50 | |
MrJamesK | DuncanT: Thanks for info; too bad. I looked at the code for the block and LVM (refrence) driver, really just a merging of the two would suffice for my needs. | 14:52 |
*** asselin__ has quit IRC | 14:52 | |
jgriffith | MrJamesK: but it breaks all of the standard use cases is the problem | 14:52 |
DuncanT | MrJamesK: The problem is that people have different needs. BlockDeviceDriver really shouldn't be in cinder at all any more, it doesn't actually work as a standard cinder driver | 14:53 |
jgriffith | MrJamesK: I have a hybrid proposal to resurrect in Mitaka | 14:53 |
jgriffith | DuncanT: +1 | 14:53 |
MrJamesK | jgriffith: is that because it is local to a compute node? | 14:53 |
jgriffith | MrJamesK: correct | 14:53 |
*** p0rtal has joined #openstack-cinder | 14:53 | |
jgriffith | MrJamesK: but we can provide the best of both worlds | 14:53 |
*** esker has quit IRC | 14:53 | |
*** p0rtal has quit IRC | 14:54 | |
MrJamesK | jgriffith: link to your proposal? | 14:54 |
jgriffith | MrJamesK: with what was at one point called "brick" but now that name belongs to something else | 14:54 |
*** diogogmt has quit IRC | 14:54 | |
*** jgregor has joined #openstack-cinder | 14:54 | |
jgriffith | MrJamesK: It needs completely rewritten | 14:54 |
MrJamesK | I would be willing to put coding clock cycles to it | 14:54 |
*** p0rtal has joined #openstack-cinder | 14:54 | |
jgriffith | MrJamesK: but the idea is an agent running on the compute nodes that allows allocation of local storage for those that have it, and people that want it | 14:54 |
*** mriedem_meeting is now known as mriedem | 14:54 | |
jgriffith | MrJamesK: with a hook to attach a target in cases where things like instance migration occur | 14:55 |
jgriffith | MrJamesK: it's not that complex I don't think once the scheduling/type challenges are all figured out | 14:55 |
*** diogogmt has joined #openstack-cinder | 14:55 | |
*** p0rtal has quit IRC | 14:56 | |
jgriffith | MrJamesK: mtanino also had a proposal out to do shared LVM | 14:56 |
*** p0rtal has joined #openstack-cinder | 14:56 | |
jgriffith | Number of options/thoughts out there on the topic | 14:56 |
*** jungleboyj has joined #openstack-cinder | 14:57 | |
MrJamesK | jgriffith: assuming this is what you are referring to - https://blueprints.launchpad.net/cinder/+spec/lvm-driver-for-shared-storage | 14:58 |
jgriffith | MrJamesK: yeah, that's mtanino 's proposal | 14:58 |
*** hemnafk is now known as hemna | 14:58 | |
MrJamesK | I've worked around it today by having it use availability zones isolated to the box, but then iscsi is the overhead on the compute node | 14:58 |
jgriffith | MrJamesK: there was also this https://wiki.openstack.org/wiki/CinderBrick | 14:58 |
*** krotscheck is now known as kro_afk | 14:59 | |
jgriffith | MrJamesK: My only argument here is that if iSCSI is done correctly it's not typically a bottle-neck | 14:59 |
jgriffith | MrJamesK: same with LVm | 14:59 |
jgriffith | LVM | 14:59 |
jgriffith | but anyway | 14:59 |
DuncanT | MrJamesK: It has been proposed that we can just add a bit of code to cinder and nova to use a local device if the device happens to be local | 14:59 |
MrJamesK | You mean from a network throughput perspective? | 14:59 |
MrJamesK | DuncanT: ya that would suffice as well | 15:00 |
jgriffith | From a performance perspective | 15:00 |
DuncanT | MrJamesK: So we include the hostname and the device name in the output of the lvm initialise_connection and get nova to consume that | 15:00 |
jgriffith | iSCSI is plenty performant if do things like a dedicated iscsi network, and use 10Gig ethernet | 15:00 |
MrJamesK | jgriffith: Agree 100% | 15:01 |
jgriffith | but anyway... you don't want to get me ranting on that :) | 15:01 |
MrJamesK | I just have some use cases where that infrastructure isn't possible | 15:01 |
jgriffith | MrJamesK: I get easily annoyed because the people that say they MUST have local storage or raw disk for perf are using things like shared 1Gig nics with all of their network traffic on it | 15:01 |
MrJamesK | iSCSI local on the compute node also works, but tgt eats too much of the compute node resources to be viable | 15:01 |
jgriffith | MrJamesK: understod | 15:02 |
*** julim_ has joined #openstack-cinder | 15:02 | |
DuncanT | MrJamesK: What hasn't yet been done is scale testing for running the lvm driver (and c-vol) on every compute node - can the scheduler cope? | 15:02 |
DuncanT | MrJamesK: If you have the facilities to test that, it would be very useful info as to how much of a smarter solution we really need | 15:03 |
hemna | WTF is up with people and their -1's for missing . | 15:03 |
hemna | I'm so over it | 15:03 |
DuncanT | hemna: Just ignore the -1 and +2 over it | 15:03 |
hemna | we need a kick ban for -1 over missing . | 15:03 |
hemna | :P | 15:03 |
hemna | no reviews for you for 24 hours! | 15:03 |
jgriffith | hemna: FEEL MY PAIN!!! | 15:04 |
hemna | bloody hell | 15:04 |
MrJamesK | DuncanT: Can you elaborate what you mean by scale testing? Scale as in having 100s of logical volumes on a compute node? | 15:04 |
simondodsley | +1 on the stuid -1's | 15:04 |
simondodsley | s/stuid/stupid | 15:04 |
DuncanT | MrJamesK: More having 100 copies of c-vol running into one scheduler | 15:04 |
* jungleboyj didn't do it. | 15:04 | |
*** kro_afk is now known as krotscheck | 15:04 | |
hemna | simondodsley, -1 on your missing p | 15:04 |
*** nkrinner has quit IRC | 15:04 | |
hemna | :P | 15:04 |
*** julim has quit IRC | 15:05 | |
MrJamesK | DuncanT: interesting, I would anticiapte if you were trying to use local storage you wouldn't expect to scale your logical volumes past 20 or 30. | 15:05 |
MrJamesK | And if you have c-vol on the compute node, you just need to scale the compute node for the additional overhead of running storage as well | 15:06 |
DuncanT | MrJamesK: The problem isn't the LV count, it's the max cloud size that can support this style of install. If every compute node has local storage, that means every compute node has a c-vol service - we have never tested that many c-vol services all talking to the scheduler at once | 15:06 |
DuncanT | MrJamesK: 10s of c-vol services is currently considered 'large' | 15:07 |
MrJamesK | DuncanT: ahhh | 15:07 |
DuncanT | MrJamesK: Given you can run 10+ c-vol talking to loopback devices on one node, it isn't that hard to test the scheduler with low hundreds of c-vol services.... maybe look at the fake driver too just to get the stats reporting and filters working hard | 15:08 |
DuncanT | MrJamesK: If it works, then the local LVM patch really is small and fairly safe, but I suspect something will cause the scheduler to crawl / die | 15:09 |
MrJamesK | I'll see what I can produce | 15:10 |
*** MrJamesK is now known as MrJamesK_away | 15:10 | |
DuncanT | MrJamesK: Thanks | 15:11 |
*** dims_ has quit IRC | 15:12 | |
*** jistr is now known as jistr|call | 15:12 | |
*** p0rtal has quit IRC | 15:14 | |
*** dannywilson has joined #openstack-cinder | 15:14 | |
*** ronis has quit IRC | 15:15 | |
*** dannywil_ has joined #openstack-cinder | 15:16 | |
*** dannywilson has quit IRC | 15:16 | |
Swanson | Did live migration work on kilo? | 15:20 |
*** eharney has joined #openstack-cinder | 15:22 | |
*** dustins_ has quit IRC | 15:25 | |
*** p0rtal has joined #openstack-cinder | 15:29 | |
*** jdurgin1 has joined #openstack-cinder | 15:30 | |
*** jistr|call is now known as jistr | 15:38 | |
e0ne | does anybody know what changed with nova attachment API? all rally jobs failed with attachment:( | 15:39 |
*** alexschm has quit IRC | 15:40 | |
hemna | man, is everything stuck in the gate today? | 15:42 |
* hemna queued | 15:42 | |
e0ne | hemna: didn't make any patch today. everything work well last night | 15:42 |
hemna | patrickeast, ping | 15:43 |
Swanson | hemna: doesn't look so bad today. Last weekend my patch took about 26 or so hours to get through gate. | 15:43 |
hemna | doh | 15:43 |
hemna | chain of rebase merge conflicts. *sigh* | 15:43 |
jungleboyj | Wow. Poor gate. So backed up. | 15:43 |
hemna | jungleboyj, someone get the gate some coffee, lets unload the queue! | 15:44 |
*** tsufiev has joined #openstack-cinder | 15:44 | |
tsufiev | hi, folks! | 15:44 |
tsufiev | I have a question about https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/quotas.py#L33 | 15:44 |
jungleboyj | hemna: :-) | 15:44 |
jungleboyj | hemna: I have some hazelnut dream right here. Where do I pour it? | 15:45 |
tsufiev | is it true that now the Cinder quota can be disabled with the service itself is still enabled? | 15:45 |
hemna | jungleboyj, usually on the keyboard | 15:45 |
tsufiev | we've started to receive 500 error from Cinder service in Horizon integration tests, where Cinder is being deployed in Devstack in some default configuration | 15:46 |
tsufiev | Horizon assumption up until this time was that if Cinder is enabled, then its quotas are enabled as well | 15:46 |
hemna | tsufiev, sorry, I'm not up to speed on the quota stuffs. | 15:46 |
*** xiaohui has quit IRC | 15:47 | |
jgriffith | tsufiev: not sure I'm following, we are in fact setting default quotas | 15:47 |
*** xiaohui has joined #openstack-cinder | 15:47 | |
*** hodos has joined #openstack-cinder | 15:47 | |
jgriffith | tsufiev: can you share info on "what' the 500 errors are from? and what "some default configuraton" is? | 15:48 |
tsufiev | jgriffith, this line in Horizon is failing: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/cinder.py#L418 | 15:49 |
tsufiev | with the 500 status and u'The server has either erred or is incapable of performing the requested operation.' message | 15:49 |
*** dustins has joined #openstack-cinder | 15:49 | |
tsufiev | * with 500 status and u'The server has either erred or is incapable of performing the requested operation.' message | 15:50 |
jgriffith | tsufiev: so there haven't been any changes around that code in quite a while.... | 15:50 |
jgriffith | tsufiev: unless.... just a sec | 15:50 |
tsufiev | as for 'some default configuration'... I wish I knew where I could find it | 15:50 |
tsufiev | it's a thing more specific to devstack folks, I'm not super-proficient in that stuff | 15:51 |
*** dims has joined #openstack-cinder | 15:51 | |
jgriffith | tsufiev: hmm it may be further down the line | 15:51 |
*** timcl has joined #openstack-cinder | 15:51 | |
jgriffith | tsufiev: like in the nested-quota driver changes | 15:51 |
jgriffith | https://github.com/openstack/cinder/commit/8a7ab267a6bbd48fc5e9ccb91a1472cf1e017e3f#diff-03a7544f58abd38d6c39e9433b0c7017 | 15:51 |
jgriffith | tsufiev: would you mind filing a bug for me against cinder with as much info as you can? | 15:52 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 15:52 |
jgriffith | tsufiev: and then I can take a look at it later and see if I can figure out what's up | 15:52 |
*** anshul has quit IRC | 15:52 | |
hemna | patrickeast, ^^ had to resolve a rebase/merge conflict it wasn't going to pass gate | 15:52 |
tsufiev | jgriffith, sure, I'll do. Do you know by chance what's the channel here for devstack devs? | 15:53 |
jgriffith | tsufiev: you can try openstack-dev | 15:53 |
tsufiev | okay | 15:53 |
patrickeast | hemna: thanks! | 15:53 |
hemna | gah, if only I didn't screw up the topic | 15:54 |
*** p0rtal has quit IRC | 15:54 | |
* hemna is lame | 15:54 | |
patrickeast | hemna: where was the conflict? | 15:54 |
patrickeast | haha, does the topic really even matter for single patches like that? | 15:55 |
*** dustins has quit IRC | 15:55 | |
hemna | patrickeast, it was on the cinder/tests/unit/utils.py | 15:55 |
patrickeast | ah ok, i was worried it might need a rev on the db migration number | 15:55 |
hemna | patrickeast, https://github.com/openstack/cinder/blob/master/cinder/tests/unit/utils.py had a conflict with the replace_obj_loader | 15:56 |
patrickeast | gotcha | 15:56 |
hemna | my dep patch had a merge conflict that saw it | 15:57 |
*** esker has joined #openstack-cinder | 15:57 | |
*** mtanino has quit IRC | 15:57 | |
hemna | but your patch hadn't made it out of the queue yet, so it didn't show up on your patch | 15:57 |
*** dustins has joined #openstack-cinder | 15:57 | |
*** ndipanov has quit IRC | 15:57 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: 3PAR Disable generic image volume cache https://review.openstack.org/219406 | 15:57 |
*** ndipanov has joined #openstack-cinder | 15:57 | |
*** sghanekar has joined #openstack-cinder | 15:57 | |
patrickeast | so i guess we need to +A it again right? | 15:58 |
hemna | yah I think so | 15:58 |
patrickeast | and by we i mean someone who can +A it :D | 15:58 |
openstackgerrit | John Griffith proposed openstack/cinder: Remove useless response checks in SolidFire driver https://review.openstack.org/219756 | 15:58 |
hemna | it's at the bottom of the check Queue right now :( | 15:58 |
hemna | patrickeast, once it passes jenkins, I'll +A it for you | 15:59 |
patrickeast | ok cool, thanks | 15:59 |
patrickeast | hopefully it makes it through the gate before L ships :o | 15:59 |
*** esker has quit IRC | 15:59 | |
*** agarciam has quit IRC | 16:01 | |
* hemna crosses fingers | 16:01 | |
jgriffith | meeting? | 16:01 |
*** xyang has quit IRC | 16:02 | |
*** dims has quit IRC | 16:02 | |
*** xyang has joined #openstack-cinder | 16:03 | |
*** dims has joined #openstack-cinder | 16:03 | |
*** markvoelker has quit IRC | 16:03 | |
openstackgerrit | abhiram moturi proposed openstack/cinder: ZFSSA driver to return project 'available' space https://review.openstack.org/211299 | 16:03 |
*** merooney has quit IRC | 16:04 | |
*** dims_ has joined #openstack-cinder | 16:04 | |
*** p0rtal has joined #openstack-cinder | 16:05 | |
openstackgerrit | abhiram moturi proposed openstack/cinder: ZFSSA driver to return project 'available' space https://review.openstack.org/211299 | 16:05 |
*** svilgelm has joined #openstack-cinder | 16:05 | |
openstackgerrit | Tom Barron proposed openstack/cinder: Implement thin provisioning support for E-Series https://review.openstack.org/215833 | 16:06 |
*** p0rtal has quit IRC | 16:06 | |
*** garthb has joined #openstack-cinder | 16:07 | |
*** dims has quit IRC | 16:07 | |
*** p0rtal has joined #openstack-cinder | 16:07 | |
*** timcl1 has joined #openstack-cinder | 16:08 | |
mriedem | xyang: hemna: cross your fingers https://review.openstack.org/#/c/207677/ | 16:08 |
*** timcl has quit IRC | 16:08 | |
*** p0rtal has quit IRC | 16:08 | |
*** mtanino has joined #openstack-cinder | 16:08 | |
*** timcl1 has left #openstack-cinder | 16:09 | |
hemna | mriedem, +1 | 16:09 |
*** p0rtal has joined #openstack-cinder | 16:09 | |
*** timcl has joined #openstack-cinder | 16:09 | |
openstackgerrit | abhiram moturi proposed openstack/cinder: ZFSSA driver to return project 'available' space https://review.openstack.org/211299 | 16:10 |
*** stefan_amann has quit IRC | 16:13 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/python-cinderclient: Remove duplicate code in functional tests https://review.openstack.org/219772 | 16:13 |
*** esker has joined #openstack-cinder | 16:14 | |
*** angela-s has joined #openstack-cinder | 16:14 | |
*** afazekas__ has joined #openstack-cinder | 16:16 | |
*** devlaps has joined #openstack-cinder | 16:16 | |
tsufiev | jgriffith, https://bugs.launchpad.net/cinder/+bug/1491495 | 16:16 |
openstack | Launchpad bug 1491495 in Cinder "cinderclient.quotas.get() fails against Cinder service in a Devstack" [Undecided,New] | 16:16 |
tsufiev | perhaps I was not very lucky in coining the bug title | 16:16 |
*** julim_ has quit IRC | 16:17 | |
*** svilgelm has quit IRC | 16:17 | |
*** alexpilotti has quit IRC | 16:17 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 16:21 |
*** esker has quit IRC | 16:23 | |
*** leeantho has joined #openstack-cinder | 16:23 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Add fancy pypi version and download images https://review.openstack.org/219779 | 16:31 |
*** smcgmobile has joined #openstack-cinder | 16:32 | |
*** haypo has left #openstack-cinder | 16:34 | |
openstackgerrit | Michael Price proposed openstack/cinder: NetApp E-Series over-subscription support https://review.openstack.org/215801 | 16:34 |
*** afazekas__ has quit IRC | 16:35 | |
*** jdurgin1 has quit IRC | 16:36 | |
*** mudassirlatif has joined #openstack-cinder | 16:36 | |
*** earlephilhower has joined #openstack-cinder | 16:38 | |
*** ronis has joined #openstack-cinder | 16:40 | |
*** julim has joined #openstack-cinder | 16:40 | |
*** julim has quit IRC | 16:40 | |
*** julim has joined #openstack-cinder | 16:41 | |
*** Yogi1 has quit IRC | 16:41 | |
*** jistr has quit IRC | 16:44 | |
*** stefan_amann has joined #openstack-cinder | 16:47 | |
*** smcginnis_ has joined #openstack-cinder | 16:48 | |
*** afazekas__ has joined #openstack-cinder | 16:48 | |
*** MIDENN_ has quit IRC | 16:50 | |
*** mdenny has quit IRC | 16:50 | |
*** Yogi1 has joined #openstack-cinder | 16:50 | |
*** smcgmobile has quit IRC | 16:51 | |
*** MIDENN_ has joined #openstack-cinder | 16:52 | |
*** mdenny has joined #openstack-cinder | 16:52 | |
*** smcginnis_ has quit IRC | 16:54 | |
*** merooney has joined #openstack-cinder | 16:56 | |
*** earlephilhower has quit IRC | 16:56 | |
*** pots has joined #openstack-cinder | 16:57 | |
*** salv-orlando has quit IRC | 16:57 | |
*** earlephilhower has joined #openstack-cinder | 16:58 | |
*** julim has quit IRC | 16:58 | |
*** julim has joined #openstack-cinder | 17:01 | |
*** annegentle has quit IRC | 17:01 | |
*** xyang has quit IRC | 17:03 | |
*** lcurtis has joined #openstack-cinder | 17:06 | |
geguileo | xiaohui: ping | 17:07 |
*** tpsilva has quit IRC | 17:08 | |
*** sgotliv has quit IRC | 17:08 | |
*** rushil has quit IRC | 17:08 | |
*** lpetrut has quit IRC | 17:10 | |
*** lpetrut has joined #openstack-cinder | 17:10 | |
*** xyang has joined #openstack-cinder | 17:11 | |
*** e0ne has quit IRC | 17:12 | |
*** pv_ has joined #openstack-cinder | 17:13 | |
*** afazekas__ has quit IRC | 17:14 | |
pv_ | i had a quick question on LUNids, how do I programatically pull the LUN id for a device? | 17:14 |
pv_ | currently im hardcoding it and my attach works, but im not sure how to do it dynamically in my code | 17:14 |
*** p0rtal has quit IRC | 17:18 | |
*** earnthis has joined #openstack-cinder | 17:22 | |
*** tpsilva has joined #openstack-cinder | 17:23 | |
earnthis | probably not the best place to ask but im looking for some info on platform9s integration with cinder and storage backends other than solidfire | 17:23 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 17:25 |
DuncanT | earnthis: I'm afraid I don't even know what platform9 is, sorry | 17:27 |
DuncanT | pv_: If it's not in the return value from initialize_connection then I'd be reasonably sure it is constant | 17:28 |
earnthis | DuncanT: no worries, it's a software based controller for openstack | 17:28 |
pv_ | yeah i know it needs to be in the return structure from initialize_connection, but im not sure how to set it in that structure before returning it. Currently I have the 'target_lun' field hardcoded to 0 and then i return the structure | 17:29 |
pv_ | in initialize_connection | 17:29 |
pv_ | im trying to figure out how to dynamically get the correct lun id, especially when i have more than one device | 17:30 |
DuncanT | pv_: Surely that is backend-specific? | 17:30 |
pv_ | probably haha i just wanted to know if you guys knew of a way, i know how to get the lun id from the command line using lsscsci etc | 17:31 |
*** dims_ has quit IRC | 17:33 | |
*** stefan_amann has quit IRC | 17:33 | |
*** markvoelker has joined #openstack-cinder | 17:35 | |
*** markvoelker has quit IRC | 17:35 | |
*** dims has joined #openstack-cinder | 17:35 | |
*** markvoelker has joined #openstack-cinder | 17:36 | |
openstackgerrit | Kurt Martin proposed openstack/python-cinderclient: Volume migration progress https://review.openstack.org/218145 | 17:37 |
*** p0rtal has joined #openstack-cinder | 17:38 | |
*** aix has quit IRC | 17:40 | |
*** stefan_amann has joined #openstack-cinder | 17:46 | |
*** merooney has quit IRC | 17:47 | |
patrickeast | jungleboyj: DuncanT: hey, so with the two +2's from you guys and the decision at the meeting would one of you feel comfortable +A'ing this https://review.openstack.org/#/c/213855 ? | 17:48 |
*** thangp has quit IRC | 17:49 | |
*** thangp_ has joined #openstack-cinder | 17:49 | |
jungleboyj | patrickeast: A fine 30 year McCallen should be sent to ... | 17:50 |
patrickeast | jungleboyj: haha | 17:50 |
patrickeast | jungleboyj: how about some sake in tokyo? | 17:51 |
DuncanT | patrickeast: Yes. I'm more of a highlands man myself, nothing too peaty please | 17:51 |
DuncanT | (Approved) | 17:51 |
patrickeast | thanks! | 17:52 |
jungleboyj | Happy Trails! | 17:52 |
jungleboyj | It has been +A'd twice! | 17:52 |
patrickeast | twice as good! | 17:52 |
DuncanT | We'll need the AA after all the Sake.... | 17:52 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 17:54 |
jungleboyj | DuncanT: Nice! | 17:55 |
jungleboyj | Yes, Sake will do. | 17:55 |
hemna | Sake bomb! | 17:55 |
*** dustins has quit IRC | 17:56 | |
xyang | jungleboyj, DuncanT, hemna, can someone help review this? https://review.openstack.org/#/c/215530/ | 17:56 |
*** tpsilva has quit IRC | 17:58 | |
hemna | man | 17:58 |
hemna | maybe I'm a bummer, but when do we stop allowing new features in ? | 17:59 |
*** dustins has joined #openstack-cinder | 17:59 | |
*** stefan_amann has quit IRC | 17:59 | |
xyang | hemna: well, if we want to have more than 1 implementation, this is good to have | 18:00 |
hemna | I'm all for being flexible, but it's started to seem like we're just allowing anything in. | 18:00 |
hemna | xyang, sure, but when do we stop? | 18:00 |
diablo_rojo | jgriffith: I heard you were interested in helping with the genconfig patch, so I pushed up what I have so far. If you have any questions I will do my best to answer them :) https://review.openstack.org/#/c/219700/ | 18:00 |
hemna | we can't be doing this all the way up to RC1 ? | 18:01 |
jgriffith | diablo_rojo: saw it thanks! | 18:01 |
jgriffith | diablo_rojo: so I think a hybrid of what you have and what I've got going would be most excellent | 18:01 |
diablo_rojo | jgriffith: Cool :) | 18:01 |
jgriffith | diablo_rojo: my changes aren't up, but I've been building the opts files by hand | 18:01 |
*** kmartin_ has joined #openstack-cinder | 18:02 | |
jgriffith | diablo_rojo: ultimately we want it to look "just like" what nova has | 18:02 |
jungleboyj | hemna: Back and for the reviews go, where they stop, no body knows! | 18:02 |
jgriffith | diablo_rojo: with a gen.config file, and use the oslo genconfig tool only | 18:02 |
hemna | diablo_rojo, you have lots of pep8's that need to be hashed out | 18:02 |
jgriffith | diablo_rojo: the part I was workign on finishing was the opt files in each module | 18:02 |
diablo_rojo | jgriffith: Yeah I figured it was best to come up with a way to generate it rather than do it by hand | 18:02 |
jungleboyj | hemna: -1 .... -1! | 18:03 |
*** kmartin has quit IRC | 18:03 | |
*** mdenny has quit IRC | 18:03 | |
*** MIDENN_ has quit IRC | 18:03 | |
diablo_rojo | jgriffith: I just fixed them and I will push up something fixing the pep8 errors in a few min | 18:03 |
*** mdenny has joined #openstack-cinder | 18:03 | |
*** MIDENN_ has joined #openstack-cinder | 18:03 | |
jgriffith | diablo_rojo: so it looks like this: https://github.com/openstack/nova/blob/master/etc/nova/nova-config-generator.conf | 18:03 |
jgriffith | diablo_rojo: and this https://github.com/openstack/nova/blob/master/nova/compute/opts.py | 18:03 |
*** merooney has joined #openstack-cinder | 18:04 | |
jgriffith | diablo_rojo: and most importantly https://github.com/openstack/nova/blob/master/tox.ini#L140 | 18:04 |
diablo_rojo | jgriffith: I spent some time looking at those in the early stages of this patch | 18:04 |
jgriffith | diablo_rojo: so what I have now is everything up to the "opt.py" files | 18:04 |
jgriffith | diablo_rojo: I *think* that the script you have there will automate that part for me | 18:04 |
diablo_rojo | jgriffith: the first and third link you just sent are basically the same as what I have going in the setup.cfg and the cinder.conf | 18:04 |
jgriffith | diablo_rojo: "us" | 18:05 |
jgriffith | as opposed to me using grep/awk/sed etc | 18:05 |
jgriffith | cinder.conf? | 18:05 |
jgriffith | setup.cfg yes... same deal | 18:05 |
diablo_rojo | yeah in the new config dir that I created | 18:05 |
*** markvoelker has quit IRC | 18:05 | |
diablo_rojo | yes | 18:05 |
jgriffith | wait... hold on | 18:05 |
jgriffith | diablo_rojo: oh.. yeah; you need to change that name :) | 18:06 |
jgriffith | diablo_rojo: s/cinder.conf/cinder-genconfig.conf/ | 18:06 |
diablo_rojo | okay | 18:06 |
diablo_rojo | I will do that with the pep8 fixes | 18:06 |
jgriffith | or... cinder-cofnig-generator.conf :) | 18:07 |
jgriffith | config even | 18:07 |
*** bill_az_ has joined #openstack-cinder | 18:07 | |
diablo_rojo | do you have a preference? | 18:07 |
jgriffith | the second one for consistency | 18:07 |
*** earnthis has quit IRC | 18:07 | |
openstackgerrit | Tiago Pasqualini da Silva proposed openstack/cinder: Fix HDS HNAS driver logging password as plain text https://review.openstack.org/219810 | 18:07 |
diablo_rojo | okay done :) | 18:07 |
jgriffith | diablo_rojo: so if you're script works (I haven't had a chance to try it) you shouldn't submit the script, but the resultant opt files | 18:07 |
jgriffith | diablo_rojo: awesome, thanks! | 18:08 |
jgriffith | I'll get to it after lunch (I hope) | 18:08 |
diablo_rojo | You mean the patch should just be the opt file that's generated? | 18:08 |
jgriffith | diablo_rojo: correct | 18:08 |
*** tpsilva has joined #openstack-cinder | 18:09 | |
diablo_rojo | but not the script that generates it? | 18:09 |
jgriffith | diablo_rojo: indeed | 18:09 |
jgriffith | diablo_rojo: after the initial impl is done, it's up to those adding conf options to update those files | 18:09 |
diablo_rojo | I don't follow that reasoning. | 18:09 |
jgriffith | diablo_rojo: ok | 18:10 |
diablo_rojo | Why wouldn't we want to have that out there so that when new opts get added it can be run? | 18:10 |
jgriffith | diablo_rojo: some think of it as that pesky thing called source control | 18:10 |
jgriffith | diablo_rojo: ok, your call | 18:10 |
jgriffith | but it doesn't really work that way | 18:10 |
diablo_rojo | I could very well be incorrect, just trying to understand :) | 18:11 |
jgriffith | diablo_rojo: so that means you have a dirty tree to gen config | 18:11 |
jgriffith | diablo_rojo: the problem with that approach is that you end up with opt.py files scattered throughout tree when you run your script | 18:11 |
jgriffith | diablo_rojo: not a huge deal | 18:11 |
diablo_rojo | Ah. | 18:11 |
jgriffith | diablo_rojo: my suggestion would be a hybrid | 18:11 |
jgriffith | diablo_rojo: provide the tool in tools/configxxxx | 18:12 |
jgriffith | diablo_rojo: so people can regenerate | 18:12 |
diablo_rojo | I was planning to add to generate_sample.sh to remove the opt file after oslo config had been run and done whatever it needs to do | 18:12 |
jgriffith | diablo_rojo: but use what's in tree to do the actual work | 18:12 |
diablo_rojo | Hadn't gotten that far yet :) | 18:12 |
jgriffith | diablo_rojo: yeah.... I get nervous swapping things in and out of tree :) | 18:12 |
jgriffith | diablo_rojo: plus then it's kinda "magic" | 18:12 |
diablo_rojo | magic is awesome! :) | 18:13 |
jgriffith | magic==bad | 18:13 |
jgriffith | :) | 18:13 |
diablo_rojo | haha awww :( | 18:13 |
jgriffith | voodoo==good | 18:13 |
jgriffith | magic==bad | 18:13 |
DuncanT | hemna: We do need to put a cap on it | 18:13 |
jgriffith | magic is for manequins and funny people in top-hats | 18:13 |
DuncanT | hemna: But we also need to try to ballance that against the gate issues and other lack of last-minute throughput | 18:14 |
diablo_rojo | jgriffith: so I shouldnt add to generate_sample to remove the opts.py file that gets generated after oslo config has been run? | 18:14 |
jgriffith | Ok, so much for my statement earlier that we're all professional adults and can use our judgement | 18:14 |
jgriffith | DuncanT: hemna ^^ | 18:14 |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix HDS HNAS driver logging password as plain text https://review.openstack.org/219810 | 18:15 |
jgriffith | DuncanT: hemna patrickeast jungleboyj I'm just going to -2 everything that's submitted right now | 18:16 |
jgriffith | we're done here | 18:16 |
jgriffith | and that means all of it | 18:16 |
jgriffith | migration, replication, snapshots etc | 18:17 |
DuncanT | jgriffith: If that's your call, I won't argue. Somebody needs to make the call at some point | 18:17 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 18:17 |
*** merooney has quit IRC | 18:17 | |
hemna | jgriffith, I'm ok with that. | 18:18 |
hemna | DuncanT, like I said, I'm all for being flexible | 18:19 |
xyang | I thought someone mentioned to have more than 1 implementation during the meeting. so I thought there may be some benefit to have it in. If you guys don't want it, I'm fine with that | 18:19 |
hemna | but at some point we need to put the brakes on, so help solidify the release. | 18:19 |
*** p0rtal_ has joined #openstack-cinder | 18:19 | |
openstackgerrit | Kendall Nelson proposed openstack/cinder: WIP: Dynamically create cinder.conf.sample https://review.openstack.org/219700 | 18:19 |
*** annegentle has joined #openstack-cinder | 18:20 | |
hemna | diablo_rojo, see my review comments ? | 18:20 |
diablo_rojo | hemna: Oh crap, no., Looking now. | 18:21 |
jgriffith | hemna: DuncanT jungleboyj xyang so at this point, bugs (real bugs) ok, features done | 18:21 |
jgriffith | too bad | 18:21 |
jgriffith | I would've liked to have seen the generic migration go through | 18:21 |
jgriffith | but it's ridiculous at this point that we've picked at it for a week | 18:21 |
erlon | jgriffith: hi, you must be full of hearing this question but, the -2 weren't for features? | 18:22 |
hemna | well the PTL isn't here, so it's up to us to decide when enough is enough. | 18:22 |
diablo_rojo | hemna: I'll make sure to address the few that I missed in the next patch. Thank you :) | 18:22 |
*** julim has quit IRC | 18:22 | |
jgriffith | erlon: all features at this point get a -2 | 18:22 |
hemna | diablo_rojo, np | 18:22 |
erlon | jgriffith: how about bugfixes? | 18:22 |
*** p0rtal has quit IRC | 18:23 | |
jgriffith | erlon: let people review them | 18:23 |
erlon | feature == feature + bugfix? | 18:23 |
jgriffith | erlon: What? | 18:23 |
*** merooney has joined #openstack-cinder | 18:23 | |
erlon | jgriffith: is was never clear to me what feature freeze means, does that means any change in code? | 18:23 |
DuncanT | erlon: Bug fixes only, no new features or functionality | 18:24 |
erlon | jgriffith: you have just -2 this bugfix: https://review.openstack.org/#/c/219810/ | 18:24 |
jgriffith | hemna: DuncanT jungleboyj just to point out, the other thing is people can submit whatever they want, people don't have to review it | 18:26 |
jgriffith | as far as I'm concerned I could care less what gets submitted, I just pick what I review and what I don't | 18:26 |
jgriffith | :) | 18:26 |
*** rushil has joined #openstack-cinder | 18:27 | |
hemna | lol | 18:28 |
hemna | so no bug fixes either? | 18:29 |
hemna | haha | 18:29 |
hemna | man | 18:29 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 18:29 |
jgriffith | hemna: bug fixes? | 18:29 |
DuncanT | jgriffith: Anything that looks like it is clearly a feature you should -2 so people like me who are careless don't merge it by mistake | 18:30 |
DuncanT | jgriffith: (IMO, naturally) | 18:30 |
jgriffith | DuncanT: hehe | 18:30 |
jgriffith | DuncanT: honeslty it doesn't matter | 18:30 |
jgriffith | people don't seem to get what i've been saying | 18:30 |
jgriffith | given gate backlog and cut time, most of this stuff isn't going anywhere anyway | 18:31 |
openstackgerrit | Yuriy Nesenenko proposed openstack/python-cinderclient: Remove duplicate code in functional tests https://review.openstack.org/219772 | 18:31 |
hemna | yah there are -2's on bugfixes now | 18:31 |
jgriffith | hemna: where... I'll fix if so | 18:31 |
hemna | https://review.openstack.org/#/c/211299/ | 18:31 |
hemna | that looks like a fix to me | 18:31 |
jgriffith | hemna: by the way... wasn't your quote that this was out of control or somehting like that? | 18:31 |
jgriffith | hemna: fixed | 18:32 |
hemna | *sigh* | 18:32 |
jgriffith | hemna: what "sigh" | 18:32 |
DuncanT | jgriffith: Any way the wind blows? | 18:32 |
jgriffith | DuncanT: apprantly so | 18:32 |
jgriffith | first he's upset there's stuff being proposed, then he's upset it got a -2 | 18:33 |
jgriffith | confusing | 18:33 |
hemna | I simply asked when do we stop allowing new features in, and also said that I was all for being flexible. | 18:33 |
openstackgerrit | abhiram moturi proposed openstack/cinder: ZFSSA driver to return project 'available' space https://review.openstack.org/211299 | 18:33 |
jgriffith | hemna: weren't you in the meeting this morning? | 18:34 |
*** aix has joined #openstack-cinder | 18:34 | |
hemna | yup | 18:34 |
*** esker has joined #openstack-cinder | 18:34 | |
jgriffith | hemna: as far as I was concerened and what I proposed was people can submit whatever they want | 18:34 |
hemna | sure, that's always the case | 18:34 |
jgriffith | hemna: and that it was up to the core team to be professional and excercise good judgment by reviewing things | 18:35 |
*** esker has quit IRC | 18:35 | |
jgriffith | hemna: that all I cared about was that nothing effecting core project was added (feature) | 18:35 |
jgriffith | and that NOTHING was at the expense of items that were on Launchpad | 18:35 |
*** esker has joined #openstack-cinder | 18:35 | |
jgriffith | but apparantly you weren't happy about that... nor was Duncan | 18:35 |
hemna | yah that's fine, I just was asking when we actually cut it off. | 18:36 |
jgriffith | so I can take the A-hole approach and just say "were' done" | 18:36 |
jgriffith | but people don't like that either | 18:36 |
jgriffith | it's funny to me | 18:36 |
*** merooney has quit IRC | 18:36 | |
jgriffith | hemna: what does that question even mean? | 18:36 |
hemna | I dunno man, I think that's a bit extreme. I just wanted to ask a question and see when if we wanted the release feature freeze to actually happen, so we can focus on bug fixes. | 18:36 |
jgriffith | hemna: so the RC gets cut tonight/tomorrow as I said before | 18:37 |
jgriffith | hemna: but nobody is telling you "this is what you work on or don't" | 18:37 |
jgriffith | you get to work on whatever you want :) | 18:37 |
jgriffith | hemna: so which do you want? | 18:38 |
jgriffith | hemna: what do you recommend? | 18:38 |
jgriffith | hemna: I'd like your input about a solution | 18:38 |
hemna | like I said earlier, I'm all for being flexible due to the normal gate/check issues and just wanted to find out what makes sense. | 18:39 |
hemna | that's all | 18:39 |
jgriffith | hemna: ok, that's not a *solution* | 18:39 |
jgriffith | hemna: how about this | 18:39 |
jgriffith | hemna: I'll clear out my votes | 18:39 |
jgriffith | and someobdy else can try and manage it | 18:39 |
simondodsley | holding my tongue - here - especially after the meeting we just had where we were going to let the team decide.... | 18:40 |
simondodsley | and this is just me talking - nothing to do with who i work for | 18:40 |
hemna | simondodsley, yah and I think that's fine. I just didn't think asking a question of when the cutoff is going to happen, turns into -2 mass reviews. | 18:41 |
*** e0ne has joined #openstack-cinder | 18:42 | |
jgriffith | hemna: there ya go clean slate | 18:43 |
hemna | jgriffith, I'm sorry if I caused any confusion. it was not my intention. | 18:43 |
jgriffith | hemna: NOW, what is it you would like here? | 18:43 |
*** shyama has quit IRC | 18:43 | |
*** martyturner has quit IRC | 18:48 | |
*** martyturner has joined #openstack-cinder | 18:50 | |
jgriffith | Ok... for anybody still listening that might be here :) | 18:53 |
hemna | :) | 18:53 |
openstackgerrit | Tiago Pasqualini da Silva proposed openstack/cinder: Fix HDS HNAS driver logging password as plain text https://review.openstack.org/219810 | 18:53 |
jgriffith | I want to just reiterate how things work and where the release is at | 18:53 |
jgriffith | The idea is anything that was listed as targeted for L3 is something that was determined as being important for the relase | 18:54 |
jgriffith | all I care about is that those things merge | 18:54 |
*** harlowja has quit IRC | 18:54 | |
jgriffith | after that, if people have last minute bug-fixes, or small changes then that's absolutely cool by me | 18:54 |
jgriffith | things should be treated similar to how we treat backports (safe, low impact and generally speaking not a feature) | 18:55 |
jgriffith | Finally, as I pointed out before, nobody has to review anything if they don't want to :) | 18:55 |
*** julim has joined #openstack-cinder | 18:56 | |
Swanson | 5 hours to go. Ain't nothin else getting in. | 18:56 |
jgriffith | and a lot of this is sort of silly anyway, because the reality is if you keep tweaking/updating it will never get through the gates and merge before RC is cut anyway :) | 18:56 |
jgriffith | Swanson: nahh... that's not what I was saying | 18:56 |
jgriffith | Swanson: what i was saying was that the cut off items are in | 18:56 |
jgriffith | Swanson: and if there are things people want to review and feel are safe to go in and are not just pure feature merges that that's probably ok | 18:57 |
*** harlowja has joined #openstack-cinder | 18:58 | |
jgriffith | Swanson: the one disturbing thing is that there are items that were stated as "done" last week that have had significant updates since last night and this morning (and not to address a bug etc) | 18:58 |
jgriffith | which is too bad, and kinda screws things up for everyone | 18:58 |
jgriffith | anyway..... | 18:58 |
jgriffith | sorry this has been such a confusing thing for everyone | 18:59 |
Swanson | jgriffith: Not bug fixes but finishing features? | 18:59 |
jgriffith | Swanson: see.. this is the thing | 18:59 |
hemna | ok bbiab....lunch | 18:59 |
Swanson | jgriffith: The overnight stuff | 18:59 |
simondodsley | jgriffith: it that were the case why bother removing the blocks on generic image cache, or even to that point, why block them in the first place | 18:59 |
*** markvoelker has joined #openstack-cinder | 19:00 | |
jgriffith | simondodsley: what do you mean? | 19:00 |
jgriffith | simondodsley: so let me back up a bit | 19:00 |
simondodsley | you said that with only 5 hours to go nothing will get through anyway | 19:00 |
jgriffith | Swanson: said that :) | 19:00 |
Swanson | simondodsley: I think I said that. | 19:00 |
jgriffith | [12:56:13] Swanson:5 hours to go. Ain't nothin else getting in. | 19:01 |
simondodsley | ok - misread - apologies | 19:01 |
*** martyturner has quit IRC | 19:01 | |
jgriffith | simondodsley: by the way... something that folks don't always see/realize, is that for the last week I've been getting all the PM's and everything asking "what abou tthis, can I do that, this doesn't seem fair" etc etc | 19:02 |
jgriffith | simondodsley: my feeling is that we are adults we can manage ourselves and do what we need to do | 19:02 |
Swanson | I assumed we had 5 hours for features and bugfixes until the end. Pending begging to be added. | 19:02 |
jgriffith | simondodsley: but when people keep pinging me and saying "they don't know what to do" it seems like maybe I'm wrong :) | 19:02 |
jgriffith | simondodsley: and I put a -2 on things because a number of people were complaing and pissed because everybody is continuing to iterate on their features | 19:03 |
*** julim_ has joined #openstack-cinder | 19:03 | |
jgriffith | simondodsley: frankly I don't really care much... if they screw around too much it's not going to matter anyway | 19:03 |
simondodsley | jgriffith: i get that you are being bombarded with stuff and we appreciate you taking on the role from thingee in this busy period, but that last -2 of everything seemed a little harsh. Some things weren't being iterated apart from stupid -1's for grammar | 19:03 |
jgriffith | simondodsley: two things: | 19:04 |
jgriffith | 1. I removed the -2's | 19:04 |
simondodsley | jgriffith: yes - but why do them in the first place? | 19:04 |
jgriffith | 2. the nit thing is not my problem, take it up with the nit-picker :) | 19:04 |
simondodsley | jgriffith: and i do... | 19:05 |
Swanson | It did get your attention... | 19:05 |
simondodsley | jgriffith: i send a lot of comments back about grammatical -1s that should be 0 | 19:05 |
jgriffith | simondodsley: I did it in the first place because a number of core folks were coming to me and saying "I don't know what to do" "this is crazy" "aren't we done yet" 'when do we stop" | 19:05 |
*** martyturner has joined #openstack-cinder | 19:05 | |
jgriffith | Swanson: and yes, that was the point more than anything else | 19:05 |
*** julim has quit IRC | 19:06 | |
jgriffith | simondodsley: everybody here is supposed to be working together | 19:06 |
jgriffith | simondodsley: not off on their own agendas, and we're supposed to be making Cinder better, NOT just our product/driver | 19:06 |
jgriffith | especially at this phase of the release | 19:07 |
simondodsley | jgriffith: I don't diagree...anyway this is probably better discussed over a sake in Tokyo | 19:08 |
*** coolsvap_ has joined #openstack-cinder | 19:09 | |
jgriffith | simondodsley: I'd argue there's nothing to really discuss :) | 19:09 |
jgriffith | people here know what's right/wrong and what they should be doing | 19:09 |
jgriffith | they don't need somebody to tell them those things | 19:09 |
simondodsley | jgriffith: well I might still buy you a sake anyway :) | 19:10 |
jgriffith | simondodsley: well I'll certainly drink it :) | 19:11 |
*** merooney has joined #openstack-cinder | 19:11 | |
*** e0ne has quit IRC | 19:12 | |
*** JoseMello has joined #openstack-cinder | 19:13 | |
* patrickeast is catching up | 19:13 | |
jgriffith | patrickeast: lol.. don't bother | 19:14 |
jgriffith | it's not that interesting | 19:14 |
patrickeast | jgriffith: lol | 19:14 |
patrickeast | jgriffith: so to clarify (and take back up the ladder) the line is drawn, no more features | 19:14 |
patrickeast | yea? | 19:14 |
patrickeast | jgriffith: looks like yes | 19:14 |
jgriffith | patrickeast: you're core, what do you want to do? | 19:15 |
* patrickeast isn't core :( | 19:15 | |
jgriffith | patrickeast: Whaaaa | 19:15 |
patrickeast | i kno right | 19:15 |
*** adrianofr has joined #openstack-cinder | 19:15 | |
simondodsley | saying nothing | 19:15 |
jgriffith | well in that case my apologies | 19:15 |
jgriffith | I'll see what we can do | 19:15 |
jgriffith | simondodsley: what's that mean? | 19:15 |
simondodsley | jgriffith: I've been asking patrickeast about him being a core that's all | 19:16 |
jgriffith | ahh | 19:16 |
jgriffith | anyway | 19:16 |
jgriffith | so patrickeast my opinion is the same as it was this morning... work on what you work on. | 19:16 |
jgriffith | so long as the L3 items are taken care of | 19:17 |
*** annegentle has quit IRC | 19:17 | |
*** Yogi1 has quit IRC | 19:17 | |
patrickeast | jgriffith: the ones left here, https://launchpad.net/cinder/+milestone/liberty-3 ? | 19:17 |
jgriffith | and nobody merges anything that is brand new feature or places any risk to anything I personally feel that reviewers should be able to use their own judgement | 19:17 |
patrickeast | or were there more still? | 19:17 |
pv_ | "everybody here is supposed to be working together" | 19:17 |
pv_ | brought a tear to my eye | 19:17 |
patrickeast | jgriffith: yea that makes sense | 19:17 |
jgriffith | patrickeast: that's it | 19:17 |
patrickeast | kk | 19:17 |
jgriffith | patrickeast: :) | 19:18 |
jgriffith | err | 19:18 |
jgriffith | pv_: :) | 19:18 |
jgriffith | pv_: mine too | 19:18 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races from delete methods https://review.openstack.org/205835 | 19:21 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add atomic conditional updates to objects https://review.openstack.org/205834 | 19:21 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: WIP: Remove more API races https://review.openstack.org/216378 | 19:21 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Move get_by_id to CinderObject https://review.openstack.org/218012 | 19:21 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Improve metadata update operations https://review.openstack.org/216376 | 19:21 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races from attach and detach methods https://review.openstack.org/216377 | 19:21 |
*** bill_az_ has quit IRC | 19:23 | |
*** rushil has quit IRC | 19:23 | |
jgriffith | geguileo: so for the most part those changes have looked good to me | 19:24 |
jgriffith | geguileo: but I am kinda nervous about DB changes hours before RC | 19:24 |
geguileo | jgriffith: You mean those patches I just updated? | 19:24 |
jgriffith | geguileo: am I being paranoid? | 19:24 |
jgriffith | :) | 19:24 |
geguileo | jgriffith: No, no, you are totally right | 19:24 |
geguileo | jgriffith: This is NOT to be included now | 19:24 |
geguileo | jgriffith: That would be irresponsible on our part | 19:25 |
jgriffith | :) | 19:25 |
geguileo | jgriffith: But I have to keep working on them ;-) | 19:26 |
*** BharatK has quit IRC | 19:26 | |
jgriffith | geguileo: yes | 19:26 |
*** Yogi1 has joined #openstack-cinder | 19:26 | |
jgriffith | geguileo: and I was -1 workflowing them so as to avoid confusion, but maybe you could do that for me :) | 19:26 |
geguileo | jgriffith: Ok, doing it right now | 19:26 |
jgriffith | geguileo: I appreciate that | 19:27 |
jgriffith | geguileo: thank you | 19:27 |
geguileo | jgriffith: np | 19:27 |
patrickeast | hemna: so https://review.openstack.org/#/c/195795 is ready for a +A again? | 19:28 |
*** hideme has quit IRC | 19:30 | |
*** Guest16076 has joined #openstack-cinder | 19:30 | |
*** garthb_ has joined #openstack-cinder | 19:33 | |
*** garthb has quit IRC | 19:35 | |
*** annegentle has joined #openstack-cinder | 19:35 | |
hodos | thingee: hi, what are the deadlines for M release for thirdparty drivers to get in? | 19:36 |
jgriffith | hodos: I don't know that there is one, but I suspect it will be similar to the L release; something like the first milestone | 19:37 |
hodos | jgriffith: i would like to know more precisely, so we don't get thrown out llike happened in L | 19:39 |
*** tpsilva has quit IRC | 19:42 | |
*** lpetrut has quit IRC | 19:44 | |
*** coolsvap_ has quit IRC | 19:45 | |
*** esker has quit IRC | 19:48 | |
jgriffith | hodos: afraid you're asking the wrong person | 19:49 |
jgriffith | hodos: you'll have to wait for thingee to get back from vacation | 19:50 |
hodos | jgriffith: ok, i was asking thingee at the first place:) | 19:50 |
*** martyturner has quit IRC | 19:50 | |
jgriffith | hodos: I'm curious, why don't you just submit as soon as M opens up? | 19:50 |
hodos | jgriffith: i will | 19:51 |
jgriffith | hodos: and I was TRYING to be helpful as he's on vacation and you would not get a response | 19:51 |
hodos | jgriffith: thanks john | 19:51 |
*** martyturner has joined #openstack-cinder | 19:52 | |
*** julim_ has quit IRC | 19:56 | |
jgriffith | hodos: np | 19:57 |
*** erhudy has joined #openstack-cinder | 20:00 | |
*** garthb_ has quit IRC | 20:02 | |
erhudy | jgriffith: do you have a moment | 20:02 |
*** garthb_ has joined #openstack-cinder | 20:02 | |
jgriffith | erhudy: sure, what's up? | 20:03 |
erhudy | i just wanted to understand your comment here: https://review.openstack.org/#/c/217857/6/cinder/volume/flows/api/create_volume.py | 20:03 |
*** bill_az_ has joined #openstack-cinder | 20:03 | |
erhudy | since i'm not sure if you have another log message in mind you want me to make it consistent with | 20:04 |
jgriffith | erhudy: Ahh.. | 20:04 |
jgriffith | so we have this cool new thing added to Logging | 20:04 |
jgriffith | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L363 | 20:05 |
erhudy | i see | 20:05 |
erhudy | so supply source_volume to that | 20:05 |
jgriffith | erhudy: so that little beauty will auto format the volume id, request id etc all in the log mesage | 20:05 |
Swanson | jgriffith: Is hodos question a thingee question? I didn't think he was running for Cinder Project Team Dad after serving two terms. | 20:05 |
*** merooney has quit IRC | 20:06 | |
jgriffith | Swanson: Oh? I hadn't heard that | 20:06 |
jgriffith | Swanson: I don't know | 20:06 |
jgriffith | erhudy: so yeah, you pass in a v reference there | 20:06 |
*** crose has quit IRC | 20:07 | |
erhudy | k | 20:07 |
jgriffith | erhudy: and it works for exception messages to, you can see other examples in the manager file there | 20:07 |
Swanson | jgriffith: I don't know if that's true as I don't remember where I heard it. | 20:07 |
erhudy | i reverted the POT changes, i guess i should just leave those alone? | 20:07 |
jgriffith | erhudy: for cases where you don't have a full/valid ref you can also put in manually | 20:07 |
*** merooney has joined #openstack-cinder | 20:07 | |
jgriffith | erhudy: cool! Yeah, those are "automagic" | 20:07 |
erhudy | k | 20:07 |
openstackgerrit | John Griffith proposed openstack/cinder: Add mechanism to update snapshot provider_id https://review.openstack.org/219864 | 20:10 |
angela-s | jgriffith: question, i have code reviews that were pending on CI, but the specs were also on hold waiting for CI. thingee has given -2 to the specs back in kilo. can they be approved now that CI is up? | 20:12 |
jgriffith | angela-s: sure, but honeslty I wouldn't worry about the specs right now | 20:12 |
*** merooney has quit IRC | 20:12 | |
jgriffith | angela-s: we can deal with updating those later | 20:12 |
jgriffith | angela-s: he downvoted specs or CI? | 20:12 |
jgriffith | that seems odd | 20:12 |
angela-s | jgriffith: ok. how about code review? thingee had given -2 on one of them, does he need to rescind before it can get approved? | 20:13 |
jgriffith | angela-s: unfortunately he's the only one that can remove that | 20:13 |
angela-s | jgriffith: downvoted specs because CI was not up | 20:14 |
jgriffith | vim | 20:17 |
jgriffith | derp | 20:17 |
*** simondodsley has quit IRC | 20:18 | |
jgriffith | angela-s: so I don't have the foo to override that, you probably want/need to check with him when he returns | 20:20 |
angela-s | jgriffith: sure, thanks for the info. i'll follow up with him | 20:21 |
*** markvoelker has quit IRC | 20:21 | |
*** pots has quit IRC | 20:22 | |
*** rbradbury has joined #openstack-cinder | 20:22 | |
openstackgerrit | John Griffith proposed openstack/cinder: Add mechanism to update snapshot provider_id https://review.openstack.org/219864 | 20:22 |
*** pots has joined #openstack-cinder | 20:22 | |
*** Lee1092 has quit IRC | 20:23 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Fix problem of efficient volume copy for migration https://review.openstack.org/219867 | 20:23 |
openstackgerrit | Edmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder https://review.openstack.org/217857 | 20:25 |
*** rushil has joined #openstack-cinder | 20:25 | |
*** lpetrut has joined #openstack-cinder | 20:25 | |
mtanino | oh,,, this patch https://review.openstack.org/#/c/187270/ was merged with message '(Pulled from gate, cinder can no longer pass unit tests)'... | 20:29 |
*** rushil has quit IRC | 20:30 | |
hemna | uhhh | 20:30 |
*** MrJamesK_away has quit IRC | 20:30 | |
*** timcl has quit IRC | 20:31 | |
*** bswartz has quit IRC | 20:31 | |
mtanino | :( | 20:31 |
hemna | mtanino, I think the commit message was updated when we had gate problems | 20:32 |
mtanino | hemna: yes, sdange udpated the message. | 20:32 |
mtanino | hemna: but no one does not care after the problem was fixed... I guess | 20:33 |
mtanino | no one care.. | 20:33 |
hemna | mtanino, yah, I don't think it matters now though | 20:34 |
hemna | tests are passing afaik | 20:34 |
mtanino | hemna: yes, just I noticed it was still remained and there is no problem on our tests now :) | 20:35 |
*** e0ne has joined #openstack-cinder | 20:35 | |
*** markvoelker has joined #openstack-cinder | 20:37 | |
jbernard | mtanino: thanks for that patch | 20:38 |
jbernard | mtanino: sparse slipped by me | 20:38 |
mtanino | jbernard: sure. We don't have enough time to merge it into your patch... | 20:38 |
jbernard | mtanino: it's merged already, so we can only move forward now ;) | 20:38 |
jbernard | mtanino: will that make it past the freeze? i think it should | 20:39 |
hemna | jgriffith, so do we only have 1 High BP for L left ? capacity-headroom | 20:39 |
jbernard | mtanino: it's a bugfix so i guess it will | 20:39 |
mtanino | jbernard: I think it's bug fix, so we can make it. I guess | 20:39 |
eharney | yes, it's a regression with a simple fix, we need to land it | 20:39 |
mtanino | eharney: thank you. | 20:40 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add hypermetro support for Huawei driver https://review.openstack.org/202023 | 20:41 |
*** gouthamr has quit IRC | 20:42 | |
*** raildo is now known as raildo-afk | 20:43 | |
*** raildo-afk is now known as raildo | 20:43 | |
*** julim has joined #openstack-cinder | 20:43 | |
*** harlowja has quit IRC | 20:45 | |
hemna | jungleboyj, ping | 20:47 |
*** markvoelker has quit IRC | 20:48 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Calculate virtual free capacity and notify https://review.openstack.org/206923 | 20:51 |
*** ociuhandu has quit IRC | 20:54 | |
*** julim has quit IRC | 20:57 | |
openstackgerrit | Patrick East proposed openstack/cinder: Get full volume model in Replication manager API’s https://review.openstack.org/219874 | 20:59 |
openstackgerrit | Patrick East proposed openstack/cinder: Use consolidated update for failover_replication https://review.openstack.org/219875 | 20:59 |
patrickeast | jgriffith: ^ not sure if you already had something for those, let me know if they look sane and i'll update the unit tests later today and test em a bit more thoroughly | 21:00 |
patrickeast | had the code sitting on a branch, figured i might as well put it up for review and file the bugs for em | 21:01 |
*** ronis has quit IRC | 21:02 | |
*** lpetrut has quit IRC | 21:02 | |
*** dflorea has joined #openstack-cinder | 21:03 | |
*** thangp_ has quit IRC | 21:07 | |
*** raildo is now known as raildo-afk | 21:07 | |
*** xyang has quit IRC | 21:10 | |
*** edtubill1 has quit IRC | 21:15 | |
jgriffith | patrickeast: Oh... AWESOME! | 21:17 |
jgriffith | patrickeast: much better on that model_update, thanks! | 21:17 |
*** jwcroppe_ has joined #openstack-cinder | 21:17 | |
*** Yogi1 has quit IRC | 21:18 | |
*** chutwig has joined #openstack-cinder | 21:18 | |
*** jwcroppe has quit IRC | 21:19 | |
*** akerr has quit IRC | 21:19 | |
*** dims has quit IRC | 21:19 | |
*** dims has joined #openstack-cinder | 21:19 | |
*** harlowja has joined #openstack-cinder | 21:21 | |
*** edmondsw has quit IRC | 21:21 | |
*** chutwig is now known as erhudy1 | 21:22 | |
*** dims has quit IRC | 21:24 | |
jungleboyj | hemna: Pong. Sorry, stuck in meetings all afternoon. | 21:26 |
hemna | jungleboyj, so, what's the plan with this one ? https://review.openstack.org/#/c/206923/ | 21:26 |
hemna | it was failing jenkins prior to rebasing it | 21:27 |
hemna | so, there is that | 21:27 |
hemna | it's the last BP that is outstanding for L3 | 21:27 |
hemna | afaik | 21:27 |
jungleboyj | hemna: Looking. | 21:27 |
*** dflorea has quit IRC | 21:28 | |
jungleboyj | hemna: I don't know about this one. It touches scheduler, manager and volume utils. | 21:29 |
*** ociuhandu has joined #openstack-cinder | 21:29 | |
*** ociuhandu has quit IRC | 21:30 | |
*** ociuhandu has joined #openstack-cinder | 21:31 | |
*** e0ne has quit IRC | 21:32 | |
hemna | yup | 21:32 |
*** ociuhandu has quit IRC | 21:32 | |
*** e0ne has joined #openstack-cinder | 21:33 | |
*** ociuhandu has joined #openstack-cinder | 21:33 | |
*** porrua has quit IRC | 21:34 | |
jungleboyj | What do you think dude? | 21:34 |
hemna | well, it has to pass jenkins first to even have a chance | 21:34 |
*** martyturner has quit IRC | 21:34 | |
hemna | and I'd like winston to look at it | 21:35 |
jgriffith | jungleboyj: hemna FWIW, my vote on that one was no | 21:35 |
jgriffith | uberjay: hemna it got lost in the noise somewhere... | 21:35 |
jgriffith | oops... jungleboyj | 21:35 |
jungleboyj | Oh no! You have summoned uberjay! | 21:36 |
jgriffith | My opinion was that it doesn't add something to manager but modifies it, and that it's only for pools based devices etc | 21:36 |
jgriffith | haha | 21:36 |
jgriffith | who is uberjay anyhow? | 21:36 |
hemna | jgriffith, ah yah I see your questions on the 10th | 21:36 |
uberjay | haha :) | 21:36 |
uberjay | hi | 21:36 |
hemna | :P | 21:36 |
jgriffith | LOL | 21:36 |
uberjay | i see it was an accidental summoning :) | 21:37 |
hemna | yah, so I say we punt on this one as well. | 21:37 |
jgriffith | so if it was something like adding a manager call and exposing something,t hat would be different | 21:37 |
jungleboyj | jgriffith: hemna My feeling was it could way. | 21:37 |
hemna | lots of questions about it | 21:37 |
jgriffith | but frankly I don't really get the change to begin with :( | 21:37 |
jgriffith | I *think* it's just aggregating pool capacities.... | 21:38 |
jgriffith | but didn't see quite how/why it worked :) | 21:38 |
hemna | ok I -1'd it. | 21:38 |
hemna | it's unclear, and the commit message isn't overly informative on the approach/need | 21:39 |
*** dannywil_ has quit IRC | 21:40 | |
*** e0ne has quit IRC | 21:41 | |
*** e0ne has joined #openstack-cinder | 21:43 | |
*** dannywilson has joined #openstack-cinder | 21:47 | |
*** bill_az_ has quit IRC | 21:49 | |
*** e0ne has quit IRC | 21:52 | |
*** martyturner has joined #openstack-cinder | 21:53 | |
*** bill_az_ has joined #openstack-cinder | 21:55 | |
*** mriedem has quit IRC | 21:56 | |
*** akerr has joined #openstack-cinder | 21:57 | |
*** mtanino has quit IRC | 21:57 | |
*** bill_az has quit IRC | 21:58 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/python-cinderclient: Remove duplicate code in functional tests https://review.openstack.org/219772 | 21:59 |
*** akerr_ has joined #openstack-cinder | 21:59 | |
*** bkopilov has quit IRC | 22:01 | |
*** hemna is now known as hemnafk | 22:02 | |
*** akerr has quit IRC | 22:02 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/python-cinderclient: Remove duplicate code in functional tests https://review.openstack.org/219772 | 22:02 |
Swanson | Is L3 being tagged at midnight UTC? | 22:03 |
*** dustins has quit IRC | 22:03 | |
*** mtanino has joined #openstack-cinder | 22:05 | |
*** bkopilov has joined #openstack-cinder | 22:06 | |
*** IanGovett has quit IRC | 22:07 | |
*** IanGovett has joined #openstack-cinder | 22:08 | |
*** gouthamr has joined #openstack-cinder | 22:08 | |
*** annegentle has quit IRC | 22:08 | |
*** JoseMello has quit IRC | 22:09 | |
*** jaypipes has quit IRC | 22:10 | |
*** gouthamr_ has joined #openstack-cinder | 22:10 | |
*** IanGovett has quit IRC | 22:12 | |
*** rushil has joined #openstack-cinder | 22:13 | |
*** gouthamr has quit IRC | 22:14 | |
*** rushil_ has joined #openstack-cinder | 22:14 | |
*** pv_ has quit IRC | 22:16 | |
*** jgregor has left #openstack-cinder | 22:17 | |
*** rushil has quit IRC | 22:18 | |
*** jungleboyj has quit IRC | 22:18 | |
*** diogogmt has quit IRC | 22:19 | |
*** martyturner has quit IRC | 22:22 | |
*** bkopilov has quit IRC | 22:22 | |
*** gouthamr has joined #openstack-cinder | 22:23 | |
*** xyang has joined #openstack-cinder | 22:26 | |
*** xyang has quit IRC | 22:26 | |
*** eharney has quit IRC | 22:26 | |
*** gouthamr_ has quit IRC | 22:26 | |
openstackgerrit | Patrick East proposed openstack/cinder: Use consolidated update for failover_replication https://review.openstack.org/219875 | 22:27 |
patrickeast | jgriffith: ^ that one actually passes pep8 :D | 22:28 |
hemnafk | w00t! | 22:28 |
*** bkopilov has joined #openstack-cinder | 22:28 | |
hemnafk | passes pep8...ship it! | 22:28 |
*** hemnafk is now known as hemna | 22:28 | |
jgriffith | patrickeast: lol... bonus! | 22:28 |
patrickeast | hemnafk: clearly means it works | 22:28 |
jgriffith | patrickeast: but I'm waiting this time :) | 22:28 |
patrickeast | jgriffith: haha yea, i put those up and went to a meeting, came back to see them +A'ed and was like oh crap maybe i should have tested those better | 22:29 |
patrickeast | jgriffith: figured there would be more back and forth | 22:29 |
jgriffith | patrickeast: LOL... sadly it's my MO | 22:29 |
hemna | lol | 22:29 |
*** garthb__ has joined #openstack-cinder | 22:30 | |
*** garthb_ has quit IRC | 22:32 | |
*** zhangjn has joined #openstack-cinder | 22:32 | |
wilson | patch https://review.openstack.org/#/c/202023/ have passed Jenkins and the backend CI | 22:35 |
*** dannywilson has quit IRC | 22:35 | |
*** zhangjn has quit IRC | 22:36 | |
openstackgerrit | John Griffith proposed openstack/cinder: Add mechanism to update snapshot provider_id https://review.openstack.org/219864 | 22:36 |
wilson | Appreciate for any reviews | 22:36 |
*** lcurtis has quit IRC | 22:36 | |
*** dannywilson has joined #openstack-cinder | 22:37 | |
wilson | thanks! | 22:37 |
*** akerr_ has quit IRC | 22:38 | |
*** diogogmt has joined #openstack-cinder | 22:40 | |
openstackgerrit | Mudassir Latif proposed openstack/cinder: bug: fixing replication_status values https://review.openstack.org/219900 | 22:41 |
erhudy1 | jgriffith: do you mind reviewing https://review.openstack.org/#/c/217857/ again now that i think/hope i fixed your concern | 22:42 |
*** haomaiwang has joined #openstack-cinder | 22:43 | |
*** haomaiwa_ has quit IRC | 22:46 | |
*** hemna is now known as hemnafk | 22:49 | |
*** mriedem has joined #openstack-cinder | 22:55 | |
*** diogogmt has quit IRC | 22:55 | |
openstackgerrit | Mudassir Latif proposed openstack/cinder: Allow replicated volumes to be recoverable https://review.openstack.org/219900 | 22:57 |
*** mtanino_ has joined #openstack-cinder | 22:59 | |
*** annasort has quit IRC | 23:01 | |
*** mtanino has quit IRC | 23:02 | |
*** mriedem has quit IRC | 23:03 | |
*** mriedem has joined #openstack-cinder | 23:04 | |
*** angela-s has quit IRC | 23:10 | |
*** mudassirlatif_ has joined #openstack-cinder | 23:16 | |
*** erhudy has quit IRC | 23:19 | |
*** mudassirlatif has quit IRC | 23:20 | |
*** mudassirlatif_ is now known as mudassirlatif | 23:20 | |
*** dannywilson has quit IRC | 23:31 | |
*** krotscheck is now known as kro_paternity | 23:34 | |
*** elmiko has joined #openstack-cinder | 23:35 | |
*** ndipanov has quit IRC | 23:35 | |
elmiko | anyone around who knows a bunch about iscsi and chap? | 23:35 |
elmiko | i'm attempting to write a security note for this bug https://bugs.launchpad.net/ossn/+bug/1329214 | 23:36 |
openstack | Launchpad bug 1329214 in OpenStack Security Notes "tgtadm iscsi chap does not work" [Undecided,In progress] - Assigned to Michael McCune (mimccune) | 23:36 |
elmiko | and i could use a little assistance | 23:36 |
*** harlowja has quit IRC | 23:42 | |
*** harlowja has joined #openstack-cinder | 23:43 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 23:44 |
*** markvoelker has joined #openstack-cinder | 23:46 | |
erhudy1 | jgriffith: thank you sir | 23:47 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/210918 | 23:49 |
mtanino_ | elmiko: what happend? | 23:52 |
*** takedakn has joined #openstack-cinder | 23:53 | |
elmiko | mtanino_: i'm trying to better understand how tgtadm and chap were broken back in icehouse/juno | 23:55 |
*** IanGovett has joined #openstack-cinder | 23:55 | |
elmiko | it looked like requesting chap used the wrong parameter name, which would allow unauthenticated access to lvmiscsidriver volumes | 23:56 |
elmiko | i *think* i understand this a little better now | 23:56 |
mtanino_ | elmiko: I think using 'IncomingUser' for tgtd, we can limit of access for the target. | 23:57 |
mtanino_ | elmiko: But using wrong option 'incominguser' is simply ignored during the configuration and there was no access limitation for iSCSI target. | 23:58 |
*** markvoelker has quit IRC | 23:58 | |
elmiko | mtanino_: ok, that confirms what i was thinking. thanks! | 23:58 |
mtanino_ | elmiko: That's why this is security issue, I think. | 23:58 |
mtanino_ | elmiko: sure :) | 23:59 |
elmiko | mtanino_: yea, makes sense. as user, i might expect that i have enabled chap, when in reality it can be bypassed | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!