*** gouthamr_ has joined #openstack-cinder | 00:02 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Remove the destination volume check in delete_volume https://review.openstack.org/219108 | 00:03 |
---|---|---|
*** gouthamr has quit IRC | 00:05 | |
*** zhangjn has quit IRC | 00:06 | |
*** EinstCrazy has quit IRC | 00:06 | |
*** hodos has quit IRC | 00:07 | |
*** DericHorn-HP has joined #openstack-cinder | 00:07 | |
*** rhedlind has quit IRC | 00:15 | |
*** rhedlind has joined #openstack-cinder | 00:16 | |
*** cbader has joined #openstack-cinder | 00:21 | |
*** DericHorn-HP has quit IRC | 00:23 | |
*** salv-orlando has quit IRC | 00:24 | |
*** garthb has quit IRC | 00:25 | |
*** stevemar has joined #openstack-cinder | 00:27 | |
*** Apoorva_ has joined #openstack-cinder | 00:29 | |
*** _cjones_ has quit IRC | 00:32 | |
*** Apoorva has quit IRC | 00:32 | |
*** Apoorva_ has quit IRC | 00:33 | |
*** dims_ has quit IRC | 00:42 | |
*** strony-zhang has quit IRC | 00:43 | |
*** ilackarms2 has quit IRC | 00:43 | |
*** mss_ has quit IRC | 00:46 | |
*** DericHorn-HP has joined #openstack-cinder | 00:47 | |
*** DericHorn-HP has quit IRC | 00:50 | |
*** EinstCrazy has joined #openstack-cinder | 00:51 | |
*** zhangjn has joined #openstack-cinder | 00:54 | |
*** ondergetekende has quit IRC | 00:56 | |
*** ondergetekende has joined #openstack-cinder | 00:57 | |
*** leeantho has quit IRC | 01:01 | |
*** DericHorn-HP has joined #openstack-cinder | 01:08 | |
*** cbader has quit IRC | 01:09 | |
*** DericHorn-HP has quit IRC | 01:11 | |
*** DericHorn-HP has joined #openstack-cinder | 01:11 | |
*** Lee1092 has joined #openstack-cinder | 01:25 | |
*** dims has joined #openstack-cinder | 01:26 | |
*** DericHorn-HP has quit IRC | 01:28 | |
*** jgregor has joined #openstack-cinder | 01:29 | |
*** DericHorn-HP has joined #openstack-cinder | 01:31 | |
openstackgerrit | Sean McCully proposed openstack/cinder: Use of ast for integers doesn't changes type https://review.openstack.org/225947 | 01:36 |
*** gouthamr has joined #openstack-cinder | 01:41 | |
*** gouthamr_ has quit IRC | 01:44 | |
*** stevemar has quit IRC | 01:46 | |
*** haomaiwa_ has joined #openstack-cinder | 01:51 | |
*** chenying1 has joined #openstack-cinder | 01:59 | |
*** haomaiwa_ has quit IRC | 02:01 | |
*** davechen has joined #openstack-cinder | 02:01 | |
*** 6A4AAH74W has joined #openstack-cinder | 02:01 | |
*** davechen1 has joined #openstack-cinder | 02:05 | |
*** davechen has quit IRC | 02:08 | |
*** DericHorn-HP has quit IRC | 02:12 | |
*** Yogi1 has joined #openstack-cinder | 02:22 | |
*** salv-orlando has joined #openstack-cinder | 02:28 | |
*** Yogi1 has quit IRC | 02:28 | |
*** diogogmt has joined #openstack-cinder | 02:28 | |
*** mtreinish has quit IRC | 02:28 | |
*** jungleboyj has joined #openstack-cinder | 02:32 | |
*** salv-orlando has quit IRC | 02:32 | |
*** dims has quit IRC | 02:33 | |
*** rushil has joined #openstack-cinder | 02:36 | |
*** Yogi1 has joined #openstack-cinder | 02:36 | |
*** rushil_ has joined #openstack-cinder | 02:37 | |
*** gouthamr_ has joined #openstack-cinder | 02:38 | |
*** david-ly_ has joined #openstack-cinder | 02:39 | |
*** david-lyle has quit IRC | 02:40 | |
*** rushil has quit IRC | 02:40 | |
*** dhellmann has quit IRC | 02:40 | |
*** dhellmann has joined #openstack-cinder | 02:41 | |
*** gouthamr has quit IRC | 02:41 | |
*** dansmith has quit IRC | 02:41 | |
*** dansmith has joined #openstack-cinder | 02:42 | |
*** dansmith is now known as Guest24378 | 02:42 | |
*** baojg has joined #openstack-cinder | 02:43 | |
*** zhonghua-lee has quit IRC | 02:44 | |
*** zhonghua-lee has joined #openstack-cinder | 02:45 | |
*** DericHorn-HP has joined #openstack-cinder | 02:46 | |
*** tobe has joined #openstack-cinder | 02:48 | |
*** tobe has quit IRC | 02:48 | |
*** DericHorn-HP has quit IRC | 02:54 | |
*** stevemar has joined #openstack-cinder | 02:56 | |
*** DericHorn-HP has joined #openstack-cinder | 02:58 | |
*** mtreinish has joined #openstack-cinder | 02:59 | |
*** 6A4AAH74W has quit IRC | 03:01 | |
*** gouthamr has joined #openstack-cinder | 03:01 | |
*** haomaiwa_ has joined #openstack-cinder | 03:01 | |
*** rushil_ has quit IRC | 03:01 | |
*** DericHorn-HP has quit IRC | 03:03 | |
*** gouthamr_ has quit IRC | 03:03 | |
*** RA_ has joined #openstack-cinder | 03:04 | |
*** Yogi1 has quit IRC | 03:05 | |
*** david-ly_ is now known as david-lyle | 03:17 | |
*** harlowja_at_home has joined #openstack-cinder | 03:20 | |
*** baojg has quit IRC | 03:22 | |
jgriffith | thingee: around? | 03:23 |
jgriffith | smcginnis: ? | 03:24 |
openstackgerrit | Gao Zexu proposed openstack/cinder: Fix UsedLimitsController's authorizer to soft https://review.openstack.org/226149 | 03:24 |
jgriffith | geguileo: ? | 03:24 |
jgriffith | anyone :) | 03:24 |
harlowja_at_home | jgriffith, i'm here for u | 03:30 |
jgriffith | harlowja_at_home: :) | 03:30 |
harlowja_at_home | how may i be of service | 03:30 |
jgriffith | harlowja_at_home: I'm confused, last I heard (this morning) we still hadn't cut rc branch and opened master back up... no? | 03:30 |
harlowja_at_home | ah yes, i heard a chainsaw this morning to but i was also confused | 03:31 |
* jgriffith checks launchpad | 03:31 | |
harlowja_at_home | i assumed it was the lawn cleaners | 03:31 |
jgriffith | LOL | 03:31 |
harlowja_at_home | person cutting branch may have hurt themselves? | 03:31 |
harlowja_at_home | :-/ | 03:31 |
jgriffith | harlowja_at_home: so I'm trying to figure out why everybody is approving this: https://review.openstack.org/#/c/205834/15 | 03:32 |
openstackgerrit | Gao Zexu proposed openstack/cinder: Fix UsedLimitsController's authorizer to soft https://review.openstack.org/226149 | 03:32 |
harlowja_at_home | intersting | 03:33 |
jgriffith | harlowja_at_home: things are kind of out of control | 03:33 |
jgriffith | just the way /me like it! | 03:33 |
jgriffith | :) | 03:33 |
harlowja_at_home | cowboy in action | 03:33 |
harlowja_at_home | yeee ha | 03:33 |
harlowja_at_home | *cowboy john | 03:33 |
harlowja_at_home | https://img0.etsystatic.com/000/0/5940612/il_570xN.260259762.jpg | 03:34 |
jgriffith | harlowja_at_home: if you look at this: https://github.com/openstack/cinder/commits/master | 03:34 |
harlowja_at_home | ^ big john | 03:34 |
jgriffith | Hey!!! That's awesome! | 03:34 |
harlowja_at_home | big john home style, lol | 03:34 |
harlowja_at_home | lol | 03:34 |
jgriffith | He kinda looks like me :) | 03:34 |
harlowja_at_home | i didn't know u had your own wine... | 03:34 |
*** dims has joined #openstack-cinder | 03:34 | |
jgriffith | harlowja_at_home: depending on who you ask, I have the strongest/loudest wine :) | 03:34 |
harlowja_at_home | lol | 03:34 |
jgriffith | oh.. wait.. that's different | 03:34 |
harlowja_at_home | that's what i'd expect from big john | 03:35 |
harlowja_at_home | but ya, master seems somewhat open :-/ | 03:35 |
jgriffith | a "big wine" | 03:35 |
jgriffith | harlowja_at_home: hmm... well, better safe than sorry til I get confirmation | 03:35 |
harlowja_at_home | big john will figure it out | 03:35 |
harlowja_at_home | hmmm, or http://www.robtrigg.co.uk/files/gimgs/20_john-1.png | 03:37 |
harlowja_at_home | idk | 03:37 |
harlowja_at_home | u decide | 03:37 |
harlowja_at_home | ha | 03:37 |
harlowja_at_home | but u should get one of those tattooed somewhere | 03:37 |
*** DericHorn-HP has joined #openstack-cinder | 03:45 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Use function capsulation in Huawei driver https://review.openstack.org/222916 | 03:49 |
*** jgregor has quit IRC | 03:59 | |
thingee | jgriffith: hi | 03:59 |
thingee | jgriffith: I have made the request to the release team | 04:01 |
*** haomaiwa_ has quit IRC | 04:01 | |
*** jgregor has joined #openstack-cinder | 04:01 | |
*** haomaiwa_ has joined #openstack-cinder | 04:01 | |
*** dims has quit IRC | 04:09 | |
*** stevemar has quit IRC | 04:09 | |
*** stevemar has joined #openstack-cinder | 04:10 | |
*** garthb has joined #openstack-cinder | 04:10 | |
*** jgregor has quit IRC | 04:17 | |
*** mtreinish has quit IRC | 04:18 | |
*** asselin_ has joined #openstack-cinder | 04:20 | |
*** mtreinish has joined #openstack-cinder | 04:23 | |
*** A_thomson has joined #openstack-cinder | 04:23 | |
*** gouthamr has quit IRC | 04:28 | |
A_thomson | hello all. why my ubuntu 14.04 instance kernel panic after boot from cinder-volume ? | 04:30 |
A_thomson | I'm using ceph as volume back-end | 04:30 |
*** chenying1 has quit IRC | 04:31 | |
*** shyama has joined #openstack-cinder | 04:40 | |
*** harlowja_at_home has quit IRC | 04:40 | |
*** shausy has joined #openstack-cinder | 04:54 | |
*** haomaiwa_ has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-cinder | 05:01 | |
*** deepakcs has joined #openstack-cinder | 05:05 | |
*** DericHorn-HP has quit IRC | 05:10 | |
*** changbl has quit IRC | 05:11 | |
*** jseiler has quit IRC | 05:12 | |
*** smcginnis has quit IRC | 05:12 | |
*** DericHorn-HP has joined #openstack-cinder | 05:13 | |
*** changbl has joined #openstack-cinder | 05:15 | |
*** DericHorn-HP has quit IRC | 05:18 | |
*** dsariel_ has joined #openstack-cinder | 05:20 | |
*** annasort has quit IRC | 05:20 | |
*** DericHorn-HP has joined #openstack-cinder | 05:25 | |
*** salv-orlando has joined #openstack-cinder | 05:26 | |
*** nkrinner has joined #openstack-cinder | 05:33 | |
*** salv-orlando has quit IRC | 05:33 | |
*** ankit_ag has joined #openstack-cinder | 05:35 | |
*** vgridnev has joined #openstack-cinder | 05:36 | |
*** shausy has quit IRC | 05:36 | |
*** veena has joined #openstack-cinder | 05:38 | |
*** shausy has joined #openstack-cinder | 05:39 | |
*** DericHorn-HP has quit IRC | 05:41 | |
*** mudassirlatif has joined #openstack-cinder | 05:44 | |
*** garthb has quit IRC | 05:48 | |
*** garthb has joined #openstack-cinder | 05:49 | |
*** stevemar has quit IRC | 05:53 | |
*** zhangjn_ has joined #openstack-cinder | 05:55 | |
*** garthb has quit IRC | 05:55 | |
*** zhangjn has quit IRC | 05:55 | |
*** BharatK has joined #openstack-cinder | 05:59 | |
*** BharatK_ has joined #openstack-cinder | 05:59 | |
*** chenying1 has joined #openstack-cinder | 06:00 | |
*** BharatK_ has quit IRC | 06:00 | |
*** haomaiwang has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-cinder | 06:01 | |
*** BharatK has quit IRC | 06:03 | |
*** zhangjn has joined #openstack-cinder | 06:07 | |
*** zhangjn_ has quit IRC | 06:11 | |
*** zhangjn has quit IRC | 06:11 | |
*** BharatK has joined #openstack-cinder | 06:12 | |
veena | chenying1: Hi | 06:15 |
chenying1 | veena, Hi | 06:18 |
veena | related to bug https://bugs.launchpad.net/devstack/+bug/1488432 | 06:19 |
openstack | Launchpad bug 1488432 in devstack "cinder daemon processes quit unexpectedly in my devstack environment" [Undecided,Invalid] | 06:19 |
veena | chenying1: I'm also seeing this issue on other services | 06:19 |
veena | chenying1: I didn't close the client connectivity | 06:20 |
*** mss has joined #openstack-cinder | 06:20 | |
chenying1 | My issue is caused by shell client being closed. | 06:23 |
*** mss has quit IRC | 06:24 | |
*** yrabl has joined #openstack-cinder | 06:25 | |
chenying1 | I do not think it has something to do with rabbitmq. Cinder processes not running in background maybe cause the error. | 06:30 |
*** mudassirlatif has quit IRC | 06:31 | |
*** mss has joined #openstack-cinder | 06:35 | |
*** shausy has quit IRC | 06:46 | |
veena | chenying1: Okay, will try to debug what caused the cinder processes to crash | 06:47 |
veena | chenying1: Thank you | 06:47 |
*** shausy has joined #openstack-cinder | 06:47 | |
*** smcginnis has joined #openstack-cinder | 06:53 | |
*** anshul has joined #openstack-cinder | 06:57 | |
*** david-lyle has quit IRC | 06:58 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-cinder | 07:01 | |
*** edtubill has quit IRC | 07:02 | |
*** subscope has quit IRC | 07:03 | |
*** salv-orlando has joined #openstack-cinder | 07:03 | |
openstackgerrit | Sergey Vilgelm proposed openstack/cinder: Remove unused config generator module https://review.openstack.org/226179 | 07:04 |
*** mss has quit IRC | 07:06 | |
openstackgerrit | Sergey Vilgelm proposed openstack/cinder: Remove unused oslo-incubator modules https://review.openstack.org/226179 | 07:11 |
openstackgerrit | Sergey Vilgelm proposed openstack/cinder: Remove unused oslo-incubator modules https://review.openstack.org/226179 | 07:13 |
*** david-lyle has joined #openstack-cinder | 07:14 | |
*** jamielennox is now known as jamielennox|away | 07:15 | |
*** dsariel_ has quit IRC | 07:16 | |
*** sgotliv has joined #openstack-cinder | 07:16 | |
*** vgridnev has quit IRC | 07:18 | |
*** ronis has joined #openstack-cinder | 07:26 | |
*** vgridnev has joined #openstack-cinder | 07:28 | |
*** takedakn has joined #openstack-cinder | 07:28 | |
*** veena has quit IRC | 07:31 | |
geguileo | jgriffith: yt? | 07:33 |
*** zhangjn has joined #openstack-cinder | 07:34 | |
*** zhangjn has quit IRC | 07:35 | |
openstackgerrit | Gao Zexu proposed openstack/cinder: Add policy check for volume types api https://review.openstack.org/226188 | 07:35 |
*** zhangjn has joined #openstack-cinder | 07:35 | |
*** Adriano_ has quit IRC | 07:41 | |
*** sweston has quit IRC | 07:41 | |
*** patrickeast has quit IRC | 07:41 | |
*** rhefner has quit IRC | 07:41 | |
*** DuncanT has quit IRC | 07:41 | |
*** erlon has quit IRC | 07:41 | |
*** serverascode has quit IRC | 07:41 | |
*** Lee1092 has quit IRC | 07:41 | |
*** zhenguo has quit IRC | 07:41 | |
*** marcusvrn_ has quit IRC | 07:41 | |
*** scottda has quit IRC | 07:41 | |
*** adrianofr has quit IRC | 07:41 | |
*** rex_lee_ has quit IRC | 07:41 | |
*** boris-42 has quit IRC | 07:41 | |
*** ctracey has quit IRC | 07:41 | |
*** cppforlife_ has quit IRC | 07:41 | |
*** thingee has quit IRC | 07:41 | |
*** wanghao has quit IRC | 07:41 | |
*** zhiyan has quit IRC | 07:41 | |
*** ameade has quit IRC | 07:41 | |
*** briancurtin has quit IRC | 07:41 | |
*** jordanP has joined #openstack-cinder | 07:42 | |
*** briancurtin has joined #openstack-cinder | 07:43 | |
*** zhenguo has joined #openstack-cinder | 07:45 | |
*** takedakn has quit IRC | 07:48 | |
*** Lee1092 has joined #openstack-cinder | 07:50 | |
*** aix has joined #openstack-cinder | 07:50 | |
*** chenying1 has quit IRC | 07:51 | |
*** ndipanov has quit IRC | 07:52 | |
*** takedakn has joined #openstack-cinder | 07:54 | |
*** haomaiwang has quit IRC | 08:01 | |
*** vgridnev has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-cinder | 08:01 | |
*** shyama has quit IRC | 08:03 | |
*** sayali has joined #openstack-cinder | 08:04 | |
*** RA_ has quit IRC | 08:12 | |
*** chenying1 has joined #openstack-cinder | 08:14 | |
*** shyama has joined #openstack-cinder | 08:17 | |
*** wilson has joined #openstack-cinder | 08:17 | |
*** chenying11 has joined #openstack-cinder | 08:17 | |
*** wilson is now known as Guest75391 | 08:18 | |
*** wilson-1 has quit IRC | 08:18 | |
*** chenying1 has quit IRC | 08:18 | |
*** DuncanT has joined #openstack-cinder | 08:19 | |
openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Remove VMDK driver for ESX server https://review.openstack.org/222566 | 08:22 |
*** sayali has quit IRC | 08:23 | |
*** ronis has quit IRC | 08:25 | |
*** ndipanov has joined #openstack-cinder | 08:26 | |
*** sayali has joined #openstack-cinder | 08:27 | |
*** takedakn has quit IRC | 08:27 | |
*** alexpilotti has joined #openstack-cinder | 08:33 | |
*** ronis has joined #openstack-cinder | 08:38 | |
*** aix has quit IRC | 08:46 | |
*** alexpilotti has quit IRC | 08:47 | |
*** vgridnev has joined #openstack-cinder | 08:54 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-cinder | 09:01 | |
openstackgerrit | chenying proposed openstack/python-cinderclient: Fix a snapshots not being deleted by using name https://review.openstack.org/223067 | 09:03 |
*** lpetrut has joined #openstack-cinder | 09:03 | |
*** BharatK has quit IRC | 09:05 | |
*** shausy has quit IRC | 09:11 | |
*** mss has joined #openstack-cinder | 09:14 | |
*** aix has joined #openstack-cinder | 09:16 | |
*** mss has quit IRC | 09:18 | |
*** BharatK has joined #openstack-cinder | 09:19 | |
*** ociuhandu has quit IRC | 09:21 | |
*** chenying11 has quit IRC | 09:24 | |
*** boris-42 has joined #openstack-cinder | 09:26 | |
*** e0ne has joined #openstack-cinder | 09:26 | |
*** lprice has joined #openstack-cinder | 09:41 | |
*** lprice1 has quit IRC | 09:41 | |
*** ociuhandu has joined #openstack-cinder | 09:43 | |
*** ociuhandu_ has joined #openstack-cinder | 09:45 | |
*** dims has joined #openstack-cinder | 09:47 | |
*** ociuhandu has quit IRC | 09:47 | |
*** ociuhandu_ is now known as ociuhandu | 09:47 | |
*** BharatK has quit IRC | 09:48 | |
*** marcusvrn_ has joined #openstack-cinder | 09:49 | |
*** erlon has joined #openstack-cinder | 09:49 | |
*** ameade has joined #openstack-cinder | 09:53 | |
*** sweston has joined #openstack-cinder | 09:53 | |
*** IanGovett has joined #openstack-cinder | 09:54 | |
*** serverascode has joined #openstack-cinder | 09:54 | |
*** rhefner has joined #openstack-cinder | 09:54 | |
*** ctracey has joined #openstack-cinder | 09:54 | |
*** zhiyan has joined #openstack-cinder | 09:54 | |
*** davechen1 has left #openstack-cinder | 09:55 | |
*** thingee has joined #openstack-cinder | 09:55 | |
*** cppforlife_ has joined #openstack-cinder | 09:55 | |
*** scottda has joined #openstack-cinder | 09:55 | |
*** adrianofr has joined #openstack-cinder | 09:55 | |
*** wanghao has joined #openstack-cinder | 09:56 | |
*** salv-orlando has quit IRC | 09:56 | |
*** rex_lee_ has joined #openstack-cinder | 09:56 | |
*** IanGovett1 has joined #openstack-cinder | 09:57 | |
*** markvoelker has quit IRC | 09:57 | |
*** IanGovett has quit IRC | 09:58 | |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-cinder | 10:01 | |
*** BharatK has joined #openstack-cinder | 10:02 | |
*** mss has joined #openstack-cinder | 10:03 | |
*** A_thomson has quit IRC | 10:03 | |
*** Adriano_ has joined #openstack-cinder | 10:07 | |
*** patrickeast has joined #openstack-cinder | 10:07 | |
*** mss has quit IRC | 10:07 | |
*** RA_ has joined #openstack-cinder | 10:08 | |
*** e0ne has quit IRC | 10:30 | |
*** RA_ has quit IRC | 10:31 | |
*** e0ne has joined #openstack-cinder | 10:35 | |
openstackgerrit | Sergey Gotliv proposed openstack/python-cinderclient: Adding pagination capabilities to snapshots and backups lists https://review.openstack.org/225582 | 10:45 |
*** salv-orlando has joined #openstack-cinder | 10:47 | |
*** aix has quit IRC | 10:53 | |
*** yrabl has quit IRC | 10:58 | |
*** yrabl has joined #openstack-cinder | 10:58 | |
*** porrua has joined #openstack-cinder | 10:59 | |
*** haomaiwang has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-cinder | 11:01 | |
*** aix has joined #openstack-cinder | 11:05 | |
*** eduardo has joined #openstack-cinder | 11:07 | |
*** timcl has joined #openstack-cinder | 11:28 | |
*** markvoelker has joined #openstack-cinder | 11:28 | |
*** markvoelker has quit IRC | 11:33 | |
*** julim has joined #openstack-cinder | 11:37 | |
*** manas has joined #openstack-cinder | 11:52 | |
*** haomaiwang has quit IRC | 11:55 | |
*** manas has quit IRC | 11:55 | |
*** ociuhandu has quit IRC | 11:58 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Encode username and password in Huawei driver https://review.openstack.org/216085 | 11:58 |
*** dosaboy has quit IRC | 12:00 | |
*** timcl has quit IRC | 12:02 | |
*** timcl has joined #openstack-cinder | 12:03 | |
*** e0ne has quit IRC | 12:03 | |
*** ociuhandu has joined #openstack-cinder | 12:03 | |
*** dosaboy has joined #openstack-cinder | 12:07 | |
*** alexpilotti has joined #openstack-cinder | 12:09 | |
*** timcl1 has joined #openstack-cinder | 12:17 | |
*** markvoelker has joined #openstack-cinder | 12:18 | |
*** raildo-afk is now known as raildo | 12:19 | |
*** timcl has quit IRC | 12:19 | |
*** e0ne has joined #openstack-cinder | 12:23 | |
*** tpsilva has joined #openstack-cinder | 12:24 | |
*** bswartz has quit IRC | 12:26 | |
*** dobson has quit IRC | 12:27 | |
*** akerr has joined #openstack-cinder | 12:29 | |
*** dobson has joined #openstack-cinder | 12:32 | |
*** edmondsw has joined #openstack-cinder | 12:33 | |
*** timcl1 has quit IRC | 12:35 | |
*** pschaef has joined #openstack-cinder | 12:37 | |
jgriffith | geguileo: hey | 12:37 |
*** RA_ has joined #openstack-cinder | 12:37 | |
geguileo | jgriffith: Hi! | 12:37 |
jgriffith | geguileo: You probably saw my comments on your patch, which is why I was pinging | 12:37 |
jgriffith | geguileo: WRT still being in RC mode etc | 12:38 |
geguileo | jgriffith: No, I must have missed them, I came back from PTO yesterday... | 12:38 |
geguileo | jgriffith: Which patch, please? | 12:38 |
*** timcl has joined #openstack-cinder | 12:39 | |
geguileo | jgriffith: Oh, I see, the -2 | 12:39 |
geguileo | jgriffith: Well, that change is needed for all the API races bug fixes | 12:40 |
jgriffith | geguileo: ok, I"ll lift it | 12:40 |
jgriffith | geguileo: seems like an incredibly big fix for this late in the game | 12:40 |
geguileo | jgriffith: That I cannot argue with :-( | 12:40 |
geguileo | jgriffith: I would like to see the API races fixed, but they are changes to almost all API methods | 12:41 |
geguileo | jgriffith: So I'm not sure people will want them fixed this late | 12:41 |
geguileo | jgriffith: I think I'll bring it up tomorrow on the meeting | 12:41 |
jgriffith | good idea :) | 12:41 |
jgriffith | geguileo: thanks! | 12:42 |
geguileo | Thank you!! | 12:42 |
*** xek has joined #openstack-cinder | 12:47 | |
*** alejandrito has joined #openstack-cinder | 12:47 | |
*** boris-42 has quit IRC | 12:49 | |
*** merooney has joined #openstack-cinder | 12:49 | |
*** Yogi1 has joined #openstack-cinder | 12:49 | |
*** martyturner has joined #openstack-cinder | 12:51 | |
*** merooney has quit IRC | 12:52 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Fix capability report error in Huawei driver https://review.openstack.org/226308 | 12:52 |
*** xyang1 has joined #openstack-cinder | 12:53 | |
*** merooney has joined #openstack-cinder | 12:53 | |
*** eharney has joined #openstack-cinder | 12:54 | |
*** martyturner has quit IRC | 12:54 | |
e0ne | jgriffith: good morning John | 12:56 |
*** martyturner has joined #openstack-cinder | 12:57 | |
*** merooney has quit IRC | 12:57 | |
e0ne | jgriffith: could you please take a short look on https://review.openstack.org/#/c/224124/ once you have a time? I would like to choose name for new attachment client as soon, as possible | 12:58 |
*** RA_ has quit IRC | 12:58 | |
*** merooney has joined #openstack-cinder | 12:58 | |
e0ne | I don't want to get a series of renaming/refactoring issues in the future | 12:59 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Fix capability report error in Huawei driver https://review.openstack.org/226308 | 12:59 |
*** haomaiwang has joined #openstack-cinder | 13:00 | |
*** haomaiwang has quit IRC | 13:01 | |
*** haomaiwang has joined #openstack-cinder | 13:01 | |
*** vgridnev has quit IRC | 13:01 | |
*** bswartz has joined #openstack-cinder | 13:03 | |
*** vgridnev has joined #openstack-cinder | 13:05 | |
*** lprice has quit IRC | 13:07 | |
*** mdenny has joined #openstack-cinder | 13:07 | |
*** pschaef has quit IRC | 13:12 | |
*** dims has quit IRC | 13:14 | |
*** dims has joined #openstack-cinder | 13:15 | |
*** dustins has joined #openstack-cinder | 13:15 | |
*** jgregor has joined #openstack-cinder | 13:18 | |
*** salv-orlando has quit IRC | 13:18 | |
jgriffith | e0ne: awesome! | 13:19 |
jgriffith | e0ne: I'm getting ready to make the commute in to the office, will check it out when I get there! | 13:20 |
jgriffith | thingee: thanks for the update on release | 13:20 |
jgriffith | BB in an hour or so | 13:20 |
*** Yogi1 has quit IRC | 13:23 | |
*** pschaef has joined #openstack-cinder | 13:24 | |
*** BharatK has quit IRC | 13:24 | |
*** akerr has quit IRC | 13:28 | |
*** akerr has joined #openstack-cinder | 13:28 | |
*** jungleboyj has quit IRC | 13:30 | |
*** timcl has quit IRC | 13:31 | |
*** mriedem_away is now known as mriedem | 13:31 | |
*** e0ne has quit IRC | 13:37 | |
*** lprice has joined #openstack-cinder | 13:38 | |
*** RA_ has joined #openstack-cinder | 13:39 | |
*** e0ne has joined #openstack-cinder | 13:39 | |
e0ne | jgriffith: thanks | 13:39 |
*** e0ne has quit IRC | 13:39 | |
*** annasort has joined #openstack-cinder | 13:40 | |
smcginnis | thingee: Just seeing scrollback. No, that was entirely based on code review. | 13:40 |
*** e0ne has joined #openstack-cinder | 13:40 | |
*** ankit_ag has quit IRC | 13:41 | |
*** BharatK has joined #openstack-cinder | 13:41 | |
*** deepakcs has quit IRC | 13:43 | |
*** takedakn has joined #openstack-cinder | 13:45 | |
*** jaypipes has joined #openstack-cinder | 13:46 | |
*** mc_nair has joined #openstack-cinder | 13:48 | |
*** cbader has joined #openstack-cinder | 13:49 | |
*** jaypipes has quit IRC | 13:49 | |
*** jaypipes has joined #openstack-cinder | 13:50 | |
*** timcl has joined #openstack-cinder | 13:51 | |
*** hodos has joined #openstack-cinder | 13:52 | |
*** timcl has quit IRC | 13:53 | |
*** mriedem is now known as mriedem_meeting | 13:53 | |
*** cdelatte has joined #openstack-cinder | 13:54 | |
*** delattec has joined #openstack-cinder | 13:54 | |
*** lcurtis has joined #openstack-cinder | 13:56 | |
*** lcurtis_ has joined #openstack-cinder | 13:56 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/cinder: Fix use of wrong storage pools for NetApp Drivers https://review.openstack.org/222413 | 13:58 |
*** vgridnev has quit IRC | 13:58 | |
*** porrua has quit IRC | 13:58 | |
*** porrua has joined #openstack-cinder | 14:00 | |
*** haomaiwang has quit IRC | 14:01 | |
*** haomaiwa_ has joined #openstack-cinder | 14:01 | |
*** DericHorn-HP has joined #openstack-cinder | 14:02 | |
*** EinstCrazy has quit IRC | 14:03 | |
*** sgotliv has quit IRC | 14:03 | |
*** zhangjn has quit IRC | 14:03 | |
*** stevemar has joined #openstack-cinder | 14:03 | |
*** vgridnev has joined #openstack-cinder | 14:07 | |
*** breitz has quit IRC | 14:09 | |
*** breitz has joined #openstack-cinder | 14:10 | |
*** annasort_ has joined #openstack-cinder | 14:10 | |
*** annasort has quit IRC | 14:10 | |
*** annasort_ is now known as annasort | 14:10 | |
*** dobson has quit IRC | 14:10 | |
*** cdelatte has quit IRC | 14:12 | |
*** delattec has quit IRC | 14:12 | |
*** thangp has joined #openstack-cinder | 14:12 | |
*** dobson has joined #openstack-cinder | 14:15 | |
*** crose has joined #openstack-cinder | 14:18 | |
*** edtubill has joined #openstack-cinder | 14:24 | |
*** markus_z has joined #openstack-cinder | 14:25 | |
*** ronis has quit IRC | 14:26 | |
*** DericHorn-HP has quit IRC | 14:26 | |
*** boris-42 has joined #openstack-cinder | 14:30 | |
*** alexpilotti has quit IRC | 14:30 | |
*** zhangjn has joined #openstack-cinder | 14:30 | |
*** zhangjn has quit IRC | 14:30 | |
*** cdelatte has joined #openstack-cinder | 14:31 | |
*** zhangjn has joined #openstack-cinder | 14:31 | |
*** zhangjn has quit IRC | 14:31 | |
*** zhangjn has joined #openstack-cinder | 14:32 | |
*** zhangjn has quit IRC | 14:32 | |
*** cdelatte has quit IRC | 14:33 | |
*** zhangjn has joined #openstack-cinder | 14:38 | |
*** zhangjn has quit IRC | 14:38 | |
*** zhangjn has joined #openstack-cinder | 14:39 | |
*** cdelatte has joined #openstack-cinder | 14:39 | |
*** zhangjn has quit IRC | 14:39 | |
*** zhangjn has joined #openstack-cinder | 14:41 | |
jgriffith | e0ne: https://review.openstack.org/#/c/224124/ | 14:41 |
*** zhangjn has quit IRC | 14:41 | |
*** mtanino has joined #openstack-cinder | 14:41 | |
jgriffith | e0ne: I sort of think the whole "agent" thing is the wrong direction to start, but no reason for me to object to it | 14:41 |
*** zhangjn has joined #openstack-cinder | 14:42 | |
jgriffith | e0ne: and depending on how it turns out it might be interesting to see if nova could just leverage it | 14:42 |
*** zhangjn has quit IRC | 14:42 | |
jgriffith | e0ne: it's also kinda weird because frankly the stuff hemnafk has done with Brick it's part way there already | 14:42 |
jgriffith | e0ne: so that's probably where it should live IMHO | 14:43 |
*** zhangjn has joined #openstack-cinder | 14:43 | |
*** zhangjn has quit IRC | 14:43 | |
jgriffith | thingee: https://review.openstack.org/#/c/205834/ | 14:44 |
*** jseiler has joined #openstack-cinder | 14:44 | |
*** zhangjn has joined #openstack-cinder | 14:44 | |
jgriffith | thingee: let me know if I'm mistaken | 14:44 |
jgriffith | geguileo: Just thinking that waiting til Wed meeting will be too late | 14:44 |
jgriffith | geguileo: I'm "sure" we will release by then | 14:44 |
jgriffith | geguileo: so if there's a case to merge it for release we probably need to figure that out ASAP | 14:45 |
geguileo | Well, then those patches will have to wait :-( | 14:45 |
jgriffith | geguileo: maybe... maybe not | 14:45 |
geguileo | jgriffith: We've been working with those races for a long time | 14:45 |
jgriffith | geguileo: seems diablo_rojo and smcginnis as well as others are comfrotable with it | 14:45 |
geguileo | jgriffith: I don't think rushing is the best idea now | 14:45 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Fix capacity report error in Huawei driver https://review.openstack.org/226308 | 14:45 |
jgriffith | geguileo: me neither, but I seem to be in the minority :) | 14:46 |
jgriffith | geguileo: so it's kinda of up to you it seems | 14:46 |
geguileo | jgriffith: I want it to get merged, but I wouldn't accept this if it came from somebody else | 14:46 |
jgriffith | geguileo: I'll let other cores and the PTL override me and remove my -2 based on their suggestions | 14:46 |
smcginnis | jgriffith: No, I think you're right. | 14:47 |
geguileo | jgriffith: That patch is useless in its own | 14:47 |
jgriffith | geguileo: so that was the other thing :) | 14:47 |
smcginnis | I +2'd it, but I don't think it's critical to get in before release. | 14:47 |
geguileo | jgriffith: And merging 7 patches right now is a big risk | 14:47 |
smcginnis | There's enough additional work to be done that it | 14:47 |
smcginnis | 's probably worth holding off a bit. | 14:47 |
jgriffith | geguileo: ok, cool... sorry man | 14:47 |
geguileo | Ok, then we hold it | 14:47 |
smcginnis | geguileo: Yeah, sorry. | 14:48 |
geguileo | jgriffith: Well, it's what I would do | 14:48 |
dulek | As patch isn't useful on its own it shouldn't be merged I think. | 14:48 |
geguileo | So no worries | 14:48 |
geguileo | dulek: Yep, that's right | 14:48 |
geguileo | dulek: And merging more patches would be too risky I think | 14:48 |
smcginnis | geguileo: Will be good to get it fixed, then backported though. | 14:48 |
* dulek finally got some time to look at that today. | 14:48 | |
geguileo | Ok, then we all agree, it'll have to wait | 14:49 |
geguileo | Thanks guys | 14:49 |
smcginnis | geguileo: Thanks for working on it! | 14:49 |
*** mdbooth has quit IRC | 14:49 | |
geguileo | smcginnis: No problem, it has been a painful kind of fun ;-) | 14:49 |
diablo_rojo | geguileo: Yeah it looked good to me :) An impressive number of bugs addressed. | 14:50 |
jgriffith | geguileo: promise my first review when master opens back up! | 14:50 |
geguileo | jgriffith: Thanks | 14:50 |
*** tsekiyama has joined #openstack-cinder | 14:51 | |
dulek | jgriffith: Hey, you've promised that to Volume object patch! ;) | 14:51 |
*** tsekiyam_ has joined #openstack-cinder | 14:52 | |
jgriffith | dulek: crap... your'e right! | 14:52 |
jgriffith | geguileo: you're second in line | 14:52 |
jgriffith | dulek: geguileo both of you need to remind me though :) | 14:52 |
jgriffith | I'll forget | 14:52 |
geguileo | XD XD XD | 14:52 |
jgriffith | I'm pretty sure you are the only two I made such promised too :) | 14:52 |
geguileo | Second is good enough for me :-) | 14:52 |
e0ne | jgriffith: thanks for feedback | 14:52 |
smcginnis | Hah | 14:53 |
*** timcl has joined #openstack-cinder | 14:53 | |
e0ne | jgriffith: maybe it's a good idea to not introduce new library/package and do it inside os-brick | 14:53 |
jgriffith | e0ne: that's my opinion for sure | 14:53 |
e0ne | jgriffith: but I don't want to add cinderclient dependency to brick. that's why I', proposing a new lib | 14:54 |
jgriffith | e0ne: just add a cmd to the Cinder API to get all the info | 14:54 |
jgriffith | e0ne: then let brick or whoever do whatever they want with tit | 14:54 |
jgriffith | e0ne: no no... certainly not! | 14:54 |
jgriffith | e0ne: I would definitely barf all over that | 14:54 |
*** timcl has quit IRC | 14:54 | |
e0ne | jgriffith: :) | 14:54 |
jgriffith | e0ne: my contention is that we don't need to automate the whole thing | 14:54 |
e0ne | jgriffith: I'm going to introduce 2 options: with attach for everybody | 14:55 |
*** mss has joined #openstack-cinder | 14:55 | |
jgriffith | e0ne: I'm saying "cinder external-attach <iqn> volume-id" or something | 14:55 |
e0ne | jgriffith: and the second one: only provide necessary info for attachment for power users | 14:55 |
jgriffith | e0ne: and that returns all of the target info | 14:55 |
jgriffith | then the caller can do whatever they want with it | 14:55 |
*** mdbooth has joined #openstack-cinder | 14:55 | |
jgriffith | if that means using some fancy tool that's in the brick library, good for them | 14:55 |
jgriffith | if it means they type in iscsi-adm xxxxxx... that's fine too | 14:55 |
*** tsekiyama has quit IRC | 14:56 | |
e0ne | jgriffith: in my PoC I'm using brick | 14:56 |
jgriffith | the point being we should let them choose, and keep it decoupled from the other OpenStack pieces as that's kinda the whole idea | 14:56 |
*** Guest24378 is now known as dansmith | 14:56 | |
e0ne | jgriffith: in any case, it should be done on top of the brick | 14:56 |
jgriffith | e0ne: yeah, if we go that route I would think that brick is where it should live | 14:57 |
jgriffith | e0ne: but I want to stress that I'd like the ability to just get the target info and update the DB entry | 14:57 |
e0ne | jgriffith: sure. it should works even operators/users won't to install additional package inside baremetal instance or desktop | 14:57 |
jgriffith | e0ne: so I can use Cinder from "anywhere" without requiring a framework of tools on top of it | 14:57 |
jgriffith | e0ne: yup.. perfect | 14:57 |
*** eharney has quit IRC | 14:59 | |
e0ne | jgriffith: "without requiring a framework of tools on top of it" I'm afraid that it's not easy. at lease os-brick depends on oslo.rootwrap, etc. But I really want to have as less depemdencies as possible | 14:59 |
jgriffith | e0ne: well.. what I'm saying is consumers of the Cinder API can make the choice | 15:00 |
jgriffith | e0ne: either use the framework and have things attached, or just get the raw info and do it on their own | 15:00 |
jgriffith | make sense? | 15:01 |
*** haomaiwa_ has quit IRC | 15:01 | |
e0ne | jgriffith: sure | 15:01 |
jgriffith | e0ne: I realize if you auto attach it's sort of a big deal... (I dont' think it's necessary either, but doesn't matter) | 15:01 |
e0ne | jgriffith: I need to re-phase part of the spec about 'generate-attach'. It should be about " just get the raw info and do it on their own" | 15:01 |
jgriffith | e0ne: yeah | 15:02 |
*** nkrinner has quit IRC | 15:02 | |
jgriffith | e0ne: I kinda interpretted what you wrote as meaning just that | 15:02 |
jgriffith | e0ne: and added my comment there :) | 15:02 |
e0ne | jgriffith: two people, two minds. DuncanT wants auto-attach as a first step | 15:02 |
*** haomaiwa_ has joined #openstack-cinder | 15:02 | |
jgriffith | e0ne: Yeah... I think that's a bad idea but it's fine | 15:03 |
e0ne | :) | 15:03 |
jgriffith | e0ne: I can write a 10 line patch to Cinder to get what I want | 15:03 |
jgriffith | so no big deal at all | 15:03 |
e0ne | jgriffith: I know, I've already done it | 15:03 |
jgriffith | and people that want the other part can have it | 15:03 |
jgriffith | e0ne: :) | 15:03 |
*** strony-zhang has joined #openstack-cinder | 15:04 | |
*** BharatK has quit IRC | 15:04 | |
*** merooney has quit IRC | 15:04 | |
e0ne | there is two cases: when users/operators want to install additional package(s) on their env to attach volumes, and others don't want to install anything more. | 15:04 |
jgriffith | exactly | 15:05 |
e0ne | jgriffith: we need do be flexible and support both of cases with good documented APIs and tools | 15:05 |
e0ne | s/do be/to be | 15:05 |
jgriffith | e0ne: and Docker for example gives me hooks to do anything I want, I just need the information. | 15:05 |
*** takedakn has quit IRC | 15:05 | |
jgriffith | maybe later down the road that changes | 15:06 |
e0ne | jgriffith: it's good example, IMO. I need to take a look on it | 15:06 |
*** mriedem_meeting is now known as mriedem | 15:06 | |
*** bswartz has quit IRC | 15:08 | |
*** merooney has joined #openstack-cinder | 15:12 | |
*** EinstCrazy has joined #openstack-cinder | 15:14 | |
*** annegentle has joined #openstack-cinder | 15:14 | |
*** cdelatte has quit IRC | 15:15 | |
*** bswartz has joined #openstack-cinder | 15:15 | |
*** dims has quit IRC | 15:20 | |
*** tsekiyam_ has quit IRC | 15:22 | |
*** tsekiyama has joined #openstack-cinder | 15:23 | |
*** garthb has joined #openstack-cinder | 15:25 | |
*** diogogmt has quit IRC | 15:26 | |
*** eharney has joined #openstack-cinder | 15:26 | |
*** annegent_ has joined #openstack-cinder | 15:27 | |
*** crose has quit IRC | 15:28 | |
*** e0ne has quit IRC | 15:28 | |
*** dims has joined #openstack-cinder | 15:28 | |
*** e0ne has joined #openstack-cinder | 15:30 | |
*** jdurgin1 has joined #openstack-cinder | 15:30 | |
*** annegentle has quit IRC | 15:30 | |
*** annegent_ has quit IRC | 15:36 | |
*** annegentle has joined #openstack-cinder | 15:36 | |
*** diogogmt has joined #openstack-cinder | 15:36 | |
markus_z | Does Cinder have the "bug czar" role implemented? I'm the Nova bug czar and like to exchange some ideas and get to know my "counter-part" in the other projects. | 15:36 |
jgriffith | markus_z: we do not | 15:38 |
jgriffith | markus_z: but might be a good thing to propose :) | 15:38 |
*** cdelatte has joined #openstack-cinder | 15:39 | |
jgriffith | markus_z: we have 4 PTL candidates, surely one of them would be interested? | 15:39 |
markus_z | jgriffith: Too bad. I think the PTLs discussed this in 2014: http://lists.openstack.org/pipermail/openstack-dev/2014-August/043812.html | 15:40 |
*** cdelatte has quit IRC | 15:40 | |
jgriffith | markus_z: yeah, ttx sent that out and I think it's a great idea | 15:40 |
jgriffith | markus_z: I'll raise it at our meeting this week | 15:41 |
smcginnis | Oh, interesting. Hadn't seen that. | 15:41 |
jgriffith | markus_z: I think it's something we certainly would benefit from | 15:41 |
markus_z | jgriffith: I already have found my counter-part in Neutron. As we most probably face a lot of similar issues, I think it would make sense to exchange inter-project wise. | 15:41 |
*** leeantho has joined #openstack-cinder | 15:41 | |
jgriffith | markus_z: agreed | 15:41 |
*** e0ne has quit IRC | 15:41 | |
markus_z | jgriffith: Thanks, that's great! | 15:41 |
*** jungleboyj has joined #openstack-cinder | 15:42 | |
jgriffith | markus_z: I'd like to extend this do things like a QA/Tempest liason as well | 15:42 |
strony-zhang | Hi | 15:42 |
jgriffith | all sorts of possibilities :) | 15:42 |
markus_z | jgriffith: To be more specific, I have two patch which would benefit from feedback from a Cinder bug czar (+ team): https://review.openstack.org/#/c/209847/ + https://review.openstack.org/#/c/192232/ | 15:43 |
markus_z | *patches | 15:43 |
markus_z | jgriffith: Cool, I'll note down your name and nail you down on that :) | 15:44 |
markus_z | jgriffith: If you attend the summit in Tokyo, we should chat, I guess. | 15:44 |
strony-zhang | Could anyone please review and approve my BP filed last Friday, (https://blueprints.launchpad.net/cinder/+spec/zfs-iscsi-driver)? | 15:44 |
strony-zhang | Any comments are appreciated. | 15:44 |
jgriffith | strony-zhang: Update the release Juno-->Mitaka and point out that it's for the Mitake release and that you'll have CI | 15:45 |
jgriffith | strony-zhang: then I'd be happy to approve it | 15:46 |
jgriffith | and leave it to the incoming M PTL to target it | 15:46 |
thingee | smcginnis: asking again, did you test out this patch that you +2'd? https://review.openstack.org/#/c/225891/ | 15:46 |
smcginnis | thingee: No, that was entirely based on code review. | 15:46 |
jgriffith | jungleboyj: did you test it? ^^ | 15:47 |
markus_z | jgriffith: I'll attend tomorrows Cinder meeting, in case anyone has direct questions to me. Thanks for your time and effort! | 15:48 |
jungleboyj | jgriffith: No, I haven't tested taht one. | 15:50 |
jgriffith | thingee: ^^ | 15:50 |
*** cdelatte has joined #openstack-cinder | 15:50 | |
jungleboyj | jgriffith: Why? What is up? | 15:50 |
jgriffith | thingee: is apparantly asking if those that approved it tested it | 15:50 |
jgriffith | not sure if there's a problem etc | 15:50 |
strony-zhang | jgriffith:Thanks for your comments. I have updated the BP with the Mitaka-release target and make sure CI will be available. In fact, the existing ZFSSA CI within Oracle will be shared with my ZFS driver tests. | 15:52 |
*** timcl has joined #openstack-cinder | 15:53 | |
*** merooney has quit IRC | 15:54 | |
*** daneyon has joined #openstack-cinder | 15:54 | |
*** cdelatte has quit IRC | 15:54 | |
*** mc_nair has quit IRC | 15:55 | |
*** dustins is now known as dustins|afl | 15:55 | |
*** dustins|afl is now known as dustins|afk | 15:55 | |
*** timcl has quit IRC | 15:55 | |
*** RA_ has quit IRC | 15:57 | |
thingee | smcginnis, jungleboyj just making sure we feel good on these last merges before cut | 15:58 |
*** martyturner has quit IRC | 15:58 | |
*** RA_ has joined #openstack-cinder | 15:58 | |
smcginnis | thingee: I didn't see anything that caused me concern and it appeared to have covered the cases it needs to. | 15:59 |
thingee | I'll try to be more clear. | 15:59 |
thingee | I would appreciate someone verifying this if they're going to spend the time to +2 it | 16:00 |
thingee | at this point in the release. | 16:00 |
*** Apoorva has joined #openstack-cinder | 16:00 | |
*** zhangjn has quit IRC | 16:00 | |
*** cdelatte has joined #openstack-cinder | 16:00 | |
*** 1JTAAB3VD has joined #openstack-cinder | 16:00 | |
jungleboyj | thingee: Gotcha. Hadn't actually run that one since it was from e0ne and he knows that code. Didn't look terribly dangerouse. | 16:00 |
thingee | if no one can do that, I can do that later today | 16:00 |
*** cdelatte has quit IRC | 16:00 | |
*** 1JTAAB3VD has quit IRC | 16:00 | |
*** haomaiwa_ has quit IRC | 16:01 | |
*** haomaiwa_ has joined #openstack-cinder | 16:01 | |
thingee | looks like we're fine on the horizon side | 16:01 |
*** mudassirlatif has joined #openstack-cinder | 16:01 | |
*** BharatK has joined #openstack-cinder | 16:02 | |
*** daneyon_ has joined #openstack-cinder | 16:02 | |
*** whydidyoustealmy is now known as shakamunyi | 16:03 | |
*** gouthamr has joined #openstack-cinder | 16:03 | |
*** zhangjn has joined #openstack-cinder | 16:04 | |
*** RA_ has quit IRC | 16:04 | |
*** Yogi1 has joined #openstack-cinder | 16:04 | |
*** akerr has quit IRC | 16:05 | |
strony-zhang | jgriffith: thanks for your approval | 16:05 |
*** daneyon has quit IRC | 16:05 | |
openstackgerrit | Kendall Nelson proposed openstack/cinder: Missing configuration opts from cinder.sample.conf https://review.openstack.org/225974 | 16:06 |
*** annegent_ has joined #openstack-cinder | 16:06 | |
*** akerr has joined #openstack-cinder | 16:06 | |
thingee | jungleboyj, smcginnis ok left a -2 until I can verify things | 16:06 |
jungleboyj | Ok. Understood. | 16:07 |
gouthamr | DuncanT, smcginnis: got to bug you guys one more time for your reviews. I had to rebase because of a gate failure to merge: https://review.openstack.org/#/c/222413/ | 16:07 |
*** annegentle has quit IRC | 16:07 | |
*** Yogi1 has quit IRC | 16:12 | |
*** Yogi1 has joined #openstack-cinder | 16:13 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Allow c-vol backends to start when some backends fail to load https://review.openstack.org/225982 | 16:13 |
*** bswartz has quit IRC | 16:14 | |
*** timcl has joined #openstack-cinder | 16:16 | |
*** cdelatte has joined #openstack-cinder | 16:18 | |
*** EinstCrazy has quit IRC | 16:19 | |
*** bswartz has joined #openstack-cinder | 16:20 | |
*** timcl1 has joined #openstack-cinder | 16:20 | |
*** timcl has quit IRC | 16:22 | |
*** vgridnev has quit IRC | 16:22 | |
*** martyturner has joined #openstack-cinder | 16:24 | |
*** dosaboy_ has joined #openstack-cinder | 16:25 | |
*** dosaboy_ has quit IRC | 16:26 | |
*** mudassirlatif has quit IRC | 16:31 | |
*** dosaboy has quit IRC | 16:32 | |
*** dosaboy has joined #openstack-cinder | 16:33 | |
*** jdurgin1 has quit IRC | 16:34 | |
*** timcl1 has quit IRC | 16:35 | |
*** gouthamr has quit IRC | 16:35 | |
openstackgerrit | Jacob Gregor proposed openstack/cinder: Override 'enabled_backends' to None https://review.openstack.org/226408 | 16:38 |
*** Yogi1 has quit IRC | 16:39 | |
*** annegent_ has quit IRC | 16:40 | |
jgriffith | jungleboyj: https://bugs.launchpad.net/cinder/+bug/1498148 | 16:41 |
openstack | Launchpad bug 1498148 in Cinder "test_main_load_binary_exception fails if there is an existing /etc/cinder/cinder.conf file" [Medium,In progress] - Assigned to Jacob Gregor (jgregor) | 16:41 |
*** annegent_ has joined #openstack-cinder | 16:42 | |
*** pschaef has quit IRC | 16:44 | |
*** strony-zhang has quit IRC | 16:45 | |
*** david-lyle has quit IRC | 16:46 | |
*** annegent_ has quit IRC | 16:48 | |
*** delattec has joined #openstack-cinder | 16:49 | |
*** cdelatte has quit IRC | 16:52 | |
*** ronis has joined #openstack-cinder | 16:53 | |
*** delattec has quit IRC | 16:53 | |
*** markus_z has quit IRC | 16:54 | |
*** _cjones_ has joined #openstack-cinder | 16:55 | |
*** Swanson has joined #openstack-cinder | 16:55 | |
*** xyang1 has quit IRC | 16:57 | |
*** xyang1 has joined #openstack-cinder | 16:57 | |
*** rushil has joined #openstack-cinder | 16:58 | |
*** rushil has quit IRC | 17:00 | |
*** haomaiwa_ has quit IRC | 17:01 | |
*** haomaiwang has joined #openstack-cinder | 17:01 | |
*** dustins|afk is now known as dustins | 17:01 | |
*** delattec has joined #openstack-cinder | 17:02 | |
*** gouthamr_ has joined #openstack-cinder | 17:02 | |
*** hemnafk is now known as hemna | 17:06 | |
hemna | finally in. phew. | 17:08 |
*** vgridnev has joined #openstack-cinder | 17:08 | |
*** BharatK has quit IRC | 17:12 | |
*** merooney has joined #openstack-cinder | 17:14 | |
openstackgerrit | Scott DAngelo proposed openstack/cinder-specs: cinder-api-microversions https://review.openstack.org/223803 | 17:14 |
*** Yogi1 has joined #openstack-cinder | 17:16 | |
scottda | How come running run_tests.sh catches a few flake8 errors with "Running flake8 ..." but running flake8 manually catches 220 failures? | 17:23 |
*** timcl has joined #openstack-cinder | 17:25 | |
smcginnis | scottda: This? https://github.com/openstack/cinder/blob/master/tox.ini#L165 | 17:26 |
*** jordanP has quit IRC | 17:27 | |
scottda | No, I'm seeing E128, E126, etc..lots of unit test for drivers | 17:28 |
scottda | maybe they're being skipped elsewhere | 17:28 |
smcginnis | scottda: Ah, I think anything under the test directory is exluded when run via run_tests/tox. | 17:28 |
smcginnis | I'm sure there's probably a ton of violations in the tests. | 17:29 |
scottda | ok, that might be it | 17:29 |
openstackgerrit | Dmitry Guryanov proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 17:29 |
scottda | thanks smcginnis | 17:29 |
smcginnis | scottda: Anytime | 17:29 |
scottda | Actually, since you said 'anytime'... | 17:30 |
scottda | What about these? | 17:30 |
scottda | https://www.irccloud.com/pastebin/eCB0qukY/fail | 17:30 |
hemna | :P | 17:30 |
*** dims has quit IRC | 17:31 | |
scottda | I'd like to skip my P.I.T.A 'hanging indent' failures as well | 17:31 |
smcginnis | scottda: Interesting... | 17:32 |
*** dims has joined #openstack-cinder | 17:32 | |
*** lpetrut has quit IRC | 17:32 | |
smcginnis | scottda: Not sure why that would be. | 17:33 |
smcginnis | Actually looks correct in the code to me. | 17:33 |
smcginnis | The only reference I see in the ChangeLog is that E126 was enabled a while back. | 17:34 |
smcginnis | scottda: You're just running "flake8 ./cinder"? | 17:35 |
scottda | I'm running "/opt/stack/cinder$ flake8 | 17:35 |
scottda | (should be a quote at the end " | 17:36 |
scottda | in other words, just 'flake8' in the /opt/stack/cinder dir | 17:36 |
scottda | Although I'd appreciate any tips as to how to re-verify flake8 failures in a more proper way | 17:37 |
smcginnis | Well, I usually run it from my local dev repo, not out of /opt/stack/cinder, but I just do ./run_tests.sh -p | 17:38 |
smcginnis | Or "tox -e flake8" if your jgriffith and don't let convenient shell scripts. :) | 17:39 |
smcginnis | s/let/like/ | 17:39 |
*** haomaiwang has quit IRC | 17:39 | |
smcginnis | s/your/you're/ | 17:40 |
scottda | thanks. That's good to know. I'd still like to figure out how to fix some of these "hanging indent" and "visually indented line with same indent as next logical line" failures | 17:40 |
jgriffith | smcginnis: I used to be anti-tox, but have seen the error of my ways :) | 17:41 |
smcginnis | scottda: Yeah, I don't get why you are getting those. The indentation looks correct (at least in master) as far as I can see. | 17:41 |
jgriffith | smcginnis: like the bug jungleboyj logged :) | 17:41 |
smcginnis | jgriffith: ;) | 17:41 |
smcginnis | jgriffith: I was going to ask about htat. | 17:41 |
smcginnis | jgriffith: So should we just submit a patch to remove run_tests? | 17:41 |
smcginnis | Is it that evil? | 17:42 |
Swanson | yes | 17:43 |
smcginnis | Swanson: Hey, what are you doing here? :P | 17:43 |
*** delattec has quit IRC | 17:44 | |
openstackgerrit | Scott DAngelo proposed openstack/cinder: cinder-api-microversions code https://review.openstack.org/224910 | 17:44 |
Swanson | smcginnis: after the great windows 10 update fiasco of 2015 (never seen so many BSODs and such numbers!) I had to get everything running again including the VPN. | 17:44 |
Swanson | I don't think I'll be on too long. | 17:45 |
jgriffith | smcginnis: well.. that's a good question | 17:45 |
jgriffith | smcginnis: it's been suggested in the past that it should just go way | 17:45 |
*** mc_nair has joined #openstack-cinder | 17:46 | |
smcginnis | jgriffith: There seems to be enough confusion about it. At this point I'd rather just force one option and be done with it. | 17:46 |
jgriffith | smcginnis: but there were limitations in testr and such, which I *believe* are no longer there | 17:46 |
smcginnis | Especially if one has issues. | 17:46 |
jgriffith | smcginnis: I agree, just need to make sure everything is up to date now and works :) | 17:46 |
jgriffith | smcginnis: you *used* to not be able to set breakpoints, but you can now | 17:46 |
smcginnis | jgriffith: Oh, nice. | 17:47 |
jgriffith | so I don't know that there's any reason to keep run_tests.sh around any longer | 17:47 |
smcginnis | jgriffith: I remember struggling with that once. | 17:47 |
scottda | OK, new question: is there any way to post a patch, say a WIP, without triggering CI? | 17:47 |
smcginnis | scottda: Workflow-1? | 17:47 |
scottda | It's too late by then | 17:47 |
*** lpetrut has joined #openstack-cinder | 17:48 | |
smcginnis | scottda: If I remember right, certain actions will actually yank it from Jenkins. | 17:48 |
scottda | It's be nice if CI looked for something in the commit message like "WIP" and didn't trigger. | 17:48 |
smcginnis | scottda: Maybe a good question for infra? | 17:48 |
openstackgerrit | Ryan Lucio proposed openstack/cinder: VMEM v7000: support storage pools / volume types https://review.openstack.org/195773 | 17:48 |
scottda | even for 3rd party CI? That's what I'm most concerned about. | 17:48 |
scottda | I'll ask Infra | 17:48 |
jgriffith | scottda: nope | 17:49 |
jgriffith | scottda: but that's ok | 17:49 |
smcginnis | scottda: Well I only run after Jenkins says it's good, so it's fine with me. ;) | 17:49 |
jgriffith | scottda: you can use drafts, but that's frowned upon | 17:49 |
jgriffith | scottda: just post and mark workflow -1 "in progress" | 17:49 |
scottda | Ok. Just trying to keep the load down a bit. | 17:49 |
jgriffith | scottda: yeah... understood | 17:49 |
smcginnis | scottda: Probably a better time now than a few weeks ago. Only 80 in queue at the moment. | 17:50 |
jgriffith | scottda: so I mispoke, the draft option has been removed | 17:50 |
jgriffith | http://docs.openstack.org/infra/manual/developers.html | 17:51 |
smcginnis | So really frowned upon now. ;) | 17:51 |
jgriffith | "work in progress" section | 17:51 |
*** anshul has quit IRC | 17:51 | |
jgriffith | check gate isn't usually a huge concern | 17:51 |
*** mriedem has quit IRC | 17:52 | |
*** mriedem1 has joined #openstack-cinder | 17:53 | |
*** mc_nair has quit IRC | 17:55 | |
*** vgridnev has quit IRC | 17:55 | |
*** rushil has joined #openstack-cinder | 17:57 | |
asselin | scottda, it's up to the third party ci configuration | 17:57 |
asselin | scottda, we also wait for jenkins +1, but will run WIP patches, which can be helpful to developers | 17:58 |
hemna | jgriffith, I agree. I'm not sure why we still have run_tests.sh | 17:59 |
jgriffith | mtreinish: ^^ | 18:00 |
jgriffith | I think mtreinish and I talked about this once before | 18:01 |
*** _cjones_ has quit IRC | 18:01 | |
*** garthb has quit IRC | 18:02 | |
*** _cjones_ has joined #openstack-cinder | 18:02 | |
eharney | i don't think tox covers run_tests.sh -N or -8 | 18:02 |
*** garthb has joined #openstack-cinder | 18:02 | |
*** jungleboyj has quit IRC | 18:02 | |
jgriffith | eharney: for sure the -N | 18:02 |
jgriffith | but that's kind of the problem :) | 18:03 |
jgriffith | the -8 would just be "tox -epep8" | 18:03 |
jgriffith | I don't know that non-venv is a good thing any longer or not | 18:04 |
smcginnis | -8 just does the changed files, IIRC. | 18:04 |
jgriffith | thus the bug I mentioned earlier that IMO maybe isn't a bug | 18:04 |
eharney | tox -e pep8 is ./run_tests.sh -p | 18:04 |
mtreinish | jgriffith: why run_tests exists? | 18:04 |
mtreinish | it's mostly historical | 18:04 |
mtreinish | the one thing it does enable is running without a venv | 18:05 |
mtreinish | tox will always use a venv | 18:05 |
jgriffith | eharney: https://github.com/openstack/cinder/blob/master/tox.ini#L109 | 18:05 |
mtreinish | there have been multiple efforts to try and remove it in the past | 18:06 |
hemna | in the past that was sometimes the only way to get run_tests to work, was w/o a venv. | 18:06 |
mtreinish | but apparently people like it and they've never gone anywehere | 18:06 |
mtreinish | personally I don't understand it | 18:06 |
*** rushil has quit IRC | 18:06 | |
jgriffith | mtreinish: I say nuke it :) | 18:07 |
jgriffith | unless running outside of venv is a deal breaker for folks | 18:07 |
*** vgridnev has joined #openstack-cinder | 18:07 | |
jgriffith | that's the only advantage (or disadvantage actually) that I see | 18:07 |
jgriffith | I used to be the big WHINER there | 18:07 |
jgriffith | but since discovered things like pip-caching etc so venv rules ;) | 18:08 |
mtreinish | yeah, that's the only feature it offers on top of tox | 18:08 |
mtreinish | well does the cinder one use that colorizer script? | 18:08 |
mtreinish | because I've also heard that people like the colorful output | 18:08 |
mtreinish | but the colors don't actually mean anything useful so go figure | 18:09 |
*** ronis has quit IRC | 18:10 | |
hemna | I dig the colorized output, makes it more readable IMHO. | 18:11 |
*** delattec has joined #openstack-cinder | 18:11 | |
*** timcl has quit IRC | 18:13 | |
*** timcl has joined #openstack-cinder | 18:14 | |
*** ociuhandu has quit IRC | 18:16 | |
*** krtaylor has quit IRC | 18:16 | |
smcginnis | mtreinish: Do you know if there is any way to add the colorizer to tox's output? | 18:18 |
*** lpetrut has quit IRC | 18:20 | |
hemna | smcginnis, conditionally | 18:20 |
hemna | :P | 18:20 |
smcginnis | :) | 18:20 |
*** delattec has quit IRC | 18:21 | |
scottda | Well! I was going to look for some pep8 guru to help me figure out how to fix these, but you all have been replaced by a robot: https://github.com/hhatto/autopep8 | 18:21 |
hemna | all your base are belong to us | 18:22 |
mriedem1 | xyang1: i put some more comments in https://review.openstack.org/#/c/225278/ | 18:23 |
mriedem1 | xyang1: i'm not crazy about the blanket handling of 500 in there, but there don't seem to be very good alternatives | 18:23 |
hemna | scottda, http://www.vim.org/scripts/script.php?script_id=2914 | 18:23 |
xyang1 | mriedem1: reading it now | 18:23 |
xyang1 | mriedem1: yes, we don't have anything more specific now | 18:24 |
scottda | hemna: cool, thanks | 18:24 |
xyang1 | mriedem1: something we can improve later | 18:24 |
mriedem1 | xyang1: i'm not really sure how it can be improved | 18:24 |
*** mc_nair has joined #openstack-cinder | 18:24 | |
mriedem1 | unless just checking for a specific rpc timeout type exception that comes back from cinder | 18:24 |
mriedem1 | and is translated in cinderclient | 18:24 |
mriedem1 | xyang1: in the case of neutron, if we fail to bind or create ports, we just rollback | 18:26 |
mriedem1 | https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L722 | 18:26 |
thingee | jgriffith, smcginnis the quota-show patch lgtm. | 18:26 |
*** timcl1 has joined #openstack-cinder | 18:26 | |
smcginnis | thingee: Awesome, thanks! | 18:26 |
xyang1 | mriedem1: so rollback for any error? | 18:26 |
mriedem1 | xyang1: yeah i guess so | 18:27 |
xyang1 | mriedem1: we can do that too | 18:27 |
mriedem1 | xyang1: i'm on the fence, would be good to get some other opinions from people in there | 18:28 |
*** timcl has quit IRC | 18:28 | |
*** jwcroppe has joined #openstack-cinder | 18:29 | |
*** vgridnev has quit IRC | 18:30 | |
*** krtaylor has joined #openstack-cinder | 18:30 | |
xyang1 | mriedem1: i think this is best we can do for now. As you said, we we make a bigger change, it is not backportable | 18:32 |
*** ronis has joined #openstack-cinder | 18:32 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Remove run_tests.sh wrapper https://review.openstack.org/226487 | 18:34 |
smcginnis | jgriffith, hemna, eharney: thoughts? ^^ | 18:34 |
smcginnis | Figure I would throw it out there and make sure this is more visible. | 18:34 |
eharney | smcginnis: well as someone that uses run_tests.sh -V ... | 18:35 |
smcginnis | eharney: TBH, I use run_tests too. | 18:35 |
smcginnis | eharney: But there's been enough confusion around tox vs run_tests that I think we may be better off in the long run pushing everyone that way. | 18:35 |
*** garthb has quit IRC | 18:36 | |
*** _cjones_ has quit IRC | 18:36 | |
smcginnis | But hopefully this can get the conversation going, if nothing else. | 18:36 |
*** mss has quit IRC | 18:37 | |
hemna | as a devil's advocate, if we did remove run_tests.sh, then maybe folks that want the run_tests.sh only features might work on adding them to the tox env ? | 18:37 |
smcginnis | +1 | 18:37 |
eharney | hemna: i'm actually not sure they all can be reasonably added to tox, but i could be wrong (posting a comment now) | 18:38 |
xyang1 | smcginnis: seems like I am the only one who is still using run_tests?:). I don't have a problem moving away from it as I am using venv | 18:38 |
hemna | eharney, that's entirely possible yah. | 18:38 |
smcginnis | xyang1: You're definitely not the only one. | 18:38 |
hemna | but then again, is that justification enough to keep it around? dunno. | 18:38 |
xyang1 | smcginnis: ok, I feel better:) | 18:39 |
hemna | I don't use it, simply because tox is what the check and gate use. fwiw. | 18:39 |
*** rushil has joined #openstack-cinder | 18:46 | |
*** rushil has quit IRC | 18:46 | |
*** nikeshm has joined #openstack-cinder | 18:47 | |
*** angela-s has joined #openstack-cinder | 18:47 | |
*** aix has quit IRC | 18:49 | |
openstackgerrit | Kendall Nelson proposed openstack/cinder: WIP (until Mitaka opens up): Hacking check for opt name registration https://review.openstack.org/223375 | 18:51 |
*** _cjones_ has joined #openstack-cinder | 18:51 | |
*** lpetrut has joined #openstack-cinder | 18:51 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder-specs: Remove Volume Manager Locks https://review.openstack.org/149894 | 18:52 |
*** timcl1 has quit IRC | 18:52 | |
*** rushil has joined #openstack-cinder | 18:52 | |
*** ociuhandu has joined #openstack-cinder | 18:53 | |
*** lpetrut has quit IRC | 18:55 | |
*** rushil has quit IRC | 18:56 | |
*** jgregor has quit IRC | 18:56 | |
*** jgregor has joined #openstack-cinder | 18:57 | |
mtreinish | smcginnis: you can it's just an output filter you can have a job do something like for the command line in a tox env: testr run --subunit | colorizer | 18:58 |
hemna | mtreinish, have an example ? | 18:58 |
mtreinish | it's another weird artifact that colorizer gets called in run_tests and subunit-trace is used in tox | 18:58 |
mtreinish | not off the top of my head, no one does that with tox | 18:58 |
hemna | mtreinish, but I think eharney has a good point in the review that smcginnis put up. | 18:59 |
mtreinish | my guess is that its because colors don't work well in the console output and tox is used for gate runs | 18:59 |
*** jungleboyj has joined #openstack-cinder | 18:59 | |
gouthamr_ | Reaching out to core reviewers: https://review.openstack.org/#/c/222413/ - This patch was rebased after it had a merge conflict at the gate. Could I get one of your votes so it can retry.. | 18:59 |
mtreinish | I have no idea what the conversation was in reference to, jgriffith just asked me a question | 19:00 |
mtreinish | I'm too lazy to read the backlog | 19:00 |
*** 6JTAB3HZ2 has joined #openstack-cinder | 19:01 | |
*** 16WAAB3T7 has joined #openstack-cinder | 19:01 | |
*** hodos has quit IRC | 19:02 | |
*** hodos has joined #openstack-cinder | 19:02 | |
smcginnis | mtreinish: Thanks! Don't want to take too much advantage of your time, but if you're interested: https://review.openstack.org/226487 | 19:04 |
*** p0rtal has joined #openstack-cinder | 19:04 | |
hemna | mtreinish, :) | 19:04 |
openstackgerrit | Earle F. Philhower, III proposed openstack/os-brick: Fix typo in vgc-cluster command in rootwrap file https://review.openstack.org/226507 | 19:06 |
*** earlephilhower has joined #openstack-cinder | 19:09 | |
*** annasort has quit IRC | 19:10 | |
earlephilhower | hemna, thanks for the +2 before I could even refresh the gerrit. | 19:10 |
*** e0ne has joined #openstack-cinder | 19:10 | |
hemna | :) | 19:11 |
hemna | I think that one is my fault | 19:11 |
hemna | luckily no one is using that filter file just yet. | 19:11 |
hemna | so good catch | 19:11 |
hemna | :) | 19:11 |
mtreinish | smcginnis: ok, I left a comment on how you can use pdb with cinder's tox.ini | 19:11 |
*** vgridnev has joined #openstack-cinder | 19:12 | |
*** DericHorn-HP has joined #openstack-cinder | 19:14 | |
openstackgerrit | Michael Krotscheck proposed openstack/cinder: Added CORS support to Cinder https://review.openstack.org/219489 | 19:14 |
smcginnis | mtreinish: Awesome, thanks! | 19:15 |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Remove run_tests.sh wrapper https://review.openstack.org/226487 | 19:20 |
smcginnis | eharney: ^^ | 19:20 |
smcginnis | eharney: Didn't mean to wipe out your vote, but I thought it would be good to capture that debugging info in the devref. | 19:21 |
eharney | smcginnis: no problem | 19:23 |
eharney | smcginnis: i dunno what to think about that commit hook thing, other than that i doubt anyone uses it | 19:23 |
smcginnis | eharney: I had no idea it was there until I started grep'ing for run_test | 19:23 |
smcginnis | eharney: I actually wish I would have known about it. Could be handy. If it's quick though. | 19:24 |
winston-d | xyang1: ping | 19:25 |
xyang1 | winston-d: hi | 19:25 |
xyang1 | winston-d: still up? | 19:25 |
winston-d | xyang1: yeah | 19:25 |
winston-d | xyang1: about bug #1496655 | 19:26 |
openstack | bug 1496655 in Cinder "CG creation should be scheduled on backend level, not pool level" [Undecided,In progress] https://launchpad.net/bugs/1496655 - Assigned to wanghao (wanghao749) | 19:26 |
xyang1 | winston-d: sure | 19:26 |
eharney | smcginnis: losing run_tests.sh -8 still makes me kinda sad | 19:26 |
smcginnis | eharney: Never ran that one. I would think that would be really quick> | 19:26 |
winston-d | is there any possbility that some backend might not be able to create a cg across pools? | 19:27 |
xyang1 | winston-d: that is possible too | 19:27 |
xyang1 | winston-d: do we want to provide two options | 19:27 |
*** pv_ has joined #openstack-cinder | 19:27 | |
xyang1 | winston-d: manila's cg feature supports both, pool level or backend level | 19:28 |
winston-d | xyang1: is it possible to tell before the request gets to the driver? | 19:29 |
pv_ | is there a way openstack does device rescans? im using an external rescan script in my attach code and it doesn't recognize the LUNs until that script is executed | 19:29 |
xyang1 | winston-d: that will be thru volume type extra specs | 19:29 |
winston-d | xyang1: could you give me an example? | 19:29 |
xyang1 | winston-d: that will be an enhancement, not just a bug fix | 19:29 |
xyang1 | winston-d: one sec | 19:30 |
winston-d | sure | 19:30 |
smcginnis | eharney: Maybe we should rename it to run_checks or something and just strip it down the the flake8 pieces. | 19:30 |
smcginnis | That way everyone is consistent in running unit tests, but we have a quick tool for validating code? | 19:30 |
pv_ | ihttps://wiki.openstack.org/wiki/Cinder/FibreChannelSupport | 19:30 |
* smcginnis is brainstorming | 19:30 | |
pv_ | https://wiki.openstack.org/wiki/Cinder/FibreChannelSupport* | 19:30 |
pv_ | says that "Added a new class LibvirtFibreChannelVolumeDriver to nova/virt/libvirt/volume.py. This class implements connect_volume and disconnect_volume, it also has a private method that runs the rescan to make the kernal aware of the new storage." | 19:31 |
pv_ | but i cant find that rescan method | 19:31 |
e0ne | smcginnis: IMO, removing run_tests is a good idea | 19:31 |
*** xyang has joined #openstack-cinder | 19:32 | |
xyang | winston-d: https://review.openstack.org/#/c/215344/ | 19:32 |
smcginnis | e0ne: Cool, good to start getting the conversation going. I use run_tests, so I'm not against it. But I think it would be good to be consistent and not have multiple ways to do the same thing. | 19:32 |
smcginnis | Or rather, multiple ways that behave subtly different. | 19:33 |
e0ne | smcginnis: yes. two tests runners is too much | 19:33 |
smcginnis | pv_: That should be covered by os-brick now. | 19:33 |
smcginnis | pv_: https://github.com/openstack/os-brick/blob/471092c360b92eacad59aecbfa3974713956213d/os_brick/initiator/linuxfc.py | 19:33 |
e0ne | smcginnis: I'm only worring about removing it before RC | 19:33 |
e0ne | smcginnis: we don't know if vendors use it in their CI | 19:34 |
smcginnis | e0ne: Yeah, I think we should do this right away. True | 19:34 |
smcginnis | e0ne: Oops, that was a typo: I _don't_ think we should do this right away. | 19:36 |
e0ne | smcginnis: :) | 19:36 |
smcginnis | e0ne: We should wait for Mitaka. :) | 19:36 |
e0ne | smcginnis: agreed | 19:36 |
smcginnis | e0ne: I'm even fine abandoning it. I just wanted to put that out there to see what folks had to say about it. | 19:37 |
e0ne | smcginnis: just put -2 on it:) | 19:37 |
smcginnis | e0ne: Good point. | 19:38 |
pv_ | thank you friend | 19:38 |
pv_ | i was having trouble figuring out where that was | 19:38 |
pv_ | :D | 19:38 |
smcginnis | pv_: It's like a treasure hunt some times. ;) | 19:39 |
*** annasort has joined #openstack-cinder | 19:40 | |
jgriffith | mtreinish: sorry to drag you in and then leave :) | 19:41 |
mtreinish | jgriffith: I'm used to it by now :) | 19:41 |
jgriffith | LOL | 19:41 |
mtreinish | smcginnis: I left some additional comments on the first rev there about the gate hook | 19:41 |
mtreinish | s/gate/git | 19:41 |
mtreinish | tl;dr is I don't think a git hook for that is a good idea in general | 19:42 |
jgriffith | smcginnis: KUDOS for updating doc :) | 19:42 |
smcginnis | mtreinish: Yeah, seems like that might be bad. Thanks for adding that detail. | 19:42 |
smcginnis | jgriffith: We don't need no stinkin' docs. Oh wait, yes we do. | 19:43 |
jgriffith | Ahh.. that's probably what eharney was talking about... which frankly I didn't know was there, and I'm not sure even works | 19:43 |
*** Lee1092 has quit IRC | 19:43 | |
e0ne | smcginnis: I've added comment inline. tools/install_venv.py should be deleted too | 19:43 |
eharney | i agree that the hook probably just shouldn't be there | 19:43 |
smcginnis | e0ne: Good catch! | 19:43 |
openstackgerrit | Eric Harney proposed openstack/cinder: Add "fast8" tox env https://review.openstack.org/226523 | 19:45 |
eharney | smcginnis: solution for another complaint of mine ^ :) | 19:45 |
smcginnis | eharney: Nice! | 19:45 |
winston-d | xyang: thx, that's a big change | 19:45 |
winston-d | xyang: do you think it | 19:45 |
*** shyama has quit IRC | 19:46 | |
xyang | winston-d: yes, that is a new feature or at least an enhancement. we can't do it as a bug fix | 19:46 |
winston-d | xyang: do you think it's safer to stay with pool level cg before we have a similar cg filter in cinder? | 19:46 |
xyang | winston-d: it is probably safer now I think about it | 19:46 |
winston-d | xyang: otherwise, some backend will break after the fix | 19:46 |
xyang | winston-d: I don't think anyone is using backend level yet | 19:47 |
xyang | winston-d: agreed. so maybe we should go back to his other fix that was abandoned | 19:47 |
*** 16WAAB3T7 has quit IRC | 19:47 | |
*** 6JTAB3HZ2 has quit IRC | 19:47 | |
xyang | winston-d: let me take a look of his other fix again and add you as a reviewer. see if it make sense to address that first | 19:48 |
*** ronis has quit IRC | 19:48 | |
winston-d | xyang: sure. | 19:48 |
*** delattec has joined #openstack-cinder | 19:49 | |
*** delatte has joined #openstack-cinder | 19:49 | |
xyang | winston-d: this one https://review.openstack.org/#/c/223108/ | 19:50 |
e0ne | eharney: awesome patch! it will save our time a lot every commit:) | 19:55 |
eharney | :) | 19:57 |
*** porrua has quit IRC | 19:59 | |
winston-d | xyang: how does CG work with vol types? | 20:02 |
*** DericHorn-HP has quit IRC | 20:02 | |
*** annegentle has joined #openstack-cinder | 20:02 | |
winston-d | xyang: any specific things need to be in type extra specs? | 20:02 |
*** jamielennox|away is now known as jamielennox | 20:03 | |
xyang | winston-d: there's this consistencygroup_support, but it is not required to be in extra specs. we actually have code in scheduler to handle that | 20:03 |
xyang | winston-d: so it depends on backend report consistencygroup_support | 20:03 |
winston-d | xyang: so is bug #1495524 a valid one? | 20:04 |
openstack | bug 1495524 in Cinder "Add volume to consistencygroup should have validation on pool level" [Undecided,In progress] https://launchpad.net/bugs/1495524 - Assigned to wanghao (wanghao749) | 20:04 |
*** DericHorn-HP has joined #openstack-cinder | 20:04 | |
xyang | winston-d: so update cg is checking at backend level, that is the inconsistency | 20:06 |
xyang | winston-d: when we create cg, it is in the same pool, but update cg is checking if they are on the same backend | 20:06 |
xyang | winston-d: so he end up adding a volume in a different pool to the cg | 20:07 |
winston-d | xyang: when create a cg, what if the user put a vol type with the CG that allows vol to be placed to a backend/pool that doesn't support CG? | 20:07 |
xyang | winston-d: the backend/pool has to report cg_support = true to be selected at create time | 20:08 |
xyang | winston-d: the problem is at update time, it doesn't go thru the scheduler | 20:08 |
*** babababa has joined #openstack-cinder | 20:09 | |
*** p0rtal has quit IRC | 20:09 | |
*** p0rtal has joined #openstack-cinder | 20:10 | |
*** rhagarty has joined #openstack-cinder | 20:11 | |
*** rhagarty_ has joined #openstack-cinder | 20:11 | |
*** dustins is now known as dustins|afk | 20:12 | |
winston-d | xyang: so the ultimate fix is to go through scheduler when updating CG rather than limit CG to pool? | 20:13 |
*** p0rtal has quit IRC | 20:14 | |
xyang | winston-d: our tradition is not to go through scheduler if we already know which backend to go. so I think we should just make sure it is the same pool | 20:14 |
xyang | winston-d: in this case, a CG is already created on a backend/pool, we just add another volume to it | 20:15 |
xyang | winston-d: so just make sure they are not conflicting with each other | 20:15 |
xyang | winston-d: so I think basically this fix makes sure when we add a volume to a CG we are making sure the volume and CG are in the same pool. at CG creation time, we chose a pool that supports CG | 20:17 |
winston-d | xyang: hmm, if a vol type X is not explictly limited with cg_support = true, and a CG was created with type X, what would happen? | 20:18 |
xyang | winston-d: what do you mean "not explicitly limited"? | 20:19 |
xyang | winston-d: you mean the same volume can support CG or not support CG? | 20:19 |
xyang | winston-d: volume type | 20:19 |
xyang | winston-d: so in his case, he used the same volume type for two different pools | 20:20 |
xyang | winston-d: pool1 support cg, pool2 doesn't support cg | 20:20 |
xyang | winston-d: that is why I initially said it is invalid | 20:21 |
xyang | winston-d: use two different volume types then he won't have this issue | 20:21 |
winston-d | xyang: invalid means creating CG with type X would fail? | 20:21 |
xyang | winston-d: so he should have type X associated with pool1 which supports CG and have a type Y associated with pool2 which does not support CG | 20:22 |
xyang | winston-d: when creating CG, you give type X | 20:22 |
xyang | winston-d: then he won't be able to add any volume with type Y to the CG | 20:22 |
*** pv_ has quit IRC | 20:23 | |
xyang | winston-d: If you give both type X and type Y when creating CG, it will fail | 20:23 |
winston-d | right, but what if someone made a mistake like that, Cinder won't be able to prevent such user error? | 20:23 |
*** markstur_ has joined #openstack-cinder | 20:23 | |
xyang | winston-d: yes | 20:23 |
xyang | winston-d: so that is why we are looking at his fix | 20:24 |
winston-d | xyang: do you have CG docuemnt link handy? | 20:24 |
xyang | winston-d: one sec | 20:24 |
*** markstur_ has left #openstack-cinder | 20:25 | |
xyang | winston-d: http://docs.openstack.org/admin-guide-cloud/blockstorage-consistency-groups.html | 20:27 |
winston-d | xyang: thx! | 20:28 |
xyang | winston-d: you are welcome | 20:28 |
*** p0rtal has joined #openstack-cinder | 20:35 | |
openstackgerrit | Fergal Mc Carthy proposed openstack/cinder: Setup LVM_SYSTEM_DIR earlier in LVM.__init() https://review.openstack.org/226543 | 20:40 |
*** gman-tx has quit IRC | 20:42 | |
*** p0rtal_ has joined #openstack-cinder | 20:44 | |
*** p0rtal has quit IRC | 20:45 | |
*** p0rtal has joined #openstack-cinder | 20:45 | |
*** tpsilva has quit IRC | 20:47 | |
*** p0rtal_ has quit IRC | 20:49 | |
*** bswartz has quit IRC | 20:49 | |
*** e0ne has quit IRC | 20:51 | |
*** thangp has quit IRC | 20:52 | |
*** diogogmt has quit IRC | 20:52 | |
*** annegentle has quit IRC | 20:54 | |
*** DericHorn-HP has quit IRC | 20:55 | |
*** DericHorn-HP has joined #openstack-cinder | 20:55 | |
*** akerr has quit IRC | 20:58 | |
*** diogogmt has joined #openstack-cinder | 20:58 | |
*** eharney has quit IRC | 21:00 | |
*** DericHorn-HP has quit IRC | 21:02 | |
*** mudassirlatif has joined #openstack-cinder | 21:03 | |
*** Yogi1 has quit IRC | 21:06 | |
*** gouthamr_ has quit IRC | 21:06 | |
*** timcl has joined #openstack-cinder | 21:10 | |
*** martyturner1 has joined #openstack-cinder | 21:10 | |
*** timcl has quit IRC | 21:11 | |
*** martyturner has quit IRC | 21:12 | |
*** raildo is now known as raildo-afk | 21:12 | |
jungleboyj | jgriffith: thingee I have had a request to get this through: https://review.openstack.org/#/c/222413 It was +A yesterday and had issues in the gate. Limited to netapp driver. Concerns with +A'ing again? | 21:13 |
*** martyturner1 has quit IRC | 21:16 | |
*** IanGovett1 has quit IRC | 21:16 | |
*** cfriesen__ has joined #openstack-cinder | 21:18 | |
*** jaypipes has quit IRC | 21:19 | |
jgriffith | jungleboyj: you mean other than the fact that it's a 500 line patch :) | 21:20 |
jgriffith | jungleboyj: and adds a new config option.... | 21:20 |
jgriffith | and changes documentation... | 21:20 |
jgriffith | and ..... | 21:20 |
jgriffith | :) | 21:20 |
jgriffith | jungleboyj: in all seriousness, I personally have no problem with it | 21:20 |
cfriesen__ | Hi...I recently had an issue with one file out of a dozen or so in "/opt/cgcs/cinder/data/volumes/" being present but of size zero. Looking at the code in volume.targets.tgt.TgtAdm.create_iscsi_target(), I'm wondering if we should do a fsync() before the close(). | 21:21 |
jungleboyj | jgriffith: Yeah, I know. It is in their driver. It should have gone in yesterday but had to be rebased. | 21:21 |
*** DericHorn-HP has joined #openstack-cinder | 21:21 | |
jungleboyj | jgriffith: Otherwise, we wouldn't be having the discussion. | 21:21 |
cfriesen__ | This was on stable/kilo, if it makes a difference. | 21:21 |
jgriffith | jungleboyj: :) Honestly I don't have a problem with it | 21:21 |
jungleboyj | jgriffith: Ok, I am going to push the buttong again. | 21:22 |
jgriffith | jungleboyj: it's their driver, AFAIC it's their call | 21:22 |
jungleboyj | tbarron: You are welcome. | 21:22 |
jungleboyj | :-) | 21:22 |
*** annegentle has joined #openstack-cinder | 21:24 | |
*** DericHorn-HP has quit IRC | 21:27 | |
openstackgerrit | Fergal Mc Carthy proposed openstack/cinder: Use lvm_conf_file directory for LVM_SYSTEM_DIR value. https://review.openstack.org/226562 | 21:31 |
*** mc_nair has quit IRC | 21:31 | |
*** alejandrito has quit IRC | 21:32 | |
*** alejandrito has joined #openstack-cinder | 21:33 | |
*** delatte has quit IRC | 21:37 | |
*** delattec has quit IRC | 21:37 | |
*** mc_nair has joined #openstack-cinder | 21:38 | |
*** delattec has joined #openstack-cinder | 21:39 | |
*** delatte has joined #openstack-cinder | 21:39 | |
*** mudassirlatif_ has joined #openstack-cinder | 21:46 | |
*** babababa has quit IRC | 21:46 | |
*** mudassirlatif has quit IRC | 21:47 | |
*** mudassirlatif_ is now known as mudassirlatif | 21:47 | |
*** mriedem1 has quit IRC | 21:48 | |
*** salv-orlando has joined #openstack-cinder | 21:48 | |
openstackgerrit | Jay Bryant proposed openstack/cinder: Remove unused gettextutils from oslo-incubator https://review.openstack.org/225978 | 21:48 |
*** mriedem has joined #openstack-cinder | 21:53 | |
*** annegentle has quit IRC | 21:54 | |
*** annegentle has joined #openstack-cinder | 21:54 | |
*** mudassirlatif has quit IRC | 21:57 | |
*** xyang has quit IRC | 21:59 | |
*** jgregor has quit IRC | 22:00 | |
*** delatte has quit IRC | 22:03 | |
*** delattec has quit IRC | 22:03 | |
*** jungleboyj has quit IRC | 22:05 | |
*** edtubill has left #openstack-cinder | 22:07 | |
*** cppforlife_ has quit IRC | 22:07 | |
*** jerrygb has joined #openstack-cinder | 22:08 | |
*** ndipanov has quit IRC | 22:08 | |
*** cppforlife_ has joined #openstack-cinder | 22:08 | |
*** delattec has joined #openstack-cinder | 22:08 | |
*** delatte has joined #openstack-cinder | 22:08 | |
*** ndipanov has joined #openstack-cinder | 22:09 | |
*** sparr has quit IRC | 22:10 | |
*** edmondsw has quit IRC | 22:10 | |
*** garthb has joined #openstack-cinder | 22:11 | |
*** garthb has quit IRC | 22:11 | |
*** Guest61243 is now known as mfisch | 22:11 | |
*** garthb has joined #openstack-cinder | 22:12 | |
*** zhenguo has quit IRC | 22:12 | |
*** sparr has joined #openstack-cinder | 22:12 | |
*** mfisch is now known as Guest50715 | 22:12 | |
*** zhenguo has joined #openstack-cinder | 22:13 | |
*** dustins|afk has quit IRC | 22:13 | |
*** Guest50715 is now known as mfisch | 22:13 | |
*** mfisch has quit IRC | 22:13 | |
*** mfisch has joined #openstack-cinder | 22:13 | |
*** babababa has joined #openstack-cinder | 22:20 | |
*** boris-42 has quit IRC | 22:22 | |
*** babababa_ has joined #openstack-cinder | 22:22 | |
*** boris-42 has joined #openstack-cinder | 22:24 | |
*** babababa has quit IRC | 22:25 | |
*** babababa_ is now known as babababa | 22:25 | |
*** jwcroppe has quit IRC | 22:25 | |
*** zhangjn has quit IRC | 22:26 | |
*** jwcroppe has joined #openstack-cinder | 22:26 | |
*** thrawn01 has quit IRC | 22:26 | |
*** thrawn01 has joined #openstack-cinder | 22:26 | |
*** ndipanov has quit IRC | 22:26 | |
*** briancurtin has quit IRC | 22:26 | |
*** ndipanov has joined #openstack-cinder | 22:27 | |
*** babababa has quit IRC | 22:28 | |
*** briancurtin has joined #openstack-cinder | 22:29 | |
*** babababa has joined #openstack-cinder | 22:30 | |
*** mudassirlatif has joined #openstack-cinder | 22:30 | |
*** jwcroppe has quit IRC | 22:30 | |
*** merooney has quit IRC | 22:31 | |
*** babababa has quit IRC | 22:33 | |
*** mc_nair has quit IRC | 22:33 | |
*** babababa has joined #openstack-cinder | 22:36 | |
*** babababa has quit IRC | 22:39 | |
*** delatte has quit IRC | 22:42 | |
*** delattec has quit IRC | 22:42 | |
*** zhangjn has joined #openstack-cinder | 22:43 | |
*** zhangjn has quit IRC | 22:44 | |
*** zhangjn has joined #openstack-cinder | 22:45 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder-specs: Remove Volume Manager Locks https://review.openstack.org/149894 | 22:47 |
*** alejandrito has quit IRC | 22:55 | |
*** annasort has quit IRC | 22:56 | |
*** annegentle has quit IRC | 22:56 | |
*** angela-s has quit IRC | 23:01 | |
*** delatte has joined #openstack-cinder | 23:04 | |
*** delattec has joined #openstack-cinder | 23:04 | |
*** lcurtis has quit IRC | 23:11 | |
*** lcurtis_ has quit IRC | 23:11 | |
*** lprice has quit IRC | 23:12 | |
*** dims has quit IRC | 23:18 | |
*** stevemar has quit IRC | 23:23 | |
*** salv-orlando has quit IRC | 23:25 | |
*** stevemar has joined #openstack-cinder | 23:32 | |
*** stevemar has quit IRC | 23:36 | |
*** markvoelker has quit IRC | 23:40 | |
*** rushil has joined #openstack-cinder | 23:54 | |
*** dims has joined #openstack-cinder | 23:54 | |
*** dims has quit IRC | 23:55 | |
*** Guest18166 has joined #openstack-cinder | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!