| *** bswartz has joined #openstack-cinder | 00:02 | |
| *** gouthamr has joined #openstack-cinder | 00:12 | |
| *** jwcroppe has joined #openstack-cinder | 00:14 | |
| *** vgridnev has quit IRC | 00:17 | |
| *** vgridnev has joined #openstack-cinder | 00:18 | |
| *** mriedem1 has joined #openstack-cinder | 00:18 | |
| *** garthb has quit IRC | 00:21 | |
| *** mriedem has quit IRC | 00:21 | |
| *** tsekiyama has quit IRC | 00:26 | |
| *** mtanino has quit IRC | 00:29 | |
| *** mudassirlatif has joined #openstack-cinder | 00:29 | |
| *** bill_az has quit IRC | 00:40 | |
| *** gouthamr has quit IRC | 00:47 | |
| *** mriedem has joined #openstack-cinder | 00:51 | |
| *** leeantho has quit IRC | 00:52 | |
| *** mriedem1 has quit IRC | 00:53 | |
| *** julim has quit IRC | 01:01 | |
| *** wN has quit IRC | 01:08 | |
| *** jwcroppe has quit IRC | 01:11 | |
| *** gouthamr has joined #openstack-cinder | 01:15 | |
| *** julim has joined #openstack-cinder | 01:19 | |
| *** akerr has joined #openstack-cinder | 01:21 | |
| *** _cjones_ has quit IRC | 01:29 | |
| *** akerr_ has joined #openstack-cinder | 01:33 | |
| *** dustins has joined #openstack-cinder | 01:34 | |
| *** Lee1092 has joined #openstack-cinder | 01:35 | |
| *** akerr has quit IRC | 01:36 | |
| *** mudassirlatif has quit IRC | 01:40 | |
| *** _cjones_ has joined #openstack-cinder | 01:40 | |
| *** geguileo has quit IRC | 01:40 | |
| *** mudassirlatif has joined #openstack-cinder | 01:41 | |
| *** mudassirlatif has quit IRC | 01:41 | |
| *** geguileo has joined #openstack-cinder | 01:49 | |
| *** julim has quit IRC | 01:58 | |
| *** EinstCrazy has joined #openstack-cinder | 01:59 | |
| *** IlyaG has joined #openstack-cinder | 02:00 | |
| *** EinstCrazy has quit IRC | 02:04 | |
| *** edmondsw has quit IRC | 02:05 | |
| *** jerrygb has joined #openstack-cinder | 02:09 | |
| *** wN has joined #openstack-cinder | 02:13 | |
| *** wN has joined #openstack-cinder | 02:13 | |
| *** markvoelker has quit IRC | 02:15 | |
| *** lcurtis has quit IRC | 02:20 | |
| *** dims__ has quit IRC | 02:29 | |
| *** dims_ has joined #openstack-cinder | 02:29 | |
| *** martyturner has joined #openstack-cinder | 02:32 | |
| *** martyturner has quit IRC | 02:36 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Target iSCSI IP address https://review.openstack.org/229712 | 02:40 |
|---|---|---|
| *** gouthamr has quit IRC | 02:41 | |
| *** apoorvad has joined #openstack-cinder | 02:45 | |
| *** apoorvad_ has quit IRC | 02:48 | |
| *** haomaiwang has joined #openstack-cinder | 02:50 | |
| *** apoorvad has quit IRC | 02:50 | |
| *** haomaiwang has quit IRC | 02:50 | |
| *** haomaiwa_ has joined #openstack-cinder | 02:51 | |
| *** mriedem has quit IRC | 02:51 | |
| *** gouthamr has joined #openstack-cinder | 02:59 | |
| *** vgridnev has quit IRC | 03:00 | |
| *** vgridnev has joined #openstack-cinder | 03:01 | |
| *** haomaiwa_ has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-cinder | 03:01 | |
| *** diogogmt has quit IRC | 03:05 | |
| *** dustins has quit IRC | 03:07 | |
| *** willsama has joined #openstack-cinder | 03:07 | |
| *** dave-mccowan has quit IRC | 03:10 | |
| *** lcurtis has joined #openstack-cinder | 03:11 | |
| *** ociuhandu has joined #openstack-cinder | 03:12 | |
| *** EinstCrazy has joined #openstack-cinder | 03:14 | |
| *** dims__ has joined #openstack-cinder | 03:15 | |
| *** markvoelker has joined #openstack-cinder | 03:15 | |
| *** dims___ has joined #openstack-cinder | 03:16 | |
| *** dims____ has joined #openstack-cinder | 03:18 | |
| *** dims_ has quit IRC | 03:18 | |
| *** markvoelker has quit IRC | 03:20 | |
| *** dims__ has quit IRC | 03:20 | |
| *** BharatK has joined #openstack-cinder | 03:21 | |
| *** dims___ has quit IRC | 03:21 | |
| *** gouthamr has quit IRC | 03:25 | |
| *** r-daneel has quit IRC | 03:26 | |
| *** dims____ has quit IRC | 03:37 | |
| *** lcurtis has quit IRC | 03:41 | |
| *** salv-orl_ has joined #openstack-cinder | 03:43 | |
| *** jwcroppe has joined #openstack-cinder | 03:43 | |
| *** salv-orlando has quit IRC | 03:46 | |
| *** links has joined #openstack-cinder | 03:55 | |
| *** jerrygb has quit IRC | 03:57 | |
| *** jerrygb has joined #openstack-cinder | 03:58 | |
| *** boris-42 has quit IRC | 03:59 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-cinder | 04:01 | |
| *** harlowja_at_home has joined #openstack-cinder | 04:10 | |
| *** apoorvad has joined #openstack-cinder | 04:12 | |
| *** markvoelker has joined #openstack-cinder | 04:16 | |
| *** markvoelker has quit IRC | 04:20 | |
| *** willsama has quit IRC | 04:23 | |
| *** stevemar has joined #openstack-cinder | 04:30 | |
| openstackgerrit | xing-yang proposed openstack/cinder-specs: Integrate replication with consistency group https://review.openstack.org/229722 | 04:34 |
| *** BharatK has quit IRC | 04:48 | |
| *** shausy has joined #openstack-cinder | 04:48 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-cinder | 05:01 | |
| *** vgridnev has quit IRC | 05:06 | |
| *** akerr_ is now known as akerr_away | 05:06 | |
| openstackgerrit | xing-yang proposed openstack/cinder: WIP: Replication CG Integration Phase 1 https://review.openstack.org/229727 | 05:18 |
| *** harlowja_at_home has quit IRC | 05:19 | |
| *** BharatK has joined #openstack-cinder | 05:19 | |
| *** shausy has quit IRC | 05:35 | |
| *** vgridnev has joined #openstack-cinder | 05:35 | |
| *** shausy has joined #openstack-cinder | 05:36 | |
| *** haomaiwang has quit IRC | 05:54 | |
| *** IlyaG has quit IRC | 05:54 | |
| *** haomaiwang has joined #openstack-cinder | 05:54 | |
| *** IlyaG has joined #openstack-cinder | 05:54 | |
| *** IlyaG has quit IRC | 05:59 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-cinder | 06:01 | |
| *** apoorvad has quit IRC | 06:02 | |
| *** EinstCrazy has quit IRC | 06:05 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: Clone cg support in VNX driver https://review.openstack.org/215530 | 06:07 |
| openstackgerrit | Peter Wang proposed openstack/cinder: Clone cg support in VNX driver https://review.openstack.org/215530 | 06:09 |
| *** shausy has quit IRC | 06:10 | |
| *** shausy has joined #openstack-cinder | 06:10 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: Clone cg support in VNX driver https://review.openstack.org/215530 | 06:11 |
| *** nkrinner has joined #openstack-cinder | 06:13 | |
| *** markvoelker has joined #openstack-cinder | 06:17 | |
| *** markvoelker has quit IRC | 06:21 | |
| *** akerr_away has quit IRC | 06:25 | |
| *** vgridnev has quit IRC | 06:29 | |
| *** rajesht_ has quit IRC | 06:38 | |
| *** aarefiev has joined #openstack-cinder | 06:54 | |
| *** svasheka has joined #openstack-cinder | 06:55 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-cinder | 07:01 | |
| *** lpetrut has joined #openstack-cinder | 07:03 | |
| *** boris-42 has joined #openstack-cinder | 07:07 | |
| *** wolsen has quit IRC | 07:08 | |
| *** lpetrut has quit IRC | 07:20 | |
| *** IlyaG has joined #openstack-cinder | 07:25 | |
| *** ronis has joined #openstack-cinder | 07:28 | |
| *** IlyaG has quit IRC | 07:29 | |
| *** markus_z has joined #openstack-cinder | 07:43 | |
| *** openstackgerrit has quit IRC | 07:46 | |
| *** e0ne has joined #openstack-cinder | 07:46 | |
| *** openstackgerrit has joined #openstack-cinder | 07:47 | |
| *** e0ne has quit IRC | 07:49 | |
| *** e0ne has joined #openstack-cinder | 07:54 | |
| *** e0ne has quit IRC | 07:56 | |
| *** thingee has joined #openstack-cinder | 07:57 | |
| openstackgerrit | Philipp Marek proposed openstack/cinder: DRBD: new option "drbdmanage_devs_on_controller". https://review.openstack.org/229396 | 08:00 |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-cinder | 08:01 | |
| *** haomaiwang has quit IRC | 08:03 | |
| *** jordanP has joined #openstack-cinder | 08:08 | |
| *** edtubill has quit IRC | 08:12 | |
| *** alexpilotti has joined #openstack-cinder | 08:17 | |
| *** markvoelker has joined #openstack-cinder | 08:18 | |
| *** jistr has joined #openstack-cinder | 08:18 | |
| *** markvoelker has quit IRC | 08:22 | |
| *** e0ne has joined #openstack-cinder | 08:26 | |
| *** thingee has quit IRC | 08:31 | |
| *** ndipanov has joined #openstack-cinder | 08:34 | |
| *** e0ne has quit IRC | 08:36 | |
| *** haomaiwang has joined #openstack-cinder | 08:37 | |
| *** e0ne has joined #openstack-cinder | 08:38 | |
| *** wilson1 has quit IRC | 08:38 | |
| *** wilson1 has joined #openstack-cinder | 08:38 | |
| *** shausy has quit IRC | 08:40 | |
| *** salv-orlando has joined #openstack-cinder | 08:46 | |
| *** salv-or__ has joined #openstack-cinder | 08:46 | |
| *** salv-orl_ has quit IRC | 08:49 | |
| *** salv-orlando has quit IRC | 08:50 | |
| *** BharatK has quit IRC | 08:51 | |
| *** abehl has joined #openstack-cinder | 08:52 | |
| *** lpetrut has joined #openstack-cinder | 08:58 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** 6A4AALXHF has joined #openstack-cinder | 09:01 | |
| *** aix has joined #openstack-cinder | 09:04 | |
| *** BharatK has joined #openstack-cinder | 09:04 | |
| *** vgridnev has joined #openstack-cinder | 09:04 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Small optimization in Block Device driver https://review.openstack.org/220561 | 09:05 |
| *** deepakcs has joined #openstack-cinder | 09:11 | |
| *** alexpilotti has quit IRC | 09:13 | |
| *** shausy has joined #openstack-cinder | 09:19 | |
| *** salv-orlando has joined #openstack-cinder | 09:26 | |
| *** IanGovett has joined #openstack-cinder | 09:28 | |
| *** salv-or__ has quit IRC | 09:30 | |
| *** bluex-pl has joined #openstack-cinder | 09:33 | |
| *** bluex-pl has quit IRC | 09:34 | |
| *** bluex-pl has joined #openstack-cinder | 09:34 | |
| *** SamYaple has joined #openstack-cinder | 09:37 | |
| SamYaple | can someone point me to some documentation about the [keymgr]/encryption_auth_url setting? im a bit confused as to what it does | 09:38 |
| *** salv-orl_ has joined #openstack-cinder | 09:42 | |
| *** salv-orlando has quit IRC | 09:45 | |
| *** vgridnev has quit IRC | 09:46 | |
| *** boris-42 has quit IRC | 09:49 | |
| *** 6A4AALXHF has quit IRC | 09:52 | |
| *** haomaiwang has joined #openstack-cinder | 09:52 | |
| *** e0ne has quit IRC | 09:53 | |
| *** dims has joined #openstack-cinder | 09:55 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Small optimization in Block Device driver https://review.openstack.org/220561 | 09:55 |
| *** e0ne has joined #openstack-cinder | 09:56 | |
| *** IlyaG has joined #openstack-cinder | 09:56 | |
| *** lprice1 has joined #openstack-cinder | 09:58 | |
| *** lprice has quit IRC | 09:58 | |
| *** alexpilotti has joined #openstack-cinder | 09:58 | |
| *** IlyaG has quit IRC | 10:00 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-cinder | 10:01 | |
| *** vgridnev has joined #openstack-cinder | 10:03 | |
| *** stevemar has quit IRC | 10:08 | |
| *** stevemar has joined #openstack-cinder | 10:09 | |
| *** stevemar has quit IRC | 10:13 | |
| *** shausy has quit IRC | 10:15 | |
| *** markvoelker has joined #openstack-cinder | 10:19 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Small optimization in Block Device driver https://review.openstack.org/220561 | 10:21 |
| *** markvoelker has quit IRC | 10:23 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Small optimization in Block Device driver https://review.openstack.org/220561 | 10:27 |
| *** dsariel_ has joined #openstack-cinder | 10:30 | |
| *** geektoor has joined #openstack-cinder | 10:31 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Small optimization in Block Device driver https://review.openstack.org/220561 | 10:32 |
| *** alexpilotti has quit IRC | 10:35 | |
| *** alexpilotti has joined #openstack-cinder | 10:36 | |
| openstackgerrit | Abhishek Shrivastava proposed openstack/cinder: Setup error check & minor bug fix in CloudByte https://review.openstack.org/229814 | 10:37 |
| *** asselin_ has joined #openstack-cinder | 10:37 | |
| *** asselin__ has quit IRC | 10:40 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Implement extend_volume method to Block Device driver https://review.openstack.org/221303 | 10:40 |
| *** BharatK has quit IRC | 10:42 | |
| *** BharatK has joined #openstack-cinder | 10:55 | |
| *** cvstealt1 is now known as cvstealth | 10:57 | |
| *** divab has quit IRC | 11:00 | |
| *** haomaiwang has quit IRC | 11:01 | |
| openstackgerrit | yogeshprasad proposed openstack/cinder: Retype support for CloudByte iSCSI cinder driver https://review.openstack.org/218645 | 11:01 |
| *** haomaiwang has joined #openstack-cinder | 11:01 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Implement snapshots-related features for Block Device Driver https://review.openstack.org/222292 | 11:02 |
| e0ne | DuncanT: hi. are you around? I've got few questions about bare-metal attach | 11:05 |
| *** aix has quit IRC | 11:27 | |
| nikeshm | hi, is there any plan to add --force in kilo for cinder backups, because manual shows it is present in kilo but it is present only in liberty http://docs.openstack.org/admin-guide-cloud/blockstorage_volume_backups.html | 11:30 |
| e0ne | DuncanT: I'm not sure should it be depended on cinderclient or not | 11:31 |
| DuncanT | e0ne: Hi | 11:31 |
| e0ne | nikeshm: no, we don't backport features | 11:31 |
| DuncanT | nikeshm: No, that is liberty only | 11:32 |
| e0ne | nikeshm: from the docs you proviced: "Note: The force flag is new in OpenStack Liberty." | 11:32 |
| nikeshm | oh sorry missed that | 11:32 |
| nikeshm | thanks | 11:33 |
| *** yuriy_n17 has joined #openstack-cinder | 11:34 | |
| *** markvoelker has joined #openstack-cinder | 11:34 | |
| e0ne | DuncanT: I've got a poc of brickclient. but it uses cinderclient | 11:36 |
| e0ne | DuncanT: could it be an issue? | 11:36 |
| *** porrua has joined #openstack-cinder | 11:36 | |
| DuncanT | e0ne: I think it is highly likely to use the cinder client internals, so depending on it is fine IMO | 11:37 |
| e0ne | DuncanT: yes, it uses cinder api | 11:37 |
| DuncanT | e0ne: Seems daft to duplicate the common code | 11:38 |
| *** timcl has joined #openstack-cinder | 11:38 | |
| e0ne | DuncanT: +1 | 11:38 |
| *** markvoelker has quit IRC | 11:39 | |
| *** dave-mccowan has joined #openstack-cinder | 11:41 | |
| e0ne | DuncanT: https://github.com/e0ne/python-brickclient - a very-very early poc. just moved all things out of cinderclient | 11:41 |
| DuncanT | e0ne: I think auth etc can just be imported from python-cinderclient | 11:42 |
| e0ne | DuncanT: it's good idea, but we need to make some refactoring of the cinderclient first to get it imported | 11:43 |
| e0ne | DuncanT: actually, this code is almost copy-patsed in all clients:( | 11:44 |
| DuncanT | e0ne: That doesn't surprise me. Great start though - we can clean up as we go | 11:44 |
| e0ne | :) | 11:44 |
| e0ne | DuncanT: I'm going to cleanup a bit later | 11:44 |
| e0ne | DuncanT: the plan is: rbd support, some kind of manual, {unit}tests, cleanup code | 11:45 |
| DuncanT | e0ne: Seems reasonable. Good error output of things in the initialise_connection reply that it doesn't understand seem highly desirable too - that covers both the weird drives (sheepdog etc) and things like encryption | 11:46 |
| e0ne | DuncanT: two kind of connectors (iscsi and rbd) will be helpful to understand what we need in the brickclient and tests will help to find unused/messy code | 11:46 |
| e0ne | DuncanT: ok, added it to my backlog | 11:47 |
| DuncanT | e0ne: Thanks. Should just be a couple of lines, but it will make finding issues much easier once ti gets into the wild | 11:47 |
| e0ne | DuncanT: also, I didn' implement multipath yet | 11:47 |
| DuncanT | e0ne: Multipath is a giant pain in the ass | 11:48 |
| e0ne | :) | 11:48 |
| *** sgotliv has joined #openstack-cinder | 11:55 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-cinder | 12:01 | |
| *** markvoelker has joined #openstack-cinder | 12:01 | |
| *** aarefiev has quit IRC | 12:04 | |
| *** marcusvrn_ has joined #openstack-cinder | 12:06 | |
| *** brad[] has joined #openstack-cinder | 12:09 | |
| *** aarefiev has joined #openstack-cinder | 12:12 | |
| *** diablo_rojo has joined #openstack-cinder | 12:13 | |
| *** jerrygb has quit IRC | 12:17 | |
| *** haomaiwang has quit IRC | 12:18 | |
| *** haomaiwang has joined #openstack-cinder | 12:19 | |
| *** ociuhandu has quit IRC | 12:24 | |
| e0ne | interesting.... https://bugs.launchpad.net/cinder/+bug/1475333 on gated, is reproduced only on hp cloud nodes:( | 12:25 |
| openstack | Launchpad bug 1475333 in Cinder "gate-tempest-dsvm-full-ceph fails with Insufficient free space for volume creation on host ubuntu@ceph#ceph (requested / avail): 1/0.0" [High,Confirmed] | 12:25 |
| e0ne | also I'm able to reproduce it on my local env | 12:25 |
| *** deepakcs has quit IRC | 12:25 | |
| *** dzamboni has joined #openstack-cinder | 12:27 | |
| *** alejandrito has joined #openstack-cinder | 12:27 | |
| *** cristicalin has joined #openstack-cinder | 12:28 | |
| *** raildo-afk is now known as raildo | 12:28 | |
| *** BharatK has quit IRC | 12:35 | |
| *** merooney has joined #openstack-cinder | 12:39 | |
| *** bluex-pl has quit IRC | 12:40 | |
| *** stevemar has joined #openstack-cinder | 12:41 | |
| *** wilson-1 has joined #openstack-cinder | 12:41 | |
| *** salv-orl_ has quit IRC | 12:42 | |
| *** edmondsw has joined #openstack-cinder | 12:42 | |
| *** wilson1 has quit IRC | 12:44 | |
| *** stevemar has quit IRC | 12:46 | |
| *** stevemar has joined #openstack-cinder | 12:47 | |
| *** gouthamr has joined #openstack-cinder | 12:48 | |
| *** BharatK has joined #openstack-cinder | 12:49 | |
| *** bluex-pl has joined #openstack-cinder | 12:51 | |
| *** bluex-pl has quit IRC | 12:51 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Fix capacity report error in Huawei driver https://review.openstack.org/226308 | 12:51 |
| *** bluex-pl has joined #openstack-cinder | 12:52 | |
| *** stevemar has quit IRC | 12:52 | |
| *** julim has joined #openstack-cinder | 12:52 | |
| *** bill_az has joined #openstack-cinder | 12:53 | |
| *** delattec has joined #openstack-cinder | 12:56 | |
| *** cdelatte has quit IRC | 12:58 | |
| *** jaypipes has joined #openstack-cinder | 12:58 | |
| *** akerr has joined #openstack-cinder | 12:58 | |
| *** haomaiwang has quit IRC | 13:01 | |
| *** haomaiwang has joined #openstack-cinder | 13:01 | |
| *** martyturner has joined #openstack-cinder | 13:13 | |
| *** Yogi1 has joined #openstack-cinder | 13:14 | |
| *** Zhongjun has joined #openstack-cinder | 13:18 | |
| *** dustins has joined #openstack-cinder | 13:18 | |
| *** jgregor has joined #openstack-cinder | 13:20 | |
| *** mriedem has joined #openstack-cinder | 13:23 | |
| *** timcl has quit IRC | 13:24 | |
| *** sgotliv has quit IRC | 13:28 | |
| *** diogogmt has joined #openstack-cinder | 13:30 | |
| *** lprice has joined #openstack-cinder | 13:38 | |
| *** lpetrut has quit IRC | 13:39 | |
| *** lpetrut has joined #openstack-cinder | 13:39 | |
| *** xyang1 has joined #openstack-cinder | 13:41 | |
| *** lprice1 has quit IRC | 13:42 | |
| flip214 | jgriffith: thanks for the quick review, and "Hi, my name is Philipp, and I'm a programmer." ;/ | 13:42 |
| jgriffith | LMAO | 13:42 |
| *** timcl has joined #openstack-cinder | 13:42 | |
| *** cristicalin has quit IRC | 13:54 | |
| *** stevemar has joined #openstack-cinder | 13:54 | |
| *** ollie1 has joined #openstack-cinder | 13:57 | |
| *** links has quit IRC | 13:57 | |
| *** stevemar has quit IRC | 13:59 | |
| *** Yogi1 has left #openstack-cinder | 13:59 | |
| *** aix has joined #openstack-cinder | 14:00 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** thangp has joined #openstack-cinder | 14:01 | |
| *** haomaiwang has joined #openstack-cinder | 14:01 | |
| *** eharney has joined #openstack-cinder | 14:03 | |
| *** ntpttr has joined #openstack-cinder | 14:04 | |
| *** EinstCrazy has joined #openstack-cinder | 14:05 | |
| *** willsama has joined #openstack-cinder | 14:07 | |
| *** diogogmt has quit IRC | 14:07 | |
| *** Yogi1 has joined #openstack-cinder | 14:09 | |
| *** dims has quit IRC | 14:10 | |
| *** david-lyle has quit IRC | 14:11 | |
| *** stevemar has joined #openstack-cinder | 14:11 | |
| *** david-lyle has joined #openstack-cinder | 14:13 | |
| *** flip214 has quit IRC | 14:15 | |
| *** erhudy has joined #openstack-cinder | 14:20 | |
| *** baumann has joined #openstack-cinder | 14:20 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder: Cleanup orphaned code from cinder/utils.py https://review.openstack.org/229907 | 14:21 |
| *** EinstCrazy has quit IRC | 14:24 | |
| *** mtanino has joined #openstack-cinder | 14:27 | |
| e0ne | smcginnis: +0, -199 - not bad | 14:27 |
| e0ne | jgriffith, smcginnis: what do you think about adding (non-)voting coverage job? | 14:28 |
| jgriffith | e0ne: You mean test coverage? | 14:28 |
| jgriffith | brb | 14:28 |
| *** jungleboyj has joined #openstack-cinder | 14:29 | |
| smcginnis | e0ne: I like when we can actually remove code. :) | 14:29 |
| smcginnis | e0ne: Coverage would be interesting. | 14:29 |
| smcginnis | e0ne: I was looking at those reports more lately. | 14:29 |
| smcginnis | e0ne: There are some areas with very low coverage. | 14:29 |
| smcginnis | e0ne: It might be nice if we can notice when that gets worse by new patches. | 14:30 |
| *** timcl has quit IRC | 14:31 | |
| ntpttr | Hey all, if any cores have a moment would you mind giving me feedback on this patch I've been working on https://review.openstack.org/#/c/228646/? I'm still pretty fresh to contributing to Cinder, any feedback on what I can improve on would be appreciated. Thank you! | 14:35 |
| *** timcl has joined #openstack-cinder | 14:37 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder: Cleanup orphaned code from cinder/utils.py https://review.openstack.org/229907 | 14:39 |
| smcginnis | There, now +0/-250. Even better. | 14:39 |
| eharney | smcginnis: -1 DELETE MORE!! :) | 14:40 |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 14:40 |
| *** stevemar has quit IRC | 14:41 | |
| smcginnis | eharney: rm -fr cinder/* | 14:42 |
| smcginnis | ;) | 14:42 |
| *** stevemar has joined #openstack-cinder | 14:42 | |
| e0ne | jgriffith: yes, unit tests coverage | 14:42 |
| *** edtubill has joined #openstack-cinder | 14:43 | |
| eharney | e0ne: can it be a file left in the logs of the regular unit test job rather than running a separate unit test job just to get that report? | 14:43 |
| eharney | because i think that just means we'd run the unit test suite twice | 14:44 |
| zigo | I don't have a [lvm] section in the defauld cinder.conf generated in my package. | 14:44 |
| zigo | So I gess something went wrong, right? | 14:44 |
| e0ne | eharney: good idea. you're absolutely right | 14:44 |
| *** kevincarr1991 has joined #openstack-cinder | 14:45 | |
| e0ne | zigo: it's not required section | 14:46 |
| eharney | zigo: i don't think so... | 14:46 |
| *** stevemar has quit IRC | 14:46 | |
| *** stevemar has joined #openstack-cinder | 14:46 | |
| *** markstur has joined #openstack-cinder | 14:46 | |
| zigo | e0ne: But what if *I DO* want to use the [lvm] backend ? | 14:47 |
| zigo | How am I supposed to guess the options? :/ | 14:47 |
| *** dsariel_ has quit IRC | 14:47 | |
| eharney | the extra sections are for when you are using multi-backend w/ the enabled_backed options... they aren't for configuring certain drivers | 14:48 |
| eharney | enabled_backend* | 14:48 |
| e0ne | zigo: it depends on your enabled_backends option | 14:48 |
| smcginnis | zigo: This has some details: http://docs.openstack.org/kilo/config-reference/content/lvm-volume-driver.html | 14:48 |
| e0ne | zigo: e.g. enabled_backends = [some-driver] | 14:48 |
| e0ne | zigo: and then [som-driver] section will configure lvm backend | 14:48 |
| zigo | e0ne: Well, that too is missing from the generated config !!! | 14:48 |
| *** stevemar_ has joined #openstack-cinder | 14:49 | |
| *** geektoor_ has joined #openstack-cinder | 14:50 | |
| e0ne | smcginnis: you're winner. I've got only +3, -32 in my patch https://review.openstack.org/#/c/221323/ | 14:50 |
| smcginnis | e0ne: Hah! :) | 14:50 |
| openstackgerrit | xing-yang proposed openstack/cinder: VMAX Target iSCSI IP Address https://review.openstack.org/229712 | 14:51 |
| *** stevemar has quit IRC | 14:51 | |
| *** markstur has left #openstack-cinder | 14:52 | |
| *** ronis has quit IRC | 14:53 | |
| *** ronis has joined #openstack-cinder | 14:53 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Add backup_swift_auth_url to swift backup driver https://review.openstack.org/228646 | 14:53 |
| *** geektoor has quit IRC | 14:53 | |
| *** stevemar has joined #openstack-cinder | 14:55 | |
| *** kevincar_ has joined #openstack-cinder | 14:55 | |
| e0ne | btw, do we still support xml api? | 14:55 |
| e0ne | I didn't ever use it | 14:55 |
| zigo | e0ne: enabled_backends is supposed to be in what section? | 14:55 |
| e0ne | zigo: default | 14:55 |
| smcginnis | e0ne: Me neither, but if I remember right someone was. | 14:56 |
| zigo | Right... | 14:56 |
| smcginnis | Or we thought so. | 14:56 |
| e0ne | smcginnis: we've got a lot of xml related code... does it work? is it used by someone? is it tested? | 14:57 |
| smcginnis | e0ne: Very good questions. | 14:57 |
| *** takedakn has joined #openstack-cinder | 14:57 | |
| eharney | e0ne: surely it's gated? | 14:57 |
| smcginnis | Anyone know of anyone using it? | 14:57 |
| *** stevemar_ has quit IRC | 14:58 | |
| smcginnis | zigo: Here's a basic config. You could update this to use LVM instead. http://oslogs.compellent.com/dell-sc-iscsi-218645-8/logs/local.conf.txt.gz | 14:58 |
| *** diogogmt has joined #openstack-cinder | 14:58 | |
| *** tsekiyama has joined #openstack-cinder | 14:58 | |
| *** kevincarr1991 has quit IRC | 14:58 | |
| smcginnis | zigo: Oh, sorry. I should point out that's the local.conf for devstack. Actual resulting cinder.conf is different. | 14:59 |
| zigo | smcginnis: That's nice of you, I was able to create a working config "by hand", though what I want to do here is having a correct *full* generated config file in the Debian package for Liberty. | 14:59 |
| smcginnis | zigo: http://oslogs.compellent.com/dell-sc-iscsi-218645-8/logs/etc/cinder/cinder.conf.gz | 14:59 |
| *** haomaiwang has quit IRC | 14:59 | |
| zigo | So, I would like the generator to work properly rather than hacking around ... :/ | 14:59 |
| e0ne | eharney: afaik, tempest doesn't test it | 14:59 |
| *** jaypipes has quit IRC | 14:59 | |
| smcginnis | zigo: What generator are you talking about? | 15:00 |
| eharney | zigo: the default config shouldn't have a section for LVM or multi-backend drivers (enabled_backends)... all the options go in [DEFAULT] | 15:00 |
| *** haomaiwang has joined #openstack-cinder | 15:00 | |
| zigo | smcginnis: I'm talking about ./tools/config/generate_sample.sh | 15:00 |
| zigo | It's obviously wrong. | 15:00 |
| zigo | And since the gate isn't testing it ... | 15:00 |
| *** sayali has quit IRC | 15:00 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** ronis has quit IRC | 15:01 | |
| smcginnis | zigo: That generates the sample config file with all of the options. It's a reference. That is not going to automagically give you a working config for your given environment. | 15:01 |
| *** haomaiwa_ has joined #openstack-cinder | 15:01 | |
| *** EinstCrazy has joined #openstack-cinder | 15:01 | |
| zigo | smcginnis: Yeah, and it's not working properly. | 15:02 |
| smcginnis | * Some assembly required. | 15:02 |
| *** sayali has joined #openstack-cinder | 15:02 | |
| zigo | smcginnis: I'm well aware that it wont do a "working by default" config, but I do expect it to add the enabled_backends directive in [defaults] and the [lvm] section. | 15:02 |
| zigo | And it's not doing this for me in the Debian package. | 15:02 |
| e0ne | [openstack-dev] [all] removing XML testing completely from Tempest - 11/24/14 | 15:03 |
| e0ne | nova and keystone dropped xml api | 15:03 |
| e0ne | I'm afraid that operators will hate me is I'll ask about removing XML API from cinder | 15:03 |
| SamYaple | e0ne: do it | 15:04 |
| *** takedakn has quit IRC | 15:04 | |
| SamYaple | im an operator btw :) | 15:04 |
| smcginnis | e0ne: Hey, after taking away v1 API, this won't be so bad. ;) | 15:04 |
| *** diogogmt_ has joined #openstack-cinder | 15:04 | |
| *** diogogmt has quit IRC | 15:04 | |
| *** diogogmt_ is now known as diogogmt | 15:04 | |
| e0ne | smcginnis: lol | 15:04 |
| *** haomaiwa_ has quit IRC | 15:04 | |
| *** wolsen has joined #openstack-cinder | 15:05 | |
| e0ne | smcginnis: one less or one more patch with -2. challenge accepted! https://blueprints.launchpad.net/cinder/+spec/remove-xml-api | 15:07 |
| guitarzan | we'll have that much much less than removiong v1 | 15:08 |
| openstackgerrit | Eric Harney proposed openstack/cinder: Move ssh_utils tests to test_ssh_utils https://review.openstack.org/229947 | 15:08 |
| guitarzan | s/have/hate/ | 15:08 |
| smcginnis | e0ne: ;) | 15:08 |
| e0ne | guitarzan: :) | 15:09 |
| zigo | e0ne: Ivan, could you help me figuring out what's wrong in ./tools/config/generate_sample.sh ? | 15:09 |
| smcginnis | e0ne: This probably warrants a ML post. | 15:09 |
| zigo | I really need to get it strait before the final release. | 15:09 |
| *** dave-mccowan has quit IRC | 15:09 | |
| e0ne | smcginnis: sure | 15:09 |
| smcginnis | e0ne: At least for visibility. Give someone a chance to step forward if they actually are depending on XML. | 15:09 |
| smcginnis | e0ne: But I'm for its removal. | 15:10 |
| e0ne | zigo: I'll try it on my env right now. but i've got 10 minutes before meeting | 15:10 |
| zigo | e0ne: Maybe you can provide me with a cinder/opts.py generated within devstack, so I can compare with what I get running the generator in Debian? | 15:10 |
| e0ne | smcginnis: at least, we will know: does it work or not? | 15:10 |
| zigo | e0ne: The all hands meeting? :) | 15:10 |
| e0ne | zigo: yep | 15:11 |
| e0ne | zigo: "cinder/opts.py generated within devstack" where is it located? | 15:11 |
| *** IlyaG has joined #openstack-cinder | 15:12 | |
| zigo | e0ne: Well, just run tools/config/generate_sample.sh in your cinder tree, and it should create ./cinder/opts.py | 15:12 |
| *** abehl has quit IRC | 15:15 | |
| hemna | mep | 15:16 |
| *** IlyaG has quit IRC | 15:16 | |
| *** jerrygb has joined #openstack-cinder | 15:19 | |
| *** jerrygb has quit IRC | 15:19 | |
| *** jerrygb has joined #openstack-cinder | 15:19 | |
| *** martyturner has quit IRC | 15:21 | |
| *** nkrinner has quit IRC | 15:21 | |
| *** jdurgin1 has joined #openstack-cinder | 15:22 | |
| e0ne | zigo: ERROR: tools/config/generate_sample.sh was not called from tox. | 15:22 |
| e0ne | zigo: trying 'tox -e genconfig' | 15:23 |
| *** dave-mccowan has joined #openstack-cinder | 15:23 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder: Remove run_tests.sh wrapper https://review.openstack.org/226487 | 15:24 |
| *** martyturner has joined #openstack-cinder | 15:25 | |
| *** geektoor_ has quit IRC | 15:26 | |
| e0ne | zigo: it didn't create opts.py | 15:27 |
| smcginnis | e0ne: It will create it, then delete it. | 15:28 |
| smcginnis | e0ne: I think you'll need to edit the script to keep it. | 15:29 |
| e0ne | smcginnis: thanks | 15:29 |
| *** jaypipes has joined #openstack-cinder | 15:30 | |
| *** dims has joined #openstack-cinder | 15:30 | |
| *** IlyaG has joined #openstack-cinder | 15:32 | |
| e0ne | zigo: http://paste.openstack.org/show/475088/ | 15:33 |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 15:34 |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Cleanup for cinder tests with CGSnapshot https://review.openstack.org/207866 | 15:34 |
| *** EinstCrazy has quit IRC | 15:36 | |
| *** daneyon has joined #openstack-cinder | 15:37 | |
| zigo | e0ne: Thanks | 15:37 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Add backup_swift_auth_url to swift backup driver https://review.openstack.org/228646 | 15:38 |
| *** daneyon__ has joined #openstack-cinder | 15:39 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Add backup_swift_auth_url to swift backup driver https://review.openstack.org/228646 | 15:39 |
| *** daneyon_ has quit IRC | 15:40 | |
| hemna | jgriffith, ping | 15:40 |
| *** daneyon has quit IRC | 15:41 | |
| *** merooney has quit IRC | 15:49 | |
| *** ociuhandu has joined #openstack-cinder | 15:52 | |
| *** e0ne has quit IRC | 15:53 | |
| *** kevincar_ has quit IRC | 15:54 | |
| *** vgridnev has quit IRC | 15:55 | |
| *** alejandrito has quit IRC | 15:58 | |
| *** ntpttr has left #openstack-cinder | 15:58 | |
| zigo | https://bugs.launchpad.net/cinder/+bug/1501820 | 16:00 |
| openstack | Launchpad bug 1501820 in Cinder "./tools/config/generate_sample.sh doesn't work properly" [Undecided,New] | 16:00 |
| *** daneyon has joined #openstack-cinder | 16:00 | |
| *** Yogi1 has quit IRC | 16:02 | |
| *** daneyon__ has quit IRC | 16:03 | |
| hemna | diablo_rojo, ^^ | 16:05 |
| *** alejandrito has joined #openstack-cinder | 16:05 | |
| *** martyturner has quit IRC | 16:06 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix volume throttling to Python 3 https://review.openstack.org/229991 | 16:06 |
| *** thingee has joined #openstack-cinder | 16:08 | |
| *** markus_z has quit IRC | 16:09 | |
| *** mudassirlatif has joined #openstack-cinder | 16:10 | |
| *** r-daneel has joined #openstack-cinder | 16:13 | |
| *** apoorvad has joined #openstack-cinder | 16:13 | |
| *** apoorvad has quit IRC | 16:14 | |
| *** breitz has quit IRC | 16:14 | |
| *** breitz has joined #openstack-cinder | 16:14 | |
| *** leeantho has joined #openstack-cinder | 16:15 | |
| *** _cjones_ has quit IRC | 16:16 | |
| *** merooney has joined #openstack-cinder | 16:17 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: emc vmac driver: use integer division for Python 3 https://review.openstack.org/229998 | 16:17 |
| *** jdurgin1 has quit IRC | 16:17 | |
| *** salv-orlando has joined #openstack-cinder | 16:17 | |
| *** jaypipes has quit IRC | 16:18 | |
| *** salv-orlando has quit IRC | 16:20 | |
| *** ronis has joined #openstack-cinder | 16:20 | |
| diablo_rojo | hemna: Thanks :) I just responded to it. | 16:21 |
| *** mriedem is now known as mriedem_lunch | 16:22 | |
| hemna | diablo_rojo, coolio, thanks for getting on top of that. if we get a fix in, we might be able to get that in L still | 16:22 |
| openstackgerrit | Eric Harney proposed openstack/cinder: Move ssh_utils tests to test_ssh_utils https://review.openstack.org/229947 | 16:23 |
| *** thingee has quit IRC | 16:23 | |
| *** stevemar_ has joined #openstack-cinder | 16:25 | |
| diablo_rojo | hemna: I think that problem got solved with my patch that was merged on the 25th. https://review.openstack.org/#/c/225974/ | 16:27 |
| *** stevemar has quit IRC | 16:27 | |
| *** bluex-pl has quit IRC | 16:27 | |
| *** garthb has joined #openstack-cinder | 16:28 | |
| *** jistr has quit IRC | 16:29 | |
| *** mriedem_lunch is now known as mriedem | 16:30 | |
| *** ameade has quit IRC | 16:31 | |
| *** IlyaG has quit IRC | 16:32 | |
| *** _cjones_ has joined #openstack-cinder | 16:32 | |
| *** ameade has joined #openstack-cinder | 16:33 | |
| *** ndipanov has quit IRC | 16:34 | |
| *** erhudy has quit IRC | 16:39 | |
| *** salv-orlando has joined #openstack-cinder | 16:39 | |
| *** salv-orlando has quit IRC | 16:39 | |
| *** martyturner has joined #openstack-cinder | 16:39 | |
| *** salv-orlando has joined #openstack-cinder | 16:40 | |
| *** amit213 has joined #openstack-cinder | 16:43 | |
| *** vgridnev has joined #openstack-cinder | 16:44 | |
| *** apoorvad has joined #openstack-cinder | 16:45 | |
| *** apoorvad has quit IRC | 16:45 | |
| *** apoorvad has joined #openstack-cinder | 16:45 | |
| *** garthb has quit IRC | 16:46 | |
| *** Yogi1 has joined #openstack-cinder | 16:47 | |
| *** erlon has joined #openstack-cinder | 16:53 | |
| *** e0ne has joined #openstack-cinder | 16:54 | |
| *** e0ne has quit IRC | 16:55 | |
| *** markvoelker has quit IRC | 16:55 | |
| *** markvoelker has joined #openstack-cinder | 16:56 | |
| *** jgregor has quit IRC | 16:58 | |
| zigo | I've just built Cinder 3 times. Twice I had unit test failures (2 different ones), the 3rd time it passed it all !!! | 17:01 |
| * zigo submit bugs | 17:01 | |
| *** IlyaG has joined #openstack-cinder | 17:02 | |
| *** mriedem has quit IRC | 17:02 | |
| *** dims_ has joined #openstack-cinder | 17:03 | |
| eharney | zigo: were the unit test failures related to notifications? | 17:03 |
| *** jerrygb has quit IRC | 17:04 | |
| *** dims has quit IRC | 17:04 | |
| zigo | eharney: https://bugs.launchpad.net/cinder/+bug/1501839 | 17:06 |
| openstack | Launchpad bug 1501839 in Cinder "Unreliable unit tests with unpredictable results" [Undecided,New] | 17:06 |
| *** crose has joined #openstack-cinder | 17:06 | |
| eharney | zigo: is that on python 2.7 or 3? | 17:06 |
| zigo | eharney: Py 2.7 | 17:07 |
| eharney | zigo: it's probably related to https://bugs.launchpad.net/cinder/+bug/1501745 | 17:07 |
| openstack | Launchpad bug 1501745 in Cinder "gate-cinder-python34 failed" [Undecided,New] - Assigned to Eric Harney (eharney) | 17:07 |
| *** kevincarr1991 has joined #openstack-cinder | 17:07 | |
| *** mriedem has joined #openstack-cinder | 17:07 | |
| zigo | Nop, I'm not running Python 3 unit tests at all. | 17:07 |
| eharney | i have a suspicion about what code is breaking this | 17:07 |
| zigo | Good ! | 17:07 |
| eharney | good to know you hit it on py27 though, probably easier for me to hunt it there | 17:07 |
| zigo | But it's going to be hard to debug though, as I don't know how to reproduce. | 17:08 |
| zigo | Maybe some racy conditions are involved here? | 17:08 |
| eharney | we worked through a bug that presented exactly like this a while ago | 17:08 |
| zigo | Oh... | 17:08 |
| eharney | it was due to improper sharing and a race in the fake_notifier, and affected volume tests testing notifications things | 17:08 |
| eharney | so running just test_volume w/ concurrency was the easiest way to hit it | 17:09 |
| * zigo goes to take care of kids | 17:09 | |
| eharney | but, i'm suspecting image/test_cache.py now since it's new-ish and does similar things, for anyone curious | 17:09 |
| *** leitan has joined #openstack-cinder | 17:11 | |
| *** tsekiyama has quit IRC | 17:11 | |
| leitan | Hi guys, im playing with EMC VNX integration , im wondering if any of the driver mode FC or ISCSI needs that the user on the storage to be administrator, cause on VNX it seems that you can configure limited roles | 17:13 |
| leitan | and it will be a pitty if i have to configure a full admin or full block admin on the driver, and not limit the permissions of that user to the cinder pool | 17:13 |
| leitan | if anyone already played with it, wille be great to have some notes | 17:13 |
| leitan | :) | 17:13 |
| smcginnis | xyang1: ^^ | 17:14 |
| xyang1 | smcginnis: hi | 17:14 |
| smcginnis | xyang1: Hey, wondering if you can answer leitan's question or point them in the right direction. | 17:14 |
| xyang1 | leitan: you don't need to be admin to provision volume | 17:15 |
| leitan | xyang1, so how can i lock a user to use just one pool on VNX | 17:16 |
| xyang1 | leitan: you want to prevent others from using the same pool? | 17:16 |
| *** kevincarr1991 has quit IRC | 17:17 | |
| leitan | xyang1, i dont want to put on the cinder.conf a user that can do everything on the storage | 17:17 |
| leitan | xyang1, so i want to create a user, that just can create and delete volumes into a specific pool, that is just for that user | 17:18 |
| *** stevemar_ has quit IRC | 17:18 | |
| leitan | and put that user on the cinder.conf , to use on the VNX FC type driver xyang1 | 17:18 |
| leitan | byw, thanks smcginnis to bring the right guy into the conversation | 17:18 |
| leitan | byw = btw | 17:19 |
| xyang1 | leitan: I don't know if you can do that, I'll have to check | 17:19 |
| leitan | xyang1, how about configuring a user that can operate only the cinder pool, but i dont have any problems if any other admin touches its pool/volume | 17:19 |
| leitan | xyang1, so it will be, userA (global admin) userB (just creates and delete from the cinder pool, only that) | 17:20 |
| xyang1 | leitan: I don't know the answer now, I have never tried that | 17:21 |
| *** lpetrut has quit IRC | 17:21 | |
| xyang1 | leitan: will have to ping you back | 17:21 |
| xyang1 | leitan: are you on IRC all the time or should I email you | 17:22 |
| leitan | xyang1, email me please leandro@nubeliu.com, im on the irc but maybe not when you try to reach me :) | 17:23 |
| xyang1 | leitan: the VNX guys are all on vacation for a week, so expect delays:) | 17:23 |
| leitan | xyang1, thanks! that will be great, thanks for the support | 17:24 |
| xyang1 | leitan: no problem | 17:24 |
| openstackgerrit | oliver-leahy-l proposed openstack/cinder: encryption_api_url requires a version https://review.openstack.org/230031 | 17:25 |
| *** kevincarr1991 has joined #openstack-cinder | 17:27 | |
| *** kevincarr1991 has quit IRC | 17:33 | |
| *** alejandrito has quit IRC | 17:36 | |
| *** ociuhandu has quit IRC | 17:36 | |
| *** wilson1 has joined #openstack-cinder | 17:37 | |
| *** alejandrito has joined #openstack-cinder | 17:38 | |
| *** jgregor has joined #openstack-cinder | 17:39 | |
| *** wilson-1 has quit IRC | 17:40 | |
| *** porrua has quit IRC | 17:41 | |
| *** angela-s has joined #openstack-cinder | 17:45 | |
| *** alejandrito has quit IRC | 17:46 | |
| *** garthb has joined #openstack-cinder | 17:47 | |
| *** alejandrito has joined #openstack-cinder | 17:47 | |
| *** jordanP has quit IRC | 17:52 | |
| *** lcurtis has joined #openstack-cinder | 17:54 | |
| *** Zhongjun has quit IRC | 17:57 | |
| *** ociuhandu has joined #openstack-cinder | 17:58 | |
| *** baumann1 has joined #openstack-cinder | 18:02 | |
| anish | mtanino: what's next on the to-do list :) | 18:04 |
| *** baumann has quit IRC | 18:04 | |
| *** cdelatte has joined #openstack-cinder | 18:06 | |
| openstackgerrit | Angela Smith proposed openstack/cinder: Adds VF support with HTTPS southbound connector https://review.openstack.org/184799 | 18:06 |
| *** delattec has quit IRC | 18:08 | |
| *** BharatK has quit IRC | 18:09 | |
| *** tsekiyama has joined #openstack-cinder | 18:10 | |
| mtanino | anish: no todo right now :) | 18:10 |
| *** kevincarr1991 has joined #openstack-cinder | 18:12 | |
| *** asselin__ has joined #openstack-cinder | 18:13 | |
| *** asselin_ has quit IRC | 18:17 | |
| anish | mtanino: how bout relative base path for config files | 18:18 |
| cdelatte | ls | 18:19 |
| mtanino | anish: bug No.? | 18:19 |
| anish | isn't one | 18:21 |
| anish | I'm wondering if it's worth it since it doesn't seem to have impacted anyone | 18:21 |
| *** delattec has joined #openstack-cinder | 18:22 | |
| *** cdelatte has quit IRC | 18:24 | |
| patrickeast | maybe i'm late to the party, but can someone explain whats going on with https://github.com/openstack/nova/blob/b5e56eef935c7e4eeefe62ca4726f581ea7a9ca9/nova/compute/api.py#L1854-L1858 ?? playing around with a kilo change i'm seeing errors with the TestShelveInstance | 18:25 |
| patrickeast | is my driver supposed to be able to handle terminating a connection with iqn.fake and 127.0.0.1 ?! | 18:26 |
| *** aix has quit IRC | 18:26 | |
| *** tsekiyama has quit IRC | 18:28 | |
| *** cdelatte has joined #openstack-cinder | 18:30 | |
| *** openstackgerrit has quit IRC | 18:31 | |
| *** delattec has quit IRC | 18:32 | |
| *** openstackgerrit has joined #openstack-cinder | 18:32 | |
| *** timcl has quit IRC | 18:33 | |
| openstackgerrit | Abhishek Shrivastava proposed openstack/cinder: Setup error check & minor bug fix in CloudByte https://review.openstack.org/230068 | 18:33 |
| *** dave-mccowan has quit IRC | 18:35 | |
| openstackgerrit | xing-yang proposed openstack/cinder: WIP: Replication CG Integration Phase 1 https://review.openstack.org/229727 | 18:39 |
| *** dzamboni has quit IRC | 18:42 | |
| Swanson | jgriffith: If I'm looking to implement replication where is a good place to start looking? | 18:43 |
| *** tsekiyama has joined #openstack-cinder | 18:45 | |
| *** julim has quit IRC | 18:48 | |
| *** Strony has joined #openstack-cinder | 18:48 | |
| *** Strony has quit IRC | 18:49 | |
| *** strony-zhang has joined #openstack-cinder | 18:49 | |
| *** delattec has joined #openstack-cinder | 18:51 | |
| *** delatte has joined #openstack-cinder | 18:51 | |
| *** dave-mccowan has joined #openstack-cinder | 18:51 | |
| bswartz | smcginnis: ping | 18:52 |
| smcginnis | bswartz: Hey! | 18:52 |
| *** cdelatte has quit IRC | 18:53 | |
| patrickeast | Swanson: i would recommend taking a look through the implementation https://github.com/openstack/cinder/commit/fe538dc63de2c9bab21416a4b6c920049442b4e9 and there are a couple of driver implementations to use as reference too https://review.openstack.org/#/c/218526/ https://review.openstack.org/#/c/214825/, but speaking at least for the Pure one be aware that | 18:53 |
| patrickeast | lots of it is going to change still as there are lots of unknowns still for some of the details | 18:53 |
| patrickeast | Swanson: keep an eye out for the stuff xyang1 just posted too https://review.openstack.org/#/c/229727/ since you guys do CG's iirc | 18:54 |
| *** cdelatte has joined #openstack-cinder | 18:55 | |
| jgriffith | Swanson: yeah... what patrickeast said :) | 18:55 |
| *** delattec has quit IRC | 18:56 | |
| jgriffith | Swanson: there's also a dev doc in tree as well | 18:56 |
| *** delatte has quit IRC | 18:56 | |
| hemna | jgriffith, do we have a cinderclient patch up yet that calls the replication apis ? | 18:56 |
| jgriffith | negative | 18:56 |
| Swanson | patrickeast: Thanks. Are things changing or are the details just being filled in? | 18:57 |
| hemna | ok coolio. just curious | 18:57 |
| hemna | we are finishing up our replication patch for our drivers | 18:57 |
| patrickeast | Swanson: ehh so for our driver some stuff is changing due to the way we want to handle some situations | 18:57 |
| *** vgridnev has quit IRC | 18:57 | |
| jgriffith | patrickeast: can I quote you on that :) | 18:58 |
| patrickeast | iirc there are some bugs/strange/undefined behaviors we ran into that we might try and change in the core feature too... mudassirlatif was working on it most recently for us and could probably give more details | 18:58 |
| patrickeast | jgriffith: lol | 18:58 |
| *** delattec has joined #openstack-cinder | 18:59 | |
| Swanson | patrickeast: I need to go through this and make sure I understand the cinder impl so I can sort out the best dell impl. Last I saw I had... concerns. | 19:00 |
| *** lcurtis has quit IRC | 19:00 | |
| patrickeast | Swanson: yea, unfortunately the other driver impls may not help much since we all seem to do it pretty differently, starting with the core impl is definitely a good place to start | 19:01 |
| openstackgerrit | Abhishek Shrivastava proposed openstack/cinder: Setup error check & minor bug fix in CloudByte https://review.openstack.org/230068 | 19:01 |
| *** cdelatte has quit IRC | 19:01 | |
| *** vgridnev has joined #openstack-cinder | 19:01 | |
| *** martyturner has quit IRC | 19:01 | |
| mudassirlatif | Swanson: Pure’s “proposed” implementation here: https://review.openstack.org/#/c/214825/ needs the following “bug fixes” in cinder replication replication: https://review.openstack.org/#/c/219900/ to work | 19:03 |
| Swanson | patrickeast: Replication means different things to different people. Or at least it has different scope for different people. A few different impls should help. | 19:03 |
| *** martyturner has joined #openstack-cinder | 19:03 | |
| *** stevemar has joined #openstack-cinder | 19:04 | |
| Swanson | mudassirlatif: Thanks! | 19:04 |
| *** ociuhandu has quit IRC | 19:09 | |
| *** merooney has quit IRC | 19:16 | |
| *** bill_az has quit IRC | 19:17 | |
| *** tsekiyama has quit IRC | 19:18 | |
| *** david-lyle has quit IRC | 19:18 | |
| *** jwcroppe has quit IRC | 19:18 | |
| *** merooney has joined #openstack-cinder | 19:23 | |
| *** merooney has quit IRC | 19:27 | |
| *** david-lyle has joined #openstack-cinder | 19:27 | |
| *** delatte has joined #openstack-cinder | 19:30 | |
| *** cdelatte has joined #openstack-cinder | 19:30 | |
| *** delattec has quit IRC | 19:33 | |
| *** julim has joined #openstack-cinder | 19:33 | |
| *** annasort has joined #openstack-cinder | 19:38 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Image cache tests: use fake_notifier https://review.openstack.org/230105 | 19:42 |
| *** jwcroppe has joined #openstack-cinder | 19:43 | |
| zigo | When reading the install-guide, it tells about setting up 2 endpoints for Cinder. One with type volume, and the other one with type volumev2. | 19:43 |
| zigo | Is this really mandatory? | 19:43 |
| zigo | Or can I just forget one of the 2? | 19:44 |
| *** crose has quit IRC | 19:44 | |
| eharney | zigo: you don't have to have an endpoint for the v1 API if all of your clients support v2 | 19:45 |
| zigo | eharney: Thanks! | 19:45 |
| zigo | I'll do only one then. | 19:45 |
| *** ronis has quit IRC | 19:45 | |
| eharney | do v2, v1 is missing a bunch of features | 19:45 |
| *** logan2 has quit IRC | 19:47 | |
| *** bill_az has joined #openstack-cinder | 19:48 | |
| *** ociuhandu has joined #openstack-cinder | 19:54 | |
| *** logan2 has joined #openstack-cinder | 19:55 | |
| *** lcurtis has joined #openstack-cinder | 19:56 | |
| patrickeast | hemna: ping, i've got an os-brick question for ya | 20:02 |
| *** ociuhandu has quit IRC | 20:04 | |
| *** kevincarr1991 has quit IRC | 20:04 | |
| jgriffith | thangp: eharney any more thoughts on this: https://bugs.launchpad.net/cinder/+bug/1501521 | 20:04 |
| openstack | Launchpad bug 1501521 in Cinder "Cinder object Snapshot has no attribute named: type get" [Undecided,New] | 20:04 |
| *** jungleboyj has quit IRC | 20:04 | |
| hemna | patrickeast, hey | 20:04 |
| jgriffith | eharney: thangp I don't see it on a full tox run locally, also noted it seems specific to the puppet jobs | 20:04 |
| eharney | jgriffith: well, it seems that it's pointing out calls that need to be updated | 20:05 |
| jgriffith | eharney: maybe... but where :) | 20:05 |
| thangp | jgriffith: hey | 20:05 |
| eharney | jgriffith: i was hoping to leave that as an exercise for the experts :) | 20:05 |
| jgriffith | eharney: LOL | 20:05 |
| patrickeast | hemna: hola, ok so i think i know the answer to this... but wanted to check, for the locks around the connector code https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L542 it won't provide exclusion between say n-cpu and c-vol if they are running on the same node | 20:05 |
| patrickeast | ala devstack all-in-one that the CI's use | 20:05 |
| patrickeast | right? | 20:05 |
| thangp | jgriffith: we had left the update as a todo | 20:05 |
| jgriffith | eharney: thangp I guess I need to run the puppet tests | 20:05 |
| eharney | jgriffith: i'm not sure why there would be a difference locally vs in the gate | 20:06 |
| jgriffith | thangp: well, I get where it's coming from; I'm trying to figure out who/where it's calle dfrom | 20:06 |
| *** setmason has joined #openstack-cinder | 20:06 | |
| eharney | but i haven't tried to do it locally myself | 20:06 |
| *** ociuhandu has joined #openstack-cinder | 20:06 | |
| thangp | jgriffith: I see it in the tempest logs | 20:06 |
| thangp | jgriffith: have you tried just running tempest against cinder? | 20:07 |
| jgriffith | thangp: sure, but note thos are all puppet jobs | 20:07 |
| jgriffith | thangp: yes | 20:07 |
| thangp | jgriffith: ah ok... | 20:07 |
| patrickeast | hemna: i ask because i'm seeing occasional issues when running the tempest tests in parallel and wanted to make sure that was like a known/intended thing vs me breaking something | 20:07 |
| jgriffith | thangp: I ran tox --volume and all | 20:07 |
| thangp | jgriffith: debug log level enabled? | 20:07 |
| jgriffith | debug always :) | 20:07 |
| thangp | :-/ | 20:07 |
| jgriffith | thangp: if you look at logstash you'll notice every project is puppet | 20:07 |
| hemna | patrickeast, I believe the locks should work now between n-cpu and c-vol | 20:07 |
| jgriffith | (for those hits at least) | 20:07 |
| jgriffith | thangp: http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiQ2luZGVyIG9iamVjdCBTbmFwc2hvdCBoYXMgbm8gYXR0cmlidXRlIG5hbWVkOiB0eXBlIGdldFwiIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiI2MDQ4MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxNDQzNjUwMzE3MzA5fQ== | 20:08 |
| jgriffith | hehe.. tha'ts an awesome URL | 20:08 |
| hemna | patrickeast, https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L59 | 20:08 |
| patrickeast | hemna: oooh | 20:08 |
| patrickeast | hemna: ok cool | 20:09 |
| patrickeast | hemna: does that end up putting them in the same lock directory though too? | 20:09 |
| hemna | so it should provide system wide exclusion for connect_volume calls | 20:09 |
| jgriffith | FWIW they're all centos too :) | 20:09 |
| hemna | hrmm | 20:09 |
| hemna | patrickeast, I guess that depends on lockutils | 20:09 |
| jgriffith | I'm kidding of course, I don't really think that has anything to do with it :) | 20:09 |
| patrickeast | hemna: probably configurable somewhere | 20:10 |
| hemna | patrickeast, https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/lockutils.py#L43 | 20:10 |
| hemna | patrickeast, looks like the default is an env setting OSLO_LOCK_PATH | 20:10 |
| patrickeast | hemna: i saw on kilo that they for sure aren't going to the same directories, wanted to make sure it wasn't something that needed fixin on master | 20:11 |
| hemna | kilo definitely has issues | 20:11 |
| patrickeast | yea | 20:11 |
| hemna | because kilo didn't use os-brick in nova | 20:11 |
| patrickeast | haha yea exactly | 20:11 |
| hemna | the locks in libvirt were prefixed with nova- I thinks | 20:11 |
| thangp | jgriffith: the only problem is the "type" attribute... it might be a quick fix if we can find where it is | 20:11 |
| openstackgerrit | Jacob Gregor proposed openstack/cinder: Cleanup/move code in Storwize Driver https://review.openstack.org/230117 | 20:11 |
| jgriffith | thangp: yeah, I'm trying to find it | 20:12 |
| thangp | jgriffith: the logs dont tell much on where | 20:12 |
| jgriffith | nope :( | 20:12 |
| patrickeast | hemna: yea, well and they end up (from devstack at least) in /opt/stack/data/cinder and /opt/stack/data/nova so even if they were the same prefix it wouldn't work :( | 20:12 |
| eharney | thangp: jgriffith: submit a test patch that blows up with a back trace in the service when it hits that path for the name "type"? | 20:12 |
| patrickeast | hemna: cool so it looks like the latest stuff should be fine then | 20:12 |
| hemna | patrickeast, hrmmm | 20:12 |
| * patrickeast wants to be able to run my ci with moar parallel | 20:12 | |
| jgriffith | eharney: sure, but the problem is I am somewhat convinced this only shows up in the puppet tests... | 20:13 |
| hemna | patrickeast, yah I'm seeing that in my cinder.conf | 20:13 |
| jgriffith | eharney: which makes it kinda tricky to submit an injection in the cinder code | 20:13 |
| hemna | patrickeast, can you override that setting with a custom local.conf entry ? | 20:13 |
| jgriffith | eharney: know what I mean? | 20:13 |
| eharney | jgriffith: i'm not sure i do | 20:13 |
| patrickeast | hemna: mm yea probably | 20:13 |
| eharney | jgriffith: ohh... gate-puppet-openstack... | 20:14 |
| thangp | jgriffith: a recent patch of mine has it - a test patch that blows up with a back trace in the service when it hits that path for the name "type"? | 20:14 |
| thangp | woops | 20:14 |
| thangp | http://logs.openstack.org/54/177054/96/check/gate-tempest-dsvm-full/1aa3f46/logs/screen-c-api.txt.gz | 20:14 |
| eharney | jgriffith: not sure i know what that test does exactly | 20:14 |
| thangp | /opt/stack/new/cinder/cinder/quota.py:810 | 20:14 |
| thangp | probably a red herring | 20:15 |
| *** tsekiyama has joined #openstack-cinder | 20:18 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder: Cleanup orphaned code from cinder root directory https://review.openstack.org/229907 | 20:20 |
| *** tsekiyama has quit IRC | 20:23 | |
| openstackgerrit | Angela Smith proposed openstack/cinder: Adds VF support with HTTPS southbound connector https://review.openstack.org/184799 | 20:25 |
| *** baumann1 has quit IRC | 20:25 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: DO NOT MERGE: Debugging bug #1501521 https://review.openstack.org/230126 | 20:27 |
| openstack | bug 1501521 in Cinder "Cinder object Snapshot has no attribute named: type get" [Undecided,New] https://launchpad.net/bugs/1501521 | 20:27 |
| thangp | jgriffith: eharney: ^^ | 20:28 |
| thangp | jgriffith: eharney: we'll see if that finds anything | 20:28 |
| openstackgerrit | Eric Harney proposed openstack/cinder: Tests: print fake_notifier queue upon mismatch https://review.openstack.org/230128 | 20:31 |
| *** akerr has quit IRC | 20:31 | |
| *** martyturner has quit IRC | 20:32 | |
| *** breitz has quit IRC | 20:41 | |
| *** markvoelker has quit IRC | 20:46 | |
| *** markvoelker has joined #openstack-cinder | 20:46 | |
| *** bill_az_ has joined #openstack-cinder | 20:46 | |
| *** tsekiyama has joined #openstack-cinder | 20:46 | |
| *** markvoelker has quit IRC | 20:47 | |
| *** markvoelker has joined #openstack-cinder | 20:47 | |
| *** delatte has quit IRC | 20:50 | |
| *** cdelatte has quit IRC | 20:50 | |
| *** eharney has quit IRC | 20:53 | |
| *** ekarlso has quit IRC | 20:55 | |
| *** ekarlso has joined #openstack-cinder | 20:58 | |
| *** tsekiyama has quit IRC | 20:58 | |
| *** asselin_ has joined #openstack-cinder | 21:02 | |
| *** mudassirlatif_ has joined #openstack-cinder | 21:04 | |
| *** asselin__ has quit IRC | 21:06 | |
| *** mudassirlatif has quit IRC | 21:07 | |
| *** mudassirlatif_ is now known as mudassirlatif | 21:07 | |
| *** asselin_ has quit IRC | 21:07 | |
| *** bill_az has quit IRC | 21:08 | |
| *** kevincarr1991 has joined #openstack-cinder | 21:11 | |
| openstackgerrit | oliver-leahy-l proposed openstack/cinder: encryption_api_url requires a version https://review.openstack.org/230031 | 21:11 |
| *** tsekiyama has joined #openstack-cinder | 21:14 | |
| *** dustins has quit IRC | 21:15 | |
| jgriffith | thangp: hmm... ok, that's for Volume though | 21:17 |
| jgriffith | interesting... | 21:17 |
| jgriffith | Oh.. hey, I reproduced it on a regular run | 21:19 |
| jgriffith | Ok | 21:19 |
| jgriffith | Let me dig in a bit | 21:19 |
| jgriffith | thangp: I think you were right about quotas | 21:19 |
| *** baumann has joined #openstack-cinder | 21:20 | |
| *** jgregor has quit IRC | 21:22 | |
| *** e0ne has joined #openstack-cinder | 21:23 | |
| thangp | jgriffith: cool | 21:23 |
| *** raildo is now known as raildo-afk | 21:25 | |
| *** thangp has quit IRC | 21:26 | |
| *** buster_604 has joined #openstack-cinder | 21:27 | |
| e0ne | hemna: hi. fyi, I moved attach staff out of the cinderclient https://github.com/e0ne/python-brickclient | 21:27 |
| e0ne | hemna: will work on rbd staff tomorrow | 21:27 |
| e0ne | hemna: atfter that, I'm going to work on docs and code cleanup | 21:28 |
| *** e0ne has quit IRC | 21:30 | |
| hemna | e0ne ok man, I'll take a look | 21:31 |
| *** buster_6_ has joined #openstack-cinder | 21:32 | |
| *** Lee1092 has quit IRC | 21:33 | |
| *** buster___ has joined #openstack-cinder | 21:33 | |
| *** e0ne has joined #openstack-cinder | 21:34 | |
| *** buster_604 has quit IRC | 21:35 | |
| *** buster_6_ has quit IRC | 21:37 | |
| *** boris-42 has joined #openstack-cinder | 21:38 | |
| *** buster___ has quit IRC | 21:39 | |
| *** baumann has quit IRC | 21:42 | |
| *** salv-orl_ has joined #openstack-cinder | 21:43 | |
| *** IlyaG has quit IRC | 21:43 | |
| *** mriedem has quit IRC | 21:43 | |
| *** david-lyle has quit IRC | 21:43 | |
| *** salv-orlando has quit IRC | 21:46 | |
| *** apoorvad has quit IRC | 21:47 | |
| *** Yogi1 has quit IRC | 21:49 | |
| *** daneyon_ has joined #openstack-cinder | 21:51 | |
| *** daneyon_ has quit IRC | 21:51 | |
| e0ne | I hope, orepators won't hate me: I tried to disable api v1 in the past and now, I propose to remove xml api | 21:52 |
| *** daneyon has quit IRC | 21:54 | |
| *** willsama has quit IRC | 21:56 | |
| *** david-lyle has joined #openstack-cinder | 21:56 | |
| *** e0ne has quit IRC | 22:04 | |
| *** bill_az has joined #openstack-cinder | 22:10 | |
| *** edtubill has quit IRC | 22:15 | |
| *** ociuhandu has quit IRC | 22:17 | |
| *** gouthamr has quit IRC | 22:18 | |
| *** apoorvad has joined #openstack-cinder | 22:21 | |
| *** buster_604 has joined #openstack-cinder | 22:22 | |
| *** lcurtis has quit IRC | 22:25 | |
| *** buster_604 has quit IRC | 22:28 | |
| *** buster_604 has joined #openstack-cinder | 22:28 | |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: cinder-api-microversions code https://review.openstack.org/224910 | 22:28 |
| *** gouthamr has joined #openstack-cinder | 22:32 | |
| *** xyang1 has quit IRC | 22:33 | |
| *** gouthamr_ has joined #openstack-cinder | 22:34 | |
| *** gouthamr has quit IRC | 22:37 | |
| *** IlyaG has joined #openstack-cinder | 22:45 | |
| kevincarr1991 | I have attached cinder to a nfs share. I am able to create volumes, but I cannot attach them to an instance | 22:49 |
| *** SergeyLukjanov has quit IRC | 22:51 | |
| *** mriedem has joined #openstack-cinder | 22:51 | |
| *** SergeyLukjanov has joined #openstack-cinder | 22:51 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Fix enable/disable_replication raise InvalidVolume https://review.openstack.org/230194 | 22:52 |
| *** dsariel_ has joined #openstack-cinder | 22:52 | |
| *** angela-s has quit IRC | 22:56 | |
| *** buster_6_ has joined #openstack-cinder | 22:58 | |
| *** kevincarr1991 has quit IRC | 23:00 | |
| tbarron | kevincarr1991: the next step is to look at n-cpu logs and figure out what is failing in the attach. | 23:01 |
| *** buster_604 has quit IRC | 23:01 | |
| *** stevemar has quit IRC | 23:02 | |
| *** alejandrito has quit IRC | 23:03 | |
| *** IanGovett has quit IRC | 23:05 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Ensure replication functions check driver status https://review.openstack.org/230199 | 23:06 |
| *** chlong has quit IRC | 23:07 | |
| *** akerr has joined #openstack-cinder | 23:07 | |
| *** mriedem has quit IRC | 23:10 | |
| *** mriedem has joined #openstack-cinder | 23:10 | |
| *** leitan has quit IRC | 23:11 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Fix enable/disable_replication raise InvalidVolume https://review.openstack.org/230194 | 23:12 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Ensure replication functions check driver status https://review.openstack.org/230199 | 23:13 |
| *** akerr_ has joined #openstack-cinder | 23:13 | |
| jgriffith | hemna: LOG.error(msg, resource=volume) ? | 23:14 |
| jgriffith | The exception actually isn't the most important part | 23:14 |
| jgriffith | I'm not even sure it works right :) I didn't implement that in oslo, but maybe somebody else did | 23:15 |
| hemna | did I derp that one? | 23:15 |
| hemna | doh | 23:15 |
| *** mriedem has quit IRC | 23:15 | |
| hemna | arg. lol. | 23:15 |
| hemna | yah derp'd it. thanks. | 23:15 |
| jgriffith | hemna: haha.. nahh, I think it's just a "newish" thing so it will take us a bit to get a standard | 23:15 |
| * hemna is a dumbass | 23:15 | |
| jgriffith | not even | 23:16 |
| *** akerr has quit IRC | 23:16 | |
| jgriffith | hemna: so your other patch is cool too... but I was just thinking, it's kinda stupid that we have to add those checks for every call to a driver no? | 23:16 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Fix enable/disable_replication raise InvalidVolume https://review.openstack.org/230194 | 23:17 |
| hemna | kinda yah | 23:17 |
| jgriffith | hemna: I've never understood why we have to do that as opposed to just failing the call | 23:17 |
| hemna | I actually wanted to talk to you about that check in general | 23:17 |
| * jgriffith runs | 23:17 | |
| hemna | heh | 23:17 |
| hemna | so it seems that we are doing those checks in places after we've done db fetches and such | 23:18 |
| hemna | kinda seems dumb to go through the work of pulling a volume object from the db if the driver isn't initialized and we are just going to puke anyway | 23:18 |
| jgriffith | Well, the worse part is we're doing them multiple times in the same call in some cases :) | 23:18 |
| hemna | granted it's not going to happen often | 23:18 |
| jgriffith | hemna: I was working on a decorator | 23:18 |
| jgriffith | hemna: but then thought.... "really... why do we even do this"? | 23:18 |
| jgriffith | hemna: the decorator would solve the issue you're talking about | 23:19 |
| *** akerr_ has quit IRC | 23:19 | |
| hemna | in the case of our drivers, we do some checks in do_setup, etc that raise if we know we can't talk to our backend. | 23:19 |
| jgriffith | maybe that's where you were going with it | 23:19 |
| hemna | yah I think that would for sure | 23:19 |
| jgriffith | hemna: right | 23:19 |
| hemna | also, some other calls put the volume into an error state | 23:19 |
| hemna | and I'm not sure that's really beneficial | 23:19 |
| jgriffith | hemna: but back to my other thought.... do we even need that check? | 23:19 |
| jgriffith | hemna: shouldn't we just raise and error on our own? | 23:20 |
| jgriffith | If we can't communicate with the backend I mean | 23:20 |
| hemna | I think there is one benefit though | 23:20 |
| jgriffith | hemna: yeah? | 23:20 |
| hemna | I believe the scheduler checks the status | 23:20 |
| hemna | at create time and doesn't even call us ? | 23:20 |
| jgriffith | hemna: but we've already made it past the scheduler in this case | 23:20 |
| hemna | not sure about that though | 23:20 |
| hemna | for create yah | 23:21 |
| jgriffith | hemna: it has to have stats info | 23:21 |
| hemna | yah maybe a slight rethink here is in order | 23:21 |
| hemna | like you mention | 23:21 |
| jgriffith | hemna: so if you weren't initialized it wouldn't have stats info and barf | 23:21 |
| hemna | right now when our driver pukes at do_setup | 23:21 |
| jgriffith | yeah... I'm cool with adding that it in your patch, just questioning our *habbit* | 23:21 |
| hemna | the log ends up with lots of driver is uninitialized dumps | 23:21 |
| hemna | for the periodic | 23:21 |
| jgriffith | exactly! | 23:22 |
| jgriffith | I'm looking at changing how that works FWIW | 23:22 |
| hemna | cool | 23:22 |
| hemna | :) | 23:22 |
| smcginnis | I found it amusing the first time I saw our CI passed over 50% of tests without the driver passing do_setup. | 23:22 |
| hemna | lol | 23:22 |
| jgriffith | LOL | 23:22 |
| jgriffith | It's magic! | 23:22 |
| smcginnis | It's so good it doesn't even really need the driver. | 23:23 |
| smcginnis | :) | 23:23 |
| tbarron | wow, just wow | 23:23 |
| hemna | I just think it's odd in things like delete_cgsnapshot, that we put the snapshot in error_deleting if the driver is uninitialized. | 23:23 |
| smcginnis | +1 | 23:24 |
| jgriffith | well... wait | 23:24 |
| jgriffith | you kinda have to | 23:24 |
| jgriffith | Unless that's morphed into something else... lemme look | 23:24 |
| hemna | it's odd, I'm not saying it's wrong, but seems odd because there may actually be nothing wrong with the snap | 23:25 |
| tbarron | yeah, what's the alternative? | 23:25 |
| *** mriedem has joined #openstack-cinder | 23:25 | |
| hemna | tbarron, do a try block JUST for the driver initialized | 23:25 |
| hemna | and not put the snap into error_deleting | 23:25 |
| tbarron | a new state - can't do nothin at all? | 23:25 |
| jgriffith | hemna: oh.. but if you can't get to the backend and delete it off the backend and still delete from Cinder you end up with split brain | 23:26 |
| hemna | I'm saying we don't touch the cinder db in that case | 23:26 |
| smcginnis | Or don't delete it from cinder. | 23:26 |
| hemna | leave it in it's existing state | 23:26 |
| jgriffith | hemna: my argument was that if the driver can't talk to the device that call should fail anyway | 23:26 |
| smcginnis | Sorry, come back later. | 23:26 |
| hemna | yup | 23:27 |
| jgriffith | Ohh... hrmm, I dunno know if I agree with that | 23:27 |
| tbarron | hemna: I like not touching the db, just don't know the end state | 23:27 |
| hemna | the call should fail | 23:27 |
| hemna | but not put the snap/object into error state | 23:27 |
| hemna | maybe I'm off basehere | 23:27 |
| *** sseverson has left #openstack-cinder | 23:27 | |
| jgriffith | If a user is trying to "do something" with a resource and it's not accessible IMO we should note that and make it an error | 23:27 |
| hemna | yah | 23:27 |
| hemna | but then the snap is in error state | 23:27 |
| hemna | which prevents them from trying again | 23:27 |
| jgriffith | hemna: we *used* to do things like that and users HATED us | 23:27 |
| hemna | until they manually reset-state | 23:27 |
| hemna | dang | 23:27 |
| jgriffith | hemna: they'd send a command and it would "do nothing" | 23:28 |
| jgriffith | they don't like that | 23:28 |
| hemna | sure | 23:28 |
| hemna | the api call should still fail no? | 23:28 |
| *** IlyaG has quit IRC | 23:28 | |
| hemna | giving them the feedback that it puked | 23:28 |
| jgriffith | No, it's across the RPC border | 23:28 |
| jgriffith | deletes don't block IIRC | 23:29 |
| tbarron | jgriffith: so when driver is unitialized, we can't tell that in api? | 23:29 |
| hemna | so, even if we raise DriverNotInitialized ? | 23:29 |
| tbarron | i like the idea of failing as high up the stack as possible. | 23:29 |
| tbarron | it was just not setting end-state to error that seemed wrong. | 23:30 |
| hemna | it should still fail, just not put the object into a failed state. | 23:30 |
| jgriffith | I'd just prefer the scheduler not send anything if the backend isn't initialized and be done with it | 23:30 |
| hemna | yup | 23:30 |
| *** markvoelker has quit IRC | 23:30 | |
| hemna | that'd be cool | 23:30 |
| tbarron | yes | 23:30 |
| jgriffith | in the case of things that bypass the scheduler (like delete) they should just fail | 23:30 |
| hemna | jgriffith, +1 | 23:30 |
| jgriffith | or as winston-d has suggested in the past, make everything go through scheduler and avoid the problem altogether | 23:30 |
| jgriffith | hemna: but you still have to put the resource into an error state IMO | 23:31 |
| tbarron | +1 | 23:31 |
| tbarron | fail high and fast, but fail | 23:31 |
| hemna | that's the part that I'm confused on | 23:31 |
| hemna | putting the resource into the failed state | 23:31 |
| hemna | when we know it's just the backend that puked | 23:31 |
| hemna | you are probably right though. | 23:31 |
| jgriffith | hah...well, the backend IS where the resource lives | 23:31 |
| tbarron | "just" the backend | 23:31 |
| hemna | sure | 23:32 |
| jgriffith | if it pukes.. then well you shouldn't try and mess around | 23:32 |
| hemna | the admin borks the cinder.conf during an update, and starts cinder | 23:32 |
| hemna | oopsie | 23:32 |
| tbarron | fail | 23:32 |
| hemna | maybe I'm overthinking it. | 23:32 |
| tbarron | no, it's good that you are pushing this. | 23:33 |
| hemna | the resolution is to simply reset-state and try again | 23:33 |
| jgriffith | Better than silently ignoring things, having resources piling up on the backend that you don't know about can't control and most of all... having something be wrong and not konwing | 23:33 |
| jgriffith | knowing | 23:33 |
| jgriffith | hemna: but you don't "know" that's the problem | 23:33 |
| hemna | I'm not suggesting we silently fail | 23:33 |
| hemna | true, who knows why the driver isn't initialized | 23:33 |
| hemna | maybe the array is D E D dead | 23:34 |
| jgriffith | in the case of delete, "user says delete" we wipe it from the output and the db status is changed. It no longer shows in volume-list or in quotas | 23:34 |
| jgriffith | BUT it's still on the backend | 23:34 |
| jgriffith | that no workie | 23:34 |
| jgriffith | bad bad bad | 23:34 |
| hemna | agreed, I'm not suggesting that | 23:34 |
| jgriffith | Oh... ok, sorry then I'm not following | 23:34 |
| tbarron | dinner - will come back and see what you guys figured out. | 23:35 |
| hemna | so, I was hoping that 1) we can still fail the call to delete the resource and have that inform the caller/user that it failed. | 23:36 |
| hemna | and 2) leave the resource in it's existing state | 23:36 |
| hemna | so they can simply try again | 23:36 |
| hemna | in the 1 case where the driver isn't initialized. | 23:36 |
| *** jwcroppe has quit IRC | 23:36 | |
| hemna | and/or simply not even make the call into the manager if the API knows it's down. | 23:37 |
| hemna | thus avoiding the manual reset-state, try again. | 23:37 |
| *** jwcroppe has joined #openstack-cinder | 23:37 | |
| jgriffith | hemna: sure, if you can figure out how to do that with a REST API and not block calls you'll be a hero :) | 23:37 |
| hemna | lol | 23:38 |
| jgriffith | hemna: we can do it on the API side but once you cast out from there you have some serious trade-offs/problems to worry about | 23:38 |
| jgriffith | and I'm not sure why setting the resource to an error-state is so bad still | 23:38 |
| jgriffith | I get your point in that example you gave | 23:39 |
| jgriffith | Just not sure | 23:39 |
| *** mdenny has quit IRC | 23:39 | |
| hemna | yah, I'm not sure to be honest either. | 23:39 |
| hemna | just thinking out loud really and seeing if the idea has any merit at all. | 23:39 |
| *** buster_6_ has quit IRC | 23:41 | |
| *** jwcroppe has quit IRC | 23:41 | |
| hemna | anyway, thanks for letting me bounce some stuff off you. | 23:43 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Ensure replication functions check driver status https://review.openstack.org/230199 | 23:44 |
| hemna | on that note, time for soccer practice.....l8s | 23:44 |
| *** hemna is now known as hemnafk | 23:44 | |
| *** setmason has quit IRC | 23:45 | |
| jgriffith | cya | 23:49 |
| *** dims has joined #openstack-cinder | 23:56 | |
| *** IlyaG has joined #openstack-cinder | 23:57 | |
| *** bnemec has joined #openstack-cinder | 23:57 | |
| *** dims has quit IRC | 23:58 | |
| *** dims_ has quit IRC | 23:58 | |
| *** dims has joined #openstack-cinder | 23:59 | |
| *** buster_604 has joined #openstack-cinder | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!