| *** rhagarty has joined #openstack-cinder | 00:03 | |
| *** sdague has quit IRC | 00:06 | |
| *** rhagarty_ has joined #openstack-cinder | 00:06 | |
| jgriffith | patrickeast: so the fat finger was "cctxt" vs "ctxt" sigh | 00:07 |
|---|---|---|
| *** rhagarty has quit IRC | 00:08 | |
| *** sgotliv has quit IRC | 00:11 | |
| *** sgotliv has joined #openstack-cinder | 00:11 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - get iscsi ip from port in existing MV https://review.openstack.org/245997 | 00:15 |
| *** baojg has quit IRC | 00:17 | |
| *** zhonghua has quit IRC | 00:21 | |
| *** huanan_M has quit IRC | 00:22 | |
| *** huanan_M has joined #openstack-cinder | 00:22 | |
| *** huyang has quit IRC | 00:22 | |
| jgriffith | Sweet!... finally got that mess working | 00:22 |
| *** huyang has joined #openstack-cinder | 00:22 | |
| *** zhonghua-lee has joined #openstack-cinder | 00:24 | |
| *** mdenny has quit IRC | 00:24 | |
| mc_nair | jgriffith: on to the next mess then? | 00:27 |
| *** garthb has quit IRC | 00:31 | |
| *** laughter_ has joined #openstack-cinder | 00:31 | |
| *** laughter_ has joined #openstack-cinder | 00:32 | |
| *** laughter_ has quit IRC | 00:32 | |
| *** ntpttr has quit IRC | 00:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/280857 | 00:36 |
| *** laughterwym has joined #openstack-cinder | 00:37 | |
| *** RA__ has joined #openstack-cinder | 00:38 | |
| patrickeast | jgriffith: are those api additions you mentioned earlier changing the like top level api's? i've got my setup to the point where i'm ready to start to failover stuff and haz questions about how the http requests are supposed to be formed | 00:44 |
| *** cknight has joined #openstack-cinder | 00:45 | |
| *** rcernin has quit IRC | 00:46 | |
| patrickeast | jgriffith: im going to take a break for a bit this evening, lemmie know if you have them working or newer code, I don't wanna spend time duplicating any triage/fixes you've already got ;) | 00:46 |
| *** cknight1 has joined #openstack-cinder | 00:48 | |
| *** cknight has quit IRC | 00:50 | |
| *** yangyapeng has joined #openstack-cinder | 00:51 | |
| *** arch-nemesis has quit IRC | 00:53 | |
| *** Suyash has quit IRC | 01:06 | |
| *** yangyapeng has quit IRC | 01:06 | |
| jgriffith | patrickeast: yeah, I just completely trashed my branch with a rebase | 01:07 |
| jgriffith | I give up | 01:07 |
| jgriffith | will fix it later tonight after I stop sobbing | 01:07 |
| jgriffith | or hell, let's see what happens | 01:08 |
| patrickeast | jgriffith: oh no, can you just go back with the reflog? | 01:08 |
| jgriffith | patrickeast: so, not sure how to fix | 01:09 |
| jgriffith | patrickeast: I accidentally did a "git pull" | 01:09 |
| jgriffith | the git commit --amend -a much later after finishing up my work | 01:09 |
| jgriffith | and kaboom | 01:09 |
| jgriffith | I don't know how to back it out without loosing my changes | 01:10 |
| patrickeast | Oh, so you ammended to the wrong commit? | 01:10 |
| jgriffith | yeah | 01:10 |
| patrickeast | Mm you can probably get then back out if you do a diff of the one you modified compared to the original | 01:12 |
| patrickeast | Save it and apply it as a patch XD | 01:12 |
| jgriffith | patrickeast: yeah, trying that now, but can't get friking git to ignore binary files in the diff GRRRR | 01:12 |
| jgriffith | could check google :) | 01:12 |
| patrickeast | Haha yea, a consultation with Dr Google might be helpful | 01:13 |
| *** annasort has joined #openstack-cinder | 01:14 | |
| *** alonma has joined #openstack-cinder | 01:16 | |
| *** EinstCrazy has joined #openstack-cinder | 01:17 | |
| *** mtanino has quit IRC | 01:18 | |
| *** rhagarty_ has quit IRC | 01:20 | |
| *** rhagarty has joined #openstack-cinder | 01:20 | |
| *** alonma has quit IRC | 01:21 | |
| *** alonma has joined #openstack-cinder | 01:23 | |
| *** Suyash has joined #openstack-cinder | 01:25 | |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Add replication v2.1 calls https://review.openstack.org/281597 | 01:25 |
| *** alonma has quit IRC | 01:27 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 https://review.openstack.org/275797 | 01:28 |
| *** bill_az has quit IRC | 01:28 | |
| *** Suyash has quit IRC | 01:29 | |
| jgriffith | Ok, well that got most of it back... I'll finish it up later. | 01:31 |
| jgriffith | pheww | 01:31 |
| *** yangyapeng has joined #openstack-cinder | 01:31 | |
| *** sheel has joined #openstack-cinder | 01:32 | |
| *** ebalduf has joined #openstack-cinder | 01:33 | |
| *** yangyapeng has quit IRC | 01:38 | |
| *** ebalduf has quit IRC | 01:38 | |
| *** yangyapeng has joined #openstack-cinder | 01:38 | |
| *** davechen has joined #openstack-cinder | 01:39 | |
| *** diogogmt has joined #openstack-cinder | 01:42 | |
| *** diogogmt has quit IRC | 01:42 | |
| *** diogogmt has joined #openstack-cinder | 01:44 | |
| *** baojg has joined #openstack-cinder | 01:45 | |
| *** leeantho has quit IRC | 01:45 | |
| *** esker has joined #openstack-cinder | 01:46 | |
| *** davechen1 has joined #openstack-cinder | 01:48 | |
| *** diogogmt has quit IRC | 01:49 | |
| *** davechen has quit IRC | 01:50 | |
| *** esker has quit IRC | 01:51 | |
| *** Lee1092 has joined #openstack-cinder | 01:56 | |
| *** rhagarty has quit IRC | 01:58 | |
| *** alonma has joined #openstack-cinder | 02:04 | |
| *** davechen has joined #openstack-cinder | 02:08 | |
| *** alonma has quit IRC | 02:08 | |
| *** davechen1 has quit IRC | 02:10 | |
| *** annasort has quit IRC | 02:11 | |
| *** haomaiwa_ has joined #openstack-cinder | 02:12 | |
| *** mylu has joined #openstack-cinder | 02:14 | |
| *** mriedem has left #openstack-cinder | 02:14 | |
| *** gouthamr has joined #openstack-cinder | 02:15 | |
| *** gouthamr_ has joined #openstack-cinder | 02:16 | |
| *** EinstCrazy has quit IRC | 02:17 | |
| *** EinstCrazy has joined #openstack-cinder | 02:18 | |
| *** gouthamr has quit IRC | 02:20 | |
| *** diogogmt has joined #openstack-cinder | 02:26 | |
| *** mudassirlatif has quit IRC | 02:29 | |
| *** houming has joined #openstack-cinder | 02:35 | |
| *** lixiaoy1 has joined #openstack-cinder | 02:38 | |
| lixiaoy1 | Hi, any cores help to review the patch to fix high importance bug of quota: https://review.openstack.org/#/c/267999/ which has got a +2 | 02:41 |
| *** baojg has quit IRC | 02:43 | |
| *** annasort has joined #openstack-cinder | 02:45 | |
| *** baojg has joined #openstack-cinder | 02:47 | |
| *** apoorvad has quit IRC | 02:54 | |
| *** esker has joined #openstack-cinder | 02:55 | |
| *** esker has quit IRC | 03:00 | |
| *** haomaiwa_ has quit IRC | 03:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 03:01 | |
| *** salv-orl_ has quit IRC | 03:04 | |
| *** IlyaG has joined #openstack-cinder | 03:14 | |
| *** IlyaG has quit IRC | 03:14 | |
| *** IlyaG has joined #openstack-cinder | 03:15 | |
| *** bardia has quit IRC | 03:16 | |
| *** mylu has quit IRC | 03:24 | |
| *** dims_ has quit IRC | 03:30 | |
| *** dims has joined #openstack-cinder | 03:32 | |
| *** john5223 has joined #openstack-cinder | 03:33 | |
| *** mylu has joined #openstack-cinder | 03:35 | |
| lixiaoy1 | DuncanT:dulek: Thank you to consider sheepdog things. To run gate-tempest-dsvm-full-sheepdog-nv test in jeckins, currently the problem is: devstack git clone the new os-brick patch, but it doesn't set LIBS_FROM_GIT=os-brick | 03:42 |
| *** baojg has quit IRC | 03:42 | |
| lixiaoy1 | DuncanT:deule: As a result, it still uses non-updated os-brick from pip install. The infra patch is https://review.openstack.org/#/c/281016/ | 03:43 |
| lixiaoy1 | DuncanT: dulek: after it is merged, we can test the sheepdog tempest case. | 03:44 |
| *** baojg has joined #openstack-cinder | 03:45 | |
| lixiaoy1 | DuncanT:dulek: above infra patch is to set up sheepdog to test with os-brick from source in experimental. | 03:46 |
| *** EinstCra_ has joined #openstack-cinder | 03:49 | |
| *** alonma has joined #openstack-cinder | 03:51 | |
| *** diablo_rojo has joined #openstack-cinder | 03:52 | |
| *** EinstCrazy has quit IRC | 03:52 | |
| *** baojg has quit IRC | 03:55 | |
| *** alonma has quit IRC | 03:56 | |
| *** alonma has joined #openstack-cinder | 03:59 | |
| *** haomaiwa_ has quit IRC | 04:01 | |
| *** EinstCrazy has joined #openstack-cinder | 04:01 | |
| *** haomaiwang has joined #openstack-cinder | 04:01 | |
| *** Poornima has joined #openstack-cinder | 04:02 | |
| *** EinstCra_ has quit IRC | 04:04 | |
| *** alonma has quit IRC | 04:05 | |
| *** alonma has joined #openstack-cinder | 04:08 | |
| *** diablo_rojo has quit IRC | 04:09 | |
| *** davechen1 has joined #openstack-cinder | 04:12 | |
| *** davechen has quit IRC | 04:14 | |
| *** alonma has quit IRC | 04:14 | |
| *** baojg has joined #openstack-cinder | 04:25 | |
| *** RA__ has quit IRC | 04:37 | |
| openstackgerrit | Patrick East proposed openstack/cinder: Allow for Pure drivers to verify HTTPS requests https://review.openstack.org/281625 | 04:45 |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Don't show chap password in log https://review.openstack.org/271595 | 04:45 |
| *** shyama has quit IRC | 04:48 | |
| *** shyama has joined #openstack-cinder | 04:48 | |
| *** smoriya_ has joined #openstack-cinder | 04:48 | |
| *** bill_az has joined #openstack-cinder | 04:49 | |
| *** xyang1 has joined #openstack-cinder | 04:50 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Don't fail when port group does not exist https://review.openstack.org/271599 | 04:52 |
| *** dims_ has joined #openstack-cinder | 04:53 | |
| *** dims has quit IRC | 04:55 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Match the ip more accurately in Huawei driver https://review.openstack.org/280481 | 04:57 |
| *** xyang1 has quit IRC | 04:58 | |
| *** dims_ has quit IRC | 05:00 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** esker has joined #openstack-cinder | 05:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 05:01 | |
| *** dims has joined #openstack-cinder | 05:02 | |
| *** dims has quit IRC | 05:02 | |
| *** alonma has joined #openstack-cinder | 05:03 | |
| *** esker has quit IRC | 05:05 | |
| *** ccesario has quit IRC | 05:05 | |
| *** alonma has quit IRC | 05:07 | |
| *** alonma has joined #openstack-cinder | 05:09 | |
| *** alonma has quit IRC | 05:14 | |
| *** laughter_ has joined #openstack-cinder | 05:14 | |
| *** NightKhaos has quit IRC | 05:15 | |
| *** NightKhaos has joined #openstack-cinder | 05:16 | |
| *** laughterwym has quit IRC | 05:18 | |
| *** ccesario has joined #openstack-cinder | 05:18 | |
| *** shyama has quit IRC | 05:19 | |
| *** shyama has joined #openstack-cinder | 05:20 | |
| *** esker has joined #openstack-cinder | 05:21 | |
| *** [1]Thelo has joined #openstack-cinder | 05:23 | |
| *** Thelo has quit IRC | 05:25 | |
| *** [1]Thelo is now known as Thelo | 05:25 | |
| *** ccesario has quit IRC | 05:26 | |
| *** esker has quit IRC | 05:26 | |
| *** dave-mccowan has quit IRC | 05:38 | |
| *** ccesario has joined #openstack-cinder | 05:39 | |
| *** bill_az has quit IRC | 05:40 | |
| *** liverpoo1er has quit IRC | 05:41 | |
| *** liverpooler has quit IRC | 05:42 | |
| *** mylu has quit IRC | 05:49 | |
| *** IlyaG has quit IRC | 05:51 | |
| *** laughter_ has quit IRC | 05:54 | |
| *** laughterwym has joined #openstack-cinder | 05:54 | |
| *** haomaiwa_ has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-cinder | 06:01 | |
| *** abhishekk has joined #openstack-cinder | 06:05 | |
| *** jidar has quit IRC | 06:06 | |
| *** jwcroppe_ has joined #openstack-cinder | 06:07 | |
| *** jidar has joined #openstack-cinder | 06:07 | |
| *** alonma has joined #openstack-cinder | 06:10 | |
| *** jwcroppe has quit IRC | 06:10 | |
| *** jwcroppe_ has quit IRC | 06:11 | |
| *** alonma has quit IRC | 06:15 | |
| *** jwcroppe has joined #openstack-cinder | 06:18 | |
| *** alonma has joined #openstack-cinder | 06:19 | |
| *** ChubYann has quit IRC | 06:19 | |
| *** alonma has quit IRC | 06:24 | |
| *** esker has joined #openstack-cinder | 06:24 | |
| *** alonma has joined #openstack-cinder | 06:27 | |
| *** esker has quit IRC | 06:28 | |
| *** alonma has quit IRC | 06:32 | |
| *** bkumar has joined #openstack-cinder | 06:39 | |
| *** alonma has joined #openstack-cinder | 06:39 | |
| openstackgerrit | liuke proposed openstack/cinder: Huawei: Judgement failure when creating hypermetro https://review.openstack.org/280641 | 06:41 |
| *** alonma has quit IRC | 06:45 | |
| *** alonma has joined #openstack-cinder | 06:46 | |
| *** baojg has quit IRC | 06:47 | |
| *** mvk has joined #openstack-cinder | 06:49 | |
| *** baojg has joined #openstack-cinder | 06:51 | |
| *** alonma has quit IRC | 06:51 | |
| *** alonma has joined #openstack-cinder | 06:52 | |
| openstackgerrit | liuke proposed openstack/cinder: Huawei: Judgement failure when creating hypermetro https://review.openstack.org/280641 | 06:56 |
| *** alonma has quit IRC | 06:56 | |
| *** sheel has quit IRC | 06:57 | |
| *** takedakn has joined #openstack-cinder | 06:57 | |
| *** nkrinner has joined #openstack-cinder | 06:58 | |
| *** lpetrut has joined #openstack-cinder | 06:59 | |
| *** alonma has joined #openstack-cinder | 07:00 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 07:01 | |
| *** jwcroppe has quit IRC | 07:02 | |
| *** alonma has quit IRC | 07:04 | |
| *** esker has joined #openstack-cinder | 07:06 | |
| *** liverpoo1er has joined #openstack-cinder | 07:06 | |
| *** liverpooler has joined #openstack-cinder | 07:06 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Fix message of quota exceed exception https://review.openstack.org/281666 | 07:06 |
| *** alonma has joined #openstack-cinder | 07:07 | |
| *** esker has quit IRC | 07:11 | |
| *** alonma has quit IRC | 07:11 | |
| *** alonma has joined #openstack-cinder | 07:13 | |
| openstackgerrit | liuke proposed openstack/cinder: Huawei: Create snapshot have a log error https://review.openstack.org/280622 | 07:13 |
| *** baojg has quit IRC | 07:13 | |
| *** baojg has joined #openstack-cinder | 07:16 | |
| *** alonma has quit IRC | 07:18 | |
| *** alonma has joined #openstack-cinder | 07:19 | |
| *** alonma has quit IRC | 07:23 | |
| *** alonma has joined #openstack-cinder | 07:25 | |
| *** esker has joined #openstack-cinder | 07:27 | |
| *** alonma has quit IRC | 07:30 | |
| *** esker has quit IRC | 07:31 | |
| *** alonma has joined #openstack-cinder | 07:31 | |
| *** alonma has quit IRC | 07:36 | |
| *** ponychou has joined #openstack-cinder | 07:36 | |
| openstackgerrit | Chaozhe Chen(ccz) proposed openstack/cinder: Test: use assert_has_calls() instead https://review.openstack.org/281677 | 07:37 |
| *** alonma has joined #openstack-cinder | 07:38 | |
| *** e0ne has joined #openstack-cinder | 07:41 | |
| *** alonma has quit IRC | 07:42 | |
| *** alonma has joined #openstack-cinder | 07:44 | |
| *** salv-orlando has joined #openstack-cinder | 07:44 | |
| *** davechen1 is now known as davechen | 07:46 | |
| *** alonma has quit IRC | 07:48 | |
| *** alonma has joined #openstack-cinder | 07:50 | |
| *** rcernin has joined #openstack-cinder | 07:51 | |
| lixiaoy1 | DuncanT:dulek: The infra patch is merged, and DON'T MERGE patch is running with the new jeckins. | 07:53 |
| *** yangyape_ has joined #openstack-cinder | 07:54 | |
| *** alonma has quit IRC | 07:54 | |
| *** EinstCra_ has joined #openstack-cinder | 07:55 | |
| *** alonma has joined #openstack-cinder | 07:55 | |
| *** yangyap__ has joined #openstack-cinder | 07:56 | |
| *** yangyapeng has quit IRC | 07:56 | |
| *** e0ne has quit IRC | 07:58 | |
| *** yangyape_ has quit IRC | 07:58 | |
| *** EinstCrazy has quit IRC | 07:59 | |
| *** ildikov has quit IRC | 08:00 | |
| *** takedakn has quit IRC | 08:00 | |
| *** haomaiwa_ has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-cinder | 08:01 | |
| DuncanT | lixiaoy1: Excellent stuff! | 08:02 |
| *** lpetrut has quit IRC | 08:02 | |
| *** bkumar has quit IRC | 08:05 | |
| lixiaoy1 | DuncanT: The test finishes successfully: http://logs.openstack.org/31/280731/1/experimental/gate-tempest-dsvm-full-sheepdog-src-os-brick-nv/829ed06// | 08:07 |
| *** esker has joined #openstack-cinder | 08:08 | |
| DuncanT | Great, expect two +2s within a few mintues | 08:08 |
| DuncanT | That's all I've been waiting for | 08:08 |
| lixiaoy1 | DuncanT: thank you! | 08:09 |
| *** sb has quit IRC | 08:10 | |
| *** strictlyb has joined #openstack-cinder | 08:10 | |
| *** lpetrut has joined #openstack-cinder | 08:10 | |
| *** takedakn has joined #openstack-cinder | 08:11 | |
| *** ildikov has joined #openstack-cinder | 08:12 | |
| *** esker has quit IRC | 08:13 | |
| *** takedakn has quit IRC | 08:15 | |
| *** lpetrut has quit IRC | 08:19 | |
| *** ygl has joined #openstack-cinder | 08:30 | |
| ygl | Hi All | 08:30 |
| ygl | i have an issue with creating volumes from images | 08:30 |
| ygl | can anyone help me please | 08:30 |
| ygl | is anyone here ? | 08:31 |
| DuncanT | ygl: what exactly is the problem? | 08:32 |
| *** abhishekk_ has joined #openstack-cinder | 08:32 | |
| ygl | its throwing the error saying this "ImageCopyFailure: Failed to copy image to volume: Image c72f1545-d3aa-4cbe-be0e-6ca765ee344e could not be found." | 08:32 |
| ygl | but i can see the image listed by glance and also in the database | 08:32 |
| lixiaoy1 | ygl: which version are you using? | 08:33 |
| ygl | actually i have changed the glance backend from swift to to /var/lib/glance/images | 08:33 |
| ygl | lixiaoy1: kilo | 08:34 |
| *** abhishekk has quit IRC | 08:34 | |
| ygl | its failing at this code "https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py" | 08:34 |
| *** belmoreira has joined #openstack-cinder | 08:34 | |
| ygl | DuncanT: def _copy_image_to_volume( | 08:34 |
| ygl | DuncanT: lixiaoy1 can u tell me how cinder downloads from the backend ? | 08:35 |
| DuncanT | ygl: It just calls the glance client to do it | 08:35 |
| ygl | DuncanT: lixiaoy1 i can also list the images through glance api calls | 08:36 |
| ygl | DuncanT: ok | 08:36 |
| DuncanT | Can you download it though? | 08:36 |
| DuncanT | It is possible to have things in the glance index but not the datastore | 08:36 |
| ygl | DuncanT: how to test it from command line ? | 08:36 |
| ygl | DuncanT: I mean how to download ? | 08:37 |
| *** abhishekk has joined #openstack-cinder | 08:37 | |
| DuncanT | Give me a minute, I'll see if I can find out | 08:37 |
| ygl | DuncanT: sure thanks | 08:37 |
| *** abhishekk has quit IRC | 08:37 | |
| *** abhishekk_ has quit IRC | 08:37 | |
| DuncanT | glance image-download > outfile | 08:38 |
| DuncanT | You'll need to put the image id in there too | 08:39 |
| *** jordanP has joined #openstack-cinder | 08:39 | |
| openstackgerrit | Chaozhe Chen(ccz) proposed openstack/cinder: Test: use assert_has_calls() instead https://review.openstack.org/281677 | 08:40 |
| *** alonma has quit IRC | 08:40 | |
| ygl | DuncanT: i have a three node cluster for glance services. | 08:42 |
| *** laughterwym has quit IRC | 08:42 | |
| DuncanT | ygl: Does the image-download work? If not, your glance setup is bust, and I don't know much about glance | 08:43 |
| *** laughterwym has joined #openstack-cinder | 08:43 | |
| *** lpetrut has joined #openstack-cinder | 08:43 | |
| ygl | DuncanT: it worked on one node. now trying on other nodes | 08:44 |
| ygl | DuncanT: this is the other error I got on pther node: 404 Not Found: Image /var/lib/glance/images/c72f1545-d3aa-4cbe-be0e-6ca765ee344e not found (HTTP 404) | 08:44 |
| DuncanT | Ok. You need to fix that, then cinder will probably work | 08:45 |
| ygl | DuncanT: But I see the image on this other node | 08:46 |
| ygl | DuncanT: its in /var/lib/glance/images | 08:46 |
| DuncanT | ygl: I know very little about how glance works, sorry | 08:46 |
| *** laughterwym has quit IRC | 08:47 | |
| ygl | DuncanT: ok Thanks | 08:47 |
| *** ygl has left #openstack-cinder | 08:48 | |
| lixiaoy1 | ygl: do you enable debug trace? | 08:48 |
| *** esker has joined #openstack-cinder | 08:50 | |
| *** tpatzig_ has quit IRC | 08:52 | |
| *** tpatzig has joined #openstack-cinder | 08:53 | |
| *** tpatzig has left #openstack-cinder | 08:53 | |
| *** esker has quit IRC | 08:54 | |
| openstackgerrit | Rui Chen proposed openstack/python-cinderclient: Fix Resource.__eq__ mismatch semantics of object equal https://review.openstack.org/251021 | 09:00 |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-cinder | 09:01 | |
| *** lpetrut has quit IRC | 09:02 | |
| *** houming has quit IRC | 09:07 | |
| *** esker has joined #openstack-cinder | 09:11 | |
| *** arecknag has joined #openstack-cinder | 09:14 | |
| *** esker has quit IRC | 09:15 | |
| *** ndipanov has joined #openstack-cinder | 09:18 | |
| *** EinstCrazy has joined #openstack-cinder | 09:19 | |
| *** yangyapeng has joined #openstack-cinder | 09:19 | |
| *** ildikov has quit IRC | 09:20 | |
| *** yangyap__ has quit IRC | 09:21 | |
| *** EinstCra_ has quit IRC | 09:21 | |
| *** ndipanov has quit IRC | 09:22 | |
| *** yangyape_ has joined #openstack-cinder | 09:22 | |
| *** yangyapeng has quit IRC | 09:25 | |
| *** ociuhandu has joined #openstack-cinder | 09:29 | |
| *** yuriy_n17 has joined #openstack-cinder | 09:30 | |
| *** e0ne has joined #openstack-cinder | 09:35 | |
| *** ildikov has joined #openstack-cinder | 09:36 | |
| *** ndipanov has joined #openstack-cinder | 09:41 | |
| *** yangyape_ has quit IRC | 09:45 | |
| lixiaoy1 | DuncanT: Please also help to review the patch about scaling backup: https://review.openstack.org/#/c/260903/ | 09:48 |
| *** houming has joined #openstack-cinder | 09:50 | |
| *** laughterwym has joined #openstack-cinder | 09:50 | |
| *** gouthamr_ has quit IRC | 09:51 | |
| *** laughterwym has quit IRC | 09:55 | |
| *** davechen has left #openstack-cinder | 09:55 | |
| DuncanT | lixiaoy1: Done. Not sure what the situation is with these patches and rolling upgrade of db, might get Dulek to explain it to me again. Hopefully I'll understand this time | 09:57 |
| *** mvk has quit IRC | 09:57 | |
| *** ankit_ag has joined #openstack-cinder | 09:58 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-cinder | 10:01 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** salv-orl_ has joined #openstack-cinder | 10:03 | |
| *** EinstCrazy has quit IRC | 10:03 | |
| *** openstackgerrit has joined #openstack-cinder | 10:03 | |
| dulek | DuncanT: Ah, there's no problems with DB part I think. | 10:04 |
| DuncanT | dulek: I know you've said that before. I can't remember / don't understand how adding new columns works safely though | 10:04 |
| DuncanT | dulek: When does the migrate get run? Before updating the code? | 10:05 |
| dulek | DuncanT: Before. | 10:05 |
| dulek | DuncanT: https://dev.mysql.com/doc/refman/5.7/en/innodb-create-index-overview.html#innodb-online-ddl-summary-grid | 10:05 |
| dulek | DuncanT: This is what dansmith and other Nova guys use to judge if something will block the DB or not. | 10:05 |
| *** salv-orlando has quit IRC | 10:06 | |
| dulek | DuncanT: Notice "Allows Concurrent DML" - this is probably most important column. | 10:06 |
| *** mvk has joined #openstack-cinder | 10:06 | |
| DuncanT | Ok, so there'll potentially be some db records without that field filled in with anything. I guess we just check the code handles that case ok? | 10:06 |
| dulek | DuncanT: If we have "No" there, this means that during the migration table will be locked, so some requests during the migration may fail in a strange way. | 10:07 |
| dulek | DuncanT: Let me double check, but I think I've looked into it from this perspective. | 10:07 |
| DuncanT | Thanks | 10:07 |
| DuncanT | I'm slowly getting my head around it :-) | 10:07 |
| dulek | DuncanT: http://www.danplanet.com/blog/2015/10/07/upgrades-in-nova-database-migrations/ | 10:08 |
| dulek | DuncanT: "Additive Schema-only Migrations" is the section explaining this a little. | 10:08 |
| *** lpetrut has joined #openstack-cinder | 10:10 | |
| *** lpetrut has quit IRC | 10:10 | |
| dulek | DuncanT: Okay, so 064 migration (064_add_restore_volume_id_to_backups.py) is only adding a column with NULL in there by default. Which is fine, as scalable backups code will just assume that nothing is restoring that backup. | 10:10 |
| dulek | DuncanT: And if backup service will be shut down gracefully to be upgraded we're 100% sure that no restore was in progress before the upgrade. | 10:11 |
| DuncanT | The API will still be running, so things will still go into status restoring... but that field is set in the backup manager so it will get set when things come back | 10:12 |
| dulek | DuncanT: Exactly. | 10:13 |
| DuncanT | The only issue will be with hard kills of c-bak to do the upgrade, which might leave some thing in state restoring/backingup, which will need to be reset by hand since the new cleanup code won't see them | 10:13 |
| DuncanT | (the old cleanup code would have reset the states on startup) | 10:13 |
| *** esker has joined #openstack-cinder | 10:13 | |
| dulek | DuncanT: You're right, but that simply isn't the way to correctly do the upgrade. | 10:14 |
| DuncanT | We can release note that case I guess. | 10:14 |
| dulek | DuncanT: I believe we have a lot of other places where hard-killing a service produces orphaned resources. | 10:14 |
| DuncanT | Backups are the hardest to drain during upgrade, since they can take hours | 10:14 |
| DuncanT | So well worth a release note, since it is a change in behaviour | 10:15 |
| dulek | DuncanT: That's a fair remark. I'll set myself a reminder to write a note. | 10:15 |
| DuncanT | Thanks | 10:16 |
| dulek | DuncanT, lixiaoy1: So now we just need to take care of correct scheduling in the backup.api if not all c-bak services are yet upgraded. | 10:17 |
| dulek | https://review.openstack.org/#/c/269412 | 10:17 |
| *** esker has quit IRC | 10:18 | |
| dulek | lixiaoy1: Can I try to rework this patch to include all the stuff related to bp rpc-object-compatibility we've merged? It should be really simple then. | 10:18 |
| *** baojg has quit IRC | 10:28 | |
| *** tpsilva has joined #openstack-cinder | 10:36 | |
| *** aarefiev has quit IRC | 10:37 | |
| openstackgerrit | Jordan Pittier proposed openstack/cinder: Fix race condition in RemoteFS create_snapshot_online https://review.openstack.org/281753 | 10:41 |
| openstackgerrit | Merged openstack/cinder: Add restore_volume_id in backup https://review.openstack.org/260903 | 10:41 |
| *** meomik has joined #openstack-cinder | 10:42 | |
| *** Poornima has quit IRC | 10:43 | |
| meomik | hi there, i have to cinder volumes (let say A, B) and i need to merge all data into one (A -> B or B -> A), how can i do that? do i need to make a small 'hack' in database? | 10:43 |
| dulek | meomik: Hacking the DB won't help you, Cinder does not do anything with data plane. | 10:47 |
| dulek | meomik: You can just attach both volumes to the VM and use dd command to do anything you want. | 10:47 |
| *** sdague has joined #openstack-cinder | 10:49 | |
| *** shyama_ has joined #openstack-cinder | 10:53 | |
| *** shyama has quit IRC | 10:55 | |
| *** shyama_ is now known as shyama | 10:55 | |
| *** sheel has joined #openstack-cinder | 10:58 | |
| *** dims has joined #openstack-cinder | 10:59 | |
| *** esker has joined #openstack-cinder | 11:00 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** marcusvrn_ has joined #openstack-cinder | 11:01 | |
| *** haomaiwang has joined #openstack-cinder | 11:01 | |
| *** lprice has joined #openstack-cinder | 11:03 | |
| *** lprice1 has quit IRC | 11:03 | |
| *** jwcroppe has joined #openstack-cinder | 11:03 | |
| *** yhayashi has quit IRC | 11:03 | |
| *** esker has quit IRC | 11:05 | |
| *** jwcroppe has quit IRC | 11:07 | |
| *** smoriya_ has quit IRC | 11:08 | |
| *** tobe has joined #openstack-cinder | 11:11 | |
| *** aarefiev has joined #openstack-cinder | 11:11 | |
| *** esker has joined #openstack-cinder | 11:15 | |
| *** shyama_ has joined #openstack-cinder | 11:17 | |
| *** jkraj has joined #openstack-cinder | 11:18 | |
| *** esker has quit IRC | 11:20 | |
| *** shyama has quit IRC | 11:20 | |
| *** shyama has joined #openstack-cinder | 11:21 | |
| *** ociuhandu has quit IRC | 11:22 | |
| *** shyama_ has quit IRC | 11:22 | |
| *** boichev2 has quit IRC | 11:23 | |
| ankit_ag | DuncanT: Hi | 11:27 |
| ankit_ag | DuncanT: could you please take a look on https://review.openstack.org/#/q/status:open+project:openstack/python-cinderclient+branch:master+topic:bp/return-request-id-to-caller when you get time | 11:27 |
| *** meomik has quit IRC | 11:27 | |
| *** boichev has joined #openstack-cinder | 11:30 | |
| *** dims_ has joined #openstack-cinder | 11:30 | |
| *** dims has quit IRC | 11:31 | |
| openstackgerrit | wanghao proposed openstack/cinder: Clean up image tmp file if c-vol gets restarted https://review.openstack.org/225081 | 11:31 |
| DuncanT | ankit_ag: Will do | 11:42 |
| ankit_ag | DuncanT: Thank you | 11:42 |
| e0ne | DuncanT: hi! I hate to ask somebody to review my patches, but deadline is too close for me. If you'll have a time, please take a look on https://review.openstack.org/263744 - attach/detach features for brickclient-extension | 11:44 |
| *** lpetrut has joined #openstack-cinder | 11:45 | |
| *** houming has quit IRC | 11:45 | |
| DuncanT | e0ne: You're up against the library deadline, right? I'll get to that one soon | 11:46 |
| e0ne | DuncanT: TBH, I'm talking about clients deadline and would get as much feedback, as possible before vacation | 11:47 |
| e0ne | I was wating for privsep in os-brick, but it's not ready and I start use rootwrap for now:( | 11:47 |
| DuncanT | I'm kind of glad that privsep stuff isn't going to make it TBH, I don't like the code | 11:48 |
| e0ne | :) | 11:48 |
| DuncanT | Need to spend some more time on it, figure out what it is I don't like | 11:48 |
| e0ne | it's a choise between bad and bad | 11:49 |
| DuncanT | Yeah, but it's old bad .v. introducing a new bad... we might as well get privsep right rather than having to redo it again later | 11:49 |
| e0ne | I don't like rootwrap implemetation - it's too implicit | 11:49 |
| e0ne | I don't know it there is a good English proverb for phrase: good known old one better than not known a new one | 11:51 |
| DuncanT | It's full of security holes, which makes it kind of pointless... it's no better than sudo rights anymore | 11:51 |
| DuncanT | The proverb for that would be 'Better the devil you know than the one you don't' | 11:52 |
| e0ne | thanks! | 11:52 |
| DuncanT | Usually shortened to 'Better the devil you know' in common usage | 11:53 |
| DuncanT | Origin is apparently 16th centiry Ireland | 11:54 |
| DuncanT | s/centiry/century/ | 11:54 |
| e0ne | oh.. I've just realized that it's a first proverb which I know the time of appearance/birth | 11:57 |
| *** EinstCrazy has joined #openstack-cinder | 11:59 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 12:01 | |
| *** salv-orl_ has quit IRC | 12:03 | |
| *** raildo-afk is now known as raildo | 12:09 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Test middleware test_faults to Python 3 https://review.openstack.org/249399 | 12:09 |
| *** erlon has joined #openstack-cinder | 12:11 | |
| *** laughterwym has joined #openstack-cinder | 12:22 | |
| *** laughterwym has quit IRC | 12:22 | |
| *** laughterwym has joined #openstack-cinder | 12:22 | |
| *** ociuhandu has joined #openstack-cinder | 12:23 | |
| *** laughterwym has quit IRC | 12:23 | |
| *** laughterwym has joined #openstack-cinder | 12:23 | |
| *** salv-orlando has joined #openstack-cinder | 12:26 | |
| *** dave-mccowan has joined #openstack-cinder | 12:26 | |
| *** haypo has joined #openstack-cinder | 12:27 | |
| haypo | hey, i have some issues with Brocade CI, see my latest comment at https://review.openstack.org/#/c/280335/ | 12:28 |
| haypo | "Brocade Fibre Channel Zoning HTTP error: Error while authenticating with switch: Brocade Fibre Channel Zoning HTTP error: Authentication failed, verify the switch credentials, error code -13" | 12:28 |
| *** JoseMello has joined #openstack-cinder | 12:28 | |
| haypo | do you know who own this CI and can investigate? | 12:29 |
| dulek | haypo: I've found "Brocade-Openstack-CI@Brocade.com" at https://wiki.openstack.org/wiki/ThirdPartySystems | 12:34 |
| dulek | But I don't know if this is the page we're supposed to look at. | 12:34 |
| haypo | dulek: ok, i will send an email ;) | 12:36 |
| *** ankit_ag has quit IRC | 12:39 | |
| *** ankit_ag has joined #openstack-cinder | 12:40 | |
| *** yangyapeng has joined #openstack-cinder | 12:46 | |
| *** jseiler has quit IRC | 12:47 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Add devref on rolling upgrades https://review.openstack.org/279186 | 12:47 |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Add devref on rolling upgrades https://review.openstack.org/279186 | 12:49 |
| dulek | Rolling upgrades docs for developers are up for review - we've talked about that on the mid-cycle. | 12:50 |
| dulek | ^ | 12:50 |
| *** haomaiwa_ has quit IRC | 12:52 | |
| *** timcl has joined #openstack-cinder | 12:52 | |
| *** julim has joined #openstack-cinder | 12:57 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Rtstool sets wrong exception message on save https://review.openstack.org/281821 | 13:00 |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: cinder-api-microversions code https://review.openstack.org/224910 | 13:02 |
| *** avishay has joined #openstack-cinder | 13:05 | |
| avishay | smcginnis: Hey! When do newton specs open? | 13:06 |
| dulek | avishay: I think you can simply add newton folder with your spec. | 13:08 |
| *** EinstCrazy has quit IRC | 13:09 | |
| smcginnis | avishay: The folder is added, so submit away. :) | 13:09 |
| *** EinstCrazy has joined #openstack-cinder | 13:09 | |
| scottda | smcginnis: Is there a good way to get visibility for this Grenade review? https://review.openstack.org/#/c/276505/ | 13:11 |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Add ConsistencyGroupVolumeTypeMapping table https://review.openstack.org/245854 | 13:11 |
| scottda | Or is it just to nag the right people? (#openstack-qa I think) | 13:11 |
| dulek | scottda: #openstack-dev is a better place from my experiences. | 13:12 |
| scottda | dulek: cool, thanks | 13:12 |
| dulek | scottda: You may try to ping dansmith or sdague. | 13:12 |
| scottda | ok, they're online a bit later, I think. | 13:12 |
| *** e0ne has quit IRC | 13:13 | |
| scottda | dulek: You could review that ^^, if you've time. Just a grenade change for micorversions. | 13:13 |
| sdague | scottda: typically #openstack-qa, though I saw the ping now | 13:13 |
| dulek | scottda: I want to review whole microversions stuff today, so sure. | 13:14 |
| *** e0ne has joined #openstack-cinder | 13:14 | |
| sdague | also, I don't understand why you are adding a new endpoint for it | 13:14 |
| scottda | cool, thanks | 13:14 |
| dulek | smcginnis: I think you should also add newton's specs here: https://github.com/openstack/cinder-specs/blob/master/doc/source/index.rst | 13:14 |
| smcginnis | scottda: Yeah, dev is probably a good starting place. | 13:15 |
| scottda | sdague: This was advice from manila. So a user didn't hit the old (/v2) endpoint with a microversion header, and an older server that did not understand microversions would fall back to default behaviour, causing a silent failure. | 13:15 |
| smcginnis | scottda: I think the comment was how it gets updated. | 13:15 |
| scottda | Meaning why grenade needs this? | 13:16 |
| smcginnis | dulek: Yeah, I was going to wait to link it in to the index. | 13:16 |
| smcginnis | I suppose I don't have to. | 13:17 |
| smcginnis | Just worried someone looking during the Mitaka release might not understand and think anything in Newton already made it. | 13:17 |
| sdague | scottda: it is expected the user actually hits the version list up front before that do that | 13:17 |
| dulek | smcginnis: Well, maybe it's easier to read while Mitaka's still in development. | 13:17 |
| sdague | honestly, I think sticking on the same endpoint will provide a much smoother transition | 13:17 |
| smcginnis | dulek: True. I can add it. | 13:17 |
| sdague | given that it has taken 3 years to go from 1 -> 2 | 13:18 |
| smcginnis | sdague: That was our original direction. | 13:18 |
| smcginnis | sdague: But it was pointed out by manila that that is dangerous. | 13:18 |
| scottda | sdague: Perhaps. But we discussed this at the Cinder mid-cycle and that's what people wanted. | 13:18 |
| sdague | ok, I think manilla is wrong in that regard | 13:18 |
| sdague | but so be it | 13:18 |
| smcginnis | sdague: Hah, maybe. But we talked through some scenarios that changed my mind at the time at least. | 13:19 |
| scottda | sdague: I originally had your understand and implemented it that way, so would've been great with me to stick with /v2. But here we are. | 13:19 |
| smcginnis | scottda: Wasn't the issue of new parameters silently getting ignored if it was a pre-microversion v2 endpoint? | 13:20 |
| sdague | right, it's just going to be 3 years to get things sorted as you'll need another endpoint | 13:20 |
| smcginnis | So you could end up with a successful response, but not get what you requested. | 13:20 |
| scottda | smcginnis: Yes, that was brought up as a/the problem use case | 13:20 |
| sdague | smcginnis: sure, but that's not really different than today right? | 13:21 |
| sdague | do you have strict param validation | 13:21 |
| smcginnis | sdague: I'm not sure if we do everywhere. | 13:21 |
| scottda | sdague: the issue today is that we can't/don't add new parameters... | 13:21 |
| dulek | scottda: But isn't the microversion header returned, so user can validate the response by himself? | 13:21 |
| *** haomaiwang has joined #openstack-cinder | 13:22 | |
| scottda | we tried that with passing host+instance_id during nova volume_attach and it blew up when used with old (liberty) cinder.. | 13:22 |
| sdague | scottda: sure, but if someone throws ?foo=bar onto a thing, do you explode? | 13:22 |
| scottda | and we had to back out that change for multi-attach because of this. | 13:22 |
| scottda | dulek: Yes, the user could/should validate the header, and if there is not one user would know that the server did not understand micorversions.... | 13:22 |
| sdague | or silently drop 'foo' | 13:23 |
| smcginnis | dulek: Could be too late at that point. | 13:23 |
| scottda | but there are those amongst us who take up the arguement that we must protect against the users who do things improperly. | 13:23 |
| dulek | Sure, I understand both concerns. | 13:24 |
| dulek | sdague: I think we silently drop it. | 13:24 |
| smcginnis | sdague: I think right now we silently drop foo. Which would be a problem then. | 13:24 |
| scottda | sdague: I don't remember the details on the multi-attach issue, but I think we explode. | 13:24 |
| sdague | dulek: right, so the API currently already does silent ignore | 13:24 |
| scottda | at least for adding the host+instance_id. and I believe it was an optional parameter. This was nova-> cinder via the cinderclient. | 13:25 |
| smcginnis | sdague: So if we silently ignore the new params then (assuming the response isn't checked for the header) we wouldn't do what was being requested. | 13:25 |
| avishay | smcginnis: cool thanks! | 13:25 |
| sdague | here is the trade off. Do you assume people that know enough to integrate microversions and not actually check the server does it. | 13:25 |
| smcginnis | But still return success with a different operation actually executed than what they wanted. | 13:25 |
| sdague | at the cost of having to keep the /v2 endpoint forever | 13:26 |
| smcginnis | sdague: Take the caveat emptor approach? | 13:26 |
| sdague | because if /v2 supports microversions | 13:26 |
| sdague | then old scripts keep working on /v2 | 13:26 |
| sdague | and they work forever | 13:26 |
| *** andymaier has joined #openstack-cinder | 13:26 | |
| sdague | a new stuff works forever as well | 13:26 |
| scottda | smcginnis: sdague Personally, I say caveat emptor. But that's not how opensource works....if someone(s) disagrees, we get to the point we are at now, with me having just implemented /v3 endpoint for this, and late in the release at that. | 13:27 |
| sdague | but the cost of changing out that url part is huge | 13:27 |
| *** mylu has joined #openstack-cinder | 13:27 | |
| sdague | scottda: I realize you all are down this path. I'm saying make sure you *really* *really* *want* to do it this way | 13:27 |
| sdague | because the downstream cost of this is huge | 13:28 |
| *** nkrinner has quit IRC | 13:28 | |
| smcginnis | The thought was, the switch to /v3 would be the last. Ever. /v2 clients just keep on working. It would take a while to transition for sure. | 13:28 |
| *** nkrinner has joined #openstack-cinder | 13:28 | |
| smcginnis | And it would make it very explicit when to switch to microversions. | 13:28 |
| sdague | smcginnis: by a while, we're talking 3 - 5 years | 13:28 |
| smcginnis | sdague: Or double that. ;) | 13:28 |
| sdague | yep | 13:28 |
| sdague | the whole point of microversions was to not have to be explicit to switching :) | 13:29 |
| *** mylu has quit IRC | 13:29 | |
| sdague | not in the url at least | 13:29 |
| smcginnis | bswartz: You around? | 13:29 |
| smcginnis | sdague: Yeah, fair point. | 13:29 |
| sdague | ok, anyway, I'll leave you to it. I still think it's worth making sure this is how you really want to do this. | 13:30 |
| smcginnis | sdague: Thanks, good to hear a voice arguing the other side. | 13:30 |
| scottda | sdague:Your advice is much appreciated | 13:30 |
| *** avishay has quit IRC | 13:30 | |
| smcginnis | sdague: That was our original approach until the midcycle. | 13:30 |
| scottda | That was how the code looked when it was first posted (before Tokyo summit ) | 13:31 |
| smcginnis | scottda: Wow, it has been that long, hasn't it? | 13:31 |
| scottda | yes | 13:31 |
| scottda | so, don't take this as whining, it's really a philosophical question: How can we (openstack community) get to solutions and answers more quickly? | 13:32 |
| scottda | Maybe this is as good as it gets, I don't know. | 13:32 |
| scottda | But for microversions in mitaka, it's either merge soon or punt to Newton. And waiting might be best... | 13:33 |
| sdague | scottda: well, part of the issue is not realizing something was up for debate. As someone that had a bit part in carving out this whole concept and getting it into Nova, I didn't realize there was something up for debate on the cinder side for implementation. | 13:33 |
| sdague | was there an ML thread on this? | 13:34 |
| dulek | sdague: Just the mid-cycle summary I think. | 13:34 |
| scottda | sdague: no, there was no ML thread. This came up in Jan at our mid-cycle. | 13:34 |
| scottda | so, maybe that's my answer to how to get better communication. | 13:34 |
| sdague | yeh, that's the blessing and curse of midcycles | 13:35 |
| smcginnis | Seems like microversions maybe should have been a cross project spec to make sure we were all in agreement on how to implement it. | 13:35 |
| scottda | But within Cinder, there wasn't much debate. The new endpoint was brought up, and we all kind of agreed. | 13:35 |
| sdague | you get a lot of people in the room to discuss things fast | 13:35 |
| sdague | but it assumes everyone that has information that's relevant is in the room | 13:35 |
| scottda | yup | 13:36 |
| sdague | smcginnis: we're working through api-wg guidelines on that right now | 13:36 |
| johnthetubaguy | smcginnis: you took the words from the keyboard, might still want one so we all use a similar pattern, actually do we have an API wg doc on this? we probably want to create one so we agree a general pattern | 13:36 |
| johnthetubaguy | hmm, I can't type, but the message is in there | 13:36 |
| smcginnis | johnthetubaguy: I got ya. ;) | 13:37 |
| smcginnis | sdague: Do you have a link? | 13:37 |
| sdague | the thing is, up until this point, the model was copy nova, which is what ironic and manilla largely did. But there were some varients done in the process | 13:37 |
| smcginnis | I would be hesitant to merge something this late in the cycle knowing there's questions on the implmentation. | 13:37 |
| smcginnis | Especially if it ends up counter to what the api-wg states. | 13:37 |
| scottda | smcginnis: I agree | 13:37 |
| sdague | smcginnis: it's probably not going to answer the questions you have | 13:37 |
| johnthetubaguy | sdague: true | 13:37 |
| sdague | because this idea of forcing a new endpoint is not something that I'd ever heard of before | 13:38 |
| sdague | in Nova we kind of had to because the code stacks were different | 13:38 |
| *** abhishekk has joined #openstack-cinder | 13:38 | |
| sdague | but it's a regret | 13:38 |
| smcginnis | sdague: Maybe I can raise a question on it. Or point bswartz at it to explain why they did that in manila. | 13:39 |
| johnthetubaguy | sdague: ah, good point, that was lots in translation | 13:39 |
| johnthetubaguy | lost | 13:39 |
| sdague | https://review.openstack.org/#/q/status:open+project:openstack/api-wg+branch:master+topic:micro_spec | 13:39 |
| scottda | smcginnis: I'm all for slowing down to think on this. Which means I'm about to WIP the microversions patch..... | 13:39 |
| *** edmondsw has joined #openstack-cinder | 13:39 | |
| smcginnis | scottda: I'm kinda thinking that might be better at this point. | 13:40 |
| smcginnis | scottda: At least for a bit while we stew on this. | 13:40 |
| sdague | I think that's also the thing that we should realize is that this is not a completely solved space. So there is no "this is exactly how to do this" yet. It requires discussion with folks that have done it. | 13:40 |
| abhishekk | DuncanT: hi you around? | 13:40 |
| smcginnis | sdague: True. I just hope that however we all implement it, we are _mostly_ consistent in the usage. | 13:40 |
| johnthetubaguy | sdague: its similar with upgrade, in some ways | 13:41 |
| *** edmondsw has quit IRC | 13:41 | |
| *** edmondsw has joined #openstack-cinder | 13:42 | |
| scottda | ok, patch is WIP'ed . Thanks for the input, gentlemen. | 13:42 |
| smcginnis | scottda: Thanks man. | 13:42 |
| scottda | I fell like the kids just went off to camp. What do I do now? | 13:42 |
| smcginnis | Hah! | 13:42 |
| * dulek feels a little guilty for triggering this… | 13:43 | |
| scottda | dulek: No way! Much better to figure this out now. | 13:43 |
| smcginnis | dulek: It's better we have the discussion now than in a few weeks. | 13:43 |
| scottda | This is not some simple patch that we can just revert if we find a bug. | 13:43 |
| * smcginnis goes off to find our midcycle video | 13:43 | |
| dulek | Okay. Anyway I can go back to scalable backups then… | 13:44 |
| smcginnis | Dang we have too much video. Should edit these down to useful bits. | 13:44 |
| scottda | I never liked the idea of adding a new endpoint. And I'm firmly in the Caveat Emptor camp for dealing with users. We don't need to bullet-proof everything we do . | 13:44 |
| scottda | That's kinda the point of microversions. If you want them, ask for them and deal with them properly. If you don't want them (or know about them), don't do anything and get the same, original behaviour. | 13:45 |
| smcginnis | scottda: It would certainly simplify some things. | 13:46 |
| smcginnis | And if that's the approach nova has taken, it wouldn't be inconsistent with one of the other core projects. | 13:47 |
| *** ankit_ag has quit IRC | 13:47 | |
| *** jgregor has joined #openstack-cinder | 13:47 | |
| *** xyang1 has joined #openstack-cinder | 13:47 | |
| *** krtaylor has joined #openstack-cinder | 13:47 | |
| *** xyang has joined #openstack-cinder | 13:48 | |
| scottda | Yeah, I'll take the blame for not being a better communicator about this. I think up to the mid-cycle people still didn't understand the guts of how this worked, so the was a lot of FUD about it. | 13:50 |
| dulek | What are the next steps? | 13:50 |
| dulek | We're back to the whiteboard to get it right in Newton? | 13:51 |
| dulek | Or we're still targeting Mitaka? | 13:51 |
| scottda | dulek: I have a hard time imagining we can get to consensus in the next 12 days. | 13:52 |
| smcginnis | I would say it's not completely off the table for Mitaka. | 13:52 |
| smcginnis | But the risk is high at this point. | 13:52 |
| scottda | dulek: I'm not sure how much whiteboard is needed, I'll start with an ML post on this issue, and we can see.... | 13:52 |
| *** mylu has joined #openstack-cinder | 13:53 | |
| smcginnis | scottda: That's probably a good idea. It would be good to get varied input on this. | 13:53 |
| DuncanT | abhishekk: Hi | 13:53 |
| scottda | smcginnis: dulek It's be nice to gather ideas on the implications of pushing this out to Newton. What items are dependent or blocked by microversions? | 13:53 |
| *** jwcroppe has joined #openstack-cinder | 13:54 | |
| DuncanT | I remember bswartz having a good point at the midcycle, but I forget what it was. I'll read the notes. | 13:55 |
| smcginnis | Seems like half the things we discussed at the midcycle were dependent on microversions. | 13:55 |
| smcginnis | DuncanT: Yeah, I was hoping to find the youtube video to refresh on that. | 13:55 |
| *** martyturner has joined #openstack-cinder | 13:56 | |
| smcginnis | DuncanT: But pretty sure the main point being a microversion aware client talking to a pre-microversion service. | 13:56 |
| smcginnis | DuncanT: And that older service ignoring new things and returning success even though the user didn't get what they asked for. | 13:56 |
| scottda | smcginnis: DuncanT That was the argument. But I think it defeats the point of microversions if you have a user who says "Yes, I want microversions, but I don't want to be responsible for checking that they are supported" | 13:57 |
| smcginnis | scottda: Yeah. I hate to flip flop - because I was behind /v3 at the midcycle - but I think you're right. | 13:58 |
| abhishekk | DuncanT: sorry to bother, I was unaware ankt_ag has already requested you to review request-id patches | 13:59 |
| scottda | smcginnis: Things we discussed for Newton were blocked by microversions, but with my (eternal) optimism I believe that microversions will get in for early Newton, ahead of anything else. The question is: Is there anything in Mitaka that would be blocked by this? | 13:59 |
| smcginnis | scottda: Definitely early N. | 14:00 |
| DuncanT | abhishekk: I've got the in my queue, but lots of other things too | 14:00 |
| dulek | Cheescake's fine without microversions, right? | 14:00 |
| smcginnis | I remember in Tokyo we didn't have an immediate need for it, but then it seemed like at the midcycle it was the panacea for all issues. | 14:00 |
| *** haomaiwang has quit IRC | 14:01 | |
| scottda | dulek: I think so. It's a new api, right? Not breaking anything or backwards-incompatible? | 14:01 |
| *** mylu has quit IRC | 14:01 | |
| DuncanT | smcginnis: We've a bunch of stuff queued up that changes APIs in various ways | 14:01 |
| *** haomaiwang has joined #openstack-cinder | 14:01 | |
| smcginnis | DuncanT: For M? Do you know which things? | 14:01 |
| abhishekk | DuncanT: yes. thank you and sorry again | 14:01 |
| DuncanT | dulek: I think that's ok since the old replication API never worked | 14:01 |
| smcginnis | DuncanT: Some may argue that, but I think we're past that point. ;) | 14:02 |
| DuncanT | smcginnis: There are some queued for M I'm sure. I'll see what I can find | 14:02 |
| *** rlrossit has joined #openstack-cinder | 14:03 | |
| smcginnis | DuncanT: That's the feeling I have too, I just can't think of a specific case. | 14:03 |
| scottda | Anything we would have changed previously in the API does not need microversions. It is mainly for things that could break an older deployment. | 14:03 |
| dulek | smcginnis, scottda: Maybe we should start with an ML thread so anyone would be able to chime in. We'll also signal developers who were dependent on microversions. | 14:04 |
| scottda | If you need a good primer on microversions, some smart guy wrote a blog about it: https://dague.net/tag/microversions/ | 14:04 |
| dulek | s/We'll/This will | 14:04 |
| scottda | dulek: Yes, i'll work that up. | 14:05 |
| xyang1 | scottda: replication api is in contrib, even if microversion is merged, it cannot be used on contrib until we move everything to core api | 14:05 |
| xyang1 | scottda: we had that discussion during spec review | 14:06 |
| xyang1 | scottda: smcginnis the decision back then was not to block contrib api changes for microversion | 14:07 |
| scottda | xyang1: you mean replication+microversions cannot work until everything is moved to core, right? features on contrib will still work as they have in the past... | 14:07 |
| xyang1 | scottda: yes | 14:07 |
| *** dave-mccowan has quit IRC | 14:09 | |
| bswartz | DuncanT: the issue with microversions and the URL is when a new client calls an microversioned API on an old server, you want it to fail immediately instead of having undefined behavior. Because old servers will ignore everything in the header related to microversions, the only way to ensure failure is to use a different URL path. | 14:09 |
| DuncanT | bswartz: That was it, thanks | 14:10 |
| *** dave-mccowan has joined #openstack-cinder | 14:10 | |
| DuncanT | So we really do want a V3 endpoint, otherwise every client needs an 'are microversions supported' round trip | 14:10 |
| bswartz | correct | 14:10 |
| bswartz | and because clients are often stateless, that round trip could be needed very frequently | 14:11 |
| scottda | DuncanT: But you stated the possible alternative, every client needs a 'are microversions supported' round trip | 14:11 |
| scottda | That is the point of micorversions | 14:11 |
| scottda | the client needs to know that they are supported, else you cannot use them | 14:11 |
| dulek | DuncanT: sdague argumented that it's no different that silently ignoring URL params. | 14:11 |
| dulek | DuncanT: Which we're doing now. | 14:12 |
| scottda | And we can do some smarts in python-cinderclient, like caching , to prevent round-trips after the first one. | 14:12 |
| bswartz | scottda: the point of microversions is to allow clients and servers coded for different versions to find an API definition they agree on exactly | 14:12 |
| smcginnis | bswartz: Don't they need that round trip to find that agreed on version? | 14:13 |
| dulek | smcginnis: +1 | 14:13 |
| bswartz | mcginnis: not in the general case | 14:13 |
| scottda | bswartz: Right. And that means the client will have to understand the reply from the server. IF the server does not respond with a supported micorversion, the client can understand that the server does not support microversions. | 14:13 |
| bswartz | if the server supports the version the client wants to use, then it succeeds autoamtically | 14:14 |
| bswartz | if the server doesn't support, then the client should receive an error with details about what it does support, and the client can adjust accordingly | 14:14 |
| scottda | but the client can not just assume that success means the server supported the version that is asked for. The client must verify , if the client cares enough. | 14:14 |
| scottda | bswartz: I disagree. the client that understands microversions must be aware that some (older) servers do not understand microversions. | 14:15 |
| DuncanT | If we always include a header in the microversion response, then the client knows it is talking to an old server if that header is there | 14:16 |
| bswartz | scottda: I disagree -- the client should assume that a positive response means that the API call was successful -- microversions gives us an efficient way to handle this negotiation | 14:16 |
| DuncanT | s/is there/ is not there/ | 14:16 |
| bswartz | scottda: yes obviously older server don't support microversions, therefore you detect that by sending microversioned requests to a different URL so that old servers are guaranteed to return 404 not found | 14:17 |
| *** akerr has joined #openstack-cinder | 14:17 | |
| bswartz | it's more efficient than always asking ahead of time what the server supports | 14:17 |
| scottda | bswartz: If the client wants to be efficient , they can go with old behaviour: no microversions, no new API changes. | 14:18 |
| scottda | If the client wants the latest-and-greatest api behaviour, and the client is not sure what the other end of the deployment supports, it must check the return. | 14:19 |
| bswartz | eventually that will be untenable though | 14:19 |
| bswartz | Imagine if every web browser in the world started with HTTP 0.9 and negotiated upwards to HTTP 1.1 | 14:20 |
| bswartz | all the extra round trips would be hugely wasteful, and nobody uses HTTP 0.9 since the mid 90s | 14:20 |
| bswartz | someday the existing cinder v2 API will be obsolete | 14:21 |
| smcginnis | You would negotiate down, wouldn't you? | 14:21 |
| scottda | What is the difference in efficiency with 1) hitting new /v3 endpoint, which is not supported, and getting 404 and then 2) having to fall back to old /v3 endpoint vs. 2) asking for microversion and getting a response that shows ignorance of microversions and then 2) having to fall back to old, non-micorversionsed behafiour ? | 14:21 |
| bswartz | yes | 14:21 |
| bswartz | it's better to start with the highest version you support and to have a way to negotiate down | 14:21 |
| bswartz | it's dumb to start with the lowest version and negotiate up -- it guarantees bad performance in the common case | 14:22 |
| smcginnis | bswartz: So your web browser example isn't valid? :) | 14:22 |
| bswartz | smcginnis: web browsers do start from the highest version they support | 14:22 |
| scottda | The server either does not understand microversions or returns the highest version it does understand. | 14:22 |
| *** archers has joined #openstack-cinder | 14:22 | |
| openstackgerrit | Merged openstack/cinder: Delete unuseful code in Huawei driver https://review.openstack.org/280460 | 14:24 |
| scottda | The client also starts with the highest version supported/desired. The server responds with either 1) no microversion (existing/Liberty server) or 2) compute fault 406: | 14:24 |
| scottda | {"computeFault": {"message": "Version 3.8 is not supported by the API. Minimum is 3.0 and maximum is 3.3.", "code": 406}} | 14:24 |
| scottda | the client can re-send from there. | 14:25 |
| bswartz | scottda: and if the server is liberty? | 14:25 |
| scottda | If the client does not wish to go through this, they can just not use microversions. | 14:25 |
| scottda | The liberty server won't have a microversion response in the reply | 14:25 |
| * DuncanT can understand bswartz's point... sending a microversioned request to an old server might cause something unwanted to be done by the old server, unless we're really careful with our API changes (which, realistically, we're not going to manage) | 14:26 | |
| scottda | So the client will know that it is pre-microversions and deal with it. | 14:26 |
| *** diogogmt has quit IRC | 14:26 | |
| *** mriedem has joined #openstack-cinder | 14:26 | |
| DuncanT | By the time you get the response, it is too late | 14:26 |
| bswartz | duncant: yes | 14:26 |
| DuncanT | So you'd have to probe to see if microversions are supported every time | 14:26 |
| scottda | microversions has a new API to determine supported versions, including microversions | 14:26 |
| DuncanT | Which is a performance killer | 14:26 |
| scottda | But how often is your server deployment going to change? | 14:27 |
| DuncanT | scottda: Most clients don't cache stuff | 14:27 |
| DuncanT | scottda: So there'll have to be lots of (slow) probes if we don't go V3 | 14:27 |
| scottda | I think it's ironic that has implemented some caching in their client, so this does not have to be discovered for each call. | 14:27 |
| bswartz | scottda: that approach works from a correctness standpoint it's just very slow compared to simply sending the request you want to send and hoping it succeeds (if the server supports it) or fails (if the server is too old) and then retrying with a lower version | 14:27 |
| DuncanT | bswartz: ++ | 14:28 |
| *** diogogmt has joined #openstack-cinder | 14:28 | |
| bswartz | the common case by far will be that it will succeed | 14:28 |
| guitarzan | eafp | 14:28 |
| bswartz | just like my web browser example | 14:28 |
| scottda | DuncanT: I've planned on implementing caching for cinderclient. It uses a file, so it will work with stateless clients. Expires whenever you want (2 minutes, 24 hours, 1 week...) | 14:28 |
| bswartz | every web server in the world understands HTTP/1.1 today -- but back in 1998 that wasn't true | 14:29 |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Match the ip more accurately in Huawei driver https://review.openstack.org/280481 | 14:29 |
| *** mylu has joined #openstack-cinder | 14:30 | |
| bswartz | cinder today is where the web was in 1998 | 14:30 |
| *** gouthamr has joined #openstack-cinder | 14:30 | |
| bswartz | let's not build something we'll regret in 10 years | 14:30 |
| scottda | Well every openstack cinder server in the world will understand microversions some day. Until then, you deal with the possibility that your server may not. | 14:30 |
| DuncanT | scottda: pyton-cinderclient is far from the only client out there, in fact servey shows it is in the minority IIRC | 14:30 |
| *** baumann has joined #openstack-cinder | 14:30 | |
| *** baumann has left #openstack-cinder | 14:30 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Don't show chap password in log https://review.openstack.org/271595 | 14:31 |
| scottda | What might we regret in 10 years? All servers will understand microversions by then. | 14:31 |
| dulek | DuncanT: Actually it's 85% for OpenStack clients. | 14:31 |
| smcginnis | We'll need caching either way. Fail, retry. Either fail a microversion and downgrade. Or fail a /v3 call and downgrade to /v2. | 14:32 |
| dulek | DuncanT: Python's libcloud is used by 24%. | 14:32 |
| scottda | DuncanT: OK, well, older clients who want microversions will need to change to use them. They will need to understand what they are doing, else they shouldn't be doing it. Caveat Emptor. If the other clients don't want to, or don't explicitly change to use microversions, everything is the same as today. | 14:32 |
| dulek | DuncanT: But then - it's 21% of "Wrote our own" | 14:32 |
| smcginnis | scottda: Right. libcloud will just keep working. | 14:32 |
| DuncanT | scottda: But you're requiring them to have caching to be efficient if you don't go the V3 route | 14:33 |
| scottda | Read sdague post: https://dague.net/tag/microversions/ | 14:33 |
| bswartz | scottda: when do you decide it's safe to stop calling the query microversion API? | 14:33 |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Don't fail when port group does not exist https://review.openstack.org/271599 | 14:33 |
| DuncanT | They're going to require microversions to access new features | 14:33 |
| bswartz | after 1 year? after 3 years? | 14:33 |
| *** eharney has quit IRC | 14:33 | |
| DuncanT | So you're changing the API requirements in a way no other service has actually done | 14:33 |
| bswartz | you never know for sure that all the non-microversioned servers are gone | 14:33 |
| scottda | DuncanT: They will be no more efficient with v3 route. They will still 1) try v3, which fails 2) fall back to v2. What's the difference between that and figuring out the same thing when they hit a v2 enpoint? | 14:34 |
| bswartz | there are crazy people running openstack Essex still today | 14:34 |
| DuncanT | They mostly won't fail - v3 will be in most places within a year | 14:34 |
| *** knikolla has joined #openstack-cinder | 14:34 | |
| smcginnis | DuncanT: That actually breaks libcloud then. | 14:35 |
| *** mtanino has joined #openstack-cinder | 14:35 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Check the QoS status before we use https://review.openstack.org/271601 | 14:35 |
| scottda | well, if the server has v3 they would also have v2+microversions | 14:35 |
| DuncanT | The difference is, in the V3 fast path case, which is the future, they just call the API and version they need for the operation, which will be there | 14:35 |
| smcginnis | If we use /v2 then not asking for new versions will just work. | 14:35 |
| DuncanT | In your case, they have to query *every time* | 14:35 |
| smcginnis | DuncanT: You still need to query. | 14:35 |
| DuncanT | smcginnis: Why? | 14:35 |
| *** cknight1 has quit IRC | 14:35 | |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Add description when rename LUN in Huawei driver https://review.openstack.org/271603 | 14:36 |
| smcginnis | DuncanT: Say I want version 3.5. Even if microversions are supported by the server, I have to check that it doesn't only support 3.4. | 14:36 |
| scottda | because the server might not support v3. If it does not, you have to fall back to v2. Same as querying if server supports v2+microversions, and then falling back to v2-microversions | 14:36 |
| *** jkraj has quit IRC | 14:36 | |
| *** jkraj has joined #openstack-cinder | 14:37 | |
| DuncanT | smcginnis: Just call 3.5 - the chances are, if you're calling an API in anger, you're fairly sure it is supported. The fallback case therefore happens less often | 14:37 |
| scottda | DuncanT: You can add a new feature if you re-use v2 endpoint, and not microversion it. Microversion is only required if it is a breaking API change. | 14:37 |
| smcginnis | bswartz: If I remember right, the main thing you were saying is we could do a create request for v3.5 and if 3.5 is supported, no worries. | 14:37 |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Ensure the port is online https://review.openstack.org/271600 | 14:37 |
| DuncanT | scottda: Catching 'breaking' API changes is damn difficult. Go look at our history. | 14:38 |
| smcginnis | bswartz: But if we call the 3.5 create and it isn't supported, and it isn't microversion aware, it could do a create differently than what we expect. | 14:38 |
| *** mvk has quit IRC | 14:38 | |
| smcginnis | bswartz: That was the crux of the argument for /v3, right? | 14:38 |
| DuncanT | scottda: Ignoring a parameter in the request can have unwanted side effects - we've already had bugs around that | 14:38 |
| bswartz | smcginnis: yes I'm not in favor of calling a what-do-you-support API before every API request, even with caching | 14:38 |
| scottda | DuncanT: IF you add a parameter, bump the microversion | 14:38 |
| bswartz | caching can't be used everywhere and it introduces a new class of bad behavior when the server version changes between 2 requests | 14:39 |
| DuncanT | scottda: Which goes back to the making everybody slow arguement | 14:39 |
| *** mvk has joined #openstack-cinder | 14:39 | |
| *** porrua has joined #openstack-cinder | 14:39 | |
| DuncanT | scottda: You're going round in circles | 14:39 |
| smcginnis | sdague: If you're still around - how does nova client handle caching. Or not. | 14:39 |
| *** esp has joined #openstack-cinder | 14:39 | |
| bswartz | I believe the client should just call the API it wants and the server should always succeed if it can, and always fail if it can't handle the version | 14:39 |
| openstackgerrit | Wilson Liu proposed openstack/cinder: Add LUN wwn check in Huawei driver https://review.openstack.org/271592 | 14:40 |
| DuncanT | bswartz: | 14:41 |
| DuncanT | ++ | 14:41 |
| *** kvidvans has joined #openstack-cinder | 14:42 | |
| *** diablo_rojo has joined #openstack-cinder | 14:42 | |
| scottda | bswartz: I don't think that's controversial. Either way you have that | 14:42 |
| scottda | ok, I guess I see you're point... | 14:43 |
| scottda | we're back to the 'silent failure' on v2 | 14:43 |
| bswartz | scottda: if we don't query the server version before sending, for example, a create-snapshot API, then it's possible that you send a super-spiffy-new v3 snapshot creation option and the server silently ignores it if it's plain v2 | 14:43 |
| smcginnis | scottda: I think we need a ML post for sure. If Nova is not going this route, I'd like to know how they are handling this. | 14:43 |
| DuncanT | It's not just a silent failure, it could well be that something happened that you didn't mean | 14:43 |
| bswartz | I'd rather that the server returns 404 not found so the client knows that super-spiffy snapshot creation options cannot be used with that server | 14:44 |
| scottda | smcginnis: Yeah, I was going to look for the video reference, but I think bswartz has nicely re-iterated his arguement. I'll post something this morning. | 14:44 |
| scottda | bswartz: I get you. Which is what you said at the mid-cycle. Which is why we agreed. Which is why I added v3. and now here we are..... | 14:45 |
| smcginnis | scottda: Just watched the video again. I think it's covered here. | 14:45 |
| scottda | smcginnis: can you post the link and timestamp? | 14:45 |
| *** esp has quit IRC | 14:46 | |
| *** mylu has quit IRC | 14:46 | |
| smcginnis | Trying to find when it actually starts. | 14:46 |
| bswartz | btw the nova guys did get this right | 14:47 |
| *** dustins has joined #openstack-cinder | 14:47 | |
| *** abhishekk has left #openstack-cinder | 14:47 | |
| smcginnis | bswartz: What do you mean? | 14:47 |
| bswartz | they changed their endpoint from /v2 to /v2.1, which while I think the choice of strings was poor, the fact that they changed it to something else guarantees that new clients talking to old servers won't get unwanted behavior | 14:48 |
| *** bill_az has joined #openstack-cinder | 14:48 | |
| *** mylu has joined #openstack-cinder | 14:48 | |
| *** dave-mccowan has quit IRC | 14:48 | |
| smcginnis | bswartz: Hmm, sdague was here earlier stating they didn't do a different endpoint. | 14:48 |
| bswartz | o_O | 14:48 |
| smcginnis | scottda: https://www.youtube.com/watch?v=tfEidbzPOCc | 14:48 |
| smcginnis | scottda: Around the 1:20 mark. | 14:48 |
| dulek | smcginnis: No. He stated that different endpoint was a mistake. | 14:48 |
| smcginnis | bswartz: Which is what led to all of this getting rehashed again. | 14:49 |
| dulek | <sdague> because this idea of forcing a new endpoint is not something that I'd ever heard of before | 14:49 |
| dulek | <sdague> in Nova we kind of had to because the code stacks were different | 14:49 |
| dulek | <sdague> but it's a regret | 14:49 |
| bswartz | well I disagree with sdague about that | 14:49 |
| DuncanT | Me too. Pretty sure we need a new endpoint. | 14:49 |
| *** rajinir has joined #openstack-cinder | 14:50 | |
| *** eharney has joined #openstack-cinder | 14:50 | |
| *** huanan_L has joined #openstack-cinder | 14:50 | |
| *** zhonghua has joined #openstack-cinder | 14:50 | |
| openstackgerrit | Paul Belanger proposed openstack/cinder: [DNF] Testing experimental-bindep-jobs https://review.openstack.org/281893 | 14:51 |
| scottda | OK, I'll craft a ML post with what I believe are the arguments and we can go from there. | 14:52 |
| bswartz | I think the nova guys have a strange stance on API backwards compatibility | 14:52 |
| bswartz | they (some of them at least) seem to believe that even if you have microversions, you still can't change anything in the APIs | 14:53 |
| *** zhonghua-lee has quit IRC | 14:53 | |
| bswartz | I believe that microversions are the mechanism that guarantees backwards compatibility, and it's safe to add/remove things from APIs in new microversions | 14:53 |
| *** huanan_M has quit IRC | 14:53 | |
| bswartz | I worry that nova is trying to obtain the worst of both worlds when it comes to API versioning | 14:54 |
| *** arecknag has quit IRC | 14:55 | |
| DuncanT | bswartz: I think it is safe if and only if you can continue to support all of the semantics of the old API... which is tricky and limiting | 14:55 |
| johnthetubaguy | bswartz: there are new arguments hotting up, but the sdague wrote up the principals of the idea here: https://dague.net/2015/06/05/the-nova-api-in-kilo-and-beyond-2/ | 14:56 |
| *** martyturner has quit IRC | 14:57 | |
| bswartz | well cinder has an unusually hard problem because not only do we want to version APIs, we want to completely rip out the attachment API | 14:57 |
| bswartz | johnthetubaguy: thx | 14:57 |
| *** tobe has quit IRC | 14:57 | |
| bswartz | DuncanT: I haven't thought hard enough about whether it's possible to emulate the "old" attachment API semantics on top of a new attachment design | 14:57 |
| *** cknight has joined #openstack-cinder | 14:58 | |
| *** diogogmt has quit IRC | 14:58 | |
| *** martyturner has joined #openstack-cinder | 14:59 | |
| *** belmoreira has quit IRC | 14:59 | |
| *** belmorei_ has joined #openstack-cinder | 14:59 | |
| DuncanT | bswartz: It's really, really difficult. The only clean way I can see to do it is to set a flag on the volume record whenever it is out of state 'available', and only let either the old or the new api affect the volume at a time, until it goes back to available | 14:59 |
| sheel | scottda: DuncanT: smcginnis: bswartz: some of the explainations about handling different microversions are kept here: http://specs.openstack.org/openstack/ironic-specs/specs/kilo-implemented/api-microversions.html | 14:59 |
| sheel | I think it has some details about what is being discussed above.. | 15:00 |
| smcginnis | sheel: Thanks! | 15:00 |
| *** mvk has quit IRC | 15:00 | |
| *** haomaiwang has quit IRC | 15:01 | |
| sheel | smcginnis: welcome.. | 15:01 |
| *** haomaiwang has joined #openstack-cinder | 15:01 | |
| *** markstur_ has joined #openstack-cinder | 15:02 | |
| *** dave-mccowan has joined #openstack-cinder | 15:02 | |
| *** rhagarty has joined #openstack-cinder | 15:03 | |
| *** markstur_ has left #openstack-cinder | 15:03 | |
| sheel | specifically Use Case 7B: New Client/New Ironic: Negotiated version (user-specified) | 15:03 |
| *** merooney has joined #openstack-cinder | 15:03 | |
| sheel | The user specifies a particular microversion (e.g. 1.15) that the client should use | 15:04 |
| sheel | The client makes a connection to Ironic, supplying 1.15 as the microversion | 15:04 |
| sheel | Ironic responds with a 406 Not Acceptable, along with the -Min- and -Max- headers that it can support (in this case 1.1 and 1.10) | 15:04 |
| sheel | The client reports this to the user and exits | 15:04 |
| DuncanT | That ironic page talks about defaulting high, which makes sense | 15:04 |
| DuncanT | You can only do that with a new endpoint though | 15:04 |
| scottda | That doc also has a use case : | 15:05 |
| scottda | https://www.irccloud.com/pastebin/GoX53xQq/ | 15:05 |
| scottda | This assumes the "Caveat Emptor" approach. If the client attempts to use microversion and the server does not support it, the client must figure this out and fail for the user. | 15:06 |
| sheel | yes 3B and 7B are somehow related to what was being discussed... | 15:06 |
| sheel | simply 406 if version is not supported by server.. | 15:07 |
| *** esker has joined #openstack-cinder | 15:07 | |
| *** esker has quit IRC | 15:07 | |
| *** esker has joined #openstack-cinder | 15:07 | |
| *** asselin__ has joined #openstack-cinder | 15:08 | |
| *** asselin_ has quit IRC | 15:10 | |
| scottda | Yes, but that is the debate: Put the logic in the server to protect against bad clients, or put the burden on the client to take responsibility when using microversions. | 15:11 |
| *** mylu has quit IRC | 15:12 | |
| sheel | scottda: yes, these use cases provide answer partially to same point i think, | 15:14 |
| sheel | actually it states shared responsibility by simply returning 406 in case client requested version which is not supported by server(using min max versions).. | 15:14 |
| *** archers has quit IRC | 15:14 | |
| *** lcurtis has joined #openstack-cinder | 15:14 | |
| sheel | In case 406 is returned, server will also send back the -Min- and -Max- headers that it can support so that client can decide how to proceed | 15:15 |
| sheel | please refer use case Use Case 5: New Client/New Ironic: Unsupported Ironic version for more details | 15:16 |
| scottda | sheel: I don't think 7b is the controversy, it is 3b | 15:16 |
| sheel | scottda: hmm.. | 15:17 |
| *** mylu has joined #openstack-cinder | 15:19 | |
| *** baumann has joined #openstack-cinder | 15:20 | |
| *** [1]Thelo has joined #openstack-cinder | 15:23 | |
| *** haomaiwang has quit IRC | 15:25 | |
| *** Thelo has quit IRC | 15:26 | |
| *** [1]Thelo is now known as Thelo | 15:26 | |
| *** lprice1 has joined #openstack-cinder | 15:29 | |
| *** bill_az has quit IRC | 15:30 | |
| *** lprice has quit IRC | 15:32 | |
| *** martyturner has quit IRC | 15:34 | |
| openstackgerrit | Béla Vancsics proposed openstack/cinder: Reduced the complexity of the send_cmd method (in ProphetStor) https://review.openstack.org/250517 | 15:36 |
| scottda | ML posting on microversions has been sent. Have at it. | 15:39 |
| smcginnis | scottda: Thanks! | 15:39 |
| scottda | sure. I reckon if we come to some resolution we can still get this in Mitaka, either with new /v3 or old /v2. The code is written either way. | 15:40 |
| *** tobe has joined #openstack-cinder | 15:40 | |
| smcginnis | scottda: Thanks for taking this on. I'm sure it's more than it seemed at first. | 15:42 |
| smcginnis | "Manila already did this. I can just copy their code." :) | 15:42 |
| scottda | haha...mc_nair pointed out I should just get the 'api-microversion' tattoo, since I'll be living with it forever. | 15:43 |
| smcginnis | scottda: You can get that when mc_nair gets his nested quota tattoo. | 15:44 |
| scottda | If you look at the liberty mid-cycle video, you can see hemnafk saying "someone needs to implement microversions" and then giving me the stare....so I blame him. | 15:44 |
| smcginnis | hehe | 15:44 |
| mc_nair | :) | 15:46 |
| *** haomaiwang has joined #openstack-cinder | 15:46 | |
| mc_nair | nah I'm just gonna get some Russian nesting dolls that I carry around with different quotas written on them | 15:47 |
| *** yangyapeng has quit IRC | 15:47 | |
| mc_nair | like all the kool kids are doing | 15:47 |
| smcginnis | mc_nair: Hah, nice! | 15:47 |
| sheel | :) | 15:49 |
| jordanP | I guys. I've come up with that interesting patch https://review.openstack.org/#/c/281753 for an intesting bug : Fix race condition in RemoteFS create_snapshot_online I would love some feedback. Yeah I know I submited that today, but I can"t wait :) | 15:50 |
| *** j_king has joined #openstack-cinder | 15:50 | |
| *** haomaiwang has quit IRC | 15:51 | |
| *** EinstCrazy has quit IRC | 15:51 | |
| *** bill_az has joined #openstack-cinder | 15:51 | |
| dulek | smcginnis, mc_nair: I don't like tattoos, but a car sticker saying "They see me rolling (upgrade)…" would probably cool. :D | 15:51 |
| *** zul has quit IRC | 15:53 | |
| *** zul has joined #openstack-cinder | 15:53 | |
| mc_nair | dulek: haha I like it. Not sure it'll have a big hit rate for people understanding it, but for that single person it lands with it'll be pretty epic... | 15:53 |
| scottda | I'm not sure what a good API tattoo would look like, but I've a feeling thing we had one. | 15:53 |
| mc_nair | A good API tattoo still looks like bad decisions | 15:55 |
| *** diogogmt has joined #openstack-cinder | 15:57 | |
| *** yangyapeng has joined #openstack-cinder | 15:59 | |
| *** krotscheck_dcm is now known as krotscheck | 16:00 | |
| *** ntpttr has joined #openstack-cinder | 16:00 | |
| scottda | fricken' phone. I meant to say that I suspected thingee had an API tattoo | 16:00 |
| *** timcl has quit IRC | 16:01 | |
| smcginnis | I wouldn't be surprised. | 16:01 |
| scottda | and also, we could use thingee 's opinion on the new endpoint for microversion debate. On the ML. Please. | 16:01 |
| *** raildo is now known as raildo-afk | 16:02 | |
| *** belmorei_ has quit IRC | 16:03 | |
| *** kvidvans has quit IRC | 16:03 | |
| *** salv-orl_ has joined #openstack-cinder | 16:03 | |
| *** belmoreira has joined #openstack-cinder | 16:03 | |
| *** zigo has quit IRC | 16:03 | |
| *** zigo has joined #openstack-cinder | 16:05 | |
| *** salv-orlando has quit IRC | 16:06 | |
| *** coolsvap|away has quit IRC | 16:06 | |
| mriedem | diablo_rojo: mc_nair: https://review.openstack.org/#/c/281926/ | 16:06 |
| mriedem | patrickeast: ^ per yesterday | 16:06 |
| mc_nair | mriedem: nice, should be useful for debugging that multipath issue | 16:09 |
| *** liverpooler has quit IRC | 16:11 | |
| *** liverpoo1er has quit IRC | 16:11 | |
| *** martyturner has joined #openstack-cinder | 16:11 | |
| *** jungleboyj has joined #openstack-cinder | 16:12 | |
| *** mylu has quit IRC | 16:14 | |
| *** garthb has joined #openstack-cinder | 16:15 | |
| *** nkrinner has quit IRC | 16:16 | |
| *** yangyapeng has quit IRC | 16:17 | |
| *** raildo-afk is now known as raildo | 16:17 | |
| *** garthb has quit IRC | 16:17 | |
| *** rcernin has quit IRC | 16:17 | |
| mc_nair | jordanP: is there a reason an oslo looping call couldn't be used instead of the while True there? | 16:18 |
| *** mylu has joined #openstack-cinder | 16:18 | |
| jordanP | mc_nair, I am not aware of any 'oslo looping call' ? What's that a new oslo-looping module ? | 16:19 |
| jordanP | that one has not been annonced on the ML :p | 16:19 |
| *** coolsvap|away has joined #openstack-cinder | 16:20 | |
| jordanP | mc_nair, that remotefs.py is not a master piece in term of programming... It could benefit from some refactoring anyway | 16:20 |
| *** mylu has quit IRC | 16:20 | |
| mc_nair | jordanP: haha - it's http://docs.openstack.org/developer/oslo.service/api/loopingcall.html | 16:21 |
| *** mylu has joined #openstack-cinder | 16:22 | |
| mc_nair | jordanP: not that I think it would really change the behavior, was just my initial thought looking at the code | 16:22 |
| *** bill_az has quit IRC | 16:23 | |
| jordanP | mc_nair, we want to sleep only if s['status'] == 'creating' so I am not sure we can use that oslo looping call that easilly | 16:23 |
| *** aorourke_ has joined #openstack-cinder | 16:23 | |
| mc_nair | jordanP: think you should be able to use the RetryDecorator... just throw some error that you're expecting to retry on for the creating case and some other errors that you wont retry on for the non-creating case | 16:25 |
| mc_nair | jordanP: if that still doesn't make sense I can take a closer look and try so I make sure I'm not just making stuff up :) | 16:26 |
| *** ildikov has quit IRC | 16:26 | |
| jordanP | mc_nair, I agree that we could do better here, but I'd like to avoid mixing refactoring and fixing a bug. (note: I am not being lazy, just that I don't have a lot of time left to spend on that issue) | 16:27 |
| *** ildikov has joined #openstack-cinder | 16:27 | |
| eharney | that fix is nice and backportable as is, it wouldn't be if it involved a big refactor too | 16:28 |
| jordanP | yep | 16:28 |
| eharney | fwiw i think that code predated use of loopingcalls in Cinder | 16:29 |
| *** daneyon has joined #openstack-cinder | 16:30 | |
| mc_nair | jordanP: certainly, I'm with ya. Was more trying to see if there was any particular reason for it (which eharney has cleared up). | 16:30 |
| *** daneyon__ has joined #openstack-cinder | 16:31 | |
| mc_nair | thanks for clearing it up for me | 16:31 |
| *** timcl has joined #openstack-cinder | 16:31 | |
| *** jdurgin1 has joined #openstack-cinder | 16:31 | |
| *** haomaiwang has joined #openstack-cinder | 16:32 | |
| *** laughter_ has joined #openstack-cinder | 16:32 | |
| *** laughte__ has joined #openstack-cinder | 16:34 | |
| *** daneyon_ has quit IRC | 16:34 | |
| *** belmoreira has quit IRC | 16:34 | |
| *** daneyon has quit IRC | 16:34 | |
| *** laughterwym has quit IRC | 16:35 | |
| *** dramakri has joined #openstack-cinder | 16:37 | |
| *** laughter_ has quit IRC | 16:37 | |
| mriedem | jungleboyj: where is this code? https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/ibm/xiv_ds8k.py#L36 out of tree driver? | 16:37 |
| *** laughte__ has quit IRC | 16:38 | |
| *** laughterwym has joined #openstack-cinder | 16:38 | |
| mriedem | oh awesome, you have to get it through ibm's fix central site? | 16:39 |
| *** jungleboyj has quit IRC | 16:39 | |
| *** laughterwym has quit IRC | 16:43 | |
| mc_nair | mriedem: yea, something like that. Had trouble getting that before (and just got .pyc code) | 16:46 |
| mriedem | heh | 16:47 |
| mriedem | b/c you know, pyc means you can't read the source | 16:47 |
| mriedem | anywho, bunch of emails into the thread before it gets to me, there is basically a NoneType exception in their closed source driver - thanks for thinking of me to resolve your issue guys! | 16:47 |
| *** hemnafk is now known as hemna | 16:48 | |
| *** xyang has quit IRC | 16:48 | |
| *** dims has joined #openstack-cinder | 16:50 | |
| *** dims_ has quit IRC | 16:51 | |
| *** jungleboyj has joined #openstack-cinder | 16:52 | |
| jgriffith | mriedem: maybe you can help me convince people why that approach is a BAD thing | 16:54 |
| mriedem | seems pretty awesome to me | 16:55 |
| mc_nair | mriedem: that sounds eerily similar to something that came to me a few days ago... got to the point of getting to the compiled Python code for that and saying it would be helpful to get the original code. I was thinking decompiling wouldn't get back method names and such but reading now it looks like it would for .pyc? | 16:56 |
| jgriffith | mriedem: ok, guess I will seek enlistees elsewhere :) | 16:56 |
| mriedem | mc_nair: sounds like you spent entirely too much time on someone else's problem | 16:56 |
| mc_nair | mriedem: yea, should've just not said anything and made it your problem then ;) | 16:57 |
| openstackgerrit | Alon Marx proposed openstack/cinder: Remove a vol in error state from a CG https://review.openstack.org/270460 | 16:57 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/python-brick-cinderclient-ext: Attach/detach features implementation https://review.openstack.org/263744 | 16:57 |
| mriedem | jgriffith: i was being sarcastic | 16:58 |
| jgriffith | mriedem: oh... in that case | 16:58 |
| jgriffith | :) | 16:58 |
| jgriffith | mriedem: it's a great way to not have your code reviewed :) | 16:59 |
| *** e0ne has quit IRC | 16:59 | |
| mriedem | sarcasm? | 16:59 |
| *** haypo has left #openstack-cinder | 16:59 | |
| mriedem | btw https://www.youtube.com/watch?v=ziH9St7ajuw | 17:00 |
| mriedem | classic bit | 17:00 |
| *** haomaiwang has quit IRC | 17:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 17:01 | |
| *** esker has quit IRC | 17:03 | |
| *** esker has joined #openstack-cinder | 17:03 | |
| *** apoorvad has joined #openstack-cinder | 17:07 | |
| *** rhagarty_ has joined #openstack-cinder | 17:08 | |
| *** rhagarty has quit IRC | 17:10 | |
| *** ericksonsantos has joined #openstack-cinder | 17:11 | |
| *** esker has quit IRC | 17:11 | |
| jgriffith | mriedem: haha..Nice | 17:12 |
| *** tobe has quit IRC | 17:13 | |
| *** mudassirlatif has joined #openstack-cinder | 17:14 | |
| *** daneyon has joined #openstack-cinder | 17:16 | |
| *** daneyon_ has joined #openstack-cinder | 17:17 | |
| *** daneyon__ has quit IRC | 17:19 | |
| ildikov | hemna: hey | 17:19 |
| hemna | ildikov, hey | 17:19 |
| ildikov | Just wanted to check in as the ML thread is getting slow and I'm not sure we got a consensus there | 17:20 |
| hemna | that's what I figured as well | 17:20 |
| hemna | :( | 17:21 |
| ildikov | :( | 17:21 |
| *** daneyon has quit IRC | 17:21 | |
| ildikov | I still like the idea of having the connector_info stored with the attachments in Cinder ;) | 17:21 |
| *** mylu has quit IRC | 17:21 | |
| openstackgerrit | Sheel Rana proposed openstack/python-cinderclient: Extra 'u' in output of cinder cli commands https://review.openstack.org/281475 | 17:22 |
| ildikov | ok, back to serious, I strongly believe that as Cinder handles attachments at the moment we cannot put all the administration to Nova | 17:22 |
| hemna | yes, it makes sense | 17:22 |
| hemna | but it's for force detach and split brain scenarios between nova and cinder | 17:22 |
| ildikov | *on Nova | 17:22 |
| hemna | it doesn't cover the case for determining if it's correct to call brick's disconnect_volume. | 17:22 |
| ildikov | why not? | 17:23 |
| hemna | 2 completely separate issues IMHO and people are confusing the two, by interchangeably discussing them both. | 17:23 |
| hemna | the connector info is the initiator information of the nova compute host | 17:23 |
| hemna | it has no target information at all | 17:23 |
| ildikov | ok, I mixed it up the last time then I think | 17:24 |
| hemna | there is a confusion of names and information | 17:24 |
| hemna | it's easy to get confused | 17:24 |
| ildikov | I was wondering whether we have any chance to store the target somehow | 17:25 |
| hemna | connector is the initiator side, nova compute initiator information | 17:25 |
| hemna | connection_info is what comes back from cinder's initialize_connection, which is the target information. | 17:25 |
| hemna | 2 different things, and 2 different purposes. | 17:25 |
| jgriffith | haha.. "Chris didn't actually show up" | 17:25 |
| hemna | I don't think it makes a lot of sense to store the connection_info | 17:25 |
| hemna | we can always ask Cinder (initialize_connection) for it. | 17:26 |
| ildikov | hemna: you mean connector=initiator and connector_info=target? | 17:26 |
| hemna | ildikov, correct | 17:26 |
| ildikov | uh, you really don't make the outsiders' life easy in any sense and/or extent... :) | 17:27 |
| *** leeantho has joined #openstack-cinder | 17:27 | |
| hemna | I didn't pick those names! :) | 17:27 |
| hemna | connection_info = target | 17:27 |
| hemna | just to be specific | 17:27 |
| ildikov | yeah, I know, it's always someone else's fault ;) | 17:27 |
| openstackgerrit | Sheel Rana proposed openstack/python-cinderclient: Extra 'u' in output of cinder cli commands https://review.openstack.org/281475 | 17:27 |
| ildikov | hemna: almost the same :) | 17:27 |
| hemna | it is! | 17:27 |
| *** krotscheck is now known as krotscheck_dr | 17:27 | |
| ildikov | is that correct that if the connection_info is different for two attachments than the connector will be different too? | 17:28 |
| jgriffith | mriedem: GREAT.. now I'll be watching Kids In The Hall clips all day! | 17:29 |
| hemna | ildikov, yes I believe so | 17:29 |
| ildikov | and also can the connector be different if the connection_info is the same? | 17:29 |
| hemna | the connection_info has the iqn/wwn and lun id (if any) of the target. | 17:29 |
| hemna | connector is always the same on the same n-cpu host. | 17:30 |
| ildikov | how do you mean always? | 17:32 |
| hemna | unless the compute host changes itself, it will always be the same information | 17:33 |
| hemna | cat /etc/iscsi/initiatorname.iscsi | 17:33 |
| hemna | that's in there | 17:33 |
| hemna | also any FC HBAs | 17:33 |
| hemna | its all of the initiator side information on the host itself | 17:33 |
| hemna | it 'never' changes | 17:34 |
| hemna | if it does, then there are other problems | 17:34 |
| ildikov | but if there are multiple targets there's still one initiator? | 17:34 |
| hemna | targets are irrelevant to the initiator information | 17:34 |
| hemna | completely separate information | 17:34 |
| ildikov | sorry for the dumb questions, I'm not really an expert of the area still :S :( | 17:34 |
| hemna | it's ok :) | 17:35 |
| ildikov | :) | 17:35 |
| openstackgerrit | Apoorva Deshpande proposed openstack/cinder: Tintri image cache cleanup https://review.openstack.org/268370 | 17:36 |
| ildikov | hemna: but when you attach a new volume to a host then a new initiator will be created for that new volume right? | 17:36 |
| *** rcernin has joined #openstack-cinder | 17:37 | |
| hemna | no | 17:37 |
| hemna | initiators aren't created | 17:37 |
| hemna | :) | 17:37 |
| hemna | that information is collected | 17:37 |
| hemna | (connector) and passed to cinder | 17:37 |
| ildikov | probably I'm missing the terms here :) | 17:37 |
| hemna | cinder's driver uses that initiator information to tell the backend array how/where to export a volume to. | 17:37 |
| hemna | then the driver collects the target information about the volume on the array, and puts that into the connection_info, and passes that back to Nova | 17:38 |
| hemna | nova uses the connection_info to connect to that target (iSCSI Session logins, etc) | 17:38 |
| hemna | then the volume shows up | 17:38 |
| hemna | and it's discovered and passed into the vm | 17:38 |
| ildikov | this is the Nova side log after disconnect_volume: http://logs.openstack.org/33/266633/2/check/gate-tempest-dsvm-full/8302217/logs/screen-n-cpu.txt.gz#_2016-01-23_12_25_14_939 | 17:41 |
| ildikov | which is I assume the cleanup in case of a regular detach | 17:42 |
| ildikov | so my question is/was that when we have multiple targets exported for the same volume in multiattach case does that mean multiple rounds of cleanup as well if the attachments are on the same host? | 17:43 |
| mriedem | jgriffith: it's close enough to the weekend that i think you can justify slacking off for the rest of the week | 17:46 |
| ildikov | mriedem: that youtube video made my day :) | 17:47 |
| dulek | Guys, I would love to get two more rolling upgrades related commits in Mitaka. Pretty simple ones: | 17:47 |
| dulek | https://review.openstack.org/#/c/279039/ - SIGHUP handling to reload RPC version pins cache. | 17:48 |
| dulek | https://review.openstack.org/#/c/263473/ - bugfix for a RPC version we've got in. | 17:48 |
| smcginnis | mriedem: No, he has repl to finish up. Then he can slack off. | 17:49 |
| smcginnis | :) | 17:49 |
| dulek | (okay, there will be third to follow probably - as scalable backups are getting merged right now) | 17:49 |
| *** SergeyLukjanov has left #openstack-cinder | 17:50 | |
| dulek | smcginnis: Whoa, that was quick, thanks. ;) | 17:51 |
| smcginnis | dulek: Good timing before I got distracted with other things. ;) | 17:51 |
| *** cknight has quit IRC | 17:53 | |
| *** timcl has quit IRC | 17:53 | |
| *** jdurgin1 has quit IRC | 17:58 | |
| ildikov | hemna: I assume I asked a too stupid question that you disappeared :D | 17:58 |
| *** mylu has joined #openstack-cinder | 17:59 | |
| *** haomaiwa_ has quit IRC | 18:01 | |
| *** haomaiwang has joined #openstack-cinder | 18:01 | |
| *** haomaiwang is now known as 16WAAAVR4 | 18:01 | |
| *** timcl has joined #openstack-cinder | 18:01 | |
| *** jordanP has quit IRC | 18:02 | |
| *** mriedem has quit IRC | 18:02 | |
| *** lpetrut has quit IRC | 18:02 | |
| *** mriedem has joined #openstack-cinder | 18:04 | |
| *** bardia has joined #openstack-cinder | 18:05 | |
| *** arch-nemesis has joined #openstack-cinder | 18:06 | |
| *** e0ne has joined #openstack-cinder | 18:07 | |
| *** cburgess has quit IRC | 18:07 | |
| *** cburgess has joined #openstack-cinder | 18:08 | |
| *** raildo is now known as raildo-afk | 18:10 | |
| *** e0ne has quit IRC | 18:16 | |
| *** mylu has quit IRC | 18:18 | |
| *** angela-s has joined #openstack-cinder | 18:18 | |
| *** raildo-afk is now known as raildo | 18:22 | |
| *** notmorgan has quit IRC | 18:22 | |
| *** fthiagogv_ has joined #openstack-cinder | 18:24 | |
| *** fthiagogv__ has joined #openstack-cinder | 18:26 | |
| *** porrua has quit IRC | 18:26 | |
| *** fthiagogv has quit IRC | 18:27 | |
| *** fthiagogv_ has quit IRC | 18:29 | |
| *** esker has joined #openstack-cinder | 18:29 | |
| *** 16WAAAVR4 has quit IRC | 18:30 | |
| *** e0ne has joined #openstack-cinder | 18:30 | |
| *** esker has quit IRC | 18:30 | |
| *** esker has joined #openstack-cinder | 18:31 | |
| *** vivekd has joined #openstack-cinder | 18:31 | |
| *** lcurtis has quit IRC | 18:34 | |
| *** eharney has quit IRC | 18:34 | |
| *** eharney has joined #openstack-cinder | 18:37 | |
| *** mvk has joined #openstack-cinder | 18:38 | |
| openstackgerrit | Vivek Dhayaal proposed openstack/cinder: Support HA in cinder backup service https://review.openstack.org/282002 | 18:40 |
| *** rlrossit has quit IRC | 18:41 | |
| *** bill_az has joined #openstack-cinder | 18:41 | |
| *** ChubYann has joined #openstack-cinder | 18:44 | |
| scottda | smcginnis: Is there a deadline for releasing the cinderclient | 18:46 |
| scottda | ? | 18:46 |
| hemna | ildikov, in the case of N targets for N attachments to the same compute host, that means N calls to brick's disconnect_volume. | 18:47 |
| ildikov | hemna: in this case the connection_info could be used to identify whether to call disconnect_volume or not right? | 18:49 |
| hemna | correct | 18:49 |
| hemna | that's my assertion | 18:49 |
| ildikov | hemna: and by storing it in Cinder that would reduce the roundtrips | 18:49 |
| hemna | if it's the same target exported on the array, the connection_info would be the same. | 18:49 |
| hemna | no need to store it on cinder | 18:49 |
| hemna | just call cinder's initialize_connection | 18:49 |
| hemna | it will return the connection_info | 18:49 |
| ildikov | but it's too many calls | 18:50 |
| hemna | afaik, each driver will either export a new target for every export or all will the a shared target | 18:50 |
| *** rlrossit_ has joined #openstack-cinder | 18:50 | |
| hemna | you won't have a mixed mode | 18:50 |
| hemna | so comparing 2 connection_info should be sufficient to determine shared or not shared target. | 18:50 |
| hemna | 2 calls to cinder is too many ? | 18:50 |
| hemna | ?! | 18:50 |
| ildikov | and also a bit confusing why someone tries to initialize the connection at detach time | 18:50 |
| hemna | it's only needed in the case of multiattach | 18:51 |
| ildikov | we already call Cinder once to get the attachments and it's already too much | 18:51 |
| hemna | and if the volume is multiattach enabled | 18:51 |
| hemna | and only if that volume is attached > 1 time on that same host | 18:51 |
| e0ne | scottda: http://releases.openstack.org/mitaka/schedule.html | 18:51 |
| scottda | e0ne: thanks | 18:51 |
| hemna | well, if you don't want to call cinder, then all bets are off | 18:51 |
| hemna | and I can't help | 18:51 |
| ildikov | we have to call out to Cinder to determine whether multiattach is enable or not... :) | 18:51 |
| hemna | I don't understand that logic at all | 18:52 |
| hemna | you have that information in the volume object already | 18:52 |
| hemna | that volume object that's already there in nova has all of the attachments | 18:52 |
| ildikov | I would like to be able to get all the info that's needed from the volume attachment info | 18:52 |
| *** dramakri has quit IRC | 18:52 | |
| hemna | it makes no sense for the attachments to store the connection_info | 18:52 |
| ildikov | why? | 18:53 |
| hemna | because it's 1) it will most likely get out of date (live migration) and 2) you can readily get the correct information from initialize_connection at any time. | 18:53 |
| hemna | there will always be some case that causes that information to get out of date | 18:53 |
| hemna | calling initialize_connection is the source of truth | 18:54 |
| hemna | always | 18:54 |
| ildikov | can we store any flag in the volume info to check which type of back end it's on? | 18:54 |
| hemna | making 2 calls to cinder is a very small price to pay in this very specific case | 18:54 |
| openstackgerrit | Merged openstack/cinder: Scaling backup service https://review.openstack.org/262395 | 18:54 |
| hemna | it won't happen on every non multiattach case | 18:54 |
| hemna | so I don't see what the problem is. | 18:54 |
| hemna | ugh | 18:54 |
| hemna | who is going to store that flag | 18:54 |
| hemna | and make sure it's correct ? | 18:54 |
| ildikov | you can check back the review comments on the Nova patches, I don't make it up | 18:54 |
| hemna | ok, well this is my $0.02 | 18:55 |
| ildikov | the volume has one back end it has to set once | 18:55 |
| hemna | initialize_connection will always be correct. | 18:55 |
| hemna | doing anything else is going to be a mess IMHO | 18:55 |
| ildikov | look, I'm 100% with you, I try to find solution to the already existing concerns I faced with during the past 2,5 months | 18:56 |
| ildikov | if it's the only solution we need to have the answers to all variants why they are bad | 18:57 |
| ildikov | so regarding the volume back end it can be added to the volume info when the volume is created | 18:57 |
| ildikov | like how the multiattach support depends on the back end today | 18:58 |
| ildikov | as you said we will not have mixed cases one back end has one behavior | 18:58 |
| openstackgerrit | Vivek Dhayaal proposed openstack/cinder: Support ZeroMQ messaging in cinder multibackend https://review.openstack.org/277113 | 18:59 |
| ildikov | regarding the connection_info if there is an API in Cinder to update it that can work also, but I accept that it's not the silver bullet either | 18:59 |
| hemna | so | 18:59 |
| hemna | if we go the flag route | 18:59 |
| hemna | each cinder backend would have to be updated to set that flag | 19:00 |
| hemna | shared_target=True | 19:00 |
| hemna | False | 19:00 |
| hemna | or whatever | 19:00 |
| *** ndipanov has quit IRC | 19:00 | |
| hemna | but Nova would still have to fetch that information from calling initialize_connection | 19:00 |
| hemna | and either store it in the bdm at attach time | 19:00 |
| hemna | or a detach time | 19:00 |
| ildikov | cannot that be added to the volume info? | 19:01 |
| hemna | I'm not sure that makes sense | 19:01 |
| hemna | as not every volume is multiattachable | 19:01 |
| ildikov | what's against it? | 19:01 |
| hemna | most of the time that flag is unused | 19:01 |
| hemna | to me, that's more overhead | 19:01 |
| ildikov | can a flag be optional? | 19:01 |
| hemna | than calling initialize_connection twice in the case of a multiattachable volume that has more than 1 volume attachment on a host, at detach time | 19:02 |
| hemna | vs. every call to get any volume, has now another flag | 19:02 |
| hemna | we don't have optional volume columns | 19:02 |
| ildikov | multiattach itself is unused most of the time as well | 19:02 |
| hemna | unless it's stored in metadata | 19:02 |
| hemna | which sux as well | 19:03 |
| hemna | ildikov, exactly my point | 19:03 |
| ildikov | but that's just a flag still :) | 19:03 |
| ildikov | I mean if someone does nto need it they will not use it | 19:03 |
| hemna | ok, well that's my $0.02 on it all | 19:04 |
| hemna | I'm kinda over it at this point | 19:04 |
| hemna | everyone wants to make this the most impossible as possible. | 19:04 |
| ildikov | I'm just trying to check all possibilities we might have | 19:05 |
| hemna | it's this kind of stuff that makes me stay away from Nova entirely. | 19:05 |
| hemna | bleh | 19:05 |
| ildikov | otherwise we need to have this discussion we have now in review comments during N, which will hurt even more IMHO | 19:06 |
| hemna | ildikov, do you have the review url handy ? | 19:06 |
| openstackgerrit | Patrick East proposed openstack/cinder: Allow for Pure drivers to verify HTTPS requests https://review.openstack.org/281625 | 19:07 |
| ildikov | hemna: the Nova patches you mean? | 19:07 |
| hemna | yuh | 19:07 |
| ildikov | hemna: https://review.openstack.org/#/q/topic:bp/volume-multi-attach | 19:07 |
| ildikov | a few patches are abandoned as I had to reorganize some stuff | 19:07 |
| hemna | which review specifically talks about this | 19:08 |
| ildikov | I also have to write up a spec for N... | 19:08 |
| ildikov | I don't remember exactly now which oone had the roundtrip comments :S | 19:08 |
| ildikov | I think it's better to have a cross-project session on the Summit to be on the same page as much as possible | 19:09 |
| *** andymaier has quit IRC | 19:11 | |
| jungleboyj | All ... Please be aware that our account for holding 3rd Party CI logs on SoftLayer has had issues. So, IBM's 3rd Party CI Logs are not currently accessible. The issue is being actively worked. | 19:12 |
| ildikov | hemna: probably this one has some as I worked on reducing the number of roundtrips here: https://review.openstack.org/#/c/193134/ | 19:12 |
| *** lpetrut has joined #openstack-cinder | 19:12 | |
| ildikov | hemna: and please don't hate me, I just want to have this done finally like you | 19:14 |
| *** akerr has quit IRC | 19:14 | |
| *** akerr has joined #openstack-cinder | 19:16 | |
| *** dmz has joined #openstack-cinder | 19:16 | |
| *** eharney has quit IRC | 19:16 | |
| hemna | ildikov, lol, it's ok I don't hate you | 19:17 |
| dmz | howdy y'all, i'm trying to create a volume from an image and keep getting the following error: Failed to copy image to volume No space left on device; no matter what size I set the volume to (even 2x the size of the image); any suggestoins? | 19:17 |
| hemna | ildikov, we need to see how to make this happen | 19:17 |
| hemna | there are just too many damn cooks in the kitchen that don't understand how to cook IMHO. | 19:17 |
| ildikov | hemna: yeah, this is why I'm annoying you now :) | 19:18 |
| hemna | not that I'm a good cook or anything... | 19:18 |
| bswartz | dmz: did you check "image_conversion_dir" in cinder.conf? | 19:18 |
| hemna | I can boil water | 19:18 |
| patrickeast | dmz: do you have a stack trace for it in the cinder-volume log? there are a few places it could be coming from | 19:18 |
| ildikov | hemna: haha :) | 19:18 |
| ildikov | hemna: I can do more, but you still kill all my ideas here :) | 19:19 |
| hemna | :( | 19:19 |
| dmz | https://gist.github.com/dmz006/2488fdf0293786bb169c | 19:20 |
| dmz | i'm checking conversion dir now | 19:20 |
| bswartz | dmz: you need to have enough free space (2x the uncompresed image size) in the filesystem that that directory points to | 19:21 |
| dmz | the image isn't compressed, it's a raw image taken (dd) from a disk | 19:21 |
| dmz | if the image_conversion_dir is commented out where would it default to? | 19:21 |
| bswartz | might be /tmp | 19:22 |
| *** jwcroppe has quit IRC | 19:22 | |
| bswartz | might be /var/lib/cinder/conversions | 19:22 |
| dmz | that might explain it; tmp is only 5 gig | 19:22 |
| *** jwcroppe has joined #openstack-cinder | 19:22 | |
| bswartz | in any case, you should set it, so you know where the temp file are going | 19:22 |
| dmz | and var is also limited; let me try changing that to somewhere else; thanks! | 19:22 |
| *** bkumar has joined #openstack-cinder | 19:25 | |
| *** jwcroppe has quit IRC | 19:26 | |
| *** flip214 has quit IRC | 19:28 | |
| *** aorourke_ has quit IRC | 19:28 | |
| *** aorourke_ has joined #openstack-cinder | 19:29 | |
| *** cknight has joined #openstack-cinder | 19:31 | |
| *** Lee1092 has quit IRC | 19:32 | |
| *** haomaiwang has joined #openstack-cinder | 19:32 | |
| *** eharney has joined #openstack-cinder | 19:33 | |
| *** jwcroppe has joined #openstack-cinder | 19:34 | |
| *** flip214 has joined #openstack-cinder | 19:35 | |
| *** haomaiwang has quit IRC | 19:37 | |
| *** jkraj has quit IRC | 19:38 | |
| *** lpetrut has quit IRC | 19:42 | |
| *** lpetrut has joined #openstack-cinder | 19:46 | |
| *** angela-s has quit IRC | 19:55 | |
| *** rajinir has quit IRC | 19:55 | |
| *** rcernin has quit IRC | 19:55 | |
| *** hemna is now known as hemnafk | 19:55 | |
| *** ociuhandu has quit IRC | 19:58 | |
| *** krtaylor has quit IRC | 19:59 | |
| *** rlrossit_ has quit IRC | 20:00 | |
| *** zhonghua-lee has joined #openstack-cinder | 20:07 | |
| *** annasort_ has joined #openstack-cinder | 20:07 | |
| *** markvoelker_ has joined #openstack-cinder | 20:07 | |
| *** flip214_ has joined #openstack-cinder | 20:09 | |
| *** krtaylor has joined #openstack-cinder | 20:11 | |
| *** guitarza1 has joined #openstack-cinder | 20:11 | |
| *** zmd has joined #openstack-cinder | 20:11 | |
| *** annasort has quit IRC | 20:12 | |
| *** john5223 has quit IRC | 20:12 | |
| *** flip214 has quit IRC | 20:12 | |
| *** markvoelker has quit IRC | 20:12 | |
| *** bill_az has quit IRC | 20:12 | |
| *** zhonghua has quit IRC | 20:12 | |
| *** guitarzan has quit IRC | 20:12 | |
| *** ircuser-1 has quit IRC | 20:12 | |
| *** dmz has quit IRC | 20:12 | |
| *** stevemar has quit IRC | 20:12 | |
| *** annasort_ is now known as annasort | 20:12 | |
| *** vivekd has quit IRC | 20:12 | |
| *** stevemar has joined #openstack-cinder | 20:13 | |
| *** ircuser-1_ has joined #openstack-cinder | 20:13 | |
| *** bkumar has quit IRC | 20:14 | |
| *** boris-42 has quit IRC | 20:16 | |
| openstackgerrit | Chuck Fouts proposed openstack/cinder: Support for iSCSI CHAP Uni-directional Auth https://review.openstack.org/251925 | 20:16 |
| *** boris-42 has joined #openstack-cinder | 20:18 | |
| *** boris-42 has quit IRC | 20:24 | |
| *** ociuhandu has joined #openstack-cinder | 20:31 | |
| *** angela-s has joined #openstack-cinder | 20:38 | |
| *** e0ne has quit IRC | 20:45 | |
| *** e0ne has joined #openstack-cinder | 20:45 | |
| *** e0ne has quit IRC | 20:46 | |
| *** porrua has joined #openstack-cinder | 20:57 | |
| *** esp has joined #openstack-cinder | 20:59 | |
| *** apoorvad has quit IRC | 20:59 | |
| *** rlrossit has joined #openstack-cinder | 20:59 | |
| *** cdelatte has quit IRC | 21:05 | |
| *** esp has quit IRC | 21:05 | |
| *** raildo is now known as raildo-afk | 21:06 | |
| *** sheel has quit IRC | 21:07 | |
| *** jwcroppe has quit IRC | 21:09 | |
| *** esker has quit IRC | 21:13 | |
| *** merooney has quit IRC | 21:15 | |
| *** aorourke__ has joined #openstack-cinder | 21:18 | |
| *** aorourke_ has quit IRC | 21:18 | |
| *** stupidnic has joined #openstack-cinder | 21:22 | |
| *** jwcroppe has joined #openstack-cinder | 21:25 | |
| stupidnic | I seem to be having an issue with Cinder using the Upload to Image function. I have some metadata set on a volume and when it goes transfer the volume to the image, I get an error about "is not of type u'string' | 21:26 |
| *** martyturner has quit IRC | 21:29 | |
| *** martyturner has joined #openstack-cinder | 21:30 | |
| *** diablo_rojo has quit IRC | 21:31 | |
| *** cdelatte has joined #openstack-cinder | 21:31 | |
| scottda | Does the os-brick release that just went out mean no more os-brick release for mitaka? | 21:32 |
| scottda | And am I right that change from rootwrap to privsep is off the table for Mitaka? | 21:33 |
| scottda | hemnafk: seems AFK | 21:33 |
| patrickeast | scottda: that was my interpretation, but not 100% sure | 21:33 |
| *** jungleboyj has quit IRC | 21:34 | |
| scottda | patrickeast: Thanks. We're talking about this in nova meeting ATM so I'm wanting to be sure. | 21:34 |
| *** jgregor has quit IRC | 21:37 | |
| *** jgregor has joined #openstack-cinder | 21:37 | |
| *** timcl has quit IRC | 21:37 | |
| *** jgregor has quit IRC | 21:38 | |
| *** akerr has quit IRC | 21:38 | |
| *** krtaylor has quit IRC | 21:38 | |
| *** e0ne has joined #openstack-cinder | 21:38 | |
| openstackgerrit | Ryan McNair proposed openstack/cinder: WIP Re-enable -1 child limits https://review.openstack.org/282068 | 21:39 |
| *** ociuhandu has quit IRC | 21:41 | |
| scottda | So, Nova folks seem to think we are doing another release of os-brick, and it must have the privsep change. | 21:41 |
| scottda | Which may be true. | 21:41 |
| scottda | So I'll stop spreading rumours and wait for something definitive from some definitive-type person. | 21:42 |
| smcginnis | scottda: Nope, no privsep for Mitaka. | 21:45 |
| scottda | please state that now in #openstack-meeting | 21:45 |
| scottda | smcginnis: They are of a different opinion. | 21:45 |
| *** krtaylor has joined #openstack-cinder | 21:51 | |
| *** jgregor has joined #openstack-cinder | 21:51 | |
| *** melwitt has joined #openstack-cinder | 21:54 | |
| *** merooney has joined #openstack-cinder | 21:54 | |
| *** mikal has joined #openstack-cinder | 21:54 | |
| *** chlong has quit IRC | 21:57 | |
| *** chlong_ has joined #openstack-cinder | 21:58 | |
| *** martyturner has quit IRC | 21:58 | |
| *** martyturner has joined #openstack-cinder | 21:59 | |
| *** apoorvad has joined #openstack-cinder | 21:59 | |
| *** cknight has quit IRC | 21:59 | |
| *** krtaylor has quit IRC | 22:02 | |
| *** mudassirlatif_ has joined #openstack-cinder | 22:02 | |
| *** salv-orlando has joined #openstack-cinder | 22:03 | |
| *** martyturner has quit IRC | 22:03 | |
| *** mudassirlatif has quit IRC | 22:04 | |
| *** mudassirlatif_ is now known as mudassirlatif | 22:04 | |
| *** apoorvad has quit IRC | 22:04 | |
| *** hemnafk is now known as hemna | 22:05 | |
| hemna | back | 22:05 |
| hemna | sorry, lots of things being juggled | 22:05 |
| *** salv-orl_ has quit IRC | 22:05 | |
| *** jwcroppe has quit IRC | 22:05 | |
| smcginnis | hemna: No change in privsep, right? | 22:06 |
| hemna | smcginnis, correct | 22:06 |
| hemna | last time I tried it still hung nova | 22:06 |
| smcginnis | Just want to make sure I'm not taking a hard stance on something I'm going to have to back pedal on. ;) | 22:06 |
| hemna | :) | 22:06 |
| smcginnis | OK, that was my understanding. We should be fine I think. | 22:06 |
| hemna | yah you are good | 22:06 |
| *** martyturner has joined #openstack-cinder | 22:07 | |
| smcginnis | I think there were only two rootwrap changes so far that don't have corresponding changes in nova, so I don't think this should be an issue. | 22:07 |
| smcginnis | Other than not being able to get rid of rootwrap as soon as some would like. | 22:07 |
| *** knikolla has quit IRC | 22:09 | |
| scottda | Thanks guys. | 22:09 |
| *** dustins has quit IRC | 22:09 | |
| openstackgerrit | Eric Harney proposed openstack/python-cinderclient: Add extra_specs_list test https://review.openstack.org/282075 | 22:11 |
| *** merooeny_ has joined #openstack-cinder | 22:11 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 https://review.openstack.org/275797 | 22:13 |
| openstackgerrit | Yucong Feng proposed openstack/cinder: Remove extra get_active_zoneset query from Brocade CLI https://review.openstack.org/266044 | 22:13 |
| smcginnis | jgriffith: Happy happy joy joy | 22:13 |
| jgriffith | smcginnis: haha... the rebase made a real mess. Still not completely fixed, but wanted to get it pushed back up before I trash it again like last night :) | 22:14 |
| *** merooney has quit IRC | 22:14 | |
| smcginnis | jgriffith: Hah, play it safe. ;) | 22:15 |
| jgriffith | :) | 22:15 |
| *** krtaylor has joined #openstack-cinder | 22:15 | |
| bswartz | did the cheesecake moniker get dropped? :-( | 22:16 |
| *** eharney has quit IRC | 22:16 | |
| smcginnis | bswartz: The cool kids still use it. ;) | 22:16 |
| smcginnis | jgriffith: services.py L70, should that be root.set() or are you missing adding elem to root? | 22:17 |
| *** merooney has joined #openstack-cinder | 22:20 | |
| *** mylu has joined #openstack-cinder | 22:21 | |
| *** apoorvad has joined #openstack-cinder | 22:21 | |
| *** porrua has quit IRC | 22:22 | |
| *** merooeny_ has quit IRC | 22:22 | |
| *** mriedem has quit IRC | 22:24 | |
| *** arch-nemesis has quit IRC | 22:25 | |
| *** dave-mccowan has quit IRC | 22:26 | |
| *** JoseMello has quit IRC | 22:28 | |
| *** jungleboyj has joined #openstack-cinder | 22:30 | |
| jgriffith | smcginnis: I don't even know any more :) | 22:30 |
| openstackgerrit | Yucong Feng proposed openstack/cinder: Remove extra get_active_zoneset query from Brocade CLI https://review.openstack.org/266044 | 22:30 |
| jgriffith | smcginnis: hehe.. yup | 22:32 |
| Swanson | jgriffith, your patch has been in the queue for 13 minutes without a pep8 failure. This might be a record. | 22:32 |
| jgriffith | haha... just give it a moment | 22:32 |
| jgriffith | Swanson: smcginnis just pointed them out | 22:33 |
| *** mylu has quit IRC | 22:33 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 https://review.openstack.org/275797 | 22:33 |
| jgriffith | ok.. I *think* I'm back to where I was prior to rebase. Please don't merge any other db and rpc migrations :) | 22:34 |
| *** cknight has joined #openstack-cinder | 22:34 | |
| *** jgregor has quit IRC | 22:35 | |
| Swanson | Fully featured at this point? Just need to make your way past the smcginnis and patrickeast types and we're all mergelicious? | 22:36 |
| patrickeast | haha | 22:36 |
| jgriffith | Swanson: I think we're pretty close. Couple more API calls and the silly periodic | 22:36 |
| *** tpsilva has quit IRC | 22:36 | |
| jgriffith | Swanson: my goal is merge by end of day tomorrow :) | 22:37 |
| patrickeast | the only thing that would block me from pushing it through is that the failover rest api call seems borked | 22:37 |
| Swanson | jgriffith, excellent! | 22:37 |
| jgriffith | patrickeast: yeah... I haven't touched that yet :) | 22:37 |
| patrickeast | jgriffith: saving the best part for last! | 22:37 |
| jgriffith | patrickeast: sorry, I should've explained the only thing I messed with was freeze/thaw | 22:37 |
| jgriffith | patrickeast: *easiest* for last :) | 22:37 |
| patrickeast | jgriffith: no worries, i realized that after looking at it to figure out how to test it | 22:37 |
| *** mylu has joined #openstack-cinder | 22:39 | |
| openstackgerrit | Angus Lees proposed openstack/os-brick: Trivial rootwrap -> privsep replacement https://review.openstack.org/277224 | 22:40 |
| *** ociuhandu has joined #openstack-cinder | 22:41 | |
| *** cknight1 has joined #openstack-cinder | 22:42 | |
| *** mylu has quit IRC | 22:44 | |
| *** cknight has quit IRC | 22:44 | |
| *** mylu has joined #openstack-cinder | 22:45 | |
| *** ChubYann has quit IRC | 22:47 | |
| *** lpetrut has quit IRC | 22:48 | |
| *** edmondsw has quit IRC | 22:49 | |
| *** thurloat has joined #openstack-cinder | 22:50 | |
| mc_nair | woot woot - thanks for the workflow smcginnis! | 22:50 |
| jungleboyj | mc_nair: First quota patch? | 22:50 |
| mc_nair | jungleboyj: yea, the one to split out the NestedQuota support | 22:51 |
| mc_nair | best news about it is it can be turned off now :) | 22:51 |
| jungleboyj | mc_nair: Awesome! | 22:51 |
| *** aorourke__ has quit IRC | 22:52 | |
| *** aorourke_ has joined #openstack-cinder | 22:52 | |
| mc_nair | So now I put up a preview of re-enabling the -1 limits in child quotas here (https://review.openstack.org/#/c/282068/). But I'm worried about the race-conditions that are definitely present in that patch | 22:52 |
| mc_nair | trying to figure out how to fix those in an efficient way where we don't slow volume creates down or things like that. I'm a bit stumped on best way to do this, so I'm actively soliciting ideas if anyone has ways to do this ^ better | 22:54 |
| jungleboyj | mc_nair: I am assuming that the existing locking code for volume creation doesn't help? | 22:54 |
| mc_nair | smcginnis, jgriffith - if you have any thoughts on the general approach ^^ lemme know, I'm hungry for feedback and improvements on it. | 22:55 |
| *** martyturner has quit IRC | 22:55 | |
| mc_nair | or DuncanT - not sure if you're around, but you always seems to be full of feedback :) | 22:55 |
| mc_nair | jungleboyj: lemme take a lock at what locks we have there currently. I am just worried if I start adding locks I'm going to end up grinding things to a halt (but I don't know if that's valid) | 22:56 |
| mc_nair | *look | 22:57 |
| jungleboyj | mc_nair: Nice Freudian slip. :-) | 22:57 |
| *** rlrossit has quit IRC | 22:57 | |
| jungleboyj | That would be a place to start. Agree that adding locks could cause performance concerns. | 22:58 |
| *** ChubYann has joined #openstack-cinder | 22:58 | |
| *** cdelatte has quit IRC | 22:59 | |
| *** baumann has quit IRC | 23:00 | |
| *** ChubYann has quit IRC | 23:01 | |
| *** mudassirlatif has quit IRC | 23:01 | |
| *** cknight1 has quit IRC | 23:01 | |
| *** xyang1 has quit IRC | 23:01 | |
| *** e0ne has quit IRC | 23:06 | |
| *** vmorris has joined #openstack-cinder | 23:06 | |
| vmorris | anyone here have experience with setting up SMI-S provider in linux for connecting cinder to EMC VMAX Symmetrix Array? | 23:09 |
| jgriffith | SMI-S PIIM | 23:09 |
| vmorris | when i run the TestSmiProvider and display version (dv), I get Error: The target namespace does not exist. (Invalid namespace root/emc) | 23:10 |
| *** cknight has joined #openstack-cinder | 23:11 | |
| mc_nair | jungleboyj: https://github.com/openstack/cinder/blob/master/cinder/quota.py#L392-L399. So currently, we do the quota reserve and then will roll things back if we're unable to complete the request. At a minimum I think we'll want to add the same quota-reserve for allocated (we currently only do it for in_use), that way we can rollback stuff on failure | 23:11 |
| vmorris | i have the 6 gatekeeper LUNS from the storage array visible to the linux SMI-S host | 23:12 |
| mc_nair | jungleboyj: it's possible pushing the logic further down into the db's quota_reserve, and do the reserving up the chain it could be alright. Still unsure though :/ | 23:12 |
| mc_nair | seems like it'd be moving in the right direction | 23:12 |
| *** gouthamr has quit IRC | 23:14 | |
| *** ChubYann has joined #openstack-cinder | 23:15 | |
| jungleboyj | mc_nair: If there is one spot where we can hit it for all cases that would be better. I need to drop off here. Will try to look at this a little more later and we can chat tomorrow. | 23:15 |
| *** jungleboyj has quit IRC | 23:20 | |
| *** merooney has quit IRC | 23:20 | |
| *** jamielennox is now known as jamielennox|away | 23:20 | |
| *** mudassirlatif has joined #openstack-cinder | 23:21 | |
| *** cknight has quit IRC | 23:22 | |
| *** jwcroppe has joined #openstack-cinder | 23:23 | |
| *** ChubYann has quit IRC | 23:25 | |
| *** tobe has joined #openstack-cinder | 23:28 | |
| *** Suyash has joined #openstack-cinder | 23:29 | |
| *** cheneydc has joined #openstack-cinder | 23:33 | |
| *** tobe has quit IRC | 23:35 | |
| *** dims_ has joined #openstack-cinder | 23:36 | |
| *** dims has quit IRC | 23:38 | |
| *** cheneydc has quit IRC | 23:38 | |
| *** dave-mccowan has joined #openstack-cinder | 23:41 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Operations and timeout issues https://review.openstack.org/272760 | 23:42 |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - SnapVX and other snapshot improvements https://review.openstack.org/279881 | 23:43 |
| *** openstackgerrit has quit IRC | 23:47 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:47 | |
| *** openstackgerrit_ has joined #openstack-cinder | 23:48 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:48 | |
| *** tobe has joined #openstack-cinder | 23:49 | |
| *** openstackgerrit_ has joined #openstack-cinder | 23:49 | |
| *** yhayashi has joined #openstack-cinder | 23:52 | |
| *** chlong_ has quit IRC | 23:52 | |
| *** mylu has quit IRC | 23:55 | |
| *** openstackgerrit_ has quit IRC | 23:55 | |
| *** openstackgerrit_ has joined #openstack-cinder | 23:57 | |
| *** sgotliv has quit IRC | 23:57 | |
| *** smoriya_ has joined #openstack-cinder | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!