*** vmorris has quit IRC | 00:00 | |
DuncanT | mc_nair: It's 2am for me now, but I'll take a look at a more sensible hour | 00:02 |
---|---|---|
openstackgerrit | Merged openstack/os-brick: Include multipath -ll output in failed to parse warning https://review.openstack.org/281926 | 00:03 |
*** tobe has quit IRC | 00:06 | |
*** sdague has quit IRC | 00:06 | |
openstackgerrit | Kurt Martin proposed openstack/cinder: 3PAR get host by WWN now handles mixed cases https://review.openstack.org/281552 | 00:10 |
*** Fdaisuke has joined #openstack-cinder | 00:12 | |
*** suhani has joined #openstack-cinder | 00:12 | |
*** suhani has quit IRC | 00:13 | |
*** mriedem has joined #openstack-cinder | 00:13 | |
mc_nair | DuncanT: ah that'd be awesome :) I'm going to pop on later at a less sensible hour for me, so we can sync up then | 00:13 |
*** suhani has joined #openstack-cinder | 00:13 | |
*** mylu has joined #openstack-cinder | 00:13 | |
*** Abhijith has joined #openstack-cinder | 00:15 | |
*** Abhijith has quit IRC | 00:16 | |
*** suhani has quit IRC | 00:16 | |
*** Abhijith has joined #openstack-cinder | 00:16 | |
*** Suhani has joined #openstack-cinder | 00:16 | |
Suhani | hi | 00:19 |
*** Suhani has quit IRC | 00:19 | |
Abhijith | Hey guys | 00:19 |
*** Suhani has joined #openstack-cinder | 00:19 | |
Abhijith | anyone here? | 00:19 |
*** mylu has quit IRC | 00:19 | |
Abhijith | I have some queries regarding contributing a new cinder driver | 00:19 |
hemna | Abhijith, hey | 00:20 |
Swanson | hello | 00:20 |
*** diogogmt has quit IRC | 00:21 | |
Abhijith | just to give you guys some background info.. I work for a company called Hedvig and we've developed a cinder driver and done all the testing at our end.. | 00:21 |
*** mylu has joined #openstack-cinder | 00:21 | |
hemna | sweet | 00:21 |
Abhijith | we now want to contribute the driver to the openstack release | 00:21 |
hemna | coolio | 00:21 |
Abhijith | I found out that the deadline for contributing a driver is already past for the Mitaka release | 00:21 |
hemna | Abhijith, https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver | 00:21 |
openstackgerrit | Merged openstack/cinder: Rtstool sets wrong exception message on save https://review.openstack.org/281821 | 00:21 |
hemna | yah we are already past the Mitaka deadline for new drivers | 00:21 |
Abhijith | so here's my question - is it possible to contribute a driver to the older releases of openstack? | 00:22 |
Swanson | Mitaka 1, right? | 00:22 |
hemna | but there is no reason why you can't submit the patch and work on getting CI up and running | 00:22 |
patrickeast | its a good time to start on getting your CI system ready (if you don't have one) to get it in the N release | 00:22 |
Swanson | You can't get a new driver into an old release. | 00:22 |
hemna | Abhijith, no, they won't accept new code into already released versions | 00:22 |
*** mylu has quit IRC | 00:22 | |
*** mylu has joined #openstack-cinder | 00:22 | |
Abhijith | okay, thanks.. | 00:22 |
hemna | Abhijith, read that wiki url I just gave you. that'll give you a good place to start | 00:23 |
Abhijith | is the CI setup a prerequisite for posting a review? or can I post the review for the cinder driver and work on the CI setup in parallel? | 00:23 |
hemna | Abhijith, it's a prerequisite to getting the code to land. | 00:23 |
hemna | Abhijith, you can submit a review any time. | 00:23 |
patrickeast | you can do them in parallel, but i guarantee the ci setup will end up blocking the review | 00:23 |
patrickeast | it takes much more time/effort | 00:23 |
Swanson | It will not merge until the CI is in place. | 00:24 |
Abhijith | @patrickeast, alright, that makes sense | 00:24 |
kmartin | patrickeast, CI can be setup in day :) | 00:24 |
patrickeast | kmartin: well, yea, if you already know how it works | 00:24 |
hemna | lolz | 00:24 |
hemna | Abhijith, talk to this guy about it asselin | 00:24 |
openstackgerrit | Merged openstack/cinder: Roll back reservations quota in RPC if necessary https://review.openstack.org/263473 | 00:24 |
Abhijith | TBH, we are having some troubles setting up the CI :) | 00:25 |
Abhijith | so it might take more than a day for us | 00:25 |
patrickeast | Abhijith: haha, don't sweat it, unfortunately they are a huge pain to setup | 00:25 |
Swanson | Abhijith, if you only have some trouble you're doing a great job. | 00:25 |
Abhijith | to put it politely, some trouble :) | 00:26 |
Abhijith | I think I took far less time to develop the cinder driver | 00:26 |
patrickeast | Abhijith: if you haven't already I recommend attending some of the thirdparty meetings https://wiki.openstack.org/wiki/Meetings/ThirdParty they are a good resource for working through issues | 00:26 |
kmartin | Abhijith, if your using common CI, many in here and openstack-infra can help | 00:26 |
patrickeast | and lots of us have gone through it so we can probably help | 00:26 |
*** mylu has quit IRC | 00:28 | |
Abhijith | okay cool.. thanks guys.. | 00:28 |
Abhijith | I have been following these 2 links to setup CI | 00:28 |
Abhijith | http://docs.openstack.org/infra/system-config/third_party.html#requesting-a-service-account http://www.joinfu.com/2014/02/setting-up-an-external-openstack-testing-system/ | 00:28 |
Abhijith | are these the right links to follow or do you guys recommend any other resources to setup CI? | 00:29 |
patrickeast | Abhijith: ehh be careful with the joinfu one, its very out of date | 00:29 |
asselin | Abhijith, http://docs.openstack.org/infra/openstackci/ | 00:30 |
patrickeast | Abhijith: the concepts and info about configuration for some of the stuff like zuul are still ok but thats about it | 00:30 |
hemna | https://specs.openstack.org/openstack-infra/infra-specs/specs/openstackci.html | 00:30 |
hemna | I guess that's the original spec | 00:30 |
bardia | Abhijith, try this: http://docs.openstack.org/infra/openstackci/ | 00:31 |
bardia | I setup our CI using the guide above. asselin and the infra team put it together | 00:31 |
asselin | Abhijith, the other links are good background information, but use use it for more than that. http://docs.openstack.org/infra/openstackci/ is the 'official' new source that's being actively maintained. | 00:31 |
*** salv-orlando has quit IRC | 00:32 | |
bardia | I can vouch that it works :) | 00:32 |
*** jamielennox|away is now known as jamielennox | 00:33 | |
Abhijith | okay cool.. let me give it a shot then.. | 00:34 |
Abhijith | if I run into any issues, I'll come back here and post my questions or join the next thridparty meeting | 00:34 |
Abhijith | thanks for responding guys.. this was really helpful | 00:34 |
*** mylu has joined #openstack-cinder | 00:36 | |
*** laughterwym has joined #openstack-cinder | 00:39 | |
*** laughterwym has quit IRC | 00:39 | |
*** laughterwym has joined #openstack-cinder | 00:40 | |
mc_nair | jgriffith: you still around? I've had some time to digest your comments on https://review.openstack.org/#/c/278648/ more | 00:44 |
*** cknight has joined #openstack-cinder | 00:47 | |
*** mylu has quit IRC | 00:49 | |
*** cknight1 has joined #openstack-cinder | 00:49 | |
*** qeelee has joined #openstack-cinder | 00:51 | |
*** cknight has quit IRC | 00:52 | |
*** IlyaG has joined #openstack-cinder | 00:59 | |
*** yangyapeng has joined #openstack-cinder | 01:03 | |
*** tobe has joined #openstack-cinder | 01:04 | |
*** angela-s has quit IRC | 01:05 | |
*** JoseMello has joined #openstack-cinder | 01:06 | |
*** yangyapeng has quit IRC | 01:07 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: Manage volume fails due to lower array version https://review.openstack.org/281050 | 01:10 |
*** IlyaG has quit IRC | 01:11 | |
*** ntpttr has quit IRC | 01:12 | |
*** IlyaG has joined #openstack-cinder | 01:16 | |
*** IlyaG has quit IRC | 01:16 | |
*** Suyash has quit IRC | 01:17 | |
*** diogogmt has joined #openstack-cinder | 01:18 | |
lixiaoy1 | dulek: You are welcome to rework the patch https://review.openstack.org/#/c/269412 | 01:19 |
*** davechen has joined #openstack-cinder | 01:22 | |
*** jroll has quit IRC | 01:22 | |
*** mylu has joined #openstack-cinder | 01:23 | |
*** jroll has joined #openstack-cinder | 01:24 | |
*** mylu has quit IRC | 01:26 | |
*** Thelo has quit IRC | 01:26 | |
*** yangyapeng has joined #openstack-cinder | 01:27 | |
*** leeantho has quit IRC | 01:28 | |
*** EinstCrazy has joined #openstack-cinder | 01:28 | |
*** laughterwym has quit IRC | 01:29 | |
*** Thelo has joined #openstack-cinder | 01:29 | |
*** laughterwym has joined #openstack-cinder | 01:29 | |
*** lprice1 has quit IRC | 01:29 | |
*** laughterwym has quit IRC | 01:30 | |
*** laughterwym has joined #openstack-cinder | 01:30 | |
*** mylu has joined #openstack-cinder | 01:31 | |
*** yangyape_ has joined #openstack-cinder | 01:31 | |
*** EinstCrazy has quit IRC | 01:32 | |
*** yangyap__ has joined #openstack-cinder | 01:33 | |
*** mylu has quit IRC | 01:33 | |
*** yangyapeng has quit IRC | 01:34 | |
*** EinstCrazy has joined #openstack-cinder | 01:35 | |
*** yangyape_ has quit IRC | 01:36 | |
*** baojg has joined #openstack-cinder | 01:48 | |
lixiaoy1 | hemna: ping? May I talk to you about your comments in the patch https://review.openstack.org/#/c/280588/ add sheepdog support in os-brick? | 01:48 |
*** cheneydc has joined #openstack-cinder | 01:51 | |
*** mudassirlatif has quit IRC | 01:53 | |
*** chlong_ has joined #openstack-cinder | 01:56 | |
*** IlyaG has joined #openstack-cinder | 01:56 | |
*** tobe has quit IRC | 01:56 | |
*** laughterwym has quit IRC | 01:57 | |
*** laughterwym has joined #openstack-cinder | 01:57 | |
*** IlyaG has quit IRC | 02:00 | |
*** jamielennox is now known as jamielennox|away | 02:02 | |
*** lprice has joined #openstack-cinder | 02:02 | |
*** laughterwym has quit IRC | 02:02 | |
*** winston-d_ has joined #openstack-cinder | 02:02 | |
*** david-lyle_ has joined #openstack-cinder | 02:04 | |
*** david-lyle_ is now known as david-lyle | 02:05 | |
*** erlon has quit IRC | 02:06 | |
*** qeelee has quit IRC | 02:10 | |
*** qeelee has joined #openstack-cinder | 02:11 | |
*** jamielennox|away is now known as jamielennox | 02:12 | |
*** john5223 has joined #openstack-cinder | 02:14 | |
*** aorourke__ has joined #openstack-cinder | 02:15 | |
*** aorourke_ has quit IRC | 02:15 | |
*** Abhijith has quit IRC | 02:15 | |
*** aorourke__ has quit IRC | 02:16 | |
*** aorourke__ has joined #openstack-cinder | 02:16 | |
*** haomaiwang has joined #openstack-cinder | 02:16 | |
openstackgerrit | XinXiaohui proposed openstack/cinder: Update detach_volume() with versionedobjects https://review.openstack.org/268609 | 02:18 |
openstackgerrit | XinXiaohui proposed openstack/cinder: Update attach_volume() with versionedobjects https://review.openstack.org/268608 | 02:18 |
openstackgerrit | XinXiaohui proposed openstack/cinder: Update test cases related to attach_volume and detach_volume API https://review.openstack.org/271614 | 02:18 |
*** bardia has quit IRC | 02:19 | |
*** haomaiwang has quit IRC | 02:21 | |
*** jamielennox is now known as jamielennox|away | 02:24 | |
*** apoorvad has quit IRC | 02:25 | |
*** jamielennox|away is now known as jamielennox | 02:25 | |
*** jamielennox is now known as jamielennox|away | 02:26 | |
*** dims has joined #openstack-cinder | 02:28 | |
*** dims_ has quit IRC | 02:29 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/280857 | 02:30 |
*** cknight1 has quit IRC | 02:32 | |
*** haomaiwang has joined #openstack-cinder | 02:32 | |
*** jamielennox|away is now known as jamielennox | 02:33 | |
*** markvoelker_ has quit IRC | 02:34 | |
*** jamielennox is now known as jamielennox|away | 02:34 | |
*** jamielennox|away is now known as jamielennox | 02:35 | |
*** jamielennox is now known as jamielennox|away | 02:36 | |
*** haomaiwang has quit IRC | 02:37 | |
*** Suhani has quit IRC | 02:37 | |
*** apoorvad has joined #openstack-cinder | 02:37 | |
*** cknight has joined #openstack-cinder | 02:37 | |
*** laughterwym has joined #openstack-cinder | 02:42 | |
*** qeelee_ has joined #openstack-cinder | 02:42 | |
*** laughterwym has quit IRC | 02:43 | |
*** qeelee has quit IRC | 02:43 | |
*** qeelee_ is now known as qeelee | 02:43 | |
*** laughterwym has joined #openstack-cinder | 02:47 | |
*** haomaiwa_ has joined #openstack-cinder | 02:48 | |
*** jamielennox|away is now known as jamielennox | 02:51 | |
*** houming has joined #openstack-cinder | 02:55 | |
*** apoorvad has quit IRC | 02:58 | |
*** haomaiwa_ has quit IRC | 03:01 | |
*** haomaiwa_ has joined #openstack-cinder | 03:01 | |
*** JoseMello has quit IRC | 03:08 | |
*** salv-orlando has joined #openstack-cinder | 03:09 | |
openstackgerrit | Merged openstack/python-cinderclient: Fix return type in backup docstring https://review.openstack.org/281141 | 03:11 |
*** salv-orlando has quit IRC | 03:11 | |
*** ponychou has quit IRC | 03:18 | |
*** krotscheck_dr is now known as krotscheck_afk | 03:18 | |
*** Lee1092 has joined #openstack-cinder | 03:18 | |
*** esker has joined #openstack-cinder | 03:27 | |
*** links has joined #openstack-cinder | 03:30 | |
*** qeelee has quit IRC | 03:30 | |
*** dims has quit IRC | 03:32 | |
*** markvoelker has joined #openstack-cinder | 03:34 | |
*** dims has joined #openstack-cinder | 03:34 | |
*** dims has quit IRC | 03:37 | |
*** markvoelker has quit IRC | 03:39 | |
*** david-lyle_ has joined #openstack-cinder | 03:42 | |
*** david-lyle has quit IRC | 03:45 | |
*** baojg has quit IRC | 03:53 | |
*** qeelee has joined #openstack-cinder | 04:00 | |
*** david-lyle has joined #openstack-cinder | 04:00 | |
*** guitarza1 is now known as guitarzan | 04:00 | |
*** haomaiwa_ has quit IRC | 04:01 | |
*** haomaiwang has joined #openstack-cinder | 04:01 | |
*** david-lyle_ has quit IRC | 04:03 | |
*** david_lyle__ has joined #openstack-cinder | 04:03 | |
*** david-lyle has quit IRC | 04:04 | |
openstackgerrit | Merged openstack/cinder: Coho volume stats update https://review.openstack.org/279766 | 04:06 |
*** jwcroppe has quit IRC | 04:07 | |
*** david_lyle__ has quit IRC | 04:08 | |
*** jwcroppe has joined #openstack-cinder | 04:08 | |
*** qeelee has quit IRC | 04:10 | |
*** jwcroppe has quit IRC | 04:13 | |
*** qeelee has joined #openstack-cinder | 04:16 | |
*** mriedem has quit IRC | 04:18 | |
*** mudassirlatif has joined #openstack-cinder | 04:20 | |
*** qeelee has quit IRC | 04:20 | |
*** asselin__ has quit IRC | 04:30 | |
*** asselin_ has joined #openstack-cinder | 04:30 | |
*** qeelee has joined #openstack-cinder | 04:31 | |
*** bardia has joined #openstack-cinder | 04:39 | |
*** qeelee has quit IRC | 04:39 | |
*** vivekd has joined #openstack-cinder | 04:47 | |
*** salv-orlando has joined #openstack-cinder | 04:51 | |
*** laughterwym has quit IRC | 04:53 | |
*** bkumar has joined #openstack-cinder | 04:55 | |
openstackgerrit | Angus Lees proposed openstack/os-brick: Trivial rootwrap -> privsep replacement https://review.openstack.org/277224 | 04:58 |
openstackgerrit | LisaLi proposed openstack/os-brick: Add sheepdog support https://review.openstack.org/280588 | 04:59 |
*** haomaiwang has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-cinder | 05:01 | |
openstackgerrit | LisaLi proposed openstack/cinder: DO NOT MERGE https://review.openstack.org/282169 | 05:01 |
*** Poornima has joined #openstack-cinder | 05:05 | |
*** salv-orlando has quit IRC | 05:07 | |
*** qeelee has joined #openstack-cinder | 05:09 | |
*** daneyon_ has quit IRC | 05:17 | |
*** daneyon has joined #openstack-cinder | 05:17 | |
*** salv-orlando has joined #openstack-cinder | 05:22 | |
openstackgerrit | javeme proposed openstack/cinder: Remove RequestBodySizeLimiter from middleware https://review.openstack.org/282176 | 05:26 |
*** houming has quit IRC | 05:27 | |
*** cknight has quit IRC | 05:27 | |
*** salv-orlando has quit IRC | 05:28 | |
*** dave-mccowan has quit IRC | 05:28 | |
*** vivekd has quit IRC | 05:28 | |
*** mtanino has quit IRC | 05:29 | |
openstackgerrit | LisaLi proposed openstack/cinder: Handle OverQuota exception during volume transfer https://review.openstack.org/281053 | 05:31 |
openstackgerrit | javeme proposed openstack/cinder: Remove RequestBodySizeLimiter from middleware https://review.openstack.org/282176 | 05:32 |
openstackgerrit | Wang Bo proposed openstack/cinder: Fix python2,3 compatibility issues https://review.openstack.org/270037 | 05:34 |
*** laughterwym has joined #openstack-cinder | 05:35 | |
*** markvoelker has joined #openstack-cinder | 05:36 | |
*** sgotliv has joined #openstack-cinder | 05:36 | |
*** rcernin has joined #openstack-cinder | 05:38 | |
*** markvoelker has quit IRC | 05:40 | |
*** baojg has joined #openstack-cinder | 05:45 | |
*** bharathk has joined #openstack-cinder | 05:56 | |
*** bkumar has quit IRC | 05:56 | |
*** aorourke__ has quit IRC | 05:56 | |
*** cheneydc has quit IRC | 05:57 | |
*** cheneydc has joined #openstack-cinder | 05:57 | |
*** qeelee has quit IRC | 05:58 | |
*** haomaiwang has quit IRC | 06:01 | |
*** haomaiwa_ has joined #openstack-cinder | 06:01 | |
*** vivekd has joined #openstack-cinder | 06:02 | |
*** mudassirlatif has quit IRC | 06:13 | |
*** resker has joined #openstack-cinder | 06:13 | |
openstackgerrit | Keiichi KII proposed openstack/os-brick: remove unneeded in_use flag checking for multipath https://review.openstack.org/264678 | 06:13 |
*** mudassirlatif has joined #openstack-cinder | 06:15 | |
*** esker has quit IRC | 06:15 | |
*** belmoreira has joined #openstack-cinder | 06:23 | |
*** lpetrut has joined #openstack-cinder | 06:25 | |
*** resker has quit IRC | 06:30 | |
*** salv-orlando has joined #openstack-cinder | 06:34 | |
*** cheneydc has quit IRC | 06:34 | |
*** flip214_ is now known as flip214 | 06:35 | |
*** flip214 has joined #openstack-cinder | 06:36 | |
*** salv-orlando has quit IRC | 06:37 | |
openstackgerrit | Dinesh Bhor proposed openstack/cinder: Fix 500 error if 'offset' is out of range https://review.openstack.org/278354 | 06:41 |
*** nkrinner has joined #openstack-cinder | 06:43 | |
openstackgerrit | Matan Sabag proposed openstack/cinder: Changes in ScaleIO configurations options. https://review.openstack.org/281541 | 06:53 |
*** esker has joined #openstack-cinder | 06:53 | |
*** EinstCra_ has joined #openstack-cinder | 06:57 | |
*** yangyapeng has joined #openstack-cinder | 06:58 | |
*** yangyap__ has quit IRC | 06:59 | |
*** yangyapeng has quit IRC | 06:59 | |
*** EinstCrazy has quit IRC | 06:59 | |
*** yangyapeng has joined #openstack-cinder | 06:59 | |
*** haomaiwa_ has quit IRC | 07:01 | |
*** 20WAABHNQ has joined #openstack-cinder | 07:01 | |
*** ankit_ag has joined #openstack-cinder | 07:18 | |
*** sgotliv has quit IRC | 07:20 | |
*** lpetrut has quit IRC | 07:21 | |
*** yangyape_ has joined #openstack-cinder | 07:26 | |
*** yangyapeng has quit IRC | 07:26 | |
*** esker has quit IRC | 07:31 | |
*** markvoelker has joined #openstack-cinder | 07:36 | |
*** markvoelker has quit IRC | 07:40 | |
*** yangyapeng has joined #openstack-cinder | 07:41 | |
*** chlong_ has quit IRC | 07:41 | |
*** winston-d_ has quit IRC | 07:42 | |
*** yangyape_ has quit IRC | 07:42 | |
*** yangyapeng has quit IRC | 07:46 | |
*** e0ne has joined #openstack-cinder | 07:49 | |
*** esker has joined #openstack-cinder | 07:50 | |
*** EinstCra_ has quit IRC | 07:52 | |
*** bardia has quit IRC | 07:56 | |
*** abhishek_k has joined #openstack-cinder | 07:57 | |
*** abhishek_k has quit IRC | 07:57 | |
*** 20WAABHNQ has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-cinder | 08:01 | |
*** boris-42 has joined #openstack-cinder | 08:04 | |
openstackgerrit | Vivek Dhayaal proposed openstack/cinder: Removed potential races from volume update method https://review.openstack.org/277588 | 08:09 |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Refactor Hitachi Block Storage Driver (patch - 1/4) https://review.openstack.org/280497 | 08:17 |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Refactor Hitachi Block Storage Driver (patch - 2/4) https://review.openstack.org/280499 | 08:20 |
*** salv-orlando has joined #openstack-cinder | 08:22 | |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Refactor Hitachi Block Storage Driver (patch - 3/4) https://review.openstack.org/280500 | 08:22 |
*** zhangjn has quit IRC | 08:23 | |
openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Refactor Hitachi Block Storage Driver (patch - 4/4) https://review.openstack.org/280501 | 08:24 |
*** lpetrut has joined #openstack-cinder | 08:30 | |
*** houming has joined #openstack-cinder | 08:31 | |
*** esker has quit IRC | 08:31 | |
*** salv-orlando has quit IRC | 08:31 | |
*** zhangjn has joined #openstack-cinder | 08:32 | |
*** teju has joined #openstack-cinder | 08:34 | |
*** lpetrut has quit IRC | 08:35 | |
*** ildikov has quit IRC | 08:35 | |
mc_nair | DuncanT: lemme know if you're around and have some time to discuss some quota stuff. I'll be online for a bit longer | 08:36 |
openstackgerrit | LisaLi proposed openstack/cinder: Add update_host for backup in cinder-manager https://review.openstack.org/282230 | 08:38 |
*** laughterwym has quit IRC | 08:39 | |
*** esker has joined #openstack-cinder | 08:41 | |
*** annasort_ has joined #openstack-cinder | 08:45 | |
*** e0ne_ has joined #openstack-cinder | 08:46 | |
*** shyama_ has joined #openstack-cinder | 08:46 | |
*** yhayashi has quit IRC | 08:47 | |
*** e0ne has quit IRC | 08:48 | |
*** annasort has quit IRC | 08:48 | |
*** annasort_ is now known as annasort | 08:48 | |
*** e0ne_ has quit IRC | 08:48 | |
*** shyama has quit IRC | 08:50 | |
*** shyama_ is now known as shyama | 08:50 | |
*** arecknag has joined #openstack-cinder | 08:53 | |
*** zhangjn has quit IRC | 09:00 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-cinder | 09:01 | |
*** salv-orlando has joined #openstack-cinder | 09:03 | |
*** haypo has joined #openstack-cinder | 09:08 | |
haypo | hey, can a core reviewer please re-approved https://review.openstack.org/#/c/249399/ ? it was approved, but i had to fix a simple and obvious conflict on tests-py3.txt | 09:09 |
openstackgerrit | huanan proposed openstack/cinder: Huawei: Check the QoS status before we use https://review.openstack.org/271601 | 09:11 |
*** zhangjn has joined #openstack-cinder | 09:12 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Add SIGHUP handlers to reset RPC version pins https://review.openstack.org/279039 | 09:13 |
*** jordanP has joined #openstack-cinder | 09:20 | |
*** esker has quit IRC | 09:30 | |
*** esker has joined #openstack-cinder | 09:34 | |
*** zhangjn has quit IRC | 09:35 | |
*** markvoelker has joined #openstack-cinder | 09:37 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Add SIGHUP handlers to reset RPC version pins https://review.openstack.org/279039 | 09:38 |
*** markvoelker has quit IRC | 09:42 | |
*** zhangjn has joined #openstack-cinder | 09:44 | |
*** baojg has quit IRC | 09:44 | |
lixiaoy1 | dulek: Hi Michal | 09:45 |
*** baojg has joined #openstack-cinder | 09:45 | |
*** zhangjn has quit IRC | 09:46 | |
dulek | lixiaoy1: Hi! | 09:47 |
dulek | lixiaoy1: Can I have a quick question if you're here? | 09:47 |
lixiaoy1 | dulek: thank you for your support in scaling backup! | 09:47 |
lixiaoy1 | dulke: your help to review the codes | 09:47 |
dulek | lixiaoy1: Sure, I believe this is a very important feature in this release, so it was a pleasure. :) | 09:48 |
dulek | lixiaoy1: https://github.com/openstack/cinder/blob/master/cinder/backup/manager.py#L91 - do we need this line now? | 09:48 |
lixiaoy1 | dulek: no! | 09:48 |
lixiaoy1 | dulek: yesterday you said you were going to rework the upgrade patch about backup | 09:49 |
dulek | lixiaoy1: I was a little confused when rebasing my patch, it's cool we don't need it. | 09:49 |
dulek | lixiaoy1: Yes, I've already started. It turns out a little harder than I thought, but I think I'm making progress. | 09:50 |
dulek | lixiaoy1: The idea is to add a dummy backup RPC API version (1.3) that marks the beginning of scalable backups era. | 09:50 |
openstackgerrit | Jordan Pittier proposed openstack/cinder: Fix race condition in RemoteFS create_snapshot_online https://review.openstack.org/281753 | 09:50 |
dulek | lixiaoy1: And then be able to do scheduling based on that. | 09:50 |
lixiaoy1 | dulek: I will review the code later | 09:51 |
lixiaoy1 | dulek:dulek: Another questions about rpc_current_version, currently when service starts, it gets the minimum version. | 09:51 |
dulek | lixiaoy1: If we're running with RPC API pinned to something lower than 1.2 - we're scheduling the old way - to the node where the backup/host is. | 09:51 |
dulek | lixiaoy1: Yes, it gets it. What's the issue here? | 09:52 |
lixiaoy1 | dulek: what I concerned is: should we exclude the services which are not available? | 09:52 |
lixiaoy1 | dulek: for example, I have a volume service, and later I kill it and never use. | 09:52 |
dulek | lixiaoy1: Excellent question! I've got back and forth on that. | 09:53 |
lixiaoy1 | dulek: :) | 09:53 |
dulek | lixiaoy1: So my motivation to *not* exclude unavailable ones is that Cinder doesn't know if the service is gone for good or not. | 09:54 |
dulek | lixiaoy1: It may be just a small network issue that made 5-6 heartbeats to disappear, but service will be back in a moment. | 09:55 |
dulek | lixiaoy1: We don't know that. | 09:55 |
lixiaoy1 | dulek: yes, this is a tricky problem | 09:55 |
*** davechen has left #openstack-cinder | 09:55 | |
*** zhangjn has joined #openstack-cinder | 09:55 | |
*** zhangjn has quit IRC | 09:56 | |
dulek | lixiaoy1: I prefer administrators to clean up their service list manually (we have "cinder-manage service remove" command) as they will know which services are really gone. | 09:56 |
lixiaoy1 | dulek: sorry I have to leave office now. | 09:57 |
dulek | lixiaoy1: The fact that you're asking about it means that we certainly need a release note explaining that. I'll make a note. | 09:57 |
lixiaoy1 | dulek: catch bus! | 09:57 |
dulek | lixiaoy1: Safe travel! | 09:57 |
lixiaoy1 | dulek: talk you later | 09:57 |
*** zhangjn has joined #openstack-cinder | 10:00 | |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-cinder | 10:01 | |
*** ildikov has joined #openstack-cinder | 10:01 | |
*** sgotliv has joined #openstack-cinder | 10:02 | |
*** salv-orl_ has joined #openstack-cinder | 10:03 | |
yuriy_n17 | geguileo: Hi! Very sorry for disturbing. Please review https://review.openstack.org/#/c/198006/ whenever you have free time. Thanks a lot for advance. | 10:05 |
*** salv-orlando has quit IRC | 10:06 | |
*** zhangjn has quit IRC | 10:13 | |
*** zhangjn has joined #openstack-cinder | 10:22 | |
*** zhangjn has quit IRC | 10:23 | |
*** houming has quit IRC | 10:24 | |
*** ndipanov has joined #openstack-cinder | 10:27 | |
*** zhangjn has joined #openstack-cinder | 10:27 | |
*** sdague has joined #openstack-cinder | 10:28 | |
*** zhangjn has quit IRC | 10:28 | |
*** slunkad_ has joined #openstack-cinder | 10:29 | |
*** tpsilva has joined #openstack-cinder | 10:31 | |
*** zhangjn has joined #openstack-cinder | 10:34 | |
*** slunkad_ has quit IRC | 10:36 | |
*** ildikov has quit IRC | 10:43 | |
*** ociuhandu has quit IRC | 10:47 | |
*** salv-orl_ has quit IRC | 10:48 | |
*** baojg has quit IRC | 10:58 | |
*** baojg has joined #openstack-cinder | 10:58 | |
*** haomaiwang has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-cinder | 11:01 | |
*** baojg has quit IRC | 11:03 | |
*** haomaiwang has quit IRC | 11:08 | |
yuriy_n17 | dulek: Hi! Very sorry for disturbing. Please review https://review.openstack.org/#/c/198006/ whenever you have free time. Thanks a lot for advance. | 11:14 |
dulek | yuriy_n17: I'm not sure if it will be today, but I'll try to take a look. | 11:16 |
yuriy_n17 | dulek: Whenever you have free time. Thanks. | 11:16 |
*** vivekd has quit IRC | 11:21 | |
*** smoriya_ has quit IRC | 11:22 | |
*** vivekd has joined #openstack-cinder | 11:24 | |
*** [1]Thelo has joined #openstack-cinder | 11:25 | |
*** vivekd_ has joined #openstack-cinder | 11:26 | |
*** Thelo has quit IRC | 11:28 | |
*** [1]Thelo is now known as Thelo | 11:28 | |
*** vivekd has quit IRC | 11:29 | |
*** vivekd_ is now known as vivekd | 11:29 | |
*** salv-orlando has joined #openstack-cinder | 11:29 | |
*** JoseMello has joined #openstack-cinder | 11:30 | |
*** esker has quit IRC | 11:31 | |
*** Poornima has quit IRC | 11:31 | |
*** vivekd has quit IRC | 11:35 | |
*** bharathk has quit IRC | 11:36 | |
*** markvoelker has joined #openstack-cinder | 11:38 | |
*** markvoelker has quit IRC | 11:42 | |
*** esker has joined #openstack-cinder | 11:43 | |
*** sgotliv has quit IRC | 11:43 | |
*** dave-mccowan has joined #openstack-cinder | 11:49 | |
*** lixiaoy1 has quit IRC | 11:52 | |
*** ociuhandu has joined #openstack-cinder | 12:03 | |
*** chlong_ has joined #openstack-cinder | 12:11 | |
*** cheneydc has joined #openstack-cinder | 12:17 | |
*** teju has quit IRC | 12:19 | |
*** laughterwym has joined #openstack-cinder | 12:22 | |
*** Lee1092 has quit IRC | 12:22 | |
*** cdelatte has joined #openstack-cinder | 12:22 | |
*** cheneydc has quit IRC | 12:26 | |
*** cheneydc has joined #openstack-cinder | 12:27 | |
*** EinstCrazy has joined #openstack-cinder | 12:27 | |
*** esker has quit IRC | 12:27 | |
*** dims_ has joined #openstack-cinder | 12:29 | |
*** raildo-afk is now known as raildo | 12:35 | |
*** esker has joined #openstack-cinder | 12:36 | |
*** raildo is now known as raildo-afk | 12:38 | |
*** cheneydc has quit IRC | 12:39 | |
*** raildo-afk is now known as raildo | 12:39 | |
*** lpetrut has joined #openstack-cinder | 12:39 | |
*** zhangjn has quit IRC | 12:46 | |
*** lpetrut has quit IRC | 12:50 | |
*** markvoelker has joined #openstack-cinder | 12:54 | |
*** zhangjn has joined #openstack-cinder | 12:54 | |
*** shyama has quit IRC | 12:55 | |
*** shyama has joined #openstack-cinder | 12:56 | |
*** markvoelker has quit IRC | 12:58 | |
*** klkumar has joined #openstack-cinder | 13:01 | |
*** markvoelker has joined #openstack-cinder | 13:04 | |
*** krotscheck_afk is now known as krotscheck | 13:05 | |
*** vivekd has joined #openstack-cinder | 13:07 | |
*** mylu has joined #openstack-cinder | 13:08 | |
*** ankit_ag has quit IRC | 13:09 | |
*** mylu has quit IRC | 13:09 | |
*** fthiagogv__ has quit IRC | 13:12 | |
*** salv-orlando has quit IRC | 13:21 | |
*** edmondsw has joined #openstack-cinder | 13:28 | |
*** porrua has joined #openstack-cinder | 13:29 | |
*** diablo_rojo has joined #openstack-cinder | 13:36 | |
*** cbader has quit IRC | 13:40 | |
*** jyoti-ranjan has joined #openstack-cinder | 13:42 | |
*** salv-orlando has joined #openstack-cinder | 13:54 | |
*** lpetrut has joined #openstack-cinder | 13:57 | |
haypo | hey, here are two easy win for python 3, review please! https://review.openstack.org/#/c/280335/ & https://review.openstack.org/#/c/249399/ ;) | 13:58 |
haypo | smcginnis: ^^ thanks for the +2, but why not reapproving https://review.openstack.org/#/c/249399/ ? the change was approved, i just had to rebase it in the meanwhile | 13:59 |
*** jyoti-ranjan has quit IRC | 13:59 | |
*** akerr has joined #openstack-cinder | 13:59 | |
smcginnis | haypo: Well, even on rebases we _should_ be going for two +2's. | 14:00 |
smcginnis | Maybe even especially on rebases. | 14:00 |
smcginnis | haypo: But I think that one was pretty straightforward. If no one else bites before I get back to it I'll take a look again and reapprove. | 14:00 |
haypo | smcginnis: ah? i didn't know. on oslo, if i see that a change was approved before, i reapprove it. maybe i should ask how other oslo dev handle this case | 14:01 |
*** diogogmt has quit IRC | 14:01 | |
haypo | smcginnis: CIs on Cinder are quite annoying :-( | 14:01 |
*** Julien-zte has joined #openstack-cinder | 14:01 | |
smcginnis | haypo: Hah! There's a true statement. | 14:01 |
dulek | smcginnis: I have similar problem on https://review.openstack.org/279039 - it was approved yesterday, but scalable backups got in before it and broke UT. | 14:01 |
smcginnis | Very necessary and useful, but very annoying. | 14:01 |
haypo | smcginnis: i had to wait for a specific CI for most of my pending changes, and each time the specific CI failed, multiple times... | 14:01 |
* dulek needs to switch from "works on master" to "works on master with every combination of things in zuul". | 14:02 | |
*** fthiagogv has joined #openstack-cinder | 14:02 | |
smcginnis | dulek: ;) Added to my list. | 14:02 |
haypo | smcginnis: for HGST, it looks like the CI is gone or doesn't run anymore!? my change https://review.openstack.org/#/c/280154/ the CI https://wiki.openstack.org/wiki/ThirdPartySystems/HGST_Solutions_CI | 14:02 |
haypo | smcginnis: i sent an email to the owner | 14:02 |
*** diogogmt has joined #openstack-cinder | 14:02 | |
*** cbader has joined #openstack-cinder | 14:02 | |
haypo | smcginnis: "Hah! There's a true statement." i don't expect any solution, it's just to complain :) | 14:03 |
smcginnis | OK, good. Thanks for doing that. I think they've been having issues lately. That needs to get resolved. | 14:03 |
smcginnis | haypo: Some times you just need to get it out, even if it doesn't change anything. ;) | 14:03 |
haypo | smcginnis: hehe. i took the habit of working on many changes at the same time. it's rare that i have less than 15 pending changes. but for cinder, it's very excited, because in 5 changes, all unit tests will pass on py3! | 14:04 |
haypo | (i checked again this morning, 0 failure, really) | 14:04 |
smcginnis | haypo: I love it! | 14:05 |
smcginnis | haypo: That's a great milestone to reach for us. Thanks for all your work on that. | 14:05 |
haypo | smcginnis: "a great milestone to reach for us" yeah, for me too :) i ported glance, horizon & cinder in this cycle | 14:06 |
smcginnis | haypo: Wow. You've really been busy! | 14:06 |
haypo | smcginnis: only trove & swift are working hard to block my python 3 happyness :) | 14:06 |
smcginnis | haypo: Really? I'm surprised by that. | 14:07 |
smcginnis | I think we've been talking py3 at least since Atlanta. | 14:07 |
haypo | (at least, i fixed the py3 gate and made it voting for swift) | 14:07 |
haypo | smcginnis: ahah | 14:07 |
haypo | smcginnis: come on | 14:07 |
*** baojg has joined #openstack-cinder | 14:07 | |
*** rlrossit has joined #openstack-cinder | 14:08 | |
haypo | smcginnis: they really don't care. for swift, i'm bugging them like every week, i joiend some meetings on IRC, and at the end i joiend a physical meeting at tokyo :) it's just stuck | 14:08 |
smcginnis | haypo: Hmm. Well, once everyone else has switched over maybe they'll see the need. That's unfortunate. | 14:09 |
smcginnis | bbib - gotta grab some coffee to make it through all these tabs I've opened. ;) | 14:09 |
*** lpetrut has quit IRC | 14:12 | |
*** gouthamr has joined #openstack-cinder | 14:13 | |
*** jgregor has joined #openstack-cinder | 14:20 | |
*** martyturner has joined #openstack-cinder | 14:20 | |
*** zhangjn has quit IRC | 14:23 | |
*** mriedem has joined #openstack-cinder | 14:23 | |
mriedem | can anyone tell me which cinder 3rd party CIs run with multipath enabled? | 14:23 |
mriedem | i thought there were a couple | 14:23 |
smcginnis | mriedem: I think Pure and at least some of the HPE ones. | 14:24 |
mriedem | ok | 14:24 |
smcginnis | mriedem: I recall I started to update mine, but honestly can't remember if I ever finished it :) | 14:24 |
mriedem | k, just checking logs to see if this warning shows up https://review.openstack.org/#/c/281926/1/os_brick/initiator/connector.py | 14:25 |
mriedem | i'll look at the purestorage ones | 14:25 |
smcginnis | It's too bad we don't have a central ELK for all CIs. | 14:25 |
*** jyoti-ranjan has joined #openstack-cinder | 14:25 | |
mriedem | yeah, logstash for 3rd party ci is something that would be very helpful | 14:26 |
*** esker has quit IRC | 14:26 | |
*** links has quit IRC | 14:27 | |
*** timcl has joined #openstack-cinder | 14:27 | |
*** lprice has quit IRC | 14:29 | |
mriedem | HPE FC ci uses multipath | 14:29 |
mriedem | oh snap http://54.201.44.218/26/281926/1/check/3par-fc-driver-master-client-pip-eos10-src-os-brick-dsvm/c5ba351/logs/screen-n-cpu.txt.gz?level=TRACE | 14:29 |
*** cknight has joined #openstack-cinder | 14:29 | |
mriedem | https://bugs.launchpad.net/os-brick/+bug/1547539 | 14:30 |
openstack | Launchpad bug 1547539 in os-brick "KeyError: 'multipath_id' when attaching a volume" [Undecided,New] | 14:30 |
mriedem | hemna: ^ | 14:30 |
smcginnis | mriedem: New one that you've uncovered with that additional logging? Or logging that's backing up a bug that was out there. | 14:31 |
mriedem | looks unrelated | 14:31 |
mriedem | https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L1442 | 14:31 |
mriedem | easy fix | 14:32 |
mriedem | the logic is a bit wonky | 14:32 |
smcginnis | Just about to say that. :) | 14:33 |
smcginnis | The easy part. | 14:33 |
*** zhangjn has joined #openstack-cinder | 14:33 | |
mriedem | i'll push up a fix | 14:33 |
smcginnis | mriedem: Awesome, thanks. | 14:33 |
scottda | mriedem: Do you have an opinion on the issue of adding a new Cinder /v3 endpoint for using api-microversions? | 14:33 |
*** vivekd has quit IRC | 14:34 | |
scottda | (while I've got you here) | 14:34 |
smcginnis | scottda: Surprised we haven't had more response on that ML thread. | 14:34 |
scottda | because I was just going to talk to smcginnis about this..... | 14:34 |
smcginnis | ;) | 14:34 |
scottda | smcginnis: yes | 14:34 |
mriedem | rather than v2.1? | 14:34 |
*** baojg has quit IRC | 14:34 | |
*** dustins has joined #openstack-cinder | 14:34 | |
scottda | and I'm thinking I'll un-WIP the patch | 14:34 |
mriedem | i guess i haven't read the thread | 14:34 |
*** dansmith is now known as superdan | 14:34 | |
mriedem | sdague: would probably be the best to answer | 14:34 |
scottda | mriedem: yes. I don't see much difference if the endpoint changes, a new /2.1 vs a new /3.0 | 14:35 |
sdague | yeh, sorry, I was knee deep in this metadata bug yesterday. I can compose a response later today. | 14:35 |
scottda | yes, sdague weighed in yesterday, cautioning that Nova had regrets about adding a new endpoint. | 14:35 |
scottda | sdague: ok, thanks | 14:35 |
smcginnis | mriedem: If you're interested: http://lists.openstack.org/pipermail/openstack-dev/2016-February/086910.html | 14:35 |
scottda | But the momentum to getting this in is strong, and I think we're a bit loathe to push this out to Newton.... | 14:36 |
scottda | smcginnis: That sound about right? I just spoke with DuncanT on this... | 14:36 |
smcginnis | scottda: Yeah, I agree. | 14:36 |
scottda | smcginnis: Anyway, I'm going to un-WIP and get back to work on adding /v3 support to the cinderclient. | 14:37 |
*** diogogmt has quit IRC | 14:37 | |
scottda | and maybe poke e0ne, dulek , etc to have a look at reviewing | 14:37 |
smcginnis | Good plan. | 14:37 |
scottda | (looks like e0ne is offline. Is he on holiday?) | 14:37 |
smcginnis | No official Ukraine holiday today that I know of. | 14:38 |
scottda | I think he lives in Moscow, no? | 14:38 |
smcginnis | scottda: I didn't think so. I could be wrong though. | 14:39 |
scottda | or maybe that's just where he flies through... | 14:39 |
scottda | ok | 14:39 |
dulek | scottda: Nope, it's Kharkov. | 14:39 |
dulek | smcginnis, scottda: Every Friday is a little holiday. ;) | 14:39 |
smcginnis | dulek: Hah! ;) | 14:39 |
dulek | scottda: I can't promise, I'm swamped by getting scalable backups to be able to upgrade seamlessly. | 14:40 |
scottda | anyway, I get the gist of sdague comment in the grenade patch about not copying the entire api-paste.ini file for the changes, but does anyone have an example of a more elegant way? I can only think of a bunch of ugly sed/grep/awk stuff..... | 14:40 |
dulek | scottda: But I need to do it one time. | 14:40 |
scottda | dulek: no problem. There's 2 x +2 from Sean and Patrick and I think Duncan will follow as well... | 14:40 |
scottda | smcginnis: so it's mainly an issue of figuring out which cores plan on reviewing and getting them to do it. I tried to get some names at last week's meeting, but I don't know of anyone else besides Ivan, and diablo_rojo said she was interested. | 14:41 |
smcginnis | scottda: Maybe you need to start offering cheesecake to get volunteers. | 14:42 |
smcginnis | scottda: But really, once it's ready I think we need to ping folks here and make sure everyone knows. | 14:42 |
*** openstackgerrit_ has quit IRC | 14:43 | |
*** zhangjn has quit IRC | 14:43 | |
scottda | It's friday, which means I make home-made pizza. I think the code name for microversions should be pepperoni pizza. | 14:43 |
scottda | so my offer is "pizza + beer" | 14:43 |
smcginnis | Hah, love it. | 14:43 |
scottda | smcginnis: It is ready now. | 14:43 |
smcginnis | All new features need to have food code names. | 14:44 |
smcginnis | scottda: I'll try to load it up in a bit. | 14:44 |
scottda | cool | 14:44 |
scottda | smcginnis: dulek For help with testing you can try using this: https://github.com/scottdangelo/TestCinderAPImicroversions | 14:45 |
smcginnis | scottda: Have you taken a look at the API-WG related specs? | 14:45 |
smcginnis | scottda: It might be good to have your input on those. | 14:45 |
smcginnis | scottda: https://review.openstack.org/#/q/status:open+project:openstack/api-wg+branch:master+topic:micro_spec | 14:45 |
smcginnis | scottda: Or at least a skim to make sure there's no glaring issues. | 14:46 |
*** jwcroppe has joined #openstack-cinder | 14:47 | |
*** diogogmt has joined #openstack-cinder | 14:49 | |
*** zhangjn has joined #openstack-cinder | 14:49 | |
*** martyturner has quit IRC | 14:51 | |
*** erlon has joined #openstack-cinder | 14:53 | |
*** vivekd has joined #openstack-cinder | 14:53 | |
scottda | smcginnis: will do | 14:55 |
*** cknight has quit IRC | 14:58 | |
*** cknight has joined #openstack-cinder | 15:01 | |
*** openstackgerrit_ has joined #openstack-cinder | 15:01 | |
*** timcl1 has joined #openstack-cinder | 15:01 | |
*** akerr has quit IRC | 15:03 | |
*** timcl has quit IRC | 15:04 | |
*** akerr has joined #openstack-cinder | 15:05 | |
*** Julien-zte has quit IRC | 15:06 | |
*** baumann has joined #openstack-cinder | 15:07 | |
*** lprice has joined #openstack-cinder | 15:08 | |
*** eharney has joined #openstack-cinder | 15:09 | |
*** eharney has quit IRC | 15:10 | |
*** eharney has joined #openstack-cinder | 15:10 | |
*** al_indigo has quit IRC | 15:11 | |
*** dave-mccowan has quit IRC | 15:11 | |
*** vivekd has quit IRC | 15:12 | |
*** nkrinner has quit IRC | 15:12 | |
*** links has joined #openstack-cinder | 15:13 | |
*** mtanino has joined #openstack-cinder | 15:13 | |
*** dhellmann has quit IRC | 15:16 | |
*** dhellmann has joined #openstack-cinder | 15:19 | |
*** esker has joined #openstack-cinder | 15:20 | |
*** ociuhandu has quit IRC | 15:22 | |
*** zhangjn has quit IRC | 15:24 | |
*** ociuhandu has joined #openstack-cinder | 15:24 | |
openstackgerrit | Michal Dulko proposed openstack/cinder: Scalable backup service - Liberty compatibility https://review.openstack.org/269412 | 15:24 |
*** esker has quit IRC | 15:25 | |
*** dave-mccowan has joined #openstack-cinder | 15:25 | |
*** dims_ has quit IRC | 15:27 | |
*** zhangjn has joined #openstack-cinder | 15:29 | |
*** shyama has quit IRC | 15:29 | |
*** jyoti-ranjan has quit IRC | 15:29 | |
*** jyoti-ranjan has joined #openstack-cinder | 15:30 | |
openstackgerrit | Michael Price proposed openstack/cinder: NetApp: E-Series remove snapshot limitations https://review.openstack.org/278515 | 15:31 |
openstackgerrit | Michael Price proposed openstack/cinder: NetApp: Add Consistency Group support for E-Series https://review.openstack.org/282388 | 15:31 |
*** alaski is now known as lascii | 15:33 | |
*** martyturner has joined #openstack-cinder | 15:33 | |
*** timcl1 has quit IRC | 15:33 | |
*** aorourke_ has joined #openstack-cinder | 15:35 | |
*** mvk has quit IRC | 15:36 | |
*** zhangjn has quit IRC | 15:36 | |
*** jungleboyj has joined #openstack-cinder | 15:38 | |
*** zhangjn has joined #openstack-cinder | 15:41 | |
*** sgotliv has joined #openstack-cinder | 15:44 | |
*** sheel has joined #openstack-cinder | 15:46 | |
*** timcl has joined #openstack-cinder | 15:46 | |
*** lpetrut has joined #openstack-cinder | 15:48 | |
jgriffith | mc_nair: ping | 15:48 |
*** chris_morrell has joined #openstack-cinder | 15:48 | |
*** fthiagogv has quit IRC | 15:49 | |
*** jdurgin1 has joined #openstack-cinder | 15:49 | |
*** fthiagogv has joined #openstack-cinder | 15:49 | |
*** aorourke_ has quit IRC | 15:51 | |
mc_nair | jgriffith: hey hey | 15:51 |
*** chris_morrell has quit IRC | 15:52 | |
jgriffith | mc_nair: so what's up, you mentioned you had some thoughts on that review? | 15:52 |
*** annasort has quit IRC | 15:53 | |
*** annasort has joined #openstack-cinder | 15:53 | |
*** zhangjn has quit IRC | 15:54 | |
*** xyang1 has joined #openstack-cinder | 15:55 | |
openstackgerrit | Alex O'Rourke proposed openstack/cinder: WIP - 3PAR: Update replication to v2.1 https://review.openstack.org/279307 | 15:55 |
*** fthiagogv has quit IRC | 15:56 | |
*** lpetrut has quit IRC | 15:57 | |
sdague | scottda: I just posted the long response on the ML | 15:58 |
mc_nair | jgriffith: ah - forgot about that :) I'll just put my questions on that review - since it's not high priority or anything. I was initially going to start yesterday which is why I pung but didn't end up getting to it anyway. | 15:58 |
scottda | sdague: thanks | 15:58 |
*** fthiagogv has joined #openstack-cinder | 15:58 | |
sdague | sorry I didn't sooner, just, you know, we discovered we broke the metadata server | 15:58 |
sdague | so I was a bit preoccupied | 15:58 |
*** zhangjn has joined #openstack-cinder | 15:58 | |
jgriffith | mc_nair: so all I was getting at with the comment was that if we want to do things like request verifications we should implement a generic way to do it. As opposed to a bunch of one-off adds in the volume.api | 15:59 |
*** jyoti-ranjan has quit IRC | 15:59 | |
*** jyoti_ranjan has joined #openstack-cinder | 15:59 | |
scottda | sdague: no problem. While I have you here... | 15:59 |
scottda | sdague: IN the grenade patch for upgrading api-past.ini https://review.openstack.org/#/c/276505/2/projects/70_cinder/from-liberty/upgrade-cinder | 15:59 |
*** mriedem is now known as mriedem_meeting | 16:00 | |
scottda | When you ask that the specific lines be added to the file, do you want to see some awk/sed stuff, or am I missing something? | 16:00 |
openstackgerrit | Alex O'Rourke proposed openstack/cinder: WIP - 3PAR: Update replication to v2.1 https://review.openstack.org/279307 | 16:00 |
sdague | scottda: yeh | 16:01 |
sdague | I think iniset probably can be used | 16:01 |
scottda | sdague: ok, thanks. Just wanted to check before I went down that path. | 16:01 |
sdague | although, I'm a little confused why it is needed. On the upgraded side the new code should work with the old config, because nothing is going to hit the new api yet | 16:02 |
mc_nair | jgriffith: generic as in would look at the front of the key for a vol_type extra spec, decide if this is something we should be validating. Then break off "min" and decide that should be a <=, and look at the next portion of the name "size" and grabs that prop from volume? | 16:03 |
*** coolsvap|away has quit IRC | 16:03 | |
*** sgotliv has quit IRC | 16:03 | |
hemna | mornin | 16:06 |
*** salv-orlando has quit IRC | 16:06 | |
*** klkumar has quit IRC | 16:06 | |
sdague | scottda: what was actually failing without the new lines? | 16:07 |
scottda | sdague: The new lines were to add the v3 endpoints. I may be wrong that the are required...just a sec... | 16:08 |
jgriffith | scottda: gimmie a shout when you're wrapped up with sdague; I think I misunderstood your plan with micro-versions | 16:08 |
*** crose has joined #openstack-cinder | 16:09 | |
sdague | scottda: right, grenade is just testing that mitaka code works with liberty config | 16:09 |
sdague | given that these would be additive, I don't think there is any reason they'd be needed | 16:09 |
scottda | sdague: So this is the change to api-paste.ini .. | 16:09 |
scottda | https://www.irccloud.com/pastebin/rQAmcclM/ | 16:09 |
sdague | scottda: yep | 16:09 |
*** coolsvap|away has joined #openstack-cinder | 16:09 | |
sdague | yeh, I don't think you need that to pass grenade | 16:10 |
scottda | sdague: ok, thanks. Sorry about my grenade ignorance. | 16:10 |
sdague | unless something is really weird in how things are initialized on the cinder side | 16:10 |
scottda | OK, I'll change that dependency | 16:10 |
scottda | ' | 16:10 |
sdague | if you hit a real issue, let me know | 16:10 |
sdague | and we can work through it | 16:10 |
scottda | sdague: thanks. I appreciate it. | 16:10 |
*** arecknag has quit IRC | 16:11 | |
openstackgerrit | Scott DAngelo proposed openstack/cinder: cinder-api-microversions code https://review.openstack.org/224910 | 16:12 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Fix setting the multipath_id https://review.openstack.org/282405 | 16:12 |
hemna | mriedem_meeting, ^ | 16:13 |
*** haypo has left #openstack-cinder | 16:13 | |
*** arch-nemesis has joined #openstack-cinder | 16:13 | |
mriedem_meeting | sorry for not getting that up soon enough | 16:15 |
*** vivekd has joined #openstack-cinder | 16:15 | |
mriedem_meeting | i've had distractions this morning | 16:15 |
mriedem_meeting | would be good to have a unit test on that case since it slipped through | 16:15 |
*** jgregor has quit IRC | 16:15 | |
openstackgerrit | Kurt Martin proposed openstack/cinder: 3PAR get host by WWN now handles mixed cases https://review.openstack.org/281552 | 16:15 |
scottda | jgriffith: Hi | 16:15 |
jgriffith | scottda: hey | 16:16 |
hemna | mriedem_meeting, np | 16:16 |
jgriffith | scottda: so I think I missed something | 16:16 |
jgriffith | scottda: I thought we talked about doing the versioning without introducing a V3 at all? | 16:16 |
scottda | jgriffith: No, I think by the end of the conversation at the mid-cycle it was decided to add a /v3. I could be wrong here, I hadn't reviewed the video. But I think smcginnis might have just watched it... | 16:17 |
scottda | jgriffith: And while we're on the subject, what's your opinion on new /v3 vs no-new-endpoint ? | 16:18 |
jgriffith | scottda: ok, you're probably right. But for some reason I thought we talked about just adding something like ' "id": "v2.1" ' etc | 16:18 |
jgriffith | scottda: I'm not a fan of a V3 at all :( | 16:18 |
jgriffith | scottda: I had hoped we could do this by just extending V2 | 16:18 |
jgriffith | but I don't want to torpedo all the work you've already done either | 16:19 |
scottda | jgriffith: That would have made my life easier. AT this point, I've coded it both ways. I can see both sides of the issue... | 16:19 |
jgriffith | scottda: :) | 16:19 |
scottda | and I'd like to see this get in one way or the other in Mitaka. I think many/most Cinder folks want that as well. | 16:19 |
*** lpetrut has joined #openstack-cinder | 16:20 | |
jgriffith | scottda: so I had envisioned/hoped and even thought the path we were on was saying like: curl -g -i -X GET http://127.0.0.1:8776/v2.1/xxxxxxxxx | 16:20 |
jgriffith | scottda: so I had envisioned/hoped and even thought the path we were on was saying like: curl -g -i -X GET http://127.0.0.1:8776/v2.5/xxxxxxxxx | 16:20 |
jgriffith | etc etc | 16:20 |
smcginnis | jgriffith: I think we talked about that a bit at the midcycle. | 16:20 |
jgriffith | scottda: so then old clients and such that aren't updated or don't care are still just using the default "v2.0" and everything still "just works" | 16:21 |
jgriffith | smcginnis: yeah, that's what I was remembering... but perhaps we diverged and I've forgotten :( | 16:21 |
scottda | Yeah, but that means adding a new endpoint for each microversion change. Do we really want that? | 16:21 |
smcginnis | jgriffith: IIRC, others haven't gone with the version in the URL, so a bit too late for us to. | 16:21 |
*** mriedem_meeting is now known as mriedem | 16:21 | |
openstackgerrit | Merged openstack/cinder: Update quota when volume type renames https://review.openstack.org/267999 | 16:21 |
smcginnis | jgriffith: The headers being the existing approach. | 16:21 |
scottda | and like smcginnis , the pattern I've chosen is similar to how Nova, Ironic, Manila have all done it... | 16:22 |
smcginnis | jgriffith: So the big argument, at least in my mind, for /v3 is safety against unaware clients. | 16:22 |
scottda | with the HTTP header containing the info, i.e "OpenStack-Volume-microversion: 2.37" | 16:22 |
jgriffith | scottda: I guess I thought that we could have a single endpoint and "cinder" could figure out the version number interally... maybe I'm crazy there | 16:22 |
smcginnis | jgriffith: If a new, microversion aware, client tries to perform an action on an older non-microversion aware cinder. | 16:23 |
smcginnis | jgriffith: In that case, the new call could have some special params. | 16:23 |
jgriffith | smcginnis: the call fails | 16:23 |
jgriffith | :) | 16:23 |
smcginnis | jgriffith: That the old cinder doesn't know to look for. | 16:23 |
smcginnis | jgriffith: So it does succeed. | 16:23 |
jgriffith | smcginnis: you have the same problem if you are mv aware and call an invalid version no? | 16:23 |
smcginnis | jgriffith: But the client does actually get what they asked for. | 16:23 |
smcginnis | jgriffith: No, in that case cinder knows about mv and can treat it correctly. | 16:24 |
jgriffith | smcginnis: ok... guess I don't get it :( | 16:24 |
smcginnis | jgriffith: The issue is the older cinder's that don't know and therefore don't know to fail it. | 16:24 |
hemna | looks like others are seeing 503 errors talking to ubuntu.com :( | 16:24 |
jgriffith | smcginnis: scottda so what I had *thought* of was you actually have a "mv" number for each Cinder release | 16:24 |
smcginnis | jgriffith: Liberty, as it is today, would just take the request and ignore extra params. | 16:24 |
jgriffith | smcginnis: scottda so everything that goes in M for example gets a "2.1" endpoint | 16:25 |
jgriffith | smcginnis: scottda everything in N gets a 2.2 endpoint and so on | 16:25 |
jgriffith | maybe that's a horrible idea | 16:25 |
*** mylu has joined #openstack-cinder | 16:25 | |
jgriffith | smcginnis: scottda and when I say "everything" I mean everything that is an API change that needs a version change | 16:25 |
jgriffith | smcginnis: scottda so we tie things to Cinder release every 6 months | 16:26 |
scottda | jgriffith: No, that's not the model other's use. Instead, the microversion is bumped for every patch that changes the api in a way that requires a new microversion. Because we never really know when the last patch will land before release. | 16:26 |
jgriffith | scottda: well... are you sure the model others use is the best one for us to use :) | 16:26 |
scottda | jgriffith: No, not sure of that at all. But there is a benefit to all of us doing it the same way. | 16:26 |
jgriffith | scottda: so the model you describe is a bit complex IMO | 16:27 |
jgriffith | scottda: but yeah, consistency might be a good thing | 16:27 |
jgriffith | scottda: even if it's consistently complex/difficult :( | 16:28 |
jgriffith | scottda: ok, I'll leave you to it then and won't make start a schism on this | 16:28 |
scottda | I can imagine that someday all/most services will have microversions. If we all do it the same, i.e. with an HTTP header requesting the version, it sure will be easier to client developers, users, etc. | 16:28 |
*** yuriy_n17 has quit IRC | 16:28 | |
smcginnis | jgriffith: This all just makes me really hesitant to land this in M. | 16:28 |
scottda | jgriffith: While we're on the subject, do you care to review the patch? | 16:29 |
smcginnis | It seems like there is still a lot of concern, confusion, misconceptions, etc. around microversions. | 16:29 |
scottda | jgriffith: As in, should we wait for you to review when it comes time to merge? | 16:29 |
jgriffith | scottda: well, I did :) | 16:29 |
jgriffith | scottda: I gave it a -1 for the reasons I outlined here | 16:29 |
jgriffith | scottda: but I just cleared that, because it sounds like consistency is preferred | 16:30 |
scottda | jgriffith: Sorry, needed to refresh my browser. | 16:30 |
jgriffith | scottda: honestly the approach being taken is kinda confusing to me, so I'm not sure my review is that helpful. I'm also pretty strongly opposed to V3 after the debacle with V2 | 16:31 |
jgriffith | scottda: and like I said the other day... the "cp -R v2/ v3/" is just bad IMO | 16:31 |
scottda | jgriffith: I've yanked out all those /v3/ unit tests | 16:31 |
jgriffith | scottda: well, I don't mean just the unit tests though | 16:32 |
scottda | jgriffith: And we went with your suggestion: new tests for /v3 (microversioned) fucntions would go in the new tests/unit/api/v3 dir | 16:32 |
jgriffith | scottda: the V2 thing was kind of a learning experience in what not to do IMO | 16:32 |
smcginnis | jgriffith: But given the header approach instead of the explicit /v2.1 /v2.2 approach - would you rather just extend /v2 | 16:32 |
jgriffith | scottda: it created A LOT of confusion and A LOT of extra maintenance for no gain | 16:32 |
scottda | There's not much new in /api/v3, just the router.py that re-uses /v2 stuff | 16:32 |
jgriffith | smcginnis: yeah, extend FOR SURE | 16:32 |
jgriffith | smcginnis: although I have to admit I'm not completely clear on what the approach your taking is going to look like | 16:33 |
smcginnis | jgriffith: So no concern that a new client with microversions will hit an old cinder and do Somethign Bad? | 16:33 |
jgriffith | smcginnis: scottda but it has to be better than a V3 | 16:33 |
jgriffith | smcginnis: well... that's the problem. In my model it would hit it with an unsupported v number (or endpoint) and fail | 16:34 |
jgriffith | no harm no foul | 16:34 |
jgriffith | but the important thing is that it would preserve backward compatability | 16:34 |
scottda | jgriffith: That would happen if the request was for some new method that does not exist on the old server... | 16:34 |
*** timcl has quit IRC | 16:34 | |
smcginnis | jgriffith: Yeah, I do like the explicitivity (is that a word?) of that. | 16:34 |
jgriffith | scottda: no... it's more than that | 16:34 |
smcginnis | But if we use headers, that's not an option. | 16:34 |
scottda | smcginnis: Right. Putting it in the HTTP header will be ignored by the old, unaware client | 16:35 |
jgriffith | scottda: so if I have an old cinder version that only supports V2.0... and I try and send something that says "v2.1" in the endpoint, header or whatever it fails | 16:35 |
scottda | jgriffith: That is true. With a new endpoint. | 16:35 |
*** belmoreira has quit IRC | 16:35 | |
*** arch-nemesis has quit IRC | 16:35 | |
smcginnis | jgriffith: THe header will just be ignored I beleive. | 16:35 |
scottda | jgriffith: So you are saying, add a new /v2.1 endpoint? | 16:35 |
jgriffith | I guess I'm hung up still thinking my endpoint per-release approach is better :) | 16:36 |
smcginnis | :) | 16:36 |
scottda | jgriffith: It may be better. But I think the villagers would be at our door with torches and pitchforks if we did that. | 16:36 |
jgriffith | it just seems "easier" and cleaner... but I guess we need to either say that's "off the table" or not | 16:36 |
jgriffith | so I don't waste your time on it | 16:36 |
jgriffith | scottda: which villagers? Cuz if you mean other OpenStack project villagers I'm not sure I care... I'm fine with blasting them with a fire hose | 16:37 |
*** shyama has joined #openstack-cinder | 16:37 | |
jgriffith | scottda: think of it from the deployer/consumer villagers view-point | 16:37 |
jgriffith | rather clear/easy to understand, backward compatible and pretty well defined in terms of what version you get based on the Cinder release | 16:38 |
scottda | jgriffith: Those are the villagers I meant. I'm not sure if they care, of if life is harder to use a new endpoint vs. changing the header to a new microversion. It might be the same. | 16:38 |
*** mudassirlatif has quit IRC | 16:38 | |
scottda | But some of the consumers of our API are other OS projects... | 16:38 |
jgriffith | scottda: you know we don't support old clients and new cinders very well anyway. Nor does Nova, Neutron etc | 16:39 |
smcginnis | New clients and old cinders are the issue though. | 16:39 |
jgriffith | but it's worse, because you get crappy things like "module not found" "can't do x on None object" etc etc | 16:39 |
jgriffith | smcginnis: and my argument there is that's easy to fix | 16:39 |
scottda | jgriffith: Yes, but this is an attempt to support various old vs. new combinations. | 16:39 |
jgriffith | smcginnis: via the endpoint strategy | 16:40 |
jgriffith | smcginnis: scottda well... it's not even "easy to fix" it's just "not a problem" | 16:40 |
*** salv-orlando has joined #openstack-cinder | 16:40 | |
scottda | So there's an unfortunate timing issue here. IF we want this in Mitaka, we'll need to come to consensus pretty darn quickly... | 16:41 |
scottda | If we don't care if it slips to Newton, we can have many more debates. | 16:41 |
jgriffith | scottda: yeah, that's why I was kinda reluctant to start making noise here | 16:42 |
jgriffith | scottda: would it be useful for me to write it up on ML and see what kinda feedback comes in? | 16:43 |
jgriffith | scottda: or would you prefer I went back to replication and let you make progress :) | 16:43 |
smcginnis | jgriffith: I would appreciate if you can respond to that thread. | 16:43 |
scottda | jgriffith: I don't want to shut you down. But as you know from your experience, this can get pretty exhausting.... | 16:43 |
jgriffith | scottda: FWIW, I don't want to have "debates" I just want my solution :) | 16:44 |
scottda | haha | 16:44 |
jgriffith | scottda: ok, I'll leave you to it then | 16:44 |
jgriffith | scottda: sorry for the side-track | 16:44 |
scottda | I think OpenStack could benefit from a Benevolent Dictator , the way Linux has Linus... | 16:45 |
jgriffith | scottda: I nominate /me | 16:45 |
smcginnis | We have various dictators with varying levels of benevolence. | 16:45 |
scottda | jgriffith: Fine with me. As long as it's someone. | 16:45 |
jgriffith | scottda: :) | 16:45 |
jgriffith | smcginnis: LMAO | 16:45 |
scottda | smcginnis: That's the problem , democracy degenerating to a mob of dictators | 16:45 |
smcginnis | True | 16:46 |
jgriffith | scottda: smcginnis what's always funny to me about the title is there is NO benevolence when it comes to Linus | 16:46 |
guitarzan | I was just going to ask that | 16:46 |
*** kvidvans has joined #openstack-cinder | 16:46 | |
guitarzan | jgriffith: can you be as benevolent as linus? :) | 16:46 |
scottda | OK, I'll spend the rest of my day cleaning up loose ends and enjoying some pre-spring Colorado weather.... | 16:46 |
jgriffith | scottda: smcginnis and frankly the linux kernel is NOTHING like the monster that OpenStack has become | 16:46 |
jgriffith | scottda: no kidding huh! What's up with these temps! | 16:47 |
*** arch-nemesis has joined #openstack-cinder | 16:47 | |
jgriffith | smcginnis: 73 here yesterday | 16:47 |
smcginnis | It's even warm-ish in MN. | 16:47 |
scottda | jgriffith: I think the linux kernel is cleaner because it has the Dictator. Whether Benevolent or not, it keeps things consistent and makes decisions more clear. | 16:47 |
*** mylu has quit IRC | 16:48 | |
jgriffith | scottda: well... we have smcginnis as the benevolent dictator in Cinder | 16:48 |
jgriffith | which is all I'm really concerned about here | 16:48 |
openstackgerrit | Merged openstack/cinder: Fix last Python 3 issues in zonemanager https://review.openstack.org/280335 | 16:49 |
smcginnis | Hah | 16:49 |
jgriffith | pitch forks be damned, especially if they're aimed at smcginnis and not me ;) | 16:49 |
kvidvans | Hi Team, looking for a +1 workflow for https://review.openstack.org/#/c/263766/6 | 16:49 |
smcginnis | I need to find a tall tower to lock myself in. Preferably stone so that can't be set on fire. | 16:50 |
jgriffith | smcginnis: LOL | 16:50 |
*** laughterwym has quit IRC | 16:51 | |
*** martyturner has quit IRC | 16:52 | |
scottda | smcginnis: So one final thing...I would need to update the client for /v3 and haven't done that yet. So I'd like a decision on all this pretty early next week. | 16:52 |
*** laughterwym has joined #openstack-cinder | 16:52 | |
smcginnis | scottda: Yeah, we need to decide quick. | 16:52 |
smcginnis | scottda: I need to stew some more. | 16:52 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Fix setting the multipath_id https://review.openstack.org/282405 | 16:52 |
smcginnis | scottda: At least some input trickling in on the ML post now. | 16:52 |
openstackgerrit | Merged openstack/cinder: Test middleware test_faults to Python 3 https://review.openstack.org/249399 | 16:53 |
*** links has quit IRC | 16:53 | |
*** laughterwym has quit IRC | 16:56 | |
*** martyturner has joined #openstack-cinder | 16:57 | |
*** rcernin has quit IRC | 16:58 | |
*** e0ne has joined #openstack-cinder | 17:02 | |
hemna | personally, I don't like the idea of doing v3 | 17:02 |
hemna | it's taken fordamn ever to get folks to use v2 | 17:02 |
hemna | v3 simply won't be used for years, if the migration to v2 is any example | 17:02 |
*** stupidnic has left #openstack-cinder | 17:04 | |
smcginnis | hemna: Very true. | 17:06 |
smcginnis | hemna: The protection from dumb clients is my only concern. | 17:06 |
hemna | it basically means microversioned changes won't be used at all. :( | 17:06 |
scottda | I agree as well. And we need Nova to be onboard to make some of the microversioned changes we'd like for things like multi-attach | 17:07 |
hemna | I think that's far worse in my opinion | 17:07 |
smcginnis | hemna: But with a lot of folks still using v1, but the time we get to real support we can have backported protection for k and L. | 17:07 |
scottda | And I don't care about dumb clients. IF you are dumb, you get to learn a lesson and hopefully become smarter. | 17:07 |
smcginnis | Well, TBF, they have to make a change to use microversions in the first place. | 17:07 |
*** porrua has quit IRC | 17:07 | |
hemna | scottda, +1 | 17:07 |
smcginnis | So going to v2 with microversion or v3, it's a small difference. | 17:07 |
scottda | smcginnis: That's right. IF the client is choosing to use microversions they'd better be smart enough to deal with it. IF they are not, too bad. | 17:08 |
*** cknight has quit IRC | 17:08 | |
*** mylu has joined #openstack-cinder | 17:08 | |
*** esker has joined #openstack-cinder | 17:08 | |
smcginnis | scottda: I haven't looked. How much work would it be to backport a fix for microversion awareness just enough to reject calls if the header is present. | 17:09 |
smcginnis | Pretty trivial, right? | 17:09 |
*** sbezverk has joined #openstack-cinder | 17:10 | |
scottda | smcginnis: I'm not positive, but it might be done easily with changes to api-paste.ini : | 17:10 |
*** baumann has quit IRC | 17:10 | |
scottda | https://www.irccloud.com/pastebin/lsnyt4Kt/ | 17:10 |
scottda | If that stuff is enforced, there should be a way to have something like "latent_disallow_headers". But not too sure on that... | 17:10 |
smcginnis | So if it's not in latent_allow_headers it gets rejects? | 17:10 |
scottda | No, I don't think so. | 17:11 |
scottda | patrickeast: pointed out that I should probably add the new stuff for the microverson headers, which I did... | 17:11 |
scottda | But they are not allowed on an older server, and it does not reject the headers if you send it. | 17:11 |
sbezverk | Hello, anybody could help with LVM/iscsi related question? | 17:12 |
smcginnis | sbezverk: We can try. Shoot. | 17:12 |
scottda | That is , they are not specifically allowed via that filter. | 17:12 |
sbezverk | I need a bit of guidance in troubleshooting an issue I am seeing. I brought up iscsid with targetcli in a docker container and I would like to cinder to use if for volumes. cinder.conf has right configuration for iscsi and lvm backend. When I create a volume I see all existing volume groups get locked up and a volume gets stuck in creating state.. | 17:15 |
*** porrua has joined #openstack-cinder | 17:16 | |
smcginnis | sbezverk: Anything in the c-vol log file? | 17:16 |
smcginnis | Sorry, late for something. If you can put any errors in paste.openstack.org I'm sure someone here can help. | 17:16 |
*** garthb has joined #openstack-cinder | 17:17 | |
sbezverk | smcginnis no much, I should probably enable debug, but check this out | 17:17 |
sbezverk | http://paste.openstack.org/show/487607/ | 17:17 |
*** porrua has quit IRC | 17:21 | |
hemna | patrickeast, pure's CI seems to be unhappy at the moment. 503's from | 17:21 |
*** leeantho has joined #openstack-cinder | 17:22 | |
rhedlind | Both my CI tests have been failing for the last 14 hours. It hits an exception in os-brick complaining about an unsupported operand type. Still looking for clues as to what might be wrong. Not aware of any changes in our internal environment. Any ideas are welcome. Trying to figure out if any changes to os-brick went in about that time that would help me get to the bottom of this. http://paste.openstack.org/show/487600/ | 17:23 |
*** timcl has joined #openstack-cinder | 17:24 | |
scottda | smcginnis: bswartz Ok, how crazy is this idea to solve the issue of new_microversion client taking to old, non-micro server (and not checking)... | 17:26 |
scottda | Don't allow adding new parameters to methods that currently exist. Isn't that the only scenario where there is a problem? | 17:26 |
scottda | Instead, add a new API call with the new parameter, and in the API code just make that a wrapper using the old method. | 17:26 |
scottda | New client talking to old server would fail. | 17:26 |
bswartz | scottda: that approach would take away most of the power of microversions to allow us to improve the API | 17:27 |
bswartz | if you can't add to existing APIs you'll have the exact same problem you have without microversions | 17:27 |
Swanson | Abhijith, if you only have some trouble you're doing a great job. | 17:27 |
Swanson | grr | 17:27 |
scottda | OK, I said it might be crazy. | 17:28 |
openstackgerrit | Sheel Rana proposed openstack/python-cinderclient: Extra 'u' in output of cinder cli commands https://review.openstack.org/281475 | 17:28 |
*** jdurgin1 has quit IRC | 17:28 | |
*** esker has quit IRC | 17:29 | |
scottda | But am I correct that the only troublesome scenario is when we add a parameter to an existing API? | 17:29 |
scottda | I'm still not convinced that the caller would not have to deal with it anyway, i.e. try: new way else: old way | 17:30 |
bswartz | scottda: any time we significantly redefine how an API works in such a way that an invocation of the new API could be mistaken for an invocation of the old API by a server that's not microversion aware | 17:30 |
*** rcernin has joined #openstack-cinder | 17:30 | |
bswartz | scottda: the thing confusing me here is -- why is simply changing /v2 to /v3 such a big deal? | 17:31 |
bswartz | changing that 1 character in the URL solves so many problems, yet there seems to be a lot of resistence to it | 17:31 |
scottda | bswartz: See the ML thread for some reasons. | 17:32 |
bswartz | I did read it -- and it wasn't evident | 17:32 |
bswartz | I will read again | 17:32 |
jgriffith | bswartz: well, there's a few reasons | 17:33 |
jgriffith | bswartz: after living through V2 for over a year, that's one big argument why it should be avoided. Nobody picked it up, most were unclear on why they would want it | 17:34 |
jgriffith | bswartz: contributors were unclear where/why they should put things | 17:34 |
jgriffith | bswartz: we ended up maintaining bug fixes in 2 places | 17:34 |
jgriffith | bswartz: the code was almost an exact copy/paste with no real value/add/change | 17:34 |
*** shyama has quit IRC | 17:35 | |
jgriffith | bswartz: we still have some consumers using V1 | 17:35 |
bswartz | the last part seems like an implementation issue | 17:35 |
jgriffith | bswartz: we had a slew of bugs when nova tried to move to V2 | 17:35 |
bswartz | it should be possible for v1and v2 to invoke common code if the code is in fact identical | 17:35 |
jgriffith | bswartz: well.. yeah, arguably much of it is impl issues | 17:35 |
*** dims has joined #openstack-cinder | 17:35 | |
jgriffith | bswartz: except the endpoint :) | 17:35 |
bswartz | as far a clients continuing to use v1 -- that's their choice and I don't see why it's a problem | 17:35 |
jgriffith | bswartz: maintenacne | 17:36 |
jgriffith | maintenance even | 17:36 |
jgriffith | bug reports | 17:36 |
jgriffith | etc etc | 17:36 |
*** chris_morrell has joined #openstack-cinder | 17:36 | |
jgriffith | bswartz: and when you add a feature in Cinder for Nova to consume and they're not on a version that supports it... well then your'e kinda screwed | 17:36 |
bswartz | well the goal of removing old compabitility layers is different from the goal of adding new versions to people who want to run the latest can do so without insanity | 17:36 |
jgriffith | bswartz: ok | 17:37 |
bswartz | As nice as it would be to drop compatibility for old stuff, I've never advocated actually doing that | 17:37 |
jgriffith | bswartz: we could discuss implementation insanity if you like ;) | 17:37 |
bswartz | I advocate making the new version great, and keeping compatible with old versions through whatever tricks are necessary | 17:37 |
jgriffith | bswartz: I'm certainly not saying that either.. never have | 17:37 |
jgriffith | I don't think anybody is proposing that at all | 17:37 |
jgriffith | bswartz: we're on the same page | 17:38 |
jgriffith | bswartz: My point was that copy/paste thousands of lines of code is stoopid | 17:38 |
jgriffith | bswartz: and unnecessary | 17:38 |
bswartz | yes but that can be avoided IMO | 17:38 |
bswartz | python is magic after all | 17:38 |
jgriffith | bswartz: well that's the crux of the discussion on going v2-->v3 really | 17:39 |
bswartz | okay | 17:39 |
jgriffith | bswartz: and yes, I mentioned that I think there are ways to do it via endpoints or internal endpoints branched off of V2.0 | 17:39 |
bswartz | scottda: since you proposed a crazy idea, let me throw a crazy idea back at you | 17:39 |
jgriffith | but that's apparantly not the "community" way | 17:39 |
bswartz | how about we implement a /v3 endpoint, that interally is simply aliased to the v2 endpoint | 17:40 |
bswartz | the only difference between the 2 would be that if a client came in through the /v2 endpoint we would note that that client does not support microversions | 17:40 |
bswartz | and if they came in through the v3 endpoint, we would require the microversion header and track the version | 17:41 |
jgriffith | bswartz: seems like a nice compromise | 17:41 |
bswartz | IIRC that's what manila does on the server side regarding v1 vs v2 | 17:41 |
scottda | bswartz: I think the aliasing is done via the /v3/router.py : https://review.openstack.org/#/c/224910/31/cinder/api/v3/router.py | 17:42 |
scottda | So that's kinda done, unless I'm missing something. | 17:42 |
bswartz | that brings me back to confusion about why adding v3 is considered a big deal | 17:43 |
bswartz | its 1 character in a URL string and it's not a log of code to handle it | 17:43 |
scottda | It's not really a big deal to me | 17:43 |
bswartz | not a lot*' | 17:43 |
scottda | It's implemented and ready to go. Ship it. | 17:43 |
patrickeast | hemna: thanks for the heads up, just got in and saw the ci scoreboard... something must have broken in a new and exciting way since nagios has been silent :( | 17:45 |
*** jyoti_ranjan has quit IRC | 17:45 | |
*** jyoti_ranjan has joined #openstack-cinder | 17:45 | |
*** baumann has joined #openstack-cinder | 17:45 | |
patrickeast | scottda: fwiw those header changes in the api-paste were only for cors stuff, they shouldn't affect normal traffic to the api service | 17:45 |
scottda | patrickeast: OK , thanks. | 17:46 |
patrickeast | scottda: would need different settings to block requests | 17:46 |
*** shyama has joined #openstack-cinder | 17:46 | |
patrickeast | scottda: also, reading scrollback, whats the tl;dr for micro-drama today? | 17:46 |
scottda | Well, backporting something like that would only help in a very limited number of cases (i.e. actually deploying the backport), so I don't think that gets us very far. | 17:47 |
scottda | patrickeast: ARe you up on the micro-drama from yesterday? | 17:47 |
scottda | i.e. should we be adding a /v3 endpoint? | 17:47 |
scottda | Today is not much different | 17:47 |
patrickeast | oh ok | 17:47 |
patrickeast | yea i was following some of it and the ML thread | 17:48 |
patrickeast | scottda: sounds like we are kind of going in circles a little... | 17:48 |
scottda | ahhh..that's why I'm so dizzy | 17:48 |
sheel | hi all | 17:49 |
sheel | are we still supporting cinder client v1 api? | 17:49 |
openstackgerrit | Yucong Feng proposed openstack/cinder: Mark oslo.vmware as optional dependency https://review.openstack.org/242257 | 17:49 |
scottda | Here's an idea, since you are a newly-minted core patrickeast . Just +2 A that sucker right now and be done with it. What could go wrong? | 17:50 |
*** mudassirlatif has joined #openstack-cinder | 17:50 | |
patrickeast | haha | 17:50 |
*** haomaiwang has joined #openstack-cinder | 17:52 | |
patrickeast | scottda: looks like it just failed pep8 timing out cloning : / | 17:52 |
cfouts | scottda: https://review.openstack.org/#/c/229142/ the commit message there might be of some use to you. :) | 17:53 |
sheel | smcginnis: hi | 17:54 |
sheel | smcginnis: just for confirmation if we still support cinderclient V1 | 17:54 |
*** jyoti_ranjan has quit IRC | 17:54 | |
*** jordanP has quit IRC | 17:56 | |
sheel | smcginnis: some bug is reported for v1 "cinder --os-volume-api-version 1 list --limit 0", so confirming whether we should fix or can let it go. | 17:56 |
*** annasort has quit IRC | 17:56 | |
*** annasort has joined #openstack-cinder | 17:56 | |
jgriffith | :) | 17:56 |
*** haomaiwang has quit IRC | 17:56 | |
sheel | jgriffith: Hi, any input on ^^ :) | 17:57 |
jgriffith | sheel: my guess would be if it's a bug and you want to fix it then do so | 17:58 |
*** jungleboyj has quit IRC | 17:59 | |
sheel | jgriffith: actually this is fixed in v2 but v1 is still having it. so wanted to confirm if we still have v1 support | 17:59 |
sheel | :) | 17:59 |
scottda | cfouts: Thanks! | 18:00 |
scottda | patrickeast: That looks really weird to me. | 18:00 |
patrickeast | scottda: the pep8 thing? | 18:01 |
sheel | jgriffith: I am confirming on early hand because getting things reviewed takes lot of efforts than fixing :) and if this is rejected later in review because we do not care for V1, it hurts :( | 18:01 |
scottda | patrickeast: yes. Any idea what that is, I was just going to recheck | 18:01 |
jgriffith | sheel: I hear ya. If the change fixes something and doesn't break compat I'd +2/A it. That's all I can tell ya | 18:01 |
patrickeast | scottda: oh, yea i posted a recheck already, i've seen it a few times over the last few days | 18:01 |
patrickeast | scottda: i think its just the new infra mirrors timing out | 18:02 |
scottda | patrickeast: cool, thanks. | 18:02 |
*** martyturner has quit IRC | 18:02 | |
sheel | jgriffith: hmm... that make sense.... its enough.. | 18:03 |
sheel | jgriffith: :) | 18:03 |
*** rlrossit has quit IRC | 18:03 | |
*** markusz has quit IRC | 18:08 | |
*** IlyaG has joined #openstack-cinder | 18:09 | |
*** Suyash has joined #openstack-cinder | 18:12 | |
*** vivekd has quit IRC | 18:16 | |
*** chlong_ has quit IRC | 18:18 | |
*** mylu has quit IRC | 18:20 | |
*** dims_ has joined #openstack-cinder | 18:22 | |
*** dims has quit IRC | 18:25 | |
*** ccesario has quit IRC | 18:25 | |
*** tonyb has quit IRC | 18:25 | |
*** netapp has quit IRC | 18:25 | |
*** krotscheck has quit IRC | 18:25 | |
*** ByPasS has quit IRC | 18:25 | |
*** mikal has quit IRC | 18:25 | |
*** dobson has quit IRC | 18:25 | |
*** mkoderer__ has quit IRC | 18:25 | |
*** ByPasS has joined #openstack-cinder | 18:25 | |
*** mikal has joined #openstack-cinder | 18:25 | |
*** krotscheck has joined #openstack-cinder | 18:25 | |
*** netapp has joined #openstack-cinder | 18:26 | |
*** mkoderer__ has joined #openstack-cinder | 18:26 | |
*** dobson has joined #openstack-cinder | 18:26 | |
*** anish has quit IRC | 18:27 | |
*** rhedlind has quit IRC | 18:27 | |
*** hparekh has quit IRC | 18:27 | |
*** hemna has quit IRC | 18:27 | |
*** abhi has quit IRC | 18:27 | |
*** lifeless has quit IRC | 18:27 | |
*** gcb has quit IRC | 18:27 | |
*** anish has joined #openstack-cinder | 18:27 | |
*** hparekh has joined #openstack-cinder | 18:27 | |
*** lifeless has joined #openstack-cinder | 18:27 | |
*** david-lyle has joined #openstack-cinder | 18:27 | |
*** gcb has joined #openstack-cinder | 18:27 | |
*** hemna has joined #openstack-cinder | 18:27 | |
*** ccesario has joined #openstack-cinder | 18:28 | |
*** abhi has joined #openstack-cinder | 18:28 | |
*** rhedlind has joined #openstack-cinder | 18:28 | |
*** tonyb has joined #openstack-cinder | 18:31 | |
*** diablo_rojo has quit IRC | 18:34 | |
*** diablo_rojo has joined #openstack-cinder | 18:35 | |
*** diablo_rojo has quit IRC | 18:35 | |
*** apoorvad has joined #openstack-cinder | 18:36 | |
*** lpetrut has quit IRC | 18:36 | |
*** mriedem has quit IRC | 18:39 | |
*** cknight has joined #openstack-cinder | 18:40 | |
*** IlyaG has quit IRC | 18:41 | |
*** mriedem has joined #openstack-cinder | 18:41 | |
*** crose has quit IRC | 18:41 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/280857 | 18:41 |
*** mudassirlatif has quit IRC | 18:41 | |
*** IlyaG has joined #openstack-cinder | 18:42 | |
*** chris_morrell has quit IRC | 18:45 | |
smcginnis | sheel: Fixes for v1 were actively being blocked for some time because the plan was to get rid of it. | 18:47 |
smcginnis | sheel: That's no longer the case. So I would welcome any v1 fixes. :) | 18:47 |
sheel | smcginnis: oh thanks.. | 18:48 |
smcginnis | sheel: Thanks for looking at it. | 18:48 |
sheel | smcginnis: :) | 18:48 |
*** haomaiwang has joined #openstack-cinder | 18:53 | |
*** rlrossit has joined #openstack-cinder | 18:54 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-brick: Updated from global requirements https://review.openstack.org/282489 | 18:55 |
*** EinstCrazy has quit IRC | 18:56 | |
*** diablo_rojo has joined #openstack-cinder | 18:56 | |
*** fthiagogv has quit IRC | 18:56 | |
*** rcernin has quit IRC | 18:56 | |
*** haomaiwang has quit IRC | 18:58 | |
*** vkmc has joined #openstack-cinder | 18:59 | |
*** vkmc has left #openstack-cinder | 19:01 | |
*** bardia has joined #openstack-cinder | 19:05 | |
*** sdague has quit IRC | 19:05 | |
*** mylu has joined #openstack-cinder | 19:08 | |
*** diablo_rojo has quit IRC | 19:08 | |
*** shyama has quit IRC | 19:10 | |
*** martyturner has joined #openstack-cinder | 19:10 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: [LVM] Restore target config during ensure_export https://review.openstack.org/271424 | 19:14 |
*** esker has joined #openstack-cinder | 19:15 | |
*** erlon has quit IRC | 19:16 | |
*** ildikov has joined #openstack-cinder | 19:18 | |
*** e0ne has quit IRC | 19:18 | |
*** porrua has joined #openstack-cinder | 19:20 | |
*** e0ne has joined #openstack-cinder | 19:23 | |
*** rcernin has joined #openstack-cinder | 19:23 | |
*** diogogmt has quit IRC | 19:24 | |
*** IlyaG has quit IRC | 19:25 | |
*** e0ne has quit IRC | 19:25 | |
*** diogogmt has joined #openstack-cinder | 19:25 | |
*** sdague has joined #openstack-cinder | 19:33 | |
*** laughterwym has joined #openstack-cinder | 19:33 | |
Swanson | These cafeteria sandwiches are not good. I didn't know chicken had hooves. | 19:33 |
*** ildikov has quit IRC | 19:35 | |
*** mylu has quit IRC | 19:36 | |
*** laughterwym has quit IRC | 19:38 | |
*** diogogmt has quit IRC | 19:40 | |
*** ociuhandu has quit IRC | 19:41 | |
*** mylu has joined #openstack-cinder | 19:43 | |
*** rcernin has quit IRC | 19:45 | |
*** diogogmt has joined #openstack-cinder | 19:46 | |
*** mylu has quit IRC | 19:48 | |
*** kfarr has joined #openstack-cinder | 19:49 | |
*** ChubYann has joined #openstack-cinder | 19:52 | |
*** lpetrut has joined #openstack-cinder | 19:55 | |
*** ChubYann has quit IRC | 19:58 | |
*** ChubYann_ has joined #openstack-cinder | 19:58 | |
*** baumann has quit IRC | 20:02 | |
*** mudassirlatif has joined #openstack-cinder | 20:06 | |
*** eharney has quit IRC | 20:18 | |
*** baumann has joined #openstack-cinder | 20:21 | |
*** timcl has quit IRC | 20:24 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder: Prevent unsupported microversion API requests https://review.openstack.org/282526 | 20:24 |
smcginnis | scottda: Interested in your thoughts. ^^ | 20:24 |
smcginnis | jgriffith: You too. | 20:24 |
smcginnis | bswartz: Curious on what you have to say on that too. ^^ | 20:25 |
smcginnis | bswartz: Though I may regret asking. ;) | 20:25 |
*** porrua has quit IRC | 20:28 | |
*** akerr has quit IRC | 20:30 | |
*** dims_ has quit IRC | 20:31 | |
*** mudassirlatif has quit IRC | 20:31 | |
openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake) https://review.openstack.org/275797 | 20:35 |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Add replication v2.1 (cheesecake) calls https://review.openstack.org/281597 | 20:35 |
patrickeast | smcginnis: so would that go along with adding the v3 endpoint? or instead? | 20:35 |
*** diablo_rojo has joined #openstack-cinder | 20:35 | |
smcginnis | patrickeast: Instead. This would give at least some level of safety to be able to stay on /v2. | 20:36 |
smcginnis | patrickeast: If we backport this now to Liberty and Kilo, theoretically by the time folks actually start using microversion... | 20:36 |
smcginnis | and by the time we make an incompatible API change... | 20:36 |
jgriffith | smcginnis: I'm not sure I see why this wouldn't be good | 20:36 |
jgriffith | smcginnis: just don't know if I'm missing something else in the impl that impacts it | 20:37 |
smcginnis | then backports will have been released and folks will have updated their installs. | 20:37 |
patrickeast | yea, the only part i'm not sure about it the whole waiting for folks to update their deployments | 20:37 |
patrickeast | whereas the v3 endpoint means anyone using a newer client with microversions just can't do anything without a v3 enabled deployment | 20:38 |
smcginnis | patrickeast: I raised that on the ML discussion. Having a fix available is different than being protected. | 20:38 |
patrickeast | but it definitely wouldn't hurt anything to put it in | 20:38 |
patrickeast | other than maybe false sense of having it 'fixed' | 20:38 |
smcginnis | patrickeast: But folks seem to be hung up on /v3, so this is a bit of a compromise. | 20:38 |
patrickeast | yea | 20:38 |
*** IlyaG has joined #openstack-cinder | 20:39 | |
cfouts | patrickeast: a newer client should be able to fall back to using v2 for deployments not using v3, right? | 20:40 |
patrickeast | cfouts: yea, and as a newer microversion aware client they should know that microversions don't work on v2 | 20:41 |
*** haomaiwa_ has joined #openstack-cinder | 20:41 | |
patrickeast | it seems like (granted I'm probably missing something) that would be the safest approach to this | 20:41 |
scottda | smcginnis: That seems like added protection. But it won't help existing deploys, of course. | 20:42 |
smcginnis | scottda: Yep | 20:42 |
patrickeast | jgriffith: oo nice, so the api's for failover are ready to go on the service controller? | 20:42 |
smcginnis | scottda: So if we do go the v3 route... | 20:42 |
scottda | cfouts: I think people are concerned about poorly implemented clients, i.e. not using cinderclient. | 20:42 |
jgriffith | patrickeast: yup... and yes, after looking at it putting everything under services just seemed to make sense | 20:43 |
smcginnis | scottda: Eventually we could switch directions and have the v2 ones routed to v3 as "microversion 2.0", right? | 20:43 |
patrickeast | jgriffith: sweet, yea i agree with putting it there | 20:43 |
patrickeast | jgriffith: i'll update my environment and play with it this afternoon | 20:43 |
jgriffith | patrickeast: i think there's good room for improvements in a lot of the code, but I have no desire to polish the rivet from now until next release | 20:43 |
jgriffith | patrickeast: cool, lemme know if you run into issues with it | 20:44 |
* smcginnis gets out the spellchecker | 20:44 | |
jgriffith | smcginnis: LOL... careful, I ignored the type in your commit message :) | 20:44 |
smcginnis | jgriffith: Doh!! | 20:44 |
*** eharney has joined #openstack-cinder | 20:44 | |
scottda | smcginnis: Yes, I think so. I'd have to play around with that. In fact, a microversion is always required now and if you hit the /v1 or /v2 endpoint my code sets the microversion to 1.0 and 2.0 today. | 20:44 |
*** IlyaG has quit IRC | 20:45 | |
smcginnis | scottda: Cool. So we theorectically wouldn't have a maintainability issue like we have today between v1 and v2. | 20:45 |
smcginnis | No copy/pasted duplicate code to maintain. | 20:45 |
*** IlyaG has joined #openstack-cinder | 20:45 | |
scottda | I think that's correct, yes. | 20:45 |
smcginnis | So really the only drawback on /v3 I'm really hearing is that it's taken forever for v1 clients to migrate to v2. | 20:46 |
*** haomaiwa_ has quit IRC | 20:46 | |
smcginnis | But their going to have to make a change anyway to go to microversion usage, whether that is /v2 or /v3 | 20:46 |
jgriffith | patrickeast: crap! I still need to fix the status_update thing I think | 20:46 |
scottda | smcginnis: Well I don't see much difference between migrating to a new /v3 vs. using a microversion header. | 20:46 |
smcginnis | But if they don't care, they can still keep on using /v2 and it won't make any difference to them. | 20:46 |
scottda | smcginnis: yup | 20:46 |
smcginnis | scottda: Yeah, still noodling. | 20:47 |
scottda | smcginnis: It's really only for people that want to move on. If they don't want to have new API changes, that's fine. | 20:47 |
smcginnis | scottda: If we go the v3 route I'll abandon that patch. | 20:47 |
scottda | ok | 20:47 |
smcginnis | If we do go the v2 route I'll get it proposed for backport ASAP and get new releases queued. | 20:47 |
scottda | I eagerly await your decision, Great Leader. | 20:48 |
smcginnis | Hah | 20:48 |
smcginnis | scottda: It is slightly simpler to maintain on our side sticking to /v2? | 20:48 |
scottda | smcginnis: Yes, I think that is true. | 20:49 |
scottda | But If we can do the re-routing that you mentioned , it might not be much difference. | 20:49 |
smcginnis | If | 20:50 |
scottda | smcginnis: Well, right now all /v3 stuff is routed to /v2. If we add something new, it would be under /v3/ but never exist in /v2 anyway. So I don't know if there would ever be code duplication. | 20:51 |
scottda | smcginnis: IF we need to fix something existing, it goes under /v2 (and gets routed to /v2 from /v3). For something new, it's in /v3 anyway. | 20:52 |
scottda | This is how Manila did it. So perhaps bswartz xyang1 cfouts could confirm that I have this right. | 20:53 |
*** apoorvad has quit IRC | 20:53 | |
smcginnis | scottda: I'm just wondering if there will be any developer confusion if they need to fix something and have to figure out which directory it's actually in. | 20:53 |
smcginnis | Especially for new folks. | 20:53 |
scottda | smcginnis: Well, at least it's only in 1 directory. | 20:54 |
scottda | I cannot imagine any new person looking at the cinder code and being confused. | 20:55 |
smcginnis | LOL | 20:55 |
openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Permit volume type operations for policy authorized users https://review.openstack.org/274204 | 20:57 |
mtanino | jgriffith: Hi, Could you revisit the LIO fix? https://review.openstack.org/#/c/271424/ Seems Oleg is waiting that the problem is fixed immediately. | 21:00 |
*** alyson_ has quit IRC | 21:02 | |
xyang1 | scottda: you are right | 21:03 |
jgriffith | mtanino: no problem, updated with my +2 again | 21:03 |
xyang1 | scottda: for common code, there is a MixIn class under v2 (v1 in manila) | 21:04 |
mtanino | jgriffith: Thank you for handling quickly :) | 21:04 |
scottda | xyang1: cool, thanks | 21:04 |
xyang1 | scottda: there is version handling in views as well if we need to add new fields | 21:06 |
scottda | I do like how Manila has solved all the problems for us. | 21:09 |
xyang1 | :) | 21:10 |
*** e0ne has joined #openstack-cinder | 21:16 | |
*** apoorvad has joined #openstack-cinder | 21:17 | |
*** e0ne has quit IRC | 21:21 | |
openstackgerrit | John Griffith proposed openstack/cinder: Remove useless get_replication_updates driver call https://review.openstack.org/282537 | 21:23 |
jgriffith | patrickeast: there ^^ | 21:23 |
jgriffith | patrickeast: next up... abc's | 21:25 |
patrickeast | jgriffith: yay! | 21:25 |
smcginnis | jgriffith: I've been thinking about abc's lately. | 21:25 |
jgriffith | but that one may have to wait til Monday | 21:25 |
*** [1]Thelo has joined #openstack-cinder | 21:25 | |
jgriffith | smcginnis: sorry for you | 21:25 |
smcginnis | jgriffith: I've actually been thinking of not having abc's, so that's good. ;) | 21:26 |
smcginnis | But probably not something for a Friday afternoon. | 21:26 |
jgriffith | smcginnis: I have a compromise to propose | 21:26 |
jgriffith | smcginnis: I'll submit it next week and people can take it or leave it | 21:26 |
patrickeast | smcginnis: that might be the best time, grab a couple of beers and start reverting code | 21:26 |
jgriffith | patrickeast: :) | 21:26 |
smcginnis | Hah! | 21:26 |
* jgriffith think "shit.. they're on to me" | 21:26 | |
patrickeast | haha | 21:27 |
smcginnis | jgriffith: Well, I'll be interested to see what you have. Especially if it's along the lines of what I've been thinking of. ;) | 21:27 |
jgriffith | smcginnis: so it's a working version of what I proposed in the past | 21:27 |
jgriffith | smcginnis: skips all the class nonsense | 21:27 |
*** Thelo has quit IRC | 21:27 | |
*** [1]Thelo is now known as Thelo | 21:28 | |
jgriffith | smcginnis: uses a decorator only on the base methods that are required | 21:28 |
smcginnis | Does it quack like a duck? | 21:28 |
jgriffith | smcginnis: anything without is considered options | 21:28 |
jgriffith | haha | 21:28 |
smcginnis | Ah, I see. | 21:28 |
jgriffith | smcginnis: were you thinking abandon altogether? | 21:28 |
smcginnis | Sorta | 21:28 |
jgriffith | smcginnis: zope? | 21:28 |
smcginnis | Hah, nope zope. Thought about that for a bit, but not sure. | 21:29 |
jgriffith | smcginnis: hehe | 21:29 |
jgriffith | smcginnis: so FWIW my idea works like zope kinda... so what are you thinking? | 21:29 |
smcginnis | Just learned something interesting things about how python handles isinstance() that could be useful. | 21:29 |
smcginnis | Maybe I'll throw together something too. | 21:29 |
jgriffith | smcginnis: ahhhh | 21:29 |
smcginnis | It's magic. | 21:29 |
jgriffith | smcginnis: so isinstance magic on a sub-class might be interesting | 21:30 |
jgriffith | Ok, I'll eagerly await next week :) | 21:30 |
smcginnis | I see two aspects to object heirarchy. | 21:30 |
smcginnis | 1) Enforce a contract for an interface that can be programmatically verified. | 21:30 |
*** garthb_ has joined #openstack-cinder | 21:30 | |
smcginnis | 2) Reuse code so the implementation burden is less and we all use as much common well-tested code as possible. | 21:31 |
smcginnis | I've mostly been looking at 1. | 21:31 |
smcginnis | I know when I came in to this, just figuring out what methods I was supposed to implement and which ones I didn't need to was a big hurdle. | 21:31 |
jgriffith | smcginnis: yeah, 2 is awesome... but well sort of doesn't fit with our calls | 21:31 |
smcginnis | Much less what those methods were actually supposed to do. | 21:32 |
jgriffith | smcginnis: yeah, that's what I'd like to fix | 21:32 |
*** garthb has quit IRC | 21:33 | |
*** jungleboyj has joined #openstack-cinder | 21:34 | |
openstackgerrit | Yucong Feng proposed openstack/cinder: Return all target_wwpns for FC storwize. https://review.openstack.org/282541 | 21:34 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Fix setting the multipath_id https://review.openstack.org/282405 | 21:42 |
*** edmondsw has quit IRC | 21:44 | |
*** dave-mccowan has quit IRC | 21:44 | |
*** timcl has joined #openstack-cinder | 21:45 | |
*** baumann has quit IRC | 21:45 | |
openstackgerrit | Patrick East proposed openstack/cinder: WIP: Update Pure replication to cheesecake https://review.openstack.org/276981 | 21:45 |
*** kvidvans has quit IRC | 21:46 | |
*** tpsilva has quit IRC | 21:46 | |
*** e0ne has joined #openstack-cinder | 21:47 | |
*** timcl has quit IRC | 21:47 | |
*** e0ne has quit IRC | 21:48 | |
smcginnis | hemna: Is that os-brick change something we'll need to quick cut a 1.1.0 release for? | 21:50 |
hemna | smcginnis, yes | 21:51 |
smcginnis | hemna: Bleh | 21:51 |
hemna | smcginnis, it's causing FC tests to fail, we are going to update our CI to skip the failing tests until that patch lands and is released. | 21:51 |
hemna | :( | 21:51 |
smcginnis | hemna: So the combination of FC and multipath? | 21:51 |
hemna | yah | 21:52 |
smcginnis | I guess I should probably get mine configured for multipathing some day. :] | 21:52 |
hemna | :P | 21:52 |
hemna | we need more CI tests runs against os-brick patches | 21:53 |
hemna | that would help catch these :( | 21:53 |
kmartin | patrickeast, not sure how Pures (patrickeast) are passing... he has multipath enabled in cinder and nova, he might be skipping them? | 21:53 |
openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake) https://review.openstack.org/275797 | 21:54 |
patrickeast | hemna: yea it never broke mine | 21:54 |
patrickeast | kmartin: ^ | 21:54 |
jgriffith | aorourke: ^^ | 21:54 |
kmartin | strange | 21:54 |
smcginnis | hemna: We should probably add instructions here to tell folks how to test os-brick patches: | 21:54 |
smcginnis | hemna: https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver#Third_Party_CI_Requirement_Policy | 21:54 |
jgriffith | smcginnis: I'll pick your brain next week on release notes and add those in as a follow up | 21:54 |
aorourke | jgriffith, looking through it right now :) downloaded the cinderclient patch as well | 21:54 |
jgriffith | aorourke: the admin_actions calls are old cruft | 21:55 |
smcginnis | jgriffith: Awesome. No worries, they can be added later. | 21:55 |
jgriffith | aorourke: I was trying to keep parallel calls for IBM, but that's not really going to work out here | 21:55 |
smcginnis | I believe we had commitment at the beginning of the cycle that the v1 stuff would be pulled out. | 21:56 |
jgriffith | smcginnis: yes, we did... so I'm counting on that | 21:56 |
hemna | smcginnis, +1 | 21:56 |
hemna | smcginnis, I also think it's time to start adding CI tests for connectors | 21:56 |
smcginnis | hemna: +1 | 21:57 |
*** dave-mccowan has joined #openstack-cinder | 21:57 | |
hemna | and requiring them | 21:57 |
hemna | fwiw | 21:57 |
aorourke | jgriffith, quick question from the few minutes of testing...how can i get the Replication Status field out of not-capable? | 21:58 |
smcginnis | hemna: We probably should. | 21:58 |
aorourke | jgriffith, this all looks really good by the way | 21:58 |
*** adrianofr_ has quit IRC | 22:00 | |
jgriffith | aorourke: capability reporting (stats update) | 22:01 |
jgriffith | aorourke: and thank you | 22:01 |
*** IlyaG has quit IRC | 22:03 | |
*** salv-orl_ has joined #openstack-cinder | 22:03 | |
jgriffith | aorourke: oh... hehe, that may not be in there :) | 22:03 |
hemna | scottda, so are we still sticking with v3 endpoint? :( | 22:03 |
hemna | scottda, just looking at the review | 22:03 |
aorourke | jgriffith, I was going to say...looking through it I cannot seem to find it | 22:03 |
jgriffith | aorourke: wait one | 22:03 |
scottda | hemna: That question is still up in the air. Waiting for some guidance from Great Leader. | 22:04 |
hemna | ok | 22:04 |
scottda | hemna: I think it's looking like we will stick with /v3 and that you are OK to review. | 22:04 |
scottda | hemna: You've seen this for some testing ideas? https://github.com/scottdangelo/TestCinderAPImicroversions | 22:05 |
hemna | not yet | 22:05 |
hemna | *click* | 22:05 |
scottda | ok. might make things easier | 22:05 |
*** salv-orlando has quit IRC | 22:06 | |
*** ByPasS has quit IRC | 22:07 | |
*** sheel has quit IRC | 22:07 | |
*** martyt has joined #openstack-cinder | 22:09 | |
smcginnis | scottda: I'm leaning toward /v3, so yeah, definitely review it. | 22:10 |
*** annasort has quit IRC | 22:10 | |
scottda | swell | 22:10 |
jgriffith | WTF are extra_capabilities ? | 22:12 |
hemna | special_specs | 22:12 |
*** changbl has quit IRC | 22:12 | |
jgriffith | hemna: ok.. WTF are "special_specs" | 22:12 |
hemna | :P | 22:12 |
hemna | I'm just messing with you | 22:13 |
jgriffith | hemna: not nice :) | 22:13 |
hemna | :P | 22:13 |
smcginnis | hah | 22:13 |
*** ByPasS has joined #openstack-cinder | 22:13 | |
*** martyt has quit IRC | 22:17 | |
*** gouthamr has quit IRC | 22:19 | |
*** lascii is now known as alaski | 22:22 | |
*** dustins has quit IRC | 22:25 | |
*** IlyaG has joined #openstack-cinder | 22:26 | |
jgriffith | aorourke: there.. let's just use that for now | 22:28 |
jgriffith | aorourke: we can get clever later | 22:28 |
*** garthb__ has joined #openstack-cinder | 22:29 | |
jgriffith | aorourke: https://review.openstack.org/#/c/275797/21..22/cinder/volume/manager.py | 22:29 |
*** haomaiwang has joined #openstack-cinder | 22:29 | |
*** daneyon has quit IRC | 22:30 | |
*** lprice has quit IRC | 22:30 | |
*** mylu has joined #openstack-cinder | 22:31 | |
*** garthb_ has quit IRC | 22:32 | |
aorourke | jgriffith, looks good to me | 22:32 |
* patrickeast might have missed something | 22:32 | |
patrickeast | jgriffith: why can't it just use the driver stats api? | 22:32 |
*** mylu has quit IRC | 22:32 | |
*** mylu has joined #openstack-cinder | 22:32 | |
openstackgerrit | Yucong Feng proposed openstack/cinder: Return all target_wwpns for FC storwize. https://review.openstack.org/282541 | 22:34 |
*** haomaiwang has quit IRC | 22:35 | |
*** dims has joined #openstack-cinder | 22:36 | |
patrickeast | jgriffith: fwiw i ask because for my driver right now I won't know if we have replication enabled until do_setup happens, which i think is later on from when that call happens | 22:36 |
*** mriedem has quit IRC | 22:37 | |
*** JoseMello has quit IRC | 22:38 | |
*** rlrossit has quit IRC | 22:39 | |
*** changbl has joined #openstack-cinder | 22:40 | |
jgriffith | patrickeast: I'm down with that | 22:41 |
jgriffith | patrickeast: just couldn't figure out where to shove that in :) | 22:41 |
*** annasort has joined #openstack-cinder | 22:41 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Fix setting the multipath_id https://review.openstack.org/282405 | 22:41 |
patrickeast | jgriffith: cool, i think it will be easier that way too | 22:41 |
patrickeast | jgriffith: less code for everyone | 22:42 |
jgriffith | patrickeast: throw up a gist or just add it to the patch in progress | 22:42 |
*** lpetrut has quit IRC | 22:45 | |
patrickeast | jgriffith: can do | 22:45 |
*** annasort has quit IRC | 22:45 | |
*** IlyaG has quit IRC | 22:49 | |
*** david-lyle has quit IRC | 22:50 | |
*** david-lyle has joined #openstack-cinder | 22:51 | |
*** ociuhandu has joined #openstack-cinder | 22:53 | |
*** david-lyle has quit IRC | 22:54 | |
*** david-lyle has joined #openstack-cinder | 22:54 | |
*** kfarr has quit IRC | 22:55 | |
*** sgotliv has joined #openstack-cinder | 22:56 | |
patrickeast | jgriffith: hokay, two options for init_host https://gist.github.com/patrick-east/1cff43a04a2d3dc29085 | 23:03 |
*** martyt has joined #openstack-cinder | 23:03 | |
patrickeast | jgriffith: one of them uses that new driver api, the other doesn't need it, but lacks a way to get the distinction between disabled and not-capable | 23:03 |
patrickeast | dunno how much we care about them | 23:03 |
jgriffith | patrickeast: cool.. lemme look | 23:04 |
jgriffith | patrickeast: so disabled/not-capable isn't important to me right now | 23:04 |
patrickeast | jgriffith: ditto | 23:05 |
jgriffith | patrickeast: so without the driver method is good for me. | 23:05 |
patrickeast | jgriffith: sounds good to me | 23:05 |
jgriffith | patrickeast: Oh... DERP | 23:05 |
*** mylu has quit IRC | 23:05 | |
jgriffith | patrickeast: don't know why I was hung up on that | 23:06 |
jgriffith | patrickeast: I'm far too lazy to change the "not-capable" default at this point though :) | 23:06 |
jgriffith | patrickeast: but I think I should | 23:07 |
patrickeast | jgriffith: maybe thats the default if stats doesn't contain replication_enabled key? | 23:07 |
jgriffith | patrickeast: yeah, that's how I have it now, but I can't think of why I wouldn't just use disabled for that | 23:07 |
*** martyt has quit IRC | 23:07 | |
jgriffith | patrickeast: except that I thought it might be useful to know the difference between "supported" and just not configured, or configured incorrectly | 23:08 |
patrickeast | jgriffith: yea, although for like the scheduler it won't care right? | 23:08 |
jgriffith | patrickeast: correct | 23:08 |
patrickeast | jgriffith: we just look at enabled as a bool | 23:08 |
*** mylu has joined #openstack-cinder | 23:08 | |
jgriffith | patrickeast: I'll roll with your suggestion and clean things out to just enabled/disabled I think | 23:09 |
patrickeast | jgriffith: cool, works for me | 23:09 |
*** haomaiwang has joined #openstack-cinder | 23:09 | |
jgriffith | patrickeast: thanks for that example | 23:09 |
patrickeast | np | 23:09 |
jgriffith | patrickeast: haha.. my patch is using the wrong db field anyway | 23:10 |
patrickeast | lol | 23:11 |
patrickeast | jgriffith: i was wondering if it was supposed to be the replication_status | 23:12 |
*** mudassirlatif has joined #openstack-cinder | 23:13 | |
*** sgotliv has quit IRC | 23:13 | |
jgriffith | patrickeast: yeah :) | 23:13 |
*** haomaiwang has quit IRC | 23:14 | |
*** sbezverk has quit IRC | 23:16 | |
*** sdague has quit IRC | 23:21 | |
*** xyang1 has quit IRC | 23:22 | |
*** ociuhandu has quit IRC | 23:23 | |
*** mylu has quit IRC | 23:24 | |
*** mudassirlatif has quit IRC | 23:25 | |
mc_nair | jgriffith: I have a throw-back of a quota question for you... was looking at https://review.openstack.org/#/c/11510/ - is there a particular reason you split up the usage into reserved/in_use/total? | 23:26 |
*** martyturner has quit IRC | 23:26 | |
mc_nair | jgriffith: as opposed to just adding to the usage on a reserve, and then subtracting if you rollback that reservation? | 23:27 |
jgriffith | mc_nair: TBF that was like 4 years ago :) | 23:27 |
*** mylu has joined #openstack-cinder | 23:29 | |
*** david-lyle_ has joined #openstack-cinder | 23:29 | |
mc_nair | Friday evening tradition, review arbitrary patch sets from 6 releases ago | 23:30 |
*** david-lyle has quit IRC | 23:30 | |
*** mylu has quit IRC | 23:30 | |
*** mylu has joined #openstack-cinder | 23:30 | |
mc_nair | jgriffith: I'm asking because I'm looking to enable a similar quota reserve system for the "allocated" portion of a limit. Right now I'm just hacking it by letting a Reservation point to a Usage or a Quota (where "allocated" lives), but "allocated" doesn't have a split for reserved/allocated. I think it will work still though, unless there's some pitfall you were avoiding by doing that | 23:31 |
openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake) https://review.openstack.org/275797 | 23:32 |
jgriffith | mc_nair: there was a reason that we had them seperated in the past | 23:32 |
jgriffith | mc_nair: but I honestly don't remember what it was or if it's still valid | 23:33 |
openstackgerrit | Merged openstack/cinder: Split out NestedQuotas into a separate driver https://review.openstack.org/274825 | 23:33 |
mc_nair | I'm taking that as "continue haphazardly forth" :) | 23:34 |
mc_nair | jgriffith: if you happen to remember lemme know, otherwise I'm sure someone will shout it out on the review | 23:34 |
*** laughterwym has joined #openstack-cinder | 23:35 | |
*** annasort has joined #openstack-cinder | 23:35 | |
mc_nair | http://gizmodo.com/5968394/the-most-important-events-of-2012-in-16-gifs/ - maybe that will help jog your memory | 23:35 |
mc_nair | get you back in the mindset | 23:35 |
smcginnis | hah | 23:36 |
jgriffith | mc_nair: LOL | 23:37 |
jgriffith | mc_nair: lemme have a look | 23:38 |
smcginnis | Oh, I forgot about McAfee. | 23:38 |
jgriffith | mc_nair: so at one point which actually used to have a concept of a "real" reserve | 23:38 |
jgriffith | mc_nair: where you wouldn't create the resource, but "save" some allocation for it | 23:39 |
jgriffith | mc_nair: I don't think it ever got finished or worked though | 23:39 |
*** mylu has quit IRC | 23:39 | |
*** annasort has quit IRC | 23:39 | |
*** laughterwym has quit IRC | 23:40 | |
mc_nair | jgriffith: ok - incomplete and broken, I already implemented that approach | 23:40 |
mc_nair | :) | 23:41 |
mc_nair | anyway, I'm headed out. I'll push on with this approach now, hopefully get together some better POC for the -1 stuff, and then you can tell me why it's a bad idea | 23:42 |
mc_nair | jgriffith: thanks for the background on that | 23:43 |
openstackgerrit | Patrick East proposed openstack/cinder: WIP: Update Pure replication to cheesecake https://review.openstack.org/276981 | 23:45 |
*** diablo_rojo has quit IRC | 23:48 | |
*** jwcroppe has quit IRC | 23:53 | |
*** jwcroppe has joined #openstack-cinder | 23:54 | |
*** jwcroppe has quit IRC | 23:58 | |
*** martyt has joined #openstack-cinder | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!