*** merooney has quit IRC | 00:00 | |
*** haomaiwang has quit IRC | 00:01 | |
*** haomaiwang has joined #openstack-cinder | 00:01 | |
*** IlyaG has joined #openstack-cinder | 00:01 | |
jgriffith | jeanfabrice: sorry, I'm really not sure. Have you logged into the screen session and verified everything is running? | 00:04 |
---|---|---|
jeanfabrice | jgriffith: yep. I setup osapi_volume_base_URL in cinder.conf then stop / start the cinder-api in the screen session | 00:05 |
*** mylu has joined #openstack-cinder | 00:06 | |
jgriffith | jeanfabrice: sorry, not sure what might be going on. Likely a problem with the config file. You could also try the client just incase your curl cmd is goofed up | 00:07 |
jeanfabrice | I'm devstacking a stable/kilo, to compare. The concern is that I'm facing a similar issue to this one : https://bugs.launchpad.net/mos/+bug/1490266, trying to solve it using osapi_volume_base_URL without success till now. | 00:10 |
openstack | Launchpad bug 1490266 in Mirantis OpenStack 9.0.x "[Tempest] [SSL] Tempest test "test_volume_list_pagination" and "test_volume_list_details_pagination" FAIL in MOS with TLS" [Medium,Confirmed] - Assigned to MOS Puppet Team (mos-puppet) | 00:10 |
*** diogogmt has quit IRC | 00:10 | |
jeanfabrice | my cinder.conf : | 00:11 |
jeanfabrice | [DEFAULT] | 00:11 |
jeanfabrice | osapi_volume_base_URL = http://foo.com/ | 00:11 |
jeanfabrice | stop/start the api, then : | 00:12 |
jeanfabrice | curl http://localhost:8776 | 00:12 |
jeanfabrice | {"versions": [{"status": "SUPPORTED", "updated": "2014-06-28T12:20:21Z", "id": "v1.0", "links": [{"href": "http://localhost:8776/v1/", "rel": "self"}]}, {"status": "CURRENT", "updated": "2012-11-21T11:33:21Z", "id": "v2.0", "links": [{"href": "http://localhost:8776/v2/", "rel": "self"}]}]} | 00:12 |
jeanfabrice | same issue running devstack/kilo. Sounds like a pebkac... | 00:15 |
*** sdague has quit IRC | 00:15 | |
*** laughterwym has joined #openstack-cinder | 00:15 | |
jeanfabrice | (or I don't understand the use of osapi_volume_base_URL) | 00:15 |
*** laughter_ has joined #openstack-cinder | 00:17 | |
*** laughter_ has quit IRC | 00:18 | |
*** laughter_ has joined #openstack-cinder | 00:18 | |
*** laughter_ has quit IRC | 00:18 | |
*** annasort has joined #openstack-cinder | 00:18 | |
*** laughterwym has quit IRC | 00:19 | |
*** laughterwym has joined #openstack-cinder | 00:21 | |
*** IlyaG has quit IRC | 00:21 | |
*** ntpttr has quit IRC | 00:21 | |
jgriffith | jeanfabrice: try removing that entry | 00:23 |
jeanfabrice | the entry that sets osapi_volume_base_URL ? Sure ? That's the reply from the api I would like to see in the json (instead of the href:localhost) | 00:25 |
jeanfabrice | according to http://docs.openstack.org/juno/config-reference/content/section_cinder.conf.html, osapi_volume_base_URL is : | 00:28 |
jeanfabrice | # Base URL that will be presented to users in links to the | 00:28 |
jeanfabrice | # OpenStack Volume API (string value) | 00:28 |
jeanfabrice | # Deprecated group/name - [DEFAULT]/osapi_compute_link_prefix | 00:28 |
jeanfabrice | #osapi_volume_base_URL=<None> | 00:28 |
*** qeelee has joined #openstack-cinder | 00:31 | |
jgriffith | aorourke: you there? | 00:36 |
aorourke | jgriffith, yes | 00:36 |
jgriffith | aorourke: so thanks for finding those issues | 00:36 |
jgriffith | aorourke: my merge somewhere along the way go screwed up | 00:37 |
jgriffith | aorourke: notice that the thaw method I specifically point out that problem in service get | 00:37 |
jgriffith | aorourke: for the rep_status, I saved the service.status instead of the service.replication_status :( | 00:37 |
jgriffith | aorourke: which also points out that I'm not using my fancy new enum there | 00:37 |
openstackgerrit | Merged openstack/cinder: cinder-api-microversions code https://review.openstack.org/224910 | 00:38 |
jgriffith | aorourke: finally on the restart... I'm not sure what's up with that, but I'll dig into it | 00:38 |
aorourke | jgriffith, excellent. i think it's almost there | 00:38 |
jgriffith | aorourke: I'm not sure what to do about the restart thing yet :) | 00:39 |
jgriffith | aorourke: the others are EZ | 00:39 |
aorourke | jgriffith, if active_backend_id is not None, don't update it? | 00:39 |
aorourke | assume failover | 00:39 |
jgriffith | aorourke: meh | 00:40 |
jgriffith | maybe | 00:40 |
*** vincent_hou has quit IRC | 00:40 | |
*** mylu has quit IRC | 00:42 | |
jgriffith | aorourke: that might be the only way for now | 00:44 |
aorourke | jgriffith, i mean it's not the best solution but i think it would work | 00:45 |
aorourke | or off of the replication_status | 00:45 |
jgriffith | aorourke: Oh,, DERP | 00:46 |
*** ildikov has quit IRC | 00:48 | |
jgriffith | aorourke: running unit tests and pep8 now | 00:49 |
*** ildikov has joined #openstack-cinder | 00:52 | |
apoorvad | smcginnis: When you get a chance, could you please look at https://review.openstack.org/#/c/268370/? | 00:52 |
*** mylu has joined #openstack-cinder | 00:54 | |
*** akerr has joined #openstack-cinder | 00:58 | |
*** delatte has joined #openstack-cinder | 00:58 | |
*** wilson_liu has quit IRC | 00:58 | |
openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake) https://review.openstack.org/275797 | 00:59 |
*** wilson has joined #openstack-cinder | 00:59 | |
*** akerr_ has joined #openstack-cinder | 00:59 | |
*** wilson is now known as Guest78071 | 00:59 | |
*** delattec has quit IRC | 01:00 | |
*** haomaiwang has quit IRC | 01:01 | |
*** haomaiwang has joined #openstack-cinder | 01:01 | |
jgriffith | well the attach stuff was going good til I hit the unit tests :( | 01:02 |
jgriffith | sigh | 01:02 |
*** akerr has quit IRC | 01:02 | |
openstackgerrit | Jacob Gregor proposed openstack/cinder: WIP: Storwize SVC multiple management IPs https://review.openstack.org/284267 | 01:02 |
*** jdillaman has quit IRC | 01:08 | |
*** cheneydc has joined #openstack-cinder | 01:08 | |
*** yangyapeng has joined #openstack-cinder | 01:09 | |
*** jgregor has quit IRC | 01:12 | |
*** yangyapeng has quit IRC | 01:12 | |
*** gouthamr_ has quit IRC | 01:13 | |
*** mylu has quit IRC | 01:13 | |
*** garthb has quit IRC | 01:14 | |
*** garthb_ has quit IRC | 01:14 | |
openstackgerrit | Patrick East proposed openstack/cinder: WIP: Update Pure replication to cheesecake https://review.openstack.org/276981 | 01:14 |
*** davechen has joined #openstack-cinder | 01:14 | |
*** gouthamr has joined #openstack-cinder | 01:16 | |
*** Suyash has quit IRC | 01:16 | |
*** aorourke is now known as aorourke-afk | 01:17 | |
*** EinstCrazy has joined #openstack-cinder | 01:20 | |
*** jdillaman has joined #openstack-cinder | 01:21 | |
*** mss-4 has joined #openstack-cinder | 01:22 | |
*** haomaiwang has quit IRC | 01:22 | |
openstackgerrit | smile-luobin proposed openstack/cinder-specs: Specify availability_zone and volume_type for backup restore API https://review.openstack.org/273870 | 01:25 |
*** julim has joined #openstack-cinder | 01:26 | |
*** Lee1092 has joined #openstack-cinder | 01:27 | |
*** Thelo has joined #openstack-cinder | 01:31 | |
*** mtanino has quit IRC | 01:32 | |
*** zhangjn has quit IRC | 01:32 | |
Thelo | Hi all, in the project system-config, If I change the file system-config/modules/openstack_project/files/pydistutils.cfg to use this link, what do I need to do to have it taken into account? | 01:34 |
*** yangyapeng has joined #openstack-cinder | 01:34 | |
Thelo | O wrong channel | 01:35 |
*** edtubill has joined #openstack-cinder | 01:36 | |
*** zhangjn has joined #openstack-cinder | 01:37 | |
*** leeantho has quit IRC | 01:39 | |
patrickeast | jgriffith: hey, still around? just rebased on patchset 32 and am seeing http://paste.openstack.org/show/488133/ | 01:39 |
patrickeast | oh | 01:40 |
patrickeast | nvm, i see the typo | 01:40 |
*** zzzeek has quit IRC | 01:45 | |
*** zzzeek has joined #openstack-cinder | 01:45 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/283923 | 01:46 |
*** zzzeek has quit IRC | 01:47 | |
*** zzzeek has joined #openstack-cinder | 01:50 | |
*** dims has quit IRC | 01:52 | |
*** zzzeek has quit IRC | 01:52 | |
smcginnis | gus: You still around? | 01:52 |
*** zzzeek has joined #openstack-cinder | 01:54 | |
*** vincent_hou has joined #openstack-cinder | 01:58 | |
smcginnis | gus: NM, commented on the patch I had a question on. | 01:58 |
*** haomaiwang has joined #openstack-cinder | 01:59 | |
*** haomaiwang has quit IRC | 02:01 | |
*** haomaiwang has joined #openstack-cinder | 02:01 | |
*** mss-4 has quit IRC | 02:04 | |
*** diogogmt has joined #openstack-cinder | 02:05 | |
openstackgerrit | Patrick East proposed openstack/cinder: WIP: Update Pure replication to cheesecake https://review.openstack.org/276981 | 02:15 |
*** erlon has quit IRC | 02:16 | |
openstackgerrit | LisaLi proposed openstack/cinder: Fix NoneType error in service_get_all https://review.openstack.org/284500 | 02:20 |
*** IlyaG has joined #openstack-cinder | 02:24 | |
*** houming has joined #openstack-cinder | 02:26 | |
*** smoriya_ has quit IRC | 02:41 | |
*** bardia_ has quit IRC | 02:45 | |
*** links has joined #openstack-cinder | 02:47 | |
openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake) https://review.openstack.org/275797 | 02:48 |
openstackgerrit | Merged openstack/cinder: Tintri image cache cleanup https://review.openstack.org/268370 | 02:50 |
huyang | kindly review, https://review.openstack.org/#/c/283975/ | 02:50 |
openstackgerrit | Merged openstack/cinder: Fix HNAS iSCSI driver attachment https://review.openstack.org/284295 | 02:51 |
*** apoorvad has quit IRC | 02:52 | |
*** apoorvad has joined #openstack-cinder | 02:53 | |
*** apoorvad has quit IRC | 02:57 | |
*** edtubill has quit IRC | 02:59 | |
*** haomaiwang has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-cinder | 03:01 | |
*** gcb has quit IRC | 03:02 | |
*** gcb has joined #openstack-cinder | 03:03 | |
*** boris-42 has quit IRC | 03:04 | |
*** edmondsw has quit IRC | 03:07 | |
*** gcb has quit IRC | 03:07 | |
*** gcb has joined #openstack-cinder | 03:08 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add unit tests for Huawei drivers https://review.openstack.org/283029 | 03:11 |
*** diogogmt has quit IRC | 03:23 | |
*** akerr_ has quit IRC | 03:24 | |
*** diogogmt has joined #openstack-cinder | 03:26 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: delete_snapshot need not return any value https://review.openstack.org/284514 | 03:27 |
*** salv-orlando has joined #openstack-cinder | 03:27 | |
*** salv-orlando has quit IRC | 03:28 | |
*** salv-orl_ has quit IRC | 03:30 | |
*** links has quit IRC | 03:34 | |
*** diogogmt has quit IRC | 03:43 | |
*** chlong_ has quit IRC | 03:47 | |
*** davechen is now known as davechen_afk | 03:49 | |
*** chlong_ has joined #openstack-cinder | 03:49 | |
*** vincent_hou has quit IRC | 03:51 | |
*** vincent_hou has joined #openstack-cinder | 03:52 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add LUN wwn check in Huawei driver https://review.openstack.org/271592 | 03:55 |
*** qeelee has quit IRC | 04:00 | |
*** haomaiwang has quit IRC | 04:01 | |
*** haomaiwa_ has joined #openstack-cinder | 04:01 | |
gus | smcginnis: (was out for a bit, back now if that helps) | 04:02 |
*** Guest78071 has quit IRC | 04:04 | |
*** Guest78071 has joined #openstack-cinder | 04:05 | |
*** ntpttr has joined #openstack-cinder | 04:07 | |
*** shyama has joined #openstack-cinder | 04:10 | |
*** vincent_hou has quit IRC | 04:12 | |
*** gouthamr has quit IRC | 04:17 | |
*** gcb has quit IRC | 04:28 | |
*** gcb has joined #openstack-cinder | 04:28 | |
*** salv-orlando has joined #openstack-cinder | 04:29 | |
*** links has joined #openstack-cinder | 04:29 | |
*** haomaiwa_ has quit IRC | 04:30 | |
*** merooney_ has quit IRC | 04:31 | |
*** salv-orlando has quit IRC | 04:39 | |
*** haomaiwa_ has joined #openstack-cinder | 04:39 | |
*** winston-d_ has joined #openstack-cinder | 04:42 | |
*** ntpttr has quit IRC | 04:47 | |
*** davechen_afk is now known as davechen | 04:48 | |
*** qeelee has joined #openstack-cinder | 04:59 | |
*** cknight1 has quit IRC | 04:59 | |
*** haomaiwa_ has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-cinder | 05:01 | |
*** lprice has joined #openstack-cinder | 05:06 | |
*** qeelee has quit IRC | 05:10 | |
*** Lallana has quit IRC | 05:11 | |
*** Lallana has joined #openstack-cinder | 05:12 | |
*** belmoreira has joined #openstack-cinder | 05:12 | |
*** Fdaisuke has quit IRC | 05:15 | |
*** Fdaisuke has joined #openstack-cinder | 05:17 | |
*** bardia has joined #openstack-cinder | 05:20 | |
*** bardia has quit IRC | 05:20 | |
*** bardia has joined #openstack-cinder | 05:21 | |
*** sgotliv has joined #openstack-cinder | 05:23 | |
*** shyama has quit IRC | 05:24 | |
*** shyama_ has joined #openstack-cinder | 05:24 | |
*** shyama_ is now known as shyama | 05:24 | |
*** Poornima has joined #openstack-cinder | 05:30 | |
*** cknight has joined #openstack-cinder | 05:35 | |
*** liverpooler has quit IRC | 05:44 | |
openstackgerrit | Chhavi Agarwal proposed openstack/cinder-specs: Allow setting multiattach property https://review.openstack.org/264059 | 05:44 |
*** cknight has quit IRC | 05:46 | |
*** qeelee has joined #openstack-cinder | 05:49 | |
*** dims has joined #openstack-cinder | 05:52 | |
*** nkrinner has joined #openstack-cinder | 05:58 | |
*** salv-orlando has joined #openstack-cinder | 05:58 | |
*** laughterwym has quit IRC | 05:59 | |
*** laughterwym has joined #openstack-cinder | 06:00 | |
*** haomaiwang has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-cinder | 06:01 | |
*** edtubill has joined #openstack-cinder | 06:03 | |
*** salv-orlando has quit IRC | 06:03 | |
*** laughterwym has quit IRC | 06:13 | |
*** laughterwym has joined #openstack-cinder | 06:14 | |
*** gcb has quit IRC | 06:18 | |
*** laughterwym has quit IRC | 06:19 | |
*** jeanfabrice has quit IRC | 06:22 | |
*** cknight has joined #openstack-cinder | 06:27 | |
*** laughterwym has joined #openstack-cinder | 06:29 | |
*** ChubYann has quit IRC | 06:29 | |
*** gcb has joined #openstack-cinder | 06:30 | |
*** laughterwym has quit IRC | 06:31 | |
*** laughterwym has joined #openstack-cinder | 06:31 | |
qeelee | Hello, does anyone know if the sheepdog tempest testing is done in a real sheepdog cluster env? | 06:34 |
lixiaoy1_ | qeelee: I think. devstack install sheepdog plugin | 06:35 |
*** aagrawal has joined #openstack-cinder | 06:35 | |
*** laughterwym has quit IRC | 06:36 | |
*** Poornima has quit IRC | 06:37 | |
*** edtubill has quit IRC | 06:38 | |
*** Poornima has joined #openstack-cinder | 06:39 | |
*** laughterwym has joined #openstack-cinder | 06:43 | |
*** dims has quit IRC | 06:43 | |
qeelee | lixiaoy1_: Thanks! | 06:43 |
*** dave-mccowan has quit IRC | 06:45 | |
*** cknight has quit IRC | 06:46 | |
*** laughterwym has quit IRC | 06:47 | |
*** laughterwym has joined #openstack-cinder | 06:50 | |
*** qeelee_ has joined #openstack-cinder | 06:50 | |
*** qeelee has quit IRC | 06:50 | |
*** qeelee_ is now known as qeelee | 06:50 | |
*** belmoreira has quit IRC | 06:53 | |
ankit_ag | smcginnis: hi | 06:54 |
*** laughterwym has quit IRC | 06:56 | |
ankit_ag | smcginnis:: wanted to discuss about https://review.openstack.org/#/c/147186/ if community is interested to push this Snapshot feature in Mitaka timeframe | 06:56 |
*** zzzeek has quit IRC | 06:56 | |
*** laughterwym has joined #openstack-cinder | 06:58 | |
*** zzzeek has joined #openstack-cinder | 06:59 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-cinder | 07:01 | |
*** salv-orlando has joined #openstack-cinder | 07:02 | |
*** laughterwym has quit IRC | 07:02 | |
*** abhishekk has joined #openstack-cinder | 07:02 | |
*** bardia has quit IRC | 07:06 | |
*** salv-orlando has quit IRC | 07:07 | |
*** jeanfabrice has joined #openstack-cinder | 07:10 | |
*** zzzeek has quit IRC | 07:10 | |
*** laughterwym has joined #openstack-cinder | 07:10 | |
*** laughterwym has quit IRC | 07:17 | |
*** lpetrut has joined #openstack-cinder | 07:19 | |
*** anshul has joined #openstack-cinder | 07:23 | |
*** salv-orlando has joined #openstack-cinder | 07:25 | |
*** salv-orl_ has joined #openstack-cinder | 07:26 | |
*** salv-orlando has quit IRC | 07:26 | |
*** ociuhandu has joined #openstack-cinder | 07:30 | |
*** ociuhandu has quit IRC | 07:31 | |
*** ociuhandu has joined #openstack-cinder | 07:32 | |
*** liverpooler has joined #openstack-cinder | 07:32 | |
*** jeanfabrice has quit IRC | 07:36 | |
*** laughterwym has joined #openstack-cinder | 07:38 | |
*** zul has quit IRC | 07:41 | |
*** laughter_ has joined #openstack-cinder | 07:42 | |
*** laughter_ has quit IRC | 07:42 | |
*** laughter_ has joined #openstack-cinder | 07:42 | |
*** laughterwym has quit IRC | 07:45 | |
openstackgerrit | huanan proposed openstack/cinder: Huawei: Check the QoS status before we use https://review.openstack.org/271601 | 07:48 |
*** zul has joined #openstack-cinder | 07:48 | |
*** ociuhandu has quit IRC | 07:49 | |
*** Poornima has quit IRC | 07:51 | |
*** belmoreira has joined #openstack-cinder | 07:51 | |
*** Poornima has joined #openstack-cinder | 07:52 | |
openstackgerrit | huanan proposed openstack/cinder: Huawei: Check the QoS status before we use https://review.openstack.org/271601 | 07:53 |
openstackgerrit | Sheel Rana proposed openstack/cinder: Adding verbose to error during volume create https://review.openstack.org/284571 | 07:54 |
openstackgerrit | LisaLi proposed openstack/cinder: No volume_id needed for backup-create from snapshot https://review.openstack.org/284572 | 07:54 |
*** daneyon_ has quit IRC | 07:55 | |
*** belmoreira has quit IRC | 07:58 | |
*** smoriya_ has joined #openstack-cinder | 07:59 | |
*** belmoreira has joined #openstack-cinder | 08:00 | |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwa_ has joined #openstack-cinder | 08:01 | |
*** belmoreira has quit IRC | 08:06 | |
openstackgerrit | huanan proposed openstack/cinder: Huawei: Check the QoS status before we use https://review.openstack.org/271601 | 08:08 |
openstackgerrit | LisaLi proposed openstack/cinder: Handle exceptions about snapshot in backup create https://review.openstack.org/284577 | 08:09 |
*** arecknag has joined #openstack-cinder | 08:09 | |
*** lpetrut has quit IRC | 08:13 | |
*** Oku_OS has quit IRC | 08:18 | |
openstackgerrit | huanan proposed openstack/cinder: Huawei: Check the QoS status before we use https://review.openstack.org/271601 | 08:31 |
*** laughter_ has quit IRC | 08:43 | |
*** laughterwym has joined #openstack-cinder | 08:43 | |
*** laughterwym has quit IRC | 08:47 | |
*** laughterwym has joined #openstack-cinder | 08:50 | |
*** boris-42 has joined #openstack-cinder | 08:52 | |
*** laughterwym has quit IRC | 08:55 | |
openstackgerrit | Béla Vancsics proposed openstack/cinder: Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B) https://review.openstack.org/284597 | 08:55 |
*** haomaiwa_ has quit IRC | 09:01 | |
*** Lallana has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-cinder | 09:01 | |
*** jistr has joined #openstack-cinder | 09:01 | |
*** Lallana has joined #openstack-cinder | 09:01 | |
openstackgerrit | LisaLi proposed openstack/cinder: Add necessary fields to volume creation https://review.openstack.org/284600 | 09:03 |
openstackgerrit | Maxim Nestratov proposed openstack/cinder: vzstorage: add ploop volume format support https://review.openstack.org/262246 | 09:06 |
openstackgerrit | Maxim Nestratov proposed openstack/cinder: vzstorage: fix creating and deleting snapshots of in-use volumes https://review.openstack.org/276465 | 09:06 |
openstackgerrit | Maxim Nestratov proposed openstack/cinder: Use versionedobjects in remotefs.py https://review.openstack.org/261558 | 09:06 |
*** mvk has joined #openstack-cinder | 09:09 | |
*** esp has joined #openstack-cinder | 09:10 | |
*** Oku_OS has joined #openstack-cinder | 09:10 | |
dulek | lixiaoy1_: Hi! | 09:12 |
lixiaoy1_ | dulek: I found a bug today, I need you to look, it may cause serious problem | 09:13 |
dulek | lixiaoy1_: Sure, I was reading through recent bugreports and seen some of yours. | 09:13 |
dulek | lixiaoy1_: Which one it is? | 09:13 |
lixiaoy1_ | dulek: https://bugs.launchpad.net/cinder/+bug/1549669 | 09:13 |
openstack | Launchpad bug 1549669 in Cinder "object get can't work when fields not valid" [High,Confirmed] - Assigned to Lisa Li (lisali) | 09:13 |
lixiaoy1_ | dulek: it is about ovo. | 09:14 |
dulek | lixiaoy1_: Oh, I see. | 09:14 |
*** esp has quit IRC | 09:14 | |
lixiaoy1_ | dulek: it leads qurey_all and query the invalid item not work | 09:15 |
*** jeanfabrice has joined #openstack-cinder | 09:15 | |
lixiaoy1_ | dulek: this case is probably happen when users upgrade to new release | 09:15 |
*** ildikov has quit IRC | 09:15 | |
dulek | lixiaoy1_: I wonder what motivations had thangp to make Volume.attach_status non-nullable in object while it's nullable in the DB. | 09:16 |
lixiaoy1_ | dulek: this problem is not only for this field. for any fields, if nullable is change in this release, or db module is different from object, it may lead problem | 09:17 |
dulek | lixiaoy1_: I agree, nullable status of a field should match. | 09:17 |
dulek | lixiaoy1_: How about simply changing the object to match what's in the DB? | 09:18 |
lixiaoy1_ | dulek: I am worried about other fields which may also have such problem. maybe we can fix this bug like you say. And we need to have UT to check | 09:19 |
lixiaoy1_ | dulek: db schema and objects match | 09:20 |
dulek | lixiaoy1_: That should be possible. | 09:20 |
dulek | lixiaoy1_: I can work on that if you want. | 09:20 |
lixiaoy1_ | dulek: that's ok. I can do it. as the backup bp is finished, I have time now :) | 09:21 |
lixiaoy1_ | dulek: I just want to confirm with you about the solution | 09:21 |
dulek | lixiaoy1_: I think the right thing to do is to keep them in sync. | 09:21 |
*** ndipanov has joined #openstack-cinder | 09:21 | |
*** yangyapeng has quit IRC | 09:21 | |
dulek | lixiaoy1_: I'll answer on the bugreport and will try to draft a UT idea for you. | 09:22 |
dulek | lixiaoy1_: I think we have a matching between models and objects done somewhere. ;) | 09:23 |
lixiaoy1_ | dulek: another issue is that we also have to check that there is no fields whose nullable is changed from true to false for liberty to mitaka | 09:23 |
lixiaoy1_ | dulek: that's good | 09:23 |
dulek | lixiaoy1_: This is very easy by just looking on DB migrations - quick check tells me that there weren't. | 09:24 |
lixiaoy1_ | dulek: yes :) | 09:24 |
lixiaoy1_ | dulek: you remind me | 09:25 |
dulek | lixiaoy1_: https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L4314-L4325 | 09:26 |
*** salv-orlando has joined #openstack-cinder | 09:27 | |
lixiaoy1_ | dulek: this is for name change between db models and versioned object. any problems? | 09:27 |
dulek | lixiaoy1_: In the UT you can iterate over objects like test_objects.TestObjectVersions.test_versions_history is doing. | 09:28 |
dulek | lixiaoy1_: And in the loop you can use this method to fetch the correct DB model for the Object and compare nullable statuses for fields and columns. | 09:29 |
lixiaoy1_ | dulek: yes! | 09:30 |
*** salv-orl_ has quit IRC | 09:30 | |
dulek | lixiaoy1_: I advice you to iterate over DB model columns and check obj fields and not the other way around. | 09:31 |
dulek | lixiaoy1_: Because sometimes there more fields than columns. | 09:31 |
dulek | lixiaoy1_: Yeah, that should work. :) | 09:31 |
lixiaoy1_ | dulek: nullable, default value, data type, need to check. how do you think | 09:32 |
dulek | lixiaoy1_: We can start with nullable, maybe default. | 09:32 |
lixiaoy1_ | dulek: ok | 09:32 |
dulek | data type is more complicated - UUID on Object is Varchar in the DB. Same for enums. | 09:33 |
*** yuriy_n17 has joined #openstack-cinder | 09:34 | |
lixiaoy1_ | dulek: got all. And will do it tomorrow | 09:35 |
dulek | lixiaoy1_: Okay, feel free to add me to the review. :) | 09:35 |
*** yangyapeng has joined #openstack-cinder | 09:35 | |
lixiaoy1_ | dulek: of course | 09:35 |
lixiaoy1_ | dulek: you give me the idea to fix it. | 09:36 |
openstackgerrit | xiaoqin proposed openstack/cinder: IBM Storwize pool aware support https://review.openstack.org/284614 | 09:37 |
dulek | lixiaoy1_: Ah, no, no Co-Authored-By, just as reviewer. | 09:41 |
dulek | lixiaoy1_: :P | 09:41 |
*** liverpooler has quit IRC | 09:41 | |
dulek | lixiaoy1_: So I can notice a new mail from Gerrit. :) | 09:41 |
lixiaoy1_ | dulek: ok reviewer :) | 09:41 |
*** liverpooler has joined #openstack-cinder | 09:42 | |
*** salv-orlando has quit IRC | 09:43 | |
abhishekk | hi all, could you please go through comments on https://bugs.launchpad.net/cinder/+bug/1540938 and update your thoughts for the same | 09:44 |
openstack | Launchpad bug 1540938 in Cinder "upload volume to image fails if disk-format is iso" [Undecided,New] - Assigned to Abhishek Kekane (abhishek-kekane) | 09:45 |
openstackgerrit | Dinesh Bhor proposed openstack/cinder: Fix error message in cinder type-update https://review.openstack.org/284618 | 09:45 |
*** laughterwym has joined #openstack-cinder | 09:46 | |
*** haomaiw__ has joined #openstack-cinder | 09:48 | |
*** haomaiwang has quit IRC | 09:49 | |
*** qeelee has quit IRC | 09:51 | |
*** laughterwym has quit IRC | 09:51 | |
*** jeanfabrice has quit IRC | 09:53 | |
*** davechen has left #openstack-cinder | 09:53 | |
*** grassy is now known as davechen_afk | 09:53 | |
*** haomaiw__ has quit IRC | 10:01 | |
*** ildikov has joined #openstack-cinder | 10:01 | |
*** Guest78071 has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-cinder | 10:01 | |
*** mvk has quit IRC | 10:01 | |
*** wilson has joined #openstack-cinder | 10:02 | |
*** cheneydc has quit IRC | 10:02 | |
*** wilson is now known as Guest73495 | 10:03 | |
openstackgerrit | xiaoqin proposed openstack/cinder: IBM Storwize with pool-aware-cinder-scheduler https://review.openstack.org/284614 | 10:04 |
*** EinstCrazy has quit IRC | 10:07 | |
*** EinstCrazy has joined #openstack-cinder | 10:07 | |
openstackgerrit | Béla Vancsics proposed openstack/cinder: Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B) https://review.openstack.org/284597 | 10:08 |
*** EinstCrazy has quit IRC | 10:12 | |
*** yangyapeng has quit IRC | 10:12 | |
*** qeelee has joined #openstack-cinder | 10:19 | |
*** jeanfabrice has joined #openstack-cinder | 10:20 | |
*** qeelee has quit IRC | 10:31 | |
*** lpetrut has joined #openstack-cinder | 10:39 | |
*** belmoreira has joined #openstack-cinder | 10:49 | |
openstackgerrit | Yuriy Nesenenko proposed openstack/python-brick-cinderclient-ext: Attach/detach features implementation https://review.openstack.org/263744 | 10:57 |
*** salv-orlando has joined #openstack-cinder | 10:59 | |
*** salv-orlando has quit IRC | 10:59 | |
*** salv-orlando has joined #openstack-cinder | 10:59 | |
*** slotti has joined #openstack-cinder | 11:00 | |
*** haomaiwang has quit IRC | 11:01 | |
slotti | Hey guys, I'm using cinder volume-types in liberty. Is it possible to set the default quota value for number of Volumes (is always -1 here) to another Value? | 11:01 |
*** haomaiwang has joined #openstack-cinder | 11:01 | |
*** sdague has joined #openstack-cinder | 11:06 | |
openstackgerrit | Wilson Liu proposed openstack/cinder: Huawei: delete_snapshot need not return any value https://review.openstack.org/284514 | 11:10 |
openstackgerrit | Wilson Liu proposed openstack/cinder: Add LUN wwn check in Huawei driver https://review.openstack.org/271592 | 11:20 |
*** erlon has joined #openstack-cinder | 11:20 | |
*** jordanP has joined #openstack-cinder | 11:25 | |
*** houming has quit IRC | 11:31 | |
arnewiebalck | slotti: I think this is what the default classes are for. | 11:32 |
arnewiebalck | default quota classes | 11:32 |
*** [1]Thelo has joined #openstack-cinder | 11:32 | |
*** wanghao has quit IRC | 11:33 | |
arnewiebalck | slotti: cinder help quota-class-update | 11:34 |
*** Thelo has quit IRC | 11:34 | |
*** [1]Thelo is now known as Thelo | 11:34 | |
*** wanghao has joined #openstack-cinder | 11:35 | |
*** ankit_ag has quit IRC | 11:37 | |
*** ankit_ag has joined #openstack-cinder | 11:37 | |
*** aagrawal has quit IRC | 11:41 | |
*** gcb has quit IRC | 11:42 | |
*** EinstCrazy has joined #openstack-cinder | 11:43 | |
*** gcb has joined #openstack-cinder | 11:43 | |
*** laughterwym has joined #openstack-cinder | 11:53 | |
openstackgerrit | Gábor Antal proposed openstack/cinder: Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B) https://review.openstack.org/284597 | 11:57 |
*** tpsilva has joined #openstack-cinder | 11:58 | |
*** haomaiwang has quit IRC | 12:01 | |
*** haomaiwang has joined #openstack-cinder | 12:01 | |
*** fthiagogv has quit IRC | 12:10 | |
*** adrianofr_ has joined #openstack-cinder | 12:11 | |
openstackgerrit | Béla Vancsics proposed openstack/cinder: Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B) https://review.openstack.org/284597 | 12:12 |
slotti | arnewiebalck: Thank you :-) tried that using project_id as class... didn't know there is a class called default. | 12:18 |
*** yhayashi has quit IRC | 12:19 | |
*** Lee1092 has quit IRC | 12:22 | |
*** jeanfabrice has quit IRC | 12:22 | |
*** haomaiwang has quit IRC | 12:31 | |
*** raildo-afk is now known as raildo | 12:37 | |
*** yangyapeng has joined #openstack-cinder | 12:37 | |
*** zul has quit IRC | 12:43 | |
*** zul has joined #openstack-cinder | 12:44 | |
*** diogogmt has joined #openstack-cinder | 12:46 | |
*** fthiagogv has joined #openstack-cinder | 12:53 | |
*** salv-orlando has quit IRC | 12:56 | |
*** dave-mccowan has joined #openstack-cinder | 12:56 | |
*** akerr has joined #openstack-cinder | 13:00 | |
yuriy_n17 | hemnafk: Hi! Very sorry for disturbing. Please review https://review.openstack.org/#/c/263744/ whenever you have free time. Thanks a lot for advance. | 13:01 |
*** takedakn has joined #openstack-cinder | 13:02 | |
*** smoriya_ has quit IRC | 13:02 | |
*** ildikov has quit IRC | 13:03 | |
*** edmondsw has joined #openstack-cinder | 13:04 | |
openstackgerrit | Sheel Rana proposed openstack/cinder: Adding verbose to error during volume create https://review.openstack.org/284571 | 13:04 |
*** yangyapeng has quit IRC | 13:08 | |
*** yangyapeng has joined #openstack-cinder | 13:09 | |
*** diogogmt has quit IRC | 13:10 | |
*** yangyape_ has joined #openstack-cinder | 13:13 | |
*** takedakn has quit IRC | 13:15 | |
*** yangyapeng has quit IRC | 13:16 | |
*** timcl has joined #openstack-cinder | 13:17 | |
*** gouthamr has joined #openstack-cinder | 13:22 | |
*** links has quit IRC | 13:26 | |
openstackgerrit | Sheel Rana proposed openstack/cinder: Added Bootable filter for cinder list command https://review.openstack.org/278605 | 13:29 |
*** jseiler has quit IRC | 13:32 | |
openstackgerrit | Béla Vancsics proposed openstack/cinder: Reduced the complexity of the send_cmd method (in ProphetStor) https://review.openstack.org/250517 | 13:37 |
*** ankit_ag has quit IRC | 13:37 | |
openstackgerrit | Sheel Rana proposed openstack/cinder: Adding verbose to error during volume create https://review.openstack.org/284571 | 13:39 |
openstackgerrit | Béla Vancsics proposed openstack/cinder: Reduce code duplication (in the ssc_cmode.py) https://review.openstack.org/251478 | 13:42 |
*** shyama has quit IRC | 13:44 | |
*** dims has joined #openstack-cinder | 13:47 | |
scottda | dulek: Hi | 13:49 |
*** ildikov has joined #openstack-cinder | 13:50 | |
*** martyturner has joined #openstack-cinder | 13:50 | |
*** xyang1 has joined #openstack-cinder | 13:52 | |
*** JoseMello has joined #openstack-cinder | 13:55 | |
*** Poornima has quit IRC | 13:55 | |
*** zzzeek has joined #openstack-cinder | 13:57 | |
*** zzzeek has quit IRC | 13:58 | |
*** salv-orlando has joined #openstack-cinder | 13:58 | |
*** zzzeek has joined #openstack-cinder | 13:58 | |
*** porrua has joined #openstack-cinder | 14:00 | |
*** shyama has joined #openstack-cinder | 14:01 | |
*** edtubill has joined #openstack-cinder | 14:03 | |
*** salv-orlando has quit IRC | 14:03 | |
*** edtubill has quit IRC | 14:04 | |
*** edtubill has joined #openstack-cinder | 14:04 | |
*** links has joined #openstack-cinder | 14:07 | |
dulek | scottda: Hi, what's up? | 14:07 |
scottda | dulek: sorry, give me a minute. Nova meeting right now... | 14:08 |
*** slotti has quit IRC | 14:08 | |
*** andymaier has joined #openstack-cinder | 14:08 | |
*** jgregor has joined #openstack-cinder | 14:11 | |
*** rlrossit_ has joined #openstack-cinder | 14:15 | |
scottda | dulek: Saw your comments on the "remove pypi" patch | 14:16 |
dulek | scottda: Ah, right. Tempest is down, so maybe I'm wrong. | 14:17 |
scottda | dulek: I'm not sure what caused this issue. I did hear in Nova meeting that there was a nasty gate bug, and the fix just merged. | 14:17 |
scottda | dulek: OK. That patch could probably use a 'reverify', maybe after a while to ensure that gate bug fix goes through. I'm not sure on the details. | 14:17 |
dulek | scottda: I agree. :) | 14:18 |
scottda | cool. I've had my morning coffee. Crisis potentially averted. On to the next thing..... | 14:18 |
*** rlrossit_ has quit IRC | 14:19 | |
dulek | Sorry for suggesting it may be your patch, but "policy" ringed a bell for me. | 14:19 |
*** rlrossit has joined #openstack-cinder | 14:19 | |
scottda | dulek: No problem. Microversions just merged and then this broke. I'd suspect the same thing. | 14:20 |
*** merooney has joined #openstack-cinder | 14:20 | |
smcginnis | dulek: We can just blame scottda for everything for a while now. ;) | 14:30 |
openstackgerrit | Evgeny Antyshev proposed openstack/cinder: Move test from test_glusterfs and test_quobyte to test_remotefs https://review.openstack.org/261549 | 14:33 |
openstackgerrit | Evgeny Antyshev proposed openstack/cinder: Use versionedobjects in remotefs.py https://review.openstack.org/261558 | 14:33 |
kaisers | Hi Cinders! If you have experience with libvirt supported migrations perhaps take a glance at https://bugs.launchpad.net/nova/+bug/1549828 , I'd appreciate any help with that. :) | 14:33 |
openstack | Launchpad bug 1549828 in OpenStack Compute (nova) "permission denied on console.log during some migrations" [Undecided,New] | 14:33 |
kaisers | eharney: ping ^^^^^^ | 14:33 |
*** cknight has joined #openstack-cinder | 14:39 | |
*** dustins has joined #openstack-cinder | 14:39 | |
*** tsekiyama has joined #openstack-cinder | 14:40 | |
*** mriedem has joined #openstack-cinder | 14:40 | |
*** jwcroppe has joined #openstack-cinder | 14:44 | |
*** Yogi1 has joined #openstack-cinder | 14:47 | |
*** markstur_ has joined #openstack-cinder | 14:54 | |
scottda | smcginnis: dulek Weren't we just discussing paranoia yesterday? I definitely think it's a healthy attitude... | 14:55 |
*** merooney has quit IRC | 14:56 | |
*** markstur_ has left #openstack-cinder | 14:57 | |
smcginnis | ;) | 14:58 |
*** diogogmt has joined #openstack-cinder | 14:59 | |
*** eharney has joined #openstack-cinder | 15:00 | |
*** merooney has joined #openstack-cinder | 15:01 | |
*** baumann has joined #openstack-cinder | 15:02 | |
*** baumann has quit IRC | 15:03 | |
*** PsionTheory has joined #openstack-cinder | 15:04 | |
*** baumann has joined #openstack-cinder | 15:04 | |
*** diablo_rojo has joined #openstack-cinder | 15:07 | |
*** salv-orlando has joined #openstack-cinder | 15:08 | |
*** links has quit IRC | 15:12 | |
*** e0ne has joined #openstack-cinder | 15:13 | |
*** arecknag has quit IRC | 15:14 | |
*** salv-orlando has quit IRC | 15:15 | |
arnewiebalck | Is there a way to have metadata associated with volume types? Think “intended_usage” as an example. | 15:15 |
*** knikolla has joined #openstack-cinder | 15:16 | |
*** nkrinner has quit IRC | 15:16 | |
*** anshul has quit IRC | 15:16 | |
merooney | hey xyang1, got an all-green run on https://review.openstack.org/#/c/283194/4 Should be ready for you now :) | 15:17 |
xyang1 | merooney: sure | 15:18 |
*** garthb_ has joined #openstack-cinder | 15:18 | |
*** garthb has joined #openstack-cinder | 15:18 | |
*** merooney has quit IRC | 15:18 | |
*** kfarr has joined #openstack-cinder | 15:19 | |
*** merooney has joined #openstack-cinder | 15:23 | |
*** jungleboyj has joined #openstack-cinder | 15:23 | |
*** boichev2 has joined #openstack-cinder | 15:24 | |
*** PsionTheory has quit IRC | 15:26 | |
*** boichev has quit IRC | 15:26 | |
*** chris_mo_ has quit IRC | 15:26 | |
DuncanT | arnewiebalck: There's the description field? | 15:27 |
*** sdague has quit IRC | 15:32 | |
arnewiebalck | DuncanT: Wasn’t aware of that one. That should do, thx! | 15:32 |
*** Yogi1 has quit IRC | 15:34 | |
*** liverpooler has quit IRC | 15:36 | |
*** wilson has joined #openstack-cinder | 15:37 | |
*** wilson is now known as Guest5289 | 15:37 | |
*** Guest5289 has quit IRC | 15:37 | |
*** wilson_liu has joined #openstack-cinder | 15:38 | |
mc_nair | dulek: do you know if there's a config setting to specify the DB connection pool size? Saw that https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L625 doesn't have a config for pool_size, but wanted to verify | 15:40 |
*** e0ne has quit IRC | 15:40 | |
*** e0ne_ has joined #openstack-cinder | 15:41 | |
dulek | mc_nair: Sorry, I have no idea. Probably option may be hidden inside oslo.db, but I don't really know. Maybe #openstack-oslo? | 15:42 |
*** mtanino has joined #openstack-cinder | 15:43 | |
*** lprice1 has joined #openstack-cinder | 15:43 | |
*** knikolla has quit IRC | 15:43 | |
mc_nair | dulek: thanks, will do. You're the first stop for all DB questions :) | 15:44 |
*** lprice has quit IRC | 15:44 | |
*** kaisers_ has joined #openstack-cinder | 15:45 | |
*** darosale has joined #openstack-cinder | 15:46 | |
dulek | mc_nair: I probably shouldn't be, I just got some knowledge on how Nova classifies things… | 15:46 |
dulek | mc_nair: Or maybe I need to learn more to be worthy the hopes you have. ;) | 15:46 |
mc_nair | dulek: yea, that sounds easiest for everyone :) | 15:48 |
dulek | Damn… | 15:49 |
openstackgerrit | Scott DAngelo proposed openstack/python-cinderclient: api-microversion support for python-cinderclient https://review.openstack.org/248163 | 15:49 |
*** aorourke-afk is now known as aorourke | 15:49 | |
*** e0ne_ has quit IRC | 15:52 | |
*** mtanino has quit IRC | 15:52 | |
openstackgerrit | Alex O'Rourke proposed openstack/cinder: WIP - 3PAR: Update replication to v2.1 https://review.openstack.org/279307 | 15:53 |
*** darosale has quit IRC | 15:54 | |
*** daneyon has joined #openstack-cinder | 15:56 | |
scottda | smcginnis: There's ^^^ a working /v3 enpdoint cinderclient that passes unit tests (except 1 with Mock issues I need to fix, but am skipping) | 15:57 |
*** daneyon_ has joined #openstack-cinder | 15:57 | |
*** kaisers_ has quit IRC | 15:57 | |
smcginnis | scottda: Sweet, thanks! | 15:57 |
scottda | It could use a high-level look from Cores/others regarding how I've moved /v2 stuff to /v3. Seems like a good way (stolen from Manila) but results in a bunch of copy to new dir and removal from old. So equals a lot of LOC. | 15:58 |
*** kaisers_ has joined #openstack-cinder | 15:58 | |
smcginnis | Stealing is good. :) | 15:58 |
*** wilson_liu has quit IRC | 15:59 | |
*** kaisers_ has quit IRC | 15:59 | |
scottda | sorry, should have said 'leveraging' | 15:59 |
smcginnis | haha | 15:59 |
*** knikolla has joined #openstack-cinder | 15:59 | |
*** merooney has quit IRC | 15:59 | |
*** daneyon has quit IRC | 16:00 | |
*** timcl1 has joined #openstack-cinder | 16:01 | |
*** kvidvans has quit IRC | 16:02 | |
bswartz | "good artists borrow, great artists steal" -- attributed to picasso? | 16:02 |
yuriy_n17 | hemnafk: ping ^^ | 16:02 |
scottda | I nominate bswartz for Quote Czar | 16:03 |
*** timcl has quit IRC | 16:03 | |
*** mtanino has joined #openstack-cinder | 16:03 | |
*** merooney has joined #openstack-cinder | 16:03 | |
Swanson | bswartz, by that logic I'm a great neighbor. | 16:05 |
*** garthb has quit IRC | 16:06 | |
*** garthb_ has quit IRC | 16:06 | |
*** dims has quit IRC | 16:06 | |
*** mylu has joined #openstack-cinder | 16:08 | |
*** diogogmt has quit IRC | 16:08 | |
*** daneyon_ has quit IRC | 16:11 | |
*** merooney has quit IRC | 16:12 | |
*** sdague has joined #openstack-cinder | 16:14 | |
*** crose has joined #openstack-cinder | 16:18 | |
*** timcl1 has quit IRC | 16:19 | |
*** laughterwym has quit IRC | 16:20 | |
*** avishay has joined #openstack-cinder | 16:21 | |
*** anshul has joined #openstack-cinder | 16:23 | |
*** haomaiwa_ has joined #openstack-cinder | 16:24 | |
*** belmoreira has quit IRC | 16:27 | |
*** mylu has quit IRC | 16:30 | |
*** arch-nemesis has joined #openstack-cinder | 16:30 | |
*** mylu has joined #openstack-cinder | 16:31 | |
*** anshul has quit IRC | 16:34 | |
*** merooney has joined #openstack-cinder | 16:36 | |
*** merooney has quit IRC | 16:38 | |
*** salv-orlando has joined #openstack-cinder | 16:38 | |
*** JoseMello has quit IRC | 16:38 | |
*** sheel has joined #openstack-cinder | 16:39 | |
*** sgotliv has quit IRC | 16:39 | |
*** timcl has joined #openstack-cinder | 16:40 | |
*** JoseMello has joined #openstack-cinder | 16:41 | |
*** salv-orlando has quit IRC | 16:41 | |
*** ntpttr has joined #openstack-cinder | 16:41 | |
*** salv-orlando has joined #openstack-cinder | 16:41 | |
*** EinstCrazy has quit IRC | 16:46 | |
sdague | fyi, it looks like cinder unit tests are borked, and all cinder patches will fail until it's dealt with | 16:47 |
sheel | hey all | 16:47 |
sheel | why below test is getting failed | 16:47 |
sheel | https://www.irccloud.com/pastebin/LyHGJOOg/ | 16:47 |
smcginnis | sdague: That's not the previous gate issues? | 16:47 |
sdague | http://logs.openstack.org/94/283194/4/gate/gate-cinder-python27/993b7b8/console.html#_2016-02-25_16_04_54_985 | 16:47 |
sdague | no, unit tests | 16:48 |
sheel | This is on fresh cinder repo | 16:48 |
smcginnis | sdague: We've had a few pass recently. | 16:48 |
sdague | ok, you have 3 failing in the gate | 16:48 |
smcginnis | sdague: K, I'll take a look. Thanks for the heads up. | 16:48 |
sdague | right now | 16:48 |
eharney | netapp unit test failure, and we just landed a patch for those tests to support py3... https://review.openstack.org/#/c/280331/ | 16:49 |
sheel | eharney: yes, its netapp | 16:49 |
smcginnis | Gerrit down now? I get a Service Unavailable | 16:49 |
eharney | gerrit's having some issues today | 16:50 |
*** crose has quit IRC | 16:51 | |
*** crose has joined #openstack-cinder | 16:51 | |
scottda | So it's not microversions? | 16:51 |
openstackgerrit | Sheel Rana proposed openstack/cinder: Add verbose logging for multibyte unicode errors https://review.openstack.org/284571 | 16:51 |
smcginnis | scottda: Guilty until proven innocent. | 16:51 |
scottda | That's how I think. This is turning out to be a stressful day. | 16:52 |
eharney | i'm going to just assume it's microversions, because the git commit message for that is too wide to read in my terminal :) | 16:52 |
smcginnis | Hah | 16:52 |
*** ivase has joined #openstack-cinder | 16:53 | |
smcginnis | Hmm, can't repro UT failures locally. | 16:53 |
eharney | me neither so far... | 16:53 |
sheel | smcginnis: I have pasted same above | 16:53 |
*** mylu has quit IRC | 16:53 | |
sheel | its failing on my end locally | 16:53 |
sheel | on fresh cinder checkout | 16:53 |
eharney | smcginnis: maybe need a new tox env? | 16:54 |
sheel | https://www.irccloud.com/pastebin/LyHGJOOg/ | 16:54 |
*** dims has joined #openstack-cinder | 16:54 | |
smcginnis | Trying fresh. | 16:54 |
*** mylu has joined #openstack-cinder | 16:54 | |
smcginnis | Aaaand, awesome. Can't even kick off tests now. | 16:54 |
mtanino | umm, I'm hitting netapp unit test error with latest master branch.... | 16:55 |
eharney | mtanino: see the above conversation :) | 16:55 |
*** chris_morrell has joined #openstack-cinder | 16:55 | |
sheel | tox -epy27 -- --no-discover cinder.tests.unit.volume.drivers.netapp.dataontap.test_block_base.NetAppBlockStorageLibraryTestCase.test_get_reserved_percentage | 16:55 |
sheel | specifically for this test | 16:55 |
mtanino | eharney: yes, I read it thanks :) | 16:55 |
eharney | so the failure is related to mocking out log calls... ooh, this will be a fun one | 16:56 |
sheel | LOG.WARN | 16:57 |
smcginnis | eharney: Bah!! Still not happy with anything with logging in UTs. | 16:58 |
eharney | asserting that LOG.warn was not called may be risky, since that could be called by about anything | 16:58 |
*** garthb has joined #openstack-cinder | 16:58 | |
*** garthb_ has joined #openstack-cinder | 16:59 | |
smcginnis | <rant deleted> | 17:00 |
openstackgerrit | Vivek Dhayaal proposed openstack/cinder: Fix usage of "cinder-volume" string https://review.openstack.org/283225 | 17:00 |
*** haomaiwa_ has quit IRC | 17:01 | |
*** esker has quit IRC | 17:01 | |
*** haomaiwang has joined #openstack-cinder | 17:01 | |
smcginnis | Oh! How did that get in. | 17:02 |
smcginnis | LOG.warn is deprecated, so LOG.warn won't get called. | 17:02 |
smcginnis | LOG.warning | 17:02 |
eharney | it probably worked when it was first written | 17:03 |
openstackgerrit | Eric Harney proposed openstack/cinder: Tests: Don't assert on LOG.warn https://review.openstack.org/284816 | 17:04 |
eharney | that's my proposal until anyone has a better idea ^ | 17:04 |
*** zhipeng has joined #openstack-cinder | 17:04 | |
xyang1 | smcginnis: any other objections on cheese cake? ready to merge? | 17:05 |
Swanson | mergemergemergemerge | 17:05 |
smcginnis | xyang1: Yeah, I'd like to have it go in and have issues fixed as we go. | 17:06 |
xyang1 | smcginnis: done | 17:07 |
smcginnis | Most of it is good, so rather than having to churn over a big patch on smaller things, I'd rather we have smaller focused patches. | 17:07 |
smcginnis | xyang1: At least that's my take. ;) | 17:07 |
xyang1 | smcginnis: sure | 17:07 |
smcginnis | eharney: versionutils update? | 17:07 |
smcginnis | That code (UT and code under test) hasn't changed since 8/2015 | 17:08 |
Swanson | having to keep merging that patch endlessly will push jgriffith to drink and horse. | 17:08 |
smcginnis | There is also no direct logging, just a call to versionutils.report_deprecated_feature. | 17:08 |
smcginnis | Swanson: It will make his horses drink. | 17:08 |
*** jistr has quit IRC | 17:08 | |
mtanino | eharney: or self.assertTrue(block_base.LOG.warning.called) works for me | 17:08 |
Swanson | smcginnis, :) | 17:08 |
smcginnis | mtanino: Yeah, looks like versionutils must have updated to switch LOG.warn to LOG.warning. | 17:09 |
eharney | that doesn't make sense though, that just means it's not a valid thing to test | 17:09 |
smcginnis | eharney: Exactly. I'm for your patch. | 17:09 |
eharney | the test needs to assert that a warning with some specific text appeared or not if it really wants to check that | 17:09 |
smcginnis | Just get rid of them. | 17:09 |
mtanino | eharney: ok. I understand your opinion. | 17:09 |
avishay | ...the fear when you see you are reaching 80 characters will be with me forever... | 17:10 |
smcginnis | NO! No specific text. :) | 17:10 |
smcginnis | avishay: ;) | 17:10 |
*** bardia has joined #openstack-cinder | 17:10 | |
smcginnis | avishay: I find myself watching that with non-Python non-OS code too. | 17:10 |
sheel | :) | 17:11 |
avishay | smcginnis: :) | 17:11 |
eharney | while on the subject of warnings, i'm about to submit a different patch related to how we handle warnings in Cinder logging too | 17:13 |
smcginnis | eharney: Oh? In what way? | 17:13 |
eharney | smcginnis: modules that issue messages via the warnings module spit them out to stderr instead of our logs | 17:13 |
eharney | smcginnis: which is pretty not great | 17:13 |
smcginnis | eharney: Oh, the whole "warnings.warn()" thing? | 17:14 |
eharney | some oslo ones do this (Deprecation), python-amqp does this | 17:14 |
eharney | smcginnis: yeah | 17:14 |
smcginnis | eharney: Cool! | 17:14 |
Swanson | avishay, I find it thrilling when you just fit a line in at 80 chars! And heartbreaking when you have to split it.... | 17:14 |
*** timcl has quit IRC | 17:14 | |
dims | eharney : smcginnis : oslo has a debtcollector library that helps with the deprecation stuff as well (http://docs.openstack.org/developer/debtcollector/api.html) | 17:15 |
smcginnis | dims: Thanks, I hadn't looked at that one. | 17:16 |
dims | some examples here - http://docs.openstack.org/developer/debtcollector/examples.html#removing-a-class-classmethod-method-function | 17:16 |
openstackgerrit | John Griffith proposed openstack/cinder: Change frozen error messages from _LE to _ https://review.openstack.org/284823 | 17:16 |
openstackgerrit | Kendall Nelson proposed openstack/cinder: WIP: Add SnapshotStatus enum field https://review.openstack.org/284825 | 17:17 |
avishay | Swanson: yep :) | 17:17 |
*** wilson_liu has joined #openstack-cinder | 17:20 | |
*** Guest73495 has quit IRC | 17:20 | |
jgriffith | xyang1: 284823 fixes those logging hints up, thanks! | 17:20 |
smcginnis | jgriffith: Thanks for that. ^^ | 17:20 |
jgriffith | smcginnis: NP | 17:20 |
xyang1 | jgriffith: great, thanks for the quick fix | 17:21 |
*** leeantho has joined #openstack-cinder | 17:21 | |
jgriffith | smcginnis: have I mentioned my distaste for /cinder/tests/unit/test_volume.py today? | 17:21 |
*** krtaylor has quit IRC | 17:21 | |
smcginnis | jgriffith: Hah, not today yet. :) | 17:21 |
jgriffith | smcginnis: ok... well consider it mentioned | 17:21 |
eharney | jgriffith: but it has every flavor that exists in it! | 17:22 |
eharney | ;) | 17:22 |
jgriffith | eharney: :) | 17:22 |
smcginnis | eharney: You broke out some of that, right? | 17:22 |
eharney | smcginnis: yeah, but i slowed down on the continuation of that | 17:22 |
jgriffith | eharney: it's sad because you've cleaned up so many things in it, but it's still rather bloated | 17:22 |
eharney | i chopped some of it into separate classes which still need to be split into different files | 17:22 |
tbarron | eharney: smcginnis: mtanino: sheel: well this is too much fun, I am the culprit on that mock of LOG.warn | 17:22 |
jgriffith | eharney: and some fairly crazy logic in there as well | 17:22 |
smcginnis | eharney: You don't want to work on unit test refactoring full time? :) | 17:22 |
tbarron | eharney: thanks! | 17:22 |
*** mylu has quit IRC | 17:22 | |
smcginnis | tbarron: It was fine at the time. | 17:23 |
jgriffith | smcginnis: ohh... I think that's a GREAT idea :) | 17:23 |
jgriffith | eharney: I'll come and visit you in the institution | 17:23 |
tbarron | smcginnis: mocking LOG globally is not good | 17:23 |
eharney | lol | 17:23 |
sheel | tbarron: oops | 17:23 |
tbarron | smcginnis: probably shouldn't do it at all | 17:23 |
tbarron | or if there's a real reason, mock it in smaller scope | 17:24 |
jgriffith | tbarron: just curious why you would do it at all as you mentioend? | 17:24 |
smcginnis | tbarron: Yeah. And asserting on a library doing logging probably isn't too good either. | 17:24 |
tbarron | jgriffith: i was learning :-) | 17:24 |
jgriffith | smcginnis: I thought the test framework did that for us anyway | 17:24 |
jgriffith | tbarron: ahh... fair enough :) | 17:24 |
tbarron | jgriffith: we had a mandate to get as much coverage as possible | 17:24 |
openstackgerrit | Eric Harney proposed openstack/cinder: Capture warnings into logs https://review.openstack.org/284828 | 17:24 |
jgriffith | tbarron: LOL | 17:24 |
smcginnis | eharney: Oh, just thought of something. | 17:25 |
eharney | smcginnis: there's the other warning thing ^ | 17:25 |
tbarron | jgriffith: and I got too enthusiastic | 17:25 |
jgriffith | coverage for the sake of coverage eh | 17:25 |
smcginnis | eharney: Probably should have pulled out the "self.mock_object(block_base, 'LOG')" lines in those tests too. | 17:25 |
smcginnis | eharney: Harmless I guess, but not really needed. | 17:25 |
eharney | smcginnis: well, i looked at self.mock_object for a minute (which is used everywhere) and kinda decided i would pretend it didn't exist | 17:25 |
tbarron | jgriffith: well, like all guidelines, it requires intelligence (that I didn't exercise in this case) on the part of the person following it | 17:25 |
*** haplo37 has joined #openstack-cinder | 17:25 | |
smcginnis | eharney: ;) | 17:26 |
eharney | smcginnis: because using something like that always has be worried about whether the mocks are cleaned up right, etc | 17:26 |
openstackgerrit | Kendall Nelson proposed openstack/cinder: WIP: Add SnapshotStatus enum field https://review.openstack.org/284825 | 17:26 |
jgriffith | tbarron: haha | 17:26 |
eharney | but yeah, i missed it as far as removing it | 17:26 |
tbarron | lately I've been mocking time.time() and such. Am learning to do it with as narrow scope as possible :-) | 17:26 |
tbarron | there's a lot to learn about mock | 17:27 |
smcginnis | tbarron: Really, time.time() has been mocking me. | 17:27 |
tbarron | time is unreal | 17:27 |
openstackgerrit | Merged openstack/python-cinderclient: Remove pypy from tox environment list https://review.openstack.org/283215 | 17:27 |
tbarron | a position that I have learned to take aas the years have passed | 17:27 |
Swanson | time.time() gets all men. | 17:27 |
tbarron | pretty deep, Homer | 17:28 |
*** julim has quit IRC | 17:28 | |
eharney | i also feel like Homer when i work on unit tests | 17:29 |
eharney | it's just "Doh! Doh! Doh!" over and over | 17:29 |
smcginnis | :) | 17:29 |
*** merooney has joined #openstack-cinder | 17:30 | |
*** asti_ has joined #openstack-cinder | 17:33 | |
*** krtaylor has joined #openstack-cinder | 17:33 | |
*** jordanP has quit IRC | 17:35 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Delete volumes with snapshots https://review.openstack.org/264982 | 17:36 |
*** jwcroppe has quit IRC | 17:38 | |
*** jwcroppe has joined #openstack-cinder | 17:39 | |
openstackgerrit | Merged openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/282768 | 17:40 |
Swanson | Cinder patches are drowning in a sea of blood. Might want to skip +A'ing and rechecking until that is sorted. | 17:40 |
*** mylu has joined #openstack-cinder | 17:43 | |
*** jwcroppe has quit IRC | 17:43 | |
*** asti_ has left #openstack-cinder | 17:44 | |
*** asti_ has joined #openstack-cinder | 17:45 | |
*** crose has quit IRC | 17:47 | |
*** bardia has quit IRC | 17:49 | |
*** avishay has quit IRC | 17:49 | |
jgriffith | Swanson: ? | 17:51 |
Swanson | Seems better now. I presume it was the failures being talked about earlier. | 17:51 |
*** apoorvad has joined #openstack-cinder | 17:52 | |
*** crose has joined #openstack-cinder | 17:53 | |
*** jwcroppe has joined #openstack-cinder | 17:58 | |
*** timcl has joined #openstack-cinder | 18:00 | |
*** haomaiwang has quit IRC | 18:01 | |
*** hemna has joined #openstack-cinder | 18:01 | |
*** haomaiwang has joined #openstack-cinder | 18:01 | |
*** mylu has quit IRC | 18:02 | |
*** ndipanov has quit IRC | 18:07 | |
*** lpetrut has quit IRC | 18:08 | |
*** julim has joined #openstack-cinder | 18:10 | |
*** wilson_liu has quit IRC | 18:14 | |
*** wilson-l has joined #openstack-cinder | 18:14 | |
*** tsekiyama has quit IRC | 18:16 | |
*** wanghao has quit IRC | 18:17 | |
*** wanghao has joined #openstack-cinder | 18:17 | |
openstackgerrit | Merged openstack/python-cinderclient: Add extra_specs_list test https://review.openstack.org/282075 | 18:18 |
aorourke | jgriffith, the issue of the active_backend_id not being passed into the driver if c-vol is restarted after fail-over still exists | 18:19 |
*** annasort has quit IRC | 18:19 | |
aorourke | jgriffith, i can have my driver save off the new active_backend_id no problem, but if c-vol is restarted, i lose that entry | 18:20 |
aorourke | jgriffith, the disabled services are filtered out of the query used here: https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L423 so the service is not found. how can we handle the case where c-vol is restarted? | 18:22 |
jgriffith | aorourke: don't use that query | 18:26 |
aorourke | jgriffith, it is done in the manager | 18:27 |
aorourke | jgriffith, on driver init | 18:27 |
jgriffith | aorourke: Yes, my point is that I think that's a bug outside of replication | 18:27 |
jgriffith | aorourke: if someone disables the service that should be honored on a restart, looking at the existing code that doesn't appear to be the case | 18:28 |
jgriffith | aorourke: see what I mean? | 18:28 |
aorourke | jgriffith, maybe it is. Either way, if c-vol is restarted or the driver is re-initialized, fail-over no longer works | 18:28 |
aorourke | jgriffith, the driver has no access to the active_backend_id | 18:28 |
jgriffith | aorourke: yeah, I got ya on that | 18:28 |
jgriffith | aorourke: I can fix that | 18:28 |
jgriffith | aorourke: going to be a bit before I get it fired up and running again though | 18:31 |
aorourke | jgriffith, followup patch then? Looks like your patch has been +A'd | 18:31 |
jgriffith | aorourke: yeah, follow up as bug fix for restarts | 18:32 |
aorourke | jgriffith, sounds good | 18:32 |
*** salv-orlando has quit IRC | 18:32 | |
*** hemna has quit IRC | 18:33 | |
*** Suyash has joined #openstack-cinder | 18:37 | |
*** salv-orlando has joined #openstack-cinder | 18:39 | |
*** haomaiwang has quit IRC | 18:39 | |
*** hemna has joined #openstack-cinder | 18:40 | |
*** asti_ has left #openstack-cinder | 18:42 | |
openstackgerrit | Yucong Feng proposed openstack/cinder: Return all target_wwpns for FC storwize https://review.openstack.org/282541 | 18:42 |
*** haomaiwang has joined #openstack-cinder | 18:44 | |
*** bardia has joined #openstack-cinder | 18:45 | |
anteaya | jungleboyj: are you at the ibm site in rochester? and are you coming to the neutron sprint? (or have you been already?) | 18:48 |
openstackgerrit | John Griffith proposed openstack/cinder: Add connector info to volume_attachment table https://review.openstack.org/284867 | 18:49 |
*** haomaiwang has quit IRC | 18:49 | |
jungleboyj | anteaya: I am at the IBM site but I don't know that I am going to make it over there. It has been a very busy week. | 18:49 |
anteaya | jungleboyj: I hear that | 18:51 |
*** merooney has quit IRC | 18:51 | |
anteaya | would be great to see you if you can make it over | 18:51 |
*** hemna has quit IRC | 18:52 | |
smcginnis | anteaya: Missed you. I was there the last two days but had to get back to work. | 18:52 |
anteaya | smcginnis: :( sorry I missed you | 18:53 |
anteaya | would have been great to see you | 18:53 |
anteaya | was it beneficial to be here do you think? | 18:53 |
*** mvk has joined #openstack-cinder | 18:54 | |
*** IlyaG has quit IRC | 18:54 | |
smcginnis | anteaya: Yeah, it was good to meet some of the folks I don't normally interact with. | 18:54 |
smcginnis | A couple of interesting discussions as well. | 18:55 |
*** dramakri has joined #openstack-cinder | 18:55 | |
*** ChubYann has joined #openstack-cinder | 18:55 | |
anteaya | nice to hear | 18:55 |
anteaya | glad you could make it down for a few days | 18:55 |
smcginnis | anteaya: You got lucky with the weather. This is overall pretty good for Feb. | 18:56 |
*** lpetrut has joined #openstack-cinder | 18:56 | |
anteaya | way warm | 18:56 |
anteaya | home keeps getting rain | 18:56 |
anteaya | it is supposed to be a steady -10 at home at least | 18:57 |
*** cknight has quit IRC | 18:57 | |
anteaya | and it isn't | 18:57 |
anteaya | :( | 18:57 |
smcginnis | At least you're getting a little sunshine here. | 18:57 |
anteaya | our local economy is hurting as we are tourist based and also logging | 18:57 |
anteaya | sunshine is good! | 18:57 |
smcginnis | anteaya: Oh yeah, didn't think of that. | 18:57 |
*** cknight has joined #openstack-cinder | 18:58 | |
anteaya | hard on tourism when they keep falling through the ice when they shouldn't be on it in the first place | 18:58 |
*** hemna has joined #openstack-cinder | 18:58 | |
anteaya | but they don't think of that | 18:58 |
smcginnis | Hah, I suppose. | 18:58 |
smcginnis | Well, off to a meeting. Have fun! | 18:59 |
anteaya | thanks, happy meeting | 18:59 |
*** merooney has joined #openstack-cinder | 18:59 | |
*** esker has joined #openstack-cinder | 19:01 | |
*** daneyon has joined #openstack-cinder | 19:02 | |
ntpttr | is the volume status 'maintenance' only reserved for migration or is there anything else its used for? | 19:05 |
*** daneyon has quit IRC | 19:06 | |
sdague | hey, can folks stop approving cinder patches until the unit tests are fixed? | 19:06 |
sdague | oh, sorry, looks like they did. I had an old zuul screen with different fails. | 19:07 |
sdague | never mind | 19:07 |
hemna | doh | 19:07 |
sdague | though, I haven't seen the fixed change post into the gate yet, so I have no idea if it's fixed or not | 19:10 |
eharney | check jobs haven't even started running on the fix yet | 19:10 |
sdague | eharney: ah | 19:10 |
sdague | the mad rush after the gate fix? | 19:11 |
eharney | https://review.openstack.org/#/c/284816/ is the patch to fix it | 19:12 |
*** angela-s has joined #openstack-cinder | 19:14 | |
Swanson | 373 patch queue. Then gate. Soooo... Sometime sunday things will be ready for a recheck? | 19:15 |
*** JoseMello has quit IRC | 19:18 | |
*** salv-orlando has quit IRC | 19:29 | |
*** andymaier has quit IRC | 19:30 | |
*** salv-orlando has joined #openstack-cinder | 19:36 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Delete volumes with snapshots https://review.openstack.org/264982 | 19:41 |
*** kvidvans has joined #openstack-cinder | 19:42 | |
openstackgerrit | Kendall Nelson proposed openstack/cinder: Add SnapshotStatus enum field https://review.openstack.org/284825 | 19:42 |
eharney | i rebased delete volume with snaps to merge after Replication v2.1 (rpcapi version number sync) ^ | 19:42 |
*** haomaiwang has joined #openstack-cinder | 19:45 | |
*** lpetrut has quit IRC | 19:48 | |
*** shyama has quit IRC | 19:50 | |
*** krotscheck is now known as krotscheck_dcm | 19:50 | |
*** timcl has quit IRC | 19:51 | |
*** martyturner has quit IRC | 19:52 | |
*** haomaiwang has quit IRC | 19:53 | |
*** lpetrut has joined #openstack-cinder | 19:54 | |
*** timcl has joined #openstack-cinder | 19:55 | |
*** hemna has quit IRC | 19:56 | |
*** porrua has quit IRC | 19:59 | |
*** porrua has joined #openstack-cinder | 19:59 | |
*** martyturner has joined #openstack-cinder | 19:59 | |
*** porrua has quit IRC | 20:02 | |
*** porrua has joined #openstack-cinder | 20:03 | |
openstackgerrit | Vivek Dhayaal proposed openstack/cinder: Fixed string formatting issues in volume manager https://review.openstack.org/284907 | 20:11 |
*** annasort has joined #openstack-cinder | 20:15 | |
*** salv-orlando has quit IRC | 20:18 | |
*** salv-orlando has joined #openstack-cinder | 20:20 | |
*** esker has quit IRC | 20:21 | |
*** kfarr has quit IRC | 20:23 | |
*** sheel has quit IRC | 20:27 | |
diablo_rojo | brick7992 | 20:28 |
diablo_rojo | Lol | 20:29 |
diablo_rojo | nvm that | 20:29 |
* smcginnis writes down diablo_rojo's passwords | 20:29 | |
diablo_rojo | I am just failing at life today | 20:29 |
smcginnis | :] | 20:29 |
diablo_rojo | This whole week actually | 20:29 |
smcginnis | diablo_rojo: Can't be _that_ bad. | 20:30 |
diablo_rojo | smcginnis: I guess things could have gone worse today given how little and badly I slept last night. | 20:31 |
smcginnis | diablo_rojo: Bleh. That sucks. | 20:32 |
diablo_rojo | smcginnis: That it does. I can sleep in tomorrow though so that'll be nice. Are you still in Rochester? | 20:32 |
smcginnis | diablo_rojo: Nope, bad to the cities. | 20:32 |
smcginnis | *back | 20:32 |
diablo_rojo | smcginnis: How was the meetup while you were there? | 20:33 |
smcginnis | diablo_rojo: Not bad. Nice to hang out with folks. | 20:34 |
smcginnis | diablo_rojo: I still think you're crazy with that commute though. | 20:34 |
diablo_rojo | smcginnis: I sleep for most of them. That's the only way I can cope. | 20:35 |
diablo_rojo | smcginnis: Also its way more fun to harrass jungleboyj in person. | 20:35 |
scottda | diablo_rojo: I hope you're not the driver. | 20:35 |
smcginnis | Hah! | 20:35 |
diablo_rojo | scottda: Not usually while I'm sleeping | 20:36 |
scottda | whew! | 20:36 |
diablo_rojo | scottda: Have to listen to Wiggle on repeat to keep me awake. | 20:36 |
scottda | That works? It seems kinda soothing and sleep-inducing to me. | 20:36 |
cfouts | smcginnis: I see your point regarding https://review.openstack.org/#/c/284816. I didn't like the use of warn.call either. A number of these cases need bug fixes (*cough refactoring). I'll see what I can do about it in Newton | 20:37 |
smcginnis | scottda: It's like a lullaby. | 20:37 |
smcginnis | cfouts: Awesome, thanks! | 20:38 |
scottda | IN all seriousness, I'd appreciate any reviewer input on the direction I've taken with microversion cinderclient for /v3 endpoint: https://review.openstack.org/#/c/248163 | 20:38 |
smcginnis | cfouts: I know there is a lot in there, all over the place. | 20:38 |
scottda | A quick look and general :) or :( would be nice. | 20:38 |
smcginnis | scottda: :| | 20:38 |
scottda | smcginnis: That all leads to the next big question: How badly do we want these changes for the Mitaka release of cinderclient? | 20:39 |
smcginnis | scottda: Kidding, haven't had a chance to look yet. | 20:39 |
smcginnis | scottda: Did you see the requirements error? | 20:39 |
smcginnis | scottda: It would be great if we can get this in for M. | 20:39 |
smcginnis | scottda: But if we have to wait until after the M deadline for clients, I think we're fine. | 20:40 |
*** jwcroppe has quit IRC | 20:40 | |
*** daneyon has joined #openstack-cinder | 20:40 | |
*** jwcroppe has joined #openstack-cinder | 20:40 | |
scottda | smcginnis: What requirements error? You may need a browser refresh. | 20:41 |
smcginnis | scottda: If you have CI's filtered you won't see it. | 20:41 |
smcginnis | scottda: All jenkins tests show up green but there's a -1 from jenkins. | 20:41 |
scottda | ahh, you are right. | 20:42 |
eharney | the "Toggle CI" thing is broken for requirements failures | 20:42 |
smcginnis | eharney: And other cases... | 20:42 |
diablo_rojo | smcginnis: Yeah I see that too. | 20:42 |
*** JoseMello has joined #openstack-cinder | 20:42 | |
*** haplo37 has quit IRC | 20:43 | |
scottda | OK, olso stuff, I think due to latest library. I'll fix after gate stuff calms down. | 20:43 |
smcginnis | scottda: Good plan. Not much point in doing it immediately with the way things are going. | 20:44 |
smcginnis | Dang, up to 383 in queue. | 20:45 |
*** jwcroppe has quit IRC | 20:45 | |
eharney | that's why i just put Depends-On: <gate fix> in my last patch submission and kept moving | 20:46 |
haypo | cinder.tests.unit.volume.drivers.netapp.dataontap.test_block_base.NetAppBlockStorageLibraryTestCase.test_get_reserved_percentage fails | 20:46 |
haypo | in master | 20:46 |
smcginnis | haypo: Fix is in queue. | 20:46 |
haypo | smcginnis: ah great :) how was it merged? the test didn't fail on the gate? | 20:46 |
jungleboyj | smcginnis: Oh, that is why my UT is failing here. | 20:46 |
openstackgerrit | Merged openstack/python-cinderclient: Don't print HTTP codes for non-HTTP errors https://review.openstack.org/283850 | 20:46 |
jungleboyj | Yay. Glad it is not my problem. | 20:47 |
smcginnis | haypo: A test was checking for a mocked logger call that changed in an oslo library. | 20:47 |
smcginnis | jungleboyj: It's all your fault! | 20:47 |
jungleboyj | smcginnis: Are two test failing due to that? | 20:47 |
smcginnis | And scottda's of course for microversions. | 20:47 |
haypo | smcginnis: hum ok | 20:47 |
smcginnis | jungleboyj: I just saw one, but there were two tests doing that. | 20:47 |
smcginnis | haypo: Hopefully it makes it through that queue some time this week. | 20:48 |
eharney | the other test was passing because it was asserting that the log method was called, but still wrong | 20:48 |
*** porunov has joined #openstack-cinder | 20:48 | |
jungleboyj | smcginnis: Ok. Cool. Been beating my head against that for a little bit. | 20:49 |
smcginnis | jungleboyj: That's why diablo_rojo is having a bad week. Bang your head against the other wall for a bit. | 20:50 |
*** haomaiwang has joined #openstack-cinder | 20:50 | |
openstackgerrit | Dina Belova proposed openstack/cinder: Use OSprofiler options consolidated in lib itself https://review.openstack.org/278155 | 20:54 |
*** mylu has joined #openstack-cinder | 20:57 | |
*** haomaiwang has quit IRC | 20:58 | |
* jungleboyj starts banging his head again. | 20:58 | |
scottda | rock on jungleboyj | 20:58 |
openstackgerrit | Jacob Gregor proposed openstack/cinder: Storwize: SVC multiple management IPs https://review.openstack.org/284267 | 21:02 |
*** martyturner has quit IRC | 21:02 | |
*** timcl has quit IRC | 21:03 | |
openstackgerrit | Jacob Gregor proposed openstack/cinder: Storwize SVC multiple management IPs https://review.openstack.org/284267 | 21:04 |
*** raildo is now known as raildo-afk | 21:04 | |
*** haplo37 has joined #openstack-cinder | 21:06 | |
eharney | smcginnis: could you look at https://review.openstack.org/#/c/268255/ again? I just found more missing dependencies | 21:06 |
*** tpsilva has quit IRC | 21:07 | |
*** merooney has quit IRC | 21:09 | |
*** _alastor_ has joined #openstack-cinder | 21:09 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Add missing requirements https://review.openstack.org/284929 | 21:13 |
*** martyturner has joined #openstack-cinder | 21:14 | |
*** ildikov has quit IRC | 21:16 | |
*** timcl has joined #openstack-cinder | 21:17 | |
*** annasort has quit IRC | 21:25 | |
*** annasort has joined #openstack-cinder | 21:28 | |
*** timcl has quit IRC | 21:29 | |
smcginnis | eharney: Back, looking now. | 21:30 |
*** [1]Thelo has joined #openstack-cinder | 21:32 | |
*** jungleboyj has quit IRC | 21:32 | |
smcginnis | eharney: ImportError: cannot import name normalize_name | 21:33 |
smcginnis | eharney: Am I missing something? | 21:34 |
smcginnis | Well... other than the normalize_name module of course. | 21:34 |
*** Thelo has quit IRC | 21:34 | |
*** [1]Thelo is now known as Thelo | 21:34 | |
*** esker has joined #openstack-cinder | 21:36 | |
*** kaisers has quit IRC | 21:39 | |
*** esker has quit IRC | 21:41 | |
*** sgotliv has joined #openstack-cinder | 21:41 | |
*** kaisers has joined #openstack-cinder | 21:41 | |
*** annasort has quit IRC | 21:44 | |
eharney | smcginnis: umm... not familiar with that one, how did you hit it? | 21:45 |
smcginnis | cd cinder; git review -d 268255; tox -e pip-missing-reqs | 21:46 |
*** esker has joined #openstack-cinder | 21:46 | |
*** akerr has quit IRC | 21:47 | |
eharney | smcginnis: is there a stack trace? i don't see "normalize_name" anywhere? | 21:47 |
eharney | ahh, it's a method imported from pip.utils | 21:48 |
smcginnis | eharney: Here's the full thing: http://paste.openstack.org/show/488280/ | 21:48 |
smcginnis | yep | 21:48 |
smcginnis | Kind of ironic, don't you think? | 21:49 |
eharney | hah, yeah | 21:49 |
eharney | i assume you need a newer pip, what version is that? | 21:49 |
smcginnis | 8.0.3 | 21:49 |
smcginnis | pip 8.0.3 from /usr/local/lib/python2.7/dist-packages (python 2.7) | 21:49 |
*** annasort has joined #openstack-cinder | 21:50 | |
*** esker has quit IRC | 21:51 | |
*** esker has joined #openstack-cinder | 21:51 | |
eharney | smcginnis: apparently that method was removed in 8.0.0 | 21:51 |
eharney | smcginnis: so i guess the pip_missing_reqs package is buggy, awesome | 21:51 |
smcginnis | Doh! | 21:52 |
*** winston-d_ has quit IRC | 21:52 | |
*** haomaiwang has joined #openstack-cinder | 21:55 | |
*** chris_morrell has quit IRC | 21:55 | |
*** baumann has quit IRC | 21:56 | |
*** delatte has quit IRC | 22:00 | |
*** haomaiwang has quit IRC | 22:01 | |
*** porunov has quit IRC | 22:01 | |
*** ivase has quit IRC | 22:01 | |
*** julim has quit IRC | 22:04 | |
eharney | smcginnis: i went and wrote a fix for it, only to find that dims already did it :) | 22:04 |
dims | haha eharney | 22:05 |
*** merooney has joined #openstack-cinder | 22:05 | |
*** porrua has quit IRC | 22:07 | |
smcginnis | :) | 22:07 |
*** gouthamr has quit IRC | 22:07 | |
_alastor_ | hey folks. I'm trying to post a review for cinder, but `git review` tells me to fill out the contact information on review.openstack.org and that site just gives me a server error when I try to do that. | 22:07 |
smcginnis | _alastor_: I can get to it now. Can you try to refresh? | 22:07 |
smcginnis | _alastor_: I know they've been having some issues today. | 22:08 |
*** martyturner has quit IRC | 22:08 | |
_alastor_ | refresh the page? | 22:08 |
smcginnis | _alastor_: Yep. Or try to hit it again in some way. | 22:08 |
_alastor_ | kk | 22:08 |
_alastor_ | It still says 'server error cannot store contact information' | 22:09 |
_alastor_ | It said the same thing when I tried to input that information when I signed the contribution agreement. | 22:10 |
*** eharney has quit IRC | 22:10 | |
smcginnis | _alastor_: Hmm. Might need to ask over in #openstack-infra if someone there knows of any issues with that right now. | 22:10 |
_alastor_ | cool. I'll head over there. Thanks! | 22:10 |
*** mylu has quit IRC | 22:10 | |
smcginnis | _alastor_: np, good luck. | 22:10 |
*** knikolla has quit IRC | 22:13 | |
jgriffith | aorourke: turns out I think this might be pretty easy | 22:14 |
*** crose has quit IRC | 22:14 | |
jgriffith | aorourke: on init if failed_over, just call failover_host again with the info from the db | 22:14 |
*** crose has joined #openstack-cinder | 22:15 | |
jgriffith | aorourke: which is what I should've done in the first place now that I think about it | 22:15 |
*** mylu has joined #openstack-cinder | 22:17 | |
aorourke | jgriffith, so the driver should then also check to see if it is failed over? Otherwise it may try and run failover related commands to a dead array | 22:22 |
patrickeast | jgriffith: aorourke: hey guys, i'm catching up on the replication stuff, did one of you run into or already fix the issues where after failover you cant do anything? seeing http://paste.openstack.org/show/488284/ in c-api | 22:22 |
*** jeanfabrice has joined #openstack-cinder | 22:22 | |
aorourke | patrickeast, is that the newest patch set? Looks like an error from before FAILED_OVER was added in the object | 22:23 |
jgriffith | aorourke: patrickeast https://goo.gl/aWKkgq | 22:23 |
patrickeast | aorourke: yep, the latest one | 22:23 |
patrickeast | jgriffith: whats that for? | 22:24 |
aorourke | jgriffith, ah, your comment in that answers my question | 22:24 |
* patrickeast might be missing context | 22:24 | |
aorourke | jgriffith, so our drivers should know that it has already done failover on the volumes and simply return the active_backend_id | 22:24 |
jgriffith | patrickeast: when you failover, if you restart a c-vol node, it comes back up and the driver doesn't "know" anything | 22:24 |
jgriffith | patrickeast: I forgot to tell the driver on init that "hey... you're supposed to be in a failed over state based on the DB" | 22:25 |
patrickeast | jgriffith: huh? that was why we passed in the like active backend id | 22:25 |
patrickeast | jgriffith: or was that not enough? | 22:25 |
Swanson | patrickeast, is it being sent in? | 22:25 |
aorourke | patrickeast, disabled services were being filtered out the of the query | 22:25 |
*** delatte has joined #openstack-cinder | 22:25 | |
aorourke | so no it was not being sent in | 22:25 |
aorourke | because the manager could not find the service | 22:25 |
patrickeast | why not just use a different query? | 22:26 |
aorourke | patrickeast, that is always an option I believe | 22:26 |
* patrickeast is suspicious about calling failover multiple times and having the driver need to know how to handle them correctly | 22:26 | |
jgriffith | aorourke: patrickeast yes, so there's two sides of it | 22:27 |
patrickeast | its also very possible i'm kind of out of the loop and just causing trouble :D | 22:27 |
jgriffith | patrickeast: I could just add a new call that tells it what the backend_id is set to and leave it at that | 22:28 |
jgriffith | patrickeast: but I thought there might be some things that driver wanted to reset after it did a restart | 22:28 |
jgriffith | patrickeast: like if it was keeping cached info or something | 22:28 |
aorourke | jgriffith, I think something along those lines is better. I too am a little iffy on calling failover every time | 22:28 |
patrickeast | jgriffith: wasn't it a kwarg for the driver init? | 22:28 |
aorourke | patrickeast, it still is | 22:28 |
patrickeast | im not sure i'm seeing why a new method is required | 22:28 |
jgriffith | ahhh sob | 22:28 |
jgriffith | You're correct patrickeast | 22:29 |
jgriffith | aorourke: use the kwarg :) | 22:29 |
aorourke | jgriffith, I am using the kwarg | 22:29 |
jgriffith | patrickeast: that seems like soooo long ago | 22:29 |
aorourke | jgriffith, but it is not set | 22:29 |
aorourke | that is the whole problem | 22:29 |
jgriffith | aorourke: well.. why didn't you say so :) | 22:29 |
aorourke | jgriffith, patrickeast this query is being called https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L419-L429 | 22:29 |
aorourke | i did | 22:29 |
jeanfabrice | jgriffith: we have a talk last a day ago regarding the use of osapi_volume_base_URL in cinder.conf. Just to let you know the issue was a kind of pebkac on my side. osapi_volume_base_URL is dedicated to the wsgi setup while a recent (kilo) public_endpoint patch introduces the configuration of the versions endpoint announced by the api. We backported this patch to juno. | 22:29 |
jgriffith | You HP guys... everything is a riddle | 22:29 |
jgriffith | :) | 22:29 |
jgriffith | just kidding | 22:29 |
patrickeast | ok i think i get it now | 22:29 |
aorourke | jgriffith, and that query strips out alld isabled services | 22:30 |
patrickeast | so yah, lets fix that query | 22:30 |
aorourke | all disabled* | 22:30 |
jgriffith | patrickeast: yes, that's the easy one | 22:30 |
*** hemna has joined #openstack-cinder | 22:30 | |
*** jungleboyj has joined #openstack-cinder | 22:31 | |
openstackgerrit | Matt Smith proposed openstack/cinder: Updating Datera DataFabric Driver to v2 of Datera DataFabric API https://review.openstack.org/284967 | 22:32 |
*** diablo_rojo has quit IRC | 22:32 | |
jgriffith | aorourke: patrickeast https://goo.gl/EavVz6 | 22:33 |
*** delattec has joined #openstack-cinder | 22:33 | |
patrickeast | jgriffith: sweet | 22:34 |
patrickeast | jgriffith: next up: any ideas on http://paste.openstack.org/show/488284/? | 22:34 |
patrickeast | looks like going from db -> object after a failover it doesn't like the status enum value | 22:35 |
patrickeast | but i dunno why | 22:35 |
patrickeast | that field was added in the latest patchset | 22:35 |
*** mylu has quit IRC | 22:35 | |
jgriffith | hum, not sure... gimmie a moment | 22:35 |
*** delatte has quit IRC | 22:36 | |
jgriffith | patrickeast: I think that's something different than the enum | 22:36 |
*** IlyaG has joined #openstack-cinder | 22:36 | |
jgriffith | patrickeast: It appears that it's trying to access a member field named "failed-over" but that's no bueano | 22:36 |
jgriffith | failed_over | 22:36 |
patrickeast | ohh | 22:37 |
jgriffith | what I mean is there is not "failed_over" in the db model at all | 22:37 |
jgriffith | patrickeast: that's a wild guess though, trying to reproduce it now | 22:38 |
hemna | are patches making it through the gate yet? | 22:40 |
patrickeast | jgriffith: poking around a little bit the only thing i see is http://paste.openstack.org/show/488286/, in the stack trace its failing while iterating through the field keys and is complaining about the field value | 22:41 |
patrickeast | the only thing i see with that string* | 22:42 |
*** mylu has joined #openstack-cinder | 22:42 | |
smcginnis | hemna: A think some are. Still a lot of issues yet. | 22:43 |
*** annasort has quit IRC | 22:43 | |
*** arch-nemesis has quit IRC | 22:44 | |
patrickeast | jgriffith: yea its the replication_status value, updating the db directly to set it to disabled prevents the error | 22:44 |
jgriffith | patrickeast: coolio, looking now | 22:44 |
*** mylu has quit IRC | 22:44 | |
jgriffith | patrickeast: don't forget that snippet I sent on the service get needs a context change | 22:44 |
*** mylu has joined #openstack-cinder | 22:44 | |
patrickeast | jgriffith: ah yea, thanks, was just applying that change to my test env | 22:45 |
Swanson | smcginnis, 284816 is still the big holdup, right? Once that goes through cinder has a chance. Currently blocked with gate-cinder-docs-constraints queued. | 22:46 |
jgriffith | patrickeast: oddly I can't repro your failure | 22:46 |
jgriffith | patrickeast: what sequence of cmds did you run to get that? | 22:47 |
aorourke | patrickeast, I have not ran into that either during testing FWIW | 22:47 |
smcginnis | Swanson: Yep, that's the one. | 22:47 |
jgriffith | aorourke: http://goo.gl/Oeee1h | 22:47 |
jgriffith | aorourke: that jibberish in the middle is the stop/restart of c-vol | 22:48 |
smcginnis | Swanson: Man, queued for almost 6 hours and just waiting on a docs-constraints test. | 22:48 |
patrickeast | jgriffith: just did a failover (cinder failover-host blah) and then was trying to run like cinder service-list or cinder create | 22:48 |
aorourke | jgriffith, the db was always populated, it just was not being passed into the driver via the kwargs | 22:48 |
jgriffith | aorourke: right... it is now though :) | 22:48 |
jgriffith | sorry... now I'm using riddles :) | 22:49 |
patrickeast | jgriffith: aorourke : let me reset things and get to a nice clean state and try to repro again, theres a reasonable chance something weird happened while i was trying to failover and fixing some bugs in my driver | 22:49 |
aorourke | i will add that change to my setup as well and see what happens | 22:49 |
Swanson | smcginnis, +2/A that thing. It is going to pass. | 22:50 |
jgriffith | aorourke: here's a breakpoint in the driver on init: http://goo.gl/SC26nf | 22:50 |
jgriffith | aorourke: if you roll with that don't forget that I didn't fix the context in that gist yet | 22:50 |
jgriffith | patrickeast: I'm completely unable to repro the issue you are seeing :( | 22:51 |
patrickeast | jgriffith: no worries, i'm not convinced yet that its a real bug or something | 22:51 |
*** esker has quit IRC | 22:52 | |
*** jgregor has quit IRC | 22:54 | |
openstackgerrit | John Griffith proposed openstack/cinder: Get disabled services on init https://review.openstack.org/284976 | 22:55 |
*** hemna has quit IRC | 22:55 | |
* jgriffith was so happy with his attach/connector patch, until he started looking at the unit tests | 22:58 | |
* jgriffith jumps out the window | 22:58 | |
smcginnis | Swanson: Already did. Should go right through. | 22:58 |
* smcginnis knocks on formica | 22:58 | |
* jgriffith knocks on his hollow head | 22:58 | |
smcginnis | :) | 22:59 |
smcginnis | jgriffith: Unit tests tend to have that affect on people I think. | 22:59 |
*** haomaiwang has joined #openstack-cinder | 22:59 | |
*** arch-nemesis has joined #openstack-cinder | 22:59 | |
* jgriffith can't respond to your message right now, he's jumped out a window | 23:00 | |
smcginnis | hah! | 23:00 |
*** haomaiwang has quit IRC | 23:01 | |
*** delatte has joined #openstack-cinder | 23:01 | |
*** rlrossit has quit IRC | 23:02 | |
*** delattec has quit IRC | 23:03 | |
*** crose has quit IRC | 23:04 | |
*** arch-nemesis has quit IRC | 23:07 | |
*** hemna has joined #openstack-cinder | 23:07 | |
*** odyssey4me has joined #openstack-cinder | 23:08 | |
*** salv-orl_ has joined #openstack-cinder | 23:08 | |
odyssey4me | exit | 23:08 |
*** odyssey4me has left #openstack-cinder | 23:08 | |
*** cknight has quit IRC | 23:09 | |
*** jungleboyj has quit IRC | 23:10 | |
*** edmondsw has quit IRC | 23:11 | |
*** lpetrut has quit IRC | 23:11 | |
*** edtubill has quit IRC | 23:11 | |
hemna | smcginnis, so, still no +A'ing patches then? | 23:12 |
*** salv-orlando has quit IRC | 23:12 | |
scottda | smcginnis: What about submitting patches? Are we supposed to hold off on that as well? | 23:14 |
*** xyang1 has quit IRC | 23:14 | |
*** sborkows has quit IRC | 23:17 | |
*** xek_ has joined #openstack-cinder | 23:19 | |
*** xek has quit IRC | 23:19 | |
*** sborkows has joined #openstack-cinder | 23:20 | |
*** mriedem has quit IRC | 23:23 | |
openstackgerrit | Patrick East proposed openstack/cinder: Update Pure replication to cheesecake https://review.openstack.org/276981 | 23:24 |
*** haplo37 has quit IRC | 23:25 | |
*** hemna has quit IRC | 23:28 | |
*** JoseMello has quit IRC | 23:28 | |
*** jeanfabrice has quit IRC | 23:30 | |
jgriffith | patrickeast: so did you get it working then? | 23:31 |
patrickeast | jgriffith: dunno yet, spent some time fixing up unit tests... waiting on fresh stack.sh right now | 23:32 |
jgriffith | patrickeast: ahh... ok, well let me know | 23:32 |
patrickeast | jgriffith: i'm hoping its just a side effect of my kinda hacked up devstack | 23:32 |
*** jeanfabrice has joined #openstack-cinder | 23:35 | |
patrickeast | ugh my stupid ci is broken again | 23:38 |
patrickeast | every time i go on a trip somewhere.... its like it knows | 23:38 |
jgriffith | patrickeast: I'm not sure what's going on but mine has been acting up lately as well | 23:38 |
jgriffith | past few days have been weird stuff in the gerrit stream it looks like | 23:38 |
patrickeast | yea | 23:38 |
patrickeast | and i think a lot of libs getting cut | 23:39 |
patrickeast | which never helps with devstack stability | 23:39 |
*** salv-orl_ has quit IRC | 23:39 | |
jgriffith | :( | 23:39 |
*** jeanfabrice has quit IRC | 23:39 | |
*** bardia_ has joined #openstack-cinder | 23:40 | |
*** bardia has quit IRC | 23:40 | |
*** jeanfabrice has joined #openstack-cinder | 23:40 | |
*** sgotliv has quit IRC | 23:42 | |
jgriffith | hmm... network unreachable trying to connect to gerrit | 23:45 |
jgriffith | this doesn't look good | 23:45 |
*** smoriya_ has joined #openstack-cinder | 23:45 | |
*** edtubill has joined #openstack-cinder | 23:49 | |
Swanson | Infra is having their sprint now aren't they? | 23:53 |
*** yhayashi has joined #openstack-cinder | 23:54 | |
*** jeanfabrice has quit IRC | 23:57 | |
*** krtaylor has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!