| *** haomaiwa_ has joined #openstack-cinder | 00:01 | |
| *** yangyape_ has quit IRC | 00:02 | |
| *** chlong_ has quit IRC | 00:03 | |
| *** angela-s has quit IRC | 00:05 | |
| *** haomaiwa_ has quit IRC | 00:09 | |
| *** merooney has quit IRC | 00:09 | |
| *** merooney has joined #openstack-cinder | 00:11 | |
| patrickeast | jgriffith: hokay, so, now i can't repro that issue any more either | 00:12 |
|---|---|---|
| patrickeast | jgriffith: good news there | 00:12 |
| jgriffith | patrickeast: butttt....? | 00:12 |
| patrickeast | jgriffith: no buts | 00:12 |
| patrickeast | jgriffith: :D | 00:12 |
| jgriffith | patrickeast: pheww | 00:12 |
| *** krtaylor has joined #openstack-cinder | 00:12 | |
| patrickeast | jgriffith: the service query patch works great too | 00:12 |
| * jgriffith steps back from off the ledge | 00:12 | |
| patrickeast | jgriffith: my last question is.... now that i've failed over, i can do stuff and things are using the secondary target, did we decide on a sort of recommended path to get back? | 00:13 |
| jgriffith | patrickeast: I plan to use failover again | 00:13 |
| jgriffith | patrickeast: but need to add some things to make that work correctly | 00:14 |
| jgriffith | patrickeast: something like "failover_host xxxx primary" | 00:14 |
| jgriffith | patrickeast: that's what I was thinking anyway, don't know if folks have better suggestions | 00:14 |
| patrickeast | jgriffith: mm yea that should work for mine too, guess i coud just add the 'primary' as one of the secondary targets we report | 00:14 |
| jgriffith | patrickeast: how come? | 00:15 |
| jgriffith | patrickeast: so my thought was some "keyword" that meant, just get the default from config file | 00:15 |
| patrickeast | jgriffith: ohh i see | 00:15 |
| patrickeast | jgriffith: yea that would work | 00:15 |
| jgriffith | patrickeast: and that would clear "active_backend_Id" as well | 00:15 |
| jgriffith | patrickeast: I just need a clever "code" name | 00:16 |
| jgriffith | patrickeast: heck... maybe I call it "graham-cracker" | 00:16 |
| patrickeast | lol | 00:16 |
| jgriffith | patrickeast: as in the delicious foundation of Cheesecake | 00:16 |
| patrickeast | jgriffith: perfect! | 00:16 |
| jgriffith | patrickeast: I suppose others would rather I just use something like "default" | 00:17 |
| patrickeast | jgriffith: i guess if the naming gets weird it could just be a flag thats like 'undo-failover' | 00:17 |
| jgriffith | smcginnis: no joy on eharneys patch yet I guess huh | 00:17 |
| patrickeast | jgriffith: default works as well | 00:17 |
| jgriffith | patrickeast: yeah... but if we don't do it now then we have an rpc version bump and all that mess :( | 00:18 |
| jgriffith | patrickeast: I'll work up a patch now that uses "default" as a key work | 00:18 |
| jgriffith | word even | 00:18 |
| patrickeast | jgriffith: sounds good to me | 00:18 |
| jgriffith | aorourke: would that work ok for you? ^^ | 00:18 |
| aorourke | jgriffith, let me read through the convo | 00:19 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Don't allow operations on deleting volumes https://review.openstack.org/284994 | 00:20 |
| aorourke | jgriffith, patrickeast would we be expected to configure cinder.conf with a value for this? Or are we settling on a default? | 00:22 |
| jgriffith | aorourke: the default | 00:22 |
| *** dramakri has quit IRC | 00:22 | |
| aorourke | jgriffith, sound good to me | 00:23 |
| jgriffith | aorourke: patrickeast like this: https://gist.github.com/4540792b27737572ebb8 | 00:23 |
| jgriffith | aorourke: patrickeast so it set status back to ENABLED, clears the active_backend_id and disabled settings | 00:24 |
| jgriffith | aorourke: patrickeast then it's up to the driver what they need/want to do when they see "default" come back in | 00:24 |
| aorourke | jgriffith, would it be possible to allow a call to the driver first? That way we can ensure the admin properly reset everything back up on their end? | 00:25 |
| jgriffith | aorourke: the call to the driver is first actually | 00:25 |
| aorourke | jgriffith, oh it does... right? | 00:25 |
| jgriffith | aorourke: yep | 00:25 |
| *** IlyaG has quit IRC | 00:25 | |
| aorourke | jgriffith, great. Is there an exception or something we can raise to basically say not ready? | 00:25 |
| *** laughterwym has joined #openstack-cinder | 00:25 | |
| jgriffith | aorourke: same one we use for driver.failover_host | 00:26 |
| aorourke | jgriffith, cool | 00:26 |
| jgriffith | aorourke: that could use some refinement, but at least there's something there currently | 00:26 |
| *** sdague has quit IRC | 00:26 | |
| jgriffith | patrickeast: I'll wait to get your buy in... and Swanson if you're still following this madness :) | 00:26 |
| *** laughterwym has joined #openstack-cinder | 00:27 | |
| jgriffith | so personally I like it because it's relatively "clean" | 00:27 |
| *** daneyon has quit IRC | 00:28 | |
| patrickeast | jgriffith: yea it looks good to me, i'll have to figure out for my driver how much we want to support... in theory we can try and set up replication back to the default (if its still alive) and make that call to default automate moving everything back over (sort of a fail-back behavior) | 00:31 |
| patrickeast | jgriffith: buuut that adds a lot of complexity : / | 00:31 |
| patrickeast | maybe i'll just change the current array id and assume the admin move stuff back over on their own | 00:31 |
| jgriffith | patrickeast: yeah, we talked in RTP about failover being something possibly best left to an admin | 00:32 |
| jgriffith | patrickeast: the main thing as I've argued is that the use case is that your cluster ate itself | 00:33 |
| jgriffith | and doesn't exist any longer | 00:33 |
| patrickeast | jgriffith: yea def | 00:33 |
| jgriffith | but perhaps you rolled something else in set it up, replicated to it and modified your config | 00:33 |
| jgriffith | to me this seemed like the only way to really recover... or by the way... this is how you switch the secondary over to now be advertised as the primary | 00:34 |
| patrickeast | its probably safest to assume the admin fixed things and is ready to go back | 00:34 |
| patrickeast | doing it automatically is just asking to lose someones data | 00:34 |
| jgriffith | patrickeast: yeah, that's what got us in to trouble with the old code | 00:34 |
| patrickeast | or more importantly, having it be my fault that the data is lost :D | 00:34 |
| jgriffith | LOL | 00:34 |
| jgriffith | patrickeast: TAKE NO RESPONSIBILITY!!!! | 00:35 |
| patrickeast | lol | 00:35 |
| jgriffith | patrickeast: just have your driver raise an exception if backend_id is == default | 00:35 |
| *** mylu has quit IRC | 00:35 | |
| jgriffith | that's what I'm going to do | 00:35 |
| jgriffith | at least for now | 00:35 |
| patrickeast | jgriffith: i'll probably swap my like current_id stuff we keep track of, but do nothing else | 00:35 |
| jgriffith | patrickeast: yeah, that's the most I'll do probably.. and document it | 00:36 |
| jgriffith | FRIK | 00:39 |
| jgriffith | there's another one of those stupid query problems | 00:39 |
| jgriffith | oh.. never mind :) | 00:39 |
| jgriffith | derp | 00:39 |
| jgriffith | lol | 00:39 |
| aorourke | jgriffith, btw, that change seems to work fine for me as well. active_backend_id is available in kwargs upon init | 00:39 |
| jgriffith | aorourke: excellent | 00:39 |
| *** The_Ball has joined #openstack-cinder | 00:41 | |
| *** ntpttr has quit IRC | 00:43 | |
| *** mylu has joined #openstack-cinder | 00:43 | |
| patrickeast | jgriffith: lemmie know if my response on https://review.openstack.org/#/c/276981/8 makes sense, i don't think we need provider info for anything on the volumes | 00:44 |
| patrickeast | jgriffith: i had considered updating volume replication status or setting ones that were left behind to an error state... but its proven very easy to get in a weird state where they aren't in sync with reality | 00:44 |
| jgriffith | patrickeast: yeah, makes sense and that's what I kind of expected, but just thought I'd point it out | 00:45 |
| *** salv-orlando has joined #openstack-cinder | 00:45 | |
| *** mylu has quit IRC | 00:46 | |
| patrickeast | actually... as i think about it more maybe I will set left behind ones to error | 00:47 |
| patrickeast | easy enough for an admin to do a reset-state if they are actually ok at some point in the future (like after doing a failover to default), kind of err on the side of assuming things are broken | 00:47 |
| jgriffith | patrickeast: Yup! | 00:48 |
| jgriffith | patrickeast: much better than just 'random' failures for user | 00:49 |
| jgriffith | dang... Erics patch to fix the log.warning mess is still 8 hours out just for the check queue :( | 00:51 |
| patrickeast | ouch | 00:53 |
| patrickeast | jgriffith: does anyone have magic powers to just merge it? | 00:53 |
| jgriffith | patrickeast: not really.. the only way to really do that is pretty ugly. Kill everything, clear the queues, promote that change then turn everything back on | 00:53 |
| jgriffith | patrickeast: at least IIRC that's how they would do it | 00:54 |
| patrickeast | jgriffith: gotcha | 00:54 |
| *** qeelee has joined #openstack-cinder | 00:56 | |
| *** mylu has joined #openstack-cinder | 00:58 | |
| *** gouthamr has joined #openstack-cinder | 00:58 | |
| jgriffith | patrickeast: aorourke http://goo.gl/M8uXry | 00:59 |
| jgriffith | a few changes to that gist I sent and a change to the query in the API | 01:00 |
| patrickeast | jgriffith: ship it! | 01:00 |
| jgriffith | LOL | 01:01 |
| aorourke | jgriffith, loogs good! | 01:02 |
| aorourke | jgriffith, I briefly scanned over your convo yesterday, what was the recommendation for finding replication targets/backend_id ? | 01:03 |
| *** mylu has quit IRC | 01:03 | |
| jgriffith | aorourke: get_capabilities | 01:03 |
| aorourke | jgriffith, ah ok. Is there a way to list them still? | 01:03 |
| aorourke | or view them | 01:03 |
| *** gouthamr_ has joined #openstack-cinder | 01:03 | |
| *** gouthamr has quit IRC | 01:03 | |
| jgriffith | aorourke: so that would be the method to use... report the configured backends in your volume stats update | 01:04 |
| jgriffith | aorourke: then when an admin runs get_capabilities they'll now show up | 01:04 |
| *** mylu has joined #openstack-cinder | 01:04 | |
| aorourke | jgriffith, ah, i see that in the code now. Cool | 01:05 |
| aorourke | | replication_targets | [] | | 01:05 |
| aorourke | i need to populate that | 01:05 |
| jgriffith | aorourke: exact-o-mundo | 01:05 |
| jgriffith | aorourke: here's my fake: https://gist.github.com/j-griffith/2eb4f7099e77e92abd12 | 01:06 |
| *** mylu has quit IRC | 01:06 | |
| jgriffith | oops | 01:06 |
| jgriffith | don't forget to make it a member of the data dict | 01:06 |
| jgriffith | anyway.. you get the idea | 01:06 |
| *** haomaiwa_ has joined #openstack-cinder | 01:06 | |
| *** salv-orlando has quit IRC | 01:07 | |
| jgriffith | There.. updated | 01:07 |
| aorourke | jgriffith, that was easy :) | 01:09 |
| jgriffith | hehe | 01:09 |
| *** haomaiwa_ has quit IRC | 01:13 | |
| *** aorourke is now known as aorourke-afk | 01:13 | |
| *** yangyapeng has joined #openstack-cinder | 01:13 | |
| *** sheel has joined #openstack-cinder | 01:14 | |
| *** mylu has joined #openstack-cinder | 01:15 | |
| *** EinstCrazy has joined #openstack-cinder | 01:16 | |
| *** mylu has quit IRC | 01:17 | |
| *** edtubill has quit IRC | 01:18 | |
| *** mylu has joined #openstack-cinder | 01:19 | |
| *** IlyaG has joined #openstack-cinder | 01:19 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Add ability to failback for replication V2.1 https://review.openstack.org/285007 | 01:20 |
| *** mtanino has quit IRC | 01:21 | |
| *** davechen_afk is now known as grassy | 01:22 | |
| *** cknight has joined #openstack-cinder | 01:22 | |
| *** davechen1 has joined #openstack-cinder | 01:22 | |
| *** mylu has quit IRC | 01:23 | |
| *** haomaiwang has joined #openstack-cinder | 01:25 | |
| openstackgerrit | Patrick East proposed openstack/cinder: Update Pure replication to cheesecake https://review.openstack.org/276981 | 01:25 |
| smcginnis | Still waiting for the gate fix to make it through. | 01:26 |
| *** daneyon has joined #openstack-cinder | 01:28 | |
| *** garthb has quit IRC | 01:28 | |
| *** Lee1092 has joined #openstack-cinder | 01:28 | |
| *** garthb_ has quit IRC | 01:29 | |
| *** laughterwym has quit IRC | 01:29 | |
| *** laughterwym has joined #openstack-cinder | 01:30 | |
| *** davechen1 is now known as davechen | 01:30 | |
| openstackgerrit | Patrick East proposed openstack/cinder: Update Pure replication to cheesecake https://review.openstack.org/276981 | 01:30 |
| smcginnis | Hmm, and it's not even in any of the queue right now. | 01:30 |
| *** daneyon_ has joined #openstack-cinder | 01:30 | |
| *** haomaiwang has quit IRC | 01:33 | |
| *** daneyon has quit IRC | 01:33 | |
| *** uberjay has quit IRC | 01:35 | |
| *** uberjay has joined #openstack-cinder | 01:37 | |
| *** Suyash has quit IRC | 01:38 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/283923 | 01:38 |
| *** yangyapeng has quit IRC | 01:39 | |
| *** EinstCrazy has quit IRC | 01:40 | |
| *** mylu has joined #openstack-cinder | 01:41 | |
| *** EinstCrazy has joined #openstack-cinder | 01:42 | |
| *** qeelee_ has joined #openstack-cinder | 01:42 | |
| *** qeelee has quit IRC | 01:42 | |
| *** qeelee_ is now known as qeelee | 01:42 | |
| *** leeantho has quit IRC | 01:45 | |
| *** cheneydc has joined #openstack-cinder | 01:48 | |
| *** dims has quit IRC | 01:49 | |
| *** chlong_ has joined #openstack-cinder | 01:50 | |
| *** laughterwym has quit IRC | 01:52 | |
| *** laughterwym has joined #openstack-cinder | 01:52 | |
| *** laughterwym has quit IRC | 01:53 | |
| *** laughterwym has joined #openstack-cinder | 01:53 | |
| *** annasort has joined #openstack-cinder | 01:55 | |
| *** mylu has quit IRC | 02:00 | |
| *** jungleboyj has joined #openstack-cinder | 02:00 | |
| *** mylu has joined #openstack-cinder | 02:08 | |
| *** laughterwym has quit IRC | 02:14 | |
| *** laughterwym has joined #openstack-cinder | 02:14 | |
| *** igornsa has joined #openstack-cinder | 02:20 | |
| *** laughterwym has quit IRC | 02:20 | |
| *** laughterwym has joined #openstack-cinder | 02:21 | |
| *** haomaiwang has joined #openstack-cinder | 02:21 | |
| *** knikolla has joined #openstack-cinder | 02:21 | |
| openstackgerrit | Matt Smith proposed openstack/cinder: Updating Datera DataFabric Driver to v2 of Datera DataFabric API https://review.openstack.org/284967 | 02:22 |
| *** igornsa has quit IRC | 02:26 | |
| *** laughterwym has quit IRC | 02:29 | |
| *** laughterwym has joined #openstack-cinder | 02:29 | |
| *** qeelee has quit IRC | 02:29 | |
| *** qeelee has joined #openstack-cinder | 02:31 | |
| *** jwcroppe has joined #openstack-cinder | 02:31 | |
| *** mylu has quit IRC | 02:34 | |
| *** mylu has joined #openstack-cinder | 02:35 | |
| *** mylu has quit IRC | 02:39 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Make nullable of fields in db model and object match https://review.openstack.org/285086 | 02:40 |
| *** laughterwym has quit IRC | 02:47 | |
| *** laughterwym has joined #openstack-cinder | 02:47 | |
| *** laughterwym has quit IRC | 02:48 | |
| *** laughterwym has joined #openstack-cinder | 02:48 | |
| *** gcb has quit IRC | 02:48 | |
| *** bardia_ has quit IRC | 02:52 | |
| *** IlyaG has quit IRC | 02:52 | |
| *** laughterwym has quit IRC | 02:53 | |
| *** wanghao has quit IRC | 02:54 | |
| *** wanghao has joined #openstack-cinder | 02:55 | |
| *** delatte has quit IRC | 02:56 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-cinder | 03:01 | |
| *** cknight has quit IRC | 03:02 | |
| *** laughterwym has joined #openstack-cinder | 03:03 | |
| *** IlyaG has joined #openstack-cinder | 03:05 | |
| *** gcb has joined #openstack-cinder | 03:05 | |
| openstackgerrit | Jay Bryant proposed openstack/cinder: Tests: Don't assert on LOG.warn https://review.openstack.org/284816 | 03:06 |
| openstackgerrit | Jay Bryant proposed openstack/cinder: Add CGSnapshotStatus enum field https://review.openstack.org/261068 | 03:06 |
| *** dims has joined #openstack-cinder | 03:10 | |
| *** apoorvad has quit IRC | 03:11 | |
| openstackgerrit | LisaLi proposed openstack/cinder: unit test fix in netapp https://review.openstack.org/285089 | 03:11 |
| *** knikolla has quit IRC | 03:15 | |
| lixiaoy1_ | hi, any cores here? I just fix a bug which blocks CI. please have a look: https://review.openstack.org/285089 | 03:16 |
| *** boris-42 has quit IRC | 03:24 | |
| *** gouthamr_ has quit IRC | 03:26 | |
| *** links has joined #openstack-cinder | 03:26 | |
| *** sheel has quit IRC | 03:27 | |
| *** jwcroppe has quit IRC | 03:37 | |
| *** jwcroppe has joined #openstack-cinder | 03:37 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Tests: Don't assert on LOG.warn https://review.openstack.org/284816 | 03:38 |
| *** jwcroppe has quit IRC | 03:42 | |
| *** qeelee has quit IRC | 03:50 | |
| *** markvoelker has quit IRC | 03:51 | |
| *** daneyon_ has quit IRC | 03:54 | |
| *** erlon has quit IRC | 03:56 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Tests: Don't assert on LOG.warn https://review.openstack.org/284816 | 03:59 |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-cinder | 04:01 | |
| *** edtubill has joined #openstack-cinder | 04:02 | |
| *** cknight has joined #openstack-cinder | 04:05 | |
| *** edtubill has quit IRC | 04:09 | |
| *** yhayashi has quit IRC | 04:24 | |
| *** Poornima has joined #openstack-cinder | 04:26 | |
| *** gcb has quit IRC | 04:29 | |
| *** IlyaG_ has joined #openstack-cinder | 04:35 | |
| *** itzdilip has joined #openstack-cinder | 04:37 | |
| *** IlyaG has quit IRC | 04:38 | |
| *** jwcroppe has joined #openstack-cinder | 04:39 | |
| *** IlyaG_ has quit IRC | 04:39 | |
| *** mylu has joined #openstack-cinder | 04:41 | |
| *** qeelee has joined #openstack-cinder | 04:41 | |
| *** gcb has joined #openstack-cinder | 04:41 | |
| *** ntpttr has joined #openstack-cinder | 04:45 | |
| *** markvoelker has joined #openstack-cinder | 04:51 | |
| *** dustins has quit IRC | 04:56 | |
| *** markvoelker has quit IRC | 04:56 | |
| *** qeelee has quit IRC | 04:57 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-cinder | 05:01 | |
| *** shyama has joined #openstack-cinder | 05:03 | |
| *** shyama has quit IRC | 05:04 | |
| *** yhayashi has joined #openstack-cinder | 05:08 | |
| *** jwcroppe has quit IRC | 05:12 | |
| *** gcb has quit IRC | 05:13 | |
| *** edtubill has joined #openstack-cinder | 05:18 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Don't allow operations on deleting volumes https://review.openstack.org/284994 | 05:24 |
| *** mylu has quit IRC | 05:25 | |
| *** Roamer` has quit IRC | 05:26 | |
| *** Roamer` has joined #openstack-cinder | 05:26 | |
| *** ntpttr has quit IRC | 05:28 | |
| *** gcb has joined #openstack-cinder | 05:30 | |
| *** laughterwym has quit IRC | 05:30 | |
| *** cknight has quit IRC | 05:31 | |
| *** garthb_ has joined #openstack-cinder | 05:31 | |
| *** garthb has joined #openstack-cinder | 05:31 | |
| *** mylu has joined #openstack-cinder | 05:35 | |
| *** IlyaG has joined #openstack-cinder | 05:35 | |
| *** laughterwym has joined #openstack-cinder | 05:36 | |
| *** merooney has quit IRC | 05:37 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Add backup update function https://review.openstack.org/263179 | 05:37 |
| *** IlyaG has quit IRC | 05:40 | |
| *** laughterwym has quit IRC | 05:42 | |
| *** laughterwym has joined #openstack-cinder | 05:43 | |
| *** laughterwym has quit IRC | 05:43 | |
| *** laughterwym has joined #openstack-cinder | 05:43 | |
| *** laughterwym has joined #openstack-cinder | 05:43 | |
| *** qeelee has joined #openstack-cinder | 05:52 | |
| *** cheneydc has quit IRC | 05:54 | |
| *** laughterwym has quit IRC | 06:00 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-cinder | 06:01 | |
| *** wanghao has quit IRC | 06:05 | |
| *** wanghao has joined #openstack-cinder | 06:06 | |
| *** wanghao has quit IRC | 06:07 | |
| *** wanghao has joined #openstack-cinder | 06:08 | |
| *** sgotliv has joined #openstack-cinder | 06:14 | |
| openstackgerrit | Dinesh Bhor proposed openstack/cinder: Provide user friendly messages for db sync https://review.openstack.org/284156 | 06:17 |
| *** jwcroppe has joined #openstack-cinder | 06:19 | |
| *** laughterwym has joined #openstack-cinder | 06:22 | |
| openstackgerrit | Matt Smith proposed openstack/cinder: Updating Datera DataFabric Driver to v2 of Datera DataFabric API https://review.openstack.org/284967 | 06:23 |
| *** abhishekk_ has joined #openstack-cinder | 06:24 | |
| *** Lallana has quit IRC | 06:26 | |
| *** links has quit IRC | 06:26 | |
| *** Lallana has joined #openstack-cinder | 06:26 | |
| *** sgotliv has quit IRC | 06:33 | |
| *** sgotliv has joined #openstack-cinder | 06:33 | |
| *** ChubYann has quit IRC | 06:34 | |
| *** IlyaG has joined #openstack-cinder | 06:36 | |
| *** nkrinner has joined #openstack-cinder | 06:37 | |
| *** dims has quit IRC | 06:37 | |
| *** IlyaG has quit IRC | 06:41 | |
| *** sheel has joined #openstack-cinder | 06:43 | |
| *** edtubill has quit IRC | 06:44 | |
| *** jeanfabrice has joined #openstack-cinder | 06:48 | |
| *** jwcroppe has quit IRC | 06:52 | |
| *** haomaiwang has quit IRC | 06:52 | |
| *** markvoelker has joined #openstack-cinder | 06:53 | |
| *** haomaiwang has joined #openstack-cinder | 06:53 | |
| *** markvoelker has quit IRC | 06:57 | |
| *** ankit_ag has joined #openstack-cinder | 06:58 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-cinder | 07:01 | |
| openstackgerrit | Cao ShuFeng proposed openstack/python-cinderclient: Fix return type in consistencygroups docstring https://review.openstack.org/285137 | 07:04 |
| *** yangyapeng has joined #openstack-cinder | 07:04 | |
| *** rcernin has joined #openstack-cinder | 07:05 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: VNX: Update replication for v2.1 https://review.openstack.org/285139 | 07:06 |
| *** sgotliv has quit IRC | 07:10 | |
| *** garthb_ has quit IRC | 07:19 | |
| *** garthb has quit IRC | 07:19 | |
| *** chlong_ has quit IRC | 07:26 | |
| *** arecknag has joined #openstack-cinder | 07:26 | |
| *** lpetrut has joined #openstack-cinder | 07:27 | |
| *** anshul has joined #openstack-cinder | 07:27 | |
| *** salv-orlando has joined #openstack-cinder | 07:29 | |
| *** [1]Thelo has joined #openstack-cinder | 07:32 | |
| *** abhishekk has quit IRC | 07:34 | |
| *** Thelo has quit IRC | 07:34 | |
| *** [1]Thelo is now known as Thelo | 07:34 | |
| *** jeanfabrice has quit IRC | 07:36 | |
| *** frickler has joined #openstack-cinder | 07:44 | |
| *** ildikov has joined #openstack-cinder | 07:46 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Add necessary fields to volume creation https://review.openstack.org/284600 | 07:47 |
| *** laughterwym has quit IRC | 07:48 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Add backup update function https://review.openstack.org/263179 | 07:48 |
| *** jwcroppe has joined #openstack-cinder | 07:49 | |
| *** laughterwym has joined #openstack-cinder | 07:51 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Add necessary fields to volume creation https://review.openstack.org/284600 | 07:51 |
| *** laughterwym has quit IRC | 07:52 | |
| dulek | geguileo, DuncanT: Hi, you've read through the log from last night? Looks like gate fix is still not approved: https://review.openstack.org/#/c/284816/ | 07:53 |
| dulek | geguileo, DuncanT: I don't know why jungleboyj rebased it while it was in the queue, but we're with non-functional gate at the moment. :( | 07:54 |
| *** cheneydc has joined #openstack-cinder | 07:56 | |
| *** mylu has quit IRC | 07:56 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-cinder | 08:01 | |
| *** zhangjn has quit IRC | 08:02 | |
| *** laughterwym has joined #openstack-cinder | 08:04 | |
| *** zhangjn has joined #openstack-cinder | 08:07 | |
| *** belmoreira has joined #openstack-cinder | 08:08 | |
| *** laughterwym has quit IRC | 08:08 | |
| dulek | lixiaoy1_: Why patchset 5 of https://review.openstack.org/#/c/263179 was failing pep8? | 08:10 |
| dulek | lixiaoy1_: This file even doesn't had that many lines… | 08:10 |
| lixiaoy1_ | dulek: I don't know. I didn't find any useful info from the logs | 08:18 |
| lixiaoy1_ | dulek: pep8 succeeds in my machine | 08:18 |
| dulek | lixiaoy1_: Sure, I was mistaken then. Eh, we have the py27, py34 blocked anyway. :( Thanks for updating the release note. | 08:20 |
| lixiaoy1_ | dulek: np | 08:20 |
| *** jwcroppe has quit IRC | 08:22 | |
| *** adrianofr_ has quit IRC | 08:25 | |
| *** adrianofr_ has joined #openstack-cinder | 08:27 | |
| openstackgerrit | xiaoqin proposed openstack/cinder: IBM Storwize with pool-aware-cinder-scheduler https://review.openstack.org/284614 | 08:27 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Enable all unit tests on Python 3.4 https://review.openstack.org/284308 | 08:36 |
| haypo | ^^ i rebased my approved change since master was broken. maybe i wasn't needed. it looks like i lost the approval :-/ | 08:38 |
| dulek | haypo: Gate is dead until https://review.openstack.org/284816 merges. | 08:39 |
| haypo | 21:46 < smcginnis> haypo: Fix is in queue. | 08:39 |
| haypo | dulek: ^^ the fix is not merged yet? | 08:39 |
| dulek | haypo: Nope, it was stuck in the queue for a long time and I think this is why jungleboyj tried to rebase it. | 08:40 |
| dulek | haypo: Which removed it from the queue. | 08:40 |
| haypo | dulek: ah https://review.openstack.org/#/c/284816/ is the fix? ok | 08:40 |
| haypo | but it lost its "Patch Set 1: Code-Review+2 Workflow+1" too | 08:41 |
| dulek | haypo: Yeah. I hoped geguileo, DuncanT or e0ne could fast-approve it, but looks like they aren't here yet. | 08:41 |
| *** jeanfabrice has joined #openstack-cinder | 08:42 | |
| haypo | dulek: hum, i don't understand why it was rebased. the patch was ready to be merged, it was at the last step "Starting gate jobs." | 08:42 |
| haypo | dulek: i heard that we can ask the infra to reorder jobs when a gate is broken | 08:42 |
| haypo | once the change is +2a again, we can try to ask that to repair the gate quickly | 08:42 |
| haypo | (anyway, running new jobs on cinder is a loss of time, since all jobs will fail) | 08:43 |
| dulek | haypo: From the IRC logs I've seen it was hanging in docs queue for an incredibly long time. | 08:43 |
| dulek | haypo: True. | 08:43 |
| dulek | haypo: At least the weather here marks a nice Friday. ;) | 08:43 |
| haypo | right now, zuul is closer to idle :) http://status.openstack.org/zuul/ | 08:44 |
| dulek | haypo: Yeah, it would be great to have it approved now, it would get merged in about an hour. | 08:44 |
| haypo | it's fun to see the size of the queue depending on the hour, we can see that openstack is not really developed in all timezones | 08:44 |
| haypo | IMHO we depend a lot on america timezones :) | 08:44 |
| dulek | haypo: Yes we do. :) But I like the fact my patches are checked super-fast in my working hours. ;) | 08:45 |
| dulek | haypo: And get merged overnight. :) | 08:45 |
| *** lpetrut has quit IRC | 08:47 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Move deprecation release notes to correct section https://review.openstack.org/285165 | 08:47 |
| *** jordanP has joined #openstack-cinder | 08:49 | |
| *** markvoelker has joined #openstack-cinder | 08:53 | |
| *** markvoelker has quit IRC | 08:57 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 09:01 | |
| sheel | dulek: hi | 09:07 |
| sheel | dulek: need some clarification on https://review.openstack.org/#/c/274589/ | 09:07 |
| sheel | dulek: could we discuss that now? | 09:07 |
| dulek | sheel: Sure. | 09:08 |
| sheel | dulek: ok, regarding your comment | 09:08 |
| sheel | :) | 09:08 |
| sheel | dulek: I think tests will fail without my fix | 09:08 |
| sheel | as I have specifically written one more test | 09:08 |
| sheel | @mock.patch.object(db.sqlalchemy.api, | 09:08 |
| sheel | '_volume_glance_metadata_key_to_id', | 09:08 |
| sheel | return_value = '1') | 09:08 |
| sheel | def test_volume_glance_metadata_key_to_id_called(self, | 09:08 |
| sheel | metadata_key_to_id_mock) | 09:08 |
| sheel | this checks if mocked function is called once or not | 09:09 |
| sheel | if fix is not there test will fail | 09:09 |
| sheel | dulek: is this suffice your comment? | 09:09 |
| sheel | dulek: you can refer complete testcase here : https://review.openstack.org/#/c/274589/12/cinder/tests/unit/test_db_api.py | 09:10 |
| dulek | sheel: Oh, yeah, but that's like a white-box testing. If someone reworked volume_metadata_delete to still use _volume_glance_metadata_key_to_id but changed filter_by clause to use key=key again, it would still pass. | 09:11 |
| sheel | dulek: haha | 09:11 |
| dulek | sheel: And it wouldn't find the regression. | 09:11 |
| sheel | dulek: yes | 09:12 |
| sheel | dulek: you are right | 09:12 |
| dulek | sheel: Question is - is this testable…? | 09:12 |
| sheel | dulek: I think hard to test | 09:12 |
| sheel | dulek: will still have to devote much more time for this | 09:12 |
| sheel | dulek: I think this is very rare case where someone will change key in code, though possible | 09:13 |
| dulek | sheel: You can probably mock filter_by and check if it was called with correct params. | 09:14 |
| dulek | sheel: But I've removed -1. :) | 09:14 |
| sheel | dulek: oh thanks | 09:14 |
| *** rcernin has quit IRC | 09:14 | |
| sheel | dulek: I think we can let this go as this suffice the case upto some extent | 09:14 |
| sheel | dulek: later on i will add tests | 09:15 |
| sheel | dulek: is it ok? | 09:15 |
| dulek | Yeah, cool. | 09:15 |
| sheel | dulek: thanks .. | 09:15 |
| dulek | sheel: BTW - you've seen post on the openstack-dev about case sensitivity issues? | 09:15 |
| sheel | dulek: no | 09:15 |
| dulek | sheel: http://lists.openstack.org/pipermail/openstack-dev/2016-February/087404.html | 09:16 |
| dulek | sheel: They have similar problem, we probably should watch how they solve it to be consistent. | 09:16 |
| sheel | dulek: ah, yes | 09:16 |
| sheel | dulek: i will follow this | 09:17 |
| dulek | sheel: Thanks! | 09:18 |
| sheel | dulek: but we are able to create things with seperate cases.. | 09:18 |
| sheel | dulek: will check further | 09:18 |
| *** jwcroppe has joined #openstack-cinder | 09:19 | |
| *** salv-orlando has quit IRC | 09:19 | |
| *** salv-orlando has joined #openstack-cinder | 09:19 | |
| *** laughterwym has joined #openstack-cinder | 09:23 | |
| *** jistr has joined #openstack-cinder | 09:27 | |
| *** laughterwym has quit IRC | 09:28 | |
| *** rcernin has joined #openstack-cinder | 09:28 | |
| *** _alastor1 has joined #openstack-cinder | 09:32 | |
| *** aagrawal has joined #openstack-cinder | 09:32 | |
| *** jordanP has quit IRC | 09:32 | |
| *** laughterwym has joined #openstack-cinder | 09:33 | |
| *** jwcroppe_ has joined #openstack-cinder | 09:34 | |
| *** ishant has joined #openstack-cinder | 09:35 | |
| *** jwcroppe has quit IRC | 09:35 | |
| *** _alastor_ has quit IRC | 09:35 | |
| *** ankit_ag has quit IRC | 09:35 | |
| *** wanghao has quit IRC | 09:35 | |
| *** wanghao has joined #openstack-cinder | 09:35 | |
| *** yangyape_ has joined #openstack-cinder | 09:42 | |
| *** asselin__ has joined #openstack-cinder | 09:44 | |
| *** yangyapeng has quit IRC | 09:45 | |
| *** jordanP has joined #openstack-cinder | 09:47 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Adding general notes about rolling upgrades https://review.openstack.org/285190 | 09:47 |
| *** yangyape_ has quit IRC | 09:47 | |
| *** asselin_ has quit IRC | 09:48 | |
| *** ndipanov has joined #openstack-cinder | 09:50 | |
| *** tpsilva has joined #openstack-cinder | 09:50 | |
| *** jwcroppe_ has quit IRC | 09:53 | |
| *** EinstCrazy has quit IRC | 09:55 | |
| *** davechen has left #openstack-cinder | 09:55 | |
| *** grassy is now known as davechen_afk | 09:56 | |
| *** salv-orlando has quit IRC | 10:00 | |
| *** haomaiwa_ has quit IRC | 10:01 | |
| *** cheneydc has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-cinder | 10:01 | |
| *** laughterwym has quit IRC | 10:03 | |
| *** laughterwym has joined #openstack-cinder | 10:04 | |
| *** salv-orlando has joined #openstack-cinder | 10:08 | |
| *** laughterwym has quit IRC | 10:08 | |
| *** qeelee has quit IRC | 10:09 | |
| *** salv-orlando has quit IRC | 10:11 | |
| *** salv-orlando has joined #openstack-cinder | 10:12 | |
| *** haomaiwang has quit IRC | 10:23 | |
| *** lpetrut has joined #openstack-cinder | 10:26 | |
| *** sdague has joined #openstack-cinder | 10:27 | |
| *** ishant has quit IRC | 10:27 | |
| *** haomaiwang has joined #openstack-cinder | 10:29 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Add devref on rolling upgrades https://review.openstack.org/279186 | 10:33 |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: Mark oslo.vmware as optional dependency https://review.openstack.org/242257 | 10:36 |
| *** erlon has joined #openstack-cinder | 10:48 | |
| *** sgotliv has joined #openstack-cinder | 10:49 | |
| *** jwcroppe has joined #openstack-cinder | 10:50 | |
| *** markvoelker has joined #openstack-cinder | 10:54 | |
| *** salv-orlando has quit IRC | 10:57 | |
| *** markvoelker has quit IRC | 10:58 | |
| *** yhayashi has quit IRC | 11:00 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-cinder | 11:01 | |
| yuriy_n17 | geguileo: Hi! Very sorry for distusbing. Please review https://review.openstack.org/#/c/271696/ whenever you have free time. Thanks a lot for advance. | 11:03 |
| yuriy_n17 | DuncanT: Hi! Very sorry for distusbing. Please review https://review.openstack.org/#/c/271696/ whenever you have free time. Thanks a lot for advance. | 11:04 |
| *** sgotliv has quit IRC | 11:08 | |
| openstackgerrit | javeme proposed openstack/cinder-specs: Implement the oslo_db enginefacade proposal https://review.openstack.org/270601 | 11:11 |
| *** haomaiwang has quit IRC | 11:14 | |
| *** eantyshev has joined #openstack-cinder | 11:19 | |
| *** eantyshev has left #openstack-cinder | 11:19 | |
| *** eantyshev has joined #openstack-cinder | 11:20 | |
| *** qeelee has joined #openstack-cinder | 11:20 | |
| *** jwcroppe has quit IRC | 11:23 | |
| *** Poornima has quit IRC | 11:25 | |
| openstackgerrit | javeme proposed openstack/cinder: Remove RequestBodySizeLimiter from middleware https://review.openstack.org/282176 | 11:26 |
| eantyshev | Hello! Are Cinder gate tests broken? I don't see anything merged in the past 32 hours | 11:26 |
| *** EinstCrazy has joined #openstack-cinder | 11:32 | |
| dulek | eantyshev: Yup. | 11:36 |
| dulek | eantyshev: https://review.openstack.org/#/c/284816/ - this will fix it, but still not +A. | 11:36 |
| eantyshev | dulek: Thanks! Will give it my +1 :^) | 11:39 |
| *** lprice has joined #openstack-cinder | 11:41 | |
| *** lprice1 has quit IRC | 11:41 | |
| *** smoriya_ has quit IRC | 11:56 | |
| *** qeelee has quit IRC | 11:58 | |
| openstackgerrit | Scott DAngelo proposed openstack/python-cinderclient: api-microversion support for python-cinderclient https://review.openstack.org/248163 | 12:05 |
| *** gcb has quit IRC | 12:10 | |
| *** gcb has joined #openstack-cinder | 12:11 | |
| *** Lee1092 has quit IRC | 12:12 | |
| *** ccesario has quit IRC | 12:12 | |
| *** krotscheck_dcm is now known as krotscheck | 12:13 | |
| *** haomaiwang has joined #openstack-cinder | 12:14 | |
| *** cdelatte has joined #openstack-cinder | 12:18 | |
| *** haomaiwang has quit IRC | 12:19 | |
| *** jwcroppe has joined #openstack-cinder | 12:20 | |
| *** salv-orlando has joined #openstack-cinder | 12:20 | |
| *** zhipeng has quit IRC | 12:21 | |
| *** ccesario has joined #openstack-cinder | 12:25 | |
| *** raildo-afk is now known as raildo | 12:32 | |
| *** laughterwym has joined #openstack-cinder | 12:33 | |
| *** jordanP has quit IRC | 12:35 | |
| *** jordanP has joined #openstack-cinder | 12:36 | |
| *** markvoelker has joined #openstack-cinder | 12:40 | |
| *** dalgaaf has joined #openstack-cinder | 12:40 | |
| *** takedakn has joined #openstack-cinder | 12:43 | |
| *** markvoelker has quit IRC | 12:44 | |
| *** julim has joined #openstack-cinder | 12:45 | |
| *** takedakn has quit IRC | 12:50 | |
| *** abhishekk_ has quit IRC | 12:52 | |
| *** jwcroppe has quit IRC | 12:53 | |
| *** gcb has quit IRC | 12:55 | |
| *** aagrawal has quit IRC | 12:57 | |
| geguileo | yuriy_n17: Done | 13:18 |
| *** markvoelker has joined #openstack-cinder | 13:20 | |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: Allow api_version_request.matches to accept a string https://review.openstack.org/285293 | 13:20 |
| scottda | sheel: ^^^ | 13:20 |
| scottda | I did not add the defaults for "min_verson=None, max_version=None" | 13:21 |
| sheel | scottda: great | 13:21 |
| sheel | scottda: so i need to pass 3.1, None | 13:21 |
| sheel | right? | 13:21 |
| sheel | or may be only min version | 13:22 |
| scottda | I want to think on that and run some tests first | 13:22 |
| sheel | k | 13:22 |
| scottda | sheel: I think for now you need "3.1", "3.1" | 13:22 |
| openstackgerrit | Avishay Traeger proposed openstack/cinder: List manageable volumes and snapshots https://review.openstack.org/285296 | 13:22 |
| scottda | But test with passing "3.1", None | 13:22 |
| sheel | hmm | 13:22 |
| sheel | ok | 13:23 |
| *** ric has joined #openstack-cinder | 13:23 | |
| *** cknight has joined #openstack-cinder | 13:23 | |
| scottda | I'm just not sure about setting the defaults. But you can at least list that patch as a dependency and carry on with your testing, etc. | 13:23 |
| sheel | yes, sure | 13:23 |
| sheel | i ll keep that as dependent | 13:24 |
| sheel | scottda: will test and ping u in second half if all went well | 13:25 |
| *** cknight has quit IRC | 13:25 | |
| yuriy_n17 | geguileo: Thank you ever so much. | 13:25 |
| *** merooney has joined #openstack-cinder | 13:30 | |
| *** merooney has quit IRC | 13:34 | |
| *** cbader has quit IRC | 13:34 | |
| *** gouthamr has joined #openstack-cinder | 13:35 | |
| *** porrua has joined #openstack-cinder | 13:35 | |
| openstackgerrit | Jordan Pittier proposed openstack/os-brick: Mock time.sleep() in 3 unit tests https://review.openstack.org/285302 | 13:35 |
| *** baumann has joined #openstack-cinder | 13:35 | |
| *** akerr has joined #openstack-cinder | 13:37 | |
| *** haomaiwang has joined #openstack-cinder | 13:38 | |
| *** alkhodos has quit IRC | 13:42 | |
| *** merooney has joined #openstack-cinder | 13:43 | |
| *** ric has quit IRC | 13:47 | |
| *** cbader has joined #openstack-cinder | 13:47 | |
| *** jwcroppe has joined #openstack-cinder | 13:50 | |
| *** edmondsw has joined #openstack-cinder | 13:50 | |
| *** dims has joined #openstack-cinder | 13:54 | |
| *** jwcroppe has quit IRC | 13:58 | |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: Allow api_version_request.matches to accept a string https://review.openstack.org/285293 | 13:58 |
| *** merooney has quit IRC | 13:59 | |
| scottda | sheel: ^^ Fixed a bug, and added unit test for passing in api_version_request.matches("3.2", None) or (None, "3.2") | 13:59 |
| scottda | That should be good. I don't think we need default values = None for the args to matches() | 14:00 |
| *** haomaiwang has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-cinder | 14:01 | |
| sheel | scottda: ok, nice | 14:02 |
| openstackgerrit | Jordan Pittier proposed openstack/os-brick: Actually run the RemoteFSClient unit tests https://review.openstack.org/285313 | 14:03 |
| sheel | scottda: sounds good | 14:03 |
| jordanP | I am on a "fix unit tests" spree :) | 14:03 |
| jordanP | (that's to be nice with the community, in the hope that by next patch, which is vendor specific, is going to be reviewed with kindess :p) | 14:05 |
| scottda | jordanP: You get a sticker for that. I cannot promise any kindness from anyone around here :) | 14:05 |
| jordanP | :D | 14:05 |
| *** rlrossit has joined #openstack-cinder | 14:06 | |
| *** zhangjn has quit IRC | 14:08 | |
| *** zhangjn has joined #openstack-cinder | 14:09 | |
| *** jungleboyj has quit IRC | 14:11 | |
| openstackgerrit | Merged openstack/cinder: Tests: Don't assert on LOG.warn https://review.openstack.org/284816 | 14:11 |
| openstackgerrit | Mannu proposed openstack/cinder: Return BadRequest for invalid Unicode names https://review.openstack.org/285320 | 14:12 |
| *** alyson_ has joined #openstack-cinder | 14:12 | |
| *** takedakn has joined #openstack-cinder | 14:13 | |
| *** takedakn has quit IRC | 14:14 | |
| *** EinstCrazy has quit IRC | 14:14 | |
| *** avishay has joined #openstack-cinder | 14:15 | |
| *** xyang1 has joined #openstack-cinder | 14:17 | |
| *** diablo_rojo has joined #openstack-cinder | 14:22 | |
| *** xyang has joined #openstack-cinder | 14:24 | |
| *** laughterwym has quit IRC | 14:25 | |
| *** anshul has quit IRC | 14:25 | |
| *** yangyapeng has joined #openstack-cinder | 14:26 | |
| *** nkrinner has quit IRC | 14:26 | |
| *** cknight has joined #openstack-cinder | 14:27 | |
| *** merooney has joined #openstack-cinder | 14:30 | |
| *** timcl has joined #openstack-cinder | 14:32 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Enable all unit tests on Python 3.4 https://review.openstack.org/284308 | 14:35 |
| *** dansmith is now known as superdan | 14:36 | |
| *** laughterwym has joined #openstack-cinder | 14:37 | |
| *** jgregor has joined #openstack-cinder | 14:39 | |
| *** eharney has joined #openstack-cinder | 14:42 | |
| *** dustins has joined #openstack-cinder | 14:43 | |
| *** knikolla has joined #openstack-cinder | 14:43 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Delete volumes with snapshots https://review.openstack.org/264982 | 14:44 |
| smcginnis | geguileo: If there's another gate blocker, feel free to +A right away to get those through. | 14:45 |
| *** larsks has joined #openstack-cinder | 14:45 | |
| *** chhavi has joined #openstack-cinder | 14:45 | |
| larsks | eharney: Does cinder have anything like nova's rpc version pinning, so that a version N-1 cinder-volume can talk to a version N cinder-api/scheduler/etc? | 14:46 |
| *** gcb has joined #openstack-cinder | 14:46 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Add missing requirements https://review.openstack.org/284929 | 14:49 |
| *** crose has joined #openstack-cinder | 14:51 | |
| xyang | smcginnis: is anyone looking at this error in cinder.tests.unit.volume.drivers.netapp.dataontap.test_block_base.NetAppBlockStorageLibraryTestCase.test_get_reserved_percentage. | 14:52 |
| akerr | xyang: there's a patch up already | 14:52 |
| akerr | xyang: I think it just merged | 14:52 |
| xyang | akerr: great | 14:52 |
| xyang | akerr: thanks | 14:53 |
| merooney | xyang https://review.openstack.org/#/c/284816/ | 14:54 |
| *** jwcroppe has joined #openstack-cinder | 14:54 | |
| xyang | merooney: thanks | 14:54 |
| *** _alastor1 has quit IRC | 14:55 | |
| openstackgerrit | Gage Hugo proposed openstack/cinder: Removed duplicated code in VNX cinder driver https://review.openstack.org/279782 | 14:56 |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: Allow api_version_request.matches to accept a string https://review.openstack.org/285293 | 14:57 |
| *** cknight has quit IRC | 14:58 | |
| *** kvidvans has quit IRC | 14:58 | |
| *** kvidvans has joined #openstack-cinder | 14:58 | |
| *** mriedem has joined #openstack-cinder | 14:58 | |
| scottda | When I post a patch with "Closes-Bug: <bug>" , isn't that supposed to show up in the bug report? | 14:59 |
| eharney | larsks: yes, it does, there has been a fair amount of mitaka work to add that | 15:00 |
| larsks | eharney: I saw the bp and some patches, but I wasn't sure if the feature was entirely implemented yet. Sounds like yes? | 15:00 |
| smcginnis | scottda: Should. I noticed another one that didn't though. | 15:00 |
| smcginnis | scottda: I wonder if something broke there. | 15:00 |
| *** edtubill has joined #openstack-cinder | 15:00 | |
| *** haomaiwang has quit IRC | 15:01 | |
| scottda | smcginnis: I'll keep an eye on it. Might just be a lag. | 15:01 |
| eharney | larsks: that i'm not sure about -- i'm not sure what may be remaining still | 15:01 |
| *** haomaiwang has joined #openstack-cinder | 15:01 | |
| larsks | eharney: okay, thanks. | 15:01 |
| *** laughterwym has quit IRC | 15:01 | |
| *** arecknag has quit IRC | 15:02 | |
| sheel | scottda: hey, I too noticed this thing | 15:02 |
| sheel | scottda: but after 2-3 houts it was showing | 15:03 |
| sheel | scottda: so seems some lag sometimes | 15:03 |
| scottda | sheel: Thanks. BTW, with your filters patch, are there any existing unit tests for this function? It would be nice to add/change UT for different microversion behaviour. | 15:04 |
| *** delattec has joined #openstack-cinder | 15:04 | |
| sheel | scottda: ah yes | 15:05 |
| sheel | scottda: let me check | 15:05 |
| *** cdelatte has quit IRC | 15:06 | |
| *** laughterwym has joined #openstack-cinder | 15:06 | |
| sheel | scottda: here you go | 15:08 |
| sheel | https://review.openstack.org/#/c/272232/5/cinderclient/tests/unit/v2/test_shell.py | 15:08 |
| sheel | very small tests though | 15:08 |
| sheel | :) | 15:08 |
| *** merooney has quit IRC | 15:08 | |
| scottda | sheel: So, how does the behaviour change with your fix? Can this be unit tested? | 15:09 |
| *** arch-nemesis has joined #openstack-cinder | 15:09 | |
| sheel | scottda: actuall before this fix, filtering was considering everything as True | 15:10 |
| sheel | scottda: except if we explicitely pass False | 15:10 |
| scottda | sheel: If we can test the change, we should be able to test 2 ways: 1 with no_microversion | old_microversion and old behaviour, and one with new_microversion and new behaviour | 15:10 |
| scottda | sheel: OK, it's something we can think on. | 15:11 |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Check for service existance in capabilities API https://review.openstack.org/271696 | 15:11 |
| sheel | scottda: but in this patch it will raise error for anything passed other than o/false/False/1/true/True | 15:11 |
| *** jwcroppe has quit IRC | 15:11 | |
| sheel | scottda: right i need to right test for this | 15:11 |
| sheel | I need to write | 15:12 |
| sheel | :) | 15:12 |
| sheel | scottda: give me 15 min | 15:12 |
| sheel | scottda: will add to it | 15:12 |
| sheel | scottda: ok? | 15:12 |
| scottda | sheel: sounds goog | 15:13 |
| scottda | s/goog/good | 15:13 |
| sheel | :) | 15:13 |
| sheel | oh, I was checking my dictionary if it has goog | 15:13 |
| sheel | just kidding | 15:13 |
| sheel | : | 15:13 |
| sheel | :) | 15:13 |
| *** laughterwym has quit IRC | 15:14 | |
| sheel | scottda: here i go.. | 15:17 |
| *** JoseMello has joined #openstack-cinder | 15:17 | |
| sheel | https://www.irccloud.com/pastebin/3Z1rPInL/ | 15:17 |
| sheel | scottda: will add to patch | 15:18 |
| sheel | in a while | 15:18 |
| mc_nair | know we're racing towards feature freeze, but anyone who gives https://review.openstack.org/#/c/282068/ a review will get some BBQ or beer in Austin | 15:18 |
| mc_nair | pure bribery time | 15:18 |
| *** cknight has joined #openstack-cinder | 15:19 | |
| smcginnis | ;) | 15:19 |
| openstackgerrit | Ronald Bradford proposed openstack/cinder: Define context.roles with base class https://review.openstack.org/285354 | 15:21 |
| *** merooney has joined #openstack-cinder | 15:21 | |
| *** IlyaG has joined #openstack-cinder | 15:22 | |
| *** aorourke-afk is now known as aorourke | 15:24 | |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: Allow api_version_request.matches to accept a string https://review.openstack.org/285293 | 15:26 |
| *** IlyaG has quit IRC | 15:27 | |
| *** delatte has joined #openstack-cinder | 15:28 | |
| *** lprice has quit IRC | 15:30 | |
| *** gcb has quit IRC | 15:30 | |
| *** delattec has quit IRC | 15:30 | |
| *** Yogi1 has joined #openstack-cinder | 15:33 | |
| *** lcurtis has joined #openstack-cinder | 15:39 | |
| *** belmoreira has quit IRC | 15:43 | |
| openstackgerrit | Jacob Gregor proposed openstack/cinder: Storwize SVC multiple management IPs https://review.openstack.org/284267 | 15:43 |
| sheel | smcginnis: hi there | 15:43 |
| sheel | https://review.openstack.org/#/c/284571/ turned green | 15:43 |
| smcginnis | sheel: OK, thanks. | 15:44 |
| smcginnis | sheel: Looks like the recheck is still running. | 15:45 |
| sheel | smcginnis: all voting tests passed | 15:45 |
| sheel | @zuul | 15:45 |
| smcginnis | sheel: Oh, still working through but all tests are passing? | 15:46 |
| sheel | smcginnis: yes all are passing, only one test is left, will hardly take atmost 30 seconds | 15:46 |
| smcginnis | The review itself has the last jenkins result from about 10 hours ago. | 15:46 |
| smcginnis | sheel: OK, thanks. | 15:46 |
| *** mriedem has quit IRC | 15:49 | |
| sheel | smcginnis: thank you | 15:49 |
| openstackgerrit | Avishay Traeger proposed openstack/python-cinderclient: List manageable volumes and snapshots https://review.openstack.org/285381 | 15:50 |
| openstackgerrit | Avishay Traeger proposed openstack/python-cinderclient: List manageable volumes and snapshots https://review.openstack.org/285381 | 15:51 |
| openstackgerrit | Jordan Pittier proposed openstack/os-brick: Fix Scality SOFS support https://review.openstack.org/285382 | 15:51 |
| *** avishay has quit IRC | 15:53 | |
| *** mriedem has joined #openstack-cinder | 15:53 | |
| *** mtanino has joined #openstack-cinder | 15:54 | |
| *** mriedem is now known as mriedem_meeting | 15:54 | |
| *** yangyapeng has quit IRC | 15:56 | |
| *** yangyapeng has joined #openstack-cinder | 15:56 | |
| *** yangyapeng has quit IRC | 15:56 | |
| *** Yogi1 has quit IRC | 15:58 | |
| *** salv-orl_ has joined #openstack-cinder | 15:59 | |
| *** jeanfabrice has quit IRC | 16:00 | |
| *** arch-nemesis has quit IRC | 16:00 | |
| *** lprice has joined #openstack-cinder | 16:00 | |
| *** martyturner has joined #openstack-cinder | 16:00 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-cinder | 16:01 | |
| *** salv-orlando has quit IRC | 16:01 | |
| *** hemnafk is now known as hemna | 16:04 | |
| *** haplo37 has joined #openstack-cinder | 16:06 | |
| *** _alastor1 has joined #openstack-cinder | 16:08 | |
| *** mriedem_meeting has quit IRC | 16:08 | |
| sheel | xyang: yes its merged | 16:09 |
| sheel | xyang: sorry, other group | 16:09 |
| smcginnis | hemna: Morning! Curious, did you ever see a speed improvement with all that caching work you did? | 16:11 |
| hemna | still haven't plugged it into our CI yet | 16:11 |
| hemna | the box that had my mirror died | 16:12 |
| smcginnis | hemna: Bleh | 16:12 |
| hemna | yup | 16:12 |
| smcginnis | hemna: Any non-CI, local testing show an improvement? | 16:12 |
| hemna | my local apt-get stuff worked well | 16:12 |
| hemna | and was much faster | 16:12 |
| hemna | no 503 errors either | 16:12 |
| hemna | :) | 16:12 |
| smcginnis | hemna: Nice. | 16:13 |
| smcginnis | Maybe I should give it another try here. | 16:13 |
| sheel | eharney: hi | 16:13 |
| eharney | sheel: hi | 16:13 |
| smcginnis | hemna: What packages did you end up setting up again? apt-cache-ng? | 16:13 |
| hemna | apt-mirror is what I used | 16:13 |
| hemna | I can send you my conf | 16:13 |
| smcginnis | hemna: Cool, thanks for the pointer. | 16:13 |
| *** logan- has quit IRC | 16:14 | |
| sheel | eharney: regarding your review on https://review.openstack.org/#/c/284571/4 | 16:14 |
| *** logan- has joined #openstack-cinder | 16:14 | |
| sheel | eharney: i uploaded this patch set for verbose that you wanted to add | 16:14 |
| sheel | :) | 16:14 |
| *** mriedem has joined #openstack-cinder | 16:14 | |
| *** laughterwym has joined #openstack-cinder | 16:14 | |
| eharney | sheel: this is not the right approach | 16:14 |
| hemna | smcginnis, http://paste.openstack.org/show/488393/ | 16:14 |
| hemna | that pulls 64bit and 32bti | 16:14 |
| hemna | and puts everything in /mnt/apt-mirror | 16:14 |
| smcginnis | hemna: Is 32bit needed? | 16:15 |
| hemna | yah | 16:15 |
| sheel | eharney: is this adding some complexity? | 16:15 |
| sheel | eharney: just out of curiosity.. | 16:15 |
| hemna | 195G | 16:15 |
| eharney | sheel: yes? all of the code related to parsing Unicode etc... | 16:15 |
| eharney | sheel: which we don't need to achieve the right result | 16:15 |
| smcginnis | hemna: Good thing I've got some storage laying around. ;) | 16:16 |
| hemna | smcginnis, after you have that mirrored, then it's a simple matter of apache pointing to it. | 16:16 |
| hemna | smcginnis, :) | 16:16 |
| sheel | sheel: oh | 16:16 |
| sheel | eharney: oh | 16:16 |
| hemna | smcginnis, I used a 3PAR iSCSI volume for it...good thing since the box serving it up burned. | 16:16 |
| smcginnis | hemna: Yeah, at least you don't need to pull it all down again. | 16:16 |
| hemna | yup | 16:17 |
| *** sgotliv has joined #openstack-cinder | 16:17 | |
| *** ntpttr has joined #openstack-cinder | 16:17 | |
| sheel | eharney: so could you suggest some approach so that i could mould it | 16:17 |
| sheel | eharney: if possible only as good gesture.. | 16:17 |
| sheel | eharney: thanks in advance | 16:17 |
| yuriy_n17 | hemna: Hi! Very sorry for disturbing. Please review https://review.openstack.org/#/c/263744/ whenever you have free time. | 16:17 |
| openstackgerrit | Eric Harney proposed openstack/cinder: Return BadRequest for invalid Unicode names https://review.openstack.org/285320 | 16:18 |
| *** mriedem has left #openstack-cinder | 16:18 | |
| *** mriedem has joined #openstack-cinder | 16:18 | |
| eharney | sheel: i'm about to add it to this patch, all we need is a LOG.exception there and we're good ^ | 16:19 |
| hemna | yuriy_n17, I have, and I kind think that DuncanT is right | 16:19 |
| eharney | (rebased to kick it out of the gate since i approved it before realizing that was missing) | 16:19 |
| sheel | eharney: ok | 16:19 |
| *** laughterwym has quit IRC | 16:19 | |
| hemna | I think maybe we should just run sudo cinder local-attach | 16:19 |
| *** yuriy_n17 has quit IRC | 16:21 | |
| *** dims has quit IRC | 16:22 | |
| *** _alastor1 has quit IRC | 16:23 | |
| *** jdurgin1 has joined #openstack-cinder | 16:24 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Return BadRequest for invalid Unicode names https://review.openstack.org/285320 | 16:25 |
| mriedem | new ceph job bug https://bugs.launchpad.net/cinder/+bug/1550409 | 16:26 |
| openstack | Launchpad bug 1550409 in Cinder ""Detected volume stuck in downloading status, setting to ERROR." in ceph job" [Undecided,New] | 16:26 |
| eharney | sheel: try out that patch and see what you think ^ | 16:26 |
| sheel | eharney: it seems ok | 16:27 |
| sheel | eharney: but no information about which field is craeting problem | 16:27 |
| sheel | "Error writing field to database" | 16:27 |
| sheel | eharney: its quite generalized | 16:27 |
| sheel | eharney: may be we should be a bit specific | 16:27 |
| eharney | sheel: the logged exception will give that info | 16:27 |
| openstackgerrit | Michael Price proposed openstack/cinder: NetApp: Add Consistency Group support for E-Series https://review.openstack.org/282388 | 16:27 |
| sheel | eharney: you mean, it will output field name as well? | 16:28 |
| sheel | eharney: if so then quite good | 16:28 |
| *** garthb has joined #openstack-cinder | 16:28 | |
| *** garthb_ has joined #openstack-cinder | 16:28 | |
| eharney | sheel: yes, try it out and you will see a message in the log that says "Incorrect string value: '\\xF0\\x9F\\xA0\\x80' for column 'display_name'" | 16:28 |
| sheel | eharney: great | 16:29 |
| eharney | sheel: oslo.db etc already handles this stuff for us, we don't have to code for it too | 16:29 |
| sheel | eharney: i guess you suggest this approach | 16:29 |
| sheel | eharney: to committer for sure | 16:29 |
| sheel | eharney: nice fix | 16:29 |
| *** Lee1092 has joined #openstack-cinder | 16:29 | |
| *** merooney has quit IRC | 16:30 | |
| *** rcernin has quit IRC | 16:31 | |
| *** darosale has joined #openstack-cinder | 16:34 | |
| *** mss has joined #openstack-cinder | 16:34 | |
| *** timcl has quit IRC | 16:35 | |
| *** garthb has quit IRC | 16:36 | |
| *** garthb_ has quit IRC | 16:36 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Don't allow operations on deleting volumes https://review.openstack.org/284994 | 16:39 |
| *** merooney has joined #openstack-cinder | 16:39 | |
| *** diablo_rojo has quit IRC | 16:40 | |
| openstackgerrit | Merged openstack/cinder: Correct iscsi lun type https://review.openstack.org/283475 | 16:41 |
| *** garthb has joined #openstack-cinder | 16:44 | |
| jgriffith | ntpttr: ping | 16:47 |
| openstackgerrit | David Rosales proposed openstack/cinder: Change Fail to Failed in error messages https://review.openstack.org/284395 | 16:47 |
| jgriffith | ntpttr: sorry for the -2... but let me know if the comments don't make sense: https://review.openstack.org/#/c/284994/3 | 16:47 |
| ntpttr | jgriffith: hey | 16:47 |
| ntpttr | jgriffith: no problem, I was pretty sure there was a better way to go about it | 16:48 |
| jgriffith | ntpttr: yeah... | 16:48 |
| jgriffith | ntpttr: so sadly we have a lack of discipline in how we do things so there's various things scattered all over the place. If I happen to see them I chime in | 16:48 |
| jgriffith | ntpttr: it was your lucky day :) | 16:48 |
| ntpttr | jgriffith: what do you mean by various things? | 16:49 |
| jgriffith | ntpttr: so status checks are a good example | 16:49 |
| jgriffith | ntpttr: rather than just by convention making those checks in the API layer... we sometimes do them there, sometimes in the manager and sometimes in both :( | 16:50 |
| ntpttr | jgriffith: ah yeah your comment does make sense, and I was thinking that was needed - hence my comment after uploading the first patch set - but I wasn't sure what check would go there | 16:50 |
| jgriffith | ntpttr: which is one of the reasons we have issues with races the way we do IMO | 16:50 |
| ntpttr | jgriffith: ah yes, like the quota checks from that bug I was looking at a while back | 16:50 |
| jgriffith | ntpttr: YES!!! Exactly!!!! | 16:50 |
| jgriffith | ntpttr: we have the same sort of problem with other calls too | 16:51 |
| jgriffith | ntpttr: ie we left things open to interpretation and now there's some really "weird" code in various places for everybody's "one-off" patch | 16:51 |
| ntpttr | jgriffith: so, before the delete call is issued from the API, we need to be checking the status of the volume to make sure nothing else is going on with it | 16:51 |
| jgriffith | ntpttr: yes, that would be the correct thing here IMO | 16:51 |
| ntpttr | jgriffith: but things like initialize_connection don't change volume status do they? | 16:51 |
| ntpttr | jgriffith: that's why I wasn't sure what check to include | 16:52 |
| jgriffith | ntpttr: although I'm sure somebody removed that at some point for their *special case* they wanted to solve | 16:52 |
| jgriffith | ntpttr: they don't need to.. because prior to calling initialize-connection you need to call "reserve" which changes it | 16:52 |
| jgriffith | ntpttr: so that's a confusing thing | 16:52 |
| jgriffith | and I think part of why understanding has diverged so much | 16:53 |
| ntpttr | jgriffith: okay that makes sense, so when the volume is reserved it's no longer available - so we need to check to see that it's not in some status other than available or error before deleting | 16:53 |
| jgriffith | ntpttr: so when it comes to attach/detach... basically the only two calls that were every intended to "do" anything were intialize and terminate connection | 16:53 |
| dulek | It's Friday evening, so I'm unable to look into it, but I've seen 2 failures of gate-tempest-dsvm-full-ceph on rechecked patches (https://review.openstack.org/#/c/284308 - one of them). | 16:53 |
| dulek | Just a heads up. | 16:53 |
| jgriffith | ntpttr: the "reserve/attach" and "begin term / detach" were just DB status updates and call-backs | 16:54 |
| jgriffith | ntpttr: but that's changed dramatically | 16:54 |
| jgriffith | ntpttr: sorry... "reserve/attach" and "begin_detaching/detach" are the analogous calls I was referring to | 16:55 |
| ntpttr | jgriffith: ah okay that's starting to come together now. I didn't know about that! | 16:55 |
| ntpttr | jgriffith: thanks for the help/info :) | 16:55 |
| jgriffith | ntpttr: sure | 16:55 |
| jgriffith | ntpttr: BTW http://j-griffith.github.io/2015/07/16/volume-attach-code-flow-in-cinder/ | 16:55 |
| jgriffith | ntpttr: I'm going to update it with the detach stuff right now | 16:56 |
| * jgriffith should've done it years ago | 16:56 | |
| ntpttr | jgriffith: awesome, I'll check it out | 16:56 |
| *** Yogi1 has joined #openstack-cinder | 16:56 | |
| ntpttr | it would be cool to have recommended reading stuff like this linked in the wiki somewhere maybe, otherwise it's not easy for new folks to find it all | 16:56 |
| jgriffith | ntpttr: yeah... I wanted to start updating the devref docs in tree | 16:57 |
| jgriffith | ntpttr: but I've found that that's not so good because they get neglected and nobody updates them | 16:57 |
| jgriffith | ntpttr: incorrect info is worse than no info | 16:57 |
| ntpttr | jgriffith: true | 16:58 |
| scottda | jgriffith: ++ . We could stand to document these architectural/design standards and best practices, so we can have consistency for new code. | 16:58 |
| Swanson | jgriffith, make updating the wiki a requirement to merge? | 16:58 |
| scottda | Swanson: or updating the devref | 16:58 |
| jgriffith | scottda: NOOO wikis! | 16:58 |
| jgriffith | errr... Swanson | 16:58 |
| jgriffith | scottda: +1 | 16:59 |
| Swanson | jgriffith, scottda, yeah, devref. | 16:59 |
| jgriffith | scottda: I was just looking there because I know I submitted that write up there as well... not sure it ever merged | 16:59 |
| scottda | IMO, devref changes should be included in patches with major functional changes, so they can be reviewed at the same time and gate merging the feature or fix. | 16:59 |
| Swanson | jgriffith, v2.1 is never going to merge. look forward to seeing it in newton. | 16:59 |
| *** asselin_ has joined #openstack-cinder | 16:59 | |
| jgriffith | scottda: agreed! | 16:59 |
| jgriffith | Swanson: huh? Why do you say that? | 17:00 |
| jgriffith | Swanson: of course if that's how it goes I'm fine with it | 17:00 |
| *** merooney has quit IRC | 17:00 | |
| *** haomaiwang has quit IRC | 17:01 | |
| jgriffith | Swanson: but I thought after the unit test fix was in a recheck would allow it to just "breeze on by" :) | 17:01 |
| *** apoorvad has joined #openstack-cinder | 17:01 | |
| jgriffith | scottda: ntpttr I'll work up a devref docs patch for the attach/detach stuff right now | 17:01 |
| *** haomaiwang has joined #openstack-cinder | 17:01 | |
| *** asselin__ has quit IRC | 17:01 | |
| Swanson | jgriffith, I'm just a firm believer that gerrit is always darkest right before it fails completely. So I have to assume it'll be another 29 hours before we see the next ceph failure. Then god help us all. | 17:02 |
| jgriffith | LOL | 17:03 |
| jgriffith | Well that could be | 17:03 |
| *** jgregor has quit IRC | 17:03 | |
| jgriffith | and all the additions to eharney 's patch last night didn't help the timeline :) | 17:03 |
| eharney | that thing did take a while to squeak through | 17:04 |
| jgriffith | eharney: yeah, then a rebase at the 11'th hour, followed by another add and then another | 17:05 |
| jgriffith | eharney: I was watching it in ancicipation and it drove me to drink :) | 17:05 |
| eharney | :) | 17:05 |
| Swanson | :) | 17:05 |
| *** jordanP has quit IRC | 17:06 | |
| *** mss is now known as _alastor_ | 17:07 | |
| ntpttr | jgriffith: would the best way to go about fixing the delete issue be to more the checks here up to the top of the function? https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L395 ? Or were those put there for some reason? Seems odd that if the check is needed it would come after a possible deletion happens earlier in the function | 17:08 |
| jgriffith | ntpttr: yes, IMO that's what we should have | 17:09 |
| *** dims has joined #openstack-cinder | 17:09 | |
| *** leeantho has joined #openstack-cinder | 17:09 | |
| jgriffith | ntpttr: so we never get to a point where we try and delete and attached/attaching volume | 17:09 |
| *** dims has quit IRC | 17:10 | |
| *** chris_morrell has joined #openstack-cinder | 17:12 | |
| *** jklare_ has joined #openstack-cinder | 17:12 | |
| *** melwitt_ has joined #openstack-cinder | 17:12 | |
| *** rhagarty__ has joined #openstack-cinder | 17:12 | |
| *** xek__ has joined #openstack-cinder | 17:13 | |
| *** IlyaG has joined #openstack-cinder | 17:13 | |
| hemna | smcginnis, ping | 17:14 |
| *** j_king_ has joined #openstack-cinder | 17:15 | |
| *** Trident has joined #openstack-cinder | 17:15 | |
| *** diegows_ has joined #openstack-cinder | 17:16 | |
| *** guitarza1 has joined #openstack-cinder | 17:16 | |
| *** mikal_ has joined #openstack-cinder | 17:16 | |
| _alastor_ | hey folks. I'm trying to get this patch (https://review.openstack.org/#/c/284967/) to pass the gate, but I'm getting failures in drivers unrelated to mine (mostly it seems to be netapp) | 17:16 |
| *** tonyb_ has joined #openstack-cinder | 17:16 | |
| *** spring_ has joined #openstack-cinder | 17:16 | |
| *** jeanfabrice has joined #openstack-cinder | 17:16 | |
| *** Nakato_ has joined #openstack-cinder | 17:17 | |
| _alastor_ | For example, the failure listed in this gate check (http://logs.openstack.org/67/284967/3/check/gate-cinder-python27/6bded2b/console.html) is showing a failure in the netapp driver | 17:17 |
| *** jungleboyj has joined #openstack-cinder | 17:18 | |
| eharney | _alastor_: it's been fixed in master now, just issue a "recheck" | 17:18 |
| _alastor_ | Ok, thanks! | 17:18 |
| *** gouthamr_ has joined #openstack-cinder | 17:19 | |
| _alastor_ | Is the easiest way to recheck to `git commit --amend` then `git review` or is there a way to do it on the web UI? | 17:20 |
| *** edmondsw has quit IRC | 17:20 | |
| *** gouthamr has quit IRC | 17:20 | |
| *** xek_ has quit IRC | 17:20 | |
| *** zul has quit IRC | 17:20 | |
| *** rhagarty_ has quit IRC | 17:20 | |
| *** ekarlso- has quit IRC | 17:20 | |
| *** guitarzan has quit IRC | 17:20 | |
| *** Nakato has quit IRC | 17:20 | |
| *** anteaya has quit IRC | 17:20 | |
| *** krotscheck has quit IRC | 17:20 | |
| *** davechen_afk has quit IRC | 17:20 | |
| *** _fortis has quit IRC | 17:20 | |
| *** jklare has quit IRC | 17:20 | |
| *** j_king has quit IRC | 17:20 | |
| *** tonyb has quit IRC | 17:20 | |
| *** mikal has quit IRC | 17:20 | |
| *** mkoderer__ has quit IRC | 17:20 | |
| *** thurloat has quit IRC | 17:20 | |
| *** strictlyb has quit IRC | 17:20 | |
| *** bswartz has quit IRC | 17:20 | |
| *** afazekas has quit IRC | 17:20 | |
| *** bapalm has quit IRC | 17:20 | |
| *** Tridde has quit IRC | 17:20 | |
| *** diegows has quit IRC | 17:20 | |
| *** melwitt has quit IRC | 17:20 | |
| *** krotscheck has joined #openstack-cinder | 17:20 | |
| *** mkoderer___ has joined #openstack-cinder | 17:20 | |
| hemna | type recheck in the review | 17:20 |
| eharney | _alastor_: you can just leave a comment in gerrit that says "recheck" | 17:21 |
| *** afazekas has joined #openstack-cinder | 17:21 | |
| *** bapalm has joined #openstack-cinder | 17:21 | |
| *** strictlyb has joined #openstack-cinder | 17:21 | |
| _alastor_ | eharney: ok | 17:21 |
| *** thurloat has joined #openstack-cinder | 17:21 | |
| *** dims has joined #openstack-cinder | 17:22 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Stop deleting operation on busy volumes https://review.openstack.org/284994 | 17:22 |
| ntpttr | ^^ something went wrong there, it didn't upload the correct changes. I'll try it again | 17:23 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Stop deleting operation on busy volumes https://review.openstack.org/284994 | 17:24 |
| *** jeanfabrice has quit IRC | 17:25 | |
| *** rlrossit has quit IRC | 17:26 | |
| *** ekarlso- has joined #openstack-cinder | 17:27 | |
| *** edmondsw has joined #openstack-cinder | 17:27 | |
| *** zul has joined #openstack-cinder | 17:27 | |
| *** timcl has joined #openstack-cinder | 17:28 | |
| *** anteaya has joined #openstack-cinder | 17:28 | |
| *** _fortis_ has joined #openstack-cinder | 17:28 | |
| *** anshul has joined #openstack-cinder | 17:31 | |
| *** lpetrut has quit IRC | 17:32 | |
| *** [1]Thelo has joined #openstack-cinder | 17:33 | |
| *** Thelo has quit IRC | 17:35 | |
| *** _fortis_ is now known as _fortis | 17:35 | |
| *** [1]Thelo is now known as Thelo | 17:35 | |
| *** lpetrut has joined #openstack-cinder | 17:37 | |
| *** porrua has quit IRC | 17:40 | |
| *** jdurgin1 has quit IRC | 17:41 | |
| *** laughterwym has joined #openstack-cinder | 17:44 | |
| *** IlyaG has quit IRC | 17:47 | |
| *** laughterwym has quit IRC | 17:48 | |
| *** jistr has quit IRC | 17:49 | |
| *** merooney has joined #openstack-cinder | 17:50 | |
| *** xyang has quit IRC | 17:52 | |
| *** xyang has joined #openstack-cinder | 17:52 | |
| openstackgerrit | Sheel Rana proposed openstack/cinder: Added Bootable filter for cinder list command https://review.openstack.org/278605 | 17:53 |
| _alastor_ | eharney: I posted the 'recheck' comment, but I can't see anything showing that a recheck is scheduled. It doesn't show on tintri, or on the review itself | 17:54 |
| sheel | DuncanT: ^^ | 17:54 |
| sheel | _alastor_: you wont see anything on review page for recheck | 17:55 |
| DuncanT | sheel: I'm waiting for scottda's +1 on that before I go through it, he's our current expert | 17:57 |
| sheel | oh I mistakenly mentioned you | 17:57 |
| sheel | DuncanT: I was also thinking of pinging scottda | 17:58 |
| _alastor_ | sheel: ok, thanks. I'll sit tight and hope for the best :) | 17:58 |
| sheel | DuncanT: sorry | 17:58 |
| sheel | _alastor_: hey no, you can see this on zool | 17:58 |
| sheel | zuul | 17:58 |
| sheel | whats your review id | 17:58 |
| sheel | ? | 17:58 |
| _alastor_ | sheel: 284967 | 17:58 |
| sheel | scottda: https://review.openstack.org/278605 | 17:59 |
| DuncanT | sheel: I need to apologise, I was just letting you know that I was waiting. Worth getting the first one as right as we can | 17:59 |
| openstackgerrit | Adriano Freires Rosso proposed openstack/cinder: WIP: HNAS drivers refactoring https://review.openstack.org/285469 | 17:59 |
| sheel | DuncanT: no no, its ok...really i too wanted to get reviewed by scottda as we were discussing it since last day | 18:00 |
| sheel | DuncanT: sorry for making you feel like that | 18:00 |
| sheel | DuncanT: actually i am expecting -1 on this due to tests | 18:00 |
| sheel | DuncanT: :) | 18:00 |
| openstackgerrit | John Griffith proposed openstack/cinder: Add basic workflow of attach/detach to devref https://review.openstack.org/285471 | 18:00 |
| *** haomaiwang has quit IRC | 18:01 | |
| jgriffith | ntpttr: scottda smcginnis ^^ | 18:01 |
| jgriffith | there's a start at any rate | 18:01 |
| *** haomaiwang has joined #openstack-cinder | 18:01 | |
| sheel | DuncanT: once scottda passes it, i will ping you for review... | 18:01 |
| openstackgerrit | Adriano Freires Rosso proposed openstack/cinder: WIP: HNAS drivers refactoring https://review.openstack.org/285469 | 18:02 |
| *** ndipanov has quit IRC | 18:02 | |
| *** sgotliv has quit IRC | 18:02 | |
| sheel | _alastor_: hey its in rechecking state | 18:03 |
| _alastor_ | sheel: cool. Thanks for checking | 18:04 |
| sheel | _alastor_: a lot of requests are there, so may be take some long time to complete | 18:04 |
| _alastor_ | sheel: Any way I can see that queue? | 18:04 |
| sheel | _alastor_: no problem, you can also check on http://status.openstack.org/zuul/ | 18:05 |
| *** ChubYann has joined #openstack-cinder | 18:05 | |
| *** porrua has joined #openstack-cinder | 18:06 | |
| scottda | sheel: Sorry, I'm heading out early today, so won't get to it until monday. | 18:06 |
| sheel | scottda: no issues | 18:06 |
| sheel | scottda: happy weekend | 18:06 |
| ntpttr | jgriffith: thanks, I'll check it out | 18:06 |
| sheel | scottda: take rest, its been long microversionnig .. | 18:07 |
| scottda | sheel: For unit tests, I was thinking you could use one of the patterns in cinder/tests/unit/api/test_versions.py | 18:07 |
| scottda | sheel: In that way, you could see that the behaviour differed base on what version of the api was requested. | 18:07 |
| sheel | scottda: ok, sure | 18:07 |
| scottda | sheel: Thanks! | 18:08 |
| *** IlyaG has joined #openstack-cinder | 18:08 | |
| mc_nair | DuncanT: know it's probably too late for you today, but think you'll get to review https://review.openstack.org/#/c/282068/ before the feature freeze? | 18:08 |
| sheel | scottda: :) | 18:08 |
| *** dims is now known as dimsum__ | 18:09 | |
| DuncanT | mc_nair: Yeah, I'll take a look. I'd really like to see some really thorough tests for this quota code, including some that really show all the ways it's supposed to work - we made a mistake of merging without that once, and it was rather painful | 18:09 |
| sheel | hey all | 18:10 |
| sheel | need some eyes on https://review.openstack.org/#/c/274589/ .... | 18:10 |
| sheel | its waiting since long... :) | 18:10 |
| sheel | (quite small patch) | 18:10 |
| *** lpetrut has quit IRC | 18:10 | |
| mc_nair | DuncanT: yea, that's fair. I tried adding a decent amount of tests showing how it should work (it's over half the code in the patch), but there's nothing in Tempest currently. I'm working on adding those as we speak. The saving grace of the nested quota stuff now is at least it's not on by default :) | 18:11 |
| mc_nair | DuncanT: but that also means I need to create a new Tempest job that uses the nested quota driver to get the coverage | 18:12 |
| DuncanT | mc_nair: Glad to hear the tempest stuff is being worked on. Sounds like a possible candidate for a nova-style big-ops test in the gate that just used the fake driver? | 18:12 |
| mc_nair | DuncanT: not aware of that. Fake driver so it's not creating volumes and such? That would make sense. I'll follow up with you once I get more of the coverage working | 18:14 |
| sheel | DuncanT: now i am looking towards you for some help in review ^^ ... | 18:14 |
| sheel | :) | 18:15 |
| openstackgerrit | Merged openstack/cinder: Huawei: Log the IP when login fails https://review.openstack.org/283973 | 18:15 |
| mc_nair | DuncanT: currently working though adding the hierarchical projects and being able to switch between which project we're using to create the volumes. But that's starting to come along now | 18:15 |
| openstackgerrit | Merged openstack/cinder: NetApp: Implement CGs for ONTAP Drivers https://review.openstack.org/283194 | 18:16 |
| DuncanT | mc_nair: great to hear, thanks. | 18:16 |
| *** mriedem has quit IRC | 18:18 | |
| openstackgerrit | Merged openstack/cinder: Huawei: Don't fail when port group does not exist https://review.openstack.org/271599 | 18:19 |
| openstackgerrit | Merged openstack/cinder: EMC VMAX - not cleaning up HW Resource WWPN initiators https://review.openstack.org/280967 | 18:21 |
| openstackgerrit | Jay Bryant proposed openstack/cinder: Add CGSnapshotStatus enum field https://review.openstack.org/261068 | 18:22 |
| *** Yogi1 has quit IRC | 18:28 | |
| smcginnis | hemna: Still need something? | 18:28 |
| *** timcl has quit IRC | 18:29 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Delete volumes with snapshots https://review.openstack.org/264982 | 18:29 |
| eharney | i'd appreciate some final review on https://review.openstack.org/#/c/264982/ -- i missed one thing on the last rebase, but it should be good now | 18:30 |
| *** Suyash has joined #openstack-cinder | 18:31 | |
| *** bjornar__ has joined #openstack-cinder | 18:31 | |
| bjornar__ | How can I figure what options in cider.conf are spesific to api/volume/backup ? | 18:32 |
| bjornar__ | Is this documented at all? | 18:32 |
| sheel | bjornar__: Hey | 18:35 |
| sheel | bjornar__: i think its clearly mentioned in cinder.conf | 18:35 |
| sheel | bjornar__: please refer " | 18:35 |
| sheel | # Options defined in cinder.backup.driver" | 18:35 |
| sheel | " Options defined in cinder.backup.drivers.ceph" | 18:35 |
| sheel | # Options defined in cinder.wsgi | 18:36 |
| sheel | # Options defined in cinder.volume.api | 18:36 |
| sheel | bjornar__: hope it will help in differentiating | 18:36 |
| bjornar__ | sheel, but does this mean that section includes all the options for example cinder-volume will care about, or just the additional ones? | 18:37 |
| *** timcl has joined #openstack-cinder | 18:37 | |
| sheel | bjornar__: i think only more specific options | 18:38 |
| bjornar__ | sheel, Thats what I mean.. | 18:38 |
| sheel | bjornar__: for additional options I think i can point you to some other page | 18:38 |
| sheel | bjornar__: give me a sec, finding | 18:38 |
| *** knikolla has quit IRC | 18:40 | |
| *** knikolla has joined #openstack-cinder | 18:40 | |
| openstackgerrit | Apoorva Deshpande proposed openstack/cinder: Tintri image direct clone https://review.openstack.org/261126 | 18:40 |
| sheel | bjornar__: please refer http://docs.openstack.org/liberty/config-reference/content/section_volume-misc.html | 18:42 |
| sheel | bjornar__: for additional options of cinder.conf | 18:42 |
| sheel | bjornar__: you will find all options here in it, including different drivers etc | 18:44 |
| bjornar__ | sheel, but still no documentation on what config options apply for the different services? | 18:44 |
| sheel | bjornar__: ah, only small referential comments will be there in it | 18:45 |
| *** fthiagogv has quit IRC | 18:46 | |
| sheel | like "Table 2.66. Description of backups configuration options" | 18:46 |
| *** haomaiwang has quit IRC | 18:46 | |
| bjornar__ | sheel, no basically "noone" knows what config options cinder-backup uses? | 18:46 |
| *** AJaeger has joined #openstack-cinder | 18:47 | |
| bjornar__ | I mean, it probably uses database and mq.. so needs those options.. | 18:47 |
| openstackgerrit | Andreas Jaeger proposed openstack/cinder: always use pip constraints https://review.openstack.org/285494 | 18:47 |
| bjornar__ | but probably only api needs [keystone_authtoken] .. and so on | 18:47 |
| AJaeger | cinder cores, please review the change above together with the infra change https://review.openstack.org/285493 | 18:47 |
| *** haomaiwang has joined #openstack-cinder | 18:48 | |
| AJaeger | smcginnis: these two changes remove the constraints jobs and enable the new way of using them for cinder. A review of the infra change would be appreciated! | 18:48 |
| smcginnis | AJaeger: Will take a look now. Thanks! | 18:49 |
| AJaeger | smcginnis: thanks! If you have questions ask. No need to merge this *now* but let's not waste extra nodes with these jobs longer than needed... | 18:50 |
| sheel | bjornar__: some basic for backup, for mq - backup_topic = cinder-backup, for backup host -> backup_driver = cinder.backup.drivers.swift | 18:50 |
| smcginnis | AJaeger: That would be nice to get rid of those. | 18:50 |
| sheel | bjornar__: but, yes these options are not much detailed anywhere | 18:50 |
| bjornar__ | sheel, that is a big problem for understanding the services, I think | 18:50 |
| *** arch-nemesis has joined #openstack-cinder | 18:50 | |
| AJaeger | smcginnis: the same change I'm proposing has been done for nova and glance already | 18:50 |
| *** bardia has joined #openstack-cinder | 18:51 | |
| sheel | bjornar__: agree with you | 18:51 |
| bjornar__ | sheel, I dont even know, without ss .. who is talking to who | 18:51 |
| smcginnis | AJaeger: OK, good. Always nice when someone else takes the leap before you. ;) | 18:51 |
| sheel | bjornar__: hmm | 18:51 |
| smcginnis | bjornar__: Are you looking for something like this? http://docs.openstack.org/liberty/config-reference/content/section_backup-drivers.html | 18:51 |
| bjornar__ | smcginnis, no, I want to know all the config options/sections that are of any interest to the different services | 18:52 |
| smcginnis | bjornar__: Well, the docs will tell you what relevant config settings you need. | 18:53 |
| bjornar__ | smcginnis, so for example, [keystone_authtoken] .. is that needed by -backup or -volume ? | 18:53 |
| bjornar__ | I do not think so, but I cant say for sure | 18:53 |
| *** lpetrut has joined #openstack-cinder | 18:54 | |
| AJaeger | thanks, smcginnis ! | 18:55 |
| *** bswartz has joined #openstack-cinder | 18:55 | |
| sheel | bjornar__: may be you can follow up with architecture and guess upto some extent, like keystone authtok will be for api only which is part of dev docs | 18:57 |
| bjornar__ | smcginnis, and, is it only cinder-api that needs database access, or also -volume? .. what about -backup ? | 18:57 |
| sheel | bjornar__: i am sharing architecture doc with you | 18:58 |
| sheel | you will get some idea about that | 18:58 |
| bjornar__ | this one? http://docs.openstack.org/developer/cinder/devref/architecture.html | 18:59 |
| sheel | http://docs.openstack.org/developer/cinder/devref/architecture.html | 19:00 |
| sheel | bjornar__: ah yes | 19:00 |
| bjornar__ | yeah, that was great! | 19:00 |
| *** haomaiwang has quit IRC | 19:01 | |
| bjornar__ | Is this really the most information that is out there on these topics? | 19:01 |
| *** 92AAAEL3R has joined #openstack-cinder | 19:01 | |
| sheel | bjornar__: well you may go through openstack.org | 19:03 |
| sheel | bjornar__: a lot of documentation is present which will surely help you in getting answers to your query | 19:03 |
| bjornar__ | I think I have seen most | 19:03 |
| bjornar__ | So if you cant give me more help here, who can? | 19:04 |
| sheel | bjornar__: do refer http://docs.openstack.org/openstack-ops/openstack-ops-manual.pdf | 19:04 |
| sheel | bjornar__: I think i tried to help you most but still you can ask someone in group | 19:05 |
| Swanson | oooo... 275797 looks like it has finally kicked off! There is hope! | 19:05 |
| mtanino | Hi :), Can I get an attention for this bug fix? https://review.openstack.org/#/c/274204/ | 19:05 |
| *** permalac has joined #openstack-cinder | 19:05 | |
| sheel | bjornar__: simply you can float your query in group and see if someone have some more information ...there would be i think | 19:05 |
| bjornar__ | sheel, lets start with: does -backup and -volume access database directly? | 19:06 |
| *** delattec has joined #openstack-cinder | 19:06 | |
| bjornar__ | I mean if people in here does not know that, there are huge problems here! | 19:06 |
| *** sdague has quit IRC | 19:06 | |
| sheel | bjornar__: dont worry these are simple things | 19:07 |
| sheel | bjornar__: everyone knows and can share with you | 19:07 |
| *** delatte has quit IRC | 19:08 | |
| *** delatte has joined #openstack-cinder | 19:09 | |
| sheel | bjornar__: oh i missed your query | 19:10 |
| sheel | bjornar__: backup and volume should not access directly | 19:10 |
| *** jwcroppe has joined #openstack-cinder | 19:11 | |
| bjornar__ | "should not"? | 19:11 |
| *** delattec has quit IRC | 19:11 | |
| *** Lee1092 has quit IRC | 19:12 | |
| eharney | backup and volume services both talk to the database | 19:13 |
| bjornar__ | sheel, I feel this is a huge issue with documentation. It is not possible (afaik) to figure this out from docs | 19:13 |
| bjornar__ | eharney, so they connect directly to the database? | 19:13 |
| eharney | bjornar__: yes | 19:13 |
| bjornar__ | eharney, an this you are sure about? | 19:13 |
| bjornar__ | What would they do in the database? | 19:14 |
| *** melwitt_ is now known as melwitt | 19:14 | |
| guitarza1 | bjornar__: they perform lots of db queries... | 19:14 |
| guitarza1 | state updates for one easy example | 19:14 |
| bjornar__ | guitarza1, ok.. what do they ask for? | 19:15 |
| bjornar__ | I would believe they just did what they were told to do over mq.. but I dont know | 19:15 |
| *** jgregor has joined #openstack-cinder | 19:15 | |
| *** alkhodos has joined #openstack-cinder | 19:15 | |
| alkhodos | Hi guys! Don't want to be annoying, but can 1 more core review this please? https://review.openstack.org/#/c/271537 Hanging there for some time now :) | 19:16 |
| guitarza1 | bjornar__: of course, but most of those actions involve them updating the state of a volume | 19:16 |
| *** dimsum__ has quit IRC | 19:16 | |
| bjornar__ | guitarza1, so can you please point me to the architecture document where this is described in detail? | 19:16 |
| guitarza1 | bjornar__: I don't understand | 19:17 |
| guitarza1 | what architecture document? | 19:17 |
| bjornar__ | guitarza1, but do they update the state themselves, or send rpc message to api or wherever. | 19:17 |
| guitarza1 | why would they make an rpc call to the api to update the db? they just make the db update themselves | 19:17 |
| *** chhavi has quit IRC | 19:17 | |
| bjornar__ | guitarza1, The document where I can see the workflow of for example cinder-volume | 19:17 |
| bjornar__ | guitarza1, Because they have probably been given a job by rpc, then the answer to that job would probably be the new state.. and so on.. | 19:18 |
| guitarza1 | bjornar__: it's not that granular | 19:18 |
| guitarza1 | the api doesn't know "Now I need to update the volume to state X" | 19:18 |
| guitarza1 | the volume manager manages all the interactions with the backend drivers | 19:18 |
| bjornar__ | But do you say: "there is no documentation describing the architecture _at all_"? | 19:19 |
| smcginnis | If you want to see the architecture, you were given that. If you want to know the fine details of how things are done, look at the code. | 19:19 |
| guitarza1 | I definitely didn't say that | 19:20 |
| smcginnis | If you actually have a constructive question, please ask. | 19:20 |
| bjornar__ | The constructive question was: "where can I find a complete reference of the config options in use by the different daemons" | 19:20 |
| guitarza1 | bjornar__: maybe you could start here: http://docs.openstack.org/developer/nova/rpc.html | 19:20 |
| bjornar__ | ..that will tell me alot of what is going on. | 19:20 |
| smcginnis | You've been given the config options for backup. | 19:21 |
| bjornar__ | smcginnis, no, only those spesific to backup | 19:21 |
| smcginnis | You now seem to want to complain that that doesn't branch out into every other possible option that could be touched by it. | 19:21 |
| bjornar__ | smcginnis, I guess it needs rpc as well.. maby database.. what else? | 19:21 |
| guitarza1 | bjornar__: the document you're looking for does not exist | 19:21 |
| bjornar__ | guitarza1, dont you see that as a problem? | 19:21 |
| guitarza1 | nope | 19:21 |
| bjornar__ | ok. good answer | 19:22 |
| eharney | lots of people want better documentation, few people want to write it :) | 19:22 |
| guitarza1 | bjornar__: maybe you want this? http://docs.openstack.org/liberty/config-reference/content/ | 19:22 |
| bjornar__ | I really hope you atleast agree that it should be possible to figure out what options apply where. | 19:22 |
| *** ndipanov has joined #openstack-cinder | 19:24 | |
| openstackgerrit | Merged openstack/cinder: Huawei: Fix create volume with prefetch value error https://review.openstack.org/283975 | 19:25 |
| *** anshul has quit IRC | 19:26 | |
| kvidvans | smcginnis: appreciate if you could take a look at https://review.openstack.org/#/c/271462/ again...you had given a +2 but I had to rebase | 19:26 |
| bjornar__ | guitarza1, how could I from the code extract the various config options for example -backup tries to access? | 19:27 |
| *** cknight has quit IRC | 19:27 | |
| *** ntpttr has quit IRC | 19:28 | |
| guitarza1 | bjornar__: I'm not sure that's possible. The services load the entire config. Determining what options they use would be a pretty large task. | 19:29 |
| guitarza1 | you can certainly trace the code and find out if you wish though | 19:30 |
| *** cknight has joined #openstack-cinder | 19:30 | |
| kvidvans | thanks smcginnis! | 19:31 |
| kvidvans | any core willing to review and hopefully help merge https://review.openstack.org/#/c/271462/ ..would appreciate the help | 19:34 |
| *** porunov has joined #openstack-cinder | 19:38 | |
| *** martyturner has quit IRC | 19:41 | |
| hemna | kvidvans, do you have CI for the NFS driver ? I don't see it | 19:42 |
| kvidvans | hemna...yes..https://openstackci.oracle.com/zfssa_ci/refs-changes-62-271462-8-nfs/ you should also see it if you click toggle ci ..it is the 7th item from the bottom.. | 19:44 |
| kvidvans | we have a problem with the way we report the result...we over write the existing label. but the logs are still available in the CI results table | 19:44 |
| *** laughterwym has joined #openstack-cinder | 19:45 | |
| openstackgerrit | Merged openstack/cinder: EMC ScaleIO - fix bug in extend volume https://review.openstack.org/274391 | 19:45 |
| smcginnis | kvidvans: Are you working on splitting that out into two separate accounts? Or combining the results reporting so that doesn't happen anymore? | 19:46 |
| kvidvans | yes...we will split it into separate accounts... the two CI system for NFS and iSCSI are not in sync so combined reporting is not possible | 19:47 |
| kvidvans | smcginnis^^ | 19:47 |
| *** xyang has quit IRC | 19:48 | |
| *** erhudy has joined #openstack-cinder | 19:48 | |
| hemna | this is confusing | 19:48 |
| hemna | you should all of your CI reporting under the same acct | 19:49 |
| *** laughterwym has quit IRC | 19:49 | |
| kvidvans | hemna, ok..we will figure something out | 19:50 |
| *** xyang has joined #openstack-cinder | 19:50 | |
| *** jwcroppe has quit IRC | 19:54 | |
| *** ntpttr has joined #openstack-cinder | 19:56 | |
| kvidvans | hemna, ZFS NFS does report, its in the list of CI reports for the review | 19:58 |
| hemna | it's just not showing up in the list up top | 19:58 |
| kvidvans | right..but the CI is reporting...we will fix the reporting | 19:59 |
| kvidvans | we need to combine the results | 19:59 |
| *** sgotliv has joined #openstack-cinder | 19:59 | |
| *** 92AAAEL3R has quit IRC | 20:01 | |
| kvidvans | hemna, thanks! I will work on the reporting | 20:01 |
| *** haomaiwang has joined #openstack-cinder | 20:01 | |
| hemna | ok np | 20:01 |
| *** eharney has quit IRC | 20:02 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Get disabled services on init https://review.openstack.org/284976 | 20:03 |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake) https://review.openstack.org/275797 | 20:03 |
| smcginnis | jgriffith: Oh noes. Rebase? | 20:04 |
| jgriffith | smcginnis: yeah | 20:06 |
| jgriffith | no worries.. what could go wrong ;) | 20:06 |
| smcginnis | * queue total infra crash... | 20:07 |
| jgriffith | smcginnis: uhoh... you "said it" out loud | 20:07 |
| jgriffith | we're doomed I say... doomed | 20:07 |
| smcginnis | ;) | 20:07 |
| bswartz | Welcome to merge conflict hell! Your room will be right next to the river of failed rechecks... | 20:07 |
| jgriffith | bswartz: haha! Nice | 20:08 |
| smcginnis | bswartz: Hah | 20:08 |
| smcginnis | bswartz: We can check out any time we want, but we can never leave? | 20:08 |
| jgriffith | hmm... I'm not sure we've fixed tbarron 's wonderul log.warn tests | 20:08 |
| hemna | heh | 20:08 |
| jgriffith | rebase -i master.... run tests; failed | 20:08 |
| smcginnis | jgriffith: Same failures? | 20:08 |
| jgriffith | smcginnis: yeah | 20:08 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Stop deleting operation on busy volumes https://review.openstack.org/285527 | 20:09 |
| smcginnis | jgriffith: Pull latest from origin? | 20:09 |
| jgriffith | cinder.tests.unit.volume.drivers.netapp.dataontap.test_block_base.NetAppBlockStorageLibraryTestCase.test_get_reserved_percentage | 20:09 |
| smcginnis | That's the one. | 20:09 |
| jgriffith | smcginnis: lemme try that... surely it's fixed | 20:09 |
| smcginnis | We've had a few go through, so I would be surprised. | 20:09 |
| *** mdenny has quit IRC | 20:10 | |
| jgriffith | Awww.. and Who put an ssh call in the unit tests!!!! | 20:11 |
| jgriffith | WTF | 20:11 |
| jgriffith | "The Pretzels are making me THIRSTY!!!!" | 20:11 |
| bswartz | rofl | 20:12 |
| smcginnis | Wha! | 20:12 |
| smcginnis | ssh call to what? | 20:12 |
| jgriffith | smcginnis: hell if I know... but run unit tests and you'll notice a lovely "ssh_known_hosts" file created in your test dir | 20:13 |
| guitarza1 | hah, nice | 20:13 |
| *** sdague has joined #openstack-cinder | 20:13 | |
| smcginnis | tox -epy27 passes for me locally on master at least. | 20:14 |
| jgriffith | guitarza1: "nice" is NOT the word I used | 20:14 |
| tbarron | jgriffith: nice, is there an authorized_keys there for me as well? | 20:14 |
| guitarza1 | jgriffith: fair enough :) | 20:14 |
| jgriffith | tbarron: nope | 20:14 |
| jgriffith | tbarron: and the file is empty BTW | 20:14 |
| tbarron | lemme pull fresh and see what I see | 20:14 |
| smcginnis | jgriffith: That must be recent. | 20:14 |
| jgriffith | tbarron: please don't tell me you added a "assert ssh_known_hosts file exists" in a unit test to boost coverage numbers :) | 20:15 |
| smcginnis | Hah! | 20:15 |
| tbarron | i have no recollection of any such | 20:15 |
| jgriffith | LOL | 20:15 |
| tbarron | :-) | 20:15 |
| jgriffith | Senator Barron | 20:15 |
| tbarron | but I want to look at this thing | 20:15 |
| *** eharney has joined #openstack-cinder | 20:17 | |
| *** martyturner has joined #openstack-cinder | 20:19 | |
| jgriffith | smcginnis: pheww... ok, fresh clone/pull/rebase and we're good | 20:19 |
| smcginnis | Oh good | 20:19 |
| tbarron | no ssh_known_hosts added either? | 20:20 |
| openstackgerrit | John Griffith proposed openstack/cinder: Add ability to failback for replication V2.1 https://review.openstack.org/285007 | 20:20 |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake) https://review.openstack.org/275797 | 20:20 |
| smcginnis | tbarron: No, I get that on master | 20:20 |
| jgriffith | smcginnis: tbarron well sofab... | 20:20 |
| *** alejandrito has joined #openstack-cinder | 20:20 | |
| jgriffith | take a look at test_ssh_utils.py | 20:20 |
| *** mdenny has joined #openstack-cinder | 20:22 | |
| jgriffith | actually, those are probably ok | 20:22 |
| jgriffith | I'll find it... and when I do... look out!!! | 20:23 |
| jgriffith | :) | 20:23 |
| smcginnis | Blame only shows a recent online update from Eric there, so I would have been surprised. | 20:23 |
| tbarron | well I've been putting stuff in there so eric can get his commit numbers up, so he owes me | 20:24 |
| smcginnis | tbarron: Hah! | 20:24 |
| smcginnis | tbarron: It was all part of your master plan. | 20:24 |
| *** guitarza1 is now known as guitarzan | 20:26 | |
| tbarron | jgriffith: smcginnis: removing the file and running 'tox -epy27 -- --regex cinder.tests.unit.test_ssh_utils' does not produce a new file | 20:27 |
| tbarron | so that's not it | 20:27 |
| smcginnis | tbarron: Yeah, I think it's probably somewhere else that forgot to mock something. | 20:27 |
| tbarron | yeah, we're looking for what part of the code to mock now :-) | 20:27 |
| smcginnis | It's mocking us. | 20:28 |
| *** kfarr has joined #openstack-cinder | 20:28 | |
| smcginnis | I tested against the last commit on Feb 23 and it does not show up. | 20:29 |
| smcginnis | So something in the last couple of days. | 20:29 |
| smcginnis | Last one on the 24th and it does show up. | 20:32 |
| *** eharney_ has joined #openstack-cinder | 20:32 | |
| smcginnis | So it was something on the 24th. | 20:32 |
| *** eharney has quit IRC | 20:33 | |
| *** timcl has left #openstack-cinder | 20:33 | |
| *** eharney_ is now known as eharney | 20:33 | |
| *** AJaeger has left #openstack-cinder | 20:34 | |
| *** sgotliv has quit IRC | 20:37 | |
| openstackgerrit | Nate Potter proposed openstack/cinder: Stop deleting operation on busy volumes https://review.openstack.org/285527 | 20:40 |
| smcginnis | Introduced after "Fix HBAS iSCSI driver attachment" on the 24th. | 20:40 |
| tbarron | smcginnis: the great bisector! | 20:41 |
| smcginnis | tbarron: ;) It's one way to track it down. | 20:41 |
| tbarron | it's a great way | 20:41 |
| openstackgerrit | Alex O'Rourke proposed openstack/cinder: WIP - 3PAR: Update replication to v2.1 https://review.openstack.org/279307 | 20:41 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Stop deleting operation on busy volumes https://review.openstack.org/285527 | 20:42 |
| jgriffith | tbarron: yeah, that's what I meant "it's ok" :( | 20:42 |
| jgriffith | still on the hunt | 20:42 |
| smcginnis | Oh, microversion code went in after there. I can blame scottda . | 20:42 |
| openstackgerrit | Nate Potter proposed openstack/cinder: Stop deleting operation on busy volumes https://review.openstack.org/285527 | 20:44 |
| jgriffith | smcginnis: nice | 20:46 |
| *** dims has joined #openstack-cinder | 20:48 | |
| smcginnis | This did it: https://github.com/openstack/cinder/commit/8ed2d59395611ec2dc0ed78e8290af66bd02b1f2 | 20:49 |
| *** cknight has quit IRC | 20:49 | |
| tbarron | smcginnis: jgriffith: i see, griffith's outfit :-) | 20:50 |
| tbarron | smcginnis: jgriffith: actually, I +1-ed that | 20:51 |
| smcginnis | hemna: 192.9 Gib, 4 hours and 7 minutes. | 20:52 |
| jgriffith | smcginnis: tbarron "go figure" | 20:52 |
| tbarron | smcginnis: jgriffith: superficially, it *looks* like ssh stuff is getting mocked out in test_netapp.py | 20:53 |
| *** cknight has joined #openstack-cinder | 20:53 | |
| smcginnis | tbarron: Hah, I just finally figured out what you meant by Griffith's outfit! :) | 20:53 |
| * smcginnis is slow | 20:53 | |
| tbarron | smcginnis: maybe tired, but never slow | 20:54 |
| smcginnis | tbarron: Yeah, nothing is jumping out there as the culprit. | 20:54 |
| *** annasort has quit IRC | 20:54 | |
| tbarron | i'll play with it a bit | 20:54 |
| jgriffith | smcginnis: I suspect something in the external lib (zapi_client) | 20:54 |
| jgriffith | smcginnis: I hate this external lib shit.. have no idea what's going on | 20:54 |
| smcginnis | jgriffith: True | 20:55 |
| smcginnis | It's something in test_netapp. | 20:55 |
| jgriffith | smcginnis: or the netapp_api.SSHUtil (cuz cinder's isn't good enough).... or paramiko.SSHclient (cuz Netapps is better, but still not the best), or .... blah blah blah | 20:55 |
| jgriffith | :( | 20:55 |
| smcginnis | The only change there is the zapi_client bit. | 20:55 |
| tbarron | yeah | 20:56 |
| smcginnis | Repro'd with tox -e py27 -- -n cinder.tests.unit.test_netapp | 20:56 |
| *** dave-mccowan has quit IRC | 20:56 | |
| akerr | we don't have an external lib anymore | 20:56 |
| tbarron | yeah, I did that repro too | 20:56 |
| tbarron | akerr: ahah! | 20:56 |
| tbarron | so the mock fails to prevent ssh from really running. | 20:56 |
| jgriffith | akerr: external to Cinder is what I mean there :) | 20:56 |
| akerr | jgriffith: ok, I thought we beat that horse already :) | 20:57 |
| tbarron | oh, you *don't' have the external lib | 20:57 |
| tbarron | misunderstood | 20:57 |
| jgriffith | akerr: "It's not dead yet" :) | 20:57 |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Changes in ScaleIO configurations options. https://review.openstack.org/281541 | 20:58 |
| akerr | i can't even think off-hand what we'd use ssh for... | 20:59 |
| tbarron | smcginnis: yeah, i reproed it there too | 21:00 |
| akerr | all our management calls are http | 21:00 |
| jgriffith | akerr: it's all over in your code | 21:00 |
| tbarron | akerr: chuck had to do some ssh stuff to do some iscsi chap tricks | 21:00 |
| akerr | tbarron: oh ya... | 21:00 |
| jgriffith | akerr: https://github.com/openstack/cinder/commit/8ed2d59395611ec2dc0ed78e8290af66bd02b1f2#diff-5ac6c045fa4a4a6c5e083349a2352cd7R515 | 21:00 |
| akerr | tbarron: that pile... | 21:00 |
| tbarron | akerr: he regular zapis didn't have the secret stuff | 21:00 |
| jgriffith | akerr: hehe... | 21:00 |
| *** haomaiwang has quit IRC | 21:01 | |
| akerr | we blame cfouts then :) | 21:01 |
| tbarron | akerr: I am biting my tongue about l***al requriements | 21:01 |
| *** haomaiwang has joined #openstack-cinder | 21:01 | |
| tbarron | poor cfouts was forced to do that stuff | 21:01 |
| tbarron | but the question is why this mock isn't working | 21:01 |
| tbarron | it looks like it would on the face of it | 21:02 |
| *** akerr has quit IRC | 21:04 | |
| smcginnis | tbarron: Ah, it's too late. | 21:04 |
| smcginnis | The constructor for the driver's client includes a call to _init_ssh_client. | 21:04 |
| *** laughterwym has joined #openstack-cinder | 21:04 | |
| smcginnis | So by this point, the test already has the driver, then sets up the mock. | 21:04 |
| tbarron | smcginnis: that makes sense | 21:04 |
| smcginnis | So I think it's this: | 21:05 |
| *** xyang has quit IRC | 21:05 | |
| smcginnis | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/netapp/dataontap/client/client_base.py#L52 | 21:05 |
| *** merooney has quit IRC | 21:05 | |
| eharney | here's how to find the source of it: http://paste.openstack.org/show/488428/ | 21:09 |
| *** laughterwym has quit IRC | 21:09 | |
| *** kfarr has quit IRC | 21:10 | |
| smcginnis | eharney: Ooh, nice! | 21:10 |
| eharney | this should have an actual fix w/ mock, but we could also set a conf fixture for ssh_hosts_key_file to be /dev/null to prevent this in the future | 21:13 |
| eharney | (maybe that would just encourage bad tests, though) | 21:13 |
| smcginnis | eharney: True. But the fixture could be good to have. | 21:14 |
| *** delattec has joined #openstack-cinder | 21:15 | |
| *** alejandrito has quit IRC | 21:16 | |
| *** jungleboyj has quit IRC | 21:17 | |
| *** delatte has quit IRC | 21:17 | |
| cfouts | okay, I had it mocked out properly but when I switched to using SSH Pool I forgot to double check that. | 21:17 |
| cfouts | smcginnis, eharney: I can create the bug and get it fixed | 21:18 |
| *** JoseMello has quit IRC | 21:18 | |
| smcginnis | cfouts: Great, thanks! | 21:20 |
| eharney | sounds great | 21:20 |
| *** delattec has quit IRC | 21:20 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Change frozen error messages from _LE to _ https://review.openstack.org/284823 | 21:22 |
| *** delattec has joined #openstack-cinder | 21:22 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Add basic workflow of attach/detach to devref https://review.openstack.org/285471 | 21:24 |
| *** gouthamr_ has quit IRC | 21:26 | |
| *** Yogi1 has joined #openstack-cinder | 21:26 | |
| *** alkhodos has quit IRC | 21:28 | |
| *** garthb_ has joined #openstack-cinder | 21:28 | |
| cfouts | smcginnis, eharney: LOG.warn is breaking tests in stable/liberty on our CI. I should have a patch up soonish for https://bugs.launchpad.net/cinder/+bug/1550102 | 21:28 |
| openstack | Launchpad bug 1550102 in Cinder "Unit test test_get_reserved_percentage fails" [Critical,Fix released] - Assigned to Eric Harney (eharney) | 21:28 |
| smcginnis | cfouts: Cool, thanks. I didn't think about backports. | 21:28 |
| cfouts | can one of you add stable/liberty to that? | 21:28 |
| openstackgerrit | Jacob Gregor proposed openstack/cinder: Storwize SVC multiple management IPs https://review.openstack.org/284267 | 21:29 |
| smcginnis | cfouts: I will if I can remember how. ;) | 21:29 |
| eharney | done | 21:30 |
| smcginnis | eharney: Thanks | 21:30 |
| eharney | smcginnis: yeah no kidding, it took me 2 minutes to find the button | 21:30 |
| smcginnis | eharney: Ah, now I see it. | 21:30 |
| *** lprice1 has joined #openstack-cinder | 21:30 | |
| smcginnis | Link a related branch. | 21:30 |
| eharney | i think that does something very different :) | 21:30 |
| eharney | it's actually "target to series" | 21:30 |
| *** lprice has quit IRC | 21:30 | |
| *** garthb has quit IRC | 21:30 | |
| smcginnis | eharney: Oh, which one is it? | 21:30 |
| smcginnis | OK | 21:31 |
| *** IlyaG has quit IRC | 21:31 | |
| eharney | we can just cherry-pick the master patch straight from gerrit right? | 21:31 |
| smcginnis | eharney, cfouts: I would think so. It was pretty self contained. | 21:31 |
| *** IlyaG has joined #openstack-cinder | 21:31 | |
| bswartz | eharney: yes, iff it's merged in master | 21:32 |
| jgriffith | just curious... does anybody know if there's some reason people use test__ instead of test_ in their test names? IE two underscores? | 21:32 |
| smcginnis | Typo? | 21:33 |
| tbarron | stuck keyboard | 21:33 |
| jgriffith | dell, hp and netapp seem to all do it a fair bit | 21:33 |
| bswartz | because 2 is better than 1 | 21:33 |
| eharney | too much coffee, i assume | 21:33 |
| jgriffith | ok fair enough... I deserved all of those | 21:33 |
| jgriffith | :) | 21:33 |
| smcginnis | Or it's test_ in front of something like _do_something. | 21:33 |
| smcginnis | test__do_something? | 21:33 |
| bswartz | oh | 21:33 |
| bswartz | well it you're testing a private method, then it would make sense | 21:33 |
| tbarron | i always just copied dell | 21:33 |
| eharney | there's even test___eq__, neato | 21:33 |
| jgriffith | smcginnis: yeah... that's what it is... but why? | 21:34 |
| smcginnis | eharney: Really!? | 21:34 |
| openstackgerrit | Merged openstack/cinder: LeftHand: Updating minimum client version https://review.openstack.org/267780 | 21:34 |
| eharney | well, the method is called __eq__ :) | 21:34 |
| bswartz | becuause test_x() tests x() and test__x() tests _x() | 21:34 |
| cfouts | eharney: I cherry picked your patch and fixed some LOG.warn in test_nfs. those tests were deprecated and removed in M | 21:34 |
| jgriffith | bswartz: ok... I'm officially sorry I asked :) | 21:34 |
| smcginnis | jgriffith: I think it's probably good to keep test_(actual name). | 21:34 |
| *** apoorvad has quit IRC | 21:35 | |
| smcginnis | Then if there is a do_something() that internally calls _do_something() it's clear which is the target of the test. | 21:35 |
| smcginnis | Maybe? | 21:35 |
| jgriffith | smcginnis: yeah, the reason I was asking is I was grepping on some things and got "unexpected" results | 21:35 |
| jgriffith | smcginnis: sure.... I guess... I dunno | 21:35 |
| eharney | cfouts: what landed didn't really look much like what i submitted, so i probably don't know all the details | 21:35 |
| smcginnis | Yeah, meh | 21:35 |
| jgriffith | smcginnis: I always thought that's what private methods (_do_something) were for | 21:36 |
| jgriffith | but what do I know | 21:36 |
| jgriffith | I'm clearly not "hip" | 21:36 |
| tbarron | oh quit bragging :-) | 21:36 |
| tbarron | it's nice out, I'm going for a walk with my dog. Enough double underscores for now. | 21:37 |
| jgriffith | tbarron: nice!!! | 21:37 |
| jgriffith | tbarron: you've got the right idea! Enjoy! | 21:37 |
| smcginnis | NIce here too. Think I should probably get out before my last obligation of the week. | 21:38 |
| smcginnis | tbarron: Have a good one. | 21:38 |
| scottda | smcginnis: I broke stuff? | 21:39 |
| smcginnis | scottda: Just finding excuses to blame microversions for problems. :P | 21:39 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/283923 | 21:40 |
| *** adrianofr_ has quit IRC | 21:40 | |
| *** jgregor has quit IRC | 21:42 | |
| *** jamielennox is now known as jamielennox|away | 21:43 | |
| *** Yogi1 has quit IRC | 21:43 | |
| *** porunov has quit IRC | 21:45 | |
| scottda | Whew, ok. I'm in the mountains. No internet and poor cell phone coverage. So, I won't be fixing anything until Monday :) | 21:51 |
| *** apoorvad has joined #openstack-cinder | 21:52 | |
| smcginnis | scottda: Nice! Sounds fun. | 21:54 |
| hemna | scottda, +A | 21:54 |
| _alastor_ | I think my CI is hitting a race condition, but I'm not sure how to prevent it. | 21:55 |
| smcginnis | _alastor_: What's happening? | 21:55 |
| _alastor_ | If you take a look at this log: http://stkci.daterainc.com.s3-website-us-west-2.amazonaws.com/refs-changes-95-284395-2/console.log.txt | 21:55 |
| _alastor_ | I'm getting a MismatchError as the exception | 21:56 |
| *** scottda is now known as scottda_is_outta | 21:56 | |
| _alastor_ | testtools.matchers._impl.MismatchError: [u'cinder-scheduler', u'cinder-volume'] != [u'cinder-scheduler'] | 21:56 |
| *** mdenny has quit IRC | 21:57 | |
| smcginnis | That's a new one to me. | 21:57 |
| _alastor_ | It only happens sometimes (in the past 24 hours I've this pass a few times) | 21:57 |
| *** dustins has quit IRC | 21:59 | |
| _alastor_ | But if the cinder-volume service wasn't running, I'd get a lot more test failures than just this one. | 21:59 |
| *** salv-orlando has joined #openstack-cinder | 21:59 | |
| smcginnis | _alastor_: I noticed I could access the c-vol log when I poked around. | 22:00 |
| smcginnis | _alastor_: The name was there, but when I click on it I get an error. | 22:00 |
| _alastor_ | Yeah, the index is getting miscreated, there's a double slash in the url that should be a single slash | 22:00 |
| smcginnis | _alastor_: But yeah, it should have more than two failures if that's the case. So I think you're right. | 22:00 |
| *** haomaiwang has quit IRC | 22:01 | |
| _alastor_ | Here's the c-vol log: http://stkci.daterainc.com.s3-website-us-west-2.amazonaws.com/refs-changes-95-284395-2/logs/screen-c-vol.log.txt | 22:01 |
| *** eharney has quit IRC | 22:01 | |
| *** haomaiwang has joined #openstack-cinder | 22:01 | |
| *** salv-orl_ has quit IRC | 22:02 | |
| *** crose has quit IRC | 22:02 | |
| smcginnis | _alastor_: No, it does look like a c-vol failure: | 22:04 |
| smcginnis | 2016-02-26 12:58:33.129 ERROR cinder.volume.manager [req-a19dadf7-4753-4846-9656-83d5d9ab59cf None] [driver-VolumeManager] Failed to initialize driver | 22:04 |
| smcginnis | DateraAPIException: Request to Datera cluster returned bad status: 400 | Bad Request | 22:04 |
| _alastor_ | I think that might be the exception that happens before I re-initialize the driver with the code that's currently in review. | 22:05 |
| *** martyturner has quit IRC | 22:05 | |
| _alastor_ | It also has to fail a request to the backend before it logs in with the provided creds. | 22:05 |
| _alastor_ | So there's always at least one of those :) | 22:05 |
| smcginnis | OK, yeah, I see goodness after that. | 22:06 |
| *** baumann has left #openstack-cinder | 22:06 | |
| *** merooney has joined #openstack-cinder | 22:06 | |
| *** tpsilva has quit IRC | 22:07 | |
| *** sheel has quit IRC | 22:07 | |
| _alastor_ | The exception happens at 13:03, but in the c-vol logs I don't see anything out of the ordinary | 22:10 |
| *** lprice1 has quit IRC | 22:10 | |
| *** jungleboyj has joined #openstack-cinder | 22:11 | |
| smcginnis | _alastor_: Yeah, I didn't either. | 22:11 |
| smcginnis | _alastor_: Not sure what that could be. I never ran into that before. | 22:11 |
| smcginnis | _alastor_: You said it's only periodic? | 22:11 |
| *** knikolla has quit IRC | 22:11 | |
| _alastor_ | Yeah, the most recent run passed: http://stkci.daterainc.com.s3-website-us-west-2.amazonaws.com/refs-changes-56-284156-2/console.log.txt | 22:12 |
| _alastor_ | But I've seen that error on a few of the runs in the past 24 | 22:13 |
| smcginnis | _alastor_: Maybe ask in the channel next week and see if anyone else has seen it. | 22:13 |
| smcginnis | _alastor_: I have a feeling most are gone by now. | 22:13 |
| *** lprice has joined #openstack-cinder | 22:15 | |
| _alastor_ | smcginnis: btw, is the Datera CI reporting enough to allow review 284967 to make it through provided it passes the gate? | 22:17 |
| smcginnis | _alastor_: Yeah, as long as it runs against those changes to validate it passes tempest, that should be good. | 22:18 |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Changing PercentSynced to CopyState in isSynched https://review.openstack.org/246992 | 22:18 |
| smcginnis | _alastor_: Looks like it hit the gate issues we had over the last day. | 22:19 |
| _alastor_ | smcginnis: It's running them right now, I patch the CI with those changes for every patch request it gets | 22:19 |
| _alastor_ | smcginnis: Yeah, but I think it's catching up now | 22:19 |
| smcginnis | _alastor_: Just triggered a recheck to see if we get a +1 from Jenkins. | 22:19 |
| smcginnis | _alastor_: Assuming Jenkins and your CI are happy, and the code looks good, shouldn't be a problem to get it in at this point. | 22:19 |
| _alastor_ | smcginnis: cool | 22:19 |
| *** darosale has quit IRC | 22:21 | |
| *** merooney has quit IRC | 22:23 | |
| *** porrua has quit IRC | 22:30 | |
| *** merooney has joined #openstack-cinder | 22:30 | |
| *** edtubill has quit IRC | 22:33 | |
| *** lprice has quit IRC | 22:38 | |
| jungleboyj | smcginnis: Anything critical that needs more eyes right now? | 22:39 |
| smcginnis | jungleboyj: Maybe a gander through the open client patches? | 22:40 |
| smcginnis | jungleboyj: I think there were a few waiting a second set of eyes. | 22:40 |
| jungleboyj | Ok. | 22:40 |
| smcginnis | jungleboyj: Deadlines early next week. Yikes! | 22:40 |
| jungleboyj | Yeah. | 22:41 |
| jungleboyj | smcginnis: Time flies when you are having fun? | 22:41 |
| smcginnis | jungleboyj: Heh, something like that. ;) | 22:41 |
| jungleboyj | I wish someone would get russelbryant.net working again. | 22:42 |
| smcginnis | jungleboyj: I have one working | 22:42 |
| smcginnis | jungleboyj: All kinds of goodies: http://cinderstats-dellstorage.rhcloud.com/ | 22:42 |
| *** IlyaG has quit IRC | 22:43 | |
| jungleboyj | smcginnis: Oh, you run the reports too! | 22:43 |
| * jungleboyj wants to hug smcginnis | 22:43 | |
| smcginnis | jungleboyj: Yeah, I was playing around with some other things using some of the code from that. | 22:43 |
| smcginnis | jungleboyj: Figured I might as well throw it out somewhere. | 22:44 |
| smcginnis | Hah! | 22:44 |
| *** ndipanov has quit IRC | 22:44 | |
| * tbarron averts his eyes | 22:45 | |
| smcginnis | tbarron: Back from dog walking already? | 22:45 |
| tbarron | the dogs were better behaved | 22:45 |
| jungleboyj | smcginnis:I need those numbers to motivate me. | 22:45 |
| smcginnis | jungleboyj: I haven't run it in awhile, but this was interesting: http://cinderstats-dellstorage.rhcloud.com/cinder-reviewers-1095.txt | 22:45 |
| *** merooney has quit IRC | 22:46 | |
| *** marcusvrn_ has quit IRC | 22:47 | |
| jungleboyj | smcginnis: He he he. Still staying ahead of you. | 22:47 |
| jungleboyj | One day I will pass up jgriffith | 22:47 |
| *** zhonghua has joined #openstack-cinder | 22:48 | |
| smcginnis | jungleboyj: Could be getting close. I should run that one again. I'm sure I've beat you by now. :P | 22:50 |
| jungleboyj | :p | 22:50 |
| smcginnis | http://cinderstats-dellstorage.rhcloud.com/cinder-reviewers-365.txt | 22:50 |
| jgriffith | jungleboyj: huh? | 22:50 |
| jgriffith | Oh.. that! | 22:50 |
| openstackgerrit | Merged openstack/cinder: Fix NoneType error in service_get_all https://review.openstack.org/284500 | 22:51 |
| smcginnis | jgriffith: He's comparing size. | 22:51 |
| jgriffith | jungleboyj: I've been on vacation for 6 months... now's your chance!!! | 22:51 |
| * jgriffith provides a subdued but deep chuckle | 22:51 | |
| * jungleboyj is working on it. | 22:51 | |
| jgriffith | as coffee spurts out his nose | 22:51 |
| jungleboyj | jgriffith: Ouch! | 22:51 |
| *** zhonghua-lee has quit IRC | 22:51 | |
| smcginnis | My work here is done. | 22:51 |
| jgriffith | smcginnis: well played! | 22:52 |
| *** alyson_ has quit IRC | 22:52 | |
| jungleboyj | smcginnis: According to stackalytics for all time reviews I am behind John by about 500 reviews and you are behind me by about 600. | 22:54 |
| jungleboyj | I am the meanest of the three. | 22:54 |
| jungleboyj | ;-) | 22:54 |
| smcginnis | Well, we have at least that out there. I think you're goal for the weekend is to review all outstanding patches. :) | 22:54 |
| jungleboyj | smcginnis: Ha, I don't think my boys would appreciate that. | 22:55 |
| jungleboyj | Is this one we want in? https://review.openstack.org/#/c/264983/ | 22:55 |
| jungleboyj | The BP link doesn't work. | 22:56 |
| smcginnis | jungleboyj: Server side of that is still pending. | 22:56 |
| *** merooney has joined #openstack-cinder | 22:57 | |
| smcginnis | jungleboyj: But I think we can approve that and it will just hang until the support goes in to cinder. | 22:57 |
| smcginnis | jungleboyj: It was previously approved I see. | 22:58 |
| jungleboyj | smcginnis: Yeah, I just saw that. | 22:58 |
| jungleboyj | smcginnis: Weird, not sure why the link to the BP isn't working. There is one out there. | 22:59 |
| smcginnis | jungleboyj: Format right? | 22:59 |
| jungleboyj | Looks like it. | 23:00 |
| jungleboyj | smcginnis: Not worth holding it up for. | 23:00 |
| smcginnis | I've seen that some times where it just doesn't link right. I'm not sure why. | 23:00 |
| jungleboyj | Want me to +A? | 23:00 |
| *** haomaiwang has quit IRC | 23:01 | |
| jungleboyj | Or wait for the server side to go in? | 23:01 |
| *** haomaiwa_ has joined #openstack-cinder | 23:01 | |
| openstackgerrit | Gerald McBrearty proposed openstack/cinder: Revert "Remove Cisco FC Zone Manager Driver" https://review.openstack.org/285578 | 23:04 |
| *** IlyaG has joined #openstack-cinder | 23:04 | |
| jungleboyj | What is Gerald doing? | 23:04 |
| *** NightKhaos has quit IRC | 23:06 | |
| *** dims has quit IRC | 23:07 | |
| *** wanghao has quit IRC | 23:08 | |
| *** wanghao has joined #openstack-cinder | 23:09 | |
| *** xyang1 has quit IRC | 23:11 | |
| *** chris_morrell has quit IRC | 23:13 | |
| *** merooney has quit IRC | 23:13 | |
| jungleboyj | Oops, way to push to the wrong tree. | 23:13 |
| *** haplo37 has quit IRC | 23:24 | |
| aorourke | jgriffith, is there a strict deadline for the python-cinderclient? | 23:26 |
| *** IlyaG has quit IRC | 23:27 | |
| mtanino | jungleboyj: ping, | 23:30 |
| *** lpetrut has quit IRC | 23:31 | |
| mtanino | jungleboyj: If you have a chance now, could you revisit this quota fix? https://review.openstack.org/#/c/274204/ | 23:31 |
| smcginnis | aorourke: client deadline is next Tuesday, IIRC. | 23:31 |
| aorourke | smcginnis, cool. Just making sure it was not today or anything :) | 23:32 |
| *** dims has joined #openstack-cinder | 23:34 | |
| jungleboyj | mtanino: Sure, I need to drop off for now but can take a look later. | 23:34 |
| mtanino | jungleboyj: thank you, Review on Monday is fine for me :) | 23:34 |
| *** yangyapeng has joined #openstack-cinder | 23:35 | |
| *** erlon has quit IRC | 23:36 | |
| *** jungleboyj has quit IRC | 23:38 | |
| *** edmondsw has quit IRC | 23:39 | |
| *** haplo37 has joined #openstack-cinder | 23:40 | |
| *** erhudy has quit IRC | 23:40 | |
| *** ntpttr has quit IRC | 23:53 | |
| *** aorourke is now known as aorourke-afk | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!