*** salv-orlando has joined #openstack-cinder | 00:01 | |
*** chris_morrell has quit IRC | 00:04 | |
*** 7IZAAPZ3F has quit IRC | 00:04 | |
*** ducttape_ has joined #openstack-cinder | 00:05 | |
*** salv-orlando has quit IRC | 00:05 | |
*** ducttape_ has quit IRC | 00:06 | |
*** yangyapeng has quit IRC | 00:07 | |
*** ducttape_ has joined #openstack-cinder | 00:10 | |
*** kaisers has joined #openstack-cinder | 00:16 | |
*** kaisers2 has joined #openstack-cinder | 00:17 | |
*** kaisers4 has quit IRC | 00:17 | |
*** kaisers1 has quit IRC | 00:17 | |
*** lixiaoy1 has joined #openstack-cinder | 00:18 | |
*** ducttape_ has quit IRC | 00:23 | |
*** leeantho_ has quit IRC | 00:24 | |
*** lixiaoy1 has quit IRC | 00:28 | |
*** markvoelker has quit IRC | 00:30 | |
*** baojg has quit IRC | 00:32 | |
*** Apoorva has quit IRC | 00:34 | |
*** david-lyle_ has joined #openstack-cinder | 00:38 | |
*** laughterwym has joined #openstack-cinder | 00:38 | |
*** laughterwym has quit IRC | 00:39 | |
*** ducttape_ has joined #openstack-cinder | 00:39 | |
*** laughterwym has joined #openstack-cinder | 00:39 | |
*** zhangguoqing has joined #openstack-cinder | 00:40 | |
*** david-lyle has quit IRC | 00:41 | |
*** ducttape_ has quit IRC | 00:49 | |
*** bardia has quit IRC | 00:50 | |
*** bardia has joined #openstack-cinder | 00:51 | |
*** bardia has joined #openstack-cinder | 00:51 | |
*** gershon_ has joined #openstack-cinder | 00:52 | |
*** gershon has joined #openstack-cinder | 00:52 | |
*** GB21 has joined #openstack-cinder | 00:52 | |
*** mriedem is now known as mriedem_debate | 00:54 | |
*** aohuanxuan has joined #openstack-cinder | 01:00 | |
*** salv-orlando has joined #openstack-cinder | 01:02 | |
*** Apoorva has joined #openstack-cinder | 01:05 | |
*** salv-orlando has quit IRC | 01:06 | |
*** kaisers_ has quit IRC | 01:14 | |
*** EinstCrazy has joined #openstack-cinder | 01:15 | |
*** yangyapeng has joined #openstack-cinder | 01:19 | |
*** mtanin___ has joined #openstack-cinder | 01:23 | |
*** mtanino has quit IRC | 01:24 | |
*** diablo_rojo has joined #openstack-cinder | 01:24 | |
*** sdake has quit IRC | 01:28 | |
*** markvoelker has joined #openstack-cinder | 01:31 | |
*** aspiers has quit IRC | 01:34 | |
*** diablo_rojo has quit IRC | 01:34 | |
*** harlowja has quit IRC | 01:35 | |
*** sage_ has quit IRC | 01:36 | |
*** markvoelker has quit IRC | 01:36 | |
*** sage_ has joined #openstack-cinder | 01:37 | |
*** gershon_ has quit IRC | 01:37 | |
*** gershon has quit IRC | 01:37 | |
*** aspiers has joined #openstack-cinder | 01:39 | |
*** ducttape_ has joined #openstack-cinder | 01:50 | |
*** ducttape_ has quit IRC | 01:54 | |
*** bkopilov has quit IRC | 01:55 | |
*** lprice has joined #openstack-cinder | 01:58 | |
*** raunak has quit IRC | 01:59 | |
*** haplo37_ has quit IRC | 02:00 | |
*** haplo37_ has joined #openstack-cinder | 02:02 | |
*** bardia has quit IRC | 02:02 | |
*** salv-orlando has joined #openstack-cinder | 02:03 | |
*** ebalduf has joined #openstack-cinder | 02:07 | |
*** salv-orlando has quit IRC | 02:07 | |
*** aohuanxuan has quit IRC | 02:09 | |
*** ebalduf has quit IRC | 02:09 | |
*** rhefner has joined #openstack-cinder | 02:21 | |
*** aohuanxuan has joined #openstack-cinder | 02:22 | |
*** nicolasbock has quit IRC | 02:29 | |
*** GB21 has quit IRC | 02:37 | |
*** Lee1092 has joined #openstack-cinder | 02:41 | |
*** david-lyle_ has quit IRC | 02:48 | |
*** mtanin___ has quit IRC | 02:49 | |
*** david-lyle has joined #openstack-cinder | 02:49 | |
*** zengyingzhe__ has quit IRC | 02:50 | |
*** zengyingzhe__ has joined #openstack-cinder | 02:50 | |
*** ducttape_ has joined #openstack-cinder | 02:51 | |
*** GB21 has joined #openstack-cinder | 02:54 | |
*** sdake has joined #openstack-cinder | 02:55 | |
jgriffith | smcginnis: scottda so what's the rule/goal for new api modules? V3, V2, use contrib? All of the above? | 02:56 |
---|---|---|
*** ducttape_ has quit IRC | 02:56 | |
*** itzdilip has joined #openstack-cinder | 02:58 | |
openstackgerrit | TommyLike proposed openstack/cinder-specs: Add volume type filter to Get-Pools https://review.openstack.org/362747 | 02:58 |
*** mriedem_debate has quit IRC | 02:59 | |
*** adisky has joined #openstack-cinder | 03:00 | |
*** sudipto has joined #openstack-cinder | 03:03 | |
*** sudipto_ has joined #openstack-cinder | 03:04 | |
*** david-lyle has quit IRC | 03:04 | |
zhengyin | good morning | 03:04 |
*** Apoorva has quit IRC | 03:06 | |
*** bkopilov has joined #openstack-cinder | 03:09 | |
*** sdake has quit IRC | 03:15 | |
*** sdake has joined #openstack-cinder | 03:23 | |
*** lprice1 has joined #openstack-cinder | 03:31 | |
*** lprice has quit IRC | 03:31 | |
*** wanghao_ has joined #openstack-cinder | 03:32 | |
sudipto | zhengyin, good morning, may i ask you a question w.r.t LVM? | 03:32 |
*** markvoelker has joined #openstack-cinder | 03:32 | |
*** raunak has joined #openstack-cinder | 03:36 | |
*** markvoelker has quit IRC | 03:38 | |
*** sdake has quit IRC | 03:40 | |
*** sdake has joined #openstack-cinder | 03:41 | |
*** aswadr_ has joined #openstack-cinder | 03:45 | |
*** lkuchlan has joined #openstack-cinder | 03:47 | |
*** sdake has quit IRC | 03:47 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/cinder: TrivialFix: Remove default=None when set value in Config https://review.openstack.org/377194 | 03:50 |
*** karthikp- has quit IRC | 03:52 | |
*** GB21 has quit IRC | 03:53 | |
*** hemna_ has joined #openstack-cinder | 03:59 | |
*** hemna_ has quit IRC | 04:00 | |
*** rmcall_ has joined #openstack-cinder | 04:13 | |
*** rmcall has quit IRC | 04:14 | |
*** rmcall_ is now known as rmcall | 04:14 | |
*** sdake has joined #openstack-cinder | 04:15 | |
*** links has joined #openstack-cinder | 04:19 | |
*** sdake_ has joined #openstack-cinder | 04:22 | |
*** sdake has quit IRC | 04:24 | |
*** shausy has joined #openstack-cinder | 04:27 | |
*** coolsvap has quit IRC | 04:32 | |
*** GB21 has joined #openstack-cinder | 04:36 | |
*** sudipto_ has quit IRC | 04:39 | |
*** sudipto has quit IRC | 04:39 | |
*** sdake_ has quit IRC | 04:40 | |
*** sdake has joined #openstack-cinder | 04:43 | |
*** gouthamr has quit IRC | 04:44 | |
*** gouthamr has joined #openstack-cinder | 04:45 | |
*** gouthamr has quit IRC | 04:45 | |
*** psachin has joined #openstack-cinder | 04:45 | |
*** sdake_ has joined #openstack-cinder | 04:46 | |
*** sdake has quit IRC | 04:48 | |
*** bks has joined #openstack-cinder | 04:52 | |
*** ducttape_ has joined #openstack-cinder | 04:53 | |
*** salv-orlando has joined #openstack-cinder | 04:54 | |
*** ducttape_ has quit IRC | 04:57 | |
*** lpetrut has joined #openstack-cinder | 04:58 | |
*** sdake_ has quit IRC | 04:58 | |
*** kaisers_ has joined #openstack-cinder | 05:03 | |
*** pgadiya has joined #openstack-cinder | 05:05 | |
*** laughter_ has joined #openstack-cinder | 05:07 | |
*** pdeore has joined #openstack-cinder | 05:07 | |
*** pdeore has quit IRC | 05:08 | |
*** pdeore has joined #openstack-cinder | 05:08 | |
*** pdeore has quit IRC | 05:09 | |
*** pdeore has joined #openstack-cinder | 05:09 | |
*** laughterwym has quit IRC | 05:11 | |
*** pdeore has quit IRC | 05:12 | |
*** jgregor has joined #openstack-cinder | 05:12 | |
*** pdeore has joined #openstack-cinder | 05:13 | |
*** jgregor has quit IRC | 05:13 | |
*** pbandark has joined #openstack-cinder | 05:16 | |
*** sudipto has joined #openstack-cinder | 05:20 | |
*** sudipto_ has joined #openstack-cinder | 05:20 | |
*** snarwade has quit IRC | 05:21 | |
*** snarwade has joined #openstack-cinder | 05:21 | |
*** ducttape_ has joined #openstack-cinder | 05:25 | |
*** ducttape_ has quit IRC | 05:27 | |
*** ducttape_ has joined #openstack-cinder | 05:27 | |
*** ducttape_ has quit IRC | 05:27 | |
*** lpetrut has quit IRC | 05:29 | |
*** cknight has joined #openstack-cinder | 05:36 | |
openstackgerrit | Tony Xu proposed openstack/python-brick-cinderclient-ext: Add oslo.concurrency to requirements https://review.openstack.org/377247 | 05:38 |
*** Poornima has joined #openstack-cinder | 05:53 | |
*** rajinir has quit IRC | 05:55 | |
*** arecknag has joined #openstack-cinder | 06:02 | |
*** jay_ has joined #openstack-cinder | 06:03 | |
*** mjura has joined #openstack-cinder | 06:04 | |
*** nherciu has joined #openstack-cinder | 06:05 | |
*** mjura has quit IRC | 06:11 | |
*** mjura has joined #openstack-cinder | 06:12 | |
*** liverpooler has joined #openstack-cinder | 06:14 | |
*** liverpooler has quit IRC | 06:14 | |
*** liverpooler has joined #openstack-cinder | 06:14 | |
openstackgerrit | Anh Tran proposed openstack/python-cinderclient: Import module instead of object https://review.openstack.org/377263 | 06:19 |
*** laughter_ has quit IRC | 06:22 | |
*** bluex has quit IRC | 06:22 | |
*** laughterwym has joined #openstack-cinder | 06:22 | |
*** cknight has quit IRC | 06:23 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/os-brick: Docstrings should not start with a space https://review.openstack.org/377265 | 06:27 |
*** bluex has joined #openstack-cinder | 06:30 | |
*** raunak has quit IRC | 06:36 | |
*** pcaruana has joined #openstack-cinder | 06:45 | |
*** GB21 has quit IRC | 06:47 | |
*** rcernin has joined #openstack-cinder | 06:59 | |
*** salv-orl_ has joined #openstack-cinder | 07:01 | |
*** salv-orlando has quit IRC | 07:04 | |
*** salv-orl_ has quit IRC | 07:05 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Zanata https://review.openstack.org/377283 | 07:07 |
*** GB21 has joined #openstack-cinder | 07:09 | |
*** ducttape_ has joined #openstack-cinder | 07:10 | |
*** GB21 has quit IRC | 07:13 | |
*** GB21 has joined #openstack-cinder | 07:13 | |
*** ducttape_ has quit IRC | 07:15 | |
*** GB21 has quit IRC | 07:15 | |
*** GB21 has joined #openstack-cinder | 07:15 | |
*** nkrinner_afk is now known as nkrinner | 07:20 | |
*** alonma has joined #openstack-cinder | 07:24 | |
*** xek has joined #openstack-cinder | 07:25 | |
*** mjura has quit IRC | 07:34 | |
*** mjura has joined #openstack-cinder | 07:35 | |
*** hoonetorg has quit IRC | 07:42 | |
*** anteaya has quit IRC | 07:48 | |
*** anteaya has joined #openstack-cinder | 07:49 | |
*** jordanP has joined #openstack-cinder | 07:50 | |
*** hoonetorg has joined #openstack-cinder | 07:59 | |
*** e0ne has joined #openstack-cinder | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-cinder | 08:00 | |
*** e0ne has quit IRC | 08:01 | |
openstackgerrit | xianming.mao proposed openstack/cinder: add launchpad url in setup.cfg https://review.openstack.org/366686 | 08:11 |
*** ducttape_ has joined #openstack-cinder | 08:12 | |
*** ducttape_ has quit IRC | 08:17 | |
*** jay_ has quit IRC | 08:18 | |
*** laughterwym has quit IRC | 08:27 | |
*** mdovgal has joined #openstack-cinder | 08:29 | |
*** e0ne has joined #openstack-cinder | 08:30 | |
*** Digvijay has joined #openstack-cinder | 08:43 | |
*** bhagyashri has joined #openstack-cinder | 08:44 | |
*** lpetrut has joined #openstack-cinder | 08:46 | |
*** mjura has quit IRC | 08:49 | |
*** hoonetorg has quit IRC | 08:51 | |
*** GB21 has quit IRC | 08:57 | |
*** hoonetorg has joined #openstack-cinder | 09:03 | |
*** GB21 has joined #openstack-cinder | 09:10 | |
*** alonma has quit IRC | 09:12 | |
*** ducttape_ has joined #openstack-cinder | 09:12 | |
*** alonma has joined #openstack-cinder | 09:13 | |
*** namnh has joined #openstack-cinder | 09:13 | |
namnh | Hi everyone. Do you know how to setup Devstack in oder that Cinder can use NFS backend. :) Thanks | 09:15 |
*** obutenko_ has joined #openstack-cinder | 09:16 | |
openstackgerrit | Anh Tran proposed openstack/python-cinderclient: TrivialFix: Removed redundant 'the' https://review.openstack.org/377389 | 09:16 |
*** alonma has quit IRC | 09:17 | |
*** ducttape_ has quit IRC | 09:18 | |
openstackgerrit | Anh Tran proposed openstack/python-cinderclient: TrivialFix: Removed redundant 'the' https://review.openstack.org/377389 | 09:20 |
*** alonma has joined #openstack-cinder | 09:20 | |
e0ne | namnh: hi. you have to setup NFS server manually and configure devstack to use NFS driver | 09:20 |
namnh | e0ne, thanks for your repley. Yes, correct :) Would you mind giving me some comments. | 09:22 |
namnh | e0ne, I tried to do some ways but it was not correct. :( | 09:23 |
*** alonma has quit IRC | 09:25 | |
*** e0ne has quit IRC | 09:27 | |
*** e0ne has joined #openstack-cinder | 09:27 | |
*** mvk has quit IRC | 09:27 | |
*** GB21 has quit IRC | 09:28 | |
*** namnh has quit IRC | 09:28 | |
*** namnh has joined #openstack-cinder | 09:29 | |
e0ne | namnh: do you have any errors? | 09:29 |
namnh | e0ne: I cannot assign cinder-volumn using NFS, it means that when I finished installing Cinder by Devstack, the cinder.conf still setup using LVM | 09:33 |
*** laughterwym has joined #openstack-cinder | 09:35 | |
*** laughterwym has quit IRC | 09:39 | |
e0ne | namnh: did you add CINDER_ENABLED_BACKENDS=nfs:nfs to your devstack config? | 09:41 |
*** GB21 has joined #openstack-cinder | 09:41 | |
*** namnh has quit IRC | 09:42 | |
*** itzdilip has quit IRC | 09:43 | |
*** akapil has joined #openstack-cinder | 09:45 | |
*** akapil has quit IRC | 09:50 | |
*** jay_ has joined #openstack-cinder | 09:51 | |
*** winston-d has quit IRC | 09:53 | |
*** yangyapeng has quit IRC | 09:53 | |
*** yangyapeng has joined #openstack-cinder | 09:53 | |
*** rhefner has quit IRC | 09:54 | |
*** haplo37_ has quit IRC | 09:56 | |
*** Dinesh_Bhor has quit IRC | 09:57 | |
*** jmccrory has quit IRC | 09:57 | |
*** cebruns__ has joined #openstack-cinder | 09:57 | |
*** cebruns_ has quit IRC | 09:57 | |
*** aohuanxuan has quit IRC | 09:58 | |
*** mvk has joined #openstack-cinder | 09:58 | |
*** haplo37_ has joined #openstack-cinder | 09:59 | |
*** jmccrory has joined #openstack-cinder | 10:00 | |
*** melwitt has quit IRC | 10:01 | |
*** melwitt has joined #openstack-cinder | 10:01 | |
*** melwitt is now known as Guest3203 | 10:02 | |
*** EinstCrazy has quit IRC | 10:03 | |
*** EinstCrazy has joined #openstack-cinder | 10:04 | |
*** yangyapeng has quit IRC | 10:05 | |
*** sdague has joined #openstack-cinder | 10:08 | |
*** EinstCrazy has quit IRC | 10:08 | |
*** alonma has joined #openstack-cinder | 10:11 | |
*** akapil has joined #openstack-cinder | 10:11 | |
*** aohuanxuan has joined #openstack-cinder | 10:14 | |
*** Lee1092 has quit IRC | 10:14 | |
*** ducttape_ has joined #openstack-cinder | 10:15 | |
*** ducttape_ has quit IRC | 10:19 | |
*** sdake has joined #openstack-cinder | 10:27 | |
*** portdirect has quit IRC | 10:39 | |
*** salv-orlando has joined #openstack-cinder | 10:39 | |
*** scottda has quit IRC | 10:40 | |
*** alonma has quit IRC | 10:40 | |
*** gcb has joined #openstack-cinder | 10:46 | |
*** akapil has quit IRC | 10:47 | |
*** akapil has joined #openstack-cinder | 10:48 | |
*** alonma has joined #openstack-cinder | 10:48 | |
*** nicolasbock has joined #openstack-cinder | 10:50 | |
*** alonma has quit IRC | 10:50 | |
*** alonma has joined #openstack-cinder | 10:51 | |
*** nkrinner has quit IRC | 10:54 | |
*** pdeore has quit IRC | 11:01 | |
*** sudipto has quit IRC | 11:06 | |
*** sudipto_ has quit IRC | 11:06 | |
*** nkrinner has joined #openstack-cinder | 11:07 | |
*** sdake has quit IRC | 11:12 | |
*** ducttape_ has joined #openstack-cinder | 11:15 | |
*** nherciu_ has joined #openstack-cinder | 11:17 | |
*** yangyapeng has joined #openstack-cinder | 11:17 | |
*** nherciu has quit IRC | 11:19 | |
*** ducttape_ has quit IRC | 11:20 | |
*** salv-orlando has quit IRC | 11:27 | |
johnthetubaguy | jgriffith: hemna: ildikov: https://review.openstack.org/373203 is updated after the meeting yesterday | 11:28 |
johnthetubaguy | jgriffith: hemna: ildikov: feels like we need a call back to say os-brick has finished attaching things, so other volumes can re-use that host connection, or something like that, but I am not sure | 11:29 |
openstackgerrit | Merged openstack/cinder: Imported Translations from Zanata https://review.openstack.org/377283 | 11:32 |
*** sudipto has joined #openstack-cinder | 11:38 | |
*** sudipto_ has joined #openstack-cinder | 11:39 | |
*** salv-orlando has joined #openstack-cinder | 11:40 | |
*** Poornima has quit IRC | 11:42 | |
*** pgadiya has quit IRC | 11:43 | |
*** akapil has quit IRC | 11:45 | |
*** narayrak has joined #openstack-cinder | 11:49 | |
*** bkopilov has quit IRC | 11:50 | |
*** wanghao_ has quit IRC | 11:50 | |
*** breitz has quit IRC | 11:56 | |
*** jgregor has joined #openstack-cinder | 11:56 | |
*** pgadiya has joined #openstack-cinder | 11:57 | |
*** sandanar has joined #openstack-cinder | 12:03 | |
openstackgerrit | Merged openstack/python-cinderclient: TrivialFix: Removed redundant 'the' https://review.openstack.org/377389 | 12:04 |
*** sandanar_ has joined #openstack-cinder | 12:04 | |
*** sandanar has quit IRC | 12:05 | |
*** Digvijay has quit IRC | 12:06 | |
*** kumarb has joined #openstack-cinder | 12:06 | |
*** bks has quit IRC | 12:06 | |
*** yangyapeng has quit IRC | 12:10 | |
*** jseiler__ has quit IRC | 12:10 | |
*** rhe00 has joined #openstack-cinder | 12:14 | |
*** rhedlind has quit IRC | 12:15 | |
*** yangyapeng has joined #openstack-cinder | 12:16 | |
*** gouthamr has joined #openstack-cinder | 12:16 | |
*** ducttape_ has joined #openstack-cinder | 12:16 | |
*** sudipto_ has quit IRC | 12:16 | |
*** sudipto has quit IRC | 12:16 | |
*** sudipto has joined #openstack-cinder | 12:17 | |
*** tpsilva has joined #openstack-cinder | 12:18 | |
openstackgerrit | JohnnyChou proposed openstack/cinder: Add support for Infortrend GS Series products https://review.openstack.org/375274 | 12:20 |
*** ducttape_ has quit IRC | 12:20 | |
*** jungleboyj has joined #openstack-cinder | 12:24 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add cleanable base object and cleanup request VO https://review.openstack.org/303020 | 12:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Make c-vol use workers table for cleanup https://review.openstack.org/303021 | 12:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: [WIP] Add remaining operations to cluster https://review.openstack.org/355968 | 12:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: [WIP] Support A/A on Scheduler operations https://review.openstack.org/344226 | 12:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: [PoC][Don't review] Testing delay https://review.openstack.org/353069 | 12:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Support A/A in attach/detach operations https://review.openstack.org/318573 | 12:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: [WIP] Allow triggering cleanup from API https://review.openstack.org/363010 | 12:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Support A/A in delete actions and get_capabilities https://review.openstack.org/344225 | 12:27 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: [WIP] Cosmetic changes to scheduler https://review.openstack.org/346041 | 12:27 |
*** sdake has joined #openstack-cinder | 12:28 | |
*** aohuanxuan has quit IRC | 12:29 | |
*** markvoelker has joined #openstack-cinder | 12:29 | |
*** edmondsw has joined #openstack-cinder | 12:30 | |
*** portdirect has joined #openstack-cinder | 12:33 | |
*** jgregor has quit IRC | 12:34 | |
openstackgerrit | JohnnyChou proposed openstack/cinder: Add support for Infortrend GS Series products https://review.openstack.org/377665 | 12:34 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/python-cinderclient: set_metadata throws AttributeError: id https://review.openstack.org/308475 | 12:35 |
*** salv-orlando has quit IRC | 12:45 | |
*** jungleboyj has quit IRC | 12:50 | |
*** kumarb has quit IRC | 12:50 | |
*** porrua has joined #openstack-cinder | 12:56 | |
*** david-lyle has joined #openstack-cinder | 12:56 | |
*** GB21 has quit IRC | 12:57 | |
*** ducttape_ has joined #openstack-cinder | 12:58 | |
*** rlrossit has joined #openstack-cinder | 13:03 | |
openstackgerrit | David Sariel proposed openstack/cinder: Updated from global requirements https://review.openstack.org/377682 | 13:06 |
*** vnogin has joined #openstack-cinder | 13:08 | |
*** jay_ has quit IRC | 13:09 | |
*** laughterwym has joined #openstack-cinder | 13:09 | |
*** rmcall has quit IRC | 13:10 | |
*** pgadiya has quit IRC | 13:11 | |
*** salv-orlando has joined #openstack-cinder | 13:12 | |
*** alonma has quit IRC | 13:14 | |
*** dustins has joined #openstack-cinder | 13:15 | |
*** mriedem has joined #openstack-cinder | 13:19 | |
*** alonma has joined #openstack-cinder | 13:20 | |
*** tongli has joined #openstack-cinder | 13:23 | |
*** merooney has joined #openstack-cinder | 13:29 | |
openstackgerrit | Eric Harney proposed openstack/cinder: Remove GlusterFS volume driver https://review.openstack.org/377028 | 13:33 |
*** akapil has joined #openstack-cinder | 13:34 | |
*** rooneym has joined #openstack-cinder | 13:40 | |
*** pdeore has joined #openstack-cinder | 13:40 | |
*** scottda has joined #openstack-cinder | 13:40 | |
*** shyama has joined #openstack-cinder | 13:40 | |
*** salv-orl_ has joined #openstack-cinder | 13:42 | |
*** bkopilov has joined #openstack-cinder | 13:43 | |
*** rlrossit has quit IRC | 13:45 | |
*** mugsie__ is now known as mugsie | 13:45 | |
*** salv-orlando has quit IRC | 13:46 | |
*** laughterwym has quit IRC | 13:47 | |
*** eharney has joined #openstack-cinder | 13:48 | |
*** shausy has quit IRC | 13:50 | |
*** rlrossit_ has joined #openstack-cinder | 13:51 | |
*** lkuchlan has left #openstack-cinder | 13:51 | |
*** laughterwym has joined #openstack-cinder | 13:52 | |
*** karthikp_ has joined #openstack-cinder | 13:53 | |
*** jordanP has quit IRC | 13:54 | |
*** arecknag has quit IRC | 13:56 | |
*** laughterwym has quit IRC | 13:56 | |
*** rajinir has joined #openstack-cinder | 13:56 | |
*** jgregor has joined #openstack-cinder | 13:59 | |
*** eharney has quit IRC | 14:00 | |
openstackgerrit | Jiong Liu proposed openstack/cinder: Remove default=None when set value in Config https://review.openstack.org/377715 | 14:02 |
*** mtanino has joined #openstack-cinder | 14:02 | |
*** laughterwym has joined #openstack-cinder | 14:03 | |
*** Julien-zte has joined #openstack-cinder | 14:11 | |
scottda | jgriffith: We wanted to move old and new api modules to core, if they belong there. So new core features should be in v3. New features that aren't implemented by everyone (so, traditional extensions) should go in contrib. | 14:13 |
*** alonma has quit IRC | 14:14 | |
ildikov | johnthetubaguy: thank for the update! | 14:14 |
johnthetubaguy | ildikov: no worries, hopefully that helps | 14:15 |
johnthetubaguy | ildikov: hit a question about needing an extra API call, but added the TODO in context in the spec | 14:15 |
johnthetubaguy | jgriffith: curious on your take on the updates spec | 14:15 |
ildikov | johnthetubaguy: yeap, I've just checked your earlier ping | 14:16 |
ildikov | johnthetubaguy: I'll check that and if we are unsure about that part we can bring this up on the next meeting | 14:17 |
*** eharney has joined #openstack-cinder | 14:18 | |
*** jordanP has joined #openstack-cinder | 14:18 | |
*** liverpooler has quit IRC | 14:18 | |
*** sdake has quit IRC | 14:24 | |
*** sudipto_ has joined #openstack-cinder | 14:24 | |
*** GB21 has joined #openstack-cinder | 14:26 | |
smcginnis | scottda: That was my understanding of the past conversations as well. | 14:30 |
*** diablo_rojo has joined #openstack-cinder | 14:32 | |
*** jungleboyj has joined #openstack-cinder | 14:33 | |
*** zhangguoqing has quit IRC | 14:34 | |
*** sdake has joined #openstack-cinder | 14:37 | |
*** ducttape_ has quit IRC | 14:40 | |
*** xinli has joined #openstack-cinder | 14:40 | |
erlon | scottda: https://gist.github.com/anonymous/6430e858967c9d97d460515815d4d56c | 14:42 |
erlon | scottda: migration test script result | 14:42 |
scottda | @erlon Are those NFS failures for ceph and gluster to be expected | 14:43 |
scottda | ? | 14:43 |
erlon | scottda: no, don't know why are failing, haven't investigated | 14:44 |
erlon | scottda: but the tests make easy to find out problems like this | 14:44 |
*** shyama has quit IRC | 14:44 | |
scottda | erlon: Cool. | 14:44 |
erlon | scottda: I only added 3 backends, but there's 6 | 14:45 |
*** gershon_ has joined #openstack-cinder | 14:45 | |
*** gershon has joined #openstack-cinder | 14:45 | |
erlon | scottda: I think we will have to choose some of then, or find a way to select the backends | 14:45 |
scottda | erlon: Yes, it would be nice if the script read a conf file or something, so the backends could be easily changed. | 14:46 |
erlon | because 6x6 will take, 80 minutes to run | 14:46 |
*** GB21 has quit IRC | 14:47 | |
erlon | scottda: I mean select the backends based on the code | 14:47 |
erlon | scottda: for example, changes in the ceph driver will run all ceph tests | 14:48 |
scottda | erlon: OK. We should also get some feedback from infra on this, based on how long it takes to run, etc. | 14:53 |
erlon | scottda: tough there are changes that can affect migration that can't be related with any specific driver | 14:53 |
erlon | scottda: ok | 14:53 |
*** cknight has joined #openstack-cinder | 14:53 | |
*** adisky has quit IRC | 14:53 | |
jgriffith | scottda: smcginnis I think we need to talk through what we're doing here again | 14:54 |
jgriffith | scottda: smcginnis I filed this bug last night https://bugs.launchpad.net/cinder/+bug/1627921 | 14:55 |
openstack | Launchpad bug 1627921 in Cinder "clean up API versions" [Undecided,New] | 14:55 |
*** cknight has quit IRC | 14:56 | |
jgriffith | scottda: the duplicated frameworks and managers inherriting from each other in multiple places is kind of wasteful and confusing | 14:56 |
jgriffith | scottda: and I'm not sure I agree that anything new has to go under V3, because you create a problem with consumers and how they pick things up | 14:56 |
jgriffith | scottda: in particular we've set things up as an all or nothing (you're V3, or you're V2) | 14:57 |
smcginnis | jgriffith: Can't remember entirely now, but my hope was v3 could just inherit from v2 since they are initially the same. | 14:57 |
smcginnis | jgriffith: Then override it as uniqueness is introduced. | 14:57 |
scottda | jgriffith: Sorry, in a meeting ATM..can discuss later.. | 14:57 |
jgriffith | scottda: and the redirect back to V2 trick is neat, but I'm not sure that is a great end user experience | 14:57 |
jgriffith | smcginnis: yeah, that's in fact what's implemented and makes sense.... until one tries to actually do something with the code or add a new module :( | 14:58 |
smcginnis | jgriffith: Any change should just go in v3 for the most part. | 14:59 |
jgriffith | smcginnis: I guess my point was I just *really* think that Nova's direction on this is vastly superior (and I don't say that about many things) | 14:59 |
smcginnis | jgriffith: Guess I need to take a closer look at how they've done things. | 15:00 |
jgriffith | smcginnis: sure, but then I'm maintaining a V1, V2 and V3 set of API modules. | 15:00 |
jgriffith | smcginnis: and we still have all the contrib stuff hanging out there :( | 15:00 |
smcginnis | Yeah, hoping most of that can go away and just be absorbed into the normal API. | 15:00 |
jgriffith | smcginnis: maybe I'm crazy; but it seems like a more straight forward approach | 15:00 |
jgriffith | smcginnis: less code duplication, and rather easy to find things and understand what's going on | 15:01 |
smcginnis | Looks good on paper. | 15:01 |
smcginnis | :) | 15:01 |
jgriffith | smcginnis: I am not a fan of being *clever* for the sake of being clever :) | 15:01 |
jgriffith | smcginnis: hehe... or an LCD screen :) | 15:01 |
jgriffith | smcginnis: I don't want to cause trouble on this, but I think we might be creating a mess for ourselves | 15:02 |
e0ne | jgriffith, smcginnis: just FYI, we've got the same problem with cinderclietn | 15:02 |
smcginnis | jgriffith: Well, part of the intent was to reduce code duplication and hopefully make it simpler. But if that's not turning out to be the case then I'm all for trying another approach. | 15:03 |
jgriffith | e0ne: yeah, that's where I started on this last night :( | 15:03 |
jgriffith | e0ne: My dog had to cover his ears because I was using very offensive language :) | 15:03 |
e0ne | jgriffith, smcginnis: I'm going to refactor cinderclient side once, I'll finish cinderclient functional tests | 15:03 |
jgriffith | smcginnis: I think it's increased both of those things | 15:04 |
e0ne | :) | 15:04 |
smcginnis | e0ne: Awesome! | 15:04 |
jgriffith | smcginnis: we now have a xxxManager in each directory V1, V2 and V3 | 15:04 |
e0ne | jgriffith, smcginnis: I could help with cinder side too if needed | 15:04 |
e0ne | jgriffith, smcginnis: for note: almost the same managers:( | 15:04 |
jgriffith | smcginnis: back when Nova was moving away from all of those I didn't understand the direction, but now looking at the end result it makes a lot of sense to me | 15:05 |
*** mriedem is now known as mriedem_meeting | 15:05 | |
smcginnis | Any work on simplifying the code would be very welcome. :) | 15:05 |
jgriffith | smcginnis: I started messing with it last night briefly and I don't think it's that difficult to do | 15:05 |
jgriffith | smcginnis: there is a LOT of detail/grunt work though which kinda sucks | 15:06 |
e0ne | I not a fun of OOP stuff, but in this case it's really helpful | 15:06 |
jgriffith | e0ne: OOP? | 15:06 |
*** pcaruana has quit IRC | 15:06 | |
e0ne | object oriented programming | 15:06 |
jgriffith | e0ne: oh.. haah | 15:06 |
jgriffith | e0ne: well I think that's what's wrong with our approach, too much OOP hackery :) | 15:06 |
*** rcernin has quit IRC | 15:07 | |
e0ne | jgriffith: :) | 15:07 |
*** yangyape_ has joined #openstack-cinder | 15:07 | |
jgriffith | anyway... I need to get my patches updated so that everything works and post them | 15:07 |
*** yangyapeng has quit IRC | 15:07 | |
jgriffith | just wanted to raise this quickly | 15:07 |
jgriffith | and I guess I'll have to figure out how to add these things to V3 and get Nova to talk to V3 :( | 15:08 |
*** pdeore has quit IRC | 15:11 | |
*** alonma has joined #openstack-cinder | 15:15 | |
sudipto_ | e0ne, hi, can i ask you questions w.r.t os-brick? | 15:16 |
e0ne | sudipto_: hi, sure | 15:16 |
*** jgregor has quit IRC | 15:16 | |
*** jgregor has joined #openstack-cinder | 15:17 | |
*** haplo37__ has joined #openstack-cinder | 15:17 | |
sudipto_ | e0ne, per this code, https://github.com/openstack/os-brick/blob/5dfa56d8f40799b95c9e6d18c8fc42c263b3f6c4/os_brick/initiator/linuxscsi.py#L241 - it states that the multi path device file names can have various patterns, but seems to only address one such pattern. I thought of pushing a patch to include the other patterns, but also wanted to understand - why we have not done that already? | 15:17 |
*** openstackgerrit has quit IRC | 15:18 | |
sudipto_ | On my RHEL host, i see that if the user friendly names are turned off - the device names are scsi-**** - however that doesn't get detected because we don't check for it in the above code. | 15:18 |
*** openstackgerrit has joined #openstack-cinder | 15:19 | |
*** jgregor1 has joined #openstack-cinder | 15:19 | |
*** alonma has quit IRC | 15:19 | |
*** crose has joined #openstack-cinder | 15:20 | |
*** jgregor has quit IRC | 15:21 | |
sudipto_ | I wrote a bug for this here: https://bugs.launchpad.net/os-brick/+bug/1628163 and plan to propose a patch to fix it. But wanted to understand from you on whether it's a valid one to do. | 15:23 |
openstack | Launchpad bug 1628163 in os-brick "OS brick does not have a check for all types of multipath device paths" [Undecided,New] - Assigned to Sudipta Biswas (sbiswas7) | 15:23 |
*** arch-nemesis has joined #openstack-cinder | 15:24 | |
scottda | jgriffith: Sorry, I'm back now. Looks like you all have solved the worlds problems already... | 15:25 |
*** rlrossit_ has quit IRC | 15:26 | |
openstackgerrit | JohnnyChou proposed openstack/cinder: Add support for Infortrend GS Series products https://review.openstack.org/377665 | 15:29 |
mtanino | e0ne: Hi | 15:31 |
mtanino | e0ne: I've tried your local-attach feature recently, and it works fine! it's nice | 15:32 |
*** diablo_rojo has quit IRC | 15:33 | |
*** jgregor1 has quit IRC | 15:34 | |
*** jgregor has joined #openstack-cinder | 15:36 | |
e0ne | sudipto_: IMO, it's because multipath feature is not widely used and tested :( | 15:38 |
*** hemna_ has joined #openstack-cinder | 15:38 | |
e0ne | hemna: ^^ | 15:39 |
*** hemna_ has quit IRC | 15:39 | |
e0ne | mtanino: hi! great news, thanks! | 15:39 |
mtanino | e0ne: I have a question about that. Do you have a plan to support FC storage for local-attach? | 15:39 |
*** psachin has quit IRC | 15:39 | |
hemna | hey | 15:39 |
sudipto_ | e0ne, ah ok - just curious a most frequently used feature with LVM would be? Or is it that LVM itself is not so widely used? (Consider me a storage noob) | 15:39 |
hemna | morning | 15:39 |
e0ne | mtanino: unfortunately, I didn't have FC storage to test it | 15:40 |
hemna | e0ne, what's up | 15:40 |
mtanino | e0ne: Ah I see, that's why the feature doesn't support FC storage.. | 15:40 |
e0ne | hema: sudipto_ is asking about multipath stuff | 15:40 |
*** ducttape_ has joined #openstack-cinder | 15:40 | |
hemna | so | 15:41 |
e0ne | mtanino: it should be easy to enable it for FC if you have such env | 15:41 |
e0ne | hemna: https://bugs.launchpad.net/os-brick/+bug/1628163 | 15:41 |
openstack | Launchpad bug 1628163 in os-brick "OS brick does not have a check for all types of multipath device paths" [Undecided,New] - Assigned to Sudipta Biswas (sbiswas7) | 15:41 |
hemna | sudipto_, the pattern was chosen because regardless of how multipathd is configured (friendly names on or off) that pattern is always there if it's running. | 15:41 |
hemna | the others don't show up all the time. | 15:42 |
hemna | and so searching for them isn't helpful | 15:42 |
sudipto_ | hemna, ok - on my host they appear as scsi-*** | 15:42 |
hemna | because /dev/disk/by-id/dm-uuid-mpath-%(wwn)s is always there. | 15:42 |
mtanino | e0ne: I see. I don't have FC storage too. But you mean FC storage can be supported by technically. | 15:42 |
hemna | so it's not a bug that we don't look for the other paths | 15:43 |
hemna | it's intentional | 15:43 |
sudipto_ | hemna, ok - but on my machine i couldn't see the dm-uuid pattern. That's one of the reasons it went on to another fix: https://review.openstack.org/#/c/324248/ | 15:43 |
jgriffith | scottda: LOL.. hardly! | 15:43 |
e0ne | mtanino: yes | 15:43 |
mtanino | e0ne: gocha. Thank you. | 15:43 |
e0ne | mtanino: you're welcome | 15:43 |
sudipto_ | and i was running mitaka - so that failed as well, because the fix above was not present. | 15:43 |
hemna | sudipto_, your problem is not a bug in brick | 15:44 |
sudipto_ | Is there something i can do to configure the multi path ids to be of the pattern you mentioned? | 15:44 |
e0ne | mtanino: I'll try to get CI working with this feature during O release, maybe, we can test it with FC too | 15:44 |
jgriffith | scottda: TLDR, we should probably take another look at how we've done API versions, and consider aligning more with how Nova is handling things | 15:44 |
hemna | your problem is a misconfigured multipath daemon and a non functioning udev rules | 15:44 |
scottda | jgriffith: OK. how is Nova doing it? | 15:44 |
mtanino | e0ne: It's nice. | 15:44 |
hemna | your bug even states that | 15:44 |
jgriffith | scottda: I find our code a bit confusing and lots of duplicate | 15:44 |
hemna | multipath -l fails | 15:44 |
hemna | that's because udev failed | 15:44 |
jgriffith | scottda: single modules for each API manager | 15:44 |
sudipto_ | hemna, well that does not fail once i apply the fix that i stated in the review... | 15:44 |
jgriffith | scottda: handle the versioning inside of said module | 15:45 |
sudipto_ | https://review.openstack.org/#/c/324248/ - this one. | 15:45 |
scottda | jgriffith: OK, I'll have a look at Nova. | 15:45 |
jgriffith | scottda: get rid of this /v1, /v2, /v3 | 15:45 |
johnthetubaguy | so the version number is global in nova | 15:45 |
johnthetubaguy | just hidden in the header | 15:45 |
sudipto_ | I am OK to mark the bug as invalid, if you could just help me understand what i might be doing wrong in the multi path config? | 15:45 |
jgriffith | scottda: and create a MUCH simpler routing mechanism | 15:45 |
jgriffith | johnthetubaguy: +1 | 15:45 |
scottda | jgriffith: Well, not to shirk responsibility, but the v1 to v2 switched pre-dates my involvement | 15:45 |
jgriffith | johnthetubaguy: scottda which IMO is a much more efficient way to go about it | 15:45 |
johnthetubaguy | I think you will have to leave v1 and v2 there now though, just add it into v2 | 15:45 |
jgriffith | scottda: not saying your responsible :) | 15:46 |
jgriffith | scottda: BUT | 15:46 |
hemna | why are we doing anything with v2 ? | 15:46 |
*** ducttape_ has quit IRC | 15:46 | |
scottda | I'll claim responsibility for the v3 stuff :) | 15:46 |
e0ne | hemna: we fix bugs even for v1 | 15:46 |
hemna | bah | 15:46 |
jgriffith | scottda: what I am saying is "cp -R v1/*, V2/*, V3/*, contrib/* "api/block/" | 15:46 |
hemna | v1 has been deprecated for some time | 15:46 |
hemna | we shouldn't be touching it IMO | 15:46 |
sudipto_ | hemna, and when i put in the fix to look for pattern scsi-* the disk gets attached properly | 15:46 |
jgriffith | scottda: then have a single router into those managers, and handle version differences in the module | 15:46 |
*** sandanar_ has quit IRC | 15:46 | |
jgriffith | scottda: V2 was not your problem, but it was our first mistake | 15:47 |
jgriffith | scottda: at the time though I don't think we really knew any better, and we certainly didn't know we'd end up on the micro-versioning strategy etc | 15:47 |
scottda | Yeah, my first pass on v3 was to do as we did in v1 -> v2, and copy everything. That sucked... | 15:47 |
e0ne | hemna: I don't agree with you. e.g. we've got 500 error from v1/v2/v3 APIs if some param is in a wrong format. we should fix such bugs for all versions | 15:47 |
scottda | So then I went with inheriting everything in v3 from v2 | 15:48 |
jgriffith | scottda: yeah... and what we have now is *slightly* better as it inherits from V2, but I think we should dump that whole business altogether | 15:48 |
scottda | And that is why we end up with duplicate code in v3 for any function that is changed. | 15:48 |
jgriffith | scottda: right, and what I'm saying is we can avoid that | 15:48 |
scottda | jgriffith: I'm all for doing things better. I'll get up to speed on the Nova way. I'm happy to help or work with you or whatever. | 15:48 |
jgriffith | scottda: Nova has done a lot of work on this, and improved it via trial by fire | 15:48 |
jgriffith | scottda: we should leverage the work done by those that went before us :) | 15:49 |
hemna | sudipto_, I want to see your logs and find out why line 491 returned None | 15:49 |
johnthetubaguy | did you see the nice blog post on some of this stuff? | 15:49 |
johnthetubaguy | its really good context | 15:49 |
jgriffith | scottda: cool | 15:49 |
*** diablo_rojo has joined #openstack-cinder | 15:49 | |
jgriffith | scottda: I started playing with it last night, but I MUST finish the attach stuff first, then the local disk stuff | 15:49 |
johnthetubaguy | scottda: jgriffith: I was thinking this one: https://dague.net/2015/06/05/the-nova-api-in-kilo-and-beyond-2/ | 15:49 |
jgriffith | johnthetubaguy: you mean sdague 's or someobody elses? | 15:49 |
hemna | sudipto_, besides, the patch you mentioned landed 9 weeks ago, so I'm not sure what the problem is | 15:50 |
johnthetubaguy | jgriffith: yeah, sean' | 15:50 |
jgriffith | johnthetubaguy: yeah :) That's a pretty nice write up | 15:50 |
scottda | johnthetubaguy: yeah, that's good stuff. Especially for describing microversions | 15:50 |
sudipto_ | hemna, no there isn't a problem with that patch - it's just that, i wondered why i ended up having to use that patch at all | 15:50 |
jgriffith | scottda: anyway, I'd love to work on this with you if you're interested | 15:50 |
sudipto_ | i will get you the logs in a bit. | 15:50 |
jgriffith | but it's going to be a little bit before I have the bandwidth | 15:50 |
scottda | jgriffith: yes, I am. | 15:50 |
jgriffith | cool | 15:51 |
jgriffith | we'll chat in Barcelona | 15:51 |
hemna | sudipto_, ? that patch is part of brick now. | 15:51 |
scottda | jgriffith: I hear you on bandwidth. We can talk in Barcelona indeed. | 15:51 |
hemna | sudipto_, I don't get what you are saying. sorry. | 15:51 |
johnthetubaguy | jgriffith: would love your take on this question when you get chance: https://review.openstack.org/#/c/373203/5/specs/ocata/approved/cinder-new-attach-apis.rst@131 | 15:52 |
sudipto_ | hemna, ok - basically i all i am saying is - if we had looked for the right pattern (scsi-*) in the os-brick code here: https://github.com/openstack/os-brick/blob/5dfa56d8f40799b95c9e6d18c8fc42c263b3f6c4/os_brick/initiator/linuxscsi.py#L250 - we probably would always find the WWN? | 15:52 |
jgriffith | johnthetubaguy: looking now | 15:52 |
johnthetubaguy | jgriffith: awesome, thanks | 15:52 |
jgriffith | johnthetubaguy: ahhh | 15:52 |
jgriffith | johnthetubaguy: well, so I took a different approach on this | 15:52 |
jgriffith | johnthetubaguy: part of what I wanted to solve was the raciness of the req/ack phase of this | 15:53 |
jgriffith | johnthetubaguy: so what I ended up doing was when you do "create_attachment" I mark the volume as "in-use" | 15:53 |
*** diablo_rojo has quit IRC | 15:53 | |
jgriffith | johnthetubaguy: from Cinder's perspective I consider it attached/connected/in-use | 15:53 |
jgriffith | at that point and time | 15:53 |
hemna | sudipto_, the real problem is why didn't your box have the /dev/disk/by-id/dm-uuid-mpath-%(wwn)s or /dev/mapper/%(wwn)s paths | 15:54 |
jgriffith | johnthetubaguy: and I don't re-use attachments | 15:54 |
jgriffith | johnthetubaguy: so if you do multi-attach I create a new attachment record | 15:54 |
johnthetubaguy | jgriffith: right, thats what I have assumed too | 15:54 |
sudipto_ | hemna, agreed...can you tell me how i could generate such device names? (considering i just installed mutlipath and didn't do much - just started the daemon) | 15:54 |
jgriffith | johnthetubaguy: that way we don't care or try and "guess" things when you remove_attachment(attachment-id) | 15:54 |
johnthetubaguy | jgriffith: totally agreed, but there is a bigger issue here I think | 15:55 |
jgriffith | johnthetubaguy: ruh roh :) | 15:55 |
johnthetubaguy | jgriffith: so you add the first volume | 15:55 |
hemna | sudipto_, those paths are created by udev and the daemon itself based upon udev rules and how multpathd is configured | 15:55 |
*** pdeore has joined #openstack-cinder | 15:55 | |
johnthetubaguy | jgriffith: the first person to create_attachment gets to tell os-brick to do the volume host connect bit, but it fails for some reasson | 15:56 |
hemna | sudipto_, https://github.com/openstack/os-brick/blob/5dfa56d8f40799b95c9e6d18c8fc42c263b3f6c4/os_brick/initiator/linuxscsi.py#L221-L234 | 15:56 |
*** pbandark has quit IRC | 15:56 | |
hemna | that is the standard pattern that I noticed when researching this ages ago | 15:56 |
johnthetubaguy | jgriffith: in the mean time, a second volume is attached on another VM, expecting to re-use that connection underneath | 15:56 |
johnthetubaguy | jgriffith: and well that fails | 15:56 |
*** laughterwym has quit IRC | 15:56 | |
hemna | sudipto_, what distro and version are you using ? | 15:56 |
sudipto_ | hemna, i am using RHEL 7.2 | 15:56 |
hemna | sudipto_, and what version of udev and multipathd are you using? | 15:56 |
jgriffith | johnthetubaguy: hmm... I think I see what you're saying | 15:56 |
*** laughterwym has joined #openstack-cinder | 15:57 | |
johnthetubaguy | jgriffith: not totally sure what I want to do, but I am thinking we call back to say its good, and only then folks can "reuse" that connection | 15:57 |
sudipto_ | hemna, evice-mapper-multipath-0.4.9-85 | 15:57 |
jgriffith | johnthetubaguy: I was going the opposite direction; I was working on telling Cinder the connection on the Nova side failed and go back to cinder and remove the attachment | 15:57 |
johnthetubaguy | jgriffith: I guess they need to go in a holding loop in the mean time | 15:57 |
johnthetubaguy | jgriffith: right, thats fine, but its too late, i.e. racey | 15:57 |
jgriffith | johnthetubaguy: I'm trying to parse out the complications with the two connections to same host | 15:58 |
sudipto_ | hemna, udevadm --version | 15:58 |
sudipto_ | 219 | 15:58 |
scottda | jgriffith: johnthetubaguy But we should still be in attaching state, right? | 15:58 |
*** GB21 has joined #openstack-cinder | 15:58 | |
sudipto_ | i am not sure if it's the right way to get you the udev version though | 15:58 |
hemna | ok that's close to ubuntu 14.04's versions | 15:58 |
jgriffith | scottda: nope | 15:58 |
scottda | so the second attempt to attach should not proceed? | 15:58 |
johnthetubaguy | scottda: I am propsing we should be | 15:58 |
jgriffith | scottda: when you call "create_attachment" if that succeeds it's marked as attached | 15:58 |
hemna | might be helpful to list out the paths that you did get | 15:58 |
hemna | something isn't right | 15:58 |
jgriffith | scottda: johnthetubaguy well, if we do that then there's no point in the changes I made :( | 15:58 |
jgriffith | scottda: johnthetubaguy I mean the concept of create_attachment actually creating an attachment record is sort of not in the right place | 15:59 |
sudipto_ | hemna, something like this: lrwxrwxrwx 1 root root 9 Sep 27 15:20 scsi-3600507680280865df8000000000000cd -> ../../sdj | 15:59 |
johnthetubaguy | there huge purpose in most of this still, better handing of multiple attachments, better handing of the info sent to os-brick, etc, etc | 15:59 |
scottda | jgriffith: yes, we were talking yesterday about creating it during reserve() | 15:59 |
jgriffith | johnthetubaguy: scottda then we just go back to a seperate initialize and attach... which is *ok* I guess but that has a host of races | 15:59 |
jgriffith | scottda: you can't :( | 15:59 |
sudipto_ | i am trying this for the first time today, if you let me know what exact info you need, i can get you that...you may have to let me know of how it get it though... :-| | 16:00 |
jgriffith | scottda: if you look at the code the attachment record has things like the connector etc | 16:00 |
johnthetubaguy | jgriffith: I don't think we do have those races, Cinder can block the bad situations, if you handle state on the attachment | 16:00 |
hemna | sudipto_, and you don't have a /dev/disk/by-id/dm-uuid-mpath-<WWN> ? | 16:00 |
hemna | that should always be there | 16:00 |
johnthetubaguy | jgriffith: it should mostly be covered in my spec, ish | 16:00 |
jgriffith | johnthetubaguy: that may be true | 16:00 |
* scottda needs pictures | 16:01 | |
jgriffith | johnthetubaguy: hmmm... | 16:01 |
sudipto_ | hemna, i have something like dm-uuid-LVM - for some | 16:01 |
*** laughterwym has quit IRC | 16:01 | |
sudipto_ | but not the pattern you state for sure | 16:01 |
johnthetubaguy | scottda: does this help: https://review.openstack.org/#/c/373203/5/specs/ocata/approved/cinder-new-attach-apis.rst@163 | 16:01 |
*** pdeore has quit IRC | 16:01 | |
sudipto_ | dm-uuid-LVM-wcMbj2n2rcfg8fJ3NdcOsEGK9Y5luc1HGFjrZV2GscgqqI7JshVq0e9NwbCjUcmP | 16:02 |
sudipto_ | even though this doesn't seem to resemble the WWN | 16:02 |
jgriffith | johnthetubaguy: so are you just proposing a notification back to Cinder when Nova is done? | 16:02 |
scottda | johnthetubaguy: That's good, but still contains the problem you described re: failure to connect the volume with os-brick, right? | 16:03 |
jgriffith | johnthetubaguy: so rather than create_attachment setting the state to "in-use" it leaves it as 'attaching', then makes the final transition when Nova comes back and says yay | nay ? | 16:03 |
johnthetubaguy | jgriffith: yeah, I am typing that up | 16:03 |
jgriffith | johnthetubaguy: that's easy enough | 16:03 |
scottda | But as jgriffith said, that's what we already have, isn't it? | 16:03 |
jgriffith | scottda: it's different | 16:03 |
jgriffith | scottda: because all the logic and work is still taking place in create_attachment | 16:04 |
*** karthikp_ has quit IRC | 16:04 | |
scottda | But the callback to change state sounds like the equivalent of the current attach() call | 16:04 |
johnthetubaguy | its subtle, but different | 16:04 |
jgriffith | scottda: johnthetubaguy IIUC the only thing we're doing is adding an ack back to Cinder saying things are complete on the Nova side | 16:04 |
johnthetubaguy | scottda: oh, maybe it is, yeah | 16:04 |
jgriffith | scottda: johnthetubaguy success or fail | 16:04 |
johnthetubaguy | jgriffith: I think DELETE can be the fail now | 16:05 |
*** haplo37_ has quit IRC | 16:05 | |
scottda | How is that different from calling attach to set cinder DB from attaching -> in-use ? | 16:05 |
johnthetubaguy | scottda: its not really | 16:05 |
jgriffith | scottda: but attach currently does a LOT more than just set the DB state | 16:05 |
jgriffith | johnthetubaguy: I'm mixed on how I fee about this | 16:05 |
jgriffith | johnthetubaguy: I *kinda* see the case you're trying to cover, but I'm not sure I see it as a problem | 16:06 |
hemna | sudipto_, do you have a custom /etc/multipath.conf ? | 16:06 |
jgriffith | johnthetubaguy: I also wanted to keep Cinder as just a provider and nothing more | 16:06 |
*** pdeore has joined #openstack-cinder | 16:06 | |
jgriffith | johnthetubaguy: the more we try to be clever and introduce logic the more problems we have | 16:06 |
sudipto_ | hemna, nope | 16:06 |
johnthetubaguy | jgriffith: so the problems exist, I guess the question is how to fix them in a robust way | 16:07 |
jgriffith | johnthetubaguy: in other words... Cinder just provides block resources; what the consumer does with them is up to them | 16:07 |
*** haplo37_ has joined #openstack-cinder | 16:07 | |
scottda | Well, this diagram may be wrong, but it looks like Attach does does the DB change: https://drive.google.com/file/d/0B1Kp6K43HLHyRkFMZHVHWDJ3amM/view?pref=2&pli=1 | 16:07 |
jgriffith | johnthetubaguy: sorry I'm slow; can you walk me through the problem you're solving again? | 16:07 |
jgriffith | scottda: it does, but it does MORE than that too | 16:07 |
johnthetubaguy | the problem is, some of your drivers violate those rules | 16:07 |
jgriffith | johnthetubaguy: +1 | 16:07 |
jgriffith | johnthetubaguy: we're f'ing borked on the Cinder side because of all the snow-flake shit pushed up in to the manager | 16:08 |
johnthetubaguy | jgriffith: so two volumes attaching on the same host, if done serially they will share one connection to the volume backend | 16:08 |
scottda | jgriffith: I love the idea of Cinder being just a provider. Too bad we cannot just export a volume, give the connector to Nova/Ironic/whoever, and let them do as they please. | 16:08 |
jgriffith | johnthetubaguy: oh... well, I had actually thought we wouldn't do that :) | 16:08 |
johnthetubaguy | problem is some providers require that | 16:09 |
johnthetubaguy | volume providers, that is | 16:09 |
jgriffith | johnthetubaguy: yeah, I forgot about that little detail :) | 16:09 |
*** diablo_rojo has joined #openstack-cinder | 16:09 | |
jgriffith | johnthetubaguy: anyway... continue please ;) | 16:09 |
johnthetubaguy | stepping back, I think in reality there are two attachments, one to the host, and one to the instance | 16:10 |
johnthetubaguy | but I don't think we want that in the API, its way too confusing | 16:10 |
johnthetubaguy | so the bug... | 16:10 |
jgriffith | johnthetubaguy: so let's keep going on your example, I think that problem is solved but I could be wrong | 16:10 |
jgriffith | johnthetubaguy: so currently what I put in place and planned for: | 16:10 |
jgriffith | 1. attachment-1 gets created | 16:11 |
johnthetubaguy | you have volume A attaching, and create attach is called, but os-brick isn't setup | 16:11 |
johnthetubaguy | now volume B is attaching, on the same host | 16:11 |
johnthetubaguy | it wants to reuse the conneciton to the back end, its already in place, so it can, and so it proceeds | 16:11 |
*** salv-orl_ has quit IRC | 16:11 | |
*** pdeore has quit IRC | 16:11 | |
johnthetubaguy | now we get back to volume A, os-brick fails, and so things go boom | 16:11 |
johnthetubaguy | volume A just DELETEs its attachment | 16:12 |
hemna | sudipto_, maybe dump out your /dev/disk/by-id dir ? | 16:12 |
johnthetubaguy | but now volume B will never work, and spots that much later | 16:12 |
*** salv-orlando has joined #openstack-cinder | 16:12 | |
sudipto_ | hemna, alright in a sec | 16:12 |
johnthetubaguy | or volume B tries to use the thing before its actually created bt the volume A thread | 16:12 |
jgriffith | johnthetubaguy: got ya | 16:12 |
hemna | sudipto_, pastebin please :) | 16:13 |
sudipto_ | hemna, ok - was thinking paste.openstack - but will do pastern | 16:13 |
jgriffith | johnthetubaguy: I'm thinking..... | 16:13 |
*** raunak has joined #openstack-cinder | 16:14 | |
scottda | johnthetubaguy: your idea about 2 attaches is right, so maybe we need to states. something like "connected" (to compute host) and "attached" (to instance) | 16:14 |
jgriffith | johnthetubaguy: so let's call the nova side of this and the things it does with brick the "connection" to avoid ambiguity | 16:14 |
scottda | Then, the "connected" state could be used to help with the drivers that multi-plex the connection. | 16:14 |
sudipto_ | hemna, http://pastebin.com/HuZZxXEe | 16:14 |
jgriffith | johnthetubaguy: so the concern is that the connection process itself can be a race, and if the first one in fails we're doomed | 16:15 |
johnthetubaguy | jgriffith: yeah | 16:15 |
sudipto_ | hemna, i do see the wwn-% pattern - however they don't seem to match t | 16:16 |
jgriffith | johnthetubaguy: To be clear though, is this a problem for Volume-A and Volume-B OR is it actually a multi-attach problem? | 16:16 |
johnthetubaguy | scottda: I was thinking we just allow one attachment to be "attaching" or "detaching" at any one time, per host, if required, but thats kinda confusing | 16:16 |
jgriffith | johnthetubaguy: I'm not familiar with drivers that share a single target for multiple volumes | 16:16 |
hemna | sudipto_, the entire directory listing if possible | 16:16 |
johnthetubaguy | jgriffith: I think its a problem without multi-attach | 16:16 |
scottda | jgriffith: I think it's a problem for drivers that share connection to the same host, regardless of multi-attach | 16:16 |
sudipto_ | hemna, that's the entire thing ... | 16:16 |
johnthetubaguy | jgriffith: I thought the fiber channel stuff maybe? | 16:16 |
hemna | ok | 16:16 |
jgriffith | johnthetubaguy: just revert that stuff and we'll all be beter off :) | 16:17 |
*** mvk has quit IRC | 16:17 | |
*** cknight has joined #openstack-cinder | 16:17 | |
diablo_rojo | dulek if you want to get this in I took my - Workflow off https://review.openstack.org/#/c/290885/17 | 16:17 |
johnthetubaguy | jgriffith: yeah... its like the live-migrate of the drivers | 16:17 |
jgriffith | johnthetubaguy: so the only problem I have with this is that I think Nova or Brick should be owning the details | 16:18 |
hemna | sudipto_, how about /dev/mapper as well as multipath -ll | 16:18 |
johnthetubaguy | jgriffith: but Nova doesn't know the driver, and brick has no state | 16:18 |
hemna | the /dev/disk/by-id listing doesn't look like multipath devices to me | 16:18 |
jgriffith | johnthetubaguy: yeah :( | 16:18 |
johnthetubaguy | jgriffith: I think basically this is moving the state os-brick should have into the server | 16:19 |
*** akerr has joined #openstack-cinder | 16:19 | |
*** sudipto_ has quit IRC | 16:19 | |
*** sudipto has quit IRC | 16:19 | |
jgriffith | johnthetubaguy: so the problem I'm having is in the case of a shared connection like you describe we don't currently have any mechanism to deal with it today either | 16:20 |
*** sudipto has joined #openstack-cinder | 16:20 | |
*** sudipto_ has joined #openstack-cinder | 16:20 | |
jgriffith | johnthetubaguy: Unless there's driver magic taking place during initialize-connection or attach-volume | 16:20 |
sudipto | hemna, the multi path -l does not give any o/p | 16:21 |
jgriffith | johnthetubaguy: which very well could be | 16:21 |
*** nkrinner is now known as nkrinner_afk | 16:21 | |
jgriffith | johnthetubaguy: this raises a bigger problem with trying to make this change :( | 16:21 |
hemna | sudipto, multipath -ll doesn't return anything ? | 16:21 |
johnthetubaguy | jgriffith: so deep down I keep thinking everytime we don't tell Cinder the truth of whats happening, we hit a snag | 16:21 |
sudipto | hemna, yeah | 16:21 |
jgriffith | johnthetubaguy: one of the reasons I ended up where I did was because I can't change 80+ cinder drivers | 16:21 |
hemna | then you don't have multipath devices | 16:22 |
johnthetubaguy | jgriffith: it feels good saying when we are done | 16:22 |
scottda | johnthetubaguy: That's the gist of many problems, we hide the truth with trickery | 16:22 |
jgriffith | johnthetubaguy: so I wrapped up existing calls | 16:22 |
johnthetubaguy | scottda: +1 | 16:22 |
*** akapil has quit IRC | 16:22 | |
hemna | sudipto, something else is very wrong. multipathd and udev aren't playing nice. | 16:22 |
*** cknight1 has joined #openstack-cinder | 16:22 | |
johnthetubaguy | jgriffith: so thats still OK here, I think... because I think this is extra state that drivers could eventually use if needed | 16:22 |
sudipto | hemna, oh k :( | 16:23 |
sudipto | hemna, basically if multi path -ll doesn't yield any o/p - the fix would be this right: https://review.openstack.org/#/c/324248/ ? | 16:23 |
*** portdirect has quit IRC | 16:24 | |
hemna | running "multipath -ll" on a box should yield the entire list of multipath devices known. | 16:24 |
hemna | if it doesn't, multipath is in a bad state | 16:24 |
*** cknight has quit IRC | 16:24 | |
jgriffith | johnthetubaguy: what if I didn't condense the initialize and attach, but created the attachment_id on the actual attach and stored all the stateful stuff like I'm doing | 16:24 |
jgriffith | johnthetubaguy: so I wouldn't change much on the Nova side, except adding the attachment_id to the bdm object | 16:25 |
hemna | sudipto, and that patch you listed, which is already in os-brick, won't make any difference | 16:25 |
jgriffith | johnthetubaguy: so then whatever crazy mechanisms the "special" drivers are using to combat this problem today still works? | 16:25 |
sudipto | hemna, ok | 16:26 |
jgriffith | johnthetubaguy: I'm still unclear that this isn't a seperate/existing problem already | 16:26 |
sudipto | when i attach the device though with the scsi-* pattern it does appear to be fine inside the guest... | 16:26 |
johnthetubaguy | jgriffith: possibly, but I would rather we go down the "what we would do if we start over", as we are so close, then see how it maps back to what we have already | 16:26 |
johnthetubaguy | jgriffith: all the problems we are fixing here are generally existing today | 16:27 |
*** rlrossit has joined #openstack-cinder | 16:27 | |
sudipto | and i wonder how i can debug the multi path thing - any clues? | 16:27 |
hemna | sudipto, sure, but it's not a multipath device. | 16:27 |
jgriffith | johnthetubaguy: yeah, so I'd definitely be going the direction I am now if I was starting from scratch | 16:27 |
hemna | multipath isn't working | 16:27 |
hemna | I can't say that enough. | 16:27 |
jgriffith | johnthetubaguy: and drivers would have actually followed the reference | 16:27 |
sudipto | hemna, ok got it... | 16:27 |
hemna | sudipto, you can stop the daemon and run it manually in non-daemon mode | 16:27 |
sudipto | hemna, ok | 16:28 |
hemna | and it will puke out everything | 16:28 |
johnthetubaguy | jgriffith: so drivers had to be different due to technological limitations of what they do, as I understand it, they only support like 10-20 connections, etc | 16:28 |
jgriffith | johnthetubaguy: ok... so I'll change the create_attachment so it leaves it as "attaching" and add an "ack" call back | 16:28 |
hemna | multipathd -v3 -d | 16:28 |
jgriffith | johnthetubaguy: it sort of sucks for non-nova consumers though :( | 16:28 |
johnthetubaguy | jgriffith: they have the same problems right? | 16:28 |
jgriffith | johnthetubaguy: nah, that's not the biggest problem. The bigger problem is we ended up with an interesting split between how people interpretted the attach-flow | 16:29 |
hemna | jgriffith, so the odd thing about that is, that's exactly what we have today | 16:29 |
sudipto | hemna, ok - it says wwid xxx is not in wwid file. | 16:29 |
openstackgerrit | Tom Swanson proposed openstack/cinder: WIP: Dell SC: Adding additional async task logging https://review.openstack.org/377844 | 16:29 |
hemna | jgriffith, we already have that mechanism with initialize_connection and then the follow up with attach | 16:29 |
jgriffith | hemna: that was kinda my point yeah :( It's slightly different, but mostly the same | 16:29 |
johnthetubaguy | hemna: it does feel like we have come full circle here | 16:29 |
scottda | jgriffith: Sorry if I'm not remebering what's in your spec, but weren't you going to implement an is_safe_to_disconnect() call that the driver could answer if they are "special"? | 16:29 |
hemna | :( | 16:29 |
jgriffith | scottda: yeah | 16:29 |
hemna | cinder has exported the volume | 16:30 |
hemna | should cinder just say....it's exported | 16:30 |
scottda | Nova would have to change to use that call, but that seems like a solution to this issue. | 16:30 |
hemna | and if someone wants to say...yah I see it, they can. | 16:30 |
*** jgregor has quit IRC | 16:30 | |
jgriffith | hemna: cinder isn't actually exporting it either though :) | 16:30 |
hemna | does it really affect cinder's follow on actions to the volume at all? | 16:30 |
jgriffith | hemna: cinder is just a control plane | 16:30 |
hemna | well, the backend has exported it | 16:30 |
*** leeantho has joined #openstack-cinder | 16:31 | |
hemna | but as far as cinder is concerned you can take actions on that volume after it's exported from the backend | 16:31 |
*** ekarlso_ has quit IRC | 16:31 | |
hemna | cinder has done it's job of making sure the backend has exported the volume | 16:31 |
hemna | nova just hasn't seen it yet, or ran discovery on it's host. | 16:31 |
jgriffith | hemna: so we go back to "initialize_connection" is the export, and attach should've just been a db update :) | 16:31 |
hemna | the only thing left to do is ack the export | 16:32 |
hemna | yah | 16:32 |
jgriffith | hemna: I still say this isn't Cinder's problem :) | 16:32 |
hemna | it's not really | 16:32 |
*** rlrossit has quit IRC | 16:32 | |
scottda | And perhaps there's need for a 'connected state for array <-> node connection | 16:32 |
*** akapil has joined #openstack-cinder | 16:32 | |
hemna | the only caveat is what cinder will allow from an API perspective on that volume after the export has been done. | 16:32 |
jgriffith | scottda: oh lord... I'm out :) | 16:32 |
*** jordanP has quit IRC | 16:32 | |
hemna | right now we leave it in attaching state, which means there are no other actions allowed | 16:32 |
scottda | I think I agree with jgriffith that it's not cinder's problem. WE just export , but we cannot control whether it's connected to a host, or attached to a VM | 16:33 |
hemna | scottda, that's what I'm getting at | 16:33 |
hemna | but cinder currently doesn't allow any other actions on that volume unless it gets that ack | 16:33 |
*** zhongjun_ has quit IRC | 16:33 | |
hemna | we could alter this | 16:34 |
johnthetubaguy | so I updated my spec (https://review.openstack.org/373203) with the extra ack call | 16:34 |
hemna | to say, the volume is exported and the attachment just hasn't been acked | 16:34 |
johnthetubaguy | I think the only different thing in that spec now is keeping a per attachment state machine | 16:34 |
*** asselin__ has joined #openstack-cinder | 16:34 | |
hemna | johnthetubaguy, the current volume_attachment table has a state | 16:34 |
*** kaisers__ has joined #openstack-cinder | 16:35 | |
*** david-lyle_ has joined #openstack-cinder | 16:35 | |
*** tongli_ has joined #openstack-cinder | 16:35 | |
johnthetubaguy | hemna: does it match what I have put in the spec? it may just be different names | 16:35 |
hemna | http://paste.openstack.org/show/583116/ | 16:35 |
sudipto_ | hemna, one final thing - if the multi path method is able to find a scsi-* device - things just seem to work fine... | 16:35 |
hemna | attach_status | 16:35 |
hemna | sudipto_, but you aren't using a multipath device. | 16:35 |
*** rooneym_ has joined #openstack-cinder | 16:36 | |
hemna | which means you don't get any benefits from multipathing | 16:36 |
sudipto_ | hemna, agreed. | 16:36 |
hemna | that's a failure IMHO | 16:36 |
*** zhenguo_ has joined #openstack-cinder | 16:36 | |
*** xek_ has joined #openstack-cinder | 16:36 | |
*** rooneym has quit IRC | 16:36 | |
*** zhenguo has quit IRC | 16:36 | |
*** ildikov has quit IRC | 16:36 | |
*** haplo37__ has quit IRC | 16:36 | |
*** kambiz has quit IRC | 16:36 | |
*** unrahul has quit IRC | 16:36 | |
*** patrickeast has quit IRC | 16:36 | |
*** kong has quit IRC | 16:36 | |
*** pots has quit IRC | 16:36 | |
*** alaski has quit IRC | 16:36 | |
*** fmccrthy has quit IRC | 16:36 | |
*** rooneym_ is now known as rooneym | 16:36 | |
*** mtanin___ has joined #openstack-cinder | 16:36 | |
*** dansmith has quit IRC | 16:36 | |
*** mpjetta_ has quit IRC | 16:37 | |
*** cknight has joined #openstack-cinder | 16:37 | |
*** aswadr_ has quit IRC | 16:37 | |
*** tbarron has quit IRC | 16:37 | |
*** pckizer_ has quit IRC | 16:37 | |
*** arch-nemesis has quit IRC | 16:37 | |
*** porrua has quit IRC | 16:37 | |
*** nicolasbock has quit IRC | 16:37 | |
*** snarwade has quit IRC | 16:37 | |
*** cebruns_ has joined #openstack-cinder | 16:37 | |
*** Kimmo__ has joined #openstack-cinder | 16:37 | |
*** narayrak has quit IRC | 16:37 | |
*** salv-orlando has quit IRC | 16:37 | |
*** Kimmo_ has quit IRC | 16:37 | |
*** sticker_ has joined #openstack-cinder | 16:37 | |
*** lpetrut has quit IRC | 16:37 | |
*** david-lyle has quit IRC | 16:37 | |
*** kragniz has quit IRC | 16:37 | |
*** akerr_ has joined #openstack-cinder | 16:37 | |
*** sticker_ is now known as 17WAAQNWW | 16:37 | |
hemna | jgriffith, does it make any sense to change the state management of the volume ? | 16:37 |
*** mriedem_meeting has quit IRC | 16:37 | |
*** serverascode has quit IRC | 16:37 | |
*** pkoniszewski has quit IRC | 16:37 | |
*** stevemar has quit IRC | 16:37 | |
*** zengyingzhe has joined #openstack-cinder | 16:37 | |
*** rhedlind has joined #openstack-cinder | 16:37 | |
*** nkrinner_afk has quit IRC | 16:37 | |
*** mfisch has quit IRC | 16:37 | |
*** stevemar has joined #openstack-cinder | 16:37 | |
*** tbarron_ has joined #openstack-cinder | 16:37 | |
*** sticker_ has joined #openstack-cinder | 16:37 | |
*** bluex has quit IRC | 16:37 | |
*** cebruns has quit IRC | 16:37 | |
*** med_ has quit IRC | 16:37 | |
hemna | that after create_attachment is called, set the state of the volume to in-use | 16:37 |
*** nicolasbock has joined #openstack-cinder | 16:37 | |
*** bkopilov has quit IRC | 16:37 | |
*** gcb has quit IRC | 16:37 | |
*** cebruns__ has quit IRC | 16:37 | |
*** jdillaman has quit IRC | 16:37 | |
*** pleia2 has quit IRC | 16:37 | |
*** huanan has quit IRC | 16:37 | |
*** alaski_ has joined #openstack-cinder | 16:37 | |
*** kaisers_ has quit IRC | 16:37 | |
*** krtaylor has quit IRC | 16:37 | |
*** pckizer has joined #openstack-cinder | 16:37 | |
*** merooney has quit IRC | 16:37 | |
*** rhe00 has quit IRC | 16:37 | |
*** dosaboy has quit IRC | 16:37 | |
*** mikal has quit IRC | 16:37 | |
*** jgriffith has quit IRC | 16:37 | |
*** lennyb has quit IRC | 16:37 | |
*** jungleboyj has quit IRC | 16:37 | |
*** hoonetorg has quit IRC | 16:37 | |
*** mnaser has quit IRC | 16:37 | |
*** huanan_L has joined #openstack-cinder | 16:37 | |
*** tbarron_ is now known as tbarron | 16:37 | |
*** pckizer has quit IRC | 16:37 | |
*** pckizer has joined #openstack-cinder | 16:37 | |
hemna | if nova fails to discover, then nova calls cinder again to terminate | 16:37 |
*** dmellado has quit IRC | 16:37 | |
*** porrua_ has joined #openstack-cinder | 16:38 | |
*** raunak has quit IRC | 16:38 | |
*** mtanino has quit IRC | 16:38 | |
*** tongli has quit IRC | 16:38 | |
*** mdovgal has quit IRC | 16:38 | |
*** anteaya has quit IRC | 16:38 | |
*** zengyingzhe__ has quit IRC | 16:38 | |
*** sticker has quit IRC | 16:38 | |
*** asselin_ has quit IRC | 16:38 | |
*** nkrinner_afk has joined #openstack-cinder | 16:38 | |
*** GB21 has quit IRC | 16:38 | |
*** Julien-zte has quit IRC | 16:38 | |
*** thingee has quit IRC | 16:38 | |
hemna | cinder doesn't really care if nova hasn't seen/discovered yet. | 16:38 |
*** alaski_ is now known as alaski | 16:38 | |
*** crose has quit IRC | 16:38 | |
*** ccesario has quit IRC | 16:38 | |
*** sileht has quit IRC | 16:38 | |
hemna | I guess it might introduce a race though | 16:38 |
*** eharney has quit IRC | 16:38 | |
*** gouthamr has quit IRC | 16:38 | |
*** nherciu_ has quit IRC | 16:38 | |
*** sudipto has quit IRC | 16:38 | |
*** jidar has quit IRC | 16:38 | |
*** krtaylor has joined #openstack-cinder | 16:38 | |
*** anteaya has joined #openstack-cinder | 16:38 | |
*** kambiz has joined #openstack-cinder | 16:38 | |
*** kaisers1 has joined #openstack-cinder | 16:38 | |
*** cknight1 has quit IRC | 16:38 | |
*** zzzeek has quit IRC | 16:38 | |
*** Wi1d_ has quit IRC | 16:38 | |
*** akerr has quit IRC | 16:38 | |
*** kaisers has quit IRC | 16:38 | |
*** lpetrut1 has joined #openstack-cinder | 16:38 | |
*** pkoniszewski has joined #openstack-cinder | 16:38 | |
*** xek has quit IRC | 16:38 | |
*** lennyb has joined #openstack-cinder | 16:38 | |
*** dmellado has joined #openstack-cinder | 16:38 | |
hemna | between the time that cinder sets the state to in-use and nova calls terminate, we could get another action being taken on the volume. | 16:38 |
*** links has quit IRC | 16:38 | |
*** wxy__ has quit IRC | 16:38 | |
*** apopovych has quit IRC | 16:38 | |
*** dgonzalez has quit IRC | 16:38 | |
*** lpetrut1 is now known as lpetrut | 16:38 | |
*** hoonetorg has joined #openstack-cinder | 16:38 | |
*** diablo_rojo has quit IRC | 16:38 | |
*** cebruns has joined #openstack-cinder | 16:38 | |
*** timcl has quit IRC | 16:38 | |
hemna | we'd have to modify the API to allow terminate on that volume to be called. | 16:38 |
*** xinli has quit IRC | 16:38 | |
hemna | gets us into an odd place | 16:39 |
*** pleia2 has joined #openstack-cinder | 16:39 | |
hemna | (sorry I'm just thinking outloud) | 16:39 |
hemna | nm | 16:39 |
*** sudipto has joined #openstack-cinder | 16:39 | |
*** jgriffith has joined #openstack-cinder | 16:39 | |
*** Julien-zte has joined #openstack-cinder | 16:39 | |
*** nherciu_ has joined #openstack-cinder | 16:39 | |
*** arch-nemesis has joined #openstack-cinder | 16:39 | |
jgriffith | johnthetubaguy: sorry... got bounced | 16:39 |
jgriffith | johnthetubaguy: ok, we'll go with that for now then | 16:39 |
*** 17WAAQNWW has quit IRC | 16:40 | |
*** dansmith has joined #openstack-cinder | 16:40 | |
*** snarwade has joined #openstack-cinder | 16:40 | |
johnthetubaguy | jgriffith: so I updated the spec with my current preference, I think: https://review.openstack.org/373203 | 16:40 |
*** zhenguo_ is now known as zhenguo | 16:40 | |
*** kragniz1 has joined #openstack-cinder | 16:40 | |
*** haplo37 has joined #openstack-cinder | 16:40 | |
jgriffith | johnthetubaguy: seems like an ok comporomise, and I have an idea to keep it from being problematic for consumers other than Nova that don't need the extra step | 16:40 |
openstackgerrit | michaeldovgal proposed openstack/cinder: Add if host's cinder-volume service is disabled validation https://review.openstack.org/377886 | 16:40 |
openstackgerrit | Merged openstack/os-brick: Docstrings should not start with a space https://review.openstack.org/377265 | 16:40 |
jgriffith | johnthetubaguy: yeah, I read the update, looks good to me | 16:41 |
*** ircuser-1 has quit IRC | 16:41 | |
*** Apoorva has joined #openstack-cinder | 16:41 | |
*** gouthamr has joined #openstack-cinder | 16:41 | |
jgriffith | johnthetubaguy: thanks for your patience, I can be slow sometimes :) | 16:41 |
*** jidar has joined #openstack-cinder | 16:41 | |
*** DuncanT has quit IRC | 16:41 | |
johnthetubaguy | jgriffith: mind meld over IRC isn't that efficient | 16:41 |
*** ducttape_ has joined #openstack-cinder | 16:42 | |
*** mfisch has joined #openstack-cinder | 16:42 | |
jgriffith | johnthetubaguy: true | 16:42 |
*** mfisch has quit IRC | 16:42 | |
*** mfisch has joined #openstack-cinder | 16:42 | |
johnthetubaguy | jgriffith: so there was one more case, os-brick fails to detach | 16:42 |
*** mikal has joined #openstack-cinder | 16:42 | |
johnthetubaguy | its tempting to have an ERROR state for an attachment for that case, but it feels like overkil | 16:43 |
*** ildikov has joined #openstack-cinder | 16:44 | |
*** dosaboy has joined #openstack-cinder | 16:44 | |
*** wilson_liu has joined #openstack-cinder | 16:45 | |
*** dgonzalez has joined #openstack-cinder | 16:45 | |
*** Apoorva_ has joined #openstack-cinder | 16:45 | |
*** rhe00 has joined #openstack-cinder | 16:45 | |
*** cknight1 has joined #openstack-cinder | 16:45 | |
scottda | Well, as johnthetubaguy pointed out, the problem is that we mask the truth. We could be more explicit around volume state: exported, connected, in-use. | 16:45 |
*** sudswas__ has joined #openstack-cinder | 16:46 | |
*** zengyingzhe_ has joined #openstack-cinder | 16:46 | |
*** huanan_M has joined #openstack-cinder | 16:46 | |
hemna | scottda, +1 | 16:46 |
*** Guest66676 has quit IRC | 16:46 | |
*** grumpycatt has quit IRC | 16:46 | |
*** grumpycatt has joined #openstack-cinder | 16:46 | |
*** kaisers has joined #openstack-cinder | 16:46 | |
*** cburgess_ has joined #openstack-cinder | 16:46 | |
*** nherciu__ has joined #openstack-cinder | 16:47 | |
*** lennyb has quit IRC | 16:47 | |
*** ChubYann has quit IRC | 16:47 | |
johnthetubaguy | scottda: hemna: my spec tries to do most of that by adding extra state into the attachments, I am curious if I am missing any now | 16:47 |
*** rhagarty_ has joined #openstack-cinder | 16:47 | |
*** rhagarty_ has quit IRC | 16:47 | |
*** rhagarty_ has joined #openstack-cinder | 16:47 | |
*** rhedlind has quit IRC | 16:47 | |
*** cburgess has quit IRC | 16:47 | |
*** pkoraca has quit IRC | 16:47 | |
*** mtanino has joined #openstack-cinder | 16:47 | |
*** porrua has joined #openstack-cinder | 16:47 | |
*** yangyapeng has joined #openstack-cinder | 16:47 | |
*** sudipto has quit IRC | 16:47 | |
*** pckizer has quit IRC | 16:47 | |
*** Guest96871 has quit IRC | 16:47 | |
*** mtanino has quit IRC | 16:47 | |
*** mtanino has joined #openstack-cinder | 16:47 | |
hemna | ok I'll go read the update :) | 16:47 |
*** mfisch` has joined #openstack-cinder | 16:47 | |
*** tbarron has quit IRC | 16:47 | |
*** zengyingzhe has quit IRC | 16:47 | |
*** sdague has quit IRC | 16:47 | |
*** zhengyin has quit IRC | 16:47 | |
*** pocketprotector has quit IRC | 16:47 | |
*** nherciu_ has quit IRC | 16:47 | |
*** jgriffith has quit IRC | 16:47 | |
*** tbarron has joined #openstack-cinder | 16:47 | |
*** dmellado_ has joined #openstack-cinder | 16:47 | |
*** jidar_ has joined #openstack-cinder | 16:47 | |
*** kaisers2 has quit IRC | 16:47 | |
*** ducttape_ has quit IRC | 16:48 | |
*** lpetrut1 has joined #openstack-cinder | 16:48 | |
*** gouthamr has quit IRC | 16:48 | |
*** cebruns has quit IRC | 16:48 | |
*** sticker_ has quit IRC | 16:48 | |
*** briancurtin has quit IRC | 16:48 | |
*** Apoorva has quit IRC | 16:48 | |
*** huanan_L has quit IRC | 16:48 | |
*** mtanin___ has quit IRC | 16:48 | |
*** jamielennox has quit IRC | 16:48 | |
*** vkmc has quit IRC | 16:48 | |
*** Wi1d has joined #openstack-cinder | 16:48 | |
*** zzzeek has joined #openstack-cinder | 16:48 | |
*** dansmith has quit IRC | 16:48 | |
*** lpetrut has quit IRC | 16:48 | |
*** mfisch has quit IRC | 16:48 | |
*** kragniz1 has quit IRC | 16:48 | |
*** yangyape_ has quit IRC | 16:48 | |
*** rhagarty__ has quit IRC | 16:48 | |
*** rmk` has joined #openstack-cinder | 16:48 | |
*** dansmith has joined #openstack-cinder | 16:48 | |
*** gouthamr_ has joined #openstack-cinder | 16:48 | |
*** vkmc- has joined #openstack-cinder | 16:48 | |
*** dmellado has quit IRC | 16:48 | |
*** logan- has quit IRC | 16:48 | |
*** rmk has quit IRC | 16:48 | |
*** anteaya has quit IRC | 16:48 | |
*** jidar has quit IRC | 16:48 | |
*** porrua_ has quit IRC | 16:48 | |
*** pckizer has joined #openstack-cinder | 16:48 | |
*** pckizer has quit IRC | 16:48 | |
*** pckizer has joined #openstack-cinder | 16:48 | |
*** med_ has joined #openstack-cinder | 16:48 | |
*** lpetrut1 is now known as lpetrut | 16:48 | |
*** mpjetta has joined #openstack-cinder | 16:48 | |
*** rmk` is now known as rmk | 16:48 | |
*** rmk has quit IRC | 16:48 | |
*** rmk has joined #openstack-cinder | 16:48 | |
*** dansmith is now known as Guest3747 | 16:48 | |
*** cebruns has joined #openstack-cinder | 16:48 | |
*** vkmc- is now known as vkmc | 16:48 | |
*** vkmc has quit IRC | 16:48 | |
*** vkmc has joined #openstack-cinder | 16:48 | |
*** med_ is now known as Guest44064 | 16:48 | |
*** fmccrthy has joined #openstack-cinder | 16:48 | |
*** jamielennox has joined #openstack-cinder | 16:48 | |
*** bkopilov has joined #openstack-cinder | 16:49 | |
*** cknight has quit IRC | 16:49 | |
*** winston-d has joined #openstack-cinder | 16:49 | |
*** jidar_ is now known as jidar | 16:49 | |
*** jgriffith has joined #openstack-cinder | 16:49 | |
*** Guest3203 is now known as melwitt | 16:49 | |
*** timcl has joined #openstack-cinder | 16:49 | |
*** lennyb has joined #openstack-cinder | 16:50 | |
*** GB21 has joined #openstack-cinder | 16:50 | |
*** cdelatte has quit IRC | 16:50 | |
*** eharney has joined #openstack-cinder | 16:50 | |
*** ccesario has joined #openstack-cinder | 16:50 | |
*** anteaya has joined #openstack-cinder | 16:50 | |
*** cdelatte has joined #openstack-cinder | 16:51 | |
*** kragniz1 has joined #openstack-cinder | 16:51 | |
*** gcb has joined #openstack-cinder | 16:51 | |
*** crose has joined #openstack-cinder | 16:51 | |
*** sileht has joined #openstack-cinder | 16:51 | |
*** ChubYann has joined #openstack-cinder | 16:51 | |
*** jklare has quit IRC | 16:51 | |
*** diablo_rojo has joined #openstack-cinder | 16:51 | |
*** links has joined #openstack-cinder | 16:52 | |
*** bluex has joined #openstack-cinder | 16:52 | |
*** AndyWojo has quit IRC | 16:52 | |
*** zhengyin has joined #openstack-cinder | 16:52 | |
*** jdillaman has joined #openstack-cinder | 16:52 | |
*** Guest3747 is now known as dansmith | 16:52 | |
*** pocketprotector has joined #openstack-cinder | 16:53 | |
*** logan- has joined #openstack-cinder | 16:54 | |
*** patrickeast has joined #openstack-cinder | 16:54 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/377426 | 16:54 |
*** e0ne has quit IRC | 16:56 | |
*** wxy__ has joined #openstack-cinder | 16:56 | |
*** raunak has joined #openstack-cinder | 16:57 | |
*** mnaser has joined #openstack-cinder | 16:57 | |
*** Guest66666 has joined #openstack-cinder | 16:57 | |
*** jklare has joined #openstack-cinder | 16:58 | |
*** sdague has joined #openstack-cinder | 16:58 | |
*** mriedem has joined #openstack-cinder | 16:58 | |
*** karthikp- has joined #openstack-cinder | 16:59 | |
*** salv-orlando has joined #openstack-cinder | 16:59 | |
*** rajinir has quit IRC | 17:00 | |
*** akapil has quit IRC | 17:00 | |
*** ducttape_ has joined #openstack-cinder | 17:01 | |
*** Apoorva has joined #openstack-cinder | 17:01 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-brick: Updated from global requirements https://review.openstack.org/373771 | 17:01 |
*** unrahul has joined #openstack-cinder | 17:02 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/376131 | 17:02 |
*** ircuser-1 has joined #openstack-cinder | 17:03 | |
*** akapil has joined #openstack-cinder | 17:03 | |
scottda | Well, at some point "special" drivers need to know if there's already an connection to the NOva host for a given volume, or possibly for any volume. This is the info needed for a is_safe_to_disconnect call. I think it's better to be explicit that to hack around to figure that out. But just my opinion. | 17:04 |
*** Apoorva_ has quit IRC | 17:04 | |
johnthetubaguy | scottda: so the initialize_detaching call is the is_safe_to_disconnect call | 17:06 |
*** ducttape_ has quit IRC | 17:06 | |
*** frontrunner has joined #openstack-cinder | 17:06 | |
johnthetubaguy | scottda: so I guess its a hack, but we would know if volume x has been connected on host y, with that proposed attachment logic | 17:06 |
johnthetubaguy | scottda: basically I am leaving it os-brick and cinder to sort out its own interface for that, at least I think I am... | 17:08 |
johnthetubaguy | scottda: I should think on that more | 17:08 |
*** nherciu_ has joined #openstack-cinder | 17:08 | |
*** timcl1 has joined #openstack-cinder | 17:09 | |
*** Apoorva_ has joined #openstack-cinder | 17:10 | |
*** jidar_ has joined #openstack-cinder | 17:10 | |
*** jgriffith_ has joined #openstack-cinder | 17:10 | |
*** cdelatte has quit IRC | 17:10 | |
*** timcl has quit IRC | 17:10 | |
*** kaisers has quit IRC | 17:10 | |
*** jidar has quit IRC | 17:10 | |
*** ccesario has quit IRC | 17:10 | |
*** GB21 has quit IRC | 17:10 | |
*** Guest44064 has quit IRC | 17:10 | |
*** kaisers2 has joined #openstack-cinder | 17:10 | |
*** nherciu__ has quit IRC | 17:11 | |
*** jidar_ is now known as jidar | 17:11 | |
*** mpjetta has quit IRC | 17:11 | |
*** jgriffith has quit IRC | 17:11 | |
*** unrahul has quit IRC | 17:11 | |
*** logan- has quit IRC | 17:11 | |
*** stevemar has quit IRC | 17:11 | |
*** stevemar has joined #openstack-cinder | 17:11 | |
*** ircuser-1 has quit IRC | 17:11 | |
*** porrua_ has joined #openstack-cinder | 17:11 | |
*** delattec has joined #openstack-cinder | 17:11 | |
*** apopovych has joined #openstack-cinder | 17:11 | |
*** raunak_ has joined #openstack-cinder | 17:11 | |
*** mtanino__ has joined #openstack-cinder | 17:11 | |
*** sdague has quit IRC | 17:11 | |
*** patrickeast has quit IRC | 17:11 | |
*** dmellado_ has quit IRC | 17:11 | |
*** alaski has quit IRC | 17:11 | |
*** apopovych has quit IRC | 17:11 | |
*** apopovych has joined #openstack-cinder | 17:11 | |
*** mtanino__ has quit IRC | 17:11 | |
*** mtanino__ has joined #openstack-cinder | 17:11 | |
*** lpetrut1 has joined #openstack-cinder | 17:11 | |
*** mnaser has quit IRC | 17:11 | |
*** rhagarty_ has quit IRC | 17:11 | |
*** GB21 has joined #openstack-cinder | 17:11 | |
*** frontrunner has quit IRC | 17:11 | |
*** pocketprotector has quit IRC | 17:11 | |
*** eharney has quit IRC | 17:11 | |
*** bkopilov has quit IRC | 17:11 | |
*** tbarron has quit IRC | 17:11 | |
*** porrua has quit IRC | 17:11 | |
*** mtanino has quit IRC | 17:11 | |
*** kambiz has quit IRC | 17:11 | |
*** dansmith has quit IRC | 17:11 | |
*** links has quit IRC | 17:11 | |
*** gouthamr_ has quit IRC | 17:11 | |
*** Julien-zte has quit IRC | 17:12 | |
*** lpetrut has quit IRC | 17:12 | |
*** jamielennox has quit IRC | 17:12 | |
*** Wi1d has quit IRC | 17:12 | |
*** pleia2 has quit IRC | 17:12 | |
*** cebruns has quit IRC | 17:12 | |
*** Guest66666 has quit IRC | 17:12 | |
*** wxy__ has quit IRC | 17:12 | |
*** lpetrut1 is now known as lpetrut | 17:12 | |
*** mpjetta has joined #openstack-cinder | 17:12 | |
*** eharney has joined #openstack-cinder | 17:12 | |
*** akapil has quit IRC | 17:12 | |
*** jklare has quit IRC | 17:12 | |
*** jklare has joined #openstack-cinder | 17:12 | |
*** winston-d has quit IRC | 17:12 | |
*** Wi1d_ has joined #openstack-cinder | 17:12 | |
*** kambiz_ has joined #openstack-cinder | 17:12 | |
*** bkopilov_ has joined #openstack-cinder | 17:12 | |
*** gouthamr has joined #openstack-cinder | 17:12 | |
*** jgriffith_ is now known as jgriffith | 17:12 | |
*** tbarron has joined #openstack-cinder | 17:12 | |
*** pocketprotector has joined #openstack-cinder | 17:12 | |
*** pocketprotector has quit IRC | 17:12 | |
*** pocketprotector has joined #openstack-cinder | 17:12 | |
*** Apoorva has quit IRC | 17:12 | |
*** raunak has quit IRC | 17:12 | |
*** raunak_ is now known as raunak | 17:12 | |
*** ircuser-1 has joined #openstack-cinder | 17:12 | |
*** jraju has joined #openstack-cinder | 17:12 | |
*** ccesario has joined #openstack-cinder | 17:12 | |
*** dmellado has joined #openstack-cinder | 17:12 | |
*** cebruns has joined #openstack-cinder | 17:12 | |
*** logan- has joined #openstack-cinder | 17:12 | |
*** kambiz_ is now known as kambiz | 17:12 | |
*** dansmith has joined #openstack-cinder | 17:13 | |
*** sdague has joined #openstack-cinder | 17:13 | |
*** Julien-zte has joined #openstack-cinder | 17:13 | |
*** frontrunner has joined #openstack-cinder | 17:14 | |
*** alaski has joined #openstack-cinder | 17:14 | |
*** jamielennox has joined #openstack-cinder | 17:14 | |
*** kragniz1 is now known as kragniz | 17:15 | |
*** pleia2 has joined #openstack-cinder | 17:15 | |
scottda | johnthetubaguy: ok | 17:15 |
*** winston-d has joined #openstack-cinder | 17:16 | |
*** Guest66666 has joined #openstack-cinder | 17:17 | |
*** harlowja has joined #openstack-cinder | 17:17 | |
*** ircuser-1 has quit IRC | 17:17 | |
*** patrickeast has joined #openstack-cinder | 17:17 | |
patrickeast | is freenode having problems? i keep getting disconnected :( | 17:18 |
*** ircuser-1 has joined #openstack-cinder | 17:18 | |
*** porrua has joined #openstack-cinder | 17:18 | |
*** gouthamr_ has joined #openstack-cinder | 17:19 | |
*** mtanino has joined #openstack-cinder | 17:19 | |
scottda | IRC is pretty flaky today.... | 17:20 |
*** cdelatte has joined #openstack-cinder | 17:20 | |
*** raunak_ has joined #openstack-cinder | 17:20 | |
openstackgerrit | Karthik Prabhu Vinod proposed openstack/cinder: Switch service capabilities to ovo https://review.openstack.org/319040 | 17:20 |
openstackgerrit | Karthik Prabhu Vinod proposed openstack/cinder: Refactoring total_capacity_gb & free_capavity_gb in capabilities https://review.openstack.org/374971 | 17:20 |
*** grumpycatt has quit IRC | 17:21 | |
*** grumpycatt has joined #openstack-cinder | 17:21 | |
*** dmellado_ has joined #openstack-cinder | 17:21 | |
*** haplo37_ has quit IRC | 17:21 | |
*** mikal_ has joined #openstack-cinder | 17:21 | |
*** lpetrut has quit IRC | 17:21 | |
*** dmellado has quit IRC | 17:21 | |
*** stevemar has quit IRC | 17:21 | |
*** swamireddy_ has quit IRC | 17:21 | |
*** delattec has quit IRC | 17:21 | |
*** stevemar has joined #openstack-cinder | 17:21 | |
patrickeast | scottda: yea, irccloud was down… back to using ancient means of communication | 17:21 |
*** tbarron has quit IRC | 17:21 | |
*** mtanino__ has quit IRC | 17:21 | |
*** sileht has quit IRC | 17:21 | |
*** diegows has quit IRC | 17:21 | |
*** harlowja_ has joined #openstack-cinder | 17:22 | |
*** Wi1d has joined #openstack-cinder | 17:22 | |
*** Guest66676 has joined #openstack-cinder | 17:22 | |
*** sage_ has quit IRC | 17:22 | |
*** zzzeek has quit IRC | 17:22 | |
*** krtaylor has quit IRC | 17:22 | |
*** harlowja has quit IRC | 17:22 | |
*** pleia2 has quit IRC | 17:22 | |
*** logan- has quit IRC | 17:22 | |
*** raunak has quit IRC | 17:22 | |
*** porrua_ has quit IRC | 17:22 | |
*** zhengyin has quit IRC | 17:22 | |
*** raunak_ is now known as raunak | 17:22 | |
patrickeast | ah yea https://twitter.com/freenodestaff/status/780813276733210629 | 17:22 |
*** kambiz has quit IRC | 17:22 | |
*** bluex has quit IRC | 17:22 | |
*** jklare has quit IRC | 17:22 | |
openstackgerrit | Karthik Prabhu Vinod proposed openstack/cinder: Refactoring total_capacity_gb & free_capacity_gb in capabilities https://review.openstack.org/374971 | 17:22 |
*** tbarron has joined #openstack-cinder | 17:22 | |
*** frontrunner has quit IRC | 17:22 | |
*** mikal has quit IRC | 17:22 | |
*** kambiz has joined #openstack-cinder | 17:22 | |
*** Guest66666 has quit IRC | 17:22 | |
*** bkopilov_ has quit IRC | 17:22 | |
*** gouthamr has quit IRC | 17:22 | |
*** Wi1d_ has quit IRC | 17:22 | |
*** frontrunner has joined #openstack-cinder | 17:22 | |
*** salv-orl_ has joined #openstack-cinder | 17:22 | |
*** sage_ has joined #openstack-cinder | 17:22 | |
*** jklare has joined #openstack-cinder | 17:22 | |
*** krtaylor has joined #openstack-cinder | 17:22 | |
*** pleia2 has joined #openstack-cinder | 17:23 | |
*** haplo37_ has joined #openstack-cinder | 17:23 | |
*** bkopilov_ has joined #openstack-cinder | 17:23 | |
*** serverascode has joined #openstack-cinder | 17:23 | |
*** alonma has joined #openstack-cinder | 17:23 | |
*** pkoraca has joined #openstack-cinder | 17:23 | |
*** shyama has joined #openstack-cinder | 17:23 | |
*** zzzeek has joined #openstack-cinder | 17:24 | |
*** sileht has joined #openstack-cinder | 17:24 | |
*** david-lyle_ is now known as david-lyle | 17:24 | |
*** diablo_rojo has quit IRC | 17:25 | |
*** bluex has joined #openstack-cinder | 17:25 | |
*** salv-orlando has quit IRC | 17:25 | |
*** haplo37| has joined #openstack-cinder | 17:25 | |
scottda | patrickeast: Yes! IT's not just you. | 17:25 |
*** swamireddy has joined #openstack-cinder | 17:26 | |
*** rmk` has joined #openstack-cinder | 17:27 | |
*** zhengyin has joined #openstack-cinder | 17:27 | |
*** GB21 has quit IRC | 17:27 | |
*** haplo37 has quit IRC | 17:28 | |
*** alonma has quit IRC | 17:28 | |
*** logan- has joined #openstack-cinder | 17:28 | |
*** salv-orlando has joined #openstack-cinder | 17:31 | |
*** frontrunner2 has joined #openstack-cinder | 17:32 | |
*** lennyb has quit IRC | 17:32 | |
*** rmk has quit IRC | 17:32 | |
*** rmk` is now known as rmk | 17:32 | |
*** rmk has quit IRC | 17:32 | |
*** rmk has joined #openstack-cinder | 17:32 | |
*** apopovych has quit IRC | 17:32 | |
*** stevemar has quit IRC | 17:32 | |
*** mtreinish has quit IRC | 17:33 | |
*** unrahul has joined #openstack-cinder | 17:33 | |
*** unrahul has quit IRC | 17:33 | |
*** unrahul has joined #openstack-cinder | 17:33 | |
*** logan- has quit IRC | 17:33 | |
*** sage_ has quit IRC | 17:33 | |
*** tbarron has quit IRC | 17:33 | |
*** harlowja_ has quit IRC | 17:33 | |
*** sdague has quit IRC | 17:33 | |
*** tbarron has joined #openstack-cinder | 17:33 | |
*** dillaman has joined #openstack-cinder | 17:33 | |
*** frontrunner has quit IRC | 17:33 | |
*** jklare_ has joined #openstack-cinder | 17:33 | |
*** shyama has quit IRC | 17:33 | |
*** jklare has quit IRC | 17:34 | |
*** salv-orl_ has quit IRC | 17:34 | |
*** sileht has quit IRC | 17:34 | |
*** jdillaman has quit IRC | 17:34 | |
*** stevemar has joined #openstack-cinder | 17:34 | |
*** sileht has joined #openstack-cinder | 17:34 | |
*** harlowja has joined #openstack-cinder | 17:34 | |
*** sage_ has joined #openstack-cinder | 17:34 | |
*** rmcall has joined #openstack-cinder | 17:35 | |
*** shyama has joined #openstack-cinder | 17:35 | |
*** sdague has joined #openstack-cinder | 17:35 | |
jgriffith | patrickeast: I tihnk it's freenode | 17:36 |
jgriffith | patrickeast: i've been bouncing on and off all morning | 17:36 |
*** mnaser has joined #openstack-cinder | 17:37 | |
*** diegows has joined #openstack-cinder | 17:37 | |
*** logan- has joined #openstack-cinder | 17:38 | |
*** aswadr_ has joined #openstack-cinder | 17:39 | |
*** mtreinish has joined #openstack-cinder | 17:40 | |
*** lennyb has joined #openstack-cinder | 17:40 | |
*** rmcall has quit IRC | 17:41 | |
Swanson | Argle bargle | 17:41 |
*** Apoorva_ has quit IRC | 17:41 | |
*** harlowja has quit IRC | 17:42 | |
*** sudipto_ has quit IRC | 17:42 | |
*** sudswas__ has quit IRC | 17:42 | |
*** Apoorva has joined #openstack-cinder | 17:42 | |
*** med_ has joined #openstack-cinder | 17:44 | |
*** med_ is now known as Guest79278 | 17:45 | |
*** kong has joined #openstack-cinder | 17:46 | |
*** shyama has quit IRC | 17:46 | |
*** harlowja has joined #openstack-cinder | 17:47 | |
*** DuncanT has joined #openstack-cinder | 17:47 | |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix Cinder migrate_volume_completion https://review.openstack.org/377945 | 17:48 |
*** mvk has joined #openstack-cinder | 17:51 | |
openstackgerrit | Karthik Prabhu Vinod proposed openstack/cinder: Switch service capabilities to ovo https://review.openstack.org/319040 | 17:52 |
*** wxy__ has joined #openstack-cinder | 17:52 | |
*** rajinir has joined #openstack-cinder | 17:52 | |
*** jraju has quit IRC | 17:54 | |
*** apopovych has joined #openstack-cinder | 17:56 | |
*** AndyWojo has joined #openstack-cinder | 17:57 | |
*** aswadr_ has quit IRC | 17:58 | |
*** briancurtin has joined #openstack-cinder | 18:00 | |
*** rlrossit has joined #openstack-cinder | 18:01 | |
*** rlrossit has quit IRC | 18:03 | |
jgriffith | Swanson: Mugles Bugles | 18:08 |
jgriffith | so intersting thing about objects... | 18:08 |
jgriffith | how is it that cinderclient "knows" how to transform a response to an object ? | 18:08 |
*** kambiz_ has joined #openstack-cinder | 18:09 | |
*** aspiers has quit IRC | 18:09 | |
*** grumpycatt has quit IRC | 18:10 | |
*** grumpycatt has joined #openstack-cinder | 18:10 | |
*** harlowja has quit IRC | 18:10 | |
*** jklare_ has quit IRC | 18:10 | |
*** haplo37| has quit IRC | 18:10 | |
*** pkoraca has quit IRC | 18:10 | |
*** serverascode has quit IRC | 18:10 | |
*** mtreinish_ has joined #openstack-cinder | 18:10 | |
*** patrickeast_ has joined #openstack-cinder | 18:10 | |
*** haplo37- has joined #openstack-cinder | 18:10 | |
*** patrickeast_ has quit IRC | 18:10 | |
*** patrickeast_ has joined #openstack-cinder | 18:10 | |
*** yangyape_ has joined #openstack-cinder | 18:10 | |
*** mvk has quit IRC | 18:10 | |
*** Guest79278 has quit IRC | 18:10 | |
*** lennyb has quit IRC | 18:10 | |
*** sage_ has quit IRC | 18:10 | |
*** yangyapeng has quit IRC | 18:10 | |
*** mvk has joined #openstack-cinder | 18:11 | |
jgriffith | my cinder/api/v3/attachments.py looks like this: https://gist.github.com/j-griffith/8798ff8d4af4c9d0c3c7f209f53cca6d | 18:11 |
*** sdague has quit IRC | 18:11 | |
*** wxy__ has quit IRC | 18:11 | |
*** kambiz has quit IRC | 18:11 | |
*** mtreinish has quit IRC | 18:11 | |
*** mtreinish_ is now known as mtreinish | 18:11 | |
*** diegows has quit IRC | 18:11 | |
*** sileht has quit IRC | 18:11 | |
*** diegows has joined #openstack-cinder | 18:11 | |
*** jklare has joined #openstack-cinder | 18:11 | |
jgriffith | but the data returned from cinderclient is the attachment object ??? | 18:11 |
*** kambiz_ is now known as kambiz | 18:11 | |
*** sage_ has joined #openstack-cinder | 18:12 | |
jgriffith | oh.. hehe, clever!!! | 18:12 |
*** serverascode has joined #openstack-cinder | 18:12 | |
*** stevemar_ has joined #openstack-cinder | 18:12 | |
*** sdague has joined #openstack-cinder | 18:13 | |
*** sileht has joined #openstack-cinder | 18:13 | |
*** lennyb has joined #openstack-cinder | 18:13 | |
*** aspiers has joined #openstack-cinder | 18:15 | |
*** chris_morrell has joined #openstack-cinder | 18:15 | |
*** stevemar_ is now known as stevemar__ | 18:17 | |
*** stevemar__ has quit IRC | 18:18 | |
*** e0ne has joined #openstack-cinder | 18:18 | |
*** bardia has joined #openstack-cinder | 18:19 | |
*** stevemar____ has joined #openstack-cinder | 18:20 | |
*** patrickeast_ has quit IRC | 18:20 | |
*** chris_morrell has quit IRC | 18:21 | |
*** diegows has quit IRC | 18:21 | |
*** diegows has joined #openstack-cinder | 18:21 | |
*** sileht has quit IRC | 18:21 | |
*** akapil has joined #openstack-cinder | 18:21 | |
*** sbezverk_ has joined #openstack-cinder | 18:22 | |
sbezverk_ | jgriffith: ping | 18:23 |
*** gershon__ has joined #openstack-cinder | 18:23 | |
*** harlowja has joined #openstack-cinder | 18:24 | |
*** sileht has joined #openstack-cinder | 18:24 | |
*** pkoraca has joined #openstack-cinder | 18:26 | |
*** patrickeast_ has joined #openstack-cinder | 18:28 | |
*** akapil has quit IRC | 18:28 | |
*** wxy__ has joined #openstack-cinder | 18:29 | |
*** dillaman has quit IRC | 18:30 | |
*** diegows has quit IRC | 18:30 | |
*** dillaman has joined #openstack-cinder | 18:30 | |
*** salv-orlando has quit IRC | 18:35 | |
*** sdake has quit IRC | 18:35 | |
*** Rajini_Ram_ has joined #openstack-cinder | 18:36 | |
*** cknight1 has quit IRC | 18:37 | |
*** logan- has quit IRC | 18:39 | |
*** thingee has joined #openstack-cinder | 18:41 | |
*** diegows has joined #openstack-cinder | 18:42 | |
*** logan- has joined #openstack-cinder | 18:42 | |
*** med_ has joined #openstack-cinder | 18:43 | |
*** med_ is now known as Guest40876 | 18:44 | |
*** sdake has joined #openstack-cinder | 18:49 | |
*** thingee has quit IRC | 18:49 | |
*** viks has joined #openstack-cinder | 18:49 | |
*** mtanino_ has joined #openstack-cinder | 18:50 | |
viks | hi, i need some help in a check-in | 18:50 |
viks | I want to check-in under cinder and cinderclient but both are different repositories | 18:50 |
viks | how can I make a single checkin under one bug which is for these 2 repositories | 18:51 |
viks | or am I missing something here? | 18:51 |
hemna | you can't | 18:51 |
hemna | 2 different repos = 2 different commits. | 18:51 |
hemna | 2 different reviews. | 18:51 |
*** Apoorva has quit IRC | 18:52 | |
*** mtani____ has joined #openstack-cinder | 18:52 | |
*** mtanino has quit IRC | 18:52 | |
viks | what about the bug...should I open 2 different bugs | 18:52 |
*** Apoorva has joined #openstack-cinder | 18:52 | |
hemna | if they both contribute to fixing the same issue, no | 18:52 |
hemna | viks, https://wiki.openstack.org/wiki/GitCommitMessages | 18:52 |
viks | but then shold I have 2 chekcin under the same bug | 18:52 |
viks | I mean 2 different commit ids | 18:53 |
*** lpetrut has joined #openstack-cinder | 18:53 | |
viks | will that be OK? | 18:53 |
hemna | read ^^ | 18:53 |
*** raunak has quit IRC | 18:54 | |
*** Cibo has joined #openstack-cinder | 18:54 | |
*** raunak has joined #openstack-cinder | 18:55 | |
*** mtanino_ has quit IRC | 18:55 | |
*** raunak has quit IRC | 18:55 | |
*** raunak has joined #openstack-cinder | 18:56 | |
*** DuncanT has quit IRC | 18:58 | |
*** porrua has quit IRC | 18:58 | |
*** DuncanT has joined #openstack-cinder | 19:00 | |
*** stevemar____ has quit IRC | 19:02 | |
*** sdake has quit IRC | 19:10 | |
*** lpetrut has quit IRC | 19:11 | |
*** haplo37- has quit IRC | 19:11 | |
*** haplo37- has joined #openstack-cinder | 19:12 | |
*** lpetrut1 has joined #openstack-cinder | 19:12 | |
*** zzzeek has quit IRC | 19:12 | |
*** zzzeek has joined #openstack-cinder | 19:12 | |
*** lpetrut1 is now known as lpetrut | 19:12 | |
*** salv-orlando has joined #openstack-cinder | 19:13 | |
*** rlrossit has joined #openstack-cinder | 19:13 | |
*** patrickeast has quit IRC | 19:14 | |
*** patrickeast_ is now known as patrickeast | 19:14 | |
*** erlon_ has joined #openstack-cinder | 19:18 | |
*** salv-orlando has quit IRC | 19:18 | |
*** xyang1 has joined #openstack-cinder | 19:18 | |
erlon_ | . | 19:18 |
patrickeast | yay irccloud is alive again for me | 19:20 |
patrickeast | hemna: jgriffith: not sure if my pings actually got sent earlier, i've got questions about attach/detach if you guys have a few min | 19:20 |
hemna | sup | 19:21 |
hemna | about to head to lunch... | 19:21 |
patrickeast | so uh, i think there is a race condition that breaks things with setups where you have multiple luns per iscsi session | 19:21 |
*** Rajini_Ram_ has quit IRC | 19:21 | |
patrickeast | ponder this while at lunch | 19:21 |
patrickeast | we run the disconnect code in os-brick, and determine that we shouldn't run the iscsi logout since there are other volumes | 19:22 |
jgriffith | patrickeast: sounds like this might be similar to the issue johnthetubaguy is concerned about | 19:22 |
*** akapil has joined #openstack-cinder | 19:22 | |
hemna | if you iscsi logout with other volumes there, they will be gone | 19:23 |
hemna | or....broken | 19:23 |
hemna | ok lunch.... | 19:25 |
*** logan- has quit IRC | 19:26 | |
*** wxy__ has quit IRC | 19:26 | |
*** serverascode has quit IRC | 19:27 | |
*** briancurtin has quit IRC | 19:27 | |
*** stevemar has quit IRC | 19:27 | |
patrickeast | no problemo, everythings good, and we do the scsi device deletes/flush everything, etc | 19:27 |
patrickeast | we release the lock in os-brick, and someone grabs it to do an iscsi attachment *before* terminate connection is called for cinder | 19:27 |
patrickeast | os-brick happily does a iscsi rescan | 19:27 |
patrickeast | and those paths we deleted come right back :( | 19:27 |
patrickeast | looking at the nova code and how we do the disconnect -> terminate connection flow doing them as a isolated operation seems... uh.. tricky | 19:27 |
patrickeast | jgriffith: my assumption is that this isn't a problem for something like lvm, since we always logout of the iscsi session, right? | 19:27 |
patrickeast | which is done inside the os-brick lock | 19:27 |
*** sileht has quit IRC | 19:27 | |
*** unrahul has quit IRC | 19:27 | |
*** yohoffman has quit IRC | 19:27 | |
patrickeast | sort of end result being that are devices left behind on the initiator that no one ever cleans up | 19:27 |
jgriffith | patrickeast: correct | 19:27 |
*** Guest40876 has quit IRC | 19:27 | |
*** dillaman has quit IRC | 19:27 | |
*** rlrossit has quit IRC | 19:27 | |
*** aspiers has quit IRC | 19:27 | |
*** sage_ has quit IRC | 19:27 | |
*** tbarron has quit IRC | 19:27 | |
*** mtani____ has quit IRC | 19:27 | |
patrickeast | jgriffith: maybe, i was looking through the eavesdrop from the conversation this morning | 19:27 |
jgriffith | patrickeast: it's the backends that share a single connection for multiple volumes | 19:27 |
patrickeast | not 100% i followed | 19:27 |
*** xyang1 has quit IRC | 19:27 | |
*** lpetrut has quit IRC | 19:27 | |
*** lpetrut has joined #openstack-cinder | 19:27 | |
*** serverascode has joined #openstack-cinder | 19:28 | |
*** tbarron has joined #openstack-cinder | 19:28 | |
*** akapil has quit IRC | 19:28 | |
patrickeast | but similar at least | 19:28 |
jgriffith | patrickeast: oh... the rescan thing, that's been brought up before I thought | 19:28 |
*** yohoffman has joined #openstack-cinder | 19:28 | |
patrickeast | hemna: right, we shouldn't have logged out | 19:28 |
*** dillaman has joined #openstack-cinder | 19:28 | |
*** sage_ has joined #openstack-cinder | 19:28 | |
patrickeast | derp, i think i got dropped for a sec there | 19:29 |
openstackgerrit | Merged openstack/cinder: Updated from global requirements https://review.openstack.org/377426 | 19:29 |
*** aspiers has joined #openstack-cinder | 19:29 | |
*** patrickeast_ has joined #openstack-cinder | 19:30 | |
* patrickeast_ grumbles about irc | 19:30 | |
patrickeast_ | might have lost some history | 19:30 |
*** stevemar has joined #openstack-cinder | 19:30 | |
jgriffith | patrickeast_: better than carrier pigeons | 19:31 |
patrickeast_ | hemna: last thing i saw was your comment about not logging out when other volumes are there, and thats totally fine, that part of this is working correctly | 19:31 |
*** jroll has quit IRC | 19:31 | |
*** alonma has joined #openstack-cinder | 19:32 | |
*** patrickeast__ has joined #openstack-cinder | 19:32 | |
*** lpetrut1 has joined #openstack-cinder | 19:34 | |
*** logan- has joined #openstack-cinder | 19:34 | |
*** freerunner has quit IRC | 19:35 | |
*** mkoderer__ has quit IRC | 19:35 | |
*** Lehtu has quit IRC | 19:35 | |
*** tonyb has quit IRC | 19:35 | |
*** jamespd_ has quit IRC | 19:35 | |
*** patrickeast has quit IRC | 19:35 | |
*** pkoraca has quit IRC | 19:35 | |
*** patrickeast__ is now known as patrickeast | 19:35 | |
*** aspiers has quit IRC | 19:35 | |
*** sage_ has quit IRC | 19:35 | |
*** serverascode has quit IRC | 19:35 | |
*** DuncanT has quit IRC | 19:35 | |
*** rajinir has quit IRC | 19:35 | |
*** swamireddy has quit IRC | 19:35 | |
*** pleia2 has quit IRC | 19:35 | |
*** rha has quit IRC | 19:35 | |
*** zul has quit IRC | 19:35 | |
*** jamespd has joined #openstack-cinder | 19:36 | |
*** tbarron has quit IRC | 19:36 | |
*** erlon_ has quit IRC | 19:36 | |
*** mtreinish has quit IRC | 19:36 | |
*** AndyWojo has quit IRC | 19:36 | |
*** krtaylor has quit IRC | 19:36 | |
*** vkmc has quit IRC | 19:36 | |
*** lpetrut has quit IRC | 19:36 | |
*** stevemar has quit IRC | 19:36 | |
*** patrickeast_ has quit IRC | 19:36 | |
*** zzzeek has quit IRC | 19:36 | |
*** bhagyashri has quit IRC | 19:36 | |
*** tonyb_ has joined #openstack-cinder | 19:36 | |
*** tbarron has joined #openstack-cinder | 19:36 | |
*** mtreinish has joined #openstack-cinder | 19:36 | |
*** lpetrut1 is now known as lpetrut | 19:36 | |
*** pleia2 has joined #openstack-cinder | 19:36 | |
*** alonma has quit IRC | 19:36 | |
*** stevemar has joined #openstack-cinder | 19:36 | |
*** sage__ has joined #openstack-cinder | 19:36 | |
*** sileht has joined #openstack-cinder | 19:37 | |
*** freerunner has joined #openstack-cinder | 19:37 | |
*** aspiers has joined #openstack-cinder | 19:37 | |
*** vkmc has joined #openstack-cinder | 19:37 | |
*** jroll has joined #openstack-cinder | 19:37 | |
*** jroll has quit IRC | 19:37 | |
*** jroll has joined #openstack-cinder | 19:37 | |
*** rlrossit has joined #openstack-cinder | 19:37 | |
*** krtaylor has joined #openstack-cinder | 19:37 | |
*** bhagyashri has joined #openstack-cinder | 19:38 | |
*** erlon_ has joined #openstack-cinder | 19:38 | |
*** mkoderer__ has joined #openstack-cinder | 19:39 | |
*** rha has joined #openstack-cinder | 19:39 | |
*** rha has joined #openstack-cinder | 19:39 | |
*** swamireddy has joined #openstack-cinder | 19:40 | |
*** alonma has joined #openstack-cinder | 19:40 | |
*** Lehtu has joined #openstack-cinder | 19:40 | |
*** rlrossit_ has joined #openstack-cinder | 19:41 | |
*** med_ has joined #openstack-cinder | 19:43 | |
*** med_ is now known as Guest45789 | 19:43 | |
*** kfox1111 has quit IRC | 19:44 | |
*** krtaylor has quit IRC | 19:44 | |
*** jroll has quit IRC | 19:44 | |
*** stevemar has quit IRC | 19:44 | |
*** rha has quit IRC | 19:44 | |
*** krtaylor has joined #openstack-cinder | 19:44 | |
*** haplo37- has quit IRC | 19:44 | |
*** swamireddy has quit IRC | 19:45 | |
*** aspiers has quit IRC | 19:45 | |
*** jamespd has quit IRC | 19:45 | |
*** mdavidson has quit IRC | 19:45 | |
*** salv-orlando has joined #openstack-cinder | 19:45 | |
*** bhagyashri has quit IRC | 19:45 | |
*** vkmc has quit IRC | 19:45 | |
*** sage__ has quit IRC | 19:45 | |
*** rlrossit has quit IRC | 19:45 | |
*** alonma has quit IRC | 19:45 | |
*** mkoderer__ has quit IRC | 19:45 | |
*** dillaman has quit IRC | 19:45 | |
*** jamespd_ has joined #openstack-cinder | 19:45 | |
*** mkoderer__ has joined #openstack-cinder | 19:45 | |
*** dillaman has joined #openstack-cinder | 19:45 | |
*** rha has joined #openstack-cinder | 19:46 | |
*** rha has joined #openstack-cinder | 19:46 | |
*** vkmc has joined #openstack-cinder | 19:46 | |
*** jroll has joined #openstack-cinder | 19:46 | |
*** jroll has quit IRC | 19:46 | |
*** jroll has joined #openstack-cinder | 19:46 | |
*** sage__ has joined #openstack-cinder | 19:46 | |
*** xyang has joined #openstack-cinder | 19:47 | |
*** aspiers has joined #openstack-cinder | 19:47 | |
*** haplo37- has joined #openstack-cinder | 19:47 | |
*** patrickeast has quit IRC | 19:48 | |
*** alonma has joined #openstack-cinder | 19:48 | |
*** jdurgin has quit IRC | 19:48 | |
*** swamireddy has joined #openstack-cinder | 19:49 | |
*** kfox1111 has joined #openstack-cinder | 19:49 | |
*** zul has joined #openstack-cinder | 19:49 | |
*** patrickeast has joined #openstack-cinder | 19:49 | |
*** xyang has quit IRC | 19:51 | |
patrickeast | can’t keep connected | 19:51 |
patrickeast | :( | 19:51 |
patrickeast | anyway | 19:51 |
*** xyang has joined #openstack-cinder | 19:51 | |
patrickeast | jgriffith: so that scenario where potentailly we need to be careful about cleanup and really like worst case could even need locking between teh os-brick stuff and terminate_connection is something that concerns me | 19:52 |
*** rlrossit_ has quit IRC | 19:52 | |
patrickeast | jgriffith: i figure since we’re (you’re) rewriting things we should try and figure out at least a strategy to handle it | 19:52 |
*** alonma has quit IRC | 19:52 | |
*** rlrossit has joined #openstack-cinder | 19:52 | |
jgriffith | patrickeast: yeah | 19:52 |
*** zzzeek has joined #openstack-cinder | 19:52 | |
*** stevemar has joined #openstack-cinder | 19:52 | |
jgriffith | patrickeast: so I'm working right now on changing the method to by default require an ack before setting in-use | 19:53 |
patrickeast | jgriffith: sort of high level view ideally we are smarter and after we do a rescan we can be like “hey, you were deleted, go away” | 19:53 |
patrickeast | jgriffith: ack from the backend? | 19:53 |
*** DuncanT has joined #openstack-cinder | 19:54 | |
*** Apoorva has quit IRC | 19:54 | |
jgriffith | patrickeast: well, so this is the part you can help me with :) Since I don't have experience with a backend that behaves this way | 19:54 |
*** unrahul has joined #openstack-cinder | 19:54 | |
jgriffith | patrickeast: my thought was that this is something that's magically being handled with initialize_connection currently today? | 19:54 |
jgriffith | patrickeast: if that's not the case, then it's an existing issue? | 19:54 |
patrickeast | jgriffith: well so for the most part this stuff is pretty well figured out | 19:55 |
*** alonmarx has joined #openstack-cinder | 19:55 | |
jgriffith | patrickeast: haha... yes, but where? | 19:55 |
patrickeast | jgriffith: but this rescan before terminate connection is an issue today | 19:55 |
*** xyang has quit IRC | 19:55 | |
*** alonma has joined #openstack-cinder | 19:55 | |
patrickeast | jgriffith: sort of like the whole process needs to be synchronized… well thats a bad term, orchestrated? better between the os-brick disconnect and terminate_connection | 19:55 |
jgriffith | patrickeast: oh, sorry... I assumed you were talking about the other case; the "brick connection" failed while there were two attaches in flight | 19:55 |
*** rajinir has joined #openstack-cinder | 19:56 | |
patrickeast | jgriffith: thats also a problem | 19:56 |
jgriffith | patrickeast: we could do that if brick wasn't and independent thing | 19:56 |
jgriffith | patrickeast: well... | 19:56 |
sbezverk_ | jgriffith: ping | 19:56 |
jgriffith | patrickeast: so I *think* the idea of saying that we don't go to "in-use" or "avaialble" until AFTER we get an ack back from nova would help woulnd't it? | 19:57 |
jgriffith | sbezverk_: pong | 19:57 |
jgriffith | patrickeast: so the default states are attaching and detaching... and we treat those as hard locks | 19:57 |
johnthetubaguy | jgriffith: heh, thats a familiar discussioin | 19:57 |
jgriffith | patrickeast: although if the backend doesn't know how to deal with that then I'm kinda sunk :) | 19:57 |
sbezverk_ | jgriffith: that VG leak fix, I saw it went to rc2, but did it go to master? | 19:57 |
patrickeast | jgriffith: that helps but for a different problem, the state change or volume operations isn’t such a big deal | 19:57 |
jgriffith | johnthetubaguy: indeed! dejavous | 19:57 |
*** briancurtin has joined #openstack-cinder | 19:58 | |
jgriffith | johnthetubaguy: it seems that it's an existing problem :( patrickeast has been fortunate enough to encounter it on the detach side of things | 19:58 |
jgriffith | patrickeast: well, you could use that as a cheap lock | 19:58 |
patrickeast | jgriffith: yea but its like locking at the wrong granularity, i think | 19:58 |
jgriffith | patrickeast: but it requires the driver to check the status of any/all volumes on that host | 19:58 |
*** jdurgin has joined #openstack-cinder | 19:59 | |
jgriffith | patrickeast: I won't argue that | 19:59 |
patrickeast | jgriffith: needs to be like on an iscsi session level | 19:59 |
patrickeast | jgriffith: it might be OK though, need to think about it more | 19:59 |
jgriffith | patrickeast: so if you look at the table I introduced, it has connector info including iqn | 19:59 |
jgriffith | patrickeast: seems to me that a backend could be intelligent enough to inspect that info when doing initialize or attach terminate/detach and do the right thing | 20:00 |
patrickeast | jgriffith: oh yea, thats true | 20:00 |
patrickeast | jgriffith: but the problem is n-cpu+os-brick | 20:00 |
patrickeast | jgriffith: so like if it does a disconnect volume with os-brick | 20:00 |
jgriffith | patrickeast: the goal was to have that detail available on the Cinder side to be smarter. Yeah, the brick rescan thing is a whole different ball of wax | 20:00 |
patrickeast | jgriffith: and then attach volume (different volumes) | 20:00 |
*** alonma has quit IRC | 20:00 | |
patrickeast | jgriffith: before it calls terminate connection for the first one (thats the trick) | 20:01 |
jgriffith | patrickeast: but those are problems in brick since day-1 I think | 20:01 |
patrickeast | jgriffith: oh yea totally | 20:01 |
patrickeast | jgriffith: i guess i’m looking at this as our chance to kinda take another look at what were doing and maybe adjust | 20:01 |
jgriffith | patrickeast: I don't know how to fix them now that brick is outside. Unless the stuff I'm working on for nova-vol-agents pans out | 20:01 |
patrickeast | jgriffith: not just cinder <-> nova but the brick calls too | 20:01 |
*** diablo_rojo has joined #openstack-cinder | 20:02 | |
jgriffith | patrickeast: yeah, I hear ya | 20:02 |
jgriffith | patrickeast: and most definitely smart | 20:02 |
patrickeast | jgriffith: oo nova-vol-agents? | 20:02 |
jgriffith | sbezverk_: I am paying attention kinda :) | 20:02 |
jgriffith | patrickeast: yeah | 20:02 |
patrickeast | jgriffith: i was thinking about that c-data agent again… let it do all the work | 20:02 |
patrickeast | jgriffith: but mebbe thats the same idea | 20:02 |
jgriffith | patrickeast: I"m workign on a blueprint in my spare time | 20:02 |
jgriffith | patrickeast: so this is back to the local volumes problem and the original brick proposal | 20:02 |
*** serverascode has joined #openstack-cinder | 20:03 | |
*** alonma has joined #openstack-cinder | 20:03 | |
jgriffith | patrickeast: two birds with one stone | 20:03 |
sbezverk_ | jgriffith: np I see you have hot discussion. Appreciate if you could ping me when you have spare second. by some reason I still see the issue with the latest master.. | 20:03 |
patrickeast | jgriffith: yea totally, if we just had a piece of cinder on each compute node things get a little bit easier to coordinate | 20:03 |
jgriffith | patrickeast: said agent (vol, data... hippo) can coordinate a number of things for us | 20:03 |
jgriffith | sbezverk_: will do, thanks | 20:03 |
*** jungleboyj has joined #openstack-cinder | 20:03 | |
jgriffith | patrickeast: it allows us to do some really interesting things. I'm not getting on my soap box on this again though. Instead I'm going to code it this time :) | 20:04 |
jgriffith | patrickeast: https://wiki.openstack.org/wiki/CinderBrick | 20:04 |
patrickeast | jgriffith: the interesting thing is we can, theoretically, almost just drop a c-vol on every single compute node with the promises of our shiny A-A HA future | 20:04 |
jgriffith | patrickeast: that's obviously just the beginning, add in the parts you're talking about as well | 20:04 |
patrickeast | sweet | 20:05 |
jgriffith | patrickeast: :) | 20:05 |
jgriffith | patrickeast: so the prototype I started last week-end does exactly that | 20:05 |
*** xyang has joined #openstack-cinder | 20:05 | |
jgriffith | patrickeast: but it also takes my "detached" lvm driver for compute nodes that you don't actually want to serve volumes from | 20:05 |
patrickeast | jgriffith: for just local lvm vols? | 20:06 |
jgriffith | patrickeast: but, the good thing is at the end of the day it gets rid of custom block-device drivers, lvm sharing and provides a coordination capability | 20:06 |
*** pkoraca has joined #openstack-cinder | 20:06 | |
patrickeast | jgriffith: i like the sound of that | 20:06 |
*** AndyWojo has joined #openstack-cinder | 20:07 | |
jgriffith | patrickeast: so the way I have it mapped out is you *can* have a cinder VG on the compute node. If you specify to the scheduler you want a vol on host-X to attach to an Instance on host-X then is just skps doing target creation | 20:07 |
jgriffith | patrickeast: if on the other hand you're not on the same host, it attaches a target and exports it the way we do currently | 20:07 |
jgriffith | patrickeast: that also means you can live-migrate and do all the the things you do today if you need/want to | 20:07 |
jgriffith | patrickeast: I'm trying to slowly get us back to having a consistent API :) | 20:08 |
*** alonma has quit IRC | 20:08 | |
jgriffith | patrickeast: but I'm sure there will be some new whiz-bang features added this release that will torpedo that anyway :) | 20:08 |
patrickeast | jgriffith: consistent? whaaa? | 20:08 |
*** kaisers1 has quit IRC | 20:08 | |
jgriffith | patrickeast: yeah I know right :) | 20:08 |
jgriffith | patrickeast: anyway... back to our earlier convo :) | 20:09 |
jgriffith | patrickeast: let me get this first iteration of the new flow working again | 20:09 |
*** kaisers has joined #openstack-cinder | 20:09 | |
jgriffith | patrickeast: then we can pick that apart a bit and see what we can improve | 20:09 |
patrickeast | jgriffith: sounds good | 20:09 |
jgriffith | sbezverk_: what's up? | 20:09 |
*** patrickeast_ has joined #openstack-cinder | 20:13 | |
*** sdake has joined #openstack-cinder | 20:13 | |
sbezverk_ | jgriffith: I just build new cinder-volume image based on latest master and I still hit that issue | 20:14 |
sbezverk_ | I checked the bug and it says fix is in rc2 | 20:14 |
sbezverk_ | I thought it would make to master first | 20:15 |
*** julim has joined #openstack-cinder | 20:15 | |
jgriffith | sbezverk_: hmm, it certainly should have | 20:16 |
jgriffith | sbezverk_: https://review.openstack.org/#/c/365167/ | 20:16 |
*** julim has quit IRC | 20:16 | |
jgriffith | sbezverk_: just yesterday | 20:16 |
jgriffith | sbezverk_: I don't think it's been backported as of yet | 20:16 |
*** e0ne has quit IRC | 20:18 | |
jgriffith | sbezverk_: nope, it hasn't but I'll propose that right now | 20:18 |
*** e0ne has joined #openstack-cinder | 20:18 | |
*** wilson_liu has quit IRC | 20:19 | |
*** huanan_M has quit IRC | 20:19 | |
sbezverk_ | jgriffith: thank you. appreciate it.. | 20:20 |
jgriffith | sbezverk_: https://review.openstack.org/#/c/378013/ | 20:20 |
*** wilson has joined #openstack-cinder | 20:20 | |
jgriffith | sbezverk_: no problem, glad you reminded me :) | 20:20 |
*** rlrossit_ has joined #openstack-cinder | 20:20 | |
sbezverk_ | jgriffith: do you think it will take anoher month of so to get backported ;-) to master ? | 20:20 |
*** wilson is now known as Guest74307 | 20:20 | |
*** patrickeast__ has joined #openstack-cinder | 20:21 | |
*** rlrossit_ has quit IRC | 20:21 | |
*** huanan has joined #openstack-cinder | 20:21 | |
jgriffith | LOL... it should be in master now; it should make it into Newton shortly | 20:21 |
*** logan- has quit IRC | 20:21 | |
*** pkoniszewski has quit IRC | 20:21 | |
*** jschwarz has quit IRC | 20:21 | |
*** e0ne_ has joined #openstack-cinder | 20:22 | |
*** unrahul has quit IRC | 20:22 | |
*** e0ne_ has quit IRC | 20:22 | |
jgriffith | sbezverk_: I'll get smcginnis and patrickeast__ to give it a vote and I'll +a it | 20:22 |
*** flip214 has quit IRC | 20:22 | |
*** _alastor_ has quit IRC | 20:22 | |
*** j_king has quit IRC | 20:22 | |
smcginnis | jgriffith: Looking... | 20:22 |
jgriffith | sbezverk_: just waiting for jenkins to finish | 20:22 |
patrickeast__ | jgriffith: link? | 20:22 |
*** asselin has quit IRC | 20:22 | |
*** mkoderer___ has joined #openstack-cinder | 20:22 | |
jgriffith | patrickeast__: https://review.openstack.org/#/c/378013/ | 20:22 |
patrickeast__ | oh dis one? https://review.openstack.org/#/c/378013/1 | 20:22 |
patrickeast__ | yea | 20:22 |
*** pkoraca has quit IRC | 20:22 | |
*** rajinir has quit IRC | 20:22 | |
*** DuncanT has quit IRC | 20:22 | |
*** swamireddy has quit IRC | 20:23 | |
*** xyang has quit IRC | 20:23 | |
*** jungleboyj has quit IRC | 20:23 | |
jgriffith | yeah, still needs to run through gate | 20:23 |
jgriffith | but it's a straight backport | 20:23 |
patrickeast__ | oh man, i thought we backported it already | 20:23 |
jgriffith | patrickeast: yeah, me too :( | 20:23 |
*** sdake_ has joined #openstack-cinder | 20:23 | |
*** zzzeek has quit IRC | 20:23 | |
*** sage__ has quit IRC | 20:23 | |
*** jroll has quit IRC | 20:23 | |
*** vkmc has quit IRC | 20:23 | |
smcginnis | jgriffith: Hmm, we should probably have had a DocImpact tag on that one. | 20:23 |
jgriffith | patrickeast: but I had some interference getting it to land in master that slowed things down a bit | 20:23 |
*** j_king has joined #openstack-cinder | 20:23 | |
smcginnis | Oh well | 20:23 |
jgriffith | smcginnis: garrrr | 20:23 |
*** jroll has joined #openstack-cinder | 20:23 | |
*** jroll has quit IRC | 20:23 | |
*** jroll has joined #openstack-cinder | 20:23 | |
*** patrickeast has quit IRC | 20:23 | |
*** mkoderer__ has quit IRC | 20:24 | |
*** e0ne has quit IRC | 20:24 | |
*** asselin_ has joined #openstack-cinder | 20:24 | |
*** sdake has quit IRC | 20:24 | |
*** rlrossit has quit IRC | 20:24 | |
*** zul has quit IRC | 20:24 | |
*** aspiers has quit IRC | 20:24 | |
*** jungleboyj_ has joined #openstack-cinder | 20:24 | |
smcginnis | At least the release note is good. | 20:24 |
*** patrickeast__ is now known as patrickeast | 20:24 | |
jgriffith | smcginnis: You want me to update the commit on the backport at least? | 20:24 |
*** _alastor_ has joined #openstack-cinder | 20:24 | |
smcginnis | And it's targeted to a specific case | 20:24 |
*** vkmc has joined #openstack-cinder | 20:24 | |
jgriffith | smcginnis: yeah, I mean how much docs do we needs :) | 20:24 |
*** gouthamr_ has quit IRC | 20:24 | |
*** pkoniszewski has joined #openstack-cinder | 20:24 | |
smcginnis | jgriffith: I guess I'm fine either way. | 20:24 |
*** sage__ has joined #openstack-cinder | 20:24 | |
*** gouthamr has joined #openstack-cinder | 20:24 | |
*** Apoorva has joined #openstack-cinder | 20:25 | |
*** aspiers has joined #openstack-cinder | 20:25 | |
*** swamireddy has joined #openstack-cinder | 20:25 | |
hemna | patrickeast, back | 20:26 |
jgriffith | smcginnis: I updated | 20:26 |
*** wxy__ has joined #openstack-cinder | 20:26 | |
smcginnis | jgriffith: Cool, thanks. | 20:26 |
jgriffith | certainly | 20:26 |
*** logan- has joined #openstack-cinder | 20:26 | |
*** jschwarz has joined #openstack-cinder | 20:26 | |
patrickeast | hemna: :D how much scrollback do you have? | 20:27 |
*** flip214 has joined #openstack-cinder | 20:27 | |
*** flip214 has quit IRC | 20:27 | |
*** flip214 has joined #openstack-cinder | 20:27 | |
*** sam64_ has quit IRC | 20:27 | |
smcginnis | Would be awesome if folks would stop DoSing freenode. :[ | 20:27 |
patrickeast | smcginnis: +1 | 20:27 |
*** sam64 has joined #openstack-cinder | 20:27 | |
jgriffith | smcginnis: +A | 20:27 |
*** zzzeek has joined #openstack-cinder | 20:27 | |
jgriffith | smcginnis: patrickeast can't we all just get along | 20:28 |
smcginnis | Maybe someone's not happy that their patch didn't land. :D | 20:28 |
patrickeast | hah | 20:28 |
jgriffith | smcginnis: huh... well that's a thing I guess | 20:29 |
sbezverk_ | jgriffith: when it is merged it will be in cinder's tarball right away or tomorrow? | 20:29 |
hemna | patrickeast, so, after a disconnect_volume call, and a cinder terminate_connection call, we potentially get another os_brick.connect_volume call that induces an iscsi rescan? | 20:29 |
hemna | which would then bring those volumes back | 20:30 |
*** viks has quit IRC | 20:30 | |
patrickeast | hemna: so the order is like disconnect_volume(A), connect_volume(B), rescan, terminate_connection(A) | 20:30 |
hemna | yah | 20:30 |
*** Apoorva_ has joined #openstack-cinder | 20:30 | |
hemna | so I think the only way we can be safe there, is to change the order of operations | 20:30 |
hemna | call terminate_connection(a), disconnect_volume(a) | 20:31 |
patrickeast | hemna: is that safe? what about flushing and all that? | 20:31 |
hemna | cinder will remove the export from the backend first. | 20:31 |
patrickeast | i guess its like disconnect from vm, flush paths, terminate connection, disconnect volume? | 20:31 |
hemna | I think the volume is already removed from the instance at that point | 20:31 |
hemna | before calling brick | 20:32 |
patrickeast | it is when we call disconnect volume | 20:32 |
*** ntpttr has quit IRC | 20:32 | |
hemna | we could add a flush io api to brick | 20:32 |
patrickeast | so the problem (or part of it) is looking through where we do terminate connection its like in a different layer than where the disconnect happens | 20:32 |
hemna | to force any transient io out | 20:32 |
*** AndyWojo has quit IRC | 20:32 | |
*** jschwarz has quit IRC | 20:32 | |
*** serverascode has quit IRC | 20:32 | |
*** aspiers has quit IRC | 20:32 | |
*** briancurtin has quit IRC | 20:32 | |
*** guitarzan has quit IRC | 20:32 | |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Fix Cinder migrate_volume_completion https://review.openstack.org/377945 | 20:32 |
patrickeast | its in like the nova virt driver destroy iirc | 20:32 |
patrickeast | and the terminate comes from the like manager later on after the destroy | 20:32 |
*** jamespd_ has quit IRC | 20:33 | |
*** jamespd has joined #openstack-cinder | 20:33 | |
*** Apoorva has quit IRC | 20:33 | |
*** vkmc has quit IRC | 20:33 | |
*** jroll has quit IRC | 20:33 | |
*** tbarron has quit IRC | 20:33 | |
patrickeast | so we’d need to rearrange some stuff over there | 20:33 |
*** jschwarz has joined #openstack-cinder | 20:33 | |
hemna | yup | 20:33 |
*** tbarron has joined #openstack-cinder | 20:33 | |
*** flip214 has quit IRC | 20:33 | |
*** guitarzan has joined #openstack-cinder | 20:33 | |
patrickeast | jgriffith: which i guess is where your new changes for the nova side of things comes in :D | 20:33 |
*** flip214 has joined #openstack-cinder | 20:33 | |
*** flip214 has quit IRC | 20:33 | |
*** flip214 has joined #openstack-cinder | 20:33 | |
*** ntpttr has joined #openstack-cinder | 20:33 | |
jgriffith | patrickeast: :) | 20:34 |
*** jroll has joined #openstack-cinder | 20:34 | |
*** jroll has quit IRC | 20:34 | |
*** jroll has joined #openstack-cinder | 20:34 | |
jgriffith | patrickeast: hemna that doesn't cause problems for *something* does it? | 20:34 |
patrickeast | oh no doubt | 20:34 |
*** vkmc has joined #openstack-cinder | 20:34 | |
* patrickeast glances at the remotefs backends | 20:34 | |
hemna | yah I'm not sure actually | 20:35 |
patrickeast | jgriffith: as much as i don’t want to double down on snowflakes, it might be something where we could give hints to nova (or whoever) on how they should disconnect | 20:35 |
patrickeast | jgriffith: at a more fine grained level than rbd, or iscsi | 20:36 |
*** aspiers has joined #openstack-cinder | 20:36 | |
jgriffith | patrickeast: sigh.... but frankly, isn't that what brick is supposed to do for us? | 20:36 |
patrickeast | jgriffith: probably | 20:36 |
jgriffith | patrickeast: abstract out the customization for things like initiatlize/terminate | 20:36 |
patrickeast | jgriffith: i guess it comes down to extending what brick does then | 20:36 |
patrickeast | jgriffith: if we put the terminate_connection calls and stuff into it, then yea totally | 20:37 |
jgriffith | patrickeast: so create a new driver_type for brick like "iscsi-shared" or something | 20:37 |
hemna | so one thing is that os-brick does a blind rescan | 20:37 |
*** zul has joined #openstack-cinder | 20:37 | |
hemna | regardless of the # of sessions it has | 20:37 |
jgriffith | hemna: don't do that :) | 20:37 |
hemna | heh | 20:37 |
hemna | it's been that way for ages | 20:37 |
hemna | we could somehow get the session id for the target_portal in question | 20:37 |
hemna | and only rescan that | 20:37 |
patrickeast | hemna: well, even if we target them to a specific session if there are multiple luns sharing one its the “right” thing to do, but same problem | 20:37 |
jgriffith | hemna: I know, I'm pretty sure this has come up before... like last year or something | 20:37 |
hemna | but that still leaves the race for that portal | 20:37 |
*** rhagarty_ has joined #openstack-cinder | 20:38 | |
patrickeast | what i’m wondering is if maybe we just say screw it, assume we can’t cleanly disconnect | 20:38 |
patrickeast | and look more at our attachment code to see if we can make it work better if it starts on a borked system | 20:38 |
*** jklare has quit IRC | 20:38 | |
patrickeast | in theory if brick had a list of paths it knew 100% were not valid anymore | 20:39 |
patrickeast | it can just rescan, and clean them up again | 20:39 |
*** DuncanT has joined #openstack-cinder | 20:39 | |
patrickeast | like, as a sysadmin attaching volumes | 20:39 |
hemna | brick currently is stateless | 20:39 |
patrickeast | if i did a rescan and saw them come back thats how i would fix it | 20:39 |
hemna | the problem is that the next attach, those paths could be valid | 20:39 |
patrickeast | hemna: yep, which is a problem | 20:39 |
hemna | and we don't want to nuke em | 20:40 |
patrickeast | hemna: hmm true | 20:40 |
patrickeast | hemna: i wonder if we can check the scsi id on them or something to see how valid they are | 20:40 |
hemna | what to do in the case where someone is attaching that same volume to another instance | 20:41 |
hemna | :( | 20:41 |
hemna | the wwn would be valid | 20:41 |
patrickeast | cry a little on the inside? | 20:41 |
*** unrahul has joined #openstack-cinder | 20:41 | |
patrickeast | well | 20:41 |
hemna | :P | 20:41 |
hemna | so | 20:42 |
patrickeast | i guess its possible some backends would have another attachment for the same volume? | 20:42 |
patrickeast | but why wouldn’t they just be the same /dev/sdX’s | 20:42 |
patrickeast | ?* | 20:42 |
hemna | when we do connect_volume, I return the scsi wwn along with everything else. | 20:42 |
*** jklare has joined #openstack-cinder | 20:42 | |
hemna | udev controls what /dev/sdX is created | 20:42 |
hemna | and that's not guaranteed to be the same value | 20:42 |
smcginnis | patrickeast: If it's the same volume over the same path it would be the same sdX. | 20:43 |
hemna | hence the entire reason for using scsi_id in the linux scsi subsystem | 20:43 |
*** rajinir has joined #openstack-cinder | 20:43 | |
*** eharney has quit IRC | 20:43 | |
*** serverascode has joined #openstack-cinder | 20:43 | |
smcginnis | But if it's over a different path it would end up different. | 20:43 |
hemna | smcginnis, not if another volume came along | 20:43 |
hemna | between the disconnect and attach | 20:43 |
patrickeast | maybe i give too much credit to udev and team | 20:43 |
hemna | udev is going to use the next avail | 20:43 |
*** zengyingzhe_ has quit IRC | 20:44 | |
hemna | this is the entire reason for using scsi wwn's | 20:44 |
smcginnis | patrickeast: Oh, different host. Sorry, read through too quick. | 20:44 |
smcginnis | Yeah, then no guarantee of sameness. | 20:44 |
*** patrickeast_ has quit IRC | 20:44 | |
*** asselin has joined #openstack-cinder | 20:44 | |
smcginnis | I was thinking multiple attaches on the same host. | 20:44 |
*** Anticimex has quit IRC | 20:44 | |
hemna | age old linux problem | 20:44 |
hemna | for mountpoints etc. | 20:44 |
*** jamespd_ has joined #openstack-cinder | 20:44 | |
smcginnis | +1 | 20:44 |
patrickeast | smcginnis: no wait, your right it is the same host | 20:44 |
*** rhagarty__ has joined #openstack-cinder | 20:44 | |
*** jdillaman1 has joined #openstack-cinder | 20:44 | |
*** frakt_ has quit IRC | 20:44 | |
*** zengyingzhe_ has joined #openstack-cinder | 20:44 | |
patrickeast | i think the problem is that the same volume could be presented as different sdx devices if attached again | 20:45 |
*** jamespd has quit IRC | 20:45 | |
*** dillaman has quit IRC | 20:45 | |
*** guitarzan has quit IRC | 20:45 | |
*** jungleboyj_ has quit IRC | 20:45 | |
*** asselin_ has quit IRC | 20:45 | |
*** diablo_rojo has quit IRC | 20:45 | |
smcginnis | patrickeast: OK, then if you're adding another attachment for the same volume on the same host, it should be the same. Assuming your storage works like mine with the same targets. | 20:45 |
*** jungleboyj__ has joined #openstack-cinder | 20:45 | |
smcginnis | patrickeast: Shouldn't be. | 20:45 |
patrickeast | smcginnis: yep, thats that i was thinking | 20:45 |
* hemna wonders if creating a python lib in front of libiscsi would help anything | 20:45 | |
patrickeast | but i guess i can’t speak for all backends | 20:45 |
*** diablo_rojo has joined #openstack-cinder | 20:45 | |
smcginnis | patrickeast: I think for us it's a noop basically, right? For mine if I'm asked to attach a volume to the same host it's already attached to I just return the existing info. | 20:46 |
smcginnis | hemna: I thought I saw the start of a library like that. | 20:46 |
*** DuncanT has quit IRC | 20:46 | |
*** swamireddy has quit IRC | 20:46 | |
*** sdake_ has quit IRC | 20:46 | |
*** jamielennox has quit IRC | 20:46 | |
*** rhagarty_ has quit IRC | 20:46 | |
*** vkmc has quit IRC | 20:46 | |
*** jroll has quit IRC | 20:46 | |
*** tbarron has quit IRC | 20:46 | |
*** sage__ has quit IRC | 20:46 | |
*** rha has quit IRC | 20:46 | |
*** krtaylor has quit IRC | 20:46 | |
*** Anticime1 has joined #openstack-cinder | 20:46 | |
*** guitarza1 has joined #openstack-cinder | 20:46 | |
*** tbarron has joined #openstack-cinder | 20:46 | |
*** jroll has joined #openstack-cinder | 20:46 | |
*** sage__ has joined #openstack-cinder | 20:46 | |
patrickeast | hemna: yea i was poking around a little bit at something like that, or python bindings for like libdevmapper | 20:46 |
*** krtaylor has joined #openstack-cinder | 20:46 | |
*** jroll is now known as Guest49945 | 20:46 | |
patrickeast | if we can cut out some of the hacky cli tricks we have to do it would be (maybe) easier to manage some of this stuff | 20:47 |
hemna | patrickeast, yah I think that might be worth hacking at | 20:47 |
hemna | maybe in my next job..... | 20:47 |
smcginnis | :) | 20:47 |
*** sdake has joined #openstack-cinder | 20:47 | |
*** briancurtin has joined #openstack-cinder | 20:47 | |
*** Guest49945 is now known as jroll|dupe | 20:47 | |
*** jroll|dupe has quit IRC | 20:47 | |
*** jroll|dupe has joined #openstack-cinder | 20:47 | |
hemna | https://github.com/sahlberg/libiscsi-python | 20:48 |
*** rha has joined #openstack-cinder | 20:48 | |
hemna | 2 years old..... | 20:48 |
*** swamireddy has joined #openstack-cinder | 20:48 | |
smcginnis | hemna: Don't know about all the "swig" business, but could be a start. | 20:49 |
hemna | yah | 20:49 |
*** vkmc has joined #openstack-cinder | 20:50 | |
*** xyang has joined #openstack-cinder | 20:50 | |
*** jamielennox has joined #openstack-cinder | 20:51 | |
*** xyang has quit IRC | 20:51 | |
*** pkoraca has joined #openstack-cinder | 20:53 | |
hemna | patrickeast, https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L410-L412 | 20:53 |
*** AndyWojo has joined #openstack-cinder | 20:53 | |
hemna | that comment is....suspect | 20:53 |
jgriffith | smcginnis: from somebody that did a lot of swig in a past life, "DON"T DO IT" | 20:53 |
patrickeast | lol | 20:53 |
*** xyang has joined #openstack-cinder | 20:53 | |
smcginnis | :) | 20:53 |
hemna | and the funny thing is, rescan looks like it happens twice | 20:53 |
smcginnis | jgriffith: Never had to touch it. | 20:54 |
hemna | https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L204 | 20:54 |
jgriffith | smcginnis: awesome idea/concept, and works great for the more trivial cases | 20:54 |
openstackgerrit | Xinli Guan proposed openstack/cinder: qos_specs: Correcting the qos_specs format https://review.openstack.org/378028 | 20:54 |
*** jroll|dupe is now known as jroll | 20:54 | |
jgriffith | smcginnis: it gets kinda gnarly depending on how much OO you have in your domain | 20:54 |
jgriffith | smcginnis: hard to debug | 20:55 |
*** frakt has joined #openstack-cinder | 20:55 | |
smcginnis | Hah: "for the most trivial cases" <- probably not a good fit for us. We don't do anything trivial. :D | 20:55 |
*** DuncanT has joined #openstack-cinder | 20:57 | |
hemna | patrickeast, I'm going to remove line 412 | 20:58 |
*** manjeets has joined #openstack-cinder | 20:59 | |
*** patrickeast_ has joined #openstack-cinder | 20:59 | |
*** Apoorva has joined #openstack-cinder | 21:02 | |
*** akapil has joined #openstack-cinder | 21:02 | |
*** eharney has joined #openstack-cinder | 21:04 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Remove the duplicate calls to rescan https://review.openstack.org/378033 | 21:05 |
hemna | patrickeast, ^^ | 21:05 |
*** lpetrut has quit IRC | 21:05 | |
*** Apoorva_ has quit IRC | 21:05 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: 3PAR use OSLO versioned Object for volume https://review.openstack.org/339147 | 21:05 |
patrickeast | sweet | 21:05 |
hemna | so that just gets us to a single rescan call | 21:06 |
hemna | so that issue still exists | 21:06 |
* hemna wonders if we just removed iscsi_rescan entirely ? | 21:07 | |
patrickeast | mm | 21:08 |
patrickeast | i think its needed | 21:08 |
patrickeast | well | 21:08 |
patrickeast | at least when i tested | 21:08 |
*** xyang has quit IRC | 21:14 | |
karthikp | Please could somebody review this : https://review.openstack.org/#/c/332480/ ?? | 21:14 |
hemna | patrickeast, https://github.com/open-iscsi/open-iscsi/blob/master/usr/iscsiadm.c#L756-L778 | 21:14 |
*** xyang has joined #openstack-cinder | 21:15 | |
*** patrickeast has quit IRC | 21:15 | |
*** patrickeast_ is now known as patrickeast | 21:16 | |
*** xyang has quit IRC | 21:17 | |
*** akapil has quit IRC | 21:20 | |
*** sdake has quit IRC | 21:22 | |
*** kmartin has joined #openstack-cinder | 21:22 | |
hemna | ok well that was fruitless | 21:22 |
hemna | patrickeast, smcginnis http://paste.openstack.org/show/583169/ | 21:23 |
patrickeast | :( | 21:23 |
smcginnis | hemna: Ship it. | 21:23 |
*** mikal_ is now known as mikal | 21:29 | |
*** cknight has joined #openstack-cinder | 21:32 | |
*** gouthamr has quit IRC | 21:33 | |
*** cknight1 has joined #openstack-cinder | 21:35 | |
patrickeast | oo this stackviz thing is pretty cool | 21:36 |
patrickeast | i wonder how long jenkins has been doing this | 21:37 |
smcginnis | patrickeast: That's part of jenkins now? | 21:37 |
hemna | stackviz ? | 21:38 |
*** cknight has quit IRC | 21:38 | |
smcginnis | hemna: https://github.com/openstack/stackviz | 21:38 |
smcginnis | Cool idea | 21:39 |
hemna | analyze the performance of devstack setup ? | 21:40 |
*** Apoorva has quit IRC | 21:44 | |
patrickeast | smcginnis: hemna: yea http://logs.openstack.org/86/366686/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/8f04b42/logs/stackviz/#/stdin/timeline | 21:45 |
*** Apoorva has joined #openstack-cinder | 21:45 | |
patrickeast | i added in the nodepool element for it, and now my ci does it too | 21:45 |
hemna | ah nice | 21:45 |
patrickeast | was amazed at how much it just kinda worked without any config http://openstack-logs.purestorage.com/86/366686/4/check/PureISCSIDriver-tempest-dsvm-trusty-mn-multipath/79db9e4/logs/stackviz/#/stdin | 21:46 |
patrickeast | http://openstack-logs.purestorage.com/86/366686/4/check/PureISCSIDriver-tempest-dsvm-trusty-mn-multipath/79db9e4/logs/stackviz/#/stdin/timeline | 21:46 |
patrickeast | not sure just how helpful it is, but sure is a pretty graph | 21:46 |
smcginnis | patrickeast: Would be good if you could drill down into more details. | 21:46 |
patrickeast | smcginnis: yea i guess for now its just tempest logs | 21:48 |
*** tonyb_ is now known as tonyb | 21:56 | |
*** xyang has joined #openstack-cinder | 21:57 | |
*** nherciu_ has quit IRC | 21:58 | |
sbezverk_ | jgriffith: sorry to bug you, that config parameter to ignore message, which section it goes under? | 21:59 |
*** kaisers2 has quit IRC | 21:59 | |
*** kaisers1 has joined #openstack-cinder | 21:59 | |
jgriffith | sbezverk_: needs to go under the driver section | 22:00 |
jgriffith | sbezverk_: which I guess is kind of annoying with multiple LVM backends | 22:00 |
*** sdague has quit IRC | 22:02 | |
patrickeast | if only we had some sort of default section | 22:03 |
openstackgerrit | Karthik Prabhu Vinod proposed openstack/cinder: Fix for resource field length in database for quota tables https://review.openstack.org/375179 | 22:08 |
patrickeast | a;klajsdf | 22:10 |
patrickeast | hemna: found a new fun trick while testing out those changes for os-brick to stop rescanning things | 22:10 |
patrickeast | hemna: somehow by the end of tempest i had 1 iscsi session still up | 22:11 |
*** alonma has joined #openstack-cinder | 22:11 | |
hemna | hrmm | 22:11 |
hemna | still up ? | 22:11 |
patrickeast | the other 3 were logged out | 22:11 |
patrickeast | yea uhh one sec | 22:12 |
*** mriedem has quit IRC | 22:12 | |
*** ccesario has quit IRC | 22:12 | |
*** haplo37- has quit IRC | 22:12 | |
jgriffith | patrickeast: lol | 22:13 |
*** delattec has joined #openstack-cinder | 22:13 | |
patrickeast | jgriffith: it like never ends | 22:13 |
*** xyang has quit IRC | 22:13 | |
jgriffith | patrickeast: the gift that keeps on giving :) | 22:14 |
jgriffith | patrickeast: but didn't somebody figure out a fix for that? | 22:14 |
*** haplo37- has joined #openstack-cinder | 22:14 | |
patrickeast | jgriffith: at least once before | 22:14 |
jgriffith | haha | 22:15 |
patrickeast | jgriffith: and i'm sure we'll be fixing it again | 22:15 |
*** salv-orlando has quit IRC | 22:15 | |
*** alonma has quit IRC | 22:15 | |
patrickeast | hemna: so like, that one session looks perfectly happy | 22:15 |
*** cdelatte has quit IRC | 22:16 | |
*** alonma has joined #openstack-cinder | 22:18 | |
*** thingee has joined #openstack-cinder | 22:22 | |
*** Guest45789 is now known as med_ | 22:22 | |
*** Julien-zte has quit IRC | 22:22 | |
*** med_ has quit IRC | 22:23 | |
*** med_ has joined #openstack-cinder | 22:23 | |
*** alonma has quit IRC | 22:23 | |
*** salv-orlando has joined #openstack-cinder | 22:23 | |
openstackgerrit | John Griffith proposed openstack/python-cinderclient: Add new attach/detach API calls https://review.openstack.org/327409 | 22:23 |
openstackgerrit | John Griffith proposed openstack/cinder: Add new attach/detach API calls https://review.openstack.org/327408 | 22:23 |
*** ccesario has joined #openstack-cinder | 22:24 | |
*** mtanino has joined #openstack-cinder | 22:29 | |
*** rooneym has quit IRC | 22:29 | |
*** diablo_rojo has quit IRC | 22:32 | |
*** jungleboyj__ has quit IRC | 22:37 | |
*** salv-orlando has quit IRC | 22:46 | |
*** frontrunner2 has quit IRC | 22:47 | |
*** akerr_ has quit IRC | 22:48 | |
*** sbezverk has joined #openstack-cinder | 22:50 | |
*** sbezverk_ has quit IRC | 22:54 | |
*** sdake has joined #openstack-cinder | 22:56 | |
*** sdake_ has joined #openstack-cinder | 22:58 | |
*** cknight1 has quit IRC | 23:00 | |
*** nicolasbock has quit IRC | 23:01 | |
*** sdake has quit IRC | 23:01 | |
*** nicolasbock has joined #openstack-cinder | 23:02 | |
*** sticker_ has joined #openstack-cinder | 23:10 | |
*** sticker_ is now known as sticker | 23:11 | |
*** markvoelker has quit IRC | 23:19 | |
*** lprice has joined #openstack-cinder | 23:28 | |
*** lprice1 has quit IRC | 23:28 | |
*** leeantho has quit IRC | 23:33 | |
*** gershon__ has quit IRC | 23:37 | |
*** ducttape_ has joined #openstack-cinder | 23:41 | |
*** ducttape_ has quit IRC | 23:44 | |
*** EinstCrazy has joined #openstack-cinder | 23:47 | |
*** cdelatte has joined #openstack-cinder | 23:48 | |
*** EinstCrazy has quit IRC | 23:48 | |
*** mtanino has quit IRC | 23:49 | |
*** frontrunner has joined #openstack-cinder | 23:49 | |
*** gershon_ has quit IRC | 23:50 | |
*** delattec has quit IRC | 23:50 | |
*** gershon has quit IRC | 23:51 | |
*** salv-orlando has joined #openstack-cinder | 23:53 | |
*** ducttape_ has joined #openstack-cinder | 23:57 | |
*** salv-orlando has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!