*** mriedem has quit IRC | 00:01 | |
*** itlinux has joined #openstack-cinder | 00:11 | |
*** itlinux has quit IRC | 00:11 | |
*** Liang__ has joined #openstack-cinder | 00:16 | |
*** markguz_ has quit IRC | 00:36 | |
*** dklyle has joined #openstack-cinder | 00:53 | |
*** brinzhang has joined #openstack-cinder | 01:08 | |
*** dave-mccowan has joined #openstack-cinder | 01:17 | |
*** hedvig_01 has quit IRC | 01:20 | |
*** lixiaoy1 has joined #openstack-cinder | 01:21 | |
lixiaoy1 | jungleboyj: smcginnis eharney could you help to have a look at our rsd driver https://review.openstack.org/#/c/621465/ ? anything we missed? | 01:25 |
---|---|---|
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Add policy configuration howto https://review.openstack.org/624424 | 01:54 |
*** bhagyashris has joined #openstack-cinder | 01:56 | |
*** Dinesh_Bhor has joined #openstack-cinder | 01:59 | |
*** Dinesh_Bhor has quit IRC | 02:09 | |
*** Dinesh_Bhor has joined #openstack-cinder | 02:10 | |
*** dave-mccowan has quit IRC | 02:14 | |
*** itlinux has joined #openstack-cinder | 02:17 | |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Add policy configuration howto https://review.openstack.org/624424 | 02:18 |
*** mhen has quit IRC | 02:27 | |
*** mhen has joined #openstack-cinder | 02:28 | |
openstackgerrit | LisaLi proposed openstack/cinder master: Driver reinitialization after failure https://review.openstack.org/618702 | 02:37 |
openstackgerrit | LisaLi proposed openstack/cinder-specs master: nitialization after failure https://review.openstack.org/624853 | 03:09 |
openstackgerrit | LisaLi proposed openstack/cinder-specs master: Driver reinitialization after failure https://review.openstack.org/624853 | 03:14 |
*** dklyle has quit IRC | 03:22 | |
*** brinzhang has quit IRC | 03:28 | |
openstackgerrit | Merged openstack/cinder master: VMware: Check empty provider location https://review.openstack.org/604462 | 03:45 |
*** itlinux has quit IRC | 04:11 | |
*** khomesh has joined #openstack-cinder | 04:16 | |
openstackgerrit | Merged openstack/cinder stable/rocky: SF ensure the correct volume is deleted https://review.openstack.org/623036 | 04:20 |
*** itlinux has joined #openstack-cinder | 04:43 | |
*** udesale has joined #openstack-cinder | 04:49 | |
*** bhagyashris has quit IRC | 05:01 | |
*** itlinux has quit IRC | 05:11 | |
*** _alastor_ has joined #openstack-cinder | 05:24 | |
*** Liang__ is now known as LiangFang | 05:29 | |
*** bhagyashris has joined #openstack-cinder | 05:52 | |
whoami-rajat | enriquetaso I've put up the fix for the openstackclient bug, https://review.openstack.org/#/c/624860/ . Kindly check. | 05:56 |
openstackgerrit | LisaLi proposed openstack/cinder master: Driver reinitialization after failure https://review.openstack.org/618702 | 06:02 |
openstackgerrit | LisaLi proposed openstack/cinder master: Driver reinitialization after failure https://review.openstack.org/618702 | 06:05 |
*** _alastor_ has quit IRC | 06:20 | |
openstackgerrit | Liang Fang proposed openstack/cinder master: Handle image download and conversion errors https://review.openstack.org/618976 | 06:39 |
*** _alastor_ has joined #openstack-cinder | 06:40 | |
openstackgerrit | Brin Zhang proposed openstack/cinder master: api-ref: Fix the parameters of update volume type interface's response https://review.openstack.org/624865 | 06:52 |
*** _alastor_ has quit IRC | 06:59 | |
*** rcernin has quit IRC | 07:09 | |
*** pcaruana has joined #openstack-cinder | 07:12 | |
*** yikun has quit IRC | 07:20 | |
*** Luzi has joined #openstack-cinder | 07:33 | |
*** _alastor_ has joined #openstack-cinder | 07:35 | |
lixiaoy1 | eharney: abishop: please help to review the updated spec for driver reinitialization. https://review.openstack.org/#/c/624853/ and its implementation is here https://review.openstack.org/#/c/618702/ | 07:36 |
*** _alastor_ has quit IRC | 07:40 | |
openstackgerrit | Woojay Poynter proposed openstack/cinder master: Update DRBD (drbdmanagedrv) Driver to LINSTOR (linstordrv) https://review.openstack.org/624233 | 07:47 |
*** dklyle has joined #openstack-cinder | 08:07 | |
*** _alastor_ has joined #openstack-cinder | 08:08 | |
openstackgerrit | Woojay Poynter proposed openstack/cinder master: Update DRBD (drbdmanagedrv) Driver to LINSTOR (linstordrv) https://review.openstack.org/624233 | 08:08 |
*** _alastor_ has quit IRC | 08:12 | |
*** imacdonn has quit IRC | 08:23 | |
*** imacdonn has joined #openstack-cinder | 08:24 | |
*** dklyle has quit IRC | 08:27 | |
openstackgerrit | Yingxin Cheng proposed openstack/os-brick master: Support RSD scenario of nvme connector https://review.openstack.org/620250 | 08:31 |
*** Dinesh_Bhor has quit IRC | 08:31 | |
*** Dinesh_Bhor has joined #openstack-cinder | 08:32 | |
*** brinzhang has joined #openstack-cinder | 08:45 | |
*** brinzh has joined #openstack-cinder | 08:48 | |
*** brinzhang has quit IRC | 08:50 | |
openstackgerrit | Yingxin Cheng proposed openstack/cinder master: [wip] Cinder RSD Driver https://review.openstack.org/621465 | 08:57 |
openstackgerrit | Yingxin Cheng proposed openstack/cinder master: [wip] Cinder RSD Driver https://review.openstack.org/621465 | 08:59 |
*** alkhodos has quit IRC | 09:06 | |
*** alkhodos has joined #openstack-cinder | 09:06 | |
*** arne_wiebalck has quit IRC | 09:14 | |
*** arne_wiebalck_ has joined #openstack-cinder | 09:14 | |
*** trident has quit IRC | 09:16 | |
*** trident has joined #openstack-cinder | 09:19 | |
*** dcdamien has joined #openstack-cinder | 09:29 | |
*** sayalilunkad has quit IRC | 09:31 | |
*** luizbag has joined #openstack-cinder | 09:39 | |
*** e0ne has joined #openstack-cinder | 09:41 | |
openstackgerrit | Brin Zhang proposed openstack/cinder master: api-ref: Fix the parameter of update volume type interface's response https://review.openstack.org/624865 | 09:42 |
*** markvoelker has joined #openstack-cinder | 09:46 | |
*** bhagyashris has quit IRC | 09:47 | |
*** ganso has joined #openstack-cinder | 10:06 | |
*** mpasserini1 has joined #openstack-cinder | 10:11 | |
*** trident has quit IRC | 10:15 | |
*** trident has joined #openstack-cinder | 10:15 | |
*** helenafm has joined #openstack-cinder | 10:16 | |
*** mvkr has quit IRC | 10:24 | |
*** sayalilunkad has joined #openstack-cinder | 10:35 | |
*** mvkr has joined #openstack-cinder | 10:56 | |
*** LiangFang has quit IRC | 11:03 | |
*** mvkr has quit IRC | 11:16 | |
*** mvkr has joined #openstack-cinder | 11:16 | |
*** _alastor_ has joined #openstack-cinder | 11:25 | |
*** _alastor_ has quit IRC | 11:30 | |
*** tobias-urdin is now known as tobias-urdin_afk | 11:41 | |
*** tobias-urdin_afk is now known as tobias-urdin | 11:42 | |
*** tobias-urdin is now known as tobias-urdin_afk | 11:43 | |
*** Dinesh_Bhor has quit IRC | 12:14 | |
*** helenafm has quit IRC | 12:17 | |
openstackgerrit | Dou Rui Yuan proposed openstack/os-brick master: Fix create ceph conf failed when cephx disable https://review.openstack.org/624969 | 12:23 |
*** eharney has quit IRC | 12:24 | |
*** markvoelker has quit IRC | 12:24 | |
*** udesale has quit IRC | 12:25 | |
*** udesale has joined #openstack-cinder | 12:26 | |
openstackgerrit | Dmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Fix _per_gb_min usage with _per_gb https://review.openstack.org/624970 | 12:28 |
*** brinzh has quit IRC | 12:32 | |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: Add policy test for volume create policy https://review.openstack.org/617542 | 12:36 |
openstackgerrit | Ghanshyam Mann proposed openstack/cinder master: Add irrelevant-files for integrated test jobs https://review.openstack.org/624975 | 12:36 |
openstackgerrit | Yikun Jiang proposed openstack/cinder master: Add policy test for volume create policy https://review.openstack.org/617542 | 12:37 |
openstackgerrit | Ghanshyam Mann proposed openstack/cinder master: Add irrelevant-files for integrated test jobs https://review.openstack.org/624975 | 12:38 |
*** mriedem has joined #openstack-cinder | 12:42 | |
openstackgerrit | Maciej Szwed proposed openstack/cinder master: Adding SPDK volume driver https://review.openstack.org/564229 | 12:42 |
openstackgerrit | Maciej Szwed proposed openstack/cinder master: SPDK drivers documentation https://review.openstack.org/609276 | 12:42 |
openstackgerrit | LisaLi proposed openstack/cinder-specs master: Driver reinitialization after failure https://review.openstack.org/624853 | 12:49 |
*** e0ne has quit IRC | 12:51 | |
*** tobias-urdin_afk is now known as tobias-urdin | 12:53 | |
*** abishop has joined #openstack-cinder | 12:54 | |
*** markvoelker has joined #openstack-cinder | 13:10 | |
*** eharney has joined #openstack-cinder | 13:16 | |
openstackgerrit | LisaLi proposed openstack/cinder master: Driver reinitialization after failure https://review.openstack.org/618702 | 13:17 |
*** lixiaoy1 has quit IRC | 13:18 | |
*** zul has quit IRC | 13:32 | |
*** e0ne has joined #openstack-cinder | 13:35 | |
*** zul has joined #openstack-cinder | 13:40 | |
openstackgerrit | Jay Rubenstein proposed openstack/cinder master: SF: Handle qos values on extend volume https://review.openstack.org/606959 | 13:40 |
*** e0ne has quit IRC | 13:49 | |
*** helenafm has joined #openstack-cinder | 13:52 | |
*** Liang__ has joined #openstack-cinder | 13:54 | |
*** e0ne has joined #openstack-cinder | 13:57 | |
*** Liang__ is now known as LiangFang | 13:59 | |
*** irclogbot_0 has quit IRC | 14:00 | |
*** markvoelker has quit IRC | 14:03 | |
*** irclogbot_0 has joined #openstack-cinder | 14:08 | |
*** irclogbot_0 has quit IRC | 14:14 | |
*** mchlumsky has joined #openstack-cinder | 14:22 | |
*** irclogbot_0 has joined #openstack-cinder | 14:23 | |
enriquetaso | whoami-rajat: thanks!!! | 14:25 |
*** _alastor_ has joined #openstack-cinder | 14:33 | |
*** markvoelker has joined #openstack-cinder | 14:36 | |
*** _alastor_ has quit IRC | 14:38 | |
openstackgerrit | Dan Smith proposed openstack/cinder master: Synchronize all LVM operations https://review.openstack.org/624809 | 14:46 |
dansmith | mriedem: first patch passed so here's one we could keep if we decide ^ | 14:47 |
dansmith | here's one that would have run concurrently but waited for the lock: http://logs.openstack.org/09/624809/1/check/tempest-full/ee9862a/controller/logs/screen-c-vol.txt.gz#_Dec_12_21_50_37_005098 | 14:52 |
openstackgerrit | Francois Deppierraz proposed openstack/cinder master: cinder-volume: Stop masking IOError different than ENOSPC https://review.openstack.org/612393 | 14:53 |
openstackgerrit | Francois Deppierraz proposed openstack/cinder master: cinder-volume: Stop masking IOError different than ENOSPC https://review.openstack.org/612393 | 14:54 |
dansmith | there are several in there actually | 14:54 |
jungleboyj | dansmith: Would be really nice if that was the key. | 14:54 |
dansmith | yeah, the lock makes it easy to see that many things would be run concurrently, so it seems like a reasonable stab to take in the dark | 14:55 |
jungleboyj | :-) | 14:56 |
* mriedem is currently fighting in like 4 channels at once | 14:57 | |
jungleboyj | dansmith: So how do you think we should proceed with that patch? | 14:58 |
jungleboyj | Keep running it through and see how it fairs? | 14:59 |
noonedeadpunk | Folks, can you take a look at https://review.openstack.org/#/c/624970/ ? It's fixing min per_gb qos | 14:59 |
openstackgerrit | Francois Deppierraz proposed openstack/cinder master: cinder-volume: Stop masking IOError different than ENOSPC https://review.openstack.org/612393 | 14:59 |
noonedeadpunk | mnaser ^ it might be interesting for you, as an author (and probably you're using it in prod) | 15:00 |
dansmith | jungleboyj: I think it won't hurt anything, could help a lot, and we won't know for sure until we get it running at gate scale, so .. yeah I think it's worth putting it in and seeing what effect it has, if you guys are cool with it | 15:00 |
mriedem | dansmith: Dec 12 21:50:37.005098 ubuntu-bionic-vexxhost-sjc1-0001160633 cinder-volume[13331]: DEBUG oslo_concurrency.lockutils [None req-8373164f-7f9b-4a67-a02a-69aee338bcb5 tempest-ServersNegativeTestJSON-439819850 None] Lock "cinder-lvm-exec" acquired by "cinder.brick.local_dev.lvm._execute" :: waited 0.304s {{(pid=13442) inner /usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py:327}} also looks like the | 15:01 |
mriedem | est wait i see in there | 15:01 |
mriedem | .3 seconds | 15:01 |
mriedem | better than ~60 seconds... | 15:01 |
jungleboyj | Agreed. | 15:01 |
dansmith | mriedem: there's a half second wait in there to do an lv delete | 15:01 |
dansmith | but most are ~0.2ish seconds | 15:01 |
jungleboyj | mriedem: I would say, based on discussion yesterday, that this isn't hurting anything and it is the best guess we have at the moment. | 15:02 |
jungleboyj | If it causes other issues at scale, we can always roll it back. | 15:02 |
mriedem | yes, and we should know within a week of it's helped | 15:03 |
mriedem | b/c the e-r graph will go down | 15:03 |
mriedem | commented and +1 | 15:04 |
*** dpawlik has quit IRC | 15:06 | |
*** itlinux has joined #openstack-cinder | 15:06 | |
*** dpawlik has joined #openstack-cinder | 15:07 | |
*** dpawlik has quit IRC | 15:07 | |
mnaser | noonedeadpunk: that’s super bad if that’s the case. Are you able to add a test that shows that? | 15:08 |
noonedeadpunk | Had 2 disks, which are connected to the instance - 10Gb VDC and 200GB VDD: http://paste.openstack.org/show/737139/ | 15:09 |
noonedeadpunk | and qos limits http://paste.openstack.org/show/737138/ | 15:10 |
noonedeadpunk | Also, I'm going to add another patch, to remove conflict with %s_sec_max, as it's used with %_per_gb, and per_gb is higher, than max - instance will fail booting | 15:12 |
noonedeadpunk | But I don't know, how to do the best way - in addition to per_gb_min add per_gb_max, or rely on existing max options, so that the operator could set maximum available capacity, even if per_gb is used | 15:14 |
frickler | cinder might be broken on centos-7 with mysl5.6, see http://logs.openstack.org/86/624986/1/check/devstack-platform-centos-7/893f067/job-output.txt.gz#_2018-12-13_13_43_54_348189 and https://stackoverflow.com/questions/1814532/1071-specified-key-was-too-long-max-key-length-is-767-bytes | 15:21 |
*** mpasserini1 has quit IRC | 15:25 | |
noonedeadpunk | mnaser: so after this slight fix, and volume re-attach, it has right number of iops in virsh xml | 15:25 |
frickler | jungleboyj: smcginnis: dansmith: this is the patch that introduced the migration https://review.openstack.org/611530 | 15:33 |
*** markvoelker has quit IRC | 15:38 | |
*** dpawlik has joined #openstack-cinder | 15:40 | |
jungleboyj | frickler: Ugh. | 15:41 |
jungleboyj | That is not good. | 15:42 |
*** dpawlik has quit IRC | 15:44 | |
*** Luzi has quit IRC | 15:52 | |
*** morgan is now known as kmalloc | 16:09 | |
*** LiangFang has quit IRC | 16:16 | |
openstackgerrit | Sofia Enriquez proposed openstack/cinder stable/pike: ScaleIO Driver - adding cache and refactoring tests https://review.openstack.org/625041 | 16:19 |
*** eharney has quit IRC | 16:22 | |
*** eharney_ has joined #openstack-cinder | 16:22 | |
*** e0ne has quit IRC | 16:30 | |
*** e0ne has joined #openstack-cinder | 16:30 | |
*** _alastor_ has joined #openstack-cinder | 16:34 | |
*** markguz_ has joined #openstack-cinder | 16:40 | |
*** udesale has quit IRC | 16:41 | |
markguz_ | jungleboyj: i found another interesting problem. Not sure if it;s the zone manager or flashsystem driver. if i create two volumes and map them to the same vm. The first volume maps ok | 16:42 |
jungleboyj | markguz_: That is very odd. Do you have replication set in the extra specs or something? | 16:43 |
*** _alastor_ has quit IRC | 16:43 | |
markguz_ | the second fails to map. What i see in the log is that zone manager says "zone already present in I-T mode, not creating" and then the flashsystem driver never creates the vdiskhostmap to the second volume | 16:43 |
jungleboyj | So Cinder things there are two volumes but there is only one? | 16:44 |
markguz_ | jungleboyj: no there are two volumes. zonemanager says "i don't need to create another zone because there's already a zone in place", but then i would expect cinder to carry on and tell the flashsystem to create the vdisk->host map for the second volume | 16:45 |
markguz_ | but it never does and nova just times out the attachment process | 16:46 |
markguz_ | in short. I cannot map more than one volume from the same flashsystem to the same host | 16:47 |
openstackgerrit | Alan Bishop proposed openstack/cinder master: Fix A/A 'resource_backend' when scheduling volumes https://review.openstack.org/625052 | 16:47 |
markguz_ | jungleboyj: i feel like i'm doing something wrong because this seems pretty fundamental to me | 16:51 |
jungleboyj | Yeah. That should be a pretty fundamental function. I would think if that wasn't working someone would have seen it. | 16:52 |
markguz_ | indeed. not sure how to debug it | 16:53 |
*** eharney_ is now known as eharney | 16:53 | |
openstackgerrit | Merged openstack/os-brick stable/rocky: Tests: Add unit tests for nfs mount race https://review.openstack.org/623034 | 16:54 |
openstackgerrit | Merged openstack/os-brick stable/rocky: Fix NFS "already mounted" detection https://review.openstack.org/623035 | 16:54 |
whoami-rajat | jungleboyj: Hi Jay, can you take a look at this https://review.openstack.org/#/c/619676 . It will be easier for me to write the remaining tests if the base framework gets merged. Thanks. | 16:59 |
jungleboyj | Ok. Will take a look today. | 17:00 |
whoami-rajat | jungleboyj: Thanks ! | 17:03 |
*** helenafm has quit IRC | 17:07 | |
openstackgerrit | Dmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb https://review.openstack.org/625058 | 17:12 |
*** zul has quit IRC | 17:35 | |
*** ianychoi has quit IRC | 17:42 | |
*** dcdamien has quit IRC | 17:42 | |
dansmith | mriedem: jungleboyj smcginnis: at the end of the 4h window that it takes to get a vote on a patch, we'll see that the lvm-serialization patch failed a single glance test and needs to be rechecked | 17:51 |
smcginnis | Yeah, was tempted to abandon/restore to short circuit the recheck, but I'd like to see the tempest-full results. | 17:52 |
dansmith | yeah | 17:52 |
dansmith | actually it looks like that job is either stuck or zuul isn't updating its console for some reason | 17:54 |
dansmith | latest log entry is from 10m after it started | 17:54 |
* dansmith heads to infra | 17:54 | |
dansmith | smcginnis: it just finished, zero failed | 17:56 |
smcginnis | Looks like it's still running. | 17:59 |
*** erlon has joined #openstack-cinder | 18:01 | |
dansmith | it is, but it's cleaning up.. tempest succeeded was all I meant | 18:02 |
dansmith | not much use in short circuiting now I think | 18:02 |
dansmith | smcginnis: http://logs.openstack.org/09/624809/2/check/grenade-py3/151dee7/ | 18:03 |
dansmith | er | 18:03 |
dansmith | http://logs.openstack.org/09/624809/2/check/tempest-full/c399a0b/ | 18:03 |
*** e0ne has quit IRC | 18:11 | |
*** e0ne has joined #openstack-cinder | 18:15 | |
*** e0ne has quit IRC | 18:16 | |
*** _alastor_ has joined #openstack-cinder | 18:31 | |
*** markguz_ has quit IRC | 18:37 | |
*** _alastor_ has quit IRC | 18:39 | |
*** mvkr has quit IRC | 18:40 | |
*** dcdamien has joined #openstack-cinder | 18:45 | |
openstackgerrit | Merged openstack/os-brick stable/queens: Tests: Add unit tests for nfs mount race https://review.openstack.org/623237 | 18:47 |
*** jmlowe has quit IRC | 18:47 | |
openstackgerrit | Merged openstack/os-brick stable/queens: Fix NFS "already mounted" detection https://review.openstack.org/623238 | 18:56 |
*** jmlowe has joined #openstack-cinder | 19:12 | |
*** luizbag has quit IRC | 19:18 | |
*** eharney has quit IRC | 19:20 | |
*** mvkr has joined #openstack-cinder | 19:21 | |
*** N3l1x has joined #openstack-cinder | 19:24 | |
*** alkhodos has quit IRC | 19:24 | |
*** alkhodos has joined #openstack-cinder | 19:24 | |
*** N3l1x has quit IRC | 19:30 | |
dansmith | smcginnis: heh, now it failed a unit test (for unrelated reasons) | 19:36 |
*** N3l1x has joined #openstack-cinder | 19:39 | |
*** pcaruana has quit IRC | 19:47 | |
enriquetaso | whoami-rajat: I'm trying to get the " _info" inside VolumeBackupsRetore object (https://bugs.launchpad.net/python-openstackclient/+bug/1733315). I'm putting a LOG.info(backup) but I can't see it in c-api logs. Where should I look for it? | 19:51 |
openstack | Launchpad bug 1733315 in python-openstackclient "cinder-backup - CLI 'VolumeBackupsRestore' object is not iterable" [Undecided,Confirmed] - Assigned to Rajat Dhasmana (whoami-rajat) | 19:51 |
*** e0ne has joined #openstack-cinder | 19:53 | |
*** e0ne has quit IRC | 19:58 | |
*** erlon has quit IRC | 20:15 | |
*** eharney has joined #openstack-cinder | 20:24 | |
lbragstad | just double checking, but cinder is planning on having a team meeting next week, right? | 20:28 |
jungleboyj | lbragstad: Yes. | 20:28 |
lbragstad | cool | 20:28 |
lbragstad | i saw rosmaita's note http://lists.openstack.org/pipermail/openstack-discuss/2018-December/000875.html and wanted to swing by in case y'all end up talking about it again | 20:28 |
jungleboyj | lbragstad: Would you like us to discuss it? Do you have more input because we were kind-of flailing on the subject. | 20:32 |
jungleboyj | Just wondering if I should put it on the agneda. | 20:33 |
lbragstad | i posted a follow up here - http://lists.openstack.org/pipermail/openstack-discuss/2018-December/000916.html | 20:33 |
lbragstad | and we can certainly keep iterating on the thread, but i can make myself available during the cinder meeting if people what more synchronous communication | 20:34 |
rosmaita | lbragstad: so i completely missed all the default roles stuff happening in rocky | 20:35 |
lbragstad | rosmaita to be fair, it was keystone specific - we had to take the first step in order for others to start consuming it | 20:36 |
lbragstad | early in the cycle we were asking for feedback on naming, but that's about it | 20:36 |
rosmaita | from a quick look it seems like we could do some policy config on our side to take advantage of those in our default settings | 20:37 |
lbragstad | yeah - which is kinda related to the testing point you brought up | 20:37 |
lbragstad | (which came up in Denver, too) | 20:37 |
* jungleboyj is reading | 20:38 | |
lbragstad | rosmaita my response to you got a little long winded... but did the testing bit make sense? | 20:39 |
rosmaita | not sure, i need to look at the patches | 20:40 |
lbragstad | ack | 20:41 |
jungleboyj | lbragstad: Glad you got looped in. It looks like that may be a much safer approach for what rosmaita was shooting for. | 20:41 |
lbragstad | yeah - the testing stuff would be idea, but i also completely understand it's a lot of work | 20:41 |
lbragstad | (i'm hoping we can make it an incremental thing moving forward) | 20:42 |
lbragstad | but - if it makes you feel better, keystone isn't exempt from any of this... we're currently bolstering our own API protection testing as we implement those default roles https://review.openstack.org/#/q/status:open+project:openstack/keystone+branch:master+topic:implement-default-roles | 20:43 |
rosmaita | lbragstad: i will look at the patches, i have been reviewing Yikun Jiang's policy test patches, but haven't really figured out the strategy | 20:43 |
rosmaita | wxy left a comment for me that i need to look at your original patch, so i will | 20:44 |
lbragstad | oh - nice | 20:44 |
* lbragstad digs for a link | 20:44 | |
lbragstad | https://review.openstack.org/#/c/617542/ is one of them? | 20:45 |
rosmaita | yes, that's one | 20:45 |
rosmaita | wxy left a link to https://review.openstack.org/#/c/602489/ | 20:45 |
rosmaita | which i see you also mentioned in your email | 20:45 |
lbragstad | yep | 20:51 |
lbragstad | looking at yikun's patch quick | 20:52 |
*** psachin has joined #openstack-cinder | 20:52 | |
*** lpetrut has joined #openstack-cinder | 20:53 | |
*** ianychoi has joined #openstack-cinder | 20:59 | |
*** jmlowe has quit IRC | 21:01 | |
*** mriedem has quit IRC | 21:02 | |
*** markvoelker has joined #openstack-cinder | 21:11 | |
*** tpsilva has quit IRC | 21:12 | |
*** jmlowe has joined #openstack-cinder | 21:22 | |
*** ganso has quit IRC | 21:22 | |
*** mriedem has joined #openstack-cinder | 21:26 | |
*** jmlowe has quit IRC | 21:26 | |
*** psachin has quit IRC | 21:27 | |
*** tobias-urdin has quit IRC | 21:32 | |
*** hedvig_01 has joined #openstack-cinder | 21:40 | |
*** jmlowe has joined #openstack-cinder | 21:50 | |
*** lpetrut has quit IRC | 22:00 | |
*** N3l1x has quit IRC | 22:04 | |
*** dklyle has joined #openstack-cinder | 22:05 | |
*** abishop has quit IRC | 22:06 | |
*** markvoelker has quit IRC | 22:06 | |
*** david-lyle has joined #openstack-cinder | 22:09 | |
*** dklyle has quit IRC | 22:12 | |
*** rcernin has joined #openstack-cinder | 22:21 | |
*** david-lyle has quit IRC | 22:23 | |
imacdonn | Ouch .. I believe I just found a somewhat nasty bug in cinder ... it causes it to ignore the case where the an image downloaded from glance (CC rosmaita) fails checksum/hash verification | 22:26 |
imacdonn | when that happens, glanceclient throws a IOError with code EPIPE: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/utils.py#L466-L469 | 22:28 |
imacdonn | cinder catches the IOError, but ignores it unless it's a ENOSPC: https://github.com/openstack/cinder/blob/master/cinder/image/image_utils.py#L375-L387 | 22:28 |
eharney | imacdonn: i think this is being fixed here: https://review.openstack.org/#/c/612393/ | 22:29 |
eharney | definitely need to get that one in.. | 22:29 |
imacdonn | ahh, that looks right | 22:29 |
imacdonn | PS14? urgh | 22:29 |
eharney | there are some weird db errors on the py36 job... | 22:33 |
eharney | "Command out of sync" doesn't ring a bell for me | 22:33 |
imacdonn | yeah, I was just going to look at what failed .. seems it should be a straightforward fix | 22:33 |
eharney | and, uhy, more ceph job stuff for me to patch up. i turned on encryption test cases there, but the blacklist to turn off the unsupported tests in that job apparently only worked in the devstack-plugin-ceph jobs and not in the cinder runs | 22:35 |
*** itlinux has quit IRC | 22:36 | |
*** lbragstad has quit IRC | 22:37 | |
imacdonn | I think I'm going to recheck this, unless you object ... that DB error looks unrelated to the code changed | 22:39 |
eharney | i think it is unrelated | 22:39 |
imacdonn | oh, doh, smcginnis already recheck'ed it | 22:41 |
*** mchlumsky has quit IRC | 22:45 | |
*** dcdamien has quit IRC | 22:45 | |
*** noonedeadpunk has quit IRC | 23:02 | |
*** noonedeadpunk has joined #openstack-cinder | 23:03 | |
*** _alastor_ has joined #openstack-cinder | 23:30 | |
*** mriedem has quit IRC | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!