Friday, 2018-12-14

imacdonnCan anyone explain why ImageDownloadFailed uses "_msg_fmt", where all the others use "message"? https://github.com/openstack/cinder/blob/master/cinder/exception.py#L73100:20
imacdonnasking because _msg_fmt doesn't seem to work for me ... wonder if I'm missing something ...00:22
*** woojay has quit IRC00:25
*** Liang__ has joined #openstack-cinder00:25
*** Liang__ has quit IRC00:27
*** lixiaoy1 has joined #openstack-cinder00:29
*** erlon has joined #openstack-cinder00:33
lixiaoy1jungleboyj: ping00:35
*** brinzhang has joined #openstack-cinder00:48
openstackgerritiain MacDonnell proposed openstack/cinder master: Set message property in ImageDownloadFailed  https://review.openstack.org/62513500:58
*** jcosmao has quit IRC01:04
openstackgerritLisaLi proposed openstack/cinder-specs master: Driver reinitialization after failure  https://review.openstack.org/62485301:05
openstackgerritMerged openstack/cinder master: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62168601:17
*** psachin has joined #openstack-cinder01:30
*** Dinesh_Bhor has joined #openstack-cinder01:39
*** Dinesh_Bhor has quit IRC01:43
openstackgerritYikun Jiang proposed openstack/cinder master: Add policy test for volume create policy  https://review.openstack.org/61754201:59
*** Dinesh_Bhor has joined #openstack-cinder02:01
openstackgerritYikun Jiang proposed openstack/cinder master: Add policy test for volume create policy  https://review.openstack.org/61754202:03
openstackgerritYikun Jiang proposed openstack/cinder master: Add policy test for volume create policy  https://review.openstack.org/61754202:05
openstackgerritLisaLi proposed openstack/cinder master: Driver reinitialization after failure  https://review.openstack.org/61870202:08
*** bhagyashris has joined #openstack-cinder02:11
*** mhen has quit IRC02:26
*** sapd1_ has joined #openstack-cinder02:27
*** sapd1 has quit IRC02:29
*** mhen has joined #openstack-cinder02:30
openstackgerritYingxin Cheng proposed openstack/os-brick master: Support RSD scenario of nvme connector  https://review.openstack.org/62025002:35
*** dave-mccowan has joined #openstack-cinder02:38
*** itlinux has joined #openstack-cinder02:40
*** hedvig_01 has quit IRC02:42
*** Liang__ has joined #openstack-cinder02:53
*** Liang__ is now known as LiangFang02:56
openstackgerritDave McCowan proposed openstack/cinder stable/rocky: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62513902:56
openstackgerritDave McCowan proposed openstack/cinder stable/queens: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62514002:57
*** LiangFang has quit IRC03:02
openstackgerritYikun Jiang proposed openstack/cinder master: Add policy test for volume update/del policy  https://review.openstack.org/61754303:11
openstackgerritTommyLike proposed openstack/cinder master: Increase length limit on image metadata content  https://review.openstack.org/58673703:14
*** Liang__ has joined #openstack-cinder03:23
*** Liang__ is now known as LiangFang03:23
*** lbragstad has joined #openstack-cinder03:50
*** lbragstad has quit IRC03:51
*** Dinesh_Bhor has quit IRC03:52
*** brinzh has joined #openstack-cinder04:02
*** dave-mccowan has quit IRC04:03
*** brinzhang has quit IRC04:06
*** udesale has joined #openstack-cinder04:10
*** psachin has quit IRC04:10
*** lbragstad has joined #openstack-cinder04:13
*** Dinesh_Bhor has joined #openstack-cinder04:14
*** psachin has joined #openstack-cinder04:28
whoami-rajatenriquetaso:  Since 'backup' is a class reference, you can try the following way :04:37
whoami-rajatuse pdb in openstack client04:37
whoami-rajatview the object with the following syntax:04:37
whoami-rajatfrom pprint import pprint; pprint(vars(backup))04:37
*** woojay has joined #openstack-cinder04:41
*** _alastor_ has quit IRC04:54
*** bhagyashris has quit IRC05:01
*** Dinesh_Bhor has quit IRC05:01
*** _alastor_ has joined #openstack-cinder05:02
openstackgerritMerged openstack/cinder master: Synchronize all LVM operations  https://review.openstack.org/62480905:16
*** Dinesh_Bhor has joined #openstack-cinder05:23
*** _alastor_ has quit IRC05:34
*** dklyle has joined #openstack-cinder05:38
openstackgerritMerged openstack/cinder master: Set message property in ImageDownloadFailed  https://review.openstack.org/62513505:40
openstackgerritiain MacDonnell proposed openstack/cinder stable/rocky: Set message property in ImageDownloadFailed  https://review.openstack.org/62514805:49
*** lpetrut has joined #openstack-cinder06:13
*** bhagyashris_ has joined #openstack-cinder06:35
*** rcernin has quit IRC07:03
*** pcaruana has joined #openstack-cinder07:12
*** Luzi has joined #openstack-cinder07:13
*** erlon has quit IRC07:23
openstackgerritRyan Liang proposed openstack/cinder stable/ocata: [Unity] Add `force detach` support  https://review.openstack.org/62516507:32
*** dpawlik has joined #openstack-cinder07:38
openstackgerritYong Huang proposed openstack/cinder stable/ocata: Empty option value maybe cause Unity driver failed to initialize  https://review.openstack.org/62516707:42
*** Dinesh_Bhor has quit IRC07:48
*** psachin has quit IRC07:48
*** lixiaoy1 has quit IRC07:54
*** lpetrut has quit IRC07:58
openstackgerritMerged openstack/cinder master: Automate generation of api-ref samples  https://review.openstack.org/61967608:03
openstackgerritYingxin Cheng proposed openstack/cinder master: [wip] Cinder RSD Driver  https://review.openstack.org/62146508:06
*** markvoelker has joined #openstack-cinder08:16
*** imacdonn has quit IRC08:24
*** imacdonn has joined #openstack-cinder08:24
*** lixiaoy1 has joined #openstack-cinder08:29
*** Dinesh_Bhor has joined #openstack-cinder08:33
openstackgerritYong Huang proposed openstack/cinder stable/pike: Update unity tests to use our test base  https://review.openstack.org/62518108:41
*** lixiaoy1 has quit IRC08:55
openstackgerritzhufl proposed openstack/cinder master: api-ref: volume_type_access should be array instead of object  https://review.openstack.org/62518609:00
*** brinzh has quit IRC09:06
*** erlon has joined #openstack-cinder09:13
*** arne_wiebalck has joined #openstack-cinder09:20
*** erlon has quit IRC09:22
openstackgerritFrancois Deppierraz proposed openstack/cinder master: cinder-volume: Stop masking IOError different than ENOSPC  https://review.openstack.org/61239309:23
*** Dinesh_Bhor has quit IRC09:46
*** dcdamien has joined #openstack-cinder09:50
*** luizbag has joined #openstack-cinder09:55
openstackgerritRajat Dhasmana proposed openstack/cinder master: Automate generation of API versions api-ref samples  https://review.openstack.org/62003309:56
*** erlon has joined #openstack-cinder10:21
openstackgerritRajat Dhasmana proposed openstack/cinder master: Automate generation of volumes api-ref samples  https://review.openstack.org/62147810:31
*** Dinesh_Bhor has joined #openstack-cinder10:35
*** markvoelker has quit IRC10:36
*** Dinesh_Bhor has quit IRC10:36
*** markvoelker has joined #openstack-cinder10:37
*** yongwc has joined #openstack-cinder10:38
*** e0ne has joined #openstack-cinder10:40
*** markvoelker has quit IRC10:41
openstackgerritBrin Zhang proposed openstack/cinder master: api-ref: add qos_specs_id to show default volume type response  https://review.openstack.org/62520810:54
*** yongwc has quit IRC10:54
*** bhagyashris_ has quit IRC10:59
*** LiangFang has quit IRC11:00
*** yongwc_ has joined #openstack-cinder11:09
*** markvoelker has joined #openstack-cinder11:16
openstackgerritMerged openstack/cinder master: Fix A/A 'resource_backend' when scheduling volumes  https://review.openstack.org/62505211:18
*** arne_wiebalck has quit IRC11:24
*** arne_wiebalck_ is now known as arne_wiebalck11:24
yongwc_Anyone would like do a review for https://review.openstack.org/#/c/562977/, which is a driver for inspur as13000 storage system, thanks.11:27
*** gary_perkins has quit IRC11:37
*** Luzi has quit IRC11:44
*** gary_perkins has joined #openstack-cinder11:50
*** yongwc_ has quit IRC11:57
*** udesale has quit IRC12:11
*** tpsilva has joined #openstack-cinder12:14
*** pcaruana has quit IRC12:21
*** pcaruana has joined #openstack-cinder12:22
*** pcaruana is now known as pcaruana|intw|12:25
*** _alastor_ has joined #openstack-cinder12:35
*** abishop has joined #openstack-cinder13:04
*** kaisers_ has joined #openstack-cinder13:09
*** _alastor_ has quit IRC13:14
*** dcdamien has quit IRC13:18
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505813:18
openstackgerritGorka Eguileor proposed openstack/cinder master: Add cinderlib functional tests  https://review.openstack.org/62067113:45
openstackgerritRajat Dhasmana proposed openstack/cinder master: Automate generation of API versions api-ref samples  https://review.openstack.org/62003313:52
openstackgerritRajat Dhasmana proposed openstack/cinder master: Automate generation of volumes api-ref samples  https://review.openstack.org/62147813:53
*** mriedem has joined #openstack-cinder13:56
openstackgerritRajat Dhasmana proposed openstack/cinder master: Automate generation of volumes api-ref samples  https://review.openstack.org/62147813:56
*** pcaruana|intw| has quit IRC14:05
dansmithjungleboyj: smcginnis: mriedem: http://logs.openstack.org/65/621465/18/check/nova-multiattach/93859c1/logs/screen-c-vol.txt.gz?#_Dec_14_09_07_37_26975014:12
mriedemsob14:12
dansmithwaited >60s for the lock, which tells me it's not gonna help14:12
dansmithso when we discussed this earlier, I think it was smcginnis that said "so if lvm is taking a long time there's nothing cinder can do about it", which might be true,14:13
dansmithbut I feel like we've got to do something here14:13
dansmitheither change the device we're configuring lvm to use so it can be faster,14:13
dansmithor use the long-call rpc stuff so we just wait until it's really done.. or something.14:13
mriedemthere could be other places in cinder that are hitting lvchange? but i don't think i saw any other obvious callers14:14
smcginnisI wonder if this is some kind of regression in LVM. Strange that we are hitting it more often all of a sudden.14:14
mriedemwe did just recently upgrade tempest-full and friends to bionic,14:14
dansmithmriedem: this is locking all lvm ops, not just lvchange14:14
mriedembut the nova-multiattach job is legacy so it's using xenail14:14
mriedem*xenial14:14
dansmithsmcginnis: several of these bugs have been around for a year in some form14:15
mriedemi support the long_rpc_timeout on attachment_update/os-initialize_connection14:15
mriedemthat should help with a couple of the bugs14:15
smcginnisdansmith: Yeah, it seems like it's something that kind of comes and goes though.14:15
dansmithyeah, it sucks to solve it with that just from a user perspective, but at least it would make it not time out 1s before it actually completes14:16
mriedemright14:16
dansmithsmcginnis: yeah, which smells so much like it's us a and not them to me, but.. I know.14:16
dansmithit also seems plausible that it's just an artifact of slow nodes with lots of stuff going on and a loop-mounted lvm backing store that is just getting hamstrung by terrible IO and buffer cache traffic14:17
dansmithlike I wonder if we could get away with putting the loop on tmpfs to avoid doing as much IO14:18
smcginnisHmm, took over 30 seconds just calling lvs: http://logs.openstack.org/65/621465/18/check/nova-multiattach/93859c1/logs/screen-c-vol.txt.gz?#_Dec_14_09_07_37_26768014:18
dansmithsmcginnis: right, see that's why I wonder if it's really block refreshes that are slowing it down.. like lvs does a scan that includes an iscsi device we're taking down14:19
dansmithyou know,14:19
dansmithI wonder if we could/should be configuring lvm.conf to be super selective in what it scans14:19
mriedemdoes dstat around the time of these show anything14:20
mriedem?14:20
dansmithmriedem: I have thought about doing that, but I have to plot a csv file I think so I haven't yet14:20
mriedemhttp://logs.openstack.org/65/621465/18/check/nova-multiattach/93859c1/logs/screen-dstat.txt.gz#_Dec_14_09_07_37_07186114:20
mriedemhttp://logs.openstack.org/65/621465/18/check/nova-multiattach/93859c1/logs/dstat-csv_log.txt.gz14:20
mriedemi have a hard time reading this thing14:21
dansmithyeah14:21
dansmithah, devstack is already setting an lvm filter14:21
smcginnisI thought it was, but can't find it in the collected artifacts.14:22
dansmithit doesn't collect it afaict, but it does log something, hang on14:22
dansmithoh14:22
dansmithhttp://logs.openstack.org/65/621465/18/check/nova-multiattach/93859c1/logs/devstacklog.txt.gz#_2018-12-14_08_45_31_68714:22
dansmithit seems to still include everything after the loops14:23
dansmithno that's reject14:23
dansmithnevermind14:23
dansmithso just the loop1 and loop214:23
dansmithwhich should do it I think14:23
smcginnisYeah, looks like that should lock it down enough.14:23
dansmithunless some iscsi device has loop in the name, but seems unlikely :)14:24
smcginnisHah, let's hope not.14:24
smcginnisMan, 63.103s on an lvs just seems like something is very, very wrong.14:25
eharneyi think if you add a number of "--debug" flags to "lvs", you'll see timing info on what it's doing in syslog14:25
mriedemi was wondering about that too,14:26
smcginnisI suppose we could add that temporarily as a debugging aid.14:26
eharneyrunning "sudo lvs --debug --debug --debug --debug --debug --debug" on my machine shows it14:26
mriedemif there was a way to get some kind of data capture when a command takes over a given time14:26
mriedembut i suppose you need to know what's going on while it's running, not immediately after14:26
dansmithouch, do we really need 24G of backing space for this?14:27
*** udesale has joined #openstack-cinder14:27
dansmithbecause with an 8G guest or whatever, we could be generating a lot of dirty pages14:28
smcginnisYep :/14:28
smcginnisWe were running out of space on some things.14:28
smcginnisWhich does seem ridiculous.14:28
dansmithso, in the past, loop had a really high overhead14:29
dansmithrecently they added directio support14:29
dansmithso I wonder if we're new enough to try that and/or if we need to ask for it or get it directly14:30
smcginnisOh? Any docs on that dansmith? Or something you want to try throwing a patch up for?14:30
smcginnisSounds promising.14:30
dansmithsmcginnis: gotta read first14:30
dansmiththis multiattach job is 4.4.0.. mriedem you said that's xenial, and the oldest rght?14:30
smcginnisOr at least 1 idea more than the 0 I have.14:30
smcginnisI don't believe we are running any current jobs on anything older than Xenial.14:31
*** pcaruana has joined #openstack-cinder14:31
dansmithso, it says that it defaults on (directio) but my 4.9 machine has a couple loops that don't have directio turned on, so.. maybe worth a devstack patch to force it on and show the result and see14:32
mriedemmaster won't run anything older than xenial14:34
mriedemthe zuulv3 jobs like tempest-full are running bionic as of this week14:34
mriedemnova-multiattach is not using zuulv3 so it's still xenial14:35
mriedembbiab14:35
dansmithhttps://review.openstack.org/#/c/625269/14:40
dansmithsmcginnis: aside from figuring this specific issue out, what do you think about using the long-rpc stuff for calls from api->volume that do synchronous things that could take a while like this?14:41
smcginnisdansmith: I suppose that at least will help with the timeouts. Still kills me that these calls even need to wait that long, but at least right now that appears to be an external constraint that we're just going to have to deal with.14:42
dansmithand/or should I explain what that means? :)14:42
dansmithsmcginnis: right, we should try to fix the acute problem for sure,14:43
dansmithit's just that any time you're doing something synchronous that is manipulating stuff like this you're open to it14:43
dansmithsmcginnis: years ago some storage vendor was recommending setting their cinder rpc timeout suuuper high because they were making synchronous calls from volume to their backend which took a long time.. do you know of any such suggestion currently?14:44
dansmithand/or other drivers that might do such a thing?14:44
smcginnisWe do still have some create from image calls that can take a long time.14:45
dansmithlvm is maybe a little special in this regard14:45
dansmiththat the api is waiting for?14:45
smcginnisI can't recall now, but I think it was at the time. Not sure if we changed that. Actually...14:46
smcginnisI think I'm actually thinking of the boot from volume through the Nova api.14:46
dansmithokay, we poll in that case14:46
smcginnisThat was the one I remember hitting the most with customers when I was closer to the front line.14:46
dansmithyeah for sure14:46
*** jmlowe has quit IRC14:48
mriedemthat was probably before cinder did image caching?14:49
mriedemyou had to tweak the nova configs just to keep bfv from timing out polling b/c cinder was downloading the image14:49
smcginnisYeah, it was especially bad before that.14:49
*** psachin has joined #openstack-cinder14:50
mriedemeharney: i see you just recently enabled the encrypted volume tests in the ceph job14:53
mriedemhttp://logs.openstack.org/43/619143/14/check/devstack-plugin-ceph-tempest/9e84802/testr_results.html.gz14:53
mriedemhttp://logs.openstack.org/43/619143/14/check/devstack-plugin-ceph-tempest/9e84802/controller/logs/screen-c-vol.txt.gz?level=TRACE#_Dec_14_08_34_27_30776014:54
mriedemDec 14 08:34:27.307760 ubuntu-bionic-rax-iad-0001195720 cinder-volume[1362]:            |__Flow 'volume_create_manager': VolumeDriverException: Volume driver reported an error: Provider plain not supported.14:54
eharneyyeah, i need to go set the right config to turn that particular test off for that job everywhere14:55
mriedemhow did https://review.openstack.org/#/c/625130/ pass then?14:55
eharneybecause the way i turned it off turned it off in the devstack-plugin-ceph repo and nowhere else :/14:55
mriedemhmm, all the other jobs should be using that same blacklist14:56
eharneythat was the hope, but i guess they aren't as of now14:57
mriedemhttp://git.openstack.org/cgit/openstack/devstack-plugin-ceph/tree/.zuul.yaml#n2614:57
mriedemit's the same job14:58
eharneywould zuul.project.src_dir be a different value on a different project's run?  i'm not sure how that works14:58
mriedemhmm14:58
eharneyhttp://logs.openstack.org/43/619143/14/check/devstack-plugin-ceph-tempest/9e84802/job-output.txt.gz#_2018-12-14_07_52_04_770767  checks and doesn't apply the file14:58
*** kaisers_ is now known as kaisers_away14:58
mriedemrevert here for the time being https://review.openstack.org/#/c/625277/15:00
*** mchlumsky has joined #openstack-cinder15:00
mriedemyup the non-devstack-plugin-ceph runs are definitely not using the blacklist15:01
mriedemhttp://logs.openstack.org/43/619143/14/check/devstack-plugin-ceph-tempest/9e84802/job-output.txt.gz#_2018-12-14_07_52_08_31934715:01
mriedemgmann: ^15:01
mriedemoh actually https://review.openstack.org/#/c/570015/ is probably the problem15:03
*** zul has joined #openstack-cinder15:04
*** jmlowe has joined #openstack-cinder15:04
eharneyi think i just need to change it to a zuul.projects.['something'] reference15:05
*** markvoelker has quit IRC15:06
mriedemwhy did that need to change at all?15:07
mriedemthere was no mention in the comments or commit message15:07
mriedemi posted a revert for it here https://review.openstack.org/#/c/625279/ but apparently it's already in merge conflict15:08
eharneythe previous path coded in zuul.yaml was not resulting in the blacklist file loading15:09
mriedemhmm, gonna need gmann or AJaeger to help then probably,15:10
mriedemi've posted reverts of both changes for now if we want to push those through until it's sorted out and we can show it working on both devstack-plugin-ceph changes and non-dpc changes15:11
mriedemwe can test that using a depends-on from cinder to the dpc change15:11
dansmithsmcginnis: we are not currently using directio: https://pastebin.com/raw/Hktap6xd15:16
smcginnisdansmith: Good check. So we need to add something to devstack to set that?15:17
dansmithsmcginnis: that patch is up and I'm waiting for it to hit the same spot to see if that 0 flips to a 115:17
dansmithsmcginnis: boom: https://pastebin.com/raw/7cw7rd7G15:18
openstackgerritFrancois Deppierraz proposed openstack/cinder master: cinder-volume: Stop masking IOError different than ENOSPC  https://review.openstack.org/61239315:19
smcginnisNice!15:19
smcginnisdansmith: Got a link?15:19
dansmithsmcginnis: https://review.openstack.org/#/c/625269/115:19
dansmithI'll modify the swift one as well and submit without the debug patch underneath15:20
dansmithmriedem: ^15:20
smcginnisdansmith: Thanks for jumping on that. I think it will be good to just merge it and see if we see a difference.15:20
dansmithyeah15:21
*** psachin has quit IRC15:21
*** gnufied has joined #openstack-cinder15:21
dansmithactually, I'm not sure where the swift one is15:21
smcginnisMaybe less of a concern though. Maybe15:21
mriedemdoes that need to be conditional on the filesystem? we have a check for that in nova https://github.com/openstack/nova/blob/5ca357c100b15341001bff1bba663c36bb13d5a8/nova/privsep/utils.py#L3515:22
dansmithah, swift loop mounts15:22
dansmithso yeah I guess I'll punt on that for now15:23
*** dpawlik has quit IRC15:24
dansmithaw man, xenial doesn't have it in losetup even though the kernel should be new enough15:26
dansmithso the bionic jobs can do it but the xenial ones won't15:27
*** psachin has joined #openstack-cinder15:28
dansmithmriedem: sorry I missed that the above comment was related until I just saw it15:33
dansmithon the patch15:34
*** dpawlik has joined #openstack-cinder15:48
*** dpawlik has quit IRC15:52
dansmithmriedem: so if we do this directio thing on bionic, we can track and see if it helped, and if so justify moving the other jobs to bionic for most things?15:59
dansmithat least, jobs that run volume tests?15:59
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  changing from 8.4 to 9.0 REST endpoints  https://review.openstack.org/62529716:05
*** dklyle has quit IRC16:07
mriedemheh all jobs run volume tests :)16:07
*** dklyle has joined #openstack-cinder16:07
mriedemgmann is on a crusade to move all legacy jobs over to zuulv3, which would get them to bionic16:07
mriedemso i think that will happen with time,16:07
mriedemi'm working on trying to kill the nova-multiattach job and fold it into tempest-full and tempest-slow, which i thnk would also resolve that one,16:08
mriedembut that's hung up on other stupid stuff not working16:08
mriedemiow, i don't think we need justification to move jobs to bionic, just people power16:08
mriedemsoylant green gives me people power16:09
dansmithno, I meant "provide another reason to do it"16:09
dansmithmy tweaked devstack patch passes xenial and bionic now16:09
mriedeman incentive if you will16:10
dansmithyes, incentive is what I meant16:10
*** dklyle has quit IRC16:13
*** pcaruana has quit IRC16:20
*** e0ne has quit IRC16:24
*** dklyle has joined #openstack-cinder16:24
*** jmlowe has quit IRC16:27
*** kaisers_away is now known as kaisers_16:37
*** dklyle has quit IRC16:41
openstackgerritEric Harney proposed openstack/python-cinderclient master: Re-enable shell UUID completion cache  https://review.openstack.org/61061916:43
openstackgerritEric Harney proposed openstack/python-cinderclient master: Fix doc build error  https://review.openstack.org/61170816:44
openstackgerritEric Harney proposed openstack/cinder master: DNM: Test Ceph job  https://review.openstack.org/62530816:50
*** kaisers_ is now known as kaisers_away16:52
*** kaisers_away is now known as kaisers_17:00
*** kaisers_ is now known as kaisers_away17:00
*** kaisers_away is now known as kaisers_17:01
*** udesale has quit IRC17:07
*** mriedem is now known as mriedem_lunch17:10
*** erlon_ has joined #openstack-cinder17:10
*** dklyle has joined #openstack-cinder17:11
*** e0ne has joined #openstack-cinder17:13
*** erlon has quit IRC17:14
*** luizbag has quit IRC17:15
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505817:17
noonedeadpunkFolks, can someone give a review for https://review.openstack.org/#/c/624970/1 ?17:24
eharneynoonedeadpunk: is there a unit test that could hit this case?17:27
noonedeadpunkeharney: existing ones are not hitting this exact thing, but I may re-work them a bit17:29
*** markvoelker has joined #openstack-cinder17:31
noonedeadpunkthis one is supposed to check this thing, but numbers are luckely correct for not facing it https://github.com/openstack/cinder/blob/master/cinder/tests/unit/volume/test_connection.py#L30117:31
*** markvoelker has quit IRC17:35
*** psachin has quit IRC17:39
*** e0ne has quit IRC17:41
*** e0ne has joined #openstack-cinder17:43
*** dklyle has quit IRC17:51
*** kaisers_ is now known as kaisers_away17:51
openstackgerritMerged openstack/python-cinderclient master: Fix doc build error  https://review.openstack.org/61170817:56
*** dklyle has joined #openstack-cinder18:00
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505818:01
*** kaisers_away is now known as kaisers_18:06
*** kaisers_ is now known as kaisers_away18:07
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Fix _per_gb_min usage with _per_gb  https://review.openstack.org/62497018:09
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Fix _per_gb_min usage with _per_gb  https://review.openstack.org/62497018:11
*** itlinux has quit IRC18:13
*** itlinux has joined #openstack-cinder18:13
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Fix _per_gb_min usage with _per_gb  https://review.openstack.org/62497018:18
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Fix _per_gb_min usage with _per_gb  https://review.openstack.org/62497018:19
noonedeadpunksorry for this - mixed up with commits at the end of the day(((18:20
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505818:21
*** dklyle has quit IRC18:25
*** alkhodos has quit IRC18:36
*** kaisers_away is now known as kaisers_18:37
*** kaisers_ has quit IRC18:42
*** N3l1x has joined #openstack-cinder18:42
*** N3l1x has quit IRC18:42
*** N3l1x has joined #openstack-cinder18:43
*** dklyle has joined #openstack-cinder18:46
*** mriedem_lunch is now known as mriedem18:49
*** mriedem has quit IRC18:52
*** dklyle has quit IRC18:54
*** mriedem has joined #openstack-cinder18:56
*** dklyle has joined #openstack-cinder19:11
*** e0ne has quit IRC19:13
*** dklyle has quit IRC19:21
*** jmlowe has joined #openstack-cinder19:32
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505819:35
*** dklyle has joined #openstack-cinder19:42
*** dklyle has quit IRC19:55
*** e0ne has joined #openstack-cinder20:11
*** e0ne has quit IRC20:11
*** noonedeadpunk has quit IRC20:15
*** mchlumsky has quit IRC21:01
*** tpsilva has quit IRC21:23
*** dklyle has joined #openstack-cinder21:27
*** abishop has quit IRC21:30
*** dklyle has quit IRC21:32
*** dklyle has joined #openstack-cinder21:33
*** woojay has quit IRC21:35
*** mchlumsky has joined #openstack-cinder21:35
*** woojay has joined #openstack-cinder21:37
*** N3l1x has quit IRC21:38
*** mchlumsky has quit IRC21:53
*** dklyle has quit IRC21:54
*** dklyle has joined #openstack-cinder21:56
*** mriedem has quit IRC22:01
*** dklyle has quit IRC22:02
*** dklyle has joined #openstack-cinder22:13
*** dklyle has quit IRC22:18
*** e0ne has joined #openstack-cinder22:23
*** yongwc has joined #openstack-cinder22:36
*** dklyle has joined #openstack-cinder22:37
*** e0ne has quit IRC22:40
*** dklyle has quit IRC22:41
*** dklyle has joined #openstack-cinder22:42
*** dklyle has quit IRC22:57
*** lbragstad has quit IRC23:08
openstackgerritAngela Smith proposed openstack/cinder master: REST connector for Brocade zone driver  https://review.openstack.org/61710023:08
*** lbragstad has joined #openstack-cinder23:16
*** rosmaita has left #openstack-cinder23:20
openstackgerritMerged openstack/cinder stable/rocky: VMAX Driver - VMAX OS Upgrade Bug  https://review.openstack.org/62445023:22
openstackgerritMerged openstack/cinder stable/rocky: Ensure image utils don't block greenthreads  https://review.openstack.org/62449723:22
*** lbragstad has quit IRC23:22
*** yongwc has quit IRC23:34

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!