*** enriquetaso has joined #openstack-cinder | 00:13 | |
*** enriquetaso has quit IRC | 00:20 | |
openstackgerrit | Merged openstack/cinder master: Use excutils.save_and_reraise_exception instead of reraise https://review.openstack.org/642353 | 00:43 |
---|---|---|
*** markvoelker has joined #openstack-cinder | 00:43 | |
*** whoami-rajat has joined #openstack-cinder | 00:51 | |
*** zhubx has quit IRC | 00:58 | |
*** zhubx has joined #openstack-cinder | 00:58 | |
*** tkajinam_ has joined #openstack-cinder | 00:58 | |
*** tkajinam has quit IRC | 01:01 | |
*** markvoelker has quit IRC | 01:21 | |
*** Nel1x has joined #openstack-cinder | 01:25 | |
*** dviroel_ has quit IRC | 01:47 | |
*** rosmaita has left #openstack-cinder | 02:11 | |
*** adriant has joined #openstack-cinder | 02:35 | |
adriant | Out of curiosity, is there any reason why Gunicorn wouldn't work as a server for Cinder? | 02:37 |
adriant | I've added "application = initialize_application()" to the wsgi file, and was trying to run it as: "gunicorn cinder.wsgi.wsgi:application" in a docker container, but it just doesn't work. | 02:38 |
adriant | I get "gunicorn: error: unrecognized arguments: cinder.wsgi.wsgi:application" because it seems gunicorn can't quite use the application variable Cinder makes. | 02:38 |
adriant | uWSGI works fine, but I can't for the life of my understand why it would work, but Gunicorn won't. | 02:39 |
adriant | but even for uWSGI we have to add: "application = initialize_application()" so I am curious why that isn't there in the first place | 02:45 |
adriant | or potentially should I be doing it via: | 02:59 |
adriant | http://docs.gunicorn.org/en/stable/run.html#paste | 02:59 |
adriant | ? | 02:59 |
*** psachin has joined #openstack-cinder | 03:03 | |
*** Nel1x has quit IRC | 03:05 | |
whoami-rajat | adriant: could you provide a error traceback? | 03:13 |
adriant | whoami-rajat: When running the gunicorn command I didn't get any errors other than that, and my colleague who was trying to get it running ran into much the same thing | 03:16 |
adriant | potentially we configured the log output of Cinder wrong, but we didnt' see anything. it mostly just failed to start with gunicorn as the server | 03:17 |
adriant | and as I look at it, that gunicorn paste option doesn't actually at all seem related to paste https://pypi.org/project/Paste/ | 03:18 |
*** itlinux has quit IRC | 03:41 | |
*** udesale has joined #openstack-cinder | 04:17 | |
whoami-rajat | adriant: sorry i went off. could you paste your wsgi file. i might be wrong but application should be a function right? 'application=initialize_application' | 04:23 |
adriant | whoami-rajat: a WSGI application object is a callable, but it expects 2 arguments | 04:30 |
adriant | initialize_application() isn't valid | 04:30 |
adriant | and for some reason the object it returns does work for Gunicorn | 04:30 |
adriant | whoami-rajat: and as for my wsgi file, literally all I did is append: "application = initialize_application()" to the one in cinder | 04:31 |
adriant | so that it calls that function to save it's result as a variable I can give gunicorn | 04:31 |
*** zhubx has quit IRC | 04:34 | |
whoami-rajat | adriant: yeah it's returning the object to my point shouldn't matter. | 04:34 |
adriant | oh typo.. "and for some reason the object it returns *doesn't* work for Gunicorn" | 04:34 |
*** zhubx has joined #openstack-cinder | 04:35 | |
adriant | It's just weird that the same exactly code and installed versions work for UWSGI with a uwsgi file, but not gunicorn | 04:35 |
*** zhubx has quit IRC | 04:36 | |
*** zhubx has joined #openstack-cinder | 04:36 | |
adriant | If I'm just doing something wrong I'm happy because it's easy to fix, but if there is a bug that probably should be looked at. | 04:37 |
*** zhubx has quit IRC | 04:37 | |
adriant | I don't even mind using uWSGI, I like prefer Gunicorn and was hoping to maintain a standard :P | 04:38 |
*** zhubx has joined #openstack-cinder | 04:38 | |
adriant | and it's just weird it doesn't work | 04:38 |
adriant | Chances are Cinder isn't the only service with the issue, I just happened to start with Cinder.' | 04:39 |
whoami-rajat | adriant: are the 2 arguments mandatory? i haven't really tried deploying it with any other server since uWSGI is default and works well. i don't think cinder has some specific settings for uWSGI and should work for other servers as well. | 04:39 |
adriant | whoami-rajat: https://www.python.org/dev/peps/pep-0333/ the wsgi interface expects to be called with "(environ, start_response)" | 04:41 |
adriant | so the value that initialize_application returns is what uWSGI or Gunicorn would be using as the app callable | 04:42 |
*** zhubx has quit IRC | 04:44 | |
*** zhubx has joined #openstack-cinder | 04:45 | |
adriant | anyway, I need to run, but my IRC bouncer will still keep me logged in. whoami-rajat: if you have any ideas of advice I'd be happy to test things out tomorrow | 04:46 |
whoami-rajat | adriant: hmm. so currently what we can do is report a bug against it, i can query for the same in cinder meeting tonight if anyone has tried the same. | 04:46 |
adriant | If this is entirely PEBKAC I'm fine with that, I just would like the option of using gunicorn if I can for consistency :) | 04:46 |
whoami-rajat | adriant: also if you're willing to try it for other modules, would be great to see if this is cinder specific or on openstack level. | 04:47 |
whoami-rajat | adriant: Thanks for mentioning this scenario. | 04:47 |
adriant | As I have time I'll try a few others. I know Keystone recently switched to using Flask so I think they are safe | 04:48 |
adriant | but I'll have a look at Glance api soon as well | 04:48 |
adriant | it's possible the old paste + oslo.wsgi service stuff is a little weird | 04:49 |
whoami-rajat | adriant: did they? wow, i thought Flask wasn't much suited for production env. | 04:49 |
adriant | whoami-rajat: really? I know quite a lot of projects outside of openstack using Flask | 04:50 |
adriant | we tend to use it for a lot of microservices, but I know some people building reasonably bigger apps with it. | 04:50 |
whoami-rajat | adriant: yeah i read it in a few articles, maybe things have changed recently in newer versions. | 04:52 |
*** udesale has quit IRC | 05:16 | |
*** anks2k has joined #openstack-cinder | 05:17 | |
*** udesale has joined #openstack-cinder | 05:17 | |
*** anks2k has quit IRC | 05:17 | |
*** zhubx has quit IRC | 05:43 | |
*** zhubx has joined #openstack-cinder | 05:44 | |
*** markvoelker has joined #openstack-cinder | 05:47 | |
*** udesale has quit IRC | 05:51 | |
*** udesale has joined #openstack-cinder | 06:11 | |
*** pcaruana has joined #openstack-cinder | 06:19 | |
*** jdillaman has quit IRC | 06:30 | |
*** avishay has joined #openstack-cinder | 06:33 | |
*** jdillaman has joined #openstack-cinder | 06:35 | |
*** e0ne has joined #openstack-cinder | 06:40 | |
*** Luzi has joined #openstack-cinder | 06:48 | |
*** tonyb is now known as tonyb_gone | 07:20 | |
*** tonyb_gone is now known as tonyb | 07:21 | |
*** dpawlik has joined #openstack-cinder | 07:23 | |
*** e0ne has quit IRC | 07:31 | |
*** gkadam has joined #openstack-cinder | 07:48 | |
*** e0ne has joined #openstack-cinder | 07:51 | |
*** dpawlik has quit IRC | 07:54 | |
*** sahid has joined #openstack-cinder | 08:05 | |
*** lennyb has joined #openstack-cinder | 08:05 | |
*** dpawlik has joined #openstack-cinder | 08:06 | |
*** rcernin has quit IRC | 08:09 | |
*** zhubx has quit IRC | 08:17 | |
*** zhubx has joined #openstack-cinder | 08:17 | |
*** Liang__ has joined #openstack-cinder | 08:21 | |
*** zhubx has quit IRC | 08:21 | |
*** Liang__ is now known as LiangFang | 08:22 | |
*** zhubx has joined #openstack-cinder | 08:23 | |
*** zhubx has quit IRC | 08:23 | |
*** zhubx has joined #openstack-cinder | 08:23 | |
*** zhubx has quit IRC | 08:25 | |
*** zhubx has joined #openstack-cinder | 08:26 | |
avishay | sahid: Hey, do you have a few minutes to discuss the reverted WWN verification commit? | 08:35 |
*** e0ne has quit IRC | 08:36 | |
sahid | avishay: sure | 08:45 |
sahid | btw i saw an other revert related to the rename of scaleio, i'm wondering whether that have already been discussed? because that looks tricky since we already release a version with that change in-tree | 08:48 |
avishay | I don't know about scaleio | 08:53 |
avishay | sahid: When I try the WWN verification on my setup it works almost always. I have trouble reproducing the case where no WWN is found. I was thinking that maybe it happens when some device is leftover from a previous attachment? | 08:54 |
sahid | avishay: you mean with the first patch that you have landed? | 08:55 |
*** mszwed has quit IRC | 09:03 | |
whoami-rajat | sahid: we discussed the revert change, the renaming isn't merged in cinder and nova so changes in os-brick seems unrequired currently. also we don't need to rebrand os-brick due to a driver renaming, we can just use the same protocol 'scaleio' and same connection properties since os-brick changes doesn't reflect to the end user. | 09:13 |
avishay | sahid: Yes, the first patch (the one that was reverted) | 09:14 |
avishay | I am running a setup with multipath, and it works fine (usually) | 09:15 |
*** kukacz has quit IRC | 09:15 | |
avishay | Sometimes it fails to find the WWN but I have no idea why | 09:15 |
sahid | avishay: are you using multipah in your setup? | 09:15 |
avishay | sahid: Yes | 09:16 |
sahid | whoami-rajat: ack | 09:16 |
*** kukacz has joined #openstack-cinder | 09:17 | |
sahid | avishay: so my thinking it's that it's a timeing issue. the fix you have proposed is not right since at some point the devices are not registered anymore in /dev/disk/by-id/ | 09:18 |
sahid | and that method you are useing in your patch is using this path | 09:18 |
avishay | sahid: There is in fact only one device in /dev/disk/by-id/ that points to the multipath device, but the link is called /dev/disk/by-id/scsi-<wwid> so it still works. | 09:21 |
avishay | There is a comment there in get_sysfs_wwn() about multiple designators, not sure what that means | 09:21 |
*** tkajinam__ has joined #openstack-cinder | 09:22 | |
*** FlorianFa has joined #openstack-cinder | 09:23 | |
*** tkajinam_ has quit IRC | 09:25 | |
sahid | avishay: hum my thinkin is, the wwid which will be returned by get_sysfs_wwn() will be for example based on sda, so then the condition fails since it should not have a ref like /dev/disk/by-id/scsi-<sda-wwid>, then in the second condition we go through all the devices [sda, sdb, ...] and check if there are in /dev/disk/by-id/ but they are not anymore | 09:32 |
avishay | sahid: But in the correct case, the devices for all paths will have the same wwid, so the symlink /dev/disk/by-id/scsi-<wwid> is valid for all of them. | 09:33 |
sahid | avishay: have you try to log the return of get_sysfs_wwid?, i just checked in my env and basically i don't have /sys/block/sdb/device/wwid | 09:41 |
sahid | avishay: basically you have the mapth so what about to use get_scsi_wwn(mpath) when use_multipath is configured to do your check | 09:43 |
avishay | sahid: Yes, I thought to use get_scsi_wwn for all cases, instead of get_sysfs_wwn. I don't know if there are any downsides to it though. | 09:44 |
sahid | avishay: i have no idea, basically when your patch is ready i could apply it in my env to double check, it's using a purestorage array | 09:45 |
avishay | sahid: Mine is pure storage as well :) | 09:46 |
sahid | ahaha :) ok fair-enough so | 09:47 |
sahid | avishay: btw i would be happy if you can have a look at this at some point https://review.openstack.org/#/c/638639/ | 09:48 |
avishay | sahid: I was thinking though, in case the CI failures were really from leftover devices, maybe the best thing isn't to fail the operation? I had another patch that tried to clean up those devices at the start of the connect but it had issues as well :( | 09:48 |
avishay | will review your patch | 09:49 |
*** zhubx has quit IRC | 10:19 | |
*** zhubx has joined #openstack-cinder | 10:20 | |
*** avishay has quit IRC | 10:21 | |
*** avishay has joined #openstack-cinder | 10:24 | |
*** carlos_silva has joined #openstack-cinder | 10:38 | |
*** luizbag has joined #openstack-cinder | 10:39 | |
*** dave-mccowan has joined #openstack-cinder | 10:40 | |
*** dave-mccowan has quit IRC | 10:45 | |
*** bal has joined #openstack-cinder | 11:09 | |
*** avishay has quit IRC | 11:20 | |
*** gkadam_ has joined #openstack-cinder | 11:24 | |
*** gkadam has quit IRC | 11:25 | |
*** mriedem has joined #openstack-cinder | 11:26 | |
*** Alon_KS has joined #openstack-cinder | 11:29 | |
*** thgcorrea has joined #openstack-cinder | 11:30 | |
*** avishay has joined #openstack-cinder | 11:30 | |
*** e0ne has joined #openstack-cinder | 11:36 | |
*** avishay has quit IRC | 11:37 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Enable publish-to-pypi Zuul job https://review.openstack.org/643013 | 11:39 |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Add DevStack plugin https://review.openstack.org/643014 | 11:39 |
*** avishay has joined #openstack-cinder | 11:39 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Fix RBD connector https://review.openstack.org/643015 | 11:40 |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Support setting attach_mode https://review.openstack.org/643016 | 11:40 |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Fix error_deleting status in vol and snap https://review.openstack.org/643017 | 11:41 |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Fix Volume snapshots and connections on deletion https://review.openstack.org/643018 | 11:41 |
*** luizbag_ has joined #openstack-cinder | 11:54 | |
*** thgcorrea has quit IRC | 11:55 | |
*** luizbag has quit IRC | 11:55 | |
*** zhubx has quit IRC | 12:07 | |
*** markvoelker has quit IRC | 12:12 | |
*** markvoelker has joined #openstack-cinder | 12:13 | |
*** abishop has joined #openstack-cinder | 12:25 | |
*** rosmaita has joined #openstack-cinder | 12:32 | |
*** mchlumsky has joined #openstack-cinder | 12:38 | |
*** lseki has joined #openstack-cinder | 12:44 | |
*** lseki has quit IRC | 12:45 | |
*** lseki has joined #openstack-cinder | 12:45 | |
openstackgerrit | Matt Riedemann proposed openstack/os-brick stable/rocky: 'iscsiadm -m session' failure handling https://review.openstack.org/643039 | 12:47 |
*** thgcorrea has joined #openstack-cinder | 13:05 | |
*** e0ne has quit IRC | 13:05 | |
*** udesale has quit IRC | 13:16 | |
*** avishay has quit IRC | 13:16 | |
*** udesale has joined #openstack-cinder | 13:17 | |
*** yury-kulaz has joined #openstack-cinder | 13:18 | |
*** raghavendrat has joined #openstack-cinder | 13:33 | |
*** eharney has joined #openstack-cinder | 13:37 | |
*** dviroel_ has joined #openstack-cinder | 13:40 | |
raghavendrat | hi Eric. would like to discuss about your comment for https://review.openstack.org/#/c/634119/ | 13:40 |
raghavendrat | eharney: do you have few minutes | 13:40 |
eharney | raghavendrat: hi, sure | 13:42 |
*** thgcorrea has quit IRC | 13:43 | |
raghavendrat | In 3par, there is no way to quickly clone volume | 13:43 |
eharney | ok | 13:43 |
*** thgcorrea has joined #openstack-cinder | 13:43 | |
*** zhubx has joined #openstack-cinder | 13:43 | |
raghavendrat | also there was discussion between Rajat Dhasmana and Walter Boring | 13:44 |
raghavendrat | we thought that it would be better to change default value of extra spec to False | 13:45 |
eharney | which means that by default, some 3par volumes will fail to delete, right? | 13:45 |
raghavendrat | Rajat set convert_to_base =False as default, tested cinder rally job, specifically create_volume_from_snaphot, and it passed | 13:47 |
*** zhubx has quit IRC | 13:48 | |
whoami-rajat | ^ snapshots were dependent previously and didn't do much harm (only rally jobs failed) which I tested and passing with default=False now, so hemna_ and I agreed to restore it to previously behaviour. | 13:48 |
raghavendrat | so i guess, there have been some enhancement in rally job which takes care of volume deletion. And now deletion should work fine. | 13:48 |
eharney | i' | 13:49 |
eharney | i'm not sure what rally tests in regard to this, but it is true that this setting will cause some volumes to fail to delete, right? | 13:49 |
whoami-rajat | eharney: snapshots were created dependent initially, due to a rally job fail the functionality was modified to have independent snaps. Thought to mention it just for info. | 13:52 |
raghavendrat | eharney: sorry for my limited knowledge. may i know test scenarios for which volume delete may fail; i can perform scenarios and validate | 13:57 |
eharney | raghavendrat: clone a volume from a snapshot and then try to delete the original source volume | 13:58 |
raghavendrat | i.e set value of extra-spec is false; and v2 is created as child of s1; now try to delete original volume v1. | 14:00 |
raghavendrat | is my understanding correct? | 14:00 |
eharney | yes | 14:00 |
raghavendrat | ok. i will try this and share my finding. | 14:01 |
*** gkadam_ has quit IRC | 14:02 | |
*** thgcorrea has quit IRC | 14:03 | |
*** luizbag has joined #openstack-cinder | 14:03 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Fix Volume snapshots and connections on deletion https://review.openstack.org/643018 | 14:04 |
*** luizbag_ has quit IRC | 14:05 | |
*** zhubx has joined #openstack-cinder | 14:07 | |
*** gnufied has joined #openstack-cinder | 14:07 | |
*** gnufied has quit IRC | 14:08 | |
*** irclogbot_0 has quit IRC | 14:09 | |
*** thgcorrea has joined #openstack-cinder | 14:10 | |
*** e0ne has joined #openstack-cinder | 14:10 | |
*** irclogbot_0 has joined #openstack-cinder | 14:12 | |
*** enriquetaso has joined #openstack-cinder | 14:20 | |
*** eharney has quit IRC | 14:23 | |
*** zhubx has quit IRC | 14:24 | |
*** irclogbot_0 has quit IRC | 14:25 | |
*** eharney has joined #openstack-cinder | 14:28 | |
*** irclogbot_0 has joined #openstack-cinder | 14:28 | |
*** efried has joined #openstack-cinder | 14:29 | |
efried | o/ | 14:29 |
efried | jungleboyj, whoami-rajat, eharney: I just caught up on http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/%23openstack-cinder.2019-03-12.log.html#t2019-03-12T16:01:09 (re scaleio rename revert) | 14:30 |
efried | I agree that, if the revert is going to happen, it needs to happen right now, before the release, so we never release with the "bad" version | 14:30 |
efried | but | 14:30 |
efried | we also need to blacklist the "bad" release of os-brick | 14:31 |
efried | otherwise somebody down the road could pick it up in their project and use it | 14:31 |
efried | and be broken when they upgrade. | 14:31 |
efried | I believe this would constitute a patch in the requirements project. I don't see one in place currently. I can propose that if you agree it's the right thing to do. | 14:32 |
*** gnufied has joined #openstack-cinder | 14:34 | |
whoami-rajat | efried: ++ smcginnis ^^ | 14:34 |
*** thgcorrea has quit IRC | 14:34 | |
*** luizbag_ has joined #openstack-cinder | 14:34 | |
*** luizbag has quit IRC | 14:35 | |
*** mauricio_ps_ has joined #openstack-cinder | 14:41 | |
*** bal_ has joined #openstack-cinder | 14:43 | |
*** mauricio_ps_ has quit IRC | 14:43 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Fix VolumeAttachment is not bound to a Session https://review.openstack.org/632549 | 14:46 |
jungleboyj | efried: Yes, I agree that we should mark the releases of os-brick with that code in it as bad so that people don't use it or get into a bad state. | 14:47 |
jungleboyj | efried: Thanks for bringing that up. | 14:47 |
efried | jungleboyj: Okay. I'm talking in -requirements to figure out how to do that mechanically. | 14:47 |
jungleboyj | efried: Thanks. I will come watch over your shoulder. | 14:48 |
*** yury-kulaz has quit IRC | 14:49 | |
jungleboyj | hemna_: ^^^ | 14:50 |
*** yury-kulaz has joined #openstack-cinder | 14:54 | |
openstackgerrit | sahid proposed openstack/cinderlib master: add python 3.7 unit test job https://review.openstack.org/643067 | 14:59 |
*** mszwed has joined #openstack-cinder | 15:01 | |
*** psachin has quit IRC | 15:07 | |
*** mriedem has quit IRC | 15:10 | |
efried | jungleboyj: you have the power to +W https://review.openstack.org/#/c/642852/ right? Are you waiting for someone else to weigh in? | 15:11 |
efried | oh, I'm also looking with pretty narrow goggles; are there other patches in flight that will need to be part of the release? | 15:11 |
*** mriedem has joined #openstack-cinder | 15:11 | |
jungleboyj | efried: Well, I was hoping to dot i's and cross t's in the Cinder meeting. | 15:12 |
jungleboyj | hemna_: Doesn't appear to be around though. | 15:12 |
whoami-rajat | efried: https://review.openstack.org/#/c/642648/ | 15:13 |
efried | okay, nbd, just lmk if I can help with anything. | 15:13 |
jungleboyj | The original author has +1'd so I guess I can +W. | 15:13 |
efried | whoami-rajat: ack | 15:13 |
*** _alastor_ has quit IRC | 15:13 | |
jungleboyj | whoami-rajat: Any concerns? | 15:13 |
*** _alastor_ has joined #openstack-cinder | 15:14 | |
*** lpetrut has joined #openstack-cinder | 15:14 | |
whoami-rajat | jungleboyj: None from my side on this. my concerns are still with RSD one. | 15:14 |
*** Luzi has quit IRC | 15:14 | |
jungleboyj | whoami-rajat: Ok, so no reason to not get the ScaleIO ones merged and talk about RSD during the meeting? | 15:15 |
whoami-rajat | jungleboyj: since Yury agreed on keeping the same protocol and connection properties as previous(ScaleIO), i think we don't need the VXFlexOs patch in os-brick anymore. | 15:19 |
whoami-rajat | jungleboyj: that seems like the right way. | 15:22 |
*** martinkennelly has joined #openstack-cinder | 15:22 | |
*** dpawlik has quit IRC | 15:22 | |
jungleboyj | Right. I am merging those now. So, just trying to figure out what, if anything we have left to do with RSD. | 15:23 |
jungleboyj | whoami-rajat: I just talked to Walt and he will be in the meeting. | 15:24 |
*** _alastor_ has quit IRC | 15:24 | |
*** _alastor_ has joined #openstack-cinder | 15:24 | |
whoami-rajat | jungleboyj: just not sure why are we keeping the nvmeof name in the connector list when a connector uses nvme. | 15:26 |
whoami-rajat | jungleboyj: ok we can discuss it there then, Thanks :) | 15:26 |
whoami-rajat | s/a/the | 15:26 |
*** erlon has joined #openstack-cinder | 15:29 | |
jungleboyj | Yeah, lets talk about it there since hemna_ Will be around then. | 15:32 |
*** zhubx has joined #openstack-cinder | 15:32 | |
*** irclogbot_0 has quit IRC | 15:36 | |
*** irclogbot_0 has joined #openstack-cinder | 15:39 | |
*** enriquetaso has quit IRC | 15:41 | |
hemna_ | mornin | 15:46 |
hemna_ | what'd I miss? | 15:47 |
*** eharney has quit IRC | 15:49 | |
*** irclogbot_0 has quit IRC | 15:49 | |
*** henriqueof has quit IRC | 15:49 | |
*** irclogbot_0 has joined #openstack-cinder | 15:51 | |
*** irclogbot_0 has quit IRC | 15:52 | |
jungleboyj | hemna_: Howdy sir. I have merged your reverts for the ScaleIO change. Want to make sure we are all on the same page as to if there is anything else we need to do for os-brick. | 15:53 |
*** irclogbot_0 has joined #openstack-cinder | 15:56 | |
hemna_ | ok sounds good | 15:58 |
hemna_ | I have a work meeting at 9am | 15:59 |
hemna_ | I'll try and multitask for the cinder-meeting | 15:59 |
*** erlon has quit IRC | 16:11 | |
openstackgerrit | Yury Kulazhenkov proposed openstack/os-brick master: Fix ScaleIO KeyError after upgrade https://review.openstack.org/643092 | 16:15 |
yury-kulaz | hi. This ^^ patch is replacement for https://review.openstack.org/#/c/642849/1 | 16:16 |
*** yury-kulaz has quit IRC | 16:21 | |
*** thgcorrea has joined #openstack-cinder | 16:25 | |
*** yury-kulaz has joined #openstack-cinder | 16:25 | |
*** yury-kulaz has quit IRC | 16:25 | |
*** FlorianFa has quit IRC | 16:41 | |
*** udesale has quit IRC | 16:42 | |
*** dave-mccowan has joined #openstack-cinder | 16:43 | |
*** lpetrut has quit IRC | 16:44 | |
*** eandersson_ is now known as eandersson | 16:54 | |
*** FlorianFa has joined #openstack-cinder | 16:54 | |
*** jgriffith has quit IRC | 16:59 | |
*** e0ne has quit IRC | 17:01 | |
hemna_ | how much time do we have to release cinderlib? | 17:04 |
hemna_ | bugs can be backported | 17:04 |
*** lpetrut has joined #openstack-cinder | 17:04 | |
hemna_ | I think we need to get the pypi release job in place | 17:04 |
hemna_ | so we can push a release to pypi on time | 17:04 |
hemna_ | https://review.openstack.org/#/c/643014/ | 17:05 |
hemna_ | that's a good one to get in IMHO | 17:05 |
jungleboyj | hemna_: Yeah, that would be good to get in and get the pypi push set up. Then we can deal with the bugs. | 17:10 |
openstackgerrit | Merged openstack/os-brick master: Revert "Fix VxFlexOs KeyError after upgrade" https://review.openstack.org/642849 | 17:10 |
mriedem | non-client lib release freeze was 2 weeks ago | 17:16 |
mriedem | is enharney out this week? | 17:16 |
mriedem | jbernard: is there anything you know about this? https://bugs.launchpad.net/nova/+bug/1819944 | 17:16 |
openstack | Launchpad bug 1819944 in OpenStack Compute (nova) "nova-grenade-live-migration job failing on ubuntu bionic" [Undecided,Confirmed] | 17:16 |
mriedem | *eharney | 17:16 |
openstackgerrit | Merged openstack/os-brick master: Revert "rename ScaleIO connector to VxFlex OS" https://review.openstack.org/642852 | 17:16 |
mriedem | i guess that's not really a red hat thing though... | 17:17 |
jungleboyj | geguileo: Did you do a release of cinderlib | 17:18 |
geguileo | jungleboyj: I had done a couple of them on PyPi | 17:18 |
geguileo | jungleboyj: and when we added cinderlib to openstack I added admin privileges over the pypi account to the openstack ci | 17:19 |
geguileo | jungleboyj: and I haven't done any releases since then | 17:19 |
mriedem | so it would go through openstack/releases and smcginnis | 17:19 |
mriedem | and that ship sailed 2 weeks ago | 17:19 |
* jungleboyj was just looking through openstack/releases. | 17:20 | |
jungleboyj | Yeah. UGH. | 17:20 |
mriedem | if only there were a person per project that was responsible for being on top of that stuff ... o) | 17:23 |
mriedem | o-) | 17:23 |
mriedem | there we go | 17:23 |
jungleboyj | mriedem: We might have one of those but people seem to have been spread thin lately. | 17:24 |
mriedem | thin to win | 17:25 |
jungleboyj | geguileo: So, it appears that we need to get cinderlib added to releases for Train. What is the impact of not having it in Stein? | 17:25 |
*** dave-mccowan has quit IRC | 17:27 | |
*** lpetrut has quit IRC | 17:30 | |
*** sahid has quit IRC | 17:36 | |
*** eharney has joined #openstack-cinder | 17:41 | |
whoami-rajat | eharney: I've a query regarding https://review.openstack.org/#/c/640891/ | 17:44 |
eharney | whoami-rajat: ok | 17:44 |
whoami-rajat | eharney: our gate is failing cinder-tempest-dsvm-lvm-lio-barbican job in bionic with the following error | 17:45 |
whoami-rajat | [1] http://logs.openstack.org/26/641926/1/check/cinder-tempest-dsvm-lvm-lio-barbican/8f95df1/logs/devstacklog.txt.gz#_2019-03-13_03_36_48_757 | 17:45 |
* smcginnis swings by | 17:45 | |
smcginnis | jungleboyj, geguileo: We could probably do an "independent" release of cinderlib for now, then get it as officially part of train. | 17:45 |
jungleboyj | smcginnis: Ok. Is there an official process for that? | 17:46 |
geguileo | smcginnis: sounds like a good idea | 17:46 |
eharney | whoami-rajat: hmm, interesting | 17:46 |
smcginnis | jungleboyj: Look under the deliverables/_independent directory in openstack/releases | 17:47 |
whoami-rajat | eharney: since the legacy jobs migration is soon, our gates at cinder and os-brick may start failing due to this :( | 17:47 |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Enable publish-to-pypi Zuul job https://review.openstack.org/643013 | 17:47 |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Add DevStack plugin https://review.openstack.org/643014 | 17:47 |
geguileo | jungleboyj: smcginnis maybe like this? https://docs.openstack.org/infra/manual/creators.html#tagging-an-initial-release | 17:48 |
geguileo | but I don't know if that triggers the documentation, branch creation, etc | 17:49 |
eharney | whoami-rajat: pretty strange, ubuntu packages just failing to install correctly... | 17:49 |
whoami-rajat | eharney: yeah, looked like random failure so rechecked it. | 17:50 |
eharney | whoami-rajat: it has a pretty clear error message saying it can't use /etc/target | 17:51 |
jungleboyj | smcginnis: and geguileo I am good with doing an independent release for cinderlib to start with and then get it into the official releases for Train. | 17:52 |
geguileo | smcginnis: jungleboyj or I could try to add it to the releases project | 17:52 |
geguileo | smcginnis: jungleboyj I'll write a patch now and see what they say XD | 17:53 |
jungleboyj | geguileo: I am guessing that that will be rejected by the release team given that we have passed the freeze. | 17:53 |
eharney | whoami-rajat: my bet is the packages aren't in great shape, and we can probably work around it by adding a mkdir to the devstack script before that install is performed, but i don't have a bionic environment handy to test this with... | 17:53 |
geguileo | jungleboyj: but it's only the feature freeze, right? | 17:53 |
geguileo | jungleboyj: shouldn't it be fine until RC1? | 17:54 |
jungleboyj | https://releases.openstack.org/stein/schedule.html | 17:54 |
jungleboyj | The problem is the final release for the non-client libraries. | 17:54 |
jungleboyj | That was Mar 01. | 17:54 |
geguileo | jungleboyj: yeah, but cinderlib is not one of those libraries | 17:54 |
*** ianychoi has quit IRC | 17:55 | |
geguileo | jungleboyj: that freeze is for libraries that are used by other projects | 17:55 |
geguileo | jungleboyj: but cinderlib is a library that uses cinder as a library | 17:55 |
geguileo | jungleboyj: so it should follow cinder's cycle, imo | 17:55 |
geguileo | jungleboyj: I'll try to sell it to them that way :-) | 17:55 |
jungleboyj | OMG my head is going to explode today. | 17:55 |
jungleboyj | Ok. Give it a shot and see what happens. | 17:56 |
openstackgerrit | Jon Bernard proposed openstack/cinder master: RBD: save and restore multiattach features https://review.openstack.org/643116 | 17:58 |
jbernard | mriedem: that's new to me | 18:00 |
*** martinkennelly has quit IRC | 18:02 | |
mriedem | jbernard: yeah nvm it's an issue in the nova scripts for our live migration job, which use the devstack-plugin-ceph functions but there is something else that's busted, | 18:03 |
mriedem | so we're just going to disable ceph in these jobs temporarily | 18:03 |
jbernard | mriedem: ok, if you do find the plugin has a flaw let me know | 18:04 |
openstackgerrit | Keith Berger proposed openstack/os-brick stable/pike: Handle multiple errors in multipath -l parsing https://review.openstack.org/643120 | 18:05 |
*** bal has quit IRC | 18:07 | |
geguileo | jungleboyj: I checked the docs, I have to add it to that repo like smcginnis said, as an independent deliverable, and then on the next cycle add it as a normal cycle | 18:08 |
geguileo | so I'll propose it as independent | 18:08 |
hemna_ | since cinderlib is new and nobody in openstack is really using it, what's the harm in releasing it? | 18:17 |
whoami-rajat | eharney: wow, worked! Thanks a lot... proposed devstack fix for it https://review.openstack.org/#/c/643130/ | 18:21 |
eharney | whoami-rajat: awesome, that saves me a bunch of time :) | 18:23 |
*** pcaruana has quit IRC | 18:29 | |
*** enriquetaso has joined #openstack-cinder | 18:34 | |
jungleboyj | geguileo: Ok. Sorry it can't go in to the main release path yet. | 18:41 |
geguileo | jungleboyj: It shouldn't be that big of a deal :-) | 18:42 |
geguileo | jungleboyj: it'll be good enough if we can release it XD | 18:42 |
jungleboyj | Ok. How will the difference impact releasing it? | 18:43 |
geguileo | not sure yet | 18:44 |
geguileo | lol | 18:44 |
geguileo | I don't even know how to do a normal release... | 18:44 |
geguileo | I'll have a look at the docs if the accept the patch | 18:44 |
openstackgerrit | Ghanshyam Mann proposed openstack/cinder master: DNM: Testing cinder legacy jobs on bionic https://review.openstack.org/641926 | 18:47 |
openstackgerrit | Ghanshyam Mann proposed openstack/os-brick master: DNM: Testing os-brick legacy jobs on bionic https://review.openstack.org/641927 | 18:47 |
*** gmann is now known as gmann_afk | 18:48 | |
jungleboyj | hemna_: whoami-rajat https://review.openstack.org/#/c/643092 | 18:52 |
jungleboyj | Can we get some more eyes on that so we can get it merged if appropriate. | 18:52 |
hemna_ | done | 18:53 |
whoami-rajat | jungleboyj: was waiting for CI, +2ed | 18:53 |
jungleboyj | hemna_: Thanks. When that merges I will push up the patch for the release. | 18:56 |
*** e0ne has joined #openstack-cinder | 19:01 | |
*** mchlumsky_ has joined #openstack-cinder | 19:03 | |
*** mchlumsky has quit IRC | 19:04 | |
*** zzzeek has quit IRC | 19:04 | |
*** zzzeek has joined #openstack-cinder | 19:07 | |
*** enriquetaso has quit IRC | 19:13 | |
*** enriquetaso has joined #openstack-cinder | 19:29 | |
*** luizbag_ has quit IRC | 19:30 | |
*** luizbag has joined #openstack-cinder | 19:30 | |
*** bal has joined #openstack-cinder | 19:30 | |
*** thgcorrea has quit IRC | 19:31 | |
*** bal_ has quit IRC | 19:31 | |
*** bal has quit IRC | 20:02 | |
*** dklyle has quit IRC | 20:09 | |
*** luizbag has quit IRC | 20:12 | |
efried | jungleboyj: ready to release os-brick yet? | 20:14 |
*** dklyle has joined #openstack-cinder | 20:16 | |
enriquetaso | jungleboyj, o/ How are u? would you mind check this backport https://review.openstack.org/#/c/633598/ ? it has one +2! :) | 20:16 |
jungleboyj | efried: waiting for one more patch to land. | 20:19 |
jungleboyj | Should happen yet tonight. | 20:19 |
efried | jungleboyj: ack. lmk if you want me to propose and do the ffe request | 20:19 |
jungleboyj | enriquetaso: I will take a look. | 20:19 |
efried | jungleboyj: lmk either way, cause I'll need to update that blacklist patch | 20:19 |
jungleboyj | efried: I got it. Thanks. | 20:19 |
jungleboyj | Ok. Will do. | 20:20 |
efried | thanks | 20:20 |
*** s10 has joined #openstack-cinder | 20:24 | |
*** lpetrut has joined #openstack-cinder | 20:27 | |
*** lpetrut has quit IRC | 20:31 | |
*** e0ne has quit IRC | 20:38 | |
*** gmann_afk is now known as gmann | 20:41 | |
*** e0ne has joined #openstack-cinder | 20:41 | |
*** e0ne has quit IRC | 20:45 | |
openstackgerrit | Merged openstack/cinder stable/ocata: ScaleIO Driver - adding cache and refactoring tests https://review.openstack.org/633570 | 20:48 |
enriquetaso | thanks jungleboyj ! | 20:52 |
*** enriquetaso has quit IRC | 20:52 | |
openstackgerrit | Merged openstack/cinder-tempest-plugin master: Add metadata to snapshot for revert test https://review.openstack.org/639133 | 21:03 |
*** abishop has quit IRC | 21:07 | |
*** whoami-rajat has quit IRC | 21:11 | |
*** rcernin has joined #openstack-cinder | 21:57 | |
*** s10 has quit IRC | 21:59 | |
*** carlos_silva has quit IRC | 22:07 | |
*** mriedem is now known as mriedem_afk | 22:18 | |
*** lifeless has quit IRC | 22:27 | |
*** lifeless has joined #openstack-cinder | 22:27 | |
*** adriant has quit IRC | 22:29 | |
gmann | jungleboyj: for cinder gate failure due to bionic migration, this fix is working fine. once this is merged cinder gate will be up - https://review.openstack.org/#/c/643130/2 | 22:48 |
*** ianychoi has joined #openstack-cinder | 23:06 | |
*** sapd1 has joined #openstack-cinder | 23:09 | |
*** dave-mccowan has joined #openstack-cinder | 23:28 | |
*** sapd1 has quit IRC | 23:30 | |
*** lseki has quit IRC | 23:31 | |
*** dave-mccowan has quit IRC | 23:38 | |
openstackgerrit | Keith Berger proposed openstack/os-brick stable/pike: Handle multiple errors in multipath -l parsing https://review.openstack.org/643120 | 23:41 |
*** erlon has joined #openstack-cinder | 23:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!