Thursday, 2019-03-14

hemna_flerm00:20
*** dklyle has quit IRC00:31
*** dklyle has joined #openstack-cinder00:31
*** dklyle has quit IRC00:46
*** erlon has quit IRC00:54
*** gnufied has quit IRC00:58
*** mriedem_afk has quit IRC01:11
*** dviroel_ has quit IRC01:14
*** adriant has joined #openstack-cinder01:34
*** zhubx has quit IRC01:51
*** zhubx007 has joined #openstack-cinder01:51
*** whoami-rajat has joined #openstack-cinder02:02
*** doubletao has joined #openstack-cinder02:54
*** hoonetorg has quit IRC02:59
*** psachin has joined #openstack-cinder03:00
*** hoonetorg has joined #openstack-cinder03:12
jungleboyjgmann:  Awesome .  Thanks.03:23
*** vishakha has joined #openstack-cinder03:56
*** udesale has joined #openstack-cinder04:22
*** lpetrut has joined #openstack-cinder04:55
*** doubletao has quit IRC05:04
jungleboyjwhoami-rajat:  Are you around?05:05
whoami-rajatjungleboyj: yes.05:06
jungleboyjHey.  I need to head to bed.05:06
jungleboyjIt appears that the last path for os-brick is failing on the patch that gmann is working on.05:06
whoami-rajatjungleboyj: yes, cause my devstack change still didn't merge so os-brick and cinder gate will fail.05:07
jungleboyjhttps://review.openstack.org/#/c/643130/05:07
jungleboyjOh yeah, that is your patch as well.  :-)05:07
whoami-rajatjungleboyj: and there seems to be a problem with bionic setting env list due to which my devstack patch is failing.05:07
jungleboyjFixing all the problems!05:07
whoami-rajatjungleboyj: figured out the issue of devstack with bionic and putting up a fix now :)05:08
whoami-rajatjungleboyj: lots of problems recently !!05:08
jungleboyjOk.  Cool.  Then you can recheck https://review.openstack.org/#/c/64309205:08
whoami-rajatjungleboyj: sure, will add a depends on and merge this one ASAP.05:09
jungleboyjOnce that merges I can set up the release for os-brick and get the FFE for requirements made.05:10
whoami-rajatjungleboyj: ++05:12
jungleboyjGreat.  Thanks for all your help.  Will check in with you in about 6 hours or so.  :-)05:13
jungleboyjYay sleep.05:13
whoami-rajatjungleboyj: hope everything will be fixed when you will wake up. :) goodnight!05:14
jungleboyjThat would be awesome. Night!05:16
*** lpetrut has quit IRC05:19
openstackgerritRajat Dhasmana proposed openstack/os-brick master: Fix ScaleIO KeyError after upgrade  https://review.openstack.org/64309205:41
*** Luzi has joined #openstack-cinder06:46
*** lpetrut has joined #openstack-cinder07:07
*** markvoelker has quit IRC07:19
*** dpawlik has joined #openstack-cinder07:22
*** dpawlik has quit IRC07:27
*** dpawlik has joined #openstack-cinder07:29
*** lpetrut has quit IRC07:35
*** sahid has joined #openstack-cinder07:42
*** lpetrut has joined #openstack-cinder07:42
*** e0ne has joined #openstack-cinder07:45
*** gkadam_ has joined #openstack-cinder07:50
*** pcaruana has joined #openstack-cinder08:07
*** dpawlik has quit IRC08:09
*** dpawlik has joined #openstack-cinder08:10
*** pcaruana has quit IRC08:11
*** tkajinam__ has quit IRC08:13
*** pcaruana has joined #openstack-cinder08:23
*** hoonetorg has quit IRC08:32
*** hoonetorg has joined #openstack-cinder08:45
*** martinkennelly has joined #openstack-cinder09:24
*** e0ne has quit IRC09:43
*** e0ne has joined #openstack-cinder09:46
*** ruffian_sheep has joined #openstack-cinder09:47
*** pcaruana has quit IRC09:48
ruffian_sheepDoes anyone know what the job the third party ci should do?09:49
ruffian_sheepI want to build a third party ci of cinder.Now it can be set comment result of jobs in the community.09:50
ruffian_sheepBut I  dont know what the job it should do,and what the result we need09:51
whoami-rajatruffian_sheep: is you(your organization) planning to propose a new driver in cinder?09:54
whoami-rajats/is/are09:55
ruffian_sheep<whoami-rajat>:yes10:12
ruffian_sheep<whoami-rajat>:We have our device and try to merge our driver to the master of cinder10:13
*** luizbag has joined #openstack-cinder10:30
e0neruffian_sheep: hi. did you see this manual https://docs.openstack.org/cinder/latest/contributor/drivers.html?10:32
*** sapd1 has joined #openstack-cinder10:34
whoami-rajatruffian_sheep: also can check out [1] for setting up 3rd party CI for your driver.10:44
whoami-rajat[1] https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers10:44
*** bal has joined #openstack-cinder10:44
*** dviroel_ has joined #openstack-cinder10:47
*** udesale has quit IRC10:56
*** udesale has joined #openstack-cinder10:56
openstackgerritGorka Eguileor proposed openstack/cinderlib master: Support setting attach_mode  https://review.openstack.org/64301610:56
*** udesale has quit IRC11:15
*** udesale has joined #openstack-cinder11:15
*** henriqueof has joined #openstack-cinder11:25
*** udesale has quit IRC11:27
*** udesale has joined #openstack-cinder11:28
*** pcaruana has joined #openstack-cinder11:32
*** alkhodos has quit IRC11:33
*** thgcorrea has joined #openstack-cinder11:33
ruffian_sheepe0ne:thx!I will read it !11:38
ruffian_sheepwhoami-rajat:thx,dude!11:38
*** carlos_silva has joined #openstack-cinder11:41
*** dave-mccowan has joined #openstack-cinder11:46
jungleboyjwhoami-rajat:  Afternoon.  Looks like a busy night trying to get the gate working again.11:55
openstackgerritfutaotao proposed openstack/cinder master: Modify the configuration mode of FusionStorage Cinder Driver  https://review.openstack.org/63298311:57
*** ruffian_sheep has quit IRC11:57
whoami-rajatjungleboyj: Afternoon. Indeed. I'm glad we could fix everything in time.12:00
jungleboyjIt looks like there is still a failure in the latest test.  Unrelated though?12:01
whoami-rajatWhere ? Can you provide the link.12:02
jungleboyjhttp://zuul.openstack.org/status12:04
jungleboyjhttp://logs.openstack.org/30/643130/5/check/neutron-tempest-linuxbridge/d2e76ec/12:05
*** abishop has joined #openstack-cinder12:05
whoami-rajatjungleboyj: at a glance looks unrelated. It passed earlier but frickler updated it to just add a comment so it should be fine.12:11
jungleboyjOk.  Can you recheck.  Need to get my kids to school.12:19
*** enriquetaso has joined #openstack-cinder12:23
*** senrique_ has joined #openstack-cinder12:23
whoami-rajatjungleboyj: sure, done.12:28
*** senrique_ has quit IRC12:31
*** e0ne has quit IRC12:31
*** eharney has quit IRC12:32
*** zhubx007 has quit IRC12:44
*** zhubx007 has joined #openstack-cinder12:45
*** dklyle has joined #openstack-cinder13:01
*** bal2 has joined #openstack-cinder13:04
*** dpawlik has quit IRC13:07
*** mriedem has joined #openstack-cinder13:08
openstackgerritGorka Eguileor proposed openstack/cinderlib master: Add DevStack plugin  https://review.openstack.org/64301413:16
*** enriquetaso has quit IRC13:22
*** vishakha has quit IRC13:24
*** eharney has joined #openstack-cinder13:24
jungleboyjwhoami-rajat:  Thanks!13:26
*** e0ne has joined #openstack-cinder13:32
*** erlon has joined #openstack-cinder13:36
KeithMnemonicI appreciate any review on this os-brick backport to pike https://review.openstack.org/#/c/643120/413:38
*** bal2 has quit IRC13:41
*** bal2 has joined #openstack-cinder13:48
whoami-rajatjungleboyj: I almost forgot it was my patch, I should maintain it :P thanks to you!13:50
jungleboyj:-)  Welcome.13:51
whoami-rajatjungleboyj: seems like everyone is debugging their patches for gate failure, should've made a public announcement regarding the fix :( . https://review.openstack.org/#/c/632549/13:57
jungleboyjYou could send a note to openstack-discuss13:57
whoami-rajatjungleboyj: oh yes, my patch is close to merge but it shouldn't harm to notify everyone right?13:58
jungleboyjright.13:59
*** erlon has quit IRC14:10
whoami-rajatjungleboyj: could you please verify my mail has reached ?14:13
*** rcernin has quit IRC14:17
*** jgriffith has joined #openstack-cinder14:22
*** gnufied has joined #openstack-cinder14:26
*** enriquetaso has joined #openstack-cinder14:28
*** enriquetaso has quit IRC14:29
*** enriquetaso has joined #openstack-cinder14:30
*** zhubx007 has quit IRC14:30
*** zhubx007 has joined #openstack-cinder14:30
*** lpetrut has quit IRC14:38
*** lpetrut has joined #openstack-cinder14:39
*** lseki has joined #openstack-cinder14:52
*** luizbag has quit IRC14:54
*** dpawlik has joined #openstack-cinder14:58
*** luizbag has joined #openstack-cinder15:08
*** luizbag has quit IRC15:10
jungleboyjwhoami-rajat:  It did.15:11
*** lpetrut has quit IRC15:12
whoami-rajatjungleboyj: yay! thanks for the suggestion.15:14
openstackgerritGorka Eguileor proposed openstack/cinderlib master: Enable publish-to-pypi Zuul job  https://review.openstack.org/64301315:15
openstackgerritGorka Eguileor proposed openstack/cinderlib master: Add DevStack plugin  https://review.openstack.org/64301415:15
eharneyelastic-recheck will tell people about this issue when failures happen, if a query is added15:15
*** luizbag has joined #openstack-cinder15:15
*** luizbag has left #openstack-cinder15:16
jungleboyjwhoami-rajat:  Welcome.15:16
*** luizbag has joined #openstack-cinder15:17
jungleboyjeharney:  Oh yeah, we talked about that at the mid-cycle, didn't we?15:17
eharneyjungleboyj: yeah, but i also tried to do this one lately: https://review.openstack.org/#/c/638771/15:18
eharneyjungleboyj: so... i dunno...15:18
eharneyit doesn't really work if nobody merges them15:18
jungleboyj*SMH*15:19
eharneyit's a good theory, though :)15:20
*** mszwed has quit IRC15:21
*** mriedem is now known as mriedem_away15:24
*** zhubx007 has quit IRC15:24
*** dpawlik has quit IRC15:25
*** bal2 has quit IRC15:33
*** bal2 has joined #openstack-cinder15:33
*** zhubx has joined #openstack-cinder15:54
*** sapd1 has quit IRC15:55
hemna_another bug backported to stable/rocky for os-brick16:02
hemna_https://review.openstack.org/#/c/643120/16:02
hemna_that'll need another os-brick release for 1.x16:02
*** Luzi has quit IRC16:03
jungleboyjhemna_:  Thanks for the pointer.16:04
hemna_I'm going to ask keith to push the patch up for 1.x release after that merges16:04
jungleboyjhemna_:  Cool. Sounds like a good deal.16:05
*** jmlowe has quit IRC16:07
*** dpawlik has joined #openstack-cinder16:09
hemna_so reading up on nvme vs nvmeof16:11
hemna_nvmeof is like iscsi vs scsi16:11
hemna_just like whoami-rajat mentioned16:11
hemna_so I'm consued why we don't actually have 2 connectors16:11
hemna_looking at the nvme connector in os-brick16:13
hemna_it looks like it's an nvmeof connector from what I can tell16:13
*** dpawlik has quit IRC16:13
hemna_as it requires a target portal and port16:13
hemna_re: network16:13
hemna_so I think it's worth renaming it to nvmeof16:13
jungleboyjhemna_:  That was what I was trying to say yesterday.  I think they made a mistake ever having NVME there.16:17
hemna_yah16:18
hemna_I was ignorant of what nvmeof was16:18
hemna_vs nvme16:18
hemna_os-brick should also have a bindep on nvme-cli as well16:18
jungleboyjYeah, we should have researched that before letting any of the patches merge.16:18
hemna_and it doesn't currently16:18
hemna_openSUSE, SLES and ubuntu have nvme-cli package16:19
hemna_not sure of redhat16:19
hemna_when I get free of my work fires, I'll put together a patch to rename and add the bindep16:20
jungleboyjhemna_:  On RedHat is isn't installed by default on their director, compute or controllers.16:23
jungleboyjhemna_: Awesome.  Thank you.16:24
jungleboyjI am glad that you came to the same conclusion after looking again.16:24
*** enriquetaso has quit IRC16:38
*** e0ne has quit IRC16:38
*** dpawlik has joined #openstack-cinder16:48
*** gkadam_ has quit IRC16:50
*** dpawlik has quit IRC16:52
KeithMnemoniclooking for a +A on this please https://review.openstack.org/#/c/643120/16:54
*** mriedem_away is now known as mriedem16:54
KeithMnemonicthanks smcginnis16:57
*** dpawlik has joined #openstack-cinder16:59
*** arne_wiebalck has quit IRC16:59
*** arne_wiebalck has joined #openstack-cinder17:00
whoami-rajathemna_: Hey17:02
hemna_should we backport https://review.openstack.org/#/c/643039/ as well ?17:03
*** dpawlik has quit IRC17:03
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick stable/pike: 'iscsiadm -m session' failure handling  https://review.openstack.org/64340017:03
mriedemjbernard: this breaks the ceph job on stable branches https://review.openstack.org/#/c/638499/17:05
smcginnishemna_: That has to go to queens yet17:05
mriedemdevstack-plugin-ceph is branchless17:05
mriedembut rbd multiattach support is stein-only17:05
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick stable/queens: 'iscsiadm -m session' failure handling  https://review.openstack.org/64340117:06
hemna_smcginnis:ok there is queens17:06
*** udesale has quit IRC17:06
mriedemhttps://bugs.launchpad.net/devstack-plugin-ceph/+bug/182009817:07
openstackLaunchpad bug 1820098 in devstack-plugin-ceph "devstack-plugin-ceph-tempest jobs broken with multiattach tests on stable branches" [Undecided,New]17:07
mriedemgmann: ^17:07
whoami-rajathemna_: was going through the os-brick docs[1], i think including the nvmeof connector here would be great.17:07
whoami-rajat[1] https://docs.openstack.org/os-brick/latest/reference/os_brick/initiator/connector.html17:07
mriedemat some point here devstack-plugin-ceph probably needs to be branched17:07
hemna_whoami-rajat:hrmm that's all the connectors in the docs?!17:08
whoami-rajathemna_: yeah, we're missing a lot.17:08
hemna_doh ok17:08
hemna_we need the os-brick equivalent to the drivers docs page that cinder has17:09
gmannmriedem:  we should have create the two variant of that job with multiattach enable only for stein onwards17:09
smcginnishemna_: Not a bad idea.17:09
mriedemgmann: with different names?17:09
gmannmriedem: did not notice that during that patch. i will push17:09
gmannmriedem: with same name we can do17:09
mriedemgmann: ok thanks17:10
gmannso no effect on usage side17:10
*** dpawlik has joined #openstack-cinder17:11
whoami-rajathemna_: i'm not sure why connectors merged without adding doc info.17:11
whoami-rajathemna_: is it good if we add or the vendor should add for their drivers?17:12
eharneywhoami-rajat: i think the rbd connector has the info in the driver.  but nobody added it to connector.rst.  probably the same for some others...17:13
*** dpawlik has quit IRC17:15
whoami-rajateharney: ok. was going through the commit history of added connectors and couldn't find any doc info added. was curious if it existed anywhere else.17:20
eharneywhoami-rajat: the link you linked above is just doc info that's generated from comments in the code -- there's not much doc there other than a list of the methods and parameters they take.  so there wouldn't be commits for that...17:20
*** psachin has quit IRC17:21
whoami-rajateharney: oh ok. the commits makes sense now. just wanted to explore it more so went for the docs, could you please suggest any other way to get more familiar with os-brick.17:25
jungleboyjwhoami-rajat:  Yay, 643092 is finally in the queue!17:26
*** sahid has quit IRC17:27
whoami-rajatjungleboyj: wow, the devstack patch merged, so our gate is fixed now.17:28
* jungleboyj celebrates17:28
gmannmriedem: https://review.openstack.org/#/c/643402/17:30
gmannwhoami-rajat: jungleboyj \o/. can you recheck cinder gate if all good there.17:31
whoami-rajatgmann: just rechecked this recent failure https://review.openstack.org/#/c/632549/17:32
gmannthanks17:33
jungleboyjgmann:  Yeah, will start working on rechecking things where necessary.17:33
gmanncool, i think this was the last gate block fix for bionic migration. happy now. thanks whoami-rajat jungleboyj for help and coordination17:35
jungleboyjgmann:  Thanks for your help as well.17:35
whoami-rajatgmann: Thanks17:35
*** e0ne has joined #openstack-cinder17:46
*** enriquetaso has joined #openstack-cinder17:51
*** eharney has quit IRC17:54
*** enriquetaso has quit IRC18:04
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick master: Rename nvme to nvmeof  https://review.openstack.org/64342118:27
hemna_ ok, so how much did I just break by that patch :P18:27
* hemna_ ducks18:27
hemna_smcginnis: so, I'm lookin at the cinder interface stuffs you did a while back18:33
*** e0ne has quit IRC18:33
hemna_and was thinking of using that same mechanism for os-brick and it's connectors18:33
hemna_since they all need to basically implement all the same public methods18:33
hemna_and it would also allow me to generate the connectors list in the same way that cinder does18:34
hemna_re: documentation, etc18:34
hemna_smcginnis:thoughts?18:34
hemna_currently os-brick uses abc stuffs18:36
hemna_https://github.com/openstack/os-brick/blob/master/os_brick/initiator/initiator_connector.py18:37
hemna_that's the base of all connectors18:37
hemna_cinder has a mix of abc + cinder interface stuffs18:37
*** e0ne has joined #openstack-cinder18:40
*** eharney has joined #openstack-cinder18:43
*** gmann is now known as gmann_afk18:51
jungleboyjhemna_:  So, I think we made the high level decision a few mid-cycles ago that ABC wasn't doing what we had hoped and that was how we ended up with what Sean did.19:00
jungleboyjSo, I would say that taking os-brick in the same direction is a good call.  Especially if it ends up in more consistent documentation.19:00
hemna_os-brick has had abc in place for ages now19:08
hemna_I suppose I can just use what's in place to extract the existing connectors19:08
hemna_to gen docs19:08
*** bal has quit IRC19:09
hemna_abc in cinder seems like a mess in it's current state19:09
*** thgcorrea has quit IRC19:09
hemna_at least wrt the drivers19:09
*** bal has joined #openstack-cinder19:09
*** mvkr has quit IRC19:10
jungleboyjhemna_:  That doesn't surprise me.19:16
*** bal_ has joined #openstack-cinder19:26
*** bal has quit IRC19:27
*** bal_ has quit IRC19:42
smcginnishemna_: Yeah, os-brick's use of ABCs might be better. Cinder's is an absolute mess that I wish we could have cleaned up, but not holding out much hope for it19:50
smcginnisIf the interface stuff works with os-brick for being able to generate that stuff, that's great.19:50
*** dpawlik has joined #openstack-cinder19:51
*** dpawlik has quit IRC19:56
*** dpawlik has joined #openstack-cinder20:02
*** dpawlik has quit IRC20:07
eharneyi had started down the route of removing the abc stuff from cinder a while ago, should we start looking at that again?20:22
*** abishop has quit IRC21:12
*** itlinux has joined #openstack-cinder21:17
*** dpawlik has joined #openstack-cinder21:23
*** mriedem is now known as mriedem_away21:27
*** dpawlik has quit IRC21:27
*** whoami-rajat has quit IRC21:31
smcginniseharney: I would like to, but also not sure if we have enough incentive to do it now with less involvement and less new drivers coming in every cycle.21:35
*** dpawlik has joined #openstack-cinder22:09
*** dpawlik has quit IRC22:13
*** pcaruana has quit IRC22:21
*** e0ne has quit IRC22:28
*** gmann_afk is now known as gmann22:40
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick master: Rename nvme to nvmeof  https://review.openstack.org/64342122:41
*** rcernin has joined #openstack-cinder23:00
*** tkajinam has joined #openstack-cinder23:02
*** martinkennelly has quit IRC23:09
*** mvkr has joined #openstack-cinder23:18
*** lseki has quit IRC23:19
*** mriedem_away has quit IRC23:23
*** dviroel_ has quit IRC23:25

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!