Tuesday, 2019-04-02

*** lseki has quit IRC00:44
*** abishop has quit IRC00:49
*** Liang__ has joined #openstack-cinder00:50
*** markvoelker has joined #openstack-cinder00:55
*** Liang__ is now known as LiangFang00:59
*** luksky has quit IRC01:08
*** LiangFang has quit IRC01:14
*** enriquetaso has quit IRC01:15
*** Liang__ has joined #openstack-cinder01:24
*** Liang__ is now known as LiangFang01:26
*** whoami-rajat has joined #openstack-cinder01:31
*** brinzhang has joined #openstack-cinder01:35
*** brinzhang has quit IRC01:47
*** brinzhang has joined #openstack-cinder01:48
*** rcernin_ has joined #openstack-cinder02:05
*** rcernin has quit IRC02:06
*** rcernin_ has quit IRC02:12
*** openstackgerrit has joined #openstack-cinder02:14
openstackgerritJay Bryant proposed openstack/cinder master: Add Upgrade Check for Drivers Removed in Stein  https://review.openstack.org/64920902:14
*** rcernin has joined #openstack-cinder02:15
openstackgerritRyan Liang proposed openstack/cinder master: VNX: add option vnx_async_migrate  https://review.openstack.org/63927702:39
openstackgerritRyan Liang proposed openstack/cinder master: VNX: delete the LUN from VNX backend  https://review.openstack.org/60590402:43
*** gkadam has joined #openstack-cinder02:48
*** gkadam has quit IRC02:50
*** psachin has joined #openstack-cinder03:14
*** spsurya has joined #openstack-cinder03:31
*** brinzhang has quit IRC03:45
*** brinzhang has joined #openstack-cinder03:46
openstackgerritRyan Liang proposed openstack/cinder master: Unity: add option to delete attached snapshots  https://review.openstack.org/61151503:47
*** udesale has joined #openstack-cinder04:11
*** LiangFang has quit IRC04:14
*** Liang__ has joined #openstack-cinder04:15
*** adriant has quit IRC05:07
*** adriant has joined #openstack-cinder05:08
*** pcaruana has joined #openstack-cinder05:35
*** markvoelker has quit IRC05:58
*** openstackgerrit has quit IRC06:09
*** markvoelker has joined #openstack-cinder06:29
*** dpawlik has joined #openstack-cinder06:44
*** sahid has joined #openstack-cinder07:03
*** pck has quit IRC07:14
*** pck has joined #openstack-cinder07:14
*** luksky has joined #openstack-cinder07:14
*** e0ne has joined #openstack-cinder07:16
*** ircuser-1 has quit IRC07:23
*** Liang__ has quit IRC07:40
*** Liang__ has joined #openstack-cinder07:42
*** zul has quit IRC07:44
*** helenafm has joined #openstack-cinder07:57
*** e0ne has quit IRC08:01
*** e0ne has joined #openstack-cinder08:08
*** ZhangYang_ has joined #openstack-cinder08:09
*** gkadam has joined #openstack-cinder08:10
*** tkajinam has quit IRC08:21
*** sdin has quit IRC08:21
*** openstackgerrit has joined #openstack-cinder09:02
openstackgerritRajat Dhasmana proposed openstack/cinder master: Replace HTTP numeric codes with constants  https://review.openstack.org/64924609:02
*** e0ne has quit IRC09:07
*** davidsha has joined #openstack-cinder09:11
*** rcernin has quit IRC09:11
*** e0ne has joined #openstack-cinder09:15
*** davidsha has quit IRC09:22
*** ZhangYang_ has quit IRC09:23
*** sapd1_x has joined #openstack-cinder09:26
*** davidsha has joined #openstack-cinder09:28
*** Liang__ has quit IRC09:34
*** sapd1_x has quit IRC09:46
*** e0ne has quit IRC09:51
*** zigo has joined #openstack-cinder09:57
*** e0ne has joined #openstack-cinder10:28
*** e0ne has quit IRC10:45
*** e0ne has joined #openstack-cinder10:52
*** carlos_silva has joined #openstack-cinder11:04
*** erlon_ has joined #openstack-cinder11:06
*** _alastor_ has quit IRC11:08
*** udesale has quit IRC11:10
*** lemko has joined #openstack-cinder11:47
*** abishop has joined #openstack-cinder11:54
*** e0ne has quit IRC11:56
*** e0ne has joined #openstack-cinder12:03
*** sapd1_x has joined #openstack-cinder12:10
*** thgcorrea has joined #openstack-cinder12:16
*** markvoelker has quit IRC12:25
*** markvoelker has joined #openstack-cinder12:25
*** e0ne has quit IRC12:31
*** jmlowe has quit IRC12:34
*** brinzhang has quit IRC12:39
*** e0ne has joined #openstack-cinder12:44
*** eharney has joined #openstack-cinder12:50
*** mriedem has joined #openstack-cinder12:52
*** mriedem has left #openstack-cinder13:08
*** mriedem has joined #openstack-cinder13:09
*** lseki has joined #openstack-cinder13:20
*** lpetrut has joined #openstack-cinder13:26
*** trident has quit IRC13:30
*** trident has joined #openstack-cinder13:33
openstackgerritJay Bryant proposed openstack/cinder master: Add upgrade check for Windows iSCSI driver.  https://review.openstack.org/64919313:35
*** e0ne has quit IRC13:36
*** e0ne has joined #openstack-cinder13:42
*** e0ne has quit IRC13:43
*** helenafm has quit IRC13:44
*** eharney_ has joined #openstack-cinder13:52
*** eharney has quit IRC13:55
*** lpetrut has quit IRC14:00
*** sapd1_x has quit IRC14:08
*** e0ne has joined #openstack-cinder14:10
*** smcginnis_pto is now known as smcginnis14:16
*** sapd1_x has joined #openstack-cinder14:22
*** helenafm has joined #openstack-cinder14:24
*** dpawlik has quit IRC14:26
*** Liang__ has joined #openstack-cinder14:51
openstackgerritEric Harney proposed openstack/python-cinderclient master: Remove bash-completion calls from base.py  https://review.openstack.org/64935714:55
*** lpetrut has joined #openstack-cinder14:59
*** Liang__ is now known as LiangFang14:59
*** e0ne has quit IRC15:11
*** lpetrut has quit IRC15:14
*** eharney_ has quit IRC15:23
*** helenafm has quit IRC15:26
*** LiangFang has quit IRC15:29
openstackgerritSean McGinnis proposed openstack/cinder master: Add upgrade checker for backup driver path  https://review.openstack.org/64792715:31
openstackgerritSean McGinnis proposed openstack/cinder master: Add upgrade checker for backup driver path  https://review.openstack.org/64792715:32
*** e0ne has joined #openstack-cinder15:38
*** sapd1_x has quit IRC15:44
jungleboyjsmcginnis:  Would be nice to get that in so that I can rebase and add in my UTs.16:04
*** imacdonn has joined #openstack-cinder16:12
*** e0ne has quit IRC16:28
*** ircuser-1 has joined #openstack-cinder16:34
*** _alastor_ has joined #openstack-cinder16:37
*** _alastor_ has quit IRC16:39
*** _alastor_ has joined #openstack-cinder16:39
*** davidsha has quit IRC16:47
openstackgerritMerged openstack/python-cinderclient master: Tests: Don't write bash-completion cache files  https://review.openstack.org/63942216:51
*** gkadam has quit IRC17:02
*** dpawlik has joined #openstack-cinder17:09
*** eharney has joined #openstack-cinder17:11
*** sahid has quit IRC17:12
*** dpawlik has quit IRC17:15
*** erlon has joined #openstack-cinder17:20
*** jmlowe has joined #openstack-cinder17:28
*** eharney has quit IRC17:37
*** jmlowe has quit IRC17:37
*** psachin has quit IRC17:55
*** eharney has joined #openstack-cinder18:02
*** e0ne has joined #openstack-cinder18:04
openstackgerritEric Harney proposed openstack/python-cinderclient master: Remove bash-completion calls from base.py  https://review.openstack.org/64935718:09
*** jmlowe has joined #openstack-cinder18:11
openstackgerritMerged openstack/cinderlib master: Fix RBD connector  https://review.openstack.org/64301518:16
*** lemko has quit IRC18:17
*** spsurya has quit IRC18:32
openstackgerritMerged openstack/cinder stable/pike: Fix Snapshot object metadata loading  https://review.openstack.org/64493918:35
*** sonivi has joined #openstack-cinder18:36
openstackgerritMerged openstack/cinder stable/queens: Set right attach mode after migration  https://review.openstack.org/64797518:38
*** sonivi has quit IRC18:39
*** dpawlik has joined #openstack-cinder18:58
*** dpawlik has quit IRC19:02
*** gmann is now known as gmann_afk19:04
jungleboyjrosmaita: Hey, I saw your comment about the opts.py change.19:17
rosmaitadoes it make sense?19:18
jungleboyjI helped write that code back in the day.  Need to take a look at it but I think you are right.19:18
jungleboyjI could push up a patch to address that and make this depending upon it.19:19
rosmaitajungleboyj: there's probably a more elegant way to do it, but i was thinking just exclude cmd/status.py, because the registering of options there is going to be kind of weird out of necessity19:20
*** e0ne has quit IRC19:20
*** erlon_ has quit IRC19:22
jungleboyjrosmaita:  Agreed.19:23
smcginnisjungleboyj: For some reason I had to register those opts to get things to work at first, but apparently fixed things so it's no longer necessary.19:24
smcginnisjungleboyj: May want to make sure you actually need to do that.19:25
jungleboyjsmcginnis:  Interesting.  Ok.  I will take a lot at what you did and compare what I have and verify if it is still an issue.19:25
smcginnisLoading the volume manager I *think* should have taken care of it for you.19:25
smcginnisjungleboyj: Oh, that may be different with the need to make sure driver configs are loaded.19:28
smcginnisI wonder if it would be simpler in this case to just look up which cinder.conf file is being used and just do a grep of it.19:29
jungleboyjHmmm, I had thought about going with that approach but then we run the risk of failing if they have disabled configs in there.  It seems like it would much more error prone.19:31
jungleboyjIf I check enabled drivers and try to piece it together then I am just recreating the oslo.config code.19:32
*** ianychoi has quit IRC19:32
* jungleboyj definitely doesn't want to do that.19:32
smcginnisoslo.config doesn't come in to play then other than to find out which config file is being used.19:32
*** ianychoi has joined #openstack-cinder19:33
jungleboyjWhat I am saying is if I go to just grepping through the config file it is possible that the will have volume_driver set in a config section that isn't being used.  The current approach ensures that we will only fail the check if the driver is enabled.19:35
smcginnisIt would be kind of odd if they left it in their config, but I see what you're saying.19:39
jungleboyjI think it isn't that unlikely to leave old configs in there for reference and control things with enabled_backends.  I do that frequently.19:39
smcginnis*cough* *cough* sloppy *cough*19:40
openstackgerritEric Harney proposed openstack/cinder master: Reserve migrations for DB backports  https://review.openstack.org/64943619:40
smcginniseharney: Thanks, I thought of that last week and promptly forgot.19:40
eharneysmcginnis: it's quite a fun ritual at this point :)19:41
smcginnisI *think* moving to alembic will help get rid of that.19:41
smcginnisProbably bring a few other headaches, but at least that one will be gone. ;)19:41
eharneyyep, i was just thinking that of all things, this might be what motivates that along19:41
*** jmlowe has quit IRC19:47
*** dpawlik has joined #openstack-cinder19:48
*** dpawlik has quit IRC19:53
*** thgcorrea has quit IRC20:03
*** jmlowe has joined #openstack-cinder20:03
jungleboyjsmcginnis:  Fixing genopts is literally a one line fix.20:04
jungleboyjOk.  I will put up a patch a little later for that as it is something we should do anyway and update my existing patch.20:09
*** markvoelker has quit IRC20:23
*** pcaruana has quit IRC20:30
*** whoami-rajat has quit IRC20:30
*** abishop has quit IRC20:50
openstackgerritSean McGinnis proposed openstack/cinder master: Add upgrade check for presence of policy.json file  https://review.openstack.org/64793720:55
*** erlon has quit IRC21:06
rosmaitasmcginnis: nice tests on ^^ -- and now i know how to make sure configuration is initialized (that's where i gave up last night)21:30
smcginnisrosmaita: That was killing me last week as I was trying to get out of here.21:32
*** luksky has quit IRC21:32
rosmaitayeah, it's not as obvious as you'd think!21:33
smcginnisrosmaita: As is usually the case, getting away from it for a bit helped see things a little more clearly. (and tips from Ben) ;)21:33
rosmaitasmcginnis: jungleboyj: i'm still holding off on proposing RC-2 until we get the upgrade checker stuff in; let me know if you think we need to pivot on that21:37
smcginnisWe have a doc build failure now with the recently released sphinx 2.0. I should have a fix up shortly. We'll need to push that one through before these pass check.21:41
rosmaitai am a dope -- i looked in kibana and saw only 9 of those over the last 12 hours, figured it was some random thing -- guess we'll see more and more as updates happen21:43
smcginnisI was this close to rechecking earlier but saw some other things going on due to sphinx elsewhere so took a closer look.21:45
rosmaitais there really a problem with those code blocks? look like valid json to me21:51
smcginnisJSON doesn't like trailing commas, quotes are " not ', and it's true/false not True/False. So finding a lot of really trivial and difficult to notice problems.21:56
rosmaitasmcginnis: that does not sound conducive to a speedy resolution22:00
smcginnisrosmaita: It's proving exceedingly frustrating.22:00
smcginnisMostly because it's making me realize how bad my eyes are getting. :)22:01
rosmaitaand i wonder why upper contstraints are being modified at RC-time :(22:01
smcginnisSomeone mentioned they thought the sphinx changes only affected master, but I'm pretty sure we're going to hit it on stable/stein too.22:02
smcginnisReally bad timing of a tool, not a requirement, releasing a major release at a very bad time and us not paying attention to the deprecation warnings that have been there for months (or years).22:03
rosmaitaarrrrgh!!! plus, we can't even get to stable/stein until we get past master22:03
smcginnisLooks like I got them all.22:03
smcginnisFinal test pass to make sure and I'll push it up.22:03
rosmaitamy eyesight doesn't let me see deprecation warnings ;)22:03
openstackgerritSean McGinnis proposed openstack/cinder master: Fix code-block JSON format issues  https://review.openstack.org/64945822:06
smcginnisrosmaita, eharney, jungleboyj: We'll want that through fairly quickly.22:06
smcginnisThanks eharney22:08
smcginnisrosmaita: See how trivial those things were. :)22:10
smcginnisThey're even just stuff inside a docstring.22:10
rosmaitai did not see that False in attachment.py, and i looked really carefully22:12
rosmaitaor so i thought22:12
smcginnisIt really helped once I figured out to paste the block into jsonlint.com22:12
rosmaitawell, you know, i did that -- i thought they both validated, but now i think i must've pasted the same block in there twice22:13
rosmaitaa control-c in emacs is not a copy command22:13
smcginnisvim neither22:14
smcginnisThe False/false thing might not have been a real issue this time, but according to the spec it is case sensitive, so better fix it now rather than run into this again.22:15
rosmaitai agree, and the quotes and commas are a big deal22:16
rosmaitawhen you read json through a yaml parser it lets you get away with that22:16
*** rcernin has joined #openstack-cinder22:25
*** tkajinam has joined #openstack-cinder22:55
jungleboyjI will push your patch through as soon as it passes check.22:57
*** gmann_afk is now known as gmann23:11
*** lseki has quit IRC23:19

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!