*** dviroel_ has quit IRC | 00:24 | |
*** brinzhang has joined #openstack-cinder | 00:26 | |
*** Liang__ has joined #openstack-cinder | 00:46 | |
jungleboyj | +W | 01:02 |
---|---|---|
smcginnis | jungleboyj: Thanks | 01:07 |
jungleboyj | Welcome. Thanks for getting it fixed. | 01:07 |
smcginnis | Luckily it was a fairly easy one. | 01:08 |
*** benj_- has joined #openstack-cinder | 01:11 | |
*** mszwed has quit IRC | 01:12 | |
*** benj_ has quit IRC | 01:12 | |
*** kklimonda has quit IRC | 01:12 | |
*** spotz has quit IRC | 01:12 | |
*** kklimonda has joined #openstack-cinder | 01:12 | |
*** mmethot has quit IRC | 01:19 | |
*** Liang__ is now known as LiangFang | 01:20 | |
*** thingee has quit IRC | 01:26 | |
*** whoami-rajat has joined #openstack-cinder | 01:57 | |
*** mriedem has quit IRC | 02:07 | |
*** spsurya has joined #openstack-cinder | 02:12 | |
*** gkadam has joined #openstack-cinder | 02:37 | |
openstackgerrit | Jay Bryant proposed openstack/cinder master: Remove scanning upgrade checker from opts generation https://review.openstack.org/649494 | 02:51 |
openstackgerrit | Jay Bryant proposed openstack/cinder master: Remove scanning upgrade checker from opts generation https://review.openstack.org/649494 | 03:01 |
openstackgerrit | Jay Bryant proposed openstack/cinder master: Add upgrade check for Windows iSCSI driver. https://review.openstack.org/649193 | 03:01 |
openstackgerrit | Jay Bryant proposed openstack/cinder master: Add Upgrade Check for Drivers Removed in Stein https://review.openstack.org/649209 | 03:01 |
*** psachin has joined #openstack-cinder | 03:16 | |
*** zhubx has joined #openstack-cinder | 03:17 | |
*** zhubx has quit IRC | 03:30 | |
*** zhubx has joined #openstack-cinder | 03:31 | |
*** udesale has joined #openstack-cinder | 04:00 | |
*** brinzhang has quit IRC | 04:11 | |
*** brinzhang has joined #openstack-cinder | 04:11 | |
*** whoami-rajat has quit IRC | 04:57 | |
*** abhishekk has joined #openstack-cinder | 05:26 | |
*** lemko has joined #openstack-cinder | 05:42 | |
*** mszwed has joined #openstack-cinder | 06:16 | |
openstackgerrit | Merged openstack/cinder master: Fix code-block JSON format issues https://review.openstack.org/649458 | 06:18 |
openstackgerrit | Yong Huang proposed openstack/cinder master: Convert float type value of QoS specs to interger https://review.openstack.org/616125 | 06:34 |
*** pcaruana has joined #openstack-cinder | 06:36 | |
*** pcaruana has quit IRC | 06:38 | |
*** pcaruana has joined #openstack-cinder | 06:38 | |
*** dpawlik has joined #openstack-cinder | 06:47 | |
*** luksky has joined #openstack-cinder | 06:50 | |
*** tkajinam has quit IRC | 06:58 | |
openstackgerrit | Yong Huang proposed openstack/cinder master: Add create, delete server volume methods for nova api https://review.openstack.org/649515 | 07:00 |
*** tkajinam has joined #openstack-cinder | 07:03 | |
*** whoami-rajat has joined #openstack-cinder | 07:13 | |
*** jistr is now known as jistr|afk | 07:22 | |
*** e0ne has joined #openstack-cinder | 07:27 | |
*** sahid has joined #openstack-cinder | 07:28 | |
*** sdinescu has joined #openstack-cinder | 07:35 | |
*** sdin has joined #openstack-cinder | 07:35 | |
*** helenafm has joined #openstack-cinder | 07:44 | |
*** lennyb has joined #openstack-cinder | 08:04 | |
*** e0ne has quit IRC | 08:07 | |
*** sdinescu has quit IRC | 08:11 | |
*** sdin has quit IRC | 08:11 | |
*** sdinescu has joined #openstack-cinder | 08:12 | |
*** sdin has joined #openstack-cinder | 08:12 | |
*** e0ne has joined #openstack-cinder | 08:15 | |
*** e0ne has quit IRC | 08:17 | |
*** e0ne has joined #openstack-cinder | 08:24 | |
*** e0ne has quit IRC | 08:26 | |
*** lemko has quit IRC | 08:31 | |
*** abhishekk has quit IRC | 08:33 | |
*** tkajinam has quit IRC | 08:45 | |
*** luksky has quit IRC | 08:46 | |
*** LiangFang has quit IRC | 08:59 | |
*** luksky has joined #openstack-cinder | 09:18 | |
*** whoami-rajat has quit IRC | 09:37 | |
*** luizbag has quit IRC | 09:40 | |
*** markvoelker has joined #openstack-cinder | 09:55 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Fix get_connector_properties https://review.openstack.org/649552 | 10:00 |
*** e0ne has joined #openstack-cinder | 10:03 | |
*** e0ne has quit IRC | 10:11 | |
*** e0ne has joined #openstack-cinder | 10:15 | |
*** markvoelker has quit IRC | 10:27 | |
*** Dinesh_Bhor has quit IRC | 10:34 | |
*** erlon has joined #openstack-cinder | 10:38 | |
*** e0ne has quit IRC | 10:53 | |
*** mvkr has quit IRC | 11:01 | |
*** jistr|afk is now known as jistr | 11:02 | |
*** helenafm has quit IRC | 11:04 | |
*** hoonetorg has joined #openstack-cinder | 11:16 | |
*** markvoelker has joined #openstack-cinder | 11:24 | |
*** brinzhang has quit IRC | 11:24 | |
*** dviroel_ has joined #openstack-cinder | 11:25 | |
*** udesale has quit IRC | 11:26 | |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Remove non-exception from EXCEPTION_DETAIL_MAPPINGS https://review.openstack.org/648309 | 11:34 |
*** rcernin has quit IRC | 11:38 | |
*** abishop has joined #openstack-cinder | 11:40 | |
*** mvkr has joined #openstack-cinder | 11:54 | |
*** markvoelker has quit IRC | 11:57 | |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Add upgrade checker for backup driver path https://review.openstack.org/647927 | 11:58 |
*** luizbag has joined #openstack-cinder | 12:02 | |
*** odyssey4me has quit IRC | 12:12 | |
*** whoami-rajat has joined #openstack-cinder | 12:19 | |
*** e0ne has joined #openstack-cinder | 12:20 | |
*** odyssey4me has joined #openstack-cinder | 12:26 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Publish backup capabilities to a scheduler https://review.openstack.org/620881 | 12:27 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Create backups via scheduler https://review.openstack.org/630305 | 12:27 |
*** eharney has quit IRC | 12:33 | |
*** mmethot has joined #openstack-cinder | 12:36 | |
*** enriquetaso has joined #openstack-cinder | 12:45 | |
*** helenafm has joined #openstack-cinder | 12:54 | |
*** jmlowe has quit IRC | 12:57 | |
*** gaoyan has joined #openstack-cinder | 13:00 | |
*** Alon_KS has joined #openstack-cinder | 13:09 | |
Alon_KS | Hi, i think i just hit a bug with cinder | 13:10 |
*** lemko has joined #openstack-cinder | 13:10 | |
whoami-rajat | Alon_KS: Hi, can you elaborate? | 13:10 |
Alon_KS | "Deadlock found when trying to get lock; try restarting transaction" when trying to delete/create multiple volumes at the same time | 13:10 |
*** mriedem has joined #openstack-cinder | 13:10 | |
*** lseki has joined #openstack-cinder | 13:11 | |
Alon_KS | running openstack queens (cinder-17.1.9) | 13:11 |
Alon_KS | https://pastebin.com/Hp6Ztg8K | 13:15 |
whoami-rajat | Alon_KS: Hmm, it shouldn't occur, the fix was backported to queens [1] | 13:16 |
whoami-rajat | [1] https://github.com/openstack/cinder/blob/stable/queens/cinder/db/sqlalchemy/api.py#L1611 | 13:16 |
whoami-rajat | but looks like it isn't the most efficient solution | 13:16 |
smcginnis | whoami-rajat, Alon_KS: That might not have made it out to a stable release yet? | 13:18 |
smcginnis | Not sure what Cinder 17.1.9 is though. We're only on 14 for stein. | 13:19 |
Alon_KS | should i look into cinder-api also and search for the trigger? the main issue is that the cinder fails and affect the whole openstack environment | 13:19 |
Alon_KS | 17.1.9 is the latest version of queens, the cinder is just the venv created via openstack-ansible | 13:20 |
*** erlon has quit IRC | 13:20 | |
whoami-rajat | smcginnis: yeah, that might be the possibility. | 13:21 |
*** thgcorrea has joined #openstack-cinder | 13:22 | |
smcginnis | The latest version of ansible for cinder? | 13:24 |
Alon_KS | the latest version of openstack-ansible which include whole openstack services | 13:24 |
openstackgerrit | wanghao proposed openstack/cinder master: Support Incremental Backup Completion In RBD https://review.openstack.org/627941 | 13:26 |
*** dklyle has quit IRC | 13:30 | |
smcginnis | Alon_KS, whoami-rajat: Looks like the fix was included in Cinder 12.0.5. Ansible probably needs to be updated to pull in a newer stable release. | 13:30 |
*** dklyle has joined #openstack-cinder | 13:31 | |
Alon_KS | i think the fix is just for allowing retry performing the task 5 times, not really fixing the root cause | 13:34 |
Alon_KS | and this fix is for "creating a large amount of volumes simultaneously", the same task that im trying to do | 13:35 |
*** e0ne has quit IRC | 13:35 | |
smcginnis | When there a lot of simultaneous create requests, there ends up being some DB contention. So those retries have been shown to make that more robust and not fail right away on deadlocking. | 13:36 |
Alon_KS | mmm i understand | 13:37 |
Alon_KS | what could be the cause for failing the cinder? although its retry a few times before failing the delete/create task. | 13:38 |
whoami-rajat | smcginnis: ++, not really sure which tag of openstack ansible updates the cinder tag but since 17.1.9 is fairly old, i would also recommend updating it. | 13:39 |
Alon_KS | i thought it may also be related to ceph limitations (?), ceph is my cinder backend | 13:39 |
jungleboyj | smcginnis: Ugh, your backup driver check hit a problem in test boot pattern. | 13:45 |
*** Liang__ has joined #openstack-cinder | 13:45 | |
jungleboyj | I am losing faith that we can get these in to Stein without backput. | 13:45 |
smcginnis | jungleboyj: I should just write a bot that automatically comments recheck these days. | 13:45 |
* jungleboyj laughs | 13:45 | |
rosmaita | i wonder if you make 'recheck' the topic, what would happen | 13:46 |
smcginnis | Hah. I think the regex for that specifically looks at just new comments. | 13:46 |
jungleboyj | :-) | 13:47 |
*** e0ne has joined #openstack-cinder | 13:48 | |
jungleboyj | I am in meetings solid until 2 today but will work on getting UT put together for my patches. | 13:48 |
*** jmlowe has joined #openstack-cinder | 13:49 | |
Alon_KS | <smcginnis>, checked my cinder version and it running on 12.0.5, also i looked into api.py and saw the fix in there :/ | 13:51 |
whoami-rajat | jungleboyj: since we're discussing upgrade checks only, i would like to ask my query here rather on patch if its ok, | 13:52 |
whoami-rajat | so we create a check for stein for things changed between rocky-stein from rocky releasenotes | 13:52 |
whoami-rajat | so stein releasenotes (stein-train changes) should create a check for train right? | 13:52 |
jungleboyj | whoami-rajat: No, the checks we are creating are for the things changed in Stein, so when upgrading from rocky->stein. | 13:53 |
*** eharney has joined #openstack-cinder | 13:55 | |
*** udesale has joined #openstack-cinder | 13:56 | |
whoami-rajat | jungleboyj: we created the policy check from rocky releasenotes ? | 13:56 |
smcginnis | Stein release notes. We care about what changed in stein since rocky. | 13:57 |
jungleboyj | whoami-rajat: From Stein release notes. It is what changed in Stein and we check it as they are upgrading to it. | 13:58 |
whoami-rajat | smcginnis: jungleboyj ok. got confused a bit there. Thanks for the clarity. | 14:01 |
*** abishop has quit IRC | 14:01 | |
jungleboyj | whoami-rajat: You are welcome. I understand the confusion. You had me scared for a minute. | 14:02 |
*** Liang__ has quit IRC | 14:03 | |
whoami-rajat | jungleboyj: hah, i'm still curious why we keep the same policy point in both rocky and stein upgrade notes[1] [2] | 14:14 |
whoami-rajat | [1] https://docs.openstack.org/releasenotes/cinder/stein.html#upgrade-notes | 14:14 |
whoami-rajat | [2] https://docs.openstack.org/releasenotes/cinder/rocky.html#upgrade-notes | 14:14 |
rosmaita | whoami-rajat: that's because it was a backport | 14:15 |
*** dklyle has quit IRC | 14:15 | |
whoami-rajat | rosmaita: oh, feature of queens, releasenote added in stein backported to rocky and queens. that had me confused. Thanks. | 14:22 |
*** e0ne has quit IRC | 14:22 | |
*** e0ne has joined #openstack-cinder | 14:23 | |
rosmaita | np, the only reason i'm aware of it is that i did the backports! | 14:24 |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: VNX: delete the LUN from VNX backend https://review.openstack.org/605904 | 14:32 |
openstackgerrit | Eric Harney proposed openstack/cinder stable/rocky: Tests: Fix up migrate notify tests https://review.openstack.org/649634 | 14:33 |
*** e0ne has quit IRC | 14:37 | |
*** dklyle has joined #openstack-cinder | 14:41 | |
*** dpawlik has quit IRC | 14:44 | |
*** e0ne has joined #openstack-cinder | 14:44 | |
*** luksky has quit IRC | 14:47 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: Reserve migrations for DB backports https://review.openstack.org/649436 | 14:58 |
*** abishop has joined #openstack-cinder | 15:03 | |
eharney | do upgrade checkers get removed at some point in the future? | 15:06 |
jungleboyj | eharney: Hmmm, that is a good question. | 15:07 |
jungleboyj | Think it depends on the check? For the ones I have put in I don't think they would ever be removed unless one of the drivers was added back in. | 15:07 |
smcginnis | We can probably drop some after some time. | 15:13 |
*** zhubx has quit IRC | 15:16 | |
*** zhubx has joined #openstack-cinder | 15:16 | |
*** gaoyan has quit IRC | 15:25 | |
*** mvkr has quit IRC | 15:28 | |
openstackgerrit | Eric Harney proposed openstack/python-cinderclient master: Fix shell upload-to-image with no volume type https://review.openstack.org/648157 | 15:36 |
*** e0ne has quit IRC | 15:37 | |
*** e0ne has joined #openstack-cinder | 15:37 | |
openstackgerrit | Eric Harney proposed openstack/python-cinderclient master: Bump default shell API version https://review.openstack.org/647871 | 15:41 |
openstackgerrit | Vadym Markov proposed openstack/cinder stable/ocata: cinder incremental backup with ceph fails if last one deleted https://review.openstack.org/649652 | 15:51 |
*** e0ne has quit IRC | 15:59 | |
*** erlon has joined #openstack-cinder | 16:02 | |
*** dpawlik has joined #openstack-cinder | 16:02 | |
smcginnis | eharney: Not sure if this could end up an issue for Red Hat: https://review.openstack.org/#/c/647481/ | 16:03 |
eharney | smcginnis: iirc, our Nova team hit this problem | 16:04 |
*** e0ne has joined #openstack-cinder | 16:05 | |
*** e0ne has quit IRC | 16:05 | |
*** e0ne has joined #openstack-cinder | 16:06 | |
*** imacdonn has quit IRC | 16:12 | |
*** imacdonn has joined #openstack-cinder | 16:13 | |
*** sahid has quit IRC | 16:16 | |
*** udesale has quit IRC | 16:19 | |
*** psachin has quit IRC | 16:34 | |
*** gkadam has quit IRC | 16:42 | |
*** spsurya has quit IRC | 16:46 | |
*** e0ne has quit IRC | 16:51 | |
*** helenafm has quit IRC | 16:54 | |
*** luksky has joined #openstack-cinder | 16:55 | |
*** dviroel_ is now known as dviroel | 17:01 | |
*** carlos_silva is now known as carloss | 17:05 | |
*** e0ne has joined #openstack-cinder | 17:14 | |
*** e0ne has quit IRC | 17:15 | |
*** v12aml has quit IRC | 17:17 | |
jungleboyj | smcginnis: eharney If I could get some love on this patch it would make my subsequent patches easier. :-) | 17:19 |
jungleboyj | https://review.openstack.org/#/c/649494/2 | 17:19 |
*** erlon has quit IRC | 17:20 | |
*** dviroel has quit IRC | 17:21 | |
*** dviroel has joined #openstack-cinder | 17:21 | |
*** v12aml has joined #openstack-cinder | 17:27 | |
*** spsurya has joined #openstack-cinder | 17:27 | |
*** v12aml has quit IRC | 17:35 | |
*** v12aml has joined #openstack-cinder | 17:39 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinderlib master: DOCFIX: correct syntax of codeblock https://review.openstack.org/649679 | 17:44 |
*** dpawlik has quit IRC | 17:45 | |
whoami-rajat | geguileo: ^^ was going through cinderlib docs, did a simple docfix for | 17:45 |
whoami-rajat | https://docs.openstack.org/cinderlib/latest/topics/backends.html#installed-drivers | 17:45 |
*** jmlowe has quit IRC | 17:52 | |
*** jmlowe has joined #openstack-cinder | 17:55 | |
geguileo | whoami-rajat: thank you! | 18:07 |
*** abishop_ has joined #openstack-cinder | 18:31 | |
*** abishop has quit IRC | 18:31 | |
*** e0ne has joined #openstack-cinder | 18:48 | |
*** jmlowe has quit IRC | 18:57 | |
*** carloss has quit IRC | 19:09 | |
*** abishop_ has quit IRC | 19:13 | |
*** abishop_ has joined #openstack-cinder | 19:22 | |
*** abishop_ is now known as abishop | 19:22 | |
*** e0ne has quit IRC | 19:30 | |
openstackgerrit | Merged openstack/cinder master: Add NetApp E-Series Driver to Removal List https://review.openstack.org/647891 | 19:31 |
*** erlon has joined #openstack-cinder | 19:32 | |
*** eharney has quit IRC | 19:37 | |
*** jmlowe has joined #openstack-cinder | 19:48 | |
rosmaita | jungleboyj: smcginnis: how are we looking for rc2 ? | 20:00 |
jungleboyj | Well, I have UT for one patch done. | 20:00 |
jungleboyj | Still having fun trying to get patches merged though. | 20:00 |
rosmaita | yeah, the gate is moving very slowly | 20:00 |
jungleboyj | Second UT shouldn't be too hard now that I know how to do it. Just trying to figure out if I can use DDT to make this less ugly. | 20:01 |
*** mriedem has quit IRC | 20:01 | |
rosmaita | jungleboyj: and once those get into master, they still need to be backported to stein | 20:02 |
rosmaita | my opinion is cut rc2 now, and if we do manage to get the upgrade checks merged by tomorrow afternoon, we cut rc3 | 20:03 |
*** thgcorrea has quit IRC | 20:04 | |
rosmaita | jungleboyj: i discovered last week that ddt has an 'idata' decorator, don't know if that will help you | 20:04 |
rosmaita | my patch increasing ddt to a more current version is in the gate now | 20:05 |
jungleboyj | rosmaita: Example? | 20:05 |
*** mriedem has joined #openstack-cinder | 20:06 | |
rosmaita | https://review.openstack.org/#/c/648309/4/cinder/tests/unit/message/test_message_field.py@44 | 20:06 |
*** erlon has quit IRC | 20:07 | |
jungleboyj | Hmm, not sure if that will help here. | 20:09 |
rosmaita | yeah, very possibly not | 20:09 |
openstackgerrit | Merged openstack/cinder master: Remove non-exception from EXCEPTION_DETAIL_MAPPINGS https://review.openstack.org/648309 | 20:12 |
openstackgerrit | Merged openstack/cinder master: Remove scanning upgrade checker from opts generation https://review.openstack.org/649494 | 20:12 |
*** whoami-rajat has quit IRC | 20:29 | |
rosmaita | jungleboyj: what are you thinking release-wise for this afternoon? | 20:39 |
* jungleboyj hears the Jeopardy music. | 20:40 | |
smcginnis | I'm thinking we can just go with what we have at this point. | 20:40 |
jungleboyj | I will have my patch updated this afternoon. Whether we can get things merged and backported .... | 20:40 |
smcginnis | Just needed to restart check jobs on that first one about an hour ago, so not likely. | 20:40 |
jungleboyj | smcginnis: Yeah, what happened there? | 20:40 |
smcginnis | If things suddenly speed up we can get an rc3 tomorrow, otherwise we can just see about adding these to a stable release. | 20:41 |
smcginnis | jungleboyj: Just more random failures. | 20:41 |
rosmaita | that sounds good to me (the release, not the random failures) | 20:41 |
jungleboyj | Sadness. | 20:41 |
rosmaita | https://review.openstack.org/649721 | 20:42 |
smcginnis | rosmaita: Going to have to give you the nickname "Quickdraw" | 20:42 |
rosmaita | :) | 20:42 |
rosmaita | i am trying to make up for the cinderclient snafu | 20:42 |
jungleboyj | :-) I am sure everyone has forgotten about that now. | 20:43 |
*** rcernin has joined #openstack-cinder | 20:44 | |
openstackgerrit | Merged openstack/cinderlib master: DOCFIX: correct syntax of codeblock https://review.openstack.org/649679 | 20:51 |
*** spsurya has quit IRC | 20:59 | |
*** mmethot has quit IRC | 21:00 | |
*** pcaruana has quit IRC | 21:06 | |
*** abishop has quit IRC | 21:08 | |
*** eharney has joined #openstack-cinder | 21:21 | |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Document behavior of message.create https://review.openstack.org/648294 | 21:36 |
jungleboyj | smcginnis: rosmaita I have my patches ready to go. Just need to have Sean's first patch merge and then I can rebase and push them up. | 21:36 |
rosmaita | cool | 21:36 |
jungleboyj | And I think my UTs are decent. | 21:37 |
rosmaita | sounds good, i will take a look later | 21:37 |
jungleboyj | Yeah, I will check back later and push things up. | 21:37 |
*** rcernin has quit IRC | 21:42 | |
*** dviroel has quit IRC | 23:01 | |
*** tkajinam has joined #openstack-cinder | 23:04 | |
*** abishop has joined #openstack-cinder | 23:16 | |
*** abishop has quit IRC | 23:25 | |
*** v12aml has quit IRC | 23:41 | |
*** v12aml has joined #openstack-cinder | 23:44 | |
*** lseki has quit IRC | 23:53 | |
*** brinzhang has joined #openstack-cinder | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!