| *** Liang__ has joined #openstack-cinder | 00:49 | |
| *** Liang__ is now known as LiangFang | 00:50 | |
| *** luksky has quit IRC | 00:52 | |
| *** mriedem has quit IRC | 01:09 | |
| *** enriquetaso has quit IRC | 01:23 | |
| *** enriquetaso has joined #openstack-cinder | 01:23 | |
| *** whoami-rajat has joined #openstack-cinder | 02:03 | |
| *** mriedem has joined #openstack-cinder | 02:23 | |
| openstackgerrit | Yong Huang proposed openstack/cinder master: Convert float type value of QoS specs to interger https://review.openstack.org/616125 | 02:24 |
|---|---|---|
| *** markvoelker has joined #openstack-cinder | 02:29 | |
| *** mriedem has quit IRC | 02:29 | |
| *** zhubx has quit IRC | 02:36 | |
| *** psachin has joined #openstack-cinder | 02:43 | |
| *** markvoelker has quit IRC | 02:59 | |
| *** zhubx has joined #openstack-cinder | 03:16 | |
| *** anks2k has joined #openstack-cinder | 03:26 | |
| *** enriquetaso has quit IRC | 03:32 | |
| anks2k | smcginnis: jungleboyj: Greetings. Request you please review https://review.openstack.org/#/c/617503/ with your feedback. OSNEXUS Quantastor CI has been responding to gerrit event stream cinder patches. Would like to really make sure it is in good state to be merged after train opens. Thanks in advance | 03:32 |
| *** markvoelker has joined #openstack-cinder | 03:57 | |
| *** zhubx has quit IRC | 03:57 | |
| *** anks2k has quit IRC | 04:02 | |
| *** zhubx has joined #openstack-cinder | 04:03 | |
| *** udesale has joined #openstack-cinder | 04:09 | |
| *** markvoelker has quit IRC | 04:29 | |
| *** erlon has joined #openstack-cinder | 04:44 | |
| *** pcaruana has joined #openstack-cinder | 04:58 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder stable/queens: Check Volume Status on attachment create/update https://review.openstack.org/647974 | 05:08 |
| *** adriant has quit IRC | 05:09 | |
| *** adriant has joined #openstack-cinder | 05:09 | |
| *** e0ne has joined #openstack-cinder | 05:12 | |
| *** e0ne has quit IRC | 05:18 | |
| *** bhagyashris_ has joined #openstack-cinder | 05:23 | |
| *** markvoelker has joined #openstack-cinder | 05:27 | |
| *** ruffian_sheep has joined #openstack-cinder | 05:39 | |
| ruffian_sheep | Hi,does anyone know whether I should run all of the CI if I want to upload my driver of cinder | 05:40 |
| *** markvoelker has quit IRC | 06:00 | |
| mszwed | Hi ruffian_sheep, I you asking if you should run all tests, then the answer is yes | 06:01 |
| *** ruffian_sheep has quit IRC | 06:05 | |
| *** zhubx has quit IRC | 06:09 | |
| *** zhubx has joined #openstack-cinder | 06:09 | |
| whoami-rajat | ruffian_sheep mszwed If the query is regarding checking the correctness of driver then only zuul and driver specific CI results matter. | 06:14 |
| *** ruffian_sheep has joined #openstack-cinder | 06:15 | |
| ruffian_sheep | whoami-rajat|mszwed:I means if I should pass all the company's CI?I have passed the Unit Tests. | 06:17 |
| *** Luzi has joined #openstack-cinder | 06:18 | |
| ruffian_sheep | whoami-rajat|mszwed:I take the missions from my master.It seems a little different | 06:19 |
| ruffian_sheep | whoami-rajat|mszwed:https://review.openstack.org/#/c/643519/ | 06:21 |
| ruffian_sheep | whoami-rajat|mszwed:This is the code I upload.If I should add more CI to test my driver? | 06:22 |
| *** dpawlik has joined #openstack-cinder | 06:26 | |
| *** erlon has quit IRC | 06:36 | |
| *** sahid has joined #openstack-cinder | 06:37 | |
| *** slaweq has joined #openstack-cinder | 06:41 | |
| slaweq | hi | 06:41 |
| slaweq | recently I reported bug https://bugs.launchpad.net/cinder/+bug/1822958 | 06:41 |
| openstack | Launchpad bug 1822958 in Cinder "Backup operations fails causing tempest failures" [Undecided,New] | 06:41 |
| slaweq | I see in last few days that we hit similar issues quite often recently, e.g. http://logs.openstack.org/82/646082/6/check/tempest-full/70e04b3/testr_results.html.gz | 06:42 |
| slaweq | can maybe someone from cinder team take a look on this issue? Thx in advance | 06:42 |
| *** e0ne has joined #openstack-cinder | 06:47 | |
| *** markvoelker has joined #openstack-cinder | 06:57 | |
| mszwed | ruffian_sheep: that's enough, but keep in mind that at least Zuul CI should pass the tests | 07:04 |
| mszwed | ruffian_sheep: and as whoami-rajat mentioned also driver specific CI should pass the tests, which means that you have to add your own CI if you are creating new driver | 07:04 |
| whoami-rajat | ruffian_sheep: is your CI currently running on gate? what's the name of CI? | 07:05 |
| mszwed | I'm sorry for my first comment - I didn't get correctly the meaning of your question | 07:05 |
| openstackgerrit | Merged openstack/cinder master: Add upgrade checker for backup driver path https://review.openstack.org/647927 | 07:14 |
| ruffian_sheep | whoami-rajat|mszwed:Now I am building the CI of my company to add.And I am trying to pass the tempest,but there is something confused me that I think I should use the CI to run the tempest so thath I can use my device. | 07:19 |
| ruffian_sheep | whoami-rajat|mszwed:But in this case, how to let other drivers run on my device. Is my cognition wrong? | 07:21 |
| ruffian_sheep | <mszwed>:Is my statement not accurate enough :P | 07:21 |
| *** rosmaita has quit IRC | 07:21 | |
| *** dims has quit IRC | 07:22 | |
| *** dims has joined #openstack-cinder | 07:24 | |
| ruffian_sheep | whoami-rajat|mszwed:Or tempest is used to test my own drivers and devices. Don't you have to test the implementation of other people's drivers on my device? | 07:24 |
| mszwed | ruffian_sheep: only your CI should run on your devices. Other CI test their own devices. | 07:24 |
| mszwed | and Zuul runs generic tests that should pass no matter what driver and device you are developing - it won't so anything driver/device specific | 07:25 |
| *** rosmaita has joined #openstack-cinder | 07:26 | |
| ruffian_sheep | <mszwed>:Other people's drivers don't need to go to my device to run ,is it? | 07:26 |
| mszwed | ruffian_sheep: yes | 07:26 |
| mszwed | tha's correct | 07:27 |
| mszwed | *that's | 07:27 |
| *** markvoelker has quit IRC | 07:31 | |
| ruffian_sheep | <mszwed>: :) | 07:31 |
| *** dims has quit IRC | 07:31 | |
| ruffian_sheep | whoami-rajat|mszwed:Let me summarize, that is, unit testing is used to make the driver conform to the specification. In this way, all manufacturers' drivers can be used after they meet the specifications. Tempest is for my own use, in order to verify that the function is passed, other manufacturers do not need to pass my tempest. And the job I need to set to my CI should be tempest. | 07:31 |
| *** helenafm has joined #openstack-cinder | 07:32 | |
| *** dims has joined #openstack-cinder | 07:34 | |
| mszwed | ruffian_sheep: in general yes, but just to be sure that we are on the same page some clarification: unit tests basically will test your functions in your code. The more the better. As for Tempest: you don't have to create new tests for tempest, just need to run current set of Tempest tests ('all') in your CI on you driver and device. | 07:35 |
| *** jistr is now known as jistr|afk | 07:35 | |
| mszwed | ruffian_sheep: but if you want to add new tests to Tempest please keep in mind that they have to be generic so that they will pass no matter what driver or device you are using | 07:36 |
| mszwed | whoami-rajat: please correct me if I'm wrong :) | 07:36 |
| mszwed | ruffian_sheep: one more comment - keep in mind that some of the Tempest tests (from 'all set) assume you are using scsi interface, but if you are using different type of interface (like NVMe-oF) you will have to exclude them | 07:38 |
| mszwed | same story for manage_existing* functionality - it's being tested by Tempest, but it is not mandatory driver functionality | 07:41 |
| mszwed | so if you won't implement it you will also have to exclude tests for that also | 07:42 |
| mszwed | ruffian_sheep: I hope I've explained this clear enough :) | 07:42 |
| ruffian_sheep | <mszwed> :Thank you so much!sir ! | 07:46 |
| ruffian_sheep | <mszwed> :I finally cleared up a lot of relationships. I have never known what job should be set on the CI. I ask a little question more. Normally my driver should not be running on other devices (that is, the CI environment of other vendors). Because my driver code can't run their devices, but my driver runs through their CI environment. Does it mean that they are using the unit test jobs to do it? | 07:47 |
| *** brinzhang has quit IRC | 07:50 | |
| *** brinzhang has joined #openstack-cinder | 07:50 | |
| mszwed | ruffian_sheep: unfortunately I don't know answer for this question. But you don't have to worry about other CIs - Zuul and your own CI are the only ones that you should worry about :) | 07:50 |
| *** spsurya has joined #openstack-cinder | 07:55 | |
| ruffian_sheep | <mszwed> :Get!Thank you !!!! | 07:57 |
| mszwed | ruffian_sheep: you're welcome :) | 07:58 |
| ruffian_sheep | <whoami-rajat>:The name of my CI is MacroSAN Volume CI. | 07:59 |
| ruffian_sheep | <mszwed> :Mr,I suddenly remembered, if I should get a permission to add my CI environment? In order to listen and feedback the cinder project | 08:01 |
| mszwed | ruffian_sheep: that I don't know unfortunately, because my CI was just extension of existing one, so I didn't need to go through that. | 08:03 |
| ruffian_sheep | <mszwed> :Get it.thank you so much.:P | 08:04 |
| mszwed | ;) | 08:05 |
| openstackgerrit | Vadym Markov proposed openstack/cinder stable/ocata: cinder incremental backup with ceph fails if last one deleted https://review.openstack.org/649652 | 08:12 |
| openstackgerrit | sahid proposed openstack/cinderlib master: add python 3.7 unit test job https://review.openstack.org/643067 | 08:14 |
| *** tkajinam has quit IRC | 08:22 | |
| *** gkadam has joined #openstack-cinder | 08:27 | |
| *** markvoelker has joined #openstack-cinder | 08:28 | |
| *** e0ne has quit IRC | 08:30 | |
| *** e0ne has joined #openstack-cinder | 08:40 | |
| *** e0ne has quit IRC | 08:42 | |
| *** e0ne has joined #openstack-cinder | 08:50 | |
| *** markvoelker has quit IRC | 09:01 | |
| *** sdin has quit IRC | 09:19 | |
| *** sdinescu has quit IRC | 09:22 | |
| *** mvkr has joined #openstack-cinder | 09:24 | |
| *** LiangFang has quit IRC | 09:30 | |
| *** bhagyashris_ has quit IRC | 09:43 | |
| *** e0ne has quit IRC | 09:44 | |
| *** luksky has joined #openstack-cinder | 09:51 | |
| *** e0ne has joined #openstack-cinder | 09:54 | |
| *** sdinescu has joined #openstack-cinder | 09:57 | |
| *** sdin has joined #openstack-cinder | 09:57 | |
| *** markvoelker has joined #openstack-cinder | 09:58 | |
| *** brinzhang has quit IRC | 10:04 | |
| *** jistr|afk is now known as jistr | 10:23 | |
| *** markvoelker has quit IRC | 10:31 | |
| geguileo | whoami-rajat: Could you +A the patch since you were the 2nd +2 please? | 10:33 |
| *** peeejayz has joined #openstack-cinder | 10:47 | |
| *** sapd1_x has joined #openstack-cinder | 10:50 | |
| peeejayz | Hi All, We have been looking into some IOPs issues on our ceph cluster, we have found it, its cinder causing about 90% of the iops and they mainly seem to be cinder checking certain images - is this a known problem and is there any way to tune this down? as currently this is causing large problems for our cluster. | 10:50 |
| *** udesale has quit IRC | 10:54 | |
| *** carloss has joined #openstack-cinder | 11:06 | |
| *** erlon has joined #openstack-cinder | 11:14 | |
| *** helenafm has quit IRC | 11:22 | |
| *** markvoelker has joined #openstack-cinder | 11:28 | |
| *** mvkr has quit IRC | 11:30 | |
| openstackgerrit | Lee Yarwood proposed openstack/cinder master: Update volume status during volume migration. https://review.openstack.org/638995 | 11:39 |
| *** thgcorrea has joined #openstack-cinder | 11:40 | |
| *** erlon_ has joined #openstack-cinder | 11:45 | |
| *** e0ne has quit IRC | 11:50 | |
| *** abishop has joined #openstack-cinder | 11:54 | |
| *** ruffian_sheep has quit IRC | 11:59 | |
| *** mvkr has joined #openstack-cinder | 12:00 | |
| *** markvoelker has quit IRC | 12:02 | |
| *** anks2k has joined #openstack-cinder | 12:16 | |
| *** anks2k has quit IRC | 12:17 | |
| *** brinzhang has joined #openstack-cinder | 12:21 | |
| rosmaita | smcginnis: yt? | 12:33 |
| whoami-rajat | geguileo: can you provide the link ? | 12:40 |
| openstackgerrit | Yong Huang proposed openstack/cinder master: Supports volume attach, detach in nova api https://review.openstack.org/649515 | 12:47 |
| *** Luzi has quit IRC | 12:48 | |
| *** zul has joined #openstack-cinder | 12:51 | |
| *** mriedem has joined #openstack-cinder | 12:54 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Add upgrade check for presence of policy.json file https://review.openstack.org/647937 | 12:57 |
| *** lseki has joined #openstack-cinder | 13:00 | |
| *** dklyle has quit IRC | 13:02 | |
| rosmaita | smcginnis: ^^ (so we don't duplicate efforts) | 13:05 |
| *** udesale has joined #openstack-cinder | 13:05 | |
| *** enriquetaso has joined #openstack-cinder | 13:06 | |
| *** Luzi has joined #openstack-cinder | 13:07 | |
| *** davidsha has joined #openstack-cinder | 13:08 | |
| *** gaoyan has joined #openstack-cinder | 13:12 | |
| *** itlinux has quit IRC | 13:12 | |
| smcginnis | rosmaita: Thanks rosmaita. Odd I didn't see that locally. | 13:18 |
| rosmaita | smcginnis: hmmmm ... let' | 13:20 |
| rosmaita | s see what happens in zuul | 13:20 |
| *** raghavendrat has joined #openstack-cinder | 13:20 | |
| *** e0ne has joined #openstack-cinder | 13:22 | |
| geguileo | whoami-rajat: oooops, I though I did, my bad: https://review.openstack.org/#/c/643017/ | 13:24 |
| openstackgerrit | Raghavendra Tilay proposed openstack/cinder master: 3PAR: Provide an option duing creation of volume from snapshot https://review.openstack.org/634119 | 13:25 |
| whoami-rajat | geguileo: done | 13:27 |
| geguileo | whoami-rajat: thanks! | 13:27 |
| whoami-rajat | geguileo: np :) | 13:27 |
| openstackgerrit | Jay Bryant proposed openstack/cinder master: Add upgrade check for Windows iSCSI driver. https://review.openstack.org/649193 | 13:27 |
| openstackgerrit | Jay Bryant proposed openstack/cinder master: Add Upgrade Check for Drivers Removed in Stein https://review.openstack.org/649209 | 13:27 |
| jungleboyj | smcginnis: rosmaita ^^ Those are hopefully my final upgrade checker changes. | 13:28 |
| smcginnis | peeejayz: Cinder doesn't "check images". Can you explain a little more what you are seeing? | 13:28 |
| rosmaita | jungleboyj: cool, maybe we can actually get these done today | 13:29 |
| smcginnis | jungleboyj: Cool, will try to look soon. | 13:29 |
| smcginnis | Just need to make a sacrifice to the zuul god. | 13:29 |
| jungleboyj | *Fingers crossed* | 13:29 |
| peeejayz | smcginnis: so running logs on ceph try to work out where we are seeing IOPS and where they are comming from during the tests 140k requests from a single cinder node, compared to next highest thing that isn't cinder is a hv that did 600. | 13:31 |
| peeejayz | the main requests are: 13093 [call rbd.metadata_list] | 13:31 |
| peeejayz | 13093 [call rbd.image_get_group] | 13:31 |
| peeejayz | 13093 [call rbd.get_stripe_unit_count] | 13:31 |
| peeejayz | 13093 [call rbd.get_size,call rbd.get_object_prefix] | 13:31 |
| peeejayz | 13093 [call rbd.get_size,call rbd.get_features,call | 13:31 |
| peeejayz | rbd.get_snapcontext,call rbd.get_parent,call lock.get_info] | 13:31 |
| smcginnis | peeejayz: Anything in the cinder logs? Cinder itself shouldn't be doing anything unless it's to service a request. | 13:31 |
| peeejayz | 13093 [call rbd.get_data_pool] | 13:31 |
| peeejayz | 13093 [call rbd.get_create_timestamp] | 13:31 |
| eharney | peeejayz: what release are you running? | 13:32 |
| geguileo | peeejayz: most requests are probably coming from the stats reports | 13:32 |
| openstackgerrit | Jay Bryant proposed openstack/cinder stable/stein: Add NetApp E-Series Driver to Removal List https://review.openstack.org/649993 | 13:32 |
| geguileo | peeejayz: one for each existing volume | 13:32 |
| smcginnis | Ah, was just thinking status updates. | 13:32 |
| jdillaman | peeejayz: those are the standard calls to the OSD when opening an image | 13:32 |
| geguileo | peeejayz: what release? | 13:32 |
| openstackgerrit | Jay Bryant proposed openstack/cinder stable/stein: Remove scanning upgrade checker from opts generation https://review.openstack.org/649994 | 13:32 |
| smcginnis | eharney: We merged something to make that less overhead, right? | 13:32 |
| jungleboyj | smcginnis: In case we do an RC3 have those two cherry-picks that should go in. | 13:33 |
| peeejayz | geguileo: Queens | 13:33 |
| geguileo | smcginnis: yes 'i wrote that | 13:33 |
| smcginnis | geguileo: OK, great. | 13:33 |
| geguileo | peeejayz: let me check if the feature is there... | 13:33 |
| *** Luzi has quit IRC | 13:34 | |
| geguileo | peeejayz: set rbd_exclusive_cinder_pool = true | 13:34 |
| geguileo | peeejayz: in the RBD backend config section | 13:34 |
| geguileo | peeejayz: that makes cinder assume it is the only one using the Ceph pool | 13:35 |
| geguileo | peeejayz: so it doesn't have to query the backend | 13:35 |
| peeejayz | geguileo: okay will this have any adverse affects | 13:35 |
| geguileo | peeejayz: not if you only use that RBD pool for Cinder | 13:36 |
| peeejayz | ah we dont | 13:36 |
| geguileo | peeejayz: then you will not have the right stats in the scheduler if you enable that :-( | 13:36 |
| geguileo | that's precisely why it's disabled by default | 13:36 |
| peeejayz | geguileo: so best thing to actually do is to split our pools? | 13:36 |
| geguileo | peeejayz: that would be the best | 13:37 |
| *** Luzi has joined #openstack-cinder | 13:37 | |
| peeejayz | Okay, I will discuss as this is a big change with over 600 running vms currently. | 13:37 |
| geguileo | peeejayz: the other possibility is to enable the exclusive pool in Cinder | 13:37 |
| geguileo | peeejayz: and assume the scheduler will not have accurate data | 13:37 |
| geguileo | peeejayz: as it won't be able to account for all the storage used outside of Cinder | 13:38 |
| geguileo | so over provisioning and reserved space will not work as expected | 13:38 |
| geguileo | as far as I can tell those are your choices | 13:38 |
| peeejayz | geguileo: exactly what I was going to ask, many thanks. | 13:38 |
| geguileo | peeejayz: no problem | 13:39 |
| *** raghavendrat has quit IRC | 13:40 | |
| peeejayz | geguileo: is there any hints on how to migrate cinder pools while in production? | 13:46 |
| geguileo | peeejayz: I think the best way will be to a migration | 13:47 |
| geguileo | peeejayz: but it's going to be a pita, because you have to migrate ALL the volumes... | 13:48 |
| geguileo | some will do live migration and others will do offline migration | 13:48 |
| *** spsurya has quit IRC | 13:51 | |
| *** altlogbot_0 has quit IRC | 13:53 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Fix get_connector_properties https://review.openstack.org/649552 | 13:55 |
| *** e0ne has quit IRC | 13:59 | |
| *** imacdonn has quit IRC | 14:03 | |
| *** e0ne has joined #openstack-cinder | 14:05 | |
| *** udesale has quit IRC | 14:06 | |
| *** udesale has joined #openstack-cinder | 14:07 | |
| *** udesale has quit IRC | 14:11 | |
| *** udesale has joined #openstack-cinder | 14:11 | |
| *** gaoyan has quit IRC | 14:14 | |
| *** dpawlik has quit IRC | 14:22 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Document behavior of message.create https://review.openstack.org/648294 | 14:27 |
| *** itlinux has joined #openstack-cinder | 14:32 | |
| *** itlinux has quit IRC | 14:32 | |
| *** Luzi has quit IRC | 14:34 | |
| *** e0ne has quit IRC | 14:46 | |
| *** itlinux has joined #openstack-cinder | 14:48 | |
| *** mvkr has quit IRC | 14:48 | |
| *** itlinux has quit IRC | 14:49 | |
| *** itlinux has joined #openstack-cinder | 14:50 | |
| *** e0ne has joined #openstack-cinder | 14:52 | |
| *** e0ne has quit IRC | 14:57 | |
| *** enriquetaso has quit IRC | 15:08 | |
| *** dviroel has joined #openstack-cinder | 15:12 | |
| *** dklyle has joined #openstack-cinder | 15:27 | |
| *** erlon has quit IRC | 15:29 | |
| *** udesale has quit IRC | 15:32 | |
| *** brinzhang has quit IRC | 15:45 | |
| *** e0ne has joined #openstack-cinder | 15:46 | |
| *** e0ne has quit IRC | 15:48 | |
| *** e0ne has joined #openstack-cinder | 15:48 | |
| *** e0ne has quit IRC | 15:48 | |
| *** e0ne has joined #openstack-cinder | 16:05 | |
| *** enriquetaso has joined #openstack-cinder | 16:07 | |
| *** lemko has quit IRC | 16:09 | |
| *** e0ne has quit IRC | 16:12 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Add upgrade check for presence of policy.json file https://review.openstack.org/647937 | 16:15 |
| *** sapd1_x has quit IRC | 16:24 | |
| *** sahid has quit IRC | 16:24 | |
| *** dpawlik has joined #openstack-cinder | 16:25 | |
| jungleboyj | rosmaita: How strong are your feelings about not failing on the first removed driver found? | 16:26 |
| rosmaita | not very strong, i guess it depends on what our user expectations are | 16:27 |
| rosmaita | the alternative is to keep a list of bad drivers and then you have to deal with "this driver" vs "these drivers", pretty big PITA to code up in a hurry | 16:27 |
| jungleboyj | Right. | 16:31 |
| jungleboyj | So, I think that this is the safer approach if you are ok with it. | 16:31 |
| jungleboyj | I am fixing the whitespace issue. Sorry about that. | 16:32 |
| whoami-rajat | smcginnis: jungleboyj can we run a single upgrade check, like we do with unit tests? | 16:32 |
| rosmaita | yeah, the -1 was really about the test file & whitespace | 16:32 |
| jungleboyj | rosmaita: I have figured. | 16:33 |
| jungleboyj | whoami-rajat: Not that I am aware of. | 16:33 |
| rosmaita | jungleboyj: maybe change the error message to indicate re-run to verify? | 16:34 |
| whoami-rajat | from rosmaita 's comment on jungleboyj patch, i thought it would be better to have this functionality sometime in the future, running all checks again and again to check the fix for one seems tedious. | 16:35 |
| rosmaita | whoami-rajat: i think i see what you mean -- it would be cool if we could use ddt to turn one check into several | 16:36 |
| rosmaita | i wonder if we could use multiple inheritance to get the upgrade check + unit tester functionality | 16:38 |
| jungleboyj | whoami-rajat: The documentation on how to run the upgrade check indicates re-running but I can add it to the error message. | 16:38 |
| *** dpawlik has quit IRC | 16:38 | |
| whoami-rajat | rosmaita: not exactly. i mean to run the "removed drivers check" without running the "policy check". | 16:38 |
| rosmaita | whoami-rajat: gotcha | 16:39 |
| rosmaita | jungleboyj: if the docs already say an operator should run multiple times, i am ok with your current check code | 16:39 |
| jungleboyj | Ok. Cool. Thank you. | 16:42 |
| whoami-rajat | rosmaita: not sure if it's possible but would be good to reuse the unit tester code to implement same functionality for these checks. again just for future reference. | 16:42 |
| whoami-rajat | jungleboyj: ++ with the current approach. | 16:43 |
| *** itlinux has quit IRC | 16:45 | |
| *** itlinux has joined #openstack-cinder | 16:47 | |
| *** itlinux has quit IRC | 16:54 | |
| *** itlinux has joined #openstack-cinder | 16:55 | |
| *** itlinux has quit IRC | 16:59 | |
| *** itlinux has joined #openstack-cinder | 17:00 | |
| *** davidsha has quit IRC | 17:03 | |
| *** gkadam has quit IRC | 17:11 | |
| *** v12aml has quit IRC | 17:15 | |
| *** v12aml has joined #openstack-cinder | 17:19 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Fix deprecation escape sequence errors under 3.6 https://review.openstack.org/650080 | 17:21 |
| *** imacdonn has joined #openstack-cinder | 17:27 | |
| openstackgerrit | Jay Bryant proposed openstack/cinder master: Add Upgrade Check for Drivers Removed in Stein https://review.openstack.org/649209 | 17:29 |
| * jungleboyj makes a sacrifice to the zuul gods. | 17:30 | |
| *** spsurya has joined #openstack-cinder | 17:37 | |
| openstackgerrit | Jay Bryant proposed openstack/cinder master: Add upgrade check for Windows iSCSI driver. https://review.openstack.org/649193 | 17:41 |
| *** gmann is now known as gmann_afk | 17:44 | |
| *** enriquetaso has quit IRC | 18:03 | |
| *** erlon_ has quit IRC | 18:07 | |
| *** psachin has quit IRC | 18:28 | |
| rosmaita | smcginnis: is the final rc deadline 23:59 UTC today? | 18:34 |
| *** itlinux has quit IRC | 18:35 | |
| smcginnis | We just declare it is "today". So we can probably go to 12:59 PDT if we really had to. | 18:35 |
| smcginnis | But I don't plan on staying up that late. That's way past my bedtime. :) | 18:36 |
| rosmaita | well, it only needs to be submitted by then, right? | 18:36 |
| rosmaita | :) | 18:36 |
| smcginnis | Heh, I suppose. | 18:36 |
| smcginnis | I'm seeing unit test failures on that policy check in queue, but even completely recreating my env I am not able to reproduce the failures. | 18:37 |
| rosmaita | arrrrgh | 18:37 |
| smcginnis | Only other difference I see is I'm currently on Fedora and that's running on Bionic. | 18:37 |
| smcginnis | I suppose I could spin up a machine. | 18:38 |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Allow reset-state to detach volume as per policy https://review.openstack.org/650094 | 18:39 |
| *** jmlowe has quit IRC | 18:44 | |
| rosmaita | i'm on fedora too. looks like maybe the call to CONF.find_file('cinder.conf') at line 72 in status.py is returning None | 18:46 |
| smcginnis | Hmm, I suppose for the unit test I can mock that to return the expected value. | 18:47 |
| rosmaita | i think that would be the way to go | 18:47 |
| smcginnis | Wish I could get it to fail locally to make sure I'm actually fixing it though. | 18:47 |
| *** itlinux has joined #openstack-cinder | 18:48 | |
| rosmaita | i just did | 18:50 |
| rosmaita | i had an /etc/cinder hanging around from manual testing | 18:50 |
| rosmaita | when i deleted it, i get those same failures | 18:51 |
| smcginnis | Ahhhh, that could be my case. | 18:51 |
| rosmaita | yeah, i am kicking myself there | 18:51 |
| *** eharney has quit IRC | 18:55 | |
| smcginnis | rosmaita: Thanks, that did it (both be able to reproduce and verify the fix). | 18:56 |
| rosmaita | cool | 18:57 |
| *** enriquetaso has joined #openstack-cinder | 18:58 | |
| *** eharney has joined #openstack-cinder | 18:58 | |
| *** jmlowe has joined #openstack-cinder | 18:59 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Add upgrade check for presence of policy.json file https://review.openstack.org/647937 | 19:00 |
| *** mmethot has joined #openstack-cinder | 19:03 | |
| *** enriquetaso has quit IRC | 19:05 | |
| *** enriquetaso has joined #openstack-cinder | 19:05 | |
| smcginnis | Looks like those jobs are all passing now. | 19:21 |
| rosmaita | \o/ | 19:24 |
| *** itlinux has quit IRC | 19:33 | |
| *** enriquetaso has quit IRC | 19:43 | |
| *** gmann_afk is now known as gmann | 19:49 | |
| *** enriquetaso has joined #openstack-cinder | 19:51 | |
| *** _erlon_ has joined #openstack-cinder | 19:56 | |
| _erlon_ | jungleboyj: hey | 20:00 |
| _erlon_ | jungleboyj: do you know anything about the status of the reloadable options for cinder? | 20:00 |
| _erlon_ | https://specs.openstack.org/openstack/cinder-specs/specs/pike/dynamic_reconfiguration.html | 20:00 |
| *** thgcorrea has quit IRC | 20:01 | |
| jungleboyj | Those were in discussion for a long time and we had no one to work on them so they didn't really progressed any further. | 20:01 |
| enriquetaso | Hello cinder team o/ I need some reviews on backports https://review.openstack.org/#/c/647976/ & https://review.openstack.org/#/c/647974/ ... Please if you have a minute, check them out :P | 20:12 |
| openstackgerrit | Sofia Enriquez proposed openstack/cinder master: Support Incremental Backup Completion In RBD https://review.openstack.org/627941 | 20:13 |
| _erlon_ | jungleboyj: hmm, we might pick that up again | 20:17 |
| _erlon_ | next weak Ill know more about | 20:17 |
| smcginnis | _erlon_, jungleboyj: That was a cycle goal. | 20:18 |
| smcginnis | The base framework for it is all in place and IIRC it works for changing log levels. | 20:18 |
| smcginnis | But we could/should review to see if there are any other config options that make sense to also be reloaded. | 20:19 |
| _erlon_ | smcginnis: for that cicle or Train? | 20:19 |
| smcginnis | _erlon_: What for what? | 20:19 |
| _erlon_ | smcginnis: yes, logging level was the main case, and I think is already supported via API right? | 20:19 |
| smcginnis | :) | 20:19 |
| smcginnis | Via API and also via this reloadable config method. | 20:20 |
| _erlon_ | smcginnis: :) reloadable options is the goal for this release? | 20:20 |
| smcginnis | _erlon_: No, it was for one of the past ones. Pike I think. | 20:21 |
| _erlon_ | smcginnis: how does that reloadable config method work? | 20:21 |
| smcginnis | _erlon_: You send SIGHUP or some signal to the process. Can't remember the details, but it should have been documented. | 20:22 |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Update gate-irrelevant-files https://review.openstack.org/650138 | 20:22 |
| smcginnis | And we never miss documentation, right. ;) | 20:22 |
| rosmaita | jungleboyj: smcginnis: wish i had thought of this a week ago: Update gate-irrelevant-files https://review.openstack.org/650138 | 20:23 |
| _erlon_ | smcginnis: hmm, sending the SIGHUP is the approach mentioned on the spec | 20:23 |
| _erlon_ | Ill dig some code to see what we have now | 20:23 |
| smcginnis | Ah, it was rocky - https://governance.openstack.org/tc/goals/rocky/enable-mutable-configuration.html | 20:24 |
| _erlon_ | mutable, reloadable, reconfiguration, mutant, we should have a spec to define how we call it :p | 20:25 |
| jungleboyj | smcginnis: I feel like we might have had an issue with that working right. I had debugged a little but can't remember where I ended up. | 20:25 |
| smcginnis | I've purged those brain cells. :) | 20:26 |
| jungleboyj | _erlon_: The log level should be dynamic but we were having issues reaching agreement as to what other things should be dynamic. I am all for continuing the discussion though. | 20:28 |
| _erlon_ | I wonder why we just don't set a new flag on oslo.config so, if, reloadable is set, the config will be read directly from the config file, not from memory | 20:28 |
| _erlon_ | I didn't see this option in the spec | 20:28 |
| _erlon_ | jungleboyj: yes, I remember that part too | 20:28 |
| jungleboyj | Another thing we swept under the table due to lack of agreement. | 20:29 |
| *** pcaruana has quit IRC | 20:29 | |
| jungleboyj | And no one wanting to push it. | 20:29 |
| _erlon_ | some drivers could have problems on initialization or keeping state with the storage | 20:29 |
| *** pcaruana has joined #openstack-cinder | 20:30 | |
| *** dpawlik has joined #openstack-cinder | 20:31 | |
| *** dpawlik has quit IRC | 20:35 | |
| *** itlinux has joined #openstack-cinder | 20:37 | |
| *** itlinux has quit IRC | 20:38 | |
| *** itlinux has joined #openstack-cinder | 20:39 | |
| jungleboyj | Hey, look at that. My Upgrade Checker patches finally passed Zuul. | 20:41 |
| jungleboyj | smcginnis: I assume at this point we are just going with RC2 and then backporting changes later? | 20:41 |
| smcginnis | jungleboyj: Yeah, I think that makes sense. | 20:42 |
| smcginnis | Probably not time to get anything else backported. | 20:42 |
| jungleboyj | Ok. I won't stress further over those patches then. | 20:42 |
| jungleboyj | At least not today. | 20:42 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder stable/stein: Add upgrade checker for backup driver path https://review.openstack.org/650141 | 20:43 |
| *** spsurya has quit IRC | 20:54 | |
| *** slaweq has quit IRC | 20:58 | |
| *** abishop has quit IRC | 20:58 | |
| *** sapd1 has quit IRC | 21:03 | |
| *** dpawlik has joined #openstack-cinder | 21:04 | |
| *** sapd1 has joined #openstack-cinder | 21:08 | |
| *** slaweq has joined #openstack-cinder | 21:26 | |
| *** slaweq has quit IRC | 21:30 | |
| *** enriquetaso has quit IRC | 21:35 | |
| *** enriquetaso has joined #openstack-cinder | 21:39 | |
| *** enriquetaso has quit IRC | 21:41 | |
| *** enriquetaso has joined #openstack-cinder | 21:42 | |
| *** pcaruana has quit IRC | 21:51 | |
| *** slaweq has joined #openstack-cinder | 21:52 | |
| *** dpawlik has quit IRC | 21:53 | |
| *** enriquetaso has quit IRC | 21:53 | |
| *** slaweq has quit IRC | 21:57 | |
| *** dpawlik has joined #openstack-cinder | 22:05 | |
| *** dpawlik has quit IRC | 22:09 | |
| *** rcernin has joined #openstack-cinder | 22:23 | |
| *** whoami-rajat has quit IRC | 22:32 | |
| *** abishop has joined #openstack-cinder | 22:35 | |
| *** luksky has quit IRC | 22:57 | |
| *** tkajinam has joined #openstack-cinder | 22:59 | |
| *** carloss has quit IRC | 23:15 | |
| *** dklyle has quit IRC | 23:19 | |
| *** enriquetaso has joined #openstack-cinder | 23:19 | |
| *** enriquetaso has quit IRC | 23:19 | |
| *** _erlon_ has quit IRC | 23:25 | |
| *** itlinux has quit IRC | 23:31 | |
| *** eharney has quit IRC | 23:40 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!