Thursday, 2019-04-25

« Wednesday, 2019-04-24 Index Friday, 2019-04-26 »
*** dave-mccowan has quit IRC00:05
*** itlinux has joined #openstack-cinder00:34
*** tejdeep has quit IRC00:36
*** yedongcan has joined #openstack-cinder00:38
*** itlinux has quit IRC00:58
*** brinzhang has joined #openstack-cinder00:58
*** whoami-rajat has joined #openstack-cinder01:02
*** mriedem has quit IRC01:11
*** openstackgerrit has joined #openstack-cinder01:33
openstackgerritYong Huang proposed openstack/cinder master: [Unity] Cross-arrays storage-assisted migration support  https://review.opendev.org/65145001:33
*** markvoelker has quit IRC01:34
openstackgerritBrian Rosmaita proposed openstack/python-cinderclient master: Correct discover_version response  https://review.opendev.org/65559501:40
*** jidar has quit IRC01:46
*** ruffian_sheep has joined #openstack-cinder02:04
ruffian_sheepIt’s bad luck! I originally wanted to attend the meeting yesterday to ask. Because the meeting is in the middle of the night, I can only get it at home! The remote computer has a temporary problem, and can't find a suitable VPN! Missed the meeting T.T02:04
openstackgerritYong Huang proposed openstack/cinder master: [Unity] Update doc for compressed volume support  https://review.opendev.org/65559702:07
*** itlinux has joined #openstack-cinder02:32
openstackgerritJay Rubenstein proposed openstack/cinder master: NetApp SolidFire: handle DuplicateSfVolumeNames exception  https://review.opendev.org/64822802:34
*** tejdeep has joined #openstack-cinder02:42
whoami-rajatruffian_sheep: np. regarding your doubt, any distro could be used to setup CI, there isn't any restriction.03:05
*** smcginnis has quit IRC03:06
ruffian_sheep<whoami-rajat> :thank you! Except for the weekly meetings, who can I consult on the test cases that need to be run through http://47.254.90.248/cinder/log2.html?03:23
*** brinzhang has quit IRC03:25
*** brinzhang has joined #openstack-cinder03:26
*** markvoelker has joined #openstack-cinder03:35
*** psachin has joined #openstack-cinder03:52
*** udesale has joined #openstack-cinder03:55
*** vishakha has joined #openstack-cinder04:10
*** pcaruana has joined #openstack-cinder04:11
whoami-rajatruffian_sheep: i would say smcginnis and jungleboyj should be able to help out the most but its preferred that the CI guide should be followed [1].04:12
whoami-rajat[1] https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers04:12
*** pcaruana has quit IRC04:43
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add python37 job  https://review.opendev.org/65561204:52
*** lemko has joined #openstack-cinder04:58
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add python37 job  https://review.opendev.org/65561204:59
*** uberjay has quit IRC05:03
*** e0ne has joined #openstack-cinder05:05
*** kukacz has quit IRC05:06
*** kukacz has joined #openstack-cinder05:08
*** e0ne has quit IRC05:08
*** uberjay has joined #openstack-cinder05:08
*** Luzi has joined #openstack-cinder05:27
*** anks2k has joined #openstack-cinder05:29
*** itlinux has quit IRC05:30
*** adriant has quit IRC05:38
*** anks2k has quit IRC05:38
*** adriant has joined #openstack-cinder05:38
*** jiaopengju_2 has joined #openstack-cinder05:49
*** jiaopengju_1 has quit IRC05:52
openstackgerrityenai proposed openstack/cinder master: Fix creation failed when qemu-img is not installed  https://review.opendev.org/65369405:55
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add python37 job  https://review.opendev.org/65561205:57
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add python37 job  https://review.opendev.org/65561205:58
openstackgerrityenai proposed openstack/cinder master: Fix creation failed when qemu-img is not installed  https://review.opendev.org/65369406:00
*** phasespace has quit IRC06:09
openstackgerrityenai proposed openstack/cinder master: Fix raise OSError when qemu-img is not installed  https://review.opendev.org/65561706:14
*** pcaruana has joined #openstack-cinder06:20
*** jiaopengju_1 has joined #openstack-cinder06:27
*** jiaopengju_2 has quit IRC06:30
*** Luzi has quit IRC06:33
*** Luzi has joined #openstack-cinder06:34
*** luksky has joined #openstack-cinder06:46
*** phasespace has joined #openstack-cinder06:49
*** jiaopengju_1 has quit IRC06:49
*** jiaopengju_1 has joined #openstack-cinder06:49
*** phasespace has quit IRC06:52
*** sahid has joined #openstack-cinder06:57
*** lemko has quit IRC07:08
*** lemko has joined #openstack-cinder07:09
*** dpawlik has quit IRC07:14
openstackgerritwanghao proposed openstack/cinder master: Support Incremental Backup Completion In RBD  https://review.opendev.org/62794107:18
*** ruffian_sheep has quit IRC07:21
*** tejdeep has quit IRC07:22
*** dpawlik has joined #openstack-cinder07:36
*** phasespace has joined #openstack-cinder08:03
*** e0ne has joined #openstack-cinder08:08
*** e0ne has quit IRC08:08
*** e0ne has joined #openstack-cinder08:08
*** anks2k has joined #openstack-cinder08:22
*** anks2k has quit IRC08:27
*** zigo has quit IRC08:27
*** gmann has quit IRC08:28
*** tkajinam has quit IRC08:54
*** zigo has joined #openstack-cinder08:54
*** rha has joined #openstack-cinder08:57
*** rcernin has quit IRC08:58
*** anks2k has joined #openstack-cinder09:10
*** anks2k has quit IRC09:14
*** dims has quit IRC09:20
*** luksky has quit IRC09:21
*** dims has joined #openstack-cinder09:26
*** dims has quit IRC09:33
*** dims has joined #openstack-cinder09:34
*** jbernard has quit IRC09:48
*** dklyle has quit IRC09:50
*** dklyle has joined #openstack-cinder09:50
*** luksky has joined #openstack-cinder09:59
*** jbernard has joined #openstack-cinder10:04
*** mvkr has joined #openstack-cinder10:13
openstackgerrityenai proposed openstack/cinder master: Fix signature_verified not matched  https://review.opendev.org/65566610:44
*** dpawlik has quit IRC10:52
*** abishop has joined #openstack-cinder11:09
*** gkadam has joined #openstack-cinder11:16
*** dpawlik has joined #openstack-cinder11:25
*** udesale has quit IRC11:33
*** boxiang has quit IRC11:37
*** boxiang has joined #openstack-cinder11:37
*** jiaopengju_1 has quit IRC11:44
*** jiaopengju_1 has joined #openstack-cinder11:44
*** dpawlik has quit IRC11:52
openstackgerritBrian Rosmaita proposed openstack/python-cinderclient master: Correct discover_version response  https://review.opendev.org/65559512:13
*** markvoelker has quit IRC12:14
*** markvoelker has joined #openstack-cinder12:15
*** dpawlik has joined #openstack-cinder12:15
openstackgerritLee Yarwood proposed openstack/cinder master: lvm: Only use initiators when comparing connector dicts  https://review.opendev.org/65383712:18
openstackgerritGorka Eguileor proposed openstack/cinderlib master: Fake unused packages  https://review.opendev.org/65540112:26
*** enriquetaso has joined #openstack-cinder12:29
*** altlogbot_2 has quit IRC12:34
*** lseki has joined #openstack-cinder12:37
*** altlogbot_0 has joined #openstack-cinder12:38
*** gkadam has quit IRC12:46
*** altlogbot_0 has quit IRC12:47
*** altlogbot_2 has joined #openstack-cinder12:48
*** carloss has joined #openstack-cinder12:55
*** udesale has joined #openstack-cinder12:56
*** eharney has quit IRC13:00
*** raghavendrat has joined #openstack-cinder13:03
raghavendrathi core reviewers, this is regarding https://review.opendev.org/#/c/634119/13:04
*** mchlumsky has joined #openstack-cinder13:05
raghavendratif anyone can spare some time, review and give their approval ... it would be really appreciated13:05
*** smcginnis has joined #openstack-cinder13:10
*** ChanServ sets mode: +o smcginnis13:10
*** vishakha has quit IRC13:19
*** mriedem has joined #openstack-cinder13:22
*** altlogbot_2 has quit IRC13:23
*** altlogbot_2 has joined #openstack-cinder13:26
*** altlogbot_2 has quit IRC13:28
raghavendratis whoami-rajat: online ?13:28
*** altlogbot_0 has joined #openstack-cinder13:32
raghavendratis hemna: online?13:35
hemnasup13:35
raghavendratthis is regarding https://review.opendev.org/#/c/634119/13:36
raghavendratif you get some time, may i request you to please review. if everything looks good, can you please provide your approval13:37
hemnasure, I'll check it13:37
raghavendratthank you13:37
openstackgerritJay Rubenstein proposed openstack/cinder master: NetApp SolidFire: handle DuplicateSfVolumeNames exception  https://review.opendev.org/64822813:38
whoami-rajatraghavendrat:  Hi, i've reviewed it but i would still like to know the answer to my comment on the patch.13:39
hemnaraghavendrat: so it looks like at delete_snapshot time you potentially convert the snap to a base volume, before deleting13:40
*** eharney has joined #openstack-cinder13:41
hemnathat could take some time13:41
hemnaare you sure that doesn't lead to timeouts?13:41
*** altlogbot_0 has quit IRC13:42
hemnaraghavendrat: ^^13:43
*** jiaopengju_2 has joined #openstack-cinder13:44
*** jiaopengju_2 has quit IRC13:44
*** jiaopengju_2 has joined #openstack-cinder13:45
*** brinzhang has quit IRC13:46
*** jiaopengju_1 has quit IRC13:46
raghavendrathemna: i have checked. created volume of 100 GB size13:47
hemnaI'm concerned about timeouts for the delete -> rabbitmq -> volume manager13:47
hemnaas that convert to base can take a very long time13:48
raghavendratobserved that ... delete operation is asynchronous i.e delete request is issued and conversion to base volume takes place13:48
hemnaespecially if the 3par is busy with other actions13:48
raghavendrattimeout is not seen13:48
hemnaok I guess we'll find out :)13:49
raghavendratfor 100 GB volume, it took around 3 minutes to convert to base vol13:49
*** yedongcan has left #openstack-cinder13:49
hemnaand if you have like 5 of those going on ?13:49
hemnaor 1013:49
hemnaone of our customer's use cases is creating 100 vms (from volume snaps) running tests and then nuking all of them13:50
raghavendrati tested with six volumes which were created from snapshot and all of them were successfully converted to base13:50
hemnaeither way, having the default be false will enable the customer to create those 100 quickly13:51
hemnavs what the driver is now13:51
hemnaraghavendrat: thanks for fixing that.13:52
raghavendratok13:53
whoami-rajatthere is a tradeoff of handling this at create time or delete time. i think users will be more concerned with quick creation.13:53
hemnayup, that was the original design of the driver when I wrote it.13:53
raghavendratthanks whoami-rajat: and hemna: for providing approval13:54
whoami-rajathope noone change it again. :)13:54
*** Luzi has quit IRC13:55
raghavendrateven i wish the same :-)13:55
*** ybunker has joined #openstack-cinder13:56
whoami-rajatraghavendrat: np! i will check for the problems you mentioned while removing those redundant lines in test and put up a patch if everything is good.13:56
*** altlogbot_0 has joined #openstack-cinder13:56
raghavendratthanks whoami-rajat:13:56
raghavendratregarding comment .... this could also be optimized, directly return True or False ...13:57
raghavendratthe value of extra-spec could be either boolean or string13:58
raghavendratif its boolean, it wouldn't enter ... if isinstance(value, six.string_types)13:58
raghavendratso kept the "return" statement outside13:59
whoami-rajatraghavendrat: if it doesn't enter "if isinstance(value, six.string_types)" then it will be default(False) right? since user input will always be in string format14:04
raghavendratok. i will check14:06
*** dpawlik has quit IRC14:06
*** phasespace has quit IRC14:12
*** mmethot has quit IRC14:14
*** e0ne has quit IRC14:16
whoami-rajatsmcginnis:  i was testing the --os-project-name attribute, it works both as "--os-project-name" and "--os_project_name". is this intended or just a feature of argparse?14:18
smcginniswhoami-rajat: Hmm, I bet that's a feature of argparse. That's great.14:19
whoami-rajatsmcginnis: yep. first i thought it was a -/_ mistake in documentation, then it turned out to be cool both ways.14:21
*** gmann has joined #openstack-cinder14:26
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add python37 job  https://review.opendev.org/65561214:39
*** mvkr has quit IRC14:43
*** jiaopengju_2 has quit IRC14:50
*** jiaopengju_2 has joined #openstack-cinder14:50
*** mmethot has joined #openstack-cinder14:57
*** _erlon_ has joined #openstack-cinder15:00
*** itlinux has joined #openstack-cinder15:14
*** itlinux has quit IRC15:14
*** luksky has quit IRC15:22
*** itlinux has joined #openstack-cinder15:24
*** lpetrut has joined #openstack-cinder15:25
*** dave-mccowan has joined #openstack-cinder15:44
*** boxiang has quit IRC15:48
*** dave-mccowan has quit IRC15:49
*** boxiang has joined #openstack-cinder15:49
*** boxiang has quit IRC16:05
*** boxiang has joined #openstack-cinder16:05
openstackgerritRajat Dhasmana proposed openstack/cinder master: WIP: Add migrations for default volume type  https://review.opendev.org/63918016:09
*** gnufied has joined #openstack-cinder16:10
whoami-rajateharney: Hey16:13
eharneywhoami-rajat: hey16:15
*** dklyle has quit IRC16:15
*** dklyle has joined #openstack-cinder16:15
whoami-rajateharney:  i checked for encryption table, it has a volume_type_id column[1], at first i thought of making it non-nullable but then again volume_type is mandatory when creating encryption-type `cinder encryption-type-create <volume_type> ...` . not sure if i should go with the first thought.16:18
whoami-rajat[1] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L81316:18
eharneywhoami-rajat: it should be made non-nullable16:18
*** pcaruana has quit IRC16:19
eharneygood find16:19
whoami-rajateharney: ok thanks.16:19
whoami-rajateharney: i was making volumes and snapshots non-nullable [1], just wasn't sure about encryption table.16:20
whoami-rajat[1] https://review.opendev.org/#/c/639180/6/cinder/db/sqlalchemy/migrate_repo/versions/133_make_vol_type_col_non_nullable.py16:20
*** sahid has quit IRC16:29
openstackgerritRajat Dhasmana proposed openstack/cinder master: WIP: Add migrations for default volume type  https://review.opendev.org/63918016:35
*** pcaruana has joined #openstack-cinder16:40
openstackgerritMerged openstack/cinder master: 3PAR: Provide an option duing creation of volume from snapshot  https://review.opendev.org/63411916:45
*** udesale has quit IRC16:50
*** tejdeep has joined #openstack-cinder16:50
*** luksky has joined #openstack-cinder17:27
*** psachin has quit IRC17:28
*** lpetrut has quit IRC17:34
*** lemko has quit IRC17:38
*** itlinux has quit IRC17:39
*** itlinux has joined #openstack-cinder17:41
*** itlinux has quit IRC17:46
*** itlinux has joined #openstack-cinder17:47
*** itlinux has quit IRC17:58
*** itlinux has joined #openstack-cinder18:00
*** itlinux has quit IRC18:04
openstackgerritRajat Dhasmana proposed openstack/cinder master: Correct and optimize hpe3par tests  https://review.opendev.org/65575618:07
whoami-rajatraghavendrat:  ^^ found the issue and corrected it here.18:07
*** lpetrut has joined #openstack-cinder18:18
*** mgariepy has joined #openstack-cinder18:21
*** lpetrut has quit IRC18:23
*** tejdeep has quit IRC18:28
*** tejdeep has joined #openstack-cinder18:29
*** itlinux has joined #openstack-cinder18:43
*** itlinux has quit IRC18:52
openstackgerritAlan Bishop proposed openstack/cinder master: Fix swift backup driver crashing during service startup  https://review.opendev.org/65576518:57
*** itlinux has joined #openstack-cinder18:58
*** e0ne has joined #openstack-cinder19:06
*** lpetrut has joined #openstack-cinder19:14
*** e0ne has quit IRC19:17
openstackgerritEric Harney proposed openstack/os-brick master: Ignore pep8 W503/W504  https://review.opendev.org/65271219:17
*** ybunker has quit IRC19:21
*** eharney has quit IRC19:25
*** tejdeep has quit IRC19:26
*** rchurch_ has quit IRC19:28
*** itlinux has quit IRC19:35
*** itlinux has joined #openstack-cinder19:36
*** rchurch has joined #openstack-cinder19:41
*** boxiang has quit IRC19:55
*** boxiang has joined #openstack-cinder19:56
*** mgariepy has quit IRC20:07
*** mchlumsky has quit IRC20:08
*** mvkr has joined #openstack-cinder20:09
*** _erlon_ has quit IRC20:09
*** tejdeep has joined #openstack-cinder20:15
*** eharney has joined #openstack-cinder20:18
*** itlinux has quit IRC20:18
*** itlinux has joined #openstack-cinder20:20
*** dave-mccowan has joined #openstack-cinder20:24
*** eharney has quit IRC20:46
*** pcaruana has quit IRC20:48
*** gmann is now known as gmann_afk21:01
*** itlinux has quit IRC21:03
tejdeepI am addressing code review for rsd driver, i have a question regarding exceptions https://review.opendev.org/#/c/621465/38/cinder/exception.py . Looks like I need to move driver specific exceptions to the driver itself. I found similar exceptions from the other vendors in the exceptions.py, can some one suggest me about right place for the driver specific exceptions?21:17
smcginnistejdeep: We used to be more strict about any exceptions needing to be in cinder/exceptions.py. But I think if your exception is only used within your driver code, then it might be cleaner to just keep it within your driver code.21:25
smcginnisEither way works for me.21:25
tejdeepsmcginnis: Thanks for the suggestion. By the way i did recheck yesterday, looks like Zuul infra network problem persists. I am getting timeout error for tempest-full check https://review.opendev.org/#/c/621465/21:29
*** itlinux has joined #openstack-cinder21:31
smcginnisWow, those are some long running tests: http://logs.openstack.org/65/621465/38/check/tempest-full/733dd48/job-output.txt.gz#_2019-04-25_04_08_11_89643221:31
smcginnistejdeep: If you submit an update addressing eharney's comments and it fails there, then we can probably as in the -infra channel if this is a known issue.21:32
tejdeepsmcginnis: I haven't pushed the code changes from the code review, this Zuul is from my previous patchset21:35
smcginnistejdeep: Right.21:35
smcginnistejdeep: I'm saying if you push changes and it happens again, then we can get help if needed.21:35
tejdeepsmcginnis: Sure i will check again after submitting my patchset21:36
*** eharney has joined #openstack-cinder21:44
*** itlinux has quit IRC21:52
*** imacdonn has quit IRC22:02
*** imacdonn has joined #openstack-cinder22:02
*** carloss has quit IRC22:22
*** mszwed has quit IRC22:23
*** lpetrut has quit IRC22:26
*** whoami-rajat has quit IRC22:51
*** luksky has quit IRC22:58
*** dviroel has quit IRC23:00
*** mszwed_ has joined #openstack-cinder23:01
*** tkajinam has joined #openstack-cinder23:01
*** rcernin has joined #openstack-cinder23:03
*** mszwed_ has quit IRC23:07
*** lseki has quit IRC23:16
*** mszwed_ has joined #openstack-cinder23:25
openstackgerritTejdeep Kautharam proposed openstack/cinder master: Cinder RSD Driver  https://review.opendev.org/62146523:38
« Wednesday, 2019-04-24 Index Friday, 2019-04-26 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!