| *** brinzhang has joined #openstack-cinder | 00:20 | |
| *** ociuhandu has joined #openstack-cinder | 00:21 | |
| *** ociuhandu has quit IRC | 00:25 | |
| *** threestrands has joined #openstack-cinder | 00:35 | |
| *** brinzhang has quit IRC | 00:58 | |
| *** brinzhang has joined #openstack-cinder | 01:01 | |
| *** brinzhang has quit IRC | 01:28 | |
| *** brinzhang has joined #openstack-cinder | 01:29 | |
| *** Xuchu has joined #openstack-cinder | 01:38 | |
| *** lvbin02 has joined #openstack-cinder | 01:40 | |
| *** lvbin01 has quit IRC | 01:43 | |
| *** lvbin02 is now known as lvbin01 | 01:43 | |
| *** sapd1 has quit IRC | 01:52 | |
| *** sapd1 has joined #openstack-cinder | 02:11 | |
| *** xinliang has joined #openstack-cinder | 02:18 | |
| *** ociuhandu has joined #openstack-cinder | 02:26 | |
| *** ociuhandu has quit IRC | 02:36 | |
| *** ociuhandu has joined #openstack-cinder | 02:37 | |
| *** ociuhandu has quit IRC | 02:42 | |
| *** ociuhandu has joined #openstack-cinder | 02:55 | |
| *** ociuhandu has quit IRC | 03:05 | |
| *** kevinz has joined #openstack-cinder | 03:06 | |
| *** ircuser-1 has quit IRC | 03:09 | |
| *** Xuchu has quit IRC | 03:31 | |
| *** psachin has joined #openstack-cinder | 03:37 | |
| *** ociuhandu has joined #openstack-cinder | 03:48 | |
| *** ociuhandu has quit IRC | 03:53 | |
| *** ykarel|away is now known as ykarel | 04:09 | |
| *** xinliang has quit IRC | 04:11 | |
| *** udesale has joined #openstack-cinder | 04:38 | |
| *** rishabhhpe has joined #openstack-cinder | 04:39 | |
| *** tkajinam has quit IRC | 05:12 | |
| *** tkajinam has joined #openstack-cinder | 05:13 | |
| *** abishop has quit IRC | 05:16 | |
| *** abishop has joined #openstack-cinder | 05:16 | |
| *** yaawang_ has quit IRC | 05:18 | |
| *** yaawang_ has joined #openstack-cinder | 05:20 | |
| *** n-saito has joined #openstack-cinder | 05:24 | |
| *** raghavendrat has joined #openstack-cinder | 05:42 | |
| *** vishalmanchanda has joined #openstack-cinder | 05:46 | |
| *** rishabhhpe has quit IRC | 05:51 | |
| *** rishabhhpe has joined #openstack-cinder | 05:51 | |
| *** rishabhhpe has quit IRC | 05:58 | |
| *** rishabhhpe has joined #openstack-cinder | 05:58 | |
| *** dpawlik has joined #openstack-cinder | 06:09 | |
| raghavendrat | hi whoami-rajat: are you online? | 06:11 |
|---|---|---|
| whoami-rajat | raghavendrat, hey | 06:11 |
| raghavendrat | i have query regarding 3rd party CI | 06:12 |
| raghavendrat | saw this page: https://etherpad.opendev.org/p/cinder-ussuri-driverstuff | 06:12 |
| raghavendrat | wish to know the procedure to add entry for our CI i.e HPE Storage CI | 06:13 |
| whoami-rajat | raghavendrat, you mean here? https://wiki.openstack.org/wiki/ThirdPartySystems | 06:16 |
| whoami-rajat | raghavendrat, login with your third party CI account and follow the steps written in bottom of the page | 06:17 |
| raghavendrat | ok. thanks. let me check | 06:17 |
| raghavendrat | HPE Storage CI entry is already present in https://wiki.openstack.org/wiki/ThirdPartySystems | 06:20 |
| raghavendrat | whoami-rajat: we wish to ensure that HPE Storage CI is still marked as "supported" for Ussuri release | 06:27 |
| raghavendrat | so, wanted to know ... if we are all set OR in case we are lacking anything, we will work on the same. | 06:29 |
| whoami-rajat | raghavendrat, is your driver marked supported? | 06:33 |
| whoami-rajat | raghavendrat, regarding the CI page, i think the account that creates the driver entry can edit it's information | 06:33 |
| whoami-rajat | raghavendrat, so you can create a new entry and then remove the previous one | 06:34 |
| whoami-rajat | Current Status: enabled, non-voting,Currentlywe are fixing the issue with zuul subsystem | 06:34 |
| whoami-rajat | only the last part doesn't seem needed else i think it's OK | 06:34 |
| whoami-rajat | but IMO that isn't a major deal | 06:34 |
| raghavendrat | ok. thanks for confirmation. zuul subsystem is now fine. will update the page. | 06:36 |
| *** raghavendrat has quit IRC | 06:58 | |
| *** ociuhandu has joined #openstack-cinder | 07:00 | |
| *** pcaruana has joined #openstack-cinder | 07:12 | |
| *** breizhkoala has joined #openstack-cinder | 07:13 | |
| *** threestrands_ has joined #openstack-cinder | 07:18 | |
| *** threestrands_ has quit IRC | 07:18 | |
| *** threestrands has quit IRC | 07:21 | |
| *** udesale_ has joined #openstack-cinder | 07:47 | |
| *** udesale has quit IRC | 07:50 | |
| *** xinliang has joined #openstack-cinder | 08:00 | |
| *** lvbin01 has quit IRC | 08:06 | |
| *** lvbin01 has joined #openstack-cinder | 08:06 | |
| *** ociuhandu has quit IRC | 08:07 | |
| *** xinliang has quit IRC | 08:12 | |
| *** ykarel is now known as ykarel|lunch | 08:17 | |
| *** ociuhandu has joined #openstack-cinder | 08:43 | |
| *** ociuhandu has quit IRC | 08:48 | |
| *** vishalmanchanda has quit IRC | 08:56 | |
| *** ykarel|lunch is now known as ykarel | 09:00 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: RBD: Cleanup temporary files during exception https://review.opendev.org/721206 | 09:01 |
| *** tosky has joined #openstack-cinder | 09:01 | |
| *** andrebeltrami has quit IRC | 09:02 | |
| *** psachin has quit IRC | 09:09 | |
| *** psachin has joined #openstack-cinder | 09:16 | |
| *** ociuhandu has joined #openstack-cinder | 09:18 | |
| openstackgerrit | hjy proposed openstack/cinder master: Mark MacroSAN Driver Supported https://review.opendev.org/721210 | 09:18 |
| kevinz | Hi Cinder, is there any progress on Cinder-Ceph-ISCSI driver? | 09:23 |
| *** gregwork has quit IRC | 09:24 | |
| *** digvijay has joined #openstack-cinder | 09:24 | |
| *** raghavendrat has joined #openstack-cinder | 09:25 | |
| *** rcernin has quit IRC | 09:26 | |
| *** digvijay has quit IRC | 09:27 | |
| *** ociuhandu has quit IRC | 09:32 | |
| *** ociuhandu has joined #openstack-cinder | 09:33 | |
| *** lvbin01 has quit IRC | 09:36 | |
| *** lvbin01 has joined #openstack-cinder | 09:36 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder stable/train: PowerMax Driver - Allowing for default volume type in group https://review.opendev.org/720503 | 09:38 |
| *** ociuhandu has quit IRC | 09:39 | |
| *** e0ne has joined #openstack-cinder | 09:42 | |
| *** rcernin has joined #openstack-cinder | 09:50 | |
| *** vishalmanchanda has joined #openstack-cinder | 09:53 | |
| *** e0ne has quit IRC | 10:05 | |
| *** e0ne has joined #openstack-cinder | 10:05 | |
| *** ociuhandu has joined #openstack-cinder | 10:08 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder stable/train: PowerMax Driver - PowerMax Pools Fix https://review.opendev.org/721220 | 10:10 |
| *** e0ne has quit IRC | 10:12 | |
| *** e0ne has joined #openstack-cinder | 10:13 | |
| *** breizhkoala has quit IRC | 10:13 | |
| *** ociuhandu has quit IRC | 10:22 | |
| *** e0ne has quit IRC | 10:51 | |
| *** e0ne has joined #openstack-cinder | 10:52 | |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax Driver - RDF status validation https://review.opendev.org/720723 | 10:55 |
| *** lvbin02 has joined #openstack-cinder | 11:15 | |
| *** lvbin01 has quit IRC | 11:15 | |
| *** lvbin02 is now known as lvbin01 | 11:17 | |
| raghavendrat | hi geguileo: | 11:17 |
| geguileo | raghavendrat:hi | 11:17 |
| raghavendrat | this is regarding https://review.opendev.org/#/c/713803/; | 11:20 |
| raghavendrat | tried to address review comments | 11:20 |
| raghavendrat | whenver you get time, request you to please share your feedback. thanks. | 11:21 |
| *** tkajinam has quit IRC | 11:21 | |
| *** Xuchu has joined #openstack-cinder | 11:23 | |
| *** sapd1 has quit IRC | 11:42 | |
| *** e0ne has quit IRC | 11:43 | |
| *** e0ne has joined #openstack-cinder | 11:43 | |
| *** dpawlik has quit IRC | 11:50 | |
| *** dpawlik has joined #openstack-cinder | 11:50 | |
| *** dpawlik has quit IRC | 11:52 | |
| *** dpawlik has joined #openstack-cinder | 11:53 | |
| *** dpawlik has quit IRC | 11:54 | |
| *** dpawlik has joined #openstack-cinder | 11:54 | |
| *** rosmaita has joined #openstack-cinder | 11:55 | |
| *** ociuhandu has joined #openstack-cinder | 11:57 | |
| *** e0ne has quit IRC | 11:58 | |
| *** ociuhandu has quit IRC | 12:02 | |
| geguileo | raghavendrat: done | 12:10 |
| raghavendrat | thanks geguileo: ... i will work on review comments. | 12:15 |
| *** Xuchu has quit IRC | 12:16 | |
| *** Lucas_Gray has joined #openstack-cinder | 12:25 | |
| smcginnis | whoami-rajat: raghavendrat: It's a wiki, any account can edit things. | 12:27 |
| smcginnis | No need to delete the CI entry and create a new one. Just update any information that is no longer up to date. | 12:27 |
| raghavendrat | thanks smcginnis: we updated last line on page. | 12:29 |
| *** Xuchu has joined #openstack-cinder | 12:30 | |
| whoami-rajat | smcginnis, okay. i wasn't able to update the second page | 12:30 |
| smcginnis | whoami-rajat: Might want to check with infra about that some time to make sure your account doesn't have an issue with the wiki. | 12:31 |
| smcginnis | raghavendrat: Is the contact information on that page still accurate? | 12:32 |
| raghavendrat | yes. My colleague Rishabh's information is accurate. | 12:32 |
| whoami-rajat | smcginnis, okay. Thanks! | 12:32 |
| *** udesale_ has quit IRC | 12:34 | |
| *** Luzi has joined #openstack-cinder | 12:42 | |
| *** Xuchu has quit IRC | 12:54 | |
| *** ykarel is now known as ykarel|afk | 12:56 | |
| *** Lucas_Gray has quit IRC | 13:06 | |
| *** irclogbot_0 has quit IRC | 13:06 | |
| *** irclogbot_0 has joined #openstack-cinder | 13:07 | |
| *** kevinz has quit IRC | 13:09 | |
| rosmaita | kevinz: no | 13:09 |
| *** kevinz has joined #openstack-cinder | 13:14 | |
| *** raghavendrat has quit IRC | 13:15 | |
| rosmaita | smcginnis: when you have a few minutes, https://review.opendev.org/#/c/720294/3 | 13:28 |
| *** enriquetaso has joined #openstack-cinder | 13:30 | |
| *** lvbin01 has quit IRC | 13:30 | |
| *** ociuhandu has joined #openstack-cinder | 13:30 | |
| *** lvbin01 has joined #openstack-cinder | 13:30 | |
| *** psachin has quit IRC | 13:34 | |
| *** ociuhandu has quit IRC | 13:35 | |
| *** digvijay has joined #openstack-cinder | 13:38 | |
| *** hoonetorg has quit IRC | 13:40 | |
| *** rishabhhpe has quit IRC | 13:48 | |
| *** eharney has joined #openstack-cinder | 13:52 | |
| *** tkajinam has joined #openstack-cinder | 13:53 | |
| *** rishabhhpe has joined #openstack-cinder | 13:57 | |
| -openstackstatus- NOTICE: Zuul is temporarily offline; service should be restored in about 15 minutes. | 13:58 | |
| *** hoonetorg has joined #openstack-cinder | 13:59 | |
| *** ociuhandu has joined #openstack-cinder | 14:00 | |
| *** lvbin01 has quit IRC | 14:03 | |
| digvijay | rosmaita: quick question - do we need to delete previous release note while adding new one for support https://github.com/openstack/cinder/commit/e46aecbaf535a505387402647625db44b65d1a24#diff-cbbb1b28b66b5b9a8150b9bd4ca50259 | 14:04 |
| rosmaita | digvijay: depends on when the previous release note was committed -- looking now | 14:05 |
| smcginnis | Generally, only if it's within the same development cycle. In which case, you also don't need to add a new release note. | 14:05 |
| smcginnis | As it would be a little confusing to have to lines in the release note output saying opposite things. | 14:06 |
| rosmaita | digvijay: looks like that was committed in Train | 14:06 |
| smcginnis | *two lines | 14:06 |
| rosmaita | digvijay: so, you need to leave the previous note there, and add your new note saying that the driver is now supported | 14:07 |
| rosmaita | smcginnis: ^^ please confirm | 14:07 |
| smcginnis | Yep, I concur. | 14:08 |
| rosmaita | thantks | 14:09 |
| *** sapd1 has joined #openstack-cinder | 14:10 | |
| *** lvbin01 has joined #openstack-cinder | 14:10 | |
| *** ykarel|afk is now known as ykarel | 14:22 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Allow setting volume readonly during creating https://review.opendev.org/610177 | 14:27 |
| *** sfernand has joined #openstack-cinder | 14:28 | |
| *** hemna has quit IRC | 14:29 | |
| *** ociuhandu has quit IRC | 14:29 | |
| *** Xuchu has joined #openstack-cinder | 14:34 | |
| *** ociuhandu has joined #openstack-cinder | 14:35 | |
| *** hemna_ has quit IRC | 14:35 | |
| *** ociuhandu has quit IRC | 14:40 | |
| *** andrebeltrami has joined #openstack-cinder | 14:40 | |
| *** digvijay has quit IRC | 14:53 | |
| *** Xuchu has quit IRC | 14:57 | |
| *** tkajinam has quit IRC | 14:59 | |
| *** Kvisle has quit IRC | 15:07 | |
| *** dpawlik has quit IRC | 15:07 | |
| *** sapd1 has quit IRC | 15:14 | |
| *** hemna93 has joined #openstack-cinder | 15:17 | |
| *** ykarel is now known as ykarel|away | 15:18 | |
| *** lvbin02 has joined #openstack-cinder | 15:19 | |
| *** lvbin01 has quit IRC | 15:22 | |
| *** lvbin02 is now known as lvbin01 | 15:22 | |
| *** hemna_ has joined #openstack-cinder | 15:23 | |
| *** hemna_ has quit IRC | 15:24 | |
| *** vishalmanchanda has quit IRC | 15:26 | |
| *** sapd1 has joined #openstack-cinder | 15:26 | |
| *** hemna93 is now known as hemna | 15:32 | |
| *** hemna is now known as hemna__ | 15:35 | |
| *** hemna__ is now known as hemna | 15:37 | |
| *** hemna is now known as hemna__ | 15:37 | |
| -openstackstatus- NOTICE: Gerrit will be restarted to correct a misconfiguration which caused some git mirrors to have outdated references. | 15:46 | |
| *** hoonetorg has quit IRC | 15:46 | |
| *** ianychoi_ is now known as ianychoi | 15:53 | |
| *** KeithMnemonic has joined #openstack-cinder | 16:00 | |
| *** hoonetorg has joined #openstack-cinder | 16:00 | |
| rosmaita | hemna__: did you see http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014278.html on the ML? | 16:02 |
| rosmaita | should i just point him to https://etherpad.opendev.org/p/cinder-ceph-iscsi-driver ? | 16:02 |
| *** ganso has quit IRC | 16:03 | |
| *** ganso has joined #openstack-cinder | 16:05 | |
| *** Luzi has quit IRC | 16:15 | |
| openstackgerrit | Digvijay Ukirde proposed openstack/cinder master: Add support for IBM GPFS Driver https://review.opendev.org/721297 | 16:32 |
| *** yaawang has joined #openstack-cinder | 16:33 | |
| *** yaawang_ has quit IRC | 16:33 | |
| *** ociuhandu has joined #openstack-cinder | 16:36 | |
| *** digvijay has joined #openstack-cinder | 16:43 | |
| digvijay | rosmaita, smcginnis: https://review.opendev.org/#/c/721297/ | 16:44 |
| *** kklimonda has quit IRC | 16:54 | |
| *** kklimonda has joined #openstack-cinder | 16:55 | |
| *** enriquetaso has quit IRC | 16:56 | |
| *** ociuhandu has quit IRC | 16:56 | |
| *** hemna has joined #openstack-cinder | 16:58 | |
| *** sapd1 has quit IRC | 17:07 | |
| *** e0ne has joined #openstack-cinder | 17:07 | |
| hemna | mep | 17:09 |
| *** ociuhandu has joined #openstack-cinder | 17:10 | |
| *** e0ne has quit IRC | 17:16 | |
| *** digvijay has quit IRC | 17:16 | |
| *** ociuhandu has quit IRC | 17:22 | |
| *** enriquetaso has joined #openstack-cinder | 17:31 | |
| *** hemna__ has quit IRC | 17:32 | |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Tests: Make tests less random https://review.opendev.org/701275 | 17:38 |
| *** rishabhhpe has quit IRC | 17:43 | |
| *** billkgr has joined #openstack-cinder | 17:53 | |
| hemna | mep | 17:56 |
| *** hemna has quit IRC | 17:58 | |
| *** hemna has joined #openstack-cinder | 17:59 | |
| *** ircuser-1 has joined #openstack-cinder | 18:01 | |
| *** billkgr has quit IRC | 18:07 | |
| *** billkgr has joined #openstack-cinder | 18:12 | |
| rosmaita | jungleboyj or smcginnis: when you have a minute, https://review.opendev.org/#/c/720678/ (easy review) | 18:12 |
| *** ociuhandu has joined #openstack-cinder | 18:15 | |
| lseki | good afternoon folks, can I have some reviews on this patch, please? https://review.opendev.org/#/c/713515 | 18:17 |
| lseki | it's a simple bugfix + 5 small unit tests | 18:18 |
| openstackgerrit | Thiago Correa proposed openstack/cinder master: NetApp SolidFire: Fix retype to SolidFire https://review.opendev.org/710336 | 18:19 |
| *** ociuhandu has quit IRC | 18:20 | |
| *** ociuhandu has joined #openstack-cinder | 18:20 | |
| smcginnis | lseki: Are the SolidFire tests run by a different CI than NetApp CI? | 18:29 |
| smcginnis | lseki: Oh, nevermind. For some reason I was thinking that was a SF change, but it's not. | 18:29 |
| smcginnis | Still curious though, since I don't see it in the list. | 18:29 |
| lseki | smcginnis: yeah the patch is for ONTAP | 18:31 |
| openstackgerrit | Fernando Ferraz proposed openstack/cinder master: NetApp SolidFire: Fix pylint issues https://review.opendev.org/710476 | 18:32 |
| lseki | hmm the SF might be ignoring ONTAP patches, I'll double-check its job definition | 18:35 |
| sfernand | Hi folks! Could someone please take a look on these two patches? One is a small fix in retype operation to SolidFire, the other fixes pylint issues for the SolidFire driver. | 18:38 |
| sfernand | https://review.opendev.org/#/c/710476/ | 18:38 |
| sfernand | https://review.opendev.org/#/c/710336/ | 18:38 |
| smcginnis | sfernand: We still need to see Zuul and third party CI results on those. | 18:40 |
| sfernand | no problem | 18:41 |
| openstackgerrit | Sofia Enriquez proposed openstack/cinder master: NFS encrypted volume support https://review.opendev.org/597148 | 18:47 |
| *** enriquetaso has quit IRC | 18:56 | |
| *** ociuhandu has quit IRC | 18:57 | |
| *** ociuhandu has joined #openstack-cinder | 18:58 | |
| openstackgerrit | Lucio Seki proposed openstack/cinder master: NetApp ONTAP: Fix iSCSI multiattach volume terminates connection https://review.opendev.org/713515 | 19:00 |
| *** jdillaman has joined #openstack-cinder | 19:00 | |
| *** ociuhandu has quit IRC | 19:03 | |
| *** enriquetaso has joined #openstack-cinder | 19:06 | |
| *** jmccrory has quit IRC | 19:08 | |
| *** jmccrory has joined #openstack-cinder | 19:09 | |
| smcginnis | kmarc: Do you know the situation with the Datera CI? | 19:10 |
| smcginnis | Or do I need to put up a "Mark Datera driver unsupported" patch again? :P | 19:10 |
| openstackgerrit | Lucio Seki proposed openstack/cinder master: NetApp ONTAP: Fix iSCSI multiattach volume terminates connection https://review.opendev.org/713515 | 19:15 |
| openstackgerrit | Merged openstack/cinder master: add docs and release note for sandstone iscsi driver Partially-implements: bp add-sandstone-driver https://review.opendev.org/720678 | 19:17 |
| *** Lucas_Gray has joined #openstack-cinder | 19:18 | |
| *** Lucas_Gray has quit IRC | 19:21 | |
| *** Lucas_Gray has joined #openstack-cinder | 19:24 | |
| *** e0ne has joined #openstack-cinder | 19:35 | |
| *** e0ne has quit IRC | 19:40 | |
| *** Lucas_Gray has quit IRC | 19:41 | |
| *** e0ne has joined #openstack-cinder | 19:41 | |
| *** enriquetaso has quit IRC | 19:44 | |
| *** Lucas_Gray has joined #openstack-cinder | 19:45 | |
| *** e0ne has quit IRC | 19:46 | |
| *** ociuhandu has joined #openstack-cinder | 19:50 | |
| kmarc | looking | 19:57 |
| *** ociuhandu has quit IRC | 19:57 | |
| hemna | so I've been looking at the volume retype unit tests that we havw | 20:03 |
| hemna | test_volume_retype.py for example | 20:03 |
| hemna | doesn't really tests much of anything | 20:03 |
| hemna | and doing some digging, the tests actually don't retype | 20:03 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/tests/unit/volume/test_volume_retype.py#L147 | 20:04 |
| hemna | that test passes, | 20:04 |
| hemna | but the volume isn't retyped to the 'multiattach-type2' type. | 20:04 |
| hemna | it's still the original volume type on the volume. :( | 20:04 |
| *** enriquetaso has joined #openstack-cinder | 20:05 | |
| hemna | if you add "self.assertTrue('multiattach-type2', vol.volume_type['name'])" | 20:05 |
| hemna | right after that line, that assert fails | 20:05 |
| hemna | volume makes it to retyping state, but that's it | 20:09 |
| hemna | I don't see where we mock out the rpc calls either | 20:09 |
| *** ociuhandu has joined #openstack-cinder | 20:10 | |
| *** enriquetaso has quit IRC | 20:10 | |
| kmarc | smcginnis: :-D Please don't revert our efforts right before the finnish line :-D - the CI was my fault, it wasn't running at the time when zuul gave +1; We are actually migrating to a jenkins-based CI setup as described here: https://docs.openstack.org/infra/system-config/third_party.html#the-jenkins-gerrit-trigger-plugin-way, so right now we are in-between. Sorry for this. | 20:13 |
| smcginnis | kmarc: No worries. I just got a little concerned that our CI report didn't find any recent successful runs. :) | 20:17 |
| kmarc | actually I was going to ask about this: when is it expected it to run? Last time I configured it only to run when zuul +1s a datera-related change | 20:19 |
| kmarc | I see other CIs randomly run on patches | 20:19 |
| rosmaita | kmarc: i believe it's supposed to run on any cinder patches, not just datera changes | 20:20 |
| rosmaita | i think the randomness you see is not planned, it just happens | 20:21 |
| kmarc | :-) okay. I think then our current configuration is good | 20:22 |
| kmarc | https://i.imgur.com/hrFujJ0.png | 20:22 |
| kmarc | when zuul verifies it, then it is supposed to run | 20:23 |
| kmarc | (btw. current, gerrit-triggered run finished successfully) | 20:23 |
| rosmaita | kmarc: that sounds correct -- "CI's do not need to kick off tests until Zuul's has given a +1, though it is up to the maintainer if you want to trigger immediately on all patchsets." | 20:24 |
| kmarc | yes, that alsow works. "run-Datera" in the comment and the same code path is triggered | 20:25 |
| kmarc | So in the upcoming days (weeks...) We will migrate this thing finally to the gerrit-plugin method, but I will pay more attention that the current script is healthy and does his job | 20:25 |
| rosmaita | kmarc: ok, that sounds good -- we were having trouble finding recent CI runs that were reporting success | 20:26 |
| kmarc | check it now | 20:26 |
| kmarc | I just triggered a run | 20:26 |
| kmarc | here are the logs: http://stkci.daterainc.com.s3-website-us-west-2.amazonaws.com/refs-changes-94-720294-3/index.html, for the changelog update patch (http://stkci.daterainc.com.s3-website-us-west-2.amazonaws.com/refs-changes-94-720294-3/index.html) | 20:28 |
| kmarc | rosmaita: I'm pushing soon the docs update too | 20:29 |
| *** ociuhandu has quit IRC | 20:30 | |
| *** billkgr has quit IRC | 20:31 | |
| smcginnis | kmarc: You probably don't want that to kick off on Verified+2. | 20:31 |
| rosmaita | kmarc: will look for the docs update; also, what smcginnis said, i think you only see verified +2 when code has already merged | 20:32 |
| kmarc | isn't it like "the more CI runs, the merrier?" :-) | 20:33 |
| kmarc | Okay I will check it | 20:33 |
| hemna | it doesn't seem like cinder really has a functioning and/or functional test for retype | 20:35 |
| hemna | :0 | 20:35 |
| rosmaita | that seems ... not good | 20:35 |
| hemna | I'm shocked actually | 20:35 |
| smcginnis | kmarc: I'm not sure how that info gets populated, but note that "zuul" isn't the author of the patch. So guessing that refers to "author" for comment-added? | 20:36 |
| hemna | most of the retype tests are unit tests that drivers have written | 20:36 |
| hemna | the test_volume_retype.py is....woefully lacking and the few calls to retype in there just result in setting the volume into a state of retyping | 20:36 |
| hemna | and that's it. | 20:36 |
| * hemna is scared | 20:36 | |
| kmarc | yes, just a badly named variable (author = event["author"]["username"]) | 20:37 |
| kmarc | sorry I don't wanna hijack hemna's topic, that sounds pretty much more important | 20:37 |
| smcginnis | kmarc: OK, cool. Just making sure. ;) | 20:37 |
| hemna | nah it's cool, evidently retype has been like this forever | 20:49 |
| rosmaita | hemna: this may make you feel better: https://opendev.org/openstack/tempest/src/branch/master/tempest/api/volume/admin/test_volume_retype.py | 20:49 |
| hemna | so there is that :P | 20:49 |
| rosmaita | or not, i haven't really looked carefully at those tests | 20:50 |
| hemna | it's pretty lean too | 20:50 |
| rosmaita | if you want, you could add some scenario tests to cinder-tempest-plugin | 20:52 |
| hemna | yah that or some functional tests | 20:53 |
| hemna | retype is a monster in capability depending on the volume, it's backend, etc. etc | 20:53 |
| *** e0ne has joined #openstack-cinder | 20:54 | |
| openstackgerrit | Mark Korondi proposed openstack/cinder master: {WIP} Updating docs for Datera driver https://review.opendev.org/721342 | 20:58 |
| kmarc | ^ rosmaita give us a bit of time, I will remove the {WIP} a bit later | 21:00 |
| rosmaita | kmarc: np | 21:02 |
| *** ociuhandu has joined #openstack-cinder | 21:03 | |
| rosmaita | would be good to get it done tomorrow, though | 21:04 |
| *** ociuhandu has quit IRC | 21:08 | |
| kmarc | I'm double checking the settable properties that are changed in the documentation | 21:09 |
| kmarc | Actually you can review it already, even if we change that property, it would not affect that much of the docs | 21:10 |
| rosmaita | kmarc: left a comment on your patch | 21:14 |
| kmarc | :-) thanks. Side note: when I write an email, my vim puts an EXTRA RED WARNING CHARACTER!!!! as the trailing whitespace, whereas in python code it highlights it as a slightly bluer blue :-) I guess it's time to check $MYVIMRC | 21:37 |
| *** e0ne has quit IRC | 21:42 | |
| *** dosaboy has quit IRC | 21:46 | |
| *** enriquetaso has joined #openstack-cinder | 21:50 | |
| *** dosaboy has joined #openstack-cinder | 22:02 | |
| *** ociuhandu has joined #openstack-cinder | 22:04 | |
| *** rcernin has quit IRC | 22:05 | |
| *** rcernin has joined #openstack-cinder | 22:06 | |
| *** e0ne has joined #openstack-cinder | 22:06 | |
| *** Lucas_Gray has quit IRC | 22:13 | |
| *** ociuhandu has quit IRC | 22:18 | |
| *** ociuhandu has joined #openstack-cinder | 22:18 | |
| *** tosky has quit IRC | 22:19 | |
| *** ociuhandu has quit IRC | 22:23 | |
| *** tkajinam has joined #openstack-cinder | 22:43 | |
| openstackgerrit | Virgil Mihailovici proposed openstack/cinder master: {WIP} Updating docs for Datera driver https://review.opendev.org/721342 | 22:47 |
| *** Lucas_Gray has joined #openstack-cinder | 23:04 | |
| *** threestrands has joined #openstack-cinder | 23:18 | |
| *** Lucas_Gray has quit IRC | 23:34 | |
| *** enriquetaso has quit IRC | 23:45 | |
| *** e0ne has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
