| *** Xuchu has joined #openstack-cinder | 00:22 | |
| *** ociuhandu has joined #openstack-cinder | 00:43 | |
| *** ociuhandu has quit IRC | 00:49 | |
| *** Liang__ has joined #openstack-cinder | 01:03 | |
| *** zhanglong has joined #openstack-cinder | 01:27 | |
| *** ruffian_sheep has joined #openstack-cinder | 01:34 | |
| ruffian_sheep | whoami-rajat :Hi,are u online? | 01:36 |
|---|---|---|
| ruffian_sheep | rosmaita : Hi,are u online? | 01:55 |
| rosmaita | ruffian_sheep: what's up? | 01:55 |
| ruffian_sheep | https://review.opendev.org/#/c/721210/1 | 01:56 |
| ruffian_sheep | rosmaita : Do you mean I just replace the same content with unsupported commits? | 01:56 |
| rosmaita | looking | 01:57 |
| ruffian_sheep | rosmaita : Do I need to change the commit message? | 01:57 |
| rosmaita | ruffian_sheep: here's what's going on | 01:57 |
| rosmaita | you want to keep the driver the way it is, containing any bugfixes, etc you have done during ussuri | 01:58 |
| rosmaita | since jay's commit marking it unsupported was also in ussuri | 01:58 |
| rosmaita | all you need to do is revert his commit | 01:58 |
| rosmaita | so my suggestion is to abandon https://review.opendev.org/#/c/721210/ | 01:59 |
| rosmaita | and go to jay's patch: https://review.opendev.org/#/c/702479/ | 01:59 |
| rosmaita | and near the top you will see 2 buttons: cherry-pick and revert | 01:59 |
| rosmaita | click on revert | 01:59 |
| rosmaita | and gerrit will automatically propose a patch that will un-do jay's change | 02:00 |
| rosmaita | and then your driver will be supported | 02:00 |
| rosmaita | hopefully it will be a smooth change with no merge conflicts | 02:00 |
| ruffian_sheep | Some changes in https://review.opendev.org/#/c/721210/1 are to adapt to the related changes of ussuri. I just need to remove the changes in jay's patch: https://review.opendev.org/#/c/702479/ and update my adapted driver, right? | 02:00 |
| rosmaita | yes, do those separately | 02:01 |
| rosmaita | the key thing is to get the revert patch posted | 02:02 |
| openstackgerrit | hjy proposed openstack/cinder master: Revert "Mark MacroSAN Driver Unsupported" https://review.opendev.org/721428 | 02:02 |
| rosmaita | looks good, hopefully it will pass tests with no problem | 02:03 |
| ruffian_sheep | Just like this, all I have to do is to make the driver submission after adaptation on this branch. Do I need to modify the message? | 02:03 |
| rosmaita | no, commit message on https://review.opendev.org/721428 looks fine | 02:04 |
| ruffian_sheep | It seems that without adding new features, such as multiattach, everything went well yesterday | 02:04 |
| rosmaita | yes, it's probably best to add features one by one | 02:05 |
| rosmaita | smaller patches are easier to review, and problems are easier to track down | 02:05 |
| ruffian_sheep | get, then I submit a new driver. Perform ci. Things are done | 02:06 |
| rosmaita | :) | 02:07 |
| ruffian_sheep | ;) | 02:07 |
| ruffian_sheep | https://blueprints.launchpad.net/cinder/+spec/macrosan-driver-supported | 02:13 |
| ruffian_sheep | rosmaita : In addition, I would like to ask, does that mean that this is useless? Or I need to add | 02:13 |
| rosmaita | go ahead and change the whiteboard on that blueprint so that your new patch is listed | 02:15 |
| ruffian_sheep | rosmaita : I am not so familiar with buleprint. You mean, add it in the commit message, right? As before, https://review.opendev.org/#/c/674156/ | 02:17 |
| rosmaita | yes, that will work -- add "Partially-implements: bp macrosan-driver-supported" to the commit message | 02:19 |
| openstackgerrit | zhufl proposed openstack/cinder master: [api-ref]control_location should be mandatory https://review.opendev.org/677862 | 02:20 |
| *** lvbin01 has quit IRC | 02:20 | |
| *** Xuchu has quit IRC | 02:38 | |
| *** Xuchu has joined #openstack-cinder | 02:42 | |
| *** psachin has joined #openstack-cinder | 03:25 | |
| *** ruffian_sheep has quit IRC | 03:52 | |
| *** lvbin01 has joined #openstack-cinder | 03:57 | |
| *** ociuhandu has joined #openstack-cinder | 04:19 | |
| *** rishabhhpe has joined #openstack-cinder | 04:22 | |
| *** ociuhandu has quit IRC | 04:24 | |
| *** ykarel|away is now known as ykarel | 04:45 | |
| *** zhanglong has quit IRC | 04:48 | |
| *** zhanglong has joined #openstack-cinder | 04:52 | |
| *** vishalmanchanda has joined #openstack-cinder | 05:09 | |
| *** udesale has joined #openstack-cinder | 05:10 | |
| *** lvbin02 has joined #openstack-cinder | 05:15 | |
| *** ykarel is now known as ykarel|afk | 05:16 | |
| *** lvbin01 has quit IRC | 05:18 | |
| *** lvbin02 is now known as lvbin01 | 05:18 | |
| *** udesale_ has joined #openstack-cinder | 05:21 | |
| *** udesale has quit IRC | 05:24 | |
| *** ykarel|afk is now known as ykarel | 05:33 | |
| openstackgerrit | hjy proposed openstack/cinder master: Revert "Mark MacroSAN Driver Unsupported" https://review.opendev.org/721428 | 06:07 |
| *** dpawlik has joined #openstack-cinder | 06:08 | |
| *** udesale_ has quit IRC | 06:14 | |
| *** andrebeltrami has quit IRC | 06:20 | |
| *** breizhkoala has joined #openstack-cinder | 06:36 | |
| *** udesale has joined #openstack-cinder | 06:37 | |
| *** lvbin02 has joined #openstack-cinder | 06:38 | |
| *** lvbin01 has quit IRC | 06:41 | |
| *** lvbin02 is now known as lvbin01 | 06:41 | |
| *** udesale has quit IRC | 06:43 | |
| *** ociuhandu has joined #openstack-cinder | 06:48 | |
| *** ociuhandu has quit IRC | 06:58 | |
| *** ociuhandu has joined #openstack-cinder | 06:58 | |
| openstackgerrit | Raghavendra Tilay proposed openstack/cinder master: HPE 3PAR: Support duplicated FQDN in network https://review.opendev.org/713803 | 07:06 |
| *** ociuhandu has quit IRC | 07:26 | |
| *** tosky has joined #openstack-cinder | 07:44 | |
| *** threestrands has quit IRC | 07:55 | |
| *** ociuhandu has joined #openstack-cinder | 08:01 | |
| *** lennyb has joined #openstack-cinder | 08:03 | |
| *** KeithMnemonic has quit IRC | 08:05 | |
| *** e0ne has joined #openstack-cinder | 08:08 | |
| *** martinkennelly has joined #openstack-cinder | 08:09 | |
| *** udesale has joined #openstack-cinder | 08:16 | |
| *** udesale_ has joined #openstack-cinder | 08:22 | |
| *** udesale has quit IRC | 08:22 | |
| *** udesale has joined #openstack-cinder | 08:22 | |
| *** lvbin02 has joined #openstack-cinder | 08:56 | |
| *** lvbin01 has quit IRC | 08:59 | |
| *** lvbin02 is now known as lvbin01 | 08:59 | |
| *** e0ne has quit IRC | 09:03 | |
| *** e0ne has joined #openstack-cinder | 09:03 | |
| *** zhanglong has quit IRC | 09:07 | |
| *** vishalmanchanda has quit IRC | 09:09 | |
| *** ykarel is now known as ykarel|lunch | 09:14 | |
| *** n-saito has quit IRC | 09:19 | |
| *** sapd1 has joined #openstack-cinder | 09:35 | |
| *** lvbin02 has joined #openstack-cinder | 09:41 | |
| *** lvbin01 has quit IRC | 09:44 | |
| *** lvbin01 has joined #openstack-cinder | 09:47 | |
| *** lvbin02 has quit IRC | 09:47 | |
| *** e0ne has quit IRC | 09:59 | |
| *** e0ne has joined #openstack-cinder | 10:01 | |
| *** Liang__ has quit IRC | 10:03 | |
| *** xinliang has joined #openstack-cinder | 10:18 | |
| *** e0ne has quit IRC | 10:18 | |
| *** e0ne has joined #openstack-cinder | 10:19 | |
| *** ykarel|lunch is now known as ykarel | 10:20 | |
| *** e0ne_ has joined #openstack-cinder | 10:45 | |
| *** e0ne has quit IRC | 10:45 | |
| *** xinliang has quit IRC | 10:48 | |
| *** sapd1 has quit IRC | 10:50 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Fix rbd attach on python3 https://review.opendev.org/720553 | 11:04 |
| *** udesale has quit IRC | 11:09 | |
| openstackgerrit | Mark Korondi proposed openstack/cinder master: Updating docs for Datera driver https://review.opendev.org/721342 | 11:14 |
| *** ociuhandu has quit IRC | 11:34 | |
| *** ociuhandu has joined #openstack-cinder | 11:35 | |
| *** ociuhandu has quit IRC | 11:40 | |
| *** e0ne_ has quit IRC | 11:48 | |
| *** e0ne has joined #openstack-cinder | 11:48 | |
| *** e0ne has quit IRC | 11:49 | |
| *** e0ne has joined #openstack-cinder | 11:50 | |
| *** e0ne_ has joined #openstack-cinder | 12:10 | |
| *** e0ne has quit IRC | 12:10 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Add filter_function and goodness_function to pools https://review.opendev.org/711546 | 12:14 |
| whoami-rajat | geguileo, ^ i've added the test and done few more code changes | 12:16 |
| geguileo | whoami-rajat: why did you add sel.filter_function = None and self.goodness_function = 0 ? | 12:19 |
| whoami-rajat | geguileo, when we update from volume capabilities, the pool takes default values from BackendState and updates them in the PoolState class update_from_volume_capabilities method | 12:20 |
| whoami-rajat | https://github.com/openstack/cinder/blob/master/cinder/scheduler/host_manager.py#L229-L234 | 12:21 |
| whoami-rajat | Correct me if i'm wrong, i just followed the code flow | 12:22 |
| *** brinzhang has quit IRC | 12:30 | |
| geguileo | whoami-rajat: why are we defining those parameters in the BAckendState if we are only using them in the PoolState? | 12:36 |
| geguileo | that whole host_manager.py file looks like a poc | 12:37 |
| geguileo | whoami-rajat:minor change needed on the tests when setting the confs | 12:46 |
| geguileo | and the other comment is just me venting on the garbage we already have on the file | 12:46 |
| *** ociuhandu has joined #openstack-cinder | 12:48 | |
| whoami-rajat | geguileo, i saw the BackendState values only used by the PoolState class like self.multiattach and other parameters, also your comment on the BackendState init method describes that the instance attributes are used to resolve the circular dependencies | 12:49 |
| whoami-rajat | so i concluded that these BackendState attributes are simply defined as PoolState helper attributes | 12:50 |
| geguileo | whoami-rajat:the circular dependency is only for the PoolState, not for the other attributes | 12:51 |
| whoami-rajat | oh ok. got it. | 12:51 |
| whoami-rajat | still other attributes are only used inside PoolState update cap method | 12:52 |
| geguileo | the other attributes are most likely leftovers when we started supporting pools | 12:52 |
| geguileo | anyway, not your fault :-( | 12:52 |
| *** psachin has quit IRC | 12:53 | |
| *** lvbin01 has quit IRC | 12:53 | |
| *** lvbin01 has joined #openstack-cinder | 12:55 | |
| whoami-rajat | yeah, i also thought there is redundancy when going through this | 12:56 |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Add filter_function and goodness_function to pools https://review.opendev.org/711546 | 12:57 |
| whoami-rajat | if you would like, we can refactor it in a followup, but i don't have enough code understanding of this module | 12:57 |
| whoami-rajat | ^ did the test changes | 12:58 |
| *** ociuhandu has quit IRC | 12:58 | |
| *** ociuhandu has joined #openstack-cinder | 13:00 | |
| *** ociuhandu has quit IRC | 13:01 | |
| *** ociuhandu has joined #openstack-cinder | 13:02 | |
| *** ykarel is now known as ykarel|afk | 13:08 | |
| *** rcernin has quit IRC | 13:14 | |
| *** zhanglong has joined #openstack-cinder | 13:16 | |
| *** enriquetaso has joined #openstack-cinder | 13:17 | |
| *** zhanglong has quit IRC | 13:28 | |
| *** zhanglong has joined #openstack-cinder | 13:28 | |
| *** spatel has joined #openstack-cinder | 13:35 | |
| *** e0ne has joined #openstack-cinder | 13:41 | |
| *** e0ne_ has quit IRC | 13:41 | |
| *** lvbin01 has quit IRC | 13:42 | |
| *** KeithMnemonic has joined #openstack-cinder | 13:44 | |
| hemna | morning | 13:46 |
| *** lvbin01 has joined #openstack-cinder | 13:48 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder-tempest-plugin master: Add LVM+tgt tempest job https://review.opendev.org/537658 | 13:53 |
| whoami-rajat | tosky, ^ Done | 13:55 |
| tosky | ack! | 13:56 |
| tosky | thanks | 13:56 |
| whoami-rajat | tosky, np. thanks for keeping an eye on all the patches | 13:58 |
| *** digvijay has joined #openstack-cinder | 14:04 | |
| *** sapd1 has joined #openstack-cinder | 14:07 | |
| openstackgerrit | Xuchu Jiang proposed openstack/cinder master: [Storwize] Retry after IndexError occur https://review.opendev.org/721626 | 14:09 |
| Xuchu | whoami-rajat: Hi, Can you help to review this patch if you are available? https://review.opendev.org/#/c/715766/ Thanks | 14:17 |
| whoami-rajat | Xuchu, it needs a rebase | 14:18 |
| Xuchu | oh, So I need to rebase and commit again? | 14:18 |
| *** zhanglong has quit IRC | 14:18 | |
| whoami-rajat | you need to rebase and update the patchset | 14:19 |
| Xuchu | ok, thanks | 14:20 |
| whoami-rajat | np | 14:21 |
| whoami-rajat | ping me when it's done, i will review | 14:22 |
| *** ykarel|afk is now known as ykarel | 14:22 | |
| digvijay | rosmaita, smcginnis: can you review the patch - https://review.opendev.org/#/c/721297/ logs - https://s3.eu-geo.objectstorage.softlayer.net/ibm-storage-ci-log/ibm-gpfs-dsvm-tempest-full/72/index.html | 14:24 |
| rosmaita | digvijay: in meetings for a while, but ack -- will look a bit later | 14:25 |
| *** sapd1 has quit IRC | 14:29 | |
| digvijay | rosmaita: thanks :) | 14:30 |
| openstackgerrit | Xuchu Jiang proposed openstack/cinder master: Delete volume with additional removehostmappings parameter https://review.opendev.org/715766 | 14:35 |
| Xuchu | smcginnis: Hi, I updated this patch according to your comments, Now CI is ok now. Can you help to review it agian ? Thanks https://review.opendev.org/#/c/698630/ | 14:37 |
| *** _erlon_ has quit IRC | 14:40 | |
| *** _erlon_ has joined #openstack-cinder | 14:41 | |
| *** sapd1 has joined #openstack-cinder | 14:41 | |
| smcginnis | Xuchu: I'm still confused as to why that needs a config option, but I can try to take a look later. | 14:43 |
| Xuchu | smcginnis: I removed option of “removehostmapping” patch, in this “Ipv6” patch, you said, there should not have a IPv6 volume type, so I removed the volume_type related code | 14:45 |
| *** tkajinam has quit IRC | 15:40 | |
| *** ykarel is now known as ykarel|away | 15:40 | |
| *** rishabhhpe has quit IRC | 15:40 | |
| *** udesale_ has quit IRC | 15:41 | |
| *** ociuhandu has quit IRC | 16:15 | |
| *** ociuhandu has joined #openstack-cinder | 16:17 | |
| *** digvijay has quit IRC | 16:19 | |
| *** ociuhandu has quit IRC | 16:20 | |
| *** Xuchu has quit IRC | 16:21 | |
| *** ociuhandu has joined #openstack-cinder | 16:21 | |
| *** kklimonda has quit IRC | 16:28 | |
| *** kklimonda has joined #openstack-cinder | 16:30 | |
| *** yaawang_ has joined #openstack-cinder | 16:32 | |
| *** yaawang has quit IRC | 16:33 | |
| *** e0ne has quit IRC | 16:36 | |
| *** e0ne_ has joined #openstack-cinder | 16:36 | |
| *** kklimonda has quit IRC | 16:38 | |
| *** lseki has quit IRC | 16:38 | |
| *** dviroel has quit IRC | 16:38 | |
| *** carloss has quit IRC | 16:39 | |
| *** kklimonda has joined #openstack-cinder | 16:39 | |
| *** masayukig has quit IRC | 16:39 | |
| *** simondodsley has quit IRC | 16:40 | |
| *** dviroel has joined #openstack-cinder | 16:40 | |
| *** carloss has joined #openstack-cinder | 16:40 | |
| *** simondodsley has joined #openstack-cinder | 16:41 | |
| *** mnaser has quit IRC | 16:41 | |
| *** lseki has joined #openstack-cinder | 16:42 | |
| *** bcm has quit IRC | 16:42 | |
| *** TheJulia has quit IRC | 16:42 | |
| *** masayukig has joined #openstack-cinder | 16:43 | |
| *** bcm has joined #openstack-cinder | 16:43 | |
| *** TheJulia has joined #openstack-cinder | 16:44 | |
| *** mnaser has joined #openstack-cinder | 16:44 | |
| *** xyang has quit IRC | 16:45 | |
| *** xyang has joined #openstack-cinder | 16:46 | |
| *** mnaser has quit IRC | 16:46 | |
| *** mnaser has joined #openstack-cinder | 16:47 | |
| *** mnaser has quit IRC | 16:49 | |
| *** mnaser has joined #openstack-cinder | 16:50 | |
| *** e0ne_ has quit IRC | 17:19 | |
| *** ociuhandu has quit IRC | 17:34 | |
| *** ociuhandu has joined #openstack-cinder | 17:35 | |
| *** ociuhandu has quit IRC | 17:40 | |
| *** sapd1 has quit IRC | 18:05 | |
| *** ociuhandu has joined #openstack-cinder | 18:24 | |
| *** gmann is now known as gmann_lunch | 18:31 | |
| *** ociuhandu has quit IRC | 18:44 | |
| *** ociuhandu has joined #openstack-cinder | 18:45 | |
| *** ociuhandu has quit IRC | 18:45 | |
| *** ociuhandu has joined #openstack-cinder | 18:45 | |
| *** gmann_lunch is now known as gmann | 18:51 | |
| openstackgerrit | Merged openstack/cinder master: PowerMax Driver - RDF status validation https://review.opendev.org/720723 | 18:59 |
| *** ociuhandu has quit IRC | 19:11 | |
| *** ociuhandu has joined #openstack-cinder | 19:11 | |
| *** ociuhandu has quit IRC | 19:17 | |
| *** Lucas_Gray has joined #openstack-cinder | 19:22 | |
| *** breizhkoala has quit IRC | 19:35 | |
| *** e0ne has joined #openstack-cinder | 19:36 | |
| *** martinkennelly has quit IRC | 19:36 | |
| *** ociuhandu has joined #openstack-cinder | 19:48 | |
| *** ociuhandu has quit IRC | 19:53 | |
| *** e0ne has quit IRC | 20:14 | |
| *** e0ne has joined #openstack-cinder | 20:37 | |
| *** ociuhandu has joined #openstack-cinder | 21:03 | |
| *** ociuhandu has quit IRC | 21:08 | |
| *** spatel has quit IRC | 21:30 | |
| *** dpawlik has quit IRC | 21:34 | |
| *** e0ne has quit IRC | 21:56 | |
| *** rcernin has joined #openstack-cinder | 22:17 | |
| *** Lucas_Gray has quit IRC | 22:25 | |
| *** tkajinam has joined #openstack-cinder | 22:53 | |
| *** spatel has joined #openstack-cinder | 22:53 | |
| *** tosky has quit IRC | 23:03 | |
| *** ociuhandu has joined #openstack-cinder | 23:25 | |
| *** ociuhandu has quit IRC | 23:30 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!