| *** pcaruana has quit IRC | 00:03 | |
| *** hamalq has quit IRC | 00:09 | |
| *** knomura has joined #openstack-cinder | 00:14 | |
| *** knomura has quit IRC | 00:19 | |
| *** knomura has joined #openstack-cinder | 00:28 | |
| *** knomura has quit IRC | 00:33 | |
| *** enriquetaso has quit IRC | 00:35 | |
| *** vkmc_ is now known as vkmc | 00:54 | |
| *** lseki has quit IRC | 00:54 | |
| *** gouthamr_ has quit IRC | 00:59 | |
| *** gouthamr_ has joined #openstack-cinder | 01:05 | |
| *** jdillaman has quit IRC | 01:11 | |
| *** Liang__ has joined #openstack-cinder | 01:15 | |
| *** gouthamr_ has quit IRC | 01:25 | |
| *** gouthamr_ has joined #openstack-cinder | 01:37 | |
| openstackgerrit | wanghao proposed openstack/cinder master: Support multiple filters together for volume time comparison filter https://review.opendev.org/740146 | 01:40 |
|---|---|---|
| *** gouthamr_ has quit IRC | 02:52 | |
| *** brinzhang has joined #openstack-cinder | 02:55 | |
| *** Lucas_Gray has quit IRC | 02:56 | |
| *** gouthamr_ has joined #openstack-cinder | 02:56 | |
| *** rcernin has quit IRC | 03:00 | |
| *** jmlowe has quit IRC | 03:01 | |
| *** rcernin has joined #openstack-cinder | 03:02 | |
| *** yaawang has quit IRC | 03:10 | |
| *** yaawang has joined #openstack-cinder | 03:10 | |
| *** brinzhang_ has joined #openstack-cinder | 03:11 | |
| *** brinzhang has quit IRC | 03:15 | |
| *** Lucas_Gray has joined #openstack-cinder | 03:20 | |
| *** gouthamr_ has quit IRC | 03:26 | |
| *** gouthamr_ has joined #openstack-cinder | 03:32 | |
| *** Lucas_Gray has quit IRC | 03:32 | |
| openstackgerrit | wanghao proposed openstack/cinder master: time comparison filter didn't support time zone offset https://review.opendev.org/734415 | 03:35 |
| openstackgerrit | haixin proposed openstack/cinder master: volume list query optimization https://review.opendev.org/740152 | 03:49 |
| *** ociuhandu has joined #openstack-cinder | 03:56 | |
| *** gouthamr_ has quit IRC | 04:00 | |
| *** ociuhandu has quit IRC | 04:01 | |
| *** markvoelker has joined #openstack-cinder | 04:08 | |
| *** gouthamr_ has joined #openstack-cinder | 04:11 | |
| *** gouthamr_ has quit IRC | 04:29 | |
| *** gouthamr_ has joined #openstack-cinder | 04:30 | |
| *** gouthamr_ has quit IRC | 04:35 | |
| *** gouthamr_ has joined #openstack-cinder | 04:40 | |
| *** abdysn has joined #openstack-cinder | 05:02 | |
| *** Luzi has joined #openstack-cinder | 05:12 | |
| *** udesale has joined #openstack-cinder | 05:13 | |
| *** brinzhang0 has joined #openstack-cinder | 05:13 | |
| *** markvoelker has quit IRC | 05:13 | |
| *** markvoelker has joined #openstack-cinder | 05:14 | |
| *** m75abrams has joined #openstack-cinder | 05:15 | |
| *** brinzhang_ has quit IRC | 05:16 | |
| *** markvoelker has quit IRC | 05:18 | |
| *** Luzi has quit IRC | 05:19 | |
| *** zzzeek has quit IRC | 05:19 | |
| *** Luzi has joined #openstack-cinder | 05:19 | |
| *** zzzeek has joined #openstack-cinder | 05:23 | |
| *** lxkong has joined #openstack-cinder | 05:27 | |
| openstackgerrit | wanghao proposed openstack/cinder master: Support multiple filters together for volume time comparison filter https://review.opendev.org/740146 | 05:49 |
| n-saito | ls | 05:51 |
| n-saito | sorry. | 05:52 |
| *** brinzhang_ has joined #openstack-cinder | 05:59 | |
| *** brinzhang0 has quit IRC | 06:03 | |
| *** vishalmanchanda has joined #openstack-cinder | 06:05 | |
| openstackgerrit | haixin proposed openstack/cinder-specs master: volume list query optimization https://review.opendev.org/726070 | 06:15 |
| openstackgerrit | Kazumasa Nomura proposed openstack/cinder master: Add Hitachi Block Storage Driver https://review.opendev.org/712832 | 06:23 |
| *** yaawang has quit IRC | 06:32 | |
| *** yaawang has joined #openstack-cinder | 06:33 | |
| *** pcaruana has joined #openstack-cinder | 06:37 | |
| openstackgerrit | Lucian Petrut proposed openstack/cinder master: smbfs: pick up remotefs method signature change https://review.opendev.org/739954 | 06:42 |
| *** CeeMac has joined #openstack-cinder | 06:44 | |
| *** vishakha has joined #openstack-cinder | 06:47 | |
| *** brinzhang0 has joined #openstack-cinder | 06:48 | |
| *** gouthamr_ has quit IRC | 06:50 | |
| *** brinzhang_ has quit IRC | 06:51 | |
| *** gouthamr_ has joined #openstack-cinder | 06:52 | |
| *** knikolla has quit IRC | 06:54 | |
| *** sri_ has quit IRC | 06:54 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: WIP: default type overrides https://review.opendev.org/737707 | 06:55 |
| *** knikolla has joined #openstack-cinder | 06:56 | |
| *** sri_ has joined #openstack-cinder | 06:56 | |
| *** whoami-rajat has joined #openstack-cinder | 06:59 | |
| *** gouthamr_ has quit IRC | 07:04 | |
| openstackgerrit | wanghao proposed openstack/cinder master: time comparison filter didn't support time zone offset https://review.opendev.org/734415 | 07:05 |
| *** gouthamr_ has joined #openstack-cinder | 07:05 | |
| *** gouthamr_ has quit IRC | 07:15 | |
| *** gouthamr_ has joined #openstack-cinder | 07:22 | |
| *** geguileo has joined #openstack-cinder | 07:31 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Add cinder-manage command to remove file locks https://review.opendev.org/734144 | 07:39 |
| *** akrog has joined #openstack-cinder | 07:42 | |
| *** geguileo is now known as Guest75265 | 07:42 | |
| *** akrog is now known as geguileo | 07:42 | |
| *** markvoelker has joined #openstack-cinder | 07:43 | |
| *** gouthamr_ has quit IRC | 07:46 | |
| *** markvoelker has quit IRC | 07:48 | |
| *** m5z has quit IRC | 07:52 | |
| *** gouthamr_ has joined #openstack-cinder | 07:52 | |
| *** gouthamr_ has quit IRC | 07:57 | |
| *** udesale_ has joined #openstack-cinder | 08:00 | |
| *** Lucas_Gray has joined #openstack-cinder | 08:01 | |
| *** udesale has quit IRC | 08:03 | |
| *** gmann has quit IRC | 08:03 | |
| *** vkmc has quit IRC | 08:04 | |
| *** gmann has joined #openstack-cinder | 08:06 | |
| *** vkmc has joined #openstack-cinder | 08:07 | |
| *** m5z has joined #openstack-cinder | 08:09 | |
| *** gouthamr_ has joined #openstack-cinder | 08:09 | |
| *** udesale_ has quit IRC | 08:10 | |
| openstackgerrit | wanghao proposed openstack/cinder master: Support multiple filters together for volume time comparison filter https://review.opendev.org/740146 | 08:17 |
| walshh_ | is anyone available to look at https://review.opendev.org/#/c/731479/ it has clean CI. Thank you | 08:21 |
| *** benj_ has quit IRC | 08:41 | |
| *** n-saito has quit IRC | 08:47 | |
| *** benj_ has joined #openstack-cinder | 08:58 | |
| *** tosky has joined #openstack-cinder | 09:10 | |
| *** udesale has joined #openstack-cinder | 09:12 | |
| *** whoami-rajat has quit IRC | 09:18 | |
| *** _pewp_ has quit IRC | 09:18 | |
| *** _pewp_ has joined #openstack-cinder | 09:19 | |
| *** rcernin has quit IRC | 09:23 | |
| *** aarora06 has joined #openstack-cinder | 09:35 | |
| aarora06 | rosmaita: Hi .. I had a doubt regarding this code - https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2494 Here this conditions is checked for migrating volume via volume driver - if not force_host_copy and new_type_id is None: But, new_type_id would always be not None in-case a user wants to retype to a new type. I think check for new_type_id is None should be removed. What do you think? | 09:37 |
| openstackgerrit | wanghao proposed openstack/cinder master: Time comparison filter didn't support time zone offset https://review.opendev.org/734415 | 09:40 |
| *** markvoelker has joined #openstack-cinder | 09:44 | |
| *** markvoelker has quit IRC | 09:48 | |
| *** jmlowe has joined #openstack-cinder | 10:04 | |
| *** ociuhandu has joined #openstack-cinder | 10:16 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-cinderclient master: trivial: Drop references to os-testr https://review.opendev.org/740223 | 10:22 |
| *** jmlowe has quit IRC | 10:24 | |
| *** jmlowe has joined #openstack-cinder | 10:25 | |
| *** Liang__ has quit IRC | 10:28 | |
| *** tkajinam has quit IRC | 11:02 | |
| *** markvoelker has joined #openstack-cinder | 11:19 | |
| *** markvoelker has quit IRC | 11:24 | |
| openstackgerrit | Alex Deiter proposed openstack/cinder master: Creating snapshot on NFS backend fails https://review.opendev.org/739277 | 11:27 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: RBD: Fix error on disconnect https://review.opendev.org/738226 | 11:37 |
| *** jungleboyj has quit IRC | 11:46 | |
| *** jungleboyj_ is now known as jungleboyj | 11:46 | |
| *** whoami-rajat has joined #openstack-cinder | 11:46 | |
| *** bhagyashris is now known as bhagyashris|brb | 12:04 | |
| *** raghavendrat has joined #openstack-cinder | 12:10 | |
| rosmaita | aarora06: look at the method signature at line 2473. Also, i believe this code is also used for the os-migrate_volume action, which does not specify a target volume_type, so the new_type_id can be None | 12:24 |
| openstackgerrit | Merged openstack/cinder stable/ussuri: Disable siblings for the cinderlib functional tests https://review.opendev.org/738978 | 12:27 |
| openstackgerrit | Merged openstack/cinderlib master: Stop to use the __future__ module. https://review.opendev.org/732823 | 12:27 |
| aarora06 | rosmaita: yes, it can be None. But, for retype also, migrate_volume is called - which is because some drivers implement only migrate_volume and do not perform normal retype. In case of retype, new_type_id is not None. Also, for retype it will always go into migrate volume generic method. | 12:29 |
| rosmaita | aarora06: not sure i understand your point | 12:34 |
| *** bhagyashris|brb is now known as bhagyashris | 12:37 | |
| aarora06 | This is the migrate_volume call to the driver method: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2497 .. I am saying this should be accessible to drivers during retype. This is the migrate_volume call from retype: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2925 .. | 12:38 |
| openstackgerrit | Luigi Toscano proposed openstack/cinder stable/train: Disable siblings for the cinderlib functional tests https://review.opendev.org/740263 | 12:39 |
| *** andrebeltrami has joined #openstack-cinder | 12:40 | |
| aarora06 | rosmaita: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2872 So, if https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2872 - driver retype call fails, the driver resorts to migrate_volume. But, because new_type_id will not be None during retype, migrate_volume of the driver code will never be called for migration_policy of 'on-demand' during retype call. | 12:40 |
| raghavendrat | hi reviewers, | 12:40 |
| raghavendrat | this is regarding https://review.opendev.org/#/c/739033/ and https://review.opendev.org/#/c/739468/ | 12:40 |
| raghavendrat | for both patches, zuul and CI have passed. Appreciate if someone can have a look. | 12:41 |
| rosmaita | aarora06: since you originally asked me what I thought, i think that i personally do not like changing method signatures that have been around a long time, and as long as new_type_id has a default of None, that check must remain in that function. I don't know what else to tell you | 12:44 |
| openstackgerrit | haixin proposed openstack/cinder master: volume list query optimization https://review.opendev.org/740152 | 12:46 |
| aarora06 | rosmaita: We can probably have that enabled for retype if it is not None. Maybe we can pass a special parameter when migrate_volume is called from retype (something like retype=True) and enable driver migrate_volume call? | 12:47 |
| rosmaita | aarora06: you need to give me some context for this -- has it caused some kind of problem? | 12:49 |
| *** lseki has joined #openstack-cinder | 12:51 | |
| aarora06 | rosmaita: yes .. it did cause an issue specific to a driver. That driver did not implement retype method but had implemented migrate_volume method. So, it kind of relied on migrate_volume method during retype. Not sure if that is correct on the driver part. (I am not sure if I can tell the name of that driver on public forum) | 12:52 |
| rosmaita | if it's a driver in the cinder source code repo, then you can mention it | 12:52 |
| aarora06 | rosmaita: Nope .. it is not there in cinder source code repo. | 12:53 |
| rosmaita | but it seems that if the driver is relying on the generic method to perform retype, then it should be passing the new_type_id in that case. This seems like a driver bug, not a cinder bug | 12:54 |
| aarora06 | rosmaita: okay. sure .. thank you for the reply. | 12:55 |
| rosmaita | aarora06: np | 12:55 |
| openstackgerrit | Elod Illes proposed openstack/cinder stable/stein: Revert "Make greande jobs n-v for EM and oldest stable" https://review.opendev.org/740272 | 13:00 |
| rosmaita | stable cores: please take a look at https://review.opendev.org/#/c/736749/ to finally close out OSSN-0086 | 13:03 |
| rosmaita | e0ne eharney geguileo jungleboyj smcginnis ^^ | 13:03 |
| openstackgerrit | Lucian Petrut proposed openstack/cinder master: smbfs: pick up remotefs method signature change https://review.opendev.org/739954 | 13:05 |
| *** e0ne has joined #openstack-cinder | 13:06 | |
| *** raghavendrat has quit IRC | 13:06 | |
| *** e0ne has quit IRC | 13:07 | |
| * jungleboyj is happy to have IRC Cloud back. | 13:12 | |
| *** e0ne has joined #openstack-cinder | 13:18 | |
| *** mindthecap has joined #openstack-cinder | 13:51 | |
| *** e0ne has quit IRC | 14:03 | |
| *** e0ne has joined #openstack-cinder | 14:03 | |
| *** mindthecap has left #openstack-cinder | 14:10 | |
| *** abdysn has quit IRC | 14:24 | |
| *** aarora06 has quit IRC | 14:28 | |
| openstackgerrit | Merged openstack/os-brick stable/queens: Fix "Remove VxFlex OS credentials" regression https://review.opendev.org/736749 | 14:42 |
| *** e0ne has quit IRC | 14:44 | |
| *** bhagyashris is now known as bhagyashris|dinn | 14:52 | |
| *** vishalmanchanda has quit IRC | 14:54 | |
| openstackgerrit | Keith Berger proposed openstack/os-brick stable/pike: Fix "Remove VxFlex OS credentials" regression https://review.opendev.org/740318 | 14:54 |
| *** Lucas_Gray has quit IRC | 14:55 | |
| *** Luzi has quit IRC | 14:56 | |
| rosmaita | KeithMnemonic: have you seen http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015838.html ? | 15:00 |
| KeithMnemonic | yes but i have 13 days ? | 15:02 |
| KeithMnemonic | or am i too late | 15:02 |
| *** sfernand has joined #openstack-cinder | 15:03 | |
| rosmaita | not sure ... depends on the gate situation | 15:06 |
| KeithMnemonic | well there is this https://review.opendev.org/#/c/737094/ if someone wants to push it through | 15:08 |
| *** abhishekk is now known as abhishekk-afk | 15:09 | |
| *** Lucas_Gray has joined #openstack-cinder | 15:11 | |
| rosmaita | KeithMnemonic: i don't know how i feel about that, i'd really prefer pike and ocata to go EOL so we're not spending a lot of time fixing stuff for little gain | 15:11 |
| *** ganso has quit IRC | 15:13 | |
| *** dviroel_ is now known as dviroel | 15:15 | |
| KeithMnemonic | fair enough, never hurts to ask though ;-) | 15:15 |
| rosmaita | yeah, and we can see if there's any response to the EOL proposal on the ML | 15:16 |
| *** ganso has joined #openstack-cinder | 15:17 | |
| lseki | Hi folks, can I have another look at this backport, please? | 15:19 |
| lseki | https://review.opendev.org/#/c/738124/ | 15:19 |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax Driver - Failover abilities legacy improvements https://review.opendev.org/740321 | 15:25 |
| *** m75abrams has quit IRC | 15:36 | |
| *** bhagyashris|dinn is now known as bhagyashris | 15:49 | |
| *** geguileo has quit IRC | 16:02 | |
| *** geguileo has joined #openstack-cinder | 16:03 | |
| *** udesale_ has joined #openstack-cinder | 16:08 | |
| *** whoami-rajat has quit IRC | 16:08 | |
| *** udesale has quit IRC | 16:10 | |
| *** hamalq has joined #openstack-cinder | 16:18 | |
| *** hamalq_ has joined #openstack-cinder | 16:19 | |
| *** hamalq has quit IRC | 16:22 | |
| *** ociuhandu_ has joined #openstack-cinder | 16:23 | |
| *** abhishekk-afk is now known as abhishekk | 16:26 | |
| *** ociuhandu has quit IRC | 16:27 | |
| *** udesale_ has quit IRC | 16:27 | |
| *** ociuhandu_ has quit IRC | 16:28 | |
| *** patrickeast_ has joined #openstack-cinder | 16:47 | |
| *** andreaf has quit IRC | 16:48 | |
| *** mnasiadka_ has joined #openstack-cinder | 16:48 | |
| *** simondodsley_ has joined #openstack-cinder | 16:48 | |
| openstackgerrit | Lucian Petrut proposed openstack/cinder master: smbfs: pick up remotefs method signature change https://review.opendev.org/739954 | 16:48 |
| *** whoami-rajat has joined #openstack-cinder | 16:49 | |
| *** dasp_ has joined #openstack-cinder | 16:49 | |
| *** patrickeast has quit IRC | 16:55 | |
| *** simondodsley has quit IRC | 16:55 | |
| *** coreycb has quit IRC | 16:55 | |
| *** carloss has quit IRC | 16:55 | |
| *** mnasiadka has quit IRC | 16:55 | |
| *** dasp has quit IRC | 16:55 | |
| *** mnasiadka_ is now known as mnasiadka | 16:55 | |
| *** patrickeast_ is now known as patrickeast | 16:55 | |
| *** simondodsley_ is now known as simondodsley | 16:55 | |
| *** coreycb has joined #openstack-cinder | 16:58 | |
| *** carloss has joined #openstack-cinder | 16:58 | |
| *** whoami-rajat has quit IRC | 17:17 | |
| *** whoami-rajat has joined #openstack-cinder | 17:18 | |
| *** Lucas_Gray has quit IRC | 17:19 | |
| *** ajitha has joined #openstack-cinder | 17:44 | |
| hemna | ok so latest ceph-iscsi is that it passes all the same tempest tests as rbd driver does | 17:49 |
| hemna | going to put up some updates to my ceph-iscsi chain of reviews | 17:49 |
| *** andrebeltrami has quit IRC | 18:00 | |
| *** vishakha has quit IRC | 18:50 | |
| *** ajitha has quit IRC | 19:08 | |
| *** tosky has quit IRC | 19:26 | |
| *** whoami-rajat has quit IRC | 19:40 | |
| *** ociuhandu has joined #openstack-cinder | 20:12 | |
| *** geguileo has quit IRC | 20:12 | |
| *** geguileo has joined #openstack-cinder | 20:13 | |
| *** _pewp_ has quit IRC | 20:19 | |
| *** _pewp_ has joined #openstack-cinder | 20:20 | |
| *** ociuhandu has quit IRC | 20:31 | |
| *** ociuhandu has joined #openstack-cinder | 20:47 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/devstack-plugin-open-cas master: DNM: testing focal https://review.opendev.org/740374 | 20:49 |
| *** ociuhandu has quit IRC | 20:59 | |
| *** eharney has quit IRC | 21:42 | |
| *** tkajinam has joined #openstack-cinder | 23:00 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!