*** lbragstad has quit IRC | 00:23 | |
*** tosky has quit IRC | 00:28 | |
*** martinkennelly has quit IRC | 00:50 | |
*** lbragstad has joined #openstack-cinder | 00:52 | |
*** hamalq has quit IRC | 01:24 | |
*** rratnaka has joined #openstack-cinder | 01:27 | |
*** ociuhandu has joined #openstack-cinder | 01:42 | |
*** zenkuro has quit IRC | 01:46 | |
*** ociuhandu has quit IRC | 01:46 | |
*** zenkuro has joined #openstack-cinder | 01:47 | |
*** venkatakrishnath has joined #openstack-cinder | 02:03 | |
venkatakrishnath | Hi, I have been asking for review for these patches since last one month and posted in IRC many times. Can someone please review these https://review.opendev.org/c/openstack/cinder/+/750199 | 02:09 |
---|---|---|
venkatakrishnath | https://review.opendev.org/c/openstack/cinder/+/765154 | 02:09 |
*** rcernin has quit IRC | 02:25 | |
*** rcernin has joined #openstack-cinder | 02:42 | |
openstackgerrit | Ajitha Robert proposed openstack/cinder master: Bug fix for revert to snapshot feature https://review.opendev.org/c/openstack/cinder/+/779417 | 02:47 |
*** rcernin has quit IRC | 02:48 | |
*** rcernin has joined #openstack-cinder | 02:51 | |
*** carloss has quit IRC | 03:00 | |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357 | 03:07 |
*** ajitha has joined #openstack-cinder | 03:14 | |
*** rcernin has quit IRC | 03:20 | |
*** psachin has joined #openstack-cinder | 03:29 | |
*** ociuhandu has joined #openstack-cinder | 03:30 | |
*** ociuhandu has quit IRC | 03:34 | |
*** rcernin has joined #openstack-cinder | 03:40 | |
*** lbragstad has quit IRC | 03:43 | |
*** zzzeek has quit IRC | 03:46 | |
*** zzzeek has joined #openstack-cinder | 03:47 | |
*** rcernin_ has joined #openstack-cinder | 03:51 | |
*** kmarc_ has joined #openstack-cinder | 03:52 | |
*** gary_perkins_ has joined #openstack-cinder | 03:56 | |
*** icey_ has joined #openstack-cinder | 03:56 | |
*** rcernin has quit IRC | 03:59 | |
*** dsariel has quit IRC | 03:59 | |
*** hoonetorg has quit IRC | 03:59 | |
*** openstackgerrit has quit IRC | 03:59 | |
*** icey has quit IRC | 03:59 | |
*** jv_ has quit IRC | 03:59 | |
*** gary_perkins has quit IRC | 03:59 | |
*** LarsErikP has quit IRC | 03:59 | |
*** tbarron has quit IRC | 03:59 | |
*** kmarc has quit IRC | 03:59 | |
*** jv_ has joined #openstack-cinder | 04:02 | |
*** vishalmanchanda has joined #openstack-cinder | 04:16 | |
*** vishalmanchanda has quit IRC | 04:21 | |
*** vishalmanchanda has joined #openstack-cinder | 04:21 | |
*** GirishChilukuri has joined #openstack-cinder | 04:29 | |
*** udesale has joined #openstack-cinder | 04:31 | |
*** venkatakrishnath has quit IRC | 04:34 | |
*** whoami-rajat_ has joined #openstack-cinder | 04:41 | |
*** whoami-rajat_ is now known as whoami-rajat | 04:46 | |
*** ociuhandu has joined #openstack-cinder | 05:18 | |
*** ociuhandu has quit IRC | 05:22 | |
*** rcernin_ has quit IRC | 05:48 | |
*** rcernin_ has joined #openstack-cinder | 05:49 | |
*** m75abrams has joined #openstack-cinder | 06:46 | |
*** ociuhandu has joined #openstack-cinder | 07:00 | |
*** rratnaka has quit IRC | 07:02 | |
*** rratnaka has joined #openstack-cinder | 07:05 | |
*** ociuhandu has quit IRC | 07:06 | |
*** m75abrams has quit IRC | 07:17 | |
*** m75abrams has joined #openstack-cinder | 07:17 | |
*** rratnaka has quit IRC | 07:20 | |
*** swegener has joined #openstack-cinder | 07:22 | |
*** rratnaka has joined #openstack-cinder | 07:23 | |
*** vishalmanchanda has quit IRC | 07:36 | |
*** zenkuro has quit IRC | 07:39 | |
*** zenkuro has joined #openstack-cinder | 07:40 | |
*** ociuhandu has joined #openstack-cinder | 07:43 | |
*** e0ne has joined #openstack-cinder | 07:56 | |
*** GirishChilukuri_ has joined #openstack-cinder | 08:02 | |
*** lpetrut has joined #openstack-cinder | 08:04 | |
*** GirishChilukuri has quit IRC | 08:06 | |
*** GirishChilukuri has joined #openstack-cinder | 08:09 | |
*** GirishChilukuri_ has quit IRC | 08:11 | |
*** rpittau|afk is now known as rpittau | 08:24 | |
*** rcernin_ has quit IRC | 08:24 | |
*** martinkennelly has joined #openstack-cinder | 08:41 | |
*** ociuhandu has quit IRC | 08:48 | |
*** ociuhandu has joined #openstack-cinder | 08:49 | |
*** ociuhandu has quit IRC | 08:49 | |
*** e0ne has quit IRC | 08:51 | |
*** GirishChilukuri has quit IRC | 08:52 | |
*** _pewp_ has quit IRC | 08:53 | |
*** _pewp_ has joined #openstack-cinder | 08:54 | |
*** GirishChilukuri has joined #openstack-cinder | 08:55 | |
*** sapd1 has joined #openstack-cinder | 08:57 | |
*** tosky has joined #openstack-cinder | 09:02 | |
*** ociuhandu has joined #openstack-cinder | 09:04 | |
*** ociuhandu has quit IRC | 09:14 | |
*** ociuhandu has joined #openstack-cinder | 09:15 | |
*** ociuhandu has quit IRC | 09:20 | |
*** m75abrams has quit IRC | 09:24 | |
*** GirishChilukuri has quit IRC | 09:28 | |
*** ociuhandu has joined #openstack-cinder | 09:28 | |
*** m75abrams has joined #openstack-cinder | 09:32 | |
*** udesale_ has joined #openstack-cinder | 09:55 | |
*** jawad_axd has joined #openstack-cinder | 09:58 | |
*** udesale has quit IRC | 09:59 | |
*** manoj_katari has joined #openstack-cinder | 10:02 | |
manoj_katari | @core reviewers: please review these changes made for IBM SVF driver. Comments are addressed and CI is green. | 10:05 |
manoj_katari | https://review.opendev.org/c/openstack/cinder/+/765154 | 10:05 |
manoj_katari | https://review.opendev.org/c/openstack/cinder/+/750199 | 10:05 |
*** ajitha has quit IRC | 10:08 | |
*** GirishChilukuri has joined #openstack-cinder | 10:23 | |
*** rcernin_ has joined #openstack-cinder | 10:27 | |
*** carloss has joined #openstack-cinder | 10:59 | |
*** icey_ is now known as icey | 11:02 | |
*** sapd1 has quit IRC | 11:16 | |
*** rcernin_ has quit IRC | 11:26 | |
*** Luzi has joined #openstack-cinder | 11:27 | |
*** ociuhandu_ has joined #openstack-cinder | 11:49 | |
*** GirishChilukuri_ has joined #openstack-cinder | 11:51 | |
*** ociuhandu has quit IRC | 11:53 | |
*** ociuhandu_ has quit IRC | 11:53 | |
*** GirishChilukuri has quit IRC | 11:55 | |
*** GirishChilukuri_ has quit IRC | 11:55 | |
*** GirishChilukuri has joined #openstack-cinder | 11:56 | |
*** brinzhang has quit IRC | 11:56 | |
*** lpetrut has quit IRC | 11:56 | |
*** ociuhandu has joined #openstack-cinder | 11:57 | |
*** lpetrut has joined #openstack-cinder | 11:58 | |
*** e0ne has joined #openstack-cinder | 12:00 | |
*** GirishChilukuri_ has joined #openstack-cinder | 12:02 | |
*** ociuhandu has quit IRC | 12:03 | |
*** GirishChilukuri has quit IRC | 12:06 | |
*** GirishChilukuri has joined #openstack-cinder | 12:06 | |
*** GirishChilukuri_ has quit IRC | 12:07 | |
*** e0ne has quit IRC | 12:07 | |
*** ociuhandu has joined #openstack-cinder | 12:13 | |
*** ociuhandu has quit IRC | 12:18 | |
*** psachin has quit IRC | 12:47 | |
*** __ministry1 has joined #openstack-cinder | 12:52 | |
*** GirishChilukuri has quit IRC | 12:58 | |
*** zzzeek has quit IRC | 13:00 | |
*** zzzeek has joined #openstack-cinder | 13:02 | |
*** knomura has joined #openstack-cinder | 13:03 | |
*** enriquetaso has joined #openstack-cinder | 13:13 | |
*** m75abrams has quit IRC | 13:15 | |
*** vishalmanchanda has joined #openstack-cinder | 13:16 | |
*** m75abrams has joined #openstack-cinder | 13:16 | |
*** lbragstad has joined #openstack-cinder | 13:24 | |
*** sapd1 has joined #openstack-cinder | 13:48 | |
*** venkatakrishnath has joined #openstack-cinder | 13:52 | |
*** tkajinam has quit IRC | 13:53 | |
*** knomura has quit IRC | 14:02 | |
*** manoj_katari has quit IRC | 14:06 | |
*** knomura has joined #openstack-cinder | 14:08 | |
*** legochen has joined #openstack-cinder | 14:09 | |
*** GirishChilukuri has joined #openstack-cinder | 14:10 | |
*** caiqilong has quit IRC | 14:13 | |
venkatakrishnath | Can someone please review https://review.opendev.org/c/openstack/cinder/+/764804 | 14:15 |
jungleboyj | venkatakrishnath: Let me do my follow up review. | 14:18 |
*** pcaruana has quit IRC | 14:19 | |
venkatakrishnath | jungleboyj Thanks. Update you once that patch gets Zuul +1 and CI passed | 14:22 |
knomura | Could someone please review https://review.opendev.org/c/openstack/cinder/+/777578 | 14:22 |
*** rratnaka has quit IRC | 14:23 | |
*** abhishekk is now known as konan | 14:26 | |
*** konan is now known as abhishekk | 14:28 | |
*** Luzi has quit IRC | 14:34 | |
jungleboyj | whoami-rajat: Can you make sure your comments were addressed here? https://review.opendev.org/c/openstack/cinder/+/750199 | 14:34 |
jungleboyj | knomura: Done. | 14:36 |
GirishChilukuri | jungleboyj Addressed review comments for this patch https://review.opendev.org/c/openstack/cinder/+/753134 | 14:37 |
knomura | jungleboyj: thanks for your review. | 14:39 |
*** __ministry1 has quit IRC | 14:41 | |
knomura | junbleboyj: And I'd like you to review it https://review.opendev.org/c/openstack/cinder/+/770541 | 14:44 |
whoami-rajat | jungleboyj: will take a look | 14:45 |
*** ociuhandu has joined #openstack-cinder | 14:51 | |
lbragstad | o/ i must specify an image_id in the volume reference when i create a volume to create a bootable volume from an image, right? | 14:54 |
lbragstad | looking at https://docs.openstack.org/api-ref/block-storage/v3/?expanded=create-a-volume-detail | 14:54 |
lbragstad | i see the description eludes to that, but i don't see image_id as a request parameter | 14:54 |
eharney | lbragstad: yes, i guess it's the imageRef parameter? | 14:55 |
lbragstad | ok | 14:57 |
lbragstad | that's what it looks like | 14:57 |
lbragstad | i imagine that's a string | 14:57 |
*** ociuhandu has quit IRC | 14:57 | |
eharney | yes | 14:58 |
lbragstad | ok - cool, trying that out quick | 14:59 |
*** rosmaita has left #openstack-cinder | 15:03 | |
*** rratnaka has joined #openstack-cinder | 15:04 | |
*** pcaruana has joined #openstack-cinder | 15:04 | |
*** rosmaita has joined #openstack-cinder | 15:08 | |
*** ociuhandu has joined #openstack-cinder | 15:08 | |
*** sfernand has joined #openstack-cinder | 15:22 | |
sfernand | Hi folks, we have 3 patches that require reviews before the feature freeze: | 15:28 |
sfernand | https://review.opendev.org/c/openstack/cinder/+/770649 | 15:28 |
sfernand | https://review.opendev.org/c/openstack/cinder/+/775455 | 15:28 |
sfernand | https://review.opendev.org/c/openstack/cinder/+/776713 | 15:28 |
sfernand | rosmaita: I guess we will need a exception in order to get them merged :( | 15:29 |
rosmaita | sfernand: don 't be so pessimistic | 15:29 |
*** e0ne has joined #openstack-cinder | 15:29 | |
*** lpetrut has quit IRC | 15:29 | |
sfernand | :P | 15:31 |
*** e0ne has quit IRC | 15:31 | |
*** manoj_katari has joined #openstack-cinder | 15:31 | |
tosky | bonus point if you the features are covered by automated tests :) | 15:32 |
sfernand | they are all vendor specific, but we are already working on internal tempests for them | 15:35 |
GirishChilukuri | Hi Team, I am getting this error while running revert to snapshot test from cinder-tempest-plugin oslo_config.cfg.NoSuchOptError: no such option volume_revert in group [volume-feature-enabled] | 15:35 |
GirishChilukuri | any suggestions on this | 15:35 |
rosmaita | tosky has a good point ... it will speed up reviewing if you (meaning anyone, not just sfernand) can put a comment on your patch pointing to the log that shows your feature passing your CI | 15:35 |
GirishChilukuri | [volume-feature-enabled] | 15:37 |
GirishChilukuri | volume_revert = True | 15:37 |
GirishChilukuri | api_extensions = all | 15:37 |
GirishChilukuri | backup = False | 15:37 |
GirishChilukuri | volume-revert = True | 15:37 |
GirishChilukuri | extend_attached_volume = True | 15:37 |
GirishChilukuri | manage_volume = True | 15:37 |
GirishChilukuri | manage_snapshot = True | 15:37 |
rosmaita | GirishChilukuri: if that is a paste, you have a hypen instead of underscore in volume_revert | 15:38 |
rosmaita | nm, just saw that you have it twice | 15:38 |
GirishChilukuri | I have added above entire in /etc/tempest/tempest.conf | 15:39 |
*** m75abrams has quit IRC | 15:39 | |
*** e0ne has joined #openstack-cinder | 15:40 | |
GirishChilukuri | rosmaita Initially I used volume_revert, It was failed. So itried with different combinations. | 15:40 |
tosky | GirishChilukuri: do you have a link to the full log? It's almost impossible to understand what's going on with just the final error without context | 15:41 |
GirishChilukuri | tosky I tried it in my local vm devstack. | 15:42 |
*** rratnaka has quit IRC | 15:43 | |
tosky | GirishChilukuri: sure, but I guess the logs can be extracted | 15:45 |
*** ociuhandu has quit IRC | 15:45 | |
*** ociuhandu has joined #openstack-cinder | 15:45 | |
*** knomura has quit IRC | 15:45 | |
*** e0ne has quit IRC | 15:47 | |
*** ociuhandu has quit IRC | 15:47 | |
*** ociuhandu has joined #openstack-cinder | 15:47 | |
*** e0ne has joined #openstack-cinder | 15:48 | |
*** udesale_ has quit IRC | 15:48 | |
*** stephenfin has quit IRC | 15:53 | |
*** stephenfin has joined #openstack-cinder | 15:54 | |
lyarwood | geguileo / tosky ; https://bugs.launchpad.net/cinder/+bug/1917750 - I think I've hit this again, just building a multinode env to confirm now. Would you mind taking a look and letting me know if I'm getting something obviously wrong here? | 15:55 |
openstack | Launchpad bug 1917750 in Cinder "Running parallel iSCSI/LVM c-vol backends is causing random failures in CI" [Undecided,New] | 15:55 |
lbragstad | rosmaita ok - i have everything filled out for the first round of cinder protection tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357 | 15:58 |
tosky | also eharney and enriquetaso: please see lyarwood's comment above: ^ | 15:59 |
rosmaita | lbragstad: thanks, will look | 15:59 |
lbragstad | to my knowledge - all the tests in there test the policies in https://opendev.org/openstack/cinder/src/branch/master/cinder/policies/volumes.py | 15:59 |
lbragstad | and the project-reader tests are skipped | 16:00 |
*** e0ne has quit IRC | 16:01 | |
*** jv_ has quit IRC | 16:02 | |
*** jv_ has joined #openstack-cinder | 16:02 | |
tosky | lbragstad: oh, so he skip condition is in https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357, not in https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915/10 | 16:07 |
tosky | but on the other hand the tests in 772915 are noop | 16:07 |
tosky | well, not exactly, there is one, but it is passing | 16:07 |
*** GirishChilukuri_ has joined #openstack-cinder | 16:14 | |
*** GirishChilukuri has quit IRC | 16:17 | |
*** GirishChilukuri has joined #openstack-cinder | 16:24 | |
*** rratnaka has joined #openstack-cinder | 16:26 | |
*** GirishChilukuri_ has quit IRC | 16:28 | |
*** rratnaka14 has joined #openstack-cinder | 16:31 | |
lbragstad | tosky yep -sure | 16:32 |
lbragstad | that can be moved | 16:32 |
lbragstad | rosmaita tosky do you know what there are two different policies for controlling force delete? | 16:32 |
lbragstad | https://opendev.org/openstack/cinder/src/branch/master/cinder/policies/volumes.py#L27 | 16:32 |
lbragstad | https://opendev.org/openstack/cinder/src/branch/master/cinder/policies/volume_actions.py#L27 | 16:33 |
lbragstad | s/what/why/ | 16:34 |
rosmaita | lbragstad: looking | 16:35 |
lbragstad | from what i can tell, the policy in volumes.py is the only one that is enforced https://opendev.org/openstack/cinder/src/branch/master/cinder/api/v3/volumes.py#L75 | 16:35 |
lbragstad | but if i set this in my policy file http://paste.openstack.org/raw/803395/ it fails - but i'm not sure where that's getting picked up? | 16:37 |
*** venkatakrishnath has quit IRC | 16:37 | |
*** jawad_axd has quit IRC | 16:42 | |
*** jawad_axd has joined #openstack-cinder | 16:42 | |
*** venkatakrishnath has joined #openstack-cinder | 16:42 | |
*** jawad_axd has quit IRC | 16:44 | |
rosmaita | volume:force_delete came in with microversion 3.23, not sure why it has a different policy, though | 16:44 |
rosmaita | will have to look at the spec | 16:44 |
eharney | presumably because the newer support for force delete isn't an "extension" | 16:49 |
*** jv__ has joined #openstack-cinder | 16:52 | |
rosmaita | lbragstad: somebody being very clever: http://paste.openstack.org/raw/803395/ | 16:53 |
rosmaita | that wasn't clever | 16:53 |
rosmaita | https://opendev.org/openstack/cinder/src/branch/master/cinder/api/contrib/admin_actions.py#L71 | 16:53 |
rosmaita | that's clever | 16:53 |
lbragstad | yeah.. i just stumbled across that | 16:54 |
enriquetaso | tosky, eharney and lyarwood: I'm looking into https://bugs.launchpad.net/cinder/+bug/1917750 but I'll bring it on tomorrow's bug report week | 16:54 |
openstack | Launchpad bug 1917750 in Cinder "Running parallel iSCSI/LVM c-vol backends is causing random failures in CI" [Undecided,New] | 16:54 |
lbragstad | so - things in contrib actually use a subclassed authorize implementation that modifies the policy target | 16:55 |
lbragstad | and, depending on the mv, one policy gets used over the other | 16:55 |
lbragstad | iiuc | 16:56 |
eharney | i think which policy is used depends on which API you call, since they're different APIs | 16:56 |
lbragstad | so - theoretically (i haven't tested this yet) but if i override "volume_extension:volume_admin_actions:force_delete" in my deployment but i don't override "volume:force_delete" - could i get different authorization behavior depending on the mv i specify in the client? | 16:58 |
lbragstad | ah - https://opendev.org/openstack/tempest/src/branch/master/tempest/lib/services/volume/v3/volumes_client.py#L276-L281 | 17:00 |
eharney | i'm not sure i understand what you want to know | 17:00 |
lbragstad | yeah - that is using the actions API | 17:00 |
eharney | calling the admin action os-force_delete uses the "extension" policy | 17:00 |
*** takamatsu has quit IRC | 17:00 | |
*** openstackgerrit has joined #openstack-cinder | 17:00 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Allowing for all types of boolean in extra specs https://review.opendev.org/c/openstack/cinder/+/752423 | 17:00 |
*** jv__ has quit IRC | 17:00 | |
eharney | the volume:force_delete policy applies to an action taken on the volume itself, which only exists after microversion 3.23 | 17:00 |
lbragstad | yep - that makes sense | 17:01 |
lbragstad | so - the thing i'm trying to figure out is if there is a potential for drift if one policy is overridden and the other isn't | 17:02 |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Check for moving to same target https://review.opendev.org/c/openstack/cinder/+/779540 | 17:03 |
eharney | drift in what sense? | 17:04 |
lbragstad | if an operator overrides the "extension" policy to be tighter for some reason, but doesn't override the non-extension policy | 17:05 |
*** rpittau is now known as rpittau|afk | 17:05 | |
lbragstad | both policies ultimately protect the same behavior, don't they? | 17:05 |
openstackgerrit | Walt proposed openstack/cinder master: Added admins view all volume_admin_metadata https://review.opendev.org/c/openstack/cinder/+/779541 | 17:06 |
eharney | from the user point of view, yes | 17:08 |
openstackgerrit | Sri Harsha mekala proposed openstack/python-cinderclient master: Support passing client certificates for server version requests https://review.opendev.org/c/openstack/python-cinderclient/+/776311 | 17:16 |
*** lpetrut has joined #openstack-cinder | 17:18 | |
lbragstad | is there a reason to use one over the other, excluding mv availability? | 17:19 |
eharney | if you want to combine force and cascade delete you have to use the newer one | 17:19 |
* lbragstad nods | 17:20 | |
*** GirishChilukuri_ has joined #openstack-cinder | 17:22 | |
*** GirishChilukuri has quit IRC | 17:25 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Initiator group contents check https://review.opendev.org/c/openstack/cinder/+/764162 | 17:31 |
*** venkatakrishnath has quit IRC | 17:37 | |
*** ociuhandu has quit IRC | 17:41 | |
*** ociuhandu has joined #openstack-cinder | 17:54 | |
*** ociuhandu has quit IRC | 17:54 | |
*** ociuhandu has joined #openstack-cinder | 17:55 | |
openstackgerrit | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add support for QoS minimums specs https://review.opendev.org/c/openstack/cinder/+/770649 | 17:55 |
*** rratnaka14 has quit IRC | 17:57 | |
*** rratnaka has quit IRC | 17:57 | |
*** lpetrut has quit IRC | 18:00 | |
*** knomura has joined #openstack-cinder | 18:00 | |
*** ociuhandu has quit IRC | 18:02 | |
*** ociuhandu has joined #openstack-cinder | 18:02 | |
*** ociuhandu has quit IRC | 18:02 | |
*** ociuhandu has joined #openstack-cinder | 18:03 | |
*** knomura has quit IRC | 18:05 | |
*** ociuhandu has quit IRC | 18:12 | |
*** ociuhandu has joined #openstack-cinder | 18:16 | |
*** GirishChilukuri_ has quit IRC | 18:17 | |
*** hamalq has joined #openstack-cinder | 18:30 | |
*** ociuhandu has quit IRC | 18:53 | |
*** ociuhandu has joined #openstack-cinder | 18:54 | |
*** takamatsu has joined #openstack-cinder | 18:55 | |
*** ociuhandu has quit IRC | 19:01 | |
*** manoj_katari has quit IRC | 19:03 | |
*** hamalq has quit IRC | 19:09 | |
*** hamalq has joined #openstack-cinder | 19:09 | |
openstackgerrit | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add support for QoS minimums specs https://review.opendev.org/c/openstack/cinder/+/770649 | 19:18 |
*** ociuhandu has joined #openstack-cinder | 19:27 | |
openstackgerrit | Merged openstack/cinder master: Pure Storage: check volumename length does not exceed maximum https://review.opendev.org/c/openstack/cinder/+/769405 | 19:34 |
*** ociuhandu has quit IRC | 19:37 | |
*** e0ne has joined #openstack-cinder | 19:37 | |
openstackgerrit | Lance Bragstad proposed openstack/cinder master: WIP: Contemplate deprecating one of the force delete volume policies https://review.opendev.org/c/openstack/cinder/+/779570 | 19:40 |
*** ociuhandu has joined #openstack-cinder | 19:49 | |
*** ociuhandu has quit IRC | 19:52 | |
*** ociuhandu has joined #openstack-cinder | 19:52 | |
*** e0ne has quit IRC | 19:56 | |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Implement basic protection testing jobs https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915 | 19:57 |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357 | 19:57 |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Remove skip tests for project-reader tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/779573 | 19:57 |
*** e0ne has joined #openstack-cinder | 19:58 | |
*** e0ne has quit IRC | 19:58 | |
openstackgerrit | Lance Bragstad proposed openstack/cinder master: Implement project personas for volume API https://review.opendev.org/c/openstack/cinder/+/760199 | 19:58 |
*** lbragstad has quit IRC | 20:01 | |
*** e0ne has joined #openstack-cinder | 20:11 | |
*** lbragstad has joined #openstack-cinder | 20:15 | |
*** e0ne has quit IRC | 20:16 | |
openstackgerrit | Merged openstack/cinder master: [Pure] Fix failing consistency group tempest tests https://review.opendev.org/c/openstack/cinder/+/775944 | 20:24 |
openstackgerrit | Merged openstack/cinder master: Hitachi: Use get_volume_stats in the base driver https://review.opendev.org/c/openstack/cinder/+/770541 | 20:24 |
*** irclogbot_3 has quit IRC | 20:31 | |
*** irclogbot_1 has joined #openstack-cinder | 20:32 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Fix old attach method https://review.opendev.org/c/openstack/cinder/+/778047 | 20:32 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Remove unnecessary save call https://review.opendev.org/c/openstack/cinder/+/778048 | 20:32 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Fix volume OVO create method https://review.opendev.org/c/openstack/cinder/+/778049 | 20:32 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Remove unused code path in attachment_delete https://review.opendev.org/c/openstack/cinder/+/778532 | 20:33 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Remove unnecessary DB read https://review.opendev.org/c/openstack/cinder/+/778533 | 20:33 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Fix notification information https://review.opendev.org/c/openstack/cinder/+/778534 | 20:33 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Remove unnecesary db call in volume_detached https://review.opendev.org/c/openstack/cinder/+/778535 | 20:33 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Expose volume_attachments in Volume OVO https://review.opendev.org/c/openstack/cinder/+/779576 | 20:33 |
*** ociuhandu has quit IRC | 20:33 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Use `volume_attachment` OVO field https://review.opendev.org/c/openstack/cinder/+/779577 | 20:33 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Expose group in Volume OVO https://review.opendev.org/c/openstack/cinder/+/779578 | 20:33 |
*** legochen has quit IRC | 20:37 | |
*** whoami-rajat has quit IRC | 20:42 | |
openstackgerrit | Simon Dodsley proposed openstack/cinder stable/victoria: Pure Storage: check volumename length does not exceed maximum https://review.opendev.org/c/openstack/cinder/+/779596 | 20:45 |
openstackgerrit | Simon Dodsley proposed openstack/cinder stable/ussuri: Pure Storage: check volumename length does not exceed maximum https://review.opendev.org/c/openstack/cinder/+/779597 | 20:47 |
openstackgerrit | Simon Dodsley proposed openstack/cinder stable/train: Pure Storage: check volumename length does not exceed maximum https://review.opendev.org/c/openstack/cinder/+/779598 | 20:48 |
hemna | anyone know the policy code well? | 20:52 |
hemna | trying to figure out how to make a policy disabled by default | 20:52 |
hemna | re: https://review.opendev.org/c/openstack/cinder/+/779541 | 20:53 |
hemna | also, why doesn't the volume manager allow for a model update during init_host time after a call to ensure_export? | 20:57 |
hemna | create_export() can return a model update | 20:58 |
hemna | looking at the lvm driver's ensure_export() implementation, it actually returns a model_update | 21:02 |
hemna | but the volume manager ignores it | 21:02 |
hemna | oopsie | 21:02 |
openstackgerrit | Merged openstack/cinder master: [Storwize] Provide IOPS based storage offering https://review.opendev.org/c/openstack/cinder/+/750199 | 21:02 |
lbragstad | rosmaita ok - so here is what i have so far https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915/11 | 21:16 |
lbragstad | the series starting there adds some protection tests | 21:16 |
lbragstad | and https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/779573/1 removes skips for ProjectReader, which should fail the protection job | 21:17 |
rosmaita | lbragstad: ack | 21:17 |
lbragstad | https://review.opendev.org/c/openstack/cinder/+/760199 depends on the latest patch in the ctp series | 21:17 |
lbragstad | so - the protection tests should pass with that cinder patch | 21:18 |
*** e0ne has joined #openstack-cinder | 21:19 | |
lbragstad | because of https://review.opendev.org/c/openstack/cinder/+/760199/5/.zuul.yaml | 21:19 |
*** e0ne has quit IRC | 21:19 | |
tosky | lbragstad: sorry, one comment (with -1) on 772915 | 21:22 |
hemna | looks like several drivers return a potential model_update from ensure_export() | 21:25 |
hemna | which makes sense as the information coming back from a re-export could change in the backend | 21:25 |
hemna | but the volume manager ignores it entirely | 21:26 |
hemna | lvm even returns a model_update | 21:26 |
openstackgerrit | Simon Dodsley proposed openstack/cinder stable/victoria: [Pure] Fix failing consistency group tempest tests https://review.opendev.org/c/openstack/cinder/+/779602 | 21:28 |
openstackgerrit | Simon Dodsley proposed openstack/cinder stable/ussuri: [Pure] Fix failing consistency group tempest tests https://review.opendev.org/c/openstack/cinder/+/779603 | 21:28 |
openstackgerrit | Simon Dodsley proposed openstack/cinder stable/train: [Pure] Fix failing consistency group tempest tests https://review.opendev.org/c/openstack/cinder/+/779604 | 21:29 |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Implement basic protection testing jobs https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915 | 21:37 |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357 | 21:37 |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Remove skip tests for project-reader tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/779573 | 21:37 |
lbragstad | tosky ^ done | 21:37 |
lbragstad | all the tests continue to pass for me locally with the cinder change | 21:37 |
tosky | lbragstad: sorry for that final comment, I've missed it earlier | 21:39 |
tosky | for what I can see, at least the base change could go in | 21:39 |
tosky | let's see if the gates agree | 21:39 |
lbragstad | the protection behavior needs some attention, it's my best guess at how to map some of the policies into the new model | 21:40 |
*** zenkuro has quit IRC | 22:04 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: mypy: policy.py https://review.opendev.org/c/openstack/cinder/+/775008 | 22:14 |
openstackgerrit | Eric Harney proposed openstack/cinder master: mypy: annotate image/glance.py https://review.opendev.org/c/openstack/cinder/+/766064 | 22:15 |
*** ociuhandu has joined #openstack-cinder | 22:21 | |
*** lxkong has joined #openstack-cinder | 22:22 | |
*** rcernin has joined #openstack-cinder | 22:24 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: api-ref: Fix "name" parameter https://review.opendev.org/c/openstack/cinder/+/779622 | 22:28 |
*** rcernin has quit IRC | 22:30 | |
*** rcernin has joined #openstack-cinder | 22:30 | |
openstackgerrit | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add support for dynamic Adaptive QoS policy group creation https://review.opendev.org/c/openstack/cinder/+/775455 | 22:30 |
*** ociuhandu has quit IRC | 22:38 | |
*** tkajinam has joined #openstack-cinder | 23:00 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!