| *** vishalmanchanda has quit IRC | 00:05 | |
| *** brinzhang has joined #openstack-cinder | 00:22 | |
| openstackgerrit | Merged openstack/python-cinderclient master: Add MV 3.63 to the max supported version https://review.opendev.org/c/openstack/python-cinderclient/+/772758 | 00:22 |
|---|---|---|
| *** tosky has quit IRC | 00:36 | |
| openstackgerrit | Alan Bishop proposed openstack/python-cinderclient master: Bump API max version to 3.64 https://review.opendev.org/c/openstack/python-cinderclient/+/771236 | 00:37 |
| *** martinkennelly has quit IRC | 00:41 | |
| rm_work | Thanks for the review on https://review.opendev.org/c/openstack/python-cinderclient/+/776311 ! The release note has been added as requested. | 00:55 |
| rm_work | Client releases are going out this week -- do folks think it might be feasible to get that merged in time, or would we need to wait for another release to roll around? | 00:56 |
| *** sapd1 has quit IRC | 01:05 | |
| *** caiqilong has joined #openstack-cinder | 01:08 | |
| *** dviroel_ has joined #openstack-cinder | 01:31 | |
| *** dviroel has quit IRC | 01:38 | |
| *** dviroel_ is now known as dviroel | 01:39 | |
| *** hamalq has quit IRC | 02:14 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Use os-brick 4.3.0 https://review.opendev.org/c/openstack/cinder/+/779646 | 02:54 |
| openstackgerrit | Merged openstack/cinder master: [Pure] Add missing FC host personality support https://review.opendev.org/c/openstack/cinder/+/775948 | 03:15 |
| *** udesale has joined #openstack-cinder | 03:29 | |
| *** rratnaka has joined #openstack-cinder | 03:40 | |
| *** rratnaka14 has joined #openstack-cinder | 03:40 | |
| *** knomura has joined #openstack-cinder | 04:27 | |
| *** rratnaka has quit IRC | 04:28 | |
| *** carloss has quit IRC | 04:29 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 04:37 | |
| *** zenkuro has joined #openstack-cinder | 04:47 | |
| *** knomura has quit IRC | 04:53 | |
| *** vishalmanchanda has joined #openstack-cinder | 04:59 | |
| *** ajitha has joined #openstack-cinder | 05:11 | |
| ajitha | @rosmaita : Thank you for your comments. Nimble driver is reporting within HPE Storage CI as iscsi-driver-nimble. | 05:13 |
| *** m75abrams has joined #openstack-cinder | 05:16 | |
| openstackgerrit | Merged openstack/cinder master: Hitachi: Trace REST API input/output logs https://review.opendev.org/c/openstack/cinder/+/777578 | 05:42 |
| *** zenkuro has quit IRC | 06:00 | |
| *** zenkuro has joined #openstack-cinder | 06:01 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/776822 | 06:13 |
| *** whoami-rajat has joined #openstack-cinder | 06:23 | |
| *** e0ne has joined #openstack-cinder | 06:31 | |
| *** e0ne has quit IRC | 06:31 | |
| *** manoj_katari has joined #openstack-cinder | 06:41 | |
| *** enriquetaso has quit IRC | 06:43 | |
| *** venkatakrishnath has joined #openstack-cinder | 07:02 | |
| *** knomura has joined #openstack-cinder | 07:05 | |
| *** knomura has quit IRC | 07:09 | |
| *** ajitha has quit IRC | 07:21 | |
| *** e0ne has joined #openstack-cinder | 07:22 | |
| *** e0ne has quit IRC | 07:27 | |
| *** ociuhandu has joined #openstack-cinder | 07:45 | |
| *** ociuhandu has quit IRC | 07:51 | |
| *** rratnaka14 has quit IRC | 07:58 | |
| *** ociuhandu has joined #openstack-cinder | 08:05 | |
| *** lpetrut has joined #openstack-cinder | 08:06 | |
| *** rratnaka has joined #openstack-cinder | 08:08 | |
| *** ociuhandu has quit IRC | 08:16 | |
| *** ociuhandu has joined #openstack-cinder | 08:17 | |
| *** ociuhandu has quit IRC | 08:17 | |
| *** ociuhandu has joined #openstack-cinder | 08:18 | |
| *** brinzhang_ has joined #openstack-cinder | 08:20 | |
| *** brinzhang has quit IRC | 08:23 | |
| *** ociuhandu has quit IRC | 08:23 | |
| *** rpittau|afk is now known as rpittau | 08:27 | |
| *** ociuhandu has joined #openstack-cinder | 08:28 | |
| *** sfernand has quit IRC | 08:36 | |
| *** tosky has joined #openstack-cinder | 08:46 | |
| *** MrClayPole has quit IRC | 08:47 | |
| *** MrClayPole has joined #openstack-cinder | 08:48 | |
| *** jbernard has quit IRC | 08:58 | |
| *** manoj_katari has quit IRC | 09:03 | |
| *** jbernard has joined #openstack-cinder | 09:10 | |
| openstackgerrit | Xuan Yandong proposed openstack/cinder master: Restrict manage to encrypt volume type https://review.opendev.org/c/openstack/cinder/+/768458 | 09:15 |
| *** sapd1 has joined #openstack-cinder | 09:16 | |
| openstackgerrit | Lee Yarwood proposed openstack/cinder-tempest-plugin master: Set CINDER_ISCSI_HELPER explicitly for tgtadm job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/779697 | 09:36 |
| *** martinkennelly has joined #openstack-cinder | 09:47 | |
| openstackgerrit | Luigi Toscano proposed openstack/cinder-tempest-plugin master: DNM test a change https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/779702 | 09:53 |
| *** rcernin has quit IRC | 09:54 | |
| *** knomura has joined #openstack-cinder | 10:10 | |
| lyarwood | tosky: sorry didn't see that, just updated the commit in my change and rechecked yours | 10:10 |
| tosky | thanks | 10:12 |
| tosky | btw, the cinder weekly meeting will happen before those are merged anyway | 10:13 |
| tosky | or maybe not, let's see what the gates say | 10:13 |
| lyarwood | tosky: ack, what time is the meeting? | 10:14 |
| * lyarwood checks the wiki | 10:14 | |
| *** knomura has quit IRC | 10:14 | |
| tosky | lyarwood: 14:00 UTC - I've added a point about this to the agenda | 10:14 |
| tosky | lyarwood: https://etherpad.opendev.org/p/cinder-wallaby-meetings | 10:15 |
| lyarwood | tosky: I'm going to struggle to make the meeting today tbh, have some childcare issues between ~14:00 and ~16:00 UTC to take care of | 10:15 |
| tosky | did you mention you are still seeing issues with lioadm, though? | 10:15 |
| lyarwood | no, lioadm didn't show any issues | 10:16 |
| tosky | ok | 10:16 |
| lyarwood | I've just not been able to reproduce the volume detach failure with tgtadm | 10:16 |
| lyarwood | I've reproduced the encrypted volume failure where the path given by os-brick can point to another volume entirely | 10:16 |
| lyarwood | but that's specific to encrypted volumes as we use the /dev/disk/by-id paths for these volumes | 10:17 |
| lyarwood | and again that was with tgtadm | 10:17 |
| lyarwood | but given that behaviour I'm pretty sure the use of multiple tgtadm but multiple c-vol's is going to cause other issues | 10:17 |
| lyarwood | urgh sorry | 10:18 |
| lyarwood | `use of tgtadm by multiple c-vol's` | 10:18 |
| * lyarwood grabs a coffee and then adds the above to the pad for the meeting | 10:19 | |
| tosky | thanks | 10:19 |
| *** ociuhandu has quit IRC | 10:23 | |
| *** ociuhandu has joined #openstack-cinder | 10:24 | |
| *** ociuhandu has quit IRC | 10:31 | |
| *** ociuhandu has joined #openstack-cinder | 10:31 | |
| *** e0ne has joined #openstack-cinder | 10:35 | |
| *** masterpe has quit IRC | 10:36 | |
| *** carloss has joined #openstack-cinder | 10:39 | |
| *** masterpe has joined #openstack-cinder | 10:45 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Remove nested quota leftovers https://review.opendev.org/c/openstack/cinder/+/779717 | 11:06 |
| whoami-rajat | thanks geguileo ^ | 11:09 |
| geguileo | whoami-rajat: no problem :-) | 11:10 |
| geguileo | I'm looking into quotas to try to fix them | 11:10 |
| geguileo | So I'm doing some cleanup to make it easier | 11:10 |
| whoami-rajat | geguileo: great, i will also put up a patch to validate project with keystone in quotas, here's the base patch https://review.opendev.org/c/openstack/cinder/+/752431 | 11:11 |
| whoami-rajat | basically refactoring some methods out of quotas (hope it doesn't conflict with your patch) | 11:12 |
| geguileo | doesn't look like it does | 11:13 |
| whoami-rajat | great! | 11:14 |
| *** sapd1 has quit IRC | 11:21 | |
| *** udesale_ has joined #openstack-cinder | 11:24 | |
| openstackgerrit | Lee Yarwood proposed openstack/devstack-plugin-ceph master: tempest: Use a more appropriate name for the skip list https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/770906 | 11:26 |
| geguileo | whoami-rajat: why are you removing some tests from test_quota_utils.py? | 11:28 |
| geguileo | whoami-rajat: for example test_get_project_keystoneclient_v3_with_subtree | 11:28 |
| *** udesale has quit IRC | 11:28 | |
| geguileo | or test__filter_domain_id_from_parents_domain_as_parent | 11:28 |
| openstackgerrit | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Set volume IOPS based on volume size https://review.opendev.org/c/openstack/cinder/+/764804 | 11:36 |
| whoami-rajat | geguileo: yes, they were part of getting project hierarchy which IIRC i confirmed with lance isn't used anymore | 11:38 |
| whoami-rajat | also i think that feature isn't complete from keystone side | 11:38 |
| geguileo | whoami-rajat: but you left the code that checked that | 11:38 |
| *** venkatakrishnath has quit IRC | 11:38 | |
| whoami-rajat | :O | 11:39 |
| geguileo | if we leave the code, we should leave the tests | 11:39 |
| whoami-rajat | where? | 11:39 |
| geguileo | whoami-rajat: you didn't remove any code, right? you only moved the methods | 11:39 |
| whoami-rajat | geguileo: the code was removed with nested quota removal | 11:39 |
| geguileo | whoami-rajat: oh, I see you just changed the code, you removed get_project_hierarchy | 11:41 |
| whoami-rajat | oh wait, i think I'm mixing up things | 11:41 |
| whoami-rajat | yes, i changed get_project_hierarchy to get_project | 11:41 |
| whoami-rajat | and the methods dependent on get_project_hierarchy were removed with the nested quota driver | 11:42 |
| geguileo | whoami-rajat: then you reaaaaaally need to explain that | 11:42 |
| geguileo | a refactor is basically doing the same thing | 11:42 |
| geguileo | if you change things in the same patch it should be explained (I think) | 11:43 |
| whoami-rajat | yes you're right, it was initially a refactor only patch then i changed things and forgot to update commit msg | 11:43 |
| whoami-rajat | i will update it | 11:43 |
| geguileo | thanks! | 11:44 |
| whoami-rajat | thanks for mentioning it | 11:44 |
| *** ociuhandu has quit IRC | 12:12 | |
| *** ociuhandu has joined #openstack-cinder | 12:12 | |
| *** ociuhandu has quit IRC | 12:12 | |
| *** ociuhandu has joined #openstack-cinder | 12:13 | |
| *** ociuhandu has quit IRC | 12:18 | |
| *** manoj_katari has joined #openstack-cinder | 12:22 | |
| hemna | morning | 12:41 |
| *** ociuhandu has joined #openstack-cinder | 12:44 | |
| *** zenkuro has quit IRC | 12:45 | |
| *** ociuhandu has quit IRC | 12:48 | |
| *** venkatakrishnath has joined #openstack-cinder | 12:51 | |
| *** ociuhandu has joined #openstack-cinder | 12:51 | |
| *** venkatakrishnath has quit IRC | 12:53 | |
| *** rratnaka has quit IRC | 12:59 | |
| *** ociuhandu has quit IRC | 13:02 | |
| *** ociuhandu has joined #openstack-cinder | 13:05 | |
| *** manoj_katari has quit IRC | 13:17 | |
| *** ociuhandu has quit IRC | 13:19 | |
| *** ociuhandu has joined #openstack-cinder | 13:20 | |
| *** rratnaka has joined #openstack-cinder | 13:20 | |
| *** brinzhang_ has quit IRC | 13:23 | |
| *** brinzhang_ has joined #openstack-cinder | 13:24 | |
| *** ajitha has joined #openstack-cinder | 13:24 | |
| *** ociuhandu has quit IRC | 13:25 | |
| *** ociuhandu has joined #openstack-cinder | 13:27 | |
| *** ociuhandu has quit IRC | 13:33 | |
| *** sapd1 has joined #openstack-cinder | 13:38 | |
| eharney | easy patch to review: https://review.opendev.org/c/openstack/cinder/+/770831 | 13:44 |
| *** enriquetaso has joined #openstack-cinder | 13:46 | |
| *** manoj_katari has joined #openstack-cinder | 13:49 | |
| *** ociuhandu has joined #openstack-cinder | 13:49 | |
| *** venkatakrishnath has joined #openstack-cinder | 13:50 | |
| manoj_katari | @Core reviewers: could you please review these minor changes in IBM SVF driver waiting for merge from a long time. | 13:56 |
| manoj_katari | https://review.opendev.org/c/openstack/cinder/+/765060 | 13:56 |
| manoj_katari | https://review.opendev.org/c/openstack/cinder/+/753134 | 13:56 |
| manoj_katari | https://review.opendev.org/c/openstack/cinder/+/771783 | 13:56 |
| rosmaita | Courtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC | 14:00 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso hemna ^^ | 14:00 |
| *** ociuhandu has quit IRC | 14:01 | |
| *** ociuhandu has joined #openstack-cinder | 14:01 | |
| *** sfernand has joined #openstack-cinder | 14:05 | |
| *** jrollen is now known as jroll | 14:13 | |
| *** felipe_rodrigues has joined #openstack-cinder | 14:14 | |
| openstackgerrit | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Set volume IOPS based on volume size https://review.opendev.org/c/openstack/cinder/+/764804 | 14:33 |
| openstackgerrit | Lance Bragstad proposed openstack/cinder master: DNM: Configure tempest-integrated-storage to use new policy defaults https://review.opendev.org/c/openstack/cinder/+/779774 | 14:33 |
| openstackgerrit | Lance Bragstad proposed openstack/cinder master: DNM: Configure tempest-integrated-storage to use new policy defaults https://review.opendev.org/c/openstack/cinder/+/779774 | 14:39 |
| openstackgerrit | Lance Bragstad proposed openstack/cinder master: DNM: Configure tempest-integrated-storage to use new policy defaults https://review.opendev.org/c/openstack/cinder/+/779774 | 14:40 |
| *** fnordahl has quit IRC | 14:42 | |
| lbragstad | rosmaita ^ that's another approach we can use to increase confidence in the default policies while folks continue working on the protection tests in ctp | 14:42 |
| openstackgerrit | Lance Bragstad proposed openstack/cinder master: DNM: Configure tempest-integrated-storage to use new policy defaults https://review.opendev.org/c/openstack/cinder/+/779774 | 14:44 |
| openstackgerrit | Merged openstack/python-brick-cinderclient-ext master: remove unicode from code https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/769002 | 14:50 |
| *** ociuhandu has quit IRC | 14:54 | |
| *** ociuhandu has joined #openstack-cinder | 14:54 | |
| eharney | i'm not sure whether https://review.opendev.org/c/openstack/cinder/+/779541 is showing that data in the right place regardless of the policy considerations | 15:01 |
| *** TusharTgite has joined #openstack-cinder | 15:01 | |
| rosmaita | hemna: i think when you introduce the policy, you make it restrictive, and then it's up to the operator to open it up | 15:02 |
| hemna | eharney yah it's odd, but it is how the default admin_metadata options are added | 15:02 |
| * enriquetaso looking for a coffee | 15:02 | |
| eharney | not sure what you mean, but it's not obvious to me that admin metadata should show up when looking at volumes here | 15:03 |
| hemna | there are 2 admin_metadata fields that are added to the metadata output in the API https://github.com/openstack/cinder/blob/master/cinder/api/api_utils.py#L68 | 15:03 |
| *** ociuhandu has quit IRC | 15:03 | |
| hemna | as an admin only | 15:03 |
| eharney | we have a lot of different metadata fields, this kind of thing would benefit from a spec | 15:03 |
| *** ociuhandu has joined #openstack-cinder | 15:03 | |
| enriquetaso | OK, I'm going to start the meeting to discuss the bugs now. :) | 15:03 |
| hemna | yah a spec would be nice, but I'm just hacking around to figure some things out and start a discussion | 15:04 |
| rosmaita | hemna: and possibly making that list a config option | 15:04 |
| rosmaita | unless we are talking about allowing write access also | 15:04 |
| hemna | the way it works now, is it shows those 2 fields as part of metadata for a volume, which is odd | 15:04 |
| rosmaita | hemna: this is a good topic for the PTG | 15:04 |
| hemna | I think separating out admin_metadata and allowing drivers to write stuff in it would be useful. also making that only viewable by admins. | 15:05 |
| hemna | ok, I'm needing something sooner :P | 15:05 |
| *** knomura has joined #openstack-cinder | 15:05 | |
| *** zzzeek has quit IRC | 15:05 | |
| hemna | anyway, can we talk about this after the bug discussion that enriquetaso wants to start? | 15:05 |
| rosmaita | too late for wallaby, i think :) | 15:05 |
| rosmaita | sure | 15:05 |
| eharney | IMO changes for fundamental API things like volume show and volume metadata really need a spec | 15:05 |
| hemna | rosmaita, that's fine. I'll patch our cinder anyway internally | 15:05 |
| rosmaita | eharney: ++ | 15:06 |
| hemna | eharney agreed, this is just hacking and trying to figure out the right want to do this. | 15:06 |
| *** zzzeek has joined #openstack-cinder | 15:06 | |
| enriquetaso | hemna, thanks, sorry for interrupting your discussion | 15:06 |
| *** TusharTgite has quit IRC | 15:06 | |
| rosmaita | enriquetaso: when you have some time, you can put up a patch to make this an "official" meeting | 15:06 |
| hemna | enriquetaso np. | 15:06 |
| rosmaita | something like this one: https://review.opendev.org/c/opendev/irc-meetings/+/553834 | 15:06 |
| enriquetaso | rosmaita, sure, I'll do it | 15:07 |
| enriquetaso | #startmeeting bug-report-cinder | 15:07 |
| openstack | Meeting started Wed Mar 10 15:07:27 2021 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:07 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:07 |
| *** openstack changes topic to " (Meeting topic: bug-report-cinder)" | 15:07 | |
| openstack | The meeting name has been set to 'bug_report_cinder' | 15:07 |
| enriquetaso | I need to think of a more original and cool name for the next meeting. | 15:07 |
| rosmaita | :) | 15:07 |
| enriquetaso | I couldn't fully prepare the etherpard for today's but I have some bugs to discuss: | 15:07 |
| enriquetaso | #topic #bug_1:"Cinder ignores reader role conventions in default policies" | 15:07 |
| *** openstack changes topic to "#bug_1:"Cinder ignores reader role conventions in default policies" (Meeting topic: bug-report-cinder)" | 15:07 | |
| hemna | eharney, I'll work on a draft spec | 15:08 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1917795 | 15:08 |
| openstack | Launchpad bug 1917795 in Cinder "Cinder ignores reader role conventions in default policies" [Undecided,New] | 15:08 |
| enriquetaso | In keystone, if I grant someone the reader role on a project [0], they're able to make writable changes in cinder. | 15:08 |
| enriquetaso | Opening this bug to track work for cinder to consume keystone's default read-only `reader` role. | 15:08 |
| enriquetaso | I am worried about doing this as we approach RC time but I think we want this for W, right? | 15:08 |
| *** m75abrams has quit IRC | 15:08 | |
| rosmaita | well, we'll have to see | 15:08 |
| rosmaita | this is a bug, so not subject to FF | 15:09 |
| rosmaita | and it is a real bug, i think | 15:09 |
| enriquetaso | ah OK, so I'll set medium importance | 15:09 |
| enriquetaso | #topic bug_2: "Cinder request to glance does not support TLS" | 15:10 |
| *** openstack changes topic to "bug_2: "Cinder request to glance does not support TLS" (Meeting topic: bug-report-cinder)" | 15:10 | |
| *** knomura has quit IRC | 15:10 | |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1917797 | 15:10 |
| openstack | Launchpad bug 1917797 in Cinder "Cinder request to glance does not support TLS" [Undecided,In progress] | 15:10 |
| enriquetaso | in https://github.com/openstack/cinder/blob/39e6008543cd72bbb0daebda676d69ec80bc7be4/cinder/image/glance.py#L107 | 15:10 |
| enriquetaso | the code does not send cert/key certificates to keystoneauth so if the glance API require TLS the request will fail | 15:10 |
| eharney | that doesn't sound right | 15:10 |
| eharney | or at least, needs a lot more detail | 15:10 |
| enriquetaso | There's a patch for this so far: | 15:10 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/778768 | 15:10 |
| enriquetaso | so, the bug it's not completed | 15:11 |
| eharney | so is this really about mTLS again? | 15:11 |
| enriquetaso | yep | 15:12 |
| eharney | i don't think we can go adding support for security related features without the bugs/patches at least having a clear description of what's going on | 15:12 |
| enriquetaso | as you mention last time this bug assumes that we support strict mTLS from cinderclient which i don't know is a reasonable assumption but worth fix it. | 15:12 |
| rosmaita | well, i find it concerning that someone who wants to work on this is not being precise about what they are talking about | 15:12 |
| eharney | me too | 15:13 |
| eharney | because it's not clear if we or they understand what the requirements actually are | 15:13 |
| rosmaita | i am going to request a spec | 15:14 |
| enriquetaso | so this could be more a topic for the next PTG if the reported would like to prepare it? | 15:14 |
| enriquetaso | oh spec sounds cool | 15:14 |
| rosmaita | yep | 15:14 |
| enriquetaso | ok, next one | 15:14 |
| enriquetaso | #topic bug_3: "Volume backup timeout for large volumes" | 15:14 |
| *** openstack changes topic to "bug_3: "Volume backup timeout for large volumes" (Meeting topic: bug-report-cinder)" | 15:14 | |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1918119 | 15:14 |
| openstack | Launchpad bug 1918119 in Cinder "Volume backup timeout for large volumes" [Undecided,In progress] - Assigned to kiran pawar (kiranpawar89) | 15:14 |
| *** __ministry1 has joined #openstack-cinder | 15:14 | |
| enriquetaso | There's a patch for this | 15:14 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/779233 | 15:14 |
| enriquetaso | Update from today's meeting earlier: we are going to push it to Xena | 15:14 |
| enriquetaso | just to double check ^ | 15:15 |
| eharney | i don't think this patch is even going in the right direction the longer i think about it | 15:15 |
| eharney | both Gorka and i left some feedback | 15:15 |
| enriquetaso | cool, thanks! | 15:15 |
| enriquetaso | Last one | 15:15 |
| enriquetaso | #topic bug_4: "Cinder-backup progress notification has incorrect percentage." | 15:16 |
| *** openstack changes topic to "bug_4: "Cinder-backup progress notification has incorrect percentage." (Meeting topic: bug-report-cinder)" | 15:16 | |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1918102 | 15:16 |
| openstack | Launchpad bug 1918102 in Cinder "Cinder-backup progress notification has incorrect percentage." [Undecided,New] - Assigned to Jon Cui (czl389) | 15:16 |
| enriquetaso | In the process of volume backup, Jon Cui found the percentage number was wrong for progress notification. | 15:16 |
| enriquetaso | I wonder if this should be treat as medium o high importance bug. | 15:16 |
| rosmaita | do we give a real percentage or just make one up? | 15:16 |
| eharney | probably not high | 15:16 |
| enriquetaso | good question | 15:17 |
| rosmaita | TIL: ctrl-L in my IRC client completely wipes out the buffer | 15:17 |
| hemna | ++++ backup_percent is 1.5832483768463135e-05 | 15:17 |
| hemna | heh | 15:17 |
| eharney | the calculation looks wrong | 15:17 |
| eharney | dividing number of blocks by volume size, those aren't even the same units | 15:18 |
| rosmaita | hemna: sounds like one of your 2TB backups | 15:18 |
| hemna | rosmaita yah I think it's related to our backup setup. | 15:18 |
| hemna | we are suffering pretty bad for backups taking ages right now | 15:18 |
| eharney | we should just mark that as confirmed but it's medium prio at best | 15:18 |
| eharney | (probably low prio given that presumably it's been like that for ages with nobody noticing) | 15:19 |
| enriquetaso | sounds good to me | 15:19 |
| enriquetaso | #topic open discussion | 15:20 |
| *** openstack changes topic to "open discussion (Meeting topic: bug-report-cinder)" | 15:20 | |
| hemna | ram usage peaked around 3G for the parallel backup w/ that patch | 15:20 |
| enriquetaso | Not sure if we need a open discussion | 15:20 |
| eharney | one thing i've wondered about re: bug meetings | 15:20 |
| hemna | we also have an issue with expiring tokens for the backups taking that long | 15:20 |
| hemna | which kills the backup | 15:21 |
| eharney | we have a process for looking at incoming new bugs, do we need to periodically look at ones that have been stuck in in-progress for a long time? | 15:21 |
| enriquetaso | hemna, do you have a link? | 15:21 |
| openstackgerrit | Simon Dodsley proposed openstack/cinder stable/victoria: Pure Storage: check volumename length does not exceed maximum https://review.opendev.org/c/openstack/cinder/+/779596 | 15:21 |
| eharney | i think that expiration problem no longer happens if you configure things to use the correct style of keystone tokens etc | 15:21 |
| hemna | enriquetaso no, it's internal | 15:21 |
| hemna | eharney correct style ? | 15:22 |
| enriquetaso | eharney, i think it's a good concern, I should probably start looking to older and stuck bugs too | 15:22 |
| rosmaita | hemna: https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html | 15:22 |
| enriquetaso | the problem is: how to do the report of 'stuck in in-progress' bugs, send an email? | 15:23 |
| *** ociuhandu has quit IRC | 15:23 | |
| rosmaita | probably | 15:23 |
| hemna | rosmaita I just checked out cinder.conf and we have teh send_service_user_token = true | 15:24 |
| *** ociuhandu has joined #openstack-cinder | 15:24 | |
| rosmaita | do you have the username, project, etc for the service user? | 15:24 |
| enriquetaso | #action enriquetaso: think a good way to report the 'stuck in in-progress for a long time' bugs | 15:25 |
| rosmaita | enriquetaso: short term, we could look them over at this meeting and see if they're still relevant | 15:26 |
| *** ociuhandu has quit IRC | 15:26 | |
| hemna | yah | 15:26 |
| *** ociuhandu has joined #openstack-cinder | 15:26 | |
| enriquetaso | ++ | 15:26 |
| enriquetaso | OK | 15:27 |
| enriquetaso | that's all I have for today's meeting | 15:27 |
| rosmaita | thanks, enriquetaso | 15:27 |
| enriquetaso | #endmeeting | 15:28 |
| *** openstack changes topic to "The Block Storage Project | https://wiki.openstack.org/wiki/Cinder | https://tiny.cc/CinderPriorities" | 15:28 | |
| openstack | Meeting ended Wed Mar 10 15:28:08 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:28 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/bug_report_cinder/2021/bug_report_cinder.2021-03-10-15.07.html | 15:28 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/bug_report_cinder/2021/bug_report_cinder.2021-03-10-15.07.txt | 15:28 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/bug_report_cinder/2021/bug_report_cinder.2021-03-10-15.07.log.html | 15:28 |
| rosmaita | hemna: there are some troubleshooting tips in that doc, but it could also be a bug :( | 15:28 |
| enriquetaso | I think i ended the meeting too soon | 15:29 |
| rosmaita | no, i don't think the bug has been filed yet! | 15:29 |
| rosmaita | enriquetaso: this extra meeting is a good idea, we really don't have time during the regular meeting | 15:30 |
| *** __ministry1 has quit IRC | 15:30 | |
| enriquetaso | :D | 15:31 |
| hemna | rosmaita I think I found the issue :) | 15:31 |
| rosmaita | tell me it's not a bug! | 15:31 |
| hemna | allow_expired_window defaults to 2 days in keystone | 15:31 |
| hemna | for whatever reason ours set set to 8 hours | 15:31 |
| hemna | so, it's not a bug....from what I can tell | 15:32 |
| rosmaita | cool | 15:32 |
| hemna | so our 20 hour long backups would see that problem from what I can tell. | 15:32 |
| hemna | so I have another issue that I found yesterday that I didn't file a bug for yet. | 15:33 |
| rosmaita | i think you have a good case to your security team to get that increased | 15:33 |
| rosmaita | they may not realize that the expired token must be accompanied by a good one, so it's not like you're opening the floodgates | 15:34 |
| hemna | yah I'm notifying the keystone guys in our org | 15:34 |
| hemna | at init_host time() in the volume manager, the volume manager calls ensure_export() for each volume inuse and available | 15:35 |
| hemna | several drivers have a model_update returned from that call | 15:35 |
| hemna | but the volume manage ignores it | 15:35 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L553 | 15:35 |
| hemna | our reference driver lvm returns a model update | 15:36 |
| hemna | :P | 15:36 |
| openstackgerrit | Simon Dodsley proposed openstack/cinder stable/victoria: Pure Storage FlashArray: Add active/active support https://review.opendev.org/c/openstack/cinder/+/779781 | 15:36 |
| hemna | there are a few more, but I haven't done an extensive search | 15:36 |
| hemna | working on a patch for that | 15:37 |
| rosmaita | ok | 15:39 |
| openstackgerrit | Simon Dodsley proposed openstack/cinder master: Add QoS Suport for Pure Storage https://review.opendev.org/c/openstack/cinder/+/727267 | 15:40 |
| hemna | I'll file a bug for it | 15:42 |
| *** lpetrut has quit IRC | 15:44 | |
| *** ociuhandu has quit IRC | 15:46 | |
| *** ociuhandu has joined #openstack-cinder | 15:46 | |
| *** ociuhandu has quit IRC | 15:49 | |
| *** rratnaka has quit IRC | 15:49 | |
| *** ociuhandu has joined #openstack-cinder | 15:49 | |
| enriquetaso | rosmaita: https://review.opendev.org/c/opendev/irc-meetings/+/779818 | 16:15 |
| *** ociuhandu has quit IRC | 16:15 | |
| rosmaita | enriquetaso: LGTM! | 16:16 |
| *** udesale_ has quit IRC | 16:18 | |
| *** ociuhandu has joined #openstack-cinder | 16:24 | |
| *** ociuhandu has quit IRC | 16:24 | |
| *** ociuhandu has joined #openstack-cinder | 16:25 | |
| *** ociuhandu has quit IRC | 16:29 | |
| openstackgerrit | Jay Bryant proposed openstack/python-cinderclient master: client: Stop logging request-id twice in DEBUG https://review.opendev.org/c/openstack/python-cinderclient/+/767697 | 16:31 |
| jungleboyj | rosmaita: Looking at cinderclient patches. Have merged several. Saw this one: https://review.opendev.org/c/openstack/python-cinderclient/+/766882 | 16:32 |
| jungleboyj | What are your thoughts here? | 16:32 |
| rosmaita | looking | 16:33 |
| jungleboyj | I can see the reason for the change, but can also see why it was made that way from the start. | 16:33 |
| rosmaita | jungleboyj: yeha, i wasn't sure, just wanted to get eyes on it | 16:34 |
| *** ociuhandu has joined #openstack-cinder | 16:35 | |
| rosmaita | i guess it's not true that "there's nothing they can do about it", the user can request --os-volume-api-version that is the max supported by that server after the first message, and then the messages would go away | 16:36 |
| *** ociuhandu has quit IRC | 16:37 | |
| *** ociuhandu has joined #openstack-cinder | 16:37 | |
| *** takamatsu has quit IRC | 16:37 | |
| rosmaita | i think i agree with your intuition that we don't want to silently change something on the user | 16:37 |
| rosmaita | i downgraded that patch to "easy, but possibly controversial" on the etherpad | 16:38 |
| openstackgerrit | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Set volume IOPS based on volume size https://review.opendev.org/c/openstack/cinder/+/764804 | 16:39 |
| GirishChilukuri_ | @Core reviewers: could you please review these minor changes waiting for second +2 to merge. | 16:42 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/765060 | 16:42 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/753134 | 16:42 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/771783 | 16:42 |
| jungleboyj | rosmaita: Ok. Thank you. That was my thought as well. I am going to add a comment to the patch accordingly. | 16:46 |
| rosmaita | jungleboyj: sounds good, no sense rushing it | 16:46 |
| jungleboyj | I weighed in. Will see what others think. | 16:48 |
| *** venkatakrishnath has quit IRC | 16:50 | |
| *** ociuhandu has quit IRC | 16:51 | |
| openstackgerrit | Felix Huettner proposed openstack/cinder master: Comply with nas_secure_file_operations for qemu-img info https://review.opendev.org/c/openstack/cinder/+/779834 | 16:56 |
| *** venkatakrishnath has joined #openstack-cinder | 16:58 | |
| openstackgerrit | Walt proposed openstack/cinder master: ensure_export model_update fix https://review.opendev.org/c/openstack/cinder/+/779835 | 17:00 |
| *** ociuhandu has joined #openstack-cinder | 17:00 | |
| *** rpittau is now known as rpittau|afk | 17:05 | |
| *** GirishChilukuri_ has quit IRC | 17:09 | |
| *** sapd1 has quit IRC | 17:34 | |
| *** takamatsu has joined #openstack-cinder | 17:38 | |
| *** akrpan-pure has joined #openstack-cinder | 17:40 | |
| *** manoj_katari has quit IRC | 17:52 | |
| openstackgerrit | Merged openstack/python-cinderclient master: Remove more python2 compat code https://review.opendev.org/c/openstack/python-cinderclient/+/779270 | 18:01 |
| openstackgerrit | Merged openstack/python-cinderclient master: Remove install unnecessary packages https://review.opendev.org/c/openstack/python-cinderclient/+/751175 | 18:01 |
| openstackgerrit | Merged openstack/python-cinderclient master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/python-cinderclient/+/771571 | 18:01 |
| *** venkatakrishnath has quit IRC | 18:02 | |
| *** takamatsu has quit IRC | 18:10 | |
| *** akrpan-pure has quit IRC | 18:22 | |
| openstackgerrit | Luigi Toscano proposed openstack/python-cinderclient master: Use TOX_CONSTRAINTS_FILE https://review.opendev.org/c/openstack/python-cinderclient/+/760786 | 18:30 |
| *** tbarron has joined #openstack-cinder | 18:37 | |
| hemna | mep | 18:47 |
| *** e0ne has quit IRC | 18:48 | |
| *** ociuhandu has quit IRC | 19:12 | |
| *** ociuhandu has joined #openstack-cinder | 19:12 | |
| *** ociuhandu has quit IRC | 19:19 | |
| *** ociuhandu has joined #openstack-cinder | 19:20 | |
| *** ociuhandu has quit IRC | 19:22 | |
| *** ociuhandu has joined #openstack-cinder | 19:23 | |
| jungleboyj | o/ | 19:31 |
| *** brinzhang0 has joined #openstack-cinder | 19:33 | |
| *** ociuhandu_ has joined #openstack-cinder | 19:34 | |
| *** tosky_ has joined #openstack-cinder | 19:37 | |
| *** benj_- has joined #openstack-cinder | 19:37 | |
| *** dosaboy_ has joined #openstack-cinder | 19:38 | |
| *** whoami-rajat has quit IRC | 19:40 | |
| *** ociuhandu has quit IRC | 19:42 | |
| *** brinzhang_ has quit IRC | 19:42 | |
| *** tosky has quit IRC | 19:42 | |
| *** jv_ has quit IRC | 19:42 | |
| *** benj_ has quit IRC | 19:42 | |
| *** dosaboy has quit IRC | 19:42 | |
| *** Underknowledge has quit IRC | 19:42 | |
| *** pck has quit IRC | 19:42 | |
| *** Underknowledge has joined #openstack-cinder | 19:43 | |
| *** irclogbot_1 has quit IRC | 19:44 | |
| *** jv_ has joined #openstack-cinder | 19:49 | |
| rosmaita | sfernand: around? | 19:49 |
| *** ajitha has quit IRC | 19:54 | |
| openstackgerrit | Eric Harney proposed openstack/python-cinderclient master: Add flake8-import-order extension https://review.opendev.org/c/openstack/python-cinderclient/+/733014 | 20:05 |
| eharney | this needed a rebase after another patch landed, if someone would like to re-review ^ | 20:05 |
| eharney | (was approved but failed pep8) | 20:05 |
| rosmaita | eharney: ack | 20:06 |
| rosmaita | hey everyone, here is the promised wallaby features review etherpad: https://etherpad.opendev.org/p/cinder-wallaby-features | 20:07 |
| openstackgerrit | hemna proposed openstack/cinder-specs master: Add provider_metadata spec https://review.opendev.org/c/openstack/cinder-specs/+/779855 | 20:07 |
| hemna | rosmaita ^^ | 20:07 |
| openstackgerrit | Merged openstack/python-cinderclient master: Doc: Functional Tests in python-cinderclient https://review.opendev.org/c/openstack/python-cinderclient/+/767520 | 20:07 |
| hemna | hopefully that will shed a little bit of light on what I'm trying to do | 20:08 |
| hemna | basically, the vmware driver sucks and we have issues with volumes in vcenter | 20:08 |
| hemna | and need a way to add some metadata to store in cinder to help us move those volumes around inside of vcenter | 20:09 |
| hemna | I can hack our cinder to allow me to shove some data into the volume_admin_metadata table, or write a spec and some code to do it upstream in a provider_metadata table | 20:09 |
| hemna | the crux is the admin user needs to see that data from volume fetch API calls. | 20:10 |
| hemna | I figured adding an upstream feature is 'better' in the long run | 20:10 |
| hemna | so others can use it. if need be. | 20:10 |
| rosmaita | yeah, i think it is probably something that would be useful | 20:11 |
| hemna | we basically allow drivers today to shove vendor specific data into the cinder db | 20:11 |
| hemna | but it's all over the place | 20:11 |
| hemna | provider_id | 20:11 |
| hemna | provider_location | 20:11 |
| hemna | provider_geometry | 20:11 |
| hemna | etc | 20:11 |
| hemna | kind of a mess really | 20:11 |
| hemna | a few drivers compact several backend fields into the provider_id for extraction later | 20:12 |
| hemna | pretty much exactly backend metadata on a volume | 20:12 |
| hemna | I don't think it would take much effort to make this work, as the majority of the lifting is already in place, with all the existing model_update dict return vars supported by the volume manager. | 20:13 |
| hemna | just have to add the new db table, update the API to return the fields and save/load the fields into the table from the volume object. | 20:13 |
| rosmaita | so you see this as mostly a read-only API? the data is written by the drivers? | 20:14 |
| eharney | i'm adding comments to the spec, but, this is not the first time we've added a field to solve a problem like this | 20:15 |
| eharney | i think we need to understand how the current ones work before adding yet another | 20:15 |
| *** tosky_ is now known as tosky | 20:16 | |
| hemna | it's not a field, it's a table to allow storing multiple fields | 20:18 |
| eharney | sure | 20:18 |
| hemna | otherwise I'll just jam it into the volume_admin_metadata table and alter our API | 20:18 |
| hemna | I need to store multiple fields | 20:18 |
| eharney | i mean, we already use some of those fields to store multiple items | 20:18 |
| hemna | yes, I called those out | 20:19 |
| hemna | provider_id, provider_location, etc. | 20:19 |
| hemna | I have several uuids I need to store per volume | 20:19 |
| hemna | overloading provider_* doesn't work/make sense | 20:19 |
| eharney | ok so we have nothing that explains how to use those and how they differ from each other, or admin_metadata exactly, and we also have driver_initiator_data (not mentioned in the spec) added for similar reasons | 20:21 |
| eharney | i don't really see how just adding another table is going to help things, we can't just make the mess bigger | 20:21 |
| eharney | we need some coherent idea of how drivers are supposed to use all of these and how they work | 20:22 |
| hemna | that's outside the scope of my spec | 20:23 |
| eharney | "jamming" it into the volume_admin_metadata table might be the right answer | 20:23 |
| hemna | if you want that, then I'll just abandon this and move on | 20:23 |
| eharney | i don't really think it is | 20:23 |
| hemna | my spec isn't altering how any driver uses the existing fields. I'm not trying to rewrite the world. | 20:24 |
| hemna | if that's what is expected, then I'm out | 20:24 |
| *** takamatsu has joined #openstack-cinder | 20:25 | |
| hemna | I believe provider_* crap was added due to resistance to adding provider based metadata during the whole replication debacle | 20:26 |
| hemna | I'm not interested in touching any of that! :P | 20:26 |
| hemna | list of drivers that return a model_update from ensure_export lvm, solidfire, nimble, netapp, linstordrv, ibm, hpe 3par | 20:47 |
| hemna | fyi | 20:48 |
| eharney | i think LVM doesn't, as i noted | 20:48 |
| hemna | vmware will shortly as well, and it's needed. | 20:48 |
| hemna | well lvm does return from a call to the target driver | 20:48 |
| eharney | which returns nothing AFAICT | 20:49 |
| *** tosky has quit IRC | 20:49 | |
| hemna | and lvm is the reference implementation, so the volume manager should handle it | 20:49 |
| *** tosky has joined #openstack-cinder | 20:49 | |
| hemna | the rest of the drivers do return actual values | 20:49 |
| eharney | or maybe the fact that it returns anything is just a bug and it's not supposed to be doing that | 20:49 |
| eharney | but why are they returning values? what needs updating in that situation? | 20:49 |
| hemna | it's the latest information about the export on the storage array | 20:50 |
| hemna | it's a bug that it's ignored | 20:50 |
| eharney | it's not a bug if the Cinder API is that those calls aren't supposed to change information on the backend | 20:50 |
| eharney | that's why i'm wondering what is actually changing | 20:51 |
| hemna | cinder is ignoring the updated information about the exports, that's the bug | 20:52 |
| eharney | uh | 20:52 |
| hemna | all of those drivers are returning an update and are asking the volume manager to save it. it's not. | 20:52 |
| hemna | that's a bug | 20:52 |
| eharney | what i'm asking is, what is in the update? | 20:53 |
| hemna | some drivers are asking to update the provider_* fields | 20:54 |
| hemna | some are updating the chap information | 20:54 |
| hemna | it's different for every backend | 20:54 |
| hemna | the vmware driver needs to be able to return this as well. I'm working on a patch against the vmware driver which is related to this and the metadata spec | 20:55 |
| *** ociuhandu_ has quit IRC | 20:59 | |
| eharney | is it reasonable for a driver to change chap information on ensure_export()? | 20:59 |
| eharney | why is that a thing that even happens? | 20:59 |
| eharney | the fact that we have been ignoring such things seems to indicate that maybe it's not required... | 20:59 |
| *** ociuhandu has joined #openstack-cinder | 21:12 | |
| hemna | its a bug | 21:14 |
| hemna | just because it's been ignored doesn't mean it's not a bug | 21:14 |
| openstackgerrit | hemna proposed openstack/cinder-specs master: Add provider_metadata spec https://review.opendev.org/c/openstack/cinder-specs/+/779855 | 21:15 |
| *** martinkennelly has quit IRC | 21:20 | |
| *** NobodyCam has quit IRC | 21:39 | |
| *** NobodyCam has joined #openstack-cinder | 21:40 | |
| *** ociuhandu has quit IRC | 21:42 | |
| *** TheJulia has quit IRC | 21:45 | |
| *** TheJulia has joined #openstack-cinder | 21:45 | |
| *** johnsom has quit IRC | 21:46 | |
| *** johnsom has joined #openstack-cinder | 21:46 | |
| *** enriquetaso has quit IRC | 21:53 | |
| hemna | eharney I'm curious why we even have an volume_admin_metadata vs volume_metadata (with an admin bit) table | 22:01 |
| hemna | I suppose we could update the volume_metadata table and add an admin bit | 22:01 |
| hemna | then migrate all volume_admin_metadata fields into there. | 22:02 |
| hemna | and then add provider_metadata dict into that same table with the admin bit set | 22:02 |
| hemna | the only downside to that, is that it would be ideal to separate those out during volume index/show c-api calls | 22:02 |
| hemna | so the volumes dict coming back from the rest api would have metadata and provider_metadata fields | 22:03 |
| hemna | dunno | 22:03 |
| openstackgerrit | Merged openstack/python-cinderclient master: Bump API max version to 3.64 https://review.opendev.org/c/openstack/python-cinderclient/+/771236 | 22:04 |
| eharney | it looks like it was added because someone wanted a place to stash info related to read-only volume attachments. not sure what else it might be used for now | 22:05 |
| hemna | volume create API accepts metadata as well | 22:05 |
| hemna | which I believe is user facing key/values stuffed into the volume_metadata table | 22:06 |
| hemna | the provider_metadata is just metadata coming from the driver/backend | 22:06 |
| *** vishalmanchanda has quit IRC | 22:08 | |
| *** ociuhandu has joined #openstack-cinder | 22:10 | |
| *** zzzeek has quit IRC | 22:16 | |
| *** zzzeek has joined #openstack-cinder | 22:18 | |
| *** ociuhandu has quit IRC | 22:18 | |
| openstackgerrit | Brian Rosmaita proposed openstack/python-cinderclient master: Update requirements for wallaby release https://review.opendev.org/c/openstack/python-cinderclient/+/779875 | 22:23 |
| *** rcernin has joined #openstack-cinder | 22:27 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 22:58 | |
| GirishChilukuri_ | @Core reviewers: could you please review these minor changes waiting for second +2 to merge. | 23:00 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/765060 | 23:00 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/753134 | 23:00 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/771783 | 23:00 |
| *** GirishChilukuri_ has quit IRC | 23:06 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 23:11 | |
| *** GirishChilukuri_ has quit IRC | 23:18 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 23:30 | |
| *** rpittau|afk has quit IRC | 23:37 | |
| *** rpittau|afk has joined #openstack-cinder | 23:37 | |
| *** GirishChilukuri_ has quit IRC | 23:47 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!