*** e0ne has quit IRC | 00:03 | |
*** tosky has quit IRC | 00:35 | |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Revert "Support format info in fs type drivers" https://review.opendev.org/c/openstack/cinder/+/780464 | 00:42 |
---|---|---|
*** zenkuro has quit IRC | 00:43 | |
*** ociuhandu has joined #openstack-cinder | 00:47 | |
*** jv_ has quit IRC | 00:50 | |
*** ajitha has quit IRC | 00:54 | |
*** ociuhandu has quit IRC | 01:00 | |
*** brinzhang_ has joined #openstack-cinder | 01:03 | |
*** ianychoi_ has joined #openstack-cinder | 01:03 | |
*** lemko5 has joined #openstack-cinder | 01:04 | |
*** sapd1 has quit IRC | 01:05 | |
*** lemko has quit IRC | 01:12 | |
*** brinzhang has quit IRC | 01:12 | |
*** ianychoi has quit IRC | 01:12 | |
*** lemko5 is now known as lemko | 01:13 | |
*** hamalq has quit IRC | 01:23 | |
*** ajitha has joined #openstack-cinder | 01:46 | |
*** manoj_katari has quit IRC | 01:47 | |
*** senrique__ has joined #openstack-cinder | 01:56 | |
*** rcernin has quit IRC | 02:37 | |
openstackgerrit | Fernando Ferraz Silva proposed openstack/cinder master: NetApp ONTAP: Implement FlexGroup pool https://review.opendev.org/c/openstack/cinder/+/776713 | 02:52 |
openstackgerrit | Fernando Ferraz Silva proposed openstack/cinder master: NetApp ONTAP: Fix FlexGroup replication https://review.opendev.org/c/openstack/cinder/+/780690 | 02:52 |
openstackgerrit | Fernando Ferraz Silva proposed openstack/cinder master: NetApp ONTAP: Fix FlexGroup replication https://review.opendev.org/c/openstack/cinder/+/780690 | 03:08 |
*** rratnaka has joined #openstack-cinder | 03:14 | |
openstackgerrit | Fernando Ferraz Silva proposed openstack/cinder master: NetApp ONTAP: Fix FlexGroup replication https://review.opendev.org/c/openstack/cinder/+/780690 | 03:15 |
*** rcernin has joined #openstack-cinder | 03:19 | |
*** whoami-rajat_ has joined #openstack-cinder | 03:24 | |
*** senrique__ has quit IRC | 03:24 | |
whoami-rajat_ | rosmaita: hey, i saw the revert and the reason, my bad should've seen the CIs, so what's the next step from here? | 03:25 |
*** rcernin has quit IRC | 03:26 | |
rosmaita | well, if it's a quick fix, you can submit a patch for the fix instead, but if it's not obvious what to do (or if you don't have time for a day or two), let's revert the patch to unblock the netapp gates and then submit a fixed version | 03:27 |
whoami-rajat_ | ack, i think it should be fixed by an if condition for consistency group somewhere, i will try to create a patch today | 03:28 |
rosmaita | sounds good, thanks | 03:29 |
whoami-rajat_ | thanks! | 03:30 |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Add virtualenv requirement to tox.ini https://review.opendev.org/c/openstack/cinder/+/780692 | 03:30 |
*** rcernin has joined #openstack-cinder | 03:31 | |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Temporary fix for docs job https://review.opendev.org/c/openstack/cinder/+/780696 | 03:37 |
*** psachin has joined #openstack-cinder | 03:38 | |
*** udesale has joined #openstack-cinder | 03:46 | |
openstackgerrit | Ratnakaram Rajesh proposed openstack/cinder master: Update code layout and missing Zadara features https://review.opendev.org/c/openstack/cinder/+/774463 | 03:58 |
*** knomura_ has joined #openstack-cinder | 04:07 | |
*** knomura has quit IRC | 04:08 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: WIP: fix for create volume with groups https://review.opendev.org/c/openstack/cinder/+/780700 | 04:17 |
*** zzzeek has quit IRC | 04:18 | |
*** zzzeek has joined #openstack-cinder | 04:22 | |
*** ociuhandu has joined #openstack-cinder | 04:24 | |
*** ociuhandu has quit IRC | 04:30 | |
*** GirishChilukuri has joined #openstack-cinder | 04:33 | |
*** vishalmanchanda has joined #openstack-cinder | 04:33 | |
*** knomura_ has quit IRC | 05:00 | |
*** dviroel has quit IRC | 05:02 | |
*** rratnaka14 has joined #openstack-cinder | 05:15 | |
*** rratnaka has quit IRC | 05:18 | |
*** rratnaka14 has quit IRC | 05:20 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: WIP: fix for create volume with groups https://review.opendev.org/c/openstack/cinder/+/780700 | 05:22 |
*** ociuhandu has joined #openstack-cinder | 06:13 | |
*** ociuhandu has quit IRC | 06:17 | |
*** ociuhandu has joined #openstack-cinder | 06:18 | |
*** ociuhandu has quit IRC | 06:28 | |
*** ociuhandu has joined #openstack-cinder | 06:29 | |
*** m75abrams has joined #openstack-cinder | 06:33 | |
*** ociuhandu has quit IRC | 06:35 | |
*** icey_ has quit IRC | 07:00 | |
*** ociuhandu has joined #openstack-cinder | 07:00 | |
*** ociuhandu has quit IRC | 07:00 | |
*** ociuhandu has joined #openstack-cinder | 07:00 | |
*** icey has joined #openstack-cinder | 07:06 | |
*** whoami-rajat_ is now known as whoami-rajat | 07:09 | |
*** TusharTgite has joined #openstack-cinder | 07:21 | |
*** rcernin has quit IRC | 07:24 | |
openstackgerrit | Tushar Trambak Gite proposed openstack/cinder master: Dropping explicit unicode literal https://review.opendev.org/c/openstack/cinder/+/775831 | 07:31 |
*** udesale has quit IRC | 07:36 | |
*** rcernin has joined #openstack-cinder | 07:54 | |
*** rpittau|afk is now known as rpittau | 07:58 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: NFS: Fix for groups and cloning https://review.opendev.org/c/openstack/cinder/+/780700 | 08:04 |
*** rcernin has quit IRC | 08:06 | |
*** ociuhandu has quit IRC | 08:19 | |
*** pcaruana has joined #openstack-cinder | 08:23 | |
*** zigo has joined #openstack-cinder | 08:28 | |
*** zenkuro has joined #openstack-cinder | 08:37 | |
*** udesale has joined #openstack-cinder | 08:38 | |
zenkuro | hay! can anybody please take a look at https://review.opendev.org/c/openstack/cinder/+/763760 | 08:42 |
*** tosky has joined #openstack-cinder | 08:59 | |
*** xarlos has joined #openstack-cinder | 09:00 | |
*** lpetrut has joined #openstack-cinder | 09:02 | |
*** brinzhang0 has joined #openstack-cinder | 09:12 | |
*** brinzhang_ has quit IRC | 09:16 | |
*** knomura has joined #openstack-cinder | 09:20 | |
*** zenkuro has quit IRC | 09:22 | |
*** zenkuro has joined #openstack-cinder | 09:23 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Resolve SADeprecationWarning for joinedload_all https://review.opendev.org/c/openstack/cinder/+/780755 | 09:24 |
*** lee2 has joined #openstack-cinder | 09:24 | |
*** lee2 is now known as lyarwood | 09:24 | |
*** knomura has quit IRC | 09:25 | |
openstackgerrit | Xuan Yandong proposed openstack/cinder master: Remove six from cinder.tests.unit.objects https://review.opendev.org/c/openstack/cinder/+/780757 | 09:28 |
openstackgerrit | Xuan Yandong proposed openstack/cinder master: Remove six from cinder.tests.unit.volume.drivers https://review.opendev.org/c/openstack/cinder/+/780759 | 09:29 |
openstackgerrit | Xuan Yandong proposed openstack/cinder master: Remove six from cinder/zonemanager/* https://review.opendev.org/c/openstack/cinder/+/780760 | 09:29 |
*** e0ne has joined #openstack-cinder | 10:00 | |
*** e0ne has quit IRC | 10:03 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: NFS: Fix for groups and cloning https://review.opendev.org/c/openstack/cinder/+/780700 | 10:16 |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Fix for create group from source https://review.opendev.org/c/openstack/cinder/+/780774 | 10:21 |
*** martinkennelly has joined #openstack-cinder | 10:21 | |
*** supamatt has quit IRC | 10:43 | |
*** ociuhandu has joined #openstack-cinder | 10:44 | |
openstackgerrit | ajitha proposed openstack/cinder master: Add support for consistency groups in the Nimble Storage driver https://review.opendev.org/c/openstack/cinder/+/778886 | 10:44 |
tosky | sfernand: hi! Have you seen the comment in https://review.opendev.org/c/openstack/cinder/+/764275/ ? | 10:47 |
*** smcginnis has joined #openstack-cinder | 10:48 | |
*** ChanServ sets mode: +o smcginnis | 10:48 | |
*** dviroel has joined #openstack-cinder | 10:49 | |
sfernand | hi tosky I will fix that in a moment | 10:52 |
*** carloss has joined #openstack-cinder | 10:55 | |
openstackgerrit | Fernando Ferraz Silva proposed openstack/cinder stable/train: NetApp SolidFire: Fix duplicate volume when API response is lost https://review.opendev.org/c/openstack/cinder/+/764275 | 10:57 |
tosky | sfernand: thanks! | 11:29 |
*** TusharTgite has quit IRC | 11:31 | |
*** Reepicheep has quit IRC | 11:47 | |
*** knomura has joined #openstack-cinder | 11:47 | |
*** Reepicheep has joined #openstack-cinder | 11:48 | |
*** dosaboy has quit IRC | 11:49 | |
*** smcginnis has quit IRC | 11:50 | |
*** dosaboy has joined #openstack-cinder | 11:50 | |
*** stand has quit IRC | 11:52 | |
*** knomura has quit IRC | 11:52 | |
*** Luzi has joined #openstack-cinder | 11:57 | |
*** smcginnis has joined #openstack-cinder | 12:07 | |
*** ChanServ sets mode: +o smcginnis | 12:07 | |
*** jv_ has joined #openstack-cinder | 12:10 | |
*** knomura has joined #openstack-cinder | 12:14 | |
*** dsariel has joined #openstack-cinder | 12:16 | |
*** ociuhandu has quit IRC | 12:18 | |
*** knomura has quit IRC | 12:18 | |
whoami-rajat | doc job failure on almost all patches, anyone has any idea? | 12:20 |
whoami-rajat | tosky: ^^ | 12:20 |
whoami-rajat | sfernand: hey, can you trigger the netapp nfs CI on this patch ? https://review.opendev.org/c/openstack/cinder/+/780700 | 12:24 |
rosmaita | whoami-rajat: sqlalchemy update | 12:25 |
whoami-rajat | oh | 12:25 |
rosmaita | https://review.opendev.org/c/openstack/cinder/+/780696 | 12:25 |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Temporary fix for docs job https://review.opendev.org/c/openstack/cinder/+/780696 | 12:26 |
rosmaita | previous patch failed requirements job ^^ | 12:26 |
whoami-rajat | rosmaita: btw the nfs tempest run is passing on my patch so it should fix the issue (still waiting for netapp job) https://review.opendev.org/c/openstack/cinder/+/780700 | 12:27 |
rosmaita | ok, cool, thanks for the quick work | 12:28 |
rosmaita | probably faster than waiting for the revert to meerge | 12:28 |
sfernand | whoami-rajat: | 12:28 |
sfernand | I've started the NetApp CI jobs, thanks for fixing that. We hit that same problem yesterday when working on another patch | 12:30 |
whoami-rajat | sfernand: yeah, i focused on testing it manually and didn | 12:37 |
whoami-rajat | didn't consider the tempest run | 12:37 |
whoami-rajat | sorry about that | 12:37 |
*** ociuhandu has joined #openstack-cinder | 12:38 | |
*** ociuhandu has quit IRC | 12:39 | |
*** ociuhandu has joined #openstack-cinder | 12:40 | |
*** smcginnis has quit IRC | 12:40 | |
*** senrique__ has joined #openstack-cinder | 12:41 | |
sfernand | no problem! | 12:43 |
*** rcernin has joined #openstack-cinder | 12:47 | |
*** rratnaka has joined #openstack-cinder | 12:50 | |
*** smcginnis has joined #openstack-cinder | 12:50 | |
*** ChanServ sets mode: +o smcginnis | 12:50 | |
*** ociuhandu has quit IRC | 12:51 | |
*** rcernin has quit IRC | 12:56 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Fix for create group from source https://review.opendev.org/c/openstack/cinder/+/780774 | 12:56 |
*** ociuhandu has joined #openstack-cinder | 13:02 | |
*** smcginnis has quit IRC | 13:12 | |
*** smcginnis has joined #openstack-cinder | 13:18 | |
*** ChanServ sets mode: +o smcginnis | 13:18 | |
whoami-rajat | sfernand: cinder-cDOT-NFS this is the netapp nfs job right? | 13:22 |
whoami-rajat | which was failing on your patch | 13:22 |
*** smcginnis has quit IRC | 13:24 | |
*** supamatt has joined #openstack-cinder | 13:29 | |
sfernand | yes | 13:32 |
whoami-rajat | ok, that's passing | 13:38 |
*** smcginnis has joined #openstack-cinder | 13:41 | |
*** ChanServ sets mode: +o smcginnis | 13:41 | |
*** pcaruana has quit IRC | 13:50 | |
*** asbishop is now known as abishop | 13:50 | |
*** sapd1 has joined #openstack-cinder | 13:51 | |
openstackgerrit | Eric Harney proposed openstack/cinder stable/victoria: Label temporary files created by image_utils https://review.opendev.org/c/openstack/cinder/+/780828 | 13:52 |
*** knomura has joined #openstack-cinder | 13:52 | |
*** yoctozepto has quit IRC | 13:53 | |
*** knomura has quit IRC | 13:57 | |
*** pcaruana has joined #openstack-cinder | 13:59 | |
*** knomura has joined #openstack-cinder | 14:14 | |
*** knomura has quit IRC | 14:18 | |
*** sapd1 has quit IRC | 14:24 | |
openstackgerrit | Fernando Ferraz Silva proposed openstack/cinder stable/victoria: NetApp SolidFire: Refactor DuplicateSfVolumeNames exception https://review.opendev.org/c/openstack/cinder/+/780829 | 14:41 |
*** sapd1 has joined #openstack-cinder | 14:45 | |
*** Luzi has quit IRC | 14:53 | |
*** udesale has quit IRC | 14:55 | |
*** sapd1 has quit IRC | 15:33 | |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Temporary fix for docs job https://review.opendev.org/c/openstack/cinder/+/780696 | 15:35 |
*** psachin has quit IRC | 15:36 | |
*** jv_ has quit IRC | 15:40 | |
*** sapd1 has joined #openstack-cinder | 15:49 | |
*** manoj_katari has joined #openstack-cinder | 15:50 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Resolve SADeprecationWarning for joinedload_all https://review.opendev.org/c/openstack/cinder/+/780755 | 15:52 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Always constraint dependencies in tox https://review.opendev.org/c/openstack/cinder/+/780907 | 15:52 |
geguileo | rosmaita: ^ that's the issue with the docs, we are not constraining our usedevelop install | 15:52 |
geguileo | that was a pita | 15:52 |
rosmaita | no kidding | 15:52 |
tosky | geguileo: no, no, that's not the direction | 15:59 |
tosky | or at least please discuss it on the list | 15:59 |
tosky | we used ot have install_command before and it was removed for a reason | 15:59 |
*** GirishChilukuri_ has joined #openstack-cinder | 16:00 | |
geguileo | tosky: well, if we run tox without constraints it's going to be hell | 16:00 |
manoj_katari | @tosky: is this the reason for zuul openstack-tox-docs continous failures today ? | 16:01 |
tosky | geguileo: is cinder a snowflake as the only project affected by this? If it's general, let's find a general solution | 16:01 |
*** GirishChilukuri_ has quit IRC | 16:01 | |
geguileo | and running docs without usedev means that it may not be using the latest code when calling the generate_driver_list.py tool | 16:01 |
geguileo | tosky: being affected may depend on many, many things | 16:01 |
tosky | I understand that, it needs usedevelop, everyone has usedevelop=True in their tox.ini, I wasn't sure | 16:01 |
*** GirishChilukuri_ has joined #openstack-cinder | 16:01 | |
geguileo | maybe they do different use of SQLA | 16:02 |
*** GirishChilukuri has quit IRC | 16:03 | |
*** vishalmanchanda has quit IRC | 16:03 | |
*** jv_ has joined #openstack-cinder | 16:04 | |
geguileo | tosky: looking at Nova tox.ini they will not have upper constraints for SQLA either when running locally, afaik | 16:04 |
geguileo | on the gate may be different if the node has cached dependencies | 16:04 |
geguileo | as those will be used instead of pulling anything new (afaik) | 16:05 |
tosky | my approval is not needed, I just feel this may be a bigger problem and may break something else, so I just disagree on calling it a stable fix | 16:05 |
geguileo | tosky: the reason why it was removed can be looked in commit a42a8e63d88b120c5aa105b14e342938f995846c | 16:05 |
geguileo | it was because we were using the default value, so it was unnecessary | 16:05 |
geguileo | but now we see that, while the old install_command, was useless, the new one makes sense | 16:06 |
geguileo | tosky: I'm all up for discussion of any and all patches :-) | 16:06 |
geguileo | I just think that it makes sense to have it there | 16:06 |
geguileo | not as a temporary fix, but a proper one | 16:06 |
*** adrianc has quit IRC | 16:07 | |
*** adrianc has joined #openstack-cinder | 16:07 | |
geguileo | tosky: and your feedback is always welcome :-) | 16:07 |
*** knomura has joined #openstack-cinder | 16:08 | |
tosky | geguileo: the tox.ini used the default value due to https://review.opendev.org/c/openstack/cinder/+/614943/ | 16:10 |
tosky | so it depends on whether lower-constraints is broken | 16:10 |
geguileo | awesome they fixed lower constraints and broke every other job | 16:11 |
geguileo | kudos | 16:11 |
*** knomura has quit IRC | 16:12 | |
geguileo | I'll update the patch to use standard install command for the lower constraints | 16:12 |
geguileo | tosky: and that's why your reviews are always welcome... because you are always right | 16:14 |
geguileo | rofl | 16:14 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Always constraint dependencies in tox https://review.opendev.org/c/openstack/cinder/+/780907 | 16:14 |
openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Resolve SADeprecationWarning for joinedload_all https://review.opendev.org/c/openstack/cinder/+/780755 | 16:14 |
geguileo | tosky: rosmaita ^ ok, changed install command for lower constraints | 16:14 |
*** Luzi has joined #openstack-cinder | 16:21 | |
*** gouthamr has left #openstack-cinder | 16:26 | |
*** gouthamr has joined #openstack-cinder | 16:26 | |
*** ociuhandu has quit IRC | 16:27 | |
*** ociuhandu has joined #openstack-cinder | 16:27 | |
zenkuro | rosmaita: hi, is there a time/possibility to squize a patch? | 16:28 |
openstackgerrit | Merged openstack/cinderlib master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/cinderlib/+/771569 | 16:30 |
*** e0ne has joined #openstack-cinder | 16:33 | |
*** pcaruana has quit IRC | 16:44 | |
*** rratnaka has quit IRC | 16:44 | |
*** pcaruana has joined #openstack-cinder | 16:44 | |
*** Luzi_ has joined #openstack-cinder | 16:46 | |
*** Luzi has quit IRC | 16:46 | |
*** jv_ has quit IRC | 16:46 | |
*** hamalq has joined #openstack-cinder | 16:48 | |
*** ociuhandu_ has joined #openstack-cinder | 16:59 | |
*** jv_ has joined #openstack-cinder | 17:02 | |
*** ociuhandu has quit IRC | 17:02 | |
*** ociuhandu_ has quit IRC | 17:03 | |
*** m75abrams has quit IRC | 17:13 | |
*** e0ne has quit IRC | 17:20 | |
*** jv_ has quit IRC | 17:21 | |
*** jv_ has joined #openstack-cinder | 17:21 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: mypy: create_volume flows https://review.opendev.org/c/openstack/cinder/+/780933 | 17:22 |
*** rratnaka has joined #openstack-cinder | 17:22 | |
*** rpittau is now known as rpittau|afk | 17:29 | |
*** ociuhandu has joined #openstack-cinder | 17:30 | |
*** Luzi_ has quit IRC | 17:31 | |
*** ociuhandu has quit IRC | 17:34 | |
*** vishalmanchanda has joined #openstack-cinder | 17:48 | |
*** lpetrut has quit IRC | 18:00 | |
*** rratnaka has quit IRC | 18:04 | |
*** lbragstad has quit IRC | 18:07 | |
*** pcaruana has quit IRC | 18:13 | |
rosmaita | https://review.opendev.org/c/openstack/cinder/+/780907/ has passed everything except a non-voting job, so it would be a good time to decide if that's how we want to fix the docs job problem | 18:14 |
rosmaita | e0ne eharney geguileo hemna_ jungleboyj smcginnis whoami-rajat lseki ^^ | 18:14 |
geguileo | rosmaita: I don't think it would be nice to give myself a +2... | 18:15 |
rosmaita | geguileo: i didn't want you to feel left out of the discussion | 18:15 |
rosmaita | but i get your point :) | 18:16 |
geguileo | rosmaita: I improved the patch from the original after tosky's insights on the lower_constraints job | 18:16 |
geguileo | rosmaita: thanks :-) | 18:16 |
rosmaita | geguileo: i saw that | 18:16 |
*** pcaruana has joined #openstack-cinder | 18:16 | |
jungleboyj | :-) I don't have a strong feeling and trust geguileo 's judgement. | 18:17 |
jungleboyj | Is there a lot of contention over this? | 18:18 |
geguileo | jungleboyj: the initial contention was tosky reminding us that install_command was removed at some point, and it should have happened for a reasong | 18:19 |
geguileo | tracing it back to breaking lower-constraints job | 18:20 |
geguileo | so I updated the patch so that lower-constraints job doesn't force upper constraints | 18:20 |
jungleboyj | Ok. Sounds good to me. | 18:21 |
rosmaita | it's just a bit weird that no one else does this | 18:21 |
rosmaita | but i think geguileo's analysis makes sense | 18:22 |
rosmaita | plus, it seems to work! | 18:22 |
geguileo | the fun part is that it's easy to check locally | 18:22 |
jungleboyj | rosmaita: Yeah, that is mostly what I am going with. :-) | 18:22 |
geguileo | you run any of the cinder jobs and you get SQLAlchemy 1.4.0 | 18:22 |
jungleboyj | Ok. I am good once Zuul reponds. | 18:24 |
rosmaita | just waiting for cinder-rally-task to complete | 18:24 |
rosmaita | zuul estimates <1 min | 18:24 |
rosmaita | https://zuul.openstack.org/status#780907 | 18:26 |
*** lbragstad has joined #openstack-cinder | 18:27 | |
zenkuro | can anybody please check: https://review.opendev.org/c/openstack/cinder/+/763760 | 18:39 |
*** GirishChilukuri_ has quit IRC | 18:39 | |
jungleboyj | rosmaita: Don't see that in the FFE list. Am I missing it? | 18:40 |
*** GirishChilukuri has joined #openstack-cinder | 18:40 | |
openstackgerrit | Merged openstack/cinder master: Always constraint dependencies in tox https://review.opendev.org/c/openstack/cinder/+/780907 | 18:48 |
manoj_katari | @core reviewers: Could you please review these IBM SVF driver minor changes on wait for a long time. We are targeting them for W-release. | 19:09 |
manoj_katari | https://review.opendev.org/c/openstack/cinder/+/765060 | 19:09 |
manoj_katari | https://review.opendev.org/c/openstack/cinder/+/753134 | 19:09 |
manoj_katari | https://review.opendev.org/c/openstack/cinder/+/771783 | 19:09 |
jungleboyj | rosmaita: If you can look at the above reviews, they have +2s from me ^^^ | 19:17 |
rosmaita | jungleboyj: if you have time to look at https://review.opendev.org/c/openstack/cinder/+/763760 , i completely missed it | 19:18 |
jungleboyj | rosmaita: Ok. :-) I will look at that if you can look at the SVF ones. | 19:19 |
jungleboyj | Please. | 19:19 |
rosmaita | it's a deal! | 19:19 |
zenkuro | \>_</ | 19:20 |
jungleboyj | (╯°□°)╯︵ ┻━┻ | 19:21 |
jungleboyj | :-) | 19:21 |
*** whoami-rajat has quit IRC | 19:26 | |
*** GirishChilukuri has quit IRC | 19:34 | |
*** tosky has quit IRC | 20:05 | |
*** tosky has joined #openstack-cinder | 20:05 | |
*** vishalmanchanda has quit IRC | 20:14 | |
*** yoctozepto has joined #openstack-cinder | 20:14 | |
*** hemna has quit IRC | 20:28 | |
*** hemna has joined #openstack-cinder | 20:29 | |
*** _pewp_ has quit IRC | 20:33 | |
*** _pewp_ has joined #openstack-cinder | 20:34 | |
jungleboyj | rosmaita: The Jovian driver patch is removing a config option without a deprecation period. That isn't allowed even if it is in a driver. Right? | 20:36 |
rosmaita | i think you are right, probably should be deprecated first | 20:39 |
rosmaita | jungleboyj: thanks for looking at that, i left a follow-up comment | 20:50 |
jungleboyj | Ok. Cool. | 20:54 |
tosky | out of curiosity: does that config option affect an hardware feature? Maybe the configuration has no effect anymore, and the usual deprecation cycle doesn't make much sense | 20:59 |
tosky | but I have no idea what which option is that and which feature it enables | 20:59 |
rosmaita | tosky: it's a retry number | 21:00 |
rosmaita | tosky: nice work with geguileo on the tox.ini change | 21:01 |
rosmaita | thanks for tracking down that change to lower-constraints | 21:01 |
rosmaita | to the job, i mean ... so both you and gorka were right! | 21:02 |
tosky | I've just complained, gorka did the proper work :) | 21:04 |
zenkuro | jungleboy: hi, regarding jovian. It have not faced a single release. So if this option get removed without getting in a single release who cares? | 21:05 |
jungleboyj | Hmmm. Good question. | 21:05 |
geguileo | tosky: preventing us from having to review another patch to fix lower constraints is a big part of the work :-) | 21:05 |
jungleboyj | So it hasn't been officially released yet, you are removing it before any customers have it? | 21:05 |
zenkuro | yep | 21:05 |
rosmaita | zenkuro: you are correct! thanks for the reminder | 21:05 |
jungleboyj | I guess it is ok then. :-) | 21:06 |
zenkuro | \>_</ hurray! | 21:06 |
jungleboyj | Ok. I have updated by vote. | 21:07 |
jungleboyj | *my | 21:07 |
openstackgerrit | Merged openstack/cinder master: Add virtualenv requirement to tox.ini https://review.opendev.org/c/openstack/cinder/+/780692 | 21:13 |
*** ajitha has quit IRC | 21:22 | |
*** manoj_katari has quit IRC | 21:31 | |
*** rcernin has joined #openstack-cinder | 22:24 | |
*** brinzhang_ has joined #openstack-cinder | 22:26 | |
*** lbragstad_ has joined #openstack-cinder | 22:29 | |
*** dosaboy_ has joined #openstack-cinder | 22:30 | |
*** lbragstad has quit IRC | 22:35 | |
*** jv_ has quit IRC | 22:35 | |
*** dosaboy has quit IRC | 22:35 | |
*** supamatt has quit IRC | 22:35 | |
*** zenkuro has quit IRC | 22:35 | |
*** brinzhang0 has quit IRC | 22:35 | |
*** zenkuro has joined #openstack-cinder | 22:37 | |
*** jv_ has joined #openstack-cinder | 22:41 | |
openstackgerrit | Merged openstack/devstack-plugin-ceph master: Set rbd default features in ceph.conf https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/778960 | 22:42 |
openstackgerrit | Merged openstack/cinder master: [SVF] Set volume IOPS based on volume size https://review.opendev.org/c/openstack/cinder/+/764804 | 23:01 |
*** zenkuro has quit IRC | 23:17 | |
*** zenkuro has joined #openstack-cinder | 23:18 | |
*** carloss has quit IRC | 23:31 | |
*** rcernin has quit IRC | 23:38 | |
*** rcernin has joined #openstack-cinder | 23:39 | |
*** dsariel has quit IRC | 23:43 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!