Wednesday, 2021-03-17

*** senrique__ has quit IRC00:05
*** tosky has quit IRC00:10
*** senrique__ has joined #openstack-cinder00:17
*** zenkuro has quit IRC00:25
*** hamalq has quit IRC00:26
*** sapd1 has quit IRC00:52
openstackgerritMerged openstack/cinder master: [IBM DS8000]: Fix compatability issue in get_host  https://review.opendev.org/c/openstack/cinder/+/76506000:52
*** n-saito has quit IRC01:20
*** lbragstad_ is now known as lbragstad01:23
*** ianychoi has joined #openstack-cinder01:24
*** ianychoi_ has quit IRC01:26
*** ajitha has joined #openstack-cinder01:30
*** n-saito has joined #openstack-cinder01:41
*** rratnaka has joined #openstack-cinder02:01
*** senrique__ has quit IRC02:03
openstackgerrit江治林 proposed openstack/python-cinderclient master: testtest  https://review.opendev.org/c/openstack/python-cinderclient/+/78099802:13
*** martinkennelly has quit IRC02:21
*** psachin has joined #openstack-cinder02:27
openstackgerrit江治林 proposed openstack/cinder master: when modify encrypted information of volume type, verify encryption id  https://review.opendev.org/c/openstack/cinder/+/78100302:42
*** GirishChilukuri has joined #openstack-cinder02:46
*** udesale has joined #openstack-cinder02:54
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.dell_emc  https://review.opendev.org/c/openstack/cinder/+/78100602:56
*** priteau has quit IRC03:03
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.fusionstorage  https://review.opendev.org/c/openstack/cinder/+/78100703:05
*** GirishChilukuri has quit IRC03:06
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.fusionstorage  https://review.opendev.org/c/openstack/cinder/+/78100703:06
*** tinwood has quit IRC03:11
*** tinwood has joined #openstack-cinder03:14
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.ibm  https://review.opendev.org/c/openstack/cinder/+/78100803:19
*** rcernin has quit IRC03:22
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.ibm  https://review.opendev.org/c/openstack/cinder/+/78100803:25
*** rcernin has joined #openstack-cinder03:33
*** rcernin has quit IRC03:41
*** rcernin has joined #openstack-cinder03:42
*** GirishChilukuri has joined #openstack-cinder03:51
openstackgerritIvan Pchelintsev proposed openstack/cinder master: Add iSCSI IPv6 support to Dell EMC XtremIO driver  https://review.opendev.org/c/openstack/cinder/+/78100903:52
*** vishalmanchanda has joined #openstack-cinder04:26
*** m75abrams has joined #openstack-cinder04:59
*** knomura has joined #openstack-cinder05:05
*** knomura has quit IRC05:16
openstackgerritGirish Chilukuri proposed openstack/cinder master: [SVF]:Storwize hyperswap volume is not deleting.  https://review.opendev.org/c/openstack/cinder/+/77178305:33
openstackgerritTushar Trambak Gite proposed openstack/cinder master: Changed whitelist to allowlist in tox  https://review.opendev.org/c/openstack/cinder/+/77157205:39
*** Luzi has joined #openstack-cinder05:44
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.inspur  https://review.opendev.org/c/openstack/cinder/+/78101205:47
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.netapp  https://review.opendev.org/c/openstack/cinder/+/78101606:02
*** dsariel has joined #openstack-cinder06:09
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.nexenta  https://review.opendev.org/c/openstack/cinder/+/78101706:10
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.solidfire  https://review.opendev.org/c/openstack/cinder/+/78101806:13
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.solidfire  https://review.opendev.org/c/openstack/cinder/+/78101806:19
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.synology  https://review.opendev.org/c/openstack/cinder/+/78102206:25
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.test.unit.volume.drivers.vmware  https://review.opendev.org/c/openstack/cinder/+/78102306:28
openstackgerritXuan Yandong proposed openstack/cinder master: remove six from cinder.transter  https://review.opendev.org/c/openstack/cinder/+/78102406:37
openstackgerritXuan Yandong proposed openstack/cinder master: remove six from cinder.transter  https://review.opendev.org/c/openstack/cinder/+/78102406:39
*** lpetrut has joined #openstack-cinder06:41
openstackgerritMerged openstack/cinder master: [DS8K]: Support revert to snapshot  https://review.opendev.org/c/openstack/cinder/+/77393706:45
openstackgerritTushar Trambak Gite proposed openstack/cinder-specs master: Changed minversion in tox to 3.18.0  https://review.opendev.org/c/openstack/cinder-specs/+/78102807:11
*** knomura has joined #openstack-cinder07:28
openstackgerritRajat Dhasmana proposed openstack/cinder master: Modify/Move project validation methods to api_utils  https://review.opendev.org/c/openstack/cinder/+/75243107:29
openstackgerritGirish Chilukuri proposed openstack/cinder master: [SVF]: Volume name is not validated for host  https://review.opendev.org/c/openstack/cinder/+/75313407:30
*** happyhemant has joined #openstack-cinder07:31
openstackgerritRajat Dhasmana proposed openstack/cinder master: Modify/Move project validation methods to api_utils  https://review.opendev.org/c/openstack/cinder/+/75243107:32
*** knomura has quit IRC07:33
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.volume.drivers  https://review.opendev.org/c/openstack/cinder/+/78103207:35
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add project validation to volume type access  https://review.opendev.org/c/openstack/cinder/+/77757407:36
openstackgerritXuan Yandong proposed openstack/cinder master: remove six of cinder.volume.drivers  https://review.opendev.org/c/openstack/cinder/+/78103207:37
*** sfernand has quit IRC07:55
*** dsariel has quit IRC08:00
*** dsariel has joined #openstack-cinder08:01
*** GirishChilukuri_ has joined #openstack-cinder08:07
*** GirishChilukuri has quit IRC08:10
*** rcernin has quit IRC08:11
*** rpittau|afk is now known as rpittau08:23
*** rratnaka14 has joined #openstack-cinder08:26
rm_workAnyone know the status on this mTLS change? Just awaiting review? https://review.opendev.org/c/openstack/python-cinderclient/+/77631108:26
rm_workMay have missed client releases (last week?) but should still be able to get it in and cut a followup maybe?08:27
*** rratnaka has quit IRC08:29
*** e0ne has joined #openstack-cinder08:48
*** knomura has joined #openstack-cinder08:50
*** knomura has quit IRC08:55
*** knomura has joined #openstack-cinder09:01
*** tosky has joined #openstack-cinder09:03
*** knomura has quit IRC09:06
*** ociuhandu has joined #openstack-cinder09:10
*** rcernin has joined #openstack-cinder09:17
*** knomura has joined #openstack-cinder09:19
*** knomura has quit IRC09:23
*** ociuhandu has quit IRC09:25
*** knomura has joined #openstack-cinder09:29
*** openstackgerrit has quit IRC09:33
*** knomura_ has joined #openstack-cinder09:34
*** knomura has quit IRC09:34
*** knomura_ has quit IRC09:34
*** knomura has joined #openstack-cinder09:35
*** knomura has quit IRC09:36
*** knomura has joined #openstack-cinder09:37
*** knomura has quit IRC09:38
*** knomura has joined #openstack-cinder09:38
*** ociuhandu has joined #openstack-cinder09:39
*** knomura_ has joined #openstack-cinder09:41
*** knomura has quit IRC09:42
*** knomura has joined #openstack-cinder09:44
*** knomura_ has quit IRC09:46
*** udesale_ has joined #openstack-cinder09:46
*** knomura has quit IRC09:48
*** rcernin_ has joined #openstack-cinder09:48
*** knomura has joined #openstack-cinder09:49
*** knomura has quit IRC09:53
*** rcernin has quit IRC09:55
*** dsariel has quit IRC09:55
*** udesale has quit IRC09:55
*** ociuhandu has quit IRC09:58
*** ociuhandu has joined #openstack-cinder10:00
*** ociuhandu has quit IRC10:16
*** happyhemant has quit IRC10:18
*** knomura has joined #openstack-cinder10:22
*** knomura has quit IRC10:26
*** ociuhandu has joined #openstack-cinder10:27
*** knomura has joined #openstack-cinder10:32
*** knomura_ has joined #openstack-cinder10:35
*** udesale__ has joined #openstack-cinder10:36
*** knomura has quit IRC10:37
*** knomura_ has quit IRC10:38
*** knomura has joined #openstack-cinder10:38
*** udesale_ has quit IRC10:38
*** knomura has quit IRC10:42
*** knomura has joined #openstack-cinder10:43
*** knomura has quit IRC10:47
rosmaitarm_work: we discussed this last week at the cinder meeting and the bug meeting: http://eavesdrop.openstack.org/meetings/cinder/2021/cinder.2021-03-10-14.01.log.html#l-64 and http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/%23openstack-cinder.2021-03-10.log.html#t2021-03-10T15:10:1910:54
rosmaitalooks like i forgot to leave a comment on your patch, so apologies for that10:54
rosmaitashort story is, we would like a spec explaining what you propose and why10:54
rosmaitasee https://docs.openstack.org/cinder/latest/contributor/contributing.html#new-feature-planning for info about proposing a spec10:55
*** knomura has joined #openstack-cinder10:56
*** knomura has quit IRC11:00
*** carloss has joined #openstack-cinder11:08
*** knomura has joined #openstack-cinder11:13
*** knomura has quit IRC11:18
*** zenkuro has joined #openstack-cinder11:22
*** knomura has joined #openstack-cinder11:24
*** priteau has joined #openstack-cinder11:26
*** knomura has quit IRC11:28
*** rcernin_ has quit IRC11:32
*** manoj_katari has joined #openstack-cinder11:35
*** ociuhandu has quit IRC11:36
*** ociuhandu has joined #openstack-cinder11:37
*** ociuhandu has quit IRC11:39
*** ociuhandu has joined #openstack-cinder11:39
*** knomura has joined #openstack-cinder11:43
*** knomura has quit IRC11:47
*** zenkuro has quit IRC11:50
*** zenkuro has joined #openstack-cinder11:50
GirishChilukuri_rosmaita: Addressed review comments for below patches11:55
GirishChilukuri_https://review.opendev.org/c/openstack/cinder/+/75313411:55
GirishChilukuri_https://review.opendev.org/c/openstack/cinder/+/77178311:55
*** takamatsu has quit IRC11:57
rosmaitaGirishChilukuri_: ack12:13
GirishChilukuri_rosmaita: Thanks12:15
*** GirishChilukuri has joined #openstack-cinder12:20
*** GirishChilukuri_ has quit IRC12:20
*** manoj_katari has quit IRC12:23
*** ociuhandu has quit IRC12:27
*** GirishChilukuri has quit IRC12:27
*** GirishChilukuri has joined #openstack-cinder12:30
*** e0ne has quit IRC12:35
*** kinpaa12389 has joined #openstack-cinder12:44
*** zenkuro has quit IRC12:49
*** zenkuro has joined #openstack-cinder12:49
*** senrique__ has joined #openstack-cinder12:54
*** ociuhandu has joined #openstack-cinder12:58
*** ociuhandu has quit IRC13:03
*** GirishChilukuri has quit IRC13:14
*** GirishChilukuri has joined #openstack-cinder13:19
*** knomura has joined #openstack-cinder13:28
*** knomura has quit IRC13:32
*** almir-okato has joined #openstack-cinder13:36
*** sapd1 has joined #openstack-cinder13:36
*** knomura has joined #openstack-cinder13:44
*** GirishChilukuri has quit IRC13:45
*** e0ne has joined #openstack-cinder13:46
*** knomura has quit IRC13:46
*** GirishChilukuri has joined #openstack-cinder13:46
*** knomura has joined #openstack-cinder13:46
*** knomura has quit IRC13:50
*** openstackgerrit has joined #openstack-cinder13:52
openstackgerritEric Harney proposed openstack/cinder master: doc: Remove cryptsetup reference for compute setup  https://review.opendev.org/c/openstack/cinder/+/78110113:52
*** TusharTgite has joined #openstack-cinder13:53
rosmaitaCourtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC13:57
rosmaitajungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso hemna ^^13:57
*** senrique__ is now known as enriquetaso13:58
enriquetasothanks!13:58
*** ociuhandu has joined #openstack-cinder13:59
*** sfernand has joined #openstack-cinder14:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Fix automatic quota sync for migrating volumes  https://review.opendev.org/c/openstack/cinder/+/77818214:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Add quota utils to cinder-manage  https://review.opendev.org/c/openstack/cinder/+/77695114:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Remove unused quota python classes  https://review.opendev.org/c/openstack/cinder/+/77801714:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Quota: Fix until_refresh config changes  https://review.opendev.org/c/openstack/cinder/+/77821014:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Remove nested quota leftovers  https://review.opendev.org/c/openstack/cinder/+/77971714:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Fix quota usage duplicate entries  https://review.opendev.org/c/openstack/cinder/+/77994614:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Fix automatic quota sync for temporary volumes  https://review.opendev.org/c/openstack/cinder/+/78110414:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Update cinder manage quota commands  https://review.opendev.org/c/openstack/cinder/+/78110514:00
openstackgerritGorka Eguileor proposed openstack/cinder master: Prevent quota and reservations to go into negative  https://review.opendev.org/c/openstack/cinder/+/78110614:01
openstackgerritGorka Eguileor proposed openstack/cinder master: Quota: Fix multiple race conditions  https://review.opendev.org/c/openstack/cinder/+/78110714:01
geguileorosmaita: thanks14:01
rosmaitai think geguileo has fixed quotas!14:01
geguileorosmaita: I wish!!14:02
*** knomura has joined #openstack-cinder14:06
*** rratnaka14 has quit IRC14:08
*** rratnaka has joined #openstack-cinder14:09
rosmaitageguileo: well, at least you are leaving them better off than how you found them14:09
*** ociuhandu has quit IRC14:09
*** knomura has quit IRC14:09
*** knomura has joined #openstack-cinder14:10
*** ociuhandu has joined #openstack-cinder14:11
*** knomura has quit IRC14:11
*** knomura has joined #openstack-cinder14:11
geguileothat's the idea14:13
*** knomura has quit IRC14:13
*** knomura_ has joined #openstack-cinder14:13
*** ociuhandu has quit IRC14:16
*** knomura_ has quit IRC14:18
*** ociuhandu has joined #openstack-cinder14:25
*** vishalmanchanda has quit IRC14:25
openstackgerritMerged openstack/cinder master: API validation: Use cinder_host for services checks  https://review.opendev.org/c/openstack/cinder/+/77747014:28
*** whoami-rajat_ has joined #openstack-cinder14:30
*** vishalmanchanda has joined #openstack-cinder14:35
*** abhishekk is now known as abhishekk|afk14:36
*** rratnaka14 has joined #openstack-cinder14:59
sfernandrosmaita: are we going to have a etherpad with the review priorities for RC1?15:01
kinpaa12389can I continue here ?15:01
rosmaitakinpaa12389: wait for the meeting to start15:01
rosmaitasfernand: not sure, i have been focused on features15:02
rosmaitaonce the RC is cut, though, we will be looking for release-critical bugs15:02
*** rratnaka has quit IRC15:02
openstackgerritMerged openstack/cinder master: [SVF]:Storwize hyperswap volume is not deleting.  https://review.opendev.org/c/openstack/cinder/+/77178315:02
enriquetasohi15:02
rosmaitahello15:03
enriquetasosfernand: https://etherpad.opendev.org/p/cinder-wallaby-features15:03
*** lpetrut has quit IRC15:03
enriquetasoi think that's the etherpad15:03
openstackgerritMerged openstack/cinder master: [SVF]: Volume name is not validated for host  https://review.opendev.org/c/openstack/cinder/+/75313415:03
rosmaitai think sfernand is asking about follow-up bugs15:03
sfernandI was thinking on a etherpad for follow ups and critical fixes15:03
sfernandyep15:03
enriquetasooh, i don't have that etherpad i think... OK, i'm going to start the Cinder Bug meeting15:04
eharneywe should just use gerrit review-priority for rc1 bugs15:04
sfernandjust worried with follow ups that we can miss the deadline15:04
rosmaitasfernand: that is a good concern15:04
rosmaitaeharney: i think only cores can set the priority15:05
rosmaitai think sfernand wants a place for cores to look to decide if they should up the priority on patches15:05
eharneyah15:05
rosmaitaand people really seem to like working with etherpads15:05
*** TusharTgite has quit IRC15:06
sfernandyep15:06
enriquetaso#startmeeting cinder_bs15:06
openstackMeeting started Wed Mar 17 15:06:24 2021 UTC and is due to finish in 60 minutes.  The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot.15:06
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:06
*** openstack changes topic to " (Meeting topic: cinder_bs)"15:06
openstackThe meeting name has been set to 'cinder_bs'15:06
enriquetaso#topic roll call15:06
*** openstack changes topic to "roll call (Meeting topic: cinder_bs)"15:06
enriquetasohi :P15:06
kinpaa12389hi15:06
rosmaitao/15:06
enriquetasoEtherpad:15:06
enriquetaso#link https://etherpad.opendev.org/p/cinder-bug-squad-meeting15:06
enriquetasoFull list of bugs:15:07
enriquetaso#link http://lists.openstack.org/pipermail/openstack-discuss/2021-March/021135.html15:07
enriquetaso#topic bug_1:"SADeprecationWarning: The joinedload_all() function is deprecated, and will be removed in a future release. Please use method chaining with joinedload() instead"15:07
*** openstack changes topic to "bug_1:"SADeprecationWarning: The joinedload_all() function is deprecated, and will be removed in a future release. Please use method chaining with joinedload() instead" (Meeting topic: cinder_bs)"15:07
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/183216415:08
openstackLaunchpad bug 1832164 in Cinder "SADeprecationWarning: The joinedload_all() function is deprecated, and will be removed in a future release. Please use method chaining with joinedload() instead" [Critical,In progress] - Assigned to Gorka Eguileor (gorka)15:08
*** ociuhandu has quit IRC15:08
enriquetaso wanted to name the bug because it is in critical condition but it is already handled by Gorka.15:08
zenkurorosmaita: thanks for your detailed comments on CI, Im applying fixes right now15:08
rosmaitathat one illustrates a point eric made last week15:08
rosmaitanamely, we need to review some old bugs15:08
enriquetasorosmaita++15:09
rosmaitaenriquetaso: i can make it un-critical15:09
enriquetasoMy idea was to do an update of the old bugs but I could not do it for this week, I will prepare it for the next and maybe some for the PTG if they are important.15:09
rosmaitayeah, i am not saying that you personally need to do it15:09
enriquetasoFix proposed:15:09
rosmaitajust that "we" need to do it15:09
enriquetaso#link https://review.opendev.org/c/openstack/cinder/+/78075515:09
enriquetasorosmaita sure15:09
rosmaitaso the story is that sqlalchemy 1.4.0 drops that joinedload_all call15:10
rosmaitaand 1.4.0 was released on monday15:10
rosmaitaand our docs job was using it and breaking15:10
rosmaitain the mean time, 1.4.0 is not included in upper-constraints15:10
rosmaitaour doc job was ignoring upper constraints (sort of)15:10
rosmaitaso, we have fixed our jobs to respect upper constraints15:11
rosmaitawhat i am saying is that it is important that we fix this, because we will be broken in xena15:11
rosmaitabut it is not as critical as i thought yesterday15:11
rosmaitaand now i will shut up15:11
enriquetasoohh15:11
eharneywell, it's a pretty simple change15:11
enriquetasothanks rosmaita for the details \o/15:12
enriquetasoThe following bug is already assigned and is being worked on, but I wanted to highlight it in case someone is using quotas.15:12
enriquetaso#topic bug_2: "Automatic quota refresh counting temporary volumes"15:12
*** openstack changes topic to "bug_2: "Automatic quota refresh counting temporary volumes" (Meeting topic: cinder_bs)"15:12
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/191916115:12
openstackLaunchpad bug 1919161 in Cinder "Automatic quota refresh counting temporary volumes" [High,New] - Assigned to Gorka Eguileor (gorka)15:13
enriquetaso'When using the automatic quota refresh via `until_refresh` and `max_age` configuration options the calculated quota usage by the refresh will not be correct if there are temporary volumes (such as those created from snapshots for backups)'15:13
enriquetasoI couldn't find a patch for ^ so I think it doesn't have one yet15:13
enriquetasoMoving on... I need an opinion on next one:15:14
enriquetaso#topic bug_3: "id of encryption for volume type not verified"15:14
*** openstack changes topic to "bug_3: "id of encryption for volume type not verified" (Meeting topic: cinder_bs)"15:14
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/191887915:14
openstackLaunchpad bug 1918879 in Cinder "id of encryption for volume type not verified" [Undecided,New]15:14
enriquetasoThe description of the bug just says "when try to update encryption for a given volume type, this api received one parameter is id, but it is not used,therefore, when it is a wrong encryption id, the api layer not check".15:14
enriquetaso I guess the bug is incomplete, I'd like to ask about steps of how to reproduce the problem and probably if It's using LUKS or something else. However, I've never updated a volume type before so I'd like to be double sure about what to ask. 15:14
eharneyproably https://review.opendev.org/c/openstack/cinder/+/77943615:14
enriquetasogreat15:15
rosmaitaenriquetaso: i think start by asking exactly what api call, what they are passing in the request, and also what release they are talking about15:16
enriquetaso#action enriquetaso: ask for more detailed information15:18
enriquetasonext one:15:18
enriquetaso#topic bug_4: "ensure_export model_update ignored"15:19
*** openstack changes topic to "bug_4: "ensure_export model_update ignored" (Meeting topic: cinder_bs)"15:19
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/191844915:19
openstackLaunchpad bug 1918449 in Cinder "ensure_export model_update ignored" [Wishlist,Incomplete]15:19
enriquetaso"The volume manager calls the driver's ensure_export() at startup time. There are several volume drivers that return a model_update from ensure_export, but the volume driver ignores that model_update."15:19
enriquetasoI set the importance to wishlist, should I change it to medium?15:20
eharneythis still needs some justification that it is really a bug, and we need a discussion/decision about whether drivers should really be returning updates from ensure_export calls15:20
eharneylikely to end up as a ptg discussion i guess15:21
enriquetasoYes, please read Eric's comment15:21
eharneybefore we resolve this bug, we really need to resolve: "how exactly does the ensure_export driver API behave?" which seems to be up in the air a bit15:21
rosmaitahttps://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L143015:22
*** abhishekk|afk is now known as abhishekk15:22
rosmaitaso the other ones explicitly say " can optionally return a dict of changes", this one does not15:22
eharneyright, and we have had code for ages that does not accept a return dict from it15:23
eharneyso it seems reasonable to start at the idea that it probably shouldn't be updating things that require it to return a dict, etc15:23
rosmaitai agree15:23
eharneywhich goes back to the questions i was asking before: why exactly should we _start_ doing that?  still unclear15:23
*** ociuhandu has joined #openstack-cinder15:24
enriquetasoso, it's a good topic for the next PTG15:24
enriquetasoOK..15:25
enriquetaso#topic Open Discussion15:25
*** openstack changes topic to "Open Discussion (Meeting topic: cinder_bs)"15:25
kinpaa12389https://bugs.launchpad.net/cinder/+bug/129813515:25
openstackLaunchpad bug 1298135 in Cinder "Cinder should handle token expiration for long ops" [Medium,Confirmed]15:25
kinpaa12389can we discuss this ?15:25
enriquetasosure15:25
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/129813515:26
enriquetaso"Cinder should handle token expiration for long ops"15:26
kinpaa12389so cinder <-> nova and cinder <-> glance support service_token15:26
kinpaa12389cinder <->swift does not..15:26
kinpaa12389so I added that support and sent service_token to swift, modified swiftclient to consider session to talk with keystone middleware.15:27
kinpaa12389however this does not work. and token expiry trigger 401 Error.15:27
eharneyi'd like to understand why it does not15:27
kinpaa12389the swift proxy-server validates token for each backup chunk and it talks with keystone middleware to validate token.. This report failure as invalid token because its expired.15:28
* enriquetaso likes the tag 'bugsmash' :P15:28
*** ociuhandu has quit IRC15:28
kinpaa12389So, I see two ways to solve it:15:29
kinpaa123891) Either patch both Cinder and Swift to support service_auth and its tokens.15:29
kinpaa123892) Or use Keystone trust and refresh tokens like Glance already does for long running image uploads.15:29
eharneymy general sense is that this shouldn't require patching Cinder and Swift15:30
*** ociuhandu has joined #openstack-cinder15:30
kinpaa12389eharney can you try this experiment. may be I am doing incorrect steps.15:30
rosmaitai'm not sure what the current status of keystone trusts is15:30
eharneyi'm not sure that keystone trusts are needed for this15:30
eharneyi don't think we use trusts for service tokens used to talk to nova from cinder, do we?15:31
kinpaa12389no trusts only used for glance <->swift15:31
kinpaa12389its not in cinder15:31
kinpaa12389ok for option 1.. add expiration in keystone.conf e.g. 100 seconds and try to upload backup of 2GB in swift.15:32
eharneyi think there's more to it than that15:32
rosmaitaok, so that's a problem right there15:32
eharneyi.e. the details in  https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html15:32
rosmaitathe service tokens also expire15:32
kinpaa12389right.15:32
kinpaa12389forgot to mention15:32
kinpaa12389u need to add [service_user] section and respective support in cinder/backup/drivers/swift.py15:33
kinpaa12389please update bug if it works for anyone whoever can try.15:33
enriquetasoOK, i need to end the meeting15:34
enriquetasothe last update was in 201915:35
rosmaitaoh meant to mention this one: https://bugs.launchpad.net/oslo.db/+bug/181419915:36
openstackLaunchpad bug 1814199 in Cinder "soft_delete is wrong" [High,In progress] - Assigned to Gorka Eguileor (gorka)15:36
enriquetasosure15:36
rosmaitathis is another old one that gorka has a patch up for15:36
enriquetaso#link https://review.opendev.org/c/openstack/cinder/+/77697415:36
rosmaitaso there's probably not much to say about it15:37
enriquetasoFix proposed ^15:37
rosmaitaother than i promised gorka that i would review it15:37
enriquetaso#action review https://review.opendev.org/c/openstack/cinder/+/77697415:37
rosmaitathanks!15:37
rosmaitait's a bit more complicated than that other sqlalchemy patch15:37
enriquetasoI'll try to reproduce the bug kinpaa12389, but i'm not familiar with the topic15:38
*** ociuhandu has quit IRC15:38
enriquetasorosmaita++15:39
rosmaitakinpaa12389: you may not see much action on that until after RC-time15:39
rosmaitawe kinda have our hands full at the moment15:39
enriquetasotrue..15:39
enriquetasoOK, thank you all!15:39
enriquetaso#endmeeting15:40
*** openstack changes topic to "The Block Storage Project | https://wiki.openstack.org/wiki/Cinder | https://tiny.cc/CinderPriorities"15:40
openstackMeeting ended Wed Mar 17 15:40:00 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:40
openstackMinutes:        http://eavesdrop.openstack.org/meetings/cinder_bs/2021/cinder_bs.2021-03-17-15.06.html15:40
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/cinder_bs/2021/cinder_bs.2021-03-17-15.06.txt15:40
openstackLog:            http://eavesdrop.openstack.org/meetings/cinder_bs/2021/cinder_bs.2021-03-17-15.06.log.html15:40
rosmaitai never answered sfernand's question about feature follow-up bugs15:40
enriquetaso:P15:40
kinpaa12389ok15:40
rosmaitai think i will take enriquetaso's advice and say add follow=up bugs to https://etherpad.opendev.org/p/cinder-wallaby-features15:40
sfernandok that makes sense15:41
rosmaitacool15:43
*** psachin has quit IRC15:51
rosmaitazenkuro: ack ... feel free to ping me when your CI is ready15:52
*** josephillips has joined #openstack-cinder15:52
*** abishop_ has joined #openstack-cinder15:54
*** m75abrams has quit IRC15:54
*** abishop has quit IRC15:57
*** abishop_ is now known as abishop15:58
*** lpetrut has joined #openstack-cinder15:59
*** Luzi has quit IRC16:03
*** ociuhandu has joined #openstack-cinder16:03
*** ociuhandu_ has joined #openstack-cinder16:04
*** ociuhandu has quit IRC16:04
*** lpetrut has quit IRC16:12
*** kinpaa12389 has quit IRC16:13
*** hamalq has joined #openstack-cinder16:31
*** knomura has joined #openstack-cinder16:40
*** rratnaka has joined #openstack-cinder16:41
*** rratnaka14 has quit IRC16:44
*** knomura has quit IRC16:44
openstackgerritMerged openstack/os-brick stable/train: Add oslo.context dependency  https://review.opendev.org/c/openstack/os-brick/+/77234716:54
*** ociuhandu_ has quit IRC16:57
*** ociuhandu has joined #openstack-cinder16:58
*** ociuhandu has quit IRC17:01
*** ociuhandu has joined #openstack-cinder17:01
*** rratnaka has quit IRC17:03
*** rpittau is now known as rpittau|afk17:08
openstackgerritMerged openstack/cinder master: NFS: Fix for groups and cloning  https://review.opendev.org/c/openstack/cinder/+/78070017:13
openstackgerritMerged openstack/cinder master: Add QoS Suport for Pure Storage  https://review.opendev.org/c/openstack/cinder/+/72726717:14
*** knomura has joined #openstack-cinder17:16
openstackgerritMerged openstack/cinder master: NetApp ONTAP: Implement FlexGroup pool  https://review.opendev.org/c/openstack/cinder/+/77671317:16
*** dosaboy_ is now known as dosaboy17:16
*** knomura has quit IRC17:20
*** ociuhandu has quit IRC17:23
*** GirishChilukuri has quit IRC17:39
*** e0ne has quit IRC17:41
*** zenkuro has quit IRC17:50
*** zenkuro has joined #openstack-cinder17:50
*** udesale__ has quit IRC17:59
openstackgerritMerged openstack/cinder master: Add support for consistency groups in the Nimble Storage driver  https://review.opendev.org/c/openstack/cinder/+/77888618:07
openstackgerritMerged openstack/cinder master: Resolve SADeprecationWarning for joinedload_all  https://review.opendev.org/c/openstack/cinder/+/78075518:08
*** whoami-rajat_ is now known as whoami-rajat18:18
*** josephillips has quit IRC18:49
*** josephillips has joined #openstack-cinder18:52
*** rcernin_ has joined #openstack-cinder19:26
*** rcernin_ has quit IRC19:32
*** vishalmanchanda has quit IRC19:35
*** gmann is now known as gmann_afk19:41
*** rcernin_ has joined #openstack-cinder19:57
*** rcernin_ has quit IRC20:02
*** rcernin_ has joined #openstack-cinder20:32
*** rcernin_ has quit IRC20:37
zenkurorosmaita: hi, can you please explain more about conflict related to support-matrix.ini?20:39
rosmaitazenkuro: i'm just assuming that's where it will be, because no one else is touching the other files!20:39
zenkurorosmaita: you are saying that there will be a conflict that I will have to resolve once I pass review?20:40
*** whoami-rajat has quit IRC20:40
rosmaitaseveral people have modified the support matrix, so what's probably happening is that git can't find a common ancestor between your change and theirs, and will want you to fix it manually20:40
rosmaitazenkuro: yes, update your local repository and then rebase your change on master20:41
rosmaitai think git will tell you there are conflicts in support-matrix.ini that you need to fix20:41
zenkurohm, okey. the final deadline is on the next week right? So I can apply your propositions and work on resolving the conflict20:42
rosmaitawell, the deadline for this is friday (this friday)20:42
rosmaitaso resolve the conflict now and git-review this patch20:43
rosmaitaand the followups can be done next week (before thursday)20:43
zenkurogot it20:44
rosmaitathe key thing is resolving the merge conflict and getting the CI passed20:44
rosmaitayeah, hope i wasn't confusing there20:44
*** rcernin_ has joined #openstack-cinder20:50
rm_workrosmaita: ok, I'll read through those today, I just didn't think this was anything past a bugfix, which last I checked didn't need specs or anything :D but can do that if people think it's a bigger deal20:52
rosmaitarm_work: maybe i have you confused with someone else, are you talking about https://review.opendev.org/c/openstack/cinder/+/763760 ?20:54
rm_workNo20:55
rm_workclient mTLS bug20:55
rosmaitaoh, ok20:55
rm_workYou linked the right conversations20:55
rm_workWhich I did just read20:55
rosmaitagotcha, that was like 8 hours ago, sorry20:55
rosmaitayeah, it seems more like a feature than a bugfix20:56
rm_workIt looks like people are confused? mTLS is already supposed to be supported by everything across all clients. There were like two instances with edge cases, here and manila. We fixed both.20:56
rm_workVery minor issues where the client didn't properly pass a couple of vars or didn't use keystoneauth correctly20:57
rosmaitado you have the bug link handy?20:57
rm_workhttps://bugs.launchpad.net/python-cinderclient/+bug/191599620:58
openstackLaunchpad bug 1915996 in python-cinderclient "Support passing client certificates for mTLS connections" [Medium,In progress] - Assigned to Sri Harsha mekala (harshayahoo)20:58
rm_workit's worth mentioning for context I guess that this is the ONLY outstanding bug with mTLS across all of OSC20:59
rm_workthe entirety of OSC supports mTLS, and 95% of glanceclient does21:00
zenkurorosmaita: yah, got it. My ci failed on merge.21:00
rm_workthe issue is in this one spot where someone didn't properly pass the cert var which is expected by keystoneauth1 (and normally handled automagically internally)21:01
rm_workI don't quite understand how this would be filed as a "feature", mTLS support was done many cycles ago as part of the keystone-session adoption, just apparently not tested in glanceclient21:02
*** rcernin_ has quit IRC21:04
rm_workThe meat of the change is like 9 lines here: https://review.opendev.org/c/openstack/python-cinderclient/+/776311/18/cinderclient/client.py21:05
rm_workwhich are almost entirely just passing an extra var21:05
rosmaitaok, i think we misunderstood what you were proposing21:06
rm_workI apologize that I was not able to make it to the meeting originally so I could have cleared this up :P21:06
rosmaitathat's ok, and to be honest, we are swamped with reviews right now and were looking for any excuse to put another one off to the future21:07
rm_workwe've tested this internally (where we have turned on mTLS as fully enforced across all API endpoints) and with this patch everything is good21:08
rm_workI think as far as reviews go, this is a pretty trivial one, fortunately :P21:08
*** rcernin_ has joined #openstack-cinder21:09
*** rcernin_ has quit IRC21:15
rosmaitai guess the main problem is that the bugs and commit messages talk about not supporting TLS, which i am pretty sure we do, whereas what is missing is mtls, which you want to add21:16
rosmaitais that correct?21:16
rosmaitazenkuro: yeah, my point was don't freak out if the conflict resolution removes your +2s, it should be an easy re-review21:20
zenkuroyh, sure. Any way thanks for explaining. so I will NO try to add some new features in this patch =)21:21
rosmaitaright!21:21
rm_workhmm yeah possibly the original author missed the "m"21:32
rm_workthe bug report is titled with mTLS tho?21:33
rm_workand it says mTLS in the description of the ticket21:33
rosmaitarm_work: well, it would help if you could correct those and supply the context that mtls is already supported (almost) everywhere ... was there a community goal or something that we missed?21:34
rm_work^^ so again, having just looked at them, I don't see what you're talking about21:35
rm_workmTLS is mentioned as far as I see21:35
rm_workhttps://bugs.launchpad.net/python-cinderclient/+bug/191599621:35
openstackLaunchpad bug 1915996 in python-cinderclient "Support passing client certificates for mTLS connections" [Medium,In progress] - Assigned to Sri Harsha mekala (harshayahoo)21:35
rm_worksee title ^^21:35
rosmaitasure, and "support x" sounds like a feature21:37
rosmaitaand "Cinder request to glance does not support TLS" sounds like an incorrect statement21:37
rm_workin-so-much as the rest of OSC "supports" mTLS :P21:37
rm_workwhere is that?21:38
rosmaitahttps://bugs.launchpad.net/cinder/+bug/191779721:38
openstackLaunchpad bug 1917797 in Cinder "Cinder request to glance does not support TLS" [Low,Opinion]21:38
rm_workhmmm21:38
rm_workthat's not the bug linked to the patch i mentioned21:39
rosmaitahttps://review.opendev.org/c/openstack/cinder/+/778768 says it closes that bug21:40
rm_workthis is the patch I am interested in: https://review.opendev.org/c/openstack/python-cinderclient/+/77631121:40
rosmaitamaybe i have too many windows open21:40
rm_workyeah we may be talking across each other a bit :P21:41
rm_worki don't think i was aware there was another issue21:41
*** rcernin_ has joined #openstack-cinder21:41
rm_workthough Hamza (the other bug author) is in my org, lol21:41
rm_worklet me look into whatever the heck that is21:41
rosmaitai guess i found it here: https://review.opendev.org/c/openstack/cinder/+/77876821:42
rosmaitasorry, bad paste21:42
rosmaitahttps://bugs.launchpad.net/python-cinderclient/+bug/1915996/comments/321:42
openstackLaunchpad bug 1915996 in python-cinderclient "Support passing client certificates for mTLS connections" [Medium,In progress] - Assigned to Sri Harsha mekala (harshayahoo)21:42
rm_workhmmm21:42
rm_workinteresting21:43
rm_workyeah, it's possible *hamza's* bug is missing the "m" in TLS21:43
rm_workobviously it works for https endpoints already21:43
rm_workI will ask him to edit the title to say "mTLS" instead of "TLS" because that is wrong21:43
rm_workah I have the ability to fix that21:44
rm_workdone21:44
openstackgerritAdam Harwell proposed openstack/cinder master: Support mTLS when calling the glance API  https://review.opendev.org/c/openstack/cinder/+/77876821:48
rm_workupdated the patch title as well21:48
rm_workI continue to believe this absolutely qualifies as a *bug*, not a new feature21:49
rosmaitayeah, after your explanation, i think you have a point21:59
rosmaitaso the minor cleanup in the commit messages and bug title should help a lot21:59
rosmaitawe (or at least me) weren't aware that mTLS was supported almost everywhere in openstack22:00
rosmaitaso don't worry about the spec, the bugs & patches should be fine22:00
rm_workyeah, I hope the tiny patches should speak for themselves now that that's more clear :)22:09
*** gmann_afk is now known as gmann22:39
*** carloss has quit IRC23:27
openstackgerritAndrei proposed openstack/cinder master: JovianDSS: add certs and snapshot restore  https://review.opendev.org/c/openstack/cinder/+/76376023:29
*** ajitha has quit IRC23:40
*** sapd1 has quit IRC23:56
*** hamalq has quit IRC23:57
*** hamalq has joined #openstack-cinder23:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!