| *** elodilles is now known as elodilles_afk | 08:10 | |
| opendevreview | Merged openstack/cinder master: image_utils: Remove unused _validate_file_format method https://review.opendev.org/c/openstack/cinder/+/788311 | 08:30 |
|---|---|---|
| opendevreview | Merged openstack/cinderlib master: Remove reliance on embedded imports https://review.opendev.org/c/openstack/cinderlib/+/787180 | 08:30 |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Improve error handling around deletes https://review.opendev.org/c/openstack/cinder/+/796286 | 08:44 |
| *** geguileo is now known as Guest2379 | 10:21 | |
| *** bhagyashris_ is now known as bhagyashris | 10:27 | |
| *** Guest2379 is now known as geguileo | 10:27 | |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Improve error handling around deletes https://review.opendev.org/c/openstack/cinder/+/796286 | 10:45 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: image_utils https://review.opendev.org/c/openstack/cinder/+/774286 | 12:59 |
| *** elodilles_afk is now known as elodilles | 13:04 | |
| opendevreview | Eric Harney proposed openstack/cinder-specs master: Snapshot attached volumes w/o force flag https://review.opendev.org/c/openstack/cinder-specs/+/781914 | 13:10 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: create_volume flows https://review.opendev.org/c/openstack/cinder/+/780933 | 13:27 |
| opendevreview | Sean McGinnis proposed openstack/cinder master: Address new hacking enforcement https://review.opendev.org/c/openstack/cinder/+/757908 | 13:42 |
| opendevreview | Eric Harney proposed openstack/os-brick master: encryptors: Remove workaround for bug #1633518 https://review.opendev.org/c/openstack/os-brick/+/791270 | 13:45 |
| opendevreview | Eric Harney proposed openstack/cinder master: Update decode_cipher doc text about encryption ciphers https://review.opendev.org/c/openstack/cinder/+/796680 | 13:56 |
| rosmaita | Courtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:58 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso hemna ^^ | 13:58 |
| enriquetaso | thanks rosmaita | 13:59 |
| rosmaita | :) | 13:59 |
| opendevreview | Sean McGinnis proposed openstack/cinder master: Address new hacking enforcement https://review.opendev.org/c/openstack/cinder/+/757908 | 14:04 |
| opendevreview | Tom Barron proposed openstack/cinder master: Rename db implementation API extra specs method https://review.opendev.org/c/openstack/cinder/+/796113 | 14:05 |
| opendevreview | Tom Barron proposed openstack/cinder master: Don't drop group type extra specs at DB layer https://review.opendev.org/c/openstack/cinder/+/796114 | 14:06 |
| *** geguileo is now known as Guest2396 | 14:32 | |
| *** Guest2396 is now known as geguileo | 14:36 | |
| opendevreview | Ivan Pchelintsev proposed openstack/cinder master: Fix typo in Dell EMC Unity driver documentation https://review.opendev.org/c/openstack/cinder/+/796685 | 14:38 |
| whoami-rajat | rosmaita: hey, i was looking at gate failures on the etherpad, 3/4 issues are not related to cinder and the one related is lvdisplay (added c-vol error trace there) which is known? | 14:45 |
| rosmaita | whoami-rajat: yeah, let's keep track -- if most of them aren't cinder, that would be good to know! | 14:50 |
| whoami-rajat | ok | 14:52 |
| enriquetaso | #startmeeting cinder_bs | 15:00 |
| opendevmeet | Meeting started Wed Jun 16 15:00:32 2021 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'cinder_bs' | 15:00 |
| enriquetaso | Hell | 15:00 |
| enriquetaso | Hello, welcome to the cinder bug meeting. | 15:00 |
| rosmaita | o/ | 15:00 |
| enriquetaso | #topic bug_1: 'LVM Critical CI problems?' | 15:01 |
| enriquetaso | From cinder meeting early : | 15:01 |
| enriquetaso | <eharney> we should probably write a new bug for retrying all of the other lvm commands that can segfault that weren't covered by 1901783, since that bug already has backports spanning a few branches: | 15:01 |
| enriquetaso | What are the topics to cover in the new bug reports?- LVM delete volumes: we have https://bugs.launchpad.net/cinder/+bug/1901783/ . Should I reopen the bug or should I wait? | 15:01 |
| rosmaita | looking | 15:02 |
| eharney | that bug already has patches shipped across a handful of branches which are helpful, so we shouldn't reopen it | 15:02 |
| eharney | we need a broader bug to cover the other various lvm calls we make that also occasionally crash | 15:02 |
| rosmaita | eharney: i lost my link to your patch | 15:03 |
| rosmaita | https://review.opendev.org/c/openstack/cinder/+/772126 | 15:03 |
| eharney | well i wrote https://review.opendev.org/c/openstack/cinder/+/772126 but that basically isn't helpful for this particular fix | 15:03 |
| rosmaita | oh | 15:03 |
| enriquetaso | calls like create vol - create/delete snap - create/delete backup eharney ? | 15:03 |
| eharney | the hope was that calling lvdisplay w/ --readonly would avoid where it crashes, but it crashes anyway | 15:04 |
| eharney | enriquetaso: everything that calls lvdisplay from cinder/brick/local_dev/lvm.py to start | 15:04 |
| eharney | also calls to lvdisplay from os_brick/local_dev/lvm.py | 15:04 |
| eharney | that's 7 methods or so just for lvdisplay | 15:05 |
| enriquetaso | cool | 15:05 |
| eharney | we know this hits calls to "lvs" and "lvdisplay", i don't know if it also will hit "vgs" and "lvcreate" etc or not | 15:05 |
| eharney | i think we can implement the retry for lvs/lvdisplay and see what else shows up | 15:06 |
| rosmaita | so is the theory that "lvdisplay --readonly" works, we just don't have the readonly flag in enough places? | 15:06 |
| eharney | my guess was that it would help, but it didn't help | 15:07 |
| eharney | i just think we should do it for reasons unrelated to this bug so the patch is still up | 15:07 |
| eharney | (should probably remove the Related-Bug tag) | 15:07 |
| rosmaita | yeah, that would help | 15:07 |
| eharney | what i mean is, i saw lvdisplay also crash w/ the --readonly flag at some point after i submitted it | 15:08 |
| rosmaita | i agree it makes sense to use readonly if that's all we need | 15:08 |
| enriquetaso | #action(enriquetaso): check if this hits vgs and lvcreate as well. | 15:09 |
| eharney | so we need to replicate https://review.opendev.org/c/openstack/cinder/+/783660 for lvs/lvdisplay calls | 15:10 |
| eharney | and then look at the lvm code and see what else calls get_lv_info | 15:10 |
| opendevreview | Eric Harney proposed openstack/cinder master: LVM: Use --readonly for lvdisplay in lv_has_snapshot https://review.opendev.org/c/openstack/cinder/+/772126 | 15:11 |
| enriquetaso | OK, sounds like a plan | 15:12 |
| enriquetaso | i can do the replication if nobody is working on that already | 15:13 |
| eharney | i think nobody is | 15:13 |
| rosmaita | not me! | 15:14 |
| enriquetaso | #action(enriquetaso): replicate https://review.opendev.org/c/openstack/cinder/+/783660 for lvs/lvdisplay calls and then look at the lvm code and see what else calls get_lv_info | 15:14 |
| enriquetaso | great | 15:14 |
| enriquetaso | moving on... | 15:14 |
| enriquetaso | Cinder has 3 reported bugs related to documentation, there's two I'd like to talk about very quick: | 15:14 |
| eharney | also, elastic recheck queries for code: 139 ... | 15:14 |
| enriquetaso | should I track them as well? I didn't understand that part in the cinder meeting earlier | 15:15 |
| enriquetaso | understood* | 15:15 |
| eharney | well i think a few people have spent time rediscovering this issue where lvm tools crash | 15:16 |
| eharney | the premise of the elastic recheck system is that we can avoid that by just identifying long-occurring known failures like this automatically | 15:16 |
| rosmaita | did melanie have a link to a query in the original bug? | 15:18 |
| eharney | there are a couple of queries in there that examine syslog for crashes but i suspect we actually want to catch it from the cinder volume log | 15:18 |
| eharney | it will still crash and show up in syslog with our retry fixes | 15:19 |
| eharney | so using those queries would result in unrelated failures being tagged as this... | 15:20 |
| enriquetaso | Any other considerations for this topic? | 15:21 |
| enriquetaso | OK | 15:23 |
| enriquetaso | thanks eharney ! | 15:23 |
| enriquetaso | and Brian | 15:23 |
| eharney | i think it'd be useful to know if it only happens on certain platforms, but that's less important than patching it up probably | 15:23 |
| enriquetaso | sure | 15:24 |
| enriquetaso | #topic bug_2 'Still see v2 endpoints after disabling per documentation' | 15:25 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1928947 | 15:25 |
| enriquetaso | Bug description: | 15:25 |
| enriquetaso | The documentation states if you perform the following "Block Storage V2 API has been deprecated. To ensure Cinder does not use the V2 API, update enable_v2_api=false and enable_v3_api=true in your cinder.conf file". However after successful deployment, executing 'openstack catalog list' sourced as overcloudrc , shows that there are still v2 cinder endpoints. | 15:25 |
| * enriquetaso couldn't find where in the documentation states that so I assumed is here: [1]https://github.com/openstack/cinder/blob/master/cinder/api/__init__.py#L38 | 15:25 | |
| enriquetaso | rosmaita: Currently devstack doesn't show the v2 anymore, but I've tried to disable the v3 and it still shows it. Is there any way to disable it in cinder.conf? | 15:26 |
| eharney | turning off enable_v2_api isn't going to change whether a deployment tool creates endpoints for v2 | 15:26 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Fix: Schema validation for attachment create API https://review.opendev.org/c/openstack/cinder/+/783389 | 15:26 |
| enriquetaso | oh ok | 15:26 |
| eharney | so i assume this isn't a cinder bug | 15:27 |
| enriquetaso | so there's a misunderstanding here and the bug is invalid | 15:27 |
| rosmaita | yes, i think so, i'll put a comment on it | 15:27 |
| opendevreview | Rajat Dhasmana proposed openstack/python-cinderclient master: Make instance_uuid optional in attachment create https://review.opendev.org/c/openstack/python-cinderclient/+/783628 | 15:28 |
| enriquetaso | thanks! | 15:28 |
| enriquetaso | Last question: | 15:28 |
| enriquetaso | #topic bug_3: ' Block Storage API V3 (CURRENT) in cinder - wrong URL for backup-detail' | 15:28 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1930526 | 15:28 |
| enriquetaso | Bug description: API URL of Import a backup is wrong (https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=import-a-backup-detail): | 15:28 |
| enriquetaso | URL should be fixed to /v3/{project_id}/backups/import_record | 15:28 |
| enriquetaso | * I was going to reproduce it now but maybe a cinder member already knows if this is correct. | 15:29 |
| eharney | hmm | 15:30 |
| eharney | do we support importing to an existing backup? | 15:30 |
| eharney | i think the bug is correct if you look at the URLs in cinder/tests/unit/api/contrib/test_backups.py | 15:31 |
| eharney | probably a bad copy/paste from export_record | 15:32 |
| enriquetaso | from usage: cinder backup-import <backup_service> <backup_url>, cinder doesn't allow specifying an existing backup | 15:33 |
| eharney | makes sense | 15:33 |
| enriquetaso | #action(enriquetaso): patch for 1930526 and fix bad copy/paste | 15:34 |
| enriquetaso | #topic Open Discussion | 15:34 |
| enriquetaso | any other bugs to discuss today? :) | 15:35 |
| rosmaita | nothing from me, thanks sofia | 15:36 |
| eharney | no | 15:36 |
| enriquetaso | then.. That's all I have for today's meeting. Thank you! | 15:36 |
| enriquetaso | See you next week | 15:36 |
| enriquetaso | #endmeeting | 15:36 |
| opendevmeet | Meeting ended Wed Jun 16 15:36:39 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:36 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-06-16-15.00.html | 15:36 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-06-16-15.00.txt | 15:36 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-06-16-15.00.log.html | 15:36 |
| geguileo | eharney: rosmaita the NetApp patch has +1 from Zuul again, if you have the time to review it again: https://review.opendev.org/c/openstack/cinder/+/766296 | 15:39 |
| rosmaita | geguileo: ack | 15:40 |
| zoharm | hi all! requesting reviews of "NVMe agent" spec please (it differs from the spec that was approved for Wallaby) - https://review.opendev.org/c/openstack/cinder-specs/+/796365 | 16:06 |
| eharney | rosmaita: enriquetaso: fyi, saw this related fix go by: https://review.opendev.org/c/openstack/nova/+/796269 | 16:29 |
| opendevreview | Merged openstack/cinder master: volume api: Remove unused get_snapshot_metadata_value method https://review.opendev.org/c/openstack/cinder/+/788992 | 17:31 |
| opendevreview | Merged openstack/cinder master: PowerMax Driver - Fix for create group from source https://review.opendev.org/c/openstack/cinder/+/780774 | 17:33 |
| *** ricolin_ is now known as ricolin | 17:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!