| opendevreview | Merged openstack/cinder stable/wallaby: Add warning message about slow volume backend https://review.opendev.org/c/openstack/cinder/+/792148 | 01:45 |
|---|---|---|
| opendevreview | Merged openstack/cinder stable/stein: NetApp SolidFire: Fix failback failing after service restart https://review.opendev.org/c/openstack/cinder/+/764271 | 01:50 |
| opendevreview | Merged openstack/cinder stable/stein: Do not fail when depth is greater than rbd_max_clone_depth https://review.opendev.org/c/openstack/cinder/+/761184 | 02:01 |
| opendevreview | Merged openstack/os-brick stable/ussuri: Avoid unhandled exceptions during connecting to iSCSI portals https://review.opendev.org/c/openstack/os-brick/+/792359 | 02:06 |
| opendevreview | Rico Lin proposed openstack/cinder-tempest-plugin master: Enable tls-proxy support https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/794580 | 07:13 |
| *** akekane__ is now known as abhishekk | 08:04 | |
| opendevreview | Rico Lin proposed openstack/python-brick-cinderclient-ext master: Enable tls-proxy support in test job https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/796787 | 08:07 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Notify of snapshots transfer https://review.opendev.org/c/openstack/cinder/+/796806 | 09:17 |
| opendevreview | Moritz Wanzenböck proposed openstack/cinder master: Add install docs for LINSTOR driver dependencies https://review.opendev.org/c/openstack/cinder/+/773870 | 10:05 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinderlib master: Update TOX setenv https://review.opendev.org/c/openstack/cinderlib/+/796819 | 10:40 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinderlib master: Update TOX setenv https://review.opendev.org/c/openstack/cinderlib/+/796819 | 10:47 |
| opendevreview | Tom Barron proposed openstack/cinder-specs master: Expose ``user visible`` extra specs https://review.opendev.org/c/openstack/cinder-specs/+/796166 | 12:11 |
| rosmaita | tbarron: just in time for my morning reading! | 12:11 |
| tbarron | rosmaita: cool, I appreciate it. | 12:11 |
| opendevreview | Merged openstack/cinder master: Fix typo in Dell EMC Unity driver documentation https://review.opendev.org/c/openstack/cinder/+/796685 | 12:19 |
| enriquetaso | IDENTIFY | 12:44 |
| enriquetaso | oops | 12:44 |
| opendevreview | Takashi Kajinami proposed openstack/os-brick stable/train: Avoid unhandled exceptions during connecting to iSCSI portals https://review.opendev.org/c/openstack/os-brick/+/796671 | 13:01 |
| opendevreview | Brian Rosmaita proposed openstack/python-brick-cinderclient-ext master: Remove skip_missing_interpreters https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/796835 | 13:09 |
| rosmaita | eharney: you're going to hate ^^ ... i'm open to other options | 13:09 |
| eharney | rosmaita: well, i don't have a lot of great ideas, and i guess it works | 13:14 |
| rosmaita | yeah, it's kind of unsatisfactory ... i expect tosky will hate it too | 13:16 |
| tosky | yes | 13:18 |
| rosmaita | :) | 13:18 |
| tosky | to be honest, I don't understand the connection between the community "desires" and the tox environment and preventing a failures with 0 results | 13:19 |
| tosky | I mean, forcing python_version is fine, not sure why you also need to change tox.ini | 13:20 |
| rosmaita | because it gives us a backup if someone forgets to update zuul.yaml appropriately | 13:20 |
| rosmaita | we'd be back in the same situation | 13:20 |
| rosmaita | i think fungi summarized the case for this well: http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014810.html | 13:22 |
| tosky | that's the removal of skip... | 13:24 |
| fungi | i've generally been switching opendev's tox.ini files over to just using py3 in the default envs list, rather than specifying particular minor revs | 13:24 |
| tosky | and I disagree about "forget to update", we shouldn't forget | 13:24 |
| fungi | because odds are a developer isn't going to have more than one python niterpreter version available in a given environment anyway | 13:24 |
| fungi | ahh, yeah that's a message where i explained that, okay | 13:25 |
| rosmaita | tosky: i don't know about that, we get these patches removing "unnecessary" settings because the defaults are fine, and when those get modified forgetting happens | 13:26 |
| rosmaita | fungi: yes, i found your email very persuasive | 13:26 |
| fungi | summarized as "here's a place where it makes sense to do less work" | 13:27 |
| fungi | we need more of those | 13:27 |
| rosmaita | i think what it comes down to, is that when we discussed this at the midcycle, everyone agreed that no one just runs 'tox', so it really doesn't matter | 13:28 |
| fungi | yep, for myself, i tend to pass tox a list of the interpreters i have available to test with when that matters to me, like `tox -e linters,py35,py46,py37,py38,py39` or whatever | 13:30 |
| fungi | but i expect that most developers only have on hand (and most of the time only need to test locally with anyway) one py3x interpreter | 13:31 |
| fungi | so `tox -e py3` is a useful shortcut | 13:31 |
| fungi | if you're locally running tox tests for at least one interpreter, you're probably going to catch the vast majority of errors, and as far as testing a broader list of interpreters that's what the ci system is there to ensure anyway | 13:32 |
| fungi | i get the impression most patches get pushed without any local testing at all | 13:32 |
| fungi | though i'm sure that varies by project/team | 13:33 |
| fungi | and of course from dev to dev | 13:33 |
| rosmaita | well, we'd like to discourage patches being pushed with no tests, but yeah, it happens (it's always embarrassing when i discover i forgot to run pep8) | 13:34 |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Improve error handling around deletes https://review.opendev.org/c/openstack/cinder/+/796286 | 13:37 |
| opendevreview | Ivan Pchelintsev proposed openstack/cinder stable/wallaby: Fix typo in Dell EMC Unity driver documentation https://review.opendev.org/c/openstack/cinder/+/796859 | 13:51 |
| whoami-rajat | rosmaita: hey, can you take another look at the patch, just addressed gorka's comment there https://review.opendev.org/c/openstack/cinder/+/783389 | 13:55 |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - RDF checks https://review.opendev.org/c/openstack/cinder/+/768105 | 15:09 |
| jungleboyj | rosmaita: When you have a minute I think this is ready to go: https://review.opendev.org/c/openstack/cinder/+/772126 | 15:11 |
| rosmaita | whoami-rajat: jungleboyj: ack | 15:12 |
| opendevreview | Rajat Dhasmana proposed openstack/python-cinderclient master: Make instance_uuid optional in attachment create https://review.opendev.org/c/openstack/python-cinderclient/+/783628 | 15:12 |
| opendevreview | Eric Harney proposed openstack/cinder master: Retry "lvs" call on segfault for _get_thin_pool_free_space https://review.opendev.org/c/openstack/cinder/+/796889 | 16:30 |
| eharney | rosmaita: ^ | 16:30 |
| opendevreview | Merged openstack/cinder stable/wallaby: Fix typo in Dell EMC Unity driver documentation https://review.opendev.org/c/openstack/cinder/+/796859 | 16:37 |
| opendevreview | Ivan Pchelintsev proposed openstack/cinder stable/victoria: Fix typo in Dell EMC Unity driver documentation https://review.opendev.org/c/openstack/cinder/+/796864 | 16:42 |
| *** akekane_ is now known as abhishekk | 16:44 | |
| rosmaita | eharney: ty | 17:02 |
| gksk | To the Core Reviewers please review the below commit related to add volumes to clone group | 17:58 |
| gksk | https://review.opendev.org/c/openstack/cinder/+/784092 | 17:58 |
| *** dviroel is now known as dviroel|away | 18:05 | |
| gksk | To the Core Reviewers please review the below commit related to add volumes to clone group | 18:06 |
| gksk | https://review.opendev.org/c/openstack/cinder/+/784779 | 18:06 |
| opendevreview | Brian Rosmaita proposed openstack/python-brick-cinderclient-ext master: Remove skip_missing_interpreters https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/796835 | 18:08 |
| opendevreview | Ade Lee proposed openstack/cinder master: WIP/DNM: Add fips check jobs https://review.opendev.org/c/openstack/cinder/+/790535 | 18:22 |
| opendevreview | Ade Lee proposed openstack/cinder master: WIP/DNM: Add fips check jobs https://review.opendev.org/c/openstack/cinder/+/790535 | 18:27 |
| simondodsley | Can I get some reviews for https://review.opendev.org/c/openstack/cinder/+/794669 please? | 18:42 |
| *** dviroel|away is now known as dviroel | 18:53 | |
| jungleboyj | simondodsley: Looks good to me. | 19:05 |
| simondodsley | jungleboyj: Thank you for the +2 | 19:06 |
| simondodsley | jungleboyj: If you have time... https://review.opendev.org/c/openstack/cinder/+/792462 | 19:10 |
| jungleboyj | Oy, that one is a big boy. | 19:11 |
| jungleboyj | simondodsley: Why all the spacing changes? | 19:13 |
| simondodsley | jungleboyj: I ran `black` against it so make it after doing the changes for the REST versioning. It's not that big really from a code change perspective - 90% formatting | 19:14 |
| simondodsley | jungleboyj: I have started to run `black` against all my python code now - makes it much more readable and easier to see changes in the future | 19:17 |
| opendevreview | Merged openstack/cinder master: LVM: Use --readonly for lvdisplay in lv_has_snapshot https://review.opendev.org/c/openstack/cinder/+/772126 | 19:18 |
| jungleboyj | simondodsley: Ok. Couple of comments and then I will be ok with it. | 19:19 |
| opendevreview | Merged openstack/cinder master: Fix: Schema validation for attachment create API https://review.opendev.org/c/openstack/cinder/+/783389 | 19:22 |
| opendevreview | Simon Dodsley proposed openstack/cinder master: [Pure Storage] Fix minimum SDK version required https://review.opendev.org/c/openstack/cinder/+/792462 | 19:24 |
| opendevreview | Alan Bishop proposed openstack/cinder-specs master: Expose ``user visible`` extra specs https://review.opendev.org/c/openstack/cinder-specs/+/796166 | 19:43 |
| opendevreview | Eric Harney proposed openstack/cinder master: Tests: Simplify LVM fake_execute https://review.opendev.org/c/openstack/cinder/+/769602 | 19:51 |
| opendevreview | Eric Harney proposed openstack/cinder master: LVM: Simplify version fetching https://review.opendev.org/c/openstack/cinder/+/796946 | 19:51 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: LVM: Use --readonly for lvdisplay and Retry call on segfault https://review.opendev.org/c/openstack/cinder/+/796950 | 20:48 |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Improve error handling around deletes https://review.opendev.org/c/openstack/cinder/+/796286 | 21:05 |
| opendevreview | Merged openstack/cinder stable/victoria: Fix typo in Dell EMC Unity driver documentation https://review.opendev.org/c/openstack/cinder/+/796864 | 21:41 |
| enriquetaso | Sof1aEnr1qu3z | 21:48 |
| jungleboyj | *Sad trombone.wav* | 21:48 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: LVM: Retry lvdisplay calls on segfault https://review.opendev.org/c/openstack/cinder/+/796950 | 23:29 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!