| opendevreview | Merged openstack/cinder master: [SVf] Manage host attachment using portsets https://review.opendev.org/c/openstack/cinder/+/817351 | 00:13 |
|---|---|---|
| opendevreview | Merged openstack/cinder master: db: Remove unnecessary timezone configuration https://review.opendev.org/c/openstack/cinder/+/826123 | 00:42 |
| TusharTgite | hi core reviewers need a workflow +1 o this https://review.opendev.org/c/openstack/cinder/+/773985 | 04:00 |
| opendevreview | Atsushi Kawai proposed openstack/cinder master: Hitachi: Add port scheduler https://review.opendev.org/c/openstack/cinder/+/828696 | 06:57 |
| opendevreview | Francesco Pantano proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 09:09 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 09:57 |
| *** bhagyashris is now known as bhagyashris|ruck | 11:30 | |
| raghavendrat | hi whoami-rajat__: are you online ? | 12:38 |
| raghavendrat | hi whoami-rajat: | 12:56 |
| raghavendrat | regarding: https://review.opendev.org/c/openstack/cinder/+/786054 | 13:01 |
| raghavendrat | This is one of the FFE for Yoga. It as one +2. | 13:01 |
| raghavendrat | if you get free time, it would be great to receive feedback. Thanks. | 13:01 |
| rosmaita | TusharTgite: https://review.opendev.org/c/openstack/cinder/+/773985 is in the gate now | 13:13 |
| TusharTgite | rosmaita: i have question should i rebase its child patch now or after merge | 13:13 |
| rosmaita | TusharTgite: depends on whether it's going to require a merge commit | 13:23 |
| rosmaita | if the parent commit of your patch is the current HEAD of master, then there won't be a merge commit | 13:23 |
| rosmaita | otherwise, there will be, and it's possible that could make you have to rebase your dependent patches again if you do it now | 13:23 |
| rosmaita | current HEAD of master is a43427ef57, parent of your patch is 3bebea1, so probably better to wait | 13:25 |
| TusharTgite | rosmaita: ok thanks i'll wait then | 13:35 |
| TusharTgite | rosmaita: i need workflow on this one too has two plus 2 https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/828229 | 13:36 |
| rosmaita | got it | 13:37 |
| opendevreview | Merged openstack/cinder master: Reset state robustification for volume os-reset_status https://review.opendev.org/c/openstack/cinder/+/773985 | 14:39 |
| opendevreview | Merged openstack/cinder-tempest-plugin master: Updating python testing as per Yoga testing runtime https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/828229 | 14:56 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status https://review.opendev.org/c/openstack/cinder/+/804035 | 15:07 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status https://review.opendev.org/c/openstack/cinder/+/804735 | 15:08 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group-snapshot os-reset_status https://review.opendev.org/c/openstack/cinder/+/804757 | 15:08 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for backup os-reset_status https://review.opendev.org/c/openstack/cinder/+/778193 | 15:08 |
| hemna | rosmaita got a second? | 15:25 |
| rosmaita | sure | 15:25 |
| rosmaita | what's up? | 15:25 |
| hemna | I'm confused by this failure : https://zuul.opendev.org/t/openstack/build/c46efe4445bf447487177b370117f903 | 15:25 |
| rosmaita | looking | 15:25 |
| hemna | I didn't modify that line, and that novaclient server.create() call doesn't even have a context param | 15:26 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/tests/unit/scheduler/test_host_filters.py#L1028 | 15:27 |
| hemna | i ran pylint against master and it worked fine | 15:28 |
| hemna | the only thing I changed in that file is a few numeric values, that already existed. | 15:28 |
| hemna | https://review.opendev.org/c/openstack/cinder/+/831247/1/cinder/tests/unit/scheduler/test_host_filters.py | 15:29 |
| *** geguileo is now known as Guest914 | 15:34 | |
| rosmaita | hemna: no ideas from me ... at some point we need to address that pylint job, because it fails so often i don't think anyone pays attention to it any more | 15:36 |
| rosmaita | but yeah, i don't see any way your code change could have made that fail | 15:37 |
| hemna | ok it's not just me then. /me is confused | 15:43 |
| eharney | those pylint failures look accurate, though | 15:44 |
| eharney | probably since the job is non-voting, a patch introduced them and it wasn't noticed | 15:44 |
| opendevreview | Walt proposed openstack/cinder master: WIP: Fix capacity calculations https://review.opendev.org/c/openstack/cinder/+/831247 | 15:45 |
| hemna | eharney, if I run tox -epylint against master it's fine | 15:46 |
| eharney | oh, and it showed up here because you touched that file, since the pylint job only runs on files that are modified in that commit | 15:46 |
| eharney | right | 15:46 |
| hemna | oh | 15:46 |
| eharney | having it only run against files changed in that commit is confusing, tbh | 15:47 |
| opendevreview | Eric Harney proposed openstack/cinder master: Tests: Fix missing novaclient context arg in test_host_filters https://review.opendev.org/c/openstack/cinder/+/831395 | 15:50 |
| eharney | that fixes it ^ | 15:50 |
| hemna | hah ok cool. | 15:51 |
| hemna | I ran pylint against that file directly and didn't get that failure fwiw. | 15:51 |
| hemna | https://gist.github.com/hemna/1a277552cb1e52be3a319fbd1f66e3f2 | 15:52 |
| *** hemna8 is now known as hemna | 16:07 | |
| *** Guest914 is now known as geguileo | 16:08 | |
| geguileo | whoami-rajat: I answered your question, could you have another look at https://review.opendev.org/c/openstack/cinder/+/790492 please? | 16:09 |
| whoami-rajat | geguileo, looking | 16:37 |
| geguileo | whoami-rajat: thanks. You can do it tomorrow ;-) | 16:42 |
| *** bhagyashris_ is now known as bhagyashris|ruck | 16:43 | |
| whoami-rajat | done | 16:51 |
| opendevreview | Merged openstack/cinder master: db: Add missing foreign keys, indexes to models https://review.opendev.org/c/openstack/cinder/+/813221 | 19:07 |
| opendevreview | Ghanshyam proposed openstack/cinder master: Add grenade-skip-level irrelevant-files config https://review.opendev.org/c/openstack/cinder/+/831438 | 19:09 |
| opendevreview | Juan Pablo Suazo proposed openstack/cinder master: Adds conditional that prevents going out of index when len(parent_backup_shalist) < len(shalist). https://review.opendev.org/c/openstack/cinder/+/831439 | 19:09 |
| hemna | https://review.opendev.org/c/openstack/cinder/+/831395 | 20:33 |
| hemna | that passed zuul, can we slam that one in? | 20:33 |
| opendevreview | Merged openstack/cinder master: Tests: Fix missing novaclient context arg in test_host_filters https://review.opendev.org/c/openstack/cinder/+/831395 | 22:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!