| opendevreview | norman shen proposed openstack/cinder master: Respect volume_backend_name https://review.opendev.org/c/openstack/cinder/+/831090 | 00:35 |
|---|---|---|
| opendevreview | norman shen proposed openstack/cinder master: Respect volume_backend_name https://review.opendev.org/c/openstack/cinder/+/831090 | 02:08 |
| opendevreview | Xuan Yandong proposed openstack/cinder master: Prohibit volume manage to an encrypted volume type https://review.opendev.org/c/openstack/cinder/+/768458 | 03:07 |
| opendevreview | norman shen proposed openstack/cinder master: Respect volume_backend_name https://review.opendev.org/c/openstack/cinder/+/831090 | 03:59 |
| opendevreview | Xuan Yandong proposed openstack/cinder-specs master: Update original resource's az https://review.opendev.org/c/openstack/cinder-specs/+/778437 | 05:32 |
| opendevreview | Niklas Schwarz proposed openstack/cinder-specs master: Spec to introduce additional task status field https://review.opendev.org/c/openstack/cinder-specs/+/818551 | 07:44 |
| raghavendrat | hello whoami-rajat: are you around ? | 09:47 |
| whoami-rajat | raghavendrat, hey | 09:47 |
| raghavendrat | whoami-rajat: regarding: https://review.opendev.org/c/openstack/cinder/+/786054 | 09:48 |
| raghavendrat | This is one of the FFE for Yoga. It has one +2. | 09:49 |
| raghavendrat | if you get free time, it would be great to receive feedback. Thanks. | 09:49 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Return HTTPBadRequest instead of HTTPNotFound https://review.opendev.org/c/openstack/cinder/+/828459 | 10:40 |
| raghavendrat | Thanks a lot whoami-rajat: | 10:41 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Update volume_type_project bogus column https://review.opendev.org/c/openstack/cinder/+/822821 | 10:54 |
| opendevreview | Merged openstack/cinder master: Move nimble driver code to hpe folder https://review.opendev.org/c/openstack/cinder/+/786054 | 11:54 |
| opendevreview | Walt proposed openstack/cinder master: WIP: Fix capacity calculations https://review.opendev.org/c/openstack/cinder/+/831247 | 13:15 |
| opendevreview | Juan Pablo Suazo proposed openstack/cinder master: Adds conditional that prevents going out of index when len(parent_backup_shalist) < len(shalist). https://review.opendev.org/c/openstack/cinder/+/831439 | 13:31 |
| *** enriquetaso_ is now known as enriquetaso | 13:53 | |
| rosmaita | Courtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:58 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval ^^ | 13:58 |
| whoami-rajat | thanks rosmaita | 13:58 |
| jungleboyj | Thanks. | 13:59 |
| geguileo | rosmaita: thanks | 13:59 |
| rosmaita | yw | 13:59 |
| opendevreview | Juan Pablo Suazo proposed openstack/cinder master: Adds conditional that prevents going out of index when len(parent_backup_shalist) < len(shalist). https://review.opendev.org/c/openstack/cinder/+/831439 | 14:00 |
| yuval | hey | 14:02 |
| TusharTgite | hi core reviewers just for reminder pasting links for child patches https://review.opendev.org/c/openstack/cinder/+/778193 , https://review.opendev.org/c/openstack/cinder/+/804035 | 14:42 |
| TusharTgite | base is merged for ref https://review.opendev.org/c/openstack/cinder/+/773985 | 14:43 |
| coreycb | hi cinder folks, would someone be able to take a look at this and let us know what's needed to move it forward? it's a really small change. https://review.opendev.org/c/openstack/cinder/+/815560 | 14:44 |
| opendevreview | Lucas Morais de oliveira proposed openstack/cinder master: WIP api-ref: Add docs for clusters https://review.opendev.org/c/openstack/cinder/+/795785 | 14:44 |
| enriquetaso | Hey, hope you enjoy 1/2 hour to review the alembic completion. I've reviewed the XS patch, and left some questions. I'll review the priority patches after the bug meeting. | 15:01 |
| enriquetaso | #startmeeting cinder_bs | 15:01 |
| opendevmeet | Meeting started Wed Mar 2 15:01:44 2022 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'cinder_bs' | 15:01 |
| enriquetaso | Welcome back to the bug meeting | 15:01 |
| enriquetaso | Only two new bugs reported this period and a bug proposed for the open discussion. | 15:02 |
| enriquetaso | List of bugs: | 15:02 |
| enriquetaso | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-March/027494.html | 15:02 |
| enriquetaso | As I wrote we have a bug proposed for open discussion but I think we should discuss it first. | 15:02 |
| enriquetaso | #topic Create x Update Volume Metadata in Cinder Backend should be invalid | 15:03 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1929606 | 15:03 |
| enriquetaso | (rosmaita)I thought it was wishlist, but looking at the proposed patch, I think we should reject it | 15:03 |
| rosmaita | enriquetaso: sorry, i lost track of time | 15:03 |
| rosmaita | o/ | 15:03 |
| enriquetaso | \o | 15:03 |
| rosmaita | looking now | 15:04 |
| enriquetaso | thanks! | 15:04 |
| enriquetaso | don't worry | 15:04 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/817642 | 15:04 |
| rosmaita | enriquetaso: ty for bringing that up | 15:04 |
| enriquetaso | Brian would you mind sharing your thoughts? | 15:04 |
| rosmaita | i thought i had marked it invalid | 15:04 |
| enriquetaso | i think it's still in "in progess" | 15:05 |
| enriquetaso | I'll move it to invalid then | 15:05 |
| enriquetaso | I haven't review it yet | 15:05 |
| rosmaita | here's my reasoning | 15:05 |
| rosmaita | "As I understand the bug, the problem is that client programs are using the create call to do updates, and hence the permissions appear not to be working correctly. But if you make API calls directly for create vs. update, the policies are correctly applied." | 15:05 |
| enriquetaso | cool | 15:06 |
| rosmaita | i guess i didn't update the bug because there could be some discussion | 15:06 |
| enriquetaso | the last comment on the upstream patch is from Feb 18 | 15:07 |
| enriquetaso | Maybe I can set the bp to invalid and ask the reporter to join the upstream meeting if he'd like to discuss it a bit more? | 15:08 |
| rosmaita | i will respond and tell the author to bring it to the cinder meeting | 15:08 |
| rosmaita | :) | 15:08 |
| enriquetaso | nice :D | 15:08 |
| enriquetaso | thanks rosmaita | 15:08 |
| enriquetaso | Moving forward.. | 15:09 |
| enriquetaso | #topic [lightos] Compression handling in lightos driver while default compression enabled | 15:10 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1962221 | 15:10 |
| enriquetaso | It already has a bugfix upstream, please take a look when you have time. There's a discussion about when to add a release note. | 15:10 |
| enriquetaso | yuval ^ | 15:10 |
| enriquetaso | Moving on.. | 15:10 |
| enriquetaso | #topic IndexError when creating Backups | 15:11 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1962607There's an indexError in the chunkeddriver.py that may be valid. However, I've asked for steps to reproduce and the backup driver name. Finally, The fix proposed to master doesn't look right. | 15:11 |
| enriquetaso | oops | 15:11 |
| eharney | i was looking at this patch this morning | 15:11 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1962607 | 15:11 |
| eharney | it would presumably affect any backup driver using ChunkedDriver | 15:11 |
| eharney | i'm not too sure about the proposed fix though, i'm wondering if it's papering over something going wrong elsewhere... not sure | 15:12 |
| enriquetaso | I think the upstream fix need more work too.. | 15:13 |
| eharney | i think we need to know why the index can exceed the size of the list which isn't explained | 15:13 |
| enriquetaso | OK, so, maybe I should mark it as NEW instead of Invalid | 15:13 |
| eharney | i mean, it seems to have failed for them, so it's probably not invalid | 15:14 |
| rosmaita | enriquetaso: about your comment on https://review.opendev.org/c/openstack/cinder/+/830538 ... this is a special case because it's a pre-release bug (the lightos driver doesn't exist officially until the Yoga release) ... so this is one case where we shouldn't require a release note | 15:14 |
| enriquetaso | rosmaita, ooh! need to update my comment then.. | 15:15 |
| rosmaita | that's fine, in most cases we do want a release note with a driver bugfix | 15:15 |
| enriquetaso | eharney, yes.. when the index exceed the size of the list.. maybe a clone of a clone? | 15:15 |
| enriquetaso | need to take a deeper look | 15:16 |
| eharney | i don't think this is about clones | 15:16 |
| eharney | i'm going to ask them to explain it on the patch, because it might need a deeper look | 15:16 |
| enriquetaso | thanks eharney | 15:16 |
| enriquetaso | eharney++ | 15:16 |
| enriquetaso | rosmaita++ | 15:16 |
| enriquetaso | Moving on.. | 15:18 |
| enriquetaso | #topic open discussion | 15:18 |
| enriquetaso | Feel free to propose bugs now. | 15:18 |
| opendevreview | Luciano Lo Giudice proposed openstack/cinder master: Fix QOS computation https://review.opendev.org/c/openstack/cinder/+/815560 | 15:19 |
| enriquetaso | OK, I don't have anything else today! | 15:21 |
| eharney | do we plan to backport https://review.opendev.org/c/openstack/cinder/+/827860 ? | 15:21 |
| eharney | i think we probably should | 15:21 |
| eharney | geguileo: ^ | 15:21 |
| rosmaita | we talked about that last week | 15:21 |
| eharney | oh | 15:21 |
| rosmaita | geguileo wants it to marinate a bit in master first | 15:21 |
| eharney | that works | 15:21 |
| geguileo | yeah, in case I broke things horribly | 15:22 |
| geguileo | I tried to test it thoroughly though | 15:22 |
| eharney | should we add a target to the bug or a WIP patch or something so we don't forget about it? | 15:22 |
| geguileo | eharney: great idea! | 15:22 |
| geguileo | I'll add a calendar reminder just in case XD | 15:23 |
| enriquetaso | sounds good | 15:24 |
| eharney | i added a Wallaby target to https://bugs.launchpad.net/cinder/+bug/1960329 | 15:24 |
| geguileo | eharney: thanks | 15:24 |
| rosmaita | i was trying to figure out which would be the best tracking bug, that one works | 15:24 |
| rosmaita | (since the patch fixes like 8 bugs) | 15:25 |
| enriquetaso | \O/ | 15:27 |
| enriquetaso | OK, we have a plan | 15:28 |
| enriquetaso | anything else? | 15:28 |
| rosmaita | i just closed this old one as invalid: https://bugs.launchpad.net/cinder/+bug/1640173 | 15:28 |
| enriquetaso | I need to think of something for old bugs somehow. Maybe once a month I can send a report with very old bugs? | 15:30 |
| enriquetaso | run out of time | 15:31 |
| enriquetaso | Thanks!! | 15:31 |
| enriquetaso | #endmeeting | 15:31 |
| opendevmeet | Meeting ended Wed Mar 2 15:31:24 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:31 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-03-02-15.01.html | 15:31 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-03-02-15.01.txt | 15:31 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-03-02-15.01.log.html | 15:31 |
| rosmaita | enriquetaso: we should probably have a Festival of Ancient Bugs | 15:32 |
| rosmaita | (that is my solution for everything) | 15:32 |
| enriquetaso | hahaha | 15:32 |
| enriquetaso | why not? could work :P | 15:33 |
| rosmaita | enriquetaso: did you mean to keep your -1 on https://review.opendev.org/c/openstack/cinder/+/830538 ? | 16:06 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for backup os-reset_status https://review.opendev.org/c/openstack/cinder/+/778193 | 16:14 |
| enriquetaso | i think i would be nice to update the commit msg to track the launchpad bug | 16:38 |
| enriquetaso | but I can remove the -1 and make it optional | 16:38 |
| enriquetaso | rosmaita, updated | 16:38 |
| *** abishop_ is now known as abishop | 16:57 | |
| opendevreview | Juan Pablo Suazo proposed openstack/cinder master: Adds conditional that prevents going out of index when len(parent_backup_shalist) < len(shalist). https://review.opendev.org/c/openstack/cinder/+/831439 | 17:07 |
| opendevreview | Merged openstack/python-cinderclient master: Update master for stable/yoga https://review.opendev.org/c/openstack/python-cinderclient/+/830981 | 17:55 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Update master for stable/yoga https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/830955 | 17:56 |
| opendevreview | Eric Harney proposed openstack/cinder master: Drivers: remove unused code https://review.opendev.org/c/openstack/cinder/+/800704 | 18:05 |
| opendevreview | Jon Bernard proposed openstack/python-cinderclient master: Add user and project domain name parameters in HTTPClient https://review.opendev.org/c/openstack/python-cinderclient/+/789291 | 18:27 |
| opendevreview | Eric Harney proposed openstack/cinder master: Tests: Remove typo'd assert calls from test_attachments_manager https://review.opendev.org/c/openstack/cinder/+/831591 | 18:32 |
| opendevreview | Eric Harney proposed openstack/cinder master: Tests: Fix volume extend volume manager test https://review.opendev.org/c/openstack/cinder/+/831599 | 19:14 |
| opendevreview | Eric Harney proposed openstack/cinder master: Tests: Fix invalid assert_called_once calls in driver tests https://review.opendev.org/c/openstack/cinder/+/831600 | 19:15 |
| opendevreview | Merged openstack/cinder master: Remove attach and detach volume driver methods https://review.opendev.org/c/openstack/cinder/+/814898 | 19:21 |
| *** dviroel is now known as dviroel|out | 21:31 | |
| opendevreview | Eric Harney proposed openstack/cinder master: Tests: Remove typo'd assert calls from test_attachments_manager https://review.opendev.org/c/openstack/cinder/+/831591 | 22:01 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!