| *** dviroel|rover|afk is now known as dviroel|out | 00:16 | |
| opendevreview | Masayuki Igawa proposed openstack/cinder master: [doc] Update markups of options in capacity-based-qos https://review.opendev.org/c/openstack/cinder/+/839297 | 05:59 |
|---|---|---|
| opendevreview | Rajat Dhasmana proposed openstack/cinder-tempest-plugin master: Add test to create multiple volume from resource https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/795753 | 06:25 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder-tempest-plugin master: Add test to create multiple volume from resource https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/795753 | 06:32 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder-tempest-plugin master: Add command to fix/generate idempotent IDs https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/839301 | 06:58 |
| opendevreview | DataCore Software proposed openstack/cinder master: Reintroduce DataCore driver https://review.opendev.org/c/openstack/cinder/+/836996 | 09:13 |
| stephenfin | whoami-rajat: I just replied to your question on https://review.opendev.org/c/openstack/cinder/+/830089 (I was out yesterday) | 10:49 |
| stephenfin | (I'd genuinely be interested in seeing if there's interest in running black over, like, everything at some point :) Ideally at the start/end of a cycle when there isn't a whole lot else happening. Could be a good future PTG topic) | 10:50 |
| *** dviroel|out is now known as dviroel|rover | 11:09 | |
| rosmaita | stephenfin: probably not, see this discussion: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-06-23-14.00.log.html#l-53 | 11:46 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: releasenotes: correct formatting error https://review.opendev.org/c/openstack/cinder/+/839368 | 12:03 |
| opendevreview | Lior Friedman proposed openstack/os-brick master: Add NVMeoF Multipathing support Phase 1 (Native) implementation of NVMeoF Multipathing. https://review.opendev.org/c/openstack/os-brick/+/830800 | 12:21 |
| hemna | please no black. it's awful. | 13:00 |
| opendevreview | do3meli proposed openstack/cinder stable/yoga: NetApp ONTAP: Fix check QoS min support for SVM account https://review.opendev.org/c/openstack/cinder/+/835133 | 13:16 |
| stephenfin | rosmaita: IRC isn't well suited to these kind of discussions, but I have to note that neither problem is insurmountable | 13:29 |
| stephenfin | On the history front, you can tell git to ignore revisions (so the "blackify" revision(s)) by creating a '.git-blame-ignore-revs' file. This is what Django and most other projects that have adopted this have done | 13:29 |
| stephenfin | On the backport front, black ensures that the AST generated before and after is identical, so you could just run black over stable branches. Maybe that idea causes some people to shudder but from a purely engineering perspective, it seems sound | 13:31 |
| stephenfin | aaand on the single string vs double strings front, that's one of two knobs you can actually adjust (the other being line length). I usually use 'black -S -l 79 *' when converting code bases | 13:32 |
| rosmaita | stephenfin: thanks for the info, maybe you can propose it for the cinder midcycle | 13:35 |
| stephenfin | I can't argue with hemna's "it's awful" comment though :-D There are also stuff I don't really like. tbf though, by its very definition an opinionated linter is going to offend someone. So long as offends consistently though... :-D | 13:35 |
| stephenfin | Sure, why not. Is there an Etherpad I can add it to? I won't die on this hill, but it seems like it's maybe worth discussing. | 13:36 |
| rosmaita | stephenfin: probably not yet | 13:46 |
| rosmaita | 1) zed S-RBAC, upstream reviews | 13:47 |
| rosmaita | 2) more of the same | 13:47 |
| rosmaita | 3) none | 13:47 |
| opendevreview | Walt proposed openstack/cinder master: WIP: Store affinity/anti-affinity for migration https://review.opendev.org/c/openstack/cinder/+/839391 | 14:16 |
| hemna | black produces unreadble code. | 14:18 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: Fix encryption symlink issues https://review.opendev.org/c/openstack/os-brick/+/836391 | 14:21 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: WIP: Run codebase through black https://review.opendev.org/c/openstack/cinder/+/839405 | 16:03 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: WIP: Add '.git-blame-ignore-revs' https://review.opendev.org/c/openstack/cinder/+/839406 | 16:03 |
| *** dviroel|rover is now known as dviroel|rover|lunch | 16:11 | |
| opendevreview | Eric Harney proposed openstack/cinder master: WIP: fix status checking in reset_status https://review.opendev.org/c/openstack/cinder/+/839416 | 16:53 |
| *** dviroel|rover|lunch is now known as dviroel|rover | 17:02 | |
| opendevreview | Konstantin Shalygin proposed openstack/cinder master: RBD driver: added support for ceph-mon's msgr2 https://review.opendev.org/c/openstack/cinder/+/839424 | 18:38 |
| opendevreview | Konstantin Shalygin proposed openstack/cinder master: RBD driver: added support for ceph-mon's msgr2 https://review.opendev.org/c/openstack/cinder/+/839426 | 18:42 |
| opendevreview | Eric Harney proposed openstack/cinder master: Ceph: Remove unnecessary convert_str() calls https://review.opendev.org/c/openstack/cinder/+/839257 | 18:51 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: Rename and update job cinder-tempest-lvm-multibackend https://review.opendev.org/c/openstack/cinder/+/784815 | 22:15 |
| *** dviroel|rover is now known as dviroel|rover|out | 22:56 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!