| opendevreview | 焦浩霖 proposed openstack/cinder master: implement the revert_snapshot function imitated the _revert_to_snapshot_generic() fix the bug when using _revert_to_snapshot_generic to revert snapshot, the volume will losing iscsi-target problem. https://review.opendev.org/c/openstack/cinder/+/856941 | 00:37 |
|---|---|---|
| *** dviroel|afk is now known as dviroel | 00:41 | |
| *** dviroel is now known as dviroel|out | 00:50 | |
| opendevreview | 焦浩霖 proposed openstack/cinder master: Add retry when meet exceptions in create ssh_connection https://review.opendev.org/c/openstack/cinder/+/857075 | 02:33 |
| opendevreview | 焦浩霖 proposed openstack/cinder master: Add retry when exception is encountered in creating ssh_connection https://review.opendev.org/c/openstack/cinder/+/857075 | 02:39 |
| whoami-rajat | thanks rosmaita | 05:04 |
| opendevreview | 焦浩霖 proposed openstack/cinder master: implement the revert_snapshot function imitated the _revert_to_snapshot_generic() fix the bug when using _revert_to_snapshot_generic to revert snapshot, the volume will losing iscsi-target problem. https://review.opendev.org/c/openstack/cinder/+/856941 | 06:19 |
| *** tkajinam is now known as Guest162 | 06:33 | |
| HappyStacker | Hi core reviewers, could you please review this patch? https://review.opendev.org/c/openstack/cinder/+/806605 | 06:56 |
| opendevreview | 焦浩霖 proposed openstack/cinder master: Add retry when exception is encountered in creating ssh_connection https://review.opendev.org/c/openstack/cinder/+/857075 | 07:17 |
| opendevreview | Merged openstack/cinder master: Tests: Fix zone manager tests https://review.opendev.org/c/openstack/cinder/+/854266 | 07:45 |
| *** marlinc is now known as Guest167 | 08:04 | |
| opendevreview | Merged openstack/cinder master: Tests: Fix Pure test https://review.opendev.org/c/openstack/cinder/+/854267 | 08:17 |
| opendevreview | Merged openstack/cinder master: Tests: Fix NetApp tests https://review.opendev.org/c/openstack/cinder/+/854268 | 08:17 |
| opendevreview | Merged openstack/cinder master: Tests: Fix NFS tests https://review.opendev.org/c/openstack/cinder/+/854269 | 08:20 |
| opendevreview | Merged openstack/cinder master: Tests: Fix cmd tests https://review.opendev.org/c/openstack/cinder/+/854270 | 08:24 |
| opendevreview | Merged openstack/cinder master: Tests: Fix PowerMax tests https://review.opendev.org/c/openstack/cinder/+/854271 | 08:38 |
| opendevreview | Merged openstack/cinder master: Tests: Fix versions view https://review.opendev.org/c/openstack/cinder/+/854272 | 09:35 |
| opendevreview | Merged openstack/cinder master: Tests: Fix linstor tests https://review.opendev.org/c/openstack/cinder/+/855041 | 09:36 |
| opendevreview | Merged openstack/cinder master: Tests: Randomize tests https://review.opendev.org/c/openstack/cinder/+/854273 | 09:36 |
| opendevreview | Luigi Toscano proposed openstack/cinder-tempest-plugin master: zuul: new LVM/nvmet job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/855576 | 10:42 |
| opendevreview | Luigi Toscano proposed openstack/cinder-tempest-plugin master: zuul: new LVM/nvmet job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/855576 | 10:57 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: RBD: Improve close and flush in IOWrapper https://review.opendev.org/c/openstack/os-brick/+/857347 | 11:30 |
| geguileo | whoami-rajat: that's the fix we discussed | 11:30 |
| *** dviroel|out is now known as dviroel | 11:36 | |
| whoami-rajat | ack | 11:40 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Ceph backup: Close source file https://review.opendev.org/c/openstack/cinder/+/854274 | 11:44 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: api-ref: POST /manageable_volumes request/response https://review.opendev.org/c/openstack/cinder/+/855189 | 11:45 |
| stephenfin | whoami-rajat: Replied on https://review.opendev.org/c/openstack/cinder/+/844961 | 11:49 |
| whoami-rajat | stephenfin, ack, thanks for the explanation, updated my vote | 12:10 |
| opendevreview | Jean Pierre Roquesalane proposed openstack/cinder master: PowerMax Driver - Fix for renaming GVG https://review.opendev.org/c/openstack/cinder/+/801354 | 12:11 |
| opendevreview | Nahim Alves de Souza proposed openstack/cinder master: NetApp ONTAP: Improving REST client UT coverage https://review.opendev.org/c/openstack/cinder/+/857434 | 13:30 |
| sfv880_ | whoami-rajat: Replied and fixed on https://review.opendev.org/c/openstack/cinder/+/852009 - Thank you! | 13:34 |
| whoami-rajat | sfv880_, ack, will take a look | 13:39 |
| hemna | morning | 13:53 |
| jungleboyj | Morning. :-) | 14:05 |
| opendevreview | Nahim Alves de Souza proposed openstack/cinder master: NetApp ONTAP: Add UTs to improve REST client coverage https://review.opendev.org/c/openstack/cinder/+/857434 | 14:48 |
| hemna | rosmaita, when you have time can you take a look at this again? I addressed your documentation issues https://review.opendev.org/c/openstack/cinder/+/831247 | 14:55 |
| opendevreview | Luigi Toscano proposed openstack/cinder-tempest-plugin master: zuul: new LVM/nvmet job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/855576 | 15:02 |
| opendevreview | Sergey Drozdov proposed openstack/cinder master: RBD backend QoS implementation https://review.opendev.org/c/openstack/cinder/+/820027 | 15:26 |
| opendevreview | Sergey Drozdov proposed openstack/cinder master: RBD backend QoS implementation https://review.opendev.org/c/openstack/cinder/+/820027 | 15:27 |
| opendevreview | Merged openstack/cinder master: db: Remove unnecessary engine facade decorator https://review.opendev.org/c/openstack/cinder/+/844961 | 15:43 |
| *** dviroel is now known as dviroel|lunch | 15:51 | |
| geguileo | eharney: whoami-rajat hemna rosmaita the RBD QoS implementation is ready for final review (I already +2 it) https://review.opendev.org/c/openstack/cinder/+/820027 | 15:56 |
| eharney | geguileo: the patch is still marked WIP? | 15:56 |
| geguileo | really? lol | 15:56 |
| whoami-rajat | wow another feature | 15:56 |
| eharney | that hides it from dashboards etc... | 15:56 |
| whoami-rajat | same question as eharney | 15:57 |
| geguileo | SDrozdov: you need to remove the flag that the patch is a work in progress | 15:57 |
| hemna | geguileo, reviewed :P | 15:57 |
| geguileo | hemna: lol | 15:58 |
| eharney | do we document any requirements around this driver versioning business? | 15:58 |
| SDrozdov | I'll contact the owner, thanks guys! | 15:59 |
| geguileo | eharney: good question, I don't think the RBD driver has anything defined | 16:00 |
| hemna | does that metadata survive a volume migration? | 16:00 |
| eharney | geguileo: right, because changing the version number in the RBD driver doesn't really accomplish much for us, as far as i know | 16:00 |
| whoami-rajat | SDrozdov, please try to get the features finalized till tomorrow as we will have RC1 on thursday and no features will be acceptable after that | 16:00 |
| geguileo | eharney: truee | 16:00 |
| eharney | which is why it's been the same since 2014 | 16:01 |
| hemna | the entire point of the driver versioning in code is to see in the log what version is being used at startup, so you can cross reference that as time goes on for deployments. | 16:01 |
| hemna | then that's been bad since 2014 | 16:01 |
| SDrozdov | whoami-rajat: will do ! | 16:01 |
| SDrozdov | hemna: Would you mind confirming the reason behind the -1 ? | 16:02 |
| hemna | I just did :) | 16:02 |
| hemna | ^^^ | 16:02 |
| SDrozdov | Ah sorry, my bad ! | 16:03 |
| *** dviroel|lunch is now known as dviroel | 16:57 | |
| whoami-rajat | sfv880, hey, around ? | 17:09 |
| whoami-rajat | sfv880, some minor corrections needed and it looks ready, ping me once you update it https://review.opendev.org/c/openstack/cinder/+/852009 | 17:11 |
| opendevreview | Alexander Deiter proposed openstack/cinder master: Infinidat: support for manage/unmanage API https://review.opendev.org/c/openstack/cinder/+/852009 | 17:18 |
| sfv880_ | Hello whoami-rajat: Replied and fixed on https://review.opendev.org/c/openstack/cinder/+/852009 - Thank you very much! | 17:20 |
| whoami-rajat | sfv880_, thanks, +2ed | 17:20 |
| sfv880_ | Thank you very much!!! | 17:21 |
| opendevreview | Alan Bishop proposed openstack/cinder master: Prepare unit test request contexts for secure RBAC https://review.opendev.org/c/openstack/cinder/+/828805 | 19:03 |
| opendevreview | Alan Bishop proposed openstack/cinder master: Update deprecated policies and rules for Zed https://review.opendev.org/c/openstack/cinder/+/828806 | 19:03 |
| opendevreview | Alan Bishop proposed openstack/cinder master: WIP: Add release note for policy changes in Zed https://review.opendev.org/c/openstack/cinder/+/828807 | 19:03 |
| hemna | whoami-rajat, jungleboyj can you guys have a look? I'd like to get this one done finally. https://review.opendev.org/c/openstack/cinder/+/831247 | 19:28 |
| *** dviroel is now known as dviroel|brb | 20:10 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!