| opendevreview | melanie witt proposed openstack/cinder master: NFS update volume attachment format during volume snapshot https://review.opendev.org/c/openstack/cinder/+/857528 | 00:18 |
|---|---|---|
| melwitt | eharney: hi, I opened https://bugs.launchpad.net/cinder/+bug/1989514 and proposed https://review.opendev.org/c/openstack/cinder/+/857528 re: https://bugzilla.redhat.com/show_bug.cgi?id=2118150. I might be way off but I thought it might be easier to explain with code. your input would be appreciated | 00:28 |
| opendevreview | 焦浩霖 proposed openstack/cinder master: Add retry for create ssh_connection Add retry when exception is encountered in creating ssh_connection https://review.opendev.org/c/openstack/cinder/+/857075 | 00:50 |
| opendevreview | 焦浩霖 proposed openstack/cinder master: Add retry for create ssh_connection When the management of storage is very unstable, or the number of ssh connections of storage is limited, if there is high concurrency, the create_connection of ssh_pool will be abnormal. Adding a retry mechanism can solve this problem https://review.opendev.org/c/openstack/cinder/+/857075 | 01:25 |
| opendevreview | 焦浩霖 proposed openstack/cinder master: Add retry for create ssh_connection https://review.opendev.org/c/openstack/cinder/+/857075 | 02:00 |
| sfv880_ | Hello, cores, could you please review https://review.opendev.org/c/openstack/cinder/+/852009 ? Zuul is voting +1 and it already has a +2 from whoami-rajat. Thank you very much! | 08:51 |
| *** dviroel|brb is now known as dviroel | 11:37 | |
| opendevreview | Sergey Drozdov proposed openstack/cinder master: RBD backend QoS implementation https://review.opendev.org/c/openstack/cinder/+/820027 | 12:16 |
| opendevreview | Sergey Drozdov proposed openstack/cinder master: RBD backend QoS implementation https://review.opendev.org/c/openstack/cinder/+/820027 | 12:18 |
| rosmaita | sfv880_: left a question for you on https://review.opendev.org/c/openstack/cinder/+/852009 | 12:29 |
| raghavendrat | hi rosmaita: are you around | 12:49 |
| rosmaita | raghavendrat: depends | 12:50 |
| rosmaita | on what you want, i mean | 12:50 |
| raghavendrat | in case you have some time .. it would be great if you could look at: | 12:50 |
| raghavendrat | https://review.opendev.org/c/openstack/cinder/+/850836 | 12:51 |
| raghavendrat | It has one +2. Thanks | 12:51 |
| rosmaita | raghavendrat: will put it on my list, no promises about speedy resolution, though | 13:14 |
| raghavendrat | no problem. Thanks. | 13:15 |
| rosmaita | raghavendrat: that patch looks really familiar, though apparently i have not reviewed it before | 13:15 |
| rosmaita | did you have a similar one for a different driver? | 13:15 |
| raghavendrat | no. i submitted only one patch. | 13:16 |
| whoami-rajat | rosmaita, the same feature is added by infinidat driver, however the hpe one is a bugfix not exactly a feature | 13:41 |
| rosmaita | whoami-rajat: thanks, good to know i am not hallucinating patches | 13:49 |
| whoami-rajat | i had the same confusion :D | 13:49 |
| raghavendrat | Thank you Brian & Rajat | 13:54 |
| whoami-rajat | Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:59 |
| whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin adiare | 13:59 |
| rosmaita | whoami-rajat: ty! | 13:59 |
| whoami-rajat | np | 13:59 |
| SDrozdov | hemna: Thank you very much for approving https://review.opendev.org/c/openstack/cinder/+/820027 ! | 14:29 |
| SDrozdov | geguileo: Thank you for all the help with https://review.opendev.org/c/openstack/cinder/+/820027, it is greatly appreciated ! | 14:30 |
| opendevreview | Eric Harney proposed openstack/os-brick master: mypy: improve executor coverage https://review.opendev.org/c/openstack/os-brick/+/853789 | 14:41 |
| geguileo | SDrozdov: np | 14:44 |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: Add snapshot deletion test https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/805884 | 14:50 |
| enriquetaso | #startmeeting cinder_bs | 15:00 |
| opendevmeet | Meeting started Wed Sep 14 15:00:43 2022 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'cinder_bs' | 15:00 |
| enriquetaso | Hello, welcome to the bug meeting | 15:00 |
| enriquetaso | #topic Wrong assertion methods in unit tests | 15:01 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1989280 | 15:01 |
| whoami-rajat | hi | 15:02 |
| enriquetaso | Unittest fix for cinder and other projects: | 15:02 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/856971 | 15:02 |
| enriquetaso | I think we still need a fix for os-brick, cinderclient unit tests. | 15:02 |
| enriquetaso | Do we have any volunteers? :P | 15:02 |
| eharney | the os-brick fix is https://review.opendev.org/c/openstack/os-brick/+/857044 | 15:03 |
| enriquetaso | oh cool | 15:05 |
| rosmaita | there seems to be an awful lot going on in that cinder patch | 15:06 |
| eharney | hmm.. there does | 15:06 |
| eharney | bad conflict resolution? | 15:07 |
| rosmaita | not sure, i just looked at the first file and decided that i don't want to look any further | 15:08 |
| rosmaita | especially because that particular issue mentioned in the bug only seems to occur in 2 files | 15:09 |
| eharney | yeah it's reverting another change | 15:09 |
| enriquetaso | OK, i can mentioned that on the cinder patch, maybe should be split in smaller changes | 15:11 |
| eharney | it doesn't need to be split into smaller changes | 15:11 |
| eharney | it just needs to not have accidental changes in it | 15:11 |
| eharney | i already -1'd it | 15:11 |
| enriquetaso | os-brick patch looks fine to me | 15:12 |
| enriquetaso | thanks eharney | 15:12 |
| rosmaita | yeah, that's the downside of mocks ... you can call any method on them, and they don't complain | 15:14 |
| eharney | i've looked into to some ways to prevent this with mock sealing, it's possible, but generally takes a lot of extra work | 15:14 |
| eharney | (calling mock.seal everywhere) | 15:14 |
| eharney | i've prototyped some ways to get that to happen automatically, but it's tricky | 15:15 |
| rosmaita | i wonder if we could add that to the mock_object method in the cinder.tests.unit.test.TestCase class | 15:15 |
| rosmaita | (i say that knowing absolutely nothing about mock.seal) | 15:15 |
| eharney | it depends on how people use the mock in the tests, a lot of them rely on being able to change mocks further inside the test | 15:16 |
| rosmaita | ok | 15:16 |
| rosmaita | (enriquetaso: i have to leave early today, will be afk for 2 hours or so) | 15:17 |
| enriquetaso | i think worth looking into this, we may need to discuss this further | 15:18 |
| enriquetaso | sure rosmaita, this is the big topic for today's | 15:18 |
| enriquetaso | OK, moving on, we have 6 bugs for today's meeting | 15:18 |
| enriquetaso | i forgot to mentioned: | 15:19 |
| enriquetaso | #link https://lists.openstack.org/pipermail/openstack-discuss/2022-September/030463.html | 15:19 |
| enriquetaso | #topic revert_snapshot_will_destory_attachment_with_lvm_backend | 15:19 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1989271 | 15:19 |
| enriquetaso | Summary: | 15:19 |
| enriquetaso | 1.using lvm as cinder volume backend. | 15:19 |
| enriquetaso | 2.create a volume and attach the volume to a VM, | 15:19 |
| enriquetaso | 3.then create a snapshot of the volume | 15:19 |
| enriquetaso | 4.revert the snapshot of the volume, the VM will be crashed | 15:19 |
| enriquetaso | The reason why this happening is that lvm can not revert the snapshot in backend when lvm is using thin_proversion. | 15:19 |
| enriquetaso | So ,it will using the _revert_to_snapshot_generic function to revert the snapshot. | 15:19 |
| eharney | this seems important but the commit message needs a little work to explain what is happening | 15:20 |
| enriquetaso | Fix proposed to master, but zuul is failing because of unit test. | 15:20 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/856941 | 15:20 |
| eharney | (and to fix formatting etc) | 15:20 |
| enriquetaso | yes, it's something we would like to have for tomorrow's deadline | 15:20 |
| *** dviroel is now known as dviroel|lunch | 15:21 | |
| eharney | i would assume we'll just backport this later | 15:21 |
| enriquetaso | i'll add a comment for the commit msg | 15:21 |
| enriquetaso | yes | 15:21 |
| enriquetaso | OK | 15:21 |
| enriquetaso | #topic Failed to set image property. Invalid input for field/attribute simplestreams_metadata. Value: ... is too long (HTTP 400) | 15:21 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1988942 | 15:21 |
| enriquetaso | The reporter has an error message when setting a long simplestreams_metadata to a volume. "badRequest": {"code": 400, "message": "Invalid input for field/attribute simplestreams_metadata" is too long (HTTP 400). | 15:21 |
| enriquetaso | Simplestream is a 'protocol' for describing what virtual machine images exist on an http(s) repository. And as far as I can tell Glance uses it to Implement automatic Glance image updates: | 15:22 |
| enriquetaso | https://docs.openstack.org/charm-guide/latest/admin/ops-auto-glance-image-updates.html | 15:22 |
| enriquetaso | I'm not sure about the input the reporter use to try it without simplestreams and see if this is a cinder issue or a simplestreams feature problem. | 15:22 |
| eharney | this looks like a request to expand a metadata field size | 15:22 |
| enriquetaso | Please let me know if you have faced this error before or if you have any thoughts regarding this so I can update the bug report. | 15:22 |
| enriquetaso | is a request or a bug? | 15:22 |
| eharney | it looks more like they are hitting a set limitation, not really a bug, but something we should evaluate | 15:23 |
| enriquetaso | makes sense | 15:23 |
| eharney | it would benefit from a more clear report and explanation of their use case | 15:23 |
| enriquetaso | I'll move it to whist list | 15:24 |
| enriquetaso | yes | 15:24 |
| enriquetaso | i can ask for that | 15:24 |
| enriquetaso | OK. Last two bugs | 15:25 |
| enriquetaso | #topic Hitachi driver: no message for resource lock | 15:25 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1989176 | 15:25 |
| enriquetaso | There's a minimal command problem in the code and the logs are not displaying correctly. | 15:25 |
| enriquetaso | Fix proposed to master (it's a XS fix) | 15:25 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/856385 | 15:25 |
| eharney | already approved | 15:26 |
| enriquetaso | mentioned in the cinder main meeting ^ it's a really small fix | 15:26 |
| enriquetaso | fast :D | 15:26 |
| enriquetaso | Last bug: | 15:26 |
| enriquetaso | #topic IPV6 with lightos driver wont work | 15:26 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1989281 | 15:26 |
| yuval | o/ | 15:26 |
| enriquetaso | no bug fix proposed yet | 15:26 |
| enriquetaso | hello yuval | 15:26 |
| eharney | https://review.opendev.org/c/openstack/cinder/+/839768 is the bugfix | 15:26 |
| enriquetaso | sorry | 15:26 |
| yuval | hey there is a patch up | 15:26 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/839768 | 15:27 |
| eharney | yuval: it would be better to fix the commit message so the patch links to the bug report | 15:27 |
| yuval | got it | 15:27 |
| enriquetaso | excellent | 15:27 |
| yuval | if I update the commit now - It can still meet the deadline? | 15:27 |
| eharney | i don't know if anyone is going to review this today, but it's easily backportable | 15:28 |
| yuval | I would really prefer not to reach there | 15:29 |
| enriquetaso | OK, we are running out of time | 15:30 |
| enriquetaso | thank you for joining! | 15:30 |
| eharney | we also have https://bugs.launchpad.net/cinder/+bug/1989514 | 15:30 |
| enriquetaso | oh, I lost that one | 15:30 |
| eharney | i need to dig into this one, looks important for NFS | 15:30 |
| enriquetaso | #topic NFS volume snapshot does not update volume attachment format to qcow2 | 15:31 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1989514 | 15:31 |
| opendevreview | yuval proposed openstack/cinder master: lightos: parse urls with urlparse for ipv6 support https://review.opendev.org/c/openstack/cinder/+/839768 | 15:31 |
| yuval | the commit is updated | 15:31 |
| enriquetaso | Summary They found that after performing a volume snapshot on a stopped instance, that instance could no longer boot. | 15:32 |
| enriquetaso | thanks yuval, i'll review it once zuul vote | 15:32 |
| yuval | Thanks | 15:32 |
| enriquetaso | eharney, I going to take a look to it, since i'm working with nfs right now. | 15:32 |
| eharney | cool | 15:33 |
| enriquetaso | This reminds me that i haven't check this scenario with encryption NFS | 15:33 |
| eharney | https://review.opendev.org/c/openstack/cinder/+/762462 is doing something related, probably worth touching on while looking at this | 15:33 |
| enriquetaso | whoami-rajat, feel free to re review https://review.opendev.org/c/openstack/cinder/+/839768 if you have time :D | 15:33 |
| eharney | well, i think that is where this report came from | 15:33 |
| eharney | er, no, it's not, sorry | 15:33 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/762462 | 15:34 |
| enriquetaso | oh | 15:34 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/857528 | 15:34 |
| enriquetaso | #topic open discussion | 15:35 |
| enriquetaso | Feel free to proposed bugs to discuss now | 15:36 |
| enriquetaso | OK, looks like we don't have any other bug | 15:39 |
| enriquetaso | or a bug that i forgot to include to the email bug report | 15:39 |
| enriquetaso | Thank you for joining | 15:40 |
| enriquetaso | #endmeeting | 15:40 |
| opendevmeet | Meeting ended Wed Sep 14 15:40:05 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:40 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-09-14-15.00.html | 15:40 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-09-14-15.00.txt | 15:40 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-09-14-15.00.log.html | 15:40 |
| yuval | Thank you | 15:40 |
| *** dviroel|lunch is now known as dviroel | 16:43 | |
| opendevreview | Merged openstack/cinder master: db: Remove weird error handling code https://review.opendev.org/c/openstack/cinder/+/844962 | 16:50 |
| opendevreview | Merged openstack/cinder master: Hitachi: fix to output resource lock message correctly https://review.opendev.org/c/openstack/cinder/+/856385 | 16:50 |
| opendevreview | Merged openstack/cinder master: RBD backend QoS implementation https://review.opendev.org/c/openstack/cinder/+/820027 | 16:57 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Add cephfs_nfs_cluster_id option https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/857742 | 17:12 |
| stephenfin | hemna: Could you check out my response on https://review.opendev.org/c/openstack/cinder/+/846173/ when you've time? | 17:43 |
| sfv880_ | Hello rosmaita, Replied on https://review.opendev.org/c/openstack/cinder/+/852009 - Thank you very much! | 18:32 |
| rosmaita | ack | 18:32 |
| opendevreview | Merged openstack/cinder master: Infinidat: support for manage/unmanage API https://review.opendev.org/c/openstack/cinder/+/852009 | 20:19 |
| *** dviroel is now known as dviroel|afk | 20:26 | |
| *** dviroel|afk is now known as dviroel | 22:12 | |
| *** dviroel is now known as dviroel|afk | 22:52 | |
| opendevreview | Merged openstack/cinder master: lightos: parse urls with urlparse for ipv6 support https://review.opendev.org/c/openstack/cinder/+/839768 | 23:06 |
| opendevreview | Merged openstack/cinder master: Fix and unify capacity calculations https://review.opendev.org/c/openstack/cinder/+/831247 | 23:28 |
| opendevreview | Alexander Deiter proposed openstack/cinder master: Fix Infinidat driver to use TLS/SSL communication https://review.opendev.org/c/openstack/cinder/+/849846 | 23:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!