| opendevreview | Rajat Dhasmana proposed openstack/cinder stable/2023.2: Add cinder-manage command to update service_uuid https://review.opendev.org/c/openstack/cinder/+/929873 | 05:48 |
|---|---|---|
| opendevreview | Harsh Ailani proposed openstack/cinder master: [IBM SVf Driver] Added support of clone operation for volumegroup https://review.opendev.org/c/openstack/cinder/+/929777 | 06:46 |
| *** geguileo is now known as Guest3904 | 07:44 | |
| opendevreview | Vrinda Dhakad proposed openstack/cinder master: Doc: Documentation updates for ibm-svf-volumegroup feature. https://review.opendev.org/c/openstack/cinder/+/929906 | 11:10 |
| hemna | jbernard: yup. Looking at the code in volume manager the snapshots are not updated. :( | 13:34 |
| hemna | They are left behind and then effectively orphaned. | 13:34 |
| jbernard | hemna: that's not awesome | 13:34 |
| jbernard | hemna: i looked at incus/lxd, they default to moving snapshots, --volume-only can be used to defeat this behaivour | 13:35 |
| hemna | had a customer run into it this week. I was unaware that it was even allowed to move a volume with snaps to a different project and that snaps don't go with it. | 13:35 |
| hemna | there is an API option to force no snapshots to be moved....and I can't understand why that is even an option. | 13:36 |
| jbernard | does our tests protect this behaviour? i wonder if someone actually relies on the way it currently works | 13:36 |
| hemna | when you try and create a volume from a snapshot, the volume can't be found as it's owned by the new project. and so the volume type can't be determined... | 13:37 |
| hemna | whole mess ensues | 13:37 |
| jbernard | that's definately a bug | 13:37 |
| jbernard | oy :) | 13:37 |
| eharney | pretty sure the no-snapshots option was there for the theoretical user who wanted it to behave as it did before, and fail if a transfer was requested for a volume with snapshots | 13:53 |
| opendevreview | Takashi Kajinami proposed openstack/cinder master: datacore: Mock is_valid_ipv6 to fix unit tests with netaddr >= 1.0.0 https://review.opendev.org/c/openstack/cinder/+/929932 | 13:53 |
| tkajinam | lajoskatona, thanks for catching the problem . Please see ^^^ when you have time (I've left a comment in your patch to point it). | 13:57 |
| tkajinam | I've run unit tests with tweaked u-c to use netaddr and confirmed all datacore tests, which failed in the req bump patch, pass | 13:57 |
| tkajinam | netaddr 1.0.0, I mean | 13:58 |
| opendevreview | Takashi Kajinami proposed openstack/cinder master: datacore: Mock is_valid_ipv6 to fix unit tests with netaddr >= 1.0.0 https://review.opendev.org/c/openstack/cinder/+/929932 | 14:03 |
| opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph stable/2024.1: Delete package-based-installation test jobs https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/929943 | 14:38 |
| lajoskatona | tkajinam: thanks for checking, and good news that netaddr bumping is only for unit tests, I am fine with your aproach | 14:49 |
| opendevreview | Merged openstack/cinder stable/2023.2: Add cinder-manage command to update service_uuid https://review.opendev.org/c/openstack/cinder/+/929873 | 14:56 |
| lajoskatona | tkajinam: I checked your patch locally and with netaddr ==1.3.0, and it failed for me (I executed just the unit tests) | 15:09 |
| opendevreview | Takashi Kajinami proposed openstack/cinder master: datacore: Mock is_valid_ipv6 to fix unit tests with netaddr >= 1.0.0 https://review.opendev.org/c/openstack/cinder/+/929932 | 15:49 |
| opendevreview | Merged openstack/devstack-plugin-ceph master: Follow Up Patch Fix Ingress Deamon https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/928268 | 16:32 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!