| opendevreview | Rajat Dhasmana proposed openstack/cinder stable/2023.1: Add cinder-manage command to update service_uuid https://review.opendev.org/c/openstack/cinder/+/929993 | 05:15 |
|---|---|---|
| kpdev | hi core-folks,, I need review on https://review.opendev.org/c/openstack/cinder/+/847536, expecting to land in rc1 | 06:31 |
| *** geguileo is now known as Guest4005 | 08:05 | |
| razoff | Hi everyone ! I have a question for the cinder community. I am developping a homemade cinder backup driver (extends from chunkeddriver.ChunkedBackupDriver) and I cannot figure out how to know if from the CLI the --incremental parameter is set. Can anybody help me ? | 08:49 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Fix: Unset default type for non-existent project https://review.opendev.org/c/openstack/cinder/+/930009 | 09:43 |
| opendevreview | Luigi Toscano proposed openstack/cinder-tempest-plugin master: DNM Test ceph deps https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/930017 | 11:45 |
| tosky | hello! This change should significantly cut the running time of one of the gate jobs: https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/929316 | 11:57 |
| rosmaita | razoff: the CLI calls the cinder REST API, which processes the flag here: | 12:35 |
| rosmaita | https://github.com/openstack/cinder/blob/master/cinder/api/contrib/backups.py#L167 | 12:35 |
| rosmaita | and then passes it to the backup api here: | 12:35 |
| rosmaita | https://github.com/openstack/cinder/blob/master/cinder/api/contrib/backups.py#L190 | 12:35 |
| rosmaita | which receives it here: | 12:35 |
| rosmaita | https://github.com/openstack/cinder/blob/master/cinder/backup/api.py#L224 | 12:35 |
| rosmaita | and processes it here to get the 'parent' and 'parent_id': | 12:35 |
| rosmaita | https://github.com/openstack/cinder/blob/master/cinder/backup/api.py#L269 | 12:35 |
| rosmaita | and then creates a backup object that gets handed off to the rpc api | 12:35 |
| rosmaita | so by the time the driver sees the backup object, there is no 'incremental' flag | 12:35 |
| rosmaita | whether it's incremental is based on having a non-None parent or parent_id, for example: | 12:35 |
| rosmaita | https://github.com/openstack/cinder/blob/master/cinder/backup/chunkeddriver.py#L529 | 12:35 |
| rosmaita | razoff: ^^ | 12:35 |
| opendevreview | Merged openstack/cinder stable/2023.1: Add cinder-manage command to update service_uuid https://review.opendev.org/c/openstack/cinder/+/929993 | 13:57 |
| razoff | Thanks rosmaita. I am facing an issue where --incremental seems to be ignored. | 14:02 |
| razoff | Any advice on how to debug cinder when it is called from the cli ? | 14:03 |
| rosmaita | razoff: which CLI are you using? cinderclient or openstackclient? | 14:03 |
| razoff | openstack client I think I usually do openstack volume backup create --incremental ... | 14:03 |
| rosmaita | razoff: if you make your call start with 'openstack --debug ...' i think it will print out the API requests it is making, and you can at least verify that the flag is being passed to the cinder API | 14:07 |
| razoff | With debug activated I find that run(Namespace(formatter='json', columns=[], noindent=False, variables=[], prefix='', max_width=0, fit_width=False, print_empty=False, volume='7fd5ec3b-6eef-48b5-aa86-6afb51e3aec7', name='fb1a0304-8ec5-42ec-8b08-e9f9a8f8d128_1726838355', description='description', container=None, snapshot='<snapshotid>, force=True, incremental=True, no_incremental=True, .. | 14:12 |
| razoff | There is a incremental=true and no_incremental=true might that be an issue ? | 14:12 |
| razoff | openstack volume backup create --force --incremental --format json --name fb1a0304-8ec5-42ec-8b08-e9f9a8f8d128_1726838355 --description "description" --snapshot 067ae403-dc56-49e1-9668-9ae536165296 --debug 7fd5ec3b-6eef-48b5-aa86-6afb51e3aec7 | 14:14 |
| razoff | This is the command I ran to get this output in the debug | 14:14 |
| rosmaita | razoff: that looks weird (the no_incremental flag) | 14:18 |
| rosmaita | also, i wonder whether that's the formatting for the response or something | 14:19 |
| opendevreview | Takashi Kajinami proposed openstack/cinder master: Record the original size when creating an image from a volume https://review.opendev.org/c/openstack/cinder/+/804584 | 14:57 |
| opendevreview | Eric Harney proposed openstack/cinder stable/2024.1: Optimize rbd upload volume to image https://review.opendev.org/c/openstack/cinder/+/930071 | 15:05 |
| *** geguileo is now known as Guest4036 | 15:16 | |
| opendevreview | Rajat Dhasmana proposed openstack/cinder stable/2024.2: Add cinder-manage command to update service_uuid https://review.opendev.org/c/openstack/cinder/+/930072 | 15:42 |
| opendevreview | Eric Harney proposed openstack/cinder master: Huawei hypermetro: RECOVERYPOLICY typo https://review.opendev.org/c/openstack/cinder/+/925501 | 15:49 |
| opendevreview | Luigi Toscano proposed openstack/cinder-tempest-plugin master: Port to the tempest stable plugin interface (clients) https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/929620 | 15:54 |
| opendevreview | Merged openstack/cinder stable/2024.2: Add cinder-manage command to update service_uuid https://review.opendev.org/c/openstack/cinder/+/930072 | 16:43 |
| opendevreview | Luigi Toscano proposed openstack/cinder-tempest-plugin master: Use the proper condition for volume encryption transfer tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/930085 | 20:14 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!