| *** mhen_ is now known as mhen | 02:30 | |
| opendevreview | Medha Choudhary proposed openstack/cinder master: [DNM]: Testing cinder ci https://review.opendev.org/c/openstack/cinder/+/975602 | 09:44 |
|---|---|---|
| opendevreview | Florent Le Lain proposed openstack/cinder master: Fix encryption key cleanup when volume creation fails https://review.opendev.org/c/openstack/cinder/+/975304 | 10:14 |
| opendevreview | Raghavendra Tilay proposed openstack/cinder master: [DNM] - do not merge - test patch https://review.opendev.org/c/openstack/cinder/+/975619 | 11:34 |
| *** debian is now known as Guest1463 | 12:21 | |
| yuval_ | there is a meeting now? | 14:01 |
| kaisers | i think so | 14:02 |
| raghavendrat | hhmm | 14:02 |
| yuval_ | jbernard: ? | 14:02 |
| jbernard | yes, i need a minute, school was supposed be 2 hours delayed, but closed again, rosmaita are you able to get it started? | 14:04 |
| rosmaita | sure | 14:04 |
| rosmaita | #startmeeting cinder | 14:04 |
| opendevmeet | Meeting started Wed Feb 4 14:04:44 2026 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:04 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:04 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:04 |
| rosmaita | #topic roll call | 14:04 |
| kaisers | o/ | 14:04 |
| harsh | o/ | 14:05 |
| raghavendrat | hi | 14:05 |
| RanjithRethinam | hi | 14:05 |
| rosmaita | kind of a low turnout, but i guess we can get started | 14:07 |
| rosmaita | #topic announcements | 14:07 |
| simondodsley | o/ | 14:08 |
| rosmaita | Friday is the first Friday in February, so that means ... | 14:08 |
| rosmaita | Festival of Reviews! | 14:08 |
| kaisers | huzza | 14:08 |
| rosmaita | #link https://meetings.opendev.org/#Cinder_Festival_of_Reviews | 14:08 |
| nimeshdesai | o/ | 14:08 |
| rosmaita | try to clear some space on your calendar, and hopefully we can get some stuff reviewed and merged | 14:09 |
| yuval_ | is there a list of candidates? | 14:09 |
| rosmaita | i think the general review request list: https://etherpad.opendev.org/p/cinder-gazpacho-reviews | 14:10 |
| rosmaita | though we will try to do some sorting prior to the festival | 14:11 |
| jbernard | o/ | 14:11 |
| rosmaita | yay, Jon is here ... you can take over | 14:11 |
| jbernard | lol | 14:11 |
| jbernard | you're doing just fine ;) | 14:11 |
| jbernard | i don't have anything personally, still in snow-shutdown from 2 weeks ago | 14:12 |
| rosmaita | #chair jbernard | 14:13 |
| opendevmeet | Current chairs: jbernard rosmaita | 14:13 |
| jbernard | i have been trying to go through some reviews on the etherpad | 14:13 |
| rosmaita | #unchair rosmaita | 14:13 |
| opendevmeet | Current chairs: jbernard rosmaita | 14:13 |
| jbernard | #topic open discussion | 14:13 |
| jbernard | if we need to discuss anything we can do that now, or break early - whatever is best | 14:14 |
| harsh | how can we resolve the 1000 commit error message for the review : 926844: [IBM SVf Driver] Added support for volumegroup-snapshot for temporary volumegroup | https://review.opendev.org/c/openstack/cinder/+/926844 | 14:14 |
| harsh | without having to create a new review ? | 14:14 |
| rosmaita | harsh: i don't think you can | 14:14 |
| rosmaita | jbernard: i forgot to mention the midcycle in the 'announcements' earlier | 14:14 |
| harsh | can we merge it ? :D had a +2 from jbernard and i resolved your last comments. | 14:15 |
| jbernard | rosmaita: ^ you had a -1 on that, where are you currently standing? | 14:15 |
| jbernard | ahh yes, next wednesday is midcycle | 14:15 |
| harsh | If there is anything to address, i can take care of that in the other 28 linked patches on top of this one? | 14:16 |
| RanjithRethinam | can we review this, this had one +2 once: https://review.opendev.org/c/openstack/cinder/+/971739 | 14:16 |
| Luzi | o/ | 14:16 |
| jbernard | etherpad for midcycle: https://etherpad.opendev.org/p/cinder-gazpacho-midcycles | 14:16 |
| jbernard | please add topics, we are likely to fill any unused time with code reviews | 14:16 |
| yuval_ | harsh: why not checkout origin/master and cherry-pick your commit and push | 14:17 |
| yuval_ | I have this patch: https://review.opendev.org/c/openstack/os-brick/+/957599 | 14:17 |
| yuval_ | we agreed on merging it but I dont get the +2 and afraid to miss the merge window | 14:17 |
| rosmaita | about https://review.opendev.org/c/openstack/cinder/+/926844 ... i am fine with the revision, but assumed that the 1K gerrit update limit will prevent us from merging | 14:18 |
| rosmaita | jbernard: we can +2A it and see what happens | 14:18 |
| rosmaita | well, what happens is I can't leave a +2 on it | 14:19 |
| harsh | :( | 14:19 |
| rosmaita | harsh: you'll have to do what i outlined in this channel yesterday or whenever you asked | 14:19 |
| jbernard | yeah.. need to create a new review and reference the old one | 14:20 |
| jbernard | harsh: ping me and i can move it along quickly | 14:20 |
| jbernard | just to clarify, we all agree that this is in good shape? | 14:20 |
| harsh | rosmaita: i went offline and the history got erased. could you share the outline again please? | 14:20 |
| jbernard | https://review.opendev.org/c/openstack/cinder/+/926844 | 14:20 |
| rosmaita | harsh: https://meetings.opendev.org/irclogs/%23openstack-cinder/%23openstack-cinder.2026-02-02.log.html#openstack-cinder.2026-02-02.log.html#t2026-02-02T13:18:56 | 14:21 |
| harsh | jbernard: thanks ! | 14:21 |
| harsh | rosmaita: thanks ! | 14:22 |
| harsh | i will follow on the steps | 14:22 |
| rosmaita | np, you can be proud of being the guy who pushed gerrit to the very edge of its capabilities! | 14:23 |
| jbernard | rosmaita: you're good with that patch, yes? also yuval_'s brick patch had a -1 from you, if you get a chance to re-review we should be able to move that one too | 14:23 |
| harsh | :D | 14:23 |
| rosmaita | yeah, i am fine with harsh's revisions, will +2 the new patch | 14:23 |
| jbernard | awesome | 14:23 |
| RanjithRethinam | #jbernard: can we pls have this pr reviewed and merged: https://review.opendev.org/c/openstack/cinder/+/971739 it had one +2 from Sean already. Im afraid we may miss the merge window | 14:23 |
| jbernard | RanjithRethinam: it would help if eric re-reviewed it, when i see it i thin eric has it in progress | 14:25 |
| jbernard | eharney: ^ do you have some cycles today to take a look | 14:25 |
| rosmaita | i thought i had +2d yuval's brick patch, but apparently not ... sure hope i didn't +2 some other patch that was open in a browser window | 14:25 |
| jbernard | lol | 14:25 |
| raghavendrat | hi, may i ask query about Caracal branch | 14:26 |
| jbernard | sure | 14:26 |
| yuval_ | rosmaita: lol | 14:27 |
| jbernard | RanjithRethinam: i will reach out to eric and see if we can move forward, ping me later if you haven't heard anything | 14:27 |
| RanjithRethinam | sure thanks! | 14:28 |
| eharney | i'll try to take a look soon | 14:28 |
| raghavendrat | In https://etherpad.opendev.org/p/cinder-gazpacho-reviews i had added below Caracal backport | 14:28 |
| raghavendrat | https://review.opendev.org/c/openstack/cinder/+/971002 | 14:28 |
| raghavendrat | Someone put a comment: 2024.1 is unmaintained, cinder cannot merge this | 14:28 |
| yuval_ | what do we think about AI assisted patches or patches written completely by AI. how do we deal with that? | 14:28 |
| raghavendrat | is there any other team that can merge this please? | 14:28 |
| jbernard | raghavendrat: that was me | 14:28 |
| eharney | yuval_: https://openinfra.org/legal/ai-policy | 14:29 |
| jbernard | raghavendrat: there is a different unmaintained team that has +2 ability, cinder doesn't have that | 14:29 |
| erlon | \o late | 14:29 |
| raghavendrat | is there a separate IRC channel for unmaintained ? | 14:30 |
| yuval_ | eharney: thanks | 14:30 |
| rosmaita | raghavendrat: i think so, check your irc channel list | 14:30 |
| rosmaita | it's #openstack-unmaintained | 14:30 |
| raghavendrat | thank you. i will check | 14:30 |
| yuval_ | didnt know openstack-unmaintained exists | 14:31 |
| jbernard | erlon: thanks for the alletra reviews | 14:31 |
| rosmaita | jbernard: if you can hit yuval's patch https://review.opendev.org/c/openstack/os-brick/+/957599 , i will propose an os-brick release as soon as it merges | 14:31 |
| rosmaita | will catch the new config opts + the dell upgrade fix | 14:32 |
| jbernard | ahh, i remember discussing this one a few weeks ago | 14:32 |
| opendevreview | Eric Harney proposed openstack/cinder master: Require Gazpacho oslo.service https://review.opendev.org/c/openstack/cinder/+/975637 | 14:32 |
| jbernard | done | 14:32 |
| erlon | np, its been a bit busy around here, so I couldn't get the time I wanted for reviews this week | 14:33 |
| jbernard | i can relate :) | 14:34 |
| * noonedeadpunk has a couple of review requests as well :) | 14:35 | |
| jbernard | noonedeadpunk: sure | 14:35 |
| noonedeadpunk | #link https://review.opendev.org/c/openstack/cinder/+/959425 | 14:35 |
| noonedeadpunk | the spec for this change has been merged | 14:35 |
| noonedeadpunk | so it would be nice to get it in eventually | 14:36 |
| noonedeadpunk | And I assume we're out of spec approval window now, so I guess I need to re-propose second one for 2026.2? | 14:36 |
| jbernard | yep, will do | 14:36 |
| noonedeadpunk | #link https://review.opendev.org/c/openstack/cinder-specs/+/962306 | 14:36 |
| jbernard | yes, curious if rosmaita and simone have followups | 14:37 |
| jbernard | i think we can technically review and merge a spec before the start of the target cycle | 14:38 |
| rosmaita | well, i don't like https://review.opendev.org/c/openstack/cinder-specs/+/962306 but i'm not sure i would block it either | 14:39 |
| rosmaita | it adds some operator responsibility that i think is asking for trouble, but that's just my opinion | 14:39 |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: WIP: new extend after snapshot test https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/975561 | 14:39 |
| rosmaita | noonedeadpunk did answer my concerns on the review, so they are there for other reviewers to think about | 14:40 |
| noonedeadpunk | well, we kinda want a way to strucutre the backups on underlying systems | 14:40 |
| noonedeadpunk | instead of placing everything in a single bucket, which is really problematic | 14:41 |
| rosmaita | i agree that the goal is good | 14:41 |
| rosmaita | and it could be that this is the only way to do it | 14:41 |
| noonedeadpunk | yeah, implementation is kinda limited by current flow... | 14:41 |
| rosmaita | i'm just not sure | 14:42 |
| opendevreview | Harsh Ailani proposed openstack/cinder master: [IBM SVf Driver] Added support for volumegroup-snapshot for temporary volumegroup https://review.opendev.org/c/openstack/cinder/+/975638 | 14:42 |
| noonedeadpunk | if there's an idea how to do it differently - I'm happy to check on it and re-write the spec | 14:42 |
| rosmaita | noonedeadpunk: if you dont' get any action on your specs in the next few days, put a discussion on the agenda for the midcycle | 14:42 |
| erlon | noonedeadpunk: so, just to confirm that doesn't change the default behavior right? | 14:43 |
| erlon | backup_create_containers=True, means it will continue to create new containers (even that might mean a container with the wrong name, which is what the change is trying to fix) | 14:44 |
| harsh | rosmaita jbernard : I created the new review : 975638: [IBM SVf Driver] Added support for volumegroup-snapshot for temporary volumegroup | https://review.opendev.org/c/openstack/cinder/+/975638 | 14:44 |
| rosmaita | ack | 14:44 |
| noonedeadpunk | erlon: no, it does not change the default behavior | 14:45 |
| noonedeadpunk | I think the change tries to allow operator to avoid such cases, while not breaking ones who rely on it | 14:46 |
| erlon | I think that might lead to unpredictable behavior during cloud updates. By leaving the default as false, we still allow those affected by this issue to intentionally 'fix' the behavior for their clouds. | 14:48 |
| erlon | noonedeadpunk: would that solve the problem for you? | 14:48 |
| noonedeadpunk | erlon: um. I am confused now. today cinder-backup does create containers whenever client asks for it. So `backup_create_containers=True` preserves existing behavior, right? | 14:50 |
| erlon | now Im confused, lol | 14:50 |
| noonedeadpunk | and your suggestion is to change the behavior or keep it? | 14:50 |
| noonedeadpunk | as I was trying to keep existing thing by default | 14:51 |
| erlon | yes, I think we're talking the same thing. We both want the behavior to be preserved. I asked you to confirm if 'backup_create_containers=True', preserves the current behavior, which seems to be the case. | 14:52 |
| noonedeadpunk | yes, it does preserve the behavior | 14:52 |
| noonedeadpunk | (at least that was the intention :D) | 14:53 |
| erlon | ah, ok, it was my understanding from my review as well. so, in that case I think we are good to go in that change. | 14:53 |
| jbernard | cool, noonedeadpunk if you want to retarget the spec, we should be able to reach a consensus quickly | 14:55 |
| jbernard | 5 minutes remain, anything else to cover? | 14:56 |
| kaisers | one more small review request: https://review.opendev.org/c/openstack/cinder/+/967672 (1x +2 so far), would be great to have it reviewed by another core, it's an unsupported flag removal | 14:56 |
| raghavendrat | eharney: i tried to address comments on below patch: New cinder driver for HPE Alletra MP | 14:56 |
| raghavendrat | https://review.opendev.org/c/openstack/cinder/+/969373 | 14:57 |
| raghavendrat | It would be great if you could revisit patch. Thanks. | 14:57 |
| nimeshdesai | Need reviews on the register Plugin patches from IBM, these have been discussed in the past and all comments addressed - [IBM SVf driver] Adding support for CINDER plugin registration | https://review.opendev.org/c/openstack/cinder/+/951829 | 14:57 |
| erlon | raghavendrat: I dropped another review today on that one if you can address those | 14:57 |
| noonedeadpunk | jbernard: if it's too late for this cycle, I'm fine to re-target it | 14:57 |
| jbernard | noonedeadpunk: hmm, is the code up already? | 14:58 |
| nimeshdesai | IBM patches are also added in the festival of reviews etherpad | 14:58 |
| raghavendrat | thanks erlon: | 14:58 |
| noonedeadpunk | jbernard: yep | 14:59 |
| noonedeadpunk | #link https://review.opendev.org/c/openstack/cinder/+/962909 | 14:59 |
| jbernard | noonedeadpunk: ahh, ok lets see how that review progresses, ill keep an eye on it | 15:01 |
| jbernard | last call | 15:02 |
| jbernard | thanks everyone, and thanks rosmaita for getting things started | 15:02 |
| lutimura | jbernard: just to let you know, i submitted a new patchset to https://review.opendev.org/c/openstack/cinder/+/958707; please let me know if there's anything else i should include there (you'd reviewed it in the past) | 15:02 |
| jbernard | #endmeeting | 15:02 |
| opendevmeet | Meeting ended Wed Feb 4 15:02:29 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:02 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2026/cinder.2026-02-04-14.04.html | 15:02 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2026/cinder.2026-02-04-14.04.txt | 15:02 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2026/cinder.2026-02-04-14.04.log.html | 15:02 |
| raghavendrat | thank you all | 15:02 |
| jbernard | eharney: ^ that might be one you want to look at (encryption related) | 15:03 |
| noonedeadpunk | between. I have one more related change to for backups. I don't have a spec for it though | 15:43 |
| noonedeadpunk | #link https://review.opendev.org/c/openstack/cinder/+/958671 | 15:43 |
| opendevreview | Takashi Kajinami proposed openstack/cinder master: Fix python shebang https://review.opendev.org/c/openstack/cinder/+/898600 | 15:52 |
| opendevreview | Merged openstack/os-brick master: LightOS: update discovery client configuration https://review.opendev.org/c/openstack/os-brick/+/957599 | 16:32 |
| opendevreview | Gireesh Awasthi proposed openstack/cinder master: NetApp - Fix for LUN and namespace name handling in cache for ASAr2 https://review.opendev.org/c/openstack/cinder/+/975667 | 16:34 |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: WIP: new extend after snapshot test https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/975561 | 18:38 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!