| *** _navneet has joined #openstack-containers | 00:03 | |
| *** achanda has joined #openstack-containers | 00:06 | |
| *** _navneet has quit IRC | 00:08 | |
| *** dimtruck is now known as zz_dimtruck | 00:15 | |
| openstackgerrit | Merged openstack/magnum: Add explicit requirement for decorator module https://review.openstack.org/218540 | 00:38 |
|---|---|---|
| *** achanda has quit IRC | 00:44 | |
| *** hongbin has joined #openstack-containers | 00:58 | |
| *** yuanying-alt has joined #openstack-containers | 01:10 | |
| *** harshs has joined #openstack-containers | 01:13 | |
| *** yuanying-alt has quit IRC | 01:14 | |
| *** erkules_ has joined #openstack-containers | 01:23 | |
| *** zz_dimtruck is now known as dimtruck | 01:24 | |
| *** zhenguo has joined #openstack-containers | 01:24 | |
| *** erkules has quit IRC | 01:26 | |
| *** dimtruck is now known as zz_dimtruck | 01:29 | |
| *** achanda has joined #openstack-containers | 01:37 | |
| *** vilobhmm1 has joined #openstack-containers | 01:42 | |
| *** vilobhmm11 has joined #openstack-containers | 01:43 | |
| openstackgerrit | Hua Wang proposed openstack/magnum: [WIP] Generate keystone trust https://review.openstack.org/218699 | 01:45 |
| *** vilobhmm1 has quit IRC | 01:47 | |
| *** eghobo has quit IRC | 01:49 | |
| *** mathspanda has joined #openstack-containers | 01:50 | |
| *** tbh has joined #openstack-containers | 02:01 | |
| *** tbh has quit IRC | 02:06 | |
| vilobhmm11 | Kennan : ping | 02:17 |
| *** achanda has quit IRC | 02:22 | |
| *** eghobo has joined #openstack-containers | 02:23 | |
| *** liangbo has joined #openstack-containers | 02:23 | |
| *** achanda has joined #openstack-containers | 02:24 | |
| Kennan | hi vilobhmm11: what's up | 02:31 |
| *** kebray has joined #openstack-containers | 02:33 | |
| *** kebray has quit IRC | 02:33 | |
| *** kebray has joined #openstack-containers | 02:34 | |
| *** harshs has quit IRC | 02:52 | |
| *** kebray_ has joined #openstack-containers | 02:53 | |
| yuanying | Is humble__ Hua Wang? | 02:54 |
| humble__ | yuanying: yes | 02:55 |
| yuanying | Oh, I have question | 02:55 |
| humble__ | yuanying: What | 02:55 |
| yuanying | About this https://review.openstack.org/#/c/218699 | 02:55 |
| *** kebray has quit IRC | 02:56 | |
| yuanying | I want to keystone session which has admin context like https://review.openstack.org/#/c/188703/9/neutron_lbaas/common/keystone.py | 02:56 |
| yuanying | Can you separate your patch, one is refactor keystone client, and second is "generate keystone trust" | 02:57 |
| humble__ | yuanying: OK, I will seperate my patch | 02:58 |
| yuanying | thanks a lot! | 02:58 |
| humble__ | yuanying: What is your purpose for keystone session | 02:58 |
| yuanying | barbican requires keystone session | 02:58 |
| yuanying | and also I want to keystone session which has admin context | 02:59 |
| *** yuanying-alt has joined #openstack-containers | 02:59 | |
| *** Tennyson has joined #openstack-containers | 02:59 | |
| humble__ | Ok, I will add it to keystone client | 02:59 |
| yuanying | https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/common/cert_manager/barbican_cert_manager.py#L72 | 02:59 |
| *** yuanying-alt has quit IRC | 03:04 | |
| vilobhmm11 | Kennan : sorry was away….regarding https://review.openstack.org/#/c/217865/2/magnum/db/sqlalchemy/api.py | 03:04 |
| vilobhmm11 | I was thinking we need to change the exception raised here to a more valid one as in something like ReplicationControllerNotFoundNoBayExist | 03:05 |
| vilobhmm11 | Kennan : what do you think ? ^^ | 03:10 |
| humble__ | vilobhmm11: It makes sense | 03:17 |
| *** eghobo has quit IRC | 03:17 | |
| Kennan | hi vilobhmm11: | 03:25 |
| Kennan | what's the exception now ? for get_bay_uuid? let me check | 03:25 |
| *** vilobhmm11 has quit IRC | 03:26 | |
| *** vilobhmm1 has joined #openstack-containers | 03:27 | |
| vilobhmm1 | Kennan : https://github.com/openstack/magnum/blob/master/magnum/db/sqlalchemy/api.py#L695 | 03:27 |
| *** apmelton has quit IRC | 03:28 | |
| Kennan | vilobhmm1: it seems not need to through another so detailed exception, is BayNotFound not good to understood ? | 03:28 |
| vilobhmm1 | Kennan : IMHO its not sufficient | 03:29 |
| vilobhmm1 | its not good to understand | 03:29 |
| vilobhmm1 | there r 2 cases here | 03:29 |
| vilobhmm1 | #1. The bay does not exist | 03:29 |
| vilobhmm1 | and #2. hence the pod/rc/service does not exist | 03:29 |
| vilobhmm1 | so we should be pricise in describing why the pod/rc/services does not exist | 03:30 |
| vilobhmm1 | and thats becase the bay does not exist | 03:30 |
| *** apmelton has joined #openstack-containers | 03:30 | |
| vilobhmm1 | hence something like PodNotFoundNoBayExist/ReplicationControllerNotFoundNoBayExist/ServiceNotFoundNoBayExist is more better than just saying BayNotFound | 03:31 |
| vilobhmm1 | Kennan : ^^ | 03:31 |
| Kennan | for case#1 the bay not exist | 03:31 |
| Kennan | from code, it throws baynotfound | 03:31 |
| vilobhmm1 | true | 03:31 |
| Kennan | for case #2, bay exist, pod/service not exist | 03:31 |
| Kennan | it would throw podnotexist | 03:31 |
| Kennan | servicenotexist | 03:31 |
| vilobhmm1 | but thats not how its done today | 03:32 |
| Kennan | I did not understnad why it is not easy to understand? | 03:32 |
| Kennan | why | 03:32 |
| Kennan | from you code change | 03:32 |
| Kennan | self.get_bay_by_uuid(context, bay_uuid) | 03:32 |
| Kennan | if bay exist | 03:32 |
| Kennan | it would return | 03:32 |
| vilobhmm1 | you need to throw that podnotexits somewhere here https://github.com/openstack/magnum/blob/master/magnum/objects/pod.py#L108 when you get an empty list | 03:32 |
| Kennan | and then enter code path | 03:33 |
| Kennan | return query.all() | 03:33 |
| *** eghobo has joined #openstack-containers | 03:34 | |
| vilobhmm1 | if we disregard the changes here https://review.openstack.org/#/c/217865/2/magnum/db/sqlalchemy/api.py the query on line #892 will even fail if the bay does not exist | 03:34 |
| vilobhmm1 | and hence throw exception | 03:34 |
| Kennan | that's why I asked in your patch comments, i did not find list_by_bay_uuid any called | 03:34 |
| Kennan | in other code, it is just defined there | 03:35 |
| *** kebray_ has quit IRC | 03:37 | |
| Kennan | vilobhmm1: in short summary, if some code not used anywhere, it was old code, so need to remove it | 03:37 |
| vilobhmm1 | Kennan : true but same applies to get_pods_by_bay_uuid and get_services_by_bay_uuid | 03:37 |
| vilobhmm1 | ok | 03:37 |
| vilobhmm1 | your above statement makes sense | 03:37 |
| vilobhmm1 | dead code needs to be removed | 03:37 |
| *** kebray has joined #openstack-containers | 03:37 | |
| Kennan | vilobhmm1: if you find some codes applies CLI or rest API can kick that call happend, open one issue and append detailed descpritons | 03:38 |
| Kennan | then we can fix that | 03:38 |
| Kennan | right now, I did not find any call such object API | 03:38 |
| Kennan | so it was old died code | 03:38 |
| vilobhmm1 | get_rcs_by_bay_uuid / get_pods_by_bay_uuid / get_services_by_bay_uuid code associated with this is even dead will open a bug to clean it if that sounds ok to you | 03:39 |
| vilobhmm1 | Kennan : ^^ | 03:40 |
| *** eghobo has quit IRC | 03:40 | |
| Kennan | I am ok with that. vilobhmm1: | 03:40 |
| Kennan | thanks guy to improve our code base | 03:40 |
| vilobhmm1 | happy to help :) thanks Kennan ! | 03:41 |
| Kennan | wcl :) | 03:41 |
| *** hongbin has quit IRC | 03:42 | |
| *** jwcroppe_ has joined #openstack-containers | 03:45 | |
| vilobhmm1 | humble__: thanks for your reply | 03:46 |
| *** jwcroppe has quit IRC | 03:47 | |
| openstackgerrit | Merged openstack/magnum: tools/colorizer.py is not used anywhere https://review.openstack.org/218537 | 03:50 |
| *** vilobhmm1 has quit IRC | 03:50 | |
| *** vilobhmm1 has joined #openstack-containers | 03:51 | |
| openstackgerrit | vikas choudhary proposed openstack/magnum: Fix method and parameter descriptions https://review.openstack.org/218715 | 03:52 |
| *** vilobhmm1 has quit IRC | 04:02 | |
| *** vilobhmm1 has joined #openstack-containers | 04:04 | |
| openstackgerrit | vikas choudhary proposed openstack/magnum: Fix method and parameter descriptions https://review.openstack.org/218715 | 04:09 |
| *** eghobo has joined #openstack-containers | 04:09 | |
| *** VikasC has joined #openstack-containers | 04:36 | |
| *** yuanying-alt has joined #openstack-containers | 04:48 | |
| *** tbh has joined #openstack-containers | 04:50 | |
| *** yuanying-alt has quit IRC | 04:52 | |
| *** ig0r__ has joined #openstack-containers | 04:59 | |
| *** ig0r_ has quit IRC | 04:59 | |
| *** VikasC has quit IRC | 05:03 | |
| *** tbh has quit IRC | 05:06 | |
| *** VikasC has joined #openstack-containers | 05:08 | |
| *** tbh has joined #openstack-containers | 05:09 | |
| *** liangbo has quit IRC | 05:14 | |
| *** kebray has quit IRC | 05:17 | |
| *** tbh has quit IRC | 05:18 | |
| *** tbh has joined #openstack-containers | 05:19 | |
| VikasC | Hi Everybody | 05:22 |
| *** sdake_ has quit IRC | 05:25 | |
| *** sdake has joined #openstack-containers | 05:26 | |
| *** tbh has quit IRC | 05:27 | |
| *** tbh has joined #openstack-containers | 05:28 | |
| *** dave-mccowan has quit IRC | 05:29 | |
| *** sdake has quit IRC | 05:29 | |
| *** sdake has joined #openstack-containers | 05:30 | |
| *** chandankumar has joined #openstack-containers | 05:31 | |
| *** harshs has joined #openstack-containers | 05:43 | |
| *** sdake_ has joined #openstack-containers | 05:45 | |
| gus | container-networking-model isn't what I was expecting to find - in particular it doesn't talk about the networking model at all :/ | 05:46 |
| gus | (it seems to just talk about choosing between particular implementations - without any discussion at all of the various models they present) | 05:48 |
| gus | Err, thats the "container-network-model" *spec*. | 05:48 |
| *** sdake has quit IRC | 05:49 | |
| gus | Do we only need to support container-container within a single bay? (ie: do we want traffic coming into a k8s bay to only come in via external services?) | 05:53 |
| *** tbh has quit IRC | 05:54 | |
| *** tbh has joined #openstack-containers | 05:55 | |
| *** liangbo has joined #openstack-containers | 05:58 | |
| gus | In related news: I strongly recommend magnum switch to flannel's host-gw backend. It looks like magnum creates a dedicated neutron network for each bay, and this is exactly the situation for which I created the host-gw flannel backend. Zero packet overhead, scales to O(hundreds) of nodes. | 05:58 |
| *** shuquan has joined #openstack-containers | 06:05 | |
| tbh | did anyone write any unit test cases in magnum?, specifically on polling funciontality? | 06:08 |
| *** vilobhmm1 has quit IRC | 06:16 | |
| Kennan | gus: not quite sure what's your question. if you want to involve more discussion or question, please send your question with ML | 06:17 |
| Kennan | tbh: what's the issue | 06:17 |
| *** vilobhmm1 has joined #openstack-containers | 06:18 | |
| *** ishant has joined #openstack-containers | 06:18 | |
| tbh | Kennan, I just want to cross check the code, I wrote the test case for the bug https://bugs.launchpad.net/magnum/+bug/1489725 | 06:22 |
| openstack | Launchpad bug 1489725 in Magnum "Unable to get the status of bay with model as Docker swarm" [Undecided,In progress] - Assigned to bharaththiruveedula (bharath-ves) | 06:22 |
| tbh | Kennan, http://paste.openstack.org/show/434406/ | 06:22 |
| *** harshs has quit IRC | 06:22 | |
| tbh | Kennan, is this the correct way of testing? | 06:22 |
| *** shuquan has quit IRC | 06:23 | |
| *** shuquan has joined #openstack-containers | 06:26 | |
| Kennan | tbh: I am not sure about your functional change code | 06:29 |
| Kennan | but the test code should cover as follows: | 06:29 |
| Kennan | if you change any logic in functional | 06:29 |
| Kennan | then mock test should cover your code path | 06:29 |
| Kennan | and verified logic is your expection | 06:29 |
| *** vilobhmm1 has quit IRC | 06:30 | |
| tbh | Kennan, oh okay | 06:32 |
| tbh | Kennan, but I thought of writing the test case which change the status in heat stack to CREATE_IN_PROGRESS and poll and then assert bay.status | 06:33 |
| tbh | Kennan, as I have written in the paste | 06:34 |
| Kennan | what's your unit test for ? add test for your fix patch | 06:35 |
| Kennan | or just add another unit for existed code | 06:35 |
| *** sdake_ is now known as sdake | 06:36 | |
| openstackgerrit | vikas choudhary proposed openstack/magnum: Fix method and parameter descriptions https://review.openstack.org/218715 | 06:36 |
| tbh | Kennan, My unit case is to test the status of bay | 06:36 |
| *** yuanying-alt has joined #openstack-containers | 06:37 | |
| Kennan | so tbh: you want to add some tests right? | 06:37 |
| Kennan | it is not target to fix any issue | 06:37 |
| Kennan | right? | 06:37 |
| Kennan | tbh: you could add tests if you think some known tests coverage is not enough | 06:38 |
| Kennan | but just make sure tests not redundant from functional view | 06:39 |
| *** VikasC has quit IRC | 06:40 | |
| *** yuanying-alt has quit IRC | 06:41 | |
| tbh | Kennan, I am supposed to test this patch https://review.openstack.org/#/c/218582/ | 06:42 |
| *** j___ has joined #openstack-containers | 06:43 | |
| Kennan | tbh: that fix seems related node_count | 06:52 |
| Kennan | so your mock can test different bay types can get that node_count updated correctly | 06:53 |
| tbh | Kennan, but when I tested the self.bay.node_count it displays <MagicMock name='OpenStackClients.heat().stacks.get().parameters.__getitem__()' id='140560351144208'> | 06:54 |
| Kennan | tbh: debug code and check if mock objects have related attributes or not | 06:55 |
| *** shuquan has quit IRC | 07:00 | |
| *** BhavyaM has joined #openstack-containers | 07:00 | |
| *** BertrandN has joined #openstack-containers | 07:01 | |
| *** liangbo has quit IRC | 07:02 | |
| tbh | Kennan, sure | 07:05 |
| *** achanda has quit IRC | 07:05 | |
| *** muralia has quit IRC | 07:06 | |
| *** BertrandN has quit IRC | 07:11 | |
| openstackgerrit | bharaththiruveedula proposed openstack/magnum: Updates the node count key for all types of bay https://review.openstack.org/218582 | 07:14 |
| *** tbh has quit IRC | 07:15 | |
| *** tbh has joined #openstack-containers | 07:21 | |
| *** VikasC has joined #openstack-containers | 07:23 | |
| *** BertrandN has joined #openstack-containers | 07:27 | |
| *** apuimedo_ has joined #openstack-containers | 07:27 | |
| *** junhongl has joined #openstack-containers | 07:30 | |
| *** muralia has joined #openstack-containers | 07:38 | |
| *** tbh has quit IRC | 07:44 | |
| *** tbh has joined #openstack-containers | 07:45 | |
| *** liangbo has joined #openstack-containers | 07:49 | |
| *** eghobo has quit IRC | 07:57 | |
| *** tbh has quit IRC | 08:03 | |
| *** tbh has joined #openstack-containers | 08:03 | |
| *** apuimedo_ has quit IRC | 08:05 | |
| *** shuquan has joined #openstack-containers | 08:12 | |
| *** Jianlee has joined #openstack-containers | 08:17 | |
| *** shuquan has quit IRC | 08:24 | |
| *** shuquan has joined #openstack-containers | 08:24 | |
| *** shuquan has quit IRC | 08:25 | |
| *** yuanying-alt has joined #openstack-containers | 08:25 | |
| *** shuquan has joined #openstack-containers | 08:26 | |
| *** tbh has quit IRC | 08:30 | |
| *** yuanying-alt has quit IRC | 08:30 | |
| *** Jianlee is now known as Jian0612 | 08:31 | |
| *** tbh has joined #openstack-containers | 08:35 | |
| tbh | Kennan, you want me to check delete bay also or both delete and update? | 08:35 |
| Kennan | tbh: I suggest at least one test cover path for another node_count set | 08:36 |
| Kennan | It seems your all tests cover another path | 08:36 |
| tbh | Kennan, I didn't get you what is path? | 08:37 |
| Kennan | tbh: if I understand your tests, it all goes to | 08:38 |
| Kennan | elif stack.stack_status != self.bay.status: | 08:38 |
| Kennan | this code path | 08:38 |
| Kennan | but it not cover if (stack.stack_status in [bay_status.CREATE_COMPLETE bay_status.UPDATE_COMPLETE]): | 08:38 |
| Kennan | this | 08:38 |
| *** shuquan has quit IRC | 08:38 | |
| tbh | Kennan, okay got it | 08:38 |
| tbh | Kennan, I forgot that path, I will add it | 08:39 |
| tbh | can I check both in one after another? | 08:40 |
| tbh | and I think I have to modify the test method name | 08:40 |
| openstackgerrit | Hua Wang proposed openstack/magnum: Code refactor for keystoneclient https://review.openstack.org/218699 | 08:41 |
| Kennan | tbh: better make one test_method is simple and one funtion aspect | 08:41 |
| Kennan | not mess all in one method | 08:41 |
| Kennan | you could add other methods for update case | 08:42 |
| *** liangbo has quit IRC | 08:46 | |
| *** tbh has quit IRC | 08:47 | |
| *** sdake has quit IRC | 08:50 | |
| *** VikasC has quit IRC | 08:51 | |
| openstackgerrit | Hua Wang proposed openstack/magnum: Add default for node_count and bay_create_timeout https://review.openstack.org/218065 | 08:53 |
| openstackgerrit | Hua Wang proposed openstack/magnum: X-User is deprecated and X-Storage-Token is useless https://review.openstack.org/218171 | 09:00 |
| *** liangbo has joined #openstack-containers | 09:03 | |
| *** tbh has joined #openstack-containers | 09:04 | |
| *** erkules_ is now known as erkules | 09:04 | |
| *** erkules has joined #openstack-containers | 09:04 | |
| *** Tennyson has quit IRC | 09:12 | |
| *** mathspanda has quit IRC | 09:13 | |
| *** tbh has quit IRC | 09:21 | |
| openstackgerrit | Hua Wang proposed openstack/magnum: Code refactor for keystoneclient https://review.openstack.org/218699 | 09:24 |
| *** alex_klimov has joined #openstack-containers | 09:31 | |
| *** tbh has joined #openstack-containers | 09:35 | |
| *** ig0r_ has joined #openstack-containers | 09:37 | |
| *** ig0r__ has quit IRC | 09:39 | |
| *** VikasC has joined #openstack-containers | 09:47 | |
| openstackgerrit | bharaththiruveedula proposed openstack/magnum: Updates the node count key for all types of bay https://review.openstack.org/218582 | 10:00 |
| tbh | Kennan, updated the code | 10:03 |
| *** yuanying-alt has joined #openstack-containers | 10:14 | |
| *** yuanying-alt has quit IRC | 10:19 | |
| *** Jian0612 has quit IRC | 10:30 | |
| *** Drago has quit IRC | 10:39 | |
| *** ishant has quit IRC | 11:25 | |
| *** BhavyaM has quit IRC | 11:41 | |
| *** chandankumar has quit IRC | 11:46 | |
| *** openstackgerrit has quit IRC | 11:46 | |
| *** openstackgerrit has joined #openstack-containers | 11:47 | |
| *** BhavyaM has joined #openstack-containers | 11:58 | |
| *** yuanying-alt has joined #openstack-containers | 12:03 | |
| *** yuanying-alt has quit IRC | 12:07 | |
| *** dave-mccowan has joined #openstack-containers | 12:08 | |
| *** raildo-afk is now known as raildo | 12:16 | |
| *** humble__ has quit IRC | 12:27 | |
| *** VikasC has quit IRC | 12:37 | |
| *** tbh has quit IRC | 12:38 | |
| *** junhongl has quit IRC | 12:53 | |
| *** BhavyaM has quit IRC | 12:53 | |
| *** dane_leblanc has joined #openstack-containers | 13:10 | |
| *** shuquan has joined #openstack-containers | 13:11 | |
| *** chandankumar has joined #openstack-containers | 13:18 | |
| *** kbyrne has quit IRC | 13:19 | |
| *** liangbo has quit IRC | 13:21 | |
| *** kbyrne has joined #openstack-containers | 13:32 | |
| *** rpothier has joined #openstack-containers | 13:34 | |
| *** dims has joined #openstack-containers | 13:36 | |
| *** ctrath has joined #openstack-containers | 13:46 | |
| *** rlrossit has joined #openstack-containers | 13:47 | |
| *** yuanying-alt has joined #openstack-containers | 13:52 | |
| *** pradk has joined #openstack-containers | 13:54 | |
| *** yuanying-alt has quit IRC | 13:56 | |
| *** shuquan has quit IRC | 13:57 | |
| *** Kennan has quit IRC | 14:03 | |
| *** Kennan2 has joined #openstack-containers | 14:03 | |
| *** zz_dimtruck is now known as dimtruck | 14:11 | |
| *** _navneet has joined #openstack-containers | 14:36 | |
| *** achanda has joined #openstack-containers | 14:49 | |
| *** banix has joined #openstack-containers | 14:51 | |
| *** kebray has joined #openstack-containers | 14:51 | |
| *** dims has quit IRC | 14:51 | |
| *** banix has quit IRC | 14:57 | |
| *** diga has joined #openstack-containers | 14:57 | |
| *** banix has joined #openstack-containers | 15:01 | |
| *** hongbin has joined #openstack-containers | 15:01 | |
| *** jruano has joined #openstack-containers | 15:02 | |
| *** dims has joined #openstack-containers | 15:03 | |
| *** j___ has quit IRC | 15:03 | |
| *** achanda has quit IRC | 15:05 | |
| *** Tango has joined #openstack-containers | 15:06 | |
| *** Drago has joined #openstack-containers | 15:11 | |
| *** dave-mccowan has quit IRC | 15:11 | |
| *** diga has quit IRC | 15:13 | |
| *** wznoinsk1 is now known as wznoinsk | 15:15 | |
| *** _navneet_ has joined #openstack-containers | 15:18 | |
| *** _navneet has quit IRC | 15:22 | |
| *** wshao_ has joined #openstack-containers | 15:24 | |
| *** dave-mccowan has joined #openstack-containers | 15:25 | |
| *** VikasC has joined #openstack-containers | 15:25 | |
| *** david-ly_ has joined #openstack-containers | 15:31 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum: Updated from global requirements https://review.openstack.org/218907 | 15:32 |
| *** david-ly_ is now known as david-lyle_ | 15:33 | |
| *** david-lyle has quit IRC | 15:33 | |
| *** david-lyle_ is now known as david-lyle | 15:35 | |
| *** adrian_otto has joined #openstack-containers | 15:36 | |
| VikasC | #openstack-meeting-4 | 15:38 |
| *** alex_klimov has quit IRC | 15:38 | |
| *** chandankumar has quit IRC | 15:39 | |
| *** BertrandN has quit IRC | 15:46 | |
| *** VikasC has quit IRC | 15:50 | |
| *** wshao_ has quit IRC | 15:59 | |
| *** kebray has quit IRC | 16:08 | |
| *** banix has quit IRC | 16:08 | |
| *** mfalatic has joined #openstack-containers | 16:09 | |
| *** eghobo has joined #openstack-containers | 16:14 | |
| *** jjfreric has joined #openstack-containers | 16:15 | |
| *** jjfreric has quit IRC | 16:16 | |
| *** manjeets has joined #openstack-containers | 16:25 | |
| *** unicell has quit IRC | 16:25 | |
| *** rpothier has quit IRC | 16:28 | |
| *** liangbo has joined #openstack-containers | 16:31 | |
| *** dane_leblanc has quit IRC | 16:45 | |
| *** harshs has joined #openstack-containers | 16:48 | |
| *** sdake_ has joined #openstack-containers | 16:52 | |
| *** dims has quit IRC | 16:55 | |
| *** dane_leblanc has joined #openstack-containers | 16:55 | |
| *** harshs has quit IRC | 16:56 | |
| *** chandankumar has joined #openstack-containers | 16:59 | |
| *** banix has joined #openstack-containers | 17:00 | |
| *** Tango has quit IRC | 17:04 | |
| *** jlcoello has joined #openstack-containers | 17:09 | |
| *** julim has joined #openstack-containers | 17:11 | |
| *** jlcoello has quit IRC | 17:11 | |
| *** suro-patz has joined #openstack-containers | 17:12 | |
| *** unicell has joined #openstack-containers | 17:12 | |
| *** achanda has joined #openstack-containers | 17:18 | |
| *** banix has quit IRC | 17:18 | |
| manjeets | ._. | 17:20 |
| *** banix has joined #openstack-containers | 17:22 | |
| mfalatic | Can someone explain briefly what --docker-volume-size affects in the bay model? | 17:22 |
| mfalatic | I think I understand but I want to make sure I do. | 17:23 |
| *** liangbo has quit IRC | 17:23 | |
| *** harshs has joined #openstack-containers | 17:23 | |
| *** Drago has quit IRC | 17:24 | |
| *** banix has quit IRC | 17:25 | |
| *** dims has joined #openstack-containers | 17:29 | |
| *** vilobhmm1 has joined #openstack-containers | 17:29 | |
| *** banix has joined #openstack-containers | 17:29 | |
| *** dims_ has joined #openstack-containers | 17:30 | |
| *** dims has quit IRC | 17:30 | |
| *** sdake has joined #openstack-containers | 17:33 | |
| *** sthillma has joined #openstack-containers | 17:35 | |
| *** sdake_ has quit IRC | 17:37 | |
| *** suro-patz1 has joined #openstack-containers | 17:37 | |
| openstackgerrit | Manjeet Singh Bhatia proposed openstack/magnum: Change grep option dev-build-atomic-image.rst https://review.openstack.org/218963 | 17:38 |
| *** rlrossit has left #openstack-containers | 17:39 | |
| *** suro-patz has quit IRC | 17:39 | |
| *** Drago has joined #openstack-containers | 17:41 | |
| *** Drago has quit IRC | 17:42 | |
| *** Drago has joined #openstack-containers | 17:42 | |
| *** ig0r__ has joined #openstack-containers | 17:43 | |
| *** SourabhP has joined #openstack-containers | 17:45 | |
| *** chandankumar has quit IRC | 17:45 | |
| *** ig0r_ has quit IRC | 17:46 | |
| *** chandankumar has joined #openstack-containers | 17:52 | |
| openstackgerrit | Manjeet Singh Bhatia proposed openstack/magnum: Change grep option dev-build-atomic-image.rst https://review.openstack.org/218963 | 17:53 |
| *** Tango has joined #openstack-containers | 17:55 | |
| *** rlrossit has joined #openstack-containers | 17:56 | |
| *** eghobo_ has joined #openstack-containers | 18:00 | |
| *** eghobo has quit IRC | 18:04 | |
| vilobhmm1 | hongbin : ping | 18:06 |
| hongbin | vilobhmm1: pong | 18:06 |
| vilobhmm1 | as part of review for https://review.openstack.org/#/c/217865/2/magnum/objects/replicationcontroller.py Kennan brought up a good point and I also had this thought for a while that get_*_by_bay_uuid API's are not consumed by anyone. Same applies for list_by_bay_uuid api's in service/pod object | 18:08 |
| vilobhmm1 | so should we keep dead code ? or just remove these API's from the code base as there is no consumer of it ? | 18:08 |
| vilobhmm1 | hongbin : ^^ | 18:08 |
| hongbin | vilobhmm1: I am OK with either | 18:09 |
| vilobhmm1 | I discussed this with Kennan and he seems to agree with me that we should clean off the dead code…wanted to get your opinion. If you also agree will submit a patch accordingly | 18:09 |
| hongbin | I have no problem to clean up | 18:10 |
| vilobhmm1 | hongbin : ok thanks :) | 18:10 |
| openstackgerrit | Manjeet Singh Bhatia proposed openstack/magnum: Change grep option dev-build-atomic-image.rst https://review.openstack.org/218963 | 18:12 |
| hongbin | vilobhmm1: but I think you might need to discuss with other cores. Do you know who commit that method? | 18:13 |
| hongbin | vilobhmm1: I guess it is Jay Lau or Madhuri | 18:15 |
| hongbin | vilobhmm1: So yes, I guess the best way is to discuss with the person who commit the code, and ask them if they are OK to clean up | 18:16 |
| vilobhmm1 | hongbin : looks like you only added it https://github.com/openstack/magnum/commit/e54428845b9d42508bc8102976588d05102ae13e :) alteast the initial framework for get_pods_by_bay_uuid | 18:18 |
| *** julim has quit IRC | 18:18 | |
| vilobhmm1 | hongbin : sure will do that…seems like madhuri is away will check with jay lau | 18:18 |
| hongbin | vilobhmm1: I just renamed it, not me :) | 18:19 |
| vilobhmm1 | ok https://github.com/openstack/magnum/commit/71458fb8ea775646219daacf7908d6277ccdb812 seems to have added it then | 18:19 |
| hongbin | That guy is inactive in Magnum | 18:20 |
| vilobhmm1 | just the point is there r no consumers of this code ! | 18:20 |
| hongbin | k | 18:21 |
| *** jlcoello has joined #openstack-containers | 18:21 | |
| *** julim has joined #openstack-containers | 18:21 | |
| hongbin | Then it is fine I guess | 18:21 |
| vilobhmm1 | let me submit a patch and mark it as WIP | 18:21 |
| vilobhmm1 | and will add cores to this review | 18:21 |
| hongbin | sounds good | 18:21 |
| vilobhmm1 | cool | 18:22 |
| *** chandankumar has quit IRC | 18:26 | |
| *** banix has quit IRC | 18:28 | |
| *** rpothier has joined #openstack-containers | 18:29 | |
| *** jasonsb_ has joined #openstack-containers | 18:42 | |
| *** dflorea has joined #openstack-containers | 18:42 | |
| *** juggler has quit IRC | 18:47 | |
| *** daneyon_ has joined #openstack-containers | 18:47 | |
| *** ig0r__ has quit IRC | 18:48 | |
| *** dflorea_ has joined #openstack-containers | 18:48 | |
| *** daneyon has quit IRC | 18:49 | |
| *** chandankumar has joined #openstack-containers | 18:50 | |
| *** SourabhP has quit IRC | 18:50 | |
| openstackgerrit | Vilobh Meshram proposed openstack/magnum: WIP : Remove unused DB API and Pod object API https://review.openstack.org/217908 | 18:50 |
| vilobhmm1 | hongbin : ^^ | 18:51 |
| *** dflorea has quit IRC | 18:51 | |
| *** sthillma_ has joined #openstack-containers | 18:58 | |
| *** eghobo_ has quit IRC | 18:59 | |
| *** eghobo has joined #openstack-containers | 19:00 | |
| *** eghobo has quit IRC | 19:00 | |
| *** sthillma has quit IRC | 19:01 | |
| *** sthillma_ is now known as sthillma | 19:01 | |
| *** SourabhP has joined #openstack-containers | 19:01 | |
| *** eghobo has joined #openstack-containers | 19:01 | |
| *** sdake has quit IRC | 19:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum: Updated from global requirements https://review.openstack.org/218907 | 19:04 |
| *** sdake has joined #openstack-containers | 19:10 | |
| *** sdake has quit IRC | 19:10 | |
| *** sdake has joined #openstack-containers | 19:10 | |
| *** dflorea has joined #openstack-containers | 19:10 | |
| *** dflorea_ has quit IRC | 19:11 | |
| *** dflorea has quit IRC | 19:12 | |
| *** jwcroppe has joined #openstack-containers | 19:13 | |
| *** jwcroppe_ has quit IRC | 19:15 | |
| *** Drago has quit IRC | 19:32 | |
| *** Drago has joined #openstack-containers | 19:32 | |
| *** sthillma_ has joined #openstack-containers | 19:32 | |
| *** banix has joined #openstack-containers | 19:34 | |
| *** sthillma has quit IRC | 19:34 | |
| *** sthillma_ is now known as sthillma | 19:34 | |
| *** chandankumar has quit IRC | 19:43 | |
| mfalatic | Need a bit of info: on the master node of a bay, etcd should be running, right? It shouldn't start and then die. | 19:56 |
| mfalatic | (or is it not running til some later stage) | 19:56 |
| mfalatic | I'd expect it to be running.... the fact that it's dying pretty quickly is of concern. | 19:57 |
| *** david-lyle has quit IRC | 20:01 | |
| *** dane_leblanc has quit IRC | 20:02 | |
| *** david-lyle has joined #openstack-containers | 20:06 | |
| *** dflorea has joined #openstack-containers | 20:10 | |
| *** dane_leblanc has joined #openstack-containers | 20:11 | |
| *** ddecapit has joined #openstack-containers | 20:11 | |
| *** dims has joined #openstack-containers | 20:11 | |
| *** dims has quit IRC | 20:12 | |
| *** ddecapit_ has joined #openstack-containers | 20:14 | |
| *** dims_ has quit IRC | 20:14 | |
| *** dflorea_ has joined #openstack-containers | 20:17 | |
| *** ddecapit has quit IRC | 20:17 | |
| *** dflorea has quit IRC | 20:20 | |
| *** muralia has quit IRC | 20:25 | |
| *** dflorea_ has quit IRC | 20:33 | |
| *** dflorea has joined #openstack-containers | 20:35 | |
| *** rlrossit1 has joined #openstack-containers | 20:37 | |
| *** dflorea_ has joined #openstack-containers | 20:38 | |
| *** dflorea has quit IRC | 20:38 | |
| *** achanda has quit IRC | 20:38 | |
| *** rlrossit has quit IRC | 20:39 | |
| *** dflorea has joined #openstack-containers | 20:41 | |
| *** achanda has joined #openstack-containers | 20:41 | |
| *** achanda has quit IRC | 20:41 | |
| *** achanda has joined #openstack-containers | 20:41 | |
| hongbin | mfalatic: Do you have the log of etcd? That will possibly tell you why it die. | 20:43 |
| mfalatic | I'm trying to determine if it should be dying at all. If the answer is No, then clearly I'm seeing a problem. | 20:44 |
| *** kebray has joined #openstack-containers | 20:44 | |
| *** kebray has quit IRC | 20:44 | |
| *** dflorea_ has quit IRC | 20:45 | |
| *** kebray has joined #openstack-containers | 20:45 | |
| *** dflorea has quit IRC | 20:45 | |
| *** dflorea has joined #openstack-containers | 20:45 | |
| hongbin | mfalatic: No, it should not die | 20:46 |
| mfalatic | Thought so... thanks! | 20:47 |
| *** dflorea has quit IRC | 20:50 | |
| *** jwcroppe_ has joined #openstack-containers | 20:55 | |
| *** jwcroppe has quit IRC | 20:57 | |
| *** rlrossit1 has left #openstack-containers | 20:57 | |
| *** dims has joined #openstack-containers | 20:57 | |
| *** kebray has quit IRC | 20:59 | |
| *** jlcoello has quit IRC | 20:59 | |
| *** jlcoello has joined #openstack-containers | 21:00 | |
| *** jlcoello has quit IRC | 21:00 | |
| *** jasonsb_ has quit IRC | 21:01 | |
| *** jlcoello has joined #openstack-containers | 21:01 | |
| *** jwcroppe has joined #openstack-containers | 21:02 | |
| *** jwcroppe_ has quit IRC | 21:04 | |
| *** jlcoello has quit IRC | 21:05 | |
| openstackgerrit | Daneyon Hansen proposed openstack/python-magnumclient: WIP: Adds Container Networking Model Support https://review.openstack.org/215260 | 21:07 |
| *** jwcroppe_ has joined #openstack-containers | 21:07 | |
| *** jwcroppe has quit IRC | 21:10 | |
| *** banix has quit IRC | 21:10 | |
| *** banix has joined #openstack-containers | 21:14 | |
| *** julim has quit IRC | 21:14 | |
| *** ddecapit_ has quit IRC | 21:15 | |
| *** jwcroppe has joined #openstack-containers | 21:28 | |
| *** jwcroppe_ has quit IRC | 21:31 | |
| openstackgerrit | Vilobh Meshram proposed openstack/magnum: WIP : Remove unused DB API get_rcs_by_bay_uuid https://review.openstack.org/217865 | 21:37 |
| *** jlcoello has joined #openstack-containers | 21:37 | |
| *** jlcoello has quit IRC | 21:37 | |
| *** jlcoello has joined #openstack-containers | 21:38 | |
| *** jlcoello_ has joined #openstack-containers | 21:39 | |
| *** jlcoello has quit IRC | 21:42 | |
| *** Drago has quit IRC | 21:43 | |
| *** dave-mccowan has quit IRC | 21:46 | |
| *** jlcoello_ has quit IRC | 21:48 | |
| *** rpothier has quit IRC | 21:54 | |
| *** eghobo has quit IRC | 21:57 | |
| openstackgerrit | Vilobh Meshram proposed openstack/magnum: Remove unused DB API and Service object API https://review.openstack.org/219043 | 22:06 |
| *** dimtruck is now known as zz_dimtruck | 22:11 | |
| *** banix has quit IRC | 22:12 | |
| *** jruano has quit IRC | 22:14 | |
| *** eghobo has joined #openstack-containers | 22:14 | |
| *** dane_leblanc has quit IRC | 22:16 | |
| *** muralia has joined #openstack-containers | 22:17 | |
| *** Drago has joined #openstack-containers | 22:18 | |
| manjeets | anybody expert on this document dev-build-atomic-image.rst ? | 22:26 |
| *** _navneet_ has quit IRC | 22:28 | |
| *** pradk has quit IRC | 22:33 | |
| openstackgerrit | Merged openstack/magnum: Add default for node_count and bay_create_timeout https://review.openstack.org/218065 | 22:37 |
| *** ctrath has quit IRC | 22:42 | |
| *** muralia has quit IRC | 22:44 | |
| *** muralia has joined #openstack-containers | 22:44 | |
| openstackgerrit | Ton Ngo proposed openstack/magnum: Migrate to Kubernetes Release 1 (devstack plugin) https://review.openstack.org/210641 | 22:51 |
| openstackgerrit | Ton Ngo proposed openstack/magnum: Migrate to Kubernetes Release 1 (docs) https://review.openstack.org/207300 | 22:51 |
| openstackgerrit | Ton Ngo proposed openstack/magnum: Migrate to Kubernetes Release 1 (scripts) https://review.openstack.org/207299 | 22:51 |
| *** ameybhide has joined #openstack-containers | 22:52 | |
| *** jruano has joined #openstack-containers | 22:58 | |
| *** jjfreric has joined #openstack-containers | 23:04 | |
| *** jjfreric has quit IRC | 23:04 | |
| Tango | manjeets: Hi Manjeet, maybe I can help | 23:05 |
| openstackgerrit | Merged openstack/magnum: X-User is deprecated and X-Storage-Token is useless https://review.openstack.org/218171 | 23:05 |
| *** Drago has quit IRC | 23:08 | |
| *** irenab_ has joined #openstack-containers | 23:14 | |
| manjeets | Tango: thanks | 23:14 |
| Tango | manjeets: Are building an image? | 23:15 |
| Tango | manjeets: Are you building an image? | 23:15 |
| manjeets | tango: yes | 23:15 |
| manjeets | so i have flannel, etcd and kuberernetes added | 23:15 |
| *** irenab has quit IRC | 23:16 | |
| *** irenab_ is now known as irenab | 23:16 | |
| *** daneyon has joined #openstack-containers | 23:16 | |
| manjeets | Tango: what is host rpm-ostree repo for ? | 23:17 |
| *** daneyon_ has quit IRC | 23:17 | |
| Tango | manjeets: It's Atomic way of managing their packages and doing the atomic update to the OS | 23:17 |
| *** eghobo has quit IRC | 23:18 | |
| Tango | manjeets: http://www.projectatomic.io/docs/compose-your-own-tree/ | 23:18 |
| *** hongbin has quit IRC | 23:18 | |
| *** daneyon_ has joined #openstack-containers | 23:18 | |
| manjeets | Tango: what if I just want to use any other linux distro other than atomic ? | 23:19 |
| Tango | you could | 23:21 |
| *** eghobo has joined #openstack-containers | 23:21 | |
| manjeets | Tango: some time I feel there should be generic documentation for using different os with magnum | 23:22 |
| *** daneyon has quit IRC | 23:22 | |
| Tango | manjeets: The current config scripts have been tested with the Atomic image. They just need to be tweaked for other distro | 23:22 |
| Tango | manjeets: That would be a good exercise,writing a new doc to explain how to do this. | 23:23 |
| manjeets | Tango: by config scripts you mean heat-template yaml files ? | 23:23 |
| Tango | manjeets: right, yaml or sh script | 23:23 |
| manjeets | Tango: my assumption is os image should have atleast flannel, docker, etcd and kubernetes | 23:25 |
| Tango | manjeets: Well, daneyon is factoring out flannel as part of the networking blueprint, so soon we won't have flannel as part of the image | 23:26 |
| manjeets | oh yes | 23:27 |
| Tango | manjeets: This is so that the networking plugin can be more generic | 23:27 |
| manjeets | I see network driver option is under construction | 23:28 |
| *** jruano has quit IRC | 23:29 | |
| *** eghobo has quit IRC | 23:37 | |
| manjeets | Tango: anything else is needed other than that ? | 23:39 |
| Tango | manjeets: That should be all | 23:41 |
| *** dave-mccowan has joined #openstack-containers | 23:41 | |
| manjeets | Tango: what should be alternative for atomic updates ? | 23:41 |
| Tango | manjeets: You mean to modify the image? | 23:42 |
| manjeets | yes ? | 23:42 |
| Tango | manjeets: hmm, I am not sure, good question to ask the Atomic folks. It seems they build everything around rpm-ostree | 23:44 |
| *** adrian_otto has quit IRC | 23:46 | |
| Tango | manjeets: Heading out | 23:46 |
| manjeets | Tango: Thanks I appreciate it | 23:47 |
| *** manjeets has left #openstack-containers | 23:47 | |
| *** manjeets has joined #openstack-containers | 23:48 | |
| *** eghobo has joined #openstack-containers | 23:49 | |
| *** manjeets has quit IRC | 23:50 | |
| *** Tango has quit IRC | 23:51 | |
| *** achanda_ has joined #openstack-containers | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!