*** achanda has quit IRC | 00:01 | |
*** achanda_ has quit IRC | 00:02 | |
*** dims has quit IRC | 00:03 | |
openstackgerrit | Vilobh Meshram proposed openstack/magnum: Remove unused DB API get_rcs_by_bay_uuid https://review.openstack.org/217865 | 00:04 |
---|---|---|
openstackgerrit | Vilobh Meshram proposed openstack/magnum: Remove unused DB API and Pod object API https://review.openstack.org/217908 | 00:04 |
*** sdake_ has joined #openstack-containers | 00:08 | |
*** sdake has quit IRC | 00:11 | |
*** sdake has joined #openstack-containers | 00:18 | |
*** jruano has joined #openstack-containers | 00:19 | |
*** suro-patz1 has quit IRC | 00:20 | |
*** sdake_ has quit IRC | 00:21 | |
*** ameybhide has quit IRC | 00:29 | |
openstackgerrit | venkatamahesh proposed openstack/magnum: Fix the latest version for Docker API https://review.openstack.org/219070 | 00:40 |
*** harshs has quit IRC | 00:47 | |
*** sdake_ has joined #openstack-containers | 00:47 | |
*** sdake__ has joined #openstack-containers | 00:49 | |
*** sdake has quit IRC | 00:50 | |
*** sdake_ has quit IRC | 00:53 | |
*** sdake__ is now known as sdake | 00:54 | |
*** banix has joined #openstack-containers | 00:55 | |
*** irenab_ has joined #openstack-containers | 01:01 | |
*** irenab has quit IRC | 01:03 | |
*** irenab_ is now known as irenab | 01:03 | |
*** dave-mccowan has quit IRC | 01:04 | |
*** banix has quit IRC | 01:12 | |
*** dims has joined #openstack-containers | 01:20 | |
*** banix has joined #openstack-containers | 01:20 | |
*** vilobhmm1 has quit IRC | 01:22 | |
*** erkules_ has joined #openstack-containers | 01:22 | |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Change bay.*_cert_uuid to bay.*_cert_ref https://review.openstack.org/218086 | 01:23 |
*** erkules has quit IRC | 01:25 | |
*** hongbin has joined #openstack-containers | 01:31 | |
*** shuquan has joined #openstack-containers | 01:33 | |
*** shuquan has quit IRC | 01:38 | |
*** SourabhP has quit IRC | 01:38 | |
*** mathspanda has joined #openstack-containers | 01:54 | |
openstackgerrit | Merged openstack/magnum: Change grep option dev-build-atomic-image.rst https://review.openstack.org/218963 | 01:56 |
*** jruano has quit IRC | 01:58 | |
*** eghobo has quit IRC | 02:01 | |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Change bay.*_cert_uuid to bay.*_cert_ref https://review.openstack.org/218086 | 02:02 |
*** sthillma has quit IRC | 02:04 | |
*** ganeshna has joined #openstack-containers | 02:08 | |
*** zz_dimtruck is now known as dimtruck | 02:08 | |
*** junhongl has joined #openstack-containers | 02:08 | |
*** ganeshna has quit IRC | 02:10 | |
*** ganeshna has joined #openstack-containers | 02:10 | |
*** vilobhmm1 has joined #openstack-containers | 02:12 | |
*** banix has quit IRC | 02:13 | |
*** vilobhmm1 has left #openstack-containers | 02:18 | |
*** ganeshna has quit IRC | 02:24 | |
*** jruano has joined #openstack-containers | 02:27 | |
*** jruano has quit IRC | 02:33 | |
*** jruano has joined #openstack-containers | 02:39 | |
*** wanghua has joined #openstack-containers | 02:54 | |
*** humble_ has joined #openstack-containers | 02:57 | |
*** wanghua has quit IRC | 03:01 | |
*** suro-patz has joined #openstack-containers | 03:04 | |
*** achanda has joined #openstack-containers | 03:07 | |
*** Jian0612 has joined #openstack-containers | 03:13 | |
*** humble__ has joined #openstack-containers | 03:14 | |
openstackgerrit | venkatamahesh proposed openstack/magnum: Fix the representation of REST https://review.openstack.org/217327 | 03:15 |
*** humble_ has quit IRC | 03:18 | |
*** jruano has quit IRC | 03:19 | |
*** harshs has joined #openstack-containers | 03:20 | |
*** harshs has quit IRC | 03:30 | |
*** unicell has quit IRC | 03:31 | |
*** hongbin has quit IRC | 03:32 | |
*** harshs has joined #openstack-containers | 03:33 | |
openstackgerrit | Hua Wang proposed openstack/magnum: Add roles to context https://review.openstack.org/218203 | 03:34 |
*** humble_ has joined #openstack-containers | 03:42 | |
*** eghobo has joined #openstack-containers | 03:44 | |
*** humble__ has quit IRC | 03:44 | |
*** liangbo has joined #openstack-containers | 03:45 | |
*** humble__ has joined #openstack-containers | 03:47 | |
*** humble_ has quit IRC | 03:50 | |
*** achanda has quit IRC | 03:51 | |
*** diga has joined #openstack-containers | 04:00 | |
*** suro-patz has quit IRC | 04:13 | |
*** eghobo_ has joined #openstack-containers | 04:22 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum: Updated from global requirements https://review.openstack.org/218907 | 04:24 |
*** eghobo has quit IRC | 04:25 | |
*** vimal has joined #openstack-containers | 04:28 | |
*** dims has quit IRC | 04:30 | |
*** irenab has quit IRC | 04:31 | |
*** Tango has joined #openstack-containers | 04:38 | |
*** diga has quit IRC | 04:40 | |
*** diga has joined #openstack-containers | 04:41 | |
*** eghobo has joined #openstack-containers | 04:45 | |
*** achanda has joined #openstack-containers | 04:45 | |
*** eghobo_ has quit IRC | 04:45 | |
openstackgerrit | bharaththiruveedula proposed openstack/magnum: Updates the node count key for all types of bay https://review.openstack.org/218582 | 04:46 |
*** suro-patz has joined #openstack-containers | 04:52 | |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Fix missing sql_opts https://review.openstack.org/219121 | 04:54 |
*** tbh has joined #openstack-containers | 05:02 | |
*** unicell has joined #openstack-containers | 05:02 | |
*** Jian0612 has left #openstack-containers | 05:03 | |
openstackgerrit | Merged openstack/magnum: Fix method and parameter descriptions https://review.openstack.org/218715 | 05:03 |
openstackgerrit | Merged openstack/magnum: Fix the representation of REST https://review.openstack.org/217327 | 05:09 |
*** sthillma has joined #openstack-containers | 05:10 | |
*** sthillma_ has joined #openstack-containers | 05:16 | |
*** alex_klimov has joined #openstack-containers | 05:17 | |
*** sthillma has quit IRC | 05:20 | |
*** sthillma_ is now known as sthillma | 05:20 | |
*** suro-patz has quit IRC | 05:24 | |
*** alex_klimov has quit IRC | 05:26 | |
*** eghobo has quit IRC | 05:28 | |
*** eghobo has joined #openstack-containers | 05:29 | |
*** ameybhide has joined #openstack-containers | 05:31 | |
*** vilobhmm11 has joined #openstack-containers | 05:32 | |
*** irenab has joined #openstack-containers | 05:34 | |
vilobhmm11 | humble__ : ping | 05:38 |
*** tbh has quit IRC | 05:38 | |
humble__ | vilobhmm11:pong | 05:39 |
*** harshs_ has joined #openstack-containers | 05:39 | |
vilobhmm11 | thanks for the review of https://review.openstack.org/#/c/217865/ | 05:40 |
vilobhmm11 | I still don't get it how do the https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/replicationcontroller.py#L250 invoke get_rcs_by_bay_uuid ? | 05:40 |
*** harshs has quit IRC | 05:41 | |
*** harshs_ is now known as harshs | 05:41 | |
*** jlcoello has joined #openstack-containers | 05:41 | |
vilobhmm11 | as I can infer from your comments | 05:41 |
vilobhmm11 | humble__ : ^^ | 05:41 |
humble__ | vilobhmm11: the uuid parameter is not used | 05:43 |
*** tbh has joined #openstack-containers | 05:43 | |
humble__ | I think we should use it in _get_rcs_collection | 05:43 |
vilobhmm11 | sure that can be done..but what do we achieve by doing that | 05:45 |
vilobhmm11 | if you see here https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/replicationcontroller.py#L207 | 05:45 |
vilobhmm11 | _get_rcs_collection : #1. get_by_uuid if marker is set #2. if not does rc_list | 05:45 |
*** SourabhP has joined #openstack-containers | 05:46 | |
humble__ | magnum pod-list will show all the pods? | 05:46 |
*** dimtruck is now known as zz_dimtruck | 05:46 | |
vilobhmm11 | yes IMHO as per https://github.com/openstack/magnum/blob/master/magnum/objects/pod.py#L112 | 05:47 |
humble__ | I think we should support magnum pod-list --bay-uuid xxxxxxx | 05:47 |
vilobhmm11 | humble__ : that can be done; in its current state of art this query get_pods_by_bay_uuid was not being used anywhere and hence the proposed patch sis for | 05:48 |
vilobhmm11 | thats a nice idea ! we can discuss it in tommorows meeting | 05:48 |
humble__ | ok | 05:48 |
vilobhmm11 | at present we don't have that kind of feature | 05:49 |
vilobhmm11 | magnum pod-list --bay-uuid xxxxxxx | 05:49 |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Fix missing sql_opts https://review.openstack.org/219121 | 05:51 |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Remove unused `host` parameter in config https://review.openstack.org/219142 | 05:51 |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Introduce unit test for genconfig https://review.openstack.org/219143 | 05:51 |
vilobhmm11 | humble__ : apart from the future use of using the api for magnum pod-list --bay-uuid xxxxxxx of use do you have any more feedback for https://review.openstack.org/#/c/217865/ ? | 05:54 |
humble__ | vilobhmm11: I think it is ok | 05:55 |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Introduce unit test for genconfig https://review.openstack.org/219143 | 05:57 |
vilobhmm11 | humble__ : ok thanks ! | 05:57 |
vilobhmm11 | :) | 05:57 |
*** dims has joined #openstack-containers | 05:59 | |
*** dims has quit IRC | 06:04 | |
*** liangbo has quit IRC | 06:05 | |
*** sdake_ has joined #openstack-containers | 06:05 | |
*** sdake has quit IRC | 06:08 | |
*** sdake has joined #openstack-containers | 06:11 | |
*** sdake has quit IRC | 06:11 | |
*** sdake has joined #openstack-containers | 06:13 | |
*** unicell has quit IRC | 06:15 | |
*** sdake_ has quit IRC | 06:15 | |
*** unicell has joined #openstack-containers | 06:15 | |
*** vimal has quit IRC | 06:29 | |
*** ganeshna has joined #openstack-containers | 06:32 | |
*** SourabhP has quit IRC | 06:35 | |
*** j___ has joined #openstack-containers | 06:41 | |
*** BertrandN has joined #openstack-containers | 06:50 | |
*** liangbo has joined #openstack-containers | 06:51 | |
*** ganeshna has quit IRC | 06:56 | |
*** BertrandN has quit IRC | 06:58 | |
*** alex_klimov has joined #openstack-containers | 07:02 | |
*** harshs has quit IRC | 07:06 | |
*** slagle has quit IRC | 07:06 | |
*** jjfreric has joined #openstack-containers | 07:09 | |
*** alex_klimov has quit IRC | 07:10 | |
*** tbh has quit IRC | 07:10 | |
*** achanda has quit IRC | 07:11 | |
*** jjfreric has left #openstack-containers | 07:12 | |
*** tbh has joined #openstack-containers | 07:12 | |
*** BertrandN has joined #openstack-containers | 07:14 | |
*** sirushti has quit IRC | 07:15 | |
*** eghobo has quit IRC | 07:16 | |
*** achanda has joined #openstack-containers | 07:17 | |
*** halfss has joined #openstack-containers | 07:17 | |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Generate certs while creating bay https://review.openstack.org/214480 | 07:18 |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Change bay.*_cert_uuid to bay.*_cert_ref https://review.openstack.org/218086 | 07:18 |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Add CertManager to store CA and client certificate https://review.openstack.org/212395 | 07:18 |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/magnum: Add a tool to manage x509 objects https://review.openstack.org/212321 | 07:18 |
*** Tango has quit IRC | 07:21 | |
*** chandankumar has joined #openstack-containers | 07:24 | |
*** achanda has quit IRC | 07:25 | |
*** achanda has joined #openstack-containers | 07:26 | |
*** achanda has quit IRC | 07:30 | |
*** ishant has joined #openstack-containers | 07:34 | |
*** jwcroppe is now known as jwcroppe_zzz | 07:45 | |
*** alex_klimov has joined #openstack-containers | 07:56 | |
*** vilobhmm11 has quit IRC | 07:58 | |
*** vimal has joined #openstack-containers | 07:59 | |
*** vimal is now known as vimal|brb | 08:01 | |
*** vimal|brb is now known as vimal | 08:04 | |
*** sthillma has quit IRC | 08:04 | |
*** mathspanda has quit IRC | 08:08 | |
openstackgerrit | venkatamahesh proposed openstack/magnum: Fix the link for Docker Remote API https://review.openstack.org/219070 | 08:31 |
*** sirushti has joined #openstack-containers | 08:32 | |
*** dims has joined #openstack-containers | 08:42 | |
*** dims has quit IRC | 08:48 | |
*** Marga_ has joined #openstack-containers | 08:56 | |
*** Marga__ has joined #openstack-containers | 08:57 | |
*** Marga_ has quit IRC | 09:01 | |
*** sirushti has quit IRC | 09:08 | |
*** sirushti has joined #openstack-containers | 09:11 | |
*** Marga__ has quit IRC | 09:32 | |
*** Marga_ has joined #openstack-containers | 09:32 | |
*** dims has joined #openstack-containers | 09:36 | |
*** dims has quit IRC | 09:41 | |
openstackgerrit | Merged openstack/magnum: Fix the link for Docker Remote API https://review.openstack.org/219070 | 09:43 |
*** liangbo has quit IRC | 09:43 | |
*** Marga_ has quit IRC | 09:52 | |
*** coolsvap has quit IRC | 10:01 | |
*** coolsvap has joined #openstack-containers | 10:02 | |
*** dave-mccowan has joined #openstack-containers | 10:06 | |
*** liangbo has joined #openstack-containers | 10:26 | |
*** liangbo has quit IRC | 10:30 | |
*** dims has joined #openstack-containers | 10:30 | |
*** VikasC has joined #openstack-containers | 10:33 | |
VikasC | kennan2: Hi | 10:33 |
VikasC | kennan, are you around? | 10:34 |
VikasC | tbh:hi | 10:35 |
tbh | Hi | 10:35 |
VikasC | tbh, kennan has already pushed for review with server_type as part of baymodel | 10:36 |
*** dims has quit IRC | 10:36 | |
VikasC | tbh, he doesnt seem around | 10:36 |
tbh | VikasC, Oh can you point me to the patch? | 10:37 |
VikasC | tbh, one moment pls | 10:37 |
*** diga has quit IRC | 10:37 | |
VikasC | tbh, https://review.openstack.org/#/c/198984/7 | 10:38 |
VikasC | tbh, once this is merged .. you can use server_type from baymodel | 10:38 |
VikasC | tbh, will need to catup kennan on this | 10:39 |
tbh | VikasC, yeah sure | 10:39 |
*** h00327910__ has quit IRC | 10:43 | |
*** halfss has quit IRC | 11:05 | |
*** slagle has joined #openstack-containers | 11:12 | |
*** eghobo has joined #openstack-containers | 11:15 | |
*** eghobo has quit IRC | 11:15 | |
*** alex_klimov has quit IRC | 11:17 | |
*** banix has joined #openstack-containers | 11:23 | |
*** dims has joined #openstack-containers | 11:25 | |
*** jruano has joined #openstack-containers | 11:26 | |
*** dims has quit IRC | 11:29 | |
*** dane_leblanc has joined #openstack-containers | 11:44 | |
*** Marga_ has joined #openstack-containers | 11:49 | |
*** alex_klimov has joined #openstack-containers | 11:51 | |
*** ctrath has joined #openstack-containers | 11:56 | |
*** Marga_ has quit IRC | 11:59 | |
*** Marga_ has joined #openstack-containers | 12:02 | |
*** Marga_ has quit IRC | 12:09 | |
*** banix has quit IRC | 12:10 | |
humble__ | yuanying:ping | 12:14 |
*** ishant has quit IRC | 12:17 | |
*** humble__ has quit IRC | 12:17 | |
openstackgerrit | Grzegorz Grasza (xek) proposed openstack/magnum: Indirection API implementation https://review.openstack.org/184791 | 12:17 |
*** tbh has quit IRC | 12:30 | |
*** dims has joined #openstack-containers | 12:33 | |
*** VikasC has quit IRC | 12:36 | |
*** raildo is now known as raildo-afk | 12:40 | |
*** dane_leblanc has quit IRC | 12:43 | |
*** shuquan has joined #openstack-containers | 12:44 | |
*** shuquan has quit IRC | 12:49 | |
*** ctrath has quit IRC | 12:50 | |
*** vimal has quit IRC | 12:57 | |
*** shuquan has joined #openstack-containers | 13:00 | |
*** vimal has joined #openstack-containers | 13:00 | |
*** sdake has quit IRC | 13:17 | |
*** junhongl has quit IRC | 13:18 | |
*** _navneet has joined #openstack-containers | 13:19 | |
*** sdake has joined #openstack-containers | 13:21 | |
*** julim has joined #openstack-containers | 13:22 | |
*** jwcroppe_zzz is now known as jwcroppe | 13:32 | |
*** shuquan has quit IRC | 13:38 | |
*** ctrath has joined #openstack-containers | 13:43 | |
*** shuquan has joined #openstack-containers | 13:44 | |
*** Drago1 has joined #openstack-containers | 13:54 | |
*** jruano has quit IRC | 13:55 | |
*** zul has quit IRC | 13:56 | |
*** rlrossit has joined #openstack-containers | 13:56 | |
*** alex_klimov has quit IRC | 13:56 | |
*** zul has joined #openstack-containers | 13:56 | |
*** Drago2 has joined #openstack-containers | 13:57 | |
*** rpothier has joined #openstack-containers | 14:00 | |
*** Drago1 has quit IRC | 14:00 | |
*** Kennan has joined #openstack-containers | 14:03 | |
*** Kennan2 has quit IRC | 14:03 | |
*** dane_leblanc has joined #openstack-containers | 14:05 | |
*** muralia has quit IRC | 14:05 | |
*** muralia has joined #openstack-containers | 14:06 | |
*** _navneet is now known as ngupta | 14:08 | |
*** ngupta is now known as navgupta | 14:08 | |
*** navgupta is now known as _navneet | 14:10 | |
*** dave-mccowan has quit IRC | 14:13 | |
*** eghobo has joined #openstack-containers | 14:13 | |
*** eghobo has quit IRC | 14:16 | |
*** eghobo has joined #openstack-containers | 14:17 | |
*** eghobo has quit IRC | 14:17 | |
*** Tango has joined #openstack-containers | 14:17 | |
*** irenab has quit IRC | 14:18 | |
*** jlcoello_ has joined #openstack-containers | 14:19 | |
*** jlcoello has quit IRC | 14:22 | |
*** alex_klimov has joined #openstack-containers | 14:23 | |
*** banix has joined #openstack-containers | 14:24 | |
*** alejandrito has joined #openstack-containers | 14:26 | |
*** alex_klimov has quit IRC | 14:27 | |
*** alex_klimov has joined #openstack-containers | 14:28 | |
*** dave-mccowan has joined #openstack-containers | 14:28 | |
*** shuquan has quit IRC | 14:29 | |
*** _navneet_ has joined #openstack-containers | 14:34 | |
*** Drago2 has quit IRC | 14:36 | |
*** _navneet has quit IRC | 14:36 | |
*** zz_dimtruck is now known as dimtruck | 14:37 | |
openstackgerrit | Grzegorz Grasza (xek) proposed openstack/magnum: Indirection API implementation https://review.openstack.org/184791 | 14:37 |
*** kebray has joined #openstack-containers | 14:48 | |
*** Drago1 has joined #openstack-containers | 14:48 | |
*** dave-mccowan has quit IRC | 14:51 | |
*** sdake_ has joined #openstack-containers | 14:53 | |
*** irenab has joined #openstack-containers | 14:54 | |
*** j___ has quit IRC | 14:55 | |
*** Drago1 has quit IRC | 14:56 | |
*** suro-patz has joined #openstack-containers | 14:56 | |
*** Drago1 has joined #openstack-containers | 14:56 | |
*** sdake has quit IRC | 14:58 | |
*** dave-mccowan has joined #openstack-containers | 14:58 | |
*** hongbin has joined #openstack-containers | 14:58 | |
*** kebray has quit IRC | 15:04 | |
*** sdake_ is now known as sdake | 15:06 | |
*** Marga_ has joined #openstack-containers | 15:08 | |
*** _navneet has joined #openstack-containers | 15:08 | |
*** banix has quit IRC | 15:10 | |
*** _navneet_ has quit IRC | 15:11 | |
*** kebray has joined #openstack-containers | 15:11 | |
*** yuanying has quit IRC | 15:13 | |
*** banix has joined #openstack-containers | 15:15 | |
*** dims has quit IRC | 15:17 | |
*** Drago1 has quit IRC | 15:17 | |
*** kebray has quit IRC | 15:17 | |
*** Marga_ has quit IRC | 15:25 | |
*** Marga_ has joined #openstack-containers | 15:25 | |
*** harshs has joined #openstack-containers | 15:26 | |
*** harshs_ has joined #openstack-containers | 15:29 | |
*** harshs has quit IRC | 15:29 | |
*** harshs_ is now known as harshs | 15:29 | |
*** yuanying has joined #openstack-containers | 15:30 | |
*** suro-patz has quit IRC | 15:30 | |
*** wanghua has joined #openstack-containers | 15:32 | |
*** Drago has joined #openstack-containers | 15:33 | |
*** Drago has quit IRC | 15:34 | |
*** Drago has joined #openstack-containers | 15:34 | |
*** Marga_ has quit IRC | 15:35 | |
*** adrian_otto has joined #openstack-containers | 15:42 | |
*** chandankumar has quit IRC | 15:49 | |
*** travisn has joined #openstack-containers | 15:50 | |
*** adrian_otto has quit IRC | 15:50 | |
*** banix has quit IRC | 15:50 | |
*** banix has joined #openstack-containers | 15:51 | |
*** juggler has joined #openstack-containers | 15:57 | |
*** adrian_otto has joined #openstack-containers | 15:59 | |
adrian_otto | Our team meeting begins in a minute in #openstack-meeting-alt | 15:59 |
*** zhenguo has quit IRC | 16:00 | |
*** eghobo has joined #openstack-containers | 16:00 | |
*** vilobhmm1 has joined #openstack-containers | 16:01 | |
*** diga has joined #openstack-containers | 16:03 | |
*** dims has joined #openstack-containers | 16:05 | |
*** sdake_ has joined #openstack-containers | 16:05 | |
*** banix has quit IRC | 16:05 | |
*** vimal has quit IRC | 16:06 | |
*** sdake has quit IRC | 16:09 | |
*** dflorea has joined #openstack-containers | 16:09 | |
*** diga has quit IRC | 16:18 | |
*** sdake_ is now known as sdake | 16:21 | |
*** suro-patz has joined #openstack-containers | 16:23 | |
*** erkules_ is now known as erkules | 16:33 | |
*** erkules has joined #openstack-containers | 16:33 | |
*** alex_klimov has quit IRC | 16:34 | |
*** manjeets has joined #openstack-containers | 16:37 | |
*** jruano has joined #openstack-containers | 16:39 | |
*** kebray has joined #openstack-containers | 16:42 | |
*** BertrandN has quit IRC | 16:43 | |
*** SourabhP has joined #openstack-containers | 16:43 | |
*** SourabhP_ has joined #openstack-containers | 16:45 | |
*** SourabhP has quit IRC | 16:48 | |
*** SourabhP_ is now known as SourabhP | 16:48 | |
*** david-ly_ has joined #openstack-containers | 16:49 | |
*** david-lyle has quit IRC | 16:49 | |
*** humble_ has joined #openstack-containers | 16:59 | |
*** julim has quit IRC | 17:00 | |
*** ameybhide has quit IRC | 17:00 | |
*** kebray has quit IRC | 17:01 | |
*** travisn has left #openstack-containers | 17:02 | |
*** banix has joined #openstack-containers | 17:02 | |
*** harshs_ has joined #openstack-containers | 17:02 | |
*** wanghua has quit IRC | 17:02 | |
*** julim has joined #openstack-containers | 17:03 | |
*** vilobhmm1 has quit IRC | 17:03 | |
*** unicell has quit IRC | 17:03 | |
*** vilobhmm1 has joined #openstack-containers | 17:04 | |
*** sdake_ has joined #openstack-containers | 17:06 | |
*** vilobhmm1 has quit IRC | 17:06 | |
*** sdake has quit IRC | 17:06 | |
*** sdake has joined #openstack-containers | 17:07 | |
*** david-ly_ has quit IRC | 17:07 | |
*** dflorea has quit IRC | 17:08 | |
*** dflorea has joined #openstack-containers | 17:08 | |
*** SourabhP has quit IRC | 17:09 | |
*** sdake_ has quit IRC | 17:10 | |
*** eghobo_ has joined #openstack-containers | 17:12 | |
*** harshs_ has quit IRC | 17:13 | |
*** harshs_ has joined #openstack-containers | 17:15 | |
*** eghobo has quit IRC | 17:16 | |
*** humble_ has quit IRC | 17:18 | |
*** harshs has quit IRC | 17:22 | |
*** harshs_ is now known as harshs | 17:22 | |
*** achanda has joined #openstack-containers | 17:25 | |
mfalatic | How is docker-volume-size related to the size of the disk as specified in the flavor used for a given bay's nodes? | 17:29 |
mfalatic | (In other words, is it a superset of the node's disk size? What criteria is used for sizing the backing store versus the node's storage space?) | 17:30 |
*** unicell has joined #openstack-containers | 17:30 | |
mfalatic | let me restate | 17:30 |
mfalatic | what is the relationship between VOLUME_BACKING_FILE_SIZE (in local.conf), baymodel-create's --docker-volume-size option, and the disk size that's part of a node's flavor (also specified during the baymodel creation)? | 17:31 |
*** ameybhide has joined #openstack-containers | 17:32 | |
*** ekhugen has quit IRC | 17:34 | |
*** ameybhide has quit IRC | 17:44 | |
mfalatic | anyone? | 17:47 |
Tango | mfalatic: It's a separate Cinder volume that will get mounted on a minion node for docker images | 17:49 |
Tango | so it's additional to the size of the flavor | 17:49 |
*** kebray has joined #openstack-containers | 17:49 | |
mfalatic | And how does VOLUME_BACKING_FILE_SIZE correlate to it? | 17:49 |
*** dflorea has quit IRC | 17:51 | |
*** jlcoello_ has quit IRC | 17:52 | |
*** david-lyle has joined #openstack-containers | 17:54 | |
Tango | mfalatic: hmm, not sure, I don't see it referenced in the devstack plugin | 17:54 |
*** vilobhmm1 has joined #openstack-containers | 17:55 | |
mfalatic | Hmm... i wonder if it's unused. VOLUME_BACKING_FILE_SIZE=20G is in the docs but maybe it's deprecated. | 17:55 |
mfalatic | Actually no | 17:58 |
*** SourabhP has joined #openstack-containers | 17:58 | |
mfalatic | it's related to nova and cinder... | 17:58 |
mfalatic | Looks like we're increasing that storage space in devstack. | 17:59 |
*** dflorea has joined #openstack-containers | 18:00 | |
*** banix has quit IRC | 18:00 | |
*** chandankumar has joined #openstack-containers | 18:00 | |
*** rsFF has joined #openstack-containers | 18:01 | |
mfalatic | I'm not yet sure how it's used though. It's certainly too small for even one m1.small node so perhaps it's not so much for that as for backing the cinder storage (and correlated to docker-volume-size.) | 18:01 |
*** david-lyle has quit IRC | 18:01 | |
*** _navneet_ has joined #openstack-containers | 18:02 | |
*** banix has joined #openstack-containers | 18:02 | |
apmelton | tcammann: ping | 18:03 |
*** jlcoello has joined #openstack-containers | 18:03 | |
*** dflorea has quit IRC | 18:04 | |
*** wznoinsk has quit IRC | 18:04 | |
*** _navneet has quit IRC | 18:05 | |
*** wznoinsk has joined #openstack-containers | 18:07 | |
*** Tango has quit IRC | 18:12 | |
*** SourabhP has quit IRC | 18:16 | |
*** SourabhP has joined #openstack-containers | 18:17 | |
*** david-lyle has joined #openstack-containers | 18:19 | |
*** Marga_ has joined #openstack-containers | 18:21 | |
manjeets | https://bugs.launchpad.net/magnum/+bug/1491072 | 18:23 |
openstack | Launchpad bug 1491072 in Magnum "for swarm bay status always says none " [Undecided,New] | 18:23 |
manjeets | Tango: | 18:23 |
mfalatic | manjeets - for that swarm bug, is this using devstack? | 18:27 |
manjeets | yes I am using devstack | 18:27 |
mfalatic | Not as familiar with swarm but I wonder, is just the status wrong or are there other problems too? | 18:29 |
manjeets | status is not updating at all it always shows none | 18:29 |
manjeets | it does not show create_in_progress, create_completed | 18:29 |
manjeets | i just recloned magnum todayy | 18:30 |
*** jruano has quit IRC | 18:30 | |
mfalatic | Interesting. | 18:31 |
apmelton | mfalatic: manjeets: I'm working on that right now | 18:31 |
apmelton | the conductor is blowing up here: https://github.com/openstack/magnum/blob/master/magnum/conductor/handlers/bay_conductor.py#L243 | 18:32 |
mfalatic | Sounds good - it rang a bell for me but I'm not sure what all runs on the swarm nodes versus regular nodes. | 18:32 |
apmelton | because number_of_minions is only valid for k8s | 18:32 |
manjeets | ampleton: master_count is also added | 18:33 |
manjeets | what is master count in swarm_bay ? | 18:33 |
apmelton | manjeets: master_count? | 18:33 |
manjeets | is it a manager count for swarm bay ? | 18:34 |
manjeets | apmelton: when i list bays i see new field master_count | 18:35 |
apmelton | that's only k8s as well | 18:36 |
manjeets | then we should set master_count to NULL or something else for all other bays | 18:38 |
manjeets | apmelton: its showing 1 for swarm bay right now | 18:39 |
*** dims has quit IRC | 18:40 | |
*** dims has joined #openstack-containers | 18:40 | |
*** kebray has quit IRC | 18:45 | |
*** dims has quit IRC | 18:45 | |
manjeets | apmelton: | 18:48 |
apmelton | manjeets: that's because the API defaults it to one, it's not used anywhere except the k8s template | 18:50 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum: Updated from global requirements https://review.openstack.org/218907 | 18:51 |
*** Marga_ has quit IRC | 18:53 | |
*** raildo-afk is now known as raildo | 18:53 | |
*** eghobo_ has quit IRC | 18:56 | |
*** SourabhP has quit IRC | 18:58 | |
vilobhmm1 | adrian_otto : Hi! have couple of minutes ? | 18:58 |
manjeets | apmelton: ok is it necessary to show master_count while listing bays ? | 18:58 |
manjeets | we can remove it from magnum bay-list and add while doing magnum bay-show abcbay | 18:59 |
adrian_otto | vilobhmm1: I'm just on my way into a meeting | 18:59 |
adrian_otto | but I can check back in an hour | 18:59 |
vilobhmm1 | adrain_otto: that works. thanks ! | 18:59 |
*** adrian_otto has quit IRC | 18:59 | |
apmelton | manjeets: I'm not sure it's quite an important metric as mdoe count, moving it to bay-show might be a good idea | 18:59 |
apmelton | as node count* | 19:00 |
manjeets | i can take that and submit a patch for that lets see what other say | 19:01 |
*** adrian_otto has joined #openstack-containers | 19:01 | |
*** kebray has joined #openstack-containers | 19:04 | |
*** dims has joined #openstack-containers | 19:09 | |
*** eghobo has joined #openstack-containers | 19:09 | |
*** sdake_ has joined #openstack-containers | 19:12 | |
*** sdake has quit IRC | 19:13 | |
*** dims has quit IRC | 19:13 | |
*** sdake has joined #openstack-containers | 19:13 | |
*** julim has quit IRC | 19:14 | |
*** dane_leblanc has quit IRC | 19:16 | |
*** sdake_ has quit IRC | 19:18 | |
*** dims has joined #openstack-containers | 19:18 | |
*** banix has quit IRC | 19:21 | |
*** dims has quit IRC | 19:25 | |
*** dane_leblanc has joined #openstack-containers | 19:25 | |
*** kebray has quit IRC | 19:26 | |
*** jwcroppe has quit IRC | 19:34 | |
*** raginbajin has quit IRC | 19:34 | |
*** harlowja has quit IRC | 19:34 | |
*** eliqiao has quit IRC | 19:34 | |
*** whydidyoustealmy has quit IRC | 19:34 | |
*** brendenblanco has quit IRC | 19:34 | |
*** jwcroppe has joined #openstack-containers | 19:35 | |
*** raginbajin has joined #openstack-containers | 19:35 | |
*** eliqiao has joined #openstack-containers | 19:35 | |
*** whydidyoustealmy has joined #openstack-containers | 19:35 | |
*** brendenblanco has joined #openstack-containers | 19:35 | |
*** harlowja has joined #openstack-containers | 19:35 | |
*** whydidyoustealmy has quit IRC | 19:35 | |
*** harlowja has quit IRC | 19:35 | |
*** harlowja has joined #openstack-containers | 19:35 | |
*** dims has joined #openstack-containers | 19:35 | |
*** whydidyoustealmy has joined #openstack-containers | 19:36 | |
openstackgerrit | Andrew Melton proposed openstack/magnum: Bay: pull node count update into template definitions https://review.openstack.org/219424 | 19:37 |
*** unicell has quit IRC | 19:38 | |
apmelton | manjeets: ^^ that should fix your status issue | 19:39 |
openstackgerrit | Andrew Melton proposed openstack/magnum: Bay: pull node count update into template definitions https://review.openstack.org/219424 | 19:42 |
*** sdake_ has joined #openstack-containers | 19:45 | |
*** kebray has joined #openstack-containers | 19:47 | |
*** harlowja has quit IRC | 19:47 | |
*** jwcroppe has quit IRC | 19:47 | |
*** raginbajin has quit IRC | 19:47 | |
*** eliqiao has quit IRC | 19:47 | |
*** brendenblanco has quit IRC | 19:47 | |
*** sdake has quit IRC | 19:49 | |
*** sdake has joined #openstack-containers | 19:49 | |
*** ioni has quit IRC | 19:50 | |
*** ioni has joined #openstack-containers | 19:51 | |
*** harlowja has joined #openstack-containers | 19:52 | |
*** jwcroppe has joined #openstack-containers | 19:52 | |
*** raginbajin has joined #openstack-containers | 19:52 | |
*** eliqiao has joined #openstack-containers | 19:52 | |
*** brendenblanco has joined #openstack-containers | 19:52 | |
*** sdake_ has quit IRC | 19:53 | |
*** ekhugen has joined #openstack-containers | 19:54 | |
*** chandankumar has quit IRC | 19:57 | |
*** julim has joined #openstack-containers | 19:58 | |
*** kebray has quit IRC | 20:03 | |
*** kebray has joined #openstack-containers | 20:05 | |
*** unicell has joined #openstack-containers | 20:05 | |
openstackgerrit | Merged openstack/magnum: Change bay.*_cert_uuid to bay.*_cert_ref https://review.openstack.org/218086 | 20:06 |
manjeets | apmelton: i pulled your code and test its still same | 20:12 |
manjeets | tested* | 20:12 |
manjeets | still showing bay_status none | 20:13 |
apmelton | manjeets: can you paste the output of a 'heat stack-list'? | 20:14 |
manjeets | its showing there Create_Complete but my point was when i magnum bay-list it shows status none | 20:16 |
manjeets | apmelton: | 20:17 |
apmelton | manjeets: got a bug in my change somewhere, give me a few | 20:17 |
manjeets | ok | 20:17 |
*** dave-mccowan has quit IRC | 20:25 | |
*** harshs has quit IRC | 20:25 | |
*** julim has quit IRC | 20:29 | |
*** SourabhP has joined #openstack-containers | 20:31 | |
*** rlrossit has left #openstack-containers | 20:34 | |
*** dave-mccowan has joined #openstack-containers | 20:38 | |
*** julim has joined #openstack-containers | 20:42 | |
*** absubram has joined #openstack-containers | 20:43 | |
*** afranc202 has joined #openstack-containers | 20:45 | |
openstackgerrit | Travis Nguyen proposed openstack/magnum: WIP: Update functional test for the k8s api https://review.openstack.org/218373 | 20:49 |
*** rlrossit has joined #openstack-containers | 20:51 | |
*** sdake has quit IRC | 20:53 | |
*** achanda has quit IRC | 20:54 | |
*** alex_klimov has joined #openstack-containers | 20:56 | |
*** Tango has joined #openstack-containers | 20:57 | |
*** suro-patz has quit IRC | 21:00 | |
*** raildo is now known as raildo-afk | 21:02 | |
*** suro-patz has joined #openstack-containers | 21:04 | |
*** suro-patz has quit IRC | 21:05 | |
*** achanda has joined #openstack-containers | 21:07 | |
*** suro-patz has joined #openstack-containers | 21:08 | |
mfalatic | This etcd problem I'm having doesn't make sense. | 21:10 |
*** vilobhmm1 has quit IRC | 21:10 | |
*** vilobhmm1 has joined #openstack-containers | 21:11 | |
mfalatic | even on an older devstack things work for a while, then I can't get to the master or minions anymore via ssh. memory doesn't seem to be a problem (not seeing any leakage yet) | 21:11 |
mfalatic | This is from the machine they are hosted upon. | 21:11 |
*** eghobo has quit IRC | 21:13 | |
*** kebray has quit IRC | 21:17 | |
*** harshs has joined #openstack-containers | 21:19 | |
*** irenab_ has joined #openstack-containers | 21:20 | |
*** suro-patz has quit IRC | 21:20 | |
*** irenab has quit IRC | 21:20 | |
*** irenab_ is now known as irenab | 21:20 | |
*** kebray has joined #openstack-containers | 21:21 | |
*** julim has quit IRC | 21:25 | |
*** achanda has quit IRC | 21:30 | |
*** eghobo has joined #openstack-containers | 21:31 | |
*** kebray has quit IRC | 21:35 | |
*** kebray has joined #openstack-containers | 21:36 | |
*** rlrossit has left #openstack-containers | 21:37 | |
*** SourabhP has quit IRC | 21:42 | |
*** rpothier has quit IRC | 21:48 | |
*** alex_klimov has quit IRC | 21:51 | |
*** jlcoello has quit IRC | 21:59 | |
*** _navneet_ has quit IRC | 22:01 | |
*** suro-patz has joined #openstack-containers | 22:01 | |
vilobhmm1 | hongbin : ping | 22:03 |
hongbin | vilobhmm1: what's up | 22:04 |
vilobhmm1 | https://bugs.launchpad.net/magnum/+bug/1487257 since this is sqlite specific issue | 22:04 |
openstack | Launchpad bug 1487257 in Magnum "syntax error on sqlite schema upgrade" [Undecided,New] - Assigned to Vilobh Meshram (vilobhmm) | 22:04 |
vilobhmm1 | we should document it…and thats what even the person who filed the bug expects to be…any idea where this note should be placed | 22:04 |
vilobhmm1 | hongbin : what are your thoughts on it ? | 22:05 |
hongbin | vilobhmm1: Maybe quickstart guide? | 22:06 |
hongbin | vilobhmm1: But if users follows the quickstart guide well, they shouldn't get into this bug | 22:07 |
vilobhmm1 | https://github.com/openstack/magnum/blob/master/doc/source/dev/dev-quickstart.rst and add a note that only mysql backend is allowed | 22:07 |
vilobhmm1 | hongbin : true but just that if we are explicit we won't get such request again IMHO | 22:08 |
hongbin | Maybe write a note to instruct users how to migrate the DB properly | 22:08 |
vilobhmm1 | hongbin : sure | 22:08 |
vilobhmm1 | thanks ! :) | 22:08 |
hongbin | welcome | 22:09 |
*** ctrath has quit IRC | 22:09 | |
vilobhmm1 | hongbin : you have few more min ? | 22:09 |
vilobhmm1 | may be like 5 min or so | 22:09 |
hongbin | yes, go ahead | 22:09 |
vilobhmm1 | https://review.openstack.org/#/c/219043/ hua had an objection I clarified the same and proposed 2 approach to tackle it…if you can go through my latest comment https://review.openstack.org/#/c/219043/ it would be nice | 22:10 |
*** SourabhP has joined #openstack-containers | 22:11 | |
vilobhmm1 | adrian_otto : need to make a decision on this…if you can also have a look it would be helpful : ^^ | 22:11 |
*** manjeets has quit IRC | 22:13 | |
hongbin | vilobhmm1: I think Hua's argument is valid. Then how about leave it as is | 22:14 |
vilobhmm1 | hongbin : sure ..both the approaches are ok IMHO….but the argument is about adding something that might come in future and keeping dead code….and there was a counter argument from another review that why we keeping dead code if its not invoked anywhere :P so was kinda tricky | 22:17 |
adrian_otto | vilobhmm1: I'm having a look at it | 22:17 |
vilobhmm1 | adrian_otto : thanks | 22:17 |
adrian_otto | vilobhmm1: does that code have unit tests? | 22:19 |
vilobhmm1 | yes https://review.openstack.org/#/c/219043/ | 22:19 |
adrian_otto | If so, we can leave it, submit a blueprint, and revisit it once that blueprint is done | 22:20 |
adrian_otto | there is no point in deleting code that we reasonably expect to use again soon | 22:20 |
adrian_otto | I would agree with deleting it if we really had no plans for it at all | 22:20 |
vilobhmm1 | adrain_otto, hongbin : sure | 22:21 |
vilobhmm1 | so as proposed in https://review.openstack.org/#/c/219043/ will take route #1 | 22:21 |
adrian_otto | I do agree with the point that it should not stay around in the absence of a bug or blueprint though | 22:21 |
vilobhmm1 | in my latest comment | 22:21 |
adrian_otto | yes | 22:21 |
adrian_otto | would you be kind enough to submit the BP | 22:21 |
adrian_otto | ? | 22:22 |
vilobhmm1 | adrian_otto : thanks ! :) that helps | 22:22 |
vilobhmm1 | I will do that ASAP | 22:22 |
adrian_otto | thanks!! | 22:22 |
vilobhmm1 | np | 22:22 |
vilobhmm1 | hongbin : thanks for your input as well | 22:22 |
hongbin | np | 22:22 |
adrian_otto | ok, I voted -2 on the review, and added my rationale | 22:25 |
adrian_otto | I'm willing to revisit this again ,if desired. | 22:25 |
vilobhmm1 | adrian_otto : https://blueprints.launchpad.net/magnum/+spec/resource-list-by-bay-uuid | 22:28 |
vilobhmm1 | have specifically added regarding the evaluation for the need of list_by_bay_uuid API in the description | 22:28 |
mfalatic | Does this etcd error ring a bell for anyone? | 22:28 |
mfalatic | "as different advertised URLs in the cluster and advertised peer URLs list" | 22:28 |
vilobhmm1 | sure | 22:28 |
mfalatic | *has | 22:28 |
mfalatic | seen on k8s master after bay create. | 22:29 |
adrian_otto | thanks vilobhmm1. I appreciate your leadership on this topic. | 22:29 |
vilobhmm1 | :) thanks | 22:30 |
*** manjeets has joined #openstack-containers | 22:31 | |
mfalatic | Full error: "etcd: 10.0.0.5 has different advertised URLs in the cluster and advertised peer URLs list" | 22:33 |
mfalatic | this kills the etcd process. | 22:33 |
hongbin | mfalatic: could you paste this file? /etc/etcd/etcd.conf | 22:35 |
hongbin | mfalatic: better to paste the etcd log as well | 22:35 |
mfalatic | Will do. Was there some similar issue within the last two weeks or so? | 22:35 |
hongbin | This is the first time I saw it | 22:36 |
mfalatic | http://paste.openstack.org/show/438918/ | 22:38 |
mfalatic | It could be a misconfig here. I was previously using the default neutron addresses (172.24.4.*) but now a using a specific internal subnet because that goes badly when you ahve two devstack boxes on one network. | 22:39 |
hongbin | mfalatic: The problem is the etcd config file, ETCD_DISCOVERY should not be empty | 22:40 |
mfalatic | Hmm... I wonder why it's empty... | 22:41 |
hongbin | any luck if you destroy and re-create the baymodel and bay? | 22:41 |
mfalatic | I didn't manually change anything in the master | 22:41 |
mfalatic | I can give it a shot. may need to reboot if it can't tear down cleanly. | 22:41 |
hongbin | reboot is an overkill I think | 22:42 |
*** kebray has quit IRC | 22:42 | |
*** alejandrito_ has joined #openstack-containers | 22:43 | |
mfalatic | Well, sometimes I've gotten vms that won't go away. but it's been an unusual day. | 22:44 |
mfalatic | I see I have (had now that the bay is deleted) a demo subnet as well as a k8s subnet both on 10.0.0.0/24 | 22:45 |
*** alejandrito_ has quit IRC | 22:45 | |
*** alejandrito has quit IRC | 22:45 | |
mfalatic | hongbin ok deleted bay and bay model | 22:46 |
mfalatic | now, as I rec-create things anything I should check along the way | 22:46 |
mfalatic | ? | 22:46 |
hongbin | 1. of course, check the etcd config file | 22:47 |
hongbin | 2. magnum bay-show <bay> to see the "discovery_url" attribute | 22:48 |
mfalatic | I mean before I actually create the bay. | 22:48 |
mfalatic | and do I need to pause after baymodel-create? that seems pretty usually. | 22:49 |
mfalatic | *pretty quick | 22:49 |
hongbin | No, you don't need to | 22:49 |
hongbin | nothing special I can think of | 22:49 |
mfalatic | Hey, there's one now! | 22:50 |
mfalatic | and it was clearly empty on the revious try (I scrolled back - I always do a show during creation. | 22:51 |
mfalatic | what's up with that | 22:51 |
mfalatic | (and should it ever be empty?) | 22:51 |
*** muralia has quit IRC | 22:51 | |
mfalatic | if not, maybe it should throw an error then, eh> | 22:51 |
hongbin | mfalatic: you are on the latest master? | 22:51 |
mfalatic | nope, it's dated by a week or two now. Thats why I asked. Is master currently sane? | 22:52 |
*** muralia has joined #openstack-containers | 22:52 | |
mfalatic | I can and will update, but wanted to get my config change stabilized. So that's the next step - assuming master isn't broken today | 22:53 |
mfalatic | (which happens) | 22:53 |
*** eghobo has quit IRC | 22:53 | |
hongbin | mfalatic: if you are not in master, which commit you are in? | 22:54 |
mfalatic | hongbin - And thanks! Now I know what to watch out for. | 22:54 |
mfalatic | hang on let me look | 22:54 |
*** achanda has joined #openstack-containers | 22:54 | |
mfalatic | hongbin - it appears to be 8719df3b993cd15a1e1ab224207c95d18a298423 for magnum. 8/27 so not that old. | 22:56 |
hongbin | should be fine | 22:56 |
mfalatic | weird then. | 22:56 |
hongbin | could you try to debug why discovery_utl is not generated? It should be generated in the conductor | 22:57 |
mfalatic | I can see what I can find... | 22:57 |
*** apuimedo has joined #openstack-containers | 22:58 | |
apuimedo | daneyon_: ping | 22:58 |
*** achanda has quit IRC | 22:59 | |
*** adrian_otto has quit IRC | 23:00 | |
mfalatic | hongbin - not sure what I'm looking for... I can see it's empty in the log (and debugging is on) | 23:02 |
hongbin | mfalatic: check here: https://github.com/openstack/magnum/blob/master/magnum/conductor/template_definition.py#L375 | 23:02 |
*** dims has quit IRC | 23:03 | |
mfalatic | oh, I was reading the logs | 23:03 |
hongbin | That is the place generated the url | 23:03 |
mfalatic | That code is present. | 23:04 |
hongbin | So that method is called but the url is not generated? | 23:05 |
*** eghobo has joined #openstack-containers | 23:05 | |
mfalatic | evidently | 23:05 |
mfalatic | however | 23:06 |
mfalatic | discovery_url = requests.get(discovery_endpoint).text doesn't get checked. | 23:06 |
mfalatic | if it's inthat branch of the code, it could potentially end up an empty string | 23:06 |
mfalatic | And the string appears empty in the logs, not " " but "" | 23:07 |
hongbin | so it goes to "if" branch? | 23:07 |
mfalatic | I can't reproduce it but it seems the only place it could go | 23:09 |
mfalatic | it's working now after the re-create. | 23:09 |
mfalatic | but given the tests in the code, if it's empty it should fall into the else. | 23:09 |
hongbin | ok. if it works, then everything should be fine | 23:09 |
hongbin | will check whether it has tests | 23:10 |
mfalatic | it appears "if hasattr(bay, 'discovery_url') and bay.discovery_url:" failed, and the alternate branch has no check for an empty url | 23:10 |
hongbin | or maybe requests.get(discovery_endpoint).text return an empty string | 23:11 |
hongbin | due to internet connection | 23:11 |
mfalatic | Thats what I mean | 23:11 |
mfalatic | That's unchecked | 23:11 |
mfalatic | and the code is solid otherwise - it must go there if string is present but empty. | 23:12 |
mfalatic | Not a huge bug but a bug nonetheless. | 23:12 |
mfalatic | Shall I open a bug on it then? | 23:13 |
mfalatic | (to at least track it) | 23:13 |
hongbin | feel free to open a bug | 23:15 |
hongbin | Need to drive home now. See you folks | 23:15 |
mfalatic | thanks! | 23:16 |
*** hongbin has quit IRC | 23:16 | |
*** eghobo has quit IRC | 23:16 | |
*** eghobo has joined #openstack-containers | 23:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum: Updated from global requirements https://review.openstack.org/218907 | 23:21 |
*** absubram has quit IRC | 23:24 | |
*** dims__ has joined #openstack-containers | 23:24 | |
mfalatic | https://bugs.launchpad.net/magnum/+bug/1491178 | 23:26 |
openstack | Launchpad bug 1491178 in Magnum "get_discovery_url doesn't fully check for empty URL strings" [Undecided,New] | 23:26 |
openstackgerrit | Dimitry Ushakov proposed openstack/magnum: Catch presence for required fields when attempting to retrieve user info https://review.openstack.org/219508 | 23:27 |
*** dane_leblanc has quit IRC | 23:31 | |
manjeets | apmelton: i see lot of things messed up | 23:40 |
manjeets | i am deleting bays and after some all nova instances are gone but bay entry is still there when i do magnum-list | 23:41 |
openstackgerrit | Dimitry Ushakov proposed openstack/magnum: Catch presence for required fields when attempting to retrieve user info https://review.openstack.org/219508 | 23:44 |
*** y_sawai has joined #openstack-containers | 23:48 | |
*** Drago has quit IRC | 23:51 | |
*** kebray has joined #openstack-containers | 23:51 | |
*** y_sawai has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!