Tuesday, 2016-11-08

*** hongbin has quit IRC00:02
*** fragatin_ has quit IRC00:05
*** vijendar has quit IRC00:05
*** vijendar has joined #openstack-containers00:06
*** askb has joined #openstack-containers00:06
*** fragatina has joined #openstack-containers00:08
*** vijendar has quit IRC00:21
*** vijendar has joined #openstack-containers00:22
*** gluytium has joined #openstack-containers00:23
*** adrian_otto has joined #openstack-containers00:36
*** adrian_otto has quit IRC00:39
*** adrian_otto has joined #openstack-containers00:41
*** adrian_otto has quit IRC00:42
*** duonghq has joined #openstack-containers00:43
*** adrian_otto has joined #openstack-containers00:43
*** syed_ has quit IRC00:45
*** adrian_otto has quit IRC00:46
*** adrian_otto has joined #openstack-containers00:46
*** tkarke has quit IRC01:00
*** tkarke has joined #openstack-containers01:01
*** tkarke has quit IRC01:02
*** chetna has quit IRC01:11
*** adrian_otto has quit IRC01:16
*** trananhkma has quit IRC01:22
*** adrian_otto has joined #openstack-containers01:27
*** vijendar has quit IRC01:30
*** vijendar has joined #openstack-containers01:30
*** adrian_otto has quit IRC01:33
*** trananhkma has joined #openstack-containers01:39
*** vijendar has quit IRC01:46
*** vijendar has joined #openstack-containers01:46
*** vijendar has quit IRC02:02
*** muralia_ has joined #openstack-containers02:12
*** muralia has quit IRC02:14
*** shu-mutou has joined #openstack-containers02:20
*** hongbin has joined #openstack-containers02:24
*** muralia has joined #openstack-containers02:27
*** muralia_ has quit IRC02:27
*** fragatina has quit IRC02:50
*** fragatina has joined #openstack-containers02:55
*** fragatina has quit IRC02:56
*** adrian_otto has joined #openstack-containers03:07
*** adrian_otto has quit IRC03:26
*** vijendar has joined #openstack-containers03:26
*** vijendar_ has joined #openstack-containers03:33
*** vijendar has quit IRC03:33
*** adisky has joined #openstack-containers03:40
*** tonanhngo has quit IRC03:53
*** vijendar_ has quit IRC04:00
*** dave-mccowan has quit IRC04:01
*** tonanhngo has joined #openstack-containers04:02
*** vijendar has joined #openstack-containers04:04
*** tonanhngo has quit IRC04:04
*** vijendar has quit IRC04:08
*** narayrak has joined #openstack-containers04:17
*** tonanhngo has joined #openstack-containers04:24
*** tonanhngo has quit IRC04:25
*** hongbin has quit IRC04:32
*** tonanhngo has joined #openstack-containers04:44
*** tonanhngo has quit IRC04:46
*** tonanhngo has joined #openstack-containers05:05
*** tonanhngo has quit IRC05:06
*** tonanhngo has joined #openstack-containers05:20
*** tonanhngo has quit IRC05:20
*** ramishra has quit IRC05:30
*** ramishra has joined #openstack-containers05:31
*** chetna has joined #openstack-containers05:33
*** jperry has joined #openstack-containers05:42
*** fragatina has joined #openstack-containers05:43
*** takashi has joined #openstack-containers05:46
*** fragatina has quit IRC05:47
*** rcernin has joined #openstack-containers05:54
*** vimal has joined #openstack-containers05:58
*** chetna has quit IRC05:59
*** takashi has quit IRC06:00
*** GB21 has joined #openstack-containers06:01
*** vmud213 has joined #openstack-containers06:35
*** dimtruck is now known as zz_dimtruck06:36
*** chetna has joined #openstack-containers06:44
*** chetna has quit IRC06:45
*** belmoreira has joined #openstack-containers06:50
*** pcaruana has joined #openstack-containers06:53
*** chetna has joined #openstack-containers06:53
*** chetna has quit IRC06:54
*** snarwade has quit IRC06:59
*** david-lyle has quit IRC07:03
*** snarwade has joined #openstack-containers07:11
openstackgerrityatin proposed openstack/python-magnumclient: Remove invalid check for 'manifest' path  https://review.openstack.org/39320707:21
openstackgerrityatin proposed openstack/python-magnumclient: Increase UT coverage  https://review.openstack.org/39479807:21
*** chetna has joined #openstack-containers07:54
*** Jeffrey4l has quit IRC07:54
*** chetna has quit IRC07:55
*** pcastets has joined #openstack-containers07:56
*** takashi has joined #openstack-containers07:56
*** wangbo has quit IRC08:04
*** sahilsinha has quit IRC08:07
openstackgerrityatin proposed openstack/python-magnumclient: Increase UT coverage  https://review.openstack.org/39479808:09
*** wangbo has joined #openstack-containers08:18
*** jperry has quit IRC08:21
*** GheRivero has joined #openstack-containers08:27
*** tovin07_ has joined #openstack-containers08:31
*** zenoway has joined #openstack-containers08:36
*** sahilsinha has joined #openstack-containers08:37
openstackgerritSpyros Trigazis proposed openstack/magnum: Make cinder volume optional  https://review.openstack.org/39183008:40
*** chetna has joined #openstack-containers08:40
*** chetna has quit IRC08:41
*** narayrak has quit IRC08:43
openstackgerritOpenStack Proposal Bot proposed openstack/magnum-ui: Imported Translations from Zanata  https://review.openstack.org/39482208:43
*** narayrak has joined #openstack-containers08:44
*** shu-mutou is now known as shu-mutou-AWAY09:02
*** khamtamtun has joined #openstack-containers09:07
*** khamtamtun has quit IRC09:10
openstackgerritMerged openstack/magnum-ui: Imported Translations from Zanata  https://review.openstack.org/39482209:11
GheRiveromorning09:21
*** strigazi_AFK is now known as strigazi09:25
strigaziGheRivero, hi09:28
*** narayrak has quit IRC09:38
*** narayrak has joined #openstack-containers09:38
*** pcaruana has quit IRC09:51
*** Jeffrey4l has joined #openstack-containers09:55
*** narayrak has quit IRC10:00
*** narayrak has joined #openstack-containers10:00
*** Jeffrey4l has quit IRC10:00
*** narayrak has quit IRC10:01
*** narayrak has joined #openstack-containers10:01
*** tovin07_ has quit IRC10:03
openstackgerritMerged openstack/magnum: Remove unused configure-flannel.sh  https://review.openstack.org/39449510:03
*** Jeffrey4l has joined #openstack-containers10:08
*** Jeffrey4l has quit IRC10:14
*** askb has quit IRC10:16
*** duonghq has quit IRC10:26
openstackgerritfengbeihong proposed openstack/magnum: Support dcos installation on centos cluster  https://review.openstack.org/38643510:29
openstackgerritfengbeihong proposed openstack/magnum: [WIP] Add test for supporting dcos in magnum  https://review.openstack.org/39427010:30
*** jperry has joined #openstack-containers10:32
*** maestropandy has joined #openstack-containers10:38
*** maestropandy has left #openstack-containers10:41
*** chhavi has joined #openstack-containers10:58
*** chetna has joined #openstack-containers11:26
*** chetna has quit IRC11:27
*** dfflanders has quit IRC11:33
*** khamtamtun has joined #openstack-containers12:00
*** khamtamtun has quit IRC12:05
*** khamtamtun has joined #openstack-containers12:05
*** khamtamtun has quit IRC12:07
*** khamtamtun has joined #openstack-containers12:17
*** david-lyle has joined #openstack-containers12:37
*** GB21 has quit IRC12:38
*** wangbo has quit IRC12:42
*** Drago has joined #openstack-containers12:46
*** zz_dimtruck is now known as dimtruck12:56
*** snarwade has quit IRC13:00
*** chhavi has quit IRC13:01
*** trananhkma has quit IRC13:02
*** khamtamtun has quit IRC13:02
*** takashi has quit IRC13:09
*** jperry has quit IRC13:09
*** chhavi has joined #openstack-containers13:10
*** DanyC has joined #openstack-containers13:13
*** vmud213 has quit IRC13:24
*** david-lyle has quit IRC13:29
*** jwcroppe has quit IRC13:35
*** jwcroppe has joined #openstack-containers13:36
*** jwcroppe has quit IRC13:40
*** khamtamtun has joined #openstack-containers13:42
*** khamtamtun has quit IRC13:43
*** DanyC has left #openstack-containers13:43
*** openstackgerrit has quit IRC13:48
*** openstackgerrit has joined #openstack-containers13:49
*** jwcroppe has joined #openstack-containers13:57
*** fragatina has joined #openstack-containers13:57
*** fragatina has quit IRC14:02
*** _mbelanger has joined #openstack-containers14:09
*** chetna has joined #openstack-containers14:13
*** chetna has quit IRC14:14
*** dave-mccowan has joined #openstack-containers14:14
*** jperry has joined #openstack-containers14:23
*** hieulq_ has joined #openstack-containers14:31
*** hieulq_ has quit IRC14:32
*** hieulq_ has joined #openstack-containers14:34
*** absubram has joined #openstack-containers14:39
*** absubram_ has joined #openstack-containers14:41
*** absubram has quit IRC14:44
*** absubram_ is now known as absubram14:44
*** mjura has joined #openstack-containers14:44
*** mjura has quit IRC14:45
*** mjura has joined #openstack-containers14:45
*** hongbin has joined #openstack-containers14:46
*** Drago has quit IRC14:49
*** FengShengqin has joined #openstack-containers14:54
*** _mbelanger has quit IRC14:55
*** mjura has quit IRC14:57
*** catintheroof has joined #openstack-containers14:57
*** vimal has quit IRC15:01
*** adrian_otto has joined #openstack-containers15:01
openstackgerritSpyros Trigazis proposed openstack/magnum: [WIP] Add cluster_attributes table  https://review.openstack.org/39501215:03
*** vijendar has joined #openstack-containers15:06
*** hieulq_ has quit IRC15:12
*** hieulq_ has joined #openstack-containers15:13
*** mastermind has joined #openstack-containers15:22
*** absubram has quit IRC15:22
*** zenoway has quit IRC15:25
*** zenoway has joined #openstack-containers15:28
*** david-lyle has joined #openstack-containers15:29
*** vijendar has quit IRC15:31
*** vijendar has joined #openstack-containers15:32
*** adrian_otto has quit IRC15:32
*** mastermind has quit IRC15:32
*** tonanhngo has joined #openstack-containers15:33
*** david-lyle has quit IRC15:34
*** narayrak has quit IRC15:35
*** tonanhngo has quit IRC15:37
*** _mbelanger has joined #openstack-containers15:38
*** Drago has joined #openstack-containers15:38
*** jmckind has joined #openstack-containers15:39
*** vijendar has quit IRC15:42
*** Drago has quit IRC15:42
*** vijendar has joined #openstack-containers15:43
*** chris_hultin|AWA is now known as chris_hultin15:43
*** chris_hultin is now known as chris_hultin|AWA15:44
*** rpothier has joined #openstack-containers15:45
*** chris_hultin|AWA is now known as chris_hultin15:46
*** adrian_otto has joined #openstack-containers15:46
adrian_ottoOur team meeting will begin in just under 15 minutes in #openstack-meeting-alt (note time shift for those who use DST in their local timezones)15:47
adrian_ottoWe will begin at 1600 UTC15:47
*** adrian_otto has quit IRC15:47
*** Drago has joined #openstack-containers15:48
*** syed_ has joined #openstack-containers15:49
strigazi adrian_otto https://review.openstack.org/#/c/391770/15:49
strigaziadrian_otto requires a PTL +115:50
*** muralia has quit IRC15:52
*** randallburt has joined #openstack-containers15:55
*** adrian_otto has joined #openstack-containers15:57
*** belmoreira has quit IRC15:58
*** chetna has joined #openstack-containers15:58
*** chetna has quit IRC15:59
*** randallburt has quit IRC16:00
*** randallburt has joined #openstack-containers16:07
*** anush has quit IRC16:13
*** zenoway has quit IRC16:17
*** ramishra has quit IRC16:17
*** zenoway has joined #openstack-containers16:18
*** ramishra has joined #openstack-containers16:19
*** rcernin has quit IRC16:20
*** zenoway has quit IRC16:22
*** chhavi has quit IRC16:22
*** hieulq_ has quit IRC16:37
*** jasond has joined #openstack-containers16:43
*** muralia has joined #openstack-containers16:47
*** FengShengqin has quit IRC16:49
*** tonanhngo has joined #openstack-containers16:52
*** tonanhngo has quit IRC16:53
Dragohongbin: Let's continue the discussion here :)16:53
hongbinDrago: i will go to lunch in about 1 hour16:54
Dragohongbin: I will too16:54
hongbinDrago: ok, we can discuss it after an hour i guess16:54
*** tonanhngo has joined #openstack-containers16:54
Dragohongbin: We can discuss until one of us has to leave, and then continue after lunch16:55
hongbinDrago: oh, i mean i will go to lunch now, and back in an hour16:55
hongbinDrago: sorry, i said that wrong in before16:55
*** rcernin has joined #openstack-containers16:56
Dragohongbin: Oh okay. I will be at lunch in an hour, so I will be back in 2+ hours16:56
hongbinDrago: ok16:56
*** GheRivero has left #openstack-containers16:59
strigaziadrian_otto, https://review.openstack.org/#/c/391770/ requires a PTL +117:02
adrian_ottook strigazi I will have a look. Thanks for the heads-up.17:02
*** Drago1 has joined #openstack-containers17:02
*** Drago has quit IRC17:06
*** Drago1 has quit IRC17:06
jvgrant__strigazi: ping17:07
*** muralia1 has joined #openstack-containers17:08
strigazijvgrant__ 64 bytes from strigazi : icmp_seq=1 ttl=124 time=0.441 ms17:08
*** muralia has quit IRC17:09
jvgrant__:)17:09
jvgrant__strigazi: you worked on the install guide right?17:09
strigaziyes17:09
jvgrant__strigazi: i was helping someone yesterday that came to the channel and he ran into 2 issues. wonderign if you saw these in your testing or had work arounds17:10
jvgrant__1) driver template yaml files missing when using apt-get install17:10
jvgrant__2) using "controller" in the address for keystone registration cause the nodes to be unable to find the endpoints since they couldn't resolve "controller"17:11
strigazi2) is easy, the controller is a convention of the install guide across OS projects17:11
strigazimeans the hostname or ip of the controller node17:12
jvgrant__right, but they resolve it on each node using a modification in the etc files, but the new master/minion nodes don't have that when created17:12
strigazithe IG assumes a controller and a compute node17:12
*** Drago has joined #openstack-containers17:13
jvgrant__so cluster-creates would time out17:13
jvgrant__when they changed the keystone entries to actual IP in keystone instead of controller everything worked17:13
strigaziyes, controller must be replaced with the ip or hostname of the controller node, that is the convention17:14
strigazieg17:14
strigazihttp://docs.openstack.org/newton/install-guide-rdo/glance-install.html#install-and-configure-components17:14
Dragostrigazi: I missed the first part of this conversation. Are you saying that a real cloud should never have "controller" in its endpoints?17:15
strigazicontroller is like an alias17:15
jvgrant__right, which is what all the install guide instructions tell you to do17:16
jvgrant__but it seems like Magnum doesn't work if we do that, as the nodes we create need those alias's as well but they don't have them17:16
strigaziyou must not put controller anywhere17:17
Dragostrigazi: Is that a yes or no?17:17
strigaziyes never17:18
jvgrant__so they should replace the controller with the actual IP addresss17:18
Dragostrigazi: Then the docs should be updated so that's obvious. The thing that further confuses it is that the docs also say to put a "controller" entry into /etc/hosts that will resolve "controller" to a real IP17:18
strigazior hostname17:18
DragoSo inside your cloud, it works17:18
strigaziDrago, in all the IGs cotroller is mentioned17:19
strigaziI'm trying to find where it is explained17:19
jvgrant__i see the mentions of it being used and the instructions on /etc/hosts.17:20
jvgrant__in our guide is shows controller not being replaced with ip as the return of the example keystone entry shows "controller" not the IP17:20
DragoGotta run, I'll be back in about an hour and a half17:20
strigaziin all guides it's the same17:21
*** vijendar_ has joined #openstack-containers17:22
*** vijendar_ has quit IRC17:22
*** Drago has quit IRC17:22
*** vijendar_ has joined #openstack-containers17:22
jvgrant__yeah, ours matches them. And everything works for that entry until... you create a cluster and those nodes try to send to http://controller:9511 which they can't resolve17:23
*** vijendar has quit IRC17:23
jvgrant__those vms17:23
strigaziin all guides the endpoints are registered using controller. In a real deployment controller is like a variable where you have set the appriate ip or hostname17:25
strigaziI'll add a note to avoid confusion17:26
jvgrant__except that since they have instructions to modify the /etc/hosts file in the install guide the using "controller" seems like it works17:26
jvgrant__so i note will probably hep17:26
jvgrant__help17:26
strigaziThe thing is that the guide are officially named "Installation Tutorials", it's expected to modify the commands according to your evironment17:28
strigaziAbout the 1, was it in ubuntu?17:28
strigazior debian?17:29
jvgrant__i understand and it makes sense, but since it caused a user confusing we should probably try to avoid it17:29
*** rcernin has quit IRC17:29
jvgrant__ubuntu17:29
jvgrant__https://bugs.launchpad.net/magnum/+bug/163839317:29
openstackLaunchpad bug 1638393 in Magnum "Launch an instance in Installation Guide for Container Infrastructure Management Service" [Undecided,New]17:29
jvgrant__that is the bug for that one17:29
jvgrant__the cluster.yaml file was missing17:30
strigaziinteresting, I wrote the guide before the final release of packages so I had built the packages myself, this is a bug in the packages.17:31
strigaziI'll check with the packager17:31
jvgrant__yeah, i wasn't sure how to check to see if the file was there in the package17:32
*** chetna has joined #openstack-containers17:33
*** vijenda__ has joined #openstack-containers17:36
*** vijenda__ has quit IRC17:36
*** vijenda__ has joined #openstack-containers17:36
*** vijendar_ has quit IRC17:37
*** muralia1 has quit IRC17:38
openstackgerritSpyros Trigazis proposed openstack/magnum: Convert floating_ip_enabled from boolean to enum  https://review.openstack.org/39509517:40
*** Drago has joined #openstack-containers17:40
*** chhavi has joined #openstack-containers17:42
openstackgerritSpyros Trigazis proposed openstack/magnum: Convert floating_ip_enabled from boolean to enum  https://review.openstack.org/39509517:42
*** jmckind has quit IRC17:43
*** vijenda__ has quit IRC17:45
*** tonanhngo_ has joined #openstack-containers17:46
*** tonanhngo_ has quit IRC17:46
*** tonanhngo_ has joined #openstack-containers17:47
*** tonanhngo has quit IRC17:48
*** vijendar_ has joined #openstack-containers17:49
*** chhavi has quit IRC17:51
*** jmckind has joined #openstack-containers17:56
*** vijendar_ has quit IRC17:58
*** vijendar has joined #openstack-containers17:59
*** jperry has quit IRC18:00
*** pcastets has quit IRC18:01
*** vijendar has quit IRC18:06
*** vijendar has joined #openstack-containers18:06
*** fragatina has joined #openstack-containers18:08
*** vijendar has quit IRC18:09
*** jperry has joined #openstack-containers18:10
*** vijendar_ has joined #openstack-containers18:10
*** jvgrant__ has quit IRC18:13
*** jvgrant__ has joined #openstack-containers18:13
*** adrian_otto has quit IRC18:15
*** vijendar_ has quit IRC18:19
*** vijendar_ has joined #openstack-containers18:22
*** vijendar_ has quit IRC18:37
*** vijendar_ has joined #openstack-containers18:41
*** vijendar_ has quit IRC18:42
*** vijendar has joined #openstack-containers18:43
*** tkarke has joined #openstack-containers18:43
*** fragatina has quit IRC18:46
*** fragatina has joined #openstack-containers18:46
*** david-lyle_ has joined #openstack-containers18:47
*** vijendar has quit IRC18:48
*** vijendar has joined #openstack-containers18:48
DragoHi hongbin18:52
*** vijendar has quit IRC18:52
hongbinDrago: hi18:52
hongbinWant to start?18:52
*** vijendar has joined #openstack-containers18:53
*** adisky has quit IRC18:53
*** david-lyle_ has quit IRC18:53
*** adrian_otto has joined #openstack-containers18:55
Dragohongbin: Okay, now I'm ready18:55
hongbinDrago: you want to start first?18:55
*** adrian_otto has quit IRC18:55
Dragohongbin: I had a question for you, about the current iteration of the spec18:56
hongbingo ahead18:56
Dragohongbin: It is about exposing the state synchronizer class for drivers to implement. From the way it is written, it seems like drivers would not be forced to write a poller. Instead, they would be able to provide a class that could use a push mechanism18:58
hongbinmy understanding is taht it is a *force*18:59
Dragohongbin: My question is, is there something in the current spec would prevent drivers from doing this?19:00
hongbinbecause magnum is calling the interface to sync state, then every drivers need to implement that interface. in that sense, it is a force19:00
*** fragatin_ has joined #openstack-containers19:00
*** rpothier has quit IRC19:00
hongbinDrago: however, my major concern is why the state synchronizer is there in the first iteration19:01
hongbinDrago: i am trying to get the rational of why this class is in the interface19:02
Dragohongbin: Can we talk about that in a minute? I would like to make sure I understand HeatPoller correctly19:02
hongbinDrago: sure19:02
*** fragatina has quit IRC19:03
*** adrian_otto has joined #openstack-containers19:04
Dragohongbin: (Imagine that we are not discussing the spec at all). If we wanted to implement a pull-based cluster state synchronization, could our changes be limited to HeatPoller?19:04
hongbinnot sure exactly, need to check the code19:04
hongbinmaybe not19:05
hongbinDrago: your point is?19:05
Dragohongbin: I think you are right, there is at least a bit more code that would need to change, but most of it is in HeatPoller19:06
DragoSo assume we could get it all into HeatPoller, and magnum could simply ask HeatPoller to sync the cluster state19:07
DragoIf we exposed HeatPoller to drivers, they could actually implement a non-poller19:07
hongbinyou want to combine a poller and a pusher to the same interface?19:08
Dragohongbin: If we could, it would decouple polling from Magnum19:09
hongbinDrago: ok, then the state synchronizer interface need to evolve19:09
hongbinDrago: right now, it looks like a poller19:09
Dragohongbin: I think a little bit of code outside of HeatPoller needs to be worked with so that the *concept* of StateSynchronizer would work19:10
Dragohongbin: But do you see where the idea is going?19:10
hongbin??19:10
Dragohongbin: What are you confused about?19:11
hongbin"do you see where the idea is going?"19:11
hongbinwhat idea?19:12
Dragohongbin: I see. I mean the idea of StateSynchronizer being a generic interface that can be a poller or a pusher, depending on the implementation of the driver19:12
hongbinok19:12
hongbinget that19:12
hongbinyes, if that can be done, it would be great19:12
openstackgerritVijendar Komalla proposed openstack/magnum: Specification for Magnum Admin API  https://review.openstack.org/39153719:12
hongbinmaybe call it statesynchronizer is confusing19:13
hongbinneed a better name19:13
hongbinand it should implements a generic logic to wait for a cluster to become active19:13
Dragohongbin: If it is a generic interface, it is at least better than calling it "HeatPoller" :)19:13
Dragohongbin: Can you help us figure out the minimal changes needed to achieve this?19:14
hongbinDrago: i think we need a better name, even more, i doubt if it worthes to create a dedicated class for it, why not just a method (calling it "wait_for_active" or something)19:14
Dragohongbin: I think the idea is that the logic for "wait for active" is currently in the HeatPoller class, basically19:15
hongbinyes, the logic is here, but moving it to interface is a different thing19:15
Dragohongbin: I am not sure, perhaps going one level up has the method we want? We could instead call the driver here? https://github.com/openstack/magnum/blob/7fc0935a3ee2a7d6d8fb4e2c404b16214a110c1e/magnum/conductor/handlers/cluster_conductor.py#L17119:16
randallburtok, so talked with Adrian and this afternoon, I'm going to add a stubbed out example of how to implement the proposed interface without Heat using pseudocode19:16
Dragohongbin: _poll_and_check is what uses HeatPoller19:17
randallburtand I removed _poll_and_check19:17
*** vijendar_ has joined #openstack-containers19:17
hongbinDrago: yes, how about promote _poll_and_check to the interface instead (renaming it to "wait_for_active" to indicate it can be pushed)19:18
randallburthongbin:  I'm not moving the poll_and_check to the interface.19:18
hongbinDrago: then, hide the entire HeatPoller class19:18
randallburthongbin:  not the logic of it anyway19:19
hongbinHow it works is that19:19
randallburthongbin:  the logic of it will move to the Heat-specific implementation of the synchronizer19:19
hongbinIn cluster_create, it does the logic to create a cluster, then call "wait_for_active"19:19
Dragohongbin: What would the driver use if HeatPoller is hidden? I'm not sure I understand19:19
*** vijendar has quit IRC19:19
hongbinDrago: i mean hiding it from the interface19:19
randallburthongbin:  and wait_for_active will call the synchronizer then check the status of the cluster19:20
hongbinDrago: that means if you are using Heat driver, you call the class19:20
Dragohongbin: But a driver could use it in its logic if it wanted? Okay I see.19:20
hongbinDrago: for other drivers, implement the "wait_for_active" method19:20
*** vijendar_ has quit IRC19:20
hongbinYes, each driver are free to implement the method19:21
randallburthongbin:  so you want the exact same thing I proposed just as a single method on the driver rather than returning a class? How is that "better"?19:21
hongbinuse a state synchronier or others (the point is to hide it from the interface)19:21
randallburthongbin:  there's absolutely zero increase in information hiding.19:21
hongbinit make alternative implementation easier and looks simplier and easier to understand19:22
randallburthongbin:  how does it make it "easier"19:22
randallburthongbin:  unless you're saying implementing a method is substantially "easier" than implementing a class with a single method?19:22
DragoIt seems like using a method would make the interface smaller (fewer touchpoints)19:22
hongbinthis is the middle ground i can think of19:22
hongbinit is up to you to accept it or not19:22
hongbinanother alternative is to implement a method to sync state19:23
hongbinlike "refresh_cluster"19:23
randallburthongbin:  sure, its fine. its just more disruptive (more code moving around/changing than has to). But if you agree its "functionally" equivalent, I'm at a loss as to why there is so much fuss and a -219:23
randallburthongbin:  that's *exactly* what the synchronizer DOES>19:24
hongbinplease understand my -2 is procedural19:24
hongbinit blocks the patch until it gets to a point to consider merging19:25
*** vijendar_ has joined #openstack-containers19:25
randallburthongbin:  its disruptive and obstructionist in this case. but w/e. So if I remove the synchronizer in favor of a method on the driver class that server the *exact same purpose* but increases the implementation burden and effects tons more tests, you'll remove your -2?19:25
randallburts/server/serves19:26
hongbini remove my -2 until the spec has been thoughfully discussed19:26
randallburthongbin:  its been thoughtfully discussed for days.19:26
hongbinmaybe up to the next meeting (if the whole team agree on something)19:26
randallburthongbin:  you're kidding19:26
hongbini am serious19:27
randallburtfine. can you at least tell me if you agree to my previous statement?19:27
randallburthongbin:  ^^19:27
hongbindepending on how to revise the spec19:28
randallburthongbin:  meaning?19:28
hongbinif you upload a new patch, i will do another review and tell you if i personally agree on19:28
randallburthongbin:  fine. can't wait.19:29
Dragorandallburt: Look at this code. I think _poll_and_check is the right place to define the interface. Otherwise, StateSynchronizer would be stuffed into a loopingcall. That work is going to have to be done anyway to enable a non-polling solution https://github.com/openstack/magnum/blob/master/magnum/conductor/handlers/cluster_conductor.py#L175-L17819:29
randallburtDrago:  no, it isn't19:29
randallburtDrago:  but I'm done arguing.19:29
*** vijendar_ has quit IRC19:33
*** vijendar_ has joined #openstack-containers19:36
Dragorandallburt: I want to note that this is _poll_and_check in Handler, not poll_and_check in HeatPoller19:36
Dragohongbin: cluster_conductor.Handler._poll_and_check is blocking, right?19:38
hongbinDrago: AFAIK, no19:39
hongbinDrago: if you want it to be block, add lc.wait(..) after19:39
Dragohongbin: I see19:39
*** vijenda__ has joined #openstack-containers19:49
*** vijendar_ has quit IRC19:53
*** fragatin_ has quit IRC19:58
*** fragatina has joined #openstack-containers19:58
*** fragatina has quit IRC20:02
*** fragatina has joined #openstack-containers20:14
*** vijenda__ has quit IRC20:25
*** vijendar has joined #openstack-containers20:26
*** fragatina has quit IRC20:26
*** fragatina has joined #openstack-containers20:26
tkarkeHi, I have a question about the Creation of cluster without floating ip. As the bug exists in Newton Stable too, will the fix be backported? and if yes, will it be type enum or boolean for stable?20:32
jvgrant__tkarke, i haven't seen the fix submitted to Newton Stable as well so for now, I"m guess no.20:40
jvgrant__tkarke, the fix just went up for review though. i'm not sure what the intentions are20:40
hongbinDrago: for the design summit session about Creds/Certs Management (https://etherpad.openstack.org/p/ocata-magnum-tls), do we reach any conclusion on the approach? (sorry i was not there)20:54
Dragohongbin: In my mind, we really didn't besides committing to the nuclear option. The question of whether we should submit code upstream (to the COEs themselves), but I don't remember there being any consensus20:56
hongbinDrago: ack20:56
hongbinbtw, option #3 is an interesting approach20:56
hongbinit might work for k8s, but hard for other COEs IMO20:57
Dragohongbin: Thanks. I came up with it but didn't think it would be seriously considered20:57
hongbinok20:58
Dragohongbin: That approach will probably require submitting code to COEs as well, so option 2 is easier, I think20:59
*** rcernin has joined #openstack-containers20:59
hongbinDrago: not sure how option #2 is going to work, but happy to review a spec if there is any21:01
Dragohongbin: The COEs would natively support a revocation list. Magnum would have nothing to do with it21:02
hongbinok21:03
Dragohongbin: Well, besides magnum asking the COE to revoke a user21:04
hongbinget that21:04
*** EricGonczer_ has joined #openstack-containers21:05
*** askb has joined #openstack-containers21:11
*** vijendar has quit IRC21:17
*** vijendar has joined #openstack-containers21:18
*** vijendar has quit IRC21:25
*** vijendar has joined #openstack-containers21:27
*** _mbelanger has quit IRC21:40
openstackgerritVijendar Komalla proposed openstack/magnum: Restart swarm infra containers if deleted  https://review.openstack.org/39520921:55
*** vijendar has quit IRC22:00
*** chris_hultin is now known as chris_hultin|AWA22:08
*** tonanhngo_ has quit IRC22:09
*** tonanhngo has joined #openstack-containers22:14
*** tonanhngo has quit IRC22:18
*** catintheroof has quit IRC22:22
*** catintheroof has joined #openstack-containers22:22
*** adrian_otto has quit IRC22:24
*** catintheroof has quit IRC22:27
*** adrian_otto has joined #openstack-containers22:30
*** tonanhngo has joined #openstack-containers22:42
*** tonanhngo has quit IRC22:42
*** adrian_otto has quit IRC22:46
*** tonanhngo has joined #openstack-containers22:46
*** adrian_otto has joined #openstack-containers22:47
*** adrian_otto has quit IRC22:49
*** david-lyle_ has joined #openstack-containers22:50
randallburtgotta run take care of some family stuff. will update spec first thing tomorrow22:54
*** david-lyle_ has quit IRC22:54
*** randallburt has quit IRC22:56
*** jperry has quit IRC22:57
*** chris_hultin|AWA is now known as chris_hultin23:01
*** jasond has quit IRC23:15
*** jmckind has quit IRC23:17
*** rcernin has quit IRC23:18
*** absubram has joined #openstack-containers23:21
*** chris_hultin is now known as chris_hultin|AWA23:25
*** jwcroppe has quit IRC23:27
*** jwcroppe has joined #openstack-containers23:27
*** catintheroof has joined #openstack-containers23:29
*** catintheroof has quit IRC23:31
*** jwcroppe has quit IRC23:31
*** catintheroof has joined #openstack-containers23:31

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!