Wednesday, 2016-11-09

*** hongbin has quit IRC00:10
*** catintheroof has quit IRC00:14
*** catintheroof has joined #openstack-containers00:15
*** EricGonczer_ has quit IRC00:16
*** EricGonczer_ has joined #openstack-containers00:18
*** absubram has quit IRC00:18
*** catintheroof has quit IRC00:19
*** FengShengqin has joined #openstack-containers00:26
*** FengShengqin has quit IRC00:26
*** jwcroppe has joined #openstack-containers00:29
*** jwcroppe has quit IRC00:30
*** jwcroppe has joined #openstack-containers00:30
*** chetna has quit IRC00:36
*** hieulq has quit IRC00:49
*** hieulq has joined #openstack-containers00:52
*** syed_ has quit IRC01:15
*** vijendar has joined #openstack-containers01:36
*** EricGonczer_ has quit IRC01:40
*** chetna has joined #openstack-containers01:56
*** chetna has quit IRC01:57
*** tovin07_ has joined #openstack-containers02:06
*** tovin07 has joined #openstack-containers02:15
*** david-lyle has joined #openstack-containers02:22
*** shu-mutou-AWAY is now known as shu-mutou02:24
*** chetna has joined #openstack-containers02:26
*** chetna has quit IRC02:28
*** Drago has quit IRC02:30
*** EricGonczer_ has joined #openstack-containers02:31
*** tkarke has quit IRC02:38
*** chetna has joined #openstack-containers02:45
*** vijendar has quit IRC02:54
*** EricGonczer_ has quit IRC03:27
*** adrian_otto has joined #openstack-containers03:32
*** EricGonczer_ has joined #openstack-containers03:32
*** EricGonczer_ has quit IRC03:35
*** dave-mccowan has quit IRC03:38
*** hongbin has joined #openstack-containers03:41
*** houming has joined #openstack-containers03:41
*** adrian_otto has quit IRC03:46
*** hongbin has quit IRC03:51
*** adisky has joined #openstack-containers03:52
*** vmud213 has joined #openstack-containers04:10
*** fragatin_ has joined #openstack-containers04:26
*** bks has joined #openstack-containers04:28
*** houming has quit IRC04:29
*** fragatina has quit IRC04:29
*** GB21 has joined #openstack-containers04:30
*** fragatin_ has quit IRC04:31
*** houming has joined #openstack-containers04:33
*** mkrai has joined #openstack-containers04:37
*** adrian_otto has joined #openstack-containers04:44
*** chhavi has joined #openstack-containers04:46
*** GB21 has quit IRC04:49
*** GB21 has joined #openstack-containers05:01
openstackgerrityatin proposed openstack/python-magnumclient: Fix: Creation of cluster without floating ip  https://review.openstack.org/39540005:02
*** fragatina has joined #openstack-containers05:03
*** adrian_otto has quit IRC05:06
*** adrian_otto has joined #openstack-containers05:07
*** fragatina has quit IRC05:08
*** tkarke has joined #openstack-containers05:08
*** adrian_otto has quit IRC05:12
*** adrian_otto has joined #openstack-containers05:15
*** snarwade has joined #openstack-containers05:16
*** houming has quit IRC05:20
*** houming has joined #openstack-containers05:21
*** david-lyle has quit IRC05:22
*** fragatina has joined #openstack-containers05:22
*** david-lyle has joined #openstack-containers05:23
*** fragatina has quit IRC05:27
*** adrian_otto has quit IRC05:29
*** adrian_otto has joined #openstack-containers05:33
*** adrian_otto has quit IRC05:35
*** adrian_otto has joined #openstack-containers05:36
*** fengbeihong has joined #openstack-containers05:41
*** GB21 has quit IRC05:48
*** tkarke has quit IRC06:00
*** GB21 has joined #openstack-containers06:01
*** vimal has joined #openstack-containers06:03
*** vimal has quit IRC06:05
*** vimal has joined #openstack-containers06:05
*** GB21 has quit IRC06:06
*** GB21 has joined #openstack-containers06:06
*** GB21 has quit IRC06:07
*** GB21 has joined #openstack-containers06:07
*** adrian_otto has quit IRC06:11
*** houming has quit IRC06:14
*** manikanta_tadi has quit IRC06:20
*** houming has joined #openstack-containers06:21
*** fengbeihong_ has joined #openstack-containers06:42
*** fengbeihong has quit IRC06:42
*** fengbeihong_ is now known as fengbeihong06:42
*** houming has quit IRC06:47
*** houming has joined #openstack-containers06:48
*** rcernin has joined #openstack-containers06:54
*** zenoway has joined #openstack-containers07:05
*** Jeffrey4l has joined #openstack-containers07:09
*** fengbeihong has quit IRC07:18
*** fengbeihong has joined #openstack-containers07:24
openstackgerritfengbeihong proposed openstack/magnum-ui: [WIP] Add dcos support for magnum-ui  https://review.openstack.org/39543707:34
openstackgerritzhongshengping proposed openstack/magnum: Change cfg.set_defaults into cors.set_defaults  https://review.openstack.org/39543807:35
openstackgerritMerged openstack/magnum-ui: Updated from global requirements  https://review.openstack.org/39532507:40
*** belmoreira has joined #openstack-containers07:45
*** chetna has quit IRC08:02
*** dcwangmit01_ has joined #openstack-containers08:03
*** dcwangmit01 has quit IRC08:05
*** pcastets has joined #openstack-containers08:05
*** tkarke has joined #openstack-containers08:11
*** tkarke has quit IRC08:12
*** houming has quit IRC08:27
*** houming has joined #openstack-containers08:30
*** chetna has joined #openstack-containers08:32
*** chetna has quit IRC08:33
*** fengbeihong has quit IRC08:40
*** tkarke has joined #openstack-containers08:42
*** tkarke has quit IRC08:43
*** chhavi has quit IRC08:46
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-containers08:48
*** chhavi has joined #openstack-containers09:02
*** shu-mutou is now known as shu-mutou-AWAY09:12
*** chetna has joined #openstack-containers09:18
*** chetna has quit IRC09:19
*** dimtruck is now known as zz_dimtruck09:25
openstackgerritSpyros Trigazis proposed openstack/magnum: Make cinder volume optional  https://review.openstack.org/39183009:30
*** chhavi has quit IRC09:39
*** GB21 has quit IRC09:42
yatinstrigazi, ping09:45
strigaziHi yatin09:45
yatinstrigazi: still not working09:46
yatinstrigazi: cinder optional, have you checked creating cluster with docker_volume_size > 009:46
strigaziyatin: yes I did with 509:46
yatinstrigazi: functionality wise or just cluster_complete status09:47
strigaziyatin, logi in the node and cat /etc/sysconfig/heat-params09:47
yatinpvdisplay09:48
strigaziwith which docker_storage_driver?09:48
yatindevicemapper09:48
strigaziI did with overlay09:48
strigaziwill do devicemapper09:48
yatinOk09:49
yatinhave you checked /etc/fstab with overlay09:49
strigazi have you checked /etc/sysconfig/heat-params ? Is the number passed in the node?09:53
yatinafter the revised patch09:53
strigaziNo, I haven't checked /etc/fstab09:54
strigaziyatin: have you checked /etc/sysconfig/heat-params ? Is the number passed in the node?09:54
yatinChecking09:56
yatini deleted the cluster, creating again09:57
strigaziyatin: pvdisplay looks fine09:58
yatinOk, i will confirm09:59
strigaziytain: http://paste.openstack.org/show/588524/10:02
strigaziyatin: http://paste.openstack.org/show/588524/10:02
*** chhavi has joined #openstack-containers10:02
yatinstrigazi: Yes, its created this time10:07
strigaziyatin: cool10:08
*** tovin07_ has quit IRC10:10
*** fengbeihong has joined #openstack-containers10:16
*** chetna has joined #openstack-containers10:18
*** chetna has quit IRC10:19
*** vimal has quit IRC10:21
*** tkarke has joined #openstack-containers10:23
*** hvlad has joined #openstack-containers10:25
*** tkarke has quit IRC10:26
*** vimal has joined #openstack-containers10:28
strigaziyatin, Is there anything else you want to test on this?10:29
strigaziyatin, we can do it in parallel to double check10:29
strigaziyatin, otherwise you can +1 :) and next week +2 :)10:29
yatinstrigazi: currently going through the patch10:30
yatin:)10:30
strigaziyatin, Thanks10:30
*** askb has quit IRC10:31
*** tonanhngo has quit IRC10:31
*** fengbeihong has quit IRC10:35
*** tkarke has joined #openstack-containers10:40
*** fengbeihong has joined #openstack-containers10:41
*** tkarke has quit IRC10:42
*** chetna has joined #openstack-containers10:49
*** chetna has quit IRC10:50
*** fengbeihong has quit IRC10:51
*** snarwade has quit IRC10:55
*** DanyC has joined #openstack-containers11:02
*** jperry has joined #openstack-containers11:21
*** tonanhngo has joined #openstack-containers11:38
*** tonanhngo has quit IRC11:40
*** snarwade has joined #openstack-containers11:41
*** hvlad has quit IRC11:46
*** jvgrant_ has joined #openstack-containers11:50
*** wangbo has joined #openstack-containers11:52
*** jvgrant__ has quit IRC11:53
wangbohello, is there some configure like api-workers to run multiple magnum-api processes? thx11:57
*** chhavi has quit IRC12:09
*** DanyC has left #openstack-containers12:09
*** hvlad has joined #openstack-containers12:10
*** catintheroof has joined #openstack-containers12:16
*** mkrai has quit IRC12:20
*** catinthe_ has joined #openstack-containers12:20
*** catintheroof has quit IRC12:21
*** chhavi has joined #openstack-containers12:24
*** EricGonczer_ has joined #openstack-containers12:34
*** tkarke has joined #openstack-containers12:51
*** tkarke has quit IRC12:54
*** GB21 has joined #openstack-containers12:55
*** EricGonczer_ has quit IRC12:59
*** chhavi has quit IRC13:03
*** tkarke has joined #openstack-containers13:08
*** tkarke has quit IRC13:09
*** vmud213 has quit IRC13:12
*** jwcroppe has quit IRC13:16
yatinwangbo: As far as i know there is no such config, can anyone else confirm. Can you share the use case where you want to add this or you faced some issue.13:17
*** chetna has joined #openstack-containers13:19
*** chhavi has joined #openstack-containers13:20
*** chetna has quit IRC13:21
*** houming has quit IRC13:27
*** bks has quit IRC13:28
wangboyatin, we tried to integrate harbor into magnum. there are some synchronize calls between magnum-conductor and harbor server and these api calls take long time.13:29
wangbothese calls occupied one magnum-conductor fully13:30
wangbosuch as image-upload13:30
*** EricGonczer_ has joined #openstack-containers13:31
wangboso I want to find way to run multiple processes.13:31
*** EricGonczer_ has quit IRC13:32
*** dave-mccowan has joined #openstack-containers13:34
*** tonanhngo has joined #openstack-containers13:35
*** tonanhngo has quit IRC13:36
wangboyatin: another problem is that all magnum-api rpc to magnum-conductor use synchronize calls. so we need multiple magnum-api processes.13:37
*** tonanhngo has joined #openstack-containers13:39
openstackgerritSpyros Trigazis proposed openstack/magnum: Make cinder volume optional  https://review.openstack.org/39183013:47
*** catintheroof has joined #openstack-containers13:47
*** catinthe_ has quit IRC13:50
*** jwcroppe has joined #openstack-containers13:51
openstackgerritSpyros Trigazis proposed openstack/magnum: typo: Fix in docker storage configuration  https://review.openstack.org/39560513:54
openstackgerritSpyros Trigazis proposed openstack/magnum: Make cinder volume optional  https://review.openstack.org/39183013:56
*** _mbelanger has joined #openstack-containers13:58
*** GB21 has quit IRC13:59
*** jperry has quit IRC14:03
yatinwangbo: If this is the case, this can be discussed with the Team14:05
*** jperry has joined #openstack-containers14:10
yatinwangbo: can you share some data and scenario(your use case) via bug/etherpad that specifies long delays so it can be better discussed within Team and solution can be proposed or may be there exist some alternative to this that can be used.14:10
openstackgerritSpyros Trigazis proposed openstack/magnum: Make cinder volume optional  https://review.openstack.org/39183014:21
openstackgerritSpyros Trigazis proposed openstack/magnum: Make cinder volume optional  https://review.openstack.org/39183014:21
openstackgerritSpyros Trigazis proposed openstack/magnum: Convert floating_ip_enabled from boolean to enum  https://review.openstack.org/39509514:26
*** tkarke has joined #openstack-containers14:29
*** tkarke has quit IRC14:30
*** kaliya has joined #openstack-containers14:31
*** jvgrant__ has joined #openstack-containers14:31
*** yuanying_ has joined #openstack-containers14:32
openstackgerritSpyros Trigazis proposed openstack/magnum: Convert floating_ip_enabled from boolean to enum  https://review.openstack.org/39509514:33
*** jvgrant_ has quit IRC14:34
*** jasond has joined #openstack-containers14:34
*** _mbelanger has quit IRC14:38
*** Drago has joined #openstack-containers14:40
*** chhavi has quit IRC14:43
*** Drago has quit IRC14:45
*** Drago has joined #openstack-containers14:49
*** yuanying_ has quit IRC14:51
openstackgerritSpyros Trigazis proposed openstack/magnum: Convert floating_ip_enabled from boolean to enum  https://review.openstack.org/39509514:52
openstackgerritSpyros Trigazis proposed openstack/magnum: Convert floating_ip_enabled from boolean to enum  https://review.openstack.org/39509514:53
*** hongbin has joined #openstack-containers15:01
*** adrian_otto has joined #openstack-containers15:13
*** vimal has quit IRC15:19
*** syed__ has joined #openstack-containers15:24
*** randallburt has joined #openstack-containers15:25
*** randallburt has quit IRC15:30
*** pcastets has quit IRC15:32
*** _mbelanger has joined #openstack-containers15:32
*** chris_hultin|AWA is now known as chris_hultin15:32
*** zz_dimtruck is now known as dimtruck15:33
*** absubram has joined #openstack-containers15:33
*** absubram_ has joined #openstack-containers15:34
openstackgerritSpyros Trigazis proposed openstack/magnum-specs: Initial commit  https://review.openstack.org/39567315:34
*** chetna has joined #openstack-containers15:35
openstackgerritSpyros Trigazis proposed openstack/magnum-specs: Import all implemented specs from magnum repo  https://review.openstack.org/39567415:35
*** chetna has quit IRC15:36
*** randallburt has joined #openstack-containers15:36
*** absubram has quit IRC15:38
*** absubram_ is now known as absubram15:38
*** vimal has joined #openstack-containers15:50
openstackgerritSpyros Trigazis proposed openstack/magnum: Make cinder volume optional  https://review.openstack.org/39183015:50
*** tonanhngo_ has joined #openstack-containers15:51
*** tonanhngo has quit IRC15:51
*** hvlad has quit IRC15:54
*** pcastets has joined #openstack-containers15:55
*** tonanhngo_ has quit IRC15:55
*** vimal has quit IRC15:57
*** jerrygb has joined #openstack-containers15:57
*** vimal has joined #openstack-containers16:01
*** vimal has quit IRC16:04
openstackgerritRandall Burt proposed openstack/magnum: Add cluster driver encapsulation spec  https://review.openstack.org/38983516:04
*** vijendar_ has joined #openstack-containers16:06
*** belmoreira has quit IRC16:11
*** jasond has quit IRC16:13
*** adrian_otto has quit IRC16:13
*** jasond has joined #openstack-containers16:13
*** rcernin has quit IRC16:13
*** absubram has quit IRC16:17
*** chhavi has joined #openstack-containers16:18
*** ramishra has quit IRC16:18
*** ramishra has joined #openstack-containers16:19
*** chetna has joined #openstack-containers16:29
*** vmud213 has joined #openstack-containers16:32
*** EricGonczer_ has joined #openstack-containers16:34
*** adrian_otto has joined #openstack-containers16:36
openstackgerritSpyros Trigazis proposed openstack/magnum: Convert floating_ip_enabled from boolean to enum  https://review.openstack.org/39509516:38
*** strigazi is now known as strigazi_AFK16:39
*** EricGonczer_ has quit IRC16:39
*** EricGonczer_ has joined #openstack-containers16:40
Dragohongbin: ping16:40
*** fragatina has joined #openstack-containers16:42
hongbinDrago: sup16:43
Dragohongbin: Is it only from the name and docstring that sync_state sounds like polling?16:44
hongbinDrago: yes16:44
Dragohongbin: So if it was only named/described differently (without changing the interface!), you would be in favor of it?16:45
hongbinDrago: well, i am in favor of #116:46
hongbinDrago: but if there is a better name & doc-string, i am open to consider that.16:46
Dragohongbin: I am just talking about the naming of that one method. We can talk about the other comment after16:46
hongbinDrago: do you have a better name?16:47
Dragohongbin: Well, I personally don't think that "synchronize" has anything to do with push or poll16:48
DragoSynchronize via push, or synchronize via poll are both valid16:48
hongbini don't think it is intuitive to synchronize via push16:49
hongbinsynchronize and push sounds opposite16:49
DragoNot to me16:49
hongbinThen, we are in a tie16:49
Dragohongbin: You can search on the internet and see many other services that synchronize via push16:51
hongbinlink?16:52
hongbinDrago: you don't like the "wait_for_*" approach?16:53
Dragohongbin: The wait_for_* is something we should probably look into once we do our initial refactoring, but it is a much bigger change  to do in the first iteration16:55
hongbinDrago: this is a spec, but an implementation. that means you can change the implenetation step-by-step, but the spec should be a final version16:56
hongbinor what we expect to be the final so far16:56
hongbinin addition, i don't think the change will be huge16:56
hongbinit possibly can be done with a few tweaks.16:57
Dragohongbin: Additionally, it should probably be called "wait_for" and you specify what state you want. Right now, HeatPoller just looks for a stable state and then quits16:57
hongbinthen, how about naming it to "wait_for_[stable_state]"16:57
*** vmud213 has quit IRC16:58
hongbini like that because this is the common logic in nova/heat/....16:58
hongbinit looks quite easy to implement and being understand16:58
DragoWell, that's fine with me, because then we're back to using one method to synchronize state16:58
Dragohongbin: How about this: keep calling it sync_state, and in the docstring specify that it should synchronize the state until it becomes stable, whether that's polling or pushing16:59
hongbini don't want to limit ourselves to what we have right now16:59
hongbinDrago: the name of the method is very important17:00
hongbinif the name is wrong, it causes a lot of confusion in the implementation.17:00
Dragohongbin: I argue that it does not matter what state you're waiting for, because you can always tell when you reach a stable state, and whether that state is the state you wanted is not the method's concern17:00
Dragohongbin: I think that wait_for sounds like it is assuming push17:01
hongbinthen, come up with a better name that doesn't sound like pushing or polling17:02
Dragohongbin: Many email clients rely on push to synchronize mail https://en.wikipedia.org/wiki/Push_email17:02
hongbinDrago: but in nova, the implement "wait_for" by using polling.....17:02
*** yuanying_ has joined #openstack-containers17:03
hongbinDrago: but if they implement the interface in this way?17:03
Dragohongbin: So a developer that is familiar with nova would see wait_for and think they should implement polling?17:03
randallburtlol17:03
hongbinDrago: yes17:03
*** zenoway has quit IRC17:04
Dragohongbin: So wait_for is also a bad name. Can you come up with a better name? :)17:04
*** zenoway has joined #openstack-containers17:04
hongbinDrago: i already wrote down what I can think of in the spec17:04
hongbinDrago: if you have a better suggestion, please propose it.17:04
Dragohongbin: Thesaurus to the rescue17:05
Dragoharmonize_state17:05
Dragocoordinate_state17:05
Dragounify_state17:05
Dragoreconcile_state17:05
*** tonanhngo has joined #openstack-containers17:05
hongbinDrago: just let other team members to comment17:05
Dragocorrelate_state17:05
hongbini am going to leave the spec for a while for further inputs17:06
hongbinwill leave for lunch for a while17:06
Dragohongbin: Okay, talk to you later17:06
*** yuanying_ has quit IRC17:07
Dragohongbin: Push sync in AWS http://docs.aws.amazon.com/cognito/latest/developerguide/push-sync.html17:07
*** zenoway has quit IRC17:08
*** tonanhngo has quit IRC17:09
*** tonanhngo has joined #openstack-containers17:10
Dragohongbin: How to synchronize data between front and backend? Top answer: push. http://stackoverflow.com/questions/1945305/synchronize-data-between-frontend-and-backend17:13
*** vijendar has joined #openstack-containers17:14
*** chetna has quit IRC17:17
*** chetna has joined #openstack-containers17:17
Dragohongbin: http://blog.cloud-elements.com/webhooks-vs.-polling-sync-your-apps17:20
Dragohongbin: "Synchronize" is not strongly correlated with push or poll, from what I can find. I think it is a fitting word. Any lingering confusion can be resolved by having a clear docstring.17:22
*** EricGonczer_ has quit IRC17:47
hongbinDrago: it is hard to see what their interfaces looks like17:47
hongbinDrago: it seems AWS is putting "onEven" into their interface17:48
hongbinDrago: then, another alternative is naming that method as "on_cluster_active"17:49
hongbinDrago: but i guess this is not what you like?17:50
Dragohongbin: We are not talking about interfaces though, only whether "synchronize" implies "poll"17:51
hongbinDrago: then, i will make a similar arguement about "wait_for" implies "push"17:52
*** chhavi has quit IRC17:52
hongbinDrago: so it won't lead to a conclusion to keeping arguing that17:52
hongbinDrago: as i said, just wait for others to chime in and comments on what they like.17:53
*** jperry has quit IRC17:57
*** jperry has joined #openstack-containers17:58
Dragohongbin: What is the purpose of splitting the methods up in #1?17:59
*** tkarke has joined #openstack-containers18:00
hongbinDrago: there are several advantages18:02
hongbin1. the interface looks more straight forward, because the meaning of each method is well-defined by its name.18:03
*** fragatin_ has joined #openstack-containers18:04
hongbin2. It allows the flexibility to wait for different things by using different logic18:04
*** fragatina has quit IRC18:07
Dragohongbin: I think that makes sense18:14
Dragohongbin: Let me ask you something slightly different18:14
Dragohongbin: If the spec was accepted exactly as it is right now, would there be anything preventing another spec being proposed with #1 and accepted and implemented as well?18:16
hongbinDrago: not sure, it might or might not18:17
randallburtDrago:  no18:18
Dragohongbin: My point is, if the current spec is a step in the right direction, there's nothing stopping us from further improving the interface.18:18
hongbinDrago: i disagree. the current spec is not totally on the right direction18:18
Dragohongbin: Please explain18:19
randallburthongbin:  even when I made the changes you explicitly requested?18:19
hongbinDrago: as i said, the name of method is confusing18:19
randallburthongbin:  please tell me what name you'd approve of and I'll change it.18:19
Dragohongbin: Okay, point taken, I am more concerned with the 3 proposals you outlined18:20
hongbinrandallburt: i listed 3 proposals i can think of in the spec18:20
hongbinrandallburt: please wait for the feedback from community to evualate which proposal is the best, it might be your proposal18:21
randallburthongbin:  so you want me to totally re-write my spec based on one or all of your suggestions?18:21
Dragohongbin: Ignoring concerns about naming, are there other things in the spec that are not a step in the right direction?18:21
randallburthongbin:  with due respect, if you want to propose a competing spec, please do and cross link as alternatives18:21
Dragohongbin, randallburt: I am trying to see if there's anything in the current spec that would prevent later specs from refining the interface18:22
hongbinDrago: maybe not just the name, but the entire method: def sync_state(self, cluster)18:23
hongbinDrago: besides that method, it looks good.18:23
Dragohongbin: Okay, that is more substantive (in my opinion). What about the method would prevent further refinement in the future?18:23
hongbinDrago: not sure exactly18:25
hongbinDrago: what do you get by rushing that method into the interface?18:25
Dragohongbin: If you can think on that, and let me know, I would appreciate it.18:25
Dragohongbin: The overall goal of the spec is to refactor drivers enough to decouple Magnum from Heat. It's intent is not to come up with a final version of the driver interface18:26
Drago*Its18:26
*** tkarke has quit IRC18:26
hongbinok, then you can write the spec in a different way and taking out the driver interface entirely18:27
Dragohongbin: Why should the driver interface be taken out of the spec?18:27
hongbinDrago: because you claimed what you wanted is a refactoring, then it has nothing to do with defining a driver interface18:28
Dragohongbin: How would you decouple from Heat without changing the driver interface?18:28
hongbinDrago: you can change the interface in a implementation, but it has nothing to do by defining a interface in a spec18:29
Dragohongbin: I think we would be having the same conversation during the implementation though18:31
Dragohongbin: About the changes to the interface18:31
hongbinDrago: that depends on specific implementation18:32
randallburtsorry, had to take the dog out18:32
*** tkarke has joined #openstack-containers18:33
randallburthongbin:  what we get by taking our best stab at it is progress.18:33
randallburthongbin:  the refactoring involves moving code around in Magnum and into the current driver interface18:33
hongbinrandallburt: removing the method from the interface :)18:34
hongbinrandallburt: you can add the method later if you want18:34
randallburthongbin:  and we save discussion on patches if we can agree on a general approach rather than going round and round forever and surprising you later18:34
randallburthongbin:  done18:35
hongbinoption 1: avoid defining a driver interface in the spec18:35
openstackgerritRandall Burt proposed openstack/magnum: Add cluster driver encapsulation spec  https://review.openstack.org/38983518:35
hongbinoption 2: removing the "sync_state" method from the spec, and adding it in a separated spec18:36
randallburthongbin:  option 1 just leads to us having this discussion all over again when patches start being submitted18:36
Dragohongbin: So when you see this method introduced in a patch, because *something* is necessary to decouple from Heat, you will be… okay with it??18:36
hongbinoption 3: wait for the the community input to define the best driver interface.18:36
randallburtDrago:  whatever it takes to move forward, man. rather argue later about one method than stop any work18:36
hongbinDrago: again, depending on what the patch looks like18:38
hongbinDrago: it is hard to comment on a patch that is not there18:38
Dragohongbin: I agree with you on that :)18:38
randallburthongbin:  out of curiosity, who else are we waiting on to provide input? I can add them to the review and hopefully get that going18:38
randallburthongbin:  or you can of course if there are specific people you're wanting to hear form18:38
randallburts/form/from18:39
hongbinrandallburt: if you want, ping all the core reviewers18:39
randallburthongbin:  what's the group name for that18:39
hongbinrandallburt: and sent a ML to ask18:39
randallburt?18:39
hongbin??18:39
hongbinfrankly, i don't know why you guys are rushing this spec18:40
randallburthongbin:  what's the name for the magnum core reviewers? In heat, for example, its heat-core. If I add that as a reviewer, all the cores get added18:40
randallburthongbin:  because its a priority for us18:40
hongbinmagnum-core18:40
randallburthongbin:  thanks!18:40
*** adisky has quit IRC18:43
Dragohongbin: We are trying to propose a spec that keeps disruption to a minimum. Part of that is limiting its scope. None of us think this will declare a "final" interface of the drivers. Instead, it will be one of many incremental improvements, and we expect future specs to build on top of this work.18:46
Dragohongbin: I think that splitting the methods as you propose could be one of those improvements18:47
*** pcastets has quit IRC18:47
*** fragatin_ has quit IRC18:47
hongbinDrago: ok, i see the sync_state method was removed, then it looks good to me.18:47
DragoThank you, hongbin18:48
*** fragatina has joined #openstack-containers18:48
*** harlowja has quit IRC18:59
*** rcernin has joined #openstack-containers19:00
*** dcwangmit01 has joined #openstack-containers19:08
vijendaradrian_otto:  when you get a chance, please take a look at https://review.openstack.org/#/c/395209/19:08
*** catinthe_ has joined #openstack-containers19:10
*** dcwangmit01_ has quit IRC19:10
*** catintheroof has quit IRC19:12
openstackgerritSpyros Trigazis proposed openstack/magnum: Make cinder volume optional  https://review.openstack.org/39183019:16
*** dave-mccowan has quit IRC19:25
*** dave-mccowan has joined #openstack-containers19:26
*** adrian_otto has quit IRC19:31
*** dave-mccowan has quit IRC19:36
*** rcernin has quit IRC19:55
*** EricGonczer_ has joined #openstack-containers19:58
*** yuanying_ has joined #openstack-containers20:03
*** yuanying_ has quit IRC20:08
*** swatson_ has joined #openstack-containers20:12
*** chetna has quit IRC20:21
*** chetna has joined #openstack-containers20:23
*** chetna has quit IRC20:33
*** dave-mccowan has joined #openstack-containers20:38
*** vijendar has quit IRC20:50
*** vijendar_ has quit IRC20:50
*** vijendar_ has joined #openstack-containers20:53
*** vijendar has joined #openstack-containers20:53
openstackgerritPaul Czarkowski proposed openstack/magnum: remove extra bracket from script in docs.  https://review.openstack.org/39331320:56
*** slagle has quit IRC20:57
*** adrian_otto has joined #openstack-containers20:58
*** askb has joined #openstack-containers21:03
*** EricGonczer_ has quit IRC21:03
openstackgerritSpyros Trigazis proposed openstack/magnum: [WIP] Convert floating_ip_enabled from boolean to enum  https://review.openstack.org/39509521:12
*** vijendar_ has quit IRC21:14
*** vijendar has quit IRC21:14
*** randallburt has quit IRC21:24
*** slagle has joined #openstack-containers21:31
*** _mbelanger has quit IRC21:31
*** Jeffrey4l has quit IRC21:34
*** chetna has joined #openstack-containers21:39
*** harlowja has joined #openstack-containers21:49
*** kaliya has quit IRC21:54
*** kaliya has joined #openstack-containers21:55
*** jwcroppe has quit IRC21:57
*** jwcroppe has joined #openstack-containers21:58
*** jwcroppe has quit IRC22:03
*** yuanying_ has joined #openstack-containers22:46
*** yuanying_ has quit IRC22:50
*** jperry has quit IRC22:56
*** chetna has quit IRC22:56
*** tonanhngo has quit IRC22:57
*** kaliya has quit IRC22:57
*** adrian_otto has quit IRC22:57
*** chetnakh has joined #openstack-containers22:57
*** jasond has quit IRC23:02
*** catinthe_ has quit IRC23:04
*** harlowja_ has joined #openstack-containers23:08
*** harlowja has quit IRC23:12
*** jerrygb has quit IRC23:16
*** vijendar has joined #openstack-containers23:17
*** tonanhngo has joined #openstack-containers23:17
*** tonanhngo has quit IRC23:22
*** jerrygb has joined #openstack-containers23:23
*** jwcroppe has joined #openstack-containers23:24
*** jwcroppe has quit IRC23:25
*** jwcroppe has joined #openstack-containers23:25
*** jwcroppe has quit IRC23:30
*** Jeffrey4l has joined #openstack-containers23:31
*** Jeffrey4l has quit IRC23:32
*** Jeffrey4l has joined #openstack-containers23:32
*** Jeffrey4l has quit IRC23:33
*** Jeffrey4l has joined #openstack-containers23:34
*** chetnakh has quit IRC23:34
*** vijendar has quit IRC23:37
*** vijendar has joined #openstack-containers23:37
*** vijendar_ has joined #openstack-containers23:38
*** tonanhngo has joined #openstack-containers23:41
*** tonanhngo has quit IRC23:50
*** tonanhngo has joined #openstack-containers23:55
*** dfflanders has joined #openstack-containers23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!